[Qemu-devel] buildbot failure in qemu on block_i386_debian_6_0

2012-03-16 Thread qemu
The Buildbot has detected a new failure on builder block_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_i386_debian_6_0/builds/215 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Re

Re: [Qemu-devel] [PATCH 1/2] Isolation groups

2012-03-16 Thread David Gibson
On Fri, Mar 16, 2012 at 01:31:18PM -0600, Alex Williamson wrote: > On Fri, 2012-03-16 at 14:45 +1100, David Gibson wrote: > > On Thu, Mar 15, 2012 at 02:15:01PM -0600, Alex Williamson wrote: > > > On Wed, 2012-03-14 at 20:58 +1100, David Gibson wrote: > > > > On Tue, Mar 13, 2012 at 10:49:47AM -060

[Qemu-devel] [PATCH] QEMU: Add pflash support for versatile and integrator

2012-03-16 Thread Marek Vasut
Signed-off-by: Marek Vasut --- hw/integratorcp.c | 26 ++ hw/versatilepb.c | 24 2 files changed, 50 insertions(+), 0 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp.c index 5b06c81..2703ea6 100644 --- a/hw/integratorcp.c +++ b/

Re: [Qemu-devel] QEMU was not selected for Google Summer of Code this year

2012-03-16 Thread Natalia Portillo
QEMU hosted on Haiku would be interesting. On 16/03/2012, at 22:30, Stefan Hajnoczi wrote: > On Fri, Mar 16, 2012 at 7:44 PM, Natalia Portillo wrote: >> Really sad news :( >> >> On 16/03/2012, at 19:29, Stefan Hajnoczi wrote: >> >>> Sad news - QEMU was not accepted for Google Summer of Code 20

[Qemu-devel] [PATCH] w64: Fix data type of next_tb and tcg_qemu_tb_exec

2012-03-16 Thread Stefan Weil
next_tb is the numeric value of a tcg target (= QEMU host) address. Using tcg_target_ulong instead of unsigned long shows this and makes the code portable for hosts with an unusual size of long (w64). The type cast '(long)(next_tb & ~3)' was not needed (casting unsigned long to long does not chan

Re: [Qemu-devel] [PATCHv5 03/11] rewrite iov_* functions

2012-03-16 Thread Michael Tokarev
On 17.03.2012 02:29, Paolo Bonzini wrote: > Il 16/03/2012 23:17, Michael Tokarev ha scritto: >> test-iov.c | 158 >> Makefile changes missing. >> *sigh* Which changes? >> >> I'm sorry but i ran past any sane time limit

Re: [Qemu-devel] QEMU was not selected for Google Summer of Code this year

2012-03-16 Thread Stefan Hajnoczi
On Fri, Mar 16, 2012 at 10:11 PM, François Revol wrote: > On -10/01/-28163 20:59, Stefan Hajnoczi wrote: >> Sad news - QEMU was not accepted for Google Summer of Code 2012. >> > > Shame, there is so much to do. > >> Students can consider other organizations in the accepted >> organizations list he

Re: [Qemu-devel] QEMU was not selected for Google Summer of Code this year

2012-03-16 Thread Stefan Hajnoczi
On Fri, Mar 16, 2012 at 7:44 PM, Natalia Portillo wrote: > Really sad news :( > > On 16/03/2012, at 19:29, Stefan Hajnoczi wrote: > >> Sad news - QEMU was not accepted for Google Summer of Code 2012. >> >> Students can consider other organizations in the accepted >> organizations list here: >> >>

Re: [Qemu-devel] [PATCHv5 03/11] rewrite iov_* functions

2012-03-16 Thread Paolo Bonzini
Il 16/03/2012 23:17, Michael Tokarev ha scritto: >>> >> test-iov.c | 158 >>> >> >> > >> > Makefile changes missing. > *sigh* Which changes? > > I'm sorry but i ran past any sane time limits for this long ago. > > Come on, which ANOT

Re: [Qemu-devel] [PATCHv5 03/11] rewrite iov_* functions

2012-03-16 Thread Michael Tokarev
On 17.03.2012 02:12, Paolo Bonzini wrote: [] >> While at it, add a unit-test file test-iov.c, >> to check various corner cases with iov_from_buf() >> and iov_to_buf() (all 3 functions uses exactly >> the same logic so iov_memset() should be covered >> too). >> >> Signed-off-by: Michael Tokarev >>

[Qemu-devel] [Bug 932539] Re: qemu exits with -11 when connecting to a port redirect before the service starts listening

2012-03-16 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu-kvm - 1.0+noroms-0ubuntu8 --- qemu-kvm (1.0+noroms-0ubuntu8) precise; urgency=low * debian/patches/slirp-*: fix bad exit with -11 when connecting to a port redirect before the service starts listening. (LP: #932539) -- Serge HallynFri

[Qemu-devel] [Bug 932539] Re: qemu exits with -11 when connecting to a port redirect before the service starts listening

2012-03-16 Thread Serge Hallyn
This appears to be fixed upstream. ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/932539 Title: qemu exits with -11 when connecting to a

[Qemu-devel] [Bug 932539] Re: qemu exits with -11 when connecting to a port redirect before the service starts listening

2012-03-16 Thread Serge Hallyn
(cherrypicked the slirp/if.c patches from upstream, which fixed the problem for me. Pushing the resulting package) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/932539 Title: qemu exits with -11 w

Re: [Qemu-devel] [PATCHv5 03/11] rewrite iov_* functions

2012-03-16 Thread Paolo Bonzini
Il 16/03/2012 22:34, Michael Tokarev ha scritto: > This changes implementations of all iov_* > functions, completing the previous step. > > All iov_* functions now ensure that this offset > argument is within the iovec (using assertion), > but lets to specify `bytes' value larger than > actual len

Re: [Qemu-devel] QEMU was not selected for Google Summer of Code this year

2012-03-16 Thread François Revol
On -10/01/-28163 20:59, Stefan Hajnoczi wrote: > Sad news - QEMU was not accepted for Google Summer of Code 2012. > Shame, there is so much to do. > Students can consider other organizations in the accepted > organizations list here: > > http://www.google-melange.com/gsoc/accepted_orgs/google/g

[Qemu-devel] [PATCHv5 00/11] cleanup/consolidate iovec functions

2012-03-16 Thread Michael Tokarev
This is cleanup/consolidation of iovec-related low-level routines in qemu. The plan is to make library functions more understandable, consistent and useful, and to drop numerous implementations of the same thing. The patch changes prototypes of several iov and qiov functions to match each other,

[Qemu-devel] [PATCHv5 08/11] rename qemu_sendv to iov_send, change proto and move declarations to iov.h

2012-03-16 Thread Michael Tokarev
Rename arguments and use size_t for sizes instead of int, from int qemu_sendv(int sockfd, struct iovec *iov, int len, int iov_offset) to ssize_t iov_send(int sockfd, struct iovec *iov, size_t offset, size_t bytes) The main motivation was to make it clear that length and o

[Qemu-devel] [PATCHv5 11/11] rewrite iov_send_recv() and move it to iov.c

2012-03-16 Thread Michael Tokarev
Make it much more understandable, add a missing iov_cnt argument (number of iovs in the iov), and add comments to it. The new implementation has been extensively tested by splitting a large buffer into many small randomly-sized chunks, sending it over socket to another, slow process and verifying

[Qemu-devel] [PATCHv5 10/11] cleanup qemu_co_sendv(), qemu_co_recvv() and friends

2012-03-16 Thread Michael Tokarev
The same as for non-coroutine versions in previous patches: rename arguments to be more obvious, change type of arguments from int to size_t where appropriate, and use common code for send and receive paths (with one extra argument) since these are exactly the same. Use common iov_send_recv() direc

[Qemu-devel] [PATCHv5 02/11] change iov_* function prototypes to be more appropriate

2012-03-16 Thread Michael Tokarev
Reorder arguments to be more natural, readable and consistent with other iov_* functions, and change argument names, from: iov_from_buf(iov, iov_cnt, buf, iov_off, size) to iov_from_buf(iov, iov_cnt, offset, buf, bytes) The result becomes natural English: copy data to this `iov' vector with `i

[Qemu-devel] [PATCHv5 01/11] virtio-serial-bus: use correct lengths in control_out() message

2012-03-16 Thread Michael Tokarev
Original code has one thing to process (cur_len), requests to convert from iovec to buf another thing (len which is actually max_len), and processes something else (copied). Whole thing is very difficult to understand, even if it does a right thing. The iov_to_buf() conversion in this case will a

[Qemu-devel] [PATCHv5 06/11] consolidate qemu_iovec_copy() and qemu_iovec_concat() and make them consistent

2012-03-16 Thread Michael Tokarev
qemu_iovec_concat() is currently a wrapper for qemu_iovec_copy(), use the former (with extra "0" arg) in a few places where it is used. Change skip argument of qemu_iovec_copy() from uint64_t to size_t, since size of qiov itself is size_t, so there's no way to skip larger sizes. Rename it to soff

[Qemu-devel] [PATCHv5 07/11] change qemu_iovec_to_buf() to match other to, from_buf functions

2012-03-16 Thread Michael Tokarev
It now allows specifying offset within qiov to start from and amount of bytes to copy. Actual implementation is just a call to iov_to_buf(). Signed-off-by: Michael Tokarev --- block.c |2 +- block/iscsi.c |2 +- block/qcow.c |2 +- block/qcow2.c |2 +- block/rbd.c |

[Qemu-devel] [PATCHv5 03/11] rewrite iov_* functions

2012-03-16 Thread Michael Tokarev
This changes implementations of all iov_* functions, completing the previous step. All iov_* functions now ensure that this offset argument is within the iovec (using assertion), but lets to specify `bytes' value larger than actual length of the iovec - in this case they stops at the actual end of

[Qemu-devel] [PATCHv5 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset()

2012-03-16 Thread Michael Tokarev
This patch combines two functions into one, and replaces the implementation with already existing iov_memset() from iov.c. The new prototype of qemu_iovec_memset(): size_t qemu_iovec_memset(qiov, size_t offset, int fillc, size_t bytes) It is different from former qemu_iovec_memset_skip(), and I

[Qemu-devel] [PATCHv5 09/11] export iov_send_recv() and use it in iov_send() and iov_recv()

2012-03-16 Thread Michael Tokarev
Rename do_sendv_recvv() to iov_send_recv(), change its last arg (do_send) from int to bool, export it in iov.h, and made the two callers of it (iov_send() and iov_recv()) to be trivial #defines just adding 5th arg. iov_send_recv() will be used later. Signed-off-by: Michael Tokarev --- cutils.c

[Qemu-devel] [PATCHv5 05/11] allow qemu_iovec_from_buffer() to specify offset from which to start copying

2012-03-16 Thread Michael Tokarev
Similar to qemu_iovec_memset(QEMUIOVector *qiov, size_t offset, int c, size_t bytes); the new prototype is: qemu_iovec_from_buf(QEMUIOVector *qiov, size_t offset, const void *buf, size_t bytes); The processing starts at offset bytes within qiov. This way,

[Qemu-devel] [PATCH] qmp_output_visitor_cleanup(): fix double free

2012-03-16 Thread Laszlo Ersek
Stack entries in QmpOutputVisitor are navigation links (weak references), except the bottom (ie. least recently added) entry, which owns the root QObject [1]. Make qmp_output_visitor_cleanup() drop the stack entries, then release the QObject tree by the root. Attempting to serialize an invalid enu

Re: [Qemu-devel] [PATCH v7 2/6] Introduce "save-devices-state"

2012-03-16 Thread Luiz Capitulino
On Fri, 16 Mar 2012 09:49:55 -0600 Eric Blake wrote: > On 03/16/2012 06:13 AM, Stefano Stabellini wrote: > > - add an "is_ram" flag to SaveStateEntry; > > > > - register_savevm_live sets is_ram for live_savevm devices; > > > > - introduce a "save-devices-state" QAPI command that can be used to

[Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors

2012-03-16 Thread Luiz Capitulino
The Monitor object is passed back and forth within the migration/savevm code so that it can print errors and progress to the user. However, that approach assumes a HMP monitor, being completely invalid in QMP. This commit drops almost every single usage of the Monitor object, all monitor_printf()

[Qemu-devel] [PATCH 1/4] QError: Introduce new errors for the migration command

2012-03-16 Thread Luiz Capitulino
The new errors are QERR_MIGRATION_ACTIVE and QERR_MIGRATION_NOT_SUPPORTED, which are going to be used by the QAPI converted migration command. Signed-off-by: Luiz Capitulino --- qerror.c |8 qerror.h |6 ++ 2 files changed, 14 insertions(+) diff --git a/qerror.c b/qerror.c

[Qemu-devel] [PULL 0/4]: QMP queue

2012-03-16 Thread Luiz Capitulino
Contains only the migrate command conversion to the QAPI series. I hoped I'd finish the device_add/del conversion yesterday, but I didn't. Let's merge this before it breaks... The changes (since ae7d54d489540b49b7c13a7df7ddc220588a2ced) are available in the following repository: git://repo.or

Re: [Qemu-devel] QEMU was not selected for Google Summer of Code this year

2012-03-16 Thread Natalia Portillo
Really sad news :( On 16/03/2012, at 19:29, Stefan Hajnoczi wrote: > Sad news - QEMU was not accepted for Google Summer of Code 2012. > > Students can consider other organizations in the accepted > organizations list here: > > http://www.google-melange.com/gsoc/accepted_orgs/google/gsoc2012 >

[Qemu-devel] [PATCH 2/4] Error: Introduce error_copy()

2012-03-16 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- error.c | 13 + error.h |5 + 2 files changed, 18 insertions(+) diff --git a/error.c b/error.c index 990050f..d3455ab 100644 --- a/error.c +++ b/error.c @@ -43,6 +43,19 @@ void error_set(Error **errp, const char *fmt, ...) *errp = err

Re: [Qemu-devel] [PATCHv4 10/11] cleanup qemu_co_sendv(), qemu_co_recvv() and friends

2012-03-16 Thread Michael Tokarev
On 16.03.2012 20:22, Anthony Liguori wrote: > On 03/15/2012 04:00 PM, Michael Tokarev wrote: >> The same as for non-coroutine versions in previous >> patches: rename arguments to be more obvious, change >> type of arguments from int to size_t where appropriate, >> and use common code for send and r

[Qemu-devel] [PATCH 4/4] qapi: Convert migrate

2012-03-16 Thread Luiz Capitulino
The migrate command is one of those commands where HMP and QMP completely mix up together. This made the conversion to the QAPI (which separates the command into QMP and HMP parts) a bit difficult. The first important change to be noticed is that this commit completes the removal of the Monitor ob

Re: [Qemu-devel] [PATCHv4 05/11] allow qemu_iovec_from_buffer() to specify offset from which to start copying

2012-03-16 Thread Michael Tokarev
On 16.03.2012 20:19, Anthony Liguori wrote: > On 03/15/2012 04:00 PM, Michael Tokarev wrote: >> Similar to >> qemu_iovec_memset(QEMUIOVector *qiov, size_t offset, >> int c, size_t bytes); >> the new prototype is: >> qemu_iovec_from_buf(QEMUIOVector *qiov, size_t offset, >>

Re: [Qemu-devel] [PATCH 1/2] Isolation groups

2012-03-16 Thread Alex Williamson
On Fri, 2012-03-16 at 14:45 +1100, David Gibson wrote: > On Thu, Mar 15, 2012 at 02:15:01PM -0600, Alex Williamson wrote: > > On Wed, 2012-03-14 at 20:58 +1100, David Gibson wrote: > > > On Tue, Mar 13, 2012 at 10:49:47AM -0600, Alex Williamson wrote: > > > > On Wed, 2012-03-14 at 01:33 +1100, Davi

Re: [Qemu-devel] [PATCHv4 03/11] rewrite iov_* functions

2012-03-16 Thread Michael Tokarev
On 16.03.2012 20:17, Anthony Liguori wrote: > It makes me nervous to make a change like this as it has wide impact on the > rest of the code base. Could you include a unit test that tests the various > boundary conditions of this code? Is the below code a good unit test? Thanks, /mjt --

[Qemu-devel] QEMU was not selected for Google Summer of Code this year

2012-03-16 Thread Stefan Hajnoczi
Sad news - QEMU was not accepted for Google Summer of Code 2012. Students can consider other organizations in the accepted organizations list here: http://www.google-melange.com/gsoc/accepted_orgs/google/gsoc2012 The list is currently not complete but should be finalized over the next few days a

Re: [Qemu-devel] qemu gdb issue

2012-03-16 Thread Peter Maydell
On 16 March 2012 19:10, Mulyadi Santosa wrote: > On Fri, Mar 16, 2012 at 14:13, Jacques wrote: >> I see what you mean. How do I know if this is happening? When I do 'x/i >> $eip' I get a completely sane result with exactly the instructions I want. > > Alright, that confuses me too. > > The best o

Re: [Qemu-devel] [PATCH v2] qapi: escaping dots in c_var and in de_camel_case

2012-03-16 Thread Luiz Capitulino
On Thu, 15 Mar 2012 15:45:59 + Federico Simoncelli wrote: > This allows qapi commands and types with dots (downstream QMP extensions > containing fully qualified domain names). > > Signed-off-by: Federico Simoncelli > --- > scripts/qapi.py |4 ++-- > 1 files changed, 2 insertions(+), 2

Re: [Qemu-devel] qemu gdb issue

2012-03-16 Thread Mulyadi Santosa
Hi Jacques... On Fri, Mar 16, 2012 at 14:13, Jacques wrote: > Hi Mulyadi, > > I see what you mean. How do I know if this is happening? When I do 'x/i > $eip' I get a completely sane result with exactly the instructions I want. Alright, that confuses me too. The best other explanation I can offe

Re: [Qemu-devel] Failed to set a breakpoint on start_kernel

2012-03-16 Thread Mulyadi Santosa
Hi... On Fri, Mar 16, 2012 at 09:43, Wei Yang wrote: > 8. Attach the gdb in the kernel source directory >    gdb >    file vmlinux that vmlinux, is that the symbol file of the guest running kernel? And have you compiled the guest kernel with the option to include debug info and possibly frame po

Re: [Qemu-devel] [V5 PATCH 1/4] net: announce self after vm start

2012-03-16 Thread Paolo Bonzini
Il 16/03/2012 16:23, Jason Wang ha scritto: >>> >> Or just a global need_announce instead of looking at the runstate. >> >> Paolo >> > Then I think it's better for us introduce a parameter for vm_start() > like what we've done in V4. But that didn't work because you ended up changing the "cont" se

Re: [Qemu-devel] Add GSoC project ideas to the wiki!

2012-03-16 Thread Natalia Portillo
Hi Kevin, Sorry for the late answer, had hardware problems recently On 12/03/2012, at 11:36, Kevin Wolf wrote: > Am 24.02.2012 10:19, schrieb Stefan Hajnoczi: >> This is a reminder that QEMU will apply for Google Summer of Code 2012 and we >> need project ideas and mentors. Libvirt and kvm.ko p

[Qemu-devel] [PATCH 3/3] target-arm: Decode SETEND correctly in Thumb

2012-03-16 Thread Peter Maydell
Decode the SETEND instruction correctly in Thumb mode, rather than accidentally treating it like CPS. We don't support BE8 mode, but this change brings the Thumb mode in to line with behaviour in ARM mode: 'SETEND BE' is not supported and will provoke an UNDEF exception, but 'SETEND LE' is correctl

[Qemu-devel] [PATCH 2/3] target-arm: Clear IT bits when taking exceptions in v7M

2012-03-16 Thread Peter Maydell
When taking an exception for an M profile core, we must clear the IT bits. Since the IT bits are cached in env->condexec_bits we must clear them there: writing the bits in env->uncached_cpsr has no effect. (Reported as LP:944645.) Signed-off-by: Peter Maydell --- target-arm/helper.c |3 ++-

[Qemu-devel] [PATCH 1/3] target-arm: Fix typo in ARM946 cp15 c5 handling

2012-03-16 Thread Peter Maydell
Fix a typo in handling of the ARM946 cp15 c5 c0 0 1 handling (instruction access permission bits) that meant it would return the data access permission bits by mistake. Signed-off-by: Peter Maydell --- target-arm/helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/

[Qemu-devel] [PULL 0/3] target-arm queue

2012-03-16 Thread Peter Maydell
Hi; this is a pullreq for my target-arm queue. Just three fairly minor bug fixes this time. Please pull. Thanks -- PMM The following changes since commit ae7d54d489540b49b7c13a7df7ddc220588a2ced: target-lm32/microblaze: Drop second CPU{LM32, MB}State typedef (2012-03-14 19:48:37 -0500) are a

Re: [Qemu-devel] [PULL] pci, virtio, net

2012-03-16 Thread Anthony Liguori
On 03/15/2012 06:49 PM, Michael S. Tsirkin wrote: I'm trying a signed pull request now. You can check the signature on for_anthony if you like, and if your git is recent enough it will do it for you automatically. The following changes since commit ae7d54d489540b49b7c13a7df7ddc220588a2ced: t

Re: [Qemu-devel] [PATCH] Initial support for Ilumos build and Illumos-kvm

2012-03-16 Thread Paolo Bonzini
Il 16/03/2012 18:25, Lee Essen ha scritto: > Correct … but actually this raises another question … why create a separate > pointer to kvm_state… > > KVMState *s = kvm_state; > > … why not just use kvm_state throughout the function? > > This seems to be a common approach in many of the funct

[Qemu-devel] [PATCH 2/4] arm: make sure that number of irqs can be represented in GICD_TYPER.

2012-03-16 Thread Peter Maydell
From: Rusty Russell We currently assume that the number of interrupts (ITLinesNumber in the architecture reference manual) is divisible by 32, since we present it to the guest when it reads GICD_TYPER (in gic_dist_readb()) as (N / 32) - 1. Signed-off-by: Rusty Russell Signed-off-by: Peter Mayde

[Qemu-devel] [PATCH 1/4] arm: clean up GIC constants

2012-03-16 Thread Peter Maydell
From: Rusty Russell Interrupts numbers 0-31 are private to the processor interface, 32-1019 are general interrupts. Add GIC_INTERNAL and substitute everywhere. Signed-off-by: Rusty Russell [Peter Maydell: converted some tabs to spaces] Signed-off-by: Peter Maydell --- hw/arm_gic.c | 41 +++

[Qemu-devel] [PATCH 4/4] hw/arm11mpcore: Fix broken realview_mpcore/arm11mpcore_priv properties

2012-03-16 Thread Peter Maydell
Fix confusion in the Property arrays for the "arm11mpcore_priv" (per-CPU devices for the ARM11MPcore CPU) and "realview_mpcore" (realview-eb board specific device encapsulating CPU and some extra interrupt controllers) -- the num-irq property was defined on the wrong device and the mpcore_rirq_prop

[Qemu-devel] [PATCH 3/4] arm: add device tree support

2012-03-16 Thread Peter Maydell
From: Grant Likely If compiled with CONFIG_FDT, allow user to specify a device tree file using the -dtb argument. If the machine supports it then the dtb will be loaded into memory and passed to the kernel on boot. Signed-off-by: Jeremy Kerr Signed-off-by: Grant Likely [Peter Maydell: Use mac

[Qemu-devel] [PULL 0/4] arm-devs queue

2012-03-16 Thread Peter Maydell
Hi; this is a pullreq for the arm-devs queue; nothing hugely exciting here unless you count the final part of the -dtb support. Please pull. thanks -- PMM The following changes since commit 7c51c1aa03a52b9fd75ed1ade2e65d079ae4d50e: Merge remote-tracking branch 'kwolf/for-anthony' into staging

[Qemu-devel] [PATCH V8 RESEND 3/8] Introduce HostPCIDevice to access a pci device on the host.

2012-03-16 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- Makefile.target |3 + hw/host-pci-device.c | 278 ++ hw/host-pci-device.h | 75 ++ 3 files changed, 356 insertions(+), 0 deletions(-) create mode 100644 hw/host-pci-device.c create mode 100

Re: [Qemu-devel] Guest-sync-delimited and sentinel issue

2012-03-16 Thread Michael Roth
On Fri, Mar 16, 2012 at 05:04:22PM +0100, Michal Privoznik wrote: > On 16.03.2012 15:49, Michael Roth wrote: > > On Fri, Mar 16, 2012 at 01:47:42PM +0100, Michal Privoznik wrote: > >> Hi guys, > >> > >> I was just implementing support for guest-sync-delimited into libvirt. My > >> intent is to iss

Re: [Qemu-devel] [PATCH] Initial support for Ilumos build and Illumos-kvm

2012-03-16 Thread Lee Essen
On 16 Mar 2012, at 11:56, Paolo Bonzini wrote: > Il 16/03/2012 10:23, Lee Essen ha scritto: >> +while (mlock(base, (nbytes = step * ps)) == -1) { >> +if (errno != EAGAIN) { >> +return -1; >> +} >> + >> +if (waiting == 0) { >> +waiting = gethrtim

[Qemu-devel] [PATCH V8 RESEND 2/8] configure: Introduce --enable-xen-pci-passthrough.

2012-03-16 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- configure | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/configure b/configure index afe7395..1d1204a 100755 --- a/configure +++ b/configure @@ -136,6 +136,7 @@ vnc_png="" vnc_thread="no" xen="" xen_ctrl_versi

[Qemu-devel] [PATCH] linux-user/arm/syscall_nr.h: Add syscall number for ppoll

2012-03-16 Thread Peter Maydell
The list of ARM syscall numbers was missing the entry for ppoll, which meant we were accidentally not providing it. (This wasn't causing any practical issues beyond warnings about unimplemented syscalls, because glibc will fall back to another code path if the syscall isn't present.) Signed-off-by

Re: [Qemu-devel] [PATCH] Initial support for Ilumos build and Illumos-kvm

2012-03-16 Thread Lee Essen
On 16 Mar 2012, at 16:28, Paolo Bonzini wrote: > Il 16/03/2012 14:46, Lee Essen ha scritto: >> It does indeed … this came from the original Joyent code, I must >> admit I did wonder whether gcc would optimise it away. I did consider >> adding something to stop gcc complaining, but I don't fully >

[Qemu-devel] [Bug 935945] Re: SLIRP still not working for win32

2012-03-16 Thread Kenneth Salerno
Confirmed this effects all network communication, such as gdb TCP listen socket from guest. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/935945 Title: SLIRP still not working for win32 Status in

[Qemu-devel] [PATCH V8 RESEND 6/8] Introduce Xen PCI Passthrough, PCI config space helpers (2/3)

2012-03-16 Thread Anthony PERARD
From: Allen Kay A more complete history can be found here: git://xenbits.xensource.com/qemu-xen-unstable.git Signed-off-by: Allen Kay Signed-off-by: Guy Zana Signed-off-by: Anthony PERARD --- hw/xen_pci_passthrough.c | 10 + hw/xen_pci_passthrough.h |2 + hw/xen

Re: [Qemu-devel] RFC: double free in qmp_output_visitor_cleanup()

2012-03-16 Thread Michael Roth
On Fri, Mar 16, 2012 at 03:37:10PM +0100, Laszlo Ersek wrote: > Hi, > > we seem to have found a double free in qmp_output_visitor_cleanup(). > Please read the analysis below (that is based on commit e4e6aa14) and > please tell me if you'd like me to write a patch for solution (a) or > solution (b)

[Qemu-devel] [PATCH V8 RESEND 5/8] Introduce Xen PCI Passthrough, qdevice (1/3)

2012-03-16 Thread Anthony PERARD
From: Allen Kay A more complete history can be found here: git://xenbits.xensource.com/qemu-xen-unstable.git Signed-off-by: Allen Kay Signed-off-by: Guy Zana Signed-off-by: Anthony PERARD --- Makefile.target |2 + hw/xen_common.h |3 + hw/xen

[Qemu-devel] [PATCH V8 RESEND 0/8] Xen PCI Passthrough

2012-03-16 Thread Anthony PERARD
Hi all, This patch series introduces the PCI passthrough for Xen. Please review patches number 1, 2, 3, 4 and 7. First, we have HostPCIDevice that help to access one PCI device of the host. Then, there is an additions in the QEMU code, pci_check_bar_overlap. There are also several change in

[Qemu-devel] [PATCH V8 RESEND 8/8] Introduce Xen PCI Passthrough, MSI (3/3)

2012-03-16 Thread Anthony PERARD
From: Jiang Yunhong A more complete history can be found here: git://xenbits.xensource.com/qemu-xen-unstable.git Signed-off-by: Jiang Yunhong Signed-off-by: Shan Haitao Signed-off-by: Anthony PERARD --- Makefile.target |1 + hw/xen_pci_passthrough.c | 3

[Qemu-devel] [PATCH V8 RESEND 7/8] Introduce apic-msidef.h

2012-03-16 Thread Anthony PERARD
This patch move the msi definition from apic.c to apic-msidef.h. So it can be used also by other .c files. Signed-off-by: Anthony PERARD --- hw/apic-msidef.h | 30 ++ hw/apic.c| 11 +-- 2 files changed, 31 insertions(+), 10 deletions(-) create mod

[Qemu-devel] [PATCH V8 RESEND 4/8] pci.c: Add pci_check_bar_overlap

2012-03-16 Thread Anthony PERARD
From: Yuji Shimada This function helps Xen PCI Passthrough device to check for overlap. Signed-off-by: Yuji Shimada Signed-off-by: Anthony PERARD --- hw/pci.c | 50 ++ hw/pci.h |5 + 2 files changed, 55 insertions(+), 0 deletions(-) d

[Qemu-devel] [PATCH V8 RESEND 1/8] pci_ids: Add INTEL_82599_VF id.

2012-03-16 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- hw/pci_ids.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pci_ids.h b/hw/pci_ids.h index e8235a7..943106a 100644 --- a/hw/pci_ids.h +++ b/hw/pci_ids.h @@ -118,6 +118,7 @@ #define PCI_DEVICE_ID_INTEL_82801I_UHCI6 0x2939 #define PCI

Re: [Qemu-devel] [PATCHv4 09/11] export iov_send_recv() and use it in iov_send() and iov_recv()

2012-03-16 Thread Michael Tokarev
On 16.03.2012 20:21, Anthony Liguori wrote: > On 03/15/2012 04:00 PM, Michael Tokarev wrote: [] >> +ssize_t iov_send_recv(int sockfd, struct iovec *iov, >> + size_t offset, size_t bytes, bool do_send); >> +#define iov_recv(sockfd, iov, offset, bytes) \ >> + iov_send_recv(sockf

Re: [Qemu-devel] lsi_scsi: error: ORDERED queue not implemented

2012-03-16 Thread Marius Cirsta
On Fri, Mar 16, 2012 at 1:33 PM, Paolo Bonzini wrote: > Il 15/03/2012 23:30, Marius Cirsta ha scritto: >> >> qemu-system-arm --version >> QEMU emulator version 1.0,1, Copyright (c) 2003-2008 Fabrice Bellard >> >> and I have a premade ARM image which I start with: >> >> qemu-system-arm -M versatile

Re: [Qemu-devel] [PATCHv4 01/11] virtio-serial-bus: use correct lengths in control_out() message

2012-03-16 Thread Michael Tokarev
On 16.03.2012 20:12, Anthony Liguori wrote: > On 03/15/2012 04:00 PM, Michael Tokarev wrote: >> In case of more than one control message, the code will use >> size of the largest message so far for all subsequent messages, >> instead of using size of current one. Fix it. >> >> Signed-off-by: Micha

Re: [Qemu-devel] [PATCH] Initial support for Ilumos build and Illumos-kvm

2012-03-16 Thread Paolo Bonzini
Il 16/03/2012 14:46, Lee Essen ha scritto: > It does indeed … this came from the original Joyent code, I must > admit I did wonder whether gcc would optimise it away. I did consider > adding something to stop gcc complaining, but I don't fully > understand why this is necessary given the mlock() bi

Re: [Qemu-devel] [PATCHv4 02/11] change iov_* function prototypes to be more appropriate

2012-03-16 Thread Michael Tokarev
On 16.03.2012 20:14, Anthony Liguori wrote: > On 03/15/2012 04:00 PM, Michael Tokarev wrote: >> Reorder arguments to be more natural, readable and >> consistent with other iov_* functions, and change >> argument names, from: >> iov_from_buf(iov, iov_cnt, buf, iov_off, size) >> to >> iov_from_bu

Re: [Qemu-devel] [PATCHv4 11/11] rewrite iov_send_recv() and move it to iov.c

2012-03-16 Thread Anthony Liguori
On 03/15/2012 04:00 PM, Michael Tokarev wrote: Make it much more understandable, add a missing iov_cnt argument (number of iovs in the iov), and add comments to it. The new implementation has been extensively tested by splitting a large buffer into many small randomly-sized chunks, sending it ov

Re: [Qemu-devel] [PATCHv4 10/11] cleanup qemu_co_sendv(), qemu_co_recvv() and friends

2012-03-16 Thread Anthony Liguori
On 03/15/2012 04:00 PM, Michael Tokarev wrote: The same as for non-coroutine versions in previous patches: rename arguments to be more obvious, change type of arguments from int to size_t where appropriate, and use common code for send and receive paths (with one extra argument) since these are e

Re: [Qemu-devel] [PATCHv4 09/11] export iov_send_recv() and use it in iov_send() and iov_recv()

2012-03-16 Thread Anthony Liguori
On 03/15/2012 04:00 PM, Michael Tokarev wrote: Rename do_sendv_recvv() to iov_send_recv(), change its last arg (do_send) from int to bool, export it in iov.h, and made the two callers of it (iov_send() and iov_recv()) to be trivial #defines just adding 5th arg. iov_send_recv() will be used later

Re: [Qemu-devel] [PATCHv4 05/11] allow qemu_iovec_from_buffer() to specify offset from which to start copying

2012-03-16 Thread Anthony Liguori
On 03/15/2012 04:00 PM, Michael Tokarev wrote: Similar to qemu_iovec_memset(QEMUIOVector *qiov, size_t offset, int c, size_t bytes); the new prototype is: qemu_iovec_from_buf(QEMUIOVector *qiov, size_t offset, const void *buf, size_t bytes); The proc

Re: [Qemu-devel] [PATCH 1/5] configure to set shell type

2012-03-16 Thread Peter Maydell
On 16 March 2012 15:58, Eric Blake wrote: > On 03/16/2012 06:35 AM, Peter Maydell wrote: >> The way I expect this to work is that /bin/sh should be a posix shell... > > Then your expectations are wrong.  POSIX itself says that /bin/sh need > not be the POSIX shell, and merely requires that you can

Re: [Qemu-devel] [PATCHv4 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset()

2012-03-16 Thread Anthony Liguori
On 03/15/2012 04:00 PM, Michael Tokarev wrote: This patch combines two functions into one, and replaces the implementation with already existing iov_memset() from iov.c. The new prototype of qemu_iovec_memset(): size_t qemu_iovec_memset(qiov, size_t offset, int fillc, size_t bytes) It is diff

Re: [Qemu-devel] [PATCHv4 03/11] rewrite iov_* functions

2012-03-16 Thread Anthony Liguori
On 03/15/2012 04:00 PM, Michael Tokarev wrote: This changes implementations of all iov_* functions, completing the previous step. All iov_* functions now ensure that this offset argument is within the iovec (using assertion), but lets to specify `bytes' value larger than actual length of the iov

Re: [Qemu-devel] [PATCHv4 03/11] rewrite iov_* functions

2012-03-16 Thread Anthony Liguori
On 03/15/2012 04:00 PM, Michael Tokarev wrote: This changes implementations of all iov_* functions, completing the previous step. All iov_* functions now ensure that this offset argument is within the iovec (using assertion), but lets to specify `bytes' value larger than actual length of the iov

Re: [Qemu-devel] [PATCHv4 02/11] change iov_* function prototypes to be more appropriate

2012-03-16 Thread Anthony Liguori
On 03/15/2012 04:00 PM, Michael Tokarev wrote: Reorder arguments to be more natural, readable and consistent with other iov_* functions, and change argument names, from: iov_from_buf(iov, iov_cnt, buf, iov_off, size) to iov_from_buf(iov, iov_cnt, offset, buf, bytes) The result becomes natura

Re: [Qemu-devel] [PATCHv4 01/11] virtio-serial-bus: use correct lengths in control_out() message

2012-03-16 Thread Anthony Liguori
On 03/15/2012 04:00 PM, Michael Tokarev wrote: In case of more than one control message, the code will use size of the largest message so far for all subsequent messages, instead of using size of current one. Fix it. Signed-off-by: Michael Tokarev --- hw/virtio-serial-bus.c |6 +++--- 1

Re: [Qemu-devel] Guest-sync-delimited and sentinel issue

2012-03-16 Thread Michal Privoznik
On 16.03.2012 15:49, Michael Roth wrote: > On Fri, Mar 16, 2012 at 01:47:42PM +0100, Michal Privoznik wrote: >> Hi guys, >> >> I was just implementing support for guest-sync-delimited into libvirt. My >> intent is to issue this command prior any other command to determine if GA >> is available or

Re: [Qemu-devel] [PATCH v7 2/6] Introduce "save-devices-state"

2012-03-16 Thread Eric Blake
On 03/16/2012 09:58 AM, Anthony Liguori wrote: >>> +These operations are normally used with migration (see migration.txt), >>> +however it is also possible to save the state of all devices to file, >>> +without saving the RAM or the block devices of the VM. >>> + >>> +This operation is called "sav

Re: [Qemu-devel] [PATCH v7 2/6] Introduce "save-devices-state"

2012-03-16 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Eric Blake wrote: > On 03/16/2012 06:13 AM, Stefano Stabellini wrote: > > - add an "is_ram" flag to SaveStateEntry; > > > > - register_savevm_live sets is_ram for live_savevm devices; > > > > - introduce a "save-devices-state" QAPI command that can be used to save > > the sta

[Qemu-devel] [Bug 954099] Re: Assertion failed arp_table.c line 41 on raspberry pi fedora image boot up

2012-03-16 Thread Peter Maydell
It's probably also fixed in upstream qemu master since I haven't deliberately put anything in to qemu-linaro to fix it -- we've almost certainly just picked up the fix from upstream. Incidentally "-M versatilepb -cpu arm1136-r2" is veering slightly into "unsupported" territory, since there's no su

Re: [Qemu-devel] [PATCH v6 2/6] Introduce "save_devices"

2012-03-16 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Eric Blake wrote: > On 03/15/2012 02:34 PM, Luiz Capitulino wrote: > > On Thu, 15 Mar 2012 15:16:15 -0500 > > Anthony Liguori wrote: > > > >> On 03/15/2012 01:19 PM, Stefano Stabellini wrote: > >>> - add an "is_ram" flag to SaveStateEntry; > >>> > >>> - register_savevm_live s

Re: [Qemu-devel] [PATCH 1/5] configure to set shell type

2012-03-16 Thread Eric Blake
On 03/16/2012 06:35 AM, Peter Maydell wrote: >> The issue here is really just getting a fully POSIX-conformant shell. >> And the way I expect this to work is by executing configure and make in >> such a shell and by not having hardcoded /bin/sh creep in through some >> shebang line. > > The way I

Re: [Qemu-devel] [PATCH v7 2/6] Introduce "save-devices-state"

2012-03-16 Thread Anthony Liguori
On 03/16/2012 10:49 AM, Eric Blake wrote: On 03/16/2012 06:13 AM, Stefano Stabellini wrote: - add an "is_ram" flag to SaveStateEntry; - register_savevm_live sets is_ram for live_savevm devices; - introduce a "save-devices-state" QAPI command that can be used to save the state of all devices, b

Re: [Qemu-devel] [PATCH v7 2/6] Introduce "save-devices-state"

2012-03-16 Thread Eric Blake
On 03/16/2012 06:13 AM, Stefano Stabellini wrote: > - add an "is_ram" flag to SaveStateEntry; > > - register_savevm_live sets is_ram for live_savevm devices; > > - introduce a "save-devices-state" QAPI command that can be used to save > the state of all devices, but not the RAM or the block devic

[Qemu-devel] [Bug 899961] Re: qemu/kvm locks up when run 32bit userspace with 64bit kernel

2012-03-16 Thread Michael Tokarev
After some more digging I found out that qemu also has this very issue, but it happens a bit differently. In particular, this very same winXP test guest freezes in upstream qemu with -enable-kvm on _shutdown_, not on restart. In qemu-kvm it happens on restart but not on shutdown. And bisecting p

[Qemu-devel] [Bug 899961] Re: qemu/kvm locks up when run 32bit userspace with 64bit kernel

2012-03-16 Thread Michael Tokarev
Forgot to mention: tcg appears to be unaffected - so far anyway. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/899961 Title: qemu/kvm locks up when run 32bit userspace with 64bit kernel Status in

Re: [Qemu-devel] [PATCH v6 2/6] Introduce "save_devices"

2012-03-16 Thread Eric Blake
On 03/15/2012 02:34 PM, Luiz Capitulino wrote: > On Thu, 15 Mar 2012 15:16:15 -0500 > Anthony Liguori wrote: > >> On 03/15/2012 01:19 PM, Stefano Stabellini wrote: >>> - add an "is_ram" flag to SaveStateEntry; >>> >>> - register_savevm_live sets is_ram for live_savevm devices; >>> >>> - introduce

[Qemu-devel] [Bug 954099] Re: Assertion failed arp_table.c line 41 on raspberry pi fedora image boot up

2012-03-16 Thread Akarsh
This bug is related to ARM based processor emulation and has been fixed in Linaro QEMU(qemu-linaro). You can install qemu-linaro to solve the problem. This can be confirmed with the following link(Point 6) : http://www.cnx-software.com/2012/03/08/instructions-to-run-raspberry-pi- fedora-14-remix-in

Re: [Qemu-devel] [V5 PATCH 1/4] net: announce self after vm start

2012-03-16 Thread Jason Wang
On 03/16/2012 06:45 PM, Paolo Bonzini wrote: Il 16/03/2012 11:13, Jason Wang ha scritto: > The problem with staying in the INMIGRATE is that we can not figure out > when the migration is completed when using '-S', so this kind of > transition were forbidden by qmp_cont(). > > Looks like we

  1   2   >