Re: [Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy

2012-03-09 Thread Stefan Hajnoczi
On Fri, Mar 9, 2012 at 5:16 PM, Paolo Bonzini wrote: > Il 09/03/2012 17:07, Stefan Hajnoczi ha scritto: >>> > So am I correct that this extra permission is only needed for a single >>> > RHEL6 release? If qemu won't be doing fstafs on an ongoing basis, it >>> > doesn't seem like a good idea to per

Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys

2012-03-09 Thread Markus Armbruster
Alexander Graf writes: [...] > Imagine, your host can only do 32 bit file offsets. You want to > emulate a 64bit guest though. To load an image, you say "load the > image at offset x, max size ". If you use size_t, > it would break for large ram guests, because the size really means > semanticall

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2012-03-09 Thread Jeff Snider
I tested that other bug. As far as I can tell it is not fixed. I haven't gotten any sort of response on it for a week. So... now what? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/524447 Title:

Re: [Qemu-devel] [PATCH 08/13] ide/ahci: Use universal DMA helper functions

2012-03-09 Thread David Gibson
On Fri, Mar 09, 2012 at 10:48:20AM +0100, Kevin Wolf wrote: > Am 09.03.2012 06:01, schrieb David Gibson: > > The AHCI device can provide both PCI and SysBus AHCI device > > emulations. For this reason, it wasn't previously converted to use > > the pci_dma_*() helper functions. Now that we have un

[Qemu-devel] [PATCH RFC v4 12/44] bsd-user: Don't overuse CPUState

2012-03-09 Thread Andreas Färber
Use CPU*State where applicable. Signed-off-by: Andreas Färber --- bsd-user/main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index c3af395..78533d5 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -63,7 +63,7 @@ void gemu_lo

[Qemu-devel] [PATCH RFC v4 04/44] monitor: Avoid CPUState in read/write functions

2012-03-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 56 1 files changed, 28 insertions(+), 28 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 7d470b6..054e16c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -533,7 +533,7 @@ static const int gp

[Qemu-devel] [PATCH RFC v4 10/44] linux-user: Don't overuse CPUState

2012-03-09 Thread Andreas Färber
In target-specific code use CPU*State. While at it, fix indentation on those lines. Signed-off-by: Andreas Färber --- linux-user/elfload.c | 24 +++--- linux-user/m68k/syscall.h |2 +- linux-user/main.c | 28 +++--- linux-user/signal.c | 201 +++--

[Qemu-devel] [PATCH RFC v4 22/44] target-s390x: Don't overuse CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: sed -i "s/CPUState/CPUS390XState/g" target-s390x/*.[hc] sed -i "s/#define CPUS390XState/#define CPUState/" target-s390x/cpu.h Signed-off-by: Andreas Färber --- target-s390x/cpu.h | 46 +++--- target-s390x/helper.c| 38 ---

[Qemu-devel] [PATCH RFC v4 08/44] target-unicore32: Rename to CPUUniCore32State

2012-03-09 Thread Andreas Färber
This aids in refactoring CPUState by adopting the common naming scheme. Signed-off-by: Andreas Färber --- target-unicore32/cpu.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target-unicore32/cpu.h b/target-unicore32/cpu.h index f725634..923db05 100644 --- a/tar

[Qemu-devel] [PATCH RFC v4 05/44] target-lm32: Typedef struct CPULM32State

2012-03-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-lm32/cpu.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-lm32/cpu.h b/target-lm32/cpu.h index b6b6b4c..cc9b53b 100644 --- a/target-lm32/cpu.h +++ b/target-lm32/cpu.h @@ -28,6 +28,7 @@ #include "qemu-common.h" #include "c

[Qemu-devel] [PATCH RFC v4 07/44] target-sparc: Typedef struct CPUSPARCState early

2012-03-09 Thread Andreas Färber
Will be needed for qemu_irq_ack callback. Signed-off-by: Andreas Färber --- target-sparc/cpu.h |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/target-sparc/cpu.h b/target-sparc/cpu.h index 38a7074..8098669 100644 --- a/target-sparc/cpu.h +++ b/target-sparc/cpu.h @@

[Qemu-devel] [PATCH v4 02/44] Rename cpu_reset() to cpu_state_reset()

2012-03-09 Thread Andreas Färber
Frees the identifier cpu_reset for QOM CPUs (manual rename). Don't hide the parameter type behind explicit casts, use static functions with strongly typed argument to indirect. Signed-off-by: Andreas Färber --- bsd-user/main.c |2 +- cpu-all.h |2 +- cp

[Qemu-devel] [PATCH RFC v4 30/44] alpha hw/: Don't use CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: for file in hw/alpha_*.[hc]; do sed -i "s/CPUState/CPUAlphaState/g" $file done Signed-off-by: Andreas Färber --- hw/alpha_dp264.c |2 +- hw/alpha_sys.h |2 +- hw/alpha_typhoon.c | 14 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) di

[Qemu-devel] [PATCH RFC v4 18/44] target-m68k: Don't overuse CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: sed -i "s/CPUState/CPUM68KState/g" target-m68k/*.[hc] sed -i "s/#define CPUM68KState/#define CPUState/" target-m68k/cpu.h Signed-off-by: Andreas Färber --- target-m68k/cpu.h | 16 +- target-m68k/helper.c| 78 +++--

[Qemu-devel] [PATCH RFC v4 06/44] target-microblaze: Typedef struct CPUMBState

2012-03-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-microblaze/cpu.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-microblaze/cpu.h b/target-microblaze/cpu.h index 4092506..94ec43b 100644 --- a/target-microblaze/cpu.h +++ b/target-microblaze/cpu.h @@ -29,6 +29,7 @@ #includ

[Qemu-devel] [PATCH RFC v4 16/44] target-i386: Don't overuse CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: sed -i "s/CPUState/CPUX86State/g" target-i386/*.[hc] sed -i "s/#define CPUX86State/#define CPUState/" target-i386/cpu.h Signed-off-by: Andreas Färber --- target-i386/cpu.h | 34 +- target-i386/helper.c| 38 +- target-i386/kvm.c | 76

[Qemu-devel] [PATCH RFC v4 42/44] xtensa hw/: Don't use CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: for file in hw/xtensa_*.[hc]; do sed -i "s/CPUState/CPUXtensaState/g" $file done Signed-off-by: Andreas Färber --- hw/xtensa_lx60.c |4 ++-- hw/xtensa_pic.c | 16 hw/xtensa_sim.c |2 +- 3 files changed, 11 insertions(+), 11 deletions(-)

Re: [Qemu-devel] [libvirt] Modern CPU models cannot be used with libvirt

2012-03-09 Thread Eduardo Habkost
On Fri, Mar 09, 2012 at 03:15:26PM -0600, Anthony Liguori wrote: > On 03/09/2012 03:04 PM, Daniel P. Berrange wrote: > >On Fri, Mar 09, 2012 at 05:56:52PM -0300, Eduardo Habkost wrote: > >>Resurrecting an old thread: > >> > >>I didn't see any clear conclusion in this thread (this is why I am > >>re

[Qemu-devel] [PATCH RFC v4 09/44] hw/mc146818: Drop unneeded #includes

2012-03-09 Thread Andreas Färber
pc.h and apic.h are not needed; apic.h would drag in x86 CPUState and is now included directly for TARGET_I386. isa.h is already #included from mc146818rtc.h. Signed-off-by: Andreas Färber --- hw/mc146818rtc.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/mc146818

[Qemu-devel] [PATCH RFC v4 26/44] target-xtensa: Don't overuse CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: sed -i "s/CPUState/CPUXtensaState/g" target-xtensa/*.[hc] sed -i "s/#define CPUXtensaState/#define CPUState/" target-xtensa/cpu.h Signed-off-by: Andreas Färber --- target-xtensa/cpu.h | 44 ++-- target-xtensa/helper.c|

[Qemu-devel] [PATCH RFC v4 19/44] target-microblaze: Don't overuse CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: sed -i "s/CPUState/CPUMBState/g" target-microblaze/*.[hc] sed -i "s/#define CPUMBState/#define CPUState/" target-microblaze/cpu.h Signed-off-by: Andreas Färber --- target-microblaze/cpu.h | 30 +++--- target-microblaze/helper.c| 10

[Qemu-devel] [PATCH RFC v4 15/44] target-cris: Don't overuse CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: sed -i "s/CPUState/CPUCRISState/g" target-cris/*.[hc] sed -i "s/#define CPUCRISState/#define CPUState/" target-cris/cpu.h Signed-off-by: Andreas Färber --- target-cris/cpu.h | 12 +- target-cris/helper.c| 14 ++-- target-cris/mmu.c

[Qemu-devel] [PATCH RFC v4 39/44] s390x hw/: Don't use CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: for file in hw/s390-*.[hc]; do sed -i "s/CPUState/CPUS390XState/g" $file done Signed-off-by: Andreas Färber --- hw/s390-virtio-bus.c |6 +++--- hw/s390-virtio.c | 16 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/s390-

[Qemu-devel] [PATCH RFC v4 36/44] microblaze hw/: Don't use CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: for file in hw/microblaze_*.[hc] hw/petalogix_ml605_mmu.c hw/petalogix_s3adsp1800_mmu.c; do sed -i "s/CPUState/CPUMBState/g" $file done Signed-off-by: Andreas Färber --- hw/microblaze_boot.c |8 hw/microblaze_boot.h |4 ++-- hw/mic

[Qemu-devel] [PATCH RFC v4 27/44] arm-semi: Don't use CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: sed -i "s/CPUState/CPUARMState/g" arm-semi.c Signed-off-by: Andreas Färber --- arm-semi.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arm-semi.c b/arm-semi.c index 873518a..8debd19 100644 --- a/arm-semi.c +++ b/arm-semi.c @@ -108,7 +10

[Qemu-devel] [PATCH RFC v4 00/44] Introduce QOM CPU

2012-03-09 Thread Andreas Färber
Hello, This is a heavily rebased and redone series introducing a QOM CPU base class. It now avoids the name conflict between typedef struct CPU CPU and CPU(obj) by freeing the identifier CPUState. Patch 1 is a patch by Alex that removes some unused occurrences of cpu_reset(). Patch 2 renames cpu_

[Qemu-devel] [PATCH RFC v4 28/44] m68k-semi: Don't use CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: sed -i "s/CPUState/CPUM68KState/g" m68k-semi.c Signed-off-by: Andreas Färber --- m68k-semi.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/m68k-semi.c b/m68k-semi.c index bab01ee..3bb30cd 100644 --- a/m68k-semi.c +++ b/m68k-semi.c @@ -104,7 +1

[Qemu-devel] [PATCH RFC v4 37/44] mips hw/: Don't use CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: for file in hw/mips_*.[hc]; do sed -i "s/CPUState/CPUMIPSState/g" $file done Signed-off-by: Andreas Färber --- hw/mips_cpudevs.h |4 ++-- hw/mips_fulong2e.c | 10 +- hw/mips_int.c |6 +++--- hw/mips_jazz.c |6 +++--- hw/mips_malta.c

[Qemu-devel] [PATCH RFC v4 35/44] m68k hw/: Don't use CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: for file in hw/an5206.c hw/dummy_m68k.c hw/mcf.h hw/mcf5206.c hw/mcf5208.c hw/mcf_intc.c; do sed -i "s/CPUState/CPUM68KState/g" $file done Signed-off-by: Andreas Färber --- hw/an5206.c |2 +- hw/dummy_m68k.c |2 +- hw/mcf.h|4 ++-- hw/mcf5206

[Qemu-devel] [PATCH RFC v4 40/44] sh4 hw/: Don't use CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: for file in hw/sh.h hw/shix.c hw/r2d.c; do sed -i "s/CPUState/CPUSH4State/g" $file done Signed-off-by: Andreas Färber --- hw/r2d.c |6 +++--- hw/sh.h |2 +- hw/shix.c |2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/r2d.c b/hw/r

[Qemu-devel] [PATCH RFC v4 29/44] xtensa-semi: Don't use CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: sed -i "s/CPUState/CPUXtensaState/g" xtensa-semi.c Signed-off-by: Andreas Färber --- xtensa-semi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/xtensa-semi.c b/xtensa-semi.c index ba0e828..5754b77 100644 --- a/xtensa-semi.c +++ b/xtensa-semi.c

[Qemu-devel] [PATCH RFC v4 44/44] qom: Introduce CPU class

2012-03-09 Thread Andreas Färber
Reintroduce CPUState as QOM object: It's abstract and derived directly from TYPE_OBJECT for compatibility with the user emulators. The identifier CPUState avoids conflicts between CPU() and the struct. Introduce $(qom-twice-y) to build it separately for system and for user emulators. Prepare a vi

[Qemu-devel] [PATCH RFC v4 33/44] i386 hw/: Don't use CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: for file in hw/apic.h hw/kvm/apic.c hw/kvmvapic.c hw/pc.c hw/vmport.c hw/xen_machine_pv.c; do sed -i "s/CPUState/CPUX86State/g" $file done Signed-off-by: Andreas Färber --- hw/apic.h |2 +- hw/kvm/apic.c |2 +- hw/kvmvapic.c | 22

[Qemu-devel] [PATCH RFC v4 31/44] arm hw/: Don't use CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: for file in hw/arm-misc.h hw/arm_boot.c hw/arm_pic.c hw/armv7m.c hw/exynos4210.h hw/highbank.c hw/integratorcp.c hw/musicpal.c hw/omap.h hw/pxa.h hw/pxa2xx_gpio.c hw/pxa2xx_pic.c hw/realview.c hw/strongarm.h hw/versatilepb.c hw/vexpress.c hw/xilinx_zynq.c ; do sed -i

[Qemu-devel] [PATCH RFC v4 23/44] target-sh4: Don't overuse CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: sed -i "s/CPUState/CPUSH4State/g" target-sh4/*.[hc] sed -i "s/#define CPUSH4State/#define CPUState/" target-sh4/cpu.h Signed-off-by: Andreas Färber --- target-sh4/cpu.h | 10 +- target-sh4/helper.c| 28 ++-- target-sh4/op_hel

[Qemu-devel] [PATCH RFC v4 32/44] cris hw/: Don't use CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: for file in hw/cris-boot.[hc] hw/cris_pic_cpu.c hw/axis_dev88.c hw/etraxfs.h hw/etraxfs_ser.c; do sed -i "s/CPUState/CPUCRISState/g" $file done Signed-off-by: Andreas Färber --- hw/axis_dev88.c |2 +- hw/cris-boot.c|4 ++-- hw/cris-boot.h|2 +-

[Qemu-devel] [PATCH RFC v4 17/44] target-lm32: Don't overuse CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: sed -i "s/CPUState/CPULM32State/g" target-lm32/*.[hc] sed -i "s/#define CPULM32State/#define CPUState/" target-lm32/cpu.h Signed-off-by: Andreas Färber --- target-lm32/cpu.h | 28 ++-- target-lm32/helper.c| 16 targe

[Qemu-devel] [PATCH RFC v4 21/44] target-ppc: Don't overuse CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: sed -i "s/CPUState/CPUPPCState/g" target-ppc/*.[hc] sed -i "s/#define CPUPPCState/#define CPUState/" target-ppc/cpu.h Signed-off-by: Andreas Färber --- target-ppc/cpu.h| 38 ++-- target-ppc/helper.c | 80 +--

[Qemu-devel] [PATCH RFC v4 03/44] monitor: Don't access registers through CPUState

2012-03-09 Thread Andreas Färber
Use CPUX86State etc. instead (hand-converted). Signed-off-by: Andreas Färber --- monitor.c | 488 ++-- 1 files changed, 244 insertions(+), 244 deletions(-) diff --git a/monitor.c b/monitor.c index cbdfbad..e3b72ff 100644 --- a/monitor.c +

[Qemu-devel] [PATCH RFC v4 41/44] sparc hw/: Don't use CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: for file in hw/sun4m.c hw/sun4u.c hw/grlib.h hw/leon3.c; do sed -i "s/CPUState/CPUSPARCState/g" $file done Signed-off-by: Andreas Färber --- hw/grlib.h |2 +- hw/leon3.c |8 hw/sun4m.c | 12 ++-- hw/sun4u.c | 24

[Qemu-devel] [PATCH RFC v4 25/44] target-unicore32: Don't overuse CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: sed -i "s/CPUState/CPUUniCore32State/g" target-unicore32/*.[hc] sed -i "s/#define CPUUniCore32State/#define CPUState/" target-unicore32/cpu.h Signed-off-by: Andreas Färber --- target-unicore32/cpu.h | 24 target-unicore32/helper.c| 62 +

[Qemu-devel] [PATCH RFC v4 34/44] lm32 hw/: Don't use CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: for file in hw/lm32_boards.c hw/milkymist.c; do sed -i "s/CPUState/CPULM32State/g" $file done Signed-off-by: Andreas Färber --- hw/lm32_boards.c | 10 +- hw/milkymist.c |8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/lm3

[Qemu-devel] [PATCH RFC v4 11/44] darwin-user: Don't overuse CPUState

2012-03-09 Thread Andreas Färber
Use CPU*State where applicable. Signed-off-by: Andreas Färber --- darwin-user/main.c | 14 +++--- darwin-user/signal.c |4 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/darwin-user/main.c b/darwin-user/main.c index 13c1f05..f5cadc7 100644 --- a/darwin-user/m

[Qemu-devel] [PATCH v4 01/44] PPC: 405: Use proper CPU reset

2012-03-09 Thread Andreas Färber
From: Alexander Graf On ppc405ep there is a register that allows for software to reset the core, but not the whole system. Implement this reset using a reset interrupt. This gets rid of a bunch of #if 0'ed code. Reported-by: Andreas Färber Signed-off-by: Alexander Graf Signed-off-by: Andreas

[Qemu-devel] [PATCH RFC v4 13/44] target-alpha: Don't overuse CPUState

2012-03-09 Thread Andreas Färber
Scripted conversion: sed -i "s/CPUState/CPUAlphaState/g" target-alpha/*.[hc] sed -i "s/#define CPUAlphaState/#define CPUState/" target-alpha/cpu.h Signed-off-by: Andreas Färber --- target-alpha/cpu.h | 24 ++-- target-alpha/helper.c| 18 +++--- target-al

Re: [Qemu-devel] [PATCH v4 1/3] kvmclock: Always register type

2012-03-09 Thread Andreas Färber
Am 05.03.2012 10:23, schrieb Avi Kivity: > On 03/04/2012 10:32 PM, Andreas Färber wrote: >> Currently, the "kvmclock" type is only registered when kvm_enabled(). >> >> This breaks when moving type registration to before command line >> parsing (so that QOM types can be used for CPU and machine). >>

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_class_get_list()

2012-03-09 Thread Andreas Färber
Am 07.03.2012 11:21, schrieb Andreas Färber: > Am 25.02.2012 23:07, schrieb Andreas Färber: >> This function allows to obtain a singly-linked list of classes, which >> can be sorted by the caller. >> >> Signed-off-by: Andreas Färber >> Cc: Anthony Liguori > > Ping? You requested me to do it via

Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-03-09 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 09.03.2012 21:52, schrieb Jan Kiszka: > Andreas, do you expect CPU devices to be ready for qemu 1.1? We > would need them to pass a feature exclusion mask from > machine.compat_props to the (x86) CPU init code. I was sure hoping to! Marcelo and

[Qemu-devel] [Bug 393430] Re: kvm: use PulseAudio instead of ALSA

2012-03-09 Thread Clint Byrum
Bump, fairly old issue here. I wonder if anybody is still affected on recent releases of Ubuntu (including 10.04 but also 11.10 and precise.) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/393430 Titl

Re: [Qemu-devel] [PATCH 4/4] qapi: Convert migrate

2012-03-09 Thread Alon Levy
On Fri, Mar 09, 2012 at 03:13:06PM -0300, Luiz Capitulino wrote: > The migrate command is one of those commands where HMP and QMP completely > mix up together. This made the conversion to the QAPI (which separates the > command into QMP and HMP parts) a bit difficult. > > The first important chang

Re: [Qemu-devel] [RESEND][PATCH 2/2 v3] deal with guest panicked event

2012-03-09 Thread Marcelo Tosatti
On Thu, Mar 08, 2012 at 11:56:56AM +, Daniel P. Berrange wrote: > On Thu, Mar 08, 2012 at 01:52:45PM +0200, Avi Kivity wrote: > > On 03/08/2012 01:36 PM, Daniel P. Berrange wrote: > > > On Thu, Mar 08, 2012 at 01:28:56PM +0200, Avi Kivity wrote: > > > > On 03/08/2012 12:15 PM, Wen Congyang wrot

Re: [Qemu-devel] [RFC PATCH 14/17] block: support FALLOC_FL_PUNCH_HOLE trimming

2012-03-09 Thread Richard Laager
I was just working on this as well, though your implementation is *far* more complete than mine. (I was only looking at making changes to the discard implementation in block/raw-posix.c.) I've got several comments, which I've separated by logical topic... BLKDISCARD fallocate(

Re: [Qemu-devel] [libvirt] Modern CPU models cannot be used with libvirt

2012-03-09 Thread Anthony Liguori
On 03/09/2012 03:04 PM, Daniel P. Berrange wrote: On Fri, Mar 09, 2012 at 05:56:52PM -0300, Eduardo Habkost wrote: Resurrecting an old thread: I didn't see any clear conclusion in this thread (this is why I am resurrecting it), except that many were arguing that libvirt should simply copy and/o

Re: [Qemu-devel] [libvirt] Modern CPU models cannot be used with libvirt

2012-03-09 Thread Daniel P. Berrange
On Fri, Mar 09, 2012 at 05:56:52PM -0300, Eduardo Habkost wrote: > Resurrecting an old thread: > > I didn't see any clear conclusion in this thread (this is why I am > resurrecting it), except that many were arguing that libvirt should > simply copy and/or generate the CPU model definitions from Q

Re: [Qemu-devel] [libvirt] Modern CPU models cannot be used with libvirt

2012-03-09 Thread Eduardo Habkost
Resurrecting an old thread: I didn't see any clear conclusion in this thread (this is why I am resurrecting it), except that many were arguing that libvirt should simply copy and/or generate the CPU model definitions from Qemu. I really don't think it's reasonable to expect that. On Thu, Dec 15,

[Qemu-devel] [PATCH 3/3] qapi-schema.json: fix comment for type ObjectPropretyInfo

2012-03-09 Thread Luiz Capitulino
From: Alon Levy Signed-off-by: Alon Levy Signed-off-by: Luiz Capitulino --- qapi-schema.json |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index 93ee2a4..dd9e0e5 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -1256,7 +1256,7

[Qemu-devel] [PATCH 1/3] qjson.h: include compiler.h for GCC_FMT_ATTR

2012-03-09 Thread Luiz Capitulino
From: Alon Levy Signed-off-by: Alon Levy Signed-off-by: Luiz Capitulino --- qjson.h |1 + 1 file changed, 1 insertion(+) diff --git a/qjson.h b/qjson.h index 65b10ea..1190d8a 100644 --- a/qjson.h +++ b/qjson.h @@ -15,6 +15,7 @@ #define QJSON_H #include +#include "compiler.h" #includ

[Qemu-devel] [PATCH 2/3] qapi-schema: fix typos and explain 'spice' auth

2012-03-09 Thread Luiz Capitulino
From: Alon Levy Signed-off-by: Alon Levy Signed-off-by: Luiz Capitulino --- qapi-schema.json | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 5f293c4..93ee2a4 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -

[Qemu-devel] [PULL 0/3]: QMP queue

2012-03-09 Thread Luiz Capitulino
A few small fixes from Alon. The changes (since dac6b1b22cbad29ca34735a1e56c9feb9586e3c0) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Alon Levy (3): qjson.h: include compiler.h for GCC_FMT_ATTR qapi-schema: fix typos and explain 'sp

Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-03-09 Thread Jan Kiszka
On 2012-03-09 20:09, Liu, Jinsong wrote: > Jan Kiszka wrote: >> On 2012-03-09 19:27, Liu, Jinsong wrote: >>> Jan Kiszka wrote: On 2012-03-06 08:49, Liu, Jinsong wrote: > Jan, > > Any comments? I feel some confused about your point 'disable cpuid > feature for older machine type

Re: [Qemu-devel] [PATCH 0/2] Two small QOM fixes

2012-03-09 Thread Paolo Bonzini
Il 28/02/2012 09:54, Paolo Bonzini ha scritto: > Two fixes for bugs that were reported on the list. > > Paolo Bonzini (2): > qdev: accept empty string properties > qom: fix device hot-unplug > > hw/qdev-properties.c |4 > qom/object.c |7 ++- > 2 files changed, 2 ins

Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors

2012-03-09 Thread Luiz Capitulino
On Fri, 9 Mar 2012 16:48:10 -0300 Luiz Capitulino wrote: > > It's certainly possible to make the synchronous monitor command spit out > > status > > as it already uses a polling loop to determine when migration completes. > > As HMP now uses QMP as a real client, we'd have to make that informa

Re: [Qemu-devel] [PATCH] kvm: add flightrecorder script

2012-03-09 Thread Anthony Liguori
On 03/09/2012 08:13 AM, Stefan Hajnoczi wrote: The kvm kernel module includes a number of trace events which can be useful when debugging system behavior. Even on production systems these trace events can be used to observe guest behavior and identify the source of problems. The kvm_flightrecor

Re: [Qemu-devel] [PATCH v3] VMXNET3 paravirtual NIC device implementation

2012-03-09 Thread Anthony Liguori
On 03/07/2012 09:38 AM, Dmitry Fleytman wrote: Implementation of VMWare VMXNET3 paravirtual NIC device. Supports of all the device features including offload capabilties, VLANs and etc. The device is tested on different OSes: Fedora 15 Ubuntu 10.4 Centos 6.2

Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors

2012-03-09 Thread Eric Blake
On 03/09/2012 12:42 PM, Eric Blake wrote: > On 03/09/2012 11:53 AM, Anthony Liguori wrote: Could we just remove block migration entirely... >>> >>> Libvirt has already exposed block migration to users, >> >> :-( >> >> Do you rely on the progress stats that are printed? > > I've never per

Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors

2012-03-09 Thread Luiz Capitulino
On Fri, 09 Mar 2012 13:12:43 -0600 Anthony Liguori wrote: > On 03/09/2012 01:05 PM, Jan Kiszka wrote: > > On 2012-03-09 19:30, Luiz Capitulino wrote: > >> On Fri, 09 Mar 2012 19:20:56 +0100 > >> Jan Kiszka wrote: > >> > >>> On 2012-03-09 19:13, Luiz Capitulino wrote: > The Monitor object is

Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors

2012-03-09 Thread Eric Blake
On 03/09/2012 11:53 AM, Anthony Liguori wrote: >>> >>> Could we just remove block migration entirely... >> >> Libvirt has already exposed block migration to users, > > :-( > > Do you rely on the progress stats that are printed? I've never personally used it (as I said earlier, the libvirt suppor

Re: [Qemu-devel] [PATCH v2 2/3] make check: Add qemu-iotests subset

2012-03-09 Thread Anthony Liguori
On 03/09/2012 06:46 AM, Kevin Wolf wrote: Run the 'quick' group from qemu-iotests during 'make check'. Signed-off-by: Kevin Wolf --- tests/Makefile |5 + tests/qemu-iotests-quick.sh | 17 + 2 files changed, 22 insertions(+), 0 deletions(-) create mode

Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-03-09 Thread Liu, Jinsong
Liu, Jinsong wrote: > Jan Kiszka wrote: >> On 2012-03-06 08:49, Liu, Jinsong wrote: >>> Jan, >>> >>> Any comments? I feel some confused about your point 'disable cpuid >>> feature for older machine types by default': are you planning a >>> common approach for this common issue, or, you just ask me

Re: [Qemu-devel] [PATCH 1/2] QEmu: support disk filenames with comma

2012-03-09 Thread Anthony Liguori
On 03/09/2012 10:02 AM, Crístian Viana wrote: If there is a disk file with a comma in the name, QEmu expects a double comma instead of a single one (e.g., the file "virtual,disk.img" needs to be specified as "virtual,,disk.img" in QEmu's command line). This patch fixes libvirt to work with that f

Re: [Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7

2012-03-09 Thread Anthony Liguori
On 03/02/2012 09:49 AM, Hans de Goede wrote: VCARD_ATR_PREFIX is used as part of an array initializer so it should not have () around it, so far this happened to work, but gcc-4.7 does not like it. Signed-off-by: Hans de Goede Applied. Thanks. Regards, Anthony Liguori --- libcacard/vcar

Re: [Qemu-devel] [PATCH] arm highbank: force ramsize to INT_MAX when loading

2012-03-09 Thread Alexander Graf
On 09.03.2012, at 20:03, Andreas Färber wrote: > Am 09.03.2012 19:22, schrieb Alexander Graf: >> >> On 09.03.2012, at 17:40, Mark Langsdorf wrote: >> >>> On 03/09/2012 10:13 AM, Peter Maydell wrote: On 9 March 2012 15:57, Mark Langsdorf wrote: > Since the ram_size field of arm_boot_in

[Qemu-devel] [PATCH] initialize CPU model list after handling -readconfig options

2012-03-09 Thread Eduardo Habkost
To properly load cpudefs using -readconfig, we have to call cpudef_init() after finishing the command-line option handling. Consequently, the handling of "-cpu ?" has to be done after the command-line option handling loop, too. Without this patch, "-readconfig configfile -cpu ?" fails to list the

Re: [Qemu-devel] [PULL v2 00/11] Trivial patches for 25 February to 7 March 2012

2012-03-09 Thread Anthony Liguori
On 03/08/2012 09:37 AM, Stefan Hajnoczi wrote: There were two hickups which caused me to respin this. v2: * Drop ppc patch which Alexander Graf already has in his queue with his Signed-off-by: * Drop vnc bitfield to bool patch which triggers a compiler warning on some gccs The following c

Re: [Qemu-devel] [PATCH 0/5] [PULL] qemu-kvm.git uq/master queue

2012-03-09 Thread Anthony Liguori
On 03/08/2012 06:49 AM, Marcelo Tosatti wrote: The following changes since commit e32605062cd62c2a958ad28a6ad7de4eeab12027: xilinx_zynq: machine model initial version (2012-03-07 02:20:19 +0100) Pulled. Thanks. Regards, Anthony Liguori are available in the git repository at: git://

Re: [Qemu-devel] [PULL 00/20] usb patch queue

2012-03-09 Thread Anthony Liguori
On 03/07/2012 07:05 AM, Gerd Hoffmann wrote: Hi, Here comes the next usb update. It carries a bunch of ehci fixes and adds pipelining for usb packets. Pulled. Thanks. Regards, Anthony Liguori please pull, Gerd Gerd Hoffmann (7): uhci_fill_queue: zap debug printf usb: queue

Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors

2012-03-09 Thread Anthony Liguori
On 03/09/2012 01:05 PM, Jan Kiszka wrote: On 2012-03-09 19:30, Luiz Capitulino wrote: On Fri, 09 Mar 2012 19:20:56 +0100 Jan Kiszka wrote: On 2012-03-09 19:13, Luiz Capitulino wrote: The Monitor object is passed back and forth within the migration/savevm code so that it can print errors and

Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-03-09 Thread Liu, Jinsong
Jan Kiszka wrote: > On 2012-03-09 19:27, Liu, Jinsong wrote: >> Jan Kiszka wrote: >>> On 2012-03-06 08:49, Liu, Jinsong wrote: Jan, Any comments? I feel some confused about your point 'disable cpuid feature for older machine types by default': are you planning a common app

Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors

2012-03-09 Thread Jan Kiszka
On 2012-03-09 19:30, Luiz Capitulino wrote: > On Fri, 09 Mar 2012 19:20:56 +0100 > Jan Kiszka wrote: > >> On 2012-03-09 19:13, Luiz Capitulino wrote: >>> The Monitor object is passed back and forth within the migration/savevm >>> code so that it can print errors and progress to the user. >>> >>>

Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys

2012-03-09 Thread Alexander Graf
On 09.03.2012, at 19:47, Andreas Färber wrote: > Am 09.03.2012 18:11, schrieb Peter Maydell: >> On 9 March 2012 14:28, Andreas Färber wrote: >>> No, please. We're describing sizes, not addresses. target_phys_addr_t >>> thus is semantically wrong here. The RAM size is unsigned long IIRC (it >>> i

Re: [Qemu-devel] [PATCH] arm highbank: force ramsize to INT_MAX when loading

2012-03-09 Thread Andreas Färber
Am 09.03.2012 19:22, schrieb Alexander Graf: > > On 09.03.2012, at 17:40, Mark Langsdorf wrote: > >> On 03/09/2012 10:13 AM, Peter Maydell wrote: >>> On 9 March 2012 15:57, Mark Langsdorf wrote: Since the ram_size field of arm_boot_info is only an int, don't set that field to more than

Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors

2012-03-09 Thread Jan Kiszka
On 2012-03-09 19:31, Anthony Liguori wrote: > On 03/09/2012 12:20 PM, Jan Kiszka wrote: >> On 2012-03-09 19:13, Luiz Capitulino wrote: >>> The Monitor object is passed back and forth within the migration/savevm >>> code so that it can print errors and progress to the user. >>> >>> However, that app

Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-03-09 Thread Jan Kiszka
On 2012-03-09 19:27, Liu, Jinsong wrote: > Jan Kiszka wrote: >> On 2012-03-06 08:49, Liu, Jinsong wrote: >>> Jan, >>> >>> Any comments? I feel some confused about your point 'disable cpuid >>> feature for older machine types by default': are you planning a >>> common approach for this common issue,

Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors

2012-03-09 Thread Anthony Liguori
On 03/09/2012 12:45 PM, Eric Blake wrote: On 03/09/2012 11:31 AM, Anthony Liguori wrote: On 03/09/2012 12:20 PM, Jan Kiszka wrote: On 2012-03-09 19:13, Luiz Capitulino wrote: The Monitor object is passed back and forth within the migration/savevm code so that it can print errors and progress t

Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys

2012-03-09 Thread Andreas Färber
Am 09.03.2012 18:11, schrieb Peter Maydell: > On 9 March 2012 14:28, Andreas Färber wrote: >> No, please. We're describing sizes, not addresses. target_phys_addr_t >> thus is semantically wrong here. The RAM size is unsigned long IIRC (it >> is limited by the host's available memory). If you subtr

Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors

2012-03-09 Thread Eric Blake
On 03/09/2012 11:31 AM, Anthony Liguori wrote: > On 03/09/2012 12:20 PM, Jan Kiszka wrote: >> On 2012-03-09 19:13, Luiz Capitulino wrote: >>> The Monitor object is passed back and forth within the migration/savevm >>> code so that it can print errors and progress to the user. >>> >>> However, that

Re: [Qemu-devel] [PATCH 4/4] qapi: Convert migrate

2012-03-09 Thread Luiz Capitulino
On Fri, 09 Mar 2012 12:35:32 -0600 Anthony Liguori wrote: > >> +## > >> +# @migrate > >> +# > >> +# Migrates the current running guest to another Virtual Machine. > >> +# > >> +# @uri: the Uniform Resource Identifier of the destination VM > >> +# > >> +# @blk: #optional do block migration (full d

Re: [Qemu-devel] [PATCH 4/4] qapi: Convert migrate

2012-03-09 Thread Anthony Liguori
On 03/09/2012 12:26 PM, Eric Blake wrote: On 03/09/2012 11:13 AM, Luiz Capitulino wrote: The migrate command is one of those commands where HMP and QMP completely mix up together. This made the conversion to the QAPI (which separates the command into QMP and HMP parts) a bit difficult. The firs

Re: [Qemu-devel] [PATCH 4/4] qapi: Convert migrate

2012-03-09 Thread Luiz Capitulino
On Fri, 09 Mar 2012 11:26:53 -0700 Eric Blake wrote: > On 03/09/2012 11:13 AM, Luiz Capitulino wrote: > > The migrate command is one of those commands where HMP and QMP completely > > mix up together. This made the conversion to the QAPI (which separates the > > command into QMP and HMP parts) a

Re: [Qemu-devel] [PATCH] PPC: Fix large page support in TCG

2012-03-09 Thread Alexander Graf
On 09.03.2012, at 15:30, Nathan Whitehorn wrote: > On 03/09/12 07:13, Alexander Graf wrote: >> On 09.03.2012, at 04:42, David Gibson wrote: >> >>> On Thu, Mar 08, 2012 at 09:24:53AM -0600, Nathan Whitehorn wrote: On Mar 7, 2012, at 7:25 PM, David Gibson wrote: > On Sat, Mar 03, 20

Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors

2012-03-09 Thread Anthony Liguori
On 03/09/2012 12:20 PM, Jan Kiszka wrote: On 2012-03-09 19:13, Luiz Capitulino wrote: The Monitor object is passed back and forth within the migration/savevm code so that it can print errors and progress to the user. However, that approach assumes a HMP monitor, being completely invalid in QMP.

Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors

2012-03-09 Thread Luiz Capitulino
On Fri, 09 Mar 2012 19:20:56 +0100 Jan Kiszka wrote: > On 2012-03-09 19:13, Luiz Capitulino wrote: > > The Monitor object is passed back and forth within the migration/savevm > > code so that it can print errors and progress to the user. > > > > However, that approach assumes a HMP monitor, bein

Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-03-09 Thread Liu, Jinsong
Jan Kiszka wrote: > On 2012-03-06 08:49, Liu, Jinsong wrote: >> Jan, >> >> Any comments? I feel some confused about your point 'disable cpuid >> feature for older machine types by default': are you planning a >> common approach for this common issue, or, you just ask me a >> specific solution for

[Qemu-devel] [PATCH 4/4] qapi: Convert migrate

2012-03-09 Thread Luiz Capitulino
The migrate command is one of those commands where HMP and QMP completely mix up together. This made the conversion to the QAPI (which separates the command into QMP and HMP parts) a bit difficult. The first important change to be noticed is that this commit completes the removal of the Monitor ob

Re: [Qemu-devel] [PATCH 4/4] qapi: Convert migrate

2012-03-09 Thread Eric Blake
On 03/09/2012 11:13 AM, Luiz Capitulino wrote: > The migrate command is one of those commands where HMP and QMP completely > mix up together. This made the conversion to the QAPI (which separates the > command into QMP and HMP parts) a bit difficult. > > The first important change to be noticed is

Re: [Qemu-devel] QEmu: support disk filenames with comma

2012-03-09 Thread Crístian Viana
On 09-03-2012 14:27, Eric Blake wrote: > For starters, you mailed the qemu list. This patch should be sent > instead to libvir-l...@redhat.com, so that it will actually reach the > libvirt folks. > Oh, sorry, wrong list :-) I'll mail the right one then. Thanks!

Re: [Qemu-devel] [PATCH] arm highbank: force ramsize to INT_MAX when loading

2012-03-09 Thread Alexander Graf
On 09.03.2012, at 17:40, Mark Langsdorf wrote: > On 03/09/2012 10:13 AM, Peter Maydell wrote: >> On 9 March 2012 15:57, Mark Langsdorf wrote: >>> Since the ram_size field of arm_boot_info is only an int, don't set >>> that field to more than INT_MAX. Signed vs unsigned comparison >>> overruns ar

Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors

2012-03-09 Thread Jan Kiszka
On 2012-03-09 19:13, Luiz Capitulino wrote: > The Monitor object is passed back and forth within the migration/savevm > code so that it can print errors and progress to the user. > > However, that approach assumes a HMP monitor, being completely invalid > in QMP. > > This commit drops almost ever

[Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors

2012-03-09 Thread Luiz Capitulino
The Monitor object is passed back and forth within the migration/savevm code so that it can print errors and progress to the user. However, that approach assumes a HMP monitor, being completely invalid in QMP. This commit drops almost every single usage of the Monitor object, all monitor_printf()

[Qemu-devel] [PATCH 2/4] Error: Introduce error_copy()

2012-03-09 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- error.c | 13 + error.h |5 + 2 files changed, 18 insertions(+) diff --git a/error.c b/error.c index 990050f..d3455ab 100644 --- a/error.c +++ b/error.c @@ -43,6 +43,19 @@ void error_set(Error **errp, const char *fmt, ...) *errp = err

  1   2   3   >