Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event

2012-02-22 Thread Markus Armbruster
Kevin Wolf writes: > Am 17.02.2012 20:21, schrieb Luiz Capitulino: >> It's emitted whenever the tray is moved by the guest or by HMP/QMP >> commands. >> >> Signed-off-by: Luiz Capitulino >> --- >> QMP/qmp-events.txt | 18 ++ >> block.c| 24 ++

Re: [Qemu-devel] [PATCH v2 0/4] RTC: New logic to emulate RTC

2012-02-22 Thread Paolo Bonzini
On 02/23/2012 02:49 AM, Zhang, Yang Z wrote: >> Currently they hang very early because UF is not set. I >> attempted to fix that, but ran into other problems. UIP seems >> not to be really in sync with the update interrupt, because the >> 500 ms update tests pass when testing UIP, but not when te

Re: [Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev

2012-02-22 Thread Paolo Bonzini
On 02/23/2012 08:19 AM, Paolo Bonzini wrote: >> > Signed-off-by: Federico Simoncelli > What is the usecase, and how can this be tested? Oops, you explained it in part 0. > Step 5 - Final Switch to Destination > > VM1 is now able to switch to the destination f

Re: [Qemu-devel] [PATCH][v14] megasas: LSI Megaraid SAS HBA emulation

2012-02-22 Thread Gerhard Wiesinger
Tested-by: Gerhard Wiesinger Ciao, Gerhard -- http://www.wiesinger.com/ On Thu, 23 Feb 2012, Andreas Färber wrote: Am 23.02.2012 08:03, schrieb Gerhard Wiesinger: Ping? On Tue, 21 Feb 2012, Gerhard Wiesinger wrote: Can confirm that all issues are fixed now and v14 is ready for commit :

Re: [Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev

2012-02-22 Thread Paolo Bonzini
On 02/22/2012 06:13 PM, Federico Simoncelli wrote: > Signed-off-by: Federico Simoncelli What is the usecase, and how can this be tested? Paolo

Re: [Qemu-devel] [PATCH 2/3] Update the blkmirror block driver

2012-02-22 Thread Paolo Bonzini
On 02/22/2012 06:13 PM, Federico Simoncelli wrote: > @@ -46,7 +46,7 @@ static int blkmirror_open(BlockDriverState *bs, const char > *filename, int flags) > filename += strlen("blkmirror:"); > > /* Parse the raw image filename */ > -filename2 = qemu_malloc(strlen(filename)+1); > +

Re: [Qemu-devel] [PATCH][v14] megasas: LSI Megaraid SAS HBA emulation

2012-02-22 Thread Andreas Färber
Am 23.02.2012 08:03, schrieb Gerhard Wiesinger: > Ping? > On Tue, 21 Feb 2012, Gerhard Wiesinger wrote: > >> Can confirm that all issues are fixed now and v14 is ready for commit :-) A formal Tested-by may help. :) Andreas >> On Tue, 21 Feb 2012, Hannes Reinecke wrote: >> >>> This patch adds a

Re: [Qemu-devel] [PATCH][v14] megasas: LSI Megaraid SAS HBA emulation

2012-02-22 Thread Alexander Graf
On 21.02.2012, at 10:36, Hannes Reinecke wrote: > This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA. > I've tested it to work with Linux, Windows Vista, and Windows7. > MSI-X support is currently broken; have to investigate. > > Changes since v13: > - Remove separate MSI-X BAR >

Re: [Qemu-devel] [PATCH] Makefile vgabios.c: Add filename to VGA splash screen

2012-02-22 Thread Gerhard Wiesinger
Any comments? Ciao, Gerhard -- http://www.wiesinger.com/ On Fri, 17 Feb 2012, Gerhard Wiesinger wrote: Filename is now displayed at VGA splash screen to see which BIOS on different VGAs will be used. Signed-off-by: Gerhard Wiesinger --- Makefile |2 +- vgabios.c |3 +++ 2 files chan

[Qemu-devel] [Bug 921208] Re: win7/x64 installer hangs on startup with 0x0000005d.

2012-02-22 Thread Alexandre Derumier
I could you try with "-cpu host,level=2" I see you have a westmere cpu, and maybe this is related: I'm developper on the proxmox distribution. We are using kvm git, and one of our user can't boot guest win7x64 with -cpu host. (but it's working with linux guest). It's working fine with -cpu ho

Re: [Qemu-devel] [PATCH v2 0/4] RTC: New logic to emulate RTC

2012-02-22 Thread Paolo Bonzini
On 02/23/2012 02:49 AM, Zhang, Yang Z wrote: >> > 6) Setting the clock after 500 ms happens not on every set, but only when >> > moving >> > out of divider reset (register A bits 5-7 moving from 110 or 111 to 010). >> > As far as >> > I can read, SET prevents the registers from changing value, b

[Qemu-devel] Westmere cpu : guest win7 x64 doesn't boot with -cpu host (cpu level problem)

2012-02-22 Thread Alexandre DERUMIER
Hi, I'm developper on the proxmox distribution. We are using kvm git, and one of our user can't boot guest win7x64 with -cpu host. (but it's working with linux guest). It's working fine with -cpu host,level=9 but not with -cpu host,level=10 or level=11. We also try with new Westermere cpudefs

[Qemu-devel] Westmere cpu : guest win7 x64 doesn't boot with -cpu host (cpu level problem)

2012-02-22 Thread Alexandre DERUMIER
Hi, I'm developper on the proxmox distribution. We are using kvm git, and one of our user can't boot guest win7x64 with -cpu host. (but it's working with linux guest). It's working fine with -cpu host,level=9 but not with -cpu host,level=10 or level=11. We also try with new Westermere cpudefs

Re: [Qemu-devel] arm-linux-user, i386-linux-user: Make QEMU act as TCG compiler

2012-02-22 Thread 陳韋任
Hi Rajat, Great work! It seems this is a kind of like static compilation, right? I think people are more interested in using QEMU as a dynamic translator as a library. Would you mind to tell me what scenario your work aims to? Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Instit

Re: [Qemu-devel] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

2012-02-22 Thread 陳韋任
> ...which Peter has already done: > > http://patchwork.ozlabs.org/patch/142306/ > > Please coordinate with him. O.K., I already told Stefan to ignore my patch. :) Thanks! Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (

Re: [Qemu-devel] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

2012-02-22 Thread 陳韋任
Hi Stefan, Peter already fix this issue [1]. Please ignore my patch, thanks! Regards, chenwj [1] http://patchwork.ozlabs.org/patch/142306/ -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http:/

[Qemu-devel] Cluster_size parameter issue on qcow2 image format

2012-02-22 Thread PANKAJ RAWAT
Hi all I have been working o the qcow2 image format , I theory regarding cluster size it is written that as the size of cluster increase performance should increase. But something surprising happen The performance is degrading as the size of cluster increased from 64K to 1M ( during expansio

Re: [Qemu-devel] FLR capability hidden in VF config space

2012-02-22 Thread rukhsana ansari
Hello, Was wondering whether someone could shed some light on the issue below. Without FLR exposed in the VF, VF reset via FLR cannot be initiated from the guest. Appreciate any pointers. Thanks, Rukhsana On Wed, Feb 15, 2012 at 2:54 PM, rukhsana ansari wrote: > Hi, > > The following code snippe

[Qemu-devel] [PATCH v7 3/4] cadence_gem: initial version of device model

2012-02-22 Thread Peter A. G. Crosthwaite
Device model for cadence gem ethernet controller. Signed-off-by: Peter A. G. Crosthwaite Signed-off-by: John Linn Acked-by: Edgar E. Iglesias --- changed from v6: renamed qemu_debug() -> DB_PRINT changed from v4: changed device_init -> type_init changes from v1: removed global init function mar

[Qemu-devel] [PATCH v7 4/4] xilinx_zynq: machine model initial version

2012-02-22 Thread Peter A. G. Crosthwaite
Xilinx zynq-7000 machine model. Also includes device model for the zynq-specific system level control register (SLCR) module. Signed-off-by: Peter A. G. Crosthwaite Acked-by: Edgar E. Iglesias --- changed from v6: renamed qemu_debug() -> DB_PRINT changed from v5: removed usages of arm_boot_info-

[Qemu-devel] [PATCH v7 2/4] cadence_ttc: initial version of device model

2012-02-22 Thread Peter A. G. Crosthwaite
Implemented cadence Triple Timer Counter (TCC) Signed-off-by: Peter A. G. Crosthwaite Signed-off-by: John Linn Acked-by: Edgar E. Iglesias --- changed from v6: renamed cadence_ttc_state -> CadenceTTCState renamed qemu_debug() -> DB_PRINT (all) added reset function changed from v4: fixed FSF add

[Qemu-devel] [PATCH v7 1/4] cadence_uart: initial version of device model

2012-02-22 Thread Peter A. G. Crosthwaite
Implemented cadence UART serial controller Signed-off-by: Peter A. G. Crosthwaite Signed-off-by: John Linn Acked-by: Edgar E. Iglesias --- changed from v6: removed automatic interrupt clearing removed mask_and_right_justify removed redundant stop_break logic made tx and rx function interfaces c

[Qemu-devel] [PATCH v7 0/4] Zynq-7000 EPP platform model

2012-02-22 Thread Peter A. G. Crosthwaite
This is a suite of Device models and a machine model for the Xilinx Zynq-7000 Extensible Processing Platform: http://www.xilinx.com/products/silicon-devices/epp/zynq-7000/index.htm This is an ARM based platform featuring embedded SoC peripherals. This patch series includes a minimal set of devi

Re: [Qemu-devel] [PATCH v2 0/4] RTC: New logic to emulate RTC

2012-02-22 Thread Zhang, Yang Z
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Wednesday, February 22, 2012 7:19 PM > > 0) My alarm tests failed quite badly. :( I attach a patch for kvm-unit-tests > (repository at git://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git). > The tests can

Re: [Qemu-devel] [PATCH v6 2/4] cadence_ttc: initial version of device model

2012-02-22 Thread Peter Crosthwaite
On Tue, Feb 21, 2012 at 5:32 AM, Peter Maydell wrote: > On 20 February 2012 01:45, Peter A. G. Crosthwaite > wrote: >> Implemented cadence Triple Timer Counter (TCC) >> >> Signed-off-by: Peter A. G. Crosthwaite >> Signed-off-by: John Linn >> --- >> changed from v4: >> fixed FSF addess >> change

Re: [Qemu-devel] [PATCH v6 1/4] cadence_uart: initial version of device model

2012-02-22 Thread Peter Crosthwaite
On Tue, Feb 21, 2012 at 4:58 AM, Peter Maydell wrote: > On 20 February 2012 01:45, Peter A. G. Crosthwaite > wrote: >> Implemented cadence UART serial controller > > Is there any publicly available documentation for this? Google > only found a minimum-info datasheet... No, Silicon vendor still h

Re: [Qemu-devel] [PATCH v6 2/4] cadence_ttc: initial version of device model

2012-02-22 Thread Peter Crosthwaite
On Tue, Feb 21, 2012 at 11:04 PM, Paul Brook wrote: >> > +static inline int64_t is_between(int64_t x, int64_t a, int64_t b) >> > +{ >> > +    if (a < b) { >> > +        return x > a && x <= b; >> > +    } >> > +    return x < a && x >= b; >> > +} >> >> This looks slightly odd -- should the boundar

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Alexander Graf
On 22.02.2012, at 17:09, Peter Maydell wrote: > On 22 February 2012 16:04, Andreas Färber wrote: >> Am 22.02.2012 16:42, schrieb Peter Maydell: >>> On 22 February 2012 15:37, Andreas Färber wrote: NB: Your cpu-vmstate patches were not applied so far and they appear to conflict with th

Re: [Qemu-devel] Implementing new serial virtual HW w/ redirection

2012-02-22 Thread Emmanuel Blot
On Tue, Feb 21, 2012 at 7:58 AM, Markus Armbruster wrote: >> Any advice would be greatly appreciated, > Hope this helps. Yes, definitely. It works fine, thanks a lot. Now I need to understand why the *qdev.init function is called twice, but it's another issue. Thanks again for your help, Emman

Re: [Qemu-devel] [PATCH 0/2] linux-user: Support prctl PR_GET/SET_NAME

2012-02-22 Thread Peter Maydell
Ping? On 3 February 2012 13:53, Peter Maydell wrote: > These patches add support for the prctl options PR_GET_NAME > and PR_SET_NAME. In particular, perl 5.14 will use PR_SET_NAME > if you change the value of $0, which means that adduser will > fail if run under qemu with a sufficiently modern pe

[Qemu-devel] [PATCH] vl.c: Avoid segfault when started with no arguments

2012-02-22 Thread Peter Maydell
Fix a bug (introduced in commit a0abe47) where a command line which specified no machine arguments (either explicitly or implicitly via -kernel &co) would result in a segfault because of a NULL pointer returned from qemu_opts_find(qemu_find_opts("machine"), 0). Signed-off-by: Peter Maydell --- Oo

[Qemu-devel] [PATCH] vl.c: Increase width of machine name column in "-M ?" output

2012-02-22 Thread Peter Maydell
Increase the width of the column used for the machine name in the "-M ?" output from 10 to 20 spaces. This fixes the formatting so it looks nice for architectures where a few of the machines have overly long names. (Our current longest machine name is "petalogix-s3adsp1800" with "realview-eb-mpcore

[Qemu-devel] [PATCH v5 8/9] qxl: introduce QXLCookie

2012-02-22 Thread Alon Levy
Will be used in the next patch. Signed-off-by: Alon Levy --- hw/qxl-render.c|2 +- hw/qxl.c | 59 +++ hw/qxl.h |2 +- ui/spice-display.c | 22 -- ui/spice-display.h | 14 5 files ch

[Qemu-devel] [PATCH v5 7/9] qxl: remove flipped

2012-02-22 Thread Alon Levy
Tested on linux and windows guests. For negative stride, qxl_flip copies directly to vga->ds->surface->data, for positive it's reallocated to share qxl->guest_primary.data Signed-off-by: Alon Levy --- hw/qxl-render.c | 66 +-- hw/qxl.h

[Qemu-devel] [PATCH v5 5/9] qxl: drop qxl_spice_update_area_async definition

2012-02-22 Thread Alon Levy
It was never used. Introduced in 5ff4e36c804157bd84af43c139f8cd3a59722db9 qxl: async io support using new spice api But not used even then. Signed-off-by: Alon Levy --- hw/qxl.h |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/hw/qxl.h b/hw/qxl.h index d062991..a615

[Qemu-devel] [PATCH v5 2/9] vga: stop after the first ppm_save

2012-02-22 Thread Alon Levy
From: Gerd Hoffman Tested-by: Alon Levy --- hw/vga.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/vga.c b/hw/vga.c index c1029db..a728f29 100644 --- a/hw/vga.c +++ b/hw/vga.c @@ -2369,6 +2369,7 @@ static void vga_save_dpy_update(DisplayState *ds, { if (scree

[Qemu-devel] [PATCH v5 6/9] qxl: require spice >= 0.8.2

2012-02-22 Thread Alon Levy
drop all ifdefs on SPICE_INTERFACE_QXL_MINOR >= 1 as a result, any check for SPICE_SERVER_VERSION that is now always satisfied, and SPICE_INTERFACE_CORE_MINOR >= 3 tests, because 0.8.2 has SPICE_INTERFACE_QXL_MINOR == 1 and SPICE_INTERFACE_CORE_MINOR == 3. Signed-off-by: Alon Levy --- configure

[Qemu-devel] [PATCH v5 9/9] qxl: make qxl_render_update async

2012-02-22 Thread Alon Levy
RHBZ# 747011 Removes the last user of QXL_SYNC when using update drivers that use the _ASYNC io ports. The last user is qxl_render_update, it is called both by qxl_hw_update which is the vga_hw_update_ptr passed to graphic_console_init, and by qxl_hw_screen_dump. At the same time the QXLRect are

[Qemu-devel] [PATCH v5 4/9] sdl: remove NULL check, g_malloc0 can't fail

2012-02-22 Thread Alon Levy
Signed-off-by: Alon Levy --- ui/sdl.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index 6f8091c..f6f711c 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -167,10 +167,6 @@ static PixelFormat sdl_to_qemu_pixelformat(SDL_PixelFormat *sdl_pf) static Displ

[Qemu-devel] [PATCH v5 3/9] console: don't call console_select unnecessarily

2012-02-22 Thread Alon Levy
From: Gerd Hoffman Tested-by: Alon Levy --- console.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/console.c b/console.c index 135394f..cfcc2f7 100644 --- a/console.c +++ b/console.c @@ -181,12 +181,14 @@ void vga_hw_screen_dump(const char *filename) /* T

[Qemu-devel] [PATCH v5 1/9] qxl: fix spice+sdl no cursor regression

2012-02-22 Thread Alon Levy
regression introduced by 075360945860ad9bdd491921954b383bf762b0e5, v2: lock around qemu_spice_cursor_refresh_unlocked Reported-by: Fabiano Fidêncio Signed-off-by: Alon Levy --- hw/qxl.c |4 ui/spice-display.c | 23 ++- ui/spice-display.h |1 + 3 fil

[Qemu-devel] [PATCH v5 0/9] qxl: fix hangs caused by qxl_render_update

2012-02-22 Thread Alon Levy
v4->v5: added patches, not related but just not to forget: qxl: fix spice+sdl no cursor regression - fixes an issue discovered by Fabiano Fidêncio, he confirms this fix performs the same as reverting 075360945860ad9bdd491921954b383bf762b0e5 . vga: stop after the first ppm_save - sin

Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Luiz Capitulino
On Wed, 22 Feb 2012 14:31:17 -0600 Anthony Liguori wrote: > On 02/22/2012 02:25 PM, Luiz Capitulino wrote: > > On Wed, 22 Feb 2012 11:35:26 -0600 > > Anthony Liguori wrote: > > > >> On 02/22/2012 10:12 AM, Jeff Cody wrote: > >>> On 02/22/2012 09:53 AM, Anthony Liguori wrote: > On 02/20/2012

Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Anthony Liguori
On 02/22/2012 02:25 PM, Luiz Capitulino wrote: On Wed, 22 Feb 2012 11:35:26 -0600 Anthony Liguori wrote: On 02/22/2012 10:12 AM, Jeff Cody wrote: On 02/22/2012 09:53 AM, Anthony Liguori wrote: On 02/20/2012 11:31 AM, Jeff Cody wrote: The QAPI scripts allow for generating commands that recei

Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-02-22 Thread Anthony Liguori
On 02/15/2012 07:33 AM, Markus Armbruster wrote: Anthony Liguori writes: On 02/14/2012 11:24 AM, Markus Armbruster wrote: Markus Armbruster writes: Anthony Liguori writes: [Anthony asking for error_set() instead of error_report()...] Basically, same thing here and the remaining functi

Re: [Qemu-devel] [PATCH 6/6] qmp: add balloon-get-memory-stats & event

2012-02-22 Thread Michael Roth
On Wed, Feb 22, 2012 at 05:44:37PM -0200, Luiz Capitulino wrote: > On Wed, 22 Feb 2012 10:54:45 -0600 > Michael Roth wrote: > > > But I'm not suggesting we make query-balloon asynchronous. > > > > I'm suggesting be re-enable it as a synchronous interface by having it > > immediately return the l

Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Luiz Capitulino
On Wed, 22 Feb 2012 11:35:26 -0600 Anthony Liguori wrote: > On 02/22/2012 10:12 AM, Jeff Cody wrote: > > On 02/22/2012 09:53 AM, Anthony Liguori wrote: > >> On 02/20/2012 11:31 AM, Jeff Cody wrote: > >>> The QAPI scripts allow for generating commands that receive parameter > >>> input consisting

[Qemu-devel] [Bug 938945] [NEW] Slirp cannot be forward and makes segmentation faults

2012-02-22 Thread Vincent Autefage
Public bug reported: Hi, Let's consider the following lines: $ qemu -enable-kvm -name opeth -hda debian1.img -k fr -localtime -m 512 -net user,vlan=0 -net nic,vlan=0,model=$model,macaddr=a2:00:00:00:00:10 -net socket,vlan=1,listen=127.0.0.1:5900 -net nic,vlan=1,model=$model,macaddr=a2:00:00:00:0

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-02-22 Thread Stefan Hajnoczi
On Wed, Feb 22, 2012 at 4:48 PM, Dongsu Park wrote: >> Try turning ioeventfd off for the virtio-blk device: >> >> -device virtio-blk-pci,ioeventfd=off,... >> >> You might see better performance since ramdisk I/O should be very >> low-latency.  The overhead of using ioeventfd might not make it >> w

[Qemu-devel] [PATCH] arm: add device tree support

2012-02-22 Thread Peter Maydell
From: Grant Likely If compiled with CONFIG_FDT, allow user to specify a device tree file using the -dtb argument. If the machine supports it then the dtb will be loaded into memory and passed to the kernel on boot. Signed-off-by: Jeremy Kerr Signed-off-by: Grant Likely [Peter Maydell: Use mac

[Qemu-devel] [PATCH v2] w32: Support tests (make check)

2012-02-22 Thread Stefan Weil
Adding $(EXESUF) is needed to make those tests work on w32 hosts, too. v2: Rebased, added new tests, tests sorted alphabetically. Signed-off-by: Stefan Weil --- tests/Makefile | 38 +++--- 1 files changed, 23 insertions(+), 15 deletions(-) diff --git a/tests/M

[Qemu-devel] [Bug 938937] [NEW] Slirp --> Abort when operate dhclient

2012-02-22 Thread Vincent Autefage
Public bug reported: Hi, Let's consider the following line: $ qemu -enable-kvm -name opeth -hda debian.img -k fr -localtime -m 512 -net user,vlan=0,net=192.160.0.0/24 -net nic,vlan=0,model=$model,macaddr=a2:00:00:00:00:10 In my Guest Virtual Machine, I'm going to call the internal Slirp DHCP Se

Re: [Qemu-devel] [PATCH 6/6] qmp: add balloon-get-memory-stats & event

2012-02-22 Thread Luiz Capitulino
On Wed, 22 Feb 2012 10:54:45 -0600 Michael Roth wrote: > But I'm not suggesting we make query-balloon asynchronous. > > I'm suggesting be re-enable it as a synchronous interface by having it > immediately return the latest-available results from a timer-driven > query mechanism that tucks away t

Re: [Qemu-devel] [PATCH v2] arm: add device tree support

2012-02-22 Thread Peter Maydell
On 1 February 2012 01:10, Alexander Graf wrote: > On 01.02.2012, at 01:11, Grant Likely wrote: >> @@ -312,7 +397,6 @@ void arm_load_kernel(CPUState *env, struct arm_boot_info >> *info) >>         if (info->nb_cpus > 1) { >>             info->write_secondary_boot(env, info); >>         } >> -    

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Luiz Capitulino
On Wed, 22 Feb 2012 17:35:15 +0100 Alon Levy wrote: > On Wed, Feb 22, 2012 at 01:55:45PM -0200, Luiz Capitulino wrote: > > On Wed, 22 Feb 2012 15:29:33 +0100 > > Alon Levy wrote: > > > > > On Wed, Feb 22, 2012 at 03:22:11PM +0100, Gerd Hoffmann wrote: > > > > Hi, > > > > > > > > > Honestly,

Re: [Qemu-devel] [PATCH 2/2] build: replace librt check function

2012-02-22 Thread Anthony Liguori
On 02/20/2012 06:11 AM, Roger Pau Monne wrote: Replace clock_gettime with timer_gettime, since at least under uclibc 0.9.33 the clock_getttime function can be used without linking against librt (although the manual page states the opposite). Signed-off-by: Roger Pau Monne I don't think this is

[Qemu-devel] [PATCH 3/3] qdev: switch property accessors to fixed-width visitor interfaces

2012-02-22 Thread Michael Roth
Signed-off-by: Michael Roth --- hw/qdev-addr.c |4 ++-- hw/qdev-properties.c | 42 +- 2 files changed, 19 insertions(+), 27 deletions(-) diff --git a/hw/qdev-addr.c b/hw/qdev-addr.c index 0bb16c7..b711b6b 100644 --- a/hw/qdev-addr.c +++ b/hw/q

[Qemu-devel] Qemu Git Master on Windows (MinGW/MSYS)

2012-02-22 Thread Sebastian Huber
Hello, has someone successfully built the recent Git master version of Qemu on Windows (MinGW/MSYS)? I was able to build it and can actually run i386 programs with it. The problem is the GDB server connection. I get these error messages from my GDB client: $ i386-rtems4.11-gdb.exe test.ex

Re: [Qemu-devel] [PATCH] qom: Make object_unref() free the object's memory when refcount goes to 0.

2012-02-22 Thread Anthony Liguori
On 02/22/2012 12:00 PM, alexander_barab...@mentor.com wrote: From: Alexander Barabash In the existing implementation, object_delete() calls object_unref(), then frees the object's storage. Running object_delete() on an object with reference count different from 1 causes program failure. In the

[Qemu-devel] [PATCH 2/3] qapi: unit tests for visitor-based serialization

2012-02-22 Thread Michael Roth
Currently we test our visitors individually, and seperately for input vs. output. This is useful for validating internal representations against the native C types and vice-versa, and other visitor-specific testing, but it doesn't cover the potential use-case of using visitor pairs for serializatio

[Qemu-devel] [PATCH 1/3] qapi: add Visitor interfaces for uint*_t and int*_t

2012-02-22 Thread Michael Roth
This adds visitor interfaces for fixed-width integers types. Implementing these in visitors is optional, otherwise we fall back to visit_type_int() (int64_t) with some additional bounds checking to avoid integer overflows for cases where the value fetched exceeds the bounds of our target C type. S

[Qemu-devel] [PATCH 0/3] add fixed-width visitors and serialization tests

2012-02-22 Thread Michael Roth
These patches apply on top of qemu.git master, and can also be obtained from: git://github.com/mdroth/qemu.git visitor-fixed-width-v1 These patches add fixed-width visitor types and switches all qdev users over to them. We also add a test suite which covers these as well as does some sanity check

Re: [Qemu-devel] [RFC v4 6/9] qxl: remove flipped

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 03:09:09PM +0100, Gerd Hoffmann wrote: > On 02/22/12 13:28, Alon Levy wrote: > > On Wed, Feb 22, 2012 at 12:18:50PM +0100, Gerd Hoffmann wrote: > >> Hi, > >> > >> It's not obvious to me how the non-flipped case (qxl_stride > 0) is > >> handled now. Have you tested this wi

Re: [Qemu-devel] [PATCHv3 1/4] pci_bridge: user-friendly default bus name

2012-02-22 Thread Anthony Liguori
On 02/20/2012 04:52 PM, Michael S. Tsirkin wrote: For a pci bridge device, if we don't override the name with custom code, the bus will be addressed as .0, where id is the id specified by the user. Since PCI Bridge devices have a single bus each, we don't need the index: address the bus using th

Re: [Qemu-devel] [RFC v4 9/9] qxl-render: call ppm_save on bh

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 12:46:28PM +0100, Gerd Hoffmann wrote: > On 02/21/12 22:39, Alon Levy wrote: > > This changes the behavior of the monitor command. After the previous > > patch, there is no longer an option of deadlock with virt-manager, but > > ppm_save is called too early, before the updat

Re: [Qemu-devel] [PATCH v4 0/3] jazz-led: QOM conversion

2012-02-22 Thread Anthony Liguori
On 02/17/2012 01:27 PM, Hervé Poussineau wrote: Following patches update jazz-led emulation to current Qemu standards: - use trace framework to report events - remove usage of old_mmio API - convert to QOM Applied all. Thanks. Regards, Anthony Liguori Changes v3 -> v4: - rebased Changes

Re: [Qemu-devel] [PATCH v2 0/2] qom: add test tools (resend from "qom: dynamic properties")

2012-02-22 Thread Anthony Liguori
On 02/20/2012 04:28 PM, Michael Roth wrote: CHANGES SINCE V2: - this one actually works :) QMP_SOCKET env variable wasn't being handled properly in the last version. AFAICT the qom tool got dropped from Anthony's "qom: dynamic properties and composition tree" series due to some hardcoded

Re: [Qemu-devel] [PATCH v11 0/9] PC system flash support

2012-02-22 Thread Anthony Liguori
On 02/22/2012 01:18 AM, Jordan Justen wrote: Enable flash emulation in a PC system using pflash_cfi01. Applied all. I know it's taken a while to get these merged, but I'm very pleased with the final result. Thanks for sticking through it! Regards, Anthony Liguori v11: * Convert pc-sysf

Re: [Qemu-devel] [PATCH] qom: Fix object_initialize_with_type() assertion

2012-02-22 Thread Anthony Liguori
On 02/19/2012 05:49 PM, Andreas Färber wrote: Assert the object is at least sizeof(Object), not sizeof(ObjectClass). Signed-off-by: Andreas Färber Applied. Thanks. Regards, Anthony Liguori --- qom/object.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qom/ob

Re: [Qemu-devel] [PATCH] qom: Document ways to retrieve child object added by object_property_add_child()

2012-02-22 Thread Anthony Liguori
On 02/21/2012 04:14 AM, alexander_barab...@mentor.com wrote: From: Alexander Barabash object_property_add_child() creates a property whose values as a string is the child object's canonical path. Signed-off-by: Alexander Barabash Applied. Thanks. Regards, Anthony Liguori --- include/qe

Re: [Qemu-devel] [PATCH] pci: set memory type for memory behind the bridge

2012-02-22 Thread Anthony Liguori
On 02/21/2012 07:57 AM, Michael S. Tsirkin wrote: As we make upper bits in IO and prefetcheable memory registers writeable, we should declare support for 64 bit prefetcheable memory and 32 bit io in the bridge. This changes the default for apb, dec, but I'm guessing they got the defaults wrong b

Re: [Qemu-devel] [PATCH] pci: add accessors to get/set registers by mask

2012-02-22 Thread Anthony Liguori
On 02/21/2012 07:41 AM, Michael S. Tsirkin wrote: pci_regs.h specifies many registers by mask + shifted register values. There's always some duplication when using such: for example to override device type, we would need: pci_word_test_and_clear_mask(cap + PCI_EXP_FLAGS, PCI_EXP_FLAGS_TYPE

Re: [Qemu-devel] [PATCH] Makefile: Add dependency to fix linux-user-only build

2012-02-22 Thread Anthony Liguori
On 02/21/2012 08:44 AM, Peter Maydell wrote: Make qemu-bridge-helper explicitly depend on $(GENERATED_HEADERS) so that it doesn't fail to build when we configured for linux-user targets only. (Build breakage introduced in commit 7b93fad.) Signed-off-by: Peter Maydell Applied. Thanks. Regards

Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Jeff Cody
On 02/22/2012 12:56 PM, Anthony Liguori wrote: On 02/22/2012 11:47 AM, Eric Blake wrote: On 02/22/2012 10:35 AM, Anthony Liguori wrote: [1] JSON schema definition: { 'type': 'SnapshotDev', 'data': {'device': 'str', 'snapshot-file': 'str', '*format': 'str' } } { 'command': 'blockdev-group-sna

Re: [Qemu-devel] [PATCH 3/4] Make kernel, initrd and append be machine_opts

2012-02-22 Thread Anthony Liguori
On 02/07/2012 11:41 PM, Peter Maydell wrote: Make kernel, initrd, append be machine opts (ie -machine kernel=foo) with the old plain command line arguments as legacy/convenience equivalents. Signed-off-by: Peter Maydell I applied this patch since Andrzej applied the first two. The four patch

Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Jeff Cody
On 02/22/2012 12:35 PM, Anthony Liguori wrote: On 02/22/2012 10:12 AM, Jeff Cody wrote: On 02/22/2012 09:53 AM, Anthony Liguori wrote: On 02/20/2012 11:31 AM, Jeff Cody wrote: The QAPI scripts allow for generating commands that receive parameter input consisting of a list of custom structs, bu

[Qemu-devel] [PATCH] qom: Make object_unref() free the object's memory when refcount goes to 0.

2012-02-22 Thread alexander_barabash
From: Alexander Barabash In the existing implementation, object_delete() calls object_unref(), then frees the object's storage. Running object_delete() on an object with reference count different from 1 causes program failure. In the existing implementation, object_unref() finalizes the object w

Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Anthony Liguori
On 02/22/2012 11:47 AM, Eric Blake wrote: On 02/22/2012 10:35 AM, Anthony Liguori wrote: [1] JSON schema definition: { 'type': 'SnapshotDev', 'data': {'device': 'str', 'snapshot-file': 'str', '*format': 'str' } } { 'command': 'blockdev-group-snapshot-sync', 'data': { 'dev': [ 'SnapshotDev' ]

[Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-22 Thread Federico Simoncelli
From: Marcelo Tosatti Mirrored writes are used by live block copy. Signed-off-by: Marcelo Tosatti --- Makefile.objs |2 +- block/blkmirror.c | 282 docs/blkmirror.txt | 15 +++ 3 files changed, 298 insertions(+), 1 deletions(-)

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-22 Thread Stefan Berger
On 02/21/2012 06:08 PM, Michael S. Tsirkin wrote: On Tue, Feb 21, 2012 at 05:30:32PM -0500, Stefan Berger wrote: On 02/21/2012 02:58 PM, Michael S. Tsirkin wrote: Worst case, you can take a qemu mutex. Is tpm very performance-sensitive to make contention on that lock a problem? FYI: Some pe

Re: [Qemu-devel] [PATCH] qom: In function object_set_link_property(), first call object_ref(), then object_unref().

2012-02-22 Thread Eric Blake
On 02/22/2012 10:25 AM, Alexander Barabash wrote: > Sorry, I did not figure out yet how to add the "v2" to the subject line. )) git send-email --subject-prefix=PATCHv2 or git send-email --annotate, then in the editor that pops up, add v2 in the appropriate place there's probably other possibil

Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Eric Blake
On 02/22/2012 10:35 AM, Anthony Liguori wrote: >> [1] JSON schema definition: >> >> { 'type': 'SnapshotDev', >> 'data': {'device': 'str', 'snapshot-file': 'str', '*format': 'str' } } >> >> { 'command': 'blockdev-group-snapshot-sync', >> 'data': { 'dev': [ 'SnapshotDev' ] } } > > > This will end

Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Anthony Liguori
On 02/22/2012 10:12 AM, Jeff Cody wrote: On 02/22/2012 09:53 AM, Anthony Liguori wrote: On 02/20/2012 11:31 AM, Jeff Cody wrote: The QAPI scripts allow for generating commands that receive parameter input consisting of a list of custom structs, but the QMP input paramter checking did not suppor

Re: [Qemu-devel] [PATCH] qom: In function object_set_link_property(), first call object_ref(), then object_unref().

2012-02-22 Thread Alexander Barabash
On 02/22/2012 07:24 PM, Paolo Bonzini wrote: On 02/22/2012 06:22 PM, alexander_barab...@mentor.com wrote: From: Alexander Barabash In the old implementation, if the new value of the property links to the same object, as the old value, that object is first unref-ed, and then ref-ed. This leads t

Re: [Qemu-devel] [PATCH] qom: In function object_set_link_property(), first call object_ref(), then object_unref().

2012-02-22 Thread Paolo Bonzini
On 02/22/2012 06:22 PM, alexander_barab...@mentor.com wrote: > From: Alexander Barabash > > In the old implementation, if the new value of the property links > to the same object, as the old value, that object is first unref-ed, > and then ref-ed. This leads to unintended deinitialization of that

[Qemu-devel] [PATCH] qom: In function object_set_link_property(), first call object_ref(), then object_unref().

2012-02-22 Thread alexander_barabash
From: Alexander Barabash In the old implementation, if the new value of the property links to the same object, as the old value, that object is first unref-ed, and then ref-ed. This leads to unintended deinitialization of that object. In the new implementation, this is fixed. Signed-off-by: Ale

Re: [Qemu-devel] [PATCH] qom: In function object_set_link_property(), first call object_ref(), then object_unref().

2012-02-22 Thread Alexander Barabash
On 02/22/2012 07:17 PM, Paolo Bonzini wrote: On 02/22/2012 06:13 PM, alexander_barab...@mentor.com wrote: From: Alexander Barabash In the old implementation, if the new value of the property links to the same object, as the old value, that object is first unref-ed, and then ref-ed. This leads t

Re: [Qemu-devel] [PATCH] qom: In function object_set_link_property(), first call object_ref(), then object_unref().

2012-02-22 Thread Paolo Bonzini
On 02/22/2012 06:13 PM, alexander_barab...@mentor.com wrote: > From: Alexander Barabash > > In the old implementation, if the new value of the property links > to the same object, as the old value, that object is first unref-ed, > and then ref-ed. This leads to unintended deinitialization of that

[Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev

2012-02-22 Thread Federico Simoncelli
Signed-off-by: Federico Simoncelli --- blockdev.c | 14 -- hmp-commands.hx | 16 ++-- hmp.c|4 +++- qapi-schema.json |8 +++- qmp-commands.hx |2 +- 5 files changed, 29 insertions(+), 15 deletions(-) diff --git a/blockdev.c b/blockd

[Qemu-devel] [PATCH 2/3] Update the blkmirror block driver

2012-02-22 Thread Federico Simoncelli
Signed-off-by: Federico Simoncelli --- block/blkmirror.c | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/block/blkmirror.c b/block/blkmirror.c index 1c02710..1cfd2fb 100644 --- a/block/blkmirror.c +++ b/block/blkmirror.c @@ -46,7 +46,7 @@ static

[Qemu-devel] Live Block Migration using Mirroring

2012-02-22 Thread Federico Simoncelli
Hi, recently I've been working on live block migration combining the live snapshots and the blkmirror patch sent by Marcelo Tosatti few months ago. The design is summarized at this url as "Mirrored-Snapshot": http://www.ovirt.org/wiki/Features/Design/StorageLiveMigration The design assumes tha

[Qemu-devel] [PATCH] qom: In function object_set_link_property(), first call object_ref(), then object_unref().

2012-02-22 Thread alexander_barabash
From: Alexander Barabash In the old implementation, if the new value of the property links to the same object, as the old value, that object is first unref-ed, and then ref-ed. This leads to unintended deinitialization of that object. In the new implementation, this is fixed. Signed-off-by: Ale

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-22 Thread Michal Privoznik
On 19.02.2012 12:15, Michal Privoznik wrote: > This command returns an array of: > > [ifname, ipaddr, ipaddr_family, prefix, hwaddr] > > for each interface in the system that has an IP address. > Currently, only IPv4 and IPv6 are supported. > > Signed-off-by: Michal Privoznik > --- > diff to v

Re: [Qemu-devel] [PATCH 6/6] qmp: add balloon-get-memory-stats & event

2012-02-22 Thread Michael Roth
On Wed, Feb 22, 2012 at 02:09:35PM -0200, Luiz Capitulino wrote: > On Wed, 22 Feb 2012 09:05:22 -0600 > Michael Roth wrote: > > > On Wed, Feb 22, 2012 at 10:48:13AM -0200, Luiz Capitulino wrote: > > > On Fri, 17 Feb 2012 15:51:33 -0600 > > > Michael Roth wrote: > > > > > > > On Fri, Feb 17, 201

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-02-22 Thread Dongsu Park
Hi Stefan, see below. On 21.02.2012 17:27, Stefan Hajnoczi wrote: > On Tue, Feb 21, 2012 at 3:57 PM, Dongsu Park > wrote: .. > I'm not sure if O_DIRECT and Linux AIO to /dev/ram0 is a good idea. > At least with tmpfs O_DIRECT does not even work - which kind of makes > sense there because tmp

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 01:55:45PM -0200, Luiz Capitulino wrote: > On Wed, 22 Feb 2012 15:29:33 +0100 > Alon Levy wrote: > > > On Wed, Feb 22, 2012 at 03:22:11PM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > Honestly, for this particular case, I'm not 100% sure that having an id > > > >

Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Jeff Cody
On 02/22/2012 09:53 AM, Anthony Liguori wrote: On 02/20/2012 11:31 AM, Jeff Cody wrote: The QAPI scripts allow for generating commands that receive parameter input consisting of a list of custom structs, but the QMP input paramter checking did not support receiving a qlist as opposed to a qdict

Re: [Qemu-devel] [PATCH 6/6] qmp: add balloon-get-memory-stats & event

2012-02-22 Thread Luiz Capitulino
On Wed, 22 Feb 2012 09:05:22 -0600 Michael Roth wrote: > On Wed, Feb 22, 2012 at 10:48:13AM -0200, Luiz Capitulino wrote: > > On Fri, 17 Feb 2012 15:51:33 -0600 > > Michael Roth wrote: > > > > > On Fri, Feb 17, 2012 at 03:16:22PM -0200, Luiz Capitulino wrote: > > > > On Fri, 17 Feb 2012 10:55:4

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Peter Maydell
On 22 February 2012 16:04, Andreas Färber wrote: > Am 22.02.2012 16:42, schrieb Peter Maydell: >> On 22 February 2012 15:37, Andreas Färber wrote: >>> NB: Your cpu-vmstate patches were not applied so far and they appear to >>> conflict with the plans we've made for redesigning cp15 on ARM: We wan

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Andreas Färber
Am 22.02.2012 16:42, schrieb Peter Maydell: > On 22 February 2012 15:37, Andreas Färber wrote: >> NB: Your cpu-vmstate patches were not applied so far and they appear to >> conflict with the plans we've made for redesigning cp15 on ARM: We want >> to convert today's static fields to some list and

  1   2   3   >