[Qemu-devel] [PATCH v11 9/9] pc_piix/pc_sysfw: enable flash by default

2012-02-21 Thread Jordan Justen
Now, the pc-sysfw:rom_only property will default to false which enables flash by default. All pc types below pc-1.1 set rom_only to true. This prevents flash from being enabled on these pc machine types. For pc-1.1 rom_only will use the default (false), which will allow flash to be used for pc-1.

[Qemu-devel] [PATCH v11 3/9] vl: make find_default_machine externally visible

2012-02-21 Thread Jordan Justen
Signed-off-by: Jordan Justen --- hw/boards.h |1 + vl.c|2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/boards.h b/hw/boards.h index f6d3784..667177d 100644 --- a/hw/boards.h +++ b/hw/boards.h @@ -32,6 +32,7 @@ typedef struct QEMUMachine { } QEMUMachine;

[Qemu-devel] Help me about the FDC

2012-02-21 Thread Zhi Hui Li
I am read the code of fdc.c , I feel it was difficult to understand. Can somebody give me some help: thank you very much! 1: explain the difference between : type_register_static(&isa_fdc_info); type_register_static(&sysbus_fdc_info); type_register_static(&sun4m_fdc_info); 2: e

[Qemu-devel] [PATCH v11 1/9] blockdev: allow read-only pflash devices

2012-02-21 Thread Jordan Justen
Signed-off-by: Jordan Justen --- blockdev.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/blockdev.c b/blockdev.c index 7a6613a..2c132a3 100644 --- a/blockdev.c +++ b/blockdev.c @@ -595,7 +595,8 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi) /*

[Qemu-devel] [Bug 938431] [NEW] Reproducible crash in slirp_remque (qemu 1.0.1)

2012-02-21 Thread Craig Ringer
Public bug reported: Heya I've been testing some automated data conversion scripts with qemu 1.0.1. They work fine with qemu-kvm 0.15.1, but on qemu 1.0.1 (from the website, built from source using gcc 4.6.1, i686 host), when the script runs qemu I see qemu crash in slirp_remque a few seconds aft

Re: [Qemu-devel] [PATCH 5/9] qom: add generic string parsing/printing

2012-02-21 Thread Paolo Bonzini
On 02/21/2012 09:47 PM, Andreas Färber wrote: >> > +void object_property_parse(Object *obj, const char *string, >> > + const char *name, Error **errp) >> > +{ >> > +StringInputVisitor *mi; > Curious: where does mi/mo come from? Cut-and-paste from the version using QMP

Re: [Qemu-devel] [PATCH 1/9] qapi: allow sharing enum implementation across visitors

2012-02-21 Thread Paolo Bonzini
On 02/21/2012 09:31 PM, Andreas Färber wrote: >> > +void output_type_enum(Visitor *v, int *obj, const char *strings[], >> > + const char *kind, const char *name, >> > + Error **errp) >> > +{ >> > +int i = 0; >> > +int value = *obj; >> > +char *e

Re: [Qemu-devel] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

2012-02-21 Thread Paolo Bonzini
On 02/22/2012 03:07 AM, 陳韋任 wrote: > > -HELPERS-$(CONFIG_LINUX) = qemu-bridge-helper$(EXESUF) > +HELPERS-$(CONFIG_LINUX) : config-host.h qemu-bridge-helper$(EXESUF) This is not declaring the dependency, it is declaring a target. The rule should be like qemu-bridge-helper.o: config-host.h Paol

[Qemu-devel] [PATCH v11 7/9] hw/pc_piix: remove is_default for pc-0.15

2012-02-21 Thread Jordan Justen
Signed-off-by: Jordan Justen --- hw/pc_piix.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 17f8d5d..2fc4211 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -385,7 +385,6 @@ static QEMUMachine pc_machine_v0_15 = { .desc = "Standard

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

2012-02-21 Thread 陳韋任
On Tue, Feb 21, 2012 at 12:27:26PM +, Stefan Hajnoczi wrote: > On Tue, Feb 21, 2012 at 10:12 AM, 陳韋任 wrote: > >  Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 adds basic version of > > bridge > > helper, but introduces dependency issue at the same time. While building > > target > > xxx-li

[Qemu-devel] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

2012-02-21 Thread 陳韋任
Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 adds basic version of bridge helper, but introduces dependency issue at the same time. While building target xxx-linux-user, qemu-bridge-helper.c needs config-host.h which is not generated at the moment. Explicitly declaring the dependency for the h

[Qemu-devel] [PATCH 2/2] ARM: exynos, integratorcp: Specify U-Boot start address.

2012-02-21 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- hw/exynos4210.h |1 + hw/exynos4_boards.c |1 + hw/integratorcp.c |1 + 3 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/exynos4210.h b/hw/exynos4210.h index e7522f8..9035a2a 100644 --- a/hw/exynos4210.h +++ b/hw/exynos4210.h @

[Qemu-devel] [PATCH 1/2] ARM: Add "-uboot" option.

2012-02-21 Thread Evgeny Voevodin
With this option board can load U-Boot into address specified through arm_boot_info.uboot_start. Signed-off-by: Evgeny Voevodin --- hw/arm-misc.h |1 + hw/arm_boot.c | 51 ++- qemu-options.hx |8 sysemu.h|1 + vl.

[Qemu-devel] [PATCH 0/2] Add "-uboot" option

2012-02-21 Thread Evgeny Voevodin
These patches add "-uboot" option to ARM boards. To let user load u-boot, board should initialize .uboot_start in arm_boot_info struct. Added utilisation of "-uboot" for exynos4 and integratorcp. Evgeny Voevodin (2): ARM: Add "-uboot" option. ARM: exynos, integratorcp: Specify U-Boot start ad

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-21 Thread Michael S. Tsirkin
On Tue, Feb 21, 2012 at 07:21:28PM -0500, Stefan Berger wrote: > On 02/21/2012 06:08 PM, Michael S. Tsirkin wrote: > >On Tue, Feb 21, 2012 at 05:30:32PM -0500, Stefan Berger wrote: > > > > > >>At the moment there are two backends that need threading: the > >>libtpms and passthrough backends. Both w

Re: [Qemu-devel] VirtIO 9p mount_tag (bogus?) limit of 32 bytes

2012-02-21 Thread C Anthony Risinger
On Sat, Feb 18, 2012 at 11:38 AM, Aneesh Kumar K.V wrote: > On Thu, 16 Feb 2012 06:20:21 -0600, C Anthony Risinger > wrote: >> a) mapped FS security policy (xattrs) causes `ldconfig` to abort()? >> root or normal user ... >> >> somehow `ldconfig` gets a duplicate inode while constructing the >>

Re: [Qemu-devel] [PATCH] pci: set memory type for memory behind the bridge

2012-02-21 Thread Benjamin Herrenschmidt
On Tue, 2012-02-21 at 15:56 +0100, Alexander Graf wrote: > On 02/21/2012 02:57 PM, Michael S. Tsirkin wrote: > > As we make upper bits in IO and prefetcheable memory > > registers writeable, we should declare support > > for 64 bit prefetcheable memory and 32 bit io > > in the bridge. > > > > This

Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-02-21 Thread David Gibson
On Tue, Feb 21, 2012 at 10:09:01AM +0100, Kevin Wolf wrote: > Am 21.02.2012 09:35, schrieb Paolo Bonzini: > > On 02/20/2012 11:50 AM, Alexander Graf wrote: > DMAAIOCB *dbs = qemu_aio_get(&dma_aio_pool, bs, cb, opaque); > > -trace_dma_bdrv_io(dbs, bs, sector_num, to_dev); > >>

Re: [Qemu-devel] [PATCH 2/2] qom: add test tools

2012-02-21 Thread Andreas Färber
Am 20.02.2012 23:28, schrieb Michael Roth: > From: Anthony Liguori > > Signed-off-by: Anthony Liguori > Signed-off-by: Michael Roth Tested-by: Andreas Färber Thanks, these are really handy! :-) Since it's three independent scripts, it might make sense to split this into three commits? Andr

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-21 Thread Stefan Berger
On 02/21/2012 06:08 PM, Michael S. Tsirkin wrote: On Tue, Feb 21, 2012 at 05:30:32PM -0500, Stefan Berger wrote: At the moment there are two backends that need threading: the libtpms and passthrough backends. Both will require locking of datastructures that belong to the frontend. Only the nul

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-21 Thread Michael S. Tsirkin
On Tue, Feb 21, 2012 at 05:30:32PM -0500, Stefan Berger wrote: > On 02/21/2012 02:58 PM, Michael S. Tsirkin wrote: > >On Tue, Feb 21, 2012 at 10:05:26AM -0500, Stefan Berger wrote: > >>On 02/21/2012 07:18 AM, Michael S. Tsirkin wrote: > >>> > >>When the backend delivers the response it checks wheth

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-21 Thread Stefan Berger
On 02/21/2012 02:58 PM, Michael S. Tsirkin wrote: On Tue, Feb 21, 2012 at 10:05:26AM -0500, Stefan Berger wrote: On 02/21/2012 07:18 AM, Michael S. Tsirkin wrote: When the backend delivers the response it checks whether the interface is used in interrupt mode and raises the interrupt. IMO it

[Qemu-devel] [RFC v4 3/9] qxl: drop qxl_spice_update_area_async definition

2012-02-21 Thread Alon Levy
It was never used. Introduced in 5ff4e36c804157bd84af43c139f8cd3a59722db9 qxl: async io support using new spice api But not used even then. Signed-off-by: Alon Levy --- hw/qxl.h |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/hw/qxl.h b/hw/qxl.h index 766aa6d..6399

[Qemu-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save

2012-02-21 Thread Alon Levy
Using vga->screen_dump results in a number of calls to ppm_save, instead of a single one. Lacking time to test all the possible users of vga->screen_dump, avoid the redundant calls by doing the vga_hw_update+ ppm_save in qxl_hw_screen_dump. Signed-off-by: Alon Levy --- hw/qxl.c | 10 --

[Qemu-devel] [RFC v4 5/9] qxl: require spice >= 0.8.2

2012-02-21 Thread Alon Levy
drop all ifdefs on SPICE_INTERFACE_QXL_MINOR >= 1 as a result, 0.8.2 has SPICE_INTERFACE_QXL_MINOR == 1. Signed-off-by: Alon Levy --- configure |2 +- hw/qxl.c | 40 hw/qxl.h |4 ui/spice-display.c | 12 --

[Qemu-devel] [RFC v4 9/9] qxl-render: call ppm_save on bh

2012-02-21 Thread Alon Levy
This changes the behavior of the monitor command. After the previous patch, there is no longer an option of deadlock with virt-manager, but ppm_save is called too early, before the update has completed. With this patch it is called at the correct moment, but that means there is a race between the m

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-02-21 Thread Rusty Russell
On Tue, 21 Feb 2012 17:45:08 +0100, Dongsu Park wrote: > Hi Rusty, > > On 13.02.2012 10:25, Rusty Russell wrote: > > On Fri, 10 Feb 2012 15:36:39 +0100, Dongsu Park > > wrote: > > > Hi, > > > > > > Recently I observed performance regression regarding virtio-blk, > > > especially different IO

[Qemu-devel] [RFC v4 8/9] qxl: make qxl_render_update async

2012-02-21 Thread Alon Levy
RHBZ# 747011 Removes the last user of QXL_SYNC when using update drivers that use the _ASYNC io ports. The last user is qxl_render_update, it is called both by qxl_hw_update which is the vga_hw_update_ptr passed to graphic_console_init, and by qxl_hw_screen_dump. At the same time the QXLRect are

[Qemu-devel] [RFC v4 1/9] console: don't call console_select unnecessarily

2012-02-21 Thread Alon Levy
From: Gerd Hoffman Tested-by: Alon Levy --- console.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/console.c b/console.c index 135394f..cfcc2f7 100644 --- a/console.c +++ b/console.c @@ -181,12 +181,14 @@ void vga_hw_screen_dump(const char *filename) /* T

Re: [Qemu-devel] [Spice-devel] [RFC v4 0/9] qxl: fix hangs caused by qxl_render_update

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 11:39:28PM +0200, Alon Levy wrote: > This is the second attempt to fix this issue, as a lesson from the last time > it doesn't try to use an async monitor command. So with this patchset, in qxl > mode, a screendump monitor command will complete before the file is written

[Qemu-devel] [RFC v4 7/9] qxl: introduce QXLCookie

2012-02-21 Thread Alon Levy
Will be used in the next patch. Signed-off-by: Alon Levy --- hw/qxl-render.c|2 +- hw/qxl.c | 58 --- hw/qxl.h |2 +- ui/spice-display.c | 22 +-- ui/spice-display.h | 14 5 files c

[Qemu-devel] [RFC v4 6/9] qxl: remove flipped

2012-02-21 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl-render.c | 58 ++- hw/qxl.h|2 +- 2 files changed, 20 insertions(+), 40 deletions(-) diff --git a/hw/qxl-render.c b/hw/qxl-render.c index 133d093..4518a56 100644 --- a/hw/qxl-render.c +++ b/hw/q

[Qemu-devel] [RFC v4 2/9] sdl: remove NULL check, g_malloc0 can't fail

2012-02-21 Thread Alon Levy
Signed-off-by: Alon Levy --- ui/sdl.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index 6f8091c..f6f711c 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -167,10 +167,6 @@ static PixelFormat sdl_to_qemu_pixelformat(SDL_PixelFormat *sdl_pf) static Displ

[Qemu-devel] [RFC v4 0/9] qxl: fix hangs caused by qxl_render_update

2012-02-21 Thread Alon Levy
This is the second attempt to fix this issue, as a lesson from the last time it doesn't try to use an async monitor command. So with this patchset, in qxl mode, a screendump monitor command will complete before the file is written to disk. This is much better then a hang. To fix it does require

Re: [Qemu-devel] [PATCH 5/9] qom: add generic string parsing/printing

2012-02-21 Thread Andreas Färber
Am 09.02.2012 15:31, schrieb Paolo Bonzini: > Add generic property accessors that take a string and parse it > appropriately for the property type. All the magic here is done > by the new string-based visitors. > > Signed-off-by: Paolo Bonzini > --- > include/qemu/object.h | 24 ++

Re: [Qemu-devel] [PATCH 1/9] qapi: allow sharing enum implementation across visitors

2012-02-21 Thread Andreas Färber
Am 09.02.2012 15:31, schrieb Paolo Bonzini: > Most visitors will use the same code for enum parsing. Move it to > the core. > > Signed-off-by: Paolo Bonzini Reviewed-by: Andreas Färber However... > diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c > index ddef3ed..a4e088c 100644 >

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-21 Thread Michael S. Tsirkin
On Tue, Feb 21, 2012 at 10:05:26AM -0500, Stefan Berger wrote: > On 02/21/2012 07:18 AM, Michael S. Tsirkin wrote: > >On Tue, Feb 21, 2012 at 06:19:26AM -0500, Stefan Berger wrote: > >>On 02/20/2012 10:18 PM, Michael S. Tsirkin wrote: > >>>On Mon, Feb 20, 2012 at 07:43:05PM -0500, Stefan Berger wro

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 09:15:45AM -0700, Eric Blake wrote: > On 02/21/2012 01:19 AM, Alon Levy wrote: > > >>> (2) Async monitor command. Keeps interface and works nicely. A bunch > >>> of QAPI bits tickled into master meanwhile, so we could look at > >>> this again. Luiz? What is t

[Qemu-devel] [PATCH] PPC: 405: Use proper CPU reset

2012-02-21 Thread Alexander Graf
On ppc405ep there is a register that allows for software to reset the core, but not the whole system. Implement this reset using a reset interrupt. This gets rid of a bunch of #if 0'ed code. Reported-by: Andreas Faerber Signed-off-by: Alexander Graf --- cpu-exec.c |2 -- hw/ppc.c

[Qemu-devel] [PATCH] PPC: 405: Fix ppc405ep initialization

2012-02-21 Thread Alexander Graf
When trying to run a ppc405 guest, it segfaults quite quickly, trying to access timers that weren't initialized. Initialize them properly instead. Reported-by: Andreas Faerber Signed-off-by: Alexander Graf --- hw/ppc405_uc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --gi

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-21 Thread Peter Lieven
On 21.02.2012 17:48, Vadim Rozenfeld wrote: - Original Message - From: "Peter Lieven" To: "Vadim Rozenfeld" Cc: qemu-devel@nongnu.org, k...@vger.kernel.org, "Gleb Natapov" Sent: Tuesday, February 21, 2012 4:10:22 PM Subject: Re: win7 bad i/o performance, high insn_emulation and exists O

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-21 Thread Stefan Hajnoczi
On Tue, Feb 21, 2012 at 4:01 PM, Markus Armbruster wrote: > Anthony Liguori writes: > >> On 02/07/2012 07:50 AM, Stefan Hajnoczi wrote: >>> On Tue, Feb 7, 2012 at 1:34 PM, Kevin Wolf  wrote: Am 07.02.2012 11:29, schrieb Ori Mamluk: > Repagent is a new module that allows an external repli

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-02-21 Thread Stefan Hajnoczi
On Tue, Feb 21, 2012 at 3:57 PM, Dongsu Park wrote: > On 13.02.2012 11:57, Stefan Hajnoczi wrote: >> On Fri, Feb 10, 2012 at 2:36 PM, Dongsu Park >> wrote: >> >  Now I'm running benchmarks with both qemu-kvm 0.14.1 and 1.0. >> > >> >  - Sequential read (Running inside guest) >> >   # fio -name io

Re: [Qemu-devel] Mascot Contest Results

2012-02-21 Thread Mulyadi Santosa
On Tue, Feb 21, 2012 at 23:03, Anthony Liguori wrote: > But there is pretty clearly a favorite and with 12 votes, I'm pleased to > announce that Benoit Canet's "Kew the Angry Emu" logo is the winner! I am late to vote, but after seeing the SVG, I say it's a good logo. Kudos for Benoit! -- regar

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Stefan Hajnoczi
On Tue, Feb 21, 2012 at 1:10 PM, Kevin Wolf wrote: > Am 21.02.2012 12:36, schrieb Paolo Bonzini: > Oh, and just to open another can of worms: We should probably design in > the notion of media (which can be ejected etc.) and drives (which always > stay there). We don't have a clean separation toda

[Qemu-devel] [PULL v2 0/9] qdev deconstruction, command-line episode

2012-02-21 Thread Paolo Bonzini
Anthony, I'm sending a pull request since you informally said on IRC that you're okay with the patches. The following changes since commit 99c7f87826337fa81f2f0f9baa9ca0a44faf90e9: input: send kbd+mouse events only to running guests. (2012-02-17 11:02:55 -0600) are available in the git repos

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-21 Thread Vadim Rozenfeld
- Original Message - From: "Peter Lieven" To: "Vadim Rozenfeld" Cc: qemu-devel@nongnu.org, k...@vger.kernel.org, "Gleb Natapov" Sent: Tuesday, February 21, 2012 4:10:22 PM Subject: Re: win7 bad i/o performance, high insn_emulation and exists On 21.02.2012 14:56, Vadim Rozenfeld wrote

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-02-21 Thread Dongsu Park
Hi Rusty, On 13.02.2012 10:25, Rusty Russell wrote: > On Fri, 10 Feb 2012 15:36:39 +0100, Dongsu Park > wrote: > > Hi, > > > > Recently I observed performance regression regarding virtio-blk, > > especially different IO bandwidths between qemu-kvm 0.14.1 and 1.0. > > So I want to share the benc

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Kevin Wolf
Am 21.02.2012 17:19, schrieb Markus Armbruster: Oh, and just to open another can of worms: We should probably design in the notion of media (which can be ejected etc.) and drives (which always stay there). We don't have a clean separation today. >>> >>> The "closed BDS means no media

Re: [Qemu-devel] [PATCH v5 12/12] suspend: add qmp events

2012-02-21 Thread Eric Blake
On 02/21/2012 03:00 AM, Gerd Hoffmann wrote: > [ added libvirt to Cc:, leaving full context. > this is about qmp events when the guest enters/leaves s3 ]. > >>> @@ -1436,12 +1437,26 @@ void qemu_register_suspend_notifier(Notifier >>> *notifier) >>> >>> void qemu_system_wakeup_request(Wakeup

Re: [Qemu-devel] [PATCH] usb-hid: activate usb tablet / mouse after migration.

2012-02-21 Thread Peter Lieven
On 16.10.2011 10:54, TeLeMan wrote: On Thu, Oct 13, 2011 at 18:48, Gerd Hoffmann wrote: On 10/13/11 04:09, TeLeMan wrote: On Wed, Oct 12, 2011 at 19:30, Gerd Hoffmannwrote: qemu uses the ps/2 mouse by default. The usb tablet (or mouse) is activated as soon as qemu sees some guest activit

[Qemu-devel] PCI: Add PCI_EXP_TYPE_PCIE_BRIDGE value

2012-02-21 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- include/linux/pci_regs.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/pci_regs.h b/include/linux/pci_regs.h index e41a10f..4b608f5 100644 --- a/include/linux/pci_regs.h +++ b/include/linux/pci_regs.h @@ -391,6 +391,7 @@

Re: [Qemu-devel] [PATCH] linux-user: fix segfault deadlock

2012-02-21 Thread Peter Maydell
On 21 February 2012 16:19, Alexander Graf wrote: > On 02/21/2012 05:11 PM, Peter Maydell wrote: >> For a proper fix we probably need to handle set/getrlimit for >> RLIMIT_AS specially so we can apply them ourselves to the guest's >> mmap/brk usage and don't get spurious allocation failures of >> o

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Markus Armbruster
Kevin Wolf writes: > Am 21.02.2012 16:56, schrieb Markus Armbruster: >> Kevin Wolf writes: [...] >>> Maybe we need to introduce something outside of the whole stack, an >>> entity that is referred to by the device (as in IDE, virtio-blk, ...) >>> and that refers to a stack of top-level listeners

Re: [Qemu-devel] [PATCH] linux-user: fix segfault deadlock

2012-02-21 Thread Alexander Graf
On 02/21/2012 05:11 PM, Peter Maydell wrote: On 13 January 2012 16:21, Alexander Graf wrote: On 13.01.2012, at 17:16, Peter Maydell wrote: On 13 January 2012 15:46, Alexander Graf wrote: This patch forces unlocking of that lock in the segv handler. I'm not sure this is the right approach tho

Re: [Qemu-devel] [PATCH V7 11/11] xen passthrough: clean up MSI-X table handling

2012-02-21 Thread Anthony PERARD
On Tue, Feb 21, 2012 at 09:34, Jan Beulich wrote: > Wouldn't thus much better be merged into the prior patch(es)? After > all you're not trying to reconstruct the Xen-side history of this code > anyway. Yes, that probably better than having an extra patch. There is a "link" to the history, anyway

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-21 Thread Eric Blake
On 02/21/2012 01:19 AM, Alon Levy wrote: >>> (2) Async monitor command. Keeps interface and works nicely. A bunch >>> of QAPI bits tickled into master meanwhile, so we could look at >>> this again. Luiz? What is the status here? >>> >>> (3) Something like this patch + additionally

Re: [Qemu-devel] [PATCH] linux-user: fix segfault deadlock

2012-02-21 Thread Peter Maydell
On 13 January 2012 16:21, Alexander Graf wrote: > On 13.01.2012, at 17:16, Peter Maydell wrote: >> On 13 January 2012 15:46, Alexander Graf wrote: >>> This patch forces unlocking of that lock in the segv handler. I'm not sure >>> this is the right approach though. Maybe we should rather make sure

Re: [Qemu-devel] [PATCH V7 03/11] pci_regs: Add PCI_EXP_TYPE_PCIE_BRIDGE

2012-02-21 Thread Anthony PERARD
On Mon, Feb 20, 2012 at 20:30, Michael S. Tsirkin wrote: > On Fri, Feb 17, 2012 at 05:08:37PM +, Anthony PERARD wrote: >> Signed-off-by: Anthony PERARD >> --- >>  hw/pci_regs.h |    1 + >>  1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/hw/pci_regs.h b/hw/pci_regs.h >> in

[Qemu-devel] Mascot Contest Results

2012-02-21 Thread Anthony Liguori
First, I'd like to thank everyone for participating! We received a large number of entries and lot of great submissions. But there is pretty clearly a favorite and with 12 votes, I'm pleased to announce that Benoit Canet's "Kew the Angry Emu" logo is the winner! I'm attaching the SVG to this

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-21 Thread Markus Armbruster
Anthony Liguori writes: > On 02/07/2012 07:50 AM, Stefan Hajnoczi wrote: >> On Tue, Feb 7, 2012 at 1:34 PM, Kevin Wolf wrote: >>> Am 07.02.2012 11:29, schrieb Ori Mamluk: Repagent is a new module that allows an external replication system to replicate a volume of a Qemu VM. >> >> I rec

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Kevin Wolf
Am 21.02.2012 16:56, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 21.02.2012 12:36, schrieb Paolo Bonzini: >>> And here: >>> >>> .== BlockSource ==. >>> | MirrorListener | .== BlockSource ==. >>> | QCOW2View --+--> QCOW2Format -> | FileProtocol| >>> '

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-02-21 Thread Dongsu Park
Hi Stefan, see below. On 13.02.2012 11:57, Stefan Hajnoczi wrote: > On Fri, Feb 10, 2012 at 2:36 PM, Dongsu Park > wrote: > >  Now I'm running benchmarks with both qemu-kvm 0.14.1 and 1.0. > > > >  - Sequential read (Running inside guest) > >   # fio -name iops -rw=read -size=1G -iodepth 1 \ > >

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Markus Armbruster
Kevin Wolf writes: > Am 21.02.2012 12:36, schrieb Paolo Bonzini: >> And here: >> >> .== BlockSource ==. >> | MirrorListener | .== BlockSource ==. >> | QCOW2View --+--> QCOW2Format -> | FileProtocol| >> '='| '=' >

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Markus Armbruster
Stefan Hajnoczi writes: > This is a good discussion because BlockDriverState has become bloated > and complex. A lot of fields only apply to sub-cases and we should > really split this struct. Yup. We've had discussions where couldn't even agree whether a specific block driver is a format or a

[Qemu-devel] [PATCH] block: drop aio_multiwrite in BlockDriver

2012-02-21 Thread Paolo Bonzini
These were never used. Signed-off-by: Paolo Bonzini --- block.c | 23 ++--- block_int.h |6 -- 2 files changed, 3 insertions(+), 26 deletions(-) diff --git a/block.c b/block.c index ae297bb..b395f7b 100644 --- a/block.c +++ b/block.c @@ -2767,7 +2793,6 @@ typedef s

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-02-21 Thread Peter Maydell
On 9 February 2012 22:23, Peter Maydell wrote: > Ping re the VMState and variable sized arrays issue. I don't > see any consensus in this discussion for a different approach, > so should we just commit Mitsyanko's patchset? >From an IRC conversation I just had with Anthony and Juan: ===begin== 14

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-21 Thread Stefan Berger
On 02/21/2012 07:18 AM, Michael S. Tsirkin wrote: On Tue, Feb 21, 2012 at 06:19:26AM -0500, Stefan Berger wrote: On 02/20/2012 10:18 PM, Michael S. Tsirkin wrote: On Mon, Feb 20, 2012 at 07:43:05PM -0500, Stefan Berger wrote: On 02/20/2012 05:02 PM, Michael S. Tsirkin wrote: On Wed, Dec 14, 2

[Qemu-devel] [PATCH] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

2012-02-21 Thread 陳韋任
Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 adds basic version of bridge helper, but introduces dependency issue at the same time. While building target xxx-linux-user, qemu-bridge-helper.c needs config-host.h which is not generated at the moment. Building recurse-all target first fixes the p

Re: [Qemu-devel] KVM call agenda for Tuesday 21th

2012-02-21 Thread Anthony Liguori
On 02/21/2012 08:06 AM, Kevin Wolf wrote: Am 20.02.2012 11:13, schrieb Juan Quintela: Hi Please send in any agenda items you are interested in covering. What's the status with qtest? (Though probably a one-line email would already answer this) I still need to go through Paolo's patches. I

Re: [Qemu-devel] [PATCH] pci: set memory type for memory behind the bridge

2012-02-21 Thread Alexander Graf
On 02/21/2012 02:57 PM, Michael S. Tsirkin wrote: As we make upper bits in IO and prefetcheable memory registers writeable, we should declare support for 64 bit prefetcheable memory and 32 bit io in the bridge. This changes the default for apb, dec, but I'm guessing they got the defaults wrong b

[Qemu-devel] 2 build issues for qemu v1.0.1

2012-02-21 Thread Virtbie
Hello I am trying to build from source the qemu v1.0.1 (from git) on a Ubuntu mixed system (part is oneiric 11.10, part is precise 12.04) Here are two issues: During build of: hw/9pfs/virtio-9p-handle.c it gave errors saying it couldnt find definition of "AT_EMPTY_PATH". So I added it at the

Re: [Qemu-devel] KVM call agenda for Tuesday 21th

2012-02-21 Thread Juan Quintela
Kevin Wolf wrote: > Am 20.02.2012 11:13, schrieb Juan Quintela: >> >> Hi >> >> Please send in any agenda items you are interested in covering. > > What's the status with qtest? (Though probably a one-line email would > already answer this) As this is the only topic for today call, and you agre

[Qemu-devel] [PATCH] Makefile: Add dependency to fix linux-user-only build

2012-02-21 Thread Peter Maydell
Make qemu-bridge-helper explicitly depend on $(GENERATED_HEADERS) so that it doesn't fail to build when we configured for linux-user targets only. (Build breakage introduced in commit 7b93fad.) Signed-off-by: Peter Maydell --- I suspect we could handle generated headers better in our makefile tha

Re: [Qemu-devel] [PATCH] block: remove unused fields in BlockDriverState

2012-02-21 Thread Kevin Wolf
Am 20.02.2012 17:58, schrieb Paolo Bonzini: > sync_aiocb is unused since commit ce1a14d (Dynamically allocate AIO > Completion Blocks., 2006-08-07). > > private is unused since commit 56a1493 (drive cleanup fixes., 2009-09-25). > > Signed-off-by: Paolo Bonzini Thanks, applied to the block branc

Re: [Qemu-devel] [PATCH 3/3] qapi: Introduce blockdev-query-group-snapshot-failure

2012-02-21 Thread Jeff Cody
On 02/20/2012 12:48 PM, Eric Blake wrote: > On 02/20/2012 10:31 AM, Jeff Cody wrote: >> In the case of a failure in a group snapshot, it is possible for >> multiple file image failures to occur - for instance, failure of >> an original snapshot, and then failure of one or more of the >> attempted r

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-21 Thread Peter Lieven
On 21.02.2012 14:56, Vadim Rozenfeld wrote: - Original Message - From: "Peter Lieven" To: "Gleb Natapov" Cc: qemu-devel@nongnu.org, k...@vger.kernel.org, vroze...@redhat.com Sent: Tuesday, February 21, 2012 2:05:25 PM Subject: Re: win7 bad i/o performance, high insn_emulation and exists

Re: [Qemu-devel] KVM call agenda for Tuesday 21th

2012-02-21 Thread Kevin Wolf
Am 20.02.2012 11:13, schrieb Juan Quintela: > > Hi > > Please send in any agenda items you are interested in covering. What's the status with qtest? (Though probably a one-line email would already answer this) Kevin

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-21 Thread Vadim Rozenfeld
- Original Message - From: "Peter Lieven" To: "Gleb Natapov" Cc: qemu-devel@nongnu.org, k...@vger.kernel.org, vroze...@redhat.com Sent: Tuesday, February 21, 2012 2:05:25 PM Subject: Re: win7 bad i/o performance, high insn_emulation and exists On 21.02.2012 12:46, Gleb Natapov wrote: >

[Qemu-devel] [PATCH] pci: set memory type for memory behind the bridge

2012-02-21 Thread Michael S. Tsirkin
As we make upper bits in IO and prefetcheable memory registers writeable, we should declare support for 64 bit prefetcheable memory and 32 bit io in the bridge. This changes the default for apb, dec, but I'm guessing they got the defaults wrong by accident. Alternatively, we could let bridges decl

[Qemu-devel] [PATCH] pci: add accessors to get/set registers by mask

2012-02-21 Thread Michael S. Tsirkin
pci_regs.h specifies many registers by mask + shifted register values. There's always some duplication when using such: for example to override device type, we would need: pci_word_test_and_clear_mask(cap + PCI_EXP_FLAGS, PCI_EXP_FLAGS_TYPE); pci_word_test_and_set_mask(cap + PCI_EXP_FLAGS,

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Paolo Bonzini
On 02/21/2012 02:10 PM, Kevin Wolf wrote: >> > I think it depends, but both possibilities should be doable in this model. > > Meh. :-) Agreed. :) > Maybe we need to introduce something outside of the whole stack, an > entity that is referred to by the device (as in IDE, virtio-blk, ...) > and th

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Kevin Wolf
Am 21.02.2012 12:36, schrieb Paolo Bonzini: > And here: > > .== BlockSource ==. > | MirrorListener | .== BlockSource ==. > | QCOW2View --+--> QCOW2Format -> | FileProtocol| > '='| '=' > |

Re: [Qemu-devel] [PATCH v6 2/4] cadence_ttc: initial version of device model

2012-02-21 Thread Paul Brook
> > +static inline int64_t is_between(int64_t x, int64_t a, int64_t b) > > +{ > > +if (a < b) { > > +return x > a && x <= b; > > +} > > +return x < a && x >= b; > > +} > > This looks slightly odd -- should the boundary condition for whether > a value equal to the max/min really

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Paolo Bonzini
On 02/21/2012 01:22 PM, Stefan Hajnoczi wrote: > This is a good discussion because BlockDriverState has become bloated > and complex. A lot of fields only apply to sub-cases and we should > really split this struct. > > Fields like "backing_file" *should* be in generic code, not duplicated > in e

Re: [Qemu-devel] [PATCH 2/3] qapi: Introduce blockdev-group-snapshot-sync command

2012-02-21 Thread Jeff Cody
On 02/20/2012 12:41 PM, Eric Blake wrote: On 02/20/2012 10:31 AM, Jeff Cody wrote: This is a QAPI/QMP only command to take a snapshot of a group of devices. This is simlar to the blockdev-snapshot-sync command, except s/simlar/similar/ Oops - fixed for v2. blockdev-group-snapshot-sync ac

Re: [Qemu-devel] [PATCH 2/2] arm: make sure that number of irqs can be represented in GICD_TYPER.

2012-02-21 Thread Peter Maydell
On 21 February 2012 02:33, Rusty Russell wrote: > We currently assume that the number of interrupts (ITLinesNumber in > the architecture reference manual) is divisible by 32, since we > present it to the guest when it reads GICD_TYPER (in gic_dist_readb()) > as (N / 32) - 1. > > Signed-off-by: Rus

Re: [Qemu-devel] [PATCH 1/2] arm: clean up GIC constants.

2012-02-21 Thread Peter Maydell
On 21 February 2012 02:33, Rusty Russell wrote: > Interrupts numbers 0-31 are private to the processor interface, 32-1019 are > general interrups.  Add GIC_INTERNAL and substitute everywhere. > @@ -73,8 +75,9 @@ typedef struct gic_irq_state >  #define GIC_SET_TRIGGER(irq) s->irq_state[irq].trigger

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

2012-02-21 Thread Stefan Hajnoczi
On Tue, Feb 21, 2012 at 10:12 AM, 陳韋任 wrote: >  Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 adds basic version of bridge > helper, but introduces dependency issue at the same time. While building > target > xxx-linux-user, qemu-bridge-helper.c needs config-host.h which is not > generated > a

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-21 Thread Stefan Hajnoczi
On Tue, Feb 21, 2012 at 11:36 AM, Paolo Bonzini wrote: > On 02/21/2012 11:51 AM, Kevin Wolf wrote: >> And even protocols and protocols don't. Compare file to blkdebug, for >> example. In fact, blkdebug and blkverify are already very close to what >> BlockListeners would be. > > Yes, and I think co

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-21 Thread Michael S. Tsirkin
On Tue, Feb 21, 2012 at 06:19:26AM -0500, Stefan Berger wrote: > On 02/20/2012 10:18 PM, Michael S. Tsirkin wrote: > >On Mon, Feb 20, 2012 at 07:43:05PM -0500, Stefan Berger wrote: > >>On 02/20/2012 05:02 PM, Michael S. Tsirkin wrote: > >>>On Wed, Dec 14, 2011 at 08:43:17AM -0500, Stefan Berger wro

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-21 Thread Peter Lieven
On 21.02.2012 12:46, Gleb Natapov wrote: On Tue, Feb 21, 2012 at 12:16:16PM +0100, Peter Lieven wrote: On 21.02.2012 12:00, Gleb Natapov wrote: On Tue, Feb 21, 2012 at 11:59:23AM +0100, Peter Lieven wrote: On 21.02.2012 11:56, Gleb Natapov wrote: On Tue, Feb 21, 2012 at 11:50:47AM +0100, Pete

[Qemu-devel] [PATCH 3/9] qxl: set only off-screen surfaces dirty instead of the whole vram

2012-02-21 Thread Gerd Hoffmann
From: Yonit Halperin We used to assure the guest surfaces were saved before migration by setting the whole vram dirty. This patch sets dirty only the areas that are actually used in the vram. Signed-off-by: Yonit Halperin Signed-off-by: Gerd Hoffmann --- hw/qxl.c | 53 ++

[Qemu-devel] [PATCH 9/9] qxl: add user-friendly bar size properties

2012-02-21 Thread Gerd Hoffmann
Add two properties to specify bar sizes in megabytes instead of bytes, which is alot more user-friendly. Signed-off-by: Gerd Hoffmann --- hw/qxl.c |8 hw/qxl.h |4 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 38bb90e..87ad49a 100

[Qemu-devel] [PATCH 4/9] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-21 Thread Gerd Hoffmann
From: Yonit Halperin RHBZ #790083 Signed-off-by: Yonit Halperin Signed-off-by: Gerd Hoffmann --- hw/qxl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index b544f31..5c6b556 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1471,7 +1471,7 @@ static void

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-21 Thread Gleb Natapov
On Tue, Feb 21, 2012 at 12:16:16PM +0100, Peter Lieven wrote: > On 21.02.2012 12:00, Gleb Natapov wrote: > >On Tue, Feb 21, 2012 at 11:59:23AM +0100, Peter Lieven wrote: > >>On 21.02.2012 11:56, Gleb Natapov wrote: > >>>On Tue, Feb 21, 2012 at 11:50:47AM +0100, Peter Lieven wrote: > >I hope it

[Qemu-devel] [PULL] spice patch queue

2012-02-21 Thread Gerd Hoffmann
Hi, Here is the spice patch queue with a collection of little improvements and bugfixes. No major stuff. See individual patches for details. please pull, Gerd The following changes since commit 99c7f87826337fa81f2f0f9baa9ca0a44faf90e9: input: send kbd+mouse events only to running guests

[Qemu-devel] [PATCH 1/9] qxl: fix warnings on 32bit

2012-02-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/qxl.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index ac69125..f421a45 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -625,7 +625,7 @@ static void interface_release_resource(QXLInstance *sin, if (ext.grou

[Qemu-devel] [PATCH 5/9] Add SPICE support to add_client monitor command

2012-02-21 Thread Gerd Hoffmann
From: Daniel P. Berrange With the acceptance of some new APIs to libspice-server.so it is possible to add support for SPICE to the 'add_client' monitor command, bringing parity with VNC. Since SPICE can use TLS or plain connections, the command also gains a new 'tls' parameter to specify whether

[Qemu-devel] [PATCH 7/9] qxl: drop vram bar minimum size

2012-02-21 Thread Gerd Hoffmann
There is no reason to require a minimum size of 16 MB for the vram. Lower the limit to 4096 (one page). Make it disapper completely would break guests. --- hw/qxl.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 5c6b556..4de4b8d 100644 --- a/

  1   2   >