Re: [Qemu-devel] [QEMU] net: adapt dump to support the new syntax

2012-02-04 Thread Benjamin
On 01/24/12 20:58, Markus Armbruster wrote: Stefan Hajnoczi writes: On Tue, Jan 24, 2012 at 6:22 PM, Benjamin wrote: Hello Stefan, Hi, Please send QEMU development emails to the mailing list so others can help or we can avoid duplicating work in case someone else is already looking into th

[Qemu-devel] QEMU for ARM920T

2012-02-04 Thread Rashmi J K
Hello Can I run code compiled for ARM920T core in QEMU? I am learning Embedded Linux for ARM processor. This is very crucial for my studies. In future will have to work on AT91RM9200 atmel board with ARM920T cpu. Embedded Linux version that I am working on is 2.6.17. I am struggling to set up an

[Qemu-devel] buildbot failure in qemu on default_x86_64_fedora16

2012-02-04 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_fedora16 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_fedora16/builds/164 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_fedor

Re: [Qemu-devel] sigaltstack bug in qemu (testing on qemu-ppc)

2012-02-04 Thread Peter Maydell
On 4 February 2012 14:26, Alex Barcelo wrote: > I am barely able to understand this inline function: > > static inline int sas_ss_flags(unsigned long sp) > { >    return (target_sigaltstack_used.ss_size == 0 ? SS_DISABLE >            : on_sig_stack(sp) ? SS_ONSTACK : 0); > } > (signal.c @97) > > .

[Qemu-devel] [PATCH] cpu-exec.c: Correct comment about this file and indentation cleanup

2012-02-04 Thread 陳韋任
Each target use #define marco (in target-xxx/cpu.h) to rename cpu_exec (cpu-exec.c) to cpu_xxx_exec, then defines its own cpu_loop which calls cpu_xxx_exec. So basically, cpu-exec.c is not i386 (only) emulator main execution loop. This patch correctes the comment of this file and does indentation

[Qemu-devel] Support for multiboot images in elf64 (EM_X86_64) format

2012-02-04 Thread Goswin von Brederlow
Hi, starting your own toy kernel is a fun thing to do and there are many tutorials out there on how to do it. Unfortunately when one wants to write a kernel in 64bit it becomes much harder because one can't compile 64bit code as elf32 image and converting a elf64 image to elf32 format is a maj

[Qemu-devel] Fwd: oVirt Beijing - March 21st

2012-02-04 Thread Itamar Heim
Original Message Subject: oVirt Beijing - March 21st Date: Fri, 03 Feb 2012 15:52:41 -0500 From: Carl Trieloff Spread the word/ come join us! http://www.ovirt.org/news-and-events/workshop/ Carl

Re: [Qemu-devel] [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15

2012-02-04 Thread Vadim Rozenfeld
Thanks, I'll check this problem. Vadim. - Original Message - From: "Charles.Tsai-蔡清海-研究發展部" To: "Charles.Tsai-蔡清海-研究發展部" , "Vadim Rozenfeld" Cc: "Michael Roth" , "Stefan Hajnoczi" , spice-de...@lists.freedesktop.org, "Alex Huang-黃必賢-研究發展部" , "Alon Levy" , "qemu-devel" , "Paul Lu-盧偉智-

Re: [Qemu-devel] [PATCH] Fix memory dirty getting API change fallout

2012-02-04 Thread Jan Kiszka
On 2012-02-04 18:39, Blue Swirl wrote: > Fix confusion in length calculation in commit > cd7a45c95ecf2404810f3c6becb7cb83c5010ad8. > > Reported-by: Jan Kiszka > Signed-off-by: Blue Swirl > --- > hw/framebuffer.c |2 +- > hw/sm501.c |4 ++-- > hw/vga.c |2 +- > 3 files

[Qemu-devel] [PATCH] Fix memory dirty getting API change fallout

2012-02-04 Thread Blue Swirl
Fix confusion in length calculation in commit cd7a45c95ecf2404810f3c6becb7cb83c5010ad8. Reported-by: Jan Kiszka Signed-off-by: Blue Swirl --- hw/framebuffer.c |2 +- hw/sm501.c |4 ++-- hw/vga.c |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/f

Re: [Qemu-devel] [PATCH] usb-bsd: convert to QOM

2012-02-04 Thread Blue Swirl
On Sat, Feb 4, 2012 at 17:26, Blue Swirl wrote: > On Sat, Feb 4, 2012 at 17:07, Anthony Liguori wrote: >> On 02/04/2012 05:54 AM, Blue Swirl wrote: >>> >>> On Fri, Feb 3, 2012 at 23:41, Anthony Liguori  wrote: Untested but simple enough. Signed-off-by: Anthony Liguori >>> >>>

Re: [Qemu-devel] [PATCH] usb-bsd: convert to QOM

2012-02-04 Thread Blue Swirl
On Sat, Feb 4, 2012 at 17:07, Anthony Liguori wrote: > On 02/04/2012 05:54 AM, Blue Swirl wrote: >> >> On Fri, Feb 3, 2012 at 23:41, Anthony Liguori  wrote: >>> >>> Untested but simple enough. >>> >>> Signed-off-by: Anthony Liguori >> >> >> There are still some problems, though build does not fail

Re: [Qemu-devel] [PATCH 01/16] qdev: fix hot-unplug

2012-02-04 Thread Anthony Liguori
On 02/04/2012 12:51 AM, Paolo Bonzini wrote: On 02/04/2012 04:03 AM, Anthony Liguori wrote: There's no object_ref() in qdev_device_add(). The 2 references come from adding a child link to /peripheral and via object_new(). Sure, but there's when the object_new() reference becomes unreachable. A

Re: [Qemu-devel] [PATCH] usb-bsd: convert to QOM

2012-02-04 Thread Anthony Liguori
On 02/04/2012 05:54 AM, Blue Swirl wrote: On Fri, Feb 3, 2012 at 23:41, Anthony Liguori wrote: Untested but simple enough. Signed-off-by: Anthony Liguori There are still some problems, though build does not fail anymore: CCusb-bsd.o /src/qemu/usb-bsd.c:417: warning: initialization fro

Re: [Qemu-devel] [PATCH 0/6] VGA patches

2012-02-04 Thread Blue Swirl
On Sat, Feb 4, 2012 at 16:16, Jan Kiszka wrote: > On 2012-02-04 14:15, Blue Swirl wrote: >> On Sun, Jan 29, 2012 at 19:12, Blue Swirl wrote: >>> Patch 1 has been sent several times, though the logic has been copied >>> from flawed implementations before. >>> >>> Other patches should be trivial. >

Re: [Qemu-devel] [PATCH 0/6] VGA patches

2012-02-04 Thread Jan Kiszka
On 2012-02-04 14:15, Blue Swirl wrote: > On Sun, Jan 29, 2012 at 19:12, Blue Swirl wrote: >> Patch 1 has been sent several times, though the logic has been copied >> from flawed implementations before. >> >> Other patches should be trivial. > > Pushed. I compared vga.o object files with codiff an

Re: [Qemu-devel] [PATCH v2 0/8] qemu-ga: add support for Windows

2012-02-04 Thread Kevin O'Connor
On Fri, Feb 03, 2012 at 05:16:27PM -0200, Luiz Capitulino wrote: > On Fri, 03 Feb 2012 11:23:05 -0600 > Michael Roth wrote: > > I'd been tracking Gerd's QMP wakeup series as the s3 resolution we need > > for guest-suspend, is that still the case? > > Yes. But now I remembered about a seabios bug

[Qemu-devel] [PATCH v3] memory-region: Report if region is read-only or write-only on info mtree

2012-02-04 Thread Jan Kiszka
From: Jan Kiszka Helpful to understand guest configurations of things like the i440FX's PAM or the state of ROM devices. Signed-off-by: Jan Kiszka --- Changes in v3: - refactored writable condition (which DO makes sense as a ROM device is either in ROM or in write mode. It's readable and w

Re: [Qemu-devel] [PATCH v2] memory-region: Report if region is read-only or write-only on info mtree

2012-02-04 Thread Blue Swirl
On Sat, Feb 4, 2012 at 14:57, Jan Kiszka wrote: > From: Jan Kiszka > > Helpful to understand guest configurations of things like the i440FX's > PAM or the state of ROM devices. > > Signed-off-by: Jan Kiszka > --- > > Changes in v2: >  - encode R and W separately >  - print ROMD memory region sta

[Qemu-devel] [PATCH] cfi02: Fix lazy ROMD switching - once again

2012-02-04 Thread Jan Kiszka
The conversion to memory regions broke lazy ROMD switching by forgetting to update the rom_mode state variable. Signed-off-by: Jan Kiszka --- hw/pflash_cfi02.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pflash_cfi02.c b/hw/pflash_cfi02.c index a9e88b9..2ca0fd4 10

[Qemu-devel] [PATCH v2] memory-region: Report if region is read-only or write-only on info mtree

2012-02-04 Thread Jan Kiszka
From: Jan Kiszka Helpful to understand guest configurations of things like the i440FX's PAM or the state of ROM devices. Signed-off-by: Jan Kiszka --- Changes in v2: - encode R and W separately - print ROMD memory region state as well memory.c | 14 +++--- 1 files changed, 11 ins

Re: [Qemu-devel] [PATCH] memory-region: Report if region is read-only on info mtree

2012-02-04 Thread Jan Kiszka
On 2012-02-04 13:32, Blue Swirl wrote: > On Sat, Feb 4, 2012 at 12:23, Jan Kiszka wrote: >> On 2012-02-04 13:12, Blue Swirl wrote: >>> On Fri, Feb 3, 2012 at 12:02, Jan Kiszka wrote: Helpful to understand guest configurations of things like the i440FX's PAM. Signed-off-by: Jan

Re: [Qemu-devel] [PATCH 06/15] target-lm32: Clean includes

2012-02-04 Thread Michael Walle
Am Donnerstag 02 Februar 2012, 22:12:48 schrieb Stefan Weil: > config.h was missing in cpu.h. > > Cc: Michael Walle > Signed-off-by: Stefan Weil > --- > target-lm32/cpu.h |1 + > target-lm32/helper.c|5 - > target-lm32/translate.c |8 > 3 files changed, 1 inse

[Qemu-devel] sigaltstack bug in qemu (testing on qemu-ppc)

2012-02-04 Thread Alex Barcelo
I am barely able to understand this inline function: static inline int sas_ss_flags(unsigned long sp) { return (target_sigaltstack_used.ss_size == 0 ? SS_DISABLE : on_sig_stack(sp) ? SS_ONSTACK : 0); } (signal.c @97) ... and it seems wrong to me when used in the following function

Re: [Qemu-devel] [PATCH 3/3] vmmouse: replace PROP_PTR property with gpio pin to i8042

2012-02-04 Thread Paolo Bonzini
On 02/04/2012 02:03 PM, Gerhard Wiesinger wrote: Hello Paolo, What will be fixed/enhanced by this patch? Scenario? Nothing, it's just a cleanup. It's a step towards removing PROP_PTR. Paolo

Re: [Qemu-devel] [PATCH 0/6] VGA patches

2012-02-04 Thread Blue Swirl
On Sun, Jan 29, 2012 at 19:12, Blue Swirl wrote: > Patch 1 has been sent several times, though the logic has been copied > from flawed implementations before. > > Other patches should be trivial. Pushed. I compared vga.o object files with codiff and objdump disassembler before and after the const

Re: [Qemu-devel] [PATCH 3/3] vmmouse: replace PROP_PTR property with gpio pin to i8042

2012-02-04 Thread Gerhard Wiesinger
Hello Paolo, What will be fixed/enhanced by this patch? Scenario? Can you also add a more detailed commit message. Thnx. Ciao, Gerhard -- http://www.wiesinger.com/ On Sat, 4 Feb 2012, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- hw/pc.c |7 +++ hw/pc.h |1 -

[Qemu-devel] Windows Guest .inf File for -std vga?

2012-02-04 Thread Erik Rull
Hi all, is there a .inf file that makes a Windows XP guest no longer complaining about the missing drivers for the qemu host option -vga std? I tried several manual Windows .inf file copies / merges, but either the exclamation mark in the Device Manager persisted or it falls back to 640x480

Re: [Qemu-devel] [PULL] [PATCH 00/19] linux-user update

2012-02-04 Thread Blue Swirl
Thanks, pulled. On Fri, Feb 3, 2012 at 14:49, wrote: > From: Riku Voipio > > The following changes since commit d34e8f6e9d3a396c3327aa9807c83f9e1f4a7bd7: > >  main-loop: For tools, initialize timers as part of qemu_init_main_loop() > (2012-02-01 14:45:02 -0600) > > are available in the git rep

Re: [Qemu-devel] [PATCH] memory-region: Report if region is read-only on info mtree

2012-02-04 Thread Blue Swirl
On Sat, Feb 4, 2012 at 12:23, Jan Kiszka wrote: > On 2012-02-04 13:12, Blue Swirl wrote: >> On Fri, Feb 3, 2012 at 12:02, Jan Kiszka wrote: >>> Helpful to understand guest configurations of things like the i440FX's >>> PAM. >>> >>> Signed-off-by: Jan Kiszka >>> --- >>>  memory.c |    6 -- >>

Re: [Qemu-devel] [PATCH] memory-region: Report if region is read-only on info mtree

2012-02-04 Thread Jan Kiszka
On 2012-02-04 13:12, Blue Swirl wrote: > On Fri, Feb 3, 2012 at 12:02, Jan Kiszka wrote: >> Helpful to understand guest configurations of things like the i440FX's >> PAM. >> >> Signed-off-by: Jan Kiszka >> --- >> memory.c |6 -- >> 1 files changed, 4 insertions(+), 2 deletions(-) >> >> d

Re: [Qemu-devel] [PATCH] memory-region: Report if region is read-only on info mtree

2012-02-04 Thread Blue Swirl
On Fri, Feb 3, 2012 at 12:02, Jan Kiszka wrote: > Helpful to understand guest configurations of things like the i440FX's > PAM. > > Signed-off-by: Jan Kiszka > --- >  memory.c |    6 -- >  1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/memory.c b/memory.c > index ee4c98a..e

Re: [Qemu-devel] [PATCH] usb-bsd: convert to QOM

2012-02-04 Thread Blue Swirl
On Fri, Feb 3, 2012 at 23:41, Anthony Liguori wrote: > Untested but simple enough. > > Signed-off-by: Anthony Liguori There are still some problems, though build does not fail anymore: CCusb-bsd.o /src/qemu/usb-bsd.c:417: warning: initialization from incompatible pointer type /src/qemu/usb

Re: [Qemu-devel] [PATCH] w32: Fix build with new net bridge code

2012-02-04 Thread Blue Swirl
Thanks, applied. On Sat, Feb 4, 2012 at 08:24, Stefan Weil wrote: > Commit a7c36ee4920ea3acc227a0248dd161693f207357 added code for a net > bridge and explicitly said that "this is very Linux centric". > > Indeed, compilation failed for w32, so the bridge code is now > conditional. Hosts which don

[Qemu-devel] [PATCH] ppc: remove unused variables

2012-02-04 Thread Blue Swirl
Fix this error: /src/qemu/target-ppc/helper.c: In function 'booke206_tlb_to_page_size': /src/qemu/target-ppc/helper.c:1296:14: error: variable 'tlbncfg' set but not used [-Werror=unused-but-set-variable] Signed-off-by: Blue Swirl --- target-ppc/helper.c |3 --- 1 files changed, 0 insertions(

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add hw/highbank.c maintainer

2012-02-04 Thread Andreas Färber
Am 04.02.2012 03:43, schrieb Peter Maydell: > On 3 February 2012 20:58, Mark Langsdorf wrote: >> Signed-off-by: Mark Langsdorf >> --- >> MAINTAINERS |5 + >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 173e893..bdc254f 100644 >>

Re: [Qemu-devel] building qemu on Oracle Solaris 11 x64

2012-02-04 Thread Blue Swirl
2012/1/31 Günther Schmidt : > Hi everyone, > > I'm trying to build qemu on Oracle Solars 11 x64. I've figure out that I > need to set the --disable-guest-agent for ./configure, but there are other > errors I do not know how to fix. > > Setting LD_LIBRARY_PATH to /usr/lib/mps/amd64 helps but at leas

Re: [Qemu-devel] [PATCH] This patch is used to move some struct definition, like QEMUTimer, QEMUClock, from .c to .h.

2012-02-04 Thread Blue Swirl
On Tue, Jan 31, 2012 at 06:56, Wei Yang wrote: > Tested on i386 platform. > > Signed-off-by: Wei Yang Nack. Definitions should reside in files where they are used, only in header files when they are used by multiple sources. > --- >  qemu-timer.c |   40 >

Re: [Qemu-devel] [PULL 00/21] ppc patch queue 2012-02-02

2012-02-04 Thread Blue Swirl
On Thu, Feb 2, 2012 at 01:49, Alexander Graf wrote: > Hi Blue / Aurelien, > > This is my current patch queue for ppc. Please pull. Thanks, pulled. > Alex > > > The following changes since commit d34e8f6e9d3a396c3327aa9807c83f9e1f4a7bd7: >  Michael Roth (1): >        main-loop: For tools, initial

[Qemu-devel] [PATCH v2 19/27] qdev: remove parse/print methods for pointer properties

2012-02-04 Thread Paolo Bonzini
Pointer properties (except for PROP_PTR of course) should not need a legacy counterpart. In the future, relative paths will ensure that QEMU will support the same syntax as now for drives etc.. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 128

[Qemu-devel] [PATCH v2 23/27] qdev: inline qdev_prop_set into qdev_prop_set_ptr

2012-02-04 Thread Paolo Bonzini
qdev_prop_set is not needed anymore except for hacks, simplify it and inline it. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 26 +++--- 1 files changed, 7 insertions(+), 19 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 5a11676..b3c

[Qemu-devel] [PATCH v2 22/27] qdev: access properties via QOM

2012-02-04 Thread Paolo Bonzini
Do not poke anymore in the struct when accessing qdev properties. Instead, ask the object to set the right value. Signed-off-by: Paolo Bonzini --- hw/qdev-addr.c |5 ++- hw/qdev-properties.c | 78 ++--- hw/qdev.h|4 +-- 3 fi

[Qemu-devel] [PATCH v2 11/27] qom: fix canonical paths vs. interfaces

2012-02-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qom/object.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/qom/object.c b/qom/object.c index 75be582..e8418bc 100644 --- a/qom/object.c +++ b/qom/object.c @@ -819,6 +819,12 @@ void object_property_add_child(Object *obj, const c

[Qemu-devel] [PATCH v2 18/27] qdev: make the non-legacy pci address property accept an integer

2012-02-04 Thread Paolo Bonzini
PCI addresses are set with qdev_prop_uint32. Thus we make the QOM property accept a device and function encoded in an 8-bit integer, instead of the magic dd.f hex string. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 28 +--- 1 files changed, 9 insertions(+),

[Qemu-devel] [PATCH v2 14/27] qdev: allow reusing get/set for legacy property

2012-02-04 Thread Paolo Bonzini
In some cases, a legacy property does need a special print method but not a special parse method. In this case, we can reuse the get/set from the static (non-legacy) property. If neither parse nor print is needed, though, do not register the legacy property at all. The previous patch ensures tha

[Qemu-devel] [PATCH 1/3] smbus: fix writes

2012-02-04 Thread Paolo Bonzini
SMBus protocol sends offset and length before the actual data that is transferred. So we need to skip two bytes rather than one. Signed-off-by: Paolo Bonzini --- hw/smbus.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/smbus.c b/hw/smbus.c index 77626f3..4ff2

[Qemu-devel] [PATCH v2 04/27] qom: avoid useless conversions from string to type

2012-02-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qom/object.c | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/qom/object.c b/qom/object.c index 4d21f0a..a89e9e3 100644 --- a/qom/object.c +++ b/qom/object.c @@ -368,9 +368,10 @@ void object_delete(Object *obj) g_free(ob

[Qemu-devel] [PATCH v2 27/27] omap: remove PROP_PTR properties

2012-02-04 Thread Paolo Bonzini
Everything is already in place to turn the clock properties into links. Cc: Peter Maydell Signed-off-by: Paolo Bonzini --- hw/omap_clk.c |2 +- hw/omap_gpio.c | 46 -- hw/omap_intc.c | 26 +- 3 files changed, 46 insert

[Qemu-devel] [PATCH v2 01/27] qom: clean up cast macros

2012-02-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/qemu/object.h | 22 +++--- 1 files changed, 15 insertions(+), 7 deletions(-) diff --git a/include/qemu/object.h b/include/qemu/object.h index 9d0251d..ab1c48c 100644 --- a/include/qemu/object.h +++ b/include/qemu/object.h @@ -259,6 +259,

[Qemu-devel] [PATCH 3/3] vmmouse: replace PROP_PTR property with gpio pin to i8042

2012-02-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/pc.c |7 +++ hw/pc.h |1 - hw/pckbd.c |7 +-- hw/vmmouse.c | 11 +++ 4 files changed, 11 insertions(+), 15 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 7f3aa65..76787c7 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -1181,

[Qemu-devel] [PATCH v2 02/27] qom: more documentation on subclassing

2012-02-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/qemu/object.h | 76 +++-- 1 files changed, 73 insertions(+), 3 deletions(-) diff --git a/include/qemu/object.h b/include/qemu/object.h index ab1c48c..ad7d32d 100644 --- a/include/qemu/object.h +++ b/include/qe

[Qemu-devel] [PATCH v2 17/27] qdev: remove parse/print methods for mac properties

2012-02-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 61 ++--- 1 files changed, 42 insertions(+), 19 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index dea287a..42b9b24 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-prope

[Qemu-devel] [PATCH v2 09/27] qom: add object_resolve_path_type

2012-02-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/qemu/object.h | 25 +++-- qom/object.c | 26 ++ 2 files changed, 41 insertions(+), 10 deletions(-) diff --git a/include/qemu/object.h b/include/qemu/object.h index f36aff6..4ec7942 100644 --- a/incl

[Qemu-devel] [PATCH 2/3] smbus_eeprom: remove PTR property

2012-02-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/smbus.c|4 ++-- hw/smbus.h|4 ++-- hw/smbus_eeprom.c | 39 +-- 3 files changed, 25 insertions(+), 22 deletions(-) diff --git a/hw/smbus.c b/hw/smbus.c index 4ff2342..969d46d 100644 --- a/hw/smbus.c

[Qemu-devel] [PATCH v2 12/27] qom: add property get/set wrappers for links

2012-02-04 Thread Paolo Bonzini
These can set a link to any object, as long as it is included in the composition tree. Signed-off-by: Paolo Bonzini --- include/qemu/object.h | 24 qom/object.c | 25 + 2 files changed, 49 insertions(+), 0 deletions(-) diff --git a/i

[Qemu-devel] [PATCH v2 08/27] qom: fix off-by-one

2012-02-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qom/object.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qom/object.c b/qom/object.c index b26272f..314fc7a 100644 --- a/qom/object.c +++ b/qom/object.c @@ -871,7 +871,7 @@ static void object_set_link_property(Object *obj, Visitor *v

[Qemu-devel] [PATCH 0/3] Remove PROP_PTR, part 2/4

2012-02-04 Thread Paolo Bonzini
Part 1 is OMAP and is included in the qdev series. This one covers devices that should never have used PROP_PTR in the first place. The other parts will have to wait for QOMification of buses and CPUs. Paolo Bonzini (3): smbus: fix writes smbus_eeprom: remove PTR property vmmouse: replace P

[Qemu-devel] [PATCH v2 00/27] next steps for qdev & QOM

2012-02-04 Thread Paolo Bonzini
Here is the patch series from last thursday, on steroids. Patches 1 to 12 include the QOM parts of the previous series, plus other things I found after a more thorough code review. In particular I implemented the restriction of partial-path search to a particular type, fixed some problems with in

[Qemu-devel] [PATCH v2 13/27] qdev: remove direct calls to print/parse

2012-02-04 Thread Paolo Bonzini
There's no need to call into ->parse and ->print manually. The QOM legacy properties do that for us. Furthermore, in some cases legacy and static properties have exactly the same behavior, and we could drop the legacy properties right away. Add an appropriate fallback to prepare for this. Signed

[Qemu-devel] [PATCH v2 05/27] qom: do not include qdev header file

2012-02-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qom/object.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/qom/object.c b/qom/object.c index a89e9e3..c0f6d54 100644 --- a/qom/object.c +++ b/qom/object.c @@ -13,8 +13,6 @@ #include "qemu/object.h" #include "qemu-common.h" #include "

[Qemu-devel] [PATCH v2 21/27] qdev: fix off-by-one

2012-02-04 Thread Paolo Bonzini
Integer properties did not work. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index d69a987..debb37f 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-properties.c @@

[Qemu-devel] [PATCH v2 25/27] qdev: remove unused fields from PropertyInfo

2012-02-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/qdev-addr.c |2 -- hw/qdev-properties.c | 38 +- hw/qdev.h| 21 - 3 files changed, 1 insertions(+), 60 deletions(-) diff --git a/hw/qdev-addr.c b/hw/qdev-addr.c index 8daa733..0b

[Qemu-devel] [PATCH v2 15/27] qdev: remove parse method for string properties

2012-02-04 Thread Paolo Bonzini
We need the print method to put double quotes, but parsing is not special. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 11 --- 1 files changed, 0 insertions(+), 11 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 5e19ec8..1fc77b5 100644 --- a/hw/

[Qemu-devel] [PATCH v2 16/27] qdev: remove print/parse methods from LostTickPolicy properties

2012-02-04 Thread Paolo Bonzini
Also generalize the code so that we can have more enum properties in the future. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 62 +- hw/qdev.h|1 + qemu-common.h|1 + 3 files changed, 33 insertions(+), 31 de

[Qemu-devel] [PATCH v2 26/27] omap_clk: convert to QOM

2012-02-04 Thread Paolo Bonzini
Make the OMAP clocks QOM objects, so that they we can put them in a branch of the object graph and turn the pointer properties into links. As in the current code, the clocks are copied into a freshly allocated memory block when they are initialized. However, the "templates" now have a separate st

[Qemu-devel] [PATCH v2 10/27] qom: use object_resolve_path_type for links

2012-02-04 Thread Paolo Bonzini
This allows to restrict partial matches to objects of the expected type. It will let people use bare names to reference drives even though their name might be the same as a device's (e.g. -drive id=hd0,if=none,... -device ...,drive=hd0,id=hd0). As a useful byproduct, this fixes a problem with lin

[Qemu-devel] [PATCH v2 06/27] qom: add QObject-based property get/set wrappers

2012-02-04 Thread Paolo Bonzini
Move the creation of QmpInputVisitor and QmpOutputVisitor from qmp.c to qom/object.c, since it's the only practical way to access object properties. Signed-off-by: Paolo Bonzini --- include/qemu/qom-qobject.h | 43 +++ qmp.c | 18 +

Re: [Qemu-devel] buildbot failure in qemu on default_mingw32

2012-02-04 Thread Stefan Weil
Am 04.02.2012 00:43, schrieb Anthony Liguori: On 02/03/2012 06:11 PM, q...@buildbot.b1-systems.de wrote: The Buildbot has detected a new failure on builder default_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/16

[Qemu-devel] [PATCH v2 24/27] qdev: initialize properties via QOM

2012-02-04 Thread Paolo Bonzini
Similarly, use the object properties also to set the default values of the qdev properties. This requires reordering registration and initialization. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 29 ++--- hw/qdev.c|4 ++-- hw/qdev.h

[Qemu-devel] [PATCH v2 20/27] qdev: let QOM free properties

2012-02-04 Thread Paolo Bonzini
Drop the special free callback. Instead, register a "regular" release method in the non-legacy property. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 19 --- hw/qdev.c|8 +--- hw/qdev.h|2 +- 3 files changed, 14 insertions(+), 15

[Qemu-devel] [PATCH v2 03/27] qom: clean up/optimize object_dynamic_cast

2012-02-04 Thread Paolo Bonzini
The interface loop can be performed only on the parent object. It does not need to be done on each interface. Similarly, we can simplify the code by switching early from the implementation object to the parent object. Signed-off-by: Paolo Bonzini --- qom/object.c | 38 ++-

[Qemu-devel] [PATCH] w32: Fix build with new net bridge code

2012-02-04 Thread Stefan Weil
Commit a7c36ee4920ea3acc227a0248dd161693f207357 added code for a net bridge and explicitly said that "this is very Linux centric". Indeed, compilation failed for w32, so the bridge code is now conditional. Hosts which don't support it can simply remove the definition of CONFIG_NET_BRIDGE. Signed-

[Qemu-devel] [PATCH v2 07/27] qom: add property get/set wrappers for C types

2012-02-04 Thread Paolo Bonzini
Add wrappers that let you get/set properties using normal C data types. Signed-off-by: Paolo Bonzini --- include/qemu/object.h | 70 + qom/object.c | 119 + 2 files changed, 180 insertions(+), 9 deletions(-)