Re: [Qemu-devel] [PATCH 22/23] container: make a decendent of Object

2012-01-30 Thread Paolo Bonzini
On 01/30/2012 10:09 PM, Anthony Liguori wrote: diff --git a/qom/container.c b/qom/container.c new file mode 100644 index 000..39d7b1e --- /dev/null +++ b/qom/container.c @@ -0,0 +1,15 @@ +#include "qemu/object.h" +#include "module.h" + +static TypeInfo container_info = { +.name =

Re: [Qemu-devel] [PATCH 21/23] object: sure up reference counting

2012-01-30 Thread Paolo Bonzini
On 01/30/2012 10:08 PM, Anthony Liguori wrote: Now we have the following behavior: 1) object_new() returns an object with ref = 1 2) object_initialize() does not increase the reference count (ref may be 0). 3) object_deref() will finalize the object when ref = 0. it does not free the memory

Re: [Qemu-devel] [PATCH 17/23] qom: move properties from qdev to object

2012-01-30 Thread Paolo Bonzini
On 01/30/2012 10:08 PM, Anthony Liguori wrote: This is mostly code movement although not entirely. This makes properties part of the Object base class which means that we can now start using Object in a meaningful way outside of qdev. Can we move them to an intermediate base class? I would li

Re: [Qemu-devel] [PATCH 10/23] qdev: remove baked in notion of aliases

2012-01-30 Thread Paolo Bonzini
On 01/30/2012 10:08 PM, Anthony Liguori wrote: +/* + * Aliases were a bad idea from the start. Let's keep them + * from spreading further. + */ +static const char *qdev_class_get_alias(DeviceClass *dc) +{ +const char *typename = object_class_get_name(OBJECT_CLASS(dc)); + +if (strcmp(type

Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock

2012-01-30 Thread Paolo Bonzini
On 01/30/2012 08:28 PM, Anthony Liguori wrote: I see. It shouldn't surprise you that I completely disagree with Anthony on this. :) Give me some credit at least... The original patches didn't disable the RTC, it introduced a half-neutered Xen specific RTC. Ah. :) My original suggestion (w

Re: [Qemu-devel] [PATCH 0/4] Use rtc_clock uniformly for ARM

2012-01-30 Thread Paolo Bonzini
On 01/30/2012 06:21 PM, Peter Maydell wrote: My timer-fu is weak so I'm not going to claim to have actually reviewed these, but they don't look to be obviously wrong. Are you hoping for these to go in via the arm-devs tree? Yes... You'll need to rebase following the QOM series landing. Gah,

Re: [Qemu-devel] Why QEMUClock is defined in qemu-timer.c?

2012-01-30 Thread Richard Yang
On Tue, Jan 31, 2012 at 01:12:24PM +0700, Mulyadi Santosa wrote: >Hi :) > >On Tue, Jan 31, 2012 at 12:55, Richard Yang wrote: >> >> Hi, experts >> >> I am just coming to the qemu world. >> >> While reading the code, I am wondering why put a struct definition in the >> c file? >> >> Seems there is

[Qemu-devel] [PATCH] w32: Initialise critical section before starting thread (fix #922131)

2012-01-30 Thread Stefan Weil
This patch was contributed by Bogdan Harjoc. I added some assertions. Signed-off-by: Stefan Weil --- qemu-thread-win32.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/qemu-thread-win32.c b/qemu-thread-win32.c index fe9b931..3524c8b 100644 --- a/qemu-thread-win3

Re: [Qemu-devel] Why QEMUClock is defined in qemu-timer.c?

2012-01-30 Thread Mulyadi Santosa
Hi :) On Tue, Jan 31, 2012 at 12:55, Richard Yang wrote: > > Hi, experts > > I am just coming to the qemu world. > > While reading the code, I am wondering why put a struct definition in the > c file? > > Seems there is no error in compile, while I felt it is not a proper way > to do it. maybe

[Qemu-devel] Why QEMUClock is defined in qemu-timer.c?

2012-01-30 Thread Richard Yang
Hi, experts I am just coming to the qemu world. While reading the code, I am wondering why put a struct definition in the c file? Seems there is no error in compile, while I felt it is not a proper way to do it. -- Richard Yang Help you, Help me

[Qemu-devel] [Bug 899140] Re: Problem with Linux Kernel Traffic Control

2012-01-30 Thread Henrique Rodrigues
Hi, I figured out what was the problem. It seems that the pkts generated by each guest iperf command is bigger than the default qdisc mtu of 2kb (the pkts have length of 65k). If you set a higher qdisc mtu (=65k) the traffic should be controlled as expected. Henrique -- You received this bug n

Re: [Qemu-devel] [PATCH] rtl8139: honor RxOverflow flag in can_receive method

2012-01-30 Thread Fernando Luis Vázquez Cao
(2012年01月31日 13:12), Igor Kovalenko wrote: 2012/1/30 Fernando Luis Vázquez Cao: Some drivers (Linux' 8139too among them) rely on the NIC injecting an interrupt in the event of a receive buffer overflow and, accordingly, set the RxOverflow bit in the interrupt mask. Unfortunately rtl8139's can_re

[Qemu-devel] buildbot failure in qemu on pci_x86_64_debian_6_0

2012-01-30 Thread qemu
The Buildbot has detected a new failure on builder pci_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/pci_x86_64_debian_6_0/builds/168 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Re

[Qemu-devel] buildbot failure in qemu on pci_i386_debian_6_0

2012-01-30 Thread qemu
The Buildbot has detected a new failure on builder pci_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/pci_i386_debian_6_0/builds/169 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Reason

[Qemu-devel] [PATCH 6/7] PPC: E500: Implement msgsnd

2012-01-30 Thread Alexander Graf
This patch implements the msgsnd instruction. It is part of the Embedded.Processor Control specification and allows one CPU to IPI another CPU without going through an interrupt controller. Signed-off-by: Alexander Graf --- target-ppc/helper.h|1 + target-ppc/op_helper.c | 18 +

[Qemu-devel] [PATCH 7/7] PPC: e500mc: Enable processor control

2012-01-30 Thread Alexander Graf
The e500mc implements Embedded.Processor Control, so enable it and thus enable guests to IPI each other. This makes -smp work with -cpu e500mc. Signed-off-by: Alexander Graf --- target-ppc/translate_init.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-ppc/trans

[Qemu-devel] [PATCH 0/7] Enable doorbell for e500mc

2012-01-30 Thread Alexander Graf
On e500mc we need to implement the doorbell / processor control / msgsnd instructions to allow for smp with Linux guests. This patch set implements everything necessary for this to work. Alexander Graf (7): PPC: E500: Add some more excp vectors PPC: E500: Add doorbell defines PPC: Add CPU fe

[Qemu-devel] [PATCH 3/7] PPC: Add CPU feature for processor control

2012-01-30 Thread Alexander Graf
We're soon going to implement processor control features. Add the feature flag, so we're well prepared. Signed-off-by: Alexander Graf --- target-ppc/cpu.h |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h index f9cea3d..fbcf488 100644

[Qemu-devel] [PATCH 2/7] PPC: E500: Add doorbell defines

2012-01-30 Thread Alexander Graf
We're going to introduce doorbell instructions (called processor control in the spec) soon. Add some defines for easier patch readability later. Signed-off-by: Alexander Graf --- target-ppc/cpu.h | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/target-ppc/

[Qemu-devel] [PATCH 5/7] PPC: E500: Implement msgclr

2012-01-30 Thread Alexander Graf
This patch implements the msgclr instruction. It is part of the Embedded.Processor Control specification and clears pending doorbell interrupts on the current CPU. Signed-off-by: Alexander Graf --- target-ppc/helper.h|1 + target-ppc/op_helper.c | 35 +++

[Qemu-devel] [PATCH] PPC: E500: Populate L1CFG0 SPR

2012-01-30 Thread Alexander Graf
When running Linux on e500 with powersave-nap enabled, Linux tries to read out the L1CFG0 register and calculates some things from it. Passing 0 there ends up in a division by 0, resulting in -1, resulting in badness. So let's populate the L1CFG0 register with reasonable defaults. That way guests

[Qemu-devel] [PATCH 1/7] PPC: E500: Add some more excp vectors

2012-01-30 Thread Alexander Graf
Our EXCP list is getting outdated. By now, 3 new exception vectors have been introduced. Update the list so we have everything at one place. Signed-off-by: Alexander Graf --- target-ppc/cpu.h |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/target-ppc/cpu.h b/target-p

[Qemu-devel] [PATCH 4/7] PPC: Enable doorbell excp handlers

2012-01-30 Thread Alexander Graf
We already had all the code available to have doorbell exceptions be handled properly. It was just disabled. Enable it, so we can rely on it. Signed-off-by: Alexander Graf --- target-ppc/helper.c | 16 ++-- 1 files changed, 2 insertions(+), 14 deletions(-) diff --git a/target-ppc

[Qemu-devel] [Bug 912612] Re: rhel5u5 guest panic when booting up

2012-01-30 Thread Yongjie Ren
Already fixed. pls. track the following bug. https://bugzilla.kernel.org/show_bug.cgi?id=42563 ** Bug watch added: Linux Kernel Bug Tracker #42563 http://bugzilla.kernel.org/show_bug.cgi?id=42563 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscr

Re: [Qemu-devel] [RFC][PATCH 09/15] introduce a new monitor command 'dump' to dump guest's memory

2012-01-30 Thread Wen Congyang
At 01/31/2012 01:19 AM, Eric Blake Wrote: > On 01/29/2012 10:36 PM, Wen Congyang wrote: +++ b/hmp-commands.hx @@ -828,6 +828,22 @@ new parameters (if specified) once the vm migration finished successfully. ETEXI { +.name = "dump", +

Re: [Qemu-devel] [RFC][PATCH 00/15 v5] introducing a new, dedicated memory dump mechanism

2012-01-30 Thread Wen Congyang
At 01/31/2012 01:38 AM, Eric Blake Wrote: > On 01/29/2012 10:40 PM, Wen Congyang wrote: Yes, it may tak a lot of time. But we dump a guest memory when the guest panics, and there is no need to continue to run the guest. >>> >>> Would it be possible to have both a dump from a certain point

Re: [Qemu-devel] [PATCH] rtl8139: honor RxOverflow flag in can_receive method

2012-01-30 Thread Fernando Luis Vázquez Cao
Hi Igor, Thank you for the prompt reply. I really appreciate it. (2012年01月31日 02:28), Igor Kovalenko wrote: 2012/1/30 Fernando Luis Vázquez Cao: Some drivers (Linux' 8139too among them) rely on the NIC injecting an interrupt in the event of a receive buffer overflow and, accordingly, set the

[Qemu-devel] [Bug 913774] Re: device can't be hot-removed from the guest

2012-01-30 Thread Yongjie Ren
fixed by the following commit. commit 024a6fbdb9d8cbc4d7f833b23db51c9d1004bc47 Author: Anthony Liguori Date: Fri Jan 13 07:45:55 2012 -0600 qdev: fix device_del by refactoring reference counting Commit 8eb0283 broken device_del by having too overzealous reference counting checks.

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-01-30 Thread Alexander Graf
On 31.01.2012, at 00:53, Anthony Liguori wrote: > On 01/30/2012 05:41 PM, Andreas Färber wrote: >> Am 30.01.2012 19:55, schrieb Juan Quintela: >>> Please send in any agenda items you are interested in covering. >> >> QOM roadmap update: >> * Series 3/4 is on the list. >> -> Please officially de

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-01-30 Thread Anthony Liguori
On 01/30/2012 05:41 PM, Andreas Färber wrote: Am 30.01.2012 19:55, schrieb Juan Quintela: Please send in any agenda items you are interested in covering. QOM roadmap update: * Series 3/4 is on the list. -> Please officially designate a merge date (Friday?). -> To make review sensible, I ask

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-01-30 Thread Andreas Färber
Am 30.01.2012 19:55, schrieb Juan Quintela: > Please send in any agenda items you are interested in covering. QOM roadmap update: * Series 3/4 is on the list. -> Please officially designate a merge date (Friday?). -> To make review sensible, I ask for a hard device freeze until merged. I.e., no

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2012-01-30 Thread David Gibson
On Wed, Jan 25, 2012 at 04:44:53PM -0700, Alex Williamson wrote: > On Wed, 2012-01-25 at 14:13 +1100, David Gibson wrote: > > On Tue, Dec 20, 2011 at 09:30:37PM -0700, Alex Williamson wrote: > > > On Wed, 2011-12-21 at 14:32 +1100, David Gibson wrote: > > > > On Mon, Dec 19, 2011 at 04:41:56PM +010

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2012-01-30 Thread Serge Hallyn
** Changed in: qemu-kvm (Ubuntu Lucid) Status: Won't Fix => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/524447 Title: virsh save is very slow Status in libvirt virtualization API: U

Re: [Qemu-devel] [PATCH 00/23] qom: use Type system to register all devices

2012-01-30 Thread Anthony Liguori
On 01/30/2012 03:16 PM, Anthony Liguori wrote: (Sorry for not posting this correctly, I didn't want to spam the list with a second submission) This is the 3rd QOM series. I decided to post this even though there's a known issue with device_del as I wanted to give people more time to review what'

Re: [Qemu-devel] [PATCH 08/23] qdev: register all types natively through QEMU Object Model

2012-01-30 Thread Anthony Liguori
On 01/30/2012 04:29 PM, Peter Maydell wrote: On 30 January 2012 21:08, Anthony Liguori wrote: This was done in a mostly automated fashion. I did it in three steps and then rebased it into a single step which avoids repeatedly touching every file in the tree. The first step was a sed-based add

[Qemu-devel] [PATCH] ATA: Allow WIN_SECURITY_FREEZE_LOCK as nop

2012-01-30 Thread Alexander Graf
When using Windows 8 with an AHCI disk drive, it issues a blue screen. The reason is that WIN_SECURITY_FREEZE_LOCK / CFA_WEAR_LEVEL is not supported by our ATA implementation, but Windows expects it to be there. Since without security stuff implemented, the lock would be a nop anyway and CFA_WEAR_

Re: [Qemu-devel] [PATCH 03/23] qdev: make DeviceInfo private

2012-01-30 Thread Andreas Färber
Am 30.01.2012 22:08, schrieb Anthony Liguori: > Introduce accessors and remove any code that directly accesses DeviceInfo > members. > > Signed-off-by: Anthony Liguori Reviewed-by: Andreas Färber /-F -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer

Re: [Qemu-devel] [PATCH 08/23] qdev: register all types natively through QEMU Object Model

2012-01-30 Thread Peter Maydell
On 30 January 2012 21:08, Anthony Liguori wrote: > This was done in a mostly automated fashion.  I did it in three steps and then > rebased it into a single step which avoids repeatedly touching every file in > the tree. > > The first step was a sed-based addition of the parent type to the subclas

[Qemu-devel] [PATCH] AHCI: Fix port reset race

2012-01-30 Thread Alexander Graf
bdrv_aio_cancel() can trigger bdrv_aio_flush() which makes all aio that is currently in flight finish. So what we do is: port reset detect ncq in flight cancel ncq delete ncq sg list at which point we have double freed the sg list. Instead, with this patch we do: port reset detect nc

[Qemu-devel] [PATCH] AHCI: Masking of IRQs actually masks them

2012-01-30 Thread Alexander Graf
When masking IRQ lines, we should actually mask them out and not declare them active anymore. Once we mask them in again, they are allowed to trigger again. Signed-off-by: Alexander Graf --- hw/ide/ahci.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/ide/ahci.c b/h

Re: [Qemu-devel] [PATCH] Init win32 CRITICAL_SECTION before starting thread; crash when attaching disks

2012-01-30 Thread Sebastian Herbszt
Stefan Weil wrote: Tested-by: Stefan Weil Hi Bogdan, I can confirm that your patch fixes a crash which otherwise makes QEMU unusable on Windows hosts. This patch likely fixes bug #922131 [1]. [1] https://bugs.launchpad.net/qemu/+bug/922131 Sebastian

[Qemu-devel] [PATCH 06/23] qdev: refactor device creation to allow bus_info to be set only in class

2012-01-30 Thread Anthony Liguori
As we use class_init to set class members, DeviceInfo no longer holds this information. Signed-off-by: Anthony Liguori --- hw/qdev.c | 42 +++--- 1 files changed, 19 insertions(+), 23 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index c9f890c..bba84e2 10

[Qemu-devel] [PATCH 14/23] qdev: refactor away qdev_create_from_info

2012-01-30 Thread Anthony Liguori
Note that the FIXME gets fixed in series 4/4. We need to convert BusState to QOM before we can make parent_bus a link. Signed-off-by: Anthony Liguori --- hw/qdev.c | 35 ++- hw/qdev.h |3 +++ 2 files changed, 25 insertions(+), 13 deletions(-) diff --git a/

[Qemu-devel] [PATCH 03/23] qdev: make DeviceInfo private

2012-01-30 Thread Anthony Liguori
Introduce accessors and remove any code that directly accesses DeviceInfo members. Signed-off-by: Anthony Liguori --- hw/pci.c | 13 - hw/qdev-properties.c |4 ++-- hw/qdev.c| 30 +- hw/qdev.h| 24 +

[Qemu-devel] [PATCH 18/23] qom: accept any compatible type when setting a link property

2012-01-30 Thread Anthony Liguori
Links had limited utility before as they only allowed a concrete type to be specified. Now we can support abstract types and interfaces which means it's now possible to have a link. Signed-off-by: Anthony Liguori --- qom/object.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-

[Qemu-devel] [PATCH 23/23] not-for-upstream: fix device_del

2012-01-30 Thread Anthony Liguori
This needs to be carefully merged back but I'm not 100% confident the problem is solved by this commit. --- hw/pci.c |1 + hw/qdev.c |1 + include/qemu/object.h |4 +++- qom/object.c | 13 ++--- 4 files changed, 15 insertions(+), 4 deletions(

[Qemu-devel] [PATCH 13/23] qdev: split out common init to instance_init

2012-01-30 Thread Anthony Liguori
This gets us closer to being able to object_new() a qdev type and have a functioning object verses having to call qdev_create(). Signed-off-by: Anthony Liguori --- hw/qdev.c | 41 - 1 files changed, 28 insertions(+), 13 deletions(-) diff --git a/hw/qdev

[Qemu-devel] [PATCH 16/23] qdev: nuke qdev_init_chardev()

2012-01-30 Thread Anthony Liguori
I'm sure the intentions were good here, but there's no reason this should be in qdev. Move it to qemu-char where it belongs. Signed-off-by: Anthony Liguori --- hw/etraxfs_ser.c |2 +- hw/lm32_juart.c |2 +- hw/lm32_uart.c |2 +- hw/milkymist-uart.c |2 +- hw/pl01

[Qemu-devel] [PATCH 09/23] qdev: kill of DeviceInfo

2012-01-30 Thread Anthony Liguori
It is no longer used in the tree since everything is done natively through QEMU Object Model. Signed-off-by: Anthony Liguori --- hw/i2c.c |2 +- hw/ide/qdev.c |2 +- hw/intel-hda.c |2 +- hw/isa-bus.c |2 +- hw/pci.c |2 +

[Qemu-devel] [PATCH 10/23] qdev: remove baked in notion of aliases

2012-01-30 Thread Anthony Liguori
Limit them to the device_add functionality. Device aliases were a hack based on the fact that virtio was modeled the wrong way. The mechanism for aliasing is very limited in that only one alias can exist for any device. We have to support it for the purposes of compatibility but we only need to

[Qemu-devel] [PATCH 01/23] usb-hid: simplify class initialization a bit

2012-01-30 Thread Anthony Liguori
We can probably model USBHidDevice as a base class to get even better code sharing but for now, just use a common function to initialize the common class members. Signed-off-by: Anthony Liguori --- hw/usb-hid.c | 27 +-- 1 files changed, 13 insertions(+), 14 deletions(-

[Qemu-devel] [PATCH 04/23] qdev: remove info from class

2012-01-30 Thread Anthony Liguori
Now DeviceInfo is no longer used after object construction. All of the relevant members have been moved to DeviceClass. Signed-off-by: Anthony Liguori --- hw/pci.c |4 ++- hw/qdev.c | 94 hw/qdev.h | 26 +--- 3 fi

[Qemu-devel] [PATCH 19/23] qdev: implement cleanup logic in finalize

2012-01-30 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/qdev.c | 57 - 1 files changed, 32 insertions(+), 25 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 91dbbc7..f04f0fa 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -246,31 +246,6 @@ void qdev_init_n

[Qemu-devel] [PATCH 20/23] info qdm: do not require a parent_bus to be set

2012-01-30 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/qdev-monitor.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c index 46946fe..66a6d55 100644 --- a/hw/qdev-monitor.c +++ b/hw/qdev-monitor.c @@ -165,12 +165,14 @@ int qdev_device_help(Q

[Qemu-devel] [PATCH 07/23] qdev: kill off DeviceInfo list

2012-01-30 Thread Anthony Liguori
Teach the various bits of code that need to walk through available devices to do so via QOM. Signed-off-by: Anthony Liguori --- hw/qdev.c | 87 + hw/qdev.h |2 - 2 files changed, 30 insertions(+), 59 deletions(-) diff --git a/hw/q

[Qemu-devel] [PATCH 22/23] container: make a decendent of Object

2012-01-30 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- Makefile.objs |2 +- hw/container.c| 29 - hw/qdev-monitor.c | 14 ++ qom/Makefile |2 +- qom/container.c | 15 +++ qom/object.c |9 - 6 files changed, 27 insertion

[Qemu-devel] [PATCH 12/23] qom: add new command to search for types

2012-01-30 Thread Anthony Liguori
This adds a command that allows searching for types that implement a property. This allows you to do things like search for all available PCIDevices. In the future, we'll also have a standard interface for things with a BlockDriverState property that a PCIDevice could implement. This will enable

[Qemu-devel] [PATCH 21/23] object: sure up reference counting

2012-01-30 Thread Anthony Liguori
Now we have the following behavior: 1) object_new() returns an object with ref = 1 2) object_initialize() does not increase the reference count (ref may be 0). 3) object_deref() will finalize the object when ref = 0. it does not free the memory associated with the object. 4) both link and chil

[Qemu-devel] [PATCH 05/23] qdev: allow classes to overload qdev functions

2012-01-30 Thread Anthony Liguori
This allows us to drop per-Device registration functions by allowing the class_init functions to overload qdev methods. Signed-off-by: Anthony Liguori --- hw/qdev.c | 53 + 1 files changed, 33 insertions(+), 20 deletions(-) diff --git a/hw/q

[Qemu-devel] [PATCH 15/23] qdev: split out UI portions into a new function

2012-01-30 Thread Anthony Liguori
qdev-monitor.c deals with the -device, device_add, and info qdm/qtree interfaces. Signed-off-by: Anthony Liguori --- Makefile.objs |2 +- hw/qdev-monitor.c | 587 + hw/qdev.c | 574 +

[Qemu-devel] [PATCH 11/23] qom: allow object_class_foreach to take additional parameters to refine search

2012-01-30 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/qdev.c |4 ++-- include/qemu/object.h |1 + qom/object.c | 18 -- 3 files changed, 19 insertions(+), 4 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 636b6b4..a7980c5 100644 --- a/hw/qdev.c +++ b/hw/qdev.

[Qemu-devel] [PATCH 00/23] qom: use Type system to register all devices

2012-01-30 Thread Anthony Liguori
(Sorry for not posting this correctly, I didn't want to spam the list with a second submission) This is the 3rd QOM series. I decided to post this even though there's a known issue with device_del as I wanted to give people more time to review what's going on here. The goal of this series i

Re: [Qemu-devel] [PATCH RFC 9/7] target-arm: Move CPU feature flags to class

2012-01-30 Thread Andreas Färber
Am 30.01.2012 00:50, schrieb Andreas Färber: > The internal CPU feature flags were only ever set in > cpu_reset_model_id(). Therefore move them into ARMCPUClass. Peter made me aware that this will not work for -cpu cortex-a9,-neon. The initial feature flags can be stored in ARMCPUClass but the act

Re: [Qemu-devel] [PATCH] m48t59: use rtc_clock for alarm timer

2012-01-30 Thread Blue Swirl
Thanks, applied. On Fri, Jan 20, 2012 at 12:05, Paolo Bonzini wrote: > This lets the RTC get adjustments from the host NTP client. > The watchdog still uses the vm_clock.  The previous behavior is > available with "-rtc clock=vm". > > Cc: Andreas Färber > Signed-off-by: Paolo Bonzini > --- >  h

Re: [Qemu-devel] [PATCH V2] GRLIB UART: Add RX channel

2012-01-30 Thread Blue Swirl
On Mon, Jan 30, 2012 at 09:22, Fabien Chouteau wrote: > On 28/01/2012 13:20, Blue Swirl wrote: >> On Thu, Jan 26, 2012 at 17:03, Fabien Chouteau wrote: >>> This patch implements the RX channel of GRLIB UART with a FIFO to >>> improve data rate. >>> >>> Signed-off-by: Fabien Chouteau >>> --- >>>

Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock

2012-01-30 Thread Anthony Liguori
On 01/30/2012 05:59 AM, Paolo Bonzini wrote: On 01/30/2012 12:56 PM, Stefano Stabellini wrote: > Depending on "-rtc clock=vm" or "-rtc clock=rt", this may not be true. Good point. I should check for rtc_clock == host_clock. > Why do you need to instantiate an RTC at all? I don't, in fact in

[Qemu-devel] KVM call agenda for tuesday 31

2012-01-30 Thread Juan Quintela
hi Please send in any agenda items you are interested in covering. Cheers, Juan.

Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock

2012-01-30 Thread Stefano Stabellini
On Mon, 30 Jan 2012, Paolo Bonzini wrote: > On 01/30/2012 12:56 PM, Stefano Stabellini wrote: > >> > Depending on "-rtc clock=vm" or "-rtc clock=rt", this may not be true. > > > > Good point. > > I should check for rtc_clock == host_clock. > > > >> > Why do you need to instantiate an RTC at all?

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Luiz Capitulino
On Mon, 30 Jan 2012 17:08:33 +0100 Michal Privoznik wrote: > On 30.01.2012 15:44, Luiz Capitulino wrote: > > On Mon, 30 Jan 2012 07:54:56 -0600 > > Anthony Liguori wrote: > > > >> On 01/30/2012 06:57 AM, Luiz Capitulino wrote: > >>> On Thu, 26 Jan 2012 16:57:01 -0600 > >>> Anthony Liguori wrot

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Luiz Capitulino
On Mon, 30 Jan 2012 11:07:10 -0600 Michael Roth wrote: > On 01/30/2012 09:58 AM, Eric Blake wrote: > > On 01/30/2012 07:44 AM, Luiz Capitulino wrote: > >> I think we should do the following then: > >> > >> 1. Drop the set-support-level command > >> 2. Split the guest-suspend command into gues

Re: [Qemu-devel] [RFC][PATCH 00/15 v5] introducing a new, dedicated memory dump mechanism

2012-01-30 Thread Eric Blake
On 01/29/2012 10:40 PM, Wen Congyang wrote: >>> Yes, it may tak a lot of time. But we dump a guest memory when the guest >>> panics, and there is no need to continue to run the guest. >> >> Would it be possible to have both a dump from a certain point in time >> and still allow the guest to run unp

[Qemu-devel] [Bug 918791] Re: qemu-kvm dies when using vmvga driver and unity in the guest

2012-01-30 Thread Kate Stewart
** Tags added: rls-mgr-p-tracking -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/918791 Title: qemu-kvm dies when using vmvga driver and unity in the guest Status in QEMU: New Status in “qemu-kvm

Re: [Qemu-devel] [PATCH 0/4] Use rtc_clock uniformly for ARM

2012-01-30 Thread Peter Maydell
On 30 January 2012 16:42, Paolo Bonzini wrote: > On 01/20/2012 01:06 PM, Paolo Bonzini wrote: >> This series uses rtc_clock uniformly in device models that provide RTC >> functionality.  This will let users choose the desired semantics for >> the clock. >> >> This is most important with qtest, whe

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Michael Roth
On 01/30/2012 09:58 AM, Eric Blake wrote: On 01/30/2012 07:44 AM, Luiz Capitulino wrote: I think we should do the following then: 1. Drop the set-support-level command 2. Split the guest-suspend command into guest-suspend-ram, guest-suspend-hybrid, guest-suspend-disk 3. Libvirt shou

Re: [Qemu-devel] [RFC][PATCH 09/15] introduce a new monitor command 'dump' to dump guest's memory

2012-01-30 Thread Eric Blake
On 01/29/2012 10:36 PM, Wen Congyang wrote: >>> +++ b/hmp-commands.hx >>> @@ -828,6 +828,22 @@ new parameters (if specified) once the vm migration >>> finished successfully. >>> ETEXI >>> >>> { >>> +.name = "dump", >>> +.args_type = "file:s", >>> +.params

Re: [Qemu-devel] [PATCH 4/4] pl031: switch clock base to rtc_clock

2012-01-30 Thread Paolo Bonzini
On 01/30/2012 05:54 PM, Peter Maydell wrote: > This lets the user specify the desired semantics. By default, the RTC > will follow adjustments from the host's NTP client, and will remain in > sync when the virtual machine is stopped. The previous behavior, which > provides determinism with

Re: [Qemu-devel] [PATCH 4/4] pl031: switch clock base to rtc_clock

2012-01-30 Thread Peter Maydell
On 20 January 2012 12:06, Paolo Bonzini wrote: > This lets the user specify the desired semantics.  By default, the RTC > will follow adjustments from the host's NTP client, and will remain in > sync when the virtual machine is stopped.  The previous behavior, which > provides determinism with bot

Re: [Qemu-devel] [Bug 899140] Re: Problem with Linux Kernel Traffic Control

2012-01-30 Thread Vincent Autefage
Hi, The problem seems to come from the implementation of the Intel e1000 network cards (which is the default one used by QEMU). If you use another one, the problem does not appear ;) Vince Le 29/01/2012 05:49, Henrique Rodrigues a écrit : > Hi guys, > > I'm having the same problem with a ubuntu

Re: [Qemu-devel] [PATCH 0/4] Use rtc_clock uniformly for ARM

2012-01-30 Thread Paolo Bonzini
On 01/20/2012 01:06 PM, Paolo Bonzini wrote: This series uses rtc_clock uniformly in device models that provide RTC functionality. This will let users choose the desired semantics for the clock. This is most important with qtest, where "-rtc clock=vm" will provide determinism and let you run te

Re: [Qemu-devel] [PATCH] m48t59: use rtc_clock for alarm timer

2012-01-30 Thread Paolo Bonzini
On 01/20/2012 01:05 PM, Paolo Bonzini wrote: This lets the RTC get adjustments from the host NTP client. The watchdog still uses the vm_clock. The previous behavior is available with "-rtc clock=vm". Cc: Andreas Färber Signed-off-by: Paolo Bonzini --- hw/m48t59.c |4 ++-- 1 files changed

[Qemu-devel] [PULL] VirtFS update

2012-01-30 Thread Aneesh Kumar K.V
Hi Anthony, I now have a successful build at build bot. So hopefully build breakage is gone. I also added "remove O_NOATIME" patch which Mohan acked. -anees The following changes since commit 8c4ec5c0269bda18bb777a64b2008088d1c632dc: pxa2xx_keypad: fix unbalanced parenthesis. (2012-01-17 02:

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Michal Privoznik
On 30.01.2012 15:44, Luiz Capitulino wrote: > On Mon, 30 Jan 2012 07:54:56 -0600 > Anthony Liguori wrote: > >> On 01/30/2012 06:57 AM, Luiz Capitulino wrote: >>> On Thu, 26 Jan 2012 16:57:01 -0600 >>> Anthony Liguori wrote: >>> On 01/26/2012 01:35 PM, Luiz Capitulino wrote: > On Thu, 26

Re: [Qemu-devel] [PATCH RFC 7/7] target-arm: Embed CPUARMState in QOM ARMCPU

2012-01-30 Thread Andreas Färber
Am 30.01.2012 03:22, schrieb Anthony Liguori: > On 01/29/2012 07:25 AM, Andreas Färber wrote: >> +static void arm_cpu_realize(Object *obj) >> +{ >> +ARMCPU *cpu = ARM_CPU(obj); >> +ARMCPUClass *cpu_class = ARM_CPU_GET_CLASS(obj); >> + >> +memset(&cpu->env, 0, sizeof(CPUARMState)); >> +

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Eric Blake
On 01/30/2012 07:44 AM, Luiz Capitulino wrote: > I think we should do the following then: > > 1. Drop the set-support-level command > 2. Split the guest-suspend command into guest-suspend-ram, > guest-suspend-hybrid, > guest-suspend-disk > 3. Libvirt should query for _QEMU_'s 'wakeup' comm

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-30 Thread Paolo Bonzini
On 01/30/2012 04:43 PM, Kevin Wolf wrote: >> >> If we had force=true in the initial eject command, bdrv_close is called, >> which in turn goes through bdrv_dev_change_media_cb where an event is >> emitted. > > Can't this race with the guest eject? Can't see how, there's nothing asynchronous

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Michael Roth
On 01/30/2012 08:44 AM, Luiz Capitulino wrote: On Mon, 30 Jan 2012 07:54:56 -0600 Anthony Liguori wrote: On 01/30/2012 06:57 AM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 16:57:01 -0600 Anthony Liguori wrote: On 01/26/2012 01:35 PM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 08:18:03 -0

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-30 Thread Kevin Wolf
Am 30.01.2012 16:18, schrieb Luiz Capitulino: > On Fri, 27 Jan 2012 10:52:15 +0100 > Kevin Wolf wrote: > >> Am 26.01.2012 18:57, schrieb Luiz Capitulino: >>> On Wed, 25 Jan 2012 10:42:04 -0200 >>> Luiz Capitulino wrote: >>> On Wed, 25 Jan 2012 09:41:20 +0100 Kevin Wolf wrote: >>>

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-30 Thread Luiz Capitulino
On Fri, 27 Jan 2012 13:10:39 +0100 Paolo Bonzini wrote: > On 01/24/2012 07:16 PM, Luiz Capitulino wrote: > > @@ -237,6 +238,17 @@ static bool do_check_io_limits(BlockIOLimit *io_limits) > > return true; > > } > > > > +static void on_medium_eject(BlockDriverState *bs, int is_ejected) > > +{

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-30 Thread Luiz Capitulino
On Fri, 27 Jan 2012 10:52:15 +0100 Kevin Wolf wrote: > Am 26.01.2012 18:57, schrieb Luiz Capitulino: > > On Wed, 25 Jan 2012 10:42:04 -0200 > > Luiz Capitulino wrote: > > > >> On Wed, 25 Jan 2012 09:41:20 +0100 > >> Kevin Wolf wrote: > >> > >>> Am 24.01.2012 21:03, schrieb Eric Blake: > O

Re: [Qemu-devel] [RFC PATCH] generalize QOM path resolution

2012-01-30 Thread Paolo Bonzini
On 01/30/2012 03:28 PM, Anthony Liguori wrote: You are not going to have anyway a link. That makes it fine to resolve a link and a link according to different rules. I think we agreed (in IRC) that we can handle this by changing qdev_resolve_path() to take an optional TYPE argument which will

Re: [Qemu-devel] [PATCH v3 1/6] xen: do not initialize the interval timer emulator

2012-01-30 Thread Jan Kiszka
On 2012-01-30 12:39, Stefano Stabellini wrote: > On Fri, 27 Jan 2012, Jan Kiszka wrote: >> On 2012-01-27 19:21, Stefano Stabellini wrote: >>> PIT is emulated by the hypervisor so we don't need to emulate it in Qemu: >>> this patch prevents Qemu from waking up needlessly at PIT_FREQ on Xen. >>> >>>

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Michael Roth
On 01/30/2012 06:57 AM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 16:57:01 -0600 Anthony Liguori wrote: On 01/26/2012 01:35 PM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 08:18:03 -0700 Eric Blake wrote: [adding qemu-devel] On 01/26/2012 07:46 AM, Daniel P. Berrange wrote: One thing, t

[Qemu-devel] oVirt Live Snapshots

2012-01-30 Thread Federico Simoncelli
Hi, oVirt, and more specifically VDSM, is currently implementing the live snapshot feature using the API/commands provided by libvirt and qemu. It would be great if you could review the design and the current open issues at: http://ovirt.org/wiki/Live_Snapshots Thank you, -- Federico

Re: [Qemu-devel] TB chaining in QEMU

2012-01-30 Thread 陳韋任
> > The only reason this doesn't have any visible effect is: > > (1) x86 doesn't have split icache/dcache so no incoherency issues > > > > I think intel new architecture does split instruction cache/data cache. > http://upload.wikimedia.org/wikipedia/commons/6/64/Intel_Nehalem_arch.svg > > But I

Re: [Qemu-devel] spawning and killing threads in qemu

2012-01-30 Thread 陳韋任
> On Thu, Jan 26, 2012 at 1:35 PM, Paolo Bonzini wrote: > > On 01/26/2012 07:31 PM, Xin Tong wrote: > >> > >> When i attach gdb to qemu running in system mode, i often get things like > >> > >> [Thread 0x7ffed2013700 (LWP 29499) exited] > >> [New Thread 0x7ffed2013700 (LWP 29500)] > >> > >> what s

[Qemu-devel] [PATCH] rtl8139: honor RxOverflow flag in can_receive method

2012-01-30 Thread Fernando Luis Vázquez Cao
Some drivers (Linux' 8139too among them) rely on the NIC injecting an interrupt in the event of a receive buffer overflow and, accordingly, set the RxOverflow bit in the interrupt mask. Unfortunately rtl8139's can_receive method ignores the RxOverflow flag, which may lead to a situation where rtl81

Re: [Qemu-devel] git bisect results

2012-01-30 Thread Jan Kiszka
On 2012-01-30 15:17, Erik Rull wrote: > > > > On January 30, 2012 at 2:48 PM Jan Kiszka wrote: > >> On 2012-01-30 14:17, Erik Rull wrote: >>> >>> >>> >>> On January 30, 2012 at 12:52 PM Jan Kiszka > wrote: >>> On 2012-01-30 12:34, Erik Rull wrote: > Hi Jan, > > I'm sorry, but

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Luiz Capitulino
On Mon, 30 Jan 2012 07:54:56 -0600 Anthony Liguori wrote: > On 01/30/2012 06:57 AM, Luiz Capitulino wrote: > > On Thu, 26 Jan 2012 16:57:01 -0600 > > Anthony Liguori wrote: > > > >> On 01/26/2012 01:35 PM, Luiz Capitulino wrote: > >>> On Thu, 26 Jan 2012 08:18:03 -0700 > >>> Eric Blake wrote:

Re: [Qemu-devel] [RFC PATCH] generalize QOM path resolution

2012-01-30 Thread Anthony Liguori
On 01/30/2012 08:03 AM, Paolo Bonzini wrote: On 01/30/2012 02:39 PM, Anthony Liguori wrote: On 01/30/2012 06:53 AM, Paolo Bonzini wrote: Right now, resolving a string to an object is not generic to QOM, but rather it is entirely embedded in qdev (the Device class). This embryo patch generalizes

Re: [Qemu-devel] git bisect results

2012-01-30 Thread Erik Rull
On January 30, 2012 at 2:48 PM Jan Kiszka wrote: > On 2012-01-30 14:17, Erik Rull wrote: > > > > > > > > On January 30, 2012 at 12:52 PM Jan Kiszka wrote: > > > >> On 2012-01-30 12:34, Erik Rull wrote: > >>> Hi Jan, > >>> > >>> I'm sorry, but this does not solve my issue. I applied the patch

  1   2   >