Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2012-01-24 Thread ronnie sahlberg
On Tue, Jan 24, 2012 at 5:07 AM, Eric Blake wrote: > > Can -readconfig support reading from an inherited fd, rather than only > taking a file name that qemu has to open()? > ... > > Can you give an actual command line that uses -readconfig, as part of > your example? > Thanks for the review Eric.

[Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-24 Thread Alexey Korolev
Hi, In this post http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg03171.html I've mentioned about the issues when 64Bit PCI BAR is present and 32bit address range is selected for it. The issue affects all recent qemu releases and all old and recent guest Linux kernel versions. We've done s

[Qemu-devel] [Bug 821289] Re: qemu mac segfault

2012-01-24 Thread Joe Pintozzi
Ironically I just figured out how to fix this issue. It only segfaults when built with LLVM. If you installed with homebrew, run >brew install qemu --use-gcc --force To get a working version. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

[Qemu-devel] [Bug 821289] Re: qemu mac segfault

2012-01-24 Thread Joe Pintozzi
I can reproduce this reliably when running > qemu-system-arm -L . -kernel vmlinuz-2.6.32-5-versatile -initrd initrd.gz -hda hda.img -m 256 -M versatilepb -append "desktop=lxde" -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2012-01-24 Thread David Gibson
On Tue, Dec 20, 2011 at 09:30:37PM -0700, Alex Williamson wrote: > On Wed, 2011-12-21 at 14:32 +1100, David Gibson wrote: > > On Mon, Dec 19, 2011 at 04:41:56PM +0100, Joerg Roedel wrote: > > > On Mon, Dec 19, 2011 at 11:11:25AM +1100, David Gibson wrote: > > > > Well.. that's not where it is in Al

Re: [Qemu-devel] [PATCH v3 0/28] qom: add QEMU Object Model type hierarchy to qdev

2012-01-24 Thread Anthony Liguori
On 01/24/2012 05:13 PM, Peter Maydell wrote: On 24 January 2012 19:32, Anthony Liguori wrote: This series makes qdev a proper Object and converts qdev's type inheritance to QOM inheritance. I've tested this series extensively for the pc target including bisectability. I have not tested any o

Re: [Qemu-devel] [PATCH v3 0/28] qom: add QEMU Object Model type hierarchy to qdev

2012-01-24 Thread Peter Maydell
On 24 January 2012 19:32, Anthony Liguori wrote: > This series makes qdev a proper Object and converts qdev's type inheritance to > QOM inheritance. > I've tested this series extensively for the pc target including bisectability. > I have not tested any other targets yet so your mileage may vary.

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-24 Thread Anthony Liguori
On 01/24/2012 04:06 PM, Jan Kiszka wrote: On 2012-01-24 22:53, Anthony Liguori wrote: But I don't like this. The problem is that the declarative syntax we have doesn't distinguish between "not-specified" and "zero-initialized". That's surely solvable. Please try :-) I've spent a good chunk

[Qemu-devel] [Bug 873460] Re: Likewise no sound

2012-01-24 Thread Paul Doherty
I have same issue. 11.10 local user sound works. Sound hardware is shown under Ubuntu sound. Installed likewise from Ubuntu repository and logging in as domain user hardware doesn't show up in sound config. No sound. It also doesnt access sound hardware in most apps, although it does in Skype. I a

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-24 Thread Jan Kiszka
On 2012-01-24 22:53, Anthony Liguori wrote: > On 01/24/2012 03:31 PM, Jan Kiszka wrote: >> On 2012-01-24 22:11, Anthony Liguori wrote: >>> On 01/24/2012 03:01 PM, Jan Kiszka wrote: On 2012-01-24 21:21, Anthony Liguori wrote: >> Also, I see a lot of programmatic initialization and a lot of

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-24 Thread Anthony Liguori
On 01/24/2012 03:31 PM, Jan Kiszka wrote: On 2012-01-24 22:11, Anthony Liguori wrote: On 01/24/2012 03:01 PM, Jan Kiszka wrote: On 2012-01-24 21:21, Anthony Liguori wrote: Also, I see a lot of programmatic initialization and a lot of repeating patterns (specifically regarding trivial class ini

[Qemu-devel] [Bug 921208] Re: win7/x64 installer hangs on startup with 0x0000005d.

2012-01-24 Thread Paweł Sikora
more info: virtualbox-4.1.8 boots this win7/x64/ultimate iso without any problems. i can provide more info if you need -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/921208 Title: win7/x64 inst

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-24 Thread Jan Kiszka
On 2012-01-24 22:11, Anthony Liguori wrote: > On 01/24/2012 03:01 PM, Jan Kiszka wrote: >> On 2012-01-24 21:21, Anthony Liguori wrote: Also, I see a lot of programmatic initialization and a lot of repeating patterns (specifically regarding trivial class initialization) - there is no

[Qemu-devel] [Bug 921208] [NEW] win7/x64 installer hangs on startup with 0x0000005d.

2012-01-24 Thread Paweł Sikora
Public bug reported: hi, during booting win7/x64 installer i'm observing a bsod with 0x005d ( msdn: unsupported_processor ). used command line: qemu-system-x86_64 -m 2048 -hda w7-system.img -cdrom win7_x64.iso -boot d adding '-machine accel=kvm' instead of default tcg accel helps to boot.

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-24 Thread Anthony Liguori
On 01/24/2012 03:01 PM, Jan Kiszka wrote: On 2012-01-24 21:21, Anthony Liguori wrote: Also, I see a lot of programmatic initialization and a lot of repeating patterns (specifically regarding trivial class initialization) - there is no better alternative? Not really, no. It looks bad now becau

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-24 Thread Jan Kiszka
On 2012-01-24 21:21, Anthony Liguori wrote: >> Also, I see a lot of programmatic initialization and a lot of repeating >> patterns (specifically regarding trivial class initialization) - there >> is no better alternative? > > Not really, no. It looks bad now because you have DeviceInfo still. >

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-24 Thread Eric Blake
On 01/24/2012 11:16 AM, Luiz Capitulino wrote: > Libvirt wants to be notified when the guest ejects a medium, so that > it can update its view of the guest. > > This code has been originally written by Daniel Berrange. It adds > the event to IDE and SCSI emulation. > > Please, note that this only

[Qemu-devel] [PATCH] fixup e432cef9 (aio help text): end sentences with periods

2012-01-24 Thread Laszlo Ersek
(Please keep me CC'd on any followup; I'm not subscribed. Thanks.) Signed-off-by: Laszlo Ersek --- qemu-io.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index ffa62fb..938b20c 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -1118,7 +1118,7 @@ stati

[Qemu-devel] [PATCH 25/28] unin_pci: Drop unused reset handler

2012-01-24 Thread Anthony Liguori
From: Andreas Färber Signed-off-by: Andreas Färber Signed-off-by: Alexander Graf --- hw/unin_pci.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/hw/unin_pci.c b/hw/unin_pci.c index 8c03cb0..6a10013 100644 --- a/hw/unin_pci.c +++ b/hw/unin_pci.c @@ -63,10 +63,6

[Qemu-devel] [PATCH v3 0/28] qom: add QEMU Object Model type hierarchy to qdev

2012-01-24 Thread Anthony Liguori
This series makes qdev a proper Object and converts qdev's type inheritance to QOM inheritance. The first half of the series are manual cleanups/refactorings. The second half is mostly scripted conversion, separated out into reviewable and bisectable chunks. I've tested this series extensively f

[Qemu-devel] [PATCH 17/28] i2c: smbus: convert to QEMU Object Model

2012-01-24 Thread Anthony Liguori
This converts two types because smbus is implemented as a subclass of i2c. It's extremely difficult to convert these two independently. Signed-off-by: Anthony Liguori --- hw/ds1338.c | 21 + hw/i2c.c | 83 +--- hw/i2

[Qemu-devel] [PATCH 20/28] scsi: convert to QEMU Object Model

2012-01-24 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/scsi-bus.c | 95 +++- hw/scsi-disk.c| 159 - hw/scsi-generic.c | 29 ++ hw/scsi.h | 31 ++ 4 files changed, 201 insertions(+), 113 deletions

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-24 Thread Anthony Liguori
On 01/24/2012 02:01 PM, Jan Kiszka wrote: On 2012-01-24 20:33, Anthony Liguori wrote: This converts three devices because apic and ioapic are subclasses of sysbus. Converting subclasses independently of their base class is prohibitively hard. Hmm, I think that's more than three... Can you spli

[Qemu-devel] [PATCH 15/28] ssi: convert to QEMU Object Model

2012-01-24 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/ads7846.c | 17 - hw/max111x.c | 34 -- hw/spitz.c | 39 +++ hw/ssd0323.c | 17 - hw/ssi-sd.c| 17 - hw/ssi.c |

Re: [Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2012-01-24 Thread Rick Vernam
I experience this on uni-processor. On Tuesday 24 January 2012 16:48:04 Vitalis wrote: > And more: i have too more virtual PC with WindowsXP SP3 and with one > CPU, but them doesnt have any problems. Maybe this bug depends on 2 and > more CPU?? -- You received this bug notification because you a

[Qemu-devel] [PATCH 22/28] virtio-serial: convert to QEMU Object Model

2012-01-24 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/virtio-console.c| 69 +--- hw/virtio-serial-bus.c | 68 hw/virtio-serial.h | 81 ++-- 3 files changed, 128 insertions(+), 90

[Qemu-devel] [PATCH 13/28] usb: convert to QEMU Object Model

2012-01-24 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/usb-audio.c | 38 +++- hw/usb-bt.c | 33 ++ hw/usb-bus.c| 188 +++--- hw/usb-ccid.c | 38 +++- hw/usb-desc.c | 22 +++--- hw/usb-hid.c| 108 +++-

[Qemu-devel] [PATCH 10/28] qdev: add class_init to DeviceInfo

2012-01-24 Thread Anthony Liguori
Since we are still dynamically creating TypeInfo, we need to chain the class_init function in order to be able to make use of it within subclasses of TYPE_DEVICE. This will disappear once we register TypeInfos directly. Signed-off-by: Anthony Liguori --- hw/qdev.c |4 hw/qdev.h |5

Re: [Qemu-devel] [PATCH 22/28] virtio-serial: convert to QEMU Object Model

2012-01-24 Thread Anthony Liguori
On 01/24/2012 01:59 PM, Amit Shah wrote: On (Tue) 24 Jan 2012 [13:33:14], Anthony Liguori wrote: diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index 982ffbf..edf54d7 100644 --- a/hw/virtio-serial-bus.c +++ b/hw/virtio-serial-bus.c @@ -157,7 +157,7 @@ static void do_flush_queu

Re: [Qemu-devel] git bisect results

2012-01-24 Thread Jan Kiszka
On 2012-01-24 19:55, Erik Rull wrote: > Jan Kiszka wrote: >> On 2012-01-24 18:24, Erik Rull wrote: >>> Hi all, >>> >>> I assume that I found a possible source of the bad usbtablet update >>> rate. >>> >>> I did some git bisectioning but I didn't get a usable result due to too >>> many merges (or ma

[Qemu-devel] [PATCH 14/28] ccid: convert to QEMU Object Model

2012-01-24 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/ccid-card-emulated.c | 27 ++-- hw/ccid-card-passthru.c | 27 ++-- hw/ccid.h | 28 +++-- hw/usb-ccid.c | 76 +++ 4 files changed, 109 insertions(+)

[Qemu-devel] [PATCH 21/28] spapr: convert to QEMU Object Model (v2)

2012-01-24 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- v1 -> v2 - use QOM to check for the default console --- hw/spapr_llan.c | 37 ++- hw/spapr_vio.c | 55 - hw/spapr_vio.h | 35 + hw/spa

[Qemu-devel] [PATCH 11/28] qdev: prepare source tree for code conversion

2012-01-24 Thread Anthony Liguori
These are various small stylistic changes which help make things more consistent such that the automated conversion script can be simpler. It's not necessary to agree or disagree with these style changes because all of this code is going to be rewritten by the patch monkey script anyway. Signed-o

[Qemu-devel] [PATCH v2] pxa2xx_lcd: SRAM is valid location for the framebuffer

2012-01-24 Thread Vasily Khoruzhick
Signed-off-by: Vasily Khoruzhick --- v2: fix descptr validation hw/pxa2xx_lcd.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/pxa2xx_lcd.c b/hw/pxa2xx_lcd.c index 4e9f7b4..de0fa48 100644 --- a/hw/pxa2xx_lcd.c +++ b/hw/pxa2xx_lcd.c @@ -308,9 +308,12 @@ st

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-24 Thread Jan Kiszka
On 2012-01-24 20:33, Anthony Liguori wrote: > This converts three devices because apic and ioapic are subclasses of sysbus. > Converting subclasses independently of their base class is prohibitively hard. Hmm, I think that's more than three... Can you split up? At least per target or per board/mac

Re: [Qemu-devel] [PATCH 22/28] virtio-serial: convert to QEMU Object Model

2012-01-24 Thread Amit Shah
On (Tue) 24 Jan 2012 [13:33:14], Anthony Liguori wrote: > diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c > index 982ffbf..edf54d7 100644 > --- a/hw/virtio-serial-bus.c > +++ b/hw/virtio-serial-bus.c > @@ -157,7 +157,7 @@ static void do_flush_queued_data(VirtIOSerialPort *port, > V

[Qemu-devel] [PATCH 03/28] pci: call reset unconditionally

2012-01-24 Thread Anthony Liguori
Because now all PCI devices are converted to qdev. Signed-off-by: Anthony Liguori --- hw/pci.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 54400ac..ab3b53d 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -159,11 +159,8 @@ void pci_device_deass

[Qemu-devel] [PATCH 05/28] qdev: integrate with QEMU Object Model (v2)

2012-01-24 Thread Anthony Liguori
This is a very shallow integration. We register a TYPE_DEVICE but only use QOM as basically a memory allocator. This will make all devices show up as QOM objects but they will all carry the TYPE_DEVICE. Signed-off-by: Anthony Liguori --- v1 -> v2 - update for new location of object.h --- hw/q

[Qemu-devel] [PATCH 18/28] hda-codec: convert to QEMU Object Model

2012-01-24 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/hda-audio.c | 58 ++- hw/intel-hda.c | 31 + hw/intel-hda.h | 26 3 files changed, 71 insertions(+), 44 deletions(-) diff --git a/hw/hda-audio.c b/

Re: [Qemu-devel] [PATCH] hyperv: fix build on non-KVM hosts

2012-01-24 Thread Vadim Rozenfeld
- Original Message - From: "Blue Swirl" To: vroze...@redhat.com, "qemu-devel" Sent: Monday, January 23, 2012 10:10:51 PM Subject: [PATCH] hyperv: fix build on non-KVM hosts Signed-off-by: Blue Swirl --- Maybe a better fix would be to allow hyperv to be used also on TCG. [VR] Yes, it

[Qemu-devel] [PATCH 16/28] i2c: rename i2c_slave -> I2CSlave

2012-01-24 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/ds1338.c | 10 +- hw/i2c.c | 30 +++--- hw/i2c.h | 22 -- hw/lm832x.c | 10 +- hw/max7310.c | 10 +- hw/pxa2xx.c | 10 +- hw/smbus.c|8 h

[Qemu-devel] [PATCH 06/28] qdev: move qdev->info to class

2012-01-24 Thread Anthony Liguori
Right now, DeviceInfo acts as the class for qdev. In order to switch to a proper ObjectClass derivative, we need to ween all of the callers off of interacting directly with the info pointer. Signed-off-by: Anthony Liguori --- hw/acpi_piix4.c|4 +- hw/apic_common.c | 10 +++--

[Qemu-devel] [PATCH 04/28] qom: add the base Object class (v2)

2012-01-24 Thread Anthony Liguori
This class provides the main building block for QEMU Object Model and is extensively documented in the header file. It is largely inspired by GObject. Signed-off-by: Anthony Liguori --- v1 -> v2 - remove printf() in type registration - fix typo in comment (Paolo) - make Interface private - m

[Qemu-devel] [PATCH 08/28] qdev: use a wrapper to access reset and promote reset to a class method

2012-01-24 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/intel-hda.c |4 +--- hw/lsi53c895a.c |2 +- hw/qdev.c | 22 +- hw/qdev.h |8 4 files changed, 27 insertions(+), 9 deletions(-) diff --git a/hw/intel-hda.c b/hw/intel-hda.c index 8cb92d3..6e1c5de 100644

[Qemu-devel] [PATCH 19/28] ide: convert to QEMU Object Model

2012-01-24 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/ide/internal.h | 20 ++--- hw/ide/qdev.c | 111 + 2 files changed, 82 insertions(+), 49 deletions(-) diff --git a/hw/ide/internal.h b/hw/ide/internal.h index 00b28df..c808a0d 100644 --- a/hw/ide/

[Qemu-devel] [PATCH 24/28] unin_pci: Drop duplicate busdev

2012-01-24 Thread Anthony Liguori
From: Andreas Färber PCIHostState already has a busdev. Signed-off-by: Andreas Färber Signed-off-by: Alexander Graf --- hw/unin_pci.c | 29 - 1 files changed, 20 insertions(+), 9 deletions(-) diff --git a/hw/unin_pci.c b/hw/unin_pci.c index be0e98c..8c03cb0 1006

[Qemu-devel] [PATCH 07/28] qdev: don't access name through info

2012-01-24 Thread Anthony Liguori
We already have a QOM interface for this so let's use it. Signed-off-by: Anthony Liguori --- hw/e1000.c |2 +- hw/eepro100.c |2 +- hw/etraxfs_eth.c|2 +- hw/hda-audio.c |2 +- hw/intel-hda.c |2 +- hw/lan9118.c|

[Qemu-devel] [PATCH 28/28] virtio-s390: convert to QEMU Object Model

2012-01-24 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/s390-virtio-bus.c | 93 +++--- 1 files changed, 65 insertions(+), 28 deletions(-) diff --git a/hw/s390-virtio-bus.c b/hw/s390-virtio-bus.c index 8e34a78..565941a 100644 --- a/hw/s390-virtio-bus.c +++ b/hw/s390-vi

[Qemu-devel] [PATCH 23/28] unin_pci: Clean up qdev names

2012-01-24 Thread Anthony Liguori
From: Andreas Färber Add -pcihost to SysBus devices to resolve name conflicts, and clarify PCI vs. Internal PCI. Signed-off-by: Andreas Färber Signed-off-by: Alexander Graf --- hw/unin_pci.c | 54 +++--- 1 files changed, 39 insertions(+), 15 d

[Qemu-devel] [PATCH 02/28] openpic: remove dead code to make a PCI device version

2012-01-24 Thread Anthony Liguori
bus is always NULL so the code in this if clause is dead (and therefore untested). Signed-off-by: Anthony Liguori --- hw/openpic.c | 30 +++--- hw/openpic.h |2 +- hw/ppc_newworld.c |2 +- 3 files changed, 5 insertions(+), 29 deletions(-) diff --git a

[Qemu-devel] [PATCH 12/28] isa: pic: convert to QEMU Object Model

2012-01-24 Thread Anthony Liguori
This converts two devices at once because PIC subclasses ISA and converting subclasses independently is extremely hard. Signed-off-by: Anthony Liguori --- hw/applesmc.c | 18 -- hw/cirrus_vga.c | 17 - hw/cs4231a.c| 20 +---

[Qemu-devel] [PATCH 09/28] qdev: add a interface to register subclasses

2012-01-24 Thread Anthony Liguori
In order to introduce inheritance while still using the qdev registration interfaces, we need to be able to use a parent other than TYPE_DEVICE. Add a new interface that allows this. Signed-off-by: Anthony Liguori --- hw/qdev.c |9 +++-- hw/qdev.h |1 + 2 files changed, 8 insertions

[Qemu-devel] [PATCH 01/28] macio: convert to qdev

2012-01-24 Thread Anthony Liguori
This is a "shallow", half hearted, and untested conversion. Signed-off-by: Anthony Liguori --- hw/macio.c | 43 ++- 1 files changed, 30 insertions(+), 13 deletions(-) diff --git a/hw/macio.c b/hw/macio.c index cc6ae40..357e0ea 100644 --- a/hw/macio.c ++

Re: [Qemu-devel] [PATCH] pxa2xx_lcd: SRAM is valid location for the framebuffer

2012-01-24 Thread Vasily Khoruzhick
On Tue, 2012-01-24 at 21:49 +0300, Vasily Khoruzhick wrote: > Signed-off-by: Vasily Khoruzhick Please ignore it, this version is buggy > hw/pxa2xx_lcd.c | 10 -- > 1 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/hw/pxa2xx_lcd.c b/hw/pxa2xx_lcd.c > index 4e9f7b4..b39

[Qemu-devel] helper function and mmu

2012-01-24 Thread James Greensky
Hello all, I have a quick question that I hope somebody can shed some light on. Inside of helper functions, can you have a page fault that must be serviced by the OS? I ask because I cannot see how the cpu state is restored inside of a helper function. Inside tlb_fill, when invoked not from a helpe

[Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-24 Thread Luiz Capitulino
Libvirt wants to be notified when the guest ejects a medium, so that it can update its view of the guest. This code has been originally written by Daniel Berrange. It adds the event to IDE and SCSI emulation. Please, note that this only covers guest initiated ejects, that's, the QMP/HMP commands

Re: [Qemu-devel] icount and tb chaining

2012-01-24 Thread James Greensky
On Thu, Jan 19, 2012 at 2:32 AM, 陳韋任 wrote: >> What i mean here is that in gen-icount.h, the icount_decr.u32 field is >> exhausted and jumps out to the cpu-exec loop. This is where you would >> fall into tb_add_jump with the second argument being 2, and only if >> icount_extra was greater than zer

Re: [Qemu-devel] git bisect results

2012-01-24 Thread Erik Rull
Jan Kiszka wrote: On 2012-01-24 18:24, Erik Rull wrote: Hi all, I assume that I found a possible source of the bad usbtablet update rate. I did some git bisectioning but I didn't get a usable result due to too many merges (or maybe my little knowledge to git), so I proceeded with some manual b

[Qemu-devel] [PATCH] pxa2xx_lcd: SRAM is valid location for the framebuffer

2012-01-24 Thread Vasily Khoruzhick
Signed-off-by: Vasily Khoruzhick --- hw/pxa2xx_lcd.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/pxa2xx_lcd.c b/hw/pxa2xx_lcd.c index 4e9f7b4..b39abbb 100644 --- a/hw/pxa2xx_lcd.c +++ b/hw/pxa2xx_lcd.c @@ -311,6 +311,10 @@ static void pxa2xx_descriptor_loa

Re: [Qemu-devel] [PATCH] signrom: Rewrite as python script

2012-01-24 Thread Stefan Weil
Am 24.01.2012 16:25, schrieb Jan Kiszka: On 2012-01-24 16:22, Eric Blake wrote: On 01/24/2012 01:53 AM, Jan Kiszka wrote: Now that we have a hard dependency on python anyway, we can replace the slow shell script to calculate the option ROM checksum with a fast AND portable python version. Teste

Re: [Qemu-devel] [PATCH 1/4] vga: improve VGA logic

2012-01-24 Thread Markus Armbruster
Blue Swirl writes: > On Tue, Jan 24, 2012 at 15:57, Markus Armbruster wrote: >> Current master dies for me: >> >> $ upstream-qemu -nodefaults -S -m 384 -vnc :0 -device cirrus-vga >> RAMBlock "vga.vram" already registered, abort! >> Aborted (core dumped) >> >> git-bisect blames this one: >> >> Bl

Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option

2012-01-24 Thread Stefan Weil
Am 24.01.2012 08:22, schrieb Andreas Färber: Am 23.01.2012 08:20, schrieb Peter A. G. Crosthwaite: Added linux specific kernel dtb option. This option can be specified to inject an argument device tree blob (dtb) into linux. Signed-off-by: Peter A. G. Crosthwaite --- qemu-options.hx | 3 +++ v

Re: [Qemu-devel] git bisect results

2012-01-24 Thread Jan Kiszka
On 2012-01-24 18:24, Erik Rull wrote: > Hi all, > > I assume that I found a possible source of the bad usbtablet update rate. > > I did some git bisectioning but I didn't get a usable result due to too > many merges (or maybe my little knowledge to git), so I proceeded with some > manual bisect

Re: [Qemu-devel] [PATCH v6] qdev: Add support for property type bool

2012-01-24 Thread Jan Kiszka
On 2012-01-24 18:38, Andreas Färber wrote: > Am 24.01.2012 18:29, schrieb Jan Kiszka: >> On 2012-01-24 18:17, Andreas Färber wrote: >>> From: Andreas Färber >>> >>> VMState supports the type bool but qdev instead supports bit, backed by >>> uint32_t. Therefore let's add DEFINE_PROP_BOOL() and qdev

Re: [Qemu-devel] [PATCH v6] qdev: Add support for property type bool

2012-01-24 Thread Anthony Liguori
On 01/24/2012 11:38 AM, Andreas Färber wrote: Am 24.01.2012 18:29, schrieb Jan Kiszka: On 2012-01-24 18:17, Andreas Färber wrote: From: Andreas Färber VMState supports the type bool but qdev instead supports bit, backed by uint32_t. Therefore let's add DEFINE_PROP_BOOL() and qdev_prop_set_bool

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Anthony Liguori
On 01/24/2012 09:56 AM, Avi Kivity wrote: On 01/24/2012 03:14 PM, Anthony Liguori wrote: On 01/24/2012 05:10 AM, Avi Kivity wrote: On 01/23/2012 07:18 PM, Anthony Liguori wrote: Generally speaking, RAM is an independent device in most useful cases. Can you give examples? Do you mean a subde

Re: [Qemu-devel] [PATCH v6] qdev: Add support for property type bool

2012-01-24 Thread Andreas Färber
Am 24.01.2012 18:29, schrieb Jan Kiszka: > On 2012-01-24 18:17, Andreas Färber wrote: >> From: Andreas Färber >> >> VMState supports the type bool but qdev instead supports bit, backed by >> uint32_t. Therefore let's add DEFINE_PROP_BOOL() and qdev_prop_set_bool(). >> >> bool by definition is eith

[Qemu-devel] [PATCH] ./configure: export xfs config via --{enable, disable}-xfsctl

2012-01-24 Thread Sergei Trofimovich
From: Sergei Trofimovich Signed-off-by: Sergei Trofimovich --- configure |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 9d72145..bca1943 100755 --- a/configure +++ b/configure @@ -771,6 +771,10 @@ for opt do ;; --enable-rbd) rbd="ye

Re: [Qemu-devel] [PATCH 1/4] vga: improve VGA logic

2012-01-24 Thread Blue Swirl
On Tue, Jan 24, 2012 at 15:57, Markus Armbruster wrote: > Current master dies for me: > > $ upstream-qemu -nodefaults -S -m 384 -vnc :0 -device cirrus-vga > RAMBlock "vga.vram" already registered, abort! > Aborted (core dumped) > > git-bisect blames this one: > > Blue Swirl writes: > >> Improve V

Re: [Qemu-devel] [PATCH v6] qdev: Add support for property type bool

2012-01-24 Thread Jan Kiszka
On 2012-01-24 18:17, Andreas Färber wrote: > From: Andreas Färber > > VMState supports the type bool but qdev instead supports bit, backed by > uint32_t. Therefore let's add DEFINE_PROP_BOOL() and qdev_prop_set_bool(). > > bool by definition is either true or false. Should the need arise to > pa

[Qemu-devel] git bisect results (was: Re: bad USB tablet update rate on qemu-1.0)

2012-01-24 Thread Erik Rull
Hi all, I assume that I found a possible source of the bad usbtablet update rate. I did some git bisectioning but I didn't get a usable result due to too many merges (or maybe my little knowledge to git), so I proceeded with some manual bisectioning by manually selecting commits and tested the

[Qemu-devel] [PATCH] scsi: Guard against buflen exceeding req->cmd.xfer in scsi_disk_emulate_command

2012-01-24 Thread Thomas Higdon
On Tue, Jan 24, 2012 at 08:53:03AM -0500, Kevin Wolf wrote: > Am 23.01.2012 18:15, schrieb Thomas Higdon: > > This prevents the emulated SCSI device from trying to DMA more bytes to the > > initiator than are expected. Without this, the SCRIPTS code in the emulated > > LSI > > device eventually ra

[Qemu-devel] [PATCH v6] qdev: Add support for property type bool

2012-01-24 Thread Andreas Färber
From: Andreas Färber VMState supports the type bool but qdev instead supports bit, backed by uint32_t. Therefore let's add DEFINE_PROP_BOOL() and qdev_prop_set_bool(). bool by definition is either true or false. Should the need arise to parse yes/no, on/off, 1/0 or whatever as well, we can still

[Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2012-01-24 Thread Vitalis
And more: i have too more virtual PC with WindowsXP SP3 and with one CPU, but them doesnt have any problems. Maybe this bug depends on 2 and more CPU?? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/81

Re: [Qemu-devel] [RFC][PATCH] signrom: Speed up checksum calculation

2012-01-24 Thread Christoph Egger
On 01/23/12 20:16, Stefan Weil wrote: Am 23.01.2012 19:38, schrieb Jan Kiszka: Forking an expr process for every byte of the input data slows down the checksum calculation massively. Fix this while still remaining portable by implementing the algorithm in awk. Signed-off-by: Jan Kiszka --- Tha

[Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2012-01-24 Thread Vitalis
And I have this bug! Linux test-2 2.6.32-25-generic #45-Ubuntu SMP Sat Oct 16 19:52:42 UTC 2010 x86_64 GNU/Linux In container i have Windows XP SP3 In log: LC_ALL=C PATH=/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/sbin:/sbin:/bin QEMU_AUDIO_DRV=none /usr/bin/kvm -S -M pc-0.12 -cpu qemu32 -enabl

Re: [Qemu-devel] [PATCH 2/3] VCPU hotplug support

2012-01-24 Thread Jan Kiszka
On 2012-01-24 17:24, Igor Mammedov wrote: > On 01/23/2012 06:55 PM, Jan Kiszka wrote: >> On 2012-01-23 17:29, Igor Mammedov wrote: >>> On 01/17/2012 03:17 PM, Jan Kiszka wrote: >>> >>> It seams that "env->cpuid_apic_id = cpu" is pointless especcialy >>> taking in account that in cpu_x86_init cpuid_

[Qemu-devel] hello world pci device

2012-01-24 Thread Yohann Martineau
hello, I'm learning uefi and qemu. If I understand correctly, in uefi, device drivers contain at least three functions: supported, start and stop. When PCI devices are discovered, all drivers "supported" function is invoked and if this function returns true, it

Re: [Qemu-devel] [Android-virt] [PATCH 02/12] arm: make the number of GIC interrupts configurable

2012-01-24 Thread Rusty Russell
On Fri, 13 Jan 2012 20:52:39 +, Peter Maydell wrote: > From: Mark Langsdorf > > Increase the maximum number of GIC interrupts for a9mp and a11mp to 1020, > and create a configurable property for each defaulting to 96 and 64 > (respectively) so that device modelers can set the value appropri

Re: [Qemu-devel] [PATCH 2/3] VCPU hotplug support

2012-01-24 Thread Igor Mammedov
On 01/23/2012 06:55 PM, Jan Kiszka wrote: On 2012-01-23 17:29, Igor Mammedov wrote: On 01/17/2012 03:17 PM, Jan Kiszka wrote: It seams that "env->cpuid_apic_id = cpu" is pointless especcialy taking in account that in cpu_x86_init cpuid_apic_id is initialized by cpu_index. What we gain in having

Re: [Qemu-devel] [PATCH] i8259: Do not clear level-triggered lines in IRR on init

2012-01-24 Thread Gleb Natapov
On Tue, Jan 24, 2012 at 04:29:29PM +0100, Jan Kiszka wrote: > When an input line is handled as level-triggered, it will immediately > raise an IRQ on the output of a PIC again that goes through an init > reset. So only clear the edge-triggered inputs from IRR in that > scenario. > Looks good to me

Re: [Qemu-devel] [PATCH 1/4] vga: improve VGA logic

2012-01-24 Thread Markus Armbruster
Current master dies for me: $ upstream-qemu -nodefaults -S -m 384 -vnc :0 -device cirrus-vga RAMBlock "vga.vram" already registered, abort! Aborted (core dumped) git-bisect blames this one: Blue Swirl writes: > Improve VGA selection logic, push check for device availabilty to vl.c. > Create th

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Avi Kivity
On 01/24/2012 03:14 PM, Anthony Liguori wrote: > On 01/24/2012 05:10 AM, Avi Kivity wrote: >> On 01/23/2012 07:18 PM, Anthony Liguori wrote: >>> Generally speaking, RAM is an independent device in most useful cases. >> >> Can you give examples? Do you mean a subdevice with composition, or a >> rea

Re: [Qemu-devel] [PATCH] signrom: Rewrite as python script

2012-01-24 Thread Markus Armbruster
Jan Kiszka writes: > On 2012-01-24 16:22, Eric Blake wrote: >> On 01/24/2012 01:53 AM, Jan Kiszka wrote: >>> Now that we have a hard dependency on python anyway, we can replace the >>> slow shell script to calculate the option ROM checksum with a fast AND >>> portable python version. Tested both

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Avi Kivity
On 01/24/2012 01:44 PM, Paolo Bonzini wrote: > On 01/24/2012 12:32 PM, Avi Kivity wrote: >>> > Clearing the screen should only write to the RAM at 0xB8000 (and >>> > perhaps 0xA since IIRC it's where text-mode fonts lie). The >>> > option ROM cannot even assume that the main BIOS knows abou

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Avi Kivity
On 01/24/2012 03:25 PM, Anthony Liguori wrote: > >> To my understanding, QXL will break identically on Xen for the same reason: the reset handler assumes it can deal with the VRAM as it likes. >> >> Yes. Some data structures for host<-> guest communication are living >> in device m

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Avi Kivity
On 01/24/2012 03:18 PM, Anthony Liguori wrote: > On 01/24/2012 05:13 AM, Avi Kivity wrote: >> On 01/24/2012 12:21 PM, Gerd Hoffmann wrote: >> >> But viewing RAM as just another device, having Xen only restore a >> subset of >> devices should be a reasonable thing to do moving forwar

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Avi Kivity
On 01/24/2012 02:00 PM, Stefano Stabellini wrote: > On Tue, 24 Jan 2012, Avi Kivity wrote: > > On 01/24/2012 12:21 PM, Gerd Hoffmann wrote: > > > >>> > > > >>> But viewing RAM as just another device, having Xen only restore a > > > >>> subset of > > > >>> devices should be a reasonable thing to do

Re: [Qemu-devel] [PATCH v8 18/18] kvm: Activate in-kernel irqchip support

2012-01-24 Thread Anthony Liguori
On 01/24/2012 08:13 AM, Avi Kivity wrote: On 01/24/2012 04:10 PM, Jan Kiszka wrote: On 2012-01-24 15:05, Avi Kivity wrote: On 01/19/2012 08:54 PM, Jan Kiszka wrote: Nope, see kvm_irqchip_create, patch 13. You can also check by browsing the qtree (different device model names). That was my bi

Re: [Qemu-devel] [PATCH v8 18/18] kvm: Activate in-kernel irqchip support

2012-01-24 Thread Anthony Liguori
On 01/24/2012 08:05 AM, Avi Kivity wrote: On 01/19/2012 08:54 PM, Jan Kiszka wrote: Nope, see kvm_irqchip_create, patch 13. You can also check by browsing the qtree (different device model names). That was my biggest objection to the previous iterations. Later versions changed to use an attri

[Qemu-devel] [PATCH] i8259: Do not clear level-triggered lines in IRR on init

2012-01-24 Thread Jan Kiszka
When an input line is handled as level-triggered, it will immediately raise an IRQ on the output of a PIC again that goes through an init reset. So only clear the edge-triggered inputs from IRR in that scenario. Signed-off-by: Jan Kiszka --- hw/i8259.c|2 +- hw/i8259_common.c |2

Re: [Qemu-devel] [PATCH] signrom: Rewrite as python script

2012-01-24 Thread Jan Kiszka
On 2012-01-24 16:22, Eric Blake wrote: > On 01/24/2012 01:53 AM, Jan Kiszka wrote: >> Now that we have a hard dependency on python anyway, we can replace the >> slow shell script to calculate the option ROM checksum with a fast AND >> portable python version. Tested both with python 2.7 and 3.1. >>

Re: [Qemu-devel] [PATCH] signrom: Rewrite as python script

2012-01-24 Thread Eric Blake
On 01/24/2012 01:53 AM, Jan Kiszka wrote: > Now that we have a hard dependency on python anyway, we can replace the > slow shell script to calculate the option ROM checksum with a fast AND > portable python version. Tested both with python 2.7 and 3.1. > > Signed-off-by: Jan Kiszka > --- > > +++

Re: [Qemu-devel] [PATCH v4 2/6] block: add .bdrv_co_write_zeroes() interface

2012-01-24 Thread Kevin Wolf
Am 18.01.2012 15:59, schrieb Stefan Hajnoczi: > The ability to zero regions of an image file is a useful primitive for > higher-level features such as image streaming or zero write detection. > > Image formats may support an optimized metadata representation instead > of writing zeroes into the im

Re: [Qemu-devel] [RFC PATCH 6/9] pc: attach ioapic to the QOM composition tree

2012-01-24 Thread Jan Kiszka
On 2012-01-18 11:33, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > hw/pc_piix.c |7 +-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/hw/pc_piix.c b/hw/pc_piix.c > index 2aba89c..3f92bf9 100644 > --- a/hw/pc_piix.c > +++ b/hw/pc_piix.c > @@ -54,7 +54,7

Re: [Qemu-devel] [PATCH v4 1/6] cutils: extract buffer_is_zero() from qemu-img.c

2012-01-24 Thread Kevin Wolf
Am 18.01.2012 15:59, schrieb Stefan Hajnoczi: > The qemu-img.c:is_not_zero() function checks if a buffer contains all > zeroes. This function will come in handy for zero-detection in the > block layer, so clean it up and move it to cutils.c. > > Note that the function now returns true if the buff

Re: [Qemu-devel] [PATCH v2 3/4] uq/master: Add CPU eject handling for acpi_piix4

2012-01-24 Thread Vasilis Liaskovitis
On Tue, Jan 24, 2012 at 11:28:41AM +0100, Jan Kiszka wrote: > On 2012-01-24 11:10, Vasilis Liaskovitis wrote: > > Add stub functions for CPU eject callback. Define cpu_acpi_eject property > > and > > enable eject callback only for pc-1.1 machine model. > > Just to get the idea: What is the plan a

Re: [Qemu-devel] KVM call agenda for Tuesday 24

2012-01-24 Thread Paolo Bonzini
On 01/24/2012 03:30 PM, Kevin Wolf wrote: >> * qtest/libos: Python or C? > > Both. More importantly: When?:-) Are there still any problems that must be fixed before it can be merged? There was no discussion on my alternative proposal on IRQ interception. Which might mean it's all fine an

Re: [Qemu-devel] KVM call agenda for Tuesday 24

2012-01-24 Thread Markus Armbruster
Anthony Liguori writes: > On 01/23/2012 11:38 AM, Markus Armbruster wrote: >> Please send in any agenda items you are interested in covering. > > I don't have anything pressing. I vote to cancel the call. Call's cancelled.

Re: [Qemu-devel] KVM call agenda for Tuesday 24

2012-01-24 Thread Kevin Wolf
Am 24.01.2012 15:08, schrieb Anthony Liguori: > On 01/24/2012 08:03 AM, Paolo Bonzini wrote: >> On 01/24/2012 02:57 PM, Anthony Liguori wrote: Please send in any agenda items you are interested in covering. >>> >>> I don't have anything pressing. I vote to cancel the call. >> >> Nothing that c

  1   2   >