Re: [Qemu-devel] The reason behind block linking constraint? (Cont.)

2011-12-14 Thread Zhi Yong Wu
I have one related question. If you build one new kernel image and initrd from Linus' kernel git tree, and don't modify qemu, can it work fine? On Thu, Dec 15, 2011 at 2:57 PM, 陳韋任 wrote: > Hi all, > >  I want to continue the discussion about the cross page constraint on block > linking [1][2]. M

[Qemu-devel] [PATCH 1/3] device_isolation: Infrastructure for managing device isolation groups

2011-12-14 Thread David Gibson
From: Alexey Kardashevskiy In order to safely drive a device with a userspace driver, or to pass it through to a guest system, we must first make sure that the device is isolated in such a way that it cannot interfere with other devices on the system. This isolation is only available on some sys

[Qemu-devel] [PATCH 2/2] device_isolation: Support isolation on POWER p7ioc (IODA) bridges

2011-12-14 Thread David Gibson
This patch adds code to the code for the powernv platform to create and populate isolation groups on hardware using the p7ioc (aka IODA) PCI host bridge used on some IBM POWER systems. Signed-off-by: Alexey Kardashevskiy Signed-off-by: David Gibson --- arch/powerpc/platforms/powernv/pci-ioda.c

[Qemu-devel] [PATCH 3/3] device_isolation: Support isolation on POWER p7ioc (IODA) bridges

2011-12-14 Thread David Gibson
This patch adds code to the code for the powernv platform to create and populate isolation groups on hardware using the p7ioc (aka IODA) PCI host bridge used on some IBM POWER systems. Signed-off-by: Alexey Kardashevskiy Signed-off-by: David Gibson --- arch/powerpc/platforms/powernv/pci-ioda.c

Re: [Qemu-devel] [PATCH v3 02/14] ARM: exynos4210: CMU support

2011-12-14 Thread Dmitry Solodkiy
Dear Peter, > So, how does this compare with the struct clk in hw/omap_clk.c ? > Is there a useful generalisation we can make rather than having > every SOC model doing its own thing for clock trees? It's definitely good approach to make similar things in one place, but existing TI Omap clock

[Qemu-devel] [RFC] Device isolation infrastructure v2

2011-12-14 Thread David Gibson
Here's the second spin of my preferred approach to handling grouping of devices for safe assignment to guests. Changes since v1: * Many name changes and file moves for improved consistency * Bugfixes and cleanups * The interface to the next layer up is considerably fleshed out, although it s

[Qemu-devel] [PATCH 2/3] device_isolation: Support isolation on POWER p5ioc2 bridges

2011-12-14 Thread David Gibson
This patch adds code to the code for the powernv platform to create and populate isolation groups on hardware using the p5ioc2 PCI host bridge used on some IBM POWER systems. Signed-off-by: Alexey Kardashevskiy Signed-off-by: David Gibson --- arch/powerpc/platforms/powernv/pci-p5ioc2.c | 14 +

[Qemu-devel] The reason behind block linking constraint? (Cont.)

2011-12-14 Thread 陳韋任
Hi all, I want to continue the discussion about the cross page constraint on block linking [1][2]. Max explained to me that if we link TBs belong different guest pages, then QEMU might crash when the memory mapping is changed by tlb_set_page (exec.c). Memory mapping changes may be the result of

[Qemu-devel] [PATCH 2/3] device_isolation: Support isolation on POWER p5ioc2 bridges

2011-12-14 Thread David Gibson
This patch adds code to the code for the powernv platform to create and populate isolation groups on hardware using the p5ioc2 PCI host bridge used on some IBM POWER systems. Signed-off-by: Alexey Kardashevskiy Signed-off-by: David Gibson --- arch/powerpc/platforms/powernv/pci-p5ioc2.c | 14 +

[Qemu-devel] [PATCH 3/3] device_isolation: Support isolation on POWER p7ioc (IODA) bridges

2011-12-14 Thread David Gibson
This patch adds code to the code for the powernv platform to create and populate isolation groups on hardware using the p7ioc (aka IODA) PCI host bridge used on some IBM POWER systems. Signed-off-by: Alexey Kardashevskiy Signed-off-by: David Gibson --- arch/powerpc/platforms/powernv/pci-ioda.c

Re: [Qemu-devel] [PATCH 2/2] device_isolation: Support isolation on POWER p7ioc (IODA) bridges

2011-12-14 Thread Michael Ellerman
On Thu, 2011-12-15 at 17:08 +1100, David Gibson wrote: > This patch adds code to the code for the powernv platform to create > and populate isolation groups on hardware using the p7ioc (aka IODA) PCI host > bridge used on some IBM POWER systems. > diff --git a/arch/powerpc/platforms/powernv/pci-io

[Qemu-devel] multifunction pci virtio-blk devices

2011-12-14 Thread Hui Kai Ran
Hi, It seems that qemu now have the ability to install pci device with mutlifunction=on, such as I got a cfg file to start qemu [device "ehci"] driver = "ich9-usb-ehci1" addr = "0d.7" multifunction = "on" [device "ehci1"] driver = "ich9-usb-ehci1" addr = "0d.3" multifunction = "on

Re: [Qemu-devel] [PATCH v2 0/4] GTK-DOC build integration (v2)

2011-12-14 Thread Andreas Färber
Am 14.12.2011 22:08, schrieb Anthony Liguori: > On 12/14/2011 02:54 PM, Marc-André Lureau wrote: >> On Wed, Dec 14, 2011 at 9:01 PM, Anthony >> Liguoriwrote: >> >>> For v2, I'm relying on a fork of gtk-doc that removes the underscore >>> requirements. I really hate to do this but I like it better

Re: [Qemu-devel] [PATCH 03/17] block: pass protocol flags up to the format

2011-12-14 Thread Zhi Yong Wu
On Tue, Dec 13, 2011 at 8:37 PM, Paolo Bonzini wrote: > In the next patches, the protocols will modify bs->open_flags to signify > that they cannot support the exact requested feature set.  Pass the > modified flags to the format. > > Signed-off-by: Paolo Bonzini > --- >  block.c |    3 ++- >  1

Re: [Qemu-devel] [RFC][PATCT 0/5 v2] dump memory when host pci device is used by guest

2011-12-14 Thread HATAYAMA Daisuke
From: Wen Congyang Subject: Re: [Qemu-devel] [RFC][PATCT 0/5 v2] dump memory when host pci device is used by guest Date: Tue, 13 Dec 2011 17:20:24 +0800 > At 12/13/2011 02:01 PM, HATAYAMA Daisuke Write: >> From: Wen Congyang >> Subject: Re: [Qemu-devel] [RFC][PATCT 0/5 v2] dump memory when host

Re: [Qemu-devel] [PATCH v2] qemu-ga: Add the guest-suspend command

2011-12-14 Thread Michael Roth
On 12/14/2011 05:56 PM, Luiz Capitulino wrote: On Wed, 14 Dec 2011 15:14:40 -0600 Michael Roth wrote: On 12/14/2011 02:56 PM, Michael Roth wrote: On 12/14/2011 02:06 PM, Luiz Capitulino wrote: On Wed, 14 Dec 2011 13:43:23 -0600 Michael Roth wrote: On 12/14/2011 12:17 PM, Luiz Capitulino w

Re: [Qemu-devel] [PATCH v2 00/11] isa: preliminary work for multiple buses

2011-12-14 Thread Anthony Liguori
On 12/14/2011 05:02 PM, Hervé Poussineau wrote: Current patches are a rework of my patches already available at [1]. They don't provide full support for multiple ISA buses (yet), but add a ISABus or ISADevice argument to all ISA functions. They are mostly mechanically touching every instanciation

Re: [Qemu-devel] [PATCH] spapr: Add support for -vga option

2011-12-14 Thread Anthony Liguori
On 12/14/2011 06:00 PM, Benjamin Herrenschmidt wrote: On Wed, 2011-12-14 at 15:48 -0600, Anthony Liguori wrote: /* USB */ if (usb_enabled) { usb_ohci_init_pci(QLIST_FIRST(&spapr->phbs)->host_state.bus, -1); + if (spapr_has_graphics) { + usbdevice_create("keyboard");

[Qemu-devel] [PATCH] usb-ohci: return USBBus in usb_ohci_init_pci

2011-12-14 Thread Anthony Liguori
Untested, but seemingly obvious and hard to screw up.. Signed-off-by: Anthony Liguori --- hw/usb-ohci.c |7 +-- hw/usb-ohci.h |3 ++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/usb-ohci.c b/hw/usb-ohci.c index e68be70..4c56548 100644 --- a/hw/usb-ohci.c +++ b/h

Re: [Qemu-devel] [PATCH] spapr: Add support for -vga option

2011-12-14 Thread Benjamin Herrenschmidt
On Wed, 2011-12-14 at 15:48 -0600, Anthony Liguori wrote: > > /* USB */ > > if (usb_enabled) { > > > usb_ohci_init_pci(QLIST_FIRST(&spapr->phbs)->host_state.bus, -1); > > + if (spapr_has_graphics) { > > + usbdevice_create("keyboard"); > > + usbdevice_create("mouse");

Re: [Qemu-devel] [RFC] Device sandboxing

2011-12-14 Thread Paul Moore
On Wednesday, December 14, 2011 11:15:58 AM Serge E. Hallyn wrote: > Quoting Paul Moore (pmo...@redhat.com): > > On Wednesday, December 07, 2011 12:48:16 PM Anthony Liguori wrote: > > > On 12/07/2011 12:25 PM, Corey Bryant wrote: > > > > A group of us are starting to work on sandboxing QEMU device

Re: [Qemu-devel] [PATCH v2] qemu-ga: Add the guest-suspend command

2011-12-14 Thread Luiz Capitulino
On Wed, 14 Dec 2011 15:14:40 -0600 Michael Roth wrote: > On 12/14/2011 02:56 PM, Michael Roth wrote: > > On 12/14/2011 02:06 PM, Luiz Capitulino wrote: > >> On Wed, 14 Dec 2011 13:43:23 -0600 > >> Michael Roth wrote: > >> > >>> On 12/14/2011 12:17 PM, Luiz Capitulino wrote: > On Wed, 14 Dec

[Qemu-devel] [PATCH 06/11] sun4u: give ISA bus to ISA methods

2011-12-14 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/sun4u.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/sun4u.c b/hw/sun4u.c index dfb81da..e3e8dde 100644 --- a/hw/sun4u.c +++ b/hw/sun4u.c @@ -530,10 +530,12 @@ static ISABus * pci_ebus_init(PCIBus *bus, int devfn) {

[Qemu-devel] [PATCH 02/11] isa: move ISABus structure definition to header file

2011-12-14 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/isa-bus.c |5 - hw/isa.h |6 ++ 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index dcbb134..7c94f0b 100644 --- a/hw/isa-bus.c +++ b/hw/isa-bus.c @@ -22,11 +22,6 @@ #include "isa.h" #include

[Qemu-devel] [PATCH 01/11] isa: give ISABus/ISADevice to isa_create(), isa_bus_irqs() and isa_get_irq() functions

2011-12-14 Thread Hervé Poussineau
NULL is a valid bus/device, so there is no change in behaviour. Signed-off-by: Hervé Poussineau --- arch_init.c|8 arch_init.h|2 +- hw/adlib.c |2 +- hw/alpha_dp264.c | 10 ++ hw/alpha_typhoon.c |7 --- hw/audiodev.h |8 +

[Qemu-devel] [PATCH 09/11] isa: always use provided ISA bus when creating an isa device

2011-12-14 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/isa-bus.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index 7c94f0b..3207680 100644 --- a/hw/isa-bus.c +++ b/hw/isa-bus.c @@ -130,12 +130,11 @@ ISADevice *isa_create(ISABus *bus, const char *

[Qemu-devel] [PATCH 07/11] fulong2e: give ISA bus to ISA methods

2011-12-14 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/mips_fulong2e.c |6 ++ hw/vt82c686.c |4 ++-- hw/vt82c686.h |2 +- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/mips_fulong2e.c b/hw/mips_fulong2e.c index e6e120c..5e87665 100644 --- a/hw/mips_fulong2e.c +++ b/

[Qemu-devel] [PATCH v2 00/11] isa: preliminary work for multiple buses

2011-12-14 Thread Hervé Poussineau
Current patches are a rework of my patches already available at [1]. They don't provide full support for multiple ISA buses (yet), but add a ISABus or ISADevice argument to all ISA functions. They are mostly mechanically touching every instanciation of ISA devices, so number of lines is quite high

[Qemu-devel] [PATCH 10/11] isa: always use provided ISA bus in isa_bus_irqs()

2011-12-14 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/isa-bus.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index 3207680..5af790b 100644 --- a/hw/isa-bus.c +++ b/hw/isa-bus.c @@ -53,8 +53,10 @@ ISABus *isa_bus_new(DeviceState *dev, MemoryRegion *a

Re: [Qemu-devel] [PATCH v2] qemu-ga: Add the guest-suspend command

2011-12-14 Thread Luiz Capitulino
On Wed, 14 Dec 2011 12:06:13 -0600 Michael Roth wrote: > On 12/14/2011 10:38 AM, Luiz Capitulino wrote: > > On Wed, 14 Dec 2011 09:54:29 -0600 > > Michael Roth wrote: > > > >> On 12/14/2011 07:00 AM, Luiz Capitulino wrote: > >>> On Tue, 13 Dec 2011 14:03:08 -0600 > >>> Michael Roth wrote: > >>

[Qemu-devel] [PATCH 03/11] i8259: give ISA device to isa_register_ioport()

2011-12-14 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/i8259.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i8259.c b/hw/i8259.c index 4446339..7331e0e 100644 --- a/hw/i8259.c +++ b/hw/i8259.c @@ -469,9 +469,9 @@ static int pic_initfn(ISADevice *dev) memory_region_init_io(

[Qemu-devel] [PATCH 11/11] audio: remove unused parameter isa_pic

2011-12-14 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- arch_init.c | 10 +- arch_init.h |2 +- hw/adlib.c |2 +- hw/audiodev.h |8 hw/cs4231a.c|2 +- hw/gus.c|2 +- hw/mips_jazz.c |2 +- hw/mips_malta.c |2 +- hw/pc.h |2 +- hw/

[Qemu-devel] [PATCH 04/11] pc: give ISA bus to ISA methods

2011-12-14 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/pc.h |2 +- hw/pc_piix.c |3 +-- hw/piix_pci.c |8 +--- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/pc.h b/hw/pc.h index 5a33703..5afd16b 100644 --- a/hw/pc.h +++ b/hw/pc.h @@ -183,7 +183,7 @@ struct PCII440FXSta

[Qemu-devel] [PATCH 05/11] alpha: give ISA bus to ISA methods

2011-12-14 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/alpha_dp264.c |4 ++-- hw/alpha_sys.h |3 ++- hw/alpha_typhoon.c | 10 +- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/hw/alpha_dp264.c b/hw/alpha_dp264.c index a87d6ef..455f380 100644 --- a/hw/alpha_dp264.c +++ b/h

[Qemu-devel] [PATCH 08/11] malta: give ISA bus to ISA methods

2011-12-14 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/mips_malta.c |3 +-- hw/pc.h |2 +- hw/piix4.c |3 ++- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/mips_malta.c b/hw/mips_malta.c index 98177f3..78d99e7 100644 --- a/hw/mips_malta.c +++ b/hw/mips_malta.c @@ -94

Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan

2011-12-14 Thread Anthony Liguori
On 12/14/2011 04:23 PM, Stefan Weil wrote: Am 14.12.2011 22:51, schrieb Anthony Liguori: Look carefully at: http://qemu.weilnetz.de/gtkdoc/QEMU-Memory-API.html#MemoryRegionOps vs: http://wiki.qemu.org/docs-internal/QEMU-Memory-API.html#MemoryRegionOps There's a significant difference :-) R

Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan

2011-12-14 Thread Stefan Weil
Am 14.12.2011 22:51, schrieb Anthony Liguori: Look carefully at: http://qemu.weilnetz.de/gtkdoc/QEMU-Memory-API.html#MemoryRegionOps vs: http://wiki.qemu.org/docs-internal/QEMU-Memory-API.html#MemoryRegionOps There's a significant difference :-) Regards, Anthony Liguori I tried the follo

Re: [Qemu-devel] [PATCH] configure: don't try to compile against known broken curses.

2011-12-14 Thread andrzej zaborowski
On 7 December 2011 20:06, andrzej zaborowski wrote: > On 7 December 2011 19:57, Stefan Weil wrote: >> Am 07.12.2011 08:47, schrieb Andrzej Zaborowski: >>> +#ifdef NCURSES_VERSION >>> +# if NCURSES_VERSION_PATCH < 20040117 >>> +# error Old ncurses contain dangerous typedefs, break qemu build (and

Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan

2011-12-14 Thread Anthony Liguori
On 12/14/2011 03:26 PM, Stefan Weil wrote: Am 14.12.2011 21:54, schrieb Anthony Liguori: On 12/14/2011 02:48 PM, Stefan Weil wrote: Am 14.12.2011 20:03, schrieb Anthony Liguori: On 12/14/2011 12:54 PM, Stefan Weil wrote: Am 14.12.2011 17:34, schrieb malc: On Wed, 14 Dec 2011, Anthony Liguori

Re: [Qemu-devel] [PATCH] spapr: Add support for -vga option

2011-12-14 Thread Anthony Liguori
On 12/14/2011 03:22 AM, Benjamin Herrenschmidt wrote: The -vga option is a handy "high level" option for instanciating things automatically. This adds support for it to the spapr (aka pseries) machine. Also instanciate the USB keyboard and mouse when that option is used (you can still use -devic

Re: [Qemu-devel] ICH6 audio no sound

2011-12-14 Thread Erik Lotspeich
Hi Paolo, I will report it to the OpenSUSE team. I added the qemu user to various audio groups (e.g. audio, pulse, pulse-access) and even tried running qemu-kvm with the aoss wrapper script (just in case it was a sound server issue). Still no avail. The qemu-kvm that's shipped with OpenSUSE is l

Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan

2011-12-14 Thread Stefan Weil
Am 14.12.2011 21:54, schrieb Anthony Liguori: On 12/14/2011 02:48 PM, Stefan Weil wrote: Am 14.12.2011 20:03, schrieb Anthony Liguori: On 12/14/2011 12:54 PM, Stefan Weil wrote: Am 14.12.2011 17:34, schrieb malc: On Wed, 14 Dec 2011, Anthony Liguori wrote: GTK/glib uses a convenient of: ty

Re: [Qemu-devel] [PATCH v2] qemu-ga: Add the guest-suspend command

2011-12-14 Thread Michael Roth
On 12/14/2011 02:56 PM, Michael Roth wrote: On 12/14/2011 02:06 PM, Luiz Capitulino wrote: On Wed, 14 Dec 2011 13:43:23 -0600 Michael Roth wrote: On 12/14/2011 12:17 PM, Luiz Capitulino wrote: On Wed, 14 Dec 2011 14:38:55 -0200 Luiz Capitulino wrote: I'm also wondering if we could use g_chi

Re: [Qemu-devel] [PATCH v2 0/4] GTK-DOC build integration (v2)

2011-12-14 Thread Anthony Liguori
On 12/14/2011 02:54 PM, Marc-André Lureau wrote: Hi On Wed, Dec 14, 2011 at 9:01 PM, Anthony Liguoriwrote: For v2, I'm relying on a fork of gtk-doc that removes the underscore requirements. I really hate to do this but I like it better than not having documentation. I'm poking in the gtk+ co

Re: [Qemu-devel] [PATCH v2] qemu-ga: Add the guest-suspend command

2011-12-14 Thread Michael Roth
On 12/14/2011 02:06 PM, Luiz Capitulino wrote: On Wed, 14 Dec 2011 13:43:23 -0600 Michael Roth wrote: On 12/14/2011 12:17 PM, Luiz Capitulino wrote: On Wed, 14 Dec 2011 14:38:55 -0200 Luiz Capitulino wrote: I'm also wondering if we could use g_child_watch_add(), but it's not clear to me i

Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan

2011-12-14 Thread Anthony Liguori
On 12/14/2011 02:48 PM, Stefan Weil wrote: Am 14.12.2011 20:03, schrieb Anthony Liguori: On 12/14/2011 12:54 PM, Stefan Weil wrote: Am 14.12.2011 17:34, schrieb malc: On Wed, 14 Dec 2011, Anthony Liguori wrote: GTK/glib uses a convenient of: typedef struct _CamelCase CamelCase; The reason

Re: [Qemu-devel] [PATCH v2 0/4] GTK-DOC build integration (v2)

2011-12-14 Thread Marc-André Lureau
Hi On Wed, Dec 14, 2011 at 9:01 PM, Anthony Liguori wrote: > For v2, I'm relying on a fork of gtk-doc that removes the underscore > requirements. I really hate to do this but I like it better than not > having > documentation. I'm poking in the gtk+ community to see if there's an > upstream > c

Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan

2011-12-14 Thread Anthony Liguori
On 12/14/2011 02:23 PM, Eric Blake wrote: On 12/14/2011 11:54 AM, Stefan Weil wrote: It does violate the standard _ followed by upper case letter is reserved in all contexts. sCamelCase instead of _CamelCase seems to work, too. What about _camelCase instead of _CamelCase? That preserves the

Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan

2011-12-14 Thread Stefan Weil
Am 14.12.2011 20:03, schrieb Anthony Liguori: On 12/14/2011 12:54 PM, Stefan Weil wrote: Am 14.12.2011 17:34, schrieb malc: On Wed, 14 Dec 2011, Anthony Liguori wrote: GTK/glib uses a convenient of: typedef struct _CamelCase CamelCase; The reason that they use a separate struct name is that

Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan

2011-12-14 Thread malc
On Wed, 14 Dec 2011, Eric Blake wrote: > On 12/14/2011 11:54 AM, Stefan Weil wrote: > >> It does violate the standard _ followed by upper case letter is reserved > >> in all contexts. > > > > sCamelCase instead of _CamelCase seems to work, too. > > What about _camelCase instead of _CamelCase? T

Re: [Qemu-devel] [PULL 00/10] target-arm queue

2011-12-14 Thread andrzej zaborowski
On 13 December 2011 19:30, Peter Maydell wrote: > Current target-arm pending patches; mostly these are Andreas' > inference series, plus one from Jean-Christophe that's been > waiting since before the 1.0 release. > > Please pull. Thanks, pulled (and pushed) Cheers

Re: [Qemu-devel] [PATCH] ARM - Remove fixed map code buffer restriction

2011-12-14 Thread andrzej zaborowski
On 12 December 2011 16:37, Dr. David Alan Gilbert wrote: > On ARM, don't map the code buffer at a fixed location, and fix up the > call/goto tcg routines to let it do long jumps. > > Mapping the code buffer at a fixed address could sometimes result in it being > mapped over the top of the heap wit

Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan

2011-12-14 Thread Eric Blake
On 12/14/2011 11:54 AM, Stefan Weil wrote: >> It does violate the standard _ followed by upper case letter is reserved >> in all contexts. > > sCamelCase instead of _CamelCase seems to work, too. What about _camelCase instead of _CamelCase? That preserves the leading underscore, but no longer us

[Qemu-devel] [PATCH v2 3/4] memory: update documentation to be in gtk-doc format

2011-12-14 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- memory.h | 341 ++ 1 files changed, 188 insertions(+), 153 deletions(-) diff --git a/memory.h b/memory.h index 057aa34..04370ff 100644 --- a/memory.h +++ b/memory.h @@ -16,6 +16,15 @@ #ifndef CONFI

Re: [Qemu-devel] [PATCH v2] qemu-ga: Add the guest-suspend command

2011-12-14 Thread Michael Roth
On 12/14/2011 10:38 AM, Luiz Capitulino wrote: On Wed, 14 Dec 2011 09:54:29 -0600 Michael Roth wrote: On 12/14/2011 07:00 AM, Luiz Capitulino wrote: On Tue, 13 Dec 2011 14:03:08 -0600 Michael Roth wrote: On 12/13/2011 12:28 PM, Luiz Capitulino wrote: It supports two modes: "hibernate" (w

[Qemu-devel] [PATCH v2 4/4] memory: move header into include/ and add to QEMU docs

2011-12-14 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- QEMU-docs.xml|1 + include/memory.h | 566 ++ memory.h | 566 -- 3 files changed, 567 insertions(+), 566 deletions(-) create mode 100644 in

Re: [Qemu-devel] [PATCH v2] qemu-ga: Add the guest-suspend command

2011-12-14 Thread Luiz Capitulino
On Wed, 14 Dec 2011 13:43:23 -0600 Michael Roth wrote: > On 12/14/2011 12:17 PM, Luiz Capitulino wrote: > > On Wed, 14 Dec 2011 14:38:55 -0200 > > Luiz Capitulino wrote: > > > I'm also wondering if we could use g_child_watch_add(), but it's not > clear > to me if it works with pr

Re: [Qemu-devel] [PATCH] spapr: Add support for -vga option

2011-12-14 Thread Benjamin Herrenschmidt
On Wed, 2011-12-14 at 16:30 +0100, Paolo Bonzini wrote: > On 12/14/2011 10:22 AM, Benjamin Herrenschmidt wrote: > > of course you can use -device > > to manually instanciate individual devices. > > That's true, however... > > > @@ -563,7 +568,9 @@ static void spapr_finalize_fdt(sPAPREnvironment *

[Qemu-devel] [PATCH v2 0/4] GTK-DOC build integration (v2)

2011-12-14 Thread Anthony Liguori
This series integrates GTK-DOC into our build process via a gtkdoc build target. This is to provide internal API documentation in a more accessible format. Once this gets merged into the tree, I'll add a nightly cron job on qemu.org so that there is always a copy of the latest internal API documen

[Qemu-devel] [PATCH v2 2/4] docs: add build infrastructure for gtkdocs (v2)

2011-12-14 Thread Anthony Liguori
By convention, documented headers now go in include/ Signed-off-by: Anthony Liguori --- v1 -> v2 - Require the user to specify a path to the special gtk-doc tool - Better handling of includes --- Makefile|6 +- Makefile.docs | 29 + Makefile.hw

[Qemu-devel] [PATCH v2 1/4] memory: make memory API parsable by gtkdoc-scan (v2)

2011-12-14 Thread Anthony Liguori
gtkdoc-scan cannot handle nested structs so remove those from the memory API. Signed-off-by: Anthony Liguori --- v1 -> v2 - no need to use underscores anymore --- memory.h | 73 ++--- 1 files changed, 41 insertions(+), 32 deletions(-) d

Re: [Qemu-devel] [PATCH v2] qemu-ga: Add the guest-suspend command

2011-12-14 Thread Michael Roth
On 12/14/2011 12:17 PM, Luiz Capitulino wrote: On Wed, 14 Dec 2011 14:38:55 -0200 Luiz Capitulino wrote: I'm also wondering if we could use g_child_watch_add(), but it's not clear to me if it works with processes not created with g_spawn_*() functions. GPid's map to something other than PIDs

Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan

2011-12-14 Thread Stefan Weil
Am 14.12.2011 17:34, schrieb malc: On Wed, 14 Dec 2011, Anthony Liguori wrote: GTK/glib uses a convenient of: typedef struct _CamelCase CamelCase; The reason that they use a separate struct name is that in C++, the struct namespace not a separate namespace from the type namespace. This is a

Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan

2011-12-14 Thread Anthony Liguori
On 12/14/2011 12:54 PM, Stefan Weil wrote: Am 14.12.2011 17:34, schrieb malc: On Wed, 14 Dec 2011, Anthony Liguori wrote: GTK/glib uses a convenient of: typedef struct _CamelCase CamelCase; The reason that they use a separate struct name is that in C++, the struct namespace not a separate na

Re: [Qemu-devel] [PATCH v2] qemu-ga: Add the guest-suspend command

2011-12-14 Thread Luiz Capitulino
On Wed, 14 Dec 2011 14:38:55 -0200 Luiz Capitulino wrote: > > > I'm also wondering if we could use g_child_watch_add(), but it's not clear > > > to me if it works with processes not created with g_spawn_*() functions. > > > > GPid's map to something other than PIDs on Windows, so I think we'd ha

Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan

2011-12-14 Thread Anthony Liguori
On 12/14/2011 11:26 AM, Peter Maydell wrote: On 14 December 2011 17:19, Anthony Liguori wrote: If you have a better suggestion, I'm all for it. Shrug. I'm not sure what problem you're solving here. To introduce the infrastructure such that we can have high quality internal documentation su

[Qemu-devel] [Bug 897750] Re: libvirt/kvm problem with disk attach/detach/reattach on running virt

2011-12-14 Thread Justin L Werner
I've been looking at libvirt and qemu for other work, I'm doing, and I've criceld back to take another look at this. Since I first looked at this, my testbed has updated to use the "oneiric-proposed" qemu-kvm package '0.14.1+noroms-0ubuntu6.1' while retaining the libvirt-bin package 0.9.2

Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan

2011-12-14 Thread Stefan Weil
Am 14.12.2011 18:19, schrieb Anthony Liguori: On 12/14/2011 11:11 AM, Peter Maydell wrote: On 14 December 2011 16:55, Anthony Liguori wrote: I think in this case, we're just going to have to deviate from the standard. The benefit is great, the practice is widespread, and there's no immediate

Re: [Qemu-devel] [Bug 904308] [NEW] x86: BT/BTS/BTR/BTC: ZF flag is unaffected

2011-12-14 Thread Avi Kivity
On 12/14/2011 06:33 PM, malc wrote: > > > > Best to be conservative here. > > > > Point being, any code that relies on it being in any particular state is > broken (potentially, on AMD chips) Yes of course, but not all software is written to be portable. Probably the only thing that will break

Re: [Qemu-devel] [PATCH] PPC: Fix linker scripts on ppc hosts

2011-12-14 Thread Paul Brook
> >> The proper solution would be to rewrite mmap.c to be smarter (perhaps > >> by looking at /proc/self/maps and reserving a lot of space with > >> PROT_NONE mappings at startup and then managing it itself), but so far > >> nobody's done that > > > > Yes they have. That's what -R does. > > -R do

Re: [Qemu-devel] [PATCH 2/2] [PATCH RFC v2 2/2] hyper-v: initialize Hyper-V CPUID leaves.

2011-12-14 Thread Vadim Rozenfeld
On Thu, 2011-12-01 at 15:52 +0100, Jan Kiszka wrote: > On 2011-10-23 17:39, Vadim Rozenfeld wrote: > > --- > > target-i386/kvm.c | 73 > > +++- > > 1 files changed, 71 insertions(+), 2 deletions(-) > > > > diff --git a/target-i386/kvm.c b/target-

Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan

2011-12-14 Thread Peter Maydell
On 14 December 2011 17:19, Anthony Liguori wrote: > If you have a better suggestion, I'm all for it. Shrug. I'm not sure what problem you're solving here. The bits of QEMU that are the worst to understand are the ones which aren't documented at all, and the bits where the general structure and un

Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan

2011-12-14 Thread Anthony Liguori
On 12/14/2011 11:11 AM, Peter Maydell wrote: On 14 December 2011 16:55, Anthony Liguori wrote: I think in this case, we're just going to have to deviate from the standard. The benefit is great, the practice is widespread, and there's no immediate likelihood of changing glib's coding style pract

Re: [Qemu-devel] [RFC] Device sandboxing

2011-12-14 Thread Serge E. Hallyn
Quoting Paul Moore (pmo...@redhat.com): > On Wednesday, December 07, 2011 12:48:16 PM Anthony Liguori wrote: > > On 12/07/2011 12:25 PM, Corey Bryant wrote: > > > A group of us are starting to work on sandboxing QEMU device emulation > > > code. We're just getting started investigating various appr

Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan

2011-12-14 Thread Peter Maydell
On 14 December 2011 16:55, Anthony Liguori wrote: > I think in this case, we're just going to have to deviate from the standard. > The benefit is great, the practice is widespread, and there's no immediate > likelihood of changing glib's coding style practices. > > I still think we should adhere t

Re: [Qemu-devel] [PATCH 2/3] target-mips:enabling of 64 bit user mode and floating point operations MIPS_HFLAG_UX is included in env->hflags so that the address computation for LD instruction does not

2011-12-14 Thread Richard Henderson
On 12/08/2011 04:04 PM, Andreas Färber wrote: >> > +/* if cpu has FPU, MIPS_HFLAG_F64 must be included in env->hflags >> > + so that floating point operations can be emulated */ >> > +env->active_fpu.fcr0 = env->cpu_model->CP1_fcr0; >> > if (env->active_fpu.fcr0 & (1 << FCR0_F64)

[Qemu-devel] [Bug 904308] Re: x86: BT/BTS/BTR/BTC: ZF flag is unaffected

2011-12-14 Thread Daniil Troshkov
>Best to be conservative here. What is it means? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/904308 Title: x86: BT/BTS/BTR/BTC: ZF flag is unaffected Status in QEMU: New Bug description: He

Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan

2011-12-14 Thread Anthony Liguori
On 12/14/2011 10:34 AM, malc wrote: On Wed, 14 Dec 2011, Anthony Liguori wrote: GTK/glib uses a convenient of: typedef struct _CamelCase CamelCase; The reason that they use a separate struct name is that in C++, the struct namespace not a separate namespace from the type namespace. This

Re: [Qemu-devel] [PATCH v2] qemu-ga: Add the guest-suspend command

2011-12-14 Thread Luiz Capitulino
On Wed, 14 Dec 2011 09:54:29 -0600 Michael Roth wrote: > On 12/14/2011 07:00 AM, Luiz Capitulino wrote: > > On Tue, 13 Dec 2011 14:03:08 -0600 > > Michael Roth wrote: > > > >> On 12/13/2011 12:28 PM, Luiz Capitulino wrote: > >>> It supports two modes: "hibernate" (which corresponds to S4) and >

[Qemu-devel] [PATCH 3/4] memory: update documentation to be in gtk-doc format

2011-12-14 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- memory.h | 341 ++ 1 files changed, 188 insertions(+), 153 deletions(-) diff --git a/memory.h b/memory.h index 3aa8404..4d76df3 100644 --- a/memory.h +++ b/memory.h @@ -16,6 +16,15 @@ #ifndef CONFI

[Qemu-devel] [PATCH 2/4] docs: add build infrastructure for gtkdocs

2011-12-14 Thread Anthony Liguori
By convention, documented headers now go in include/ Signed-off-by: Anthony Liguori --- Makefile |6 +- Makefile.docs | 15 +++ QEMU-docs.xml | 31 +++ 3 files changed, 51 insertions(+), 1 deletions(-) create mode 100644 Makefile.docs cr

Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan

2011-12-14 Thread malc
On Wed, 14 Dec 2011, Anthony Liguori wrote: > GTK/glib uses a convenient of: > > typedef struct _CamelCase CamelCase; > > The reason that they use a separate struct name is that in C++, the struct > namespace not a separate namespace from the type namespace. This is actually > a > reasonab

Re: [Qemu-devel] [Bug 904308] [NEW] x86: BT/BTS/BTR/BTC: ZF flag is unaffected

2011-12-14 Thread malc
On Wed, 14 Dec 2011, Avi Kivity wrote: > On 12/14/2011 06:22 PM, malc wrote: > > On Wed, 14 Dec 2011, Avi Kivity wrote: > > > > > On 12/14/2011 06:08 PM, malc wrote: > > > > On Wed, 14 Dec 2011, Daniil Troshkov wrote: > > > > > > > > > Public bug reported: > > > > > > > > > > Hello! > > > > > >

Re: [Qemu-devel] [Bug 904308] [NEW] x86: BT/BTS/BTR/BTC: ZF flag is unaffected

2011-12-14 Thread Avi Kivity
On 12/14/2011 06:22 PM, malc wrote: > On Wed, 14 Dec 2011, Avi Kivity wrote: > > > On 12/14/2011 06:08 PM, malc wrote: > > > On Wed, 14 Dec 2011, Daniil Troshkov wrote: > > > > > > > Public bug reported: > > > > > > > > Hello! > > > > > > > > Bug was found in qemu.git. > > > > See target-i386/tra

Re: [Qemu-devel] [PATCH v3 02/14] ARM: exynos4210: CMU support

2011-12-14 Thread Peter Maydell
On 14 December 2011 17:08, Maksim E. Kozlov wrote: >>> + >>> +/* >>> + * There are five CMUs: >>> + * >>> + *  CMU_LEFTBUS >>> + *  CMU_RIGHTBUS >>> + *  CMU_TOP >>> + *  CMU_DMC >>> + *  CMU_CPU >>> + * >>> + *  each of them uses 16KB address space for SFRs >>> + * >>> + *  + 0x4000 because SFR r

Re: [Qemu-devel] [Bug 904308] [NEW] x86: BT/BTS/BTR/BTC: ZF flag is unaffected

2011-12-14 Thread malc
On Wed, 14 Dec 2011, Avi Kivity wrote: > On 12/14/2011 06:08 PM, malc wrote: > > On Wed, 14 Dec 2011, Daniil Troshkov wrote: > > > > > Public bug reported: > > > > > > Hello! > > > > > > Bug was found in qemu.git. > > > See target-i386/translate.c: > > > > > > > [..snip..] > > > > Intel's docum

[Qemu-devel] [PATCH 4/4] memory: move header into include/ and add to QEMU docs

2011-12-14 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- QEMU-docs.xml|1 + include/memory.h | 566 ++ memory.h | 566 -- 3 files changed, 567 insertions(+), 566 deletions(-) create mode 100644 in

[Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan

2011-12-14 Thread Anthony Liguori
GTK/glib uses a convenient of: typedef struct _CamelCase CamelCase; The reason that they use a separate struct name is that in C++, the struct namespace not a separate namespace from the type namespace. This is actually a reasonable policy for QEMU to adopt as we eventually start exporting C

[Qemu-devel] [PATCH 0/4] GTK-DOC build integration

2011-12-14 Thread Anthony Liguori
This series integrates GTK-DOC into our build process via a gtkdoc build target. This is to provide internal API documentation in a more accessible format. Once this gets merged into the tree, I'll add a nightly cron job on qemu.org so that there is always a copy of the latest internal API documen

Re: [Qemu-devel] [PATCH 3/3] linux-user:Signal handling for MIPS64

2011-12-14 Thread Richard Henderson
On 12/07/2011 09:25 PM, kha...@kics.edu.pk wrote: > +#if defined(TARGET_MIPS64) > +/* tswapal() do 64 bit swap in case of MIPS64 but > + we need 32 bit swap as sa_flags is 32 bit */ > +k->sa_flags = bswap32(act->sa_flags); > +#else > k->sa_flags = tswapal(act->sa_

Re: [Qemu-devel] [Bug 904308] [NEW] x86: BT/BTS/BTR/BTC: ZF flag is unaffected

2011-12-14 Thread Avi Kivity
On 12/14/2011 06:08 PM, malc wrote: > On Wed, 14 Dec 2011, Daniil Troshkov wrote: > > > Public bug reported: > > > > Hello! > > > > Bug was found in qemu.git. > > See target-i386/translate.c: > > > > [..snip..] > > Intel's documentation doesn't cover this, AMD's says that ZF is undefined, so, >

Re: [Qemu-devel] [PATCH v3 02/14] ARM: exynos4210: CMU support

2011-12-14 Thread Maksim E. Kozlov
+ +/* + * There are five CMUs: + * + * CMU_LEFTBUS + * CMU_RIGHTBUS + * CMU_TOP + * CMU_DMC + * CMU_CPU + * + * each of them uses 16KB address space for SFRs + * + * + 0x4000 because SFR region for CMUs starts at 0x1003, + * but the first CMU (CMU_LEFTBUS) starts with this offset + * +

Re: [Qemu-devel] [Bug 904308] [NEW] x86: BT/BTS/BTR/BTC: ZF flag is unaffected

2011-12-14 Thread malc
On Wed, 14 Dec 2011, Daniil Troshkov wrote: > Public bug reported: > > Hello! > > Bug was found in qemu.git. > See target-i386/translate.c: > [..snip..] Intel's documentation doesn't cover this, AMD's says that ZF is undefined, so, question is: why do you think QEMU is wrong here? -- mailto

[Qemu-devel] [Bug 889053] Re: x86: FPU_MAX, FPU_MIN incorrect

2011-12-14 Thread Daniil Troshkov
I say about #define FPU_MIN(size, a, b) float ## size ## _lt(a, b, &env->sse_status) ? (a) : (b) #define FPU_MAX(size, a, b) float ## size ## _lt(b, a, &env->sse_status) ? (b) : (a) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. ht

[Qemu-devel] [Bug 904308] Re: x86: BT/BTS/BTR/BTC: ZF flag is unaffected

2011-12-14 Thread Peter Maydell
It would be helpful if you could submit patches in line with the guidance documented on the wiki: http://wiki.qemu.org/Contribute/SubmitAPatch In particular, patches should be sent to the mailing list in the right format, and we cannot apply any patch without a signed-off-by line. Thanks. -- Y

Re: [Qemu-devel] [PATCH 1/3] linux-user:Support for MIPS64 user mode emulation in QEMU

2011-12-14 Thread Richard Henderson
On 12/08/2011 07:15 AM, Andreas Färber wrote: > For linux-user IIUC the ABI is relevant, so shouldn't this be > mipsn64-linux-user? We have a patch for mipsn32/mipsn32el. What about > mipsn64el? The compiler flags are -mabi={32,n32,64,o64}, so no, not "n64". But yes, we should have an "el" version

[Qemu-devel] [PATCH 0/3] linux-user: Implement missing *xattr calls

2011-12-14 Thread Peter Maydell
These patches implement the missing *xattr syscalls: listxattr fsetattr, fgetattr, fremovexattr, flistxattr lsetattr, lgetattr, lremovexattr, llistxattr They also fix a bug in the existing code where we weren't allowing a NULL value pointer. Tested with the testcases in crackerjack. (There are

[Qemu-devel] [PATCH 2/3] linux-user/syscall.c: Implement f and l versions of set/get/removexattr

2011-12-14 Thread Peter Maydell
Implement the f and l versions (operate on fd, don't follow links) of the setxattr, getxattr and removexattr syscalls. Signed-off-by: Peter Maydell --- linux-user/syscall.c | 79 -- 1 files changed, 70 insertions(+), 9 deletions(-) diff --git a/

[Qemu-devel] [PATCH 3/3] linux-user: Implement *listxattr syscalls

2011-12-14 Thread Peter Maydell
Implement listxattr, flistxattr and llistxattr syscalls. Signed-off-by: Peter Maydell --- linux-user/syscall.c | 36 +++- 1 files changed, 35 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index a4596c0..17c8852 100644 --

[Qemu-devel] [Bug 889053] Re: x86: FPU_MAX, FPU_MIN incorrect

2011-12-14 Thread Daniil Troshkov
May be commit you patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/889053 Title: x86: FPU_MAX, FPU_MIN incorrect Status in QEMU: New Bug description: Dear All, Bug was found in qemu.git

  1   2   >