Re: [Qemu-devel] Initializing PC from memory on reset?

2011-11-23 Thread Peter Maydell
On 23 November 2011 23:59, Andreas Färber wrote: > Unlike PowerPC, an architecture that I'm trying to emulate does not > store branch instructions in the reset vector but a memory address. I'm > therefore trying to read physical address 0x0 and store its value > into my env->pc. Have you look

Re: [Qemu-devel] [libvirt] virDomainBlockJobAbort and block_job_cancel

2011-11-23 Thread Daniel Veillard
On Wed, Nov 23, 2011 at 09:04:50AM -0700, Eric Blake wrote: > On 11/23/2011 07:48 AM, Stefan Hajnoczi wrote: > > This means that virDomainBlockJobAbort() returns to the client without > > a guarantee that the job has completed. If the client enumerates jobs > > it may still see a job that has not

Re: [Qemu-devel] [PATCH V3 2/2] Add -f option to qemu-nbd

2011-11-23 Thread Chunyan Liu
2011/11/23 Stefan Hajnoczi > On Wed, Nov 23, 2011 at 10:14 AM, Chunyan Liu wrote: > > V3: > > Remove file lock in main(). > > Try to find new free nbd device and connect to it if connecting to the > first > > first found free nbd device failed. > > > > Signed-off-by: Chunyan Liu > > --- > > qe

[Qemu-devel] Initializing PC from memory on reset?

2011-11-23 Thread Andreas Färber
Hi, Unlike PowerPC, an architecture that I'm trying to emulate does not store branch instructions in the reset vector but a memory address. I'm therefore trying to read physical address 0x0 and store its value into my env->pc. I've verified by running with -S that xp /xh 0x0 shows the exp

Re: [Qemu-devel] [PATCH v2] linux-user: fix wait* syscall status returns

2011-11-23 Thread Peter Maydell
On 23 November 2011 23:44, Alexander Graf wrote: > When calling wait4 or waitpid with a status pointer and WNOHANG, the > syscall can potentially not modify the status pointer input. Now if we > have guest code like: > >  int status = 0; >  waitpid(pid, &status, WNOHANG); >  if (status) >     > >

Re: [Qemu-devel] [PATCH] linux-user: fix wait* syscall status returns

2011-11-23 Thread Peter Maydell
On 23 November 2011 23:31, Alexander Graf wrote: > If it was the same value before, it will still be the same value in guest > memory. > >  get_guest_s32(status, status_ptr); >  old_status = status; >  wait(...) >  if (old_status != status) { >    status = convert_status(status); >    put_guest_s

[Qemu-devel] [PATCH v2] linux-user: fix wait* syscall status returns

2011-11-23 Thread Alexander Graf
When calling wait4 or waitpid with a status pointer and WNOHANG, the syscall can potentially not modify the status pointer input. Now if we have guest code like: int status = 0; waitpid(pid, &status, WNOHANG); if (status) then we have to make sure that in case status did not change we

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Mr Dash Four
>>> Is there any solution to this? >> Traditional: it may be fixed in the mainline already, F15 has version >> 2.28.8, whereas mainline tip is 2.31.2. >> However nothing in the git log suggests that. > > FWIW Ubuntu Oneiric has glib2 2.30.0 and doesn't seem to have this problem. Just compiled, bu

Re: [Qemu-devel] [PATCH 1/2] Reopen files after migration

2011-11-23 Thread Anthony Liguori
On 11/23/2011 09:34 AM, Juan Quintela wrote: We need to invalidate the Read Cache on the destination, otherwise we have corruption. Easy way to reproduce it is: - create an qcow2 images - start qemu on destination of migration (qemu -incoming tcp:...) - start qemu on source of migration an

Re: [Qemu-devel] [PATCH] linux-user: fix wait* syscall status returns

2011-11-23 Thread Alexander Graf
On 24.11.2011, at 00:02, Peter Maydell wrote: > On 23 November 2011 23:00, Alexander Graf wrote: >> >> On 23.11.2011, at 23:34, Peter Maydell wrote: >> >>> On 23 November 2011 22:03, Alexander Graf wrote: Yes. Maybe we should add a check if input_state != output_state and only then

Re: [Qemu-devel] [PATCH 1.0 (resend)] eepro100: Fix alignment requirement for statistical counters

2011-11-23 Thread Anthony Liguori
On 11/23/2011 04:26 PM, Michael S. Tsirkin wrote: On Wed, Nov 23, 2011 at 10:20:30PM +0100, Stefan Weil wrote: According to Intel's Open Source Software Developer Manual, the dump counters address must be Dword aligned. The new code enforces this alignment, so s->statsaddr may now be used with

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Peter Maydell
On 23 November 2011 23:15, Max Filippov wrote: >> >> /usr/lib/gcc/x86_64-redhat-linux/4.6.1/../../../../lib64/libglib-2.0.a(gmem.o):(.note.stapsdt+0x24): >> >> undefined reference to `glib_mem__alloc_semaphore' >> >> /usr/lib/gcc/x86_64-redhat-linux/4.6.1/../../../../lib64/libglib-2.0.a(gmem.o):(

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Max Filippov
> >> /usr/lib/gcc/x86_64-redhat-linux/4.6.1/../../../../lib64/libglib-2.0.a(gmem.o):(.note.stapsdt+0x24): > >> undefined reference to `glib_mem__alloc_semaphore' > >> /usr/lib/gcc/x86_64-redhat-linux/4.6.1/../../../../lib64/libglib-2.0.a(gmem.o):(.note.stapsdt+0x7c): > >> undefined reference to `

Re: [Qemu-devel] [PATCH] linux-user: fix wait* syscall status returns

2011-11-23 Thread Peter Maydell
On 23 November 2011 23:00, Alexander Graf wrote: > > On 23.11.2011, at 23:34, Peter Maydell wrote: > >> On 23 November 2011 22:03, Alexander Graf wrote: >>> Yes. Maybe we should add a check if input_state != output_state and >>> only then do the conversion? >> >> I'm not sure this works (unless y

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Mr Dash Four
>> $ make V=1 >> gcc -m64 -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 >> -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef >> -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing >> -fstack-protector-all -Wendif-labels -Wmissing-include-dirs -Wempty-body

Re: [Qemu-devel] [PATCH] linux-user: fix wait* syscall status returns

2011-11-23 Thread Alexander Graf
On 23.11.2011, at 23:34, Peter Maydell wrote: > On 23 November 2011 22:03, Alexander Graf wrote: >> On 23.11.2011, at 22:55, Peter Maydell wrote: >>> If the problem is that waitpid() can return success without writing to >>> status, then this code is still not right because we will get the >>>

Re: [Qemu-devel] [PATCH] linux-user: fix wait* syscall status returns

2011-11-23 Thread Peter Maydell
On 23 November 2011 22:03, Alexander Graf wrote: > On 23.11.2011, at 22:55, Peter Maydell wrote: >> If the problem is that waitpid() can return success without writing to >> status, then this code is still not right because we will get the >> initial target waitstatus into status, and then pass i

Re: [Qemu-devel] [PATCH 1.0 (resend)] eepro100: Fix alignment requirement for statistical counters

2011-11-23 Thread Michael S. Tsirkin
On Wed, Nov 23, 2011 at 10:20:30PM +0100, Stefan Weil wrote: > According to Intel's Open Source Software Developer Manual, > the dump counters address must be Dword aligned. > > The new code enforces this alignment, so s->statsaddr may now > be used with stw_le_pci_dma() and stl_le_pci_dma(). > >

Re: [Qemu-devel] [PATCH] configure: avoid screening of --{en, dis}able-usb-redir options

2011-11-23 Thread Peter Maydell
On 23 November 2011 21:53, Max Filippov wrote: > --*dir) option pattern precede --{en,dis}able-usb-redir) patterns in the > option analysis switch, making the latter options have no effect. > > Signed-off-by: Max Filippov I just said this in the other thread, but to repeat it in the right place:

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Peter Maydell
On 23 November 2011 20:27, Mr Dash Four wrote: > Peter, I hope you would be able to advice me on the following, if you can > please: I have some ugly stuff in my qemu.spec file as follows: [delete huge spec file] > What parts do you think I should keep and should I delete, do you > have an idea?

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Peter Maydell
On 23 November 2011 21:40, Max Filippov wrote: > --- a/configure > +++ b/configure > @@ -759,8 +759,6 @@ for opt do >   ;; >   --enable-opengl) opengl="yes" >   ;; > -  --*dir) > -  ;; >   --disable-rbd) rbd="no" >   ;; >   --enable-rbd) rbd="yes" Haha, nice catch. Incidentally I think that the p

Re: [Qemu-devel] [PATCH] linux-user: fix wait* syscall status returns

2011-11-23 Thread Alexander Graf
On 23.11.2011, at 22:55, Peter Maydell wrote: > On 23 November 2011 20:38, Alexander Graf wrote: >> When calling wait4 or waitpid with a status pointer and WNOHANG, the >> syscall can potentially not modify the status pointer input. Now if we >> have guest code like: >> >> int status = 0; >>

Re: [Qemu-devel] Status of the SH4 / ARM7 emulators

2011-11-23 Thread Richard Henderson
On 11/20/2011 12:51 PM, Andreas Färber wrote: > * Part of the problem is that common CPUState fields are not at the > start of the struct. I have therefore been playing with a > CPU_COMMON_PREFIX at the start of the struct and using a macro for > clearing on reset, which preserves part of the commo

Re: [Qemu-devel] [PATCH] linux-user: fix wait* syscall status returns

2011-11-23 Thread Peter Maydell
On 23 November 2011 20:38, Alexander Graf wrote: > When calling wait4 or waitpid with a status pointer and WNOHANG, the > syscall can potentially not modify the status pointer input. Now if we > have guest code like: > >  int status = 0; >  waitpid(pid, &status, WNOHANG); >  if (status) >     > >

[Qemu-devel] [PATCH] configure: avoid screening of --{en, dis}able-usb-redir options

2011-11-23 Thread Max Filippov
--*dir) option pattern precede --{en,dis}able-usb-redir) patterns in the option analysis switch, making the latter options have no effect. Signed-off-by: Max Filippov --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index f033438..e5

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Max Filippov
> > Did configure reported 'usb net redir' as 'no'? > > Could you try configure and build in a clean directory? > [mr-4@test1 qemu-1.0-rc3]$ ./configure --target-list="arm-linux-user > armeb-linux-user" --disable-kvm --disable-strip --disable-xen --disable-spice > --disable-werror --disable-sdl -

[Qemu-devel] [PATCH 1.0 (resend)] eepro100: Fix alignment requirement for statistical counters

2011-11-23 Thread Stefan Weil
According to Intel's Open Source Software Developer Manual, the dump counters address must be Dword aligned. The new code enforces this alignment, so s->statsaddr may now be used with stw_le_pci_dma() and stl_le_pci_dma(). Signed-off-by: Stefan Weil --- hw/eepro100.c | 10 +- 1 files

Re: [Qemu-devel] [PATCH v3 1.0] configure: tighten pie toolchain support test for tls variables

2011-11-23 Thread Brad
On 23/11/11 4:24 AM, Avi Kivity wrote: Some toolchains don't support pie properly when tls variables are in use. Disallow pie when such toolchains are detected. Signed-off-by: Avi Kivity Thanks. Works as expected now. -- This message has been scanned for viruses and dangerous content by Mail

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Mr Dash Four
> Did configure reported 'usb net redir' as 'no'? > Could you try configure and build in a clean directory? [mr-4@test1 qemu-1.0-rc3]$ ./configure --target-list="arm-linux-user armeb-linux-user" --disable-kvm --disable-strip --disable-xen --disable-spice --disable-werror --disable-sdl --disable-v

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Max Filippov
> Even though I executed "./configure --target-list="arm-linux-user > armeb-linux-user" --disable-kvm --disable-strip --disable-xen --disable-spice > --disable-werror --disable-sdl --disable-vnc --disable-bluez > --disable-check-utests --disable-smartcard --disable-usb-redir --static" the > -lu

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Mr Dash Four
> I don't get that - I get *SUCCESS*!!! I am going to run this through the > rpmbuild, so that I get a proper package done. I am an *idiot*. I just realised that I've ran ./configure the last time without the --static option. My build now fails with: gcc -m64 -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D

[Qemu-devel] [PATCH] linux-user: fix wait* syscall status returns

2011-11-23 Thread Alexander Graf
When calling wait4 or waitpid with a status pointer and WNOHANG, the syscall can potentially not modify the status pointer input. Now if we have guest code like: int status = 0; waitpid(pid, &status, WNOHANG); if (status) then we have to make sure that in case status did not change we

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Mr Dash Four
> In the latest F15 it's not fixed. Mr-4, probably you will not escape > re-compiling, if not even patching glib2. Nope, I've just built it successfully (see my previous post)!

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Mr Dash Four
> It fails some other way ): > > $ make V=1 > gcc -m64 -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 > -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef > -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing > -fstack-protector-all -Wendif-labels -Wmissi

Re: [Qemu-devel] [RFC PATCH] Exporting Guest RAM information for NUMA binding

2011-11-23 Thread Andrea Arcangeli
On Wed, Nov 23, 2011 at 07:34:37PM +0100, Alexander Graf wrote: > So if you define "-numa node,mem=1G,cpus=0" then QEMU should be able to > tell the kernel that this GB of RAM actually is close to that vCPU thread. > Of course the admin still needs to decide how to split up memory. That's > the d

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Max Filippov
> It fails some other way ): > > $ make V=1 > gcc -m64 -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 > -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef > -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing > -fstack-protector-all -Wendif-labels -Wmissing

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Mr Dash Four
>> That is what I just wrote in my previous post, didn't I? The "die die die" >> comments were related to the glib package, not the glib2! Just open >> glib.spec and see it for yourself. > > However it looks from Max's list of libraries like the glib2-static package > contains all the static lib

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Max Filippov
> >>> So, somebody at Fedora doesn't like static (.a) files very much, it > >>> seems. I could easily correct this, enable static building and have these > >>> installed, I think. > >> > >> There's glib2-static in Fedora: > >> > >> $ rpm -ql glib2-static > >> /usr/lib64/libgio-2.0.a > >> /usr/lib

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Peter Maydell
On 23 November 2011 19:57, Mr Dash Four wrote: >>> So, somebody at Fedora doesn't like static (.a) files very much, it seems. >>> I could easily correct this, enable static building and have these >>> installed, I think. >> >> There's glib2-static in Fedora: >> >> $ rpm -ql glib2-static >> /usr/

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Mr Dash Four
>> So, somebody at Fedora doesn't like static (.a) files very much, it seems. I >> could easily correct this, enable static building and have these installed, >> I think. > > There's glib2-static in Fedora: > > $ rpm -ql glib2-static > /usr/lib64/libgio-2.0.a > /usr/lib64/libglib-2.0.a > /usr/l

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Max Filippov
> > Do you have a static libgthread-2.0? (ie /usr/lib/libgthread-2.0.a or > > equivalent). > Nope, this is what I have: > > /usr/lib64/libgthread.so > /usr/lib64/libgthread-2.0.so > /usr/lib64/libgthread-1.2.so.0 > /usr/lib64/libgthread-1.2.so.0.0.10 > > *but*, just downloaded the source rpm and

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Mr Dash Four
> Do you have a static libgthread-2.0? (ie /usr/lib/libgthread-2.0.a or > equivalent). Nope, this is what I have: /usr/lib64/libgthread.so /usr/lib64/libgthread-2.0.so /usr/lib64/libgthread-1.2.so.0 /usr/lib64/libgthread-1.2.so.0.0.10 *but*, just downloaded the source rpm and looked at the .spec

[Qemu-devel] Latest QEMU does not support --enable-check-utests on Debian with --enable-pie (default)

2011-11-23 Thread Stefan Weil
This is my configuration and the output from configure: configure '--audio-card-list=ac97,es1370,sb16,cs4231a,adlib,gus,hda' '--audio-drv-list=alsa,sdl,oss,esd,pa' '--enable-mixemu' '--enable-check-utests' '--enable-vnc-thread' ERROR ERROR: User requested feature check ERROR: configure was not

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Peter Maydell
On 23 November 2011 19:22, Mr Dash Four wrote: > >> OK. We don't explicitly try to link with ssl3 ourselves, so this only >> ever ends up in LDFLAGS because of some other library that has claimed >> it needs it as a dependency via pkg-config. Try adding >>  --disable-sdl --disable-vnc --disable-bl

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Mr Dash Four
> Which binary are we trying to link when we fail? This is where it all fails: gcc -m64 -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fstack-protector-a

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Peter Maydell
On 23 November 2011 19:02, Mr Dash Four wrote: > >> Sonuds like a good plan. > Nope, same error as before: > /usr/bin/ld: cannot find -lssl3 > collect2: ld returned 1 exit status Which binary are we trying to link when we fail? > I get exactly the same result if I just unpack the source and run

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Mr Dash Four
> Sonuds like a good plan. Nope, same error as before: /usr/bin/ld: cannot find -lssl3 collect2: ld returned 1 exit status The source was unpacked, I disabled all the patches in that .spec file, ran "rpmbuild -bp qemu.spec", then manually went to that directory (BUILD/qemu-1.0-rc3) and typed ".

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Peter Maydell
On 23 November 2011 18:42, Mr Dash Four wrote: >> Can you retry this with one of the 1.0 release candidates >> or current head-of-git, please? > OK, I'll try with 1.0-rc3, but before that just a quick query - I use the > Fedora source rpm as a basis and do "rpmbuild -bp qemu.spec" to prepare > th

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Mr Dash Four
> Can you retry this with one of the 1.0 release candidates > or current head-of-git, please? OK, I'll try with 1.0-rc3, but before that just a quick query - I use the Fedora source rpm as a basis and do "rpmbuild -bp qemu.spec" to prepare the source. This, according to the said .spec file, appli

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Peter Maydell
On 23 November 2011 18:33, Mr Dash Four wrote: > FYI Peter, I just tried to build qemu with only the -user targets - > unsuccessfully - exactly the same error as before -lssl3 cannot be found. Can you retry this with one of the 1.0 release candidates or current head-of-git, please? (when I do a

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Mr Dash Four
>> >> So, where do I get this? > > > > You don't. Fedora does not package static libraries. Just don't use > > the option on Linux, it makes (a little) sense only on Windows to get a > > monolithic, redistributable qemu.exe. So, what you are suggesting above is that qemu-[arch]-static cannot be

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Mr Dash Four
>> You don't. Fedora does not package static libraries. Just don't use the >> option on Linux, it makes (a little) sense only on Windows to get a >> monolithic, redistributable qemu.exe. > > It's also important for building linux-user targets so you can > put them in chroots. Luckily linux-user

Re: [Qemu-devel] [RFC PATCH] Exporting Guest RAM information for NUMA binding

2011-11-23 Thread Alexander Graf
On 11/23/2011 04:03 PM, Andrea Arcangeli wrote: Hi! On Mon, Nov 21, 2011 at 07:51:21PM -0600, Anthony Liguori wrote: Fundamentally, the entity that should be deciding what memory should be present and where it should located is the kernel. I'm fundamentally opposed to trying to make QEMU overr

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Peter Maydell
On 23 November 2011 18:00, Paolo Bonzini wrote: > You don't.  Fedora does not package static libraries.  Just don't use the > option on Linux, it makes (a little) sense only on Windows to get a > monolithic, redistributable qemu.exe. It's also important for building linux-user targets so you can

Re: [Qemu-devel] [Xen-devel] [PATCH V4 05/10] Introduce HostPCIDevice to access a pci device on the host.

2011-11-23 Thread Anthony PERARD
On Fri, Nov 18, 2011 at 15:06, Konrad Rzeszutek Wilk wrote: >> +static int host_pci_config_read(HostPCIDevice *d, int pos, void *buf, int >> len) >> +{ >> +    int fd = host_pci_config_fd(d); >> +    int res = 0; >> + >> +again: >> +    res = pread(fd, buf, len, pos); >> +    if (res != len) { >>

Re: [Qemu-devel] [PATCH v3 07/11] bonito: convert north bridge register mapping to memory API

2011-11-23 Thread Peter Maydell
2011/11/23 Benoît Canet : > It would work using memory_region_add_subregion() and get_system_memory() > but Avi previously noticed me that using get_system_memory() in devices > is wrong because it goes against one of the goals of the memory API : > avoiding global knowledge. Yes. It's a bit diffi

[Qemu-devel] [PATCH 2/7] usb: fix usb_qdev_init error handling.

2011-11-23 Thread Gerd Hoffmann
qdev doesn't call the ->exit callback on ->init failures, so we have to take care ourself that we cleanup property on errors. Signed-off-by: Gerd Hoffmann --- hw/usb-bus.c | 18 +++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index

[Qemu-devel] [PATCH 4/7] usb-hub: implement reset

2011-11-23 Thread Gerd Hoffmann
based on a patch from hk...@linux.vnet.ibm.com Signed-off-by: Gerd Hoffmann --- hw/usb-hub.c | 20 +--- 1 files changed, 17 insertions(+), 3 deletions(-) diff --git a/hw/usb-hub.c b/hw/usb-hub.c index 5b48763..e195937 100644 --- a/hw/usb-hub.c +++ b/hw/usb-hub.c @@ -222,7 +222

[Qemu-devel] [PULL 1.0] usb fixes

2011-11-23 Thread Gerd Hoffmann
Hi, A few more usb bugfixes. Two are pretty serious error handling issues (patches 1+2) which can lead to use-after-free. The other ones are minor but still nice to have and simple enougth that the risk to break something is low. please pull, Gerd The following changes since commit 40897c9

[Qemu-devel] [PATCH 7/7] usb-host: add usb_host_do_reset function.

2011-11-23 Thread Gerd Hoffmann
Add a special function to reset the host usb device. It tracks the time needed by the USBDEVFS_RESET ioctl and prints a warning in case it needs too long. Usually it should be finished in 200 - 300 miliseconds. Warning threshold is one second. Intention is to help troubleshooting by indicating t

[Qemu-devel] [PATCH 1/2] configure: Include #define name in check_define compiler error

2011-11-23 Thread Peter Maydell
Include the name of the #define being tested for in the compiler error produced when a check_define test is run and fails. This appears only in the config.log, but it does make it a little easier to debug problems by inspecting config.log. Signed-off-by: Peter Maydell --- configure |2 +- 1

[Qemu-devel] [PATCH 1/7] usb: make usb_create_simple catch and pass up errors.

2011-11-23 Thread Gerd Hoffmann
Use qdev_init() instead of qdev_init_nofail(), usb device initialization can fail, most common case being port and device speed mismatch. Handle failures correctly and pass up NULL pointers then. Also fixup usb_create_simple() callers (only one was buggy) to properly check for NULL pointers befor

[Qemu-devel] planet-ltc.com

2011-11-23 Thread Alex
Preferred Domain Availability Notice: planet-ltc.com will be listed for auction in a few days. This domain might be useful for you, since you own a domain similar to this domain. To confirm interest in owning this domain, fill out the simple form here: planet-ltc.com Sincerely

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Paolo Bonzini
On 11/23/2011 04:41 PM, Mr Dash Four wrote: Hmm, this opens a huge Pandora's box for me - in my own distribution (Fedora) the "nss" package (which I have installed) provides /usr/lib64/libssl3.so, but not libssl3.a. "nss-devel" (which I also have installed) provides all the relevant /include fi

Re: [Qemu-devel] [PATCH v3 07/11] bonito: convert north bridge register mapping to memory API

2011-11-23 Thread Benoît Canet
2011/11/23 Peter Maydell > 2011/11/22 Benoît Canet : > > static int bonito_initfn(PCIDevice *dev) > > { > > PCIBonitoState *s = DO_UPCAST(PCIBonitoState, dev, dev); > > +SysBusDevice *sysbus = sysbus_from_qdev(&dev->qdev); > > This looks odd. The device here is a PCIBonitoState, which >

Re: [Qemu-devel] oprofile on qemu

2011-11-23 Thread Max Filippov
> I oprofiled QEMU with some workloads, i.e. SPECjbb on Ubuntu Linux, i > see QEMU spent about 60 - 70% of the time in the code cache ( code > cache size is 256MB ). but I want to know which TB takes the most > amount of time. I doubt that it's possible to profile TB code by external tools without

[Qemu-devel] [PATCH 5/7] usb-ehci: codestyle fixups

2011-11-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb-ehci.c | 56 1 files changed, 28 insertions(+), 28 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index 3eea94d..2609aba 100644 --- a/hw/usb-ehci.c +++ b/hw/usb-ehci.c @@ -437,37 +437,37 @

[Qemu-devel] [PATCH 6/7] usb-ehci: add register names

2011-11-23 Thread Gerd Hoffmann
The mmio register name list only had the names for four port status registers. We emulate a EHCI adapter with six ports though, the last two ones are listed as "unknown" in traces. Fix it. Signed-off-by: Gerd Hoffmann --- hw/usb-ehci.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-

[Qemu-devel] [PATCH 2/2] configure: Print a banner comment at the top of config.log

2011-11-23 Thread Peter Maydell
Print a banner comment at the top of config.log identifying when configure was run and the arguments used. This is occasionally useful for debugging purposes. Signed-off-by: Peter Maydell --- configure |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/configure b/confi

[Qemu-devel] [PATCH 0/2] configure: minor improvements to config.log

2011-11-23 Thread Peter Maydell
Two trivial patches which make it a little easier to look at config.log and figure out what's going on. The next step down this road would probably be something like test_start() { echo "# Checking for $1..." >> config.log } and then lots of: test_start "zlib" in the relevant plac

[Qemu-devel] [PATCH 3/7] usb-hub: wakeup on detach too.

2011-11-23 Thread Gerd Hoffmann
When detaching devices from the usb hub we must wakeup too, otherwise the host misses the detach event. Commit 4a33a9ea06f6fbb08d8311a7cfed72975344f9ab does the same for device attach. Found by hk...@linux.vnet.ibm.com Signed-off-by: Gerd Hoffmann --- hw/usb-hub.c |2 ++ 1 files changed, 2

Re: [Qemu-devel] [PATCH v2] qcow2: Unlock during COW

2011-11-23 Thread Kevin Wolf
Am 14.11.2011 18:55, schrieb Kevin Wolf: > Unlocking during COW allows for more parallelism. One change it requires is > that buffers are dynamically allocated instead of just using a per-image > buffer. > > While touching the code, drop the synchronous qcow2_read() function and > replace > it by

[Qemu-devel] [RFC PATCH 2/3] raw: implement raw_get_alignment

2011-11-23 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/raw-posix.c | 65 ++-- block/raw-win32.c | 45 2 files changed, 97 insertions(+), 13 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 3482fc8..f674

[Qemu-devel] [RFC PATCH 3/3] block: do not rely on the buffer alignment passed to the guest

2011-11-23 Thread Paolo Bonzini
The guest alignment should not override the host's. Instead, just use the bdrv_set_buffer_alignment calls to print a warning about possible performance degradations due to insufficiently-aligned guest buffers. Signed-off-by: Paolo Bonzini --- block.c |8 ++-- block.h

[Qemu-devel] [RFC PATCH 1/3] block: add bdrv_get_alignment, use it

2011-11-23 Thread Paolo Bonzini
We cannot simply use the guest logical block size on the host; we need to ask the protocol driver about the minimum required alignment. Signed-off-by: Paolo Bonzini --- block.c | 26 -- block.h |1 + block/raw-posix.c |3 ++- block_int.h

[Qemu-devel] [RFC PATCH 0/3] block: add support for 4k logical blocks

2011-11-23 Thread Paolo Bonzini
This series adds support for 4k logical blocks by bouncing requests unless the host's logical_block_size is also 4096. Paolo Bonzini (3): block: add bdrv_get_alignment, use it raw: implement raw_get_alignment block: do not rely on the buffer alignment passed to the guest block.c

[Qemu-devel] [PATCH 8/8] vmstate: Add copyright info for sparc processor

2011-11-23 Thread Juan Quintela
v2: Move license to BSD-like as in vl.c Signed-off-by: Juan Quintela --- target-sparc/vmstate-cpu.c | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/target-sparc/vmstate-cpu.c b/target-sparc/vmstate-cpu.c index 259db19..c74ea9a 100644 --- a/ta

Re: [Qemu-devel] oprofile on qemu

2011-11-23 Thread Xin Tong
I oprofiled QEMU with some workloads, i.e. SPECjbb on Ubuntu Linux, i see QEMU spent about 60 - 70% of the time in the code cache ( code cache size is 256MB ). but I want to know which TB takes the most amount of time. Thanks Xin On Wed, Nov 23, 2011 at 3:10 AM, 陳韋任 wrote: > On Tue, Nov 22, 20

[Qemu-devel] [PATCH 2/8] vmstate: Add copyright info for lm32 processor

2011-11-23 Thread Juan Quintela
Signed-off-by: Juan Quintela Acked-By: Michael Walle --- target-lm32/vmstate-cpu.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/target-lm32/vmstate-cpu.c b/target-lm32/vmstate-cpu.c index 60b4b29..27e09d2 100644 --- a/target-lm32/vmstate-cpu.c +++ b/tar

Re: [Qemu-devel] [PATCH v2] cow: use bdrv_co_is_allocated()

2011-11-23 Thread Kevin Wolf
Am 23.11.2011 16:00, schrieb Stefan Hajnoczi: > Now that bdrv_co_is_allocated() is available we can use it instead of > the synchronous bdrv_is_allocated() interface. This is a follow-up that > Kevin Wolf pointed out after applying the series that > introduces bdrv_co_is_allocated(). > > It is s

Re: [Qemu-devel] [libvirt] virDomainBlockJobAbort and block_job_cancel

2011-11-23 Thread Eric Blake
On 11/23/2011 07:48 AM, Stefan Hajnoczi wrote: > This means that virDomainBlockJobAbort() returns to the client without > a guarantee that the job has completed. If the client enumerates jobs > it may still see a job that has not finished cancelling. The client > must register a handler for the B

Re: [Qemu-devel] [PATCH v2] Support for UDP unicast network backend

2011-11-23 Thread Benjamin
Signed-off-by: Benjamin MARSILI --- net.c |6 - net/socket.c| 71 +- qemu-options.hx |2 + 3 files changed, 76 insertions(+), 3 deletions(-) diff --git a/net.c b/net.c index cb52050..8e957b2 100644 --- a/net.c ++

Re: [Qemu-devel] husb: out of buffers for iso stream

2011-11-23 Thread Gerd Hoffmann
On 11/19/11 20:40, Stefan Hajnoczi wrote: > I have a Windows 7 VM running a sound driver for a passthrough USB > host device. The driver submits iso in and out urbs to do audio > capture and playback at the same time. > > Audacity running inside the guest freezes and does not record audio > unles

[Qemu-devel] [Bug 894037] [NEW] With VNC, "-usbdevice tablet" no longer makes mouse pointers line up

2011-11-23 Thread Timothy Miller
Public bug reported: I use qemu in VNC mode. In order to get the client and server mouse pointers to line up, I've had to use the "-usbdevice tablet" option. This no longer works, and it behaves the same as if the option is not there. This makes my VMs unusable to me. Here's how I'm booting Win

Re: [Qemu-devel] [RFC PATCH 0/2] Fix migration with NFS & iscsi/Fiber channel

2011-11-23 Thread Juan Quintela
Juan Quintela wrote: Hi I did the stupid thing, and send the wrong directory of patches, sorry for any inconveniences. /me writes 100 times: I have to re-read the whole command line before sending patches /me writes another 100 times Later, Juan.

[Qemu-devel] [PATCH 7/8] vmstate: Add copyright info for ppc processor

2011-11-23 Thread Juan Quintela
v2: Move license to BSD-like as in vl.c Signed-off-by: Juan Quintela --- target-ppc/vmstate-cpu.c | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/target-ppc/vmstate-cpu.c b/target-ppc/vmstate-cpu.c index 1664d32..9e36a18 100644 --- a/target-pp

[Qemu-devel] [PATCH 5/8] vmstate: Add copyright info for i386 processor

2011-11-23 Thread Juan Quintela
v2: Move license to BSD-like as in vl.c Add Fabrice copyright from vl.c Signed-off-by: Juan Quintela --- target-i386/vmstate-cpu.c | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/target-i386/vmstate-cpu.c b/target-i386/vmstate-cpu.c index

[Qemu-devel] [PATCH 6/8] vmstate: Add copyright info for mips processor

2011-11-23 Thread Juan Quintela
v2: Move license to BSD-like as in vl.c Signed-off-by: Juan Quintela --- target-mips/vmstate-cpu.c | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/target-mips/vmstate-cpu.c b/target-mips/vmstate-cpu.c index d6d7830..f709cf2 100644 --- a/targe

[Qemu-devel] [PATCH 4/8] vmstate: Add copyright info for arm processor

2011-11-23 Thread Juan Quintela
Signed-off-by: Juan Quintela Acked-by: Andrzej Zaborowski --- target-arm/vmstate-cpu.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/target-arm/vmstate-cpu.c b/target-arm/vmstate-cpu.c index 836d9ed..bc48434 100644 --- a/target-arm/vmstate-cpu.c +++ b/ta

[Qemu-devel] [PATCH 1/8] vmstate: Add copyright info for alpha processor

2011-11-23 Thread Juan Quintela
Signed-off-by: Juan Quintela Acked-by: Richard Henderson --- target-alpha/vmstate-cpu.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/target-alpha/vmstate-cpu.c b/target-alpha/vmstate-cpu.c index 156cb74..9d4b065 100644 --- a/target-alpha/vmstate-cpu.c +

[Qemu-devel] [PATCH 3/8] vmstate: Add copyright info for cris processor

2011-11-23 Thread Juan Quintela
Signed-off-by: Juan Quintela Acked-by: Edgar E. Iglesias --- target-cris/vmstate-cpu.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/target-cris/vmstate-cpu.c b/target-cris/vmstate-cpu.c index 0f732d3..f062272 100644 --- a/target-cris/vmstate-cpu.c +++ b

[Qemu-devel] [PATCH v2 0/8] [RFC] vmstate: Add copyrights for all cpus

2011-11-23 Thread Juan Quintela
Hi [ Resnd this time also ading fabrice address, sorry ] v2: - split patches by file, make easier to add "acked-by" notices. - cc'd fabrice - everybody (except for Thiemo for ovbious reasons) answered. - move ppc/sparc/i386 to BSD like license from vl.c at Blue suggestion. - move all other li

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Mr Dash Four
Perhaps you lack a static version of the library. What do you mean by that? The *.la files? I wasn't aware that there are any... I mean lib*.a files. They are needed if you specify static, by definition. Hmm, this opens a huge Pandora's box for me - in my own distribution (Fedora) the "nss

Re: [Qemu-devel] MMU address collision.

2011-11-23 Thread Michael Rolnik
Hi all, I have a question regarding MMU. I've built SPARC based small embedded system. at this system addresses *0x-0x8000* (32KB) belong to ROM and *0x8000 - 0x80001000* to HW devices. the problem is that when a code from first ROM page accesses a HW device register there is an

[Qemu-devel] MMU address collision.

2011-11-23 Thread Michael Rolnik
Hi all, I have a question regarding MMU. I've built SPARC based small embedded system. at this system addresses *0x-0x8000* (32KB) belong to ROM and *0x8000 - 0x80001000* to HW devices. the problem is that when a code from first ROM page accesses a HW device register there is an

Re: [Qemu-devel] cannot build qemu with "--static" configure option

2011-11-23 Thread Paolo Bonzini
On 11/23/2011 03:15 PM, Mr Dash Four wrote: It would indicate a missing libssl3, but the library, as far as I can see, is there! When I try building this without the "--static" option all is well - the build succeeds without any hitches. What could be the problem with this, what am I missing? P

Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems

2011-11-23 Thread Paolo Bonzini
On 11/23/2011 04:11 PM, Aneesh Kumar K.V wrote: > > virtio-9p-handle.c is only for recent Linux and you can assume the ioctl > is defined there. But the file gets build by default right ? ie, we would build virtio-9p-handle.c and if FS_IOC_GETVERSION is not defined, build will fail right ? I

Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems

2011-11-23 Thread Aneesh Kumar K.V
On Wed, 23 Nov 2011 08:24:53 +0100, Paolo Bonzini wrote: > On 11/23/2011 07:16 AM, Aneesh Kumar K.V wrote: > > We would also require same changes for virtio-9p-handle.c right ? > > virtio-9p-handle.c is only for recent Linux and you can assume the ioctl > is defined there. But the file gets bui

Re: [Qemu-devel] [RFC PATCH] Exporting Guest RAM information for NUMA binding

2011-11-23 Thread Andrea Arcangeli
Hi! On Mon, Nov 21, 2011 at 07:51:21PM -0600, Anthony Liguori wrote: > Fundamentally, the entity that should be deciding what memory should be > present > and where it should located is the kernel. I'm fundamentally opposed to > trying > to make QEMU override the scheduler/mm by using cpu or

[Qemu-devel] [PATCH v2] cow: use bdrv_co_is_allocated()

2011-11-23 Thread Stefan Hajnoczi
Now that bdrv_co_is_allocated() is available we can use it instead of the synchronous bdrv_is_allocated() interface. This is a follow-up that Kevin Wolf pointed out after applying the series that introduces bdrv_co_is_allocated(). It is safe to make cow_read() a coroutine_fn because its only cal

  1   2   >