On 11/21/2011 10:01 PM, Anthony Liguori wrote:
-return qemu_utimensat(AT_FDCWD, rpath(s, path, buffer), buf,
- AT_SYMLINK_NOFOLLOW);
+return qemu_utimens(rpath(s, path, buffer), buf);
Hrm, I thought the SYMLINK_NOFOLLOW was critical in enforcing security?
Yes
On 11/22/2011 02:58 AM, Anthony Liguori wrote:
Current version of seabios is 1.6.3, released several
weeks ago. Compared with the version currently shipped
in qemu, it adds a few commits, most of which are fixes
for qemu-related issues. Maybe it's not too late to update
seabios to the latest
On 11/18/2011 04:36 PM, Paolo Bonzini wrote:
On 11/18/2011 03:59 PM, Paolo Bonzini wrote:
The fw paths for USB devices that SeaBIOS computes are off-by-one,
because QEMU builds those paths with a numbering that starts from one
(see usb_fill_port and usb_hub_initfn in QEMU). Fix that so that
the
On 11/22/2011 07:39 AM, Mark Wu wrote:
Hours in 12-hour mode are in the 1-12 range, not 0-11.
Interesting. I would like to know how you could find this problem. It
seems linux driver never changes the format and 24-hour is default in
rtc emulation code. So how did it expose and how to test it?
On 11/22/2011 02:00 AM, Paolo Bonzini wrote:
Hours in 12-hour mode are in the 1-12 range, not 0-11.
Interesting. I would like to know how you could find this problem. It
seems linux driver never changes the format and 24-hour is default in
rtc emulation code. So how did it expose and how to te
Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built
around the FreeScale i.MX31.
Signed-off-by: Hans Jang
Signed-off-by: Adam Clench
Signed-off-by: Peter Chubb
---
Makefile.target |2
hw/kzm.c| 155
2 fi
Implement the FreeSCALE i.MX31 advanced vectored interrupt controller, at least
to the extent it is used by Linux 3.0.x
Signed-off-by: Hans Jang
Signed-off-by: Adam Clench
Signed-off-by: Peter Chubb
---
hw/imx_avic.c | 363 ++
1 file cha
Implement the timers on the FreeScale i.MX31 SoC.
This is not a complete implementation, but gives enough for
Linux to boot and run.
Signed-off-by: Hans Jang
Signed-off-by: Adam Clench
Signed-off-by: Peter Chubb
---
hw/imx_timer.c | 441 ++
Implement the FreeScale i.MX UART. This uart is used in a variety of
SoCs, including some by Motorola, as well as in the FreeScale i.MX
series.
Signed-off-by: Hans Jang
Signed-off-by: Adam Clench
Signed-off-by: Peter Chubb
---
hw/imx_serial.c | 307 ++
Here follow four patches in separate emails, to implement basic
i.mx31 SoC support, and the KZM evaluation board built around this
chip.
The patch to the Makefile to build all the files is in the last of
the series, rather than changing Makefile.hw in each patch.
All comments received so far have
Properly implement dual-timer read/write for the sp804 dual timer module.
Based on ARM specs at
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0271d/index.html
Signed-off-by: Hans Jang
Signed-off-by: David Mirabito
Signed-off-by: Peter Chubb
---
hw/arm_timer.c | 41 +
Two of the calls to hw_error() in arm_timer.c contain the wrong function name.
As suggested by Andreas Färber, use the C99 standard __func__ macro to
get the correct name, instead of putting the name directly into the code.
Signed-off-by: Peter Chubb
---
hw/arm_timer.c |8
1 file
From: Dong Xu Wang
s->lock should be unlocked before leaving add_aio_request.
Signed-off-by: Dong Xu Wang
---
block/sheepdog.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 9f80609..62f1f3a 100644
--- a/block/sheepdog.c
+++
On 11/21/2011 03:22 PM, Michael Tokarev wrote:
Current version of seabios is 1.6.3, released several
weeks ago. Compared with the version currently shipped
in qemu, it adds a few commits, most of which are fixes
for qemu-related issues. Maybe it's not too late to update
seabios to the latest r
On 11/21/2011 04:50 PM, Chris Wright wrote:
* Peter Zijlstra (a.p.zijls...@chello.nl) wrote:
On Mon, 2011-11-21 at 21:30 +0530, Bharata B Rao wrote:
In the original post of this mail thread, I proposed a way to export
guest RAM ranges (Guest Physical Address-GPA) and their corresponding host
h
On 11/21/2011 11:03 AM, Peter Zijlstra wrote:
On Mon, 2011-11-21 at 21:30 +0530, Bharata B Rao wrote:
In the original post of this mail thread, I proposed a way to export
guest RAM ranges (Guest Physical Address-GPA) and their corresponding host
host virtual mappings (Host Virtual Address-HVA)
When usinge "-vga none -nographic" option.
There is no any text and graphic console created in this case.
screen dump not supported without console.
Signed-off-by: Cao,Bing Bu
---
console.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/console.c b/console.c
index
On 11/21/2011 10:56 AM, Michael S. Tsirkin wrote:
This fixes bugs dealing with msi-x mask bits pointed out by Jan Kiszka.
Applied. Thanks.
Regards,
Anthony Liguori
Jan Kiszka (1):
msix: Prevent bogus mask updates on MMIO accesses
Michael S. Tsirkin (2):
msix: track function masked
On 11/20/2011 06:54 PM, Max Filippov wrote:
Add check for the EFD_NONBLOCK and EFD_CLOEXEC flags to the
CONFIG_EVENTFD test.
This fixes the following build failure on Fedora 9:
CCevent_notifier.o
event_notifier.c: In function `event_notifier_init':
event_notifier.c:21: error
On 11/20/2011 05:34 AM, Stefan Weil wrote:
zlib.h is not a local include file, therefore it should be included
using<> instead of "".
Signed-off-by: Stefan Weil
Applied. Thanks.
Regards,
Anthony Liguori
---
block/vmdk.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
On 11/15/2011 12:12 PM, Avi Kivity wrote:
Change the default on x86 Linux hosts to building PIE (position
independent executables); instead of restricting the option to
user-only targets, apply it to all targets.
In addition, set the relocation sections to read-only (relro) when
available; this
Due to this commit:
commit 40d6444e91c6ab17e5e8ab01d4eece90cbc4afed
Author: Avi Kivity
Date: Tue Nov 15 20:12:17 2011 +0200
configure: build position independent executables on x86-Linux hosts
PIE binaries cannot be linked with non-PIE binaries and make is not smart enough
to rebuild wh
On 11/21/2011 04:56 AM, zanghongy...@huawei.com wrote:
From: Hongyong Zang
Ivshmem cannot work, and the command lspci cannot show ivshmem BAR2 in the
guest.
As for pci_register_bar(), parameter MemoryRegion should be s->bar instead of
s->ivshmem.
Signed-off-by: Hongyong Zang
Applied. Thank
> "Peter" == Peter Maydell writes:
Peter> On 21 November 2011 23:54, Peter Chubb
Peter> wrote:
>> Do you have a suggestion for an alternative to hw_error for guest
>> bad behaviour? It seems to be used historically. For emulating
>> ARM, causing qemu to stop isn't such a bad idea ... the g
On 22 November 2011 00:27, Peter Chubb wrote:
>> "Peter" == Peter Maydell writes:
>
> Peter> On 21 November 2011 23:54, Peter Chubb
> Peter> wrote:
>>> Do you have a suggestion for an alternative to hw_error for guest
>>> bad behaviour? It seems to be used historically. For emulating
>>> A
On 11/18/2011 10:35 AM, Paolo Bonzini wrote:
Old systems do not have AT_REMOVEDIR, and 9pfs fails to compile
on them. Patch 2 fixes that, patch 1 actually let me test it
on Linux. :)
Probably the same push-down should be done also for open(2) flags,
for consistency. For example, some systems m
On 11/14/2011 03:09 PM, Anthony Liguori wrote:
This lets different subsystems register an Error that is thrown whenever
migration is attempted. This works nicely because it gracefully supports
things like hotplug.
Right now, if multiple errors are registered, only one of them is reported.
I exp
On 11/17/2011 07:03 AM, Stefan Hajnoczi wrote:
These bug fixes and documentation fixes are suitable for 1.0. The purely
internal trivial patches are being queued up for 1.1 in the
trivial-patches-next tree.
The following changes since commit 3f5bd4e1b874590d3d76e031530799a4610da6dc:
Update
On 11/17/2011 11:18 AM, Luiz Capitulino wrote:
Anthony,
This pull contains a fix for the enum type handling plus Michael's Makefile
fixes.
Pulled. Thanks.
Regards,
Anthony Liguori
The changes (since 3f5bd4e1b874590d3d76e031530799a4610da6dc) are available
in the following repository:
Fix names of functions in error messages: as suggested by Andreas
Färber, use the C99 standard __func__ macro to get the correct name.
This fixes one real bug (the message used to print sp804 instead of
icp_pit), the other changes are cosmetic.
Signed-off-by: Peter Chubb
---
hw/arm_timer.c |
On 11/18/2011 08:03 AM, Kevin Wolf wrote:
The following changes since commit 3f5bd4e1b874590d3d76e031530799a4610da6dc:
Update version to 1.0-rc2 (2011-11-14 11:26:32 -0600)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git for-anthony
Pulled. Thanks.
Regards,
An
On 11/21/2011 10:15 AM, Gerd Hoffmann wrote:
Hi,
This pull fixes SYNCRONIZE_CACHE handling in usb-storage code.
The SYNCRONIZE_CACHE scsi command is different from all other ones:
It doesn't transfer any data, but still doesn't complete instantly.
usb-storage failes to handle this case corre
Hi,
On behalf of the QEMU Team, I'd like to announce the availability of QEMU 1.0,
release candidate 3. This is the third release candidate for the 1.0 release.
This is not intended for production use but rather for testing.
To participate in the testing effort, please read the Testing Wiki[
On 21 November 2011 23:54, Peter Chubb wrote:
> Do you have a suggestion for an alternative to hw_error for guest bad
> behaviour? It seems to be used historically. For emulating ARM,
> causing qemu to stop isn't such a bad idea ... the guest does
> something wrong and the qemu instance dies wit
Thanks Peter,
I'll split the patches and resubmit. It'll probably be tomorrow or Thursday.
Do you have a suggestion for an alternative to hw_error for guest bad
behaviour? It seems to be used historically. For emulating ARM,
causing qemu to stop isn't such a bad idea ... the guest does
somethin
On 21 November 2011 21:58, Peter Chubb wrote:
> Hi Peter,
> Please find appended a patch containing initial support for the
> FreeScale i.MX31 and the KZM Arm11 evaluation board.
>
> The implementation was originally written by Hans Jang and Adam
> Clench of OK-Labs; I've updated it to the
The offending code seems to be:
/* advertise availability of ioapic inti2 */
timer->config |= 0x0004ULL << 32;
in hw/hpet.c hpet_reset().
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.ne
On 21 November 2011 23:04, Peter Chubb wrote:
>> "Andreas" == Andreas Färber writes:
>>> ??? Save/restore. */
>
> Andreas> What does this comment tell us? :)
>
> Dunno. It was in the codebase I got; I think it means that save and
> restore aren't implemented yet.
I think what Andreas is t
> "Andreas" == Andreas Färber writes:
Andreas> Hi Peter, Am 21.11.2011 22:58, schrieb Peter Chubb:
>> Hi Peter, Please find appended a patch containing initial support
>> for the FreeScale i.MX31 and the KZM Arm11 evaluation board.
Andreas> Your patch format is a bit unusual.
Andreas> Pleas
Am 21.11.2011 23:05, schrieb Peter Chubb:
> Hi Peter,
>Here's a fixed patch for the sp804 timer.
>
> Properly implement the dual-timer read/write for the sp804 dual timer module.
> Based on ARM specs at
> http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0271d/index.html
>
> Sign
Thanks for the answer. For right now, I am OK with this, since I realized
that cache access is uniform (cache sets are calculated by modulo) and my
work concerns with cache. Still, I am happy to know that it is expected
thing and not unexpected.
Also I have one very important question and I would
Public bug reported:
The emulated HPET only supports triggering IRQ 2. Since MSIs are by
default disabled, this severely limits the usefulness of the HPET as
only one timer block can effectively be used (otherwise they would share
IRQ 2). Ideally, the HPET should support as much timer blocks as CP
* Peter Zijlstra (a.p.zijls...@chello.nl) wrote:
> On Mon, 2011-11-21 at 21:30 +0530, Bharata B Rao wrote:
> >
> > In the original post of this mail thread, I proposed a way to export
> > guest RAM ranges (Guest Physical Address-GPA) and their corresponding host
> > host virtual mappings (Host Vir
Hi Peter,
Am 21.11.2011 22:58, schrieb Peter Chubb:
> Hi Peter,
>Please find appended a patch containing initial support for the
>FreeScale i.MX31 and the KZM Arm11 evaluation board.
Your patch format is a bit unusual.
Please don't include personal messages in the description, keep it in
Hi Peter,
Here's a fixed patch for the sp804 timer.
Properly implement the dual-timer read/write for the sp804 dual timer module.
Based on ARM specs at
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0271d/index.html
Signed-off-by: Peter Chubb
Signed-off-by: David Mirabito
Sig
Hi Peter,
Please find appended a patch containing initial support for the
FreeScale i.MX31 and the KZM Arm11 evaluation board.
The implementation was originally written by Hans Jang and Adam
Clench of OK-Labs; I've updated it to the current qdev and memory
region paradigms and imple
Current version of seabios is 1.6.3, released several
weeks ago. Compared with the version currently shipped
in qemu, it adds a few commits, most of which are fixes
for qemu-related issues. Maybe it's not too late to update
seabios to the latest released version in order to incorporate
all the f
On 11/19/2011 03:22 AM, Hans de Goede wrote:
Hi All,
Sorry for sending these in so late, I send most of them in before a long time
ago, but then they got stuck on waiting for the big chardev rewrite. Since it
seems clear now that the big chardev rewrite won't happen before 1.0, I would
like to g
On 11/21/2011 02:29 AM, Paolo Bonzini wrote:
Small requirements on "new" features have percolated to virtio-9p-local.c.
In particular, the utimensat wrapper actually only supports dirfd = AT_FDCWD
and flags = AT_SYMLINK_NOFOLLOW in the fallback code. Remove the arguments
so that virtio-9p-local.
On 11/20/2011 08:53 AM, Avi Kivity wrote:
On 11/18/2011 04:54 PM, Anthony Liguori wrote:
Thinking more about it, I think this entire line of thinking is wrong
(including mine) :-)
The problem you're trying to solve is that the RTC fires two 1 second
timers regardless of whether the guest is re
On 11/21/2011 10:00 AM, Juan Quintela wrote:
Hi
Please send in any agenda items you are interested in covering.
I'm technical on holiday this week so I won't be attending.
But as an FYI, I ran across seccomp-nurse[1] this weekend. It more or less
let's you write a python program to impleme
Am 21.11.2011 20:49, schrieb Peter Maydell:
On 21 November 2011 19:41, Stefan Weil wrote:
This bug was spotted by cppcheck.
Using g_try_malloc0 (as does the linux-user code) fixes this.
Signed-off-by: Stefan Weil
Oh look, another bug in bsd-user it wouldn't have if it shared code
with linux-
This bug was spotted by cppcheck.
Using g_try_malloc0 (as does the linux-user code) fixes this.
v2:
Use g_free in bsdload.c, too. Thanks to Peter Maydell for this hint.
Signed-off-by: Stefan Weil
---
bsd-user/bsdload.c |2 +-
bsd-user/elfload.c |5 ++---
2 files changed, 3 insertions(+
On 21 November 2011 19:41, Stefan Weil wrote:
> This bug was spotted by cppcheck.
>
> Using g_try_malloc0 (as does the linux-user code) fixes this.
>
> Signed-off-by: Stefan Weil
Oh look, another bug in bsd-user it wouldn't have if it shared code
with linux-user :-)
> bsd-user/elfload.c | 5
This bug was spotted by cppcheck.
Using g_try_malloc0 (as does the linux-user code) fixes this.
Signed-off-by: Stefan Weil
---
bsd-user/elfload.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c
index 1ef1f97..124 100644
--
On Mon, 2011-11-21 at 20:03 +0200, Avi Kivity wrote:
>
> Does ms_mbind() require that its vmas in its area be completely
> contained in the region, or does it split vmas on demand? I suggest the
> latter to avoid exposing implementation details.
as implemented (which is still rather incomplete)
PCI_NUM_REGIONS is 7, ARRAY_SIZE(bars) is 6. Either bars must be
extended by a 7th array element, or the loop which reads bars[i]
must terminate before it tries to read bars[6].
For dev->io_regions[6].size == 0, the old code also works,
but it is not obvious whether this is always true.
This bug
On 11/21/2011 06:09 PM, Luiz Capitulino wrote:
test-coroutine is listed as a libcheck test in the 'checks' variable. This
is not right because 'make check' won't run test-coroutine if libcheck
tests are not enabled (either because libcheck isn't detected or because
--disable-check-utests is passe
On 11/21/2011 05:25 PM, Peter Zijlstra wrote:
> On Mon, 2011-11-21 at 20:48 +0530, Bharata B Rao wrote:
>
> > I looked at Peter's recent work in this area.
> > (https://lkml.org/lkml/2011/11/17/204)
> >
> > It introduces two interfaces:
> >
> > 1. ms_tbind() to bind a thread to a memsched(*) grou
Am 18.11.2011 16:33, schrieb Alexander Graf:
>
> On 10.11.2011, at 10:32, Andreas Färber wrote:
>
>> Am 09.11.2011 23:53, schrieb Andreas Färber:
>>> I get the following error:
>>>
>>> $ s390x-softmmu/qemu-system-s390x
>>> qemu-system-s390x: Guest moved used index from 0 to 47802
>>
>> Now with -
When an rtc interrupt is reinjected immediately after being acked,
other interrupts should not be reinjected, so do clear their bits.
Also, if the periodic interrupts have been disabled before acking,
do not reinject, as the guest might get very confused!
Signed-off-by: Paolo Bonzini
---
hw/mc1
Hours in 12-hour mode are in the 1-12 range, not 0-11.
Signed-off-by: Paolo Bonzini
---
hw/mc146818rtc.c | 11 +++
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
index 2aaca2f..14c8cb9 100644
--- a/hw/mc146818rtc.c
+++ b/hw/mc146818rt
Am 21.11.2011 18:09, schrieb Luiz Capitulino:
> test-coroutine is listed as a libcheck test in the 'checks' variable. This
> is not right because 'make check' won't run test-coroutine if libcheck
> tests are not enabled (either because libcheck isn't detected or because
> --disable-check-utests is
Signed-off-by: Paolo Bonzini
---
hw/mc146818rtc.c |4 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
index a5c533b..b942ce2 100644
--- a/hw/mc146818rtc.c
+++ b/hw/mc146818rtc.c
@@ -179,8 +179,9 @@ static void rtc_periodic_timer(void *opa
Signed-off-by: Paolo Bonzini
---
hw/mc146818rtc.c | 19 ++-
1 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
index 14c8cb9..a5c533b 100644
--- a/hw/mc146818rtc.c
+++ b/hw/mc146818rtc.c
@@ -427,16 +427,17 @@ static void rtc_updat
Here are a bunch of fixes for the rtc that I found while reading
the code. Might be for 1.0 or 1.1, at your choice.
I also have a fix for at least one relatively important bug: when writing
register B unmasks a pending interrupt, the IRQ line should be raised.
However, the fix is a bit invasive s
test-coroutine is listed as a libcheck test in the 'checks' variable. This
is not right because 'make check' won't run test-coroutine if libcheck
tests are not enabled (either because libcheck isn't detected or because
--disable-check-utests is passed).
Tests using the glib test framework are inde
On Tue, Nov 15, 2011 at 11:47:58AM +0100, ext Juan Quintela wrote:
> Takuya Yoshikawa wrote:
> > Adding qemu-devel ML to CC.
> >
> > Your question should have been sent to qemu-devel ML because the logic
> > is implemented in QEMU, not KVM.
> >
> > (2011/11/11 1:35), Oliver Hookins wrote:
> >> Hi,
Signed-off-by: Gerd Hoffmann
---
hw/usb-msd.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/hw/usb-msd.c b/hw/usb-msd.c
index 089c23c..6f32a0e 100644
--- a/hw/usb-msd.c
+++ b/hw/usb-msd.c
@@ -59,7 +59,6 @@ typedef struct {
char *serial;
SCSIDevice *scsi_dev
Contains unit-tests for the QMP output visitor implementation.
Signed-off-by: Luiz Capitulino
---
Makefile |4 +
configure |2 +-
qapi-schema-test.json |6 +
test-qmp-output-visitor.c | 423 +
4 files c
Hi,
This pull fixes SYNCRONIZE_CACHE handling in usb-storage code.
The SYNCRONIZE_CACHE scsi command is different from all other ones:
It doesn't transfer any data, but still doesn't complete instantly.
usb-storage failes to handle this case correctly, resulting in all sorts
of funky assert fai
Gerd Hoffmann writes:
> Commit 0c402e5abb8c2755390eee864b43a98280fc2453 is incomplete
> and misses one of the two function pointer calls in
> usb_host_scan_dev(). Add the additional port handling logic
> to the other call too.
>
> Spotted by Coverity.
>
> Cc: Markus Armbruster
> Signed-off-by:
Gerd Hoffmann writes:
> Commit 0c402e5abb8c2755390eee864b43a98280fc2453 is incomplete
> and misses one of the two function pointer calls in
> usb_host_scan_dev(). Add the additional port handling logic
> to the other call too.
>
> Spotted by Coverity.
>
> Cc: Markus Armbruster
> Signed-off-by:
This series introduces two new test programs: test-qmp-output-visitor and
test-qmp-input-visitor.
As their names suggest, they contain unit-tests to check QMP's Visitor
implementation. They supersede the test-visitor program (which is dropped
by this series).
Besides adding new unit-tests, I've _
Contains unit-tests for the QMP input visitor implementation.
Signed-off-by: Luiz Capitulino
---
Makefile |4 +
configure|2 +-
test-qmp-input-visitor.c | 270 ++
3 files changed, 275 insertions(+), 1 deletions(
usb_msd_send_status can be called from different code paths, move the
debug message into the function to make sure it is printed
unconditionally.
Signed-off-by: Gerd Hoffmann
---
hw/usb-msd.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/usb-msd.c b/hw/usb-msd.c
It has been superseded by the two previous commits, which introduced
the test-qmp-output-visitor and test-qmp-input-visitor tests.
Signed-off-by: Luiz Capitulino
---
Makefile |5 +-
test-visitor.c | 338
2 files changed, 1 inser
On Mon, 2011-11-21 at 21:30 +0530, Bharata B Rao wrote:
>
> In the original post of this mail thread, I proposed a way to export
> guest RAM ranges (Guest Physical Address-GPA) and their corresponding host
> host virtual mappings (Host Virtual Address-HVA) from QEMU (via QEMU monitor).
> The idea
On Fri, Nov 18, 2011 at 6:28 PM, Kevin Wolf wrote:
> Kevin Wolf (9):
> qcow2: Return real error code in qcow2_read_snapshots
> qcow2: Return real error code in qcow2_write_snapshots
> qcow2: Update snapshot table information at once
> qcow2: Cleanups and memleak fix in qcow2_snapshot_create
>
Check pending bit only if vector mask status changed.
This is not really important for qemu.git but helps
fix a bug in qemu-kvm.git.
Signed-off-by: Michael S. Tsirkin
---
hw/msix.c | 29 -
1 files changed, 20 insertions(+), 9 deletions(-)
diff --git a/hw/msix.c b/h
>From: Jan Kiszka
Only accesses to the MSI-X table must trigger a call to
msix_handle_mask_update, otherwise the vector
value might be out of range.
Signed-off-by: Jan Kiszka
Signed-off-by: Michael S. Tsirkin
---
hw/msix.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff
Only go over the table when function is masked.
This is not really important for qemu.git but helps
fix a bug in qemu-kvm.git.
Signed-off-by: Michael S. Tsirkin
---
hw/msix.c | 21 ++---
hw/pci.h |2 ++
2 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/hw/msi
This fixes bugs dealing with msi-x mask bits pointed out by Jan Kiszka.
Jan Kiszka (1):
msix: Prevent bogus mask updates on MMIO accesses
Michael S. Tsirkin (2):
msix: track function masked in pci device state
msix: avoid mask updates if mask is unchanged
hw/msix.c | 48
Commit 0c402e5abb8c2755390eee864b43a98280fc2453 is incomplete
and misses one of the two function pointer calls in
usb_host_scan_dev(). Add the additional port handling logic
to the other call too.
Spotted by Coverity.
Cc: Markus Armbruster
Signed-off-by: Gerd Hoffmann
---
usb-linux.c |7 +
On Fri, Nov 18, 2011 at 6:29 PM, Kevin Wolf wrote:
> + /*
> + * Increase the refcounts of all clusters and make sure everything is
> + * stable on disk before updating the snapshot table to contain a pointer
> + * to the new L1 table.
> + */
> + ret = qcow2_update_snapshot_re
scsi keeps track of the tag in SCSIRequest,
no need to store a separate copy.
Signed-off-by: Gerd Hoffmann
---
hw/usb-msd.c | 13 ++---
1 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/hw/usb-msd.c b/hw/usb-msd.c
index 5dc4afc..089c23c 100644
--- a/hw/usb-msd.c
+++ b/hw/u
Put status word into device state, fill it in command_complete, have
usb_msd_send_status just send it out.
Signed-off-by: Gerd Hoffmann
---
hw/usb-msd.c | 38 +-
1 files changed, 21 insertions(+), 17 deletions(-)
diff --git a/hw/usb-msd.c b/hw/usb-msd.c
ind
Until recently all scsi commands sent to scsi-disk did either transfer
data or finished instantly. The correct implementation of
SYNCRONIZE_CACHE changed the picture though, and usb-storage needs
a fix to handle that case correctly.
---
hw/usb-msd.c | 16 ++--
1 files changed, 10 in
Coverity thinks q could be NULL there and warns.
I believe it can't be NULL there.
Add assert to prove it.
Signed-off-by: Gerd Hoffmann
---
hw/usb-ehci.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c
index cdd5aae..3eea94d 100644
--- a/hw/
Hi
Please send in any agenda items you are interested in covering.
Later, Juan.
On Mon, Nov 21, 2011 at 04:25:26PM +0100, Peter Zijlstra wrote:
> On Mon, 2011-11-21 at 20:48 +0530, Bharata B Rao wrote:
>
> > I looked at Peter's recent work in this area.
> > (https://lkml.org/lkml/2011/11/17/204)
> >
> > It introduces two interfaces:
> >
> > 1. ms_tbind() to bind a thread to
On Mon, 2011-11-21 at 20:48 +0530, Bharata B Rao wrote:
> I looked at Peter's recent work in this area.
> (https://lkml.org/lkml/2011/11/17/204)
>
> It introduces two interfaces:
>
> 1. ms_tbind() to bind a thread to a memsched(*) group
> 2. ms_mbind() to bind a memory region to memsched group
>
In case the guest sends a SYNCHRONIZE_CACHE command scsi_req_complete()
is called twice: Once because there is no data to transfer and
scsi-disk thinks it is done with the command, and once when the flush is
actually finished ...
Signed-off-by: Gerd Hoffmann
---
hw/scsi-disk.c |5 +++--
1 f
scsi keeps track of the tag in SCSIRequest,
no need to store a separate copy.
Signed-off-by: Gerd Hoffmann
---
hw/usb-msd.c | 13 ++---
1 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/hw/usb-msd.c b/hw/usb-msd.c
index 5dc4afc..089c23c 100644
--- a/hw/usb-msd.c
+++ b/hw/u
On Tue, Nov 08, 2011 at 09:33:04AM -0800, Chris Wright wrote:
> * Alexander Graf (ag...@suse.de) wrote:
> > On 29.10.2011, at 20:45, Bharata B Rao wrote:
> > > As guests become NUMA aware, it becomes important for the guests to
> > > have correct NUMA policies when they run on NUMA aware hosts.
> >
From: "M. Mohan Kumar"
Signed-off-by: M. Mohan Kumar
---
qemu-options.hx | 25 -
1 files changed, 16 insertions(+), 9 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 681eaf1..cde17ed 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -530,19 +530,
Commit 0c402e5abb8c2755390eee864b43a98280fc2453 is incomplete
and misses one of the two function pointer calls in
usb_host_scan_dev(). Add the additional port handling logic
to the other call too.
Spotted by Coverity.
Cc: Markus Armbruster
Signed-off-by: Gerd Hoffmann
---
usb-linux.c |7 +
From: "M. Mohan Kumar"
Add new proxy filesystem driver to add root privilege to qemu process.
It needs a helper process to be started by root user.
Following command line can be used to utilize proxy filesystem driver
-virtfs proxy,id=,mount_tag=,socket_fd=
Signed-off-by: M. Mohan Kumar
---
M
From: "M. Mohan Kumar"
Pass-through security model in QEMU 9p server needs root privilege to do
few file operations (like chown, chmod to any mode/uid:gid). There are two
issues in pass-through security model
1) TOCTTOU vulnerability: Following symbolic links in the server could
provide access
From: "M. Mohan Kumar"
Signed-off-by: M. Mohan Kumar
---
Makefile | 12 +++-
fsdev/virtfs-proxy-helper.texi | 59
2 files changed, 70 insertions(+), 1 deletions(-)
create mode 100644 fsdev/virtfs-proxy-helper.texi
diff --g
1 - 100 of 162 matches
Mail list logo
