Re: [Qemu-devel] [PATCH 1.0 v4] configure: build position independent executables across the board, by default

2011-11-14 Thread Avi Kivity
On 11/14/2011 06:03 PM, Peter Maydell wrote: > On 14 November 2011 15:31, Avi Kivity wrote: > > @@ -1099,6 +1099,22 @@ for flag in $gcc_flags; do > > fi > > done > > > > +if test "$pie" = "yes" ; then > > + cat > $TMPC << EOF > > +int main(void) { return 0; } > > +EOF > > + if compile_prog

Re: [Qemu-devel] [PATCH 1.0] configure: build position independent executables across the board, by default

2011-11-14 Thread Avi Kivity
On 11/14/2011 08:45 PM, Peter Maydell wrote: > On 14 November 2011 15:18, Avi Kivity wrote: > > On 11/14/2011 05:15 PM, Peter Maydell wrote: > >> One of the failure cases I was thinking of is that if PIE means > >> the platform's loader puts things in a different bit of the > >> address space this

Re: [Qemu-devel] QEMU + ARMMP11Core combination does not work

2011-11-14 Thread TusharK
Hello Peter, Thanks for reply. Please find the comments below. (1) Does your kernel boot on the real hardware? I do not have real hardware to test my kernel. But what I did was, I downloaded pre-built kernel image from http://code.google.com/p/smp-on-qemu/downloads/list website and tried to run

Re: [Qemu-devel] I have some questions in block , can anyone help me, thank you!

2011-11-14 Thread Zhi Hui Li
On 2011年11月14日 18:00, Stefan Hajnoczi wrote: On Mon, Nov 14, 2011 at 01:47:41PM +0800, Zhi Hui Li wrote: 1) In qcow2.c, in function: qcow2_co_readv In qcow2.h, in struct BDRVQcowState I want to know the relations between sector_num in function qcow2_co_readv and cluster_sectors in struct BDR

Re: [Qemu-devel] [PATCH 0/5] docs: convert specifications to markdown

2011-11-14 Thread Stefan Weil
Am 14.11.2011 23:41, schrieb Anthony Liguori: Right now our specs are written in psuedo-wiki syntax. This series converts them to markdown. markdown is a simple markup format that's gaining in popularity. The big advantage of using markdown is that there are tools that can convert it to relati

[Qemu-devel] [PATCH v5] block:add-cow file format

2011-11-14 Thread Dong Xu Wang
From: Dong Xu Wang Provide a new file format: add-cow. The usage can be found in add-cow.txt of this patch. Signed-off-by: Dong Xu Wang --- Makefile.objs |1 + block.c|2 +- block.h|1 + block/add-cow.c| 417

[Qemu-devel] [Bug 838974] Re: Confusing error report for missing vde support

2011-11-14 Thread Dwight Schauer
** Also affects: qemu-kvm (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/838974 Title: Confusing error report for missing vde support Status in

Re: [Qemu-devel] Summary of Anthony's 'next' queue

2011-11-14 Thread Stefan Berger
On 11/14/2011 03:17 PM, Anthony Liguori wrote: Hi, This is a summary of the patches that I have queued in my next tree that were identified as 1.1 candidates. These patches will not be applied until after the 1.1 tree opens (December 1st). These patches have not been tested yet and may rece

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-11-14 Thread Alex Williamson
On Mon, 2011-11-14 at 13:54 -0700, Alex Williamson wrote: > On Fri, 2011-11-11 at 18:14 -0600, Scott Wood wrote: > > On 11/03/2011 03:12 PM, Alex Williamson wrote: > > > + int (*get)(void *); > > > + void(*put)(void *); > > > + ssize_t (*read)

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.0-rc1

2011-11-14 Thread Anthony Liguori
On 11/14/2011 07:13 PM, 陳韋任 wrote: Hi, Anthony On behalf of the QEMU Team, I'd like to announce the availability of QEMU 1.0, release candidate 2. This is the second release candidate for the 1.0 release. This is not intended for production use but rather for testing. The mail subject sho

[Qemu-devel] Unsubscription Confirmation

2011-11-14 Thread RealEstateMalaysian.com
Thank you for subscribing. You have now unsubscribed and no more messages will be sent.

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.0-rc1

2011-11-14 Thread 陳韋任
Hi, Anthony > On behalf of the QEMU Team, I'd like to announce the availability of QEMU > 1.0, > release candidate 2. This is the second release candidate for the 1.0 > release. > This is not intended for production use but rather for testing. The mail subject should be "QEMU 1.0-rc2" not

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-11-14 Thread Benjamin Herrenschmidt
On Tue, 2011-11-15 at 11:05 +1100, David Gibson wrote: > Being strict, or at least enforcing strictness, requires that the > infrastructure track all the maps, so that the unmaps can be > matching. This is not a natural thing with the data structures you > want for all IOMMUs. For example on POWE

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-11-14 Thread David Gibson
On Fri, Nov 11, 2011 at 03:10:56PM -0700, Alex Williamson wrote: > Thanks Konrad! Comments inline. > On Fri, 2011-11-11 at 12:51 -0500, Konrad Rzeszutek Wilk wrote: > > On Thu, Nov 03, 2011 at 02:12:24PM -0600, Alex Williamson wrote: [snip] > > > +The GET_NUM_REGIONS ioctl tells us how many region

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-11-14 Thread David Gibson
On Mon, Nov 14, 2011 at 03:59:00PM -0700, Alex Williamson wrote: > On Fri, 2011-11-11 at 16:22 -0600, Christian Benvenuti (benve) wrote: [snip] > > - the user either unmaps one specific mapping or 'all of them'. > > The 'all of them' case would also take care of those cases where > > the user

Re: [Qemu-devel] [PATCH 1.0 2/2] Fix some spelling bugs in documentation and comments

2011-11-14 Thread Peter Maydell
On 14 November 2011 19:54, Stefan Weil wrote: > The file still needs more patches even after your changes (e.g. replacable), > so I suggest that we proceed incrementally: first my patch, then your patch, > then whoever wants ... If you like. I might submit a patch post 1.0. -- PMM

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-11-14 Thread Alex Williamson
On Fri, 2011-11-11 at 16:22 -0600, Christian Benvenuti (benve) wrote: > > -Original Message- > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Friday, November 11, 2011 10:04 AM > > To: Christian Benvenuti (benve) > > Cc: chr...@sous-sol.org; a...@au1.ibm.com; p...@au1

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-11-14 Thread Alexander Graf
Am 14.11.2011 um 23:26 schrieb Scott Wood : > On 11/14/2011 02:54 PM, Alex Williamson wrote: >> On Fri, 2011-11-11 at 18:14 -0600, Scott Wood wrote: >>> What are the semantics of "desired and/or returned dma address"? >> >> I believe the original intention was that a user could leave dmaaddr >>

[Qemu-devel] [PATCH 4/5] docs: convert acpi_pci_hotplug to markdown

2011-11-14 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- docs/specs/acpi_pci_hotplug.md | 38 ++ docs/specs/acpi_pci_hotplug.txt | 37 - 2 files changed, 38 insertions(+), 37 deletions(-) create mode 100644 docs/specs/acpi_pci_hotplug.md de

[Qemu-devel] [PATCH 3/5] docs: convert ivshmem device spec to markdown

2011-11-14 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- docs/specs/ivshmem_device_spec.md | 97 docs/specs/ivshmem_device_spec.txt | 96 --- 2 files changed, 97 insertions(+), 96 deletions(-) create mode 100644 docs/specs/ivshmem_device_spec.m

[Qemu-devel] [PATCH 1/5] docs: convert qed_spec.txt to markdown

2011-11-14 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- docs/specs/qed_spec.md | 221 +++ docs/specs/qed_spec.txt | 138 - 2 files changed, 221 insertions(+), 138 deletions(-) create mode 100644 docs/specs/qed_spec.md delete mode 100644 docs

[Qemu-devel] [PATCH 5/5] docs: add readme to specifications directory

2011-11-14 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- docs/specs/README.md |8 1 files changed, 8 insertions(+), 0 deletions(-) create mode 100644 docs/specs/README.md diff --git a/docs/specs/README.md b/docs/specs/README.md new file mode 100644 index 000..29fec3f --- /dev/null +++ b/docs/specs/R

[Qemu-devel] [PATCH 0/5] docs: convert specifications to markdown

2011-11-14 Thread Anthony Liguori
Right now our specs are written in psuedo-wiki syntax. This series converts them to markdown. markdown is a simple markup format that's gaining in popularity. The big advantage of using markdown is that there are tools that can convert it to relatively simple HTML. That means we can build a mak

[Qemu-devel] [PATCH 2/5] docs: convert qcow2 specification to markdown

2011-11-14 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- docs/specs/qcow2.md | 263 ++ docs/specs/qcow2.txt | 260 - 2 files changed, 263 insertions(+), 260 deletions(-) create mode 100644 docs/specs/qcow2.md delete mo

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-11-14 Thread Scott Wood
On 11/14/2011 02:54 PM, Alex Williamson wrote: > On Fri, 2011-11-11 at 18:14 -0600, Scott Wood wrote: >> What are the semantics of "desired and/or returned dma address"? > > I believe the original intention was that a user could leave dmaaddr > clear and let the iommu layer provide an iova address

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-11-14 Thread Alex Williamson
On Mon, 2011-11-14 at 13:54 -0700, Alex Williamson wrote: > On Fri, 2011-11-11 at 18:14 -0600, Scott Wood wrote: > > On 11/03/2011 03:12 PM, Alex Williamson wrote: > > > + for (i = 0; i < npage; i++, iova += PAGE_SIZE, vaddr += PAGE_SIZE) { > > > + unsigned long pfn = 0; > > > + > > > +

Re: [Qemu-devel] [PATCH 2/5] ivshmem: use migration blockers to prevent live migration in peer mode (v2)

2011-11-14 Thread Anthony Liguori
On 11/14/2011 03:31 PM, Michael Roth wrote: On 11/14/2011 03:09 PM, Anthony Liguori wrote: Now when you try to migrate with ivshmem, you get a proper QMP error: (qemu) migrate tcp:localhost:1025 Migration is disabled when using feature 'peer mode' in device 'ivshmem' (qemu) Signed-off-by: Anth

Re: [Qemu-devel] [PATCH 2/5] ivshmem: use migration blockers to prevent live migration in peer mode (v2)

2011-11-14 Thread Michael Roth
On 11/14/2011 03:09 PM, Anthony Liguori wrote: Now when you try to migrate with ivshmem, you get a proper QMP error: (qemu) migrate tcp:localhost:1025 Migration is disabled when using feature 'peer mode' in device 'ivshmem' (qemu) Signed-off-by: Anthony Liguori --- v1 -> v2 - remove register

[Qemu-devel] [PATCH 0/5] migration: support migration with image files

2011-11-14 Thread Anthony Liguori
This series allows live migration to work with image formats. This series has two parts. The first part adds a new error infrastructure to migration which allows for different subsystems (other than qdev) to block migration when specific features are in use. The second part adds block interface

[Qemu-devel] [PATCH 4/5] qcow2: implement bdrv_invalidate_cache (v2)

2011-11-14 Thread Anthony Liguori
We don't reopen the actual file, but instead invoke the close and open routines. We specifically ignore the backing file since it's contents are read-only and therefore immutable. Signed-off-by: Anthony Liguori --- v1 -> v2 - make invalidate_cache work with encrypted block devices --- block/qco

[Qemu-devel] [PATCH 1/5] migrate: add migration blockers

2011-11-14 Thread Anthony Liguori
This lets different subsystems register an Error that is thrown whenever migration is attempted. This works nicely because it gracefully supports things like hotplug. Right now, if multiple errors are registered, only one of them is reported. I expect that for 1.1, we'll extend query-migrate to r

[Qemu-devel] [PATCH 2/5] ivshmem: use migration blockers to prevent live migration in peer mode (v2)

2011-11-14 Thread Anthony Liguori
Now when you try to migrate with ivshmem, you get a proper QMP error: (qemu) migrate tcp:localhost:1025 Migration is disabled when using feature 'peer mode' in device 'ivshmem' (qemu) Signed-off-by: Anthony Liguori --- v1 -> v2 - remove register_device_unmigratable as ivshmem was the only user

[Qemu-devel] [PATCH 5/5] qed: add migration blocker (v2)

2011-11-14 Thread Anthony Liguori
Now when you try to migrate with qed, you get: (qemu) migrate tcp:localhost:1025 Block format 'qed' used by device 'ide0-hd0' does not support feature 'live migration' (qemu) Signed-off-by: Anthony Liguori --- v1 -> v2 - Pull in QERR_BLOCK_FORMAT_FEATURE_NOT_SUPPORTED. I hope Stefan reviews t

[Qemu-devel] [PATCH 3/5] block: allow migration to work with image files (v3)

2011-11-14 Thread Anthony Liguori
Image files have two types of data: immutable data that describes things like image size, backing files, etc. and mutable data that includes offset and reference count tables. Today, image formats aggressively cache mutable data to improve performance. In some cases, this happens before a guest e

Re: [Qemu-devel] [PATCH] migration: add a MAINTAINERS entry for migration

2011-11-14 Thread Anthony Liguori
On 11/14/2011 11:40 AM, Juan Quintela wrote: Anthony Liguori wrote: I think this is an accurate reflection of the state of migration today. This is the second release in a row where we're scrambling to fix a critical issue in migration. We need to make our mind about it. Ultimately, we nee

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-11-14 Thread Alex Williamson
On Fri, 2011-11-11 at 18:14 -0600, Scott Wood wrote: > On 11/03/2011 03:12 PM, Alex Williamson wrote: > > +Many modern system now provide DMA and interrupt remapping facilities > > +to help ensure I/O devices behave within the boundaries they've been > > +allotted. This includes x86 hardware with

Re: [Qemu-devel] [PATCH 5/7] block: allow migration to work with image files (v2)

2011-11-14 Thread Anthony Liguori
On 11/14/2011 02:36 PM, Kevin Wolf wrote: Am 14.11.2011 21:12, schrieb Anthony Liguori: I don't think it makes even sense logically: bdrv_invalidate_cache() means "throw all your caches away and refetch everything from disk". What do we gain from doing this on stop? To some degree I could unders

Re: [Qemu-devel] [PATCH 5/7] block: allow migration to work with image files (v2)

2011-11-14 Thread Kevin Wolf
Am 14.11.2011 21:12, schrieb Anthony Liguori: > On 11/14/2011 02:11 PM, Kevin Wolf wrote: >> Am 14.11.2011 20:49, schrieb Anthony Liguori: >>> On 11/14/2011 01:46 PM, Juan Quintela wrote: Anthony Liguori wrote: > On 11/14/2011 07:11 AM, Juan Quintela wrote: >> >>> diff --git a/cp

Re: [Qemu-devel] [PATCH 5/7] block: allow migration to work with image files (v2)

2011-11-14 Thread Juan Quintela
Anthony Liguori wrote: > > Michael basically was trying to avoid having a VM's state change after > you stopped the guest. > > With something like cache=unsafe that periodically flushes based on a > timer (I think), you want to make sure that that doesn't happen after > stop occurs. Even then, w

[Qemu-devel] Summary of Anthony's 'next' queue

2011-11-14 Thread Anthony Liguori
Hi, This is a summary of the patches that I have queued in my next tree that were identified as 1.1 candidates. These patches will not be applied until after the 1.1 tree opens (December 1st). These patches have not been tested yet and may receive additional review comments. This note is m

Re: [Qemu-devel] [PATCH 5/7] block: allow migration to work with image files (v2)

2011-11-14 Thread Juan Quintela
Kevin Wolf wrote: > Am 14.11.2011 20:49, schrieb Anthony Liguori: >> On 11/14/2011 01:46 PM, Juan Quintela wrote: >>> Anthony Liguori wrote: On 11/14/2011 07:11 AM, Juan Quintela wrote: > >> diff --git a/cpus.c b/cpus.c >> index 82530c4..ae5ec99 100644 >> --- a/cpus.c >>

Re: [Qemu-devel] [PATCH 5/7] block: allow migration to work with image files (v2)

2011-11-14 Thread Anthony Liguori
On 11/14/2011 02:11 PM, Kevin Wolf wrote: Am 14.11.2011 20:49, schrieb Anthony Liguori: On 11/14/2011 01:46 PM, Juan Quintela wrote: Anthony Liguori wrote: On 11/14/2011 07:11 AM, Juan Quintela wrote: diff --git a/cpus.c b/cpus.c index 82530c4..ae5ec99 100644 --- a/cpus.c +++ b/cpus.c @@

Re: [Qemu-devel] [PATCH v2] rtl8139: Fix invalid IO access alignment

2011-11-14 Thread Julian Pidancet
On Mon, Nov 14, 2011 at 8:35 PM, Julian Pidancet wrote: > This patch makes iPXE work with the rtl8139 emulation. The rtl8139 > driver in iPXE issues a 16bit access on the ChipCmd register > (offset 0x37) to check the status of the rx buffer. The offset of the > ioport access was getting fixed up t

[Qemu-devel] [ANNOUNCE] QEMU 1.0-rc1

2011-11-14 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of QEMU 1.0, release candidate 2. This is the second release candidate for the 1.0 release. This is not intended for production use but rather for testing. To participate in the testing effort, please read the Testing Wiki

Re: [Qemu-devel] [PATCH 5/7] block: allow migration to work with image files (v2)

2011-11-14 Thread Kevin Wolf
Am 14.11.2011 20:49, schrieb Anthony Liguori: > On 11/14/2011 01:46 PM, Juan Quintela wrote: >> Anthony Liguori wrote: >>> On 11/14/2011 07:11 AM, Juan Quintela wrote: > diff --git a/cpus.c b/cpus.c > index 82530c4..ae5ec99 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -398,6

Re: [Qemu-devel] [PATCH 2/7] ivshmem: use migration blockers to prevent live migration in peer mode

2011-11-14 Thread Anthony Liguori
On 11/14/2011 01:52 PM, Juan Quintela wrote: Anthony Liguori wrote: On 11/14/2011 07:05 AM, Juan Quintela wrote: Anthony Liguori wrote: Now when you try to migrate with ivshmem, you get a proper QMP error: (qemu) migrate tcp:localhost:1025 Migration is disabled when using feature 'peer mod

Re: [Qemu-devel] [PATCH 1.0 2/2] Fix some spelling bugs in documentation and comments

2011-11-14 Thread Stefan Weil
Am 14.11.2011 20:25, schrieb Peter Maydell: On 14 November 2011 19:18, Stefan Weil wrote: --- a/docs/libcacard.txt +++ b/docs/libcacard.txt @@ -281,7 +281,7 @@ create card responses. VCardResponse *vcard_make_response(VCard7816Status status); This is the most basic function to get

Re: [Qemu-devel] [PATCH 2/7] ivshmem: use migration blockers to prevent live migration in peer mode

2011-11-14 Thread Juan Quintela
Anthony Liguori wrote: > On 11/14/2011 07:05 AM, Juan Quintela wrote: >> Anthony Liguori wrote: >>> Now when you try to migrate with ivshmem, you get a proper QMP error: >>> >>> (qemu) migrate tcp:localhost:1025 >>> Migration is disabled when using feature 'peer mode' in device 'ivshmem' >>> (qem

Re: [Qemu-devel] [PATCH 5/7] block: allow migration to work with image files (v2)

2011-11-14 Thread Anthony Liguori
On 11/14/2011 01:46 PM, Juan Quintela wrote: Anthony Liguori wrote: On 11/14/2011 07:11 AM, Juan Quintela wrote: diff --git a/cpus.c b/cpus.c index 82530c4..ae5ec99 100644 --- a/cpus.c +++ b/cpus.c @@ -398,6 +398,7 @@ static void do_vm_stop(RunState state) vm_state_notify(0, state

Re: [Qemu-devel] [PATCH 5/7] block: allow migration to work with image files (v2)

2011-11-14 Thread Juan Quintela
Anthony Liguori wrote: > On 11/14/2011 07:11 AM, Juan Quintela wrote: >> >>> diff --git a/cpus.c b/cpus.c >>> index 82530c4..ae5ec99 100644 >>> --- a/cpus.c >>> +++ b/cpus.c >>> @@ -398,6 +398,7 @@ static void do_vm_stop(RunState state) >>> vm_state_notify(0, state); >>> qemu_a

[Qemu-devel] [PATCH v2] rtl8139: Fix invalid IO access alignment

2011-11-14 Thread Julian Pidancet
This patch makes iPXE work with the rtl8139 emulation. The rtl8139 driver in iPXE issues a 16bit access on the ChipCmd register (offset 0x37) to check the status of the rx buffer. The offset of the ioport access was getting fixed up to 0x36 in qemu, causing the value read in iPXE to be invalid. Th

Re: [Qemu-devel] [PATCH 1.0 2/2] Fix some spelling bugs in documentation and comments

2011-11-14 Thread Peter Maydell
On 14 November 2011 19:18, Stefan Weil wrote: > --- a/docs/libcacard.txt > +++ b/docs/libcacard.txt > @@ -281,7 +281,7 @@ create card responses. >         VCardResponse *vcard_make_response(VCard7816Status status); > >     This is the most basic function to get a response. This function will > -  

[Qemu-devel] [PATCH 1.0 1/2] Fix spelling in documentation and comments (similiar -> similar)

2011-11-14 Thread Stefan Weil
This bug was detected by codespell. In mips_mipssim.c a grammatical error was fixed, too. Signed-off-by: Stefan Weil --- docs/libcacard.txt |2 +- hw/mips_mipssim.c |2 +- qemu-doc.texi |4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/libcacard.txt b

[Qemu-devel] [PATCH 1.0 2/2] Fix some spelling bugs in documentation and comments

2011-11-14 Thread Stefan Weil
These errors were detected by codespell: remaing -> remaining soley -> solely virutal -> virtual seperate -> separate libcacard.txt still needs some more patches. Signed-off-by: Stefan Weil --- block-migration.c |2 +- docs/libcacard.txt |6 +++--- docs/qapi-code-gen.txt |

[Qemu-devel] [PATCH 1.0 2/2] Fix some spelling bugs in documentation and comments

2011-11-14 Thread Stefan Weil
My previous mail used a wrong address for qemu-devel, sorry. Regards, Stefan Weil Original-Nachricht Betreff: [PATCH 1.0 2/2] Fix some spelling bugs in documentation and comments Datum: Sun, 13 Nov 2011 22:24:27 +0100 Von:Stefan Weil An: qemu-de...@non-gnu.org CC:

[Qemu-devel] Fwd: [PATCH 1.0] eepro100: Fix alignment requirement for statistical counters

2011-11-14 Thread Stefan Weil
Sorry, I just noticed that I sent this patch to the wrong list address. It's a patch for QEMU 1.0, so I hope it's not too late for 1.0-rc2. Regards, Stefan Weil Original-Nachricht Betreff: [PATCH] eepro100: Fix alignment requirement for statistical counters Datum: Sat, 5

Re: [Qemu-devel] [PATCH 1.0] configure: build position independent executables across the board, by default

2011-11-14 Thread Peter Maydell
On 14 November 2011 15:18, Avi Kivity wrote: > On 11/14/2011 05:15 PM, Peter Maydell wrote: >> One of the failure cases I was thinking of is that if PIE means >> the platform's loader puts things in a different bit of the >> address space this might break TCG's assumptions about maximum >> distanc

Re: [Qemu-devel] [PATCH 1/7] migrate: add migration blockers

2011-11-14 Thread Anthony Liguori
On 11/14/2011 03:08 AM, Kevin Wolf wrote: Am 12.11.2011 16:56, schrieb Anthony Liguori: This lets different subsystems register an Error that is thrown whenever migration is attempted. This works nicely because it gracefully supports things like hotplug. Right now, if multiple errors are regis

Re: [Qemu-devel] [Xen-devel] [PATCH V3 07/10] Introduce Xen PCI Passthrough, qdevice (1/3)

2011-11-14 Thread Konrad Rzeszutek Wilk
On Mon, Nov 14, 2011 at 11:09:31AM +, Stefano Stabellini wrote: > On Fri, 11 Nov 2011, Konrad Rzeszutek Wilk wrote: > > > > > +hw_error("Internal error: Invalid write emulation " > > > > > + "return value[%d]. I/O emulator exit.\n", > > > > > rc); > > >

Re: [Qemu-devel] [PATCH 1.0?] qapi: Check for negative enum values

2011-11-14 Thread Michael Roth
On 11/14/2011 11:29 AM, Luiz Capitulino wrote: We don't currently check for negative enum values in qmp_output_type_enum(), this will very likely generate a segfault when triggered. However, it _seems_ that no code in tree can trigger this today. Signed-off-by: Luiz Capitulino --- I think it's

Re: [Qemu-devel] [PATCH 3/7] qcow2: add a migration blocker

2011-11-14 Thread Lucas Meneghel Rodrigues
On 11/12/2011 01:57 PM, Anthony Liguori wrote: Now when you try to migrate with qcow2, you get: (qemu) migrate tcp:localhost:1025 Block format 'qcow2' used by device 'ide0-hd0' does not support feature 'live migration' (qemu) LGTM. From a testing perspective, it's clear and understandable, a

[Qemu-devel] [PATCH 08/12] s390: Fix cpu shutdown for KVM

2011-11-14 Thread Alexander Graf
From: Christian Borntraeger On s390 a shutdown is the state of all CPUs being either stopped or disabled (for interrupts) waiting. We have to track the overall number of running CPUs to call the shutdown sequence accordingly. This patch implements the counting and shutdown handling for the kvm pa

[Qemu-devel] [PATCH v2] qcow2: Unlock during COW

2011-11-14 Thread Kevin Wolf
Unlocking during COW allows for more parallelism. One change it requires is that buffers are dynamically allocated instead of just using a per-image buffer. While touching the code, drop the synchronous qcow2_read() function and replace it by a bdrv_read() call. Signed-off-by: Kevin Wolf --- bl

Re: [Qemu-devel] [RFC 1.0] pc_piix: set qxl revision to 2 for pc-0.14

2011-11-14 Thread Avi Kivity
On 11/14/2011 07:48 PM, Anthony Liguori wrote: > On 11/14/2011 11:45 AM, Avi Kivity wrote: >> On 11/14/2011 06:07 PM, Anthony Liguori wrote: Antony, can you apply this directly or do you wanna have a single-patch-pull-request instead? >>> >>> >>> Yes, I'll apply directly. >> >> Does stabl

Re: [Qemu-devel] [RFC 1.0] pc_piix: set qxl revision to 2 for pc-0.14

2011-11-14 Thread Anthony Liguori
On 11/14/2011 11:45 AM, Avi Kivity wrote: On 11/14/2011 06:07 PM, Anthony Liguori wrote: Antony, can you apply this directly or do you wanna have a single-patch-pull-request instead? Yes, I'll apply directly. Does stable-0.15 need it too? You mean to set the revision to 2 for 0.14, right?

Re: [Qemu-devel] KVM call agenda for November 15th

2011-11-14 Thread Anthony Liguori
On 11/14/2011 11:44 AM, Juan Quintela wrote: Hi Please send in any agenda items you are interested in covering. Proposal: - Migration debacle. Ack. You read my mind :-) Regards, Anthony Liguori Thanks, Juan.

Re: [Qemu-devel] [RFC 1.0] pc_piix: set qxl revision to 2 for pc-0.14

2011-11-14 Thread Avi Kivity
On 11/14/2011 06:07 PM, Anthony Liguori wrote: >> Antony, can you apply this directly or do you wanna have a >> single-patch-pull-request instead? > > > Yes, I'll apply directly. Does stable-0.15 need it too? -- error compiling committee.c: too many arguments to function

[Qemu-devel] KVM call agenda for November 15th

2011-11-14 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Proposal: - Migration debacle. Thanks, Juan.

Re: [Qemu-devel] [PATCH] migration: add a MAINTAINERS entry for migration

2011-11-14 Thread Juan Quintela
Anthony Liguori wrote: > I think this is an accurate reflection of the state of migration today. This > is the second release in a row where we're scrambling to fix a critical issue > in migration. We need to make our mind about it. A patch to do the reopen was posted long, long ago. Code exis

Re: [Qemu-devel] [TestDays] s390x emulation error

2011-11-14 Thread Paolo Bonzini
On 11/14/2011 06:36 PM, Alexander Graf wrote: Hrm. Paolo, any idea? Sorry for asking the obvious, but can it be bisected? Paolo

Re: [Qemu-devel] [TestDays] s390x emulation error

2011-11-14 Thread Alexander Graf
On 11/14/2011 06:29 PM, Andreas Färber wrote: Am 10.11.2011 13:36, schrieb Alexander Graf: On 10.11.2011, at 12:29, Andreas Färber wrote: Am 10.11.2011 11:32, schrieb Alexander Graf: On 10.11.2011, at 10:53, Andreas Färber wrote: Is there a known issue with running multiple instances of q

[Qemu-devel] [PATCH 12/12] s390x: initialize virtio dev region

2011-11-14 Thread Alexander Graf
When running the s390x virtio machine we can potentially use uninitialized memory for the virtio device backing ram. That can lead to weird breakge. So let's better initialize it to 0 properly. Reported-by: Andreas Färber Signed-off-by: Alexander Graf --- v1 -> v2: - use target_phys_addr_t

[Qemu-devel] [PATCH 01/12] s390x: add ldeb instruction

2011-11-14 Thread Alexander Graf
While running perl, we encountered the ldeb instruction to be used, so we implement it :). Signed-off-by: Alexander Graf --- target-s390x/helpers.h |1 + target-s390x/op_helper.c |9 + target-s390x/translate.c |4 3 files changed, 14 insertions(+), 0 deletions(-) diff

Re: [Qemu-devel] [TestDays] s390x emulation error

2011-11-14 Thread Andreas Färber
Am 10.11.2011 13:36, schrieb Alexander Graf: > > On 10.11.2011, at 12:29, Andreas Färber wrote: > >> Am 10.11.2011 11:32, schrieb Alexander Graf: >>> >>> On 10.11.2011, at 10:53, Andreas Färber wrote: >>> Is there a known issue with running multiple instances of qemu-system-s390x? I g

[Qemu-devel] [PATCH 1.0?] qapi: Check for negative enum values

2011-11-14 Thread Luiz Capitulino
We don't currently check for negative enum values in qmp_output_type_enum(), this will very likely generate a segfault when triggered. However, it _seems_ that no code in tree can trigger this today. Signed-off-by: Luiz Capitulino --- I think it's a good idea to merge this one for 1.0, but I'd

[Qemu-devel] [PATCH 03/12] s390x: update R and C bits in storage key

2011-11-14 Thread Alexander Graf
When the s390x maps a page or writes happen to a page, the R and C bits get updated. The easiest way to implement this in qemu is to simply update them whenever we map a TLB translation and act according to the permissions. Signed-off-by: Alexander Graf --- target-s390x/cpu.h |4

[Qemu-devel] [PATCH 02/12] s390x: make ipte 31-bit aware

2011-11-14 Thread Alexander Graf
When running 31-bit code we can potentially map the same virtual address twice - once as 0x0yyy and once as 0x8yyy, because the upper bit gets ignored. This also should be reflected in the tlb invalidation path, so we really invalidate also the transparently created tlb entries. Signed-of

[Qemu-devel] [PATCH 04/12] s390x: implement rrbe instruction properly

2011-11-14 Thread Alexander Graf
The rrbe instruction resets the reference bit in the given storage key. So far, we merely made it a nop and also returned an invalid CC value, so that the kernel never knew if a page actually got accessed. This patch implements it properly, flushing the R bit and returning the correct CC value. S

Re: [Qemu-devel] [PATCH] hw/usb-net.c: Fix precedence bug when checking rndis_state

2011-11-14 Thread andrzej zaborowski
On 14 November 2011 09:08, Peter Maydell wrote: > I'm happy that non-rndis works, I tested that. What I don't know > is whether the patch breaks rndis Sorry, I misread what you said assuming that you tested a branch affected by this patch. I'm unable to find a guest to test the rndis mode so I r

[Qemu-devel] [PATCH 06/12] s390: fix reset hypercall to reset the status

2011-11-14 Thread Alexander Graf
From: Christian Borntraeger This patch fixes the reset hypercall which is supposed to also reset the device status in device memory. This fixes the following bug: [root@localhost driver]# echo virtio0 > unbind [ 35.056966] [ cut here ] [ 35.057054] kernel BUG at drive

[Qemu-devel] [PATCH 11/12] tcg: Use TCGReg for standard tcg-target entry points.

2011-11-14 Thread Alexander Graf
From: Richard Henderson Including tcg_out_ld, tcg_out_st, tcg_out_mov, tcg_out_movi. Signed-off-by: Richard Henderson Reviewed-by: Andreas Färber Reviewed-by: Stefan Weil Signed-off-by: Alexander Graf --- tcg/arm/tcg-target.c | 13 +++-- tcg/hppa/tcg-target.c | 12 ++-

[Qemu-devel] [PATCH 10/12] tcg: Standardize on TCGReg as the enum for hard registers

2011-11-14 Thread Alexander Graf
From: Richard Henderson Most targets did not name the enum; tci used TCGRegister. Signed-off-by: Richard Henderson Reviewed-by: Andreas Färber Reviewed-by: Stefan Weil Signed-off-by: Alexander Graf --- tcg/arm/tcg-target.h |4 ++-- tcg/hppa/tcg-target.h |4 ++-- tcg/i386/tcg-targ

[Qemu-devel] [PATCH 05/12] s390x: implement SIGP restart and shutdown

2011-11-14 Thread Alexander Graf
An s390x OS does reboot and shutdown triggers through hypercalls that we didn't implement on the TCG backend yet. That means that so far we couldn't shut down virtual machines for example, having them hang on shutdown when not using KVM. With this patch, this restriction is gone. We can now shut d

[Qemu-devel] [PATCH 09/12] s390x: Add shutdown for TCG s390-virtio machine

2011-11-14 Thread Alexander Graf
Now that we have code in place to do refcounting of online CPUs, we can drag the TCG code along and implement shutdown for that one too, so it doesn't feel left out by its KVM counterpart. Signed-off-by: Alexander Graf --- target-s390x/cpu.h|9 + target-s390x/helper.c | 15

[Qemu-devel] [PULL 00/12] s390 patch queue 2011-11-14 1.0

2011-11-14 Thread Alexander Graf
Hi Blue, This is my current patch queue for s390 on 1.0. This time without hotplug support. Please pull. Alex The following changes since commit a3efecb847dd89886f7cd3f71661b2d79ec68072: Juha Riihimäki (1): hw/onenand: reject read-only drives are available in the git repository at:

[Qemu-devel] [PATCH 07/12] s390: fix short kernel command lines

2011-11-14 Thread Alexander Graf
From: Christian Borntraeger The default kernel command line for s390 is "root=/dev/ram0 ro" When overriding this line, we have to ensure to also copy the \0 to avoid false lines, for example, -append "root=/dev/vda" will result in "root=/dev/vda0 ro" with the current code. Signed-off-by: Christ

Re: [Qemu-devel] [PATCH] configure: build position independent executables across the board, by default

2011-11-14 Thread Paolo Bonzini
On 11/14/2011 04:30 PM, Avi Kivity wrote: +if test "$pie" = "yes" ; then + cat> $TMPC<< EOF +int main(void) { return 0; } +EOF + if compile_prog "-fPIE -dPIE" "-Wl,-pie"; then Uppercase d. +QEMU_CFLAGS="-fPIE -DPIE $QEMU_CFLAGS" +LDFLAGS="-Wl,-pie $LDFLAGS" +if compile_prog "-

Re: [Qemu-devel] [PATCH 3/4] qcow2: add a migration blocker

2011-11-14 Thread Stefan Hajnoczi
On Mon, Nov 14, 2011 at 4:49 PM, Anthony Liguori wrote: > On 11/14/2011 10:45 AM, Stefan Hajnoczi wrote: >> >> On Mon, Nov 14, 2011 at 4:25 PM, Anthony Liguori >>  wrote: >>> >>> On 11/14/2011 09:51 AM, Stefan Hajnoczi wrote: On Fri, Nov 11, 2011 at 8:29 PM, Anthony Liguori  wrote:

[Qemu-devel] [PATCH 1.1 5/6] block: dma_bdrv_* does not return NULL

2011-11-14 Thread Paolo Bonzini
Initially attempted with the following semantic patch: @ rule1 @ expression E; statement S; @@ E = ( dma_bdrv_io | dma_bdrv_read | dma_bdrv_write ) (...); ( - if (E == NULL) { ... } | - if (E) { <... S ...> } ) which however did not match anything. Signed-off-by: Paolo Bonzini -

[Qemu-devel] [PATCH 1.1 4/6] dma: the passed io_func does not return NULL

2011-11-14 Thread Paolo Bonzini
Initially found with the following semantic patch: @ type @ BlockDriverAIOCB *x; expression E; @@ x = E; - if (x == NULL) { ... } @ acb1 @ expression E, E1; @@ E1->acb = E; - if (E1->acb == NULL) { ... } @ aiocb1 @ expression E, E1; @@ E1->aiocb = E; - if (E1->aiocb == NULL) { ... } @ acb

[Qemu-devel] [PATCH 1.1 3/6] block: qemu_aio_get does not return NULL

2011-11-14 Thread Paolo Bonzini
Initially done with the following semantic patch: @ rule1 @ expression E; statement S; @@ E = qemu_aio_get (...); ( - if (E == NULL) { ... } | - if (E) { <... S ...> } ) which however missed occurrences in linux-aio.c and posix-aio-compat.c. Those were done by hand. The change in vdi_aio_s

[Qemu-devel] [PATCH 1.1 6/6] block: avoid useless checks on acb->bh

2011-11-14 Thread Paolo Bonzini
Coverity is confused by this "if" and reports leaks on acb->bh. The bottom half is always deleted before releasing the AIOCB, in either bdrv_aio_cancel_em or bdrv_aio_bh_cb. Signed-off-by: Paolo Bonzini --- block.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/block

[Qemu-devel] [PATCH 1.1 2/6] block: simplify failure handling for bdrv_aio_multiwrite

2011-11-14 Thread Paolo Bonzini
Now that early failure of bdrv_aio_writev is not possible anymore, mcb->num_requests can be set before the loop starts. Signed-off-by: Paolo Bonzini --- block.c | 28 ++-- 1 files changed, 2 insertions(+), 26 deletions(-) diff --git a/block.c b/block.c index 2b72d2c..0

[Qemu-devel] [PATCH 1.1 1/6] block: bdrv_aio_* do not return NULL

2011-11-14 Thread Paolo Bonzini
Initially done with the following semantic patch: @ rule1 @ expression E; statement S; @@ E = ( bdrv_aio_readv | bdrv_aio_writev | bdrv_aio_flush | bdrv_aio_discard | bdrv_aio_ioctl ) (...); ( - if (E == NULL) { ... } | - if (E) { <... S ...> } ) which however missed the occurre

[Qemu-devel] [PATCH 1.1 0/6] block: drop useless checks for NULL

2011-11-14 Thread Paolo Bonzini
After the coroutinization of the block layer, immediate failures of an AIO operation will still return an AIOCB and only report failure with a bottom half. This lets us remove a lot of dead NULL checks (patches 1-5). Patch 6 is on a similar theme, but a bit different. Most "added" lines are actu

Re: [Qemu-devel] [PATCH 3/4] qcow2: add a migration blocker

2011-11-14 Thread Anthony Liguori
On 11/14/2011 10:45 AM, Stefan Hajnoczi wrote: On Mon, Nov 14, 2011 at 4:25 PM, Anthony Liguori wrote: On 11/14/2011 09:51 AM, Stefan Hajnoczi wrote: On Fri, Nov 11, 2011 at 8:29 PM, Anthony Liguori wrote: +#define QERR_BLOCK_FORMAT_FEATURE_NOT_SUPPORTED \ +"{ 'class': 'BlockFormatFea

Re: [Qemu-devel] [PATCH 3/4] qcow2: add a migration blocker

2011-11-14 Thread Stefan Hajnoczi
On Mon, Nov 14, 2011 at 4:25 PM, Anthony Liguori wrote: > On 11/14/2011 09:51 AM, Stefan Hajnoczi wrote: >> >> On Fri, Nov 11, 2011 at 8:29 PM, Anthony Liguori >>  wrote: >>> >>> +#define QERR_BLOCK_FORMAT_FEATURE_NOT_SUPPORTED \ >>> +    "{ 'class': 'BlockFormatFeatureNotSupported', 'data': { 'fo

Re: [Qemu-devel] [PATCH 3/4] qcow2: add a migration blocker

2011-11-14 Thread Kevin Wolf
Am 14.11.2011 17:25, schrieb Anthony Liguori: > On 11/14/2011 09:51 AM, Stefan Hajnoczi wrote: >> On Fri, Nov 11, 2011 at 8:29 PM, Anthony Liguori wrote: >>> +#define QERR_BLOCK_FORMAT_FEATURE_NOT_SUPPORTED \ >>> +"{ 'class': 'BlockFormatFeatureNotSupported', 'data': { 'format': %s, >>> 'name

Re: [Qemu-devel] [PATCH 3/4] qcow2: add a migration blocker

2011-11-14 Thread Anthony Liguori
On 11/14/2011 09:51 AM, Stefan Hajnoczi wrote: On Fri, Nov 11, 2011 at 8:29 PM, Anthony Liguori wrote: +#define QERR_BLOCK_FORMAT_FEATURE_NOT_SUPPORTED \ +"{ 'class': 'BlockFormatFeatureNotSupported', 'data': { 'format': %s, 'name': %s, 'feature': %s } }" + Isn't having a separate error

Re: [Qemu-devel] [RFC 1.0] pc_piix: set qxl revision to 2 for pc-0.14

2011-11-14 Thread Anthony Liguori
On 11/14/2011 09:55 AM, Gerd Hoffmann wrote: On 11/14/11 12:44, Alon Levy wrote: On Mon, Nov 14, 2011 at 11:40:57AM +0100, Gerd Hoffmann wrote: On 11/13/11 14:27, Alon Levy wrote: The default is still 3, and I didn't change older machine types. Looks good to me. ok, so do you want another

  1   2   >