The Buildbot has detected a new failure on builder ppc-next_i386_debian_6_0
while building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/ppc-next_i386_debian_6_0/builds/68
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: yuzuki
Bui
This make let virtio-net driver can send gratituous packet by a new
config bit - VIRTIO_NET_S_ANNOUNCE in each config update
interrupt. When this bit is set by backend, the driver would schedule
a workqueue to send gratituous packet through NETDEV_NOTIFY_PEERS.
This feature is negotiated through b
This patch introduce a function pointer in NetClientInfo which is
called during self announcement to do the model specific announcement
such as sending gratuitous packet. Previous method is kept when model
specific announcing fails or without it.
The first user would be virtio-net.
Signed-off-by:
It's hard to track all mac address and its usage (vlan, bondings,
ipv6) in qemu to send gratituous packet in qemu side, so the better
choice is let guest do it.
The patch introduces a new rw config status bit of virtio-net,
VIRTIO_NET_S_ANNOUNCE which is used to notify guest to announce itself
( s
Export and move announce_self_create() to net.c in order to be used by model
specific announcing function.
Signed-off-by: Jason Wang
---
net.c| 31 +++
net.h|1 +
savevm.c | 32
3 files changed, 32 insertions(+), 32 del
We send gratituous packets to let switch to update its mac address
table, this is only done after migration currently because guest may
move to the host with another port connect to switch.
Unfortunately this kind of notification is also needed for continue a
stopped vm as the mac address table en
We only track primary mac address in qemu and send rarp packets after
migration to notify the switch to update its mac address table. This
may not works when guest have complicated network configurations such
as tagged vlan or ipv6, those connection may lost or stall after
migration.
One method to
The Buildbot has detected a new failure on builder ppc-next_x86_64_debian_6_0
while building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/ppc-next_x86_64_debian_6_0/builds/68
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: yuzuki
于 2011/10/22 13:13, xunxun 写道:
Hi, all
It seems that gcc's auto-omit-frame-pointer has other problems.
The example is from mingw bug tracker:
http://sourceforge.net/tracker/?func=detail&aid=3426555&group_id=2435&atid=102435
g++ -O3 main.cpp running will crash.
g++ -O2 m
Hi, all
It seems that gcc's auto-omit-frame-pointer has other problems.
The example is from mingw bug tracker:
http://sourceforge.net/tracker/?func=detail&aid=3426555&group_id=2435&atid=102435
g++ -O3 main.cpp running will crash.
g++ -O2 main.cpp running no crash.
On 10/19/2011 09:28 AM, Michael S. Tsirkin wrote:
> On Mon, Oct 17, 2011 at 10:55:57AM +0800, Jason Wang wrote:
>> Reduce spurious packet drops on RX ring empty when in c+ mode by verifying
>> that
>> we have at least 1 buffer ahead of the time.
>>
>> Change from v1:
>> Fix style comments from Ste
On 10/18/2011 06:09 PM, Mark Wu wrote:
> Hi Jason,
> Could you please elaborate what problem you try to resolve by this
> patch? And do you think we need notify I/O thread re-polling tap fd
> when receive descriptor becomes available? Otherwise, tap read polling
> will be disabled until the I/O ha
using the following command line to restore guest, it works for me now.
qemu-system-x86_64 -m 256 -net nic,macaddr=00:16:3e:06:8a:08,model=rtl8139 -net
tap,script=/etc/kvm/qemu-ifup -hda /root/test0320.img
-incoming=/roo/test-save.img
** Changed in: qemu
Status: New => Fix Released
--
Y
Am 21.10.2011 08:58, schrieb Peter Maydell:
> On 20 October 2011 23:51, Andreas Färber wrote:
>> Renesas announced
>> the R-Car H1 this week, a SoC with one SH4A core and four ARM Cortex-A9
>> cores.
>
> Does it expose the SH4 to apps/OSes, or is it mostly used for
> power management or similar i
@Peter - thanks, fair enough... I don't know enough about qemu's source
to understand what you mean, but clearly it's a complex issue. For now
the patch seems to work for me-- I haven't had the issue that @Ricardo
discusses (again, I'm on armv7l, though).
--
You received this bug notification bec
Am 21.10.2011 09:26, schrieb 陳韋任:
> COREMU treats QEMU as an entity and lauches multiple QEMUs at the same
> time. QEMUs communicates to each other by using a underlying thin layer
> provided by COREMU.
> I think this approach is much clean than trying to
> parallelize QEMU itself.
In this case
Dear Customer,
You Have One New Message
You have a new message in online banking.
Subject: Cheque on hold.
Resolve the problem.
We telephoned you today in relation to your Cheque payment, unfortunately we
were unable to contact you on the telephone numbers registered for your account
to ver
On 10/21/2011 07:08 PM, Kevin Wolf wrote:
Avi complained that not even writing out qcow2's cache on bdrv_flush() made
cache=unsafe too unsafe to be useful. He's got a point.
Why? cache=unsafe is explicitly allowing to s/data/manure/ on crash.
If you do this for raw-posix, you need to do it for
The next patch will introduce an early return. Using a bottom half to invoke
the AIO callback wouldn't be much less code, so let's go with the native
block layer interface.
Signed-off-by: Kevin Wolf
---
block/raw-posix.c | 53 -
1 files chang
From: Paolo Bonzini
Move vmdk_parent_open to vmdk_open. There's another path how
vmdk_parent_open can be reached:
vmdk_parse_extents() -> vmdk_open_sparse() -> vmdk_open_vmdk4() ->
vmdk_open_desc_file().
If that can happen, however, the code is bogus. vmdk_parent_open
reads from bs->fil
Provide a clean example of how to use the main loop in the tools.
Signed-off-by: Paolo Bonzini
---
cpus.c |5
cpus.h |1 -
vl.c | 79 +--
3 files changed, 41 insertions(+), 44 deletions(-)
diff --git a/cpus.c b/cpus.c
The expected meaning of cache=unsafe with qcow2 is that on a flush the metadata
caches are written out, but no fsync is performed.
Signed-off-by: Kevin Wolf
---
block.c |4 +---
block/raw-posix.c |4
block/raw-win32.c |4
3 files changed, 9 insertions(+), 3 deleti
Avi complained that not even writing out qcow2's cache on bdrv_flush() made
cache=unsafe too unsafe to be useful. He's got a point.
Kevin Wolf (2):
raw-posix: Convert to bdrv_co_flush
block: Handle cache=unsafe only in raw-posix/win32
block.c |4 +--
block/raw-posix.c | 57 ++
From: Paolo Bonzini
Since coroutine operation is now mandatory, convert all bdrv_flush
implementations to coroutines. For qcow2, this means taking the lock.
Other implementations are simpler and just forward bdrv_flush to the
underlying protocol, so they can avoid the lock.
The bdrv_flush callb
From: Paolo Bonzini
This makes the following patch easier to review.
Cc: MORITA Kazutaka
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
block/sheepdog.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index
From: Paolo Bonzini
The big conversion of bdrv_read/write to coroutines caused the two
homonymous callbacks in BlockDriver to become reentrant. It goes
like this:
1) bdrv_read is now called in a coroutine, and calls bdrv_read or
bdrv_pread.
2) the nested bdrv_read goes through the fast path in
The following changes since commit c2e2343e1faae7bbc77574c12a25881b1b696808:
hw/arm_gic.c: Fix save/load of irq_target array (2011-10-21 17:19:56 +0200)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git for-anthony
Alex Jia (1):
fix memory leak in aio_write_f
Kev
Signed-off-by: Paolo Bonzini
---
cpus.c |1 +
qemu-timer.c |5 +
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/cpus.c b/cpus.c
index 21538e6..1328baa 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1059,6 +1059,7 @@ void pause_all_vcpus(void)
{
CPUState *penv = first
From: Paolo Bonzini
This does the first part of the conversion to coroutines, by
wrapping bdrv_write implementations to take the mutex.
Drivers that implement bdrv_write rather than bdrv_co_writev can
then benefit from asynchronous operation (at least if the underlying
protocol supports it, whic
From: Paolo Bonzini
While vmdk_open_desc_file (touched by the patch) correctly changed -1
to -EINVAL, vmdk_open did not. Fix it directly in vmdk_parent_open.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
block/vmdk.c | 15 +--
1 files changed, 9 insertions(+), 6 de
On Fri, Oct 21, 2011 at 09:37:02AM +0200, Paolo Bonzini wrote:
> On 10/21/2011 02:26 AM, Stuart Brady wrote:
> >>> They all look okay, perhaps the include path you passed to
> >>> Coccinelle is incomplete?
> >Ah, good point! I'm not sure what include dirs are needed, though...
> >anyone have any
From: Paolo Bonzini
Since coroutine operation is now mandatory, convert both bdrv_discard
implementations to coroutines. For qcow2, this means taking the lock
around the operation. raw-posix remains synchronous.
The bdrv_discard callback is then unused and can be eliminated.
Reviewed-by: Kevi
- This mail is in HTML. Some elements may be ommited in plain text. -
Vi har en outtagna portfölj av ditt avstånd Sen släkting fonder med vår bank.
Skicka mig ett telefonnummer jag kan ringa dig eller ring mig på det här numret
447.741.782.385.
www.snsbank.nl
Läs bifogad fil för fullständig inf
Commit 63ffb564 broke floppy devices specified on the command line like
-drive file=...,if=none,id=floppy -global isa-fdc.driveA=floppy because it
relies on drive_get() which works only with -fda/-drive if=floppy.
This patch resembles what we're already doing for IDE, i.e. remember the floppy
devi
From: Paolo Bonzini
Add coroutine support for flush and apply the same emulation that
we already do for read/write. bdrv_aio_flush is simplified to always
go through a coroutine.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
block.c | 164 ++-
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
block.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index 9873b57..7184a0f 100644
--- a/block.c
+++ b/block.c
@@ -2735,7 +2735,7 @@ static AIOPool bdrv_em_co_aio_poo
The floppy device was broken by commit 212ec7ba (fdc: Convert to
isa_register_portio_list). While the old interface provided the port number
relative to the floppy drive's io_base, the new one provides the real port
number, so we need to apply a bitmask now to get the register number.
Signed-off-b
Signed-off-by: Paolo Bonzini
---
qemu-timer.c | 12
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/qemu-timer.c b/qemu-timer.c
index 58926dd..f11a28d 100644
--- a/qemu-timer.c
+++ b/qemu-timer.c
@@ -273,7 +273,11 @@ static QEMUClock *qemu_new_clock(int type)
void
The following changes since commit c76eaf13975130768070ecd2d4f3107eb69ab757:
hw/9pfs: Fix broken compilation caused by wrong trace events (2011-10-20
15:30:59 -0500)
are available in the git repository at:
git://github.com/bonzini/qemu.git split-main-loop-for-anthony
This patch series makes
None of this is needed by tools, and most of it can even be made static
inside cpus.c.
Signed-off-by: Paolo Bonzini
---
cpus.c| 295 +
exec-all.h| 14 +++
exec.c|3 -
qemu-common.h |4 +
qemu-timer.c | 279 -
Signed-off-by: Paolo Bonzini
---
Makefile.objs|2 +-
cpus.c | 189 +-
cpus.h |1 +
main-loop.c | 495 ++
main-loop.h | 24 +++
os-win32.c | 123 --
qemu-common.
From: Paolo Bonzini
This similarly adds support for coroutine and asynchronous discard.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
block.c | 102 +++--
block.h |4 ++
block/raw.c | 10 +++--
block_int.h |
From: Paolo Bonzini
Cc: MORITA Kazutaka
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
oslib-posix.c |7 +++
oslib-win32.c |6 ++
qemu_socket.h |1 +
3 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/oslib-posix.c b/oslib-posix.c
index a304fb0..db
Only qcow and qcow2 can do compression at all, and they require unallocated
clusters when writing the compressed data.
Signed-off-by: Kevin Wolf
Reviewed-by: Stefan Hajnoczi
---
qemu-img.c | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/qemu-img.c b/qemu-img.
From: Stefan Hajnoczi
Block drivers now only need to provide either of .bdrv_co_flush,
.bdrv_aio_flush() or for legacy drivers .bdrv_flush(). Remove
the redundant .bdrv_flush() implementations.
[Paolo Bonzini: change raw driver to bdrv_co_flush]
Signed-off-by: Stefan Hajnoczi
Signed-off-by: P
From: Alex Jia
Haven't released memory of 'ctx' before return.
Signed-off-by: Alex Jia
Signed-off-by: Kevin Wolf
---
qemu-io.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/qemu-io.c b/qemu-io.c
index e91af37..c45a413 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -1248,
The synchronous .bdrv_flush callback doesn't exist any more and a device really
shouldn't poke into the block layer internals anyway. All drivers are supposed
to have a correctly working bdrv_flush, so let's just hard-code this.
Signed-off-by: Kevin Wolf
---
hw/xen_disk.c |5 ++---
1 files c
If during allocation of compressed clusters the cluster was already allocated
uncompressed, fail and properly release the l2_table (the latter avoids a
failed assertion).
While at it, make it return some real error numbers instead of -1.
Signed-off-by: Kevin Wolf
Reviewed-by: Dong Xu Wang
---
Signed-off-by: Paolo Bonzini
---
qemu-timer.c | 15 ---
qemu-timer.h |1 -
vl.c |1 -
3 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/qemu-timer.c b/qemu-timer.c
index d8507e3..7fa81e1 100644
--- a/qemu-timer.c
+++ b/qemu-timer.c
@@ -840,6 +840,13 @@ s
Signed-off-by: Paolo Bonzini
---
qemu-timer.c | 35 ---
qemu-timer.h |2 ++
savevm.c | 25 +
vl.c |1 +
4 files changed, 32 insertions(+), 31 deletions(-)
diff --git a/qemu-timer.c b/qemu-timer.c
index 7fa81e1..58926
Reviewed-by: Anthony Liguori
Signed-off-by: Paolo Bonzini
---
qemu-timer.c | 129 --
1 files changed, 53 insertions(+), 76 deletions(-)
diff --git a/qemu-timer.c b/qemu-timer.c
index acf7a15..e2551f3 100644
--- a/qemu-timer.c
+++ b/qemu-t
Signed-off-by: Paolo Bonzini
---
async.c |1 +
cpus.c|7 +-
cpus.h|1 -
iohandler.c |1 +
main-loop.h | 327 +
qemu-char.h | 12 +--
qemu-common.h
From: Paolo Bonzini
This does the first part of the conversion to coroutines, by
wrapping bdrv_read implementations to take the mutex.
Drivers that implement bdrv_read rather than bdrv_co_readv can
then benefit from asynchronous operation (at least if the underlying
protocol supports it, which i
Embed the list in the QEMUClock instead.
Reviewed-by: Anthony Liguori
Signed-off-by: Paolo Bonzini
---
qemu-timer.c | 59 +++--
1 files changed, 28 insertions(+), 31 deletions(-)
diff --git a/qemu-timer.c b/qemu-timer.c
index ad1fc8b..acf7a
These will be used when moving icount accounting to cpus.c.
Reviewed-by: Anthony Liguori
Signed-off-by: Paolo Bonzini
---
qemu-timer.c | 25 +
qemu-timer.h |3 +++
2 files changed, 28 insertions(+), 0 deletions(-)
diff --git a/qemu-timer.c b/qemu-timer.c
index e25
This reverts commit c82dc29a9112f34e0a51cad9a412cf6d9d05dfb2
and 4d88a2ac8643265108ef1fb47ceee5d7b28e19f2.
Signed-off-by: Paolo Bonzini
---
iohandler.c | 54 +-
1 files changed, 1 insertions(+), 53 deletions(-)
diff --git a/iohandler.c b/ioh
Reviewed-by: Anthony Liguori
Signed-off-by: Paolo Bonzini
---
hw/mac_dbdma.c |5 -
hw/mac_dbdma.h |1 -
2 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/hw/mac_dbdma.c b/hw/mac_dbdma.c
index 5affdd1..1791ec1 100644
--- a/hw/mac_dbdma.c
+++ b/hw/mac_dbdma.c
@@ -661,11 +6
Hi Mathieu,
On 18 October 2011 23:45, Mathieu Sonet wrote:
> This driver emulates the ARM AACI interface (PL041) connected to a LM4549
> codec.
> It enables audio playback for the Versatile/PB platform.
>
> Limitations:
> - Supports only a playback on one channel (Versatile/Vexpress)
> - Supports
Fix load of floating point registers
Signed-off-by: Dmitry Koshelev
---
target-arm/machine.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-arm/machine.c b/target-arm/machine.c
index 7d4fc54..aaee9b9 100644
--- a/target-arm/machine.c
+++ b/target-arm/machine.c
@
On 13 October 2011 19:45, Peter Maydell wrote:
> Don't pass a NULL pointer in to SYS_signalfd in qemu_signalfd_available():
> this isn't valid and Valgrind complains about it.
Also pushed this patch.
Cheers
On 29 September 2011 16:48, Peter Maydell wrote:
> Fix the "-version" option, which was accidentally broken in commit
> fc9c541:
> * exit after printing version information rather than proceeding
> blithely onward (and likely printing the full usage message)
> * correct the cut-n-paste error i
Peter Maydell writes:
>> The only realistic way to get started with such setups I see is to create a
>> new target-xxx for the specific mix, define TARGET_LONG_BITS etc.
>> appropriately in a new cpu.h, compile the needed target-xyz/*.c to unique
>> xxx-softmmu/xyz-*.o and dispatch from a cpu_init
In testing my patches for 'add_client' support with SPICE, I noticed
deadlock in the QEMU/SPICE code. It only happens if I close a SPICE
client and then immediately reconnect within about 1 second. If I
wait a couple of seconds before reconnecting the SPICE client I don't
see the deadlock.
I'm usi
From: "Daniel P. Berrange"
With the proposal of some new APIs[1] to libspice-server.so it
is possible to add support for SPICE to the 'add_client'
monitor command, bringing parity with VNC. Since SPICE can
use TLS or plain connections, the command also gains a new
'tls' parameter to specify wheth
On Thu, 20 Oct 2011 23:20:54 +0400, Max Filippov wrote:
> Hi.
>
> Current git head build with trace enabled is broken by the commit
> c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p
> pdu handlers.
> Error messages:
>
> In file included from trace.c:2:0:
> trace.h: I
The most common use of -net tap is to connect a tap device to a bridge. This
requires the use of a script and running qemu as root in order to allocate a
tap device to pass to the script.
This model is great for portability and flexibility but it's incredibly
difficult to eliminate the need to ru
With qemu it is possible to run a guest from an unprivileged user but if
we wanted to communicate with the outside world we had to switch
to root.
We address this problem by introducing a new network backend and a new
network option for -net tap. This is less flexible when compared to
existing -n
This patch adds a helper that can be used to create a tap device attached to
a bridge device. Since this helper is minimal in what it does, it can be
given CAP_NET_ADMIN which allows qemu to avoid running as root while still
satisfying the majority of what users tend to want to do with tap devices
On 18 October 2011 17:12, Peter Maydell wrote:
> The OMAP2430 version of the omap-gpio device has five GPIO modules,
> not four like the other OMAP2 versions; wire up the fifth module's
> IRQ line correctly.
Thanks, pushed this patch.
Cheers
The ideal way to use qemu-bridge-helper is to give it an fscap of using:
setcap cap_net_admin=ep qemu-bridge-helper
Unfortunately, most distros still do not have a mechanism to package files
with fscaps applied. This means they'll have to SUID the qemu-bridge-helper
binary.
To improve security
On 20 October 2011 12:48, Dmitry Koshelev wrote:
> irq_target array saving/loading is in the wrong loop.
> Version bump.
>
> Signed-off-by: Dmitry Koshelev
Thanks, pushed this patch.
Cheers
We go to great lengths to restrict ourselves to just cap_net_admin as an OS
enforced security mechanism. However, we further restrict what we allow users
to do to simply adding a tap device to a bridge interface by virtue of the fact
that this is the only functionality we expose.
This is not good
Am 21.10.2011 16:11, schrieb Anthony Liguori:
> On 10/21/2011 09:03 AM, Paolo Bonzini wrote:
>> Even for files are licensed GPLv2-only, let's not play catch with
>> ourselves, and explicitly declare that future contributions to those
>> files will also be available as "any later version".
>>
>> Sig
On 10/21/2011 04:11 PM, Anthony Liguori wrote:
Otherwise I'm a bit concerned about ambiguity here. Let's say we have
to backport a fit to stable, we need to pull in this new copyright
statement.
But then what if we later discovered we need to pull in a fix from
before 10/25. That will appear
On 10/21/2011 01:17 AM, kha...@kics.edu.pk wrote:
> +switch (opc) {
> +case OPC_SEQ:
> +tcg_gen_setcondi_tl(TCG_COND_LTU, cpu_gpr[rd], t0, 1);
> +opn = "seq";
> +break;
> +case OPC_SNE:
> +tcg_gen_setcondi_tl(TCG_COND_GTU, cpu_gpr[rd], t0, 0);
> +
Am 21.10.2011 15:58, schrieb Dmitry Koshelev:
> On Fri, Oct 21, 2011 at 3:42 PM, Andreas Färber wrote:
>> Am 20.10.2011 12:48, schrieb Dmitry Koshelev:
>>> irq_target array saving/loading is in the wrong loop.
>>> Version bump.
>>>
>>> Signed-off-by: Dmitry Koshelev
>>
>> Acked-by: Andreas Färber
On Fri, Oct 21, 2011 at 09:02:37AM -0400, Dave Anderson wrote:
> It would be kind of cool if there was a "/dev/mem"-like interface
> to a KVM guest's physical memory, so that you could sit on a KVM host
> and enter "crash vmlinux-of-guest /dev/mem-of-guest" in order to
> run live analysis of a gues
On 10/21/2011 09:03 AM, Paolo Bonzini wrote:
Even for files are licensed GPLv2-only, let's not play catch with
ourselves, and explicitly declare that future contributions to those
files will also be available as "any later version".
Signed-off-by: Paolo Bonzini
diff --git a/roms/SLOF b/roms/SLOF
Even for files are licensed GPLv2-only, let's not play catch with
ourselves, and explicitly declare that future contributions to those
files will also be available as "any later version".
Signed-off-by: Paolo Bonzini
---
aio.c |2 ++
block-migration.c |2 ++
On Fri, Oct 21, 2011 at 3:42 PM, Andreas Färber wrote:
> Am 20.10.2011 12:48, schrieb Dmitry Koshelev:
>> irq_target array saving/loading is in the wrong loop.
>> Version bump.
>>
>> Signed-off-by: Dmitry Koshelev
>
> Acked-by: Andreas Färber
>
> Applies cleanly now.
>
> Is there a particular us
On 10/21/2011 03:32 PM, Kevin Wolf wrote:
2) let ide-cd create its own SCSI bus and act as an adaptor, similar to
> USB devices. There would still be duplication for commands that do DMA
> in multiple steps; I think READ CD is the only one.
>
> 3) create a separate API just for the purpose of
Am 21.10.2011 15:12, schrieb Paolo Bonzini:
> On 10/21/2011 01:42 PM, Kevin Wolf wrote:
>> There is only one 'goto fail', all other places have a direct return -1.
>> It would be good to be consistent.
>>
>> Also, as this is mostly a refactored copy from the ATAPI code, I wonder
>> what our long-te
On 2011-10-21 15:02, Dave Anderson wrote:
>
>
> - Original Message -
>> At 10/21/2011 03:11 PM, Jan Kiszka Write:
>>> On 2011-10-20 12:03, Wen Congyang wrote:
At 10/20/2011 05:41 PM, Jan Kiszka Write:
> On 2011-10-20 03:22, Wen Congyang wrote:
I didn't read full story bu
On 10/21/2011 02:31 PM, Kevin Wolf wrote:
> diff --git a/hw/esp.c b/hw/esp.c
> index d3fb1c6..8e17005 100644
> --- a/hw/esp.c
> +++ b/hw/esp.c
> @@ -217,7 +217,8 @@ static uint32_t get_cmd(ESPState *s, uint8_t *buf)
>s->async_len = 0;
>}
>
> -if (target>= ESP_MAX_DEV
On 10/21/2011 01:42 PM, Kevin Wolf wrote:
There is only one 'goto fail', all other places have a direct return -1.
It would be good to be consistent.
Also, as this is mostly a refactored copy from the ATAPI code, I wonder
what our long-term plan is. At which point will we be able to unify what
w
On 10/21/2011 01:42 PM, Kevin Wolf wrote:
> +if (s->qdev.type != TYPE_ROM || !bdrv_is_inserted(s->bs)) {
> +return -1;
> +}
> +if (s->tray_open || !bdrv_is_inserted(s->bs)) {
> +scsi_check_condition(r, SENSE_CODE(NO_MEDIUM));
> +return -1;
> +}
You
On 10/21/2011 01:54 PM, Kevin Wolf wrote:
This adds support for media change notification via the GET EVENT STATUS
> NOTIFICATION command, used by Linux versions 2.6.38 and newer.
>
> Signed-off-by: Paolo Bonzini
Looks good, but the ATAPI version of the code is somewhat nicer to read.
Yeah,
- Original Message -
> At 10/21/2011 03:11 PM, Jan Kiszka Write:
> > On 2011-10-20 12:03, Wen Congyang wrote:
> >> At 10/20/2011 05:41 PM, Jan Kiszka Write:
> >>> On 2011-10-20 03:22, Wen Congyang wrote:
> >> I didn't read full story but 'crash' is used for investigating kernel
> >>>
Am 13.10.2011 13:03, schrieb Paolo Bonzini:
> Change the devs array into a linked list, and add a scsi_device_find
> function to navigate the children list instead. This lets the SCSI
> bus use more complex addressing.
>
> scsi_device_find may return another LUN on the same target if none is
> fo
On 10/21/2011 02:01 PM, Kevin Wolf wrote:
>
> -static const struct SCSIBusOps vscsi_scsi_ops = {
> +static const struct SCSIBusInfo vscsi_scsi_info = {
> +.tcq = true,
> +.ndev = 63, /* logical unit addressing format */
This is a change from VSCSI_REQ_LIMIT = 24. This may be a bugfix
Am 13.10.2011 13:03, schrieb Paolo Bonzini:
> Signed-off-by: Paolo Bonzini
> ---
> hw/esp.c |7 +--
> hw/lsi53c895a.c |9 ++---
> hw/scsi-bus.c| 27 ---
> hw/scsi-disk.c |2 +-
> hw/scsi.h| 11 +--
> hw/spapr_vscsi.c |
On Fri, Oct 21, 2011 at 11:27:48AM +0200, Jan Kiszka wrote:
> On 2011-10-21 09:54, Michael S. Tsirkin wrote:
> > On Fri, Oct 21, 2011 at 09:09:10AM +0200, Jan Kiszka wrote:
> >> On 2011-10-21 00:02, Michael S. Tsirkin wrote:
> > Yes. But this still makes an API for acquiring per-vector resource
Am 13.10.2011 13:03, schrieb Paolo Bonzini:
> This adds support for media change notification via the GET EVENT STATUS
> NOTIFICATION command, used by Linux versions 2.6.38 and newer.
>
> Signed-off-by: Paolo Bonzini
Looks good, but the ATAPI version of the code is somewhat nicer to read.
Kevin
Am 20.10.2011 12:48, schrieb Dmitry Koshelev:
> irq_target array saving/loading is in the wrong loop.
> Version bump.
>
> Signed-off-by: Dmitry Koshelev
Acked-by: Andreas Färber
Applies cleanly now.
Is there a particular use case that was broken before and works now, or
did this turn up durin
Am 13.10.2011 13:03, schrieb Paolo Bonzini:
> Signed-off-by: Paolo Bonzini
> ---
> hw/scsi-disk.c | 101
> +++-
> 1 files changed, 100 insertions(+), 1 deletions(-)
>
> diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
> index 1786c37..14db6a0 100
Signed-off-by: Pavel Borzenkov
---
hw/fw_cfg.c | 100 ++-
1 files changed, 37 insertions(+), 63 deletions(-)
diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c
index 8df265c..d2400f5 100644
--- a/hw/fw_cfg.c
+++ b/hw/fw_cfg.c
@@ -60,71 +60,55 @@ struc
When adding the locking, we came to the conclusion that converting
read/write/flush/discard to coroutines should be enough because everything else
isn't called in coroutine context. Add assertions to spell this assumption out
and ensure that it won't be broken accidentally.
And even if we have mis
The synchronous .bdrv_flush callback doesn't exist any more and a device really
shouldn't poke into the block layer internals anyway. All drivers are supposed
to have a correctly working bdrv_flush, so let's just hard-code this.
Signed-off-by: Kevin Wolf
---
I'm not sure what feature-barrier rea
As phys_ram_size had been removed since QEMU 0.12. Remove the useless
comment.
Signed-off-by: Chen Wen-Ren
---
exec.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/exec.c b/exec.c
index d0cbf15..fb21e76 100644
--- a/exec.c
+++ b/exec.c
@@ -472,7 +472,6 @@ static void
1 - 100 of 130 matches
Mail list logo
