Re: [Qemu-devel] [0/4] pseries: Support and improvements for KVM Book3S-HV support (v2)

2011-10-06 Thread Alexander Graf
On 30.09.2011, at 09:39, David Gibson wrote: > Alex Graf has added support for KVM acceleration of the pseries > machine, using his Book3S-PR KVM variant, which runs the guest in > userspace, emulating supervisor operations. Recent kernels now have > the Book3S-HV KVM variant which uses the hard

Re: [Qemu-devel] [PATCH v2 2/2] ppc/e500_pci: Fix an array overflow issue

2011-10-06 Thread Alexander Graf
On 30.09.2011, at 05:52, Liu Yu wrote: > When access PPCE500_PCI_IW1 the previous index get overflow. > The patch fix the issue and update all to keep consistent style. > > Signed-off-by: Liu Yu Thanks, applied both to my local ppc-next tree. Will push once Blue pulled the request. Alex

[Qemu-devel] [PATCH 2/2] qemu-options.hx: Update virtfs command documentation

2011-10-06 Thread Aneesh Kumar K.V
Clarify the virtfs option better Updates from:Sripathi Kodi Signed-off-by: Aneesh Kumar K.V --- qemu-options.hx | 119 --- 1 files changed, 69 insertions(+), 50 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 38f0aef..6c744

[Qemu-devel] [PATCH 1/2] hw/9pfs: Add new virtfs option cache=writethrough to skip host page cache

2011-10-06 Thread Aneesh Kumar K.V
cache=writethrough implies the file are opened in the host with O_SYNC open flag Signed-off-by: Aneesh Kumar K.V --- fsdev/file-op-9p.h |1 + fsdev/qemu-fsdev.c | 10 -- fsdev/qemu-fsdev.h |2 ++ hw/9pfs/virtio-9p-device.c |5 + hw/9pfs/virtio-9p

Re: [Qemu-devel] [PATCH 4/5] savevm: improve subsections detection on load

2011-10-06 Thread Paolo Bonzini
On 10/07/2011 12:42 AM, Juan Quintela wrote: > This changes semantics for reads above 32KB. It should be in the > commit message, or preferably v1 could be committed instead.:) how it changes? My understanding is that we read the same, only change that I can think of is the one that I have j

[Qemu-devel] [PATCH] hw/9pfs: Use ioeventfd for 9p

2011-10-06 Thread Aneesh Kumar K.V
With ioeventfd: [root@qemu-img-64 storage]# dd if=/dev/zero of=/storage/testx bs=8k count=131072 oflag=direct 131072+0 records in 131072+0 records out 1073741824 bytes (1.1 GB) copied, 26.767 s, 40.1 MB/s Without: [root@qemu-img-64 storage]# dd if=/dev/zero of=/storage/testx bs=8k count=131072 o

[Qemu-devel] [PATCH] qemu-char: Fix use of free() instead of g_free()

2011-10-06 Thread Stefan Weil
cppcheck reported these errors: qemu-char.c:1667: error: Mismatching allocation and deallocation: s qemu-char.c:1668: error: Mismatching allocation and deallocation: chr qemu-char.c:1769: error: Mismatching allocation and deallocation: s qemu-char.c:1770: error: Mismatching allocation and dealloca

[Qemu-devel] [PATCH] block/qcow: Fix use of free() instead of g_free()

2011-10-06 Thread Stefan Weil
cppcheck reported this error: qemu/block/qcow.c:599: error: Mismatching allocation and deallocation: cluster_data Signed-off-by: Stefan Weil --- block/qcow.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index c8bfecc..eba5a04 100644 ---

Re: [Qemu-devel] QEMU + ARMMP11Core combination does not work

2011-10-06 Thread TusharK
Hi Peter, Thanks for reply. I seek help from you because I am sort of stuck. As kernel image does not get executed by QEMU. I tried single stepping but I could not debug the initial assembly code. I do not know why. My breakpoint never hits. I would like to use ARM11MPcore because my software

Re: [Qemu-devel] [PATCH] qemu: new option for snapshot_blkdev to avoid image creation

2011-10-06 Thread Dor Laor
On 10/03/2011 06:09 PM, Federico Simoncelli wrote: Add the new option [-n] for snapshot_blkdev to avoid the image creation. The file provided as [new-image-file] is considered as already initialized and will be used after passing a check for the backing file. Seems ok to me as a way to go aroun

Re: [Qemu-devel] [PATCH 4/5] savevm: improve subsections detection on load

2011-10-06 Thread Juan Quintela
Paolo Bonzini wrote: > On 10/06/2011 06:21 PM, Juan Quintela wrote: >> + >> +int qemu_get_buffer(QEMUFile *f, uint8_t *buf, int size) >> +{ >> +int pending = size; >> +int done = 0; >> + >> +while (pending> 0) { >> +int res; >> + >> +res = qemu_peek_buffer(f, buf, pend

Re: [Qemu-devel] [PATCH 3/5] savevm: define qemu_get_byte() using qemu_peek_byte()

2011-10-06 Thread Juan Quintela
Paolo Bonzini wrote: > On 10/06/2011 06:21 PM, Juan Quintela wrote: >> +result = qemu_peek_byte(f); >> + >> +if (f->buf_index< f->buf_size) { >> +f->buf_index++; >> } > > This should really be an assert that f->buf_index < f->buf_size, > otherwise qemu_peek_byte has read gar

Re: [Qemu-devel] qemu guest agent spins in poll/nanosleep(100ms) when nothing is listening on host

2011-10-06 Thread Michael Roth
On Thu, 6 Oct 2011 12:31:05 +0100, "Daniel P. Berrange" wrote: > I've been doing some experimentation with the QEMU guest agent and have > noticed that when nothing is connected on the host side of the virtio > serial channel, the guest agent just spins in a pool/sleep(100ms) loop. > I know you'd

Re: [Qemu-devel] [PATCH 1/4] Add basic version of bridge helper

2011-10-06 Thread Corey Bryant
On 10/06/2011 02:04 PM, Anthony Liguori wrote: On 10/06/2011 11:41 AM, Daniel P. Berrange wrote: On Thu, Oct 06, 2011 at 11:38:25AM -0400, Richa Marwaha wrote: This patch adds a helper that can be used to create a tap device attached to a bridge device. Since this helper is minimal in what it

Re: [Qemu-devel] [PATCH 4/4] Add support for bridge

2011-10-06 Thread Corey Bryant
On 10/06/2011 02:19 PM, Anthony Liguori wrote: On 10/06/2011 01:15 PM, Corey Bryant wrote: On 10/06/2011 01:49 PM, Anthony Liguori wrote: On 10/06/2011 10:38 AM, Richa Marwaha wrote: The most common use of -net tap is to connect a tap device to a bridge. This requires the use of a script a

Re: [Qemu-devel] [PATCH 4/4] Add support for bridge

2011-10-06 Thread Anthony Liguori
On 10/06/2011 01:15 PM, Corey Bryant wrote: On 10/06/2011 01:49 PM, Anthony Liguori wrote: On 10/06/2011 10:38 AM, Richa Marwaha wrote: The most common use of -net tap is to connect a tap device to a bridge. This requires the use of a script and running qemu as root in order to allocate a tap

Re: [Qemu-devel] [PATCH 4/4] Add support for bridge

2011-10-06 Thread Corey Bryant
On 10/06/2011 01:49 PM, Anthony Liguori wrote: On 10/06/2011 10:38 AM, Richa Marwaha wrote: The most common use of -net tap is to connect a tap device to a bridge. This requires the use of a script and running qemu as root in order to allocate a tap device to pass to the script. This model is

Re: [Qemu-devel] [PATCH 1/4] Add basic version of bridge helper

2011-10-06 Thread Corey Bryant
On 10/06/2011 01:44 PM, Anthony Liguori wrote: On 10/06/2011 10:38 AM, Richa Marwaha wrote: This patch adds a helper that can be used to create a tap device attached to a bridge device. Since this helper is minimal in what it does, it can be given CAP_NET_ADMIN which allows qemu to avoid runni

Re: [Qemu-devel] [PATCH 1/4] Add basic version of bridge helper

2011-10-06 Thread Anthony Liguori
On 10/06/2011 11:41 AM, Daniel P. Berrange wrote: On Thu, Oct 06, 2011 at 11:38:25AM -0400, Richa Marwaha wrote: This patch adds a helper that can be used to create a tap device attached to a bridge device. Since this helper is minimal in what it does, it can be given CAP_NET_ADMIN which allows

Re: [Qemu-devel] [PATCH 3/4] Add cap reduction support to enable use as SUID

2011-10-06 Thread Corey Bryant
On 10/06/2011 01:42 PM, Anthony Liguori wrote: On 10/06/2011 11:34 AM, Daniel P. Berrange wrote: On Thu, Oct 06, 2011 at 11:38:27AM -0400, Richa Marwaha wrote: The ideal way to use qemu-bridge-helper is to give it an fscap of using: setcap cap_net_admin=ep qemu-bridge-helper Unfortunately,

Re: [Qemu-devel] [PATCH 3/4] Add cap reduction support to enable use as SUID

2011-10-06 Thread Corey Bryant
On 10/06/2011 01:42 PM, Anthony Liguori wrote: On 10/06/2011 11:34 AM, Daniel P. Berrange wrote: On Thu, Oct 06, 2011 at 11:38:27AM -0400, Richa Marwaha wrote: The ideal way to use qemu-bridge-helper is to give it an fscap of using: setcap cap_net_admin=ep qemu-bridge-helper Unfortunately,

Re: [Qemu-devel] [PATCH 4/4] Add support for bridge

2011-10-06 Thread Anthony Liguori
On 10/06/2011 10:38 AM, Richa Marwaha wrote: The most common use of -net tap is to connect a tap device to a bridge. This requires the use of a script and running qemu as root in order to allocate a tap device to pass to the script. This model is great for portability and flexibility but it's i

Re: [Qemu-devel] [PATCH 3/4] Add cap reduction support to enable use as SUID

2011-10-06 Thread Anthony Liguori
On 10/06/2011 11:34 AM, Daniel P. Berrange wrote: On Thu, Oct 06, 2011 at 11:38:27AM -0400, Richa Marwaha wrote: The ideal way to use qemu-bridge-helper is to give it an fscap of using: setcap cap_net_admin=ep qemu-bridge-helper Unfortunately, most distros still do not have a mechanism to pa

Re: [Qemu-devel] [PATCH 1/4] Add basic version of bridge helper

2011-10-06 Thread Anthony Liguori
On 10/06/2011 10:38 AM, Richa Marwaha wrote: This patch adds a helper that can be used to create a tap device attached to a bridge device. Since this helper is minimal in what it does, it can be given CAP_NET_ADMIN which allows qemu to avoid running as root while still satisfying the majority of

Re: [Qemu-devel] [PATCH 1/4] Add basic version of bridge helper

2011-10-06 Thread Daniel P. Berrange
On Thu, Oct 06, 2011 at 11:38:25AM -0400, Richa Marwaha wrote: > This patch adds a helper that can be used to create a tap device attached to > a bridge device. Since this helper is minimal in what it does, it can be > given CAP_NET_ADMIN which allows qemu to avoid running as root while still > sa

Re: [Qemu-devel] [PATCH 3/4] Add cap reduction support to enable use as SUID

2011-10-06 Thread Daniel P. Berrange
On Thu, Oct 06, 2011 at 11:38:27AM -0400, Richa Marwaha wrote: > The ideal way to use qemu-bridge-helper is to give it an fscap of using: > > setcap cap_net_admin=ep qemu-bridge-helper > > Unfortunately, most distros still do not have a mechanism to package files > with fscaps applied. This mea

Re: [Qemu-devel] [RFC] Use TCGReg for all TCG targets?

2011-10-06 Thread Richard Henderson
On 10/06/2011 09:24 AM, Stefan Weil wrote: > Is there consensus that this is a good idea, or should > TCGReg be removed (then all TCG targets use int) or only > used for s390? I think it's a good idea. r~

[Qemu-devel] Integrating Dynamips and GNS3 UDP tunnels (Patches)

2011-10-06 Thread Benjamin Epitech
GNS3 team developed a GUI in order to inter-connect different emulated hardware. In order to achieve a network inter-connection between each hosts, one single protocol is used: an UDP tunneling protocol introduced by Dynamips (a cisco hardware emulator). Since the beginning, GNS3 supports Qemu by

[Qemu-devel] [PATCH] hw/9pfs: Fix build error on platform that don't support futimens

2011-10-06 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-handle.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/hw/9pfs/virtio-9p-handle.c b/hw/9pfs/virtio-9p-handle.c index 860b0e3..9860a87 100644 --- a/hw/9pfs/virtio-9p-handle.c +++ b/hw/9pfs/virtio-9p-hand

[Qemu-devel] [PATCH 5/5] Revert "savevm: fix corruption in vmstate_subsection_load()."

2011-10-06 Thread Juan Quintela
This reverts commit eb60260de0b050a5e8ab725e84d377d0b44c43ae. Conflicts: savevm.c We changed qemu_peek_byte() prototype, just fixed the rejects. Signed-off-by: Juan Quintela Reviewed-by: Anthony Liguori --- savevm.c | 10 +- 1 files changed, 1 insertions(+), 9 deletions(-)

Re: [Qemu-devel] [PATCH 4/5] savevm: improve subsections detection on load

2011-10-06 Thread Paolo Bonzini
On 10/06/2011 06:21 PM, Juan Quintela wrote: + +int qemu_get_buffer(QEMUFile *f, uint8_t *buf, int size) +{ +int pending = size; +int done = 0; + +while (pending> 0) { +int res; + +res = qemu_peek_buffer(f, buf, pending, 0); +if (res == 0) { +retur

Re: [Qemu-devel] [PATCH 3/5] savevm: define qemu_get_byte() using qemu_peek_byte()

2011-10-06 Thread Paolo Bonzini
On 10/06/2011 06:21 PM, Juan Quintela wrote: +result = qemu_peek_byte(f); + +if (f->buf_index< f->buf_size) { +f->buf_index++; } This should really be an assert that f->buf_index < f->buf_size, otherwise qemu_peek_byte has read garbage. Paolo

[Qemu-devel] [RFC] Use TCGReg for all TCG targets?

2011-10-06 Thread Stefan Weil
Hi, commit 48bb3750e13cbb5a634d3aeab5191d74d124232f introduced the data type 'TCGReg' in tcg/s390. Today, s390 is the only TCG target which uses TCGReg. This causes a conflict with my commit c0ad3001bf12292b137b05e1c4643f31c6b0a727, because some function prototypes in tcg/s390/tcg-target.c diff

[Qemu-devel] [PATCH 4/5] savevm: improve subsections detection on load

2011-10-06 Thread Juan Quintela
We add qemu_peek_buffer, that is identical to qemu_get_buffer, just that it don't update f->buf_index. We add a paramenter to qemu_peek_byte() to be able to peek more than one byte. Once this is done, to see if we have a subsection we look: - 1st byte is QEMU_VM_SUBSECTION - 2nd byte is a length,

[Qemu-devel] [PATCH 3/5] savevm: define qemu_get_byte() using qemu_peek_byte()

2011-10-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- savevm.c | 15 ++- 1 files changed, 6 insertions(+), 9 deletions(-) diff --git a/savevm.c b/savevm.c index 4069b34..94628c6 100644 --- a/savevm.c +++ b/savevm.c @@ -578,17 +578,14 @@ static int qemu_peek_byte(QEMUFile *f) int qemu_get_byte(QEMUFil

[Qemu-devel] [PATCH 2/5] savevm: some coding style cleanups

2011-10-06 Thread Juan Quintela
This patch will make moving code on next patches and having checkpatch happy easier. Signed-off-by: Juan Quintela Reviewed-by: Anthony Liguori --- savevm.c | 21 ++--- 1 files changed, 14 insertions(+), 7 deletions(-) diff --git a/savevm.c b/savevm.c index 743c304..4069b34 10

[Qemu-devel] [PATCH 1/5] savevm: teach qemu_fill_buffer to do partial refills

2011-10-06 Thread Juan Quintela
We will need on next patch to be able to lookahead on next patch v2: rename "used" to "pending" (Alex Williams) Signed-off-by: Juan Quintela Reviewed-by: Anthony Liguori --- savevm.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/savevm.c b/savevm.c inde

[Qemu-devel] [PATCH 0/5] migration: Improve subsections detection

2011-10-06 Thread Juan Quintela
Hi v2: - rename "used" to "remaining" (Alex suggestion) - implement qemu_get_{byte,buffer} on top of qemu_peek_{byte, buffer} (Anthony suggestion) - fix qemu_peek_buffe_logic (Alex discovered the problem) v1: This series move the subsections detection code form: - Look that it starts form 5 To

[Qemu-devel] [PATCH 0/4] -net tap: rootless bridge support for qemu

2011-10-06 Thread Richa Marwaha
With qemu it possible to run guest with unprivileged user but if we wanted to communicate with the outside world we had to switch to root. We address this problem by introducing a new network option.This option is less flexible as compare to other -net tap options because it relies on a helper wit

[Qemu-devel] [PATCH 1/4] Add basic version of bridge helper

2011-10-06 Thread Richa Marwaha
This patch adds a helper that can be used to create a tap device attached to a bridge device. Since this helper is minimal in what it does, it can be given CAP_NET_ADMIN which allows qemu to avoid running as root while still satisfying the majority of what users tend to want to do with tap devices

[Qemu-devel] [PATCH 2/4] Add access control support to qemu-bridge-helper

2011-10-06 Thread Richa Marwaha
We go to great lengths to restrict ourselves to just cap_net_admin as an OS enforced security mechanism. However, we further restrict what we allow users to do to simply adding a tap device to a bridge interface by virtue of the fact that this is the only functionality we expose. This is not good

[Qemu-devel] [PATCH 3/4] Add cap reduction support to enable use as SUID

2011-10-06 Thread Richa Marwaha
The ideal way to use qemu-bridge-helper is to give it an fscap of using: setcap cap_net_admin=ep qemu-bridge-helper Unfortunately, most distros still do not have a mechanism to package files with fscaps applied. This means they'll have to SUID the qemu-bridge-helper binary. To improve security

[Qemu-devel] [PATCH 4/4] Add support for bridge

2011-10-06 Thread Richa Marwaha
The most common use of -net tap is to connect a tap device to a bridge. This requires the use of a script and running qemu as root in order to allocate a tap device to pass to the script. This model is great for portability and flexibility but it's incredibly difficult to eliminate the need to ru

[Qemu-devel] Running Qemu on Mac OS 10.7

2011-10-06 Thread mneug
Hi, Has anyone on this list tried and succeeded in running a recent version of Qemu on Mac OS X? Are there any precautions that need to be taken? For me 0.15.0 compiles fine on OS X 10.7, but crashes right after trying to load an image with a segfault: Exception Type: EXC_BAD_ACCESS (SIGSEGV) Ex

[Qemu-devel] [RFC] 1.0 release schedule adjustment (spreading out RCs)

2011-10-06 Thread Anthony Liguori
Hi, I'm trying to map out the 1.1 release using the same formula as the 1.0 release. To make things work a bit better, I'd like to adjust the -rc schedule a bit. Namely: | 2011-11-01 | Freeze master |- | 2011-11-04 -> 2011-11-07 | Tag qemu-1.0-rc1 |- | 2011-11-11 -> 2011-11-14 | Tag qe

Re: [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused

2011-10-06 Thread Jan Kiszka
On 2011-10-06 16:27, Avi Kivity wrote: > On 10/05/2011 08:02 PM, Jan Kiszka wrote: >> > >> > Let's examine a concrete example: a user is debugging a guest, which >> > stops at a breakpoint. Meanwhile a live migration is going on, >> > involving internal stops. When the guest does manage to run

Re: [Qemu-devel] [PATCH] Set an invalid-bits mask for each SPE instructions

2011-10-06 Thread Fabien Chouteau
On 28/09/2011 17:54, Fabien Chouteau wrote: > SPE instructions are defined by pairs. Currently, the invalid-bits mask is set > for the first instruction, but the second one can have a different mask. > > example: > GEN_SPE(efdcmpeq,efdcfs, 0x17, 0x0B, 0x0060, 0x0018, > PPC_SPE_DO

[Qemu-devel] [PATCH V5] Add stdio char device on windows

2011-10-06 Thread Fabien Chouteau
Simple implementation of an stdio char device on Windows. Signed-off-by: Fabien Chouteau --- qemu-char.c | 227 ++- 1 files changed, 225 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 09d2309..b9381be 100644 --

Re: [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused

2011-10-06 Thread Avi Kivity
On 10/05/2011 08:02 PM, Jan Kiszka wrote: > > Let's examine a concrete example: a user is debugging a guest, which > stops at a breakpoint. Meanwhile a live migration is going on, > involving internal stops. When the guest does manage to run for a bit, > it runs out of disk space, generatin

Re: [Qemu-devel] [fedora-virt] balloon drivers missing in virtio-win-1.1.16.vfd

2011-10-06 Thread Andrew Cathrow
- Original Message - > From: "Justin M. Forbes" > To: "Andrew Cathrow" > Cc: v...@lists.fedoraproject.org, "Onkar N Mahajan" , > qemu-devel@nongnu.org, k...@vger.kernel.org > Sent: Thursday, October 6, 2011 9:35:44 AM > Subject: Re: [Qemu-devel] [fedora-virt] balloon drivers missing in

Re: [Qemu-devel] [fedora-virt] balloon drivers missing in virtio-win-1.1.16.vfd

2011-10-06 Thread Justin M. Forbes
On Thu, 2011-10-06 at 02:33 -0400, Andrew Cathrow wrote: > > > - Original Message - > > From: "Onkar N Mahajan" > > To: k...@vger.kernel.org, qemu-devel@nongnu.org > > Sent: Thursday, September 29, 2011 6:03:26 AM > > Subject: balloon drivers missing in virtio-win-1.1.16.vfd > > > > vir

[Qemu-devel] [PATCH 02/25] PPC: Fix via-cuda memory registration

2011-10-06 Thread Avi Kivity
From: Alexander Graf Commit 23c5e4ca (convert to memory API) broke the VIA Cuda emulation layer by not registering the IO structs. This patch registers them properly and thus makes -M g3beige and -M mac99 work again. Signed-off-by: Alexander Graf Signed-off-by: Avi Kivity --- hw/cuda.c | 2

[Qemu-devel] [PATCH 13/25] isa: Add isa_register_portio_list()

2011-10-06 Thread Avi Kivity
Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/isa-bus.c | 17 + hw/isa.h | 31 ++- 2 files changed, 47 insertions(+), 1 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index e9c1712..5d8ff84 100644 --- a/hw/isa-bus.c

[Qemu-devel] [PATCH 10/25] isa: Tidy support code for isabus_get_fw_dev_path

2011-10-06 Thread Avi Kivity
From: Richard Henderson The only user of ISADevice.ioports is isabus_get_fw_dev_path, and it only looks at the first entry of the array. Which suggests that this entire array+sort operation can be replaced by a simple minimum. Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw

[Qemu-devel] [PATCH 23/25] vmport: Convert to isa_register_ioport

2011-10-06 Thread Avi Kivity
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/vmport.c | 16 +--- 1 files changed, 13 insertions(+), 3 deletions(-) diff --git a/hw/vmport.c b/hw/vmport.c index c8aefaa..b5c6fa1 100644 --- a/hw/vmport.c +++ b/hw/vmport.c @@ -38,6 +38,7

[Qemu-devel] [PATCH] qemu-options: avoid #if in spicevmc texi help

2011-10-06 Thread Stefan Hajnoczi
Preprocessor directives cannot be used in STEXI/ETEXI sections since they are not passed through the preprocessor. The spicevmc chardev option help currently uses #if, which is included verbatim in the man page output. Fix this by simply stating that spicevmc chardevs are available only in builds

[Qemu-devel] [PATCH 07/25] hw/arm11mpcore: Clean up to avoid using sysbus_mmio_init_cb2

2011-10-06 Thread Avi Kivity
From: Peter Maydell Clean up the initialisation of the realview_mpcore device to avoid using sysbus_init_mmio_cb2(): we can pass through the MemoryRegion of the private arm11mpcore_priv device directly now. Signed-off-by: Peter Maydell Signed-off-by: Avi Kivity --- hw/arm11mpcore.c | 13 +--

[Qemu-devel] [PATCH 22/25] pc: Convert port92 to isa_register_ioport

2011-10-06 Thread Avi Kivity
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/pc.c | 16 +--- 1 files changed, 13 insertions(+), 3 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 203627d..ded4758 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -428,6 +428,7 @@ void pc_cmos_i

[Qemu-devel] qemu guest agent spins in poll/nanosleep(100ms) when nothing is listening on host

2011-10-06 Thread Daniel P. Berrange
I've been doing some experimentation with the QEMU guest agent and have noticed that when nothing is connected on the host side of the virtio serial channel, the guest agent just spins in a pool/sleep(100ms) loop. I know you'd ordinarily expect some mgmt app in the host to be listening to the other

[Qemu-devel] [PATCH 24/25] ide: Convert to isa_register_portio_list

2011-10-06 Thread Avi Kivity
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/ide/core.c | 30 +++--- hw/ide/internal.h |3 ++- hw/ide/isa.c |4 +--- hw/ide/piix.c |7 --- hw/ide/via.c |7 --- 5 files changed, 30 i

[Qemu-devel] [PATCH 18/25] ne2000: Convert to isa_register_ioport

2011-10-06 Thread Avi Kivity
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/ne2000-isa.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/hw/ne2000-isa.c b/hw/ne2000-isa.c index 756ed5c..11ffee7 100644 --- a/hw/ne2000-isa.c +++ b/hw/ne2000-isa.c @@ -68

[Qemu-devel] [PATCH 06/25] ppc405_boards: convert to memory API

2011-10-06 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/ppc405_boards.c | 84 +++- 1 files changed, 37 insertions(+), 47 deletions(-) diff --git a/hw/ppc405_boards.c b/hw/ppc405_boards.c index ca65ac3..b28bdda 100644 --- a/hw/ppc405_boards.c +++ b/hw/ppc405_boards.c @@

[Qemu-devel] [PATCH 04/25] petalogix_ml605: convert to memory API

2011-10-06 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/petalogix_ml605_mmu.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/petalogix_ml605_mmu.c b/hw/petalogix_ml605_mmu.c index 2a0f7fd..fb4ba29 100644 --- a/hw/petalogix_ml605_mmu.c +++ b/hw/petalogix_ml605_mmu.c @@ -149,8 +

[Qemu-devel] [PATCH 20/25] sb16: Convert to isa_register_portio_list

2011-10-06 Thread Avi Kivity
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/sb16.c | 32 +--- 1 files changed, 13 insertions(+), 19 deletions(-) diff --git a/hw/sb16.c b/hw/sb16.c index a76df1b..fe927e2 100644 --- a/hw/sb16.c +++ b/hw/sb16.c @@ -134

[Qemu-devel] [PATCH 09/25] ppc_newworld: convert to memory API

2011-10-06 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/ppc_newworld.c | 39 +-- 1 files changed, 17 insertions(+), 22 deletions(-) diff --git a/hw/ppc_newworld.c b/hw/ppc_newworld.c index b1cc3d7..946070c 100644 --- a/hw/ppc_newworld.c +++ b/hw/ppc_newworld.c @@ -83,12 +83,13 @@

[Qemu-devel] [PATCH 08/25] hw/versatile_pci: Expose multiple sysbus mmio regions

2011-10-06 Thread Avi Kivity
From: Peter Maydell Clean up versatile_pci to expose the various PCI mmio regions properly as separate mmio regions rather than as a single mmio which uses callbacks to map and unmap everything. Signed-off-by: Peter Maydell Signed-off-by: Avi Kivity --- hw/realview.c | 12 ++--

Re: [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused

2011-10-06 Thread Paolo Bonzini
On 10/05/2011 08:50 PM, Luiz Capitulino wrote: > > > I'm not exactly against the semantics you're proposing, but they don't > > > seem to fit today's qemu. > > > > Today's qemu is broken here. > > For me it's broken because it will abort() if you migrate a paused vm, for > you it see

[Qemu-devel] [PATCH 19/25] parallel: Convert to isa_register_portio_list

2011-10-06 Thread Avi Kivity
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/parallel.c | 47 --- 1 files changed, 28 insertions(+), 19 deletions(-) diff --git a/hw/parallel.c b/hw/parallel.c index ecbc8c3..8494d94 100644 --- a/hw/par

[Qemu-devel] [PATCH 14/25] fdc: Convert to isa_register_portio_list

2011-10-06 Thread Avi Kivity
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/fdc.c | 34 -- 1 files changed, 4 insertions(+), 30 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 0f1cee9..4b06e04 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -424,7 +

[Qemu-devel] [PATCH 25/25] isa: Remove isa_init_ioport_range and isa_init_ioport

2011-10-06 Thread Avi Kivity
From: Richard Henderson All users have been converted to either isa_register_ioport or isa_register_old_portio_list. Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/isa-bus.c | 19 +-- hw/isa.h |2 -- 2 files changed, 5 insertions(+), 16 deletions(-

[Qemu-devel] [PATCH 16/25] m48t59: Convert to isa_register_ioport

2011-10-06 Thread Avi Kivity
From: Richard Henderson The sysbus interface is as yet unconverted. Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/m48t59.c | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/m48t59.c b/hw/m48t59.c index 0cc361e..f318e67 100644 --- a/

[Qemu-devel] [PATCH 05/25] petalogix_s2adsp1800: convert to memory API

2011-10-06 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/petalogix_s3adsp1800_mmu.c | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) diff --git a/hw/petalogix_s3adsp1800_mmu.c b/hw/petalogix_s3adsp1800_mmu.c index 66fb96d..17da2fd 100644 --- a/hw/petalogix_s3adsp1800_mmu.c +++ b/hw/petalogix

[Qemu-devel] [PATCH 21/25] vga: Convert to isa_register_portio_list

2011-10-06 Thread Avi Kivity
From: Richard Henderson [jan: fix cut'n'paste errors] [avi: adjust pci variants not to use isa functions] Signed-off-by: Richard Henderson Signed-off-by: Jan Kiszka Signed-off-by: Avi Kivity --- hw/qxl.c|2 +- hw/vga-isa.c| 17 hw/vga-pci.c|2 +- hw/vga

[Qemu-devel] [PATCH 12/25] memory: Fix old portio word accesses

2011-10-06 Thread Avi Kivity
From: Jan Kiszka As we register old portio regions via ioport_register, we are also responsible for providing the word access wrapper. Signed-off-by: Jan Kiszka Signed-off-by: Avi Kivity --- memory.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/memory.c b

Re: [Qemu-devel] [RFC 0/2] target-arm: Adding Cortex-R4F support

2011-10-06 Thread Peter Maydell
On 6 October 2011 11:16, Andreas Färber wrote: > Am 02.10.2011 23:44, schrieb Peter Maydell: >> On 2 October 2011 19:56, Andreas Färber wrote: >>> 1) Currently, -cpu is used to look up a Main ID Register value and to base >>> feature decisions on that. This doesn't work for Cortex-R4 and Cortex-R

[Qemu-devel] [PATCH 11/25] Introduce PortioList

2011-10-06 Thread Avi Kivity
Add a type and methods for manipulating a list of disjoint I/O ports, used in some older hardware devices. Based on original patch by Richard Henderson. Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- Makefile.objs |2 +- Makefile.target |2 +- ioport.c| 108 +

[Qemu-devel] [PATCH 17/25] rtc: Convert to isa_register_ioport

2011-10-06 Thread Avi Kivity
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/mc146818rtc.c | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index feb3b25..2aaca2f 100644 --- a/hw/mc146818rtc.c +++ b/hw/mc14

[Qemu-devel] [PATCH 15/25] gus: Convert to isa_register_portio_list

2011-10-06 Thread Avi Kivity
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/gus.c | 39 +++ 1 files changed, 19 insertions(+), 20 deletions(-) diff --git a/hw/gus.c b/hw/gus.c index 37e543a..1532686 100644 --- a/hw/gus.c +++ b/hw/gus.c @@ -2

[Qemu-devel] [PATCH 03/25] palm: convert to memory API

2011-10-06 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/palm.c | 53 + 1 files changed, 25 insertions(+), 28 deletions(-) diff --git a/hw/palm.c b/hw/palm.c index d8f50e3..094bfde 100644 --- a/hw/palm.c +++ b/hw/palm.c @@ -54,16 +54,12 @@ static void static_write(v

[Qemu-devel] [PATCH 00/25] Memory API converions, batch 11

2011-10-06 Thread Avi Kivity
Review before push. I see that Alex's patch is also in the ppc queue, I'll drop it if it's merged before. Alexander Graf (1): PPC: Fix via-cuda memory registration Avi Kivity (7): palm: convert to memory API petalogix_ml605: convert to memory API petalogix_s2adsp1800: convert to memory A

[Qemu-devel] [PATCH 01/25] hw/lan9118.c: Convert to MemoryRegion

2011-10-06 Thread Avi Kivity
From: Peter Maydell Signed-off-by: Peter Maydell Signed-off-by: Avi Kivity --- hw/lan9118.c | 29 +++-- 1 files changed, 11 insertions(+), 18 deletions(-) diff --git a/hw/lan9118.c b/hw/lan9118.c index 73a8661..634b88e 100644 --- a/hw/lan9118.c +++ b/hw/lan9118.c @@

Re: [Qemu-devel] [RFC 0/2] target-arm: Adding Cortex-R4F support

2011-10-06 Thread Andreas Färber
Am 02.10.2011 23:44, schrieb Peter Maydell: > On 2 October 2011 19:56, Andreas Färber wrote: >> I've been looking into adding support for Cortex-R4F. > > Ooh, that will be the first R profile core. In particular the only > other non-M-profile PMSA core we support is the 946 which was a v5 > core,

Re: [Qemu-devel] [PATCH v2] tap: Add optional parameters to up/down script

2011-10-06 Thread Thomas Jung
On 30.09 2011 11:45, Sasha Levin wrote: > Subject: [PATCH v2] tap: Add optional parameters to up/down script > > This allows the user to add custom parameters to the up or down > scripts. > > Extra parameters are useful in more complex networking scenarios > where we would like to configure networ

[Qemu-devel] [PATCH 13/64] PPC: E500: Generate IRQ lines for many CPUs

2011-10-06 Thread Alexander Graf
Now that we can generate multiple envs for all our virtual CPUs, we also need to tell the MPIC that we have multiple CPUs connected and connect them all to the respective virtual interrupt lines. Signed-off-by: Alexander Graf --- hw/ppce500_mpc8544ds.c | 17 - 1 files changed,

[Qemu-devel] [PATCH 20/64] PPC: KVM: Remove kvmppc_read_host_property

2011-10-06 Thread Alexander Graf
We just got rid of the last user of kvmppc_read_host_property, so we can now safely remove it. Signed-off-by: Alexander Graf --- target-ppc/kvm_ppc.c | 35 --- target-ppc/kvm_ppc.h | 11 --- 2 files changed, 0 insertions(+), 46 deletions(-) diff --git

[Qemu-devel] [PATCH 28/64] device tree: give dt more size

2011-10-06 Thread Alexander Graf
We currently load a device tree blob and then just take its size x2 to account for modifications we do inside. While this is nice and great, it fails when we have a small device tree as blob and lots of nodes added in machine init code. So for now, just make it 20k bigger than it was before. We ma

[Qemu-devel] [PATCH 39/64] pseries: More complete WIMG validation in H_ENTER code

2011-10-06 Thread Alexander Graf
From: David Gibson Currently our implementation of the H_ENTER hypercall, which inserts a mapping in the hash page table assumes that only ordinary memory is ever mapped, and only permits mapping attribute bits accordingly (WIMG==0010). However, we intend to start adding emulated IO to the pseri

[Qemu-devel] [PATCH 29/64] MPC8544DS: Remove CPU nodes

2011-10-06 Thread Alexander Graf
We want to generate the CPU nodes in machine init code, so remove them from the device tree definition that we precompile. Signed-off-by: Alexander Graf --- pc-bios/mpc8544ds.dtb | Bin 2277 -> 2028 bytes pc-bios/mpc8544ds.dts | 12 2 files changed, 0 insertions(+), 12 deletions(

[Qemu-devel] [PATCH 26/64] device tree: add add_subnode command

2011-10-06 Thread Alexander Graf
We want to be able to create subnodes in our device tree, so export it through the qemu device tree abstraction framework. Signed-off-by: Alexander Graf --- device_tree.c | 24 device_tree.h |1 + 2 files changed, 25 insertions(+), 0 deletions(-) diff --git a/devi

[Qemu-devel] [PATCH 30/64] MPC8544DS: Generate CPU nodes on init

2011-10-06 Thread Alexander Graf
With this patch, we generate CPU nodes in the machine initialization, giving us the freedom to generate as many nodes as we want and as the machine supports, but only those. This is a first step towards a much cleaner device tree generation infrastructure, where we would not require precompiled dt

[Qemu-devel] [PATCH 37/64] pseries: Add a phandle to the xicp interrupt controller device tree node

2011-10-06 Thread Alexander Graf
From: David Gibson Future devices we will be adding to the pseries machine (e.g. PCI) will need nodes in the device tree which explicitly reference the top-level interrupt controller via interrupt-parent or interrupt-map properties. In order to do this, the interrupt controller node needs an ass

[Qemu-devel] [PATCH 54/64] ppc: move ADB stuff from ppc_mac.h to adb.h

2011-10-06 Thread Alexander Graf
From: Laurent Vivier Allow to use ADB in non-ppc macintosh Signed-off-by: Laurent Vivier Signed-off-by: Alexander Graf --- hw/adb.c |2 +- hw/adb.h | 67 + hw/cuda.c |1 + hw/ppc_mac.h | 42

[Qemu-devel] [PATCH 35/64] PPC: SPAPR: Use KVM function for time info

2011-10-06 Thread Alexander Graf
One of the things we can't fake on PPC is the timer speed. So we need to extract the frequency information from the host and put it back into the guest device tree. Luckily, we already have functions for that from the non-pseries targets, so all we need to do is to connect the dots and the guest s

[Qemu-devel] [PATCH 53/64] openpic: Unfold write_IRQreg

2011-10-06 Thread Alexander Graf
The helper function write_IRQreg was always called with a specific argument on the type of register to access. Inside the function we were simply doing a switch on that constant argument again. It's a lot easier to just unfold this into two separate functions and call each individually. Reported-b

[Qemu-devel] [PATCH 46/64] ppc: booke206: use MAV=2.0 TSIZE definition, fix 4G pages

2011-10-06 Thread Alexander Graf
From: Scott Wood This definition is backward compatible with MAV=1.0 as long as the guest does not set reserved bits in MAS1/MAS4. Also, fix the shift in booke206_tlb_to_page_size -- it's the base that should be able to hold a 4G page size, not the shift count. Signed-off-by: Scott Wood Signed

[Qemu-devel] [PATCH 57/64] KVM: Update kernel headers

2011-10-06 Thread Alexander Graf
Removes ABI-breaking HIOR parts - KVM patch to follow. Signed-off-by: Alexander Graf --- linux-headers/asm-powerpc/kvm.h |8 linux-headers/linux/kvm.h |1 - 2 files changed, 0 insertions(+), 9 deletions(-) diff --git a/linux-headers/asm-powerpc/kvm.h b/linux-headers/asm-p

[Qemu-devel] [PATCH 21/64] PPC: KVM: Add stubs for kvm helper functions

2011-10-06 Thread Alexander Graf
We have a bunch of helper functions that don't have any stubs for them in case we don't have CONFIG_KVM enabled. That didn't bite us so far, because gcc can optimize them out pretty well, but we should really provide them. Signed-off-by: Alexander Graf --- v1 -> v2: - use uint64_t for clock

[Qemu-devel] [PATCH 42/64] pseries: use macro for firmware filename

2011-10-06 Thread Alexander Graf
From: Nishanth Aravamudan For some time we've had a nicely defined macro with the filename for our firmware image. However we didn't actually use it in the place we're supposed to. This patch fixes it. Signed-off-by: Nishanth Aravamudan Signed-off-by: David Gibson Signed-off-by: Alexander Gr

[Qemu-devel] [PATCH 31/64] PPC: E500: Bump CPU count to 15

2011-10-06 Thread Alexander Graf
Now that we have everything in place, make the machine description aware of the fact that we can now handle 15 virtual CPUs! Signed-off-by: Alexander Graf --- v1 -> v2: - Max cpus is 15 because of MPIC --- hw/ppce500_mpc8544ds.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) di

[Qemu-devel] [PATCH 23/64] PPC: E500: Remove unneeded CPU nodes

2011-10-06 Thread Alexander Graf
We should only keep CPU nodes in the device tree around that we really have virtual CPUs for. So remove all superfluous entries that we just keep there in case someone wants to create a lot of vCPUs. Signed-off-by: Alexander Graf --- hw/ppce500_mpc8544ds.c |6 ++ 1 files changed, 6 inser

  1   2   >