[Qemu-devel] [PATCH] linux-user: fix memory leak in failure path

2011-09-27 Thread ajia
From: Alex Jia Haven't released memory of 'array' and 'host_mb' in failure paths. Signed-off-by: Alex Jia --- linux-user/syscall.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 7735008..922c2a0 100644 --- a/linux

[Qemu-devel] [PATCH] fix memory leak in aio_write_f

2011-09-27 Thread ajia
From: Alex Jia Haven't released memory of 'ctx' before return. Signed-off-by: Alex Jia --- qemu-io.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index e91af37..c45a413 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -1248,6 +1248,7 @@ static int aio

Re: [Qemu-devel] When the tlb_fill will be called from generated code?

2011-09-27 Thread Max Filippov
> > They are called from the places in TBs where > > tcg_gen_qemu_{ld,st}{8,16,32,64}{u,s} were injected. > > So you mean __stl_mmu/__ldl_mmu are called from the code cache. > > > > breakpoint on __stl_mmu/__ldl_mmu, but the backtrace can only show > > > something like, > > > > > > #0 鍮_stl_mm

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-27 Thread Paolo Bonzini
On 09/27/2011 11:23 PM, Anthony Liguori wrote: On 09/27/2011 11:39 AM, Paolo Bonzini wrote: On 09/27/2011 06:05 PM, Anthony Liguori wrote: Actually, for posix-aio, we can just switch to using g_idle_add(). g_idle_add() uses g_source_attach which is thread safe. g_idle_add() gives you a thread s

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-27 Thread Paolo Bonzini
On 09/27/2011 10:08 PM, ronnie sahlberg wrote: List, What remains before this patch can be accepted? Previous patch received good feedback and severa people indicated that they would find the feature useful for several use cases. Kevin is on vacation this week. :) Paolo

[Qemu-devel] [Bug 861141] [NEW] Installing libvirt-bin qemu slows host network

2011-09-27 Thread michael imelfort
Public bug reported: Installing the packages needed for qemu-kvm slows don network connectivity between two non-virtual machines. Uninstalling the packages does not restore the previous network speeds. Hardware: I have two identical machines (DELL poweredge R815), each with Broadcom NetXtreme II

Re: [Qemu-devel] [PATCH 1/2] gt64xxx.c: fix length modifier in DPRINTF format string

2011-09-27 Thread Ray Wang
Tested-by: Ray Wang On 9/26/2011 1:02 PM, Antony Pavlov wrote: The commit fc2bf44972349b078d8310466c3866615500e67f changed the type of val argument of the function gt64120_writel() from uint32_t to uint64_t, so we need to change the corresponding length modifier from "%x" to "%" PRIx64. Signed

[Qemu-devel] [PATCH 7/7] Enable fork and MIPS64 specific changes in mq_open syscall

2011-09-27 Thread khansa
From: Khansa Butt Signed-off-by: Khansa Butt --- configure|1 + linux-user/syscall.c | 11 +-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 5e45a43..8d39fda 100755 --- a/configure +++ b/configure @@ -3286,6 +3286,7 @@ cas

Re: [Qemu-devel] When the tlb_fill will be called from generated code?

2011-09-27 Thread 陳韋任
> > I am not sure when/where __stl_mmu/__ldl_mmu are used. I do set > > They are called from the places in TBs where > tcg_gen_qemu_{ld,st}{8,16,32,64}{u,s} were injected. So you mean __stl_mmu/__ldl_mmu are called from the code cache. > > breakpoint on __stl_mmu/__ldl_mmu, but the backtrace

[Qemu-devel] [RFC] potential risk for macro QTAILQ_INSERT_BEFORE

2011-09-27 Thread Wayne Xia
Hi, during my coding, I found macro a bit different from other QTAIL macros. QTAILQ_INSERT_AFTER was defined as: --- #define QTAILQ_INSERT_AFTER(head, listelm, elm, field) do { \ if (((elm)->field.tqe_next = (listelm)-

Re: [Qemu-devel] RFC [v2]: vfio / device assignment -- layout of device fd files

2011-09-27 Thread Alex Williamson
On Tue, 2011-09-27 at 16:28 -0500, Scott Wood wrote: > On 09/26/2011 07:45 PM, Alex Williamson wrote: > > On Mon, 2011-09-26 at 18:59 -0500, Scott Wood wrote: > >> On 09/26/2011 01:34 PM, Alex Williamson wrote: > >>> /* Reset the device */ > >>> #define VFIO_DEVICE_RESET _IO(, ,) >

Re: [Qemu-devel] When the tlb_fill will be called from generated code?

2011-09-27 Thread 陳韋任
> End of exec.c instantiates the code load functions (ld*_code), there > GETPC is defined as NULL. Otherwise GETPC works as usual, so it will > not return NULL. > > The memory access templates are a bit confusing. Op helpers use > softmmu_exec.h to instantiate {ld,st}*_{kernel,user,etc} functions.

Re: [Qemu-devel] [PATCH 04/11] hw/ac97: remove USE_MIXER code

2011-09-27 Thread Wayne Gao
On Wed, 2011-09-28 at 03:25 +0200, Marc-André Lureau wrote: > Hi Wayne > > On Mon, Sep 26, 2011 at 4:34 AM, wenyi wrote: > > # git apply ac97-patch > > fatal: corrupt patch at line 10 > > > > Do I miss other dependent patches for the patch to apply it to the > > code? > > They should apply on to

Re: [Qemu-devel] virtqueue corruption in emulation mode?

2011-09-27 Thread Sinha, Ani
On Sep 27, 2011, at 12:17 AM, Stefan Hajnoczi wrote: > On Mon, Sep 26, 2011 at 07:16:56PM -0500, Sinha, Ani wrote: >> I am using the virtqueue (virtqueue_pop, virtqueue_push etc) in the emulated >> mode (non-kvm mode) from an IO thread (a separate thread different from main >> QEMU thread). Wha

Re: [Qemu-devel] [PATCH 04/11] hw/ac97: remove USE_MIXER code

2011-09-27 Thread Marc-André Lureau
Hi Wayne On Mon, Sep 26, 2011 at 4:34 AM, wenyi wrote: > # git apply ac97-patch > fatal: corrupt patch at line 10 > > Do I miss other dependent patches for the patch to apply it to the > code? They should apply on top of current master. I just tried again. How did you save the patches? You shou

Re: [Qemu-devel] Hang when using 9p mounts after last Seabios update

2011-09-27 Thread Kevin O'Connor
On Thu, Sep 22, 2011 at 12:45:11PM +0100, Daniel P. Berrange wrote: > I'm doing some experimentation with application sandboxing and running > QEMU with the following command line: > > exec $QEMU \ > -m 64 \ > -nographic \ > -nodefconfig \ > -nodefaults \ > -kernel ./kernel-2

[Qemu-devel] Qemu varying performance

2011-09-27 Thread Torbjorn Granlund
Running Debian's vmlinux-2.6.32-5-4kc-malta under qemu-system-mips works very well--the system is fast, and when it is idle the qemu-system-mips process on the host system consumes insignificant CPU. (The same is true for qemu-system-mipsel, using the correesponding 'el' Debian kernel.) But runni

Re: [Qemu-devel] How to run realview-pbx-a9 image in qemu

2011-09-27 Thread Xiao Jiang
loody wrote: hi dave: 2011/9/27 David Gilbert : On 27 September 2011 14:01, loody wrote: hi: Would you mind to let me know which configs you use to compile for a9 running on qemu? Kernel configs? I mostly use prebuilt kernels from the Linaro images. Dave

Re: [Qemu-devel] [PATCH] remove mpc8544ds.dtb

2011-09-27 Thread Scott Wood
On 09/24/2011 02:32 AM, Alexander Graf wrote: > > On 16.09.2011, at 21:05, Stuart Yoder wrote: > >> From: Stuart Yoder >> >> make install now compiles dtb > > It doesn't when you don't have dtb installed, breaking the e500 > target for build environments that don't have dtb. I don't think > tha

Re: [Qemu-devel] RFC [v2]: vfio / device assignment -- layout of device fd files

2011-09-27 Thread Scott Wood
On 09/26/2011 07:45 PM, Alex Williamson wrote: > On Mon, 2011-09-26 at 18:59 -0500, Scott Wood wrote: >> On 09/26/2011 01:34 PM, Alex Williamson wrote: >>> /* Reset the device */ >>> #define VFIO_DEVICE_RESET _IO(, ,) >> >> What generic way do we have to do this? We should probab

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-27 Thread Anthony Liguori
On 09/27/2011 11:39 AM, Paolo Bonzini wrote: On 09/27/2011 06:05 PM, Anthony Liguori wrote: Actually, for posix-aio, we can just switch to using g_idle_add(). g_idle_add() uses g_source_attach which is thread safe. g_idle_add() gives you a thread safe mechanism to defer a piece of work to the ma

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-27 Thread ronnie sahlberg
List, What remains before this patch can be accepted? Previous patch received good feedback and severa people indicated that they would find the feature useful for several use cases. regards ronnie sahlberg On Wed, Sep 21, 2011 at 7:52 PM, ronnie sahlberg wrote: > On Wed, Sep 21, 2011 at 7:45 P

[Qemu-devel] qemu-img: subformat=streamOptimized issue

2011-09-27 Thread Rich Wellum
Hi, Can anyone tell me what this error means? qemu-img convert -O vmdk ultra.iso ultra.vmdk -o subformat=streamOptimized VMDK: can't write to allocated cluster for streamOptimized qemu-img: error while writing sector 21247: Input/output error Thanks, ||Rich

Re: [Qemu-devel] [FYI] Soft feature freeze for 1.0 is 10/15 (three weeks away)

2011-09-27 Thread Blue Swirl
On Tue, Sep 27, 2011 at 4:44 PM, Avi Kivity wrote: > On 09/27/2011 07:39 PM, Blue Swirl wrote: >> >> > >> >  Well, it's not that easy.  As the other mapping is part of an ordinary >> > BAR, >> >  you need to setup the device (at least PCI_COMMAND and >> > PCI_BASE_ADDRESS_0) >> >  so it responds t

Re: [Qemu-devel] [PATCH 24/58] PPC: E500: Add PV spinning code

2011-09-27 Thread Blue Swirl
On Tue, Sep 27, 2011 at 5:23 PM, Alexander Graf wrote: > > On 27.09.2011, at 19:20, Blue Swirl wrote: > >> On Tue, Sep 27, 2011 at 5:03 PM, Alexander Graf wrote: >>> >>> On 27.09.2011, at 18:53, Blue Swirl wrote: >>> On Tue, Sep 27, 2011 at 3:59 PM, Alexander Graf wrote: > > On 27.0

Re: [Qemu-devel] [PATCH V10 5/5] Add a TPM Passthrough backend driver implementation

2011-09-27 Thread Stefan Berger
On 09/27/2011 02:07 PM, Michael S. Tsirkin wrote: On Tue, Sep 27, 2011 at 01:38:52PM -0400, Stefan Berger wrote: On 09/27/2011 01:13 PM, Michael S. Tsirkin wrote: On Tue, Sep 27, 2011 at 10:50:48AM -0400, Stefan Berger wrote: +Since the host's firmware (BIOS/UEFI) has already initialized the T

Re: [Qemu-devel] [PATCH 24/58] PPC: E500: Add PV spinning code

2011-09-27 Thread Blue Swirl
On Tue, Sep 27, 2011 at 5:58 PM, Scott Wood wrote: > On 09/27/2011 12:03 PM, Alexander Graf wrote: >> On 27.09.2011, at 18:53, Blue Swirl wrote: >>> On Tue, Sep 27, 2011 at 3:59 PM, Alexander Graf wrote: On 27.09.2011, at 17:50, Blue Swirl wrote: > On Mon, Sep 26, 2011 at 11:19 PM, Scott

Re: [Qemu-devel] [PATCH v3 0/6]: block: Add I/O status support

2011-09-27 Thread Markus Armbruster
Luiz Capitulino writes: > This series adds support to the block layer to keep track of devices' > I/O status. That information is also made available in QMP and HMP. > > The goal here is to allow management applications that miss the > BLOCK_IO_ERROR event to able to query the VM to determine if

Re: [Qemu-devel] [PATCH V10 5/5] Add a TPM Passthrough backend driver implementation

2011-09-27 Thread Michael S. Tsirkin
On Tue, Sep 27, 2011 at 01:38:52PM -0400, Stefan Berger wrote: > On 09/27/2011 01:13 PM, Michael S. Tsirkin wrote: > >On Tue, Sep 27, 2011 at 10:50:48AM -0400, Stefan Berger wrote: > >>+Since the host's firmware (BIOS/UEFI) has already initialized the TPM, > >>+the VM's firmware (BIOS/UEFI) will no

Re: [Qemu-devel] [PATCH 24/58] PPC: E500: Add PV spinning code

2011-09-27 Thread Scott Wood
On 09/27/2011 12:03 PM, Alexander Graf wrote: > On 27.09.2011, at 18:53, Blue Swirl wrote: >> On Tue, Sep 27, 2011 at 3:59 PM, Alexander Graf wrote: >>> On 27.09.2011, at 17:50, Blue Swirl wrote: On Mon, Sep 26, 2011 at 11:19 PM, Scott Wood wrote: > I think the current approach is

Re: [Qemu-devel] Using iPXE with older qemu releases?

2011-09-27 Thread Kenton Cabiness
Stefan, On 9/27/2011 2:23 AM, Stefan Hajnoczi wrote: On Mon, Sep 26, 2011 at 02:22:21PM -0500, Kenton Cabiness wrote: Is there a way to point an older qemu release (currently running qemu-kvm-0.12.1.2-2.16) to iPXE products? We have built iPXE and installed the files and tested by changing the

Re: [Qemu-devel] [PATCH V10 5/5] Add a TPM Passthrough backend driver implementation

2011-09-27 Thread Stefan Berger
On 09/27/2011 01:13 PM, Michael S. Tsirkin wrote: On Tue, Sep 27, 2011 at 10:50:48AM -0400, Stefan Berger wrote: +Since the host's firmware (BIOS/UEFI) has already initialized the TPM, +the VM's firmware (BIOS/UEFI) will not be able to initialize the +TPM again and may therefore not show a TPM-s

[Qemu-devel] [PATCH 11/12] Revert to a hand-made select loop

2011-09-27 Thread Paolo Bonzini
This reverts commit c82dc29a9112f34e0a51cad9a412cf6d9d05dfb2 and 4d88a2ac8643265108ef1fb47ceee5d7b28e19f2. Signed-off-by: Paolo Bonzini --- iohandler.c | 54 +- 1 files changed, 1 insertions(+), 53 deletions(-) diff --git a/iohandler.c b/ioh

[Qemu-devel] [PATCH 08/12] qemu-timer: do not use RunState change handlers

2011-09-27 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qemu-timer.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 58926dd..f11a28d 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -273,7 +273,11 @@ static QEMUClock *qemu_new_clock(int type) void

[Qemu-devel] [PATCH 09/12] create main-loop.h

2011-09-27 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- async.c |1 + cpus.c|7 + cpus.h|1 - main-loop.h | 73 + qemu-char.h | 12 + qemu-common.h | 11 sysemu.h |3 +- vl.c |1

[Qemu-devel] [PATCH 06/12] qemu-timer: use atexit for quit_timers

2011-09-27 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qemu-timer.c | 15 --- qemu-timer.h |1 - vl.c |1 - 3 files changed, 8 insertions(+), 9 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index d8507e3..7fa81e1 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -840,6 +840,13 @@ s

[Qemu-devel] [PATCH 05/12] qemu-timer: do not refer to runstate_is_running()

2011-09-27 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- cpus.c |1 + qemu-timer.c |5 + 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/cpus.c b/cpus.c index 58d353f..751833d 100644 --- a/cpus.c +++ b/cpus.c @@ -1060,6 +1060,7 @@ void pause_all_vcpus(void) { CPUState *penv = first

Re: [Qemu-devel] [PATCH 24/58] PPC: E500: Add PV spinning code

2011-09-27 Thread Blue Swirl
On Tue, Sep 27, 2011 at 5:19 PM, Richard Henderson wrote: > On 09/27/2011 10:17 AM, Blue Swirl wrote: >> On Tue, Sep 27, 2011 at 5:01 PM, Richard Henderson wrote: >>> On 09/27/2011 09:53 AM, Blue Swirl wrote: >> So how would you emulate cache lines with line locking on KVM? The cache wou

Re: [Qemu-devel] [PATCH 24/58] PPC: E500: Add PV spinning code

2011-09-27 Thread Alexander Graf
On 27.09.2011, at 19:20, Blue Swirl wrote: > On Tue, Sep 27, 2011 at 5:03 PM, Alexander Graf wrote: >> >> On 27.09.2011, at 18:53, Blue Swirl wrote: >> >>> On Tue, Sep 27, 2011 at 3:59 PM, Alexander Graf wrote: On 27.09.2011, at 17:50, Blue Swirl wrote: > On Mon, Sep 26,

Re: [Qemu-devel] [PATCH 24/58] PPC: E500: Add PV spinning code

2011-09-27 Thread Blue Swirl
On Tue, Sep 27, 2011 at 5:03 PM, Alexander Graf wrote: > > On 27.09.2011, at 18:53, Blue Swirl wrote: > >> On Tue, Sep 27, 2011 at 3:59 PM, Alexander Graf wrote: >>> >>> On 27.09.2011, at 17:50, Blue Swirl wrote: >>> On Mon, Sep 26, 2011 at 11:19 PM, Scott Wood wrote: > On 09/24/2

Re: [Qemu-devel] [PATCH 24/58] PPC: E500: Add PV spinning code

2011-09-27 Thread Richard Henderson
On 09/27/2011 10:17 AM, Blue Swirl wrote: > On Tue, Sep 27, 2011 at 5:01 PM, Richard Henderson wrote: >> On 09/27/2011 09:53 AM, Blue Swirl wrote: > So how would you emulate cache lines with line locking on KVM? >>> The cache would be a MMIO device which registers to handle all memory >>> spac

Re: [Qemu-devel] [PATCH 24/58] PPC: E500: Add PV spinning code

2011-09-27 Thread Blue Swirl
On Tue, Sep 27, 2011 at 5:01 PM, Richard Henderson wrote: > On 09/27/2011 09:53 AM, Blue Swirl wrote: >>> > So how would you emulate cache lines with line locking on KVM? >> The cache would be a MMIO device which registers to handle all memory >> space. Configuring the cache controller changes how

[Qemu-devel] [PATCH 00/12] allow tools to use the QEMU main loop

2011-09-27 Thread Paolo Bonzini
This patch series makes the QEMU main loop usable out of the executable, and especially in tools and possibly unit tests. The series already starts using the refactored main loop in qemu-nbd. This is cleaner because it avoids introducing partial transitions to GIOChannel. Interfacing with the gl

[Qemu-devel] [PATCH 12/12] simplify main loop functions

2011-09-27 Thread Paolo Bonzini
Provide a clean example of how to use the main loop in the tools. Signed-off-by: Paolo Bonzini --- cpus.c |5 cpus.h |1 - vl.c | 80 +-- 3 files changed, 42 insertions(+), 44 deletions(-) diff --git a/cpus.c b/cpus.c

[Qemu-devel] [PATCH 03/12] qemu-timer: more clock functions

2011-09-27 Thread Paolo Bonzini
These will be used when moving icount accounting to cpus.c. Signed-off-by: Paolo Bonzini --- qemu-timer.c | 25 + qemu-timer.h |3 +++ 2 files changed, 28 insertions(+), 0 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index e2551f3..ebb5089 100644 --- a/qem

Re: [Qemu-devel] [PATCH V10 5/5] Add a TPM Passthrough backend driver implementation

2011-09-27 Thread Michael S. Tsirkin
On Tue, Sep 27, 2011 at 10:50:48AM -0400, Stefan Berger wrote: > +Since the host's firmware (BIOS/UEFI) has already initialized the TPM, > +the VM's firmware (BIOS/UEFI) will not be able to initialize the > +TPM again and may therefore not show a TPM-specific menu that would > +otherwise allow the

Re: [Qemu-devel] [PATCH v3] memory: simple memory tree printer

2011-09-27 Thread Blue Swirl
On Tue, Sep 27, 2011 at 12:35 PM, Jan Kiszka wrote: > On 2011-09-26 22:03, Blue Swirl wrote: >> Add a monitor command 'info mtree' to show the memory hierarchy >> much like /proc/iomem in Linux. >> >> Signed-off-by: Blue Swirl >> --- >> The alias addresses are unbiased (PPC): >> -fffe

[Qemu-devel] [PATCH 02/12] qemu-timer: move common code to qemu_rearm_alarm_timer

2011-09-27 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qemu-timer.c | 129 -- 1 files changed, 53 insertions(+), 76 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index acf7a15..e2551f3 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -153,7 +153,7 @@ str

Re: [Qemu-devel] When the tlb_fill will be called from generated code?

2011-09-27 Thread Blue Swirl
On Tue, Sep 27, 2011 at 11:02 AM, 陳韋任 wrote: > Hi, Jan > >> You can find the answer yourself: Load qemu into gdb, set a breakpoint >> on that function and let it run. If you want to catch only the retaddr >> == NULL case, make the breakpoint conditional. > >  Thanks for your tip. I see when retadd

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc/e500_pci: Fix an array overflow issue

2011-09-27 Thread Scott Wood
On 09/27/2011 12:01 PM, Alexander Graf wrote: > > On 27.09.2011, at 18:52, Scott Wood wrote: > >> On 09/27/2011 07:45 AM, Alexander Graf wrote: >>> So this is the main change, right? Why the -1? A guest could potentially >>> access pib[-1] using this, no? >> >> Not with the values of addr that l

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc/e500_pci: Fix an array overflow issue

2011-09-27 Thread Alexander Graf
On 27.09.2011, at 19:04, Richard Henderson wrote: > On 09/27/2011 10:01 AM, Alexander Graf wrote: >> 0xd >> 0xe >> 0xf >> >> ... and & 0x3 them >> >> 0x1 >> 0x2 >> 0x0 > > That's a remarkably different AND function... No, it's a typo. I typed % instead of & and didn't realize it. Bleks.

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc/e500_pci: Fix an array overflow issue

2011-09-27 Thread Richard Henderson
On 09/27/2011 10:01 AM, Alexander Graf wrote: > 0xd > 0xe > 0xf > > ... and & 0x3 them > > 0x1 > 0x2 > 0x0 That's a remarkably different AND function... r~

Re: [Qemu-devel] [PATCH 24/58] PPC: E500: Add PV spinning code

2011-09-27 Thread Alexander Graf
On 27.09.2011, at 18:53, Blue Swirl wrote: > On Tue, Sep 27, 2011 at 3:59 PM, Alexander Graf wrote: >> >> On 27.09.2011, at 17:50, Blue Swirl wrote: >> >>> On Mon, Sep 26, 2011 at 11:19 PM, Scott Wood >>> wrote: On 09/24/2011 05:00 AM, Alexander Graf wrote: > On 24.09.2011, at 10:44

[Qemu-devel] [PATCH 10/12] create main-loop.c

2011-09-27 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs|2 +- cpus.c | 188 + cpus.h |1 + main-loop.c | 494 ++ os-win32.c | 123 -- qemu-os-posix.h |4 - qemu-os-win32.h

Re: [Qemu-devel] [PATCH 24/58] PPC: E500: Add PV spinning code

2011-09-27 Thread Richard Henderson
On 09/27/2011 09:53 AM, Blue Swirl wrote: >> > So how would you emulate cache lines with line locking on KVM? > The cache would be a MMIO device which registers to handle all memory > space. Configuring the cache controller changes how the device > operates. Put this device between CPU and memory a

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc/e500_pci: Fix an array overflow issue

2011-09-27 Thread Alexander Graf
On 27.09.2011, at 18:52, Scott Wood wrote: > On 09/27/2011 07:45 AM, Alexander Graf wrote: >> On 27.09.2011, at 10:17, Liu Yu wrote: >>> --- >>> hw/ppce500_pci.c | 26 -- >>> 1 files changed, 16 insertions(+), 10 deletions(-) >>> >>> diff --git a/hw/ppce500_pci.c b/hw/pp

[Qemu-devel] [PATCH 07/12] qemu-timer: move more stuff out of qemu-timer.c

2011-09-27 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qemu-timer.c | 35 --- qemu-timer.h |2 ++ savevm.c | 25 + vl.c |1 + 4 files changed, 32 insertions(+), 31 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 7fa81e1..58926

Re: [Qemu-devel] [PATCH 24/58] PPC: E500: Add PV spinning code

2011-09-27 Thread Blue Swirl
On Tue, Sep 27, 2011 at 3:59 PM, Alexander Graf wrote: > > On 27.09.2011, at 17:50, Blue Swirl wrote: > >> On Mon, Sep 26, 2011 at 11:19 PM, Scott Wood wrote: >>> On 09/24/2011 05:00 AM, Alexander Graf wrote: On 24.09.2011, at 10:44, Blue Swirl wrote: > On Sat, Sep 24, 2011 at 8:03 AM, A

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc/e500_pci: Fix an array overflow issue

2011-09-27 Thread Scott Wood
On 09/27/2011 07:45 AM, Alexander Graf wrote: > On 27.09.2011, at 10:17, Liu Yu wrote: >> --- >> hw/ppce500_pci.c | 26 -- >> 1 files changed, 16 insertions(+), 10 deletions(-) >> >> diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c >> index 2db365d..3e24e85 100644 >> --- a/

[Qemu-devel] [PATCH 04/12] qemu-timer: move icount to cpus.c

2011-09-27 Thread Paolo Bonzini
None of this is needed by tools, and most of it can even be made static inside cpus.c. Signed-off-by: Paolo Bonzini --- cpus.c| 296 + exec-all.h| 14 +++ exec.c|7 -- qemu-common.h |4 + qemu-timer.c | 279

Re: [Qemu-devel] [FYI] Soft feature freeze for 1.0 is 10/15 (three weeks away)

2011-09-27 Thread Avi Kivity
On 09/27/2011 07:39 PM, Blue Swirl wrote: > > Well, it's not that easy. As the other mapping is part of an ordinary BAR, > you need to setup the device (at least PCI_COMMAND and PCI_BASE_ADDRESS_0) > so it responds to memory requests, and also enable the bridge. > > We could hack it by havin

Re: [Qemu-devel] [FYI] Soft feature freeze for 1.0 is 10/15 (three weeks away)

2011-09-27 Thread Blue Swirl
On Tue, Sep 27, 2011 at 8:57 AM, Avi Kivity wrote: > On 09/27/2011 11:33 AM, Avi Kivity wrote: >> >> On 09/26/2011 09:07 PM, Blue Swirl wrote: >>> >>> >>  The default address is used for early serial printk in OpenBIOS, so >>> >> it >>> >>  should still work. >>> > >>> >  Ok, so drop the extra map

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-27 Thread Paolo Bonzini
On 09/27/2011 06:05 PM, Anthony Liguori wrote: Actually, for posix-aio, we can just switch to using g_idle_add(). g_idle_add() uses g_source_attach which is thread safe. g_idle_add() gives you a thread safe mechanism to defer a piece of work to the main loop which is really what we want here.

Re: [Qemu-devel] [PATCH 1/5] qemu-char: make qemu_chr_event public

2011-09-27 Thread Hans de Goede
Hi, On 08/12/2011 03:57 PM, Anthony Liguori wrote: On 08/11/2011 07:25 AM, Hans de Goede wrote: Make qemu_chr_event public so that it can be used by chardev code which lives outside of qemu-char.c Normally, qemu_chr_generic_open() would be used to do this. Of course, there is no generic_clos

[Qemu-devel] [PATCH 01/12] qemu-timer: remove active_timers array

2011-09-27 Thread Paolo Bonzini
Embed the list in the QEMUClock instead. Signed-off-by: Paolo Bonzini --- qemu-timer.c | 59 +++-- 1 files changed, 28 insertions(+), 31 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index ad1fc8b..acf7a15 100644 --- a/qemu-timer.c +

Re: [Qemu-devel] [Xen-devel] Re: Try to integrate the Xen PCI Passthrough code into linux: have pci_regs conflict with libpci.

2011-09-27 Thread Anthony PERARD
On Tue, Sep 27, 2011 at 16:20, Michael S. Tsirkin wrote: > On Tue, Sep 27, 2011 at 04:02:23PM +0100, Anthony PERARD wrote: >> Hi, >> >> I'm trying to integrate the Xen PCI Passthrough code into Qemu. But we >> use libpci, and it's not friendly with pci_regs.h. >> >> So can I replace pci_regs by th

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-27 Thread Anthony Liguori
On 09/27/2011 10:28 AM, Jan Kiszka wrote: On 2011-09-27 17:17, Stefan Hajnoczi wrote: On Tue, Sep 27, 2011 at 3:26 PM, Avi Kivity wrote: Has no business in hw/. Signed-off-by: Avi Kivity --- hw/event_notifier.c => event_notifier.c |1 - hw/event_notifier.h => event_notifier.h |0

[Qemu-devel] [PATCH] Move filedescriptor parsing code from net.c into qemu_parse_fd()

2011-09-27 Thread Stefan Berger
Move the parsing of a filedescriptor into a common function qemu_parse_fd(). Have the code in net.c call this function. Signed-off-by: Stefan Berger --- net.c |8 ++-- qemu-char.c | 12 qemu-char.h |2 ++ 3 files changed, 16 insertions(+), 6 deletions(-) Index:

Re: [Qemu-devel] [PATCH 24/58] PPC: E500: Add PV spinning code

2011-09-27 Thread Alexander Graf
On 27.09.2011, at 17:50, Blue Swirl wrote: > On Mon, Sep 26, 2011 at 11:19 PM, Scott Wood wrote: >> On 09/24/2011 05:00 AM, Alexander Graf wrote: >>> On 24.09.2011, at 10:44, Blue Swirl wrote: On Sat, Sep 24, 2011 at 8:03 AM, Alexander Graf wrote: > On 24.09.2011, at 09:41, Blue Swirl

Re: [Qemu-devel] [PATCH 24/58] PPC: E500: Add PV spinning code

2011-09-27 Thread Blue Swirl
On Mon, Sep 26, 2011 at 11:19 PM, Scott Wood wrote: > On 09/24/2011 05:00 AM, Alexander Graf wrote: >> On 24.09.2011, at 10:44, Blue Swirl wrote: >>> On Sat, Sep 24, 2011 at 8:03 AM, Alexander Graf wrote: On 24.09.2011, at 09:41, Blue Swirl wrote: > On Mon, Sep 19, 2011 at 4:12 PM, Scott

[Qemu-devel] [PATCH V2] Add stdio char device on windows

2011-09-27 Thread Fabien Chouteau
Simple implementation of an stdio char device on Windows. Signed-off-by: Fabien Chouteau --- qemu-char.c | 199 ++- 1 files changed, 197 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 09d2309..46acf1c 100644 --

Re: [Qemu-devel] [PATCH 2/2] e1000: CTRL.RST emulation

2011-09-27 Thread Andy Gospodarek
On Tue, Sep 27, 2011 at 8:58 AM, Michael S. Tsirkin wrote: > e1000 spec says CTRL.RST write should have the same effect > as bus reset, except that is preserves PCI Config. > Reset device registers and interrupts. > > Fix suggested by Andy Gospodarek > Similar fix proposed by Anthony PERARD > >

Re: [Qemu-devel] [PATCH 0/6] Alpha system emulation, v11

2011-09-27 Thread Richard Henderson
Ping. r~ On 09/22/2011 09:04 AM, Edgar E. Iglesias wrote: > On Thu, Sep 22, 2011 at 08:30:43AM -0700, Richard Henderson wrote: >> Changes v10 - v11: >> * Fixes for icount, based on feedback from Peter and Edgar. >> * Re-based against master. >> >> The patch set is also available at >> >> g

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-27 Thread Jan Kiszka
On 2011-09-27 17:17, Stefan Hajnoczi wrote: > On Tue, Sep 27, 2011 at 3:26 PM, Avi Kivity wrote: >> Has no business in hw/. >> >> Signed-off-by: Avi Kivity >> --- >> hw/event_notifier.c => event_notifier.c |1 - >> hw/event_notifier.h => event_notifier.h |0 >> 2 files changed, 0 inserti

Re: [Qemu-devel] [PATCH] target-i386: Remove redundant word mask in port out instructions

2011-09-27 Thread Richard Henderson
On 09/26/2011 10:20 AM, Jan Kiszka wrote: > T0 was already masked to 16 bits when loading it. > > Signed-off-by: Jan Kiszka Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] Try to integrate the Xen PCI Passthrough code into linux: have pci_regs conflict with libpci.

2011-09-27 Thread Michael S. Tsirkin
On Tue, Sep 27, 2011 at 04:02:23PM +0100, Anthony PERARD wrote: > Hi, > > I'm trying to integrate the Xen PCI Passthrough code into Qemu. But we > use libpci, and it's not friendly with pci_regs.h. > > So can I replace pci_regs by the libpci one? I prefer sticking to pci_regs in linux. > Should

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-27 Thread Stefan Hajnoczi
On Tue, Sep 27, 2011 at 3:26 PM, Avi Kivity wrote: > Has no business in hw/. > > Signed-off-by: Avi Kivity > --- >  hw/event_notifier.c => event_notifier.c |    1 - >  hw/event_notifier.h => event_notifier.h |    0 >  2 files changed, 0 insertions(+), 1 deletions(-) >  rename hw/event_notifier.c

Re: [Qemu-devel] [PATCH 5/7] target-mips:Support for Cavium specific instructions

2011-09-27 Thread Richard Henderson
On 09/26/2011 09:17 PM, kha...@kics.edu.pk wrote: > +switch (opc) { > +case OPC_SEQI: > +tcg_gen_setcondi_tl(TCG_COND_LT, cpu_gpr[rt], t0, 1); > +opn = "seqi"; > +break; > +case OPC_SNEI: > +tcg_gen_setcondi_tl(TCG_COND_GT, cpu_gpr[rt], t0, 0); > +

[Qemu-devel] Try to integrate the Xen PCI Passthrough code into linux: have pci_regs conflict with libpci.

2011-09-27 Thread Anthony PERARD
Hi, I'm trying to integrate the Xen PCI Passthrough code into Qemu. But we use libpci, and it's not friendly with pci_regs.h. So can I replace pci_regs by the libpci one? Should I avoid to include both? (by having a "hook" the libpci functions) Or do you have any other suggestions? Thanks, Regar

Re: [Qemu-devel] [PATCH] Use qemu_eventfd for POSIX AIO

2011-09-27 Thread Jan Kiszka
On 2011-09-27 16:54, Avi Kivity wrote: > On 09/27/2011 05:50 PM, Jan Kiszka wrote: >> On 2011-09-27 16:48, Avi Kivity wrote: >>> On 09/27/2011 05:45 PM, Jan Kiszka wrote: I don't disagree that there is still room for improving the existing interface, generalizing to qemu_event. But tha

Re: [Qemu-devel] [PATCH] Use qemu_eventfd for POSIX AIO

2011-09-27 Thread Anthony Liguori
On 09/27/2011 09:54 AM, Avi Kivity wrote: On 09/27/2011 05:50 PM, Jan Kiszka wrote: On 2011-09-27 16:48, Avi Kivity wrote: > On 09/27/2011 05:45 PM, Jan Kiszka wrote: >> I don't disagree that there is still room for improving the existing >> interface, generalizing to qemu_event. But that's not

Re: [Qemu-devel] [PATCH] Use qemu_eventfd for POSIX AIO

2011-09-27 Thread Avi Kivity
On 09/27/2011 05:50 PM, Jan Kiszka wrote: On 2011-09-27 16:48, Avi Kivity wrote: > On 09/27/2011 05:45 PM, Jan Kiszka wrote: >> I don't disagree that there is still room for improving the existing >> interface, generalizing to qemu_event. But that's not in the scope of >> this patch. >> > >

[Qemu-devel] [PATCH V10 0/5] Qemu Trusted Platform Module (TPM) integration

2011-09-27 Thread Stefan Berger
The following series of patches adds TPM (Trusted Platform Module) support to Qemu. An emulator for the TIS (TPM Interface Spec) interface is added that provides the basis for accessing a 'backend' implementing the actual TPM functionality. The TIS emulator serves as a 'frontend' enabling for examp

[Qemu-devel] [PATCH V10 5/5] Add a TPM Passthrough backend driver implementation

2011-09-27 Thread Stefan Berger
>From Andreas Niederl's original posting with adaptations where necessary: This patch is based of off version 9 of Stefan Berger's patch series "Qemu Trusted Platform Module (TPM) integration" and adds a new backend driver for it. This patch adds a passthrough backend driver for passing command

[Qemu-devel] [PATCH V10 1/5] Support for TPM command line options

2011-09-27 Thread Stefan Berger
This patch adds support for TPM command line options. The command line options supported here are ./qemu-... -tpmdev passthrough,path=,id= -device tpm-tis,tpmdev= and ./qemu-... -tpmdev ? where the latter works similar to -soundhw ? and shows a list of available TPM backends (for exa

[Qemu-devel] [PATCH V10 4/5] Build the TPM frontend code

2011-09-27 Thread Stefan Berger
Build the TPM frontend code that has been added so far. Signed-off-by: Stefan Berger --- Makefile.target |1 + configure | 11 +++ 2 files changed, 12 insertions(+) Index: qemu-git.pt/Makefile.target === --- qe

[Qemu-devel] [PATCH V10 3/5] Add a debug register

2011-09-27 Thread Stefan Berger
This patch uses the possibility to add a vendor-specific register and adds a debug register useful for dumping the TIS's internal state. This register is only active in a debug build (#define DEBUG_TIS). v9: - prefixing all function with tpm_tis_ and all constants with TPM_TIS_ v3: - all output

[Qemu-devel] [PATCH V10 2/5] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2011-09-27 Thread Stefan Berger
This patch adds the main code of the TPM frontend driver, the TPM TIS interface, to Qemu. The code is largely based on the previous implementation for Xen but has been significantly extended to meet the standard's requirements, such as the support for changing of localities and all the functionalit

Re: [Qemu-devel] [PATCH] Use qemu_eventfd for POSIX AIO

2011-09-27 Thread Jan Kiszka
On 2011-09-27 16:48, Avi Kivity wrote: > On 09/27/2011 05:45 PM, Jan Kiszka wrote: >> I don't disagree that there is still room for improving the existing >> interface, generalizing to qemu_event. But that's not in the scope of >> this patch. >> > > Why not use event_notify.c? It doesn't solve th

Re: [Qemu-devel] [PATCH] Use qemu_eventfd for POSIX AIO

2011-09-27 Thread Avi Kivity
On 09/27/2011 05:45 PM, Jan Kiszka wrote: I don't disagree that there is still room for improving the existing interface, generalizing to qemu_event. But that's not in the scope of this patch. Why not use event_notify.c? -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCH] Use qemu_eventfd for POSIX AIO

2011-09-27 Thread Jan Kiszka
On 2011-09-27 16:42, Avi Kivity wrote: > On 09/27/2011 05:36 PM, Jan Kiszka wrote: >> On 2011-09-27 16:34, Avi Kivity wrote: >>> On 09/27/2011 05:29 PM, Jan Kiszka wrote: > > Moreover, the eventfd() counter is not lossy (practically speaking) > whereas if > you use pipe() as a

Re: [Qemu-devel] [PATCH] Use qemu_eventfd for POSIX AIO

2011-09-27 Thread Avi Kivity
On 09/27/2011 05:36 PM, Jan Kiszka wrote: On 2011-09-27 16:34, Avi Kivity wrote: > On 09/27/2011 05:29 PM, Jan Kiszka wrote: >>> >>> Moreover, the eventfd() counter is not lossy (practically speaking) whereas if >>> you use pipe() as a counter, it will be lossy in practice. >>> >>> This i

Re: [Qemu-devel] [PATCH] Use qemu_eventfd for POSIX AIO

2011-09-27 Thread Paolo Bonzini
On 09/27/2011 04:07 PM, Anthony Liguori wrote: I think it's a bit dangerous to implement eventfd() in terms of pipe(). You don't expect to handle EAGAIN with eventfd() whereas you have to handle it with pipe(). Moreover, the eventfd() counter is not lossy (practically speaking) whereas if you

Re: [Qemu-devel] [PATCH] Use qemu_eventfd for POSIX AIO

2011-09-27 Thread Anthony Liguori
On 09/27/2011 09:22 AM, Jan Kiszka wrote: On 2011-09-27 16:19, Anthony Liguori wrote: On 09/27/2011 09:11 AM, Avi Kivity wrote: On 09/27/2011 05:07 PM, Anthony Liguori wrote: You don't expect to handle EAGAIN with eventfd() whereas you have to handle it with pipe(). Moreover, the eventfd() c

Re: [Qemu-devel] [PATCH] Use qemu_eventfd for POSIX AIO

2011-09-27 Thread Jan Kiszka
On 2011-09-27 16:34, Avi Kivity wrote: > On 09/27/2011 05:29 PM, Jan Kiszka wrote: >>> >>> Moreover, the eventfd() counter is not lossy (practically speaking) >>> whereas if >>> you use pipe() as a counter, it will be lossy in practice. >>> >>> This is why posix aio uses pipe() and not eventfd(

Re: [Qemu-devel] [PATCH] Use qemu_eventfd for POSIX AIO

2011-09-27 Thread Anthony Liguori
On 09/27/2011 09:29 AM, Jan Kiszka wrote: On 2011-09-27 16:07, Anthony Liguori wrote: On 09/27/2011 08:56 AM, Jan Kiszka wrote: Move qemu_eventfd unmodified to oslib-posix and use it for signaling POSIX AIO completions. If native eventfd suport is available, this avoids multiple read accesses t

Re: [Qemu-devel] [PATCH] Use qemu_eventfd for POSIX AIO

2011-09-27 Thread Avi Kivity
On 09/27/2011 05:29 PM, Jan Kiszka wrote: > > Moreover, the eventfd() counter is not lossy (practically speaking) whereas if > you use pipe() as a counter, it will be lossy in practice. > > This is why posix aio uses pipe() and not eventfd(). I don't get this yet. eventfd is lossy by default

Re: [Qemu-devel] [PATCH qemu] e1000: CTRL.RST emulation

2011-09-27 Thread Anthony Liguori
On 09/27/2011 06:50 AM, Peter Maydell wrote: On 27 September 2011 12:25, Michael S. Tsirkin wrote: e1000 spec says CTRL.RST write should have the same effect as bus reset, except that is preserves PCI Config. Reset device registers and interrupts. Fix suggested by Andy Gospodarek Doesn't thi

Re: [Qemu-devel] [PATCH] Use qemu_eventfd for POSIX AIO

2011-09-27 Thread Jan Kiszka
On 2011-09-27 16:07, Anthony Liguori wrote: > On 09/27/2011 08:56 AM, Jan Kiszka wrote: >> Move qemu_eventfd unmodified to oslib-posix and use it for signaling >> POSIX AIO completions. If native eventfd suport is available, this >> avoids multiple read accesses to drain multiple pending signals. A

[Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-27 Thread Avi Kivity
Has no business in hw/. Signed-off-by: Avi Kivity --- hw/event_notifier.c => event_notifier.c |1 - hw/event_notifier.h => event_notifier.h |0 2 files changed, 0 insertions(+), 1 deletions(-) rename hw/event_notifier.c => event_notifier.c (98%) rename hw/event_notifier.h => event_noti

  1   2   >