Re: [Qemu-devel] [PATCH 04/14] qdev: take ownership of id pointer

2011-09-19 Thread Gerd Hoffmann
On 09/19/11 18:27, Anthony Liguori wrote: On 09/19/2011 02:34 AM, Gerd Hoffmann wrote: FYI: Keeping the pointer to the QemuOpts has one more reason: It will free the QemuOpts on hot-unplug, which is needed to free the id from QemuOpts point of view, which in turn allows to re-use the id when hot

[Qemu-devel] [PATCH v2 10/12] isa: give bus to isa_create() methods

2011-09-19 Thread Hervé Poussineau
Bus argument is mandatory, and allows to create a device on specified ISA bus. Signed-off-by: Hervé Poussineau --- hw/cs4231a.c |2 +- hw/fdc.h |4 ++-- hw/gus.c |2 +- hw/ide.h |2 +- hw/ide/isa.c |4 ++-- hw/isa-bus.c | 16 +

[Qemu-devel] [PATCH v2 09/12] isa: remove unused parameter to isa_bus_bridge_init()

2011-09-19 Thread Hervé Poussineau
Remove code which is now dead Signed-off-by: Hervé Poussineau --- hw/isa-bus.c | 43 +-- hw/isa.h |2 +- hw/mips_jazz.c |2 +- hw/mips_r4k.c |2 +- hw/pc_piix.c |2 +- hw/ppc_prep.c |2 +- 6 files changed, 10 insertions(+)

[Qemu-devel] [PATCH v2 11/12] isa: give bus to isa_get_irq() and isa_bus_irqs()

2011-09-19 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/i8254.c |2 +- hw/ide.h | 12 hw/ide/piix.c | 30 ++ hw/ide/via.c | 18 ++ hw/isa-bus.c | 14 +++--- hw/isa.h |9 +++-- hw/mips

[Qemu-devel] [PATCH v2 08/12] malta: improve bus implementation of PIIX4 bridge

2011-09-19 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/mips_malta.c |3 +-- hw/pc.h |2 +- hw/piix4.c | 23 +-- 3 files changed, 23 insertions(+), 5 deletions(-) diff --git a/hw/mips_malta.c b/hw/mips_malta.c index e7cdf20..65e5915 100644 --- a/hw/mips_malta.c +++ b/h

[Qemu-devel] [PATCH v2 06/12] fulong2e: move pic initialization + ISA bus creation to south bridge

2011-09-19 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/mips_fulong2e.c |9 ++--- hw/vt82c686.c | 24 ++-- hw/vt82c686.h |2 +- 3 files changed, 25 insertions(+), 10 deletions(-) diff --git a/hw/mips_fulong2e.c b/hw/mips_fulong2e.c index f52b8c5..3034a9c 100644 --- a/

[Qemu-devel] [PATCH v2 03/12] isa: implement isa_address_space() as a method of ISA bus

2011-09-19 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/isa-bridge.c |6 ++ hw/isa-bus.c| 13 - hw/isa.h|1 + 3 files changed, 19 insertions(+), 1 deletions(-) diff --git a/hw/isa-bridge.c b/hw/isa-bridge.c index 49fa033..bb2d8b0 100644 --- a/hw/isa-bridge.c +++ b/hw/isa-br

[Qemu-devel] [PATCH v2 04/12] audio: give ISA bus to sound cards, instead of PIC

2011-09-19 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- arch_init.c| 10 +- arch_init.h|2 +- hw/adlib.c |2 +- hw/audiodev.h |8 hw/cs4231a.c |2 +- hw/gus.c |2 +- hw/mips_jazz.c |5 +++-- hw/pc.h|2 +- hw/pc_piix.c |4 ++-- hw/pcsp

[Qemu-devel] [PATCH v2 12/12] isa: remove limitation of only one ISA bus

2011-09-19 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/isa-bus.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index 25c7191..5d32999 100644 --- a/hw/isa-bus.c +++ b/hw/isa-bus.c @@ -22,7 +22,6 @@ #include "isa.h" #include "exec-memory.h" -static IS

Re: [Qemu-devel] [PATCH 0/3] Remove QEMUFile abuse

2011-09-19 Thread malc
On Mon, 19 Sep 2011, Juan Quintela wrote: > malc wrote: > > On Sun, 18 Sep 2011, Juan Quintela wrote: > > > >> malc wrote: > >> > On Fri, 16 Sep 2011, Anthony Liguori wrote: > >> > > >> >> Reviewed-by: Anthony Liguori > >> >> > >> >> malc, please Ack. > >> >> > >> > > >> > I don't like the co

[Qemu-devel] [PATCH v2 02/12] isa: rework ISA bus internals, and add ISA bus ops structure

2011-09-19 Thread Hervé Poussineau
This allows future implementations of real pci-isa bridges Signed-off-by: Hervé Poussineau --- Makefile.objs |2 +- hw/isa-bridge.c | 71 +++ hw/isa-bus.c| 69 ++--- hw/isa.h

[Qemu-devel] [PATCH v2 05/12] pc: improve bus implementation of PIIX3 bridge

2011-09-19 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/pc.h |2 +- hw/pc_piix.c |3 ++- hw/piix_pci.c | 38 +- 3 files changed, 36 insertions(+), 7 deletions(-) diff --git a/hw/pc.h b/hw/pc.h index c3e85e9..5489039 100644 --- a/hw/pc.h +++ b/hw/pc.h @@ -181,

[Qemu-devel] [PATCH v2 07/12] sun4u: improve bus implementation of EBus bridge

2011-09-19 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/sun4u.c | 23 +-- 1 files changed, 17 insertions(+), 6 deletions(-) diff --git a/hw/sun4u.c b/hw/sun4u.c index facfae0..410d52b 100644 --- a/hw/sun4u.c +++ b/hw/sun4u.c @@ -93,6 +93,8 @@ struct hwdef { typedef struct EbusState {

Re: [Qemu-devel] QEMU as a binary disassembler

2011-09-19 Thread Lei Li
On 09/20/2011 10:11 AM, Xin Tong wrote: One of the research projects I am doing involves disassembling machine instructions (such as PTX ) to TCG IR and use the QEMU backends to generate PTX, do you mean Parallel Thread Execution, a pseudo-assembly language for NVIDIA GPUs? code I need. Basic

[Qemu-devel] [PATCH v2 01/12] isa: rename isa_bus_new to isa_bus_bridge_init

2011-09-19 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/isa-bus.c |2 +- hw/isa.h |2 +- hw/mips_jazz.c |2 +- hw/mips_r4k.c |2 +- hw/pc_piix.c |2 +- hw/piix4.c |2 +- hw/piix_pci.c |2 +- hw/ppc_prep.c |2 +- hw/sun4u.c |2 +- hw/vt82c686.c |2 +-

[Qemu-devel] [PATCH v2 00/12] ISA bus improvements

2011-09-19 Thread Hervé Poussineau
Following patches aim to change ISA bus to a first-citizen class in Qemu. They add ISA bus ops, like for scsi and usb buses. Current ISA bridges (PIIX3, PIIX4, EBUS and VT82C686) are converted to this new API, and a simple 'isabus-bridge' device is added. isa_address_space() operation can probab

Re: [Qemu-devel] [Qemu-ppc] [PATCH 50/58] pseries: Update SLOF firmware image

2011-09-19 Thread David Gibson
On Wed, Sep 14, 2011 at 07:59:28AM -0500, Anthony Liguori wrote: > On 09/14/2011 07:28 AM, Peter Maydell wrote: > >On 14 September 2011 13:24, Alexander Graf wrote: > >>Am 14.09.2011 um 13:01 schrieb Peter Maydell: > >>>I confess to not really understanding how we keep the git > >>>submodules and

Re: [Qemu-devel] QEMU as a binary disassembler

2011-09-19 Thread 陳韋任
> One of the research projects I am doing involves disassembling machine > instructions (such as PTX ) to TCG IR and use the QEMU backends to generate > code I need. Basically, I am planning to use QEMU as a dynamic translators, > instead of the full system emulation it is developed for. I need a w

[Qemu-devel] QEMU as a binary disassembler

2011-09-19 Thread Xin Tong
One of the research projects I am doing involves disassembling machine instructions (such as PTX ) to TCG IR and use the QEMU backends to generate code I need. Basically, I am planning to use QEMU as a dynamic translators, instead of the full system emulation it is developed for. I need a way to ha

[Qemu-devel] [PATCH 2/2] Barriers in qemu-barrier.h should not be x86 specific

2011-09-19 Thread David Gibson
qemu-barrier.h contains a few macros implementing memory barrier primitives used in several places throughout qemu. However, apart from the compiler-only barrier, the defined wmb() is correct only for x86, or platforms which are similarly strongly ordered. This patch addresses the FIXME about thi

[Qemu-devel] [PATCH 1/2] virtio: Use global memory barrier macros

2011-09-19 Thread David Gibson
The virtio code uses wmb() macros in several places, as required by the SMP-aware virtio protocol. However the wmb() macro is locally defined to be a compiler barrier only. This is probably sufficient on x86 due to its strong storage ordering model, but it certainly isn't on other platforms, such

[Qemu-devel] buildbot failure in qemu on block_x86_64_debian_6_0

2011-09-19 Thread qemu
The Buildbot has detected a new failure on builder block_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_x86_64_debian_6_0/builds/36 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build

[Qemu-devel] buildbot failure in qemu on block_i386_debian_6_0

2011-09-19 Thread qemu
The Buildbot has detected a new failure on builder block_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_i386_debian_6_0/builds/36 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Rea

Re: [Qemu-devel] [PATCH 6/8] tcg: Add bytecode generator for tcg interpreter

2011-09-19 Thread Stuart Brady
On Sun, Sep 18, 2011 at 10:03:07AM +, Blue Swirl wrote: > I was wondering if this #ifdeffery is needed since TCI would probably > give more performance compared to the alternative, TCG generated > emulation sequences. But it could be useful for testing those. Maybe > there should be two option

Re: [Qemu-devel] [PATCH 5/8] tcg: Add interpreter for bytecode

2011-09-19 Thread Stuart Brady
On Sat, Sep 17, 2011 at 10:00:31PM +0200, Stefan Weil wrote: > +#if MAX_OPC_PARAM_IARGS != 4 > +# error Fix needed, number of supported input arguments changed! > +#endif > +#if TCG_TARGET_REG_BITS == 32 > +typedef uint64_t (*helper_function)(tcg_target_ulong, tcg_target_ulong, > +

Re: [Qemu-devel] Temporary kvm and qemu git repositories

2011-09-19 Thread Michael S. Tsirkin
On Wed, Aug 31, 2011 at 06:38:28PM +0300, Avi Kivity wrote: > Since master.kernel.org is down for maintenance, I've set up > temporary repositories on github: > > git://github.com/avikivity/kvm.git > git://github.com/avikivity/qemu.git > > Please use these instead of kvm.git and qemu-kvm.git

Re: [Qemu-devel] RFC [v2]: vfio / device assignment -- layout of device fd files

2011-09-19 Thread Scott Wood
On 09/19/2011 04:07 PM, Alex Williamson wrote: > On Mon, 2011-09-19 at 14:37 -0500, Scott Wood wrote: >>> A DTPATH as a record, an INTERRUPT as a sub-record, etc. >> >> Same as any other unrecognized (sub)record type, you ignore it -- but >> the kernel should not be generating this. > > I'm trying

Re: [Qemu-devel] blobstore disk format (was Re: Design of the blobstore)

2011-09-19 Thread Michael S. Tsirkin
On Mon, Sep 19, 2011 at 12:22:02PM -0400, Stefan Berger wrote: > On 09/17/2011 03:28 PM, Michael S. Tsirkin wrote: > >On Fri, Sep 16, 2011 at 12:46:40PM -0400, Stefan Berger wrote: > >>On 09/16/2011 10:44 AM, Michael S. Tsirkin wrote: > >>>On Thu, Sep 15, 2011 at 10:33:13AM -0400, Stefan Berger wro

Re: [Qemu-devel] RFC [v2]: vfio / device assignment -- layout of device fd files

2011-09-19 Thread Alex Williamson
On Mon, 2011-09-19 at 14:37 -0500, Scott Wood wrote: > On 09/19/2011 10:16 AM, Alex Williamson wrote: > > On Fri, 2011-09-09 at 08:11 -0500, Stuart Yoder wrote: > >> 2. Header > >> > >> The header is located at offset 0x0 in the device fd > >> and has the following format: > >> > >> struct devf

Re: [Qemu-devel] [PATCH 0/3] Remove QEMUFile abuse

2011-09-19 Thread Juan Quintela
malc wrote: > On Sun, 18 Sep 2011, Juan Quintela wrote: > >> malc wrote: >> > On Fri, 16 Sep 2011, Anthony Liguori wrote: >> > >> >> Reviewed-by: Anthony Liguori >> >> >> >> malc, please Ack. >> >> >> > >> > I don't like the commit message. >> >> Can you be more specific? > > QEMUFile predate

Re: [Qemu-devel] [PATCH 2/4] rbd: allow escaping in config string

2011-09-19 Thread Sage Weil
On Mon, 19 Sep 2011, Kevin Wolf wrote: > If src ends with a backslash, you read beyond the end of the string. Right, sending an updated patch. > Wouldn't it make sense to have the unescape integrated in > qemu_rbd_next_tok? Or are there any places where you would want to call > it without doing a

[Qemu-devel] [PATCH] rbd: allow escaping in config string

2011-09-19 Thread Sage Weil
The config string is variously delimited by =, @, and /, depending on the field. Allow these characters to be escaped by preceeding them with \. Signed-off-by: Sage Weil --- block/rbd.c | 29 +++-- 1 files changed, 27 insertions(+), 2 deletions(-) diff --git a/block/r

Re: [Qemu-devel] RFC [v2]: vfio / device assignment -- layout of device fd files

2011-09-19 Thread Scott Wood
On 09/19/2011 10:16 AM, Alex Williamson wrote: > On Fri, 2011-09-09 at 08:11 -0500, Stuart Yoder wrote: >> 2. Header >> >> The header is located at offset 0x0 in the device fd >> and has the following format: >> >> struct devfd_header { >> __u32 magic; >> __u32 version; >>

Re: [Qemu-devel] [PATCH] isapc: give system address space when pci is disabled

2011-09-19 Thread Hervé Poussineau
Jan Kiszka a écrit : On 2011-09-18 18:04, Hervé Poussineau wrote: Signed-off-by: Hervé Poussineau --- hw/pc_piix.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index da6fa55..c0b8a3a 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -121,7

Re: [Qemu-devel] configure: Detect predefined compiler symbols for ARM and HPPA

2011-09-19 Thread Brad
On 07/09/11 9:24 PM, Brad wrote: configure: Detect predefined compiler symbols for ARM and HPPA To be able to detect some ARM / HPPA based architectures such as with OpenBSD/(armish / zaurus) or OpenBSD/hppa. Signed-off-by: Brad Smith ping. -- This message has been scanned for viruses and da

Re: [Qemu-devel] [Qemu-ppc] [PATCH 33/58] KVM: update kernel headers

2011-09-19 Thread Alexander Graf
On 19.09.2011, at 19:50, Scott Wood wrote: > On 09/17/2011 11:59 AM, Blue Swirl wrote: >> On Wed, Sep 14, 2011 at 8:42 AM, Alexander Graf wrote: >>> diff --git a/linux-headers/linux/kvm_para.h b/linux-headers/linux/kvm_para.h >>> index 7bdcf93..b315e27 100644 >>> --- a/linux-headers/linux/kvm_pa

Re: [Qemu-devel] [Qemu-ppc] [PATCH 33/58] KVM: update kernel headers

2011-09-19 Thread Scott Wood
On 09/17/2011 11:59 AM, Blue Swirl wrote: > On Wed, Sep 14, 2011 at 8:42 AM, Alexander Graf wrote: >> diff --git a/linux-headers/linux/kvm_para.h b/linux-headers/linux/kvm_para.h >> index 7bdcf93..b315e27 100644 >> --- a/linux-headers/linux/kvm_para.h >> +++ b/linux-headers/linux/kvm_para.h >> @@

Re: [Qemu-devel] [RFC PATCH 3/5] VFIO: Base framework for new VFIO driver

2011-09-19 Thread Alex Williamson
Sorry for the delay, just getting back from LPC and some time off... On Wed, 2011-09-07 at 10:52 -0400, Konrad Rzeszutek Wilk wrote: > > +static long vfio_iommu_unl_ioctl(struct file *filep, > > +unsigned int cmd, unsigned long arg) > > +{ > > + struct vfio_iommu *vio

Re: [Qemu-devel] [PATCH 5/8] tcg: Add interpreter for bytecode

2011-09-19 Thread Richard Henderson
On 09/17/2011 01:00 PM, Stefan Weil wrote: > +#if TCG_TARGET_HAS_ext8s_i32 > +case INDEX_op_ext8s_i32: > +t0 = *tb_ptr++; > +t1 = tci_read_r8s(&tb_ptr); > +tci_write_reg32(t0, t1); > +break; > +#endif You really ought not need all these ifdef

Re: [Qemu-devel] [PATCH 04/14] qdev: take ownership of id pointer

2011-09-19 Thread Anthony Liguori
On 09/19/2011 02:34 AM, Gerd Hoffmann wrote: On 09/16/11 18:00, Anthony Liguori wrote: qdev has this quirk that it owns a seemingly arbitrary QemuOpts pointer. That's because qdev expects a static string for the id (which really makes no sense since ids are supposed to be provided by the user).

Re: [Qemu-devel] blobstore disk format (was Re: Design of the blobstore)

2011-09-19 Thread Stefan Berger
On 09/17/2011 03:28 PM, Michael S. Tsirkin wrote: On Fri, Sep 16, 2011 at 12:46:40PM -0400, Stefan Berger wrote: On 09/16/2011 10:44 AM, Michael S. Tsirkin wrote: On Thu, Sep 15, 2011 at 10:33:13AM -0400, Stefan Berger wrote: On 09/15/2011 08:28 AM, Michael S. Tsirkin wrote: So the below is a

Re: [Qemu-devel] [PATCH 24/58] PPC: E500: Add PV spinning code

2011-09-19 Thread Scott Wood
On 09/19/2011 06:35 AM, Alexander Graf wrote: > > On 17.09.2011, at 19:40, Blue Swirl wrote: > >> On Sat, Sep 17, 2011 at 5:15 PM, Alexander Graf wrote: >>> >>> Am 17.09.2011 um 18:58 schrieb Blue Swirl : >>> On Sparc32, there is no need for a PV device. The CPU is woken up from halted

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-09-19 Thread Paolo Bonzini
On 09/19/2011 05:11 PM, Kevin Wolf wrote: > I think it is possible to go a step further, turn > posix_aio_process_queue into a bottom half and get rid of the pipe > altogether. This in turn would remove the only real user of > io_process_queue in qemu_aio_set_fd_handler. However, this is al

[Qemu-devel] [PATCH] qcow2: Unlock during COW

2011-09-19 Thread Kevin Wolf
Unlocking during COW allows for more parallelism. One change it requires is that buffers are dynamically allocated instead of just using a per-image buffer. While touching the code, drop the synchronous qcow2_read() function and replace it by a bdrv_read() call. Signed-off-by: Kevin Wolf --- bl

Re: [Qemu-devel] RFC [v2]: vfio / device assignment -- layout of device fd files

2011-09-19 Thread Alex Williamson
On Fri, 2011-09-09 at 08:11 -0500, Stuart Yoder wrote: > Based on the discussions over the last couple of weeks > I have updated the device fd file layout proposal and > tried to specify it a bit more formally. > > === > > 1. Overview >

Re: [Qemu-devel] [PATCH 0/8] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2011-09-19 Thread Mulyadi Santosa
Hi Stefan On Mon, Sep 19, 2011 at 03:15, Stefan Weil wrote: > Am 18.09.2011 18:39, schrieb Mulyadi Santosa: >> On Sun, Sep 18, 2011 at 22:13, Stefan Weil wrote: >> So, that interpreter, should it be build inside Qemu too? Or can we >> use/write external one? let's say creating one in python

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-09-19 Thread Kevin Wolf
Am 19.09.2011 16:37, schrieb Frediano Ziglio: > Now that iothread is always compiled sending a signal seems only an > additional step. This patch also avoid writing to two pipe (one from signal > and one in qemu_service_io). > > Work with kvm enabled or disabled. strace output is more readable (le

Re: [Qemu-devel] [PATCH] linux-aio: remove process requests callback

2011-09-19 Thread Kevin Wolf
Am 19.09.2011 17:05, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > linux-aio.c | 11 +-- > 1 files changed, 1 insertions(+), 10 deletions(-) Thanks applied to the block branch. Kevin

[Qemu-devel] mesavantages.net, bénéficiez d'avantages pour vous et vos salariés

2011-09-19 Thread Canalce
Canalce lance mesavantages.net Si ce message n'est pas lisible, merci de suivre ce lien Si vous ne voulez plus recevoir cet email, merci de suivre ce lien Si vous souhaitez vous désabonner, recopiez cette adresse dans la barre d'adresse de votre navigateur : http://www.ccmail-gmc.

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-09-19 Thread Kevin Wolf
Am 19.09.2011 17:02, schrieb Paolo Bonzini: > On 09/19/2011 04:37 PM, Frediano Ziglio wrote: >> Now that iothread is always compiled sending a signal seems only an >> additional step. This patch also avoid writing to two pipe (one from signal >> and one in qemu_service_io). >> >> Work with kvm enab

Re: [Qemu-devel] [net-next RFC V2 PATCH 0/5] Multiqueue support in tun/tap

2011-09-19 Thread Ben Hutchings
On Sat, 2011-09-17 at 14:02 +0800, Jason Wang wrote: [...] > 2 Current implementation may also get regression for single session > packet transmission. > > The reason is packets from each flow were not handled by the same > queue/vhost thread. > > Various method could be done to handle this: > >

Re: [Qemu-devel] Help needed -- vvfat.c

2011-09-19 Thread Kevin Wolf
Am 15.09.2011 14:49, schrieb Pintu Kumar: > Hi, > > This is regarding qemu block/vvfat.c. > > Currently vvfat scans all directories and sub-directories in the > beginning during init_directories(). > > I want to modify vvfat such that it should scan only the TOP directory > content and not the s

[Qemu-devel] [PATCH] linux-aio: remove process requests callback

2011-09-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- linux-aio.c | 11 +-- 1 files changed, 1 insertions(+), 10 deletions(-) diff --git a/linux-aio.c b/linux-aio.c index 5265a02..bffa6cd 100644 --- a/linux-aio.c +++ b/linux-aio.c @@ -68,15 +68,6 @@ static void qemu_laio_process_completion(struct qemu_lai

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-09-19 Thread Paolo Bonzini
On 09/19/2011 04:37 PM, Frediano Ziglio wrote: Now that iothread is always compiled sending a signal seems only an additional step. This patch also avoid writing to two pipe (one from signal and one in qemu_service_io). Work with kvm enabled or disabled. strace output is more readable (less sys

[Qemu-devel] [RFC 8/8] slirp: convert save/load function to visitor interface

2011-09-19 Thread Michael Roth
Where possible common routines are used for both input and output, thus save on lines of code, theoretically. The added lines here are mostly due to extra logic for each save/load routine to manipulate strings into a unique field name for each saved field, and in some cases a few extra Visitor call

[Qemu-devel] [RFC 6/8] savevm: add QEMUFile->visitor lookup routines

2011-09-19 Thread Michael Roth
Signed-off-by: Michael Roth --- hw/hw.h | 19 + qemu-file.c | 64 +++ 2 files changed, 83 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 244bfb9..e6d7c6a 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -10

Re: [Qemu-devel] [PATCH] scsi: fix sign extension problems

2011-09-19 Thread Kevin Wolf
Am 09.09.2011 16:47, schrieb Paolo Bonzini: > When assigning a 32-bit value to cmd->xfer (which is 64-bits) > it can be erroneously sign extended because the intermediate > 32-bit computation is signed. Fix this by standardizing on > the ld*_be_p functions. > > Signed-off-by: Paolo Bonzini Than

Re: [Qemu-devel] [PATCH 5/8] tcg: Add interpreter for bytecode

2011-09-19 Thread Andi Kleen
> You generally want CSE, yes? So you can't blame gcc for getting it > wrong sometimes. There are cases where CSE pessimizes the code, .e.g when it increases memory pressure too much or caches something that is easier recomputed. This is just another one. BTW I checked again and the problem see

[Qemu-devel] [RFC 5/8] qapi: test cases for QEMUFile input/output visitors

2011-09-19 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile |4 +- test-visitor.c | 404 2 files changed, 406 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 7e9382f..2b68e39 100644 --- a/Makefile +++ b/Makefile @@ -155,7 +15

[Qemu-devel] [RFC 7/8] cutil: add strocat(), to concat a string to an offset in another

2011-09-19 Thread Michael Roth
Signed-off-by: Michael Roth --- cutils.c |8 qemu-common.h |1 + 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/cutils.c b/cutils.c index c91f887..0835834 100644 --- a/cutils.c +++ b/cutils.c @@ -84,6 +84,14 @@ int stristart(const char *str, const char *val,

[Qemu-devel] [RFC 3/8] qapi: add QemuFileInputVisitor

2011-09-19 Thread Michael Roth
Visitor interfaces to read values from a QEMUFile Signed-off-by: Michael Roth --- Makefile.objs |1 + qapi/qemu-file-input-visitor.c | 350 qapi/qemu-file-input-visitor.h | 26 +++ 3 files changed, 377 insertions(+), 0 deletions(-)

[Qemu-devel] [RFC 2/8] qapi: add QemuFileOutputVisitor

2011-09-19 Thread Michael Roth
Visitor interface to write values to a QEMUFile. Signed-off-by: Michael Roth --- Makefile.objs | 16 +- qapi/qemu-file-output-visitor.c | 353 +++ qapi/qemu-file-output-visitor.h | 26 +++ 3 files changed, 388 insertions(+), 7 deletions(

[Qemu-devel] [RFC 4/8] savevm: move QEMUFile interfaces into qemu-file.c

2011-09-19 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile.objs |2 +- hw/hw.h |1 + qemu-file.c | 521 + savevm.c | 494 -- 4 files changed, 523 insertions(+), 495 deletions(-) crea

[Qemu-devel] [RFC 1/8] qapi: add Visitor interfaces for uint*_t and int*_t

2011-09-19 Thread Michael Roth
Signed-off-by: Michael Roth --- qapi/qapi-visit-core.c | 78 qapi/qapi-visit-core.h | 30 ++ 2 files changed, 108 insertions(+), 0 deletions(-) diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c index ddef3ed..d2e7d3

[Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-09-19 Thread Michael Roth
OVERVIEW This patch series implements a QEMUFile Visitor class that's intended to abstract away direct calls to qemu_put_*/qemu_get_* for save/load functions. Currently this is done by always creating a QEMUFileInputVisitor/QEMUFileOutputVisitor pair with each call to qemu_fopen_ops() and main

[Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-09-19 Thread Frediano Ziglio
Now that iothread is always compiled sending a signal seems only an additional step. This patch also avoid writing to two pipe (one from signal and one in qemu_service_io). Work with kvm enabled or disabled. strace output is more readable (less syscalls). Signed-off-by: Frediano Ziglio --- cpu

Re: [Qemu-devel] [PATCH v1 0/6]: block: Add I/O status support

2011-09-19 Thread Kevin Wolf
Am 19.09.2011 16:09, schrieb Luiz Capitulino: > On Mon, 19 Sep 2011 15:40:06 +0200 > Kevin Wolf wrote: > >> Am 01.09.2011 20:37, schrieb Luiz Capitulino: >>> This series adds support to the block layer to keep track of devices' >>> I/O status. That information is also made available in QMP and HM

Re: [Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices (part 1)

2011-09-19 Thread Kevin Wolf
Am 19.09.2011 16:05, schrieb Anthony Liguori: > On 09/19/2011 02:26 AM, Jan Kiszka wrote: >> On 2011-09-16 20:03, Anthony Liguori wrote: >>> So this is a simplification that I plan on running with. For now, I think >>> this >>> series is the right next step because it gives us a path name for the

Re: [Qemu-devel] [PATCH v1 0/6]: block: Add I/O status support

2011-09-19 Thread Luiz Capitulino
On Mon, 19 Sep 2011 15:40:06 +0200 Kevin Wolf wrote: > Am 01.09.2011 20:37, schrieb Luiz Capitulino: > > This series adds support to the block layer to keep track of devices' > > I/O status. That information is also made available in QMP and HMP. > > > > The goal here is to allow management appl

Re: [Qemu-devel] [PATCH 0/2][RFC?] Remove SIGUSR2 from posix-aio

2011-09-19 Thread Stefan Hajnoczi
On Mon, Sep 19, 2011 at 12:54 PM, Frediano Ziglio wrote: > Now that iothread is always compiled sending a signal seems only an > additional step. This patch also avoid writing to two pipe (one from signal > and one in qemu_service_io). > > Tested and works correctly with KVM enabled. Performances

Re: [Qemu-devel] [PATCH 0/4] More RBD updates

2011-09-19 Thread Kevin Wolf
Am 15.09.2011 23:11, schrieb Sage Weil: > Hi, > > Here are a few more improvements to the qemu rbd support. The first > patch makes the configuration file handling cleaner (do not error out if > /etc/ceph/ceph.conf doesn't exist). One allows characters in the conf > string to be escaped, so y

Re: [Qemu-devel] [PATCH 2/2] block: avoid SIGUSR2

2011-09-19 Thread Stefan Hajnoczi
On Mon, Sep 19, 2011 at 12:54 PM, Frediano Ziglio wrote: > @@ -547,7 +549,7 @@ static int posix_aio_flush(void *opaque) > >  static PosixAioState *posix_aio_state; > > -static void aio_signal_handler(int signum) > +static void posix_aio_notify_event(void) >  { >     if (posix_aio_state) { Seems l

Re: [Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices (part 1)

2011-09-19 Thread Anthony Liguori
On 09/19/2011 02:26 AM, Jan Kiszka wrote: On 2011-09-16 20:03, Anthony Liguori wrote: So this is a simplification that I plan on running with. For now, I think this series is the right next step because it gives us a path name for the name (although different syntax) and let's us enforce that a

Re: [Qemu-devel] [PATCH 2/4] rbd: allow escaping in config string

2011-09-19 Thread Kevin Wolf
Am 15.09.2011 23:11, schrieb Sage Weil: > The config string is variously delimited by =, @, and /, depending on the > field. Allow these characters to be escaped by preceeding them with \. > > Signed-off-by: Sage Weil > --- > block/rbd.c | 29 +++-- > 1 files changed,

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-19 Thread Avi Kivity
On 09/19/2011 04:55 PM, Gerd Hoffmann wrote: If the register access is trivial then you don't need to call into the driver at all ... You can have a look at hw/intel-hda.c which actually implements something like this, with some commonly needed features: * The "offset" field already ment

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-19 Thread Gerd Hoffmann
Hi, The trick of having a way to register N callbacks with one shot is worth growing. Ideally each register in a BAR would have a callback and we'd do something like MemoryRegionOps mydev_ops = { .registers = { { MYDEV_REG_x, 4, 4, mydev_reg_x_read, mydev_reg_x_wr

Re: [Qemu-devel] op-helper.c vs helper.c

2011-09-19 Thread Peter Maydell
On 19 September 2011 13:06, Xin Tong Utoronto wrote: > There are 2 files on helpers in target-ppc and target-i386 ( op-helper.c >  helper.c), what are their differences ? also, what kind of functions are > typically emulated using helpers ? The key difference is that op_helper.c is compiled with

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-09-19 Thread Justin Shafer
Here is a strace.. fumex calls??? strace -ff -o /ls-strace-alignment-6.log /usr/bin/qemu-i386 /usr/bin /wine-pthread notepad.exe ** Attachment added: "wine.log" https://bugs.launchpad.net/qemu/+bug/739785/+attachment/2426371/+files/wine.log -- You received this bug notification because you

Re: [Qemu-devel] [PATCH v1 0/6]: block: Add I/O status support

2011-09-19 Thread Kevin Wolf
Am 01.09.2011 20:37, schrieb Luiz Capitulino: > This series adds support to the block layer to keep track of devices' > I/O status. That information is also made available in QMP and HMP. > > The goal here is to allow management applications that miss the > BLOCK_IO_ERROR event to able to query th

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-19 Thread Avi Kivity
On 09/19/2011 03:55 PM, Jan Kiszka wrote: > > The trick of having a way to register N callbacks with one shot is worth > growing. Ideally each register in a BAR would have a callback and we'd > do something like > > MemoryRegionOps mydev_ops = { > .registers = { >

Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

2011-09-19 Thread Avi Kivity
On 09/19/2011 03:48 PM, Jan Kiszka wrote: > > Ah: > > -/* If we see a hole, break the region. */ > +/* If we see a new offset, break the region. */ > > > But, sorry for being slow, I don't see why it requires a core update > (other for adding mrp->offset). So far we matched

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-19 Thread Jan Kiszka
On 2011-09-19 14:42, Avi Kivity wrote: > On 09/19/2011 03:32 PM, Jan Kiszka wrote: >> > It's opt-in. If a device sets >> > MemoryRegionOps::impl.{min,max}_access_size = 1, it will only be fed >> > byte accesses (the core will take care of breaking apart larger >> > writes). If it sets MemoryR

Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

2011-09-19 Thread Jan Kiszka
On 2011-09-19 14:37, Avi Kivity wrote: > On 09/19/2011 03:29 PM, Jan Kiszka wrote: >> On 2011-09-19 14:14, Avi Kivity wrote: >> > On 09/18/2011 10:04 PM, Jan Kiszka wrote: >> >> > >> >> > If you make the core patch add both mr->offset and >> mrp->offset, then >> >> > change isa to drop memo

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-19 Thread Avi Kivity
On 09/19/2011 03:32 PM, Jan Kiszka wrote: > It's opt-in. If a device sets > MemoryRegionOps::impl.{min,max}_access_size = 1, it will only be fed > byte accesses (the core will take care of breaking apart larger > writes). If it sets MemoryRegionOps::impl.{min,max}_access_size = 4, it > wil

Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

2011-09-19 Thread Avi Kivity
On 09/19/2011 03:29 PM, Jan Kiszka wrote: On 2011-09-19 14:14, Avi Kivity wrote: > On 09/18/2011 10:04 PM, Jan Kiszka wrote: >> > >> > If you make the core patch add both mr->offset and mrp->offset, then >> > change isa to drop memory_region_set_offset(), instead adding the >> delta >>

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-19 Thread Jan Kiszka
On 2011-09-19 14:19, Avi Kivity wrote: > On 09/18/2011 10:07 PM, Jan Kiszka wrote: >> On 2011-09-18 18:49, Avi Kivity wrote: >> > On 09/18/2011 07:28 PM, Jan Kiszka wrote: >> >> >> >> >> >> This is PIO, limited by the x86 address space to 16 bit. Will >> add a >> >> >> comment. >> >> > >>

Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

2011-09-19 Thread Jan Kiszka
On 2011-09-19 14:14, Avi Kivity wrote: > On 09/18/2011 10:04 PM, Jan Kiszka wrote: >> > >> > If you make the core patch add both mr->offset and mrp->offset, then >> > change isa to drop memory_region_set_offset(), instead adding the >> delta >> > to mrp->offset, does that not work out? >> >> Nop

Re: [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts

2011-09-19 Thread Avi Kivity
On 09/18/2011 10:07 PM, Jan Kiszka wrote: > I don't think it should be deduplicated. The device is providing two > separate ABIs. Yes, two ABIs, and the only difference is the offset of the data register. How about #ifdef TARGET_I386 # define VBE_DATA_REG 1 #else # define VBE_DATA_REG 2 #e

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-19 Thread Avi Kivity
On 09/18/2011 10:07 PM, Jan Kiszka wrote: On 2011-09-18 18:49, Avi Kivity wrote: > On 09/18/2011 07:28 PM, Jan Kiszka wrote: >> >> >> >> This is PIO, limited by the x86 address space to 16 bit. Will add a >> >> comment. >> > >> > x86 PIO is not limited to 16 bits, just ISA, which memo

Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

2011-09-19 Thread Avi Kivity
On 09/18/2011 10:16 PM, Jan Kiszka wrote: On 2011-09-18 18:49, Richard Henderson wrote: > On 09/18/2011 05:54 AM, Jan Kiszka wrote: >> @@ -375,8 +375,7 @@ static const MemoryRegionPortio *find_portio(MemoryRegion *mr, uint64_t offset, >> const MemoryRegionPortio *mrp; >> >> for (mr

Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

2011-09-19 Thread Avi Kivity
On 09/18/2011 10:04 PM, Jan Kiszka wrote: > > If you make the core patch add both mr->offset and mrp->offset, then > change isa to drop memory_region_set_offset(), instead adding the delta > to mrp->offset, does that not work out? Nope. The old API accepted arbitrary portio lists per memory r

Re: [Qemu-devel] op-helper.c vs helper.c

2011-09-19 Thread Alexander Graf
On 19.09.2011, at 14:06, Xin Tong Utoronto wrote: > There are 2 files on helpers in target-ppc and target-i386 ( op-helper.c > helper.c), what are their differences ? General rule: op_helper.c: Code snippets called from TCG generated code. Implement more complex operations that gcc gets be

[Qemu-devel] op-helper.c vs helper.c

2011-09-19 Thread Xin Tong Utoronto
There are 2 files on helpers in target-ppc and target-i386 ( op-helper.c helper.c), what are their differences ? also, what kind of functions are typically emulated using helpers ? Thanks Xin

[Qemu-devel] [PATCH v2 1/2] trace: portable simple trace backend using glib

2011-09-19 Thread Stefan Hajnoczi
Convert the simple trace backend to glib so that it works under Windows. We cannot use pthread directly but glib provides portable abstractions. Also use glib atomics instead of newish gcc builtins which may not be supported on Windows toolchains. Signed-off-by: Stefan Hajnoczi --- trace/simple.

[Qemu-devel] [PATCH v2 2/2] trace: use binary file open mode in simpletrace

2011-09-19 Thread Stefan Hajnoczi
For Windows portability the simple trace backend must use the 'b' file open mode. This prevents the stdio library from mangling 0x0a/0x0d newline characters. Signed-off-by: Stefan Hajnoczi --- trace/simple.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/trace/simple.

[Qemu-devel] [PATCH v2 0/2] Make simpletrace work on Windows

2011-09-19 Thread Stefan Hajnoczi
The 'simple' trace backend uses pthreads and does not work on Windows. These patches switch from pthreads to glib so that the code builds on all platforms supported by glib. v2: * Block signals in trace write-out thread Stefan Hajnoczi (2): trace: portable simple trace backend using glib tr

Re: [Qemu-devel] [PATCH 5/8] tcg: Add interpreter for bytecode

2011-09-19 Thread Avi Kivity
On 09/19/2011 09:52 AM, Andi Kleen wrote: > I think it also improves branch target prediction - if you have a tight > loop of a few opcodes the predictor can guess where you're headed (since > there is a separate lookup key for each opcode), whereas with the > original code, there's a single

[Qemu-devel] [PATCH 2/2] block: avoid SIGUSR2

2011-09-19 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- cpus.c |5 - posix-aio-compat.c | 14 -- 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/cpus.c b/cpus.c index 54c188c..d0cfe91 100644 --- a/cpus.c +++ b/cpus.c @@ -380,11 +380,6 @@ static int qemu_signal_init(v

[Qemu-devel] [PATCH 1/2] block: avoid storing a constant in qemu_paiocb structure

2011-09-19 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- posix-aio-compat.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/posix-aio-compat.c b/posix-aio-compat.c index 3193dbf..7ea63a1 100644 --- a/posix-aio-compat.c +++ b/posix-aio-compat.c @@ -42,7 +42,6 @@ struct qemu_paiocb { i

[Qemu-devel] [PATCH 0/2][RFC?] Remove SIGUSR2 from posix-aio

2011-09-19 Thread Frediano Ziglio
Now that iothread is always compiled sending a signal seems only an additional step. This patch also avoid writing to two pipe (one from signal and one in qemu_service_io). Tested and works correctly with KVM enabled. Performances are only sligthly better (as I expected). strace output is more rea

  1   2   >