Re: [Qemu-devel] [PATCH v2 04/15] coroutine-io: handle zero returns from recv

2011-09-16 Thread MORITA Kazutaka
At Fri, 16 Sep 2011 16:25:41 +0200, Paolo Bonzini wrote: > > When the other side is shutdown, read returns zero (writes return EPIPE). > In this case, care must be taken to avoid infinite loops. This error > was already present in sheepdog. > > Cc: MORITA Kazutaka > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH v2 03/15] sheepdog: move coroutine send/recv function to generic code

2011-09-16 Thread MORITA Kazutaka
At Fri, 16 Sep 2011 16:25:40 +0200, Paolo Bonzini wrote: > > Outside coroutines, avoid busy waiting on EAGAIN by temporarily > making the socket blocking. > > The API of qemu_recvv/qemu_sendv is slightly different from > do_readv/do_writev because they do not handle coroutines. It > returns the

[Qemu-devel] [net-next RFC V2 PATCH 5/5] tuntap: add ioctls to attach or detach a file form tap device

2011-09-16 Thread Jason Wang
New ioctls were added to let multiple files/sockets to be attached to a tap device. Signed-off-by: Jason Wang --- drivers/net/tun.c | 25 ++--- include/linux/if_tun.h |3 +++ 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/drivers/net/tun.c b/driver

[Qemu-devel] [net-next RFC V2 PATCH 4/5] tuntap: multiqueue support

2011-09-16 Thread Jason Wang
This patch adds multiqueue support for tap device by allowing multiple sockets to be attached to a tap device. Then we could parallize packets transmission/reception by put them into different socket. Following steps were used when choose tx queues: 1 For the packets comes from multiqueue nics, we

[Qemu-devel] [net-next RFC V2 PATCH 2/5] tuntap: categorize ioctl

2011-09-16 Thread Jason Wang
As we've moved socket related structure to file->private_data, we move the ioctls that only touch socket out of tun_chr_ioctl() as it don't need hold rtnl lock. Signed-off-by: Jason Wang --- drivers/net/tun.c | 52 ++-- 1 files changed, 34 insert

[Qemu-devel] [net-next RFC V2 PATCH 3/5] tuntap: introduce multiqueue flags

2011-09-16 Thread Jason Wang
Add flags to be used by creating multiqueue tuntap device. Signed-off-by: Jason Wang --- include/linux/if_tun.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/if_tun.h b/include/linux/if_tun.h index 06b1829..c92a291 100644 --- a/include/linux/if_tun.h +++

[Qemu-devel] [net-next RFC V2 PATCH 1/5] tuntap: move socket to tun_file

2011-09-16 Thread Jason Wang
In order to let tap can transmit skbs to multiple sockets, the first step is to move socket from tun_device to tun_file. The reference between tap device and socket was setup during TUNSETIFF as usual. After this we can go ahead to allow multiple files to be attached to tap device. Signed-off-by:

[Qemu-devel] [net-next RFC V2 PATCH 0/5] Multiqueue support in tun/tap

2011-09-16 Thread Jason Wang
Hello all: This series brings the V2 of multiqueue tun/tap (V1 in http://www.mail-archive.com/kvm@vger.kernel.org/msg59479.html), an approach to let tun/tap can benefit from the multicore/multiqueue environment by spreading the network loads into differnet sockets/queues. Some quick overview of t

Re: [Qemu-devel] [PATCH v2 02/15] add socket_set_block

2011-09-16 Thread MORITA Kazutaka
At Fri, 16 Sep 2011 16:25:39 +0200, Paolo Bonzini wrote: > > Cc: MORITA Kazutaka > Signed-off-by: Paolo Bonzini > --- > oslib-posix.c |7 +++ > oslib-win32.c |6 ++ > qemu_socket.h |1 + > 3 files changed, 14 insertions(+), 0 deletions(-) Reviewed-by: MORITA Kazutaka

Re: [Qemu-devel] [PATCH v2 01/15] sheepdog: add coroutine_fn markers

2011-09-16 Thread MORITA Kazutaka
At Fri, 16 Sep 2011 16:25:38 +0200, Paolo Bonzini wrote: > > This makes the following patch easier to review. > > Cc: MORITA Kazutaka > Signed-off-by: Paolo Bonzini > --- > block/sheepdog.c | 14 +++--- > 1 files changed, 7 insertions(+), 7 deletions(-) Reviewed-by: MORITA Kazutaka

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Edgar E. Iglesias
On Fri, Sep 16, 2011 at 09:17:54PM -0500, Anthony Liguori wrote: > On 09/16/2011 07:48 PM, Edgar E. Iglesias wrote: > >On Fri, Sep 16, 2011 at 07:47:57PM +0300, Gleb Natapov wrote: > >>On Thu, Sep 15, 2011 at 03:50:28PM -0500, Anthony Liguori wrote: > >>>On 09/15/2011 03:29 PM, Gleb Natapov wrote:

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Edgar E. Iglesias
On Fri, Sep 16, 2011 at 09:12:19PM -0500, Anthony Liguori wrote: > On 09/16/2011 08:11 PM, Edgar E. Iglesias wrote: > >On Fri, Sep 16, 2011 at 11:10:19AM -0500, Anthony Liguori wrote: > >>On 09/16/2011 09:46 AM, John Williams wrote: > >>>On Thu, Sep 15, 2011 at 11:17 PM, Anthony Liguori > >>>wro

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Anthony Liguori
On 09/16/2011 09:17 PM, Anthony Liguori wrote: On 09/16/2011 07:48 PM, Edgar E. Iglesias wrote: QEMU should allow us to model devices in a a bus agnostic way. And this is the problem to fix in qdev. We need to kill buses in qdev. The approach really boils down to: 1) Add unique names to devic

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Anthony Liguori
On 09/16/2011 07:48 PM, Edgar E. Iglesias wrote: On Fri, Sep 16, 2011 at 07:47:57PM +0300, Gleb Natapov wrote: On Thu, Sep 15, 2011 at 03:50:28PM -0500, Anthony Liguori wrote: On 09/15/2011 03:29 PM, Gleb Natapov wrote: On Thu, Sep 15, 2011 at 12:51:23PM -0500, Anthony Liguori wrote: On 09/15

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Anthony Liguori
On 09/16/2011 08:11 PM, Edgar E. Iglesias wrote: On Fri, Sep 16, 2011 at 11:10:19AM -0500, Anthony Liguori wrote: On 09/16/2011 09:46 AM, John Williams wrote: On Thu, Sep 15, 2011 at 11:17 PM, Anthony Liguori wrote: On 09/15/2011 01:31 AM, Gleb Natapov wrote: On Wed, Sep 14, 2011 at 01:04

Re: [Qemu-devel] [PATCH v2 09/18] omap_gpmc: Fix handling of FIFOTHRESHOLDSTATUS bit

2011-09-16 Thread andrzej zaborowski
On 28 August 2011 18:56, Peter Maydell wrote: > The OMAP3 TRM is inconsistent about whether the GPMC FIFOTHRESHOLDSTATUS > bit should be set when FIFOPOINTER > FIFOTHRESHOLD or when it is >= > FIFOTHRESHOLD. Apparently the underlying functional spec from which > the TRM was created states that the

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Edgar E. Iglesias
On Fri, Sep 16, 2011 at 11:10:19AM -0500, Anthony Liguori wrote: > On 09/16/2011 09:46 AM, John Williams wrote: > >On Thu, Sep 15, 2011 at 11:17 PM, Anthony Liguori > >wrote: > >>On 09/15/2011 01:31 AM, Gleb Natapov wrote: > >>> > >>>On Wed, Sep 14, 2011 at 01:04:00PM -0500, Anthony Liguori wrote

Re: [Qemu-devel] [PATCH v2 07/18] omap_gpmc: GPMC_IRQSTATUS is write-one-to-clear

2011-09-16 Thread andrzej zaborowski
On 28 August 2011 18:56, Peter Maydell wrote: > Fix a bug in the handling of writes to GPMC_IRQSTATUS: > it behaves as "write one to clear, writing zero is ignored". > > Signed-off-by: Peter Maydell > --- >  hw/omap_gpmc.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --g

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/58] spapr: proper qdevification

2011-09-16 Thread David Gibson
On Fri, Sep 16, 2011 at 12:41:40PM +0200, Paolo Bonzini wrote: > On 09/16/2011 05:06 AM, David Gibson wrote: > >>> > >>> 1) do you mean, in Linux terms, one target per SCSI _host_ or one > >>> target per SCSI _channel_? i.e. if you looks at > >>> /sys/bus/scsi/devices, right now it looks like >

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Edgar E. Iglesias
On Fri, Sep 16, 2011 at 07:47:57PM +0300, Gleb Natapov wrote: > On Thu, Sep 15, 2011 at 03:50:28PM -0500, Anthony Liguori wrote: > > On 09/15/2011 03:29 PM, Gleb Natapov wrote: > > >On Thu, Sep 15, 2011 at 12:51:23PM -0500, Anthony Liguori wrote: > > >>On 09/15/2011 11:59 AM, Gleb Natapov wrote: >

Re: [Qemu-devel] [PATCH 1/2] omap_intc: Use MemoryRegion API

2011-09-16 Thread andrzej zaborowski
On 31 August 2011 17:55, Peter Maydell wrote: > Convert omap_intc to use the MemoryRegion API > > Signed-off-by: Peter Maydell > --- >  hw/omap_intc.c |   64 ++- >  1 files changed, 30 insertions(+), 34 deletions(-) > > diff --git a/hw/omap_intc

Re: [Qemu-devel] [PATCH 0/2] omap_intc: convert to MemoryRegion, qdev

2011-09-16 Thread Anthony Liguori
On 09/16/2011 06:19 PM, Edgar E. Iglesias wrote: On Fri, Sep 16, 2011 at 08:05:36AM -0500, Anthony Liguori wrote: On 09/09/2011 11:48 AM, Peter Maydell wrote: Ping? Is anyone actively maintaining the omap device model? Yep, Maydell. So IMO we should just apply he's patches. Or better, just

Re: [Qemu-devel] [PATCH 0/2] omap_intc: convert to MemoryRegion, qdev

2011-09-16 Thread andrzej zaborowski
On 16 September 2011 16:32, Peter Maydell wrote: > On 16 September 2011 14:05, Anthony Liguori wrote: >> On 09/09/2011 11:48 AM, Peter Maydell wrote: >>> Ping? >> >> Is anyone actively maintaining the omap device model? > > Whoops, Andrzej's email got dropped from the cc (some odd interaction > b

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Edgar E. Iglesias
On Fri, Sep 16, 2011 at 01:42:02PM -0500, Anthony Liguori wrote: > On 09/16/2011 01:22 PM, Gleb Natapov wrote: > >Then we are arguing about minor detail. But according to you this minor > >detail will prevent us from walking device tree up to the root, so it is > >not so minor for me. > > There is

Re: [Qemu-devel] [PATCH 0/2] omap_intc: convert to MemoryRegion, qdev

2011-09-16 Thread Edgar E. Iglesias
On Fri, Sep 16, 2011 at 08:05:36AM -0500, Anthony Liguori wrote: > On 09/09/2011 11:48 AM, Peter Maydell wrote: > >Ping? > > Is anyone actively maintaining the omap device model? Yep, Maydell. So IMO we should just apply he's patches. Or better, just give him commit rights for any ARM patches. C

Re: [Qemu-devel] [PATCH 0/3] Remove QEMUFile abuse

2011-09-16 Thread malc
On Fri, 16 Sep 2011, Anthony Liguori wrote: > Reviewed-by: Anthony Liguori > > malc, please Ack. > I don't like the commit message. > > > On 09/13/2011 07:52 AM, Juan Quintela wrote: > > Hi > > > > QEMUFile is intended to be used only for migration. Change the other > > three users to use

[Qemu-devel] [PATCH] qemu-char: use qemu_set_fd_handler/2 consistently

2011-09-16 Thread Marcelo Tosatti
Now that qemu_set_fd_handler and qemu_set_fd_handler2 have different implementations, one using qemu iohandlers and the other glib, it is not safe to mix the two when inserting/deleting handlers. Fixes kvm-autotest. Signed-off-by: Marcelo Tosatti diff --git a/qemu-char.c b/qemu-char.c index c9

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Anthony Liguori
On 09/16/2011 03:48 PM, Gleb Natapov wrote: On Fri, Sep 16, 2011 at 02:29:51PM -0500, Anthony Liguori wrote: On 09/16/2011 02:13 PM, Gleb Natapov wrote: On Fri, Sep 16, 2011 at 01:42:02PM -0500, Anthony Liguori wrote: On 09/16/2011 01:22 PM, Gleb Natapov wrote: Then we are arguing about minor

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Gleb Natapov
On Fri, Sep 16, 2011 at 02:29:51PM -0500, Anthony Liguori wrote: > On 09/16/2011 02:13 PM, Gleb Natapov wrote: > >On Fri, Sep 16, 2011 at 01:42:02PM -0500, Anthony Liguori wrote: > >>On 09/16/2011 01:22 PM, Gleb Natapov wrote: > >>>Then we are arguing about minor detail. But according to you this m

[Qemu-devel] [PATCH 2/2] Fix and clean code which tests the gcc version

2011-09-16 Thread Stefan Weil
The code which tests whether gcc supports warn_unused_result was wrong. Remove the wrong test from configure and replace it by code using macro QEMU_GNUC_PREREQ in compiler.h. Signed-off-by: Stefan Weil --- compiler.h |2 +- configure | 20 2 files changed, 1 insertio

[Qemu-devel] [PATCH 1/2] Move macro QEMU_GNUC_PREREQ to compiler.h

2011-09-16 Thread Stefan Weil
The macro is compiler specific and does not depend on the operating system. Move macro QEMU_GNUC_PREREQ from osdep.h to compiler.h and use it to simplify existing code. host-utils.h uses this macro, so it now needs compiler.h instead of osdep.h. Signed-off-by: Stefan Weil --- compiler.h |

[Qemu-devel] [PATCH 0/2] Use QEMU_GNUC_PREREQ to fix wrong gcc version test

2011-09-16 Thread Stefan Weil
These two patches fix a wrong gcc version test. [PATCH 1/2] Move macro QEMU_GNUC_PREREQ to compiler.h [PATCH 2/2] Fix and clean code which tests the gcc version

[Qemu-devel] [PATCH] Makefile: Fix broken build

2011-09-16 Thread Stefan Weil
make -C mybuilddir no longer works (regression caused by commit) 388d475815c23901010a25c845eb078d47ee0740. PWD is the directory of the caller (not mybuilddir), so BUILD_DIR is set to the wrong value. GNU make sets CURDIR to the correct value. Use this macro instead of PWD. Cc: Lluís Vilanova Cc

Re: [Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2011-09-16 Thread Rick Vernam
On Friday 16 September 2011 12:42:02 Rick Vernam wrote: > On Friday 16 September 2011 03:52:34 hkran wrote: > [snip] > > > I have tried many times with many restarts or shutdown-and-boot xp guest > > but failed to meet the crashing. > > (I am using the virtio drivers referenced in the earlier mail

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Anthony Liguori
On 09/16/2011 02:13 PM, Gleb Natapov wrote: On Fri, Sep 16, 2011 at 01:42:02PM -0500, Anthony Liguori wrote: On 09/16/2011 01:22 PM, Gleb Natapov wrote: Then we are arguing about minor detail. But according to you this minor detail will prevent us from walking device tree up to the root, so it

Re: [Qemu-devel] [PATCH] support compiling and installing DTBs

2011-09-16 Thread Alexander Graf
Am 16.09.2011 um 20:57 schrieb Stuart Yoder : > From: Stuart Yoder > > also adds configure options to enable/disable installing DTBs > and override location of dtc > > Signed-off-by: Stuart Yoder This generates a build dependency on dtc, right? Alex

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Gleb Natapov
On Fri, Sep 16, 2011 at 01:42:02PM -0500, Anthony Liguori wrote: > On 09/16/2011 01:22 PM, Gleb Natapov wrote: > >Then we are arguing about minor detail. But according to you this minor > >detail will prevent us from walking device tree up to the root, so it is > >not so minor for me. > > There is

[Qemu-devel] [PATCH] remove mpc8544ds.dtb

2011-09-16 Thread Stuart Yoder
From: Stuart Yoder make install now compiles dtb Signed-off-by: Stuart Yoder --- apply after 'support compiling and installing DTBs' pc-bios/mpc8544ds.dtb | Bin 2277 -> 0 bytes 1 files changed, 0 insertions(+), 0 deletions(-) delete mode 100644 pc-bios/mpc8544ds.dtb diff --git a/pc-bios/

[Qemu-devel] [PATCH] support compiling and installing DTBs

2011-09-16 Thread Stuart Yoder
From: Stuart Yoder also adds configure options to enable/disable installing DTBs and override location of dtc Signed-off-by: Stuart Yoder --- Makefile | 17 +++-- configure | 24 2 files changed, 39 insertions(+), 2 deletions(-) diff --git a/Makefile

Re: [Qemu-devel] [PATCH 1/3] Add "qemu_reset_vcpu"

2011-09-16 Thread Lluís Vilanova
Jan Kiszka writes: > On 2011-09-16 19:01, Lluís Vilanova wrote: >> Mimics the already-existing "qemu_init_vcpu". > Bad name as it implies something important happens inside. Call it > trace_reset_vcpu because that is what it will do. I just thought it is much cleaner to call a generic "qemu_rese

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Anthony Liguori
On 09/16/2011 01:22 PM, Gleb Natapov wrote: Then we are arguing about minor detail. But according to you this minor detail will prevent us from walking device tree up to the root, so it is not so minor for me. There is no root. It's not a tree. The composition tree (which we've been talking

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Gleb Natapov
On Fri, Sep 16, 2011 at 01:08:27PM -0500, Anthony Liguori wrote: > On 09/16/2011 12:47 PM, Peter Maydell wrote: > >On 16 September 2011 17:33, Gleb Natapov wrote: > >>On Thu, Sep 15, 2011 at 09:45:33PM +0100, Peter Maydell wrote: > >>>On 15 September 2011 21:29, Gleb Natapov wrote: > 16650A i

Re: [Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices (part 1)

2011-09-16 Thread Anthony Liguori
On 09/16/2011 11:48 AM, Jan Kiszka wrote: On 2011-09-16 18:00, Anthony Liguori wrote: This series introduces an infrastructure to remove anonymous devices from qdev. Anonymous devices are one of the big gaps between qdev and QOM so removing is a prerequisite to incrementally merging QOM. Beside

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Gleb Natapov
On Fri, Sep 16, 2011 at 06:47:56PM +0100, Peter Maydell wrote: > On 16 September 2011 17:33, Gleb Natapov wrote: > > On Thu, Sep 15, 2011 at 09:45:33PM +0100, Peter Maydell wrote: > >> On 15 September 2011 21:29, Gleb Natapov wrote: > >> > 16650A is not a device. ISA card it resides on is a devic

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Anthony Liguori
On 09/16/2011 12:47 PM, Peter Maydell wrote: On 16 September 2011 17:33, Gleb Natapov wrote: On Thu, Sep 15, 2011 at 09:45:33PM +0100, Peter Maydell wrote: On 15 September 2011 21:29, Gleb Natapov wrote: 16650A is not a device. ISA card it resides on is a device. The 16550A is an encapsula

Re: [Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices (part 1)

2011-09-16 Thread Anthony Liguori
On 09/16/2011 12:03 PM, Jan Kiszka wrote: On 2011-09-16 18:54, Anthony Liguori wrote: On 09/16/2011 11:48 AM, Jan Kiszka wrote: On 2011-09-16 18:00, Anthony Liguori wrote: This series introduces an infrastructure to remove anonymous devices from qdev. Anonymous devices are one of the big gaps

Re: [Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices (part 1)

2011-09-16 Thread Anthony Liguori
On 09/16/2011 12:11 PM, Kevin Wolf wrote: Am 16.09.2011 18:54, schrieb Anthony Liguori: This series just asks the device model developer to come up with a unique *when* they're doing device composition. Even with a totally path based interface, this is always going to be a firm requirement. I

Re: [Qemu-devel] [STABLE 3/4] monitor: fix build breakage with --disable-vnc

2011-09-16 Thread Luiz Capitulino
On Fri, 16 Sep 2011 12:40:40 -0500 "Justin M. Forbes" wrote: > On Fri, 2011-09-16 at 13:30 -0300, Luiz Capitulino wrote: > > From: TeLeMan > > > > The breakage was introduced by the commit > > 13661089810d3e59931f3e80d7cb541b99af7071 > > This patch, as well as the next "monitor: fix build bre

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Peter Maydell
On 16 September 2011 17:33, Gleb Natapov wrote: > On Thu, Sep 15, 2011 at 09:45:33PM +0100, Peter Maydell wrote: >> On 15 September 2011 21:29, Gleb Natapov wrote: >> > 16650A is not a device. ISA card it resides on is a device. >> >> The 16550A is an encapsulated set of functionality with some >

Re: [Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2011-09-16 Thread Rick Vernam
On Friday 16 September 2011 03:52:34 hkran wrote: [snip] > > I have tried many times with many restarts or shutdown-and-boot xp guest > but failed to meet the crashing. > (I am using the virtio drivers referenced in the earlier mail list.) > my command: > > /home/huikai/qemu15/bin/qemu --enable-

Re: [Qemu-devel] [STABLE 3/4] monitor: fix build breakage with --disable-vnc

2011-09-16 Thread Justin M. Forbes
On Fri, 2011-09-16 at 13:30 -0300, Luiz Capitulino wrote: > From: TeLeMan > > The breakage was introduced by the commit > 13661089810d3e59931f3e80d7cb541b99af7071 This patch, as well as the next "monitor: fix build breakage for ! CONFIG_VNC" are already in stable, and have been for a few weeks.

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Gleb Natapov
On Thu, Sep 15, 2011 at 03:50:28PM -0500, Anthony Liguori wrote: > On 09/15/2011 03:29 PM, Gleb Natapov wrote: > >On Thu, Sep 15, 2011 at 12:51:23PM -0500, Anthony Liguori wrote: > >>On 09/15/2011 11:59 AM, Gleb Natapov wrote: > >>>On Thu, Sep 15, 2011 at 11:33:00AM -0500, Anthony Liguori wrote: >

[Qemu-devel] [STABLE 4/4] monitor: fix build breakage for !CONFIG_VNC

2011-09-16 Thread Luiz Capitulino
From: Jamie Iles Commit c62f6d1 (monitor: fix build breakage with --disable-vnc) conditionalised some VNC setup code but left an unused variable. Move the variable into the conditional code to fix the build breakage. Cc: Luiz Capitulino Cc: Markus Armbruster Signed-off-by: Jamie Iles Signed-

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Gleb Natapov
On Thu, Sep 15, 2011 at 09:45:33PM +0100, Peter Maydell wrote: > On 15 September 2011 21:29, Gleb Natapov wrote: > > 16650A is not a device. ISA card it resides on is a device. > > The 16550A is an encapsulated set of functionality with some > well defined interfaces ("I provide a set of memory m

[Qemu-devel] [STABLE 1/4] configure: Copy test data to build directory

2011-09-16 Thread Luiz Capitulino
The QDict unit-tests (check-qdict) will fail when ran on a different build directory. That's, it only works when ran on the source dir. This happens because its data file (qdict-test-data.txt) is not copied to the build dir. Fix it. Signed-off-by: Luiz Capitulino (cherry picked from commit 70371

Re: [Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices (part 1)

2011-09-16 Thread Kevin Wolf
Am 16.09.2011 18:54, schrieb Anthony Liguori: > On 09/16/2011 11:48 AM, Jan Kiszka wrote: >> On 2011-09-16 18:00, Anthony Liguori wrote: >>> This series introduces an infrastructure to remove anonymous devices from >>> qdev. >>> Anonymous devices are one of the big gaps between qdev and QOM so rem

[Qemu-devel] [STABLE 2/4] Fix qjson test of solidus encoding

2011-09-16 Thread Luiz Capitulino
From: Jan Kiszka "\/" is supposed to be decoded as "/", but there is no need to encode "/" via escape. Fix the existing test and add a second one expressing this. Signed-off-by: Jan Kiszka Acked-by: Michael Roth Signed-off-by: Luiz Capitulino (cherry picked from commit 69faeee12aee8f54870dbea

[Qemu-devel] [STABLE 3/4] monitor: fix build breakage with --disable-vnc

2011-09-16 Thread Luiz Capitulino
From: TeLeMan The breakage was introduced by the commit 13661089810d3e59931f3e80d7cb541b99af7071 Signed-off-by: TeLeMan Signed-off-by: Anthony Liguori (cherry picked from commit c62f6d1d76aea587556c85b6b7b5c44167006264) --- monitor.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-

[Qemu-devel] [STABLE 0/4]: QMP/Monitor stable branch fixes

2011-09-16 Thread Luiz Capitulino
Hi Justin, Here goes some fixes already applied to master that are also needed in -stable. Thanks. Jamie Iles (1): monitor: fix build breakage for !CONFIG_VNC Jan Kiszka (1): Fix qjson test of solidus encoding Luiz Capitulino (1): configure: Copy test data to build directory

Re: [Qemu-devel] [PATCH 1/3] Add "qemu_reset_vcpu"

2011-09-16 Thread Jan Kiszka
On 2011-09-16 19:01, Lluís Vilanova wrote: > Mimics the already-existing "qemu_init_vcpu". Bad name as it implies something important happens inside. Call it trace_reset_vcpu because that is what it will do. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embed

Re: [Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices (part 1)

2011-09-16 Thread Jan Kiszka
On 2011-09-16 18:54, Anthony Liguori wrote: > On 09/16/2011 11:48 AM, Jan Kiszka wrote: >> On 2011-09-16 18:00, Anthony Liguori wrote: >>> This series introduces an infrastructure to remove anonymous devices from >>> qdev. >>> Anonymous devices are one of the big gaps between qdev and QOM so remov

[Qemu-devel] [PATCH 3/3] trace: Add "qemu_reset_vcpu" event

2011-09-16 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- qemu-common.h |2 +- trace-events |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-common.h b/qemu-common.h index cdb6b3b..2915ccf 100644 --- a/qemu-common.h +++ b/qemu-common.h @@ -304,7 +304,7 @@ struct qemu_work_item { void q

[Qemu-devel] [PATCH 2/3] trace: Add "qemu_init_vcpu" event

2011-09-16 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- cpus.c|1 + qemu-common.h |4 +++- trace-events |3 +++ 3 files changed, 7 insertions(+), 1 deletions(-) diff --git a/cpus.c b/cpus.c index 54c188c..8f7ce15 100644 --- a/cpus.c +++ b/cpus.c @@ -861,6 +861,7 @@ void qemu_init_vcpu(void *_env)

[Qemu-devel] [PATCH 1/3] Add "qemu_reset_vcpu"

2011-09-16 Thread Lluís Vilanova
Mimics the already-existing "qemu_init_vcpu". Signed-off-by: Lluís Vilanova --- qemu-common.h |2 ++ target-arm/helper.c |2 ++ target-cris/translate.c |2 ++ target-i386/helper.c |2 ++ target-lm32/helper.c |2 ++ target-m68k

[Qemu-devel] [PATCH 3/3] trace: [ust] Do not use zero-length format strings (avoid compiler warning)

2011-09-16 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- trace-events |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/trace-events b/trace-events index b653d70..7b2e619 100644 --- a/trace-events +++ b/trace-events @@ -480,7 +480,7 @@ qemu_coroutine_yield(void *from, void *to) "from %p to %p"

[Qemu-devel] [PATCH 2/3] trace: [ust] Do not use 'm' in event argument names (used by ust macros)

2011-09-16 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- trace-events |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/trace-events b/trace-events index 9d1fbbb..b653d70 100644 --- a/trace-events +++ b/trace-events @@ -418,8 +418,8 @@ milkymist_pfpu_pulse_irq(void) "Pulse IRQ" # hw/milkymist

[Qemu-devel] [PATCH 1/3] trace: Fix print format for "mipsnet_write"

2011-09-16 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- trace-events |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/trace-events b/trace-events index c09399f..9d1fbbb 100644 --- a/trace-events +++ b/trace-events @@ -454,7 +454,7 @@ milkymist_vgafb_memory_write(uint32_t addr, uint32_t value)

Re: [Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices (part 1)

2011-09-16 Thread Anthony Liguori
On 09/16/2011 11:48 AM, Jan Kiszka wrote: On 2011-09-16 18:00, Anthony Liguori wrote: This series introduces an infrastructure to remove anonymous devices from qdev. Anonymous devices are one of the big gaps between qdev and QOM so removing is a prerequisite to incrementally merging QOM. Beside

Re: [Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices (part 1)

2011-09-16 Thread Jan Kiszka
On 2011-09-16 18:00, Anthony Liguori wrote: > This series introduces an infrastructure to remove anonymous devices from > qdev. > Anonymous devices are one of the big gaps between qdev and QOM so removing is > a prerequisite to incrementally merging QOM. > > Besides the infrastructure, I also con

Re: [Qemu-devel] blobstore disk format (was Re: Design of the blobstore)

2011-09-16 Thread Stefan Berger
On 09/16/2011 10:44 AM, Michael S. Tsirkin wrote: On Thu, Sep 15, 2011 at 10:33:13AM -0400, Stefan Berger wrote: On 09/15/2011 08:28 AM, Michael S. Tsirkin wrote: So the below is a proposal for a directory scheme for storing (optionally multiple) nvram images, along with any metadata. Data is e

[Qemu-devel] [RFC PATCH 13/14] link the main loop and its dependencies into the tools

2011-09-16 Thread Paolo Bonzini
This completes the refactoring and lets the tools use the main loop code from QEMU. This enables tools to operate fully asynchronously. Advantages include better Windows portability (for some definition of portability) over glib's. Signed-off-by: Paolo Bonzini --- Makefile |4 +++- os-

[Qemu-devel] [PATCH 08/14] sysbus: make create_varargs take an id

2011-09-16 Thread Anthony Liguori
This is mostly mechanical but also changes sysbus_create_simple() in order to call into the new create_varargs. Signed-off-by: Anthony Liguori --- hw/axis_dev88.c|4 +- hw/integratorcp.c |5 ++- hw/musicpal.c |3 +- hw/pc.c|2 +- hw/ppce500_m

[Qemu-devel] [PATCH 03/14] qdev: push id into qdev_create calls

2011-09-16 Thread Anthony Liguori
This is preparation for enforcing an "all devices must have unique names" rule which is one of the fundamental gaps between QOM and qdev. This is a mechanical conversion other than a few manual changes in qdev.c to introduce the new parameter. Signed-off-by: Anthony Liguori --- hw/apb_pci.c

[Qemu-devel] [PATCH v2 10/15] nbd: add support for NBD_CMD_FLUSH

2011-09-16 Thread Paolo Bonzini
Note for the brace police: the style in this commit and the following is consistent with the rest of the file. It is then fixed together with the introduction of coroutines. Signed-off-by: Paolo Bonzini --- block/nbd.c | 31 +++ nbd.c | 15 ++-

[Qemu-devel] [PATCH v2 11/15] nbd: add support for NBD_CMD_FLAG_FUA

2011-09-16 Thread Paolo Bonzini
The server can use it to issue a flush automatically after a write. The client can also use it to mimic a write-through cache. Signed-off-by: Paolo Bonzini --- block/nbd.c |8 nbd.c | 13 +++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/block/nb

[Qemu-devel] [PATCH v2 3/5] dma-helpers: rewrite completion/cancellation

2011-09-16 Thread Paolo Bonzini
This fixes various problems with completion/cancellation: * if the io_func fails to get an AIOCB, the callback wasn't called * If DMA encounters a bounce buffer conflict, and the DMA operation is canceled before the bottom half fires, bad things happen. * memory is not unmapped after cancellatio

[Qemu-devel] [PATCH 04/14] qdev: take ownership of id pointer

2011-09-16 Thread Anthony Liguori
qdev has this quirk that it owns a seemingly arbitrary QemuOpts pointer. That's because qdev expects a static string for the id (which really makes no sense since ids are supposed to be provided by the user). Instead of managing just the id pointer, we currently take ownership of the entire QemuO

[Qemu-devel] [PATCH 09/14] fw_cfg: add name to global fw_cfg device

2011-09-16 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/fw_cfg.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c index e2193d5..e37a427 100644 --- a/hw/fw_cfg.c +++ b/hw/fw_cfg.c @@ -484,7 +484,7 @@ FWCfgState *fw_cfg_init(uint32_t ctl_port, uint32_t data_port,

[Qemu-devel] [PATCH v2 05/15] block: emulate .bdrv_flush() using .bdrv_aio_flush()

2011-09-16 Thread Paolo Bonzini
From: Stefan Hajnoczi Block drivers typically have two copies of the flush operation: a synchronous .bdrv_flush() and an asynchronous .bdrv_aio_flush(). This patch applies the same emulation that we already do for .bdrv_read()/.bdrv_write() to .bdrv_flush(). Now block drivers only need to provi

[Qemu-devel] [PATCH v2 13/15] nbd: switch to asynchronous operation

2011-09-16 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/nbd.c | 217 +++ nbd.c |8 ++ 2 files changed, 151 insertions(+), 74 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index 35c15c8..f6efd7b 100644 --- a/block/nbd.c +++ b/block/nbd.c @@

[Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices (part 1)

2011-09-16 Thread Anthony Liguori
This series introduces an infrastructure to remove anonymous devices from qdev. Anonymous devices are one of the big gaps between qdev and QOM so removing is a prerequisite to incrementally merging QOM. Besides the infrastructure, I also converted almost all of the possible PC devices to have uniq

[Qemu-devel] [PATCH 13/14] ide: give IDE drives a default name in qdev

2011-09-16 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/ide/qdev.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c index 8c868b5..760314c 100644 --- a/hw/ide/qdev.c +++ b/hw/ide/qdev.c @@ -102,7 +102,8 @@ IDEDevice *ide_create_drive(IDEBus *bus, int unit, D

Re: [Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices (part 1)

2011-09-16 Thread Anthony Liguori
On 09/16/2011 11:00 AM, Anthony Liguori wrote: This series introduces an infrastructure to remove anonymous devices from qdev. Anonymous devices are one of the big gaps between qdev and QOM so removing is a prerequisite to incrementally merging QOM. Besides the infrastructure, I also converted a

[Qemu-devel] [PATCH 11/14] pci: obtain devfn before initializing the device

2011-09-16 Thread Anthony Liguori
We need devfn to be allocated before the device is initialized in order to derive the name from the devfn. Signed-off-by: Anthony Liguori --- hw/pci.c | 30 ++ 1 files changed, 22 insertions(+), 8 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 67efbb2..abad900

[Qemu-devel] [PATCH 14/14] pc: assign names to machine created devices

2011-09-16 Thread Anthony Liguori
This gives names to all of the devices created by the PC machine. This need to be unique to the pc, but not necessarily unique to the device. Signed-off-by: Anthony Liguori --- hw/fdc.h |2 +- hw/kvmclock.c |2 +- hw/pc.c | 11 ++- hw/pc.h |

[Qemu-devel] [PATCH v2 1/5] dma-helpers: rename is_write to to_dev

2011-09-16 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- dma-helpers.c | 14 +++--- dma.h |2 +- hw/ide/core.c |2 +- hw/ide/macio.c |2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/dma-helpers.c b/dma-helpers.c index 4610ea0..717e384 100644 --- a/dma-helpers.c +++

[Qemu-devel] [RFC PATCH 03/14] qemu-timer: move common code to qemu_rearm_alarm_timer

2011-09-16 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qemu-timer.c | 129 -- roms/seabios |2 +- 2 files changed, 54 insertions(+), 77 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index e84e444..548b349 100644 --- a/qemu-timer.c +++ b/qemu-timer.c

[Qemu-devel] [PATCH 07/14] sysbus: add an id argument to sysbus_create_simple()

2011-09-16 Thread Anthony Liguori
This is mechanical. Signed-off-by: Anthony Liguori --- hw/arm11mpcore.c |2 +- hw/axis_dev88.c |2 +- hw/collie.c |2 +- hw/integratorcp.c | 14 +++--- hw/kvmclock.c |2 +- hw/lm32_boards.c

[Qemu-devel] [PATCH 10/14] isa: add name parameter to device creation

2011-09-16 Thread Anthony Liguori
This is mostly mechanical minus the changes to isa_simple_create() Signed-off-by: Anthony Liguori --- hw/cs4231a.c |2 +- hw/fdc.h |2 +- hw/gus.c |2 +- hw/ide/isa.c |2 +- hw/isa-bus.c | 30 -- hw/isa.h

[Qemu-devel] [PATCH 06/14] qdev: add ability to do QOM-style derived naming

2011-09-16 Thread Anthony Liguori
By using a prefix of "::" in the name, we can safely derive the composed device name from the parent device and busses name. For instance, if the "::i440fx" device created a device named "piix3", it would look like this: static void i440fx_initfn(...) { s->piix3 = qdev_create("PIIX3", "::pi

[Qemu-devel] [PATCH 02/14] qdev: enforce that no devices overload the id property

2011-09-16 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/qdev.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index a223d41..0e267a7 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -47,9 +47,17 @@ static BusState *qbus_find(const char *path); /* Register a new devi

[Qemu-devel] [PATCH 12/14] pci: give pci devices a default name.

2011-09-16 Thread Anthony Liguori
Bus names are derived from names so now that PCI devices have a name, they also have different bus names. pc_piix relies on the bus name (*sigh*) so we need to update it. Signed-off-by: Anthony Liguori --- hw/pc_piix.c |6 -- hw/pci.c |3 ++- 2 files changed, 6 insertions(+), 3

[Qemu-devel] [PATCH 01/14] apic: rename apic.id -> apic.index

2011-09-16 Thread Anthony Liguori
This clashes with the qdev name property. This shouldn't affect compatibility since the apic is a no_user device. Signed-off-by: Anthony Liguori --- hw/apic.c |2 +- hw/pc.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/apic.c b/hw/apic.c index d8f56c8..e92b

[Qemu-devel] [PATCH 05/14] qdev: remove opts pointer tracking

2011-09-16 Thread Anthony Liguori
This was only used because id's memory was stored in opts. Signed-off-by: Anthony Liguori --- hw/qdev.c |5 ++--- hw/qdev.h |1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 41ed872..3096667 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -281,7 +

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-16 Thread Anthony Liguori
On 09/16/2011 09:46 AM, John Williams wrote: On Thu, Sep 15, 2011 at 11:17 PM, Anthony Liguori wrote: On 09/15/2011 01:31 AM, Gleb Natapov wrote: On Wed, Sep 14, 2011 at 01:04:00PM -0500, Anthony Liguori wrote: All device relationships are identified as named properties. A QOM path name co

[Qemu-devel] [PATCH v2 12/15] nbd: add support for NBD_CMD_TRIM

2011-09-16 Thread Paolo Bonzini
Map it to bdrv_discard. The server can also expose NBD_FLAG_SEND_TRIM. Signed-off-by: Paolo Bonzini --- block/nbd.c | 31 +++ nbd.c | 13 - 2 files changed, 43 insertions(+), 1 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index 23f83d4..

[Qemu-devel] [RFC PATCH 14/14] qemu-nbd: use common main loop

2011-09-16 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qemu-nbd.c | 127 +--- 1 files changed, 61 insertions(+), 66 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index 3a39145..a45dd4b 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -37,6 +37,13 @@ #define NBD

[Qemu-devel] [RFC PATCH 11/14] simplify main loop functions

2011-09-16 Thread Paolo Bonzini
Provide a clean example of how to use the main loop in the tools. Signed-off-by: Paolo Bonzini --- cpus.c |5 cpus.h |1 - vl.c | 72 +-- 3 files changed, 38 insertions(+), 40 deletions(-) diff --git a/cpus.c b/cpus.c

[Qemu-devel] [PATCH v2 00/15] nbd improvements

2011-09-16 Thread Paolo Bonzini
Here is v2 of the nbd improvements series. It is based on Kevin's block branch, currently at 2168851. Compared to v1, I reordered the patches in more logical blocks. Patches 1-4 touch sheepdog, patches 5-8 (including Stefan bdrv_flush patch, rebased) touch the generic block layer, patches 9-15 to

[Qemu-devel] [RFC PATCH 08/14] create main-loop.h

2011-09-16 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- async.c |1 + cpus.c|7 + cpus.h|1 - main-loop.h | 80 + qemu-char.h | 12 + qemu-common.h | 11 sysemu.h | 10 +-- vl.c |

  1   2   >