[Qemu-devel] [PATCH] introduce environment variables for all qemu-user options

2011-08-05 Thread Johannes Schauer
Rework option parsing code for linux-user in a table-driven manner to allow environment variables for all commandline options. Also generate usage() output from option table. Fix complains from checkpatch.pl, also have envlist global Signed-off-by: Johannes Schauer --- linux-user/main.c | 53

Re: [Qemu-devel] Build broken

2011-08-05 Thread Stefan Hajnoczi
On Fri, Aug 5, 2011 at 5:49 PM, malc wrote: > On Fri, 5 Aug 2011, Stefan Hajnoczi wrote: > >> On Fri, Aug 5, 2011 at 7:22 AM, malc wrote: >> > >> > /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c: In function >> > 'coroutine_new': >> > /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:160:16:

[Qemu-devel] [PATCH v2 2/6] VMDK: add twoGbMaxExtentSparse support

2011-08-05 Thread Fam Zheng
Add twoGbMaxExtentSparse support. Introduce vmdk_free_last_extent. Signed-off-by: Fam Zheng --- block/vmdk.c | 133 -- 1 files changed, 83 insertions(+), 50 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index e22a893..ab15840 1006

Re: [Qemu-devel] 0.15.0-rc2 (any version past 0.14.1) having issues with SLIRP on Windows XP host

2011-08-05 Thread TeLeMan
On Sat, Aug 6, 2011 at 04:46, Blue Swirl wrote: > On Fri, Aug 5, 2011 at 8:09 PM, Kenneth Salerno > wrote: >> Hi, >> >> I'm not sure if any defaults (build or runtime) have changed since 0.14.1, >> but I can no longer get the following to work anymore for QEMU versions >> 0.15.0-rc2 or recent d

[Qemu-devel] Solde Hébergement Web !

2011-08-05 Thread NovaHoster en Tunisie
Solde d'hébergement Web chez NovaHoster.com Du 01 au 20 Août 2011, pour tout achat d’un pack PRO Vous bénéficiez de deux noms de domaine gratuits à vie. Commander maintenant: http://ptf.tweensa.com/link.php?M=4129515&N=121&L=39&F=T

Re: [Qemu-devel] [SeaBIOS] Time to cut a new release?

2011-08-05 Thread Jonathan A. Kollasch
On Fri, Aug 05, 2011 at 04:59:44PM -0600, Marc Jones wrote: > On Thu, Aug 4, 2011 at 7:19 PM, Kevin O'Connor wrote: > > On Thu, Aug 04, 2011 at 02:10:10PM -0500, Anthony Liguori wrote: > >> On 08/04/2011 01:49 PM, Gerd Hoffmann wrote: > >> >Hi, > >> > > >> >A bunch of new stuff has been added to m

Re: [Qemu-devel] 0.15.0-rc2 (any version past 0.14.1) having issues with SLIRP on Windows XP host

2011-08-05 Thread Kenneth Salerno
--- On Fri, 8/5/11, Jan Kiszka wrote: > From: Jan Kiszka > Subject: Re: 0.15.0-rc2 (any version past 0.14.1) having issues with SLIRP on > Windows XP host > To: "Blue Swirl" , "Kenneth Salerno" > > Cc: qemu-devel@nongnu.org > Date: Friday, August 5, 2011, 5:43 PM > On 2011-08-05 22:46, Blue S

Re: [Qemu-devel] [SeaBIOS] Time to cut a new release?

2011-08-05 Thread Marc Jones
On Thu, Aug 4, 2011 at 7:19 PM, Kevin O'Connor wrote: > On Thu, Aug 04, 2011 at 02:10:10PM -0500, Anthony Liguori wrote: >> On 08/04/2011 01:49 PM, Gerd Hoffmann wrote: >> >Hi, >> > >> >A bunch of new stuff has been added to master since the last version, >> >time to release a new one? Especially

Re: [Qemu-devel] another TCG branch weirdness

2011-08-05 Thread Artyom Tarasenko
On Fri, Aug 5, 2011 at 10:32 PM, Blue Swirl wrote: > On Fri, Aug 5, 2011 at 4:36 PM, Artyom Tarasenko wrote: >> Host x86_64, guest sparc64. Found a case where a branch instruction >> (brz,pn   %o0) unexpectedly jumps to an unexpected address. I.e. >> branch shouldn't be taken at all, but even if

Re: [Qemu-devel] 0.15.0-rc2 (any version past 0.14.1) having issues with SLIRP on Windows XP host

2011-08-05 Thread Jan Kiszka
On 2011-08-05 22:46, Blue Swirl wrote: > On Fri, Aug 5, 2011 at 8:09 PM, Kenneth Salerno > wrote: >> Hi, >> >> I'm not sure if any defaults (build or runtime) have changed since 0.14.1, >> but I can no longer get the following to work anymore for QEMU versions >> 0.15.0-rc2 or recent development

Re: [Qemu-devel] [PATCH 5/6] qemu-x86: Set tsc_khz in kvm when supported

2011-08-05 Thread Jan Kiszka
On 2011-08-05 22:55, Marcelo Tosatti wrote: > From: Joerg Roedel > > Make use of the KVM_TSC_CONTROL feature if available. > > Signed-off-by: Joerg Roedel > Signed-off-by: Marcelo Tosatti > --- > target-i386/kvm.c | 18 +- > 1 files changed, 17 insertions(+), 1 deletions(-)

Re: [Qemu-devel] [PATCH] monitor: HMP: fix consecutive integer expression parsing

2011-08-05 Thread Blue Swirl
On Fri, Aug 5, 2011 at 9:08 PM, Anthony Liguori wrote: > On 08/05/2011 03:39 PM, Blue Swirl wrote: >> >> On Fri, Aug 5, 2011 at 4:51 PM, Anthony Liguori >>  wrote: >>> >>> On 08/03/2011 06:57 AM, Alon Levy wrote: Currently a command that takes two consecutive integer operations, like >>>

[Qemu-devel] [PATCH 0/6] [PULL] qemu-kvm.git uq/master queue

2011-08-05 Thread Marcelo Tosatti
The following changes since commit 35d7ace74bd07e3d6983c1fd7cbfab4e11175689: qcow2: Fix L1 table size after bdrv_snapshot_goto (2011-08-05 07:15:47 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Jan Kiszka (2): kvmclock: Fix

Re: [Qemu-devel] [PATCH] monitor: HMP: fix consecutive integer expression parsing

2011-08-05 Thread Anthony Liguori
On 08/05/2011 03:39 PM, Blue Swirl wrote: On Fri, Aug 5, 2011 at 4:51 PM, Anthony Liguori wrote: On 08/03/2011 06:57 AM, Alon Levy wrote: Currently a command that takes two consecutive integer operations, like client_migrate_info, will be incorrectly parsed by the human monitor if the second

[Qemu-devel] [PATCH 3/6] qemu: Add strtosz_suffix_unit function

2011-08-05 Thread Marcelo Tosatti
From: Joerg Roedel This function does the same as the strtosz_suffix function except that it allows to specify the unit to which the k/M/B/T suffixes apply. This function will be used later to parse the tsc-frequency from the command-line. Signed-off-by: Joerg Roedel Signed-off-by: Marcelo Tosa

[Qemu-devel] [PATCH 2/6] kvm: Drop obsolete KVM_IOEVENTFD #ifdefs

2011-08-05 Thread Marcelo Tosatti
From: Jan Kiszka Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- kvm-all.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index cbc2532..b9c172b 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1328,7 +1328,6 @@ int kvm_set_signal_m

[Qemu-devel] [PATCH 5/6] qemu-x86: Set tsc_khz in kvm when supported

2011-08-05 Thread Marcelo Tosatti
From: Joerg Roedel Make use of the KVM_TSC_CONTROL feature if available. Signed-off-by: Joerg Roedel Signed-off-by: Marcelo Tosatti --- target-i386/kvm.c | 18 +- 1 files changed, 17 insertions(+), 1 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 10fb

[Qemu-devel] [PATCH 4/6] qemu-x86: Add tsc_freq option to -cpu

2011-08-05 Thread Marcelo Tosatti
From: Joerg Roedel To let the user configure the desired tsc frequency for the guest if running in KVM. Signed-off-by: Joerg Roedel Signed-off-by: Marcelo Tosatti --- target-i386/cpu.h |1 + target-i386/cpuid.c | 13 + 2 files changed, 14 insertions(+), 0 deletions(-) dif

[Qemu-devel] [PATCH 1/6] kvmclock: Fix feature detection

2011-08-05 Thread Marcelo Tosatti
From: Jan Kiszka Bit-wise or the feature flags and drop the obsolete #ifdef. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- hw/kvmclock.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/kvmclock.c b/hw/kvmclock.c index 692ad18..b73aec4 100644 --

[Qemu-devel] [PATCH 6/6] Remove #ifdef KVM_CAP_TSC_CONTROL

2011-08-05 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti --- target-i386/kvm.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 923d2d5..31b88b7 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -504,7 +504,6 @@ int kvm_arch_init_vcpu(CPUState *e

Re: [Qemu-devel] 0.15.0-rc2 (any version past 0.14.1) having issues with SLIRP on Windows XP host

2011-08-05 Thread Blue Swirl
On Fri, Aug 5, 2011 at 8:09 PM, Kenneth Salerno wrote: > Hi, > > I'm not sure if any defaults (build or runtime) have changed since 0.14.1, > but I can no longer get the following to work anymore for QEMU versions > 0.15.0-rc2 or recent development builds: > >  -device e1000,netdev=mynet0 -netde

Re: [Qemu-devel] [PATCH] monitor: HMP: fix consecutive integer expression parsing

2011-08-05 Thread Blue Swirl
On Fri, Aug 5, 2011 at 4:51 PM, Anthony Liguori wrote: > On 08/03/2011 06:57 AM, Alon Levy wrote: >> >> Currently a command that takes two consecutive integer operations, like >> client_migrate_info, will be incorrectly parsed by the human monitor if >> the second expression begins with a minus ('

Re: [Qemu-devel] another TCG branch weirdness

2011-08-05 Thread Blue Swirl
On Fri, Aug 5, 2011 at 4:36 PM, Artyom Tarasenko wrote: > Host x86_64, guest sparc64. Found a case where a branch instruction > (brz,pn   %o0) unexpectedly jumps to an unexpected address. I.e. > branch shouldn't be taken at all, but even if it were it should have > been to 0x13e26e4 and not to 0x5

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-05 Thread Blue Swirl
On Fri, Aug 5, 2011 at 8:40 AM, Stefan Hajnoczi wrote: > We've discussed safe methods for reopening image files (e.g. useful for > changing the hostcache parameter).  The problem is that closing the file first > and then opening it again exposes us to the error case where the open fails. > At that

[Qemu-devel] 0.15.0-rc2 (any version past 0.14.1) having issues with SLIRP on Windows XP host

2011-08-05 Thread Kenneth Salerno
Hi, I'm not sure if any defaults (build or runtime) have changed since 0.14.1, but I can no longer get the following to work anymore for QEMU versions 0.15.0-rc2 or recent development builds: -device e1000,netdev=mynet0 -netdev type=user,id=mynet0 ... Works great in 0.14.1 however. >From th

Re: [Qemu-devel] [RFC PATCH 2/4] add pc-0.14 machine

2011-08-05 Thread Anthony Liguori
On 08/05/2011 02:26 PM, Bruce Rogers wrote: So, do we not need this change, then, to go along with the 0.15 release? Strictly speaking, the 0.15 machine type is identical to the 0.14 machine type. It wouldn't hurt to have a 0.15 machine alias but I don't think it's a strict requirement. Re

Re: [Qemu-devel] [RFC PATCH 2/4] add pc-0.14 machine

2011-08-05 Thread Bruce Rogers
So, do we not need this change, then, to go along with the 0.15 release? Bruce >>> On 6/30/2011 at 09:46 AM, Paolo Bonzini wrote: > The new pc-0.15 machine will have a different migration format, so > define the compatibility one right now. > > Signed-off-by: Paolo Bonzini > --- > hw/pc_pii

Re: [Qemu-devel] [PATCH] e1000: Do reset when E1000_CTRL_RST bit is set.

2011-08-05 Thread Peter Maydell
On 5 August 2011 17:53, Anthony Liguori wrote: > You'll break some GCCs with -Wall -Werror with this.  Please do: > > if ((val & E1000_CTRL_RST)) { Hmm? There's lots of examples of that in the codebase: $ git grep 'if ([a-zA-Z]* & ' | wc -l 1558 '=' (assignment) needs those extra braces, but log

Re: [Qemu-devel] [PATCH] e1000: Do reset when E1000_CTRL_RST bit is set.

2011-08-05 Thread Richard Henderson
On 08/05/2011 09:53 AM, Anthony Liguori wrote: >> +if (val& E1000_CTRL_RST) { > > You'll break some GCCs with -Wall -Werror with this. Please do: > > if ((val & E1000_CTRL_RST)) { Err, really? What versions? I don't recall that ever being true. r~

[Qemu-devel] FW: Qemu instruction count in user mode

2011-08-05 Thread Jain Diviya-B12553
Hi, I am currently using qemu in user mode. target platform is ppc , while host machine is x86. I am a newbie and want to understand how to count instructions of the target code. I see a number of posts etc , but they all seem to be for system mode. I am also not able to generate execution t

Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix indirect syscall handling for MIPS

2011-08-05 Thread An-Cheng Huang
On Fri, Aug 05, 2011 at 10:27:21AM +0100, Peter Maydell wrote: > On 5 August 2011 01:05, An-Cheng Huang wrote: > > Ok the following patch changes the number of arguments for sys_syscall > > to 8 in mips_syscall_args and also skips the do_syscall() call if any > > of the get_user() calls fails. Do

Re: [Qemu-devel] [PATCH 1/2] linux-user: Fix indirect syscall handling for MIPS

2011-08-05 Thread An-Cheng Huang
On Fri, Aug 05, 2011 at 10:27:21AM +0100, Peter Maydell wrote: > On 5 August 2011 01:05, An-Cheng Huang wrote: > > Ok the following patch changes the number of arguments for sys_syscall > > to 8 in mips_syscall_args and also skips the do_syscall() call if any > > of the get_user() calls fails. Do

Re: [Qemu-devel] [PATCH] monitor: HMP: fix consecutive integer expression parsing

2011-08-05 Thread Markus Armbruster
Anthony Liguori writes: > On 08/03/2011 06:57 AM, Alon Levy wrote: >> Currently a command that takes two consecutive integer operations, like >> client_migrate_info, will be incorrectly parsed by the human monitor if >> the second expression begins with a minus ('-') or plus ('+') sign: >> >> cli

Re: [Qemu-devel] [PATCH 0/3] [PULL] slirp: ARP table related fixes

2011-08-05 Thread Anthony Liguori
On 08/05/2011 08:32 AM, Jan Kiszka wrote: The following changes since commit 81e34a2401f7ffd519bb7f093e833cb48734169f: Merge remote-tracking branch 'mst/for_anthony' into staging (2011-08-04 17:15:22 -0500) are available in the git repository at: git://git.kiszka.org/qemu.git queues/sli

Re: [Qemu-devel] [PATCH] when overriding default tool names don't add cross-prefix

2011-08-05 Thread Anthony Liguori
On 08/04/2011 05:10 PM, Stuart yoder wrote: From: Stuart Yoder When overriding a tool name via a shell variable, don't tack on the cross-prefix. This specifically allows the pkg-config command to be overridden and work where it does not exist in some cross build environments. Signed-off-by: St

Re: [Qemu-devel] [PATCH] Reorganize and fix monitor resume after migration

2011-08-05 Thread Anthony Liguori
On 08/05/2011 02:11 AM, Jan Kiszka wrote: From: Jan Kiszka If migration failed in migrate_fd_put_buffer, the monitor may have been resumed not only in the error path of that function but also once again in migrate_fd_put_ready which is called unconditionally by migrate_fd_connect. Fix this by e

Re: [Qemu-devel] [PATCH] e1000: Do reset when E1000_CTRL_RST bit is set.

2011-08-05 Thread Anthony Liguori
On 08/05/2011 09:36 AM, Anthony PERARD wrote: Signed-off-by: Anthony PERARD --- hw/e1000.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index 96d84f9..a1388e9 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -150,6 +150,8 @@ static const

Re: [Qemu-devel] [PATCH] monitor: HMP: fix consecutive integer expression parsing

2011-08-05 Thread Anthony Liguori
On 08/03/2011 06:57 AM, Alon Levy wrote: Currently a command that takes two consecutive integer operations, like client_migrate_info, will be incorrectly parsed by the human monitor if the second expression begins with a minus ('-') or plus ('+') sign: client_migrate_info client_migrate_in

Re: [Qemu-devel] Build broken

2011-08-05 Thread malc
On Fri, 5 Aug 2011, Stefan Hajnoczi wrote: > On Fri, Aug 5, 2011 at 7:22 AM, malc wrote: > > > > /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c: In function > > 'coroutine_new': > > /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:160:16: error: 'arg.i[1]' > > may be used uninitialized in t

Re: [Qemu-devel] [PATCH] MAINTAINERS: add entry for Xen

2011-08-05 Thread Anthony Liguori
On 07/29/2011 10:05 AM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini Signed-off-by: Stefano Stabellini Applied. Thanks. Regards, Anthony Liguori --- MAINTAINERS | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAIN

Re: [Qemu-devel] [PATCH v3 14/39] ac97: convert to memory API

2011-08-05 Thread malc
On Fri, 5 Aug 2011, Anthony Liguori wrote: > On 08/04/2011 08:06 AM, Avi Kivity wrote: > > fixes BAR sizing as well. > > > > Reviewed-by: Richard Henderson > > Signed-off-by: Avi Kivity > > Reviewed-by: Anthony Liguori > > Malc, please Ack > Ok, please notify me when this is pushed so i can c

Re: [Qemu-devel] [PATCH] memory: synchronize dirty bitmap before unmapping a range

2011-08-05 Thread Anthony Liguori
On 07/31/2011 02:47 PM, Avi Kivity wrote: When a range is being unmapped, ask accelerators (e.g. kvm) to synchronize the dirty bitmap to avoid losing information forever. Fixes grub2 screen update. Signed-off-by: Avi Kivity Applied. Thanks. Regards, Anthony Liguori --- Please apply befo

Re: [Qemu-devel] [PATCH 00/15] sdl: Usability improvements

2011-08-05 Thread Anthony Liguori
On 07/30/2011 04:39 AM, Jan Kiszka wrote: As SDL is my preferred way of working ad-hoc with guests, I had a closer look at oddities and shortcomings that this GUI exposed, at least here on Linux hosts. The result is a series of patches I've now finally polished and completed. Highlights: - fix

Re: [Qemu-devel] [PATCH] Avoid allocating TCG resources in non-TCG mode

2011-08-05 Thread Anthony Liguori
On 08/02/2011 09:10 AM, Jan Kiszka wrote: Do not allocate TCG-only resources like the translation buffer when running over KVM or XEN. Saves a "few" bytes in the qemu address space and is also conceptually cleaner. Signed-off-by: Jan Kiszka Applied. Thanks. Regards, Anthony Liguori --- N

Re: [Qemu-devel] [PATCH] qdev: Eliminate duplicate reset

2011-08-05 Thread Anthony Liguori
On 08/01/2011 08:59 PM, Isaku Yamahata wrote: qbus_reset_all_fn was registered twice, so a lot of device reset functions were also called twice when QEMU started. Which was introduced by 80376c3fc2c38fdd45354e4b0eb45031f35587ed This patch fixes it by making the main_system_bus creation not regist

Re: [Qemu-devel] [PATCH] Check fread() results to avoid gcc 4.6 warnings

2011-08-05 Thread Anthony Liguori
On 08/01/2011 01:49 AM, David Gibson wrote: When compiling with gcc 4.6, some code in fw_cfg.c complains that fop_ret is assigned but not used (which is true). However, it looks like the meaningless assignments to fop_ret were done to suppress other gcc warnings due to the fact that fread() is l

Re: [Qemu-devel] [PATCH v2] memory: use signed arithmetic

2011-08-05 Thread Anthony Liguori
On 08/03/2011 03:56 AM, Avi Kivity wrote: When trying to map an alias of a ram region, where the alias starts at address A and we map it into address B, and A> B, we had an arithmetic underflow. Because we use unsigned arithmetic, the underflow converted into a large number which failed addrran

[Qemu-devel] another TCG branch weirdness

2011-08-05 Thread Artyom Tarasenko
Host x86_64, guest sparc64. Found a case where a branch instruction (brz,pn %o0) unexpectedly jumps to an unexpected address. I.e. branch shouldn't be taken at all, but even if it were it should have been to 0x13e26e4 and not to 0x5. Was about to write that the generated OP for brz,pn usually lo

[Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2011-08-05 Thread Rick Vernam
Vadim, Have you been able to reproduce this? Do you require any additional information? Thanks, -Rick -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/818673 Title: virtio: trying to map MMIO memory

Re: [Qemu-devel] [PATCH v2 00/31] target-xtensa: new target architecture

2011-08-05 Thread Richard Henderson
On 07/24/2011 10:10 AM, Max Filippov wrote: > This series adds support for Tensilica Xtensa target. > Port status: Linux for DC232B works in the qemu. > Not implemented xtensa options: MAC16, floating point coprocessor, > boolean option, cache option, debug option. > > v1 -> v2 changes: > - ex

Re: [Qemu-devel] [PATCH 1/2] ptimer: move declarations to ptimer.h

2011-08-05 Thread Anthony Liguori
On 08/02/2011 06:47 AM, Paolo Bonzini wrote: Since the next patch will move VMState declarations for ptimers out of hw/hw.h, prepare a place for them. Signed-off-by: Paolo Bonzini --- hw/arm_timer.c|1 + hw/etraxfs_timer.c|1 + hw/grlib_apbuart.c|1 + hw/grlib_gp

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-05 Thread Anthony Liguori
On 08/05/2011 10:43 AM, Kevin Wolf wrote: Am 05.08.2011 17:24, schrieb Stefan Hajnoczi: On Fri, Aug 5, 2011 at 3:28 PM, Christoph Hellwig wrote: On Fri, Aug 05, 2011 at 02:12:48PM +0100, Daniel P. Berrange wrote: Because you cannot change O_DIRECT on an open fd :(. This is why we're going th

Re: [Qemu-devel] [PATCH] Remove unused is_softmmu parameter from cpu_handle_mmu_fault

2011-08-05 Thread Richard Henderson
On 08/03/2011 11:00 AM, Blue Swirl wrote: > Parameter is_softmmu (and its evil mutant twin brother is_softmuu) > is not used in cpu_*_handle_mmu_fault() functions, remove them > and adjust callers. > > Signed-off-by: Blue Swirl Acked-by: Richard Henderson r~ > --- > target-alpha/cpu.h

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-05 Thread Kevin Wolf
Am 05.08.2011 17:24, schrieb Stefan Hajnoczi: > On Fri, Aug 5, 2011 at 3:28 PM, Christoph Hellwig wrote: >> On Fri, Aug 05, 2011 at 02:12:48PM +0100, Daniel P. Berrange wrote: Because you cannot change O_DIRECT on an open fd :(. This is why we're going through this pain. >>> >>> Hmm, I

Re: [Qemu-devel] [PATCH 1/7] Export the unassigned_mem read/write functions.

2011-08-05 Thread Richard Henderson
On 08/04/2011 04:58 PM, Edgar E. Iglesias wrote: > QEMU only models the data lanes so I think Richards patch is quite OK > because it brings the decission back to the CPU model. > > I would prefer though, if the new Memory API would let devices pass > ctrl data back to the CPU in addition to the d

Re: [Qemu-devel] [PATCH v3 00/39] Memory API, batch 2: PCI devices

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:05 AM, Avi Kivity wrote: This is a mostly mindless conversion of all QEMU PCI devices to the memory API. After this patchset is applied, it is no longer possible to create a PCI device using the old API. An immediate benefit is that PCI BARs that overlap each other are now handl

Re: [Qemu-devel] [PATCH] Permit -mem-path without sync mmu

2011-08-05 Thread Marcelo Tosatti
On Fri, Aug 05, 2011 at 08:16:42AM +0200, Jan Kiszka wrote: > On 2011-08-05 06:02, David Gibson wrote: > > At present, an explicit test disallows use of -mem-path when kvm is enabled > > but KVM_CAP_SYNC_MMU is not set. In particular, this prevents the user > > from using hugetlbfs to back the gue

Re: [Qemu-devel] [PATCH v3 29/39] sun4u: convert to memory API

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: fixes memory leak on repeated BAR map/unmap Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/sun4u.c | 55 +-- 1 files changed, 25 insertions(+), 30 deletions(-) diff --git a/hw/sun

Re: [Qemu-devel] [PATCH v3 28/39] isa-mmio: concert to memory API

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity For the subject, s:concert:convert:g Otherwise, Reviewed-by: Anthony Liguori --- hw/isa.h |2 ++ hw/isa_mmio.c | 30 +++--- 2 files changed, 17 insertio

Re: [Qemu-devel] [PATCH v3 25/39] ne2000: convert to memory API

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/ne2000-isa.c | 14 +++--- hw/ne2000.c | 77 +- hw/ne2000.h |8 + 3 files changed, 59 insertions(+), 40 deletio

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-05 Thread Stefan Hajnoczi
On Fri, Aug 5, 2011 at 3:28 PM, Christoph Hellwig wrote: > On Fri, Aug 05, 2011 at 02:12:48PM +0100, Daniel P. Berrange wrote: >> > Because you cannot change O_DIRECT on an open fd :(.  This is why >> > we're going through this pain. >> >> Hmm, I remember hearing that before, but looking at the cu

Re: [Qemu-devel] [PATCH v3 17/39] es1370: convert to memory API

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/es1370.c | 43 +-- 1 files changed, 25 insertions(+), 18 deletions(-) diff --git a/h

Re: [Qemu-devel] [PATCH v3 16/39] eepro100: convert to memory API

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: Note: the existing code aliases the flash BAR into the MMIO bar. This is probably a bug. This patch does not correct the problem. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity Reviewed-by: Anthony Liguori Regards, Anthony Liguori ---

Re: [Qemu-devel] [PATCH v3 15/39] e1000: convert to memory API

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/e1000.c | 114 +-- 1 files changed, 48 insertions(+), 66 deletions(-)

[Qemu-devel] [PATCH V4] e1000: Handle IO Port.

2011-08-05 Thread Anthony PERARD
This patch introduces the two IOPorts on e1000, IOADDR and IODATA. The IOADDR is used to specify which register we want to access when we read or write on IODATA. This patch fixes some weird behavior that I see when I use e1000 with QEMU/Xen, the guest memory can be corrupted by this NIC because i

[Qemu-devel] [PATCH] e1000: Do reset when E1000_CTRL_RST bit is set.

2011-08-05 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- hw/e1000.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index 96d84f9..a1388e9 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -150,6 +150,8 @@ static const char phy_regcap[0x20] = { [PHY_ID2] = PHY_R,

[Qemu-devel] [PATCH][qemu-iotests] Test loading internal snapshots

2011-08-05 Thread Kevin Wolf
Test loading internal snapshots where the L1 table of the snapshot is smaller than the current L1 table. Signed-off-by: Kevin Wolf --- 029 | 65 +++ 029.out | 10 + group |1 + 3 files changed, 76 insertions(+), 0

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-05 Thread Christoph Hellwig
On Fri, Aug 05, 2011 at 02:12:48PM +0100, Daniel P. Berrange wrote: > > Because you cannot change O_DIRECT on an open fd :(. This is why > > we're going through this pain. > > Hmm, I remember hearing that before, but looking at the current fcntl() > manpage, it claims you *can* change O_DIRECT us

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-05 Thread Christoph Hellwig
On Fri, Aug 05, 2011 at 10:27:00AM +0100, Stefan Hajnoczi wrote: > > Why not do the latter unconditionally? > > Because you cannot change O_DIRECT on an open fd :(. This is why > we're going through this pain. You can. What you can't right now is O_SYNC, but we're going to change that.

Re: [Qemu-devel] [PATCH v3 14/39] ac97: convert to memory API

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: fixes BAR sizing as well. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity Reviewed-by: Anthony Liguori Malc, please Ack Regards, Anthony Liguori --- hw/ac97.c | 88 +++- 1 fil

Re: [Qemu-devel] [PATCH v3 13/39] rtl8139: convert to memory API

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/rtl8139.c | 72 ++--- 1 files changed, 38 insertions(+), 34 deletions(-) diff --git a/hw/rtl8139.c b/hw/rtl8139.c index 5214b8c..dfba

Re: [Qemu-devel] [PATCH 03/16] Add iov_clear()

2011-08-05 Thread Gerd Hoffmann
On 08/05/11 13:30, Kevin Wolf wrote: Am 04.08.2011 17:10, schrieb Gerd Hoffmann: Fill the spefified area with zeros. Signed-off-by: Gerd Hoffmann Looks like we're starting to duplicate everything in qemu_iovec_* and iov_*... Any reason not to use QEMUIOVector? I *do* use QEMUIOVector, but

Re: [Qemu-devel] [PATCH v3 12/39] pci: allow I/O BARs to be registered with pci_register_bar_region()

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/pci.c | 43 +++ hw/pci.h |1 + hw/pci_internals.h |3 ++-

Re: [Qemu-devel] [PATCH v3 11/39] pci: pass I/O address space to new PCI bus

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: This lets us register BARs in the I/O address space. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity Reviewed-by: Anthony Liguori Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v3 10/39] Integrate I/O memory regions into qemu

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: get_system_io() returns the root I/O memory region. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- exec-memory.h |2 ++ exec.c| 10 ++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/exec-memory.h b

Re: [Qemu-devel] [PATCH v3 09/39] cirrus: simplify linear framebuffer access functions

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/cirrus_vga.c | 74

Re: [Qemu-devel] [PATCH v3 08/39] vga: simplify vga window mmio access functions

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. We have to keep vga_mem_{read,write}b() since they're used by cirrus. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity Reviewed-by: Anthony

Re: [Qemu-devel] [PATCH v3 07/39] cirrus: simplify vga window mmio access functions

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/cirrus_vga.c | 79

Re: [Qemu-devel] [PATCH v3 06/39] cirrus: simplify bitblt BAR access functions

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/cirrus_vga.c | 81

Re: [Qemu-devel] [PATCH v3 05/39] cirrus: simplify mmio BAR access functions

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity -static uint64_t cirrus_mmio_read(void *opaque, target_phys_addr_t addr, -

Re: [Qemu-devel] [PATCH v3 05/39] cirrus: simplify mmio BAR access functions

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/cirrus_vga.c | 78 +- 1 files

Re: [Qemu-devel] [PATCH v3 04/39] vga: convert vga and its derivatives to the memory API

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: Convert all vga memory to the memory API. Note we need to fall back to get_system_memory(), since the various buses don't pass the vga window as a memory region. We no longer need to sync the dirty bitmap of the cirrus mapped memory banks, since the mem

Re: [Qemu-devel] [PATCH v3 03/39] vmsvga: don't remember pci BAR address in callback any more

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:05 AM, Avi Kivity wrote: We're going to remove the callback, so we can't use it to save the address. Use the pci API instead. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/vmware_vga.c | 12 +

Re: [Qemu-devel] [PATCH v3 02/39] pci: add API to get a BAR's mapped address

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:05 AM, Avi Kivity wrote: This is a hack, for devices that have a back-channel to read this address back outside the normal configuration mechanisms, such as VMware svga. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity Can we add a comment to the header file to this ef

Re: [Qemu-devel] [PATCH v3 01/39] virtio-pci: get config on init

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:05 AM, Avi Kivity wrote: From: "Michael S. Tsirkin" We originally did get config on map, so that following write accesses are done on an updated config. New memory API doesn't give us a callback on map, and arguably, devices don't know when cpu really can access there. So updati

Re: [Qemu-devel] [PATCH] target-arm: upgrade for secondary cpu bootloader

2011-08-05 Thread Evgeny Voevodin
From 4c843ce18a7534e722670ecb892a2dedd3eae5b3 Mon Sep 17 00:00:00 2001 From: Evgeny Voevodin Date: Fri, 5 Aug 2011 17:24:48 +0400 Subject: [PATCH 1/1] target-arm: Add new secondary CPU bootloader Secondary CPU bootloader enables interrupt and issues wfi until start address is written to system

[Qemu-devel] [PATCH 1/3] slirp: Fix types of IP address parameters

2011-08-05 Thread Jan Kiszka
Should be uint32_t for IPv4, not int. Also avoid in_addr_t without proper includes. Fixes build regression on mingw32. Signed-off-by: Jan Kiszka --- slirp/arp_table.c | 16 slirp/slirp.h |4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/slirp/ar

[Qemu-devel] [PATCH 0/3] [PULL] slirp: ARP table related fixes

2011-08-05 Thread Jan Kiszka
The following changes since commit 81e34a2401f7ffd519bb7f093e833cb48734169f: Merge remote-tracking branch 'mst/for_anthony' into staging (2011-08-04 17:15:22 -0500) are available in the git repository at: git://git.kiszka.org/qemu.git queues/slirp Fixes some fall-outs from the latest merge

[Qemu-devel] [PATCH 2/3] slirp: Read current time only once per if_start call

2011-08-05 Thread Jan Kiszka
No need to update the current time for each packet we send from the queue. Processing time is comparably short. Signed-off-by: Jan Kiszka --- slirp/if.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/slirp/if.c b/slirp/if.c index 2d79e45..47bebe4 100644 --- a/slirp/

[Qemu-devel] [PATCH 3/3] slirp: Only start packet expiration for delayed ones

2011-08-05 Thread Jan Kiszka
The expiration timeout must only affect packets that are queued due to pending ARP resolutions. The old version broke ping e.g. Signed-off-by: Jan Kiszka --- slirp/if.c|3 --- slirp/slirp.c |3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/slirp/if.c b/slirp/if.c

Re: [Qemu-devel] [PATCH V2] Add "tee" option to qemu char device

2011-08-05 Thread Anthony Liguori
On 08/04/2011 09:26 PM, Chun Yan Liu wrote: Alex& Anthony, About this issue, how should we proceed? Do the logging somewhere else in the Xen toolchain. Regards, Anthony Liguori

Re: [Qemu-devel] qcow2x

2011-08-05 Thread Kevin Wolf
Am 05.08.2011 15:16, schrieb Frediano Ziglio: > 2011/8/5 Kevin Wolf : >> Am 03.08.2011 15:39, schrieb Frediano Ziglio: >>> 2011/8/2 Kevin Wolf : Am 02.08.2011 17:29, schrieb Frediano Ziglio: >>> - L2 allocation can be done with relative data (this is not easy to do >>> with current cod

Re: [Qemu-devel] qcow2x

2011-08-05 Thread Frediano Ziglio
2011/8/5 Kevin Wolf : > Am 03.08.2011 15:39, schrieb Frediano Ziglio: >> 2011/8/2 Kevin Wolf : >>> Am 02.08.2011 17:29, schrieb Frediano Ziglio: >> - L2 allocation can be done with relative data (this is not easy to do >> with current code) > > What do you mean by that? > >

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-05 Thread Daniel P. Berrange
On Fri, Aug 05, 2011 at 10:27:00AM +0100, Stefan Hajnoczi wrote: > On Fri, Aug 5, 2011 at 10:04 AM, Paolo Bonzini wrote: > > On 08/05/2011 10:40 AM, Stefan Hajnoczi wrote: > >> > >> 4. Implement bdrv_reopen() > >> > >> First call bdrv_extract_fds() to stash the file descriptors, then close > >> th

Re: [Qemu-devel] [PATCH] target-arm: upgrade for secondary cpu bootloader

2011-08-05 Thread Peter Maydell
On 5 August 2011 13:10, Evgeny Voevodin wrote: > On 08/05/2011 03:35 PM, Peter Maydell wrote: >> What's the motivation for this? (ie what target board needs this?) > > The motivation is that Samsung s5pc210 board which is under development > needs this. Also, I believe that more boards will need i

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-05 Thread Stefan Hajnoczi
On Fri, Aug 5, 2011 at 10:55 AM, Paolo Bonzini wrote: > On 08/05/2011 11:27 AM, Stefan Hajnoczi wrote: First call bdrv_extract_fds() to stash the file descriptors, then close the block device.  Try opening the new image but if that fails, reopen using the stashed file desc

Re: [Qemu-devel] [PATCH 2/2] i_generation / st_gen support for handle based fs driver

2011-08-05 Thread Stefan Hajnoczi
On Fri, Aug 5, 2011 at 12:32 PM, Aneesh Kumar K.V wrote: > On Fri, 5 Aug 2011 10:24:42 +0100, Stefan Hajnoczi wrote: >> On Fri, Aug 5, 2011 at 7:40 AM, Aneesh Kumar K.V >> wrote: >> > On Thu, 4 Aug 2011 22:57:34 +0100, Stefan Hajnoczi >> > wrote: >> >> On Thu, Aug 4, 2011 at 7:45 PM, Aneesh Ku

Re: [Qemu-devel] qcow2x

2011-08-05 Thread Kevin Wolf
Am 03.08.2011 15:39, schrieb Frediano Ziglio: > 2011/8/2 Kevin Wolf : >> Am 02.08.2011 17:29, schrieb Frediano Ziglio: > - L2 allocation can be done with relative data (this is not easy to do > with current code) What do you mean by that? >>> >>> Let's take an example. By all

Re: [Qemu-devel] [PATCH v3] qcow2: Fix L1 table size after bdrv_snapshot_goto

2011-08-05 Thread Anthony Liguori
On 08/05/2011 05:06 AM, Kevin Wolf wrote: When loading an internal snapshot whose L1 table is smaller than the current L1 table, the size of the current L1 would be shrunk to the snapshot's L1 size in memory, but not on disk. This lead to incorrect refcount updates and eventuelly to image corrupt

Re: [Qemu-devel] Update to 0.15.0 release schedule

2011-08-05 Thread Anthony Liguori
On 08/05/2011 06:38 AM, Kevin Wolf wrote: Am 04.08.2011 23:38, schrieb Anthony Liguori: Hi, It took a little longer than I had hoped to converge on a work around for the migration issue. -rc2 is out but I don't think 24 hours is enough time to get proper testing for the final release. So I'm

  1   2   >