Re: [Qemu-devel] [PATCH] do not call monitor_resume() from migrate_fd_put_buffer() error path

2011-08-04 Thread Michael Tokarev
05.08.2011 02:19, Jan Kiszka wrote: [] > Resume on error in migrate_fd_put_buffer raced with migrate_fd_cleanup > triggered via migrate_fd_put_ready called from migrate_fd_connect. > > This migration code is a horrible maze. Patch below tries to move > monitor_resume a bit out of this. Please chec

[Qemu-devel] [v6 Patch 0/4]Qemu: Set host pagecache from cmdline and monitor

2011-08-04 Thread Supriya Kannery
Currently cache setting of a block device cannot be changed without restarting a running VM. Following patchset is for enabling dynamic change of cache setting for block devices through qemu monitor. Code changes are based on patches from Christoph Hellwig and Prerna Saxena. This patchset introd

[Qemu-devel] [v6 Patch 4/4]Qemu: Add commandline -drive option 'hostcache'

2011-08-04 Thread Supriya Kannery
qemu command option 'hostcache' added to -drive for block devices. While starting a VM from qemu commandline, this option can be used for setting host cache usage for block data access. It is not allowed to specify both 'hostcache' and 'cache' options in the same commandline. Signed-off-by: Sup

[Qemu-devel] [v6 Patch 3/4]Qemu: Command "block_set_hostcache" for dynamic hostcache change

2011-08-04 Thread Supriya Kannery
New command "block_set_hostcache" added for dynamically changing host pagecache setting of a block device. Signed-off-by: Supriya Kannery --- block.c | 54 ++ block.h |2 ++ blockdev.c | 26 +++

[Qemu-devel] [v6 Patch 2/4]Qemu: qerrors for file reopen and data sync

2011-08-04 Thread Supriya Kannery
New error classes defined for file reopen failure and data sync error Signed-off-by: Supriya Kannery --- qerror.c |8 qerror.h |6 ++ 2 files changed, 14 insertions(+) Index: qemu/qerror.c === --- qemu.orig/qe

[Qemu-devel] [v6 Patch 1/4]Qemu: Enhance "info block" to display host cache setting

2011-08-04 Thread Supriya Kannery
Enhance "info block" to display hostcache setting for each block device. Example: (qemu) info block ide0-hd0: type=hd removable=0 file=../rhel6-32.qcow2 ro=0 drv=qcow2 encrypted=0 Enhanced to display "hostcache" setting: (qemu) info block ide0-hd0: type=hd removable=0 hostcache=1 file=../rhel6-32

Re: [Qemu-devel] [PATCH 2/2] i_generation / st_gen support for handle based fs driver

2011-08-04 Thread Aneesh Kumar K.V
On Thu, 4 Aug 2011 22:57:34 +0100, Stefan Hajnoczi wrote: > On Thu, Aug 4, 2011 at 7:45 PM, Aneesh Kumar K.V > wrote: > > On Thu, 4 Aug 2011 15:31:08 +0100, Stefan Hajnoczi > > wrote: > >> On Thu, Aug 4, 2011 at 1:03 PM, Aneesh Kumar K.V > >> wrote: > >> > On Thu, 4 Aug 2011 12:47:42 +0100, St

Re: [Qemu-devel] [PATCH v2 0.15.0] qcow2: Fix L1 table size after bdrv_snapshot_goto

2011-08-04 Thread Frediano Ziglio
2011/8/4 Kevin Wolf : > When loading an internal snapshot whose L1 table is smaller than the current > L1 > table, the size of the current L1 would be shrunk to the snapshot's L1 size in > memory, but not on disk. This lead to incorrect refcount updates and > eventuelly > to image corruption. > >

[Qemu-devel] [Bug 821289] [NEW] qemu mac segfault

2011-08-04 Thread Stevan Vucenovic
Public bug reported: qemu-0.14.1 ./configure --target-list=i386-softmmu,x86_64-softmmu,arm-softmmu qemu(-system-(x86_64|arm)) > Segmentation fault: 11 ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-m

[Qemu-devel] Build broken

2011-08-04 Thread malc
/home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c: In function 'coroutine_new': /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:160:16: error: 'arg.i[1]' may be used uninitialized in this function /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:136:18: note: 'arg.i[1]' was declared here dif

Re: [Qemu-devel] [PATCH] Permit -mem-path without sync mmu

2011-08-04 Thread Jan Kiszka
On 2011-08-05 06:02, David Gibson wrote: > At present, an explicit test disallows use of -mem-path when kvm is enabled > but KVM_CAP_SYNC_MMU is not set. In particular, this prevents the user > from using hugetlbfs to back the guest memory. > > I can see no reason for this check, and when I asked

Re: [Qemu-devel] read-only IDE drives in qemu

2011-08-04 Thread Frédéric Dreier
Hi, Now I understand why read-only IDE support was dropped. I will investigate if I could use read-only virtio disks for my purpose. Thank you for your response and for the hints, Best regards, Frederic Le 4 août 2011 20:20, Markus Armbruster a écrit : > Frédéric Dreier writes: > > > Hi,

Re: [Qemu-devel] [ANNOUNCE] QEMU 0.15.0-rc1 Release

2011-08-04 Thread Stefan Hajnoczi
On Thu, Aug 4, 2011 at 4:20 PM, Lucas Meneghel Rodrigues wrote: > On 08/04/2011 12:17 PM, Stefan Hajnoczi wrote: >> >> On Sat, Jul 30, 2011 at 1:39 AM, Anthony Liguori >>  wrote: >>> >>> On behalf of the entire QEMU team, I'm please to announce the release of >>> QEMU 0.15.0-rc1.  This is the sec

Re: [Qemu-devel] TCG optimizations broke ppc64 target

2011-08-04 Thread Stefan Weil
Am 05.08.2011 05:45, schrieb David Gibson: Commit 22613af4a6d9602001e6d0e7b6d98aa40aa018dc 'Add copy and constant propagation' seems to break TCG emulation of the ppc64 target, at least as we use it on the pseries machine. After this patch, attempting to boot a kernel results in an abort() a sho

[Qemu-devel] TCG optimizations broke ppc64 target

2011-08-04 Thread David Gibson
Commit 22613af4a6d9602001e6d0e7b6d98aa40aa018dc 'Add copy and constant propagation' seems to break TCG emulation of the ppc64 target, at least as we use it on the pseries machine. After this patch, attempting to boot a kernel results in an abort() a short way into the boot: /home/dwg/ibm/kvm/qemu

[Qemu-devel] [PATCH] Permit -mem-path without sync mmu

2011-08-04 Thread David Gibson
At present, an explicit test disallows use of -mem-path when kvm is enabled but KVM_CAP_SYNC_MMU is not set. In particular, this prevents the user from using hugetlbfs to back the guest memory. I can see no reason for this check, and when I asked about it previously, the only theory offered was t

[Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2011-08-04 Thread Rick Vernam
Continues to occur with recently updated qxl, vdagent & virtio serial windows binaries from spice-space.org. Also continues with qemu-kvm-0.15.0-rc1, qemu-0.15.0-rc1 & qemu-0.15.0-rc2 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. h

Re: [Qemu-devel] [PATCH v4 2/3] The support for block queue

2011-08-04 Thread Zhi Yong Wu
On Tue, Aug 2, 2011 at 4:21 AM, Ryan Harper wrote: > * Zhi Yong Wu [2011-08-01 01:30]: > >> +static AIOPool block_queue_pool = { >> +    .aiocb_size         = sizeof(struct BlockDriverAIOCB), >> +    .cancel             = qemu_block_queue_cancel, >> +}; >> + >> +static void qemu_block_queue_callb

Re: [Qemu-devel] [PATCH v4 3/3] The support for queue timer and throttling algorithm

2011-08-04 Thread Zhi Yong Wu
On Tue, Aug 2, 2011 at 4:39 AM, Ryan Harper wrote: > * Zhi Yong Wu [2011-08-01 01:32]: >> Note: >>       1.) When bps/iops limits are specified to a small value such as 511 >> bytes/s, this VM will hang up. We are considering how to handle this senario. >>       2.) When "dd" command is issued i

Re: [Qemu-devel] [PATCH V2] Add "tee" option to qemu char device

2011-08-04 Thread Chun Yan Liu
Alex & Anthony, About this issue, how should we proceed? Chunyan >>> Anthony Liguori 07/24/11 9:25 PM >>> On 07/24/2011 04:47 AM, Alexander Graf wrote: > >> These arguments all apply to any possible option. Why not a grep target? >> Why not a cut or less target? > > Because they don't make s

Re: [Qemu-devel] [PATCH v4 0/3] The intro for QEMU disk I/O limits

2011-08-04 Thread Zhi Yong Wu
On Tue, Aug 2, 2011 at 4:06 AM, Ryan Harper wrote: > * Zhi Yong Wu [2011-08-01 01:30]: >> The main goal of the patch is to effectively cap the disk I/O speed or >> counts of one single VM.It is only one draft, so it unavoidably has some >> drawbacks, if you catch them, please let me know. >> >>

Re: [Qemu-devel] [PATCH v1] qmp/hmp: add block_set_io_throttle and enhance query_block

2011-08-04 Thread Zhi Yong Wu
On Thu, Aug 4, 2011 at 9:07 PM, Stefan Hajnoczi wrote: > On Thu, Aug 4, 2011 at 5:34 AM, Zhi Yong Wu wrote: >> @@ -1387,6 +1422,11 @@ void bdrv_set_io_limits(BlockDriverState *bs, >>  { >>     memset(&bs->io_limits, 0, sizeof(BlockIOLimit)); >>     bs->io_limits = *io_limits; >> +    if (bdrv_io_

Re: [Qemu-devel] Time to cut a new release?

2011-08-04 Thread Kevin O'Connor
On Thu, Aug 04, 2011 at 02:10:10PM -0500, Anthony Liguori wrote: > On 08/04/2011 01:49 PM, Gerd Hoffmann wrote: > >Hi, > > > >A bunch of new stuff has been added to master since the last version, > >time to release a new one? Especially I'd like to see qemu get a seabios > >update, and anthony pref

Re: [Qemu-devel] ethlite mac on virtex board

2011-08-04 Thread Edgar E. Iglesias
On Thu, Aug 04, 2011 at 05:31:37PM +0800, Lê Đức Tài wrote: > On Aug 08, 2011 15:13, "Lê Đức Tài" wrote: > > > > > > > > Hi Edgar, > > I have a problem with Ethernet Lite on Virtex board as following. > > Could you help me? > > Thank you! > > > _

Re: [Qemu-devel] [PATCH] linux-user: Fix indirect syscall handling for MIPS

2011-08-04 Thread An-Cheng Huang
On Thu, Aug 04, 2011 at 11:43:31PM +0100, Peter Maydell wrote: > On 4 August 2011 23:16, An-Cheng Huang wrote: > > A simpler approach would be to just change the number of arguments for > > sys_syscall to 8 in the mips_syscall_args table so that for indirect > > syscalls the "higher" arguments are

Re: [Qemu-devel] [PATCH 1/7] Export the unassigned_mem read/write functions.

2011-08-04 Thread Edgar E. Iglesias
On Sun, Jul 24, 2011 at 01:56:00PM -0500, Anthony Liguori wrote: > On 07/24/2011 11:42 AM, Richard Henderson wrote: > >On 07/24/2011 06:28 AM, Anthony Liguori wrote: > >>On 07/23/2011 02:17 PM, Richard Henderson wrote: > >>>Signed-off-by: Richard Henderson > >> > >>Why? > > > >So that I can write i

Re: [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimum

2011-08-04 Thread Edgar E. Iglesias
On Tue, Jun 28, 2011 at 09:34:16AM +0100, Stefan Hajnoczi wrote: > On Mon, Jun 27, 2011 at 5:12 PM, Fabien Chouteau wrote: > > On 27/06/2011 17:39, Stefan Hajnoczi wrote: > >> On Mon, Jun 27, 2011 at 3:23 PM, Fabien Chouteau > >> wrote: > >>> On 27/06/2011 15:50, Stefan Hajnoczi wrote: > On

Re: [Qemu-devel] [PATCH] Fix forcing multicast msgs to loopback on OpenBSD.

2011-08-04 Thread Brad
- Original message - > On Fri, Jul 29, 2011 at 07:15:11PM -0400, Brad wrote: > > Fix forcing multicast msgs to loopback on OpenBSD. > > > > e.g. > > $ sudo qemu -m 128 -no-fd-bootchk \ > > -hda virtual.img -boot n -nographic \ > > -net nic,vlan=0,model=rtl8139,macaddr=52:54:00:12:34:03 \ >

Re: [Qemu-devel] [PULL] pci, virtio, net

2011-08-04 Thread Anthony Liguori
On 08/01/2011 09:27 AM, Michael S. Tsirkin wrote: The following changes since commit d1afc48b7cfdb4490f322d5d82a2aae6d545ec06: SPARC64: implement addtional MMU faults related to nonfaulting load (2011-07-21 20:02:22 +) are available in the git repository at: git://git.kernel.org/pub/

Re: [Qemu-devel] [PULL] libcacard install fix

2011-08-04 Thread Anthony Liguori
On 08/02/2011 07:00 AM, Alon Levy wrote: Hi Anthony, This is a simple fix to make sure the permissions of data files installed with the make libcacard-install rule are not executable. Please pull, Alon Pulled. Thanks. Regards, Anthony Liguori The following changes since commit 927d721777

Re: [Qemu-devel] [PULL 0/3] Trivial patches for July 28 to August 3 2011

2011-08-04 Thread Anthony Liguori
On 08/03/2011 05:20 AM, Stefan Hajnoczi wrote: The following changes since commit 927d721777e73339f73719f36eaf400ab641366c: microblaze: Add missing call to qemu_init_vcpu. (2011-07-31 06:40:13 +0200) are available in the git repository at: ssh://repo.or.cz/srv/git/qemu/stefanha.git trivia

Re: [Qemu-devel] [PULL] spice: async i/o for qxl

2011-08-04 Thread Anthony Liguori
On 08/03/2011 05:37 AM, Gerd Hoffmann wrote: Hi, This spice/qxl pull fixes (for the most part) a design flaw in the qxl device interface. Some write operations to qxl I/O ports are blocking, i.e. they wait for the spice server finish some work, then return to the guest. Which adds noticable

Re: [Qemu-devel] [PATCH] linux-user: Fix indirect syscall handling for MIPS

2011-08-04 Thread Peter Maydell
On 4 August 2011 23:16, An-Cheng Huang wrote: > I ran into the problem of indirect syscalls not working with > mips-linux-user and found that the number of arguments for sys_syscall > is 0 in the mips_syscall_args table, which means the "higher" arguments > (5, 6, 7, and 8) are never obtained from

Re: [Qemu-devel] [PATCH 0/3] [PULL] slirp: ARP table improvements

2011-08-04 Thread Anthony Liguori
On 08/03/2011 06:24 AM, Jan Kiszka wrote: The following changes since commit 927d721777e73339f73719f36eaf400ab641366c: microblaze: Add missing call to qemu_init_vcpu. (2011-07-31 06:40:13 +0200) are available in the git repository at: git://git.kiszka.org/qemu.git queues/slirp Anthony as

Re: [Qemu-devel] [PULL] usb patch queue: iovecs, hid split, misc fixes

2011-08-04 Thread Anthony Liguori
On 08/04/2011 10:10 AM, Gerd Hoffmann wrote: Hi, Major changes in the USB patch queue: * The USBPacket payload is represented as iovec instead of a linear buffer. This allows to kill some copying and buffering. * The HID code is splitted into hw/hid.[ch], keeping only the usb in

[Qemu-devel] [PATCH] fw_cfg: Simplify error paths and avoid warnings

2011-08-04 Thread Edgar E. Iglesias
master branch doesnt build due to 3d3b8303c6f83b9b245bc774af530a6403cc4ce6 hw/fw_cfg.c: In function ‘probe_splashfile’: hw/fw_cfg.c:66:9: error: variable ‘fop_ret’ set but not used [-Werror=unused-but-set-variable] hw/fw_cfg.c: In function ‘fw_cfg_bootsplash’: hw/fw_cfg.c:130:9: error: variable ‘

Re: [Qemu-devel] [PATCH] do not call monitor_resume() from migrate_fd_put_buffer() error path

2011-08-04 Thread Jan Kiszka
On 2011-08-04 22:00, Michael Tokarev wrote: > 04.08.2011 23:52, Michael Tokarev пишет: >> 04.08.2011 23:24, Luiz Capitulino пишет: >>> On Wed, 3 Aug 2011 18:51:44 +0400 >>> Michael Tokarev wrote: >>> If we do, it results in double monitor_resume() (second being called from migrate_fd_cl

[Qemu-devel] [PATCH] linux-user: Fix indirect syscall handling for MIPS

2011-08-04 Thread An-Cheng Huang
I ran into the problem of indirect syscalls not working with mips-linux-user and found that the number of arguments for sys_syscall is 0 in the mips_syscall_args table, which means the "higher" arguments (5, 6, 7, and 8) are never obtained from the stack for the do_syscall() invocation for indir

[Qemu-devel] [PATCH] when overriding default tool names don't add cross-prefix

2011-08-04 Thread Stuart yoder
From: Stuart Yoder When overriding a tool name via a shell variable, don't tack on the cross-prefix. This specifically allows the pkg-config command to be overridden and work where it does not exist in some cross build environments. Signed-off-by: Stuart Yoder --- configure | 16 ---

Re: [Qemu-devel] [PATCH] guest agent: add --enable-guest-agent config option

2011-08-04 Thread Anthony Liguori
On 08/01/2011 02:52 PM, Michael Roth wrote: QAPI will require glib/python, but for now the guest agent is the only user. For now, make these dependencies an explicit guest agent one, and give users the option to disable it if need be. Once QAPI is adopted in core QEMU code, we would basically re

Re: [Qemu-devel] [PATCH] Add support for finding libpng via pkg-config

2011-08-04 Thread Anthony Liguori
On 07/30/2011 12:45 AM, Brad wrote: Add support for finding libpng via pkg-config. Signed-off-by: Brad Smith Applied. Thanks. Regards, Anthony Liguori --- configure |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 4012d15..25aa7

Re: [Qemu-devel] [PULL 00/29] Block patches

2011-08-04 Thread Anthony Liguori
On 08/03/2011 09:13 AM, Kevin Wolf wrote: The following changes since commit 927d721777e73339f73719f36eaf400ab641366c: microblaze: Add missing call to qemu_init_vcpu. (2011-07-31 06:40:13 +0200) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Pulled.

Re: [Qemu-devel] [PATCH 2/2] i_generation / st_gen support for handle based fs driver

2011-08-04 Thread Stefan Hajnoczi
On Thu, Aug 4, 2011 at 7:45 PM, Aneesh Kumar K.V wrote: > On Thu, 4 Aug 2011 15:31:08 +0100, Stefan Hajnoczi wrote: >> On Thu, Aug 4, 2011 at 1:03 PM, Aneesh Kumar K.V >> wrote: >> > On Thu, 4 Aug 2011 12:47:42 +0100, Stefan Hajnoczi >> > wrote: >> >> On Thu, Aug 4, 2011 at 12:20 PM, Aneesh Ku

Re: [Qemu-devel] [ANNOUNCE] QEMU 0.15.0-rc2 Release

2011-08-04 Thread Anthony Liguori
On 08/04/2011 04:33 PM, Anthony Liguori wrote: Hi, On behalf of the entire QEMU team, I'm please to announce the release of QEMU 0.15.0-rc2. This is the third and final release candidate for the 0.15.0 release. There are numerous ways you can help participate in the 0.15.0 release. There is a t

Re: [Qemu-devel] [PULL] pci, virtio, net

2011-08-04 Thread Anthony Liguori
On 08/03/2011 03:19 AM, Michael S. Tsirkin wrote: On Wed, Aug 03, 2011 at 10:15:03AM +0200, Markus Armbruster wrote: "Michael S. Tsirkin" writes: The following changes since commit d1afc48b7cfdb4490f322d5d82a2aae6d545ec06: SPARC64: implement addtional MMU faults related to nonfaulting loa

[Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2011-08-04 Thread David Rando
I have the same problem. I'm using the packages from the Sergei ppa with spice enabled on a server with 9 windows xp machines and 1 linux (ubuntu 10.04) one. Ubuntu is rock solid and never crash, but the windows machines do randomnly. I've updated everything i could (using the version from spice-sp

[Qemu-devel] Update to 0.15.0 release schedule

2011-08-04 Thread Anthony Liguori
Hi, It took a little longer than I had hoped to converge on a work around for the migration issue. -rc2 is out but I don't think 24 hours is enough time to get proper testing for the final release. So I'm pushing 0.15.0 to Monday. Please test and provide feedback. Unless there's a brown pa

[Qemu-devel] [ANNOUNCE] QEMU 0.15.0-rc2 Release

2011-08-04 Thread Anthony Liguori
Hi, On behalf of the entire QEMU team, I'm please to announce the release of QEMU 0.15.0-rc2. This is the third and final release candidate for the 0.15.0 release. There are numerous ways you can help participate in the 0.15.0 release. There is a testing coordination wiki page located at:

[Qemu-devel] [PATCH] Revert "floppy: save and restore DIR register"

2011-08-04 Thread Anthony Liguori
This reverts commit 7d905f716bea633f2836e1d661387983aacdc6d6. The use of subsections by this commit are broken because of a fundamental limitations of subsections in the current protocol. Signed-off-by: Anthony Liguori --- hw/fdc.c | 51 +-- 1 f

Re: [Qemu-devel] [PATCH] migration: remove subsections in fdc and rtl8139 and bump versions

2011-08-04 Thread Anthony Liguori
On 08/04/2011 02:22 AM, Paolo Bonzini wrote: On 08/03/2011 11:42 PM, Juan Quintela wrote: > I can certainly limit the change to IDE if we think machine, floppy, > and rtl8139 are safe. Ok, only IDE is broken, something done if we are not reverting the others. Floppy is broken too, and has the

Re: [Qemu-devel] [PATCH] do not call monitor_resume() from migrate_fd_put_buffer() error path

2011-08-04 Thread Michael Tokarev
04.08.2011 23:52, Michael Tokarev пишет: > 04.08.2011 23:24, Luiz Capitulino пишет: >> On Wed, 3 Aug 2011 18:51:44 +0400 >> Michael Tokarev wrote: >> >>> If we do, it results in double monitor_resume() (second being called >>> from migrate_fd_cleanup() anyway) and monitor suspend count becoming >

Re: [Qemu-devel] [PATCH] do not call monitor_resume() from migrate_fd_put_buffer() error path

2011-08-04 Thread Michael Tokarev
04.08.2011 23:24, Luiz Capitulino пишет: > On Wed, 3 Aug 2011 18:51:44 +0400 > Michael Tokarev wrote: > >> If we do, it results in double monitor_resume() (second being called >> from migrate_fd_cleanup() anyway) and monitor suspend count becoming >> negative. > > Are you hitting an specific is

Re: [Qemu-devel] [PATCH v3 2/6] Add copy and constant propagation.

2011-08-04 Thread Blue Swirl
On Thu, Aug 4, 2011 at 6:42 PM, Blue Swirl wrote: > On Wed, Aug 3, 2011 at 9:03 PM, Stefan Weil wrote: >> Am 03.08.2011 22:56, schrieb Stefan Weil: >>> >>> Am 03.08.2011 22:20, schrieb Blue Swirl: On Wed, Aug 3, 2011 at 7:00 PM, Stefan Weil wrote: > > Am 07.07.2011 14:37, schri

Re: [Qemu-devel] [PATCH] do not call monitor_resume() from migrate_fd_put_buffer() error path

2011-08-04 Thread Luiz Capitulino
On Wed, 3 Aug 2011 18:51:44 +0400 Michael Tokarev wrote: > If we do, it results in double monitor_resume() (second being called > from migrate_fd_cleanup() anyway) and monitor suspend count becoming > negative. Are you hitting an specific issue or did you find this by code inspection? IIRC, I

Re: [Qemu-devel] qemu-kvm aborts - vhost_dev_unassign_memory: Assertion `to >= 0' failed.

2011-08-04 Thread David Ahern
On 08/04/2011 01:17 PM, Michael S. Tsirkin wrote: > On Thu, Aug 04, 2011 at 12:48:49PM -0600, David Ahern wrote: >> >> >> On 08/03/2011 09:00 AM, Michael S. Tsirkin wrote: >>> On Wed, Aug 03, 2011 at 07:55:47AM -0600, David Ahern wrote: Tested-by: David Ahern David >>> >>> Applied

Re: [Qemu-devel] qemu-kvm aborts - vhost_dev_unassign_memory: Assertion `to >= 0' failed.

2011-08-04 Thread Michael S. Tsirkin
On Thu, Aug 04, 2011 at 12:48:49PM -0600, David Ahern wrote: > > > On 08/03/2011 09:00 AM, Michael S. Tsirkin wrote: > > On Wed, Aug 03, 2011 at 07:55:47AM -0600, David Ahern wrote: > >> Tested-by: David Ahern > >> > >> David > > > > Applied, thanks very much. > > > > I assume this will make

Re: [Qemu-devel] [PATCH] Correctly assign PCI domain numbers

2011-08-04 Thread Michael S. Tsirkin
On Thu, Aug 04, 2011 at 07:00:38PM +1000, David Gibson wrote: > On Wed, Aug 03, 2011 at 04:28:33PM +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 02, 2011 at 12:15:22AM +1000, David Gibson wrote: > > > On Mon, Aug 01, 2011 at 05:03:18PM +0300, Michael S. Tsirkin wrote: > > > > On Mon, Aug 01, 201

Re: [Qemu-devel] Time to cut a new release?

2011-08-04 Thread Anthony Liguori
On 08/04/2011 01:49 PM, Gerd Hoffmann wrote: Hi, A bunch of new stuff has been added to master since the last version, time to release a new one? Especially I'd like to see qemu get a seabios update, and anthony prefers a release instead of a git snapshot for that. What's left in order to enab

[Qemu-devel] [Bug 821078] [NEW] virtio-serial-bus: Unexpected port id

2011-08-04 Thread Rick Vernam
Public bug reported: With qemu-kvm-0.15.0-rc1 virtio-serial-bus reports an error, and windows vdagent can not start. qemu-0.15.0-rc1 behaves as expected, ie vdagent runs in the guest, mouse passes seamlessly between spicec and host and copy/paste works between guest and host. qemu-kvm has been

[Qemu-devel] [Bug 821078] Re: virtio-serial-bus: Unexpected port id

2011-08-04 Thread Rick Vernam
sorry, the output from qemu-kvm which seems to indicate an error is qemu-system-x86_64: virtio-serial-bus: Unexpected port id 3125770964 for device virtio-serial0.0 or sometimes qemu-system-x86_64: virtio-serial-bus: Unexpected port id 47936 for device virtio-serial0.0 -- You received this bug

Re: [Qemu-devel] [PATCH 01/16] re-activate usb-host for bsd

2011-08-04 Thread Gerd Hoffmann
On 08/04/11 20:50, Blue Swirl wrote: On Thu, Aug 4, 2011 at 3:10 PM, Gerd Hoffmann wrote: A bunch of code was disabled via #if 0, for a quite long time (since Sept 2009). Surprisingly the code builds just fine when they are removed (tested on OpenBSD). /me wonders nevertheless whenever there

Re: [Qemu-devel] [PATCH 01/16] re-activate usb-host for bsd

2011-08-04 Thread Blue Swirl
On Thu, Aug 4, 2011 at 3:10 PM, Gerd Hoffmann wrote: > A bunch of code was disabled via #if 0, for a quite long time (since > Sept 2009).  Surprisingly the code builds just fine when they are > removed (tested on OpenBSD).  /me wonders nevertheless whenever there > are any users of those bits when

[Qemu-devel] Time to cut a new release?

2011-08-04 Thread Gerd Hoffmann
Hi, A bunch of new stuff has been added to master since the last version, time to release a new one? Especially I'd like to see qemu get a seabios update, and anthony prefers a release instead of a git snapshot for that. cheers, Gerd

Re: [Qemu-devel] qemu-kvm aborts - vhost_dev_unassign_memory: Assertion `to >= 0' failed.

2011-08-04 Thread David Ahern
On 08/03/2011 09:00 AM, Michael S. Tsirkin wrote: > On Wed, Aug 03, 2011 at 07:55:47AM -0600, David Ahern wrote: >> Tested-by: David Ahern >> >> David > > Applied, thanks very much. > I assume this will make 0.15 since it is a regression? haven't seen the patch applied to that branch yet. Da

Re: [Qemu-devel] [PATCH 2/2] i_generation / st_gen support for handle based fs driver

2011-08-04 Thread Aneesh Kumar K.V
On Thu, 4 Aug 2011 15:31:08 +0100, Stefan Hajnoczi wrote: > On Thu, Aug 4, 2011 at 1:03 PM, Aneesh Kumar K.V > wrote: > > On Thu, 4 Aug 2011 12:47:42 +0100, Stefan Hajnoczi > > wrote: > >> On Thu, Aug 4, 2011 at 12:20 PM, Aneesh Kumar K.V > >> wrote: > >> > On Thu, 4 Aug 2011 11:21:05 +0100, S

Re: [Qemu-devel] [PATCH v3 2/6] Add copy and constant propagation.

2011-08-04 Thread Blue Swirl
On Wed, Aug 3, 2011 at 9:03 PM, Stefan Weil wrote: > Am 03.08.2011 22:56, schrieb Stefan Weil: >> >> Am 03.08.2011 22:20, schrieb Blue Swirl: >>> >>> On Wed, Aug 3, 2011 at 7:00 PM, Stefan Weil wrote: Am 07.07.2011 14:37, schrieb Kirill Batuzov: > > Make tcg_constant_folding do

Re: [Qemu-devel] -vga qxl

2011-08-04 Thread Rick Vernam
On Thursday 04 August 2011 13:15:35 Gerd Hoffmann wrote: >Hi, > > > I recently had black screen problems with QXL in 0.14.x that turned out > > to actually be a Seabios bug due to the default 64MB vram QXL has. > > It is a seabios issue indeed. > > > I suspect > > this would hit 0.15.x build

Re: [Qemu-devel] [PATCH v2 40/45] block: Declare qemu_blockalign() in block.h, not block_int.h

2011-08-04 Thread Luiz Capitulino
On Thu, 04 Aug 2011 20:22:15 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 3 Aug 2011 15:08:19 +0200 > > Markus Armbruster wrote: > > > >> Device models should be able to use it without an unclean include of > >> block_int.h. > > > > Nitpick: I'd do the prototype move

Re: [Qemu-devel] [PATCH v2 40/45] block: Declare qemu_blockalign() in block.h, not block_int.h

2011-08-04 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 3 Aug 2011 15:08:19 +0200 > Markus Armbruster wrote: > >> Device models should be able to use it without an unclean include of >> block_int.h. > > Nitpick: I'd do the prototype move after patch 38/45 and include the > block_int.h removal in the patch you're tri

Re: [Qemu-devel] read-only IDE drives in qemu

2011-08-04 Thread Markus Armbruster
Frédéric Dreier writes: > Hi, > > We are updating some machines in our server farm to Ubuntu natty (KVM / > Opennebula cluster). Since then we used to have some VM with shared > read-only IDE disks to mirror software repositories through several isolated > networks (one-way data diode). > > The u

Re: [Qemu-devel] -vga qxl

2011-08-04 Thread Gerd Hoffmann
Hi, I recently had black screen problems with QXL in 0.14.x that turned out to actually be a Seabios bug due to the default 64MB vram QXL has. It is a seabios issue indeed. I suspect this would hit 0.15.x builds too. If this is what you're hitting, then reducing the vram to 32MB is a tempo

Re: [Qemu-devel] [PATCH v2 40/45] block: Declare qemu_blockalign() in block.h, not block_int.h

2011-08-04 Thread Luiz Capitulino
On Wed, 3 Aug 2011 15:08:19 +0200 Markus Armbruster wrote: > Device models should be able to use it without an unclean include of > block_int.h. Nitpick: I'd do the prototype move after patch 38/45 and include the block_int.h removal in the patch you're trimming block_int.h includes. > > Sign

Re: [Qemu-devel] [PATCH v2 37/45] block: Show whether the guest ejected the medium in info block

2011-08-04 Thread Luiz Capitulino
On Wed, 3 Aug 2011 15:08:16 +0200 Markus Armbruster wrote: > Need to ask the device, so this requires new BlockDevOps member > is_medium_ejected(). > > Signed-off-by: Markus Armbruster Looks good to me. > --- > block.c | 17 +++-- > block.h |6 ++ > hw/

[Qemu-devel] [PATCH 05/10] dma-helpers: add dma_buf_read and dma_buf_write

2011-08-04 Thread Paolo Bonzini
These helpers do a full transfer from an in-memory buffer to target memory, with full support for MMIO areas. It will be used to store the reply of an emulated command into a QEMUSGList provided by the adapter. Signed-off-by: Paolo Bonzini --- cutils.c |8 +++--- dma-helpers.c | 63 +

Re: [Qemu-devel] [PATCH v2 35/45] block: Clean up remaining users of "removable"

2011-08-04 Thread Luiz Capitulino
On Wed, 3 Aug 2011 15:08:14 +0200 Markus Armbruster wrote: > BlockDriverState member removable is a confused mess. It is true when > an ide-cd, scsi-cd or floppy qdev is attached, or when the > BlockDriverState was created with -drive if={floppy,sd} or -drive > if={ide,scsi,xen,none},media=cdro

[Qemu-devel] [PATCH 08/10] scsi-disk: commonize iovec creation between reads and writes

2011-08-04 Thread Paolo Bonzini
Also, consistently use qiov.size instead of iov.iov_len. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 40 ++-- 1 files changed, 18 insertions(+), 22 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 2cb6ff3..37dd9d6 100644 --- a/hw/scsi-d

[Qemu-devel] read-only IDE drives in qemu

2011-08-04 Thread Frédéric Dreier
Hi, We are updating some machines in our server farm to Ubuntu natty (KVM / Opennebula cluster). Since then we used to have some VM with shared read-only IDE disks to mirror software repositories through several isolated networks (one-way data diode). The updated qemu does not allow it. It failed

Re: [Qemu-devel] [PATCH v2 20/45] ide: Provide IDEDeviceInfo method exit()

2011-08-04 Thread Luiz Capitulino
On Wed, 3 Aug 2011 15:07:59 +0200 Markus Armbruster wrote: > > Signed-off-by: Markus Armbruster > --- > hw/ide/internal.h |1 + > hw/ide/qdev.c | 12 > 2 files changed, 13 insertions(+), 0 deletions(-) > > diff --git a/hw/ide/internal.h b/hw/ide/internal.h > index 3e56

[Qemu-devel] [PATCH 03/10] dma-helpers: rewrite completion/cancellation

2011-08-04 Thread Paolo Bonzini
This fixes various problems with completion/cancellation: * If DMA encounters a bounce buffer conflict, and the DMA operation is canceled before the bottom half fires, bad things happen. * memory is not unmapped after cancellation, again causing problems when doing DMA to I/O areas * cancellatio

[Qemu-devel] [PATCH 04/10] dma-helpers: prepare for adding dma_buf_* functions

2011-08-04 Thread Paolo Bonzini
Store in the AIOCB which callback function we are using, and abstract the process of starting DMA. Signed-off-by: Paolo Bonzini --- dma-helpers.c | 22 +- 1 files changed, 13 insertions(+), 9 deletions(-) diff --git a/dma-helpers.c b/dma-helpers.c index d716524..4469ce2 10

[Qemu-devel] [PATCH 09/10] scsi-disk: lazily allocate bounce buffer

2011-08-04 Thread Paolo Bonzini
It will not be needed for reads and writes if the HBA provides a sglist. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 33 ++--- 1 files changed, 22 insertions(+), 11 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 37dd9d6..509407f 100644 --- a/

[Qemu-devel] [PATCH 02/10] dma-helpers: track position in the QEMUSGList

2011-08-04 Thread Paolo Bonzini
The DMA helpers infrastructures cannot at the moment track how many bytes have been actually written, so the users cannot detect short transfers. Adding an accessor to the DMAAIOCB cannot fix this however, because the callback may not have access at all to the AIOCB if the transfer is completed syn

[Qemu-devel] [PATCH 06/10] scsi: pass residual amount to command_complete

2011-08-04 Thread Paolo Bonzini
With the upcoming sglist support, HBAs will not see any transfer_data call and will not have a way to detect short transfers. So pass the residual amount of data upon command completion. Signed-off-by: Paolo Bonzini --- hw/esp.c |3 ++- hw/lsi53c895a.c |2 +- hw/scsi-bus.c|

[Qemu-devel] [PATCH 07/10] scsi: add scatter/gather functionality

2011-08-04 Thread Paolo Bonzini
Scatter/gather functionality uses the newly added DMA helpers. The device can choose between doing DMA itself, or calling scsi_req_data as usual, which will use the newly added DMA helpers to map the destination area(s) piecewise and copy to/from them. Signed-off-by: Paolo Bonzini --- hw/esp.c

[Qemu-devel] [PATCH 01/10] dma-helpers: allow including from target-independent code

2011-08-04 Thread Paolo Bonzini
Target-independent code cannot construct sglists, but it can take them from the outside as a black box. Allow this. Signed-off-by: Paolo Bonzini --- dma.h | 12 qemu-common.h |1 + 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/dma.h b/dma.h index 3d83

[Qemu-devel] [PATCH] Fix DEBUG_* compilation of qcow2.

2011-08-04 Thread Philipp Hahn
By introducing BlockDriverState compiling qcow2 with DEBUG_ALLOC and DEBUG_EXT defined got broken. Define a BdrvCheckResult structure locally which is now needed as the second argument. Also fix qcow2_read_extensions() needing BDRVQcowState. Signed-off-by: Philipp Hahn --- block/qcow2-snapshot.

Re: [Qemu-devel] [PATCH v2 0.15.0] qcow2: Fix L1 table size after bdrv_snapshot_goto

2011-08-04 Thread Philipp Hahn
Hello, On Thursday 04 August 2011 18:24:59 Kevin Wolf wrote: > When loading an internal snapshot whose L1 table is smaller than the > current L1 table, the size of the current L1 would be shrunk to the > snapshot's L1 size in memory, but not on disk. This lead to incorrect > refcount updates and e

Re: [Qemu-devel] -vga qxl

2011-08-04 Thread Rick Vernam
On Thursday 04 August 2011 11:09:30 Daniel P. Berrange wrote: > On Thu, Aug 04, 2011 at 11:03:10AM -0500, Rick Vernam wrote: > > it seems that qxl is not working correctly with any of the 0.15 releases > > thus far. this includes qemu and qemu-kvm. > > > > when I start qemu like so: > > qemu-syst

[Qemu-devel] [PATCH 11/11] sample pvscsi driver with s/g support

2011-08-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs |1 + default-configs/i386-softmmu.mak |1 + default-configs/pci.mak|1 + default-configs/x86_64-softmmu.mak |1 + hw/pci.h |1 + hw/vmw_pvscsi.c| 9

[Qemu-devel] [PATCH 10/10] scsi-disk: enable scatter/gather functionality

2011-08-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 52 +--- 1 files changed, 41 insertions(+), 11 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 509407f..81117d2 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -37,6 +37,7 @@ d

[Qemu-devel] [PATCH 00/10] SCSI scatter/gather support

2011-08-04 Thread Paolo Bonzini
Hi, this is the version of SCSI scatter/gather based on the existing DMA helpers infrastructure. The infrastructure required a little update because I need to know the residual amount of data upon short transfers. To this end, my choice was to make QEMUSGList mutable and track the current positi

[Qemu-devel] [PATCH V2] xen-mapcache: Fix rlimit set size.

2011-08-04 Thread Anthony PERARD
Previously, the address space soft limit was set mcache_max_size. So, before the mcache_max_size was reached by the mapcache, QEMU was killed for overuse of the virtual address space. This patch fix that by setting the soft limit the maximum than can have QEMU. So the soft and hard limit are alway

Re: [Qemu-devel] [PATCH 03/12] char: introduce tx queue to enable Unix style flow control

2011-08-04 Thread Anthony Liguori
On 08/04/2011 11:04 AM, Avi Kivity wrote: On 08/01/2011 05:23 PM, Anthony Liguori wrote: The char layer tries very hard to avoid using an intermediate buffer. The implication of this is that when the backend does a write(), the data for that write must be immediately passed to the front end. Fl

Re: [Qemu-devel] [PATCH 01/12] char: rename qemu_chr_write() to qemu_chr_fe_write()

2011-08-04 Thread Anthony Liguori
On 08/04/2011 11:17 AM, Avi Kivity wrote: On 08/04/2011 07:14 PM, Avi Kivity wrote: Yes, I'm just talking about the function names, not about the implementation. qemu_chr_fe_write(chr,...) -> qemu_chr_write(chr, ...) qemu_chr_be_write(chr, ...) -> qemu_chr_write(&chr->backend, ...) And, if

[Qemu-devel] [PATCH v2 0.15.0] qcow2: Fix L1 table size after bdrv_snapshot_goto

2011-08-04 Thread Kevin Wolf
When loading an internal snapshot whose L1 table is smaller than the current L1 table, the size of the current L1 would be shrunk to the snapshot's L1 size in memory, but not on disk. This lead to incorrect refcount updates and eventuelly to image corruption. Instead of writing the new L1 size to

Re: [Qemu-devel] [PATCH 01/12] char: rename qemu_chr_write() to qemu_chr_fe_write()

2011-08-04 Thread Anthony Liguori
On 08/04/2011 11:14 AM, Avi Kivity wrote: On 08/04/2011 07:11 PM, Anthony Liguori wrote: On 08/04/2011 11:00 AM, Avi Kivity wrote: On 08/01/2011 05:22 PM, Anthony Liguori wrote: The char layer is confusing. There is a front-end, typically a device, that can send and receive data. The front-end

Re: [Qemu-devel] [PATCH 01/12] char: rename qemu_chr_write() to qemu_chr_fe_write()

2011-08-04 Thread Avi Kivity
On 08/04/2011 07:14 PM, Avi Kivity wrote: Yes, I'm just talking about the function names, not about the implementation. qemu_chr_fe_write(chr,...) -> qemu_chr_write(chr, ...) qemu_chr_be_write(chr, ...) -> qemu_chr_write(&chr->backend, ...) And, if you want an internal pipe: QemuPi

[Qemu-devel] [PATCH 0.15.0] qcow2: Fix L1 table size after bdrv_snapshot_goto

2011-08-04 Thread Kevin Wolf
When loading an internal snapshot whose L1 table is smaller than the current L1 table, the size of the current L1 would be shrunk to the snapshot's L1 size in memory, but not on disk. This lead to incorrect refcount updates and eventuelly to image corruption. Instead of writing the new L1 size to

Re: [Qemu-devel] [PATCH 01/12] char: rename qemu_chr_write() to qemu_chr_fe_write()

2011-08-04 Thread Avi Kivity
On 08/04/2011 07:11 PM, Anthony Liguori wrote: On 08/04/2011 11:00 AM, Avi Kivity wrote: On 08/01/2011 05:22 PM, Anthony Liguori wrote: The char layer is confusing. There is a front-end, typically a device, that can send and receive data. The front-end sends data by calling qemu_chr_write(). T

Re: [Qemu-devel] [PATCH 01/12] char: rename qemu_chr_write() to qemu_chr_fe_write()

2011-08-04 Thread Anthony Liguori
On 08/04/2011 11:00 AM, Avi Kivity wrote: On 08/01/2011 05:22 PM, Anthony Liguori wrote: The char layer is confusing. There is a front-end, typically a device, that can send and receive data. The front-end sends data by calling qemu_chr_write(). The back-end, typically created via -chardev, can

  1   2   3   >