Peter Maydell writes:
> If an attempt to create a qdev device on the default sysbus (by passing
> NULL as the bus to qdev_create) fails, print a useful error message
> rather than crashing trying to dereference a NULL pointer.
The special case bus == NULL is ugly, and should be removed. But
rej
Hannes Reinecke writes:
> On 08/03/2011 03:08 PM, Markus Armbruster wrote:
>> Don't fail when tray is already open.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> hw/scsi-bus.c | 10 ++
>> hw/scsi-disk.c | 15 +++
>> hw/scsi.h |4
>> 3 files changed,
On 08/04/2011 08:39 AM, Markus Armbruster wrote:
Hannes Reinecke writes:
On 08/03/2011 03:07 PM, Markus Armbruster wrote:
We already track it in BlockDriverState. Just like tray open/close
state, we should track it in the device models instead, because it's
device state.
Signed-off-by: Mark
On 08/04/2011 08:23 AM, Hannes Reinecke wrote:
On 08/03/2011 03:08 PM, Markus Armbruster wrote:
Breaks migration of qdevs "scsi-cd" and legacy "scsi-disk" to older
versions. We normally use subsections to avoid that. Not possible
here, because we don't have a section to begin with. Too bad.
Sig
On (Mon) 01 Aug 2011 [09:22:58], Anthony Liguori wrote:
> The char layer has been growing some nasty warts for some time now as we ask
> it
> to do things it was never intended on doing. It's been long over due for an
> overhaul and its become evident to me that we need to address this first
> b
Hannes Reinecke writes:
> On 08/03/2011 03:07 PM, Markus Armbruster wrote:
>> We already track it in BlockDriverState. Just like tray open/close
>> state, we should track it in the device models instead, because it's
>> device state.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> hw/scsi-dis
On 08/03/2011 03:08 PM, Markus Armbruster wrote:
Breaks migration of qdevs "scsi-cd" and legacy "scsi-disk" to older
versions. We normally use subsections to avoid that. Not possible
here, because we don't have a section to begin with. Too bad.
Signed-off-by: Markus Armbruster
---
hw/scsi-d
On 08/03/2011 03:08 PM, Markus Armbruster wrote:
When scsi-cd is backed by a physical drive, we want the physical tray
match the virtual one. To that end, we call bdrv_eject() on guest's
load/eject, and bdrv_lock_medium() on guest's prevent/allow removal.
But we don't set the initial state on de
On 08/03/2011 03:08 PM, Markus Armbruster wrote:
Don't fail when tray is already open.
Signed-off-by: Markus Armbruster
---
hw/scsi-bus.c | 10 ++
hw/scsi-disk.c | 15 +++
hw/scsi.h |4
3 files changed, 25 insertions(+), 4 deletions(-)
diff --git a/hw
On 08/03/2011 03:07 PM, Markus Armbruster wrote:
We already track it in BlockDriverState. Just like tray open/close
state, we should track it in the device models instead, because it's
device state.
Signed-off-by: Markus Armbruster
---
hw/scsi-disk.c |4 +++-
1 files changed, 3 insertion
On 08/03/2011 03:07 PM, Markus Armbruster wrote:
We already track it in BlockDriverState since commit 4be9762a. As
discussed in that commit's message, we should track it in the device
device models instead, because it's device state.
Signed-off-by: Markus Armbruster
---
hw/scsi-disk.c |2
On 08/03/2011 03:07 PM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
---
hw/scsi-disk.c | 17 +
1 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index fa198f9..d549cb7 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
For Cavium Specific instructions, please see notes in patch 0 and give your
comments on
target-mips patches.
Thanks.
On Wed, Aug 3, 2011 at 6:20 PM, Rhonda Wittels wrote:
> On 8/3/2011 6:20 AM, Khansa Butt wrote:
>
>> Hi!
>> we are waiting for approval of our Patches for MIPS64 user mode emulatio
I am using ArchLinux 64bit, maybe i should write this bug to their bug report
system.
Anyway my configuration setup is below:
./configure --prefix=/usr \
--sysconfdir=/etc \
--audio-drv-list=alsa,sdl,oss,esd \
--audio-card-list=ac97,sb16,es1370,adli
The brief intro:
This patch is created based on the code V4 for block I/O throttling. It mainly
adds a new qmp/hmp command block_set_io_throttle, and enhances query_block(qmp)
and info block(hmp) to display current I/O throttling settings.
Welcome to all kinds of comments from you.
Signed-off-b
Eric Blake wrote:
> On 08/03/2011 08:37 AM, Jim Fehlig wrote:
>> http://lists.nongnu.org/archive/html/qemu-devel/2011-02/msg01156.html
>>
>> I thought there were more discussions on the topic but can only find the
>> above thread ATM.
>>
>> Do folks here have objections to increasing the migration
Creating streamOptimized subformat. Added subformat option
'streamOptimized', to create a image with compression enabled and each
cluster with a GrainMarker.
Signed-off-by: Fam Zheng
---
block/vmdk.c | 18 --
1 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/block
Added flags field for compressed/streamOptimized extents, open and save
image configuration.
Signed-off-by: Fam Zheng
---
block/vmdk.c | 16
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index bc725be..df93ba5 100644
--- a/block/vm
Add twoGbMaxExtentSparse support. Introduce vmdk_free_last_extent.
Signed-off-by: Fam Zheng
---
block/vmdk.c | 132 --
1 files changed, 82 insertions(+), 50 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index e22a893..be3b860 1006
Add support for reading/writing compressed extent.
Signed-off-by: Fam Zheng
---
block/vmdk.c | 113 +++--
1 files changed, 101 insertions(+), 12 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index df93ba5..da34b9d 100644
--- a/block/v
Factor out read/write extent code, since there will be more things to
take care of once reading/writing compressed clusters is introduced.
Signed-off-by: Fam Zheng
---
block/vmdk.c | 54 +-
1 files changed, 45 insertions(+), 9 deletions(-)
d
Changes from v1:
2/6: add vmdk_free_last_extent, fix qemu_realloc bugs, shorten vmdk_open,
remove unused comment
4/6: fix endianess bug
5/6: simplify qemu_free call, change qemu_mallocz to qemu_malloc, fix
endianess bug
Fam Zheng (6):
VMDK: enable twoGbMaxExtentFlat
VMDK: add tw
Enable the createType 'twoGbMaxExtentFlat'. The supporting code is
already in.
Signed-off-by: Fam Zheng
---
block/vmdk.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 37478d2..e22a893 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@
On Tue, Aug 2, 2011 at 6:32 PM, Stefan Hajnoczi wrote:
> On Wed, Jul 27, 2011 at 10:27 AM, Fam Zheng wrote:
>> Add twoGbMaxExtentSparse support. Only opening code is changed.
>>
>> Signed-off-by: Fam Zheng
>> ---
>> block/vmdk.c | 124
>> ---
On Tue, Aug 02, 2011 at 09:44:49PM -0600, Alex Williamson wrote:
> On Wed, 2011-08-03 at 12:04 +1000, David Gibson wrote:
> > On Tue, Aug 02, 2011 at 12:35:19PM -0600, Alex Williamson wrote:
> > > On Tue, 2011-08-02 at 12:14 -0600, Alex Williamson wrote:
> > > > On Tue, 2011-08-02 at 18:28 +1000, D
On Wed, Aug 03, 2011 at 02:42:15PM +0200, Bjørn Mork wrote:
>But what if additional data is added to
> the table, making f-segment allocation fail? Then you will end up with
> three different results depending on small changes instead of two:
>
> 1) nCPU <= 16 and f-segment allocation OK: SMBIOS
On Wed, Aug 03, 2011 at 03:17:07PM +0200, Gerd Hoffmann wrote:
> On 07/21/11 20:52, Michael Walle wrote:
> >The QEMU keyboard and mouse reports themselves as full speed devices,
> >though they are actually low speed devices. Until this is fixed, claim that
> >we are supporting full speed devices.
>
Convert the PL061 to VMState. We choose to widen the struct members
to uint32_t rather than the other two options of breaking migration
compatibility or using vmstate hacks to read/write a 32 bit value
into an 8 bit struct field.
Signed-off-by: Peter Maydell
---
hw/pl061.c | 174 +++
The main aim of this patchset is to add the GPIOAMSEL register
to the PL061 GPIO module. I've converted the PL061 to VMState format
first, though, because I didn't really feel like adding a new
field/version to an old-style save/load format device...
Notes: the old vmstate format for pl061 is 32 b
Support the GPIOAMSEL register found on some Stellaris boards.
Signed-off-by: Peter Maydell
---
hw/pl061.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/hw/pl061.c b/hw/pl061.c
index 27de824..d13746c 100644
--- a/hw/pl061.c
+++ b/hw/pl061.c
@@ -50,6 +50,7 @@ ty
On 08/01/2011 05:39 AM, rowa wrote:
This error is not fixed in QEMU 0.15.0-rc1
:-(
** Summary changed:
- compile error in QEMU 0.15.0-rc0
+ compile error in QEMU 0.15.0-rc0 and 0.15.0-rc1
I set up an Ubuntu 10.10 64-bit guest (GA, no updates) to test the
build, but I can't seem to reprodu
If an attempt to create a qdev device on the default sysbus (by passing
NULL as the bus to qdev_create) fails, print a useful error message
rather than crashing trying to dereference a NULL pointer.
Signed-off-by: Peter Maydell
---
hw/qdev.c |7 ++-
1 files changed, 6 insertions(+), 1 de
Anthony Liguori wrote:
> On 08/03/2011 04:00 AM, Juan Quintela wrote:
> I don't have a problem with Paolo's new protocol. In fact, I'm strong
> in favor of applying it to master. But I don't like the idea of
> adding a new migration protocol with no testing in master before
> putting it in a re
Add support for the RCC2 register on Fury class devices.
Based on a patch by Vijay Kumar.
Signed-off-by: Engin AYDOGAN
[Peter Maydell: fixed comment typos, minor cleanup of unreachable code]
Signed-off-by: Peter Maydell
---
This is a squashing-together of Engin's two patches
http://patchwork.ozl
Am 03.08.2011 22:56, schrieb Stefan Weil:
Am 03.08.2011 22:20, schrieb Blue Swirl:
On Wed, Aug 3, 2011 at 7:00 PM, Stefan Weil
wrote:
Am 07.07.2011 14:37, schrieb Kirill Batuzov:
Make tcg_constant_folding do copy and constant propagation. It is a
preparational work before actual constant fol
Am 03.08.2011 22:20, schrieb Blue Swirl:
On Wed, Aug 3, 2011 at 7:00 PM, Stefan Weil wrote:
Am 07.07.2011 14:37, schrieb Kirill Batuzov:
Make tcg_constant_folding do copy and constant propagation. It is a
preparational work before actual constant folding.
Signed-off-by: Kirill Batuzov
---
t
On Wed, 3 Aug 2011, Jan Beulich wrote:
> >>> Stefano Stabellini 08/03/11 12:01 AM >>>
> >if (rlimit_as.rlim_max < MCACHE_MAX_SIZE) {
>
> This condition minimally needs to include what Anthony's original version had.
right
> >if (qemu is priviledged) {
> >rlimit_as.rlim_max = RLIM_INFINITY;
On Wed, Aug 3, 2011 at 7:00 PM, Stefan Weil wrote:
> Am 07.07.2011 14:37, schrieb Kirill Batuzov:
>>
>> Make tcg_constant_folding do copy and constant propagation. It is a
>> preparational work before actual constant folding.
>>
>> Signed-off-by: Kirill Batuzov
>> ---
>> tcg/optimize.c | 182
>>
On 3 August 2011 20:24, Markus Armbruster wrote:
> andrzej zaborowski writes:
>> On 3 August 2011 18:38, Markus Armbruster wrote:
>>> andrzej zaborowski writes:
2. if the
underlaying storage can disappear for any other reason if tha
Am 07.07.2011 14:37, schrieb Kirill Batuzov:
Make tcg_constant_folding do copy and constant propagation. It is a
preparational work before actual constant folding.
Signed-off-by: Kirill Batuzov
---
tcg/optimize.c | 182 +++-
1 files changed
Cc: vijayku...@bravegnu.org
Signed-off-by: Engin AYDOGAN
---
.gitignore |3 +++
hw/stellaris.c | 37 -
2 files changed, 23 insertions(+), 17 deletions(-)
diff --git a/.gitignore b/.gitignore
index 54835bc..43c1e0e 100644
--- a/.gitignore
+++ b/.gitig
Add support for the RCC2 register on Fury class devices.
Based on a patch by Vijay Kumar
Signed-off-by: Engin AYDOGAN
---
hw/stellaris.c | 70 +--
1 files changed, 67 insertions(+), 3 deletions(-)
diff --git a/hw/stellaris.c b/hw/stellaris.c
On Wed, 3 Aug 2011 20:26:30 +0200
Christoph Hellwig wrote:
> On Wed, Aug 03, 2011 at 03:11:38PM -0300, Luiz Capitulino wrote:
> > > > It's already possible for QMP clients to implement this feature by using
> > > > the BLOCK_IO_ERROR event. However, the event can be missed. When this
> > > > happ
On Wed, Aug 03, 2011 at 03:11:38PM -0300, Luiz Capitulino wrote:
> > > It's already possible for QMP clients to implement this feature by using
> > > the BLOCK_IO_ERROR event. However, the event can be missed. When this
> > > happens QMP clients need a way to query if any block device has hit a
> >
andrzej zaborowski writes:
> On 3 August 2011 18:38, Markus Armbruster wrote:
>> andrzej zaborowski writes:
>>> 2. if the
>>> underlaying storage can disappear for any other reason if that's
>>> possible to check.
>>
>> bdrv_is_removable() *i
On Wed, 3 Aug 2011 18:31:31 +0200
Christoph Hellwig wrote:
> > It's already possible for QMP clients to implement this feature by using
> > the BLOCK_IO_ERROR event. However, the event can be missed. When this
> > happens QMP clients need a way to query if any block device has hit a
> > no space
On Wed, 03 Aug 2011 17:39:04 +0200
Kevin Wolf wrote:
> Am 03.08.2011 17:19, schrieb Luiz Capitulino:
> > Roughly speaking, thin provisioning is a feature where the VM is started
> > with
> > a small disk and space is allocated on demand.
> >
> > It's already possible for QMP clients to implemen
Parameter is_softmmu (and its evil mutant twin brother is_softmuu)
is not used in cpu_*_handle_mmu_fault() functions, remove them
and adjust callers.
Signed-off-by: Blue Swirl
---
target-alpha/cpu.h|2 +-
target-alpha/helper.c |4 ++--
target-alpha/op_helper.c |
On Wed, Aug 3, 2011 at 5:39 PM, Anthony Liguori wrote:
> On 08/03/2011 11:48 AM, Blue Swirl wrote:
>>
>> On Wed, Aug 3, 2011 at 9:05 AM, Philipp Hahn wrote:
>>>
>>> Hello,
>>>
>>> On Monday 25 July 2011 16:18:07 Anthony Liguori wrote:
Hands down, 0.14.0 had the best change log of any QE
On 08/03/2011 04:00 AM, Juan Quintela wrote:
Anthony Liguori wrote:
So my thinking is to be a bit more conservative. If we bump the
version number for 0.15.0, we make sure that we don't allow new -> old
migration. We will break old -> new migration, but we can fix that
(including in the sta
On 08/03/2011 03:34 AM, Kevin Wolf wrote:
Am 03.08.2011 02:18, schrieb Anthony Liguori:
As Paolo points out, the migration protocol is ambiguous when using subsections
today. That means that even if we preserve subsections and change the protocol
accordingly, the old protocol w/subsections is s
On 08/03/2011 01:44 AM, Paolo Bonzini wrote:
On 08/03/2011 02:12 AM, Anthony Liguori wrote:
Paolo's proposed changes make newer QEMUs use a new protocol. It's
still possible to read the older protocol. This means that you can't
migrate new to old, but can migrate old to new.
Not really true, w
On 08/03/2011 11:48 AM, Blue Swirl wrote:
On Wed, Aug 3, 2011 at 9:05 AM, Philipp Hahn wrote:
Hello,
On Monday 25 July 2011 16:18:07 Anthony Liguori wrote:
Hands down, 0.14.0 had the best change log of any QEMU release. A large
part of the success of the change log was how many people partic
On Wed, 03 Aug 2011 17:32:03 +0200
Jan Kiszka wrote:
> On 2011-08-03 17:17, Luiz Capitulino wrote:
> > We have two states where issuing cont before system_reset can be
> > catastrophic: QSTATE_SHUTDOWN (when -no-shutdown is used) and
> > QSTATE_INTERROR (which only happen with kvm).
> >
> > This
On 3 August 2011 18:38, Markus Armbruster wrote:
> andrzej zaborowski writes:
>> 2. if the
>> underlaying storage can disappear for any other reason if that's
>> possible to check.
>
> bdrv_is_removable() *isn't* such a check.
Obviously I wasn
Blue Swirl writes:
> On Wed, Aug 3, 2011 at 1:07 PM, Markus Armbruster wrote:
>> No functional change.
>>
>> It would be nice to have handler functions in the table, like commit
>> e1a064f9 did for ATAPI. Left for another day.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> hw/ide/core.c |
Thanks, applied.
On Tue, Aug 2, 2011 at 5:59 AM, Bob Breuer wrote:
> Blue Swirl wrote:
>> Commit b14ef7c9ab41ea824c3ccadb070ad95567cca84e
>> introduced cpu_unassigned_access() function. On Sparc,
>> the function does not restore AREG0 used for global CPUState
>> on function exit, causing bugs wit
On Wed, Aug 3, 2011 at 1:07 PM, Markus Armbruster wrote:
> No functional change.
>
> It would be nice to have handler functions in the table, like commit
> e1a064f9 did for ATAPI. Left for another day.
>
> Signed-off-by: Markus Armbruster
> ---
> hw/ide/core.c | 104
>
On Wed, Aug 3, 2011 at 9:05 AM, Philipp Hahn wrote:
> Hello,
>
> On Monday 25 July 2011 16:18:07 Anthony Liguori wrote:
>> Hands down, 0.14.0 had the best change log of any QEMU release. A large
>> part of the success of the change log was how many people participated
>> in creating it. I'd love
andrzej zaborowski writes:
> On 3 August 2011 15:28, Markus Armbruster wrote:
>> andrzej zaborowski writes:
>>
>>> On 3 August 2011 10:12, Markus Armbruster wrote:
Peter Maydell writes:
> On 1 August 2011 13:33, Markus Armbruster wrote:
>> andrzej zaborowski writes:
>>
On Wed, Aug 03, 2011 at 10:49:07AM +0200, Paolo Bonzini wrote:
> With this patch, sense data is stored in the generic data structures
> for SCSI devices and requests. The SCSI layer takes care of storing
> sense data in the SCSIDevice for the subsequent REQUEST SENSE command.
>
> At the same time
On Wed, Aug 03, 2011 at 10:49:06AM +0200, Paolo Bonzini wrote:
> A small improvement in the SCSI request API. Pass the status
> at the time the request is completed, so that we can assert that
> no request is completed twice. This would have detected the
> problem fixed in the previous patch.
>
On Wed, Aug 03, 2011 at 10:49:05AM +0200, Paolo Bonzini wrote:
> vscsi supports autosensing by providing sense data directly in the
> response. When get_sense was added, the older state machine approach
> that sent REQUEST SENSE commands separately was left in place. Remove
> it, all existing SCS
On Wed, Aug 03, 2011 at 10:49:04AM +0200, Paolo Bonzini wrote:
> In fact, if the HBA's transfer_data callback goes on with scsi_req_continue
> the request will be completed successfully instead of showing a failure.
> It can even cause a segmentation fault.
>
> An easy way to trigger it is "eject
> It's already possible for QMP clients to implement this feature by using
> the BLOCK_IO_ERROR event. However, the event can be missed. When this
> happens QMP clients need a way to query if any block device has hit a
> no space condition.
We have a mode where we stop the VM when it hits ENOSPC,
Test against QSTATE_INMIGRATE instead.
Please, note that the QSTATE_INMIGRATE state is only set when all the
initial VM setup is done, while 'incoming_expected' was set right in
the beginning when parsing command-line options. Shouldn't be a problem
as far as I could check.
Signed-off-by: Luiz Ca
TODO: migration
Signed-off-by: Luiz Capitulino
---
hw/ide/core.c | 16
hw/ide/internal.h |2 ++
2 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index ffb6500..3f075a1 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -58,6
Am 01.08.2011 11:39, schrieb Stefan Hajnoczi:
> This patch adds -drive cache=directsync for O_DIRECT | O_SYNC host file
> I/O with no disk write cache presented to the guest.
>
> This mode is useful when guests may not be sending flushes when
> appropriate and therefore leave data at risk in case
TODO: migration
Signed-off-by: Luiz Capitulino
---
hw/virtio-blk.c | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
index 265c795..a008956 100644
--- a/hw/virtio-blk.c
+++ b/hw/virtio-blk.c
@@ -29,6 +29,7 @@ typedef struct V
This new key reports the current VM status to clients. Please, check
the documentation being added in this commit for more details.
Signed-off-by: Luiz Capitulino
---
monitor.c |3 +--
qmp-commands.hx | 21 -
sysemu.h|1 +
vl.c| 24 ++
Roughly speaking, thin provisioning is a feature where the VM is started with
a small disk and space is allocated on demand.
It's already possible for QMP clients to implement this feature by using
the BLOCK_IO_ERROR event. However, the event can be missed. When this
happens QMP clients need a way
Use qemu_is_running() instead, which is introduced by this commit and
is part of the QemuState API.
Signed-off-by: Luiz Capitulino
---
cpus.c|9 -
gdbstub.c |4 ++--
hw/etraxfs_dma.c |2 +-
hw/kvmclock.c |2 +-
hw/virtio.c |2 +-
migrati
On Wed, Aug 03, 2011 at 06:23:41PM +0300, Avi Kivity wrote:
> On 08/03/2011 06:16 PM, Michael S. Tsirkin wrote:
> >>
> >> Well, the reason we have this logic here, I think, is
> >> to make sure it runs before the guest accesses
> >> the configuration with a write access.
> >>
> >> I'm not sure
We originally did get config on map, so that
following write accesses are done on an updated config.
New memory API doesn't give us a callback
on map, and arguably, devices don't know when
cpu really can access there. So updating on
init seems cleaner.
Signed-off-by: Michael S. Tsirkin
---
OK, t
Am 03.08.2011 17:19, schrieb Luiz Capitulino:
> Roughly speaking, thin provisioning is a feature where the VM is started with
> a small disk and space is allocated on demand.
>
> It's already possible for QMP clients to implement this feature by using
> the BLOCK_IO_ERROR event. However, the event
On 2011-08-03 17:17, Luiz Capitulino wrote:
> We have two states where issuing cont before system_reset can be
> catastrophic: QSTATE_SHUTDOWN (when -no-shutdown is used) and
> QSTATE_INTERROR (which only happen with kvm).
>
> This commit fixes that by making system_reset mandatory before
> issuin
except msix.
[jan: fix build]
Reviewed-by: Richard Henderson
Signed-off-by: Avi Kivity
---
hw/virtio-pci.c | 74 ++
hw/virtio-pci.h |2 +-
2 files changed, 31 insertions(+), 45 deletions(-)
diff --git a/hw/virtio-pci.c b/hw/virtio-pci.
TODO: migration
Signed-off-by: Luiz Capitulino
---
hw/scsi-disk.c | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index db2d5a3..e4b57a7 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -77,11 +77,17 @@ struct SCSIDisk
On 08/03/2011 06:16 PM, Michael S. Tsirkin wrote:
>
> Well, the reason we have this logic here, I think, is
> to make sure it runs before the guest accesses
> the configuration with a write access.
>
> I'm not sure why we don't do this in the init
> callback - Anthony?
So the following shou
This field is only available if the device model implements the
get_iostatus() operation and the VM is stopped.
It contains the I/O status before the VM being stopped.
Please, also note that it's necessary to add qemu_is_running() to
qemu-tool.c so that we can use it in block.c.
Signed-off-by: L
It returns the status of the last executed I/O operation, which can be:
o OK (success)
o ENOSPC (no space)
o FAILED (other kinds of failures such as EIO)
We make a distiction between ENOSPC and other kinds of failures because
QMP clients can use ENOSPC to implement a feature where the VM is
st
Currently, only vm_start() and vm_stop() change the VM state. That's,
the state is only changed when starting or stopping the VM.
This commit adds the qemu_state_set() function, making it possible
to also do state transitions when qemu is stopped or running.
Additional states are also added and t
We have two states where issuing cont before system_reset can be
catastrophic: QSTATE_SHUTDOWN (when -no-shutdown is used) and
QSTATE_INTERROR (which only happen with kvm).
This commit fixes that by making system_reset mandatory before
issuing cont in those states.
Signed-off-by: Luiz Capitulino
It replaces the VMSTOP macros and allows us to drop some global variables.
Also, the problem with issuing 'cont' when the VM is in bad state is addressed,
and we make the current state available in QMP.
audio/audio.c |2 +-
cpus.c | 26 +++
cpus.h
It's where all state handling functions prototypes are located.
Signed-off-by: Luiz Capitulino
---
cpus.h |1 -
sysemu.h |1 +
2 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cpus.h b/cpus.h
index f42b54e..5885885 100644
--- a/cpus.h
+++ b/cpus.h
@@ -15,7 +15,6 @@ void c
Today, when notifying a VM state change with vm_state_notify(), we
pass a VMSTOP macro as the 'reason' argument. This is not ideal,
because the VMSTOP macros tells why qemu stopped and not exactly
what the current VM state is.
One example to demonstrate this problem is that vm_start() calls
vm_sta
There is only one function, so no need for a function pointer.
Reviewed-by: Richard Henderson
Signed-off-by: Avi Kivity
---
hw/pci.c | 25 +
hw/pci.h |1 -
2 files changed, 9 insertions(+), 17 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index e9e4874..e6a759a 10
Am 02.08.2011 08:32, schrieb Aneesh Kumar K.V:
> Signed-off-by: Aneesh Kumar K.V
> ---
> qemu-coroutine-lock.c | 44
> qemu-coroutine.h | 32
> 2 files changed, 76 insertions(+), 0 deletions(-)
Thanks, applied
Reviewed-by: Richard Henderson
Signed-off-by: Avi Kivity
---
hw/cuda.c |6 ++-
hw/escc.c | 42 +--
hw/escc.h |2 +-
hw/heathrow_pic.c | 29 --
hw/ide.h |2 +-
hw/ide/macio.c| 36 ---
On Mon, Aug 01, 2011 at 01:23:22PM +0300, Michael S. Tsirkin wrote:
> On Mon, Aug 01, 2011 at 12:35:44PM +0300, Avi Kivity wrote:
> > On 08/01/2011 11:26 AM, Michael S. Tsirkin wrote:
> > >>
> > >> static void virtio_write_config(PCIDevice *pci_dev, uint32_t address,
> > >>
From: Hannes Reinecke
Instead of using its own definitions scsi-disk should
be using the device type of the parent device.
Signed-off-by: Hannes Reinecke
Signed-off-by: Kevin Wolf
---
hw/scsi-defs.h |6 +-
hw/scsi-disk.c | 46 ++
2 files c
It's a confused mess (see previous commit). No users remain.
Signed-off-by: Markus Armbruster
---
block.c |8
block.h |1 -
block_int.h |1 -
blockdev.c|5 -
hw/fdc.c |1 -
hw/ide/core.c |1 -
hw/scsi-disk.c
Reviewed-by: Richard Henderson
Signed-off-by: Avi Kivity
---
hw/usb-uhci.c | 42 --
1 files changed, 28 insertions(+), 14 deletions(-)
diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
index da74c57..96a17bd 100644
--- a/hw/usb-uhci.c
+++ b/hw/usb-uhci.c
@@ -1
We already track it in BlockDriverState since commit 4be9762a. As
discussed in that commit's message, we should track it in the device
device models instead, because it's device state.
Signed-off-by: Markus Armbruster
---
hw/ide/atapi.c|6 +-
hw/ide/internal.h |1 +
2 files chan
Not used anymore.
Reviewed-by: Richard Henderson
Signed-off-by: Avi Kivity
---
hw/pci.c | 33 ++---
1 files changed, 2 insertions(+), 31 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 6ed08ae..e6a3e56 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -848,18 +848,7 @@
We're going to remove the callback, so we can't use it to save the
address. Use the pci API instead.
Reviewed-by: Richard Henderson
Signed-off-by: Avi Kivity
---
hw/vmware_vga.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/vmware_vga.c b/hw/vmware_vga.
From: Frediano Ziglio
Signed-off-by: Frediano Ziglio
Signed-off-by: Kevin Wolf
---
block/raw-posix.c | 11 +--
1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index 6dd7086..c5c9944 100644
--- a/block/raw-posix.c
+++ b/block/raw-po
Commit 4be9762a changed bdrv_is_inserted() to fail when the tray is
open. Unfortunately, there are two different kinds of users, with
conflicting needs.
1. Device models using bdrv_eject(), currently ide-cd and scsi-cd.
They expect bdrv_is_inserted() to reflect the tray status. Commit
4be9762a m
Make use of the memory API's ability to satisfy multi-byte accesses via
multiple single-byte accesses.
Reviewed-by: Richard Henderson
Signed-off-by: Avi Kivity
---
hw/cirrus_vga.c | 81 +--
1 files changed, 13 insertions(+), 68 deletions(-)
From: Markus Armbruster
Callees always return 0, except for FreeBSD's cdrom_eject(), which
returns -ENOTSUP when the device is in a terminally wedged state.
The only caller is bdrv_eject(), and it maps -ENOTSUP to 0 since
commit 4be9762a.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin W
1 - 100 of 294 matches
Mail list logo
