[Qemu-devel] [PATCH -V3] coroutine: Add CoRwlock support

2011-08-01 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V --- qemu-coroutine-lock.c | 44 qemu-coroutine.h | 32 2 files changed, 76 insertions(+), 0 deletions(-) diff --git a/qemu-coroutine-lock.c b/qemu-coroutine-lock.c index a80f437

Re: [Qemu-devel] [PATCH] Sparc: fix non-faulting unassigned memory accesses

2011-08-01 Thread Bob Breuer
Blue Swirl wrote: > Commit b14ef7c9ab41ea824c3ccadb070ad95567cca84e > introduced cpu_unassigned_access() function. On Sparc, > the function does not restore AREG0 used for global CPUState > on function exit, causing bugs with non-faulting unassigned > memory accesses. Alpha, Microblaze and MIPS are

Re: [Qemu-devel] [RFC 01/24] block: add block conversion api

2011-08-01 Thread Devin Nakamura
On Mon, Aug 1, 2011 at 9:34 AM, Kevin Wolf wrote: >> +    /** >> +     * Gets a mapping in the image file. >> +     * >> +     * The function starts searching for a mapping at >> +     * starting_guest_offset = guest_offset + contiguous_bytes >> +     * >> +     * @param bs[in]                   T

Re: [Qemu-devel] [RFC 21/24] qcow2: add qcow2_open_conversion_target()

2011-08-01 Thread Devin Nakamura
On Mon, Aug 1, 2011 at 11:26 AM, Kevin Wolf wrote: > Am 29.07.2011 06:49, schrieb Devin Nakamura: >> Still in very raw form.  Not likely to work yet >> >> Signed-off-by: Devin Nakamura > > I don't think it's quite as easy. > > The problem is that qcow2 will access the image header in some places,

Re: [Qemu-devel] [RFC 22/24] qemu-io: make map command use new block mapping function

2011-08-01 Thread Devin Nakamura
On Mon, Aug 1, 2011 at 11:38 AM, Kevin Wolf wrote: > Am 29.07.2011 06:49, schrieb Devin Nakamura: >> bdrv_get_mapping will be used when it is defined, >> otherwise default to old behaviour. >> >> Signed-off-by: Devin Nakamura > > Hm, I think I would use a new command for this, like 'get_mapping'.

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-08-01 Thread moonman
YES! That did the trick! Though, with this patch I was unable to compile qemu 0.15rc1. I suppose the patch wasn't meant for it, but with 0.14.1 it works flawlessly. Also, I had to do echo 2 >/proc/cpu/alignment as was mentioned by Peter. I hope the patch gets applied to the main tree. -- You re

[Qemu-devel] buildbot failure in qemu on trivial-patches_i386_debian_5_0

2011-08-01 Thread qemu
The Buildbot has detected a new failure on builder trivial-patches_i386_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/trivial-patches_i386_debian_5_0/builds/52 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Bui

Re: [Qemu-devel] [PATCH] [FYI] Scripts to generate project stats

2011-08-01 Thread Anthony Liguori
On 08/01/2011 09:36 PM, Anthony Liguori wrote: As part of my talk for KVM Forum, I am collecting some stats on the project since last year. I thought I'd share the scripts in case anyone is interested in how they work. +function gen-stats() { +until="$1" +since="$2" + +echo 'Total C

[Qemu-devel] buildbot failure in qemu on qmp_x86_64_debian_5_0

2011-08-01 Thread qemu
The Buildbot has detected a new failure on builder qmp_x86_64_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/qmp_x86_64_debian_5_0/builds/52 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Rea

[Qemu-devel] buildbot failure in qemu on qmp_i386_debian_5_0

2011-08-01 Thread qemu
The Buildbot has detected a new failure on builder qmp_i386_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/qmp_i386_debian_5_0/builds/52 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Reason:

[Qemu-devel] [PATCH] [FYI] Scripts to generate project stats

2011-08-01 Thread Anthony Liguori
As part of my talk for KVM Forum, I am collecting some stats on the project since last year. I thought I'd share the scripts in case anyone is interested in how they work. I think this is just about all of the data I need, but patches are certainly welcome. Of course, you'll have to come to KVM

Re: [Qemu-devel] [PATCH 04/25] Add hard build dependency on glib

2011-08-01 Thread TeLeMan
This patch introduces "-mms-bitfields" cflag on MinGW but this cflag breaks gcc packed structures("__attribute__((packed))"). For example, slirp does not work on Win32.

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-01 Thread Benjamin Herrenschmidt
On Mon, 2011-08-01 at 12:59 -0600, Alex Williamson wrote: > > > > .../... > > I'll try to consolidate my reply to all the above here because there are > too many places above to interject and make this thread even more > difficult to respond to. True, I should try to do the same :-) > Much

[Qemu-devel] [PATCH] qdev: Eliminate duplicate reset

2011-08-01 Thread Isaku Yamahata
qbus_reset_all_fn was registered twice, so a lot of device reset functions were also called twice when QEMU started. Which was introduced by 80376c3fc2c38fdd45354e4b0eb45031f35587ed This patch fixes it by making the main_system_bus creation not register reset handler. Cc: Stefan Weil Signed-off-b

Re: [Qemu-devel] [PATCH] Correctly assign PCI domain numbers

2011-08-01 Thread David Gibson
On Mon, Aug 01, 2011 at 05:03:18PM +0300, Michael S. Tsirkin wrote: > On Mon, Aug 01, 2011 at 11:33:37PM +1000, David Gibson wrote: > > On Mon, Aug 01, 2011 at 01:10:38PM +0300, Michael S. Tsirkin wrote: > > > On Mon, Aug 01, 2011 at 04:51:02PM +1000, David Gibson wrote: > > > > qemu already almost

Re: [Qemu-devel] [Xen-devel] [PATCH] xen-mapcache: Fix rlimit set size.

2011-08-01 Thread Jan Beulich
>>> Anthony PERARD 08/01/11 9:27 PM >>> >Previously, the address space soft limit was set mcache_max_size. So, >before the mcache_max_size was reached by the mapcache, QEMU was killed >for overuse of the virtual address space. > >This patch fix that by setting the soft limit to mcache_max_size +

[Qemu-devel] buildbot failure in qemu on block_i386_debian_5_0

2011-08-01 Thread qemu
The Buildbot has detected a new failure on builder block_i386_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_i386_debian_5_0/builds/52 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Rea

[Qemu-devel] buildbot failure in qemu on block_x86_64_debian_5_0

2011-08-01 Thread qemu
The Buildbot has detected a new failure on builder block_x86_64_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_x86_64_debian_5_0/builds/52 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build

Re: [Qemu-devel] [SeaBIOS] SeaBIOS error with Juniper FreeBSD kernel

2011-08-01 Thread Kevin O'Connor
On Mon, Aug 01, 2011 at 03:49:11PM +0200, Bjørn Mork wrote: > I just confirmed the issue running > > "JUNOS 11.1R3.5 built 2011-06-25 00:17:21 UTC" > > which is as new as it officially gets at the moment. [...] > Also confirmed that 11.1R3.5 is working with SeaBIOS modified as > follows: [...] >

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-08-01 Thread moonman
Awesome Artyom! I'm compiling now. I will report back if this patch works for arm as well. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/739785 Title: qemu-i386 user mode on ARMv5 host fails (bash:

Re: [Qemu-devel] [PATCH 00/12][RFC] char: add flow control and fix guest_[open|close]

2011-08-01 Thread Anthony Liguori
On 08/01/2011 04:54 PM, Blue Swirl wrote: On Mon, Aug 1, 2011 at 2:22 PM, Anthony Liguori wrote: The char layer has been growing some nasty warts for some time now as we ask it to do things it was never intended on doing. It's been long over due for an overhaul and its become evident to me tha

Re: [Qemu-devel] [PATCH 00/12][RFC] char: add flow control and fix guest_[open|close]

2011-08-01 Thread Blue Swirl
On Mon, Aug 1, 2011 at 2:22 PM, Anthony Liguori wrote: > The char layer has been growing some nasty warts for some time now as we ask > it > to do things it was never intended on doing.  It's been long over due for an > overhaul and its become evident to me that we need to address this first > b

[Qemu-devel] [0.15][PATCH] lm32: softusb: claim to support full speed

2011-08-01 Thread Michael Walle
Am Donnerstag 21 Juli 2011, 20:52:24 schrieb Michael Walle: > The QEMU keyboard and mouse reports themselves as full speed devices, > though they are actually low speed devices. Until this is fixed, claim that > we are supporting full speed devices. > > Signed-off-by: Michael Walle > --- > hw/mi

Re: [Qemu-devel] [PATCH] guest agent: add --enable-guest-agent config option

2011-08-01 Thread Anthony Liguori
On 08/01/2011 02:52 PM, Michael Roth wrote: QAPI will require glib/python, but for now the guest agent is the only user. For now, make these dependencies an explicit guest agent one, and give users the option to disable it if need be. Once QAPI is adopted in core QEMU code, we would basically re

Re: [Qemu-devel] OpenBSD/macppc and sparc64 failing to boot with similar error.

2011-08-01 Thread Blue Swirl
On Mon, Aug 1, 2011 at 12:33 AM, Brad wrote: > I know sparc64 had little chance of actually working but > I thought I'd take it for a spin with 0.15.0-rc1 and > see how it fared in addition to macppc which has a good > chance of working nowdays with modern QEMU. Lets see > what QEMU and related bu

[Qemu-devel] [PATCH] Sparc: fix non-faulting unassigned memory accesses

2011-08-01 Thread Blue Swirl
Commit b14ef7c9ab41ea824c3ccadb070ad95567cca84e introduced cpu_unassigned_access() function. On Sparc, the function does not restore AREG0 used for global CPUState on function exit, causing bugs with non-faulting unassigned memory accesses. Alpha, Microblaze and MIPS are not affected. Fix by resto

[Qemu-devel] [RFC] Alpha system patchset updated for Memory API, batch 2: PCI devices

2011-08-01 Thread Richard Henderson
On 07/31/2011 10:57 AM, Avi Kivity wrote: > Also available from: > > git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory-region-b2 I've updated my alpha port based off of this. It seems to work just about as well as it did beforehand. git://repo.or.cz/qmu/rth.git axp-system-6 The int

Re: [Qemu-devel] [RFC PATCH v2 1/3] separate thread for VM migration

2011-08-01 Thread Umesh Deshpande
On 08/01/2011 05:37 AM, Paolo Bonzini wrote: On 07/29/2011 10:57 PM, Umesh Deshpande wrote: This patch creates a separate thread for the guest migration on the source side. Signed-off-by: Umesh Deshpande Looks pretty good! One thing that shows, is that the interface separation between buff

Re: [Qemu-devel] [PATCH v2] Fix unassigned memory access handling

2011-08-01 Thread Blue Swirl
On Mon, Aug 1, 2011 at 4:26 PM, Bob Breuer wrote: > Blue Swirl wrote: >> cea5f9a28faa528b6b1b117c9ab2d8828f473fef exposed bugs in unassigned memory >> access handling. Fix them by always passing CPUState to the handlers. >> >> Reported-by: Hervé Poussineau >> Signed-off-by: Blue Swirl >> --- >>

Re: [Qemu-devel] [PATCH] Fix duplicate device reset

2011-08-01 Thread Stefan Weil
Am 01.08.2011 13:00, schrieb Isaku Yamahata: Hi, here is the patch. Can you please give it a try? From 41039df3174fa46477c4faf93d13eab360dccc22 Mon Sep 17 00:00:00 2001 Message-Id: <41039df3174fa46477c4faf93d13eab360dccc22.1312196365.git.yamah...@valinux.co.jp> From: Isaku Yamahata Date: Mon

Re: [Qemu-devel] [PATCH v4 3/3] The support for queue timer and throttling algorithm

2011-08-01 Thread Ryan Harper
* Zhi Yong Wu [2011-08-01 01:32]: > Note: > 1.) When bps/iops limits are specified to a small value such as 511 > bytes/s, this VM will hang up. We are considering how to handle this senario. > 2.) When "dd" command is issued in guest, if its option bs is set to a > large value such

Re: [Qemu-devel] [PATCH 20/39] virtio-pci: convert to memory API

2011-08-01 Thread Anthony Liguori
On 08/01/2011 05:23 AM, Michael S. Tsirkin wrote: On Mon, Aug 01, 2011 at 12:35:44PM +0300, Avi Kivity wrote: On 08/01/2011 11:26 AM, Michael S. Tsirkin wrote: static void virtio_write_config(PCIDevice *pci_dev, uint32_t address, uint32_t val, int len)

Re: [Qemu-devel] [PATCH v2] Fix unassigned memory access handling

2011-08-01 Thread Blue Swirl
On Mon, Aug 1, 2011 at 4:26 PM, Bob Breuer wrote: > Blue Swirl wrote: >> cea5f9a28faa528b6b1b117c9ab2d8828f473fef exposed bugs in unassigned memory >> access handling. Fix them by always passing CPUState to the handlers. >> >> Reported-by: Hervé Poussineau >> Signed-off-by: Blue Swirl >> --- >>

Re: [Qemu-devel] [PATCH 20/39] virtio-pci: convert to memory API

2011-08-01 Thread Anthony Liguori
On 08/01/2011 03:26 AM, Michael S. Tsirkin wrote: On Sun, Jul 31, 2011 at 08:57:43PM +0300, Avi Kivity wrote: @@ -491,30 +473,26 @@ static void virtio_pci_config_writel(void *opaque, uint32_t addr, uint32_t val) virtio_config_writel(proxy->vdev, addr, val); } -static void virtio_map(PC

Re: [Qemu-devel] [PATCH v4 2/3] The support for block queue

2011-08-01 Thread Ryan Harper
* Zhi Yong Wu [2011-08-01 01:30]: > +static AIOPool block_queue_pool = { > +.aiocb_size = sizeof(struct BlockDriverAIOCB), > +.cancel = qemu_block_queue_cancel, > +}; > + > +static void qemu_block_queue_callback(void *opaque, int ret) > +{ > +BlockDriverAIOCB *acb

Re: [Qemu-devel] [PATCH V3 1/2] [SLIRP] Simple ARP table

2011-08-01 Thread Jan Kiszka
On 2011-08-01 18:18, Fabien Chouteau wrote: > This patch adds a simple ARP table in Slirp and also adds handling of > gratuitous ARP requests. > > Signed-off-by: Fabien Chouteau > --- > Makefile.objs |2 +- > slirp/arp_table.c | 72 > +++

Re: [Qemu-devel] [PATCH v4 0/3] The intro for QEMU disk I/O limits

2011-08-01 Thread Ryan Harper
* Zhi Yong Wu [2011-08-01 01:30]: > The main goal of the patch is to effectively cap the disk I/O speed or counts > of one single VM.It is only one draft, so it unavoidably has some drawbacks, > if you catch them, please let me know. > > The patch will mainly introduce one block I/O throttling

Re: [Qemu-devel] [PATCH] xen: Avoid useless allocation in Xen case.

2011-08-01 Thread Jan Kiszka
On 2011-08-01 21:26, Anthony PERARD wrote: > The code_gen_buffer is not use by Xen and can be really big (several > GB). Even if the host RAM is not used, this buffer just burn the address > space of the QEMU process. > > So to "avoid" this allocation, the asked tb_size is set to the minimum. > >

[Qemu-devel] [PATCH] guest agent: add --enable-guest-agent config option

2011-08-01 Thread Michael Roth
QAPI will require glib/python, but for now the guest agent is the only user. For now, make these dependencies an explicit guest agent one, and give users the option to disable it if need be. Once QAPI is adopted in core QEMU code, we would basically revert this patch. Signed-off-by: Michael Roth

Re: [Qemu-devel] [PATCH 20/39] virtio-pci: convert to memory API

2011-08-01 Thread Michael S. Tsirkin
On Mon, Aug 01, 2011 at 12:35:44PM +0300, Avi Kivity wrote: > On 08/01/2011 11:26 AM, Michael S. Tsirkin wrote: > >> > >> static void virtio_write_config(PCIDevice *pci_dev, uint32_t address, > >> uint32_t val, int len) > >> { > >> VirtIOPCIProxy *proxy =

[Qemu-devel] [PATCH] xen: Avoid useless allocation in Xen case.

2011-08-01 Thread Anthony PERARD
The code_gen_buffer is not use by Xen and can be really big (several GB). Even if the host RAM is not used, this buffer just burn the address space of the QEMU process. So to "avoid" this allocation, the asked tb_size is set to the minimum. The other way to do that would be to not call code_gen_a

[Qemu-devel] [PATCH] xen-mapcache: Fix rlimit set size.

2011-08-01 Thread Anthony PERARD
Previously, the address space soft limit was set mcache_max_size. So, before the mcache_max_size was reached by the mapcache, QEMU was killed for overuse of the virtual address space. This patch fix that by setting the soft limit to mcache_max_size + 80MB. I observed that QEMU use 75MB more than m

[Qemu-devel] glib dependency

2011-08-01 Thread Yoder Stuart-B08248
Anthony, So in QEMU 0.15 rc2 it looks like the dependency on gio and gthread has been removed, but glib is still required correct? ## # glib support probe -if $pkg_config --modversion gthread-2.0 gio-2.0 > /dev/null 2>&1 ; then -glib_cflags=`$pkg_conf

Re: [Qemu-devel] [PATCH 18/39] ide: convert to memory API

2011-08-01 Thread Richard Henderson
On 07/31/2011 10:57 AM, Avi Kivity wrote: > +pci_register_bar_region(dev, 3, PCI_BASE_ADDRESS_SPACE_IO, > +&d->cmd646_bar[2].cmd); Typo: cmd646_bar[1]. r~

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-01 Thread Alex Williamson
On Sun, 2011-07-31 at 09:54 +1000, Benjamin Herrenschmidt wrote: > On Sat, 2011-07-30 at 12:20 -0600, Alex Williamson wrote: > > > On x86, the USB controllers don't typically live behind a PCIe-to-PCI > > bridge, so don't suffer the source identifier problem, but they do often > > share an interru

Re: [Qemu-devel] qemu-kvm aborts - vhost_dev_unassign_memory: Assertion `to >= 0' failed.

2011-08-01 Thread David Ahern
On 08/01/2011 11:44 AM, David Ahern wrote: > qemu-kvm.git as of: > > commit dacdc4b10bafbb21120e1c24a9665444768ef999 > Merge: 7b69d4f 0af4922 > Author: Avi Kivity > Date: Sun Jul 31 11:42:26 2011 +0300 > > Merge branch 'upstream-merge' into next > > is aborting with the error: > > qemu-k

Re: [Qemu-devel] [PATCH 00/12][RFC] char: add flow control and fix guest_[open|close]

2011-08-01 Thread Hans de Goede
Hi, On 08/01/2011 04:22 PM, Anthony Liguori wrote: The char layer has been growing some nasty warts for some time now as we ask it to do things it was never intended on doing. It's been long over due for an overhaul and its become evident to me that we need to address this first before adding a

[Qemu-devel] qemu-kvm aborts - vhost_dev_unassign_memory: Assertion `to >= 0' failed.

2011-08-01 Thread David Ahern
qemu-kvm.git as of: commit dacdc4b10bafbb21120e1c24a9665444768ef999 Merge: 7b69d4f 0af4922 Author: Avi Kivity Date: Sun Jul 31 11:42:26 2011 +0300 Merge branch 'upstream-merge' into next is aborting with the error: qemu-kvm: qemu-kvm.git/hw/vhost.c:123: vhost_dev_unassign_memory: Asserti

Re: [Qemu-devel] [PATCH 00/39] Memory API, batch 2: PCI devices

2011-08-01 Thread Richard Henderson
On 07/31/2011 10:57 AM, Avi Kivity wrote: > This is a mostly mindless conversion of all QEMU PCI devices to the memory > API. > After this patchset is applied, it is no longer possible to create a PCI > device > using the old API. > > An immediate benefit is that PCI BARs that overlap each other

[Qemu-devel] [PATCH V3 2/2] [SLIRP] Delayed IP packets

2011-08-01 Thread Fabien Chouteau
In the current implementation, if Slirp tries to send an IP packet to a client with an unknown hardware address, the packet is simply dropped and an ARP request is sent (if_encap in slirp/slirp.c). With this patch, Slirp will send the ARP request, re-queue the packet and try to send it later. The

[Qemu-devel] [PATCH V3 1/2] [SLIRP] Simple ARP table

2011-08-01 Thread Fabien Chouteau
This patch adds a simple ARP table in Slirp and also adds handling of gratuitous ARP requests. Signed-off-by: Fabien Chouteau --- Makefile.objs |2 +- slirp/arp_table.c | 72 + slirp/bootp.c | 21 +-- slirp/slirp.c

Re: [Qemu-devel] [PATCH v2] Fix unassigned memory access handling

2011-08-01 Thread Bob Breuer
Blue Swirl wrote: > cea5f9a28faa528b6b1b117c9ab2d8828f473fef exposed bugs in unassigned memory > access handling. Fix them by always passing CPUState to the handlers. > > Reported-by: Hervé Poussineau > Signed-off-by: Blue Swirl > --- > v2: don't try to restore env since all targets eventually a

Re: [Qemu-devel] [PATCH 00/12][RFC] char: add flow control and fix guest_[open|close]

2011-08-01 Thread Anthony Liguori
On 08/01/2011 11:04 AM, Alon Levy wrote: On Mon, Aug 01, 2011 at 09:22:58AM -0500, Anthony Liguori wrote: The char layer has been growing some nasty warts for some time now as we ask it to do things it was never intended on doing. It's been long over due for an overhaul and its become evident t

Re: [Qemu-devel] [PATCH 00/12][RFC] char: add flow control and fix guest_[open|close]

2011-08-01 Thread Alon Levy
On Mon, Aug 01, 2011 at 09:22:58AM -0500, Anthony Liguori wrote: > The char layer has been growing some nasty warts for some time now as we ask > it > to do things it was never intended on doing. It's been long over due for an > overhaul and its become evident to me that we need to address this f

Re: [Qemu-devel] [PATCH V2 1/2] [SLIRP] Simple ARP table

2011-08-01 Thread Fabien Chouteau
On 01/08/2011 17:11, Jan Kiszka wrote: > On 2011-08-01 17:03, Fabien Chouteau wrote: >> On 30/07/2011 11:19, Jan Kiszka wrote: >>> On 2011-07-30 11:09, Jan Kiszka wrote: On 2011-07-29 19:34, Jan Kiszka wrote: > On 2011-07-29 18:25, Fabien Chouteau wrote: >> This patch adds a simple ARP

Re: [Qemu-devel] 0.15 testing, spice, wxp

2011-08-01 Thread Rick Vernam
On Monday 01 August 2011 09:34:32 Gerd Hoffmann wrote: > On 07/29/11 04:48, Rick Vernam wrote: > > I'd like to do some very high-level testing of qemu-stable-0.15 > > (qemu-system- x86_64, specifically) running Linux host, Windows XP SP3 > > guest. > > I'm afraid that I don't have a ready environme

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-08-01 Thread Anthony Liguori
On 08/01/2011 10:44 AM, Stefan Hajnoczi wrote: On Mon, Aug 1, 2011 at 4:44 PM, Kevin Wolf wrote: Am 01.08.2011 17:28, schrieb Anthony Liguori: On 08/01/2011 10:22 AM, Stefan Hajnoczi wrote: I like the block_set approach. Anthony, Kevin, Supriya: Any thoughts? For the sake of overall QMP sa

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-08-01 Thread Stefan Hajnoczi
On Mon, Aug 1, 2011 at 4:44 PM, Kevin Wolf wrote: > Am 01.08.2011 17:28, schrieb Anthony Liguori: >> On 08/01/2011 10:22 AM, Stefan Hajnoczi wrote: >>> On Thu, Jul 28, 2011 at 10:29 AM, Stefan Hajnoczi   >>> wrote: On Wed, Jul 27, 2011 at 5:02 PM, Anthony Liguori   wrote: > On 07/27/

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-08-01 Thread Anthony Liguori
On 08/01/2011 10:44 AM, Kevin Wolf wrote: Am 01.08.2011 17:28, schrieb Anthony Liguori: 2. Top-level command for each parameter (e.g. block_set_hostcache). Supported parameters are easily discoverable via query-commands. If individual block devices support different sets of parameters then they

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-08-01 Thread Kevin Wolf
Am 01.08.2011 17:28, schrieb Anthony Liguori: > On 08/01/2011 10:22 AM, Stefan Hajnoczi wrote: >> On Thu, Jul 28, 2011 at 10:29 AM, Stefan Hajnoczi wrote: >>> On Wed, Jul 27, 2011 at 5:02 PM, Anthony Liguori >>> wrote: On 07/27/2011 09:31 AM, Stefan Hajnoczi wrote: > > On Wed, Jul 2

Re: [Qemu-devel] [PATCH 06/12] char: add an edge event API for the front ends

2011-08-01 Thread Anthony Liguori
On 08/01/2011 10:39 AM, Stefan Hajnoczi wrote: On Mon, Aug 1, 2011 at 3:23 PM, Anthony Liguori wrote: Signed-off-by: Anthony Liguori --- qemu-char.c | 91 +-- qemu-char.h |9 ++ 2 files changed, 85 insertions(+), 15 deletions

Re: [Qemu-devel] [PATCH 12/12] char: enforce the use of qemu_chr_guest_open()

2011-08-01 Thread Anthony Liguori
On 08/01/2011 10:38 AM, Alon Levy wrote: On Mon, Aug 01, 2011 at 09:23:10AM -0500, Anthony Liguori wrote: Signed-off-by: Anthony Liguori Title should be "fe_open", not guest_open. Indeed, thanks. Regards, Anthony Liguori --- qemu-char.c | 10 ++ qemu-char.h |2 ++ 2 f

Re: [Qemu-devel] [PATCH 06/12] char: add an edge event API for the front ends

2011-08-01 Thread Stefan Hajnoczi
On Mon, Aug 1, 2011 at 3:23 PM, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori > --- >  qemu-char.c |   91 > +-- >  qemu-char.h |    9 ++ >  2 files changed, 85 insertions(+), 15 deletions(-) > > diff --git a/qemu-char.c b/qemu

Re: [Qemu-devel] [PATCH 12/12] char: enforce the use of qemu_chr_guest_open()

2011-08-01 Thread Alon Levy
On Mon, Aug 01, 2011 at 09:23:10AM -0500, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori Title should be "fe_open", not guest_open. > --- > qemu-char.c | 10 ++ > qemu-char.h |2 ++ > 2 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/qemu-char.c b/qemu-c

Re: [Qemu-devel] [PATCH 04/12] char: introduce backend tx queue

2011-08-01 Thread Anthony Liguori
On 08/01/2011 10:33 AM, Stefan Hajnoczi wrote: On Mon, Aug 1, 2011 at 3:23 PM, Anthony Liguori wrote: While the front tx queue has no flow control, the backend tx queue uses a polling function to determine when the front end can receive data. To convert this to the new queue model, we simply t

Re: [Qemu-devel] [RFC 22/24] qemu-io: make map command use new block mapping function

2011-08-01 Thread Kevin Wolf
Am 29.07.2011 06:49, schrieb Devin Nakamura: > bdrv_get_mapping will be used when it is defined, > otherwise default to old behaviour. > > Signed-off-by: Devin Nakamura Hm, I think I would use a new command for this, like 'get_mapping'. The old 'map' command can still be useful even for formats

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-08-01 Thread Stefan Hajnoczi
On Mon, Aug 1, 2011 at 4:28 PM, Anthony Liguori wrote: > On 08/01/2011 10:22 AM, Stefan Hajnoczi wrote: >> >> On Thu, Jul 28, 2011 at 10:29 AM, Stefan Hajnoczi >>  wrote: >>> >>> On Wed, Jul 27, 2011 at 5:02 PM, Anthony Liguori >>>  wrote: On 07/27/2011 09:31 AM, Stefan Hajnoczi wrote: >

Re: [Qemu-devel] [PATCH 04/12] char: introduce backend tx queue

2011-08-01 Thread Stefan Hajnoczi
On Mon, Aug 1, 2011 at 3:23 PM, Anthony Liguori wrote: > While the front tx queue has no flow control, the backend tx queue uses a > polling function to determine when the front end can receive data. > > To convert this to the new queue model, we simply try to flush the backend tx > queue whenever

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-08-01 Thread Anthony Liguori
On 08/01/2011 10:22 AM, Stefan Hajnoczi wrote: On Thu, Jul 28, 2011 at 10:29 AM, Stefan Hajnoczi wrote: On Wed, Jul 27, 2011 at 5:02 PM, Anthony Liguori wrote: On 07/27/2011 09:31 AM, Stefan Hajnoczi wrote: On Wed, Jul 27, 2011 at 1:58 PM, Anthony Liguori wrote: Index: qemu/hmp-commands

Re: [Qemu-devel] [RFC 21/24] qcow2: add qcow2_open_conversion_target()

2011-08-01 Thread Kevin Wolf
Am 29.07.2011 06:49, schrieb Devin Nakamura: > Still in very raw form. Not likely to work yet > > Signed-off-by: Devin Nakamura I don't think it's quite as easy. The problem is that qcow2 will access the image header in some places, for example when growing the L1 or refcount table. You need t

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-08-01 Thread Stefan Hajnoczi
On Thu, Jul 28, 2011 at 10:29 AM, Stefan Hajnoczi wrote: > On Wed, Jul 27, 2011 at 5:02 PM, Anthony Liguori > wrote: >> On 07/27/2011 09:31 AM, Stefan Hajnoczi wrote: >>> >>> On Wed, Jul 27, 2011 at 1:58 PM, Anthony Liguori >>>  wrote: > > Index: qemu/hmp-commands.hx > ==

[Qemu-devel] [PATCH 02/12] char: rename qemu_chr_[can_]read() to qemu_chr_be_[can_]write().

2011-08-01 Thread Anthony Liguori
To be clear about who calls this function and for what purpose. Signed-off-by: Anthony Liguori --- console.c |4 ++-- gdbstub.c |2 +- hw/baum.c | 12 ++-- hw/msmouse.c |2 +- qemu-char.c | 38 +++--- qemu

Re: [Qemu-devel] [PATCH V2 1/2] [SLIRP] Simple ARP table

2011-08-01 Thread Jan Kiszka
On 2011-08-01 17:03, Fabien Chouteau wrote: > On 30/07/2011 11:19, Jan Kiszka wrote: >> On 2011-07-30 11:09, Jan Kiszka wrote: >>> On 2011-07-29 19:34, Jan Kiszka wrote: On 2011-07-29 18:25, Fabien Chouteau wrote: > This patch adds a simple ARP table in Slirp and also adds handling of

[Qemu-devel] [PATCH 12/12] char: enforce the use of qemu_chr_guest_open()

2011-08-01 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- qemu-char.c | 10 ++ qemu-char.h |2 ++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index fb7c937..5e62795 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -206,6 +206,8 @@ int qemu_chr_fe_write(CharDriver

[Qemu-devel] [PATCH 03/12] char: introduce tx queue to enable Unix style flow control

2011-08-01 Thread Anthony Liguori
The char layer tries very hard to avoid using an intermediate buffer. The implication of this is that when the backend does a write(), the data for that write must be immediately passed to the front end. Flow control is needed to handle the likely event that the front end is not able to handle th

Re: [Qemu-devel] [PATCH V2 1/2] [SLIRP] Simple ARP table

2011-08-01 Thread Fabien Chouteau
On 30/07/2011 11:19, Jan Kiszka wrote: > On 2011-07-30 11:09, Jan Kiszka wrote: >> On 2011-07-29 19:34, Jan Kiszka wrote: >>> On 2011-07-29 18:25, Fabien Chouteau wrote: This patch adds a simple ARP table in Slirp and also adds handling of gratuitous ARP requests. Signed-off-by:

[Qemu-devel] [PATCH 11/12] char: make all devices do qemu_chr_fe_open()

2011-08-01 Thread Anthony Liguori
The semantics of guest_open are unreliable today because they there's no way of knowing whether a front end will ever call open. Let's make them reliable which means making everything call open. Signed-off-by: Anthony Liguori --- gdbstub.c |1 + hw/ccid-card-passthru.c |1

[Qemu-devel] [PATCH 07/12] char: add backend edge notification interface

2011-08-01 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- qemu-char.c | 38 ++ qemu-char.h |2 ++ 2 files changed, 36 insertions(+), 4 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 9e40e04..4ba18e2 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -188,6 +188,11 @@ sta

[Qemu-devel] [PATCH 10/12] char: rename qemu_chr_guest_close() -> qemu_chr_fe_close()

2011-08-01 Thread Anthony Liguori
To be more explicit about what the function is for. Signed-off-by: Anthony Liguori --- hw/virtio-console.c |2 +- qemu-char.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index 21f752b..d3351c8 100644 --- a/hw/vir

[Qemu-devel] [PATCH 09/12] char: rename qemu_chr_guest_open() -> qemu_chr_fe_open()

2011-08-01 Thread Anthony Liguori
--- hw/virtio-console.c |2 +- qemu-char.c |2 +- qemu-char.h |4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index 6c386fa..21f752b 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c @@ -52,7 +52

Re: [Qemu-devel] [RFC 19/24] qcow2: add qcow2_copy_header()

2011-08-01 Thread Kevin Wolf
Am 29.07.2011 06:49, schrieb Devin Nakamura: > Signed-off-by: Devin Nakamura > --- > block/qcow2.c | 54 ++ > 1 files changed, 54 insertions(+), 0 deletions(-) Do we really need to build a completely new header? We should already have one at

Re: [Qemu-devel] 0.15 testing, spice, wxp

2011-08-01 Thread Gerd Hoffmann
On 07/29/11 04:48, Rick Vernam wrote: I'd like to do some very high-level testing of qemu-stable-0.15 (qemu-system- x86_64, specifically) running Linux host, Windows XP SP3 guest. I'm afraid that I don't have a ready environment for building the windows guest bits, and the added time requirement

Re: [Qemu-devel] [RFC 18/24] qcow2: add qcow2_map

2011-08-01 Thread Kevin Wolf
Am 29.07.2011 06:49, schrieb Devin Nakamura: > Signed-off-by: Devin Nakamura > --- > block/qcow2-cluster.c | 49 > + > block/qcow2.c |1 + > block/qcow2.h |3 +++ > 3 files changed, 53 insertions(+), 0 deletions(-) > > di

[Qemu-devel] [PULL] pci, virtio, net

2011-08-01 Thread Michael S. Tsirkin
The following changes since commit d1afc48b7cfdb4490f322d5d82a2aae6d545ec06: SPARC64: implement addtional MMU faults related to nonfaulting load (2011-07-21 20:02:22 +) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_anthony Amit Sh

[Qemu-devel] [PATCH 08/12] char: make monitor use new style interface

2011-08-01 Thread Anthony Liguori
--- monitor.c | 35 --- 1 files changed, 20 insertions(+), 15 deletions(-) diff --git a/monitor.c b/monitor.c index 38d4544..3ca211b 100644 --- a/monitor.c +++ b/monitor.c @@ -4747,13 +4747,6 @@ cleanup: } } -static int monitor_can_read(void *opaque) -{ -

[Qemu-devel] [PATCH 04/12] char: introduce backend tx queue

2011-08-01 Thread Anthony Liguori
While the front tx queue has no flow control, the backend tx queue uses a polling function to determine when the front end can receive data. To convert this to the new queue model, we simply try to flush the backend tx queue whenever we poll. We then return the remaining space in the queue as the

[Qemu-devel] [PATCH 06/12] char: add an edge event API for the front ends

2011-08-01 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- qemu-char.c | 91 +-- qemu-char.h |9 ++ 2 files changed, 85 insertions(+), 15 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 0e4a30c..9e40e04 100644 --- a/qemu-char.c +++ b/qemu-char.

[Qemu-devel] [PATCH 05/12] char: add read functions for backend and frontend

2011-08-01 Thread Anthony Liguori
Instead of waiting for a callback to send data, allow for reading the backend and frontend tx queues directly. Signed-off-by: Anthony Liguori --- qemu-char.c | 10 ++ qemu-char.h |2 ++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index

[Qemu-devel] [PATCH 01/12] char: rename qemu_chr_write() to qemu_chr_fe_write()

2011-08-01 Thread Anthony Liguori
The char layer is confusing. There is a front-end, typically a device, that can send and receive data. The front-end sends data by calling qemu_chr_write(). The back-end, typically created via -chardev, can also send and receive data. Oddly, it sends data by calling qemu_chr_read(). Let's be ex

[Qemu-devel] [PATCH 00/12][RFC] char: add flow control and fix guest_[open|close]

2011-08-01 Thread Anthony Liguori
The char layer has been growing some nasty warts for some time now as we ask it to do things it was never intended on doing. It's been long over due for an overhaul and its become evident to me that we need to address this first before adding any more features to the char layer. This series is th

Re: [Qemu-devel] [RFC 16/24] qcow2: add qcow2_drop_leaked_clusters()

2011-08-01 Thread Kevin Wolf
Am 29.07.2011 06:49, schrieb Devin Nakamura: > Signed-off-by: Devin Nakamura > --- > block/qcow2-refcount.c | 34 ++ > block/qcow2.h |2 ++ > 2 files changed, 36 insertions(+), 0 deletions(-) Just for the record, discussed on IRC: Maybe it would be

[Qemu-devel] KVM call agenda for August 2

2011-08-01 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Later, Juan.

Re: [Qemu-devel] [PATCH] Correctly assign PCI domain numbers

2011-08-01 Thread Michael S. Tsirkin
On Mon, Aug 01, 2011 at 11:33:37PM +1000, David Gibson wrote: > On Mon, Aug 01, 2011 at 01:10:38PM +0300, Michael S. Tsirkin wrote: > > On Mon, Aug 01, 2011 at 04:51:02PM +1000, David Gibson wrote: > > > qemu already almost supports PCI domains; that is, several entirely > > > independent PCI host

Re: [Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format

2011-08-01 Thread Anthony Liguori
On 08/01/2011 02:54 AM, Christoph Hellwig wrote: On Sun, Jul 31, 2011 at 07:15:21PM -0500, Anthony Liguori wrote: I think we've set the bar too low historically for introducing new interfaces. I think Avi's new memory API is a good example of how we should approach these things--do the vast maj

Re: [Qemu-devel] [PATCH] Correctly assign PCI domain numbers

2011-08-01 Thread David Gibson
On Mon, Aug 01, 2011 at 05:31:06PM +0900, Isaku Yamahata wrote: > [Added mst to Cc.] > > In order to use multi PCI domain, several areas need to be addressed > in addition to this patch. For example, bios, acpi dsdt. For x86, yes. For powerpc, which is what I'm working on, no. > Do you have any

Re: [Qemu-devel] [PATCH] Correctly assign PCI domain numbers

2011-08-01 Thread David Gibson
On Mon, Aug 01, 2011 at 01:10:38PM +0300, Michael S. Tsirkin wrote: > On Mon, Aug 01, 2011 at 04:51:02PM +1000, David Gibson wrote: > > qemu already almost supports PCI domains; that is, several entirely > > independent PCI host bridges on the same machine. However, a bug in > > pci_bus_new_inplac

Re: [Qemu-devel] [SeaBIOS] SeaBIOS error with Juniper FreeBSD kernel

2011-08-01 Thread Bjørn Mork
Brandon Bennett writes: >> Are all versions based on FreeBSD 4.11? >> Are newer versions still affected? > > Newer versions should be based on 6.1 but there are a lot of changes. > I haven't had a chance to test with something newer yet. Sorry for the delay due to vacation... I just confirmed t

Re: [Qemu-devel] [RFC 07/24] qed: make qed_alloc_clusters round up offset to nearest cluster

2011-08-01 Thread Kevin Wolf
Am 29.07.2011 06:49, schrieb Devin Nakamura: > Signed-off-by: Devin Nakamura > --- > block/qed.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/block/qed.c b/block/qed.c > index 3970379..00cf895 100644 > --- a/block/qed.c > +++ b/block/qed.c > @@ -263,6 +263,9 @@

Re: [Qemu-devel] SeaBIOS image is lacking CONFIG_AHCI

2011-08-01 Thread Gerd Hoffmann
On 07/25/11 09:11, Jan Kiszka wrote: On 2011-05-09 08:03, Jan Kiszka wrote: Hi Anthony, please rebuild SeaBIOS after enabling AHCI. QEMU's current version is still not able to boot from such controllers. This unfortunately still applies to 0.15-rc0. Please fix. Updating to latest seabios wo

Re: [Qemu-devel] [RFC 03/24] block: add bdrv_open_conversion_target()

2011-08-01 Thread Kevin Wolf
Am 29.07.2011 06:49, schrieb Devin Nakamura: > Conflicts: > > block.h You can probably remove this note. ;-) > > Signed-off-by: Devin Nakamura > --- > block.c | 32 > block.h |4 > 2 files changed, 36 insertions(+), 0 deletions(-) > > diff --

  1   2   >