Re: [Qemu-devel] [RFC PATCH 4/5] avoid dandling pointers

2011-07-21 Thread Kevin Wolf
Am 20.07.2011 15:56, schrieb Frediano Ziglio: > Signed-off-by: Frediano Ziglio > --- > block/qcow.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) Subject needs a "qcow: ..." Kevin

Re: [Qemu-devel] [RFC PATCH 2/5] qcow: QCowAIOCB field cleanup

2011-07-21 Thread Kevin Wolf
Am 20.07.2011 15:56, schrieb Frediano Ziglio: > remove unused field from this structure and put some of them in > qcow_aio_read_cb and qcow_aio_write_cb > > Signed-off-by: Frediano Ziglio > qemu_co_mutex_lock(&s->lock); > if (ret < 0) { > return ret; > }

Re: [Qemu-devel] [RFC][PATCH 9/9] block: Use bdrv_co_* instead of synchronous versions in coroutines

2011-07-21 Thread Kevin Wolf
Am 21.07.2011 17:23, schrieb Stefan Hajnoczi: > On Fri, Jul 15, 2011 at 06:47:39PM +0200, Kevin Wolf wrote: >> If we're already in a coroutine, there is no reason to use the synchronous >> version of block layer functions when a coroutine one exists. This makes >> bdrv_read/write/flush use bdrv_co_

Re: [Qemu-devel] [PATCH v2 4/5] exec.c: refactor cpu_physical_memory_map

2011-07-21 Thread Liu Yu-B13201
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Friday, July 22, 2011 2:00 PM > To: Liu Yu-B13201 > Cc: stefano.stabell...@eu.citrix.com; qemu-devel@nongnu.org; > xen-de...@lists.xensource.com; Yoder Stuart-B08248 > Subject: Re: [Qemu-devel] [PATCH v2 4/5] ex

Re: [Qemu-devel] [PATCH v2 4/5] exec.c: refactor cpu_physical_memory_map

2011-07-21 Thread Liu Yu-B13201
> -Original Message- > From: qemu-devel-bounces+yu.liu=freescale@nongnu.org > [mailto:qemu-devel-bounces+yu.liu=freescale@nongnu.org] > On Behalf Of stefano.stabell...@eu.citrix.com > Sent: Friday, May 20, 2011 1:36 AM > To: qemu-devel@nongnu.org > Cc: xen-de...@lists.xensource

Re: [Qemu-devel] [PATCH v2 4/5] exec.c: refactor cpu_physical_memory_map

2011-07-21 Thread Alexander Graf
On 22.07.2011, at 07:42, Liu Yu-B13201 wrote: > > >> -Original Message- >> From: qemu-devel-bounces+yu.liu=freescale@nongnu.org >> [mailto:qemu-devel-bounces+yu.liu=freescale@nongnu.org] >> On Behalf Of stefano.stabell...@eu.citrix.com >> Sent: Friday, May 20, 2011 1:36 AM >>

[Qemu-devel] [PATCH] target-sparc: Fix compiler errors (format strings)

2011-07-21 Thread Stefan Weil
This change is needed because commit 06e12b65 now uses an unsigned long long value (uint64_t && unsigned long long => unsigned long long). Cc: Tsuneo Saito Cc: Blue Swirl Signed-off-by: Stefan Weil --- target-sparc/helper.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --

Re: [Qemu-devel] [PATCH] pci: Common overflow prevention

2011-07-21 Thread Michael S. Tsirkin
On Thu, Jul 21, 2011 at 06:50:10PM +0200, Jan Kiszka wrote: > Introduce pci_config_read/write_common helpers to prevent passing > accesses down the callback chain that go beyond the config space limits. > Adjust length assertions as they are no longer correct (cutting may > generate valid 3 byte ac

Re: [Qemu-devel] buildbot failure in qemu on default_i386_debian_5_0

2011-07-21 Thread Stefan Hajnoczi
On Fri, Jul 22, 2011 at 12:05 AM, wrote: > The Buildbot has detected a new failure on builder default_i386_debian_5_0 > while building qemu. > Full details are available at: >  http://buildbot.b1-systems.de/qemu/builders/default_i386_debian_5_0/builds/163 Does anyone have a patch for this? Yes

Re: [Qemu-devel] live snapshot wiki updated

2011-07-21 Thread Stefan Hajnoczi
On Thu, Jul 21, 2011 at 8:42 PM, Blue Swirl wrote: > On Thu, Jul 21, 2011 at 6:01 PM, Stefan Hajnoczi wrote: >> On Thu, Jul 21, 2011 at 3:02 PM, Eric Blake wrote: >>> Thank you for persisting - you've found another hole that needs to be >>> plugged.  It sounds like you are proposing that after a

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2011-07-21 Thread Serge Hallyn
Actually maverick is waiting for a fix for bug 790145 to be verified, but lucid is free. I've uploaded the proposed fix to lucid-proposed, it's waiting for an SRU admin to approve it. I will also post the amd64 lucid .debs at http://people.canonical.com/~serge/qemu-slow-save/. -- You received t

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2011-07-21 Thread Jeff Snider
Ok, great! Thanks for the quick response. I did just now get finished testing the packages you attached in #21 using my lucid box. Saves of a 256Mb guest went from ~50 seconds to ~3. So it does seem to fix the issue. I can set up a Maverick box if you need it tested there as well. I checked f

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2011-07-21 Thread Serge Hallyn
(setting importance to medium because it has a moderate impact on a core application, and especially because it has no workaround) ** Changed in: qemu-kvm (Ubuntu Lucid) Importance: Undecided => Medium ** Changed in: qemu-kvm (Ubuntu Maverick) Importance: Undecided => Medium -- You receiv

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2011-07-21 Thread Serge Hallyn
Oops, this is for qemu-kvm, not libvirt. That can go immediately. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/524447 Title: virsh save is very slow Status in libvirt virtualization API: Unkno

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2011-07-21 Thread Serge Hallyn
@Jeff, they do still need testing. However at this point new ones need to be generated. There is a bit of a backlog on libvirt updates to push. Depending on how those go, I could get packages into -proposed either next week or in 2-3 weeks. I'll make a note to queue this, and ping here when I'

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2011-07-21 Thread Jeff Snider
I'd like to help get this fixed, particularly in Lucid. What can I do? Does #21 and #22 still need testing? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/524447 Title: virsh save is very slow Sta

[Qemu-devel] Boot order problem

2011-07-21 Thread Minoru Usui
Hi, everyone I'm in trouble about boot order of VM. If anyone know cause of this problem, please let me know. On following environment, I tried to boot from IDE CD-ROM device without inserting any bootable media, which is expected to fail, but VM was booting up from virtio HDD which was not spec

[Qemu-devel] buildbot failure in qemu on disable_kvm_x86_64_out_of_tree

2011-07-21 Thread qemu
The Buildbot has detected a new failure on builder disable_kvm_x86_64_out_of_tree while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/disable_kvm_x86_64_out_of_tree/builds/163 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Buil

[Qemu-devel] buildbot failure in qemu on disable_kvm_i386_out_of_tree

2011-07-21 Thread qemu
The Buildbot has detected a new failure on builder disable_kvm_i386_out_of_tree while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/disable_kvm_i386_out_of_tree/builds/163 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: y

[Qemu-devel] buildbot failure in qemu on disable_kvm_x86_64_debian_5_0

2011-07-21 Thread qemu
The Buildbot has detected a new failure on builder disable_kvm_x86_64_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/disable_kvm_x86_64_debian_5_0/builds/166 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build:

[Qemu-devel] buildbot failure in qemu on disable_kvm_i386_debian_5_0

2011-07-21 Thread qemu
The Buildbot has detected a new failure on builder disable_kvm_i386_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/disable_kvm_i386_debian_5_0/builds/163 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuz

Re: [Qemu-devel] [RFC 3/4] A separate thread for the VM migration

2011-07-21 Thread Umesh Deshpande
- Original Message - From: "Marcelo Tosatti" To: "Umesh Deshpande" Cc: k...@vger.kernel.org, qemu-devel@nongnu.org Sent: Wednesday, July 20, 2011 3:02:46 PM Subject: Re: [RFC 3/4] A separate thread for the VM migration On Wed, Jul 20, 2011 at 12:00:44AM -0400, Umesh Deshpande wrote: >

Re: [Qemu-devel] [PATCH] esp: correctly fill bus id with requested lun

2011-07-21 Thread Artyom Tarasenko
2011/7/2 Hervé Poussineau : > This bug showed up after 1455084ea2c48abf23c4e4e15e378ee43457f381, and > may be seen only on operating systems *not* using DMA to give commands > to SCSI adapter. > > Signed-off-by: Hervé Poussineau > --- >  hw/esp.c |    2 +- >  1 files changed, 1 insertions(+), 1 de

[Qemu-devel] buildbot failure in qemu on default_x86_64_debian_5_0

2011-07-21 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_debian_5_0/builds/162 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

[Qemu-devel] buildbot failure in qemu on default_i386_out_of_tree

2011-07-21 Thread qemu
The Buildbot has detected a new failure on builder default_i386_out_of_tree while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_i386_out_of_tree/builds/162 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Bu

[Qemu-devel] buildbot failure in qemu on default_ppc

2011-07-21 Thread qemu
The Buildbot has detected a new failure on builder default_ppc while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_ppc/builds/98 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: qemu-ppc.opensuse.org Build Reason:

[Qemu-devel] buildbot failure in qemu on default_i386_debian_5_0

2011-07-21 Thread qemu
The Buildbot has detected a new failure on builder default_i386_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_i386_debian_5_0/builds/163 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Buil

[Qemu-devel] buildbot failure in qemu on default_x86_64_out_of_tree

2011-07-21 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_out_of_tree while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_out_of_tree/builds/162 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuk

[Qemu-devel] [PATCH 22/25] qerror: add QERR_JSON_PARSE_ERROR to qerror.c

2011-07-21 Thread Luiz Capitulino
From: Michael Roth Missing from previous addition of error to qerror.h. Needed for qerror_format() and friends. Signed-off-by: Michael Roth Signed-off-by: Luiz Capitulino --- qerror.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index d7fcd9

[Qemu-devel] [PATCH 07/25] qapi: add QAPI visitor core

2011-07-21 Thread Luiz Capitulino
From: Michael Roth Base definitions/includes for Visiter interface used by generated visiter/marshalling code. Includes a GenericList type. Our lists require an embedded element. Since these types are generated, if you want to use them in a different type of data structure, there's no easy way t

[Qemu-devel] [PATCH 18/25] qapi: test schema used for unit tests

2011-07-21 Thread Luiz Capitulino
From: Michael Roth This is how QMP commands/parameters/types would be defined. We use a subset of that functionality here to implement functions/types for unit testing. Signed-off-by: Michael Roth Signed-off-by: Luiz Capitulino --- qapi-schema-test.json | 22 ++ 1 files

[Qemu-devel] [PATCH 19/25] qapi: add test-visitor, tests for gen. visitor code

2011-07-21 Thread Luiz Capitulino
From: Michael Roth Signed-off-by: Michael Roth Signed-off-by: Luiz Capitulino --- Makefile | 19 +++- test-visitor.c | 306 2 files changed, 323 insertions(+), 2 deletions(-) create mode 100644 test-visitor.c diff --git a/Make

[Qemu-devel] [PATCH 13/25] qapi: add ordereddict.py helper library

2011-07-21 Thread Luiz Capitulino
From: Michael Roth We need this to parse dictionaries with schema ordering intact so that C prototypes can be generated deterministically. Signed-off-by: Michael Roth Signed-off-by: Luiz Capitulino --- scripts/ordereddict.py | 127 1 files cha

[Qemu-devel] [PATCH 11/25] qapi: add QMP command registration/lookup functions

2011-07-21 Thread Luiz Capitulino
From: Michael Roth Registration/lookup functions for that provide a lookup table for dispatching QMP commands. Signed-off-by: Michael Roth Signed-off-by: Luiz Capitulino --- Makefile.objs |1 + qapi/qmp-core.h | 39 +++ qapi/qmp-registry.c |

[Qemu-devel] [PATCH 14/25] qapi: add qapi.py helper libraries

2011-07-21 Thread Luiz Capitulino
From: Michael Roth Signed-off-by: Michael Roth Signed-off-by: Luiz Capitulino --- scripts/qapi.py | 203 +++ 1 files changed, 203 insertions(+), 0 deletions(-) create mode 100644 scripts/qapi.py diff --git a/scripts/qapi.py b/scripts/qapi.

[Qemu-devel] [PATCH 20/25] qapi: add test-qmp-commands, tests for gen. marshalling/dispatch code

2011-07-21 Thread Luiz Capitulino
From: Michael Roth Signed-off-by: Michael Roth Signed-off-by: Luiz Capitulino --- Makefile|8 +++- test-qmp-commands.c | 113 +++ 2 files changed, 120 insertions(+), 1 deletions(-) create mode 100644 test-qmp-commands.c diff --

[Qemu-devel] [PATCH 10/25] qapi: add QAPI dealloc visitor

2011-07-21 Thread Luiz Capitulino
From: Michael Roth Type of Visitor class that can be passed into a qapi-generated C type's visitor function to free() any heap-allocated data types. Signed-off-by: Michael Roth Signed-off-by: Luiz Capitulino --- Makefile.objs |2 +- qapi/qapi-dealloc-visitor.c | 147 +++

[Qemu-devel] [PATCH 23/25] guest agent: command state class

2011-07-21 Thread Luiz Capitulino
From: Michael Roth Signed-off-by: Michael Roth Signed-off-by: Luiz Capitulino --- Makefile|4 ++- configure |1 + qga/guest-agent-command-state.c | 73 +++ qga/guest-agent-core.h | 25 +++

[Qemu-devel] [PATCH 15/25] qapi: add qapi-types.py code generator

2011-07-21 Thread Luiz Capitulino
From: Michael Roth This is the code generator for qapi types. It will generation the following files: $(prefix)qapi-types.h - C types corresponding to types defined in the schema you pass in $(prefix)qapi-types.c - Cleanup functions for the above C types The $(pref

[Qemu-devel] [PATCH 06/25] qapi: add module init types for qapi

2011-07-21 Thread Luiz Capitulino
From: Michael Roth Signed-off-by: Michael Roth Signed-off-by: Luiz Capitulino --- module.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/module.h b/module.h index 9263f1c..ef66730 100644 --- a/module.h +++ b/module.h @@ -24,12 +24,14 @@ typedef enum { MODULE_IN

[Qemu-devel] [PATCH 21/25] qapi: add QAPI code generation documentation

2011-07-21 Thread Luiz Capitulino
From: Michael Roth Signed-off-by: Michael Roth Signed-off-by: Luiz Capitulino --- docs/qapi-code-gen.txt | 316 1 files changed, 316 insertions(+), 0 deletions(-) create mode 100644 docs/qapi-code-gen.txt diff --git a/docs/qapi-code-gen.txt b

[Qemu-devel] [PATCH 12/25] qapi: add QMP dispatch functions

2011-07-21 Thread Luiz Capitulino
From: Michael Roth Given an object recieved via QMP, this code uses the dispatch table provided by qmp_registry.c to call the corresponding marshalling/dispatch function and format return values/errors for delivery to the QMP. Currently only synchronous QMP functions are supported, but this will

[Qemu-devel] [PATCH 08/25] qapi: add QMP input visitor

2011-07-21 Thread Luiz Capitulino
From: Michael Roth A type of Visiter class that is used to walk a qobject's structure and assign each entry to the corresponding native C type. Command marshaling function will use this to pull out QMP command parameters recieved over the wire and pass them as native arguments to the correspondin

[Qemu-devel] [PATCH 24/25] guest agent: qemu-ga daemon

2011-07-21 Thread Luiz Capitulino
From: Michael Roth This is the actual guest daemon, it listens for requests over a virtio-serial/isa-serial/unix socket channel and routes them through to dispatch routines, and writes the results back to the channel in a manner similar to QMP. A shorthand invocation: qemu-ga -d Is equivalen

[Qemu-devel] [PATCH 05/25] qlist: add qlist_first()/qlist_next()

2011-07-21 Thread Luiz Capitulino
From: Michael Roth Signed-off-by: Michael Roth Signed-off-by: Luiz Capitulino --- qlist.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/qlist.h b/qlist.h index dbe7b92..d426bd4 100644 --- a/qlist.h +++ b/qlist.h @@ -16,6 +16,7 @@ #include "qobject.h" #in

[Qemu-devel] [PATCH 02/25] Introduce compiler.h header file

2011-07-21 Thread Luiz Capitulino
From: Luiz Capitulino This moves compiler related macros from qemu-common.h to compiler.h. The reason for this change is that there are simple header files that depend only on the compiler macros, so including qemu-common.h is overkill. Besides, qemu-common.h is bloated and will benefit from so

[Qemu-devel] [PATCH 09/25] qapi: add QMP output visitor

2011-07-21 Thread Luiz Capitulino
From: Michael Roth Type of Visiter class that serves as the inverse of the input visitor: it takes a series of native C types and uses their values to construct a corresponding QObject. The command marshaling/dispatcher functions will use this to convert the output of QMP functions into a QObject

[Qemu-devel] [PATCH 04/25] Add hard build dependency on glib

2011-07-21 Thread Luiz Capitulino
From: Anthony Liguori GLib is an extremely common library that has a portable thread implementation along with tons of other goodies. GLib and GObject have a fantastic amount of infrastructure we can leverage in QEMU including an object oriented programming infrastructure. Short term, it has a

Re: [Qemu-devel] [PATCH 0/7] SPARC64: fix nonfaulting load on softmmu

2011-07-21 Thread Blue Swirl
Thanks, applied all. On Thu, Jul 21, 2011 at 6:16 PM, Tsuneo Saito wrote: > This patch series fixes nonfaulting load ASIs and traps related to them. > According to "8.3.4 Non-Faulting Load" in the UltraSPARC-IIi User's Manual, > a CPU should raise a TLB miss to the system software if the load is

[Qemu-devel] [PATCH 17/25] qapi: add qapi-commands.py code generator

2011-07-21 Thread Luiz Capitulino
From: Michael Roth This is the code generator for qapi command marshaling/dispatch. Currently only generators for synchronous qapi/qmp functions are supported. This script generates the following files: $(prefix)qmp-marshal.c: command marshal/dispatch functions for each

[Qemu-devel] [PATCH 16/25] qapi: add qapi-visit.py code generator

2011-07-21 Thread Luiz Capitulino
From: Michael Roth This is the code generator for qapi visiter functions used to marshal/unmarshal/dealloc qapi types. It generates the following 2 files: $(prefix)qapi-visit.c: visiter function for a particular c type, used to automagically convert qobjects into the

[Qemu-devel] [PATCH 25/25] guest agent: add guest agent RPCs/commands

2011-07-21 Thread Luiz Capitulino
From: Michael Roth This adds the initial set of QMP/QAPI commands provided by the guest agent: guest-sync guest-ping guest-info guest-shutdown guest-file-open guest-file-read guest-file-write guest-file-seek guest-file-flush guest-file-close guest-fsfreeze-freeze guest-fsfreeze-thaw guest-fsfree

[Qemu-devel] [PATCH 03/25] Error: Fix build when qemu-common.h is not included

2011-07-21 Thread Luiz Capitulino
From: Luiz Capitulino Commit e4ea5e2d0e0e4c5188ab45b66f3195062ae059dc added the use of the macro GCC_FMT_ATTR to error.h, however compiler.h is not included by error.h This will cause a build error when files including error.h don't include qemu-common.h (or compiler.h). Not an issue today becau

[Qemu-devel] [PATCH 01/25] QMP: add snapshot-blkdev-sync command

2011-07-21 Thread Luiz Capitulino
From: Jes Sorensen Add QMP bits for snapshot_blkdev command. This is the same as snapshot_blkdev in the human monitor. The command is synchronous. In the future async commands and or a break down of the functionality into multiple commands might be added. Also change the 'snapshot_file' argumen

[Qemu-devel] [PULL 0/25]: QMP queue

2011-07-21 Thread Luiz Capitulino
Anthony, The following patches have been sent to the list and look good to me. I've also tested them. The changes (since 6c916eda22e7ef180bb2dd183bbef85f9ff006c6) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git for-anthony Anthony Liguori (1): Add har

Re: [Qemu-devel] [RFC v5 12/86] memory: add ioeventfd support

2011-07-21 Thread Blue Swirl
On Wed, Jul 20, 2011 at 7:49 PM, Avi Kivity wrote: > As with the rest of the memory API, the caller associates an eventfd > with an address, and the memory API takes care of registering or > unregistering when the address is made visible or invisible to the > guest. > > Signed-off-by: Avi Kivity

[Qemu-devel] [PATCH] slirp: Fix unusual "comments" in unused code

2011-07-21 Thread Stefan Weil
cppcheck detected two rather strange comments which were not correctly written as C comments. They did not cause any harm because they were framed by #ifdef notdef ... #endif, so they were never compiled. Fix them nevertheless (we could also remove the unused code). Signed-off-by: Stefan Weil -

Re: [Qemu-devel] live snapshot wiki updated

2011-07-21 Thread Blue Swirl
On Thu, Jul 21, 2011 at 6:01 PM, Stefan Hajnoczi wrote: > On Thu, Jul 21, 2011 at 3:02 PM, Eric Blake wrote: >> Thank you for persisting - you've found another hole that needs to be >> plugged.  It sounds like you are proposing that after a qemu process dies, >> that libvirt re-reads the qcow2 me

Re: [Qemu-devel] live snapshot wiki updated

2011-07-21 Thread Blue Swirl
On Thu, Jul 21, 2011 at 11:07 AM, Jes Sorensen wrote: > On 07/20/11 21:51, Blue Swirl wrote: >>> And the snapshot_blkdev monitor command is a case where qemu needs to create >>> > a new qcow2 image on the fly, while referencing the name of an existing >>> > file.  What backing name do you put in t

Re: [Qemu-devel] [PATCH 14/23] PPC: KVM: Add generic function to read host clockfreq

2011-07-21 Thread Scott Wood
On Thu, 21 Jul 2011 20:59:40 +0200 Alexander Graf wrote: > >> +uint32_t kvmppc_get_clockfreq(void) > >> +{ > >> +char buf[512]; > >> +uint32_t tb; > >> +FILE *f; > >> +int len; > >> + > >> +if (kvmppc_find_cpu_dt(buf, sizeof(buf))) { > >> +return 0; > >> +} > >> +

Re: [Qemu-devel] live snapshot wiki updated

2011-07-21 Thread Blue Swirl
On Thu, Jul 21, 2011 at 11:25 AM, Kevin Wolf wrote: > Am 20.07.2011 19:20, schrieb Blue Swirl: >> On Wed, Jul 20, 2011 at 4:51 PM, Kevin Wolf wrote: >>> Am 20.07.2011 15:25, schrieb Jes Sorensen: On 07/20/11 12:01, Kevin Wolf wrote: >>> Right, we're stuck with the two horros of NFS and s

Re: [Qemu-devel] [PATCH 14/23] PPC: KVM: Add generic function to read host clockfreq

2011-07-21 Thread Alexander Graf
Am 21.07.2011 um 19:51 schrieb Scott Wood : > On Thu, 21 Jul 2011 03:27:25 +0200 > Alexander Graf wrote: > >> +/* Try to find a device tree node for a CPU with clock-frequency property */ >> +static int kvmppc_find_cpu_dt(char *buf, int buf_len) >> +{ >> +struct dirent *dirp; >> +DIR

Re: [Qemu-devel] live snapshot wiki updated

2011-07-21 Thread Michael Roth
On 07/19/2011 11:47 AM, Daniel P. Berrange wrote: On Tue, Jul 19, 2011 at 04:30:19PM +0200, Jes Sorensen wrote: On 07/19/11 16:24, Eric Blake wrote: [adding the libvir-list] On 07/19/2011 08:09 AM, Jes Sorensen wrote: Urgh, libvirt parsing image files is really unfortunate, it really doesn't g

[Qemu-devel] [PATCH] lm32: softusb: claim to support full speed

2011-07-21 Thread Michael Walle
The QEMU keyboard and mouse reports themselves as full speed devices, though they are actually low speed devices. Until this is fixed, claim that we are supporting full speed devices. Signed-off-by: Michael Walle --- hw/milkymist-softusb.c |6 -- 1 files changed, 4 insertions(+), 2 delet

[Qemu-devel] error when doing passthrough of bcm netextreme II 10 G device

2011-07-21 Thread Sinha, Ani
Hi Folks : I am trying to assinga bcm netextreme II 10 G eth device to a guest using PCI passthrough in QEMU. 01:00.0 Ethernet controller: Broadcom Corporation NetXtreme II BCM57711 10-Gigabit PCIe 01:00.1 Ethernet controller: Broadcom Corporation NetXtreme II BCM57711 10-Gigabit PCIe qemu> d

Re: [Qemu-devel] [PATCH 14/23] PPC: KVM: Add generic function to read host clockfreq

2011-07-21 Thread Scott Wood
On Thu, 21 Jul 2011 03:27:25 +0200 Alexander Graf wrote: > +/* Try to find a device tree node for a CPU with clock-frequency property */ > +static int kvmppc_find_cpu_dt(char *buf, int buf_len) > +{ > +struct dirent *dirp; > +DIR *dp; > + > +if ((dp = opendir(PROC_DEVTREE_CPU)) == NUL

Re: [Qemu-devel] [PATCH 01/23] PPC: Add secondary CPU spinning code

2011-07-21 Thread Scott Wood
On Thu, 21 Jul 2011 18:49:44 +0200 Alexander Graf wrote: > > On 21.07.2011, at 18:38, Scott Wood wrote: > > > On Thu, 21 Jul 2011 03:27:12 +0200 > > Alexander Graf wrote: > > > >> When directly starting an SMP system with -kernel on PPC e500, we need to > >> simulate the spin table code from

Re: [Qemu-devel] [PATCH 45/55] block: Clean up remaining users of "removable"

2011-07-21 Thread Luiz Capitulino
On Wed, 20 Jul 2011 18:24:19 +0200 Markus Armbruster wrote: > BlockDriverState member removable is a confused mess. It is true when > an ide-cd, scsi-cd or floppy qdev is attached, or when the > BlockDriverState was created with -drive if={floppy,sd} or -drive > if={ide,scsi,xen,none},media=cdro

Re: [Qemu-devel] [PATCH 28/55] block: Leave enforcing tray lock to device models

2011-07-21 Thread Luiz Capitulino
On Thu, 21 Jul 2011 17:16:13 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 20 Jul 2011 18:24:02 +0200 > > Markus Armbruster wrote: > > > >> The device model knows best when to accept the guest's eject command. > >> No need to detour through the block layer. > >> > >>

Re: [Qemu-devel] [PATCH v7 00/11] async + suspend reworked

2011-07-21 Thread Gerd Hoffmann
On 07/20/11 11:20, Alon Levy wrote: v7 changes: use updated spice api (spice_qxl_update_area_async etc.) Looks good, finally hashed out all the issues, great job. I'll go queue it up for early 0.16 merge once we have a spice release with the required libspice-server bits included. thanks,

Re: [Qemu-devel] [PATCH 23/55] block: Show whether the guest ejected the medium in info block

2011-07-21 Thread Luiz Capitulino
On Thu, 21 Jul 2011 13:38:46 -0300 Luiz Capitulino wrote: > On Thu, 21 Jul 2011 17:08:56 +0200 > Markus Armbruster wrote: > > > Luiz Capitulino writes: > > > > > On Wed, 20 Jul 2011 18:23:57 +0200 > > > Markus Armbruster wrote: > > > > > >> Need to ask the device, so this requires new BlockD

Re: [Qemu-devel] [PATCH v7 00/11] async + suspend reworked

2011-07-21 Thread Alon Levy
On Thu, Jul 21, 2011 at 06:48:33PM +0200, Gerd Hoffmann wrote: > On 07/20/11 11:20, Alon Levy wrote: > >v7 changes: > > use updated spice api (spice_qxl_update_area_async etc.) > > Looks good, finally hashed out all the issues, great job. > Thanks very much. > I'll go queue it up for early 0.1

Re: [Qemu-devel] [PATCH 23/55] block: Show whether the guest ejected the medium in info block

2011-07-21 Thread Luiz Capitulino
On Thu, 21 Jul 2011 17:08:56 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 20 Jul 2011 18:23:57 +0200 > > Markus Armbruster wrote: > > > >> Need to ask the device, so this requires new BlockDevOps member > >> is_medium_ejected(). > >> > >> Signed-off-by: Markus Armbru

[Qemu-devel] [PATCH] target-arm: Support v6 barriers in linux-user mode

2011-07-21 Thread Peter Maydell
ARMv6 implemented various operations as special cases of cp15 accesses which are true instructions in v7; this includes barriers (DMB, DSB, ISB). Catch this special case at translate time, so that it works in linux-user mode (which doesn't provide a functional get_cp15 helper) as well as system mod

Re: [Qemu-devel] [PATCH 07/55] block: Make BlockDriver method bdrv_set_locked() return void

2011-07-21 Thread Luiz Capitulino
On Thu, 21 Jul 2011 17:07:17 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 20 Jul 2011 18:23:41 +0200 > > Markus Armbruster wrote: > > > >> The only caller is bdrv_set_locked(), and it ignores the value. > >> > >> Callees always return 0, except for FreeBSD's cdrom_se

Re: [Qemu-devel] [PATCH 03/23] PPC: Add CPU definitions for up to 32 guest CPUs

2011-07-21 Thread Alexander Graf
On 21.07.2011, at 18:46, Scott Wood wrote: > On Thu, 21 Jul 2011 03:27:14 +0200 > Alexander Graf wrote: > >> All guest CPUs need to be specified in the device trees. Since removing nodes >> is easy with FDT, but adding nodes is not, we just put 32 CPU nodes into the >> device tree and remove th

Re: [Qemu-devel] [PATCH 07/23] PPC: Remove cINT code from MPIC

2011-07-21 Thread Alexander Graf
On 21.07.2011, at 18:49, Scott Wood wrote: > On Thu, 21 Jul 2011 03:27:18 +0200 > Alexander Graf wrote: > >> The current code treats some bits in IDE as special for critical interrupts. >> While there is logic to route interrupts as critical, that happens through >> a different register. So for

[Qemu-devel] [PATCH] pci: Common overflow prevention

2011-07-21 Thread Jan Kiszka
Introduce pci_config_read/write_common helpers to prevent passing accesses down the callback chain that go beyond the config space limits. Adjust length assertions as they are no longer correct (cutting may generate valid 3 byte accesses). Signed-off-by: Jan Kiszka --- Now I have to deal with 3

Re: [Qemu-devel] [PATCH 01/23] PPC: Add secondary CPU spinning code

2011-07-21 Thread Alexander Graf
On 21.07.2011, at 18:38, Scott Wood wrote: > On Thu, 21 Jul 2011 03:27:12 +0200 > Alexander Graf wrote: > >> When directly starting an SMP system with -kernel on PPC e500, we need to >> simulate the spin table code from u-boot. This code adds a small c file >> plus generated .elf file that enab

Re: [Qemu-devel] [PATCH 07/23] PPC: Remove cINT code from MPIC

2011-07-21 Thread Scott Wood
On Thu, 21 Jul 2011 03:27:18 +0200 Alexander Graf wrote: > The current code treats some bits in IDE as special for critical interrupts. > While there is logic to route interrupts as critical, that happens through > a different register. So for now I'm just removing the check to enable up to > 32

Re: [Qemu-devel] [PATCH 03/23] PPC: Add CPU definitions for up to 32 guest CPUs

2011-07-21 Thread Scott Wood
On Thu, 21 Jul 2011 03:27:14 +0200 Alexander Graf wrote: > All guest CPUs need to be specified in the device trees. Since removing nodes > is easy with FDT, but adding nodes is not, we just put 32 CPU nodes into the > device tree and remove them later on init when not used. Adding nodes isn't th

Re: [Qemu-devel] [PATCH 01/23] PPC: Add secondary CPU spinning code

2011-07-21 Thread Scott Wood
On Thu, 21 Jul 2011 03:27:12 +0200 Alexander Graf wrote: > When directly starting an SMP system with -kernel on PPC e500, we need to > simulate the spin table code from u-boot. This code adds a small c file > plus generated .elf file that enable secondary CPUs to spin just like they > would with

Re: [Qemu-devel] [RFC] QEMU Object Model

2011-07-21 Thread Anthony Liguori
On 07/21/2011 10:57 AM, Avi Kivity wrote: On 07/21/2011 06:45 PM, Anthony Liguori wrote: See git://git.codemonkey.ws/kvm++.git Connection refused.. Sorry, stupid EC2. Try http://git.codemonkey.ws/git/kvm++.git You don't have permission to access /git/kvm++.git/ on this server. git clon

Re: [Qemu-devel] [RFC] QEMU Object Model

2011-07-21 Thread Anthony Liguori
On 07/21/2011 08:38 AM, Avi Kivity wrote: On 07/21/2011 04:20 PM, Anthony Liguori wrote: static TypeInfo tcp_server_type_info = { .name = TYPE_TCP_SERVER, .parent = TYPE_SOCKET_SERVER, .instance_size = sizeof(TcpServer), .instance_init = tcp_server_init, .class_init = tcp_server_class_init, };

Re: [Qemu-devel] [PATCH 07/55] block: Make BlockDriver method bdrv_set_locked() return void

2011-07-21 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 20 Jul 2011 18:23:41 +0200 > Markus Armbruster wrote: > >> The only caller is bdrv_set_locked(), and it ignores the value. >> >> Callees always return 0, except for FreeBSD's cdrom_set_locked(), >> which returns -ENOTSUP when the device is in a terminally wedge

[Qemu-devel] [PATCH 5/7] SPARC64: fix fault status overwritten on nonfaulting load

2011-07-21 Thread Tsuneo Saito
cpu_get_phys_page_nofault() calls get_physical_address() twice, that results in overwriting the fault status in the SFSR. We need this change in order for nonfaulting loads to raising MMU faults as normal loads do. Also removed the call to cpu_get_physical_page_desc() since we are going to modify n

[Qemu-devel] [PATCH 6/7] SPARC64: implement MMU miss traps on nonfaulting loads

2011-07-21 Thread Tsuneo Saito
Nonfaulting loads should raise fast_data_access_MMU_miss traps as normal loads do. It is up to the guest OS kernel that detect MMU misses on nonfaulting load instructions and make them complete without signaling. Signed-off-by: Tsuneo Saito --- target-sparc/op_helper.c | 36 ++

[Qemu-devel] [PATCH 1/7] SPARC64: TTE bits cleanup

2011-07-21 Thread Tsuneo Saito
Add macros for TTE bits and modify to use macros instead of magic numbers. Signed-off-by: Tsuneo Saito --- target-sparc/cpu.h|7 +++ target-sparc/helper.c | 35 +++ 2 files changed, 26 insertions(+), 16 deletions(-) diff --git a/target-sparc/cpu.h b

[Qemu-devel] [RFC] qcow2: 2 way to improve performance updating refcount

2011-07-21 Thread Frediano Ziglio
Hi, after a snapshot is taken currently many write operations are quite slow due to - refcount updates (decrement old and increment new ) - cluster allocation and file expansion - read-modify-write on partial clusters I found 2 way to improve refcount performance Method 1 - Lazy count Mainly do

Re: [Qemu-devel] [PATCH 23/55] block: Show whether the guest ejected the medium in info block

2011-07-21 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 20 Jul 2011 18:23:57 +0200 > Markus Armbruster wrote: > >> Need to ask the device, so this requires new BlockDevOps member >> is_medium_ejected(). >> >> Signed-off-by: Markus Armbruster >> --- >> block.c | 18 -- >> block.h |

Re: [Qemu-devel] [RFC] QEMU Object Model

2011-07-21 Thread Avi Kivity
On 07/21/2011 05:49 PM, Anthony Liguori wrote: On 07/21/2011 08:38 AM, Avi Kivity wrote: On 07/21/2011 04:20 PM, Anthony Liguori wrote: static TypeInfo tcp_server_type_info = { .name = TYPE_TCP_SERVER, .parent = TYPE_SOCKET_SERVER, .instance_size = sizeof(TcpServer), .instance_init = tcp_serv

[Qemu-devel] [PATCH 7/7] SPARC64: implement addtional MMU faults related to nonfaulting load

2011-07-21 Thread Tsuneo Saito
This patch implements MMU faults caused by TTE.NFO and TTE.E: - access other than nonfaulting load to a page marked NFO should raise data_access_exception - nonfaulting load to a page marked with E bit should raise data_access_exception To distinguish nonfaulting loads, this patch extends (abu

Re: [Qemu-devel] [PATCH 28/55] block: Leave enforcing tray lock to device models

2011-07-21 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 20 Jul 2011 18:24:02 +0200 > Markus Armbruster wrote: > >> The device model knows best when to accept the guest's eject command. >> No need to detour through the block layer. >> >> bdrv_eject() can't fail anymore. Make it void. > > But we're supposed to return

[Qemu-devel] Fedora Virt Status

2011-07-21 Thread Justin M. Forbes
Fedora 15 - We have 65 open bugs 11 of which have fixes in awaiting updates. - 12 bugs have been closed in the last week Fedora 16 Fedora 16 Feature Freeze is just 1 week away. It is time to make sure things are in shape for alpha. Important dates for the Fedora 16 Schedule: 2011-07-26 F

[Qemu-devel] [PATCH 2/7] SPARC64: SFSR cleanup and fix

2011-07-21 Thread Tsuneo Saito
Add macros for SFSR fields and use macros instead of magic numbers. Also fix the update of the register fields on MMU faults. Signed-off-by: Tsuneo Saito --- target-sparc/cpu.h| 22 target-sparc/helper.c | 52 +--- 2 files

[Qemu-devel] [PATCH 3/7] SPARC64: introduce a convenience function for getting physical addresses

2011-07-21 Thread Tsuneo Saito
Introduce cpu_sparc_get_phys_page() to be used as a help for splitting cpu_get_phys_page_debug() from cpu_get_phys_page_nofault(). Signed-off-by: Tsuneo Saito --- target-sparc/helper.c | 20 ++-- 1 files changed, 14 insertions(+), 6 deletions(-) diff --git a/target-sparc/helpe

Re: [Qemu-devel] [RFC] QEMU Object Model

2011-07-21 Thread Avi Kivity
On 07/21/2011 06:45 PM, Anthony Liguori wrote: See git://git.codemonkey.ws/kvm++.git Connection refused.. Sorry, stupid EC2. Try http://git.codemonkey.ws/git/kvm++.git You don't have permission to access /git/kvm++.git/ on this server. It's exactly the same object model, but in C++.

Re: [Qemu-devel] [PATCH] memory: transaction API

2011-07-21 Thread Avi Kivity
On 07/21/2011 06:05 PM, Jan Kiszka wrote: > > The point is _update() can only make changes for one region atomic, > while _commit() is more general. You can sometimes batch all changes > into a single container region, but sometimes it is clumsy, and > sometimes impossible. > > Deletion and

[Qemu-devel] [PATCH 0/7] SPARC64: fix nonfaulting load on softmmu

2011-07-21 Thread Tsuneo Saito
This patch series fixes nonfaulting load ASIs and traps related to them. According to "8.3.4 Non-Faulting Load" in the UltraSPARC-IIi User's Manual, a CPU should raise a TLB miss to the system software if the load is for unmapped area: "When a non-faulting load encounters a TLB miss, the operatin

Re: [Qemu-devel] [RFC] QEMU Object Model

2011-07-21 Thread Anthony Liguori
On 07/21/2011 10:19 AM, Luca Tettamanti wrote: On Thu, Jul 21, 2011 at 4:49 PM, Anthony Liguori wrote: [cut] And it's really not that much nicer than the C version. The problem with C++ is that even though the type system is much, much nicer, it still doesn't have introspection or decorators.

  1   2   >