Re: [Qemu-devel] [PATCH] e1000: Handle IO Port.

2011-06-27 Thread Paolo Bonzini
On 06/27/2011 08:07 PM, Peter Maydell wrote: > +int ioport_base; > +uint32_t ioport_reg[2]; I think ioport_reg[] needs to go in the VMStateDescription as well. I don't know enough about the PCI subsystem to know whether that's also true of ioport_base or whether the the map function is

[Qemu-devel] buildbot failure in qemu on ppc-next_i386_debian_5_0

2011-06-27 Thread qemu
The Buildbot has detected a new failure on builder ppc-next_i386_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/ppc-next_i386_debian_5_0/builds/17 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Bui

[Qemu-devel] [PATCH v5 12/12] BlockDriver: add bdrv_get_allocated_file_size() operation

2011-06-27 Thread Fam Zheng
qemu-img.c wants to count allocated file size of image. Previously it counts a single bs->file by 'stat' or Window API. As VMDK introduces multiple file support, the operation becomes format specific with platform specific meanwhile. The functions are moved to block/raw-{posix,win32}.c and qemu-im

[Qemu-devel] Query on the License of qemu

2011-06-27 Thread 박재민
Dear All, This is Jaemin Park, who delves into qemu. I have 2 questions about the license of qemu. 1. Does it has any GPL issues to deploy a virtual machine, which runs a proprietary operating system, on qemu? Qemu has GPL. A guest which runs on Qemu, has non-GPL. Is it OK to release them toget

[Qemu-devel] [PATCH v5 10/12] VMDK: create different subformats

2011-06-27 Thread Fam Zheng
Add create option 'format', with enums: monolithicSparse monolithicFlat twoGbMaxExtentSparse twoGbMaxExtentFlat Each creates a subformat image file. The default is monolithiSparse. Signed-off-by: Fam Zheng --- block/vmdk.c | 563 ++

[Qemu-devel] [PATCH v5 07/12] VMDK: move 'static' cid_update flag to bs field

2011-06-27 Thread Fam Zheng
Cid_update is the flag for updating CID on first write after opening the image. This should be per image open rather than per program life cycle, so change it from static var of vmdk_write to a field in BDRVVmdkState. Signed-off-by: Fam Zheng --- block/vmdk.c |6 +++--- 1 files changed, 3 in

[Qemu-devel] [PATCH v5 11/12] VMDK: fix coding style

2011-06-27 Thread Fam Zheng
Conform coding style in vmdk.c to pass scripts/checkpatch.pl checks. Signed-off-by: Fam Zheng --- block/vmdk.c | 79 +++-- 1 files changed, 48 insertions(+), 31 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index c8f3536..f472e39 100

[Qemu-devel] [PATCH v5 08/12] VMDK: change get_cluster_offset return type

2011-06-27 Thread Fam Zheng
The return type of get_cluster_offset was an offset that use 0 to denote 'not allocated', this will be no longer true for flat extents, as we see flat extent file as a single huge cluster whose offset is 0 and length is the whole file length. So now we use int return value, 0 means success and othe

[Qemu-devel] [PATCH v5 06/12] VMDK: flush multiple extents

2011-06-27 Thread Fam Zheng
Flush all the file that referenced by the image. Signed-off-by: Fam Zheng --- block/vmdk.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index c3f0ab6..cf7370f 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1084,7 +1084,17 @@ s

[Qemu-devel] [PATCH v5 09/12] VMDK: open/read/write for monolithicFlat image

2011-06-27 Thread Fam Zheng
Parse vmdk decriptor file and open mono flat image. Read/write the flat extent. Signed-off-by: Fam Zheng --- block/vmdk.c | 185 + 1 files changed, 172 insertions(+), 13 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index c84ea90.

[Qemu-devel] [PATCH v5 02/12] VMDK: bugfix, align offset to cluster in get_whole_cluster

2011-06-27 Thread Fam Zheng
In get_whole_cluster, the offset is not aligned to cluster when reading from backing_hd. When the first write to child is not at the cluster boundary, wrong address data from parent is copied to child. Signed-off-by: Fam Zheng --- block/vmdk.c |8 +--- 1 files changed, 5 insertions(+), 3

[Qemu-devel] [PATCH v5 05/12] VMDK: add field BDRVVmdkState.desc_offset

2011-06-27 Thread Fam Zheng
There are several occurrence of magic number 0x200 as the descriptor offset within mono sparse image file. This is not the case for images with separate descriptor file. So a field is added to BDRVVmdkState to hold the correct value. Signed-off-by: Fam Zheng --- block/vmdk.c | 26 +

[Qemu-devel] [PATCH v5 01/12] VMDK: introduce VmdkExtent

2011-06-27 Thread Fam Zheng
Introduced VmdkExtent array into BDRVVmdkState, enable holding multiple image extents for multiple file image support. Signed-off-by: Fam Zheng --- block/vmdk.c | 351 +- 1 files changed, 250 insertions(+), 101 deletions(-) diff --git a/b

[Qemu-devel] [PATCH v5 03/12] VMDK: probe for monolithicFlat images

2011-06-27 Thread Fam Zheng
Probe as the same behavior as VMware does. Recognize image as monolithicFlat descriptor file when the file is text and the first effective line (not '#' leaded comment or space line) is either 'version=1' or 'version=2'. No space or upper case charactors accepted. Signed-off-by: Fam Zheng --- bl

[Qemu-devel] [PATCH v5 04/12] VMDK: separate vmdk_open by format version

2011-06-27 Thread Fam Zheng
Separate vmdk_open by subformats to: * vmdk_open_vmdk3 * vmdk_open_vmdk4 Signed-off-by: Fam Zheng --- block/vmdk.c | 195 + 1 files changed, 126 insertions(+), 69 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 3bf8980..81c105

[Qemu-devel] [PATCH v5 00/12] Adding VMDK monolithic flat support

2011-06-27 Thread Fam Zheng
Changes from v4: 09/12: pstrcpy call off-by-one in vmdk_parse_description Fam Zheng (12): VMDK: introduce VmdkExtent VMDK: bugfix, align offset to cluster in get_whole_cluster VMDK: probe for monolithicFlat images VMDK: separate vmdk_open by format version VMDK: add field BDRVVmdkSta

Re: [Qemu-devel] [PATCH 08/12] TCG/PPC: use TCG_REG_CALL_STACK instead of TCG_REG_R1

2011-06-27 Thread malc
On Sun, 26 Jun 2011, Blue Swirl wrote: > Use TCG_REG_CALL_STACK instead of TCG_REG_R1 etc. for consistency. > This i'd rather avoid. [..snip..] -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH 09/12] TCG/PPC: use stack for TCG temps

2011-06-27 Thread malc
On Sun, 26 Jun 2011, Blue Swirl wrote: > Use stack instead of temp_buf array in CPUState for TCG temps. > This works. > Signed-off-by: Blue Swirl > --- > tcg/ppc/tcg-target.c |7 +-- > tcg/ppc64/tcg-target.c |7 +-- > 2 files changed, 10 insertions(+), 4 deletions(-) > > di

Re: [Qemu-devel] [PULL] virtio-serial: Fix segfault on start

2011-06-27 Thread Anthony Liguori
On 06/27/2011 04:37 AM, Amit Shah wrote: Hello, This fixes a segfault at startup regression debugged and fixed by Luiz. Please pull. The following changes since commit f26e428da505709ec03b2ed2c9eb3db82b30bd7b: Fix MinGW compilation when --enable-vnc-jpeg is specified (2011-06-26 20:19:38

Re: [Qemu-devel] [PATCH] [PowerPC][RFC] booke timers

2011-06-27 Thread Scott Wood
On Mon, 27 Jun 2011 18:14:06 +0200 Fabien Chouteau wrote: > While working on the emulation of the freescale p2010 (e500v2) I realized that > there's no implementation of booke's timers features. Currently mpc8544 uses > ppc_emb (ppc_emb_timers_init) which is close but not exactly like booke (for

Re: [Qemu-devel] [PATCHv2 0/4] libcacard fixes

2011-06-27 Thread Alon Levy
On Mon, Jun 27, 2011 at 05:27:35PM +0200, Christophe Fergeau wrote: > Hey, > > Alon asked me to split the parsing patches to make the review easier, to here > they are. Reviewed-by: Alon Levy > > Changes since v1: > - split first patch into 3 patches, v1 2/2 is unchanged > > Christophe Fergea

Re: [Qemu-devel] [RFC v2 00/20] Memory API

2011-06-27 Thread Anthony Liguori
On 06/27/2011 10:59 AM, Michael S. Tsirkin wrote: On Mon, Jun 27, 2011 at 06:54:05PM +0300, Avi Kivity wrote: On 06/27/2011 06:52 PM, Michael S. Tsirkin wrote: - bridges might also enable subtractive decoding (required for isa behind the bridge) What does that mean? subtractive decoding

Re: [Qemu-devel] [PULL] pending linux-user patches

2011-06-27 Thread Anthony Liguori
On 06/25/2011 11:18 AM, riku.voi...@iki.fi wrote: Hi, The following changes since commit 744d3644181ddb16ef5944a0f9217e46961c8c84: coreaudio: Fix OSStatus format specifier (2011-06-23 18:56:58 +0400) Pulled. Thanks. Regards, Anthony Liguori are available in the git repository at:

Re: [Qemu-devel] [PULL] pending linux-user patches

2011-06-27 Thread Anthony Liguori
On 06/25/2011 11:18 AM, riku.voi...@iki.fi wrote: Hi, The following changes since commit 744d3644181ddb16ef5944a0f9217e46961c8c84: coreaudio: Fix OSStatus format specifier (2011-06-23 18:56:58 +0400) are available in the git repository at: git://git.linaro.org/people/rikuvoipio/qemu.git

Re: [Qemu-devel] [PULL 00/13] Trivial patches for June 16 to June 24 2011

2011-06-27 Thread Anthony Liguori
On 06/24/2011 11:56 AM, Stefan Hajnoczi wrote: (I currently do not have access to my email address.) The following changes since commit 744d3644181ddb16ef5944a0f9217e46961c8c84: coreaudio: Fix OSStatus format specifier (2011-06-23 18:56:58 +0400) are available in the git repository at:

Re: [Qemu-devel] [PULL] usb patch queue

2011-06-27 Thread Anthony Liguori
On 06/24/2011 05:59 AM, Gerd Hoffmann wrote: Hi, Here comes the USB patch queue. Nothing major, just a bunch of little fixes and improvements. please pull, Pulled. Thanks. Regards, Anthony Liguori Gerd The following changes since commit 48e2faf222cbf4abab7c8e4b3f44229ec98eae7f:

Re: [Qemu-devel] [PATCH 2/4] virtio-serial: Clean up virtser_bus_dev_print() output

2011-06-27 Thread Andreas Färber
Am 19.05.2011 um 16:18 schrieb Markus Armbruster: Amit Shah writes: On (Thu) 19 May 2011 [13:37:15], Markus Armbruster wrote: Old version looks like this in info qtree (last four lines): dev: virtconsole, id "" dev-prop: is_console = 1 dev-prop: nr = 0

Re: [Qemu-devel] [PATCH] e1000: Handle IO Port.

2011-06-27 Thread Peter Maydell
On 27 June 2011 17:34, Anthony PERARD wrote: > @@ -83,6 +86,8 @@ typedef struct E1000State_st { >     NICState *nic; >     NICConf conf; >     int mmio_index; > +    int ioport_base; > +    uint32_t ioport_reg[2]; I think ioport_reg[] needs to go in the VMStateDescription as well. I don't know en

Re: [Qemu-devel] [PATCH 04/12] TCG/IA64: use TCG_REG_CALL_STACK instead of TCG_REG_R12

2011-06-27 Thread Richard Henderson
On 06/26/2011 12:22 PM, Blue Swirl wrote: > Use TCG_REG_CALL_STACK instead of TCG_REG_R12 for consistency. > > Signed-off-by: Blue Swirl Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 05/12] TCG/IA64: use stack for TCG temps

2011-06-27 Thread Richard Henderson
On 06/26/2011 12:22 PM, Blue Swirl wrote: > Use stack instead of temp_buf array in CPUState for TCG temps. > > Signed-off-by: Blue Swirl Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 2/2] libcacard: add pc file, install it + includes

2011-06-27 Thread Alon Levy
On Mon, Jun 27, 2011 at 02:11:00PM +0200, Christophe Fergeau wrote: > Hi, > > On Mon, Jun 27, 2011 at 12:34:44PM +0200, Alon Levy wrote: > > Also add --pkgconfigdir and --includedir configure parameters. > > --- > > configure | 10 ++ > > libcacard/Makefile| 25

[Qemu-devel] [PATCH v2] qemu_ram_ptr_length: take ram_addr_t as arguments

2011-06-27 Thread stefano.stabellini
From: Stefano Stabellini qemu_ram_ptr_length should take ram_addr_t as argument rather than target_phys_addr_t because is doing comparisons with RAMBlock addresses. cpu_physical_memory_map should create a ram_addr_t address to pass to qemu_ram_ptr_length from PhysPageDesc phys_offset. Remove co

Re: [Qemu-devel] [Qemu-trivial] [PATCH] fix MinGW compilation when --enable-vnc-jpeg is specified

2011-06-27 Thread Stefan Weil
Am 27.06.2011 07:56, schrieb Roy Tam: 2011/6/27 Stefan Weil: Am 27.06.2011 04:37, schrieb TeLeMan: This patch breaks the compilation with --enable-vnc-png: CC ui/vnc-enc-tight.o In file included from /usr/include/png.h:518, from ui/vnc-enc-tight.c:34: /usr/include/pngconf.h:371: error: expecte

Re: [Qemu-devel] [PATCH] qemu_ram_ptr_length: take ram_addr_t as arguments

2011-06-27 Thread Stefano Stabellini
On Mon, 27 Jun 2011, Peter Maydell wrote: > On 27 June 2011 14:34, Stefano Stabellini > wrote: > > On Fri, 24 Jun 2011, Peter Maydell wrote: > >> You probably want to only call qemu_ram_ptr_length() if (todo). > >> (I don't know if anybody ever calls this routine with a zero input > >> length, but

[Qemu-devel] [Bug 799036] Re: NIC assignment order in command line make some NIC can't work

2011-06-27 Thread Yongjie Ren
Without fixing address of the device, the first device will get 00:03.0 in my guest, and the second get 00:04.0. And when NIC 82576 is in the first order, it will get 00:03.0 in my guest, and it will not working. If I fix 82576 NIC using "addr=0x3" and other using "addr=0x4", 82576 NIC in guest

[Qemu-devel] [PATCH] [PowerPC][RFC] booke timers

2011-06-27 Thread Fabien Chouteau
While working on the emulation of the freescale p2010 (e500v2) I realized that there's no implementation of booke's timers features. Currently mpc8544 uses ppc_emb (ppc_emb_timers_init) which is close but not exactly like booke (for example booke uses different SPR). This is a first attempt for a

Re: [Qemu-devel] [PATCH] qemu_ram_ptr_length: take ram_addr_t as arguments

2011-06-27 Thread Peter Maydell
On 27 June 2011 14:34, Stefano Stabellini wrote: > On Fri, 24 Jun 2011, Peter Maydell wrote: >> You probably want to only call qemu_ram_ptr_length() if (todo). >> (I don't know if anybody ever calls this routine with a zero input >> length, but that would handle that case too.) > > I would rather

[Qemu-devel] [PATCH 1/2] linux-user: Add syscall numbers from kernel 2.6.39.2

2011-06-27 Thread Peter Maydell
Add syscall numbers for new syscall numbers; this brings us into line with Linux 2.6.39.2. Signed-off-by: Peter Maydell --- linux-user/alpha/syscall_nr.h | 23 ++- linux-user/arm/syscall_nr.h| 13 + linux-user/cris/syscall_nr.h |2 ++ li

[Qemu-devel] [PATCH 0/2] linux-user: Implement prlimit64

2011-06-27 Thread Peter Maydell
The main purpose of this patch series is to implement the prlimit64 syscall, which is what patch 2 does. Since prlimit64 is a new syscall number, I had to add it to the syscall number definitions. Patch 1 is therefore a comprehensive update of the syscall number tables for all archs to match the ma

[Qemu-devel] [PATCH 2/2] linux-user: Implement prlimit64 syscall

2011-06-27 Thread Peter Maydell
Implement the prlimit64 syscall. Signed-off-by: Peter Maydell --- linux-user/syscall.c | 43 +++ linux-user/syscall_defs.h |5 + 2 files changed, 48 insertions(+), 0 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c inde

Re: [Qemu-devel] [PATCH] vnc: Fix compilation with --enable-vnc-png

2011-06-27 Thread Anthony Liguori
On 06/27/2011 12:44 AM, Stefan Weil wrote: Am 27.06.2011 07:29, schrieb Stefan Weil: Commit f26e428da505709ec03b2ed2c9eb3db82b30bd7b fixed compilation with --enable-vnc-png, but broke it with --enable-vnc-png. should be with --enable-vnc-jpeg, but broke it with --enable-vnc-png. Please fix t

[Qemu-devel] [Bug 799036] Re: NIC assignment order in command line make some NIC can't work

2011-06-27 Thread Yongjie Ren
dmesg and lspci logs are attached as a tar package. There are many logs in it, please read README.txt first, which will tell you which log is in which case. ** Attachment added: "vtd-NIC-assignment-order-issue.tar" https://bugs.launchpad.net/qemu/+bug/799036/+attachment/2182799/+files/vtd-NIC

Re: [Qemu-devel] [RFC v2 00/20] Memory API

2011-06-27 Thread Avi Kivity
On 06/27/2011 06:59 PM, Michael S. Tsirkin wrote: > > >- bridges might also enable subtractive decoding > >(required for isa behind the bridge) > > What does that mean? subtractive decoding is a method of address decoding in which a device accepts all accesses not positively decoded by an

Re: [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform

2011-06-27 Thread Kevin Wolf
Am 27.06.2011 17:34, schrieb Stefano Stabellini: > On Mon, 27 Jun 2011, Kevin Wolf wrote: >> hw/ide/pci.h is just as internal as internal.h is. And even if you >> managed to access the same things without any IDE header file, I still >> think it's not the right level of abstraction because it relie

[Qemu-devel] [PATCH] e1000: Handle IO Port.

2011-06-27 Thread Anthony PERARD
This patch introduces the two IOPorts on e1000, IOADDR and IODATA. The IOADDR is used to specify which register we want to access when we read or write on IODATA. This patch fixes some weird behavior that I see when I use e1000 with QEMU/Xen, the guest memory can be corrupted by this NIC because i

Re: [Qemu-devel] [RFC v2 00/20] Memory API

2011-06-27 Thread Anthony Liguori
On 06/27/2011 08:21 AM, Avi Kivity wrote: As expected, this is taking longer than expected, so I'm releasing something less complete than I'd have liked. Not even all of the PC machine is converted, but the difficult parts are (cirrus). It appears to work well. The major change compared to v1

Re: [Qemu-devel] [PATCH] Add e500 instructions dcblc, dcbtls and dcbtstl as no-op

2011-06-27 Thread Scott Wood
On Mon, 27 Jun 2011 15:15:55 +0200 Fabien Chouteau wrote: > +/* dcbtls */ > +static void gen_dcbtls(DisasContext *ctx) > +{ > +/* interpreted as no-op */ > +} > + > +/* dcbtstls */ > +static void gen_dcbtstls(DisasContext *ctx) > +{ > +/* interpreted as no-op */ > +} Set L1CSR0[CUL] (una

[Qemu-devel] [Bug 802588] [NEW] Latest GIT version fails to compile on Linux - setjmp.h problem

2011-06-27 Thread Nigel Horne
Public bug reported: Git version: f26e428da505709ec03b2ed2c9eb3db82b30bd7b Gcc: 4.6.1 Host: Debinan/x86_64 Fails to compile at In file included from /usr/include/png.h:518:0, from ui/vnc-enc-tight.c:37: /usr/include/pngconf.h: At top level: /usr/include/pngconf.h:371:21: error:

Re: [Qemu-devel] IO errors in guest caused by LTP dio test

2011-06-27 Thread Andi Kleen
On Mon, Jun 27, 2011 at 05:59:41PM +0200, Kevin Wolf wrote: > Am 23.06.2011 01:36, schrieb Andi Kleen: > > > > Running LTP testcases/kernel/io/direct_io/test_dma_thread_diotest7 > > causes IO errors in the guest. There are no IO errors on the host. > > > > Kernel Linux 3.0.0-rc* > > Using a stan

Re: [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimum

2011-06-27 Thread Fabien Chouteau
On 27/06/2011 17:39, Stefan Hajnoczi wrote: > On Mon, Jun 27, 2011 at 3:23 PM, Fabien Chouteau wrote: >> On 27/06/2011 15:50, Stefan Hajnoczi wrote: >>> On Mon, Jun 27, 2011 at 1:41 PM, Fabien Chouteau >>> wrote: Signed-off-by: Fabien Chouteau --- slirp/slirp.c |4 ++--

Re: [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform

2011-06-27 Thread Stefano Stabellini
On Mon, 27 Jun 2011, Kevin Wolf wrote: > hw/ide/pci.h is just as internal as internal.h is. And even if you > managed to access the same things without any IDE header file, I still > think it's not the right level of abstraction because it relies on the > implementation details of IDE. > > Just th

Re: [Qemu-devel] [RFC v2 00/20] Memory API

2011-06-27 Thread Avi Kivity
On 06/27/2011 06:52 PM, Michael S. Tsirkin wrote: On Mon, Jun 27, 2011 at 06:13:03PM +0300, Avi Kivity wrote: > On 06/27/2011 04:21 PM, Avi Kivity wrote: > >As expected, this is taking longer than expected, so I'm releasing something > >less complete than I'd have liked. Not even all of the P

[Qemu-devel] [PATCHv2 3/4] libcacard: introduce NEXT_TOKEN macro

2011-06-27 Thread Christophe Fergeau
vcard_emul_options now has repetitive code to read the current token and advance to the next. After the previous changes, this repetitive code can be moved in a NEXT_TOKEN macro to avoid having this code duplicated. Signed-off-by: Christophe Fergeau --- libcacard/vcard_emul_nss.c | 71

Re: [Qemu-devel] [RFC v2 00/20] Memory API

2011-06-27 Thread Michael S. Tsirkin
On Mon, Jun 27, 2011 at 06:54:05PM +0300, Avi Kivity wrote: > On 06/27/2011 06:52 PM, Michael S. Tsirkin wrote: > >On Mon, Jun 27, 2011 at 06:13:03PM +0300, Avi Kivity wrote: > >> On 06/27/2011 04:21 PM, Avi Kivity wrote: > >> >As expected, this is taking longer than expected, so I'm releasing >

[Qemu-devel] [PATCHv2 1/4] libcacard: s/strip(args++)/strip(args+1)

2011-06-27 Thread Christophe Fergeau
vcard_emul_options used args = strip(args++) a few times, which was not returning the expected result since the rest of the code expected args to be increased by at least 1, which is not the case if *args is not a blank space when this function is called. Replace these calls by "strip(args+1)" whic

Re: [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimum

2011-06-27 Thread Stefan Hajnoczi
On Mon, Jun 27, 2011 at 3:23 PM, Fabien Chouteau wrote: > On 27/06/2011 15:50, Stefan Hajnoczi wrote: >> On Mon, Jun 27, 2011 at 1:41 PM, Fabien Chouteau >> wrote: >>> >>> Signed-off-by: Fabien Chouteau >>> --- >>>  slirp/slirp.c |    4 ++-- >>>  1 files changed, 2 insertions(+), 2 deletions(-)

Re: [Qemu-devel] IO errors in guest caused by LTP dio test

2011-06-27 Thread Kevin Wolf
Am 23.06.2011 01:36, schrieb Andi Kleen: > > Running LTP testcases/kernel/io/direct_io/test_dma_thread_diotest7 > causes IO errors in the guest. There are no IO errors on the host. > > Kernel Linux 3.0.0-rc* > Using a standard emulated IDE -hda image. Couldn't reproduce this in a quick test wit

[Qemu-devel] [PATCHv2 0/4] libcacard fixes

2011-06-27 Thread Christophe Fergeau
Hey, Alon asked me to split the parsing patches to make the review easier, to here they are. Changes since v1: - split first patch into 3 patches, v1 2/2 is unchanged Christophe Fergeau (4): libcacard: s/strip(args++)/strip(args+1) libcacard: fix soft=... parsing in vcard_emul_options libc

[Qemu-devel] [PATCHv2 4/4] libcacard: replace copy_string with strndup

2011-06-27 Thread Christophe Fergeau
copy_string reimplements strndup, this commit removes it and replaces all copy_string uses with strndup. Signed-off-by: Christophe Fergeau --- libcacard/vcard_emul_nss.c | 23 ++- 1 files changed, 6 insertions(+), 17 deletions(-) diff --git a/libcacard/vcard_emul_nss.c b/l

Re: [Qemu-devel] [RFC v2 00/20] Memory API

2011-06-27 Thread Michael S. Tsirkin
On Mon, Jun 27, 2011 at 06:13:03PM +0300, Avi Kivity wrote: > On 06/27/2011 04:21 PM, Avi Kivity wrote: > >As expected, this is taking longer than expected, so I'm releasing something > >less complete than I'd have liked. Not even all of the PC machine is > >converted, but the difficult parts are

[Qemu-devel] [PATCHv2 2/4] libcacard: fix soft=... parsing in vcard_emul_options

2011-06-27 Thread Christophe Fergeau
The previous parser had copy and paste errors when computing vname_length and type_params_length, "name" was used instead of respectively vname and type_params. This led to length that could be bigger than the input string, and to access out of the array bounds when trying to copy these strings. va

Re: [Qemu-devel] [RFC v2 00/20] Memory API

2011-06-27 Thread Avi Kivity
On 06/27/2011 06:37 PM, Anthony Liguori wrote: On 06/27/2011 08:21 AM, Avi Kivity wrote: As expected, this is taking longer than expected, so I'm releasing something less complete than I'd have liked. Not even all of the PC machine is converted, but the difficult parts are (cirrus). It appear

Re: [Qemu-devel] [RFC v2 00/20] Memory API

2011-06-27 Thread Avi Kivity
On 06/27/2011 04:21 PM, Avi Kivity wrote: As expected, this is taking longer than expected, so I'm releasing something less complete than I'd have liked. Not even all of the PC machine is converted, but the difficult parts are (cirrus). It appears to work well. The major change compared to v1

[Qemu-devel] [PATCH v3] xen_disk: cope with missing xenstore "params" node

2011-06-27 Thread stefano.stabellini
From: Stefano Stabellini When disk is a cdrom and the drive is empty the "params" node in xenstore might be missing completely: cope with it instead of segfaulting. Updated in v2: - actually removed the strchr(blkdev->params, ':') that caused the segfault; - free all the allocated strings fro

[Qemu-devel] [RFC PATCH v2] Specification for qcow2 version 3

2011-06-27 Thread Kevin Wolf
This is the second draft for what I think could be added when we increase qcow2's version number to 3. This includes points that have been made by several people over the past few months. We're probably not going to implement this next week, but I think it's important to get discussions started ea

Re: [Qemu-devel] [PATCH 08/10] cocoa: Revert dependency on VNC

2011-06-27 Thread Jes Sorensen
On 06/14/11 03:22, Andreas Färber wrote: > In 821601ea5b02a68ada479731a4d3d07a9876632a (Make VNC support optional) > cocoa.o was moved from ui-obj-$(CONFIG_COCOA) to vnc-obj-$(CONFIG_COCOA), > adding a dependency on $(CONFIG_VNC). That must've been unintentional. > > Cc: Jes Sorensen > Cc: Anthon

[Qemu-devel] KVM call agenda for June 28

2011-06-27 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Later, Juan.

Re: [Qemu-devel] [PATCH 0/2] iothread improvements for Mac OS X

2011-06-27 Thread Paolo Bonzini
On 06/09/2011 01:10 PM, Paolo Bonzini wrote: These are two old patches that I never submitted because I didn't really think they were useful except as cleanups. Recently, however, Alex Graf mentioned some problems that Mac OS X has with iothread, and they sounded to me like they were related to

Re: [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimum

2011-06-27 Thread Fabien Chouteau
On 27/06/2011 15:50, Stefan Hajnoczi wrote: > On Mon, Jun 27, 2011 at 1:41 PM, Fabien Chouteau wrote: >> >> Signed-off-by: Fabien Chouteau >> --- >> slirp/slirp.c |4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) > > Any particular bug that this fixes? > > There have been 64 byt

Re: [Qemu-devel] [RFC v2 03/20] memory: merge adjacent segments of a single memory region

2011-06-27 Thread Avi Kivity
On 06/27/2011 04:56 PM, Jan Kiszka wrote: On 2011-06-27 15:21, Avi Kivity wrote: > Simple implementations of memory routers, for example the Cirrus VGA memory banks > or the 440FX PAM registers can generate adjacent memory regions which are contiguous. > Detect these and merge them; this sav

Re: [Qemu-devel] [PATCH v2] xen_disk: cope with missing xenstore "params" node

2011-06-27 Thread Stefano Stabellini
On Sat, 25 Jun 2011, Peter Maydell wrote: > On 24 June 2011 17:35, wrote: > > +out_error: > > +    qemu_free(blkdev->params); > > +    qemu_free(blkdev->mode); > > +    qemu_free(blkdev->type); > > +    qemu_free(blkdev->dev); > > +    qemu_free(blkdev->devtype); > > +    return -1; > > It occur

Re: [Qemu-devel] Build break in current -git.

2011-06-27 Thread Stefan Hajnoczi
On Mon, Jun 27, 2011 at 1:31 PM, Rob Landley wrote: > In file included from /usr/include/png.h:510, >                 from ui/vnc-enc-tight.c:37: > /usr/include/pngconf.h:371: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or > ‘__attribute__’ before ‘.’ token > /usr/include/pngconf.h:372: error: expected ‘

Re: [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimum

2011-06-27 Thread Stefan Hajnoczi
On Mon, Jun 27, 2011 at 1:41 PM, Fabien Chouteau wrote: > > Signed-off-by: Fabien Chouteau > --- >  slirp/slirp.c |    4 ++-- >  1 files changed, 2 insertions(+), 2 deletions(-) Any particular bug that this fixes? There have been 64 byte minimum padding patches to several emulated NICs. There

Re: [Qemu-devel] [RFC v2 03/20] memory: merge adjacent segments of a single memory region

2011-06-27 Thread Jan Kiszka
On 2011-06-27 15:21, Avi Kivity wrote: > Simple implementations of memory routers, for example the Cirrus VGA memory > banks > or the 440FX PAM registers can generate adjacent memory regions which are > contiguous. > Detect these and merge them; this saves kvm memory slots and shortens lookup >

[Qemu-devel] [RFC v2 00/20] Memory API

2011-06-27 Thread Avi Kivity
As expected, this is taking longer than expected, so I'm releasing something less complete than I'd have liked. Not even all of the PC machine is converted, but the difficult parts are (cirrus). It appears to work well. The major change compared to v1 is the introduction of memory_region_init_al

Re: [Qemu-devel] [PATCH] qemu_ram_ptr_length: take ram_addr_t as arguments

2011-06-27 Thread Stefano Stabellini
On Fri, 24 Jun 2011, Peter Maydell wrote: > On 24 June 2011 12:08, wrote: > > From: Stefano Stabellini > > > > qemu_ram_ptr_length should take ram_addr_t as argument rather than > > target_phys_addr_t because is doing comparisons with RAMBlock addresses. > > > > cpu_physical_memory_map should cr

[Qemu-devel] [RFC v2 10/20] pci: add MemoryRegion based BAR management API

2011-06-27 Thread Avi Kivity
Allow registering a BAR using a MemoryRegion. Once all users are converted, pci_register_bar() and pci_register_bar_simple() will be removed. Signed-off-by: Avi Kivity --- hw/pci.c | 47 +++ hw/pci.h |3 +++ 2 files changed, 42 insertions(+), 8

[Qemu-devel] [RFC v2 01/20] Hierarchical memory region API

2011-06-27 Thread Avi Kivity
The memory API separates the attributes of a memory region (its size, how reads or writes are handled, dirty logging, and coalescing) from where it is mapped and whether it is enabled. This allows a device to configure a memory region once, then hand it off to its parent bus to map it according to

[Qemu-devel] [RFC v2 13/20] pci: add API to get a BAR's mapped address

2011-06-27 Thread Avi Kivity
This is a hack, for devices that have a back-channel to read this address back outside the normal configuration mechanisms, such as VMware svga. Signed-off-by: Avi Kivity --- hw/pci.c |5 + hw/pci.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pc

[Qemu-devel] [RFC v2 11/20] sysbus: add MemoryRegion based memory management API

2011-06-27 Thread Avi Kivity
Allow registering sysbus device memory using a MemoryRegion. Once all users are converted, sysbus_init_mmio() and sysbus_init_mmio_cb() will be removed. Signed-off-by: Avi Kivity --- hw/sysbus.c | 27 --- hw/sysbus.h |3 +++ 2 files changed, 27 insertions(+), 3 del

[Qemu-devel] [RFC v2 04/20] Internal interfaces for memory API

2011-06-27 Thread Avi Kivity
get_system_memory() provides the root of the memory hierarchy. This interface is intended to be private between memory.c and exec.c. If this file is included elsewhere, it should be regarded as a bug (or TODO item). However, it will be temporarily needed for the conversion to hierarchical memory

[Qemu-devel] [RFC v2 15/20] vga: convert vga and its derivatives to the memory API

2011-06-27 Thread Avi Kivity
Convert all vga memory to the memory API. Note we need to fall back to get_system_memory(), since the various buses don't pass the vga window as a memory region. Signed-off-by: Avi Kivity --- hw/cirrus_vga.c | 346 +-- hw/vga-isa-mm.c | 66

[Qemu-devel] [RFC v2 03/20] memory: merge adjacent segments of a single memory region

2011-06-27 Thread Avi Kivity
Simple implementations of memory routers, for example the Cirrus VGA memory banks or the 440FX PAM registers can generate adjacent memory regions which are contiguous. Detect these and merge them; this saves kvm memory slots and shortens lookup times. Signed-off-by: Avi Kivity --- memory.c |

[Qemu-devel] [RFC v2 09/20] pci: pass address space to pci bus when created

2011-06-27 Thread Avi Kivity
This is now done sloppily, via get_system_memory(). Eventually callers will be converted to stop using that. Signed-off-by: Avi Kivity --- hw/apb_pci.c |2 ++ hw/bonito.c|4 +++- hw/grackle_pci.c |5 +++-- hw/gt64xxx.c |4 +++- hw/pc.h|4 +++

[Qemu-devel] [RFC v2 19/20] vga: simplify vga window mmio access functions

2011-06-27 Thread Avi Kivity
Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. We have to keep vga_mem_{read,write}b() since they're used by cirrus. Signed-off-by: Avi Kivity --- hw/cirrus_vga.c |4 +- hw/vga.c| 56 +++---

[Qemu-devel] [RFC v2 20/20] cirrus: simplify linear framebuffer access functions

2011-06-27 Thread Avi Kivity
Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Signed-off-by: Avi Kivity --- hw/cirrus_vga.c | 78 +++--- 1 files changed, 10 insertions(+), 68 deletions(-) diff --git a/hw/cirrus_vga.c b/h

[Qemu-devel] [RFC v2 12/20] usb-ohci: convert to MemoryRegion

2011-06-27 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/usb-ohci.c | 42 +- 1 files changed, 17 insertions(+), 25 deletions(-) diff --git a/hw/usb-ohci.c b/hw/usb-ohci.c index 5d2ae01..e6a901f 100644 --- a/hw/usb-ohci.c +++ b/hw/usb-ohci.c @@ -62,7 +62,7 @@ typedef struct OHCI

[Qemu-devel] [RFC v2 16/20] cirrus: simplify mmio BAR access functions

2011-06-27 Thread Avi Kivity
Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Signed-off-by: Avi Kivity --- hw/cirrus_vga.c | 82 +++ 1 files changed, 10 insertions(+), 72 deletions(-) diff --git a/hw/cirrus_vga.c b/

[Qemu-devel] [RFC v2 05/20] exec.c: initialize memory map

2011-06-27 Thread Avi Kivity
Allocate the root memory region and initialize it. Signed-off-by: Avi Kivity --- exec.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index b03b5be..9b894b9 100644 --- a/exec.c +++ b/exec.c @@ -34,6 +34,8 @@ #include "kvm.h" #includ

[Qemu-devel] [RFC v2 14/20] vmsvga: don't remember pci BAR address in callback any more

2011-06-27 Thread Avi Kivity
We're going to remove the callback, so we can't use it to save the address. Use the pci API instead. Signed-off-by: Avi Kivity --- hw/vmware_vga.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index 354c221..190b005 100644

[Qemu-devel] [RFC v2 17/20] cirrus: simplify bitblt BAR access functions

2011-06-27 Thread Avi Kivity
Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Signed-off-by: Avi Kivity --- hw/cirrus_vga.c | 87 ++ 1 files changed, 16 insertions(+), 71 deletions(-) diff --git a/hw/cirrus_vga.c b/h

[Qemu-devel] [RFC v2 07/20] pc: convert pc_memory_init() to memory API

2011-06-27 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/pc.c | 59 --- hw/pc.h |1 + 2 files changed, 41 insertions(+), 19 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 369566a..1c9d89a 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -41,6 +41,7 @@ #include "sys

[Qemu-devel] [RFC v2 18/20] cirrus: simplify vga window mmio access functions

2011-06-27 Thread Avi Kivity
Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Signed-off-by: Avi Kivity --- hw/cirrus_vga.c | 83 -- 1 files changed, 13 insertions(+), 70 deletions(-) diff --git a/hw/cirrus_vga.c b/h

[Qemu-devel] [RFC v2 08/20] pc: move global memory map out of pc_init1() and into its callers

2011-06-27 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/pc_piix.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index d83854c..f2d0476 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -68,7 +68,8 @@ static void ioapic_init(IsaIrqState *isa_irq_state)

[Qemu-devel] [RFC v2 02/20] memory: implement dirty tracking

2011-06-27 Thread Avi Kivity
Currently dirty tracking is implemented by passing through all calls to the underlying cpu_physical_memory_*() calls. Signed-off-by: Avi Kivity --- memory.c | 39 +++ memory.h |1 + 2 files changed, 32 insertions(+), 8 deletions(-) diff --git a/memory.c

[Qemu-devel] [RFC v2 06/20] pc: grab system_memory

2011-06-27 Thread Avi Kivity
While eventually this should come from the machine initialization function, take a short cut to avoid converting all machines now. Signed-off-by: Avi Kivity --- hw/pc.c |3 ++- hw/pc.h |4 +++- hw/pc_piix.c |8 +++- 3 files changed, 12 insertions(+), 3 deletions(-) dif

[Qemu-devel] [PATCH] Add e500 instructions dcblc, dcbtls and dcbtstl as no-op

2011-06-27 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- target-ppc/translate.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 0a03b44..d0ca821 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -3995

Re: [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users

2011-06-27 Thread Markus Armbruster
Amit Shah writes: > On (Fri) 24 Jun 2011 [13:57:28], Markus Armbruster wrote: >> Ping? > > There were a couple of things: > >> port 0, guest on, host off, throttle off > > guest on/off, host on/off doesn't convey much -- what's on/off? > > Also, 'throttle' could be 'thottled'? Discus

[Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimum

2011-06-27 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- slirp/slirp.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index 1593be1..be30501 100644 --- a/slirp/slirp.c +++ b/slirp/slirp.c @@ -697,7 +697,7 @@ void if_encap(Slirp *slirp, const uint8_t *ip_data,

[Qemu-devel] Build break in current -git.

2011-06-27 Thread Rob Landley
In file included from /usr/include/png.h:510, from ui/vnc-enc-tight.c:37: /usr/include/pngconf.h:371: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘.’ token /usr/include/pngconf.h:372: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘include’ make:

  1   2   >