Re: [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup

2011-05-24 Thread Michael S. Tsirkin
On Tue, May 24, 2011 at 09:47:57PM -0600, Alex Williamson wrote: > On Thu, 2011-05-05 at 18:21 +0300, Michael S. Tsirkin wrote: > > On Thu, May 05, 2011 at 08:21:06AM -0600, Alex Williamson wrote: > > > On Thu, 2011-05-05 at 16:21 +0300, Michael S. Tsirkin wrote: > > > > On Tue, May 03, 2011 at 12:

Re: [Qemu-devel] [PATCH] vfio: Allow sub-ranges to be unmapped

2011-05-24 Thread Alex Williamson
On Tue, 2011-05-10 at 12:06 -0600, Alex Williamson wrote: > We're currently very strict in requiring that DMA unmaps are done > using the exact same regions as used for the original mapping. > In a VM environment, we may want to change sub-areas of a previous > mapping without tearing down the enti

Re: [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup

2011-05-24 Thread Alex Williamson
On Thu, 2011-05-05 at 18:21 +0300, Michael S. Tsirkin wrote: > On Thu, May 05, 2011 at 08:21:06AM -0600, Alex Williamson wrote: > > On Thu, 2011-05-05 at 16:21 +0300, Michael S. Tsirkin wrote: > > > On Tue, May 03, 2011 at 12:36:58PM -0600, Alex Williamson wrote: > > > > When a phys memory client r

[Qemu-devel] [PATCH v3 11/39] hw/cirrus_vga.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/cirrus_vga.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index 722cac7..79874b1 100644 --- a/hw/cirrus_vga.c +++ b/hw/cirrus_vga.c @@ -3097,8 +3097,8

[Qemu-devel] [PATCH v3 17/39] hw/ide/ich.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/ide/ich.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/ide/ich.c b/hw/ide/ich.c index e44339b..cb1c405 100644 --- a/hw/ide/ich.c +++ b/hw/ide/ich.c @@ -77,11 +77,6 @@ static int pci_i

[Qemu-devel] [PATCH v3 37/39] hw/xio3130_downstream.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/xio3130_downstream.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/xio3130_downstream.c b/hw/xio3130_downstream.c index 5aa6a6b..d3c387d 100644 --- a/hw/xio3130_downstream.c +++ b/hw/xio3

[Qemu-devel] [PATCH v3 34/39] hw/vga-pci.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/vga-pci.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/vga-pci.c b/hw/vga-pci.c index ce9ec45..481f448 100644 --- a/hw/vga-pci.c +++ b/hw/vga-pci.c @@ -74,7 +74,6 @@ static int pci_

[Qemu-devel] [PATCH v3 39/39] virtio-pci.c: convert to PCIDEviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/virtio-pci.c | 69 -- 1 files changed, 31 insertions(+), 38 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index c19629d..270e2c7 100644 --- a/hw/virtio-p

[Qemu-devel] [PATCH v3 02/39] usb-uhci: convert to PCIDEviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/usb-uhci.c | 46 +- 1 files changed, 17 insertions(+), 29 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index 346db3e..536c24c 100644 --- a/hw/usb-uhci.c +++ b/hw/us

[Qemu-devel] [PATCH v3 09/39] hw/acpi_piix4.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/acpi_piix4.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 96f5222..232008d 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@ -317,13 +317,9 @@

[Qemu-devel] [PATCH v3 38/39] hw/xio3130_upstream.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/xio3130_upstream.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/xio3130_upstream.c b/hw/xio3130_upstream.c index a7640f5..8283695 100644 --- a/hw/xio3130_upstream.c +++ b/hw/xio3130_upst

[Qemu-devel] [PATCH v3 32/39] hw/usb-ohci.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/usb-ohci.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/usb-ohci.c b/hw/usb-ohci.c index d21c820..7ff2322 100644 --- a/hw/usb-ohci.c +++ b/hw/usb-ohci.c @@ -1716,11 +1716,7 @@ static in

[Qemu-devel] [PATCH v3 35/39] hw/vt82c686.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/vt82c686.c | 35 --- 1 files changed, 16 insertions(+), 19 deletions(-) diff --git a/hw/vt82c686.c b/hw/vt82c686.c index ca8f826..5c973ed 100644 --- a/hw/vt82c686.c +++ b/hw/vt82c686.c @@

[Qemu-devel] [PATCH v3 36/39] hw/wdt_i6300esb.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/wdt_i6300esb.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/wdt_i6300esb.c b/hw/wdt_i6300esb.c index 0791721..bd57fd3 100644 --- a/hw/wdt_i6300esb.c +++ b/hw/wdt_i6300esb.c @@ -400,9 +40

[Qemu-devel] [PATCH v3 10/39] hw/bonito.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/bonito.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/bonito.c b/hw/bonito.c index 65a4a63..e8c57a3 100644 --- a/hw/bonito.c +++ b/hw/bonito.c @@ -691,11 +691,7 @@ static int bonito_i

[Qemu-devel] [PATCH v3 21/39] hw/ivshmem.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/ivshmem.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/ivshmem.c b/hw/ivshmem.c index 7b19a81..3055dd2 100644 --- a/hw/ivshmem.c +++ b/hw/ivshmem.c @@ -706,12 +706,7 @@ static int pci_

[Qemu-devel] [PATCH v3 15/39] hw/gt64xxx.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/gt64xxx.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/gt64xxx.c b/hw/gt64xxx.c index c66188f..8e1f6a0 100644 --- a/hw/gt64xxx.c +++ b/hw/gt64xxx.c @@ -1118,14 +1118,10 @@ static int g

[Qemu-devel] [PATCH v3 08/39] hw/ac97.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/ac97.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/ac97.c b/hw/ac97.c index d71072d..c26a86d 100644 --- a/hw/ac97.c +++ b/hw/ac97.c @@ -1281,9 +1281,6 @@ static int ac97_initfn (PCID

[Qemu-devel] [PATCH v3 26/39] hw/piix_pci.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/piix_pci.c | 19 +++ 1 files changed, 7 insertions(+), 12 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 5f0d92f..b927f01 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -228,11 +228,6 @

[Qemu-devel] [PATCH v3 23/39] hw/ne2000.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/ne2000.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ne2000.c b/hw/ne2000.c index b668ad1..f8acaae 100644 --- a/hw/ne2000.c +++ b/hw/ne2000.c @@ -721,9 +721,6 @@ static int pci_ne2000_i

[Qemu-devel] [PATCH v3 00/39] pci: initialize ids in pci common code

2011-05-24 Thread Isaku Yamahata
Okay, here is the v3 as there seems no more comments on the series. patch descriptions: vender id/device id... in pci configuration space are read-only registers which are commonly defined for all pci devices. So initialize them in common code and it simplifies the initialization a bit. Potentiall

[Qemu-devel] [PATCH v3 05/39] apb_pci: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
Use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/apb_pci.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/apb_pci.c b/hw/apb_pci.c index 84e9af7..974c87a 100644 --- a/hw/apb_pci.c +++ b/hw/apb_pci.c @@ -304,9 +304,6 @@ static int

[Qemu-devel] [PATCH v3 31/39] hw/unin_pci.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/unin_pci.c | 33 - 1 files changed, 16 insertions(+), 17 deletions(-) diff --git a/hw/unin_pci.c b/hw/unin_pci.c index c57c0a1..d364daa 100644 --- a/hw/unin_pci.c +++ b/hw/unin_pci.c @@ -

[Qemu-devel] [PATCH v3 27/39] hw/qxl.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/qxl.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index fe4212b..63cffc3 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1233,7 +1233,6 @@ static int qxl_init_common(PCIQXLDe

[Qemu-devel] [PATCH v3 33/39] hw/versatile_pci.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/versatile_pci.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/versatile_pci.c b/hw/versatile_pci.c index 2fed8a0..8e75ffc 100644 --- a/hw/versatile_pci.c +++ b/hw/versatile_pci.c @@ -13

[Qemu-devel] [PATCH v3 28/39] hw/rtl8139.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/rtl8139.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/rtl8139.c b/hw/rtl8139.c index c7c7a3c..34e3a9e 100644 --- a/hw/rtl8139.c +++ b/hw/rtl8139.c @@ -3453,10 +3453,6 @@ static int pc

[Qemu-devel] [PATCH v3 29/39] hw/sh_pci.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/sh_pci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sh_pci.c b/hw/sh_pci.c index e99d8db..a076cf2 100644 --- a/hw/sh_pci.c +++ b/hw/sh_pci.c @@ -137,8 +137,6 @@ static int sh_pci_init_de

[Qemu-devel] [PATCH v3 03/39] eepro100: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/eepro100.c | 74 +--- 1 files changed, 33 insertions(+), 41 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index 05450e8..84b98c0 100644 --- a/hw/eepro100.c +

[Qemu-devel] [PATCH v3 14/39] hw/grackle_pci.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/grackle_pci.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/grackle_pci.c b/hw/grackle_pci.c index d35701f..cee07e0 100644 --- a/hw/grackle_pci.c +++ b/hw/grackle_pci.c @@ -104,11 +104,

[Qemu-devel] [PATCH v3 06/39] ide/piix: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/ide/piix.c | 32 ++-- 1 files changed, 10 insertions(+), 22 deletions(-) diff --git a/hw/ide/piix.c b/hw/ide/piix.c index c349644..84f72b0 100644 --- a/hw/ide/piix.c +++ b/hw/ide/piix.c @@ -1

[Qemu-devel] [PATCH v3 24/39] hw/pcnet-pci.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/pcnet-pci.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/pcnet-pci.c b/hw/pcnet-pci.c index 9415a1e..216cf81 100644 --- a/hw/pcnet-pci.c +++ b/hw/pcnet-pci.c @@ -265,12 +265,8 @@ stati

[Qemu-devel] [PATCH v3 25/39] hw/piix4.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/piix4.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/hw/piix4.c b/hw/piix4.c index 71f1f84..9590e7b 100644 --- a/hw/piix4.c +++ b/hw/piix4.c @@ -86,15 +86,8 @@ static const VMStateDescr

[Qemu-devel] [PATCH v3 30/39] hw/sun4u.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/sun4u.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/sun4u.c b/hw/sun4u.c index 5eb38cf..d7dcaf0 100644 --- a/hw/sun4u.c +++ b/hw/sun4u.c @@ -553,15 +553,11 @@ pci_ebus_init1(PCIDevice

[Qemu-devel] [PATCH v3 16/39] hw/ide/cmd646.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/ide/cmd646.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index 5d5464a..56302b5 100644 --- a/hw/ide/cmd646.c +++ b/hw/ide/cmd646.c @@ -226,14 +226,8 @

[Qemu-devel] [PATCH v3 19/39] hw/intel-hda.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/intel-hda.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/intel-hda.c b/hw/intel-hda.c index 5485745..0ce 100644 --- a/hw/intel-hda.c +++ b/hw/intel-hda.c @@ -1138,10 +1138,6 @@ sta

[Qemu-devel] [PATCH v3 04/39] dec_pci: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/dec_pci.c | 26 +++--- 1 files changed, 7 insertions(+), 19 deletions(-) diff --git a/hw/dec_pci.c b/hw/dec_pci.c index bf88f2a..a35f382 100644 --- a/hw/dec_pci.c +++ b/hw/dec_pci.c @@ -50,28 +50,16

[Qemu-devel] [PATCH v3 22/39] hw/lsi53c895a.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/lsi53c895a.c | 13 - 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c index be4df58..6b9c904 100644 --- a/hw/lsi53c895a.c +++ b/hw/lsi53c895a.c @@ -2212,15 +221

[Qemu-devel] [PATCH v3 18/39] hw/ide/via.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/ide/via.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/ide/via.c b/hw/ide/via.c index 04f3290..3474c37 100644 --- a/hw/ide/via.c +++ b/hw/ide/via.c @@ -160,11 +160,7 @@ static int vt82

[Qemu-devel] [PATCH v3 07/39] vmware_vga.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/vmware_vga.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index 4656767..354c221 100644 --- a/hw/vmware_vga.c +++ b/hw/vmware_vga.c @@ -1280,15 +128

[Qemu-devel] [PATCH v3 12/39] hw/e1000.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/e1000.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index f160bfc..96d84f9 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -1164,12 +1164,8 @@ static int pci_e1000_in

[Qemu-devel] [PATCH v3 01/39] pci: move ids of config space into PCIDeviceInfo

2011-05-24 Thread Isaku Yamahata
vender id/device id... in configuration space are read-only registers which are commonly defined for all pci devices. So move those initialization into common place. Signed-off-by: Isaku Yamahata --- changes v1 -> v2: - dropped prog_interface, header_type - added assert() for header type = 1 ---

[Qemu-devel] [PATCH v3 20/39] hw/ioh3420.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/ioh3420.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/ioh3420.c b/hw/ioh3420.c index 95adf09..a6bfbb9 100644 --- a/hw/ioh3420.c +++ b/hw/ioh3420.c @@ -104,12 +104,8 @@ static int ioh34

[Qemu-devel] [PATCH v3 13/39] hw/es1370.c: convert to PCIDeviceInfo to initialize ids

2011-05-24 Thread Isaku Yamahata
use PCIDeviceInfo to initialize ids. Signed-off-by: Isaku Yamahata --- hw/es1370.c | 24 +++- 1 files changed, 11 insertions(+), 13 deletions(-) diff --git a/hw/es1370.c b/hw/es1370.c index 40cb48c..1ed62b7 100644 --- a/hw/es1370.c +++ b/hw/es1370.c @@ -998,21 +998,9 @@ st

Re: [Qemu-devel] [PATCH] ahci: Fix non-NCQ accesses for LBA > 16bits

2011-05-24 Thread Alexander Graf
On 25.05.2011, at 00:46, Alexander Graf wrote: > AHCI provides two ways of reading/writing data: > > 1) NCQ > 2) ATA commands with the LBA in the command FIS > > In the second code path, we didn't handle any LBAs that were bigger than > 16 bits, so whenever a guest that used high LBA numbers wa

Re: [Qemu-devel] [PATCH 1/3] spapr: allow creating devices with -device

2011-05-24 Thread David Gibson
On Tue, May 24, 2011 at 01:45:05PM +0200, Paolo Bonzini wrote: > Right now the spapr devices cannot be instantiated with -device, > because the IRQs need to be passed to the spapr_*_create functions. > Do this instead in the bus's init wrapper. > > This is particularly important with the conversio

Re: [Qemu-devel] [PATCH 3/3] spapr: make irq customizable via qdev

2011-05-24 Thread David Gibson
On Tue, May 24, 2011 at 01:45:07PM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > Cc: Alexander Graf > Cc: David Gibson > --- > hw/spapr_vio.c |8 +++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/hw/spapr_vio.c b/hw/spapr_vio.c > index be535d6..fee

[Qemu-devel] [PATCH] ahci: Fix non-NCQ accesses for LBA > 16bits

2011-05-24 Thread Alexander Graf
AHCI provides two ways of reading/writing data: 1) NCQ 2) ATA commands with the LBA in the command FIS In the second code path, we didn't handle any LBAs that were bigger than 16 bits, so whenever a guest that used high LBA numbers wanted to access data, the LBA got truncated down to 16 bits, g

[Qemu-devel] [PATCH] vmdk: fix endianness bugs

2011-05-24 Thread Alexander Graf
The vmdk code is sloppy when handling the header descriptor during creation of an image. Fix all header accesses in the create path to either store native endianness or convert it when appropriate. Reported-by: Yury Tsarev Signed-off-by: Alexander Graf --- block/vmdk.c | 22 ++

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-24 Thread Anthony Liguori
On 05/24/2011 02:58 PM, Stefan Hajnoczi wrote: On Tue, May 24, 2011 at 08:37:50PM +0100, Jamie Lokier wrote: Daniel P. Berrange wrote: On Wed, May 11, 2011 at 03:45:39PM +0200, Paolo Bonzini wrote: On 05/11/2011 03:05 PM, Anthony Liguori wrote: A very slow way, too (on Windows at least if yo

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-24 Thread Anthony Liguori
On 05/24/2011 02:58 PM, Stefan Hajnoczi wrote: On Tue, May 24, 2011 at 08:37:50PM +0100, Jamie Lokier wrote: Thanks, I read about that but didn't try to implement special cases because I don't have relevant OSes here to test against. My current plan is to try using sigaltstack(2) instead of make

Re: [Qemu-devel] [0/25] Async threading for VirtFS using glib threads & coroutines.

2011-05-24 Thread Jamie Lokier
Venkateswararao Jujjuri wrote: > This model makes the code simple and also in one shot we can convert > all v9fs_do_syscalls into asynchronous threads. But as Aneesh raised > will there be any additional overhead for the additional jumps? We > can quickly test it out too. I'm not sure if this is

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-24 Thread Jamie Lokier
Stefan Hajnoczi wrote: > My current plan is to try using sigaltstack(2) instead of > makecontext()/swapcontext() as a hack since OpenBSD doesn't have > makecontext()/swapcontext(). sigaltstack() is just a system call to tell the system about an alternative signal stack - that you have allocated yo

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-24 Thread Stefan Hajnoczi
On Tue, May 24, 2011 at 08:37:50PM +0100, Jamie Lokier wrote: > Daniel P. Berrange wrote: > > On Wed, May 11, 2011 at 03:45:39PM +0200, Paolo Bonzini wrote: > > > On 05/11/2011 03:05 PM, Anthony Liguori wrote: > > > >> > > > >>A very slow way, too (on Windows at least if you use qemu_cond...). > >

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-24 Thread Jamie Lokier
Stefan Hajnoczi wrote: > On Thu, May 12, 2011 at 10:51 AM, Jan Kiszka wrote: > > On 2011-05-11 12:15, Stefan Hajnoczi wrote: > >> From: Kevin Wolf > >> > >> Asynchronous code is becoming very complex.  At the same time > >> synchronous code is growing because it is convenient to write. > >> Somet

[Qemu-devel] dynamically linked binaries under sparc-linux-user

2011-05-24 Thread Artyom Tarasenko
Should it be possible to use dynamically linked binaries under sparc*-linux-user? Under qemu-system-sparc the Debian 4.08r1 initrd works fine, but: master$ sparc-linux-user/qemu-sparc -strace -L ../debian-4.08r1-initrd/ ../debian-4.08r1-initrd/bin/busybox 14004 uname(0x409ffbae) = 0 14004 brk(NULL

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-24 Thread Jamie Lokier
Daniel P. Berrange wrote: > On Wed, May 11, 2011 at 03:45:39PM +0200, Paolo Bonzini wrote: > > On 05/11/2011 03:05 PM, Anthony Liguori wrote: > > >> > > >>A very slow way, too (on Windows at least if you use qemu_cond...). > > > > > >That doesn't mean you can't do a fiber implementation for Windows

Re: [Qemu-devel] [patch 6/7] QEMU live block copy

2011-05-24 Thread Blue Swirl
On Tue, May 24, 2011 at 12:31 AM, Marcelo Tosatti wrote: > Support live image copy + switch. That is, copy an image backing > a guest hard disk to a destination image (destination image must > be created separately), and switch to this copy. > > Command syntax: > > block_copy device filename [-i]

Re: [Qemu-devel] [patch 2/7] Add blkmirror block driver

2011-05-24 Thread Blue Swirl
On Tue, May 24, 2011 at 12:31 AM, Marcelo Tosatti wrote: > Mirrored writes are used by live block copy. > > Signed-off-by: Marcelo Tosatti > > Index: qemu-block-copy/block/blkmirror.c > === > --- /dev/null > +++ qemu-block-copy/block

[Qemu-devel] [PATCH v4 1/4] rbd: use the higher level librbd instead of just librados

2011-05-24 Thread Josh Durgin
librbd stacks on top of librados to provide access to rbd images. Using librbd simplifies the qemu code, and allows qemu to use new versions of the rbd format with few (if any) changes. Signed-off-by: Josh Durgin Signed-off-by: Yehuda Sadeh --- block/rbd.c | 790 +++-

[Qemu-devel] [PATCH v4 3/4] rbd: check return values when scheduling aio

2011-05-24 Thread Josh Durgin
If scheduling fails, the number of outstanding I/Os must be correct, or there will be a hang when waiting for everything to be flushed. Reported-by: Stefan Hajnoczi Signed-off-by: Josh Durgin --- block/rbd.c | 24 1 files changed, 20 insertions(+), 4 deletions(-) dif

[Qemu-devel] [PATCH v4 4/4] rbd: Add bdrv_truncate implementation

2011-05-24 Thread Josh Durgin
Signed-off-by: Josh Durgin --- block/rbd.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index c9f32e4..015ae8e 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -687,6 +687,20 @@ static int64_t qemu_rbd_getlength(BlockDriverState *b

[Qemu-devel] [PATCH v4 2/4] rbd: allow configuration of rados from the rbd filename

2011-05-24 Thread Josh Durgin
The new format is rbd:pool/image[@snapshot][:option1=value1[:option2=value2...]] Each option is used to configure rados, and may be any Ceph option, or "conf". The "conf" option specifies a Ceph configuration file to read. This allows rbd volumes from more than one Ceph cluster to be used by speci

[Qemu-devel] [PATCH v4 0/4] rbd improvements

2011-05-24 Thread Josh Durgin
This patchset moves the complexity of the rbd format into librbd and adds truncation support. Changes since v3: * trivially rebased * updated copyright header Changes since v2: * return values are checked in rbd_aio_rw_vector * bdrv_truncate added Josh Durgin (4): rbd: use the higher level

Re: [Qemu-devel] 9p and savevm'd snapshots

2011-05-24 Thread Anthony Liguori
On 05/24/2011 03:54 AM, Alex Young wrote: Hi there, I'm having a problem with 9p virtfs mounts going away when I savevm, quit, then restart with -loadvm. The mount seems to cause the guest kernel to hang if I interact with it in any way that causes a stat(2). I'm also unable to mount a 9p filesy

Re: [Qemu-devel] [PATCH] target-s390x: Fix build for non-linux hosts

2011-05-24 Thread Alexander Graf
On 24.05.2011, at 19:42, Stefan Weil wrote: > linux/kvm.h is not always available for compilation. > > Neither linux/kvm.h nor kvm.h are needed, so remove both > which also fixes the build problem for non-linux hosts. > > Cc: Alexander Graf > Signed-off-by: Stefan Weil Thanks :). Applied to

[Qemu-devel] [PATCH] target-s390x: Fix build for non-linux hosts

2011-05-24 Thread Stefan Weil
linux/kvm.h is not always available for compilation. Neither linux/kvm.h nor kvm.h are needed, so remove both which also fixes the build problem for non-linux hosts. Cc: Alexander Graf Signed-off-by: Stefan Weil --- target-s390x/helper.c |5 - 1 files changed, 0 insertions(+), 5 deleti

Re: [Qemu-devel] [PATCH] usb-ccid: Plug memory leak on qdev exit()

2011-05-24 Thread Alon Levy
On Tue, May 24, 2011 at 06:09:10PM +0200, Markus Armbruster wrote: > ccid_initfn() allocates CCIDBus dynamically, but there is no exit > callback to free it. > > Fix by getting rid of the allocation. > > Signed-off-by: Markus Armbruster Tested-by: Alon Levy > --- > hw/usb-ccid.c | 28 +

Re: [Qemu-devel] [PATCH v2 1/2] Generalize -machine command line option

2011-05-24 Thread Jan Kiszka
On 2011-05-24 18:06, Ian Campbell wrote: > On Sun, 2011-05-22 at 13:00 +0200, Jan Kiszka wrote: >> From: Jan Kiszka >> >> -machine somehow suggests that it selects the machine, but it doesn't. >> Fix that before this command is set in stone. >> >> Actually, -machine should supersede -M and allow t

[Qemu-devel] Derivative snapshots or snapshots for versioning

2011-05-24 Thread Mike Young
Hi, I'm trying to see if I can I do a derivative snapshot as a means of versioning. I wish to do this vs dd or cp as it's much faster. I do not intend to apply a snapshot back to an original volume. So, let's say I have original_volume.img and I create a snapshot using the ­b option: "qemu-img cr

[Qemu-devel] [PATCH] usb-ccid: Plug memory leak on qdev exit()

2011-05-24 Thread Markus Armbruster
ccid_initfn() allocates CCIDBus dynamically, but there is no exit callback to free it. Fix by getting rid of the allocation. Signed-off-by: Markus Armbruster --- hw/usb-ccid.c | 28 1 files changed, 8 insertions(+), 20 deletions(-) diff --git a/hw/usb-ccid.c b/hw

Re: [Qemu-devel] [RFC][PATCH v0 0/8] Improve register allocator

2011-05-24 Thread Richard Henderson
On 05/24/2011 04:31 AM, Kirill Batuzov wrote: > > > On Mon, 23 May 2011, Aurelien Jarno wrote: > >> >> Thanks for this patch series. Your approach to solve this issue is >> really different than mine. Instead I added more state to the dead/live >> states, and use them to mark some input deads ev

Re: [Qemu-devel] [PATCH v2 1/2] Generalize -machine command line option

2011-05-24 Thread Ian Campbell
On Sun, 2011-05-22 at 13:00 +0200, Jan Kiszka wrote: > From: Jan Kiszka > > -machine somehow suggests that it selects the machine, but it doesn't. > Fix that before this command is set in stone. > > Actually, -machine should supersede -M and allow to introduce arbitrary > per-machine options to

Re: [Qemu-devel] [PATCH v2 9/9] target-i386: add support for FPU exceptions

2011-05-24 Thread Peter Maydell
On 23 May 2011 22:42, Aurelien Jarno wrote: > This patch adds support for FPU exceptions. It keeps the exception in > the softfloat status, and copy them back to env->fpus when needed by > oring them. When loading a new value to env->fpus, it starts with a > clean softfloat status. > > Signed-off-

Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter

2011-05-24 Thread Erik Rull
Hi Gerd, could you provide a single patch file for the new USB files against the released qemu 0.14.0 or 0.14.1? I tried to create that file by assembling the patch emails but no real success. Feedback on the patch is guaranteed :-) Thanks a lot! Best regards, Erik

Re: [Qemu-devel] [PATCH 1/4] slirp: Fix restricted mode

2011-05-24 Thread Jan Kiszka
On 2011-05-24 16:37, Gleb Natapov wrote: > On Tue, May 24, 2011 at 03:34:33PM +0200, Jan Kiszka wrote: >> On 2011-05-24 15:01, Gleb Natapov wrote: >>> On Tue, May 24, 2011 at 02:42:55PM +0200, Jan Kiszka wrote: On 2011-05-24 14:37, Gleb Natapov wrote: > On Mon, May 23, 2011 at 04:48:16PM +

Re: [Qemu-devel] [PATCH] Add support for fd: protocol

2011-05-24 Thread Jamie Lokier
Stefan Hajnoczi wrote: > On Mon, May 23, 2011 at 11:49 PM, Jamie Lokier wrote: > > Being able to override the backing file path would be useful anyway. > > > > I've already had problems when moving established qcow2 files between > > systems, that for historical reasons contain either an absolute

Re: [Qemu-devel] [PATCH v2 3/9] target-i386: remove old code handling float64

2011-05-24 Thread Peter Maydell
On 23 May 2011 22:42, Aurelien Jarno wrote: > Now that target-i386 uses softfloat, floatx80 is always available and > there is no need anymore to have code handling both float64 and floax80. > > Signed-off-by: Aurelien Jarno Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH 23/26] target-xtensa: implement interrupt option

2011-05-24 Thread Max Filippov
- cycles fed into advance_ccount may (and on real hardware actually do) depend on executed commands/pipeline/cache hits. Most of this stuff may be counted at the translation time; >>> >>> Since CCOUNT, as seen by any one thread of execution, on real hw depends >>> on cache hits, inte

Re: [Qemu-devel] [PATCH] block: clarify the meaning of BDRV_O_NOCACHE

2011-05-24 Thread Kevin Wolf
Am 17.05.2011 18:04, schrieb Christoph Hellwig: > Change BDRV_O_NOCACHE to only imply bypassing the host OS file cache, > but no writeback semantics. All existing callers are changed to also > specify BDRV_O_CACHE_WB to give them writeback semantics. > > Signed-off-by: Christoph Hellwig Thanks,

Re: [Qemu-devel] [PATCH 23/26] target-xtensa: implement interrupt option

2011-05-24 Thread Richard Henderson
On 05/24/2011 03:28 AM, Max Filippov wrote: >>> - cycles fed into advance_ccount may (and on real hardware actually >>> do) depend on executed commands/pipeline/cache hits. Most of this >>> stuff may be counted at the translation time; >> >> Since CCOUNT, as seen by any one thread of execution, on

Re: [Qemu-devel] [PATCH 21/26] target-xtensa: implement unaligned exception option

2011-05-24 Thread Richard Henderson
On 05/23/2011 04:20 PM, Max Filippov wrote: > I probably just don't get what you call 'out-of-line'. In fact > do_unaligned_access will be called for every unaligned access, and > alignment condition will be checked for every access. It just happens > in other place. Does it have more chances to be

Re: [Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-05-24 Thread Serge Hallyn
Please move this thread to a wiki.ubuntu.com wiki page and a private or different mailing list. Since gawk is needed for the build, you need to add gawk to the build-depends line in debian/control. -serge Quoting Boris Derzhavets (723...@bugs.launchpad.net): > @Serge, > > I am getting error whe

[Qemu-devel] [PATCH] qcow2: Fix in-flight list after qcow2_cache_put failure

2011-05-24 Thread Kevin Wolf
If qcow2_cache_put returns an error during cluster allocation and the allocation fails, it must be removed from the list of in-flight allocations. Otherwise we'd get a loop in the list when the ACB is used for the next allocation. Luckily, this qcow2_cache_put shouldn't fail anyway because the L2

Re: [Qemu-devel] [PATCH 1/4] slirp: Fix restricted mode

2011-05-24 Thread Gleb Natapov
On Tue, May 24, 2011 at 03:34:33PM +0200, Jan Kiszka wrote: > On 2011-05-24 15:01, Gleb Natapov wrote: > > On Tue, May 24, 2011 at 02:42:55PM +0200, Jan Kiszka wrote: > >> On 2011-05-24 14:37, Gleb Natapov wrote: > >>> On Mon, May 23, 2011 at 04:48:16PM +0200, Jan Kiszka wrote: > This aligns t

[Qemu-devel] [PATCH V3 2/2] xen: Introduce VGA sync dirty bitmap support

2011-05-24 Thread anthony.perard
From: Anthony PERARD This patch introduces phys memory client for Xen. Only sync dirty_bitmap and set_memory are actually implemented. migration_log will stay empty for the moment. Xen can only log one range for bit change, so only the range in the first call will be synced. Signed-off-by: Ant

[Qemu-devel] [PATCH V3 1/2] xen: Add xc_domain_add_to_physmap to xen_interface.

2011-05-24 Thread anthony.perard
From: Anthony PERARD This function will be used to support sync dirty bitmap. This come with a check against every Xen release, and special implementation for Xen version that doesn't have this specific call. This function will not be usable with Xen 3.3 because the behavior is different. Sign

[Qemu-devel] [PATCH V3 0/2] Xen VGA dirtybit support

2011-05-24 Thread anthony.perard
From: Anthony PERARD Hi, This two patches provides the support for sync dirty bitmap, especially useful for the VGA output. The sync dirty bitmap is not provided for Xen 3.3. Change v2 -> v3: * use the new log_dirty parameter of set_memory clients. * fix some mistakes related to the use of

Re: [Qemu-devel] [PATCH 1/3] spapr: allow creating devices with -device

2011-05-24 Thread Markus Armbruster
Paolo Bonzini writes: > On 05/24/2011 03:03 PM, Markus Armbruster wrote: >> > This is particularly important with the conversion from scsi-disk >> > to scsi-{cd,hd} that Markus made. After his patches, if you >> > specify a scsi-cd device attached to an if=none drive, the default >> > VSCSI

Re: [Qemu-devel] [PATCH 1/4] slirp: Fix restricted mode

2011-05-24 Thread Jan Kiszka
On 2011-05-24 15:01, Gleb Natapov wrote: > On Tue, May 24, 2011 at 02:42:55PM +0200, Jan Kiszka wrote: >> On 2011-05-24 14:37, Gleb Natapov wrote: >>> On Mon, May 23, 2011 at 04:48:16PM +0200, Jan Kiszka wrote: This aligns the code to what the documentation claims: Allow everything but re

Re: [Qemu-devel] [RFC][PATCH v0 0/8] Improve register allocator

2011-05-24 Thread Kirill Batuzov
On Tue, 24 May 2011, Laurent Desnogues wrote: > On Tue, May 24, 2011 at 1:31 PM, Kirill Batuzov wrote: > [...] > > Gathered statistics shows some interesting things too. I've run matrix > > multiplication benchmark (guest - ARM, host - x86, linux-user mode, with > > my patches applied) and here

Re: [Qemu-devel] [RFC][PATCH v0 0/8] Improve register allocator

2011-05-24 Thread Laurent Desnogues
On Tue, May 24, 2011 at 1:31 PM, Kirill Batuzov wrote: [...] > Gathered statistics shows some interesting things too. I've run matrix > multiplication benchmark (guest - ARM, host - x86, linux-user mode, with > my patches applied) and here are the results: > > spill count         3916 >  real spil

Re: [Qemu-devel] [PATCH v3 13/21] scsi: do not call send_command directly

2011-05-24 Thread Paolo Bonzini
On 05/24/2011 03:05 PM, Kevin Wolf wrote: Maybe the callback should be done from a BH then? It sounds like this could cause more bugs than what you're fixing here. Not sure, after all it makes sense to answer some queries synchronously (e.g. TEST_UNIT_READY). It's just the convoluted control

Re: [Qemu-devel] [PATCH 1/3] spapr: allow creating devices with -device

2011-05-24 Thread Paolo Bonzini
On 05/24/2011 03:03 PM, Markus Armbruster wrote: > This is particularly important with the conversion from scsi-disk > to scsi-{cd,hd} that Markus made. After his patches, if you > specify a scsi-cd device attached to an if=none drive, the default > VSCSI controller will not be created and,

Re: [Qemu-devel] KVM call agenda dfor May 24th

2011-05-24 Thread Juan Quintela
Juan Quintela wrote: > Please send in any agenda items you are interested in covering. As there have been any items for the agenda, call gets cancelled. Have a nice week, Juan.

Re: [Qemu-devel] [PATCH 0/3] spapr qdevification

2011-05-24 Thread Markus Armbruster
Paolo Bonzini writes: > This series fixes some problems with spapr's qdev interface. Patch > 1 is the important one, which makes it possible to use -device > to create vio devices. The other two are cosmetic. Looks good to spapr-ignorant me.

Re: [Qemu-devel] [PATCH 1/3] spapr: allow creating devices with -device

2011-05-24 Thread Markus Armbruster
Paolo Bonzini writes: > Right now the spapr devices cannot be instantiated with -device, > because the IRQs need to be passed to the spapr_*_create functions. > Do this instead in the bus's init wrapper. > > This is particularly important with the conversion from scsi-disk > to scsi-{cd,hd} that

Re: [Qemu-devel] [PATCH v3 13/21] scsi: do not call send_command directly

2011-05-24 Thread Kevin Wolf
Am 20.05.2011 19:43, schrieb Paolo Bonzini: > On 05/20/2011 06:04 PM, Christoph Hellwig wrote: >>> -void scsi_req_enqueue(SCSIRequest *req) >>> +int32_t scsi_req_enqueue(SCSIRequest *req, uint8_t *buf) >>> { >>> +int32_t rc; >>> assert(!req->enqueued); >>> scsi_req_ref(req); >>>

Re: [Qemu-devel] [PATCH 1/4] slirp: Fix restricted mode

2011-05-24 Thread Gleb Natapov
On Tue, May 24, 2011 at 02:42:55PM +0200, Jan Kiszka wrote: > On 2011-05-24 14:37, Gleb Natapov wrote: > > On Mon, May 23, 2011 at 04:48:16PM +0200, Jan Kiszka wrote: > >> This aligns the code to what the documentation claims: Allow everything > >> but requests that would have to be routed outside

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-05-24 Thread Boris Derzhavets
@Serge, I am getting error when build in PPA :- make[2]: Entering directory `/build/buildd/spice-gtk-0.6/po' cd .. \ && CONFIG_FILES=po/Makefile.in CONFIG_HEADERS= CONFIG_LINKS= \ /bin/bash ./config.status config.status: creating po/Makefile.in ./config.status: line 1509:

Re: [Qemu-devel] [PATCH 1/4] slirp: Fix restricted mode

2011-05-24 Thread Jan Kiszka
On 2011-05-24 14:37, Gleb Natapov wrote: > On Mon, May 23, 2011 at 04:48:16PM +0200, Jan Kiszka wrote: >> This aligns the code to what the documentation claims: Allow everything >> but requests that would have to be routed outside of the virtual LAN. >> >> So we need to drop the unneeded IP-level f

  1   2   >