john cooper writes:
> This series is a resend of several pending patches which
> have been brought up-to-date. All address problems we have
> found and corrected in our codebase in the process of test
> and deploy of cpu model support.
>
> A few have been modified slightly to address minor white
On 05/23/2011 11:11 PM, Aurelien Jarno wrote:
Looks ok in principle, but I wonder if we should really create a new
header for that. softfloat-specialize.h is already supposed to contain
the target specific functions, so it's probably a good idea to move them
there instead.
I was wondering about
Anthony Liguori writes:
> On 05/23/2011 11:18 AM, Markus Armbruster wrote:
>> Anthony Liguori writes:
>>
>>> If it's left up to the application, doesn't that mean that we can't
>>> ever send 64-bit memory/disk faithfully?
>>>
>>> Because a client would be allowed to represent integers as signed
Anthony Liguori wrote:
> On 05/23/2011 06:02 PM, Jamie Lokier wrote:
> >Richard W.M. Jones wrote:
> >>The problem is to be able to send 64 bit memory and disk offsets
> >>faithfully. This doesn't just fail to solve the problem, it's
> >>actually going to make it a whole lot worse.
> >
> >Such offs
On 05/23/2011 06:02 PM, Jamie Lokier wrote:
Richard W.M. Jones wrote:
The problem is to be able to send 64 bit memory and disk offsets
faithfully. This doesn't just fail to solve the problem, it's
actually going to make it a whole lot worse.
Such offsets would be so much more readable in hexa
于 2011-5-23 19:19, Brad Hards 写道:
On Monday 23 May 2011 19:26:45 daixiaoke wrote:
3.Compiled uClinux following steps in the attachment(Chapter 4: Building
the uClinux image). “STM3210E-EVAL-jffs” was selected for "Porduct" while
Configure uClinux for STM3210E-EVAL.
So you have built the image
> > This is also done by gen_load_store_alignment.
> > Does it really worth copying part of this logic to do_unaligned_access just
> > to use ALIGNED_ONLY framework?
>
> Yes, because it is done out-of-line, as a part of the TLB load slow path.
I probably just don't get what you call 'out-of-line
Richard W.M. Jones wrote:
> The problem is to be able to send 64 bit memory and disk offsets
> faithfully. This doesn't just fail to solve the problem, it's
> actually going to make it a whole lot worse.
Such offsets would be so much more readable in hexadecimal.
So why not use a string "0x8
Markus Armbruster wrote:
> Anthony Liguori writes:
>
> > On 05/23/2011 05:30 AM, Daniel P. Berrange wrote:
> >> It feels to me that turning the current block driver code which just does
> >> open(2) on files, into something which issues events& asynchronously
> >> waits for a file would potentia
Gleb Natapov wrote:
> On Sun, May 22, 2011 at 10:50:22AM +0300, Avi Kivity wrote:
> > On 05/20/2011 02:25 PM, Gleb Natapov wrote:
> > >>
> > >> A) Removing regions will change significantly. So far this is done by
> > >> setting a region to IO_MEM_UNASSIGNED, keeping truncation. With the new
> >
This patch adds Westmere as a qemu cpu model. The only
additional guest visible feature of a Westmere relative
to Nehalem is the inclusion of AES instructions. However
as other non-ABI visible modifications exist along with
fabrication changes, the CPUID data of the corresponding
deployed silicon
This patch was intended to address the replicated feature
flags in cpuid 8000_0001:edx from cpuid _0001:edx.
This is due to AMD's definition where these flags are
mostly cloned in the 8000_0001:edx cpuid function.
qemu64 attempted to glue together the respective Intel
and AMD nearly disjoint fe
On 23 May 2011 22:42, Aurelien Jarno wrote:
> Instead of using a table which doesn't correspond to anything from
> physical in the CPU, use directly the constants in helper_fld*_ST0().
>
> Cc: Andreas Färber
> Signed-off-by: Aurelien Jarno
Reviewed-by: Peter Maydell
Failure by qemu to open a default config file isn't cause to
error exit -- it just quietly continues on. After puzzling
issues with otherwise opaque config file locations and
startup handling numerous times, some help from qemu seemed
justified.
In the case of a "?" pseudo filename arg to -readc
Launching qemu with "-cpu [check|enforce]" without explicitly
prefixing a valid model name doesn't do as intuitively expected.
Rather qemu exits with a CLI parse error.
Unfortunately due to qemu's CLI argument parsing structure and
the fact cpu models are initialized depending on build configurati
Add kvm emulated x2apic flag to config defined cpu models
and general support for such hypervisor emulated flags.
In addition to checking user request flags against the host
we also selectively check against kvm for emulated flags.
Signed-off-by: john cooper
---
diff --git a/hw/pc.c b/hw/pc.c
i
Allow an optional qemu_early_init_vcpu() such that
kvm_arch_get_supported_cpuid() can be used from
cpu_x86_register(). Without this minimal setup
kvm_arch_get_supported_cpuid() gags kvm_ioctl() via
passing a NULL initialized KVMState *.
Signed-off-by: john cooper
---
diff --git a/cpus.c b/cpus.
On 23 May 2011 22:42, Aurelien Jarno wrote:
> target-mips has been switched to softfloat only long ago, but
> a #ifndef CONFIG_SOFTFLOAT has been forgotten. Remove it.
>
> Signed-off-by: Aurelien Jarno
Reviewed-by: Peter Maydell
Correct archaic CPU model "model" field for Intel CPUs.
The old "model" values caused two known problems:
- Skype crashes on a winxp guest if model < 6, due to syscall vs.
sysenter confusion.
- 32 bit windows doesn't enable MSI support if model < 13.
After consulting with Intel the
This series is a resend of several pending patches which
have been brought up-to-date. All address problems we have
found and corrected in our codebase in the process of test
and deploy of cpu model support.
A few have been modified slightly to address minor whitespace
issues and 4/7 reverts the
On 23 May 2011 22:42, Aurelien Jarno wrote:
> Rewrite helper_fxam_ST0() using only softfloat functions.
>
> Signed-off-by: Aurelien Jarno
(Sorry I didn't get round to this one earlier; I think I did
the easy patches and stalled on the ones I'd have to pull out
the x86 manuals for :-))
> /*
On Sun, May 22, 2011 at 07:55:53PM +0300, Blue Swirl wrote:
> On Sun, May 22, 2011 at 2:18 PM, Blue Swirl wrote:
> > Make functions take a parameter for CPUState instead of relying
> > on global env. Pass CPUState pointer to TCG prologue, which moves
> > it to AREG0.
>
> I found the problem with
On 05/23/2011 10:56 AM, Kevin Wolf wrote:
Am 23.05.2011 17:24, schrieb Markus Armbruster:
Kevin Wolf writes:
An fd: protocol can't easily support reopen. So fail it. This doesn't
break any existing usage. It's just a restriction on the new protocol.
Restrictions can render the new protocol
This patch adds support for FPU exceptions. It keeps the exception in
the softfloat status, and copy them back to env->fpus when needed by
oring them. When loading a new value to env->fpus, it starts with a
clean softfloat status.
Signed-off-by: Aurelien Jarno
---
target-i386/cpu.h | 15
Now that target-i386 uses softfloat, floatx80 is always available and
there is no need anymore to have code handling both float64 and floax80.
Signed-off-by: Aurelien Jarno
---
target-i386/cpu.h | 22 +---
target-i386/exec.h | 132 +---
target-i386/helper.c|
Rewrite helper_fxam_ST0() using only softfloat functions.
Signed-off-by: Aurelien Jarno
---
target-i386/op_helper.c | 30 --
1 files changed, 12 insertions(+), 18 deletions(-)
diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
index cec0c76..8ba2b5f 100
float*_is_zero_or_denormal() is available for float32, but not for
float64, floatx80 and float128. Fix that.
Reviewed-by: Peter Maydell
Signed-off-by: Aurelien Jarno
---
fpu/softfloat.h | 15 +++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/fpu/softfloat.h b/fpu
This patch series finally removes softfloat-native as it is not used by
default in any target. In then laters improves the target-i386 code as
it does not need to be compatible with softfloat-native anymore.
v1 -> v2:
fix mips/gdbstub
reorder patches to fix target-i386 bisection
dropped log2
Instead of using a table which doesn't correspond to anything from
physical in the CPU, use directly the constants in helper_fld*_ST0().
Cc: Andreas Färber
Signed-off-by: Aurelien Jarno
---
target-i386/op_helper.c | 27 ---
1 files changed, 8 insertions(+), 19 deletion
Remove softfloat-native support, all targets are now using softfloat
instead.
Reviewed-by: Peter Maydell
Signed-off-by: Aurelien Jarno
---
Makefile.target|3 +-
configure |2 -
cpu-all.h |5 +-
fpu/softfloat-native.c | 540 -
Now that softfloat-native is gone, there is no real point on not always
enabling floatx80 and float128 support.
Reviewed-by: Peter Maydell
Signed-off-by: Aurelien Jarno
---
cpu-all.h |2 -
fpu/softfloat-specialize.h |7 -
fpu/softfloat.c| 62 --
target-ppc has been switched to softfloat only long ago, but a
few #ifdef CONFIG_SOFTFLOAT have been forgotten. Remove them.
Cc: Alexander Graf
Reviewed-by: Peter Maydell
Signed-off-by: Aurelien Jarno
---
target-ppc/helper.h|2 --
target-ppc/op_helper.c | 11 ---
target-ppc/t
target-mips has been switched to softfloat only long ago, but
a #ifndef CONFIG_SOFTFLOAT has been forgotten. Remove it.
Signed-off-by: Aurelien Jarno
---
gdbstub.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index ae856f9..b9ae30d 100644
---
On Mon, May 23, 2011 at 10:13:47AM +0100, Peter Maydell wrote:
> The --disable-slirp option was undocumented; add it to configure's
> --help output.
>
> Signed-off-by: Peter Maydell
> ---
> configure |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Thanks, applied.
> diff --git a/c
On Mon, May 23, 2011 at 04:04:42PM +0100, Peter Maydell wrote:
> Remove a preprocessor #define which is never used.
>
> Signed-off-by: Peter Maydell
> ---
> target-arm/exec.h |2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
Thanks, applied.
> diff --git a/target-arm/exec.h b/targe
On Sun, May 22, 2011 at 11:01:13PM +0100, Stefan Hajnoczi wrote:
> The following changes since commit dcfd14b3741983c466ad92fa2ae91eeafce3e5d5:
>
> Delete unused tb_invalidate_page_range (2011-05-22 10:47:28 +)
>
> are available in the git repository at:
> git://repo.or.cz/qemu/stefanha.g
v3:
- replace commit file with mirrored writes
- address comments from round 2
v2:
- use reference counting to be safe against device hotplug / bdrv_truncate
- add comment about usage of timer
Support live image copy + switch. That is, copy an image backing
a guest hard disk to a destination image (destination image must
be created separately), and switch to this copy.
Command syntax:
block_copy device filename [-i] -- live block copy device to image
-i for incremental cop
Signed-off-by: Marcelo Tosatti
Index: qemu-block-copy/block.h
===
--- qemu-block-copy.orig/block.h
+++ qemu-block-copy/block.h
@@ -295,6 +295,14 @@ typedef enum {
BLKDBG_CLUSTER_ALLOC_BYTES,
BLKDBG_CLUSTER_FREE,
+BLKD
Signed-off-by: Marcelo Tosatti
Index: qemu-block-copy/qerror.c
===
--- qemu-block-copy.orig/qerror.c
+++ qemu-block-copy/qerror.c
@@ -209,6 +209,14 @@ static const QErrorStringTable qerror_ta
.error_fmt = QERR_VNC_SERVER_FAI
Mirrored writes are used by live block copy.
Signed-off-by: Marcelo Tosatti
Index: qemu-block-copy/block/blkmirror.c
===
--- /dev/null
+++ qemu-block-copy/block/blkmirror.c
@@ -0,0 +1,239 @@
+/*
+ * Block driver for mirrored writes.
Signed-off-by: Marcelo Tosatti
Index: qemu-block-copy/migration.c
===
--- qemu-block-copy.orig/migration.c
+++ qemu-block-copy/migration.c
@@ -19,6 +19,7 @@
#include "block.h"
#include "qemu_socket.h"
#include "block-migration.h"
To query whether migration is active.
Signed-off-by: Marcelo Tosatti
Index: qemu-block-copy/migration.c
===
--- qemu-block-copy.orig/migration.c
+++ qemu-block-copy/migration.c
@@ -480,3 +480,13 @@ int get_migration_state(void)
Signed-off-by: Marcelo Tosatti
Index: qemu-block-copy/sysemu.h
===
--- qemu-block-copy.orig/sysemu.h
+++ qemu-block-copy/sysemu.h
@@ -33,6 +33,7 @@ void qemu_del_vm_change_state_handler(VM
#define VMSTOP_SAVEVM6
#define VMSTOP_
On Thu, May 19, 2011 at 02:46:13PM +0100, Peter Maydell wrote:
> This patch series fixes a number of minor bugs in the ARM target where
> we were not correctly setting the cumulative exception flags in the
> FPSCR. It includes adding a new flag to softfloat indicating when a
> denormal result has b
On Fri, May 20, 2011 at 06:03:50PM +0200, Alexander Graf wrote:
> Hi,
>
> This is my current PPC patch queue containing all the collected PPC work for
> Qemu so far. Please pull.
Pulled. In the future, could you please also send the patch series to
the mailing list, so that people can have a look
On Fri, May 20, 2011 at 05:44:12PM +0200, Alexander Graf wrote:
> Hi,
>
> This is my current s390x patch queue containing
>
> * s390x emulation
> * fixes for s390x kvm
>
> Please pull.
Pulled. In the future, could you please also send the patch series to
the mailing list, so that people can
On Mon, May 23, 2011 at 06:40:46PM +0400, Kirill Batuzov wrote:
> This series improves register allocator by keeping track of temp's and
> register's live ranges, doing better spill choice and spilling early unneeded
> globals.
>
> The patches do need testing and performance evaluation before they
We were failing to generate EXC_DEBUG in the EXIT_PC_UPDATED path.
This caused us not to stop at the instruction after a branch, but
on the instruction afterward.
Signed-off-by: Richard Henderson
---
target-alpha/translate.c | 35 ---
1 files changed, 20 inserti
On Thu, May 19, 2011 at 03:47:00PM +0200, Paolo Bonzini wrote:
> Most definitions in softfloat.h are really target-independent. Split
> the few that stand out as target-dependent, to allow including
> softfloat.h from files that are not compiled per-target.
Looks ok in principle, but I wonder if
Signed-off-by: Richard Henderson
---
target-alpha/helper.h|1 -
target-alpha/op_helper.c | 10 --
target-alpha/translate.c | 19 ---
3 files changed, 8 insertions(+), 22 deletions(-)
diff --git a/target-alpha/helper.h b/target-alpha/helper.h
index f4f693a..de8
Expose these via MTPR, more or less like the real HW does.
Signed-off-by: Richard Henderson
---
target-alpha/helper.h|3 +++
target-alpha/op_helper.c | 11 ++-
target-alpha/translate.c | 32 +---
3 files changed, 34 insertions(+), 12 deletions(-)
Signed-off-by: Richard Henderson
---
target-alpha/helper.c | 10 +++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/target-alpha/helper.c b/target-alpha/helper.c
index 96b407b..bd3af38 100644
--- a/target-alpha/helper.c
+++ b/target-alpha/helper.c
@@ -220,14 +220,18 @@ st
In particular, SWPIPL is used quite a lot by the Linux kernel.
Doing this inline makes it significantly easier to step through
without the debugger getting confused by the mode switch.
Signed-off-by: Richard Henderson
---
target-alpha/translate.c | 140 +++---
We had two different methods in use, both of which referenced ENV,
and neither of which indicated to the generic code when different
compilation modes are not compatible.
Signed-off-by: Richard Henderson
---
target-alpha/cpu.h | 32 -
target-alpha/translate.c | 378 +
Signed-off-by: Richard Henderson
---
target-alpha/helper.c | 121 +
1 files changed, 111 insertions(+), 10 deletions(-)
diff --git a/target-alpha/helper.c b/target-alpha/helper.c
index c5479fd..a49f632 100644
--- a/target-alpha/helper.c
+++ b/targ
With all of the pre-existing code that would not compile gone,
this is the earliest point at which the target can be enabled.
There is no machine defined yet, so this will crash on startup.
Enable the target anyway, to make sure that further compilation
problems do not creep back in.
Signed-off-b
Signed-off-by: Richard Henderson
---
exec-all.h |2 +-
exec.c | 12 ++--
target-alpha/cpu.h |6 +-
target-alpha/op_helper.c | 26 ++
4 files changed, 38 insertions(+), 8 deletions(-)
diff --git a/exec-all.h b/e
This code does not work, and will be replaced by a bios image.
Signed-off-by: Richard Henderson
---
Makefile.target |2 +-
hw/alpha_palcode.c | 1048 --
target-alpha/cpu.h | 35 --
target-alpha/helper.c|2 +-
target-a
Reads the page table how PALcode would, except that the virtual
page table base register is not used.
Signed-off-by: Richard Henderson
---
target-alpha/cpu.h| 13 +
target-alpha/helper.c | 129 +++--
2 files changed, 138 insertions(+), 4 del
Also include the PCC_OFS in the return value. For user mode we
can pretend the PCC_OFS value is always zero.
Signed-off-by: Richard Henderson
---
target-alpha/op_helper.c | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/target-alpha/op_helper.c b/target-alpha/
The EXC_M_* constants were being set for the EV6, not as set for
the Unix kernel entry point.
Use PS_USER_MODE instead of hard-coding access to the PS register.
Signed-off-by: Richard Henderson
---
target-alpha/cpu.h | 56 +++--
target-alpha/trans
Introduce and use arith_excp, filling in the trap_arg[01] IPRs.
Signed-off-by: Richard Henderson
---
target-alpha/op_helper.c | 34 +-
1 files changed, 21 insertions(+), 13 deletions(-)
diff --git a/target-alpha/op_helper.c b/target-alpha/op_helper.c
index 73e5
Signed-off-by: Richard Henderson
---
target-alpha/cpu.h |1 +
target-alpha/helper.c| 37 -
target-alpha/op_helper.c |5 -
3 files changed, 41 insertions(+), 2 deletions(-)
diff --git a/target-alpha/cpu.h b/target-alpha/cpu.h
index d1ef0
This gets the PC right after an arithmetic exception. Also tidies
the code in the TLB fault handlers to use common code.
Signed-off-by: Richard Henderson
---
target-alpha/op_helper.c | 49 -
1 files changed, 30 insertions(+), 19 deletions(-)
diff -
Interrupts are disabled in PALmode, and when the PS IL is high enough.
Signed-off-by: Richard Henderson
---
cpu-exec.c | 33 ++---
target-alpha/cpu.h |5 +
target-alpha/exec.h | 12 +++-
3 files changed, 46 insertions(+), 4 deletions(-)
Delete all the code that tried to emulate the real IPRs of some
unnamed CPU. Replace those with just 3 slots that we can use to
communicate trap information between the helper functions that
signal exceptions and the OS trap handler.
Signed-off-by: Richard Henderson
---
linux-user/main.c
These aren't actually used yet, but we can at least access
them via the HW_MFPR and HW_MTPR instructions.
Signed-off-by: Richard Henderson
---
target-alpha/cpu.h | 15 +++
target-alpha/machine.c | 13 ++
target-alpha/translate.c | 96
There's no need to attempt to match EXCP_* values with PALcode entry
point offsets. Instead, compress all the values to make for more
efficient switch statements within QEMU.
We will be doing TLB fill within QEMU proper, not within the PALcode,
so all of the ITB/DTB miss, double fault, and access
This code contained typos, as it had never been compiled.
Signed-off-by: Richard Henderson
---
target-alpha/translate.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/target-alpha/translate.c b/target-alpha/translate.c
index 73c19d9..851a045 100644
--- a/target-alp
All of the "raw" memory accesses should be "phys" instead. Fix
some confusion about argument ordering of the store routines.
Fix the implementation of store-conditional.
Delete the "alt-mode" helpers. Because we only implement two
mmu modes, let /a imply user-mode unconditionally.
Leave some co
Signed-off-by: Richard Henderson
---
target-alpha/cpu.h |8 +++-
target-alpha/translate.c |6 ++
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/target-alpha/cpu.h b/target-alpha/cpu.h
index 4407b32..a59b39a 100644
--- a/target-alpha/cpu.h
+++ b/target-alpha/c
Don't bother including executive and supervisor modes.
Signed-off-by: Richard Henderson
---
target-alpha/cpu.h | 37 -
target-alpha/translate.c |7 ---
2 files changed, 32 insertions(+), 12 deletions(-)
diff --git a/target-alpha/cpu.h b/target
The QEMU emulation PALcode will use EV6 PALcode insns regardless
of the "real" cpu instruction set being emulated.
Signed-off-by: Richard Henderson
---
alpha-dis.c |4
dis-asm.h |3 +++
disas.c |2 +-
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/alpha-dis
I've been maintaining this port for a while now.
Signed-off-by: Richard Henderson
---
MAINTAINERS |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e6f853d..35d4496 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -56,8 +56,8 @@ M: Paul Broo
Changes from v4 -> v5
* Claim official ownership of the Alpha port, rather
than leave it as "unmaintained".
* Drop all the patches in hw/ for now. While they're necessary
to actually make the port work, these are the subset of the whole
patchset for which I'm confident I'm doing
On Mon, May 23, 2011 at 6:56 PM, Kevin Wolf wrote:
> Am 23.05.2011 17:24, schrieb Markus Armbruster:
>> Kevin Wolf writes:
>>
>>> Am 20.05.2011 21:53, schrieb Blue Swirl:
On Fri, May 20, 2011 at 10:42 PM, Anthony Liguori
wrote:
> On 05/20/2011 02:25 PM, Blue Swirl wrote:
>>
>>
On Mon, May 23, 2011 at 7:09 PM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> Cc: Christoph Hellwig
> ---
> hw/esp.c | 60 +---
> hw/lsi53c895a.c | 48 +++---
> hw/scsi-bus.c | 4 +-
> hw/scsi.h | 9 +
> h
On Mon, May 23, 2011 at 7:08 PM, Paolo Bonzini wrote:
> There are more operations than a SCSI bus can handle, besides completing
> commands. The current callback in fact is overloaded and can be called
> with two different meanings already. Another example, which this series
> will introduce, is
On Mon, May 23, 2011 at 5:40 PM, Kirill Batuzov wrote:
> Gather generated spills statistics. It is useful for debugging and evaluating
> of new register allocator.
>
> Signed-off-by: Kirill Batuzov
> ---
> tcg/tcg.c | 69
> +
> tcg/
On 05/23/2011 11:24 AM, Markus Armbruster wrote:
Kevin Wolf writes:
Am 20.05.2011 21:53, schrieb Blue Swirl:
On Fri, May 20, 2011 at 10:42 PM, Anthony Liguori wrote:
On 05/20/2011 02:25 PM, Blue Swirl wrote:
On Fri, May 20, 2011 at 9:48 PM, Corey Bryant wrote:
sVirt provides SELinux
On 05/23/2011 01:36 PM, Guan, Qiang wrote:
> I want to figure out what is happening in emulating the floating point
> calculation in QEMU. I checked the codes in target-i386/translate.c, but I
> cannot find anything about floating point calculation, I can only find the
> emulation about integer "mu
Hi, Everybody
I am a freshman in QEMU.
I want to figure out what is happening in emulating the floating point
calculation in QEMU. I checked the codes in target-i386/translate.c, but I
cannot find anything about floating point calculation, I can only find the
emulation about integer "mul" or
Hi,
Looks good to me, good way to fix this!
Acked-by: Hans de Goede
Regards,
Hans
On 05/23/2011 05:40 PM, Gerd Hoffmann wrote:
This patch adds USBBusOps struct with (for now) only a single callback
which is called when a device is about to be destroyed. The USB Host
adapters are implementi
Hi,
On 05/23/2011 04:53 PM, Gerd Hoffmann wrote:
Hi,
Good spotting, this is indeed a issue which needs fixing. It isn't
introduced by this patch though, it exists even without the usb patch
queue.
Something like the attached patch should fix it.
The diff looks incomplete (missing changes t
Hi,
On 05/23/2011 04:34 PM, Gerd Hoffmann wrote:
Hi,
The problem is that the USBDevice lifetime may be shorter then the
USBPacket lifetime, USBPackets are created by uhci.c (for example),
where as the device is managed from the monitor (for example), doing
a usb_del in the monitor using the gu
On 05/23/2011 11:18 AM, Markus Armbruster wrote:
Anthony Liguori writes:
If it's left up to the application, doesn't that mean that we can't
ever send 64-bit memory/disk faithfully?
Because a client would be allowed to represent integers as signed
32-bit numbers.
A client is allowed to repr
On 2011-05-23 17:11, Markus Armbruster wrote:
>> Checked again: net_client is terminated by a NULL entry. If we put
>> certain entries on fixed slots, that would created premature list
>> termination if some features is missing (e.g. VDE is configured out). So
>> we actually need a separate name ar
Anthony Liguori writes:
> On 05/23/2011 10:19 AM, Richard W.M. Jones wrote:
>> On Mon, May 23, 2011 at 10:07:21AM -0500, Anthony Liguori wrote:
>>> On 05/23/2011 09:29 AM, Markus Armbruster wrote:
Anthony Liguori writes:
JavaScript's implementation of JSON sets limits on the rang
Signed-off-by: Paolo Bonzini
Cc: Christoph Hellwig
---
hw/esp.c | 60 +---
hw/lsi53c895a.c | 48 +++---
hw/scsi-bus.c|4 +-
hw/scsi.h|9 +
hw/spapr_vscsi.c | 101 ++--
The return value is unused anyway.
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hellwig
---
hw/scsi-disk.c|6 ++
hw/scsi-generic.c |7 ++-
hw/scsi.h |2 +-
3 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
inde
From: Hannes Reinecke
The get_sense callback copies existing sense information into
the provided buffer. This is required if sense information
should be transferred together with the command response.
Signed-off-by: Hannes Reinecke
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hellwig
-
The LUN field in the CDB is a historical relic. Ignore it as reserved,
which is what modern SCSI specifications actually say.
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hellwig
---
hw/scsi-disk.c|6 +++---
hw/scsi-generic.c |5 ++---
2 files changed, 5 insertions(+), 6 del
... and remove some SCSIDevice variables or fields that now become unused.
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hellwig
---
hw/esp.c |2 +-
hw/lsi53c895a.c |2 +-
hw/scsi-bus.c|5 +
hw/scsi.h|1 +
hw/spapr_vscsi.c |8 ++--
hw/usb-m
From: Hannes Reinecke
The SCSI spec has a quite detailed list of sense codes available.
It even mandates the use of specific ones for some failure cases.
The current implementation just has one type of generic error
which is actually a violation of the spec in certain cases.
This patch introduces
This mirrors the LSI patch that was recently committed.
Signed-off-by: Paolo Bonzini
Cc: Christoph Hellwig
---
hw/esp.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/esp.c b/hw/esp.c
index 381a8fb..0b80529 100644
--- a/hw/esp.c
+++ b/hw/esp.c
@@ -61,7 +61,
Signed-off-by: Paolo Bonzini
Cc: Christoph Hellwig
---
hw/esp.c | 26 ++
hw/lsi53c895a.c | 22 --
hw/scsi-bus.c| 16 +---
hw/scsi.h|1 +
hw/spapr_vscsi.c | 26 ++
hw/usb-msd.c |
The sg driver currently has a hardcoded limit of commands it
can handle simultaneously. When this limit is reached the
driver will return -EDOM. So we need to capture this to
enable proper return values here.
Signed-off-by: Hannes Reinecke
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hell
From: Hannes Reinecke
Currently the SCSIRequest structure is abstracted away and cannot accessed
directly from the driver. This requires the handler to do a lookup on
an abstract 'tag' which identifies the SCSIRequest structure.
With this patch the SCSIRequest structure is exposed to the driver.
Signed-off-by: Paolo Bonzini
Cc: Christoph Hellwig
---
hw/esp.c | 10 +-
hw/lsi53c895a.c | 20 ++--
hw/spapr_vscsi.c | 29 +
hw/usb-msd.c | 10 +-
4 files changed, 33 insertions(+), 36 deletions(-)
diff --git a/hw/
1 - 100 of 230 matches
Mail list logo
