On 17.05.2011, at 08:47, David Gibson wrote:
> From: Alexey Kardashevskiy
>
> The existing function virtio_queue_get_ring_size returns number of bytes
> for vring only when it is already initialized.
>
> In order to know how much memory new vring requires, new function
> virtio_queue_get_mem_s
From: Alexey Kardashevskiy
The recently added pseries machine does not currently support PCI
emulation. For the (upcoming) kvm case, this is quite difficult to do
because the preferred HV mode for the host kernel does not allow MMIO
emulation (a hardware limitation).
Therefore, to support virti
From: Alexey Kardashevskiy
The existing function virtio_queue_get_ring_size returns number of bytes
for vring only when it is already initialized.
In order to know how much memory new vring requires, new function
virtio_queue_get_mem_size has been introduced. It is a copy
of the vring_size funct
A few pieces of the pSeries emulation code have variables which are set
but never used, which causes warnings on gcc 4.6. This patch removes
these instances.
Signed-off-by: David Gibson
---
hw/spapr_hcall.c |7 +--
hw/spapr_llan.c |3 ---
2 files changed, 1 insertions(+), 9 deletio
Hi Alex,
Here's a few more patches for the pSeries machine emulation. First
there's a small cleanup / bugfix that removes warnings with gcc 4.6.
Then there are two patches which add virtio support (as opposed to
PAPR style VIO) to the pSeries platform.
Please apply.
On 2011-05-17 03:38, andrzej zaborowski wrote:
> On 16 May 2011 15:08, Dmitry Eremin-Solenikov wrote:
>> On 5/16/11, andrzej zaborowski wrote:
>>> On 16 May 2011 06:54, Dmitry Eremin-Solenikov wrote:
Socket is required, as we have to know the QBus before creating the
device on it.
>>>
On 05/16/11 13:56, Gerd Hoffmann wrote:
> Add support for splitting large transfers into multiple smaller ones.
> This is needed for the upcoming EHCI emulation which allows guests
> to submit requests up to 20k in size. The linux kernel allows 16k
> max size though.
>
> Roughly based on a patch
On 16 May 2011 15:08, Dmitry Eremin-Solenikov wrote:
> On 5/16/11, andrzej zaborowski wrote:
>> On 16 May 2011 06:54, Dmitry Eremin-Solenikov wrote:
>>> Socket is required, as we have to know the QBus before creating the
>>> device on it.
>>
>> Let's skip the qbusification then. It seems that q
Am 29.04.2011 um 08:19 schrieb Khansa Butt:
From f699dbfdca62c5af92d764673b2300131d26263e Mon Sep 17 00:00:00 2001
From: Ehsan-ul-Haq, Abdul Qadeer, Abdul Waheed, Khansa Butt >
Date: Wed, 27 Apr 2011 16:08:16 +0500
Subject: [PATCH 2/3] target-mips:Support for Cavium-Octeon specific
instructio
I'm using Isaku Yamahata's q35 chipset model in Qemu0.14 and I'm trying to
figure out why the Qemu dhcpd server is not responding back to the nic device
in the guest OS when used with user mode networking.
The guest OS sees the network device and initialises it but I think the Qemu
DHCP server/f
I finally got this work after I realised that the AHCI driver was not being
loaded in my disk image and that ACHI was not being enabled in the Seabios
.config file.
This is really good work Yamahata, thanks.
As far as I can tell, everything works like the stock Qemu 0.14 except
networking. The
On 05/16/2011 03:23 PM, Christoph Hellwig wrote:
Why are you even trying this again? As explained very clearly last time you
can't change from a writeback-style to a write-through style I/O from
the monitor without creating massive data integrity problems.
To further clarify:
Today cache=none
Why are you even trying this again? As explained very clearly last time you
can't change from a writeback-style to a write-through style I/O from
the monitor without creating massive data integrity problems. See my
patchset that allows changing this from the guest for how it should be
done - I ju
On 05/16/2011 02:56 PM, Gerd Hoffmann wrote:
Hi,
Here is the current usb patch queue. Patches 1-9 have been on the list
already, the other ones are new. I plan to send a pull request for this
stuff next week.
The major new feature added is USB 2.0 support: A bunch of fixes and
improvement
Keep track of the device which owns the usb packet for async processing.
Signed-off-by: Gerd Hoffmann
---
hw/usb.c | 32
hw/usb.h | 18 +++---
2 files changed, 35 insertions(+), 15 deletions(-)
diff --git a/hw/usb.c b/hw/usb.c
index 966cb0f..8a9a
From: Hans de Goede
Make the linux usb host passthrough code use the usb_generic_handle_packet()
function, rather then the curent DYI code. This removes 200 lines of almost
identical code.
Signed-off-by: Hans de Goede
Signed-off-by: Gerd Hoffmann
---
hw/usb.c| 41 +-
hw/usb.h
From: Brad Hards
This is used for some devices that have multiple interfaces that form a logic
device. An example is Video Class, which has a Control interface and a
Streaming interface. There can be additional interfaces on the same (physical)
devices (e.g. a microphone), and Interface Associati
Remove the cancel callback from the USBPacket struct, move it over
to USBDeviceInfo. Zap usb_defer_packet() which is obsolete now.
Signed-off-by: Gerd Hoffmann
---
hw/usb-msd.c |8 +++-
hw/usb.c |2 +-
hw/usb.h | 17 +
usb-linux.c |7 +++
4 files c
Add support for splitting large transfers into multiple smaller ones.
This is needed for the upcoming EHCI emulation which allows guests
to submit requests up to 20k in size. The linux kernel allows 16k
max size though.
Roughly based on a patch from git://git.kiszka.org/qemu.git ehci
Signed-off-
usb_msd_copy_data() may cause a recursive call to
usb_msd_command_complete() which in turn may complete
the packet, setting s->packet to NULL in case it does.
Recheck s->packet before calling usb_packet_complete()
to fix the double call.
Signed-off-by: Gerd Hoffmann
---
hw/usb-msd.c |2 +-
1
From: Brad Hards
Previously we relied on the .bNumInterfaces, but that won't always be
accurate after the introduction of grouped interfaces.
Signed-off-by: Brad Hards
Signed-off-by: Gerd Hoffmann
---
hw/usb-hid.c|3 +++
hw/usb-hub.c|1 +
hw/usb-msd.c|2 ++
hw/usb-seri
The device path isn't just a number. It specifies the physical port
the device is connected to and in case the device is connected via
usb hub you'll have two numbers there, like this: "5.1". The first
specifies the root port where the hub is plugged into, the second
specifies the port number of
Add a usb_handle_packet function, put it into use everywhere.
Right now it just calls dev->info->handle_packet(), that will
change in future patches though.
Signed-off-by: Gerd Hoffmann
---
hw/usb-hub.c |2 +-
hw/usb-musb.c |2 +-
hw/usb-ohci.c |4 ++--
hw/usb-uhci.c |2 +-
hw/u
This patch adds code to track all async urbs in a linked list,
so we can find them without having to pass around a opaque
pointer to them. Prerequisite for the cleanups.
Signed-off-by: Gerd Hoffmann
---
usb-linux.c | 18 +++---
1 files changed, 11 insertions(+), 7 deletions(-)
di
From: Jan Vesely
UHCI host controller status register indicates error and
an interrupt is triggered on BABBLE and STALL errors.
Signed-off-by: Jan Vesely
Signed-off-by: Gerd Hoffmann
---
hw/usb-uhci.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/usb-uhci.c b/
This patch adds a hostport property which allows to specify the host usb
devices to pass through by bus number and physical port. This means you
can basically hand over one (or more) of the usb plugs on your host to
the guest and whatever device is plugged in there will show up in the
guest.
Usag
Calculate the max packet size correctly. Only bits 0..11 specify the size,
bits 11+12 specify the number of (highspeed) microframes the endpoint wants
to use.
Signed-off-by: Gerd Hoffmann
---
usb-linux.c | 19 +--
1 files changed, 17 insertions(+), 2 deletions(-)
diff --git a
From: Brad Hards
All callers have been updated.
Signed-off-by: Brad Hards
Signed-off-by: Gerd Hoffmann
---
hw/usb-desc.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/usb-desc.c b/hw/usb-desc.c
index 62591f2..a784155 100644
--- a/hw/usb-desc.c
+++ b/hw/usb-de
Lookup async urbs which are to be canceled using the linked list
instead of the direct opaque pointer. There are two reasons we
are doing that: First, to avoid the opaque poiner to the callback,
which is needed for upcoming cleanups. Second, because we might
need multiple urbs per request for hi
From: Brad Hards
Signed-off-by: Brad Hards
Signed-off-by: Gerd Hoffmann
---
hw/usb.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/usb.h b/hw/usb.h
index 7e46141..ca06bf8 100644
--- a/hw/usb.h
+++ b/hw/usb.h
@@ -124,6 +124,7 @@
#define USB_DT_ENDPOINT
From: Hans de Goede
This allows using the generic usb_generic_handle_packet function from
device code which does ASYNC control requests (such as the linux host
pass through code).
Signed-off-by: Hans de Goede
Signed-off-by: Gerd Hoffmann
---
hw/bt-hid.c |6 +++---
hw/usb-bt.c |
Hi,
Here is the current usb patch queue. Patches 1-9 have been on the list
already, the other ones are new. I plan to send a pull request for this
stuff next week.
The major new feature added is USB 2.0 support: A bunch of fixes and
improvements for the usb passthrough code. The EHCI host a
On Mon, May 16, 2011 at 7:16 PM, Paul Brook wrote:
>> > For changes to
>> > the TCG side we want to consider how we can provide useful aliasing
>> > information, rather than a naive replacement of TCG_AREG0 with a
>> > variable.
>>
>> What aliasing information?
>
> Aliasing of cpu state accesses b
On 05/16/2011 07:17 AM, Paolo Bonzini wrote:
On 05/16/2011 12:07 PM, Juan Quintela wrote:
From two weeks ago, we have already:
- import kvm headers into qemu, drop #ifdef maze (Jan)
SCSI patches merge plan
- libtool usage
Regards,
Anthony Liguori
Paolo
This patch adds a dummy legacy ISA device whose responsibility is to
deploy sgabios, an option rom for a serial graphics adapter.
The proposal is that this device is always-on when -nographics,
but can otherwise be enable in any setup when -device sga is used.
[v2: suggestions on qdev by Markus ]
Paolo Bonzini wrote:
> This fixes it on top of my SCSI refactoring series.
Thanks! Works here, too, for what it's worth.
I squashed the following in when applying the "scsi: introduce
scsi_req_cancel" patch, for easier reading and to get a little closer
to warning-free compilation with gcc 4.6.
Gerd Hoffmann wrote:
Hi,
When enabling the -device usb-host option support for adding
automatically USB devices from the host to the guest, only one device
gets detected.
Yes. -device usb-host creates a *single* virtual usb device instance.
When a matching device on the host is found the vi
On Mon, May 16, 2011 at 06:47:42PM +0100, Peter Maydell wrote:
> On 16 May 2011 18:29, Aurelien Jarno wrote:
> > On Mon, May 16, 2011 at 05:37:03PM +0100, Peter Maydell wrote:
> >> You can do this by calling GETPC() from the top level helper function
> >> though, right? [OK, we'd need to move the
Add monitor command "cache_set" for dynamic cache change
Signed-off-by: Christoph Hellwig
Signed-off-by: Supriya Kannery
---
block.c | 53 +
block.h |2 ++
blockdev.c | 20
blockdev.h |
New errors defined for device insertion and file reopen
Signed-off-by: Supriya Kannery
---
qerror.c |8
qerror.h |6 ++
2 files changed, 14 insertions(+)
Index: qemu/qerror.c
===
--- qemu.orig/qerror.c
+++ qem
Enhance "info block" to display cache setting
Example:
(qemu) info block
ide0-hd0: type=hd removable=0 file=../rhel6-32.qcow2 ro=0 drv=qcow2
encrypted=0
Enhanced to include "cache" setting:
(qemu) info block
ide0-hd0: type=hd removable=0 cache=none file=../rhel6-32.qcow2 ro=0
drv=qcow2 encrypte

Currently cache setting of a block device cannot be changed without
restarting a running VM. Following patchset is for enabling dynamic
change of cache setting for block devices through qemu monitor. Code
changes are based on patches from Christoph Hellwig and Prerna Saxena.
Monitor command
Watch this:
$ qemu-system-x86_64 -nodefaults -enable-kvm -m 384 -vnc :0 -S -netdev
user,id=net0 -device e1000,netdev=net0
Warning: more nics requested than this machine supports; some have been
ignored
(qemu) info network
Devices not on any VLAN:
net0: net=10.0.2.0, restric
On 16 May 2011 18:29, Aurelien Jarno wrote:
> That said given this patch is more or less an extension of an existing
> code, we may want to apply it anyway.
That is the conclusion I'm hoping to persuade you to, yes :-)
-- PMM
On 16 May 2011 18:29, Aurelien Jarno wrote:
> On Mon, May 16, 2011 at 05:37:03PM +0100, Peter Maydell wrote:
>> You can do this by calling GETPC() from the top level helper function
>> though, right? [OK, we'd need to move the definition out of dyngen-exec.h.]
>
> No we don't need to move it out o
On Mon, May 16, 2011 at 10:59:47AM +0100, Peter Maydell wrote:
> On 14 May 2011 22:32, Aurelien Jarno wrote:
> > On Fri, May 06, 2011 at 03:32:27PM +0100, Peter Maydell wrote:
> >> I just spoke with Paul on IRC about this. In summary:
> >> * for a helper to cause an exception then it has (a) to m
On Mon, May 16, 2011 at 05:37:03PM +0100, Peter Maydell wrote:
> On 16 May 2011 17:10, Paul Brook wrote:
> >> > I just spoke with Paul on IRC about this. In summary:
> >> > * for a helper to cause an exception then it has (a) to make sure CPU
> >> >
> >> > state (pc, condflags) is sync'd before t
Hi,
I found a segfault when I use VNC with qemu compiled with
--enable-debug. Without debug mode, that works fine. The segfault
happen usualy when the debian (guest) is ready to be used, or a little
bit after I'm logged in, in console mode.
Here is few detail:
HEAD
711c212 Merge remote-tracking
On 16 May 2011 17:10, Paul Brook wrote:
>> > I just spoke with Paul on IRC about this. In summary:
>> > * for a helper to cause an exception then it has (a) to make sure CPU
>> >
>> > state (pc, condflags) is sync'd before the call to the helper and (b)
>> > the helper has to be in a file with ac
On 05/16/2011 05:58 PM, Kevin Wolf wrote:
> Thanks. Still doesn't make much sense to me, the patch shouldn't change
> anything with respect to a malloc, but I can reproduce a segfault now. I
> think I'll have a closer look tomorrow.
This fixes it on top of my SCSI refactoring series. Should I sen
On 05/15/2011 03:03 PM, Michael S. Tsirkin wrote:
On Sun, May 15, 2011 at 10:20:23PM +0300, Michael S. Tsirkin wrote:
On Sun, May 15, 2011 at 07:14:42PM +0200, Jan Kiszka wrote:
Pity I missed this the first time. Thanks!
Ah, I see, I didn't miss it, just back from vacation and didn't get so
f
> > For changes to
> > the TCG side we want to consider how we can provide useful aliasing
> > information, rather than a naive replacement of TCG_AREG0 with a
> > variable.
>
> What aliasing information?
Aliasing of cpu state accesses between tcg_global_mem_new_* variables,
qemu_ld/st ops, and
> > I just spoke with Paul on IRC about this. In summary:
> > * for a helper to cause an exception then it has (a) to make sure CPU
> >
> > state (pc, condflags) is sync'd before the call to the helper and (b)
> > the helper has to be in a file with access to global env, because it
> > needs to ca
Am 16.05.2011 17:43, schrieb Jonathan Nieder:
> Kevin Wolf wrote:
>
>> Your instructions seemed clear enough, so I tried to reproduce your
>> problem. Now I have an ARM VM with a Debian installation that works just
>> fine and I have no idea what to use it for. ;-)
>
> So I was puzzled about this
Kevin Wolf wrote:
> Your instructions seemed clear enough, so I tried to reproduce your
> problem. Now I have an ARM VM with a Debian installation that works just
> fine and I have no idea what to use it for. ;-)
So I was puzzled about this for a while, but then I had a flash
of inspiration:
Kevin Wolf wrote:
> I also reviewed the patch that you mentioned and I can't find anything
> suspicious there. I'm afraid you'll have to bite the bullet and run it
> with some debugging code yourself (if it's really related to that patch,
> you'll want to enable DPRINTF in hw/scsi-disk.c as a firs
Hi Jonathan,
Am 16.05.2011 13:23, schrieb Jonathan Nieder:
> Hi,
>
> Kevin Wolf wrote:
>
>> This pulls the request completion for error cases from the caller to
>> scsi_disk_emulate_command. This should not change semantics, but allows to
>> reuse scsi_handle_write_error() for flushes in the nex
On Mon, May 16, 2011 at 04:44:03PM +0200, Paolo Bonzini wrote:
> On 05/16/2011 07:37 PM, Alon Levy wrote:
> >I've settled on libtool
> >as the linker solution since it seems to be the de facto standard, please
> >correct me on this point if I'm wrong. We are not using autoconf, so
> >I've called it
On 05/16/2011 07:37 PM, Alon Levy wrote:
I've settled on libtool
as the linker solution since it seems to be the de facto standard, please
correct me on this point if I'm wrong. We are not using autoconf, so
I've called it directly in it's various modes, compile, link and install.
I agree. I d
On Mon, May 16, 2011 at 08:28:49AM -0500, Anthony Liguori wrote:
> On 05/16/2011 08:25 AM, Alon Levy wrote:
> >No flag to configure is required. Instead, added a libcacard.la target that
> >is not built by default, only when requested explicitly via:
> >
> >mkdir build
> >cd build
> >../configure
>
On Mon, May 16, 2011 at 03:59:53PM +0200, Paolo Bonzini wrote:
> On 05/16/2011 03:28 PM, Anthony Liguori wrote:
> >>
> >>
> >> *** Warning: Linking the shared library libcacard.la against the
> >>non-libtool
> >> *** objects ../trace-dtrace.o is not portable!
> >
> >I don't think slipping in lib
The abstract submission deadline was originally set for today.
The forum committee agreed to extend the deadline period until next
Sunday, May 22.
The notification date remains the same (May 31).
Thanks,
your KVM Forum 2011 Program Committee
On 04/21/2011 08:21 PM, kvm-forum-2011...@redhat.
Rob Landley writes:
> On 05/13/2011 07:19 AM, Markus Armbruster wrote:
>> Rob Landley writes:
>>
>>> On 05/13/2011 01:54 AM, Markus Armbruster wrote:
Rob Landley writes:
> On 05/12/2011 09:10 AM, Markus Armbruster wrote:
>> Rob Landley writes:
>>
>>> In 1.14.0, if I
On 05/16/2011 03:28 PM, Anthony Liguori wrote:
*** Warning: Linking the shared library libcacard.la against the
non-libtool
*** objects ../trace-dtrace.o is not portable!
I don't think slipping in libtool like this is such a good idea.
I disagree but, the warning is indeed legitimate,
On 05/16/2011 08:25 AM, Alon Levy wrote:
No flag to configure is required. Instead, added a libcacard.la target that
is not built by default, only when requested explicitly via:
mkdir build
cd build
../configure
make libcacard.la
make install-libcacard
Uses libtool to do actual linking of objec
No flag to configure is required. Instead, added a libcacard.la target that
is not built by default, only when requested explicitly via:
mkdir build
cd build
../configure
make libcacard.la
make install-libcacard
Uses libtool to do actual linking of object files and shared library, and
installing.
On 5/16/11, andrzej zaborowski wrote:
> On 16 May 2011 06:54, Dmitry Eremin-Solenikov wrote:
>> Hello,
>>
>> On 5/16/11, andrzej zaborowski wrote:
>>> On 25 April 2011 11:06, Dmitry Eremin-Solenikov
>>> wrote:
Switch dscm1 microdrive driver to use qdev infrastructure.
---
hw
An "ide-drive" is either a hard disk or a CD-ROM, depending on the
associated BlockDriverState's type hint. Unclean; disk vs. CD belongs
to the guest part, not the host part.
Have separate qdevs "ide-hd" and "ide-cd" to model disk vs. CD in
the guest part.
Keep ide-drive for backward compatibili
This patch series is about purging the "type hint" from the block
layer. My previous series cleaned up improper uses it. Remaining
uses are info block and qdevs ide-drive, scsi-disk.
ide-drive and scsi-disk can either act as disk or as CD drive. They
use their drive's type hint to decide betwee
ide-hd does *not* suppress the default CD-ROM, unlike legacy
ide-drive.
scsi-cd *does* suppress it, unlike legacy scsi-disk.
Signed-off-by: Markus Armbruster
---
vl.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index bffba69..e271c0b 100644
--- a/vl.c
+
A "scsi-disk" is either a hard disk or a CD-ROM, depending on the
associated BlockDriverState's type hint. Unclean; disk vs. CD belongs
to the guest part, not the host part.
Have separate qdevs "scsi-hd" and "scsi-cd" to model disk vs. CD in
the guest part.
Keep scsi-disk for backward compatibil
DriveInfo is closely tied to -drive, and like -drive, it mixes
information about host and guest part of the block device. Unlike
DriveInfo, BlockDriverState should be about the host part only.
One of the remaining guest bits there is the "type hint". -drive
option media sets it, and qdevs "ide-d
query-block's specification documents response member "type" with
values "hd", "cdrom", "floppy", "unknown".
Its value is unreliable: a block device used as floppy has type
"floppy" if created with if=floppy, but type "hd" if created with
if=none.
That's because with if=none, the type is at best
No users of bdrv_get_type_hint() left. bdrv_set_type_hint() can make
the media removable by side effect. Make that explicit.
Signed-off-by: Markus Armbruster
---
block.c | 12
block.h |5 -
block_int.h |1 -
blockdev.c |4 ++--
4 files changed, 2 inserti
QED now supports the truncate (aka resize) operation for growing images.
Update test 025 so it runs for QED.
Signed-off-by: Stefan Hajnoczi
---
025 |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/025 b/025
index 691b6da..7062aa6 100755
--- a/025
+++ b/025
@@ -39,7 +39,7
The .bdrv_truncate() operation resizes images and growing is easy to
implement in QED. Simply check that the new size is valid and then
update the image_size header field to reflect the new size.
Signed-off-by: Stefan Hajnoczi
---
block/qed.c | 22 +-
1 files changed, 21 i
On 16 May 2011 06:54, Dmitry Eremin-Solenikov wrote:
> Hello,
>
> On 5/16/11, andrzej zaborowski wrote:
>> On 25 April 2011 11:06, Dmitry Eremin-Solenikov
>> wrote:
>>> Switch dscm1 microdrive driver to use qdev infrastructure.
>>> ---
>>> hw/ide/microdrive.c | 49
>>>
From: Hannes Reinecke
scsi_req_parse() already provides for a data direction setting,
so we should be using it to check for correct direction.
And we should return the sense code 'INVALID FIELD IN CDB'
in these cases.
Signed-off-by: Hannes Reinecke
Signed-off-by: Paolo Bonzini
---
hw/scsi-dis
From: Hannes Reinecke
The get_sense callback copies existing sense information into
the provided buffer. This is required if sense information
should be transferred together with the command response.
Signed-off-by: Hannes Reinecke
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c |9 +++
Signed-off-by: Paolo Bonzini
---
hw/esp.c | 26 ++
hw/lsi53c895a.c | 22 --
hw/scsi-bus.c| 10 ++
hw/scsi.h|1 +
hw/spapr_vscsi.c | 26 ++
hw/usb-msd.c | 15 ---
trace-ev
The sg driver currently has a hardcoded limit of commands it
can handle simultaneously. When this limit is reached the
driver will return -EDOM. So we need to capture this to
enable proper return values here.
Signed-off-by: Hannes Reinecke
Signed-off-by: Paolo Bonzini
---
hw/scsi-generic.c |
The code for canceling requests upon reset is already the same. Clean
it up and move it to scsi-bus.c.
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c | 12
hw/scsi-disk.c| 18 ++
hw/scsi-generic.c | 18 ++
hw/scsi.h |1 +
4
Move the common part of scsi-disk.c and scsi-generic.c to the SCSI layer.
Signed-off-by: Paolo Bonzini
---
hw/esp.c |2 +-
hw/lsi53c895a.c |2 +-
hw/scsi-bus.c |3 ++-
hw/scsi-disk.c|1 -
hw/scsi-generic.c |1 -
hw/scsi.h |2 +-
hw/spapr_vscsi.c
The return value is unused anyway.
Signed-off-by: Paolo Bonzini
---
hw/scsi-disk.c|6 ++
hw/scsi-generic.c |7 ++-
hw/scsi.h |2 +-
3 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 65744c7..4c7a53e 100644
--- a/
This covers the case of canceling a request's I/O and still
completing it.
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c|9 +
hw/scsi.h|1 +
hw/spapr_vscsi.c |8 ++--
3 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.
This is for when the request must be dropped in the void,
but still memory should be freed. To this end, the devices
register a second callback in SCSIBusOps.
Signed-off-by: Paolo Bonzini
---
hw/esp.c | 16 ++--
hw/lsi53c895a.c | 30 +-
hw/
On 05/16/2011 02:14 PM, Alon Levy wrote:
On Mon, May 16, 2011 at 02:07:55PM +0200, Paolo Bonzini wrote:
On 05/16/2011 02:06 PM, Gerd Hoffmann wrote:
Usually programs that are fully autoconf-iscated will ship a subset of
libtool sources in the tarball, build a custom version at configure
time, a
... and remove some SCSIDevice variables or fields that now become unused.
Signed-off-by: Paolo Bonzini
---
hw/esp.c |2 +-
hw/lsi53c895a.c |2 +-
hw/scsi-bus.c|5 +
hw/scsi.h|1 +
hw/spapr_vscsi.c |8 ++--
hw/usb-msd.c |2 +-
6 files chan
With the next patch, a device may hold SCSIRequest for an indefinite
time. Split a rather big patch, and protect against access errors,
by reference counting them.
There is some ugliness in scsi_send_command implementation due to
the need to unref the request when it fails. This will go away
wit
From: Hannes Reinecke
Currently the SCSIRequest structure is abstracted away and cannot accessed
directly from the driver. This requires the handler to do a lookup on
an abstract 'tag' which identifies the SCSIRequest structure.
With this patch the SCSIRequest structure is exposed to the driver.
Signed-off-by: Paolo Bonzini
---
hw/esp.c | 60 +---
hw/lsi53c895a.c | 48 +++---
hw/scsi-bus.c|4 +-
hw/scsi.h|9 +
hw/spapr_vscsi.c | 101 ++
hw/usb-msd.c
From: Hannes Reinecke
The SCSI spec has a quite detailed list of sense codes available.
It even mandates the use of specific ones for some failure cases.
The current implementation just has one type of generic error
which is actually a violation of the spec in certain cases.
This patch introduces
There are more operations than a SCSI bus can handle, besides completing
commands. One example, which this series will introduce, is cleaning up
after a request is cancelled.
More long term, a "SCSI bus" can represent the LUNs attached to a
target; in this case, while all commands will ultimately
Signed-off-by: Paolo Bonzini
---
hw/esp.c |2 +-
hw/lsi53c895a.c |3 +--
hw/scsi-bus.c|5 +
hw/scsi.h|1 +
hw/spapr_vscsi.c |2 +-
hw/usb-msd.c |2 +-
6 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/hw/esp.c b/hw/esp.c
index 3a6
Signed-off-by: Paolo Bonzini
---
hw/lsi53c895a.c | 63 +-
1 files changed, 38 insertions(+), 25 deletions(-)
diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
index ccea6ad..3b67155 100644
--- a/hw/lsi53c895a.c
+++ b/hw/lsi53c895a.c
@@ -652,38 +
Signed-off-by: Paolo Bonzini
---
hw/scsi-generic.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c
index 5bfbb8a..e1f8a8a 100644
--- a/hw/scsi-generic.c
+++ b/hw/scsi-generic.c
@@ -288,7 +288,6 @@ static int32_t scsi_send_command(
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c |6 ++
trace-events |6 ++
2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index ceeb4ec..0fd85fc 100644
--- a/hw/scsi-bus.c
+++ b/hw/scsi-bus.c
@@ -4,6 +4,7 @@
#include "scsi-defs.h"
#
On 05/16/2011 12:07 PM, Juan Quintela wrote:
From two weeks ago, we have already:
- import kvm headers into qemu, drop #ifdef maze (Jan)
SCSI patches merge plan
Paolo
This abstracts calling the command_complete callback, reducing churn
in the following patches.
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c |6 ++
hw/scsi-disk.c|8
hw/scsi-generic.c |6 +++---
hw/scsi.h |1 +
trace-events |1 +
5 files cha
scsi-generic scsi_read_complete() should not -both- call the client
complete callback with SCSI_REASON_DATA -and- call
scsi_command_complete(). The former will cause the client to queue a
new read or write request, while the later will free the request data
structure, thus causing the new read or
1 - 100 of 123 matches
Mail list logo
