[Qemu-devel] [PATCH] virtio-9p: removexattr on default acl should return 0

2011-04-26 Thread Aneesh Kumar K.V
If we don't have default acl, removexattr on default acl should return 0 Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-posix-acl.c | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/9pfs/virtio-9p-posix-acl.c b/hw/9pfs/virtio-9p-posix-acl.c index e

[Qemu-devel] [PATCH] virtio-9p: Print the pdu details on return

2011-04-26 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index 7c59988..3858e17 100644 --- a/hw/9pfs/virtio-9p.c +++ b/hw/9pfs/virtio-9p.c @@ -596,7 +596,10 @@ static V9fsPDU *all

[Qemu-devel] [PATCH] virtio-9p: move 9p files around

2011-04-26 Thread Aneesh Kumar K.V
Now that we start adding more files related to 9pfs it make sense to move them to a separate directory Signed-off-by: Aneesh Kumar K.V --- Makefile.objs| 10 +++--- Makefile.target |6 -- configure|2 ++ {

[Qemu-devel] Qemu-img convert with -B

2011-04-26 Thread Brad Campbell
G'day all, I see there is a bug raised about the behaviour of qemu-img when used to convert using an output backing file. It allocates every sector whether or not it already exists in the output backing file. I'm walking my way through the block driver to try and get a handle on why this is

Re: [Qemu-devel] [RFC PATCH 0/3 V8] QAPI: add inject-nmi qmp command

2011-04-26 Thread Lai Jiangshan
On 04/26/2011 09:29 PM, Anthony Liguori wrote: > On 04/26/2011 08:26 AM, Luiz Capitulino wrote: >> On Thu, 21 Apr 2011 11:23:54 +0800 >> Lai Jiangshan wrote: >> >>> >>> Hi, Anthony Liguori >>> >>> Any suggestion? >>> >>> Although all command line interfaces will be converted to to use QMP >>> int

Re: [Qemu-devel] Question on qemu build environment.

2011-04-26 Thread Super Bisquit
Those are the current settings. I can run ./configure or vi the file to add the sparc cpu value. I've installed extra sdl bindings/parts.addons from ports. I've enabled gnutls and pcap. Bsd user doesn't work currently for sparc64. I had sent the files earlier. These contain patches from nox (Juer

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix typo in code and comments

2011-04-26 Thread Peter Maydell
On 26 April 2011 18:26, Stefan Weil wrote: > The Oxford dictionary only accepts writable (even when I select > american english). Same result with Merriam-Webster. > Google suggests writable instead of writeable. For what it's worth, the full Oxford English Dictionary has: # writable, adj. # Form

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-26 Thread Igor Kovalenko
On Wed, Apr 27, 2011 at 12:07 AM, Blue Swirl wrote: > On Tue, Apr 26, 2011 at 10:07 PM, Igor Kovalenko > wrote: >> On Tue, Apr 26, 2011 at 10:36 PM, Blue Swirl wrote: >>> On Tue, Apr 26, 2011 at 8:02 PM, Artyom Tarasenko >>> wrote: On Mon, Apr 25, 2011 at 10:29 PM, Aurelien Jarno w

Re: [Qemu-devel] [PATCH] configure: support target dependent linking

2011-04-26 Thread Aurelien Jarno
On Tue, Apr 26, 2011 at 12:24:07AM +0200, Michael Walle wrote: > This patch is the first attempt to make configure more intelligent with > regard to how it links to libraries. It divides the softmmu libraries into > two lists, a general one and a list which depends on the target > architecture. >

Re: [Qemu-devel] KVM call minutes for Apr 26

2011-04-26 Thread Anthony Liguori
On 04/26/2011 11:47 AM, Lucas Meneghel Rodrigues wrote: On Tue, 2011-04-26 at 17:58 +0300, Avi Kivity wrote: On 04/26/2011 05:41 PM, Chris Wright wrote: - having basic common config could be useful Hi Lucas, Could you send your suggested config as a patch to qemu.git? Even better if it was

Re: [Qemu-devel] [PULL] linux-user pending patches

2011-04-26 Thread Aurelien Jarno
On Tue, Apr 26, 2011 at 10:41:07AM +0300, Riku Voipio wrote: > The following changes since commit b0b36e5d2e4c8a96c2f6dbc0981a9fd0cde111d8: > > doc: fix slirp description (2011-04-25 23:10:04 +0200) > > are available in the git repository at: > git://gitorious.org/qemu-maemo/qemu.git linux-us

Re: [Qemu-devel] [PATCH] Fix bug with virtio-9p fsync

2011-04-26 Thread Venkateswararao Jujjuri
On 04/26/2011 09:51 AM, Sassan Panahinejad wrote: v9fs_fsync and possibly others break when asked to operate on a directory. It does not check fid_type to see if it is operating on a directory and therefore accesses the wrong element of the fs union. This error can result in guest applications f

Re: [Qemu-devel] docs/tracing.txt: minor documentation fixes

2011-04-26 Thread Mike D. Day
On 27/04/11 06:46 +1000, Brad Hards wrote: > On Tue, 26 Apr 2011 10:26:01 pm Stefan Hajnoczi wrote: > > -There is a set of static trace events declared in the trace-events source > > +There is a set of static trace events declared in the "trace-events" > > source > Would it read better if it said "

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix typo in code and comments

2011-04-26 Thread Stefan Weil
Am 26.04.2011 19:26, schrieb Stefan Weil: Am 26.04.2011 19:04, schrieb Jan Marten Simons: Am Dienstag 26 April 2011 11:25:58 schrieb Stefan Hajnoczi: On Tue, Apr 26, 2011 at 9:29 AM, Stefan Weil wrote: Replace writeable -> writable Why make this change? writeable and writable are both commo

Re: [Qemu-devel] [PATCH 4/6] docs/tracing.txt: minor documentation fixes

2011-04-26 Thread Brad Hards
On Tue, 26 Apr 2011 10:26:01 pm Stefan Hajnoczi wrote: > -There is a set of static trace events declared in the trace-events source > +There is a set of static trace events declared in the "trace-events" > source Would it read better if it said "There are a set..." (i.e. "are" instead of "is")? B

Re: [Qemu-devel] [PATCH v2] configure: Make epoll_create1 test work around SPARC glibc bug

2011-04-26 Thread Blue Swirl
Thanks, applied. On Tue, Apr 26, 2011 at 6:56 PM, Peter Maydell wrote: > Work around a SPARC glibc bug which caused the epoll_create1 configure > test to wrongly claim that the function was present. Some versions of > SPARC glibc provided the function in the library but didn't declare > it in the

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-26 Thread Blue Swirl
On Tue, Apr 26, 2011 at 10:07 PM, Igor Kovalenko wrote: > On Tue, Apr 26, 2011 at 10:36 PM, Blue Swirl wrote: >> On Tue, Apr 26, 2011 at 8:02 PM, Artyom Tarasenko >> wrote: >>> On Mon, Apr 25, 2011 at 10:29 PM, Aurelien Jarno >>> wrote: On Fri, Apr 22, 2011 at 06:14:06PM +0400, Igor Kova

Re: [Qemu-devel] [PATCH] target-i386: Initialize CPUState::halted in cpu_reset

2011-04-26 Thread Blue Swirl
On Tue, Apr 26, 2011 at 9:55 PM, Jan Kiszka wrote: > On 2011-04-26 20:00, Blue Swirl wrote: >> On Tue, Apr 26, 2011 at 11:50 AM, Jan Kiszka wrote: >>> Instead of having an extra reset function at machine level and special >>> code for processing INIT, move the initialization of halted into the >>

Re: [Qemu-devel] is it just me or is ne2k broken in qemu?

2011-04-26 Thread Luiz Capitulino
On Sun, 17 Apr 2011 00:37:35 +0400 Michael Tokarev wrote: > 15.04.2011 18:17, Alex Williamson wrote: > > On Thu, 2011-04-14 at 12:31 +0400, Michael Tokarev wrote: > > >> The NIC works for a while, but after a few packets, > >> or a few 1000s of packets, it stalls. In tcpdump > >> on the host I

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-26 Thread Igor Kovalenko
On Tue, Apr 26, 2011 at 10:36 PM, Blue Swirl wrote: > On Tue, Apr 26, 2011 at 8:02 PM, Artyom Tarasenko wrote: >> On Mon, Apr 25, 2011 at 10:29 PM, Aurelien Jarno >> wrote: >>> On Fri, Apr 22, 2011 at 06:14:06PM +0400, Igor Kovalenko wrote: On Fri, Apr 22, 2011 at 2:39 AM, Laurent Desnogue

Re: [Qemu-devel] [PATCH] target-i386: Initialize CPUState::halted in cpu_reset

2011-04-26 Thread Jan Kiszka
On 2011-04-26 20:00, Blue Swirl wrote: > On Tue, Apr 26, 2011 at 11:50 AM, Jan Kiszka wrote: >> Instead of having an extra reset function at machine level and special >> code for processing INIT, move the initialization of halted into the >> cpu reset handler. > > Nack. A CPU is designated as a B

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-26 Thread Blue Swirl
On Tue, Apr 26, 2011 at 8:02 PM, Artyom Tarasenko wrote: > On Mon, Apr 25, 2011 at 10:29 PM, Aurelien Jarno wrote: >> On Fri, Apr 22, 2011 at 06:14:06PM +0400, Igor Kovalenko wrote: >>> On Fri, Apr 22, 2011 at 2:39 AM, Laurent Desnogues >>> wrote: >>> > On Thu, Apr 21, 2011 at 9:45 PM, Igor Kova

Re: [Qemu-devel] Question on qemu build environment.

2011-04-26 Thread Blue Swirl
On Tue, Apr 26, 2011 at 4:23 PM, Super Bisquit wrote: > I have noticed that qemu does not fully function on FreeBSD sparc64. > Besides n...@freebsd.org and myself, has anyone tried building and > running qemu under FreeBSD sparc64? I think you are the first to report. On OpenBSD/Sparc64 I could r

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-26 Thread Igor Kovalenko
On Tue, Apr 26, 2011 at 8:26 PM, Artyom Tarasenko wrote: > On Tue, Apr 26, 2011 at 5:34 AM, Igor Kovalenko > wrote: >> On Tue, Apr 26, 2011 at 12:29 AM, Aurelien Jarno >> wrote: >>> On Fri, Apr 22, 2011 at 06:14:06PM +0400, Igor Kovalenko wrote: On Fri, Apr 22, 2011 at 2:39 AM, Laurent Des

Re: [Qemu-devel] [PATCH] target-i386: Initialize CPUState::halted in cpu_reset

2011-04-26 Thread Blue Swirl
On Tue, Apr 26, 2011 at 11:50 AM, Jan Kiszka wrote: > Instead of having an extra reset function at machine level and special > code for processing INIT, move the initialization of halted into the > cpu reset handler. Nack. A CPU is designated as a BSP at board level. CPUs do not need to know abou

Re: [Qemu-devel] KVM call minutes for Apr 26

2011-04-26 Thread Lucas Meneghel Rodrigues
On Tue, 2011-04-26 at 17:58 +0300, Avi Kivity wrote: > On 04/26/2011 05:41 PM, Chris Wright wrote: > > - having basic common config could be useful > > > > My config is: > --- > include tests_base.cfg > include cdkeys.cfg > > image_name(_.*)? ?<= images/ > cdro

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix typo in code and comments

2011-04-26 Thread Stefan Weil
Am 26.04.2011 19:04, schrieb Jan Marten Simons: Am Dienstag 26 April 2011 11:25:58 schrieb Stefan Hajnoczi: On Tue, Apr 26, 2011 at 9:29 AM, Stefan Weil wrote: Replace writeable -> writable Why make this change? writeable and writable are both commonly used spellings. It seems like "writea

[Qemu-devel] [PATCH] target-arm: Don't update base register on abort in Thumb T1 LDM

2011-04-26 Thread Peter Maydell
Make sure the base register isn't updated if it is in the load list for a Thumb LDM (T1 encoding) which aborts partway through the load. Signed-off-by: Peter Maydell --- target-arm/translate.c | 17 ++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/target-arm/tr

Re: [Qemu-devel] [PATCH] target-arm: fix LDMIA bug on page boundary

2011-04-26 Thread Peter Maydell
On 25 April 2011 02:23, YuYeon Oh wrote: > target-arm: fix LDMIA bug on page boundary (You don't need to repeat the Subject summary line in the body, it makes the git changelog look a bit odd when the patch is applied with 'git am'). > When consecutive memory locations are on page boundary, a ba

Re: [Qemu-devel] [PATCH] lsi53c895a: add support for ABORT messages

2011-04-26 Thread Michael Tokarev
26.04.2011 18:46, Peter Lieven wrote: [] > i recently saw some qemu-kvm 0.12.5 guests with scsi and this patch > applies crashing when > we updated our backend iscsi storages. (short interrupt in traffic flow, > iscsi disconnect + reconnect) > > i always see: > lsi_scsi: error: ORDERED queue not i

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix typo in code and comments

2011-04-26 Thread Jan Marten Simons
Am Dienstag 26 April 2011 11:25:58 schrieb Stefan Hajnoczi: > On Tue, Apr 26, 2011 at 9:29 AM, Stefan Weil wrote: > > Replace writeable -> writable > > Why make this change? writeable and writable are both commonly used > spellings. It seems like "writeable" is the commonly used term in compute

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-26 Thread Artyom Tarasenko
On Mon, Apr 25, 2011 at 10:29 PM, Aurelien Jarno wrote: > On Fri, Apr 22, 2011 at 06:14:06PM +0400, Igor Kovalenko wrote: >> On Fri, Apr 22, 2011 at 2:39 AM, Laurent Desnogues >> wrote: >> > On Thu, Apr 21, 2011 at 9:45 PM, Igor Kovalenko >> > wrote: >> >> On Thu, Apr 21, 2011 at 7:44 PM, Lauren

[Qemu-devel] [PATCH] Fix bug with virtio-9p fsync

2011-04-26 Thread Sassan Panahinejad
v9fs_fsync and possibly others break when asked to operate on a directory. It does not check fid_type to see if it is operating on a directory and therefore accesses the wrong element of the fs union. This error can result in guest applications failing (in my case it was dpkg). This patch fixes th

Re: [Qemu-devel] [PATCH 12/18] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c.

2011-04-26 Thread 大村 圭
2011/4/25 Jan Kiszka : > On 2011-04-25 13:00, OHMURA Kei wrote: >> From: Yoshiaki Tamura >> >> Record mmio write event to replay it upon failover. >> >> Signed-off-by: Yoshiaki Tamura >> Signed-off-by: OHMURA Kei >> --- >>  exec.c |    4 >>  1 files changed, 4 insertions(+), 0 deletions(-)

Re: [Qemu-devel] Supporting emulation of IOMMUs

2011-04-26 Thread Joerg Roedel
Hello David, On Thu, Apr 21, 2011 at 03:03:47AM -0400, David Gibson wrote: > A few months ago, Eduard - Gabriel Munteanu posted a series of patches > implementing support for emulating the AMD PCI IOMMU > (http://lists.nongnu.org/archive/html/qemu-devel/2011-01/msg03196.html). > > In fact, this s

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-26 Thread Artyom Tarasenko
On Tue, Apr 26, 2011 at 5:34 AM, Igor Kovalenko wrote: > On Tue, Apr 26, 2011 at 12:29 AM, Aurelien Jarno wrote: >> On Fri, Apr 22, 2011 at 06:14:06PM +0400, Igor Kovalenko wrote: >>> On Fri, Apr 22, 2011 at 2:39 AM, Laurent Desnogues >>> wrote: >>> > On Thu, Apr 21, 2011 at 9:45 PM, Igor Kovale

[Qemu-devel] [PATCH v2] configure: Make epoll_create1 test work around SPARC glibc bug

2011-04-26 Thread Peter Maydell
Work around a SPARC glibc bug which caused the epoll_create1 configure test to wrongly claim that the function was present. Some versions of SPARC glibc provided the function in the library but didn't declare it in the include file; the result is that gcc warns about an implicit declaration but a l

Re: [Qemu-devel] KVM call minutes for Apr 26

2011-04-26 Thread Avi Kivity
On 04/26/2011 05:41 PM, Chris Wright wrote: - having basic common config could be useful My config is: --- include tests_base.cfg include cdkeys.cfg image_name(_.*)? ?<= images/ cdrom(_.*)? ?<= isos/ drive_cache=unsafe extra_params = -enable-kvm variants:

Re: [Qemu-devel] [PATCH 12/18] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c.

2011-04-26 Thread Jan Kiszka
On 2011-04-26 16:24, "大村 圭" wrote: > > 2011/4/25 Jan Kiszka : >> On 2011-04-25 13:00, OHMURA Kei wrote: >>> From: Yoshiaki Tamura >>> >>> Record mmio write event to replay it upon failover. >>> >>> Signed-off-by: Yoshiaki Tamura >>> Signed-off-by: OHMURA Kei >>> --- >>> exec.c |4 >>>

[Qemu-devel] [PATCH] Add QMP fsfreeze support

2011-04-26 Thread Jes . Sorensen
From: Jes Sorensen This patch adds the following QMP commands: qga-guest-fsfreeze: - Freezes all local file systems in the guest. Command will return the number of file systems that were frozen. qga-guest-fsthaw: - Thaws all local file systems in the guest. Command will return the number

[Qemu-devel] [Bug 741887] Re: virsh snapshot-create too slow (kvm, qcow2, savevm)

2011-04-26 Thread Serge Hallyn
@edison, if you want to push such a patch, please do it through upstream, since it is actually a new feature. I'm going to mark this 'wontfix' (as I thought I had done before), rather than invalid, though the latter still sounds accurate as well. ** Changed in: qemu-kvm (Ubuntu) Status: C

Re: [Qemu-devel] [PATCH] lsi53c895a: add support for ABORT messages

2011-04-26 Thread Peter Lieven
On 09.03.2011 10:25, Bernhard Kohl wrote: Am 09.03.2011 09:47, schrieb ext Kevin Wolf: Am 09.03.2011 00:04, schrieb Peter Lieven: Am 07.10.2010 um 13:27 schrieb Kevin Wolf: Am 06.09.2010 16:42, schrieb Bernhard Kohl: If these messages are not handled correctly the guest driver may hang. Al

[Qemu-devel] KVM call minutes for Apr 26

2011-04-26 Thread Chris Wright
Tools for resource accounting the virtual machines. - Luis Castro was not on the call Status of glib tree - next steps? - full conversion done in tree - still targeting 0.15 status of QCFG - code generator rewritten to be more generic and useful - merge core infrastructure first - to not block

Re: [Qemu-devel] [RFC][PATCH v2 09/17] qmp proxy: core code for proxying qmp requests to guest

2011-04-26 Thread Michael Roth
On 04/26/2011 08:21 AM, Stefan Hajnoczi wrote: On Mon, Apr 18, 2011 at 4:02 PM, Michael Roth wrote: +static int qmp_proxy_cancel_request(QmpProxy *p, QmpProxyRequest *r) +{ +if (r&& r->cb) { +r->cb(r->opaque, NULL, NULL); +} + +return 0; +} + +static int qmp_proxy_cancel_al

Re: [Qemu-devel] [PATCH] [trivial] fix "-virtfs ?" help to match reality

2011-04-26 Thread Venkateswararao Jujjuri
On 04/26/2011 06:15 AM, Michael Tokarev wrote: The correct option is mount_tag, while helpt text says mnt_tag. Addresses Debian #623858. Signed-off-by: Michael Tokarev Reviewed-by: Venkateswararao Jujjuri(JV) --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [Qemu-devel] [RFC][PATCH v2 00/11] QEMU Guest Agent: QMP-based host/guest communication (virtagent)

2011-04-26 Thread Jes Sorensen
On 04/26/11 16:27, Michael Roth wrote: > On 04/26/2011 01:57 AM, Jes Sorensen wrote: >> Yeah it was the conclusion I came to on Thursday when I was working on >> porting the freeze patches over. After fighting the json %#$%#$%#$ I >> ended up with something I couldn't test in the end :( > > I actu

Re: [Qemu-devel] [RFC][PATCH v2 00/11] QEMU Guest Agent: QMP-based host/guest communication (virtagent)

2011-04-26 Thread Michael Roth
On 04/26/2011 01:57 AM, Jes Sorensen wrote: On 04/21/11 22:58, Michael Roth wrote: On 04/21/2011 09:10 AM, Jes Sorensen wrote: On 04/18/11 17:02, Michael Roth wrote: One thing I cannot seem to figure out with this tree - the agent commands do not seem to show up in the monitor? What am I missin

Re: [Qemu-devel] [PATCH] Fix bug with virtio-9p fsync

2011-04-26 Thread Venkateswararao Jujjuri
On 04/26/2011 06:29 AM, Sassan Panahinejad wrote: I will have to study XATTR and see how that will be affected. I don't know whether it is possible for these functions to be called for XATTR, and if it is then I do not know the proper way to handle it. Perhaps we should have some function or mac

Re: [Qemu-devel] KVM call agenda for April 26th

2011-04-26 Thread Jes Sorensen
On 04/26/11 15:09, Anthony Liguori wrote: > On 04/26/2011 06:47 AM, Jes Sorensen wrote: >> On 04/26/11 11:24, Juan Quintela wrote: >>> >>> Please, send in any agenda items you are interested in covering. >>> >>> From last week: >>> Tools for resource accounting the virtual machines. >>>

Re: [Qemu-devel] [PATCH v2 10/11] trace-state: [stderr] add support for dynamically enabling/disabling events

2011-04-26 Thread Lluís
Stefan Hajnoczi writes: > On Tue, Apr 26, 2011 at 1:30 PM, Fabien Chouteau wrote: >> On 04/25/2011 08:10 PM, Paolo Bonzini wrote: >>> On 04/25/2011 12:27 PM, Lluís wrote: But in any case, I'm still not sure if stderr should have programatic tracing state controls. >>> >>> Yes, please,

Re: [Qemu-devel] [RFC][PATCH v2 15/17] guest agent: qemu-ga daemon

2011-04-26 Thread Jes Sorensen
On 04/25/11 14:27, Ian Molton wrote: > On Fri, 2011-04-22 at 13:51 +0200, Jes Sorensen wrote: >> Hiding things you miss when reading the code, it's a classic for >> people to do if(foo) bleh(); on the same line, and whoever reads >> the code will expect the action on the next line, especially if f

Re: [Qemu-devel] [PATCH v2] vl.c: Replace -virtfs string manipulation with QemuOpts

2011-04-26 Thread Stefan Hajnoczi
On Wed, Mar 16, 2011 at 8:31 AM, Stefan Hajnoczi wrote: > The -virtfs option creates an fsdev representing the pass-through file > system and a guest-visible virtio-9p-pci device that can access this > file system.  This patch replaces the string manipulation used to build > and reparse option lis

Re: [Qemu-devel] [RFC PATCH 0/3 V8] QAPI: add inject-nmi qmp command

2011-04-26 Thread Anthony Liguori
On 04/26/2011 08:26 AM, Luiz Capitulino wrote: On Thu, 21 Apr 2011 11:23:54 +0800 Lai Jiangshan wrote: Hi, Anthony Liguori Any suggestion? Although all command line interfaces will be converted to to use QMP interfaces in 0.16, I hope inject-nmi come into QAPI earlier, 0.15. I don't know

Re: [Qemu-devel] [PATCH] Fix bug with virtio-9p fsync

2011-04-26 Thread Sassan Panahinejad
On 26 April 2011 13:58, Stefan Hajnoczi wrote: > What about P9_FID_XATTR, seems like we have the same issue there too? > > wstat, lock, and getlock need closer auditing and perhaps fixing. > > Stefan > Sorry, forgot to hit reply-to-all. Yes, it is probable that those functions will suffer from

Re: [Qemu-devel] [RFC PATCH 0/3 V8] QAPI: add inject-nmi qmp command

2011-04-26 Thread Luiz Capitulino
On Thu, 21 Apr 2011 11:23:54 +0800 Lai Jiangshan wrote: > > Hi, Anthony Liguori > > Any suggestion? > > Although all command line interfaces will be converted to to use QMP > interfaces in 0.16, > I hope inject-nmi come into QAPI earlier, 0.15. I don't know what Anthony thinks about adding n

[Qemu-devel] Question on qemu build environment.

2011-04-26 Thread Super Bisquit
I have noticed that qemu does not fully function on FreeBSD sparc64. Besides n...@freebsd.org and myself, has anyone tried building and running qemu under FreeBSD sparc64?

Re: [Qemu-devel] [RFC][PATCH v2 09/17] qmp proxy: core code for proxying qmp requests to guest

2011-04-26 Thread Stefan Hajnoczi
On Mon, Apr 18, 2011 at 4:02 PM, Michael Roth wrote: > +static int qmp_proxy_cancel_request(QmpProxy *p, QmpProxyRequest *r) > +{ > +    if (r && r->cb) { > +        r->cb(r->opaque, NULL, NULL); > +    } > + > +    return 0; > +} > + > +static int qmp_proxy_cancel_all(QmpProxy *p) > +{ > +    Qmp

Re: [Qemu-devel] [PULL 0/6] Tracing patches

2011-04-26 Thread Anthony Liguori
On 04/26/2011 07:25 AM, Stefan Hajnoczi wrote: The following changes since commit b0b36e5d2e4c8a96c2f6dbc0981a9fd0cde111d8: doc: fix slirp description (2011-04-25 23:10:04 +0200) are available in the git repository at: git://repo.or.cz/qemu/stefanha.git tracing Pulled. Thanks. Regards

Re: [Qemu-devel] [PULL] Trivial patches

2011-04-26 Thread Anthony Liguori
On 04/26/2011 07:29 AM, Stefan Hajnoczi wrote: Only one patch but I want to keep them flowing regularly. The following changes since commit b0b36e5d2e4c8a96c2f6dbc0981a9fd0cde111d8: doc: fix slirp description (2011-04-25 23:10:04 +0200) are available in the git repository at: git://repo.

[Qemu-devel] [PATCH] [trivial] fix "-virtfs ?" help to match reality

2011-04-26 Thread Michael Tokarev
The correct option is mount_tag, while helpt text says mnt_tag. Addresses Debian #623858. Signed-off-by: Michael Tokarev --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 68c3b53..d141a16 100644 --- a/vl.c +++ b/vl.c @@ -2468,7 +2468,7 @@ int ma

Re: [Qemu-devel] QEMU: Discussion of separating core functionality vs supportive features

2011-04-26 Thread Anthony Liguori
On 04/26/2011 04:14 AM, Gerd Hoffmann wrote: Hi, I think that would work well for spice. Spice uses shared memory from the pci device for both the framebuffer and surfaces/commands, but this is Is that the only DMA do you do? That's good for this model. Yes. Spice does both reads and writes

Re: [Qemu-devel] KVM call agenda for April 26th

2011-04-26 Thread Anthony Liguori
On 04/26/2011 07:55 AM, Jan Kiszka wrote: On 2011-04-26 11:24, Juan Quintela wrote: Please, send in any agenda items you are interested in covering. From last week: Tools for resource accounting the virtual machines. Luis Antonio Galindo Castro (FunkyM0nk3y) - status of QCFG (

Re: [Qemu-devel] KVM call agenda for April 26th

2011-04-26 Thread Anthony Liguori
On 04/26/2011 06:47 AM, Jes Sorensen wrote: On 04/26/11 11:24, Juan Quintela wrote: Please, send in any agenda items you are interested in covering. From last week: Tools for resource accounting the virtual machines. Luis Antonio Galindo Castro (FunkyM0nk3y) - Status of glib tree

Re: [Qemu-devel] [PATCH] ioapic: Do not set irr for masked edge IRQs

2011-04-26 Thread Jan Kiszka
On 2011-04-09 13:18, Jan Kiszka wrote: > From: Jan Kiszka > > So far we set IRR for edge IRQs even if the pin is masked. If the guest > later on unmasks and switches the pin to level-triggered mode, irr will > remain set, causing an IRQ storm. The point is that setting IRR is not > correct in thi

Re: [Qemu-devel] [PATCH v2 10/11] trace-state: [stderr] add support for dynamically enabling/disabling events

2011-04-26 Thread Paolo Bonzini
On 04/26/2011 02:38 PM, Stefan Hajnoczi wrote: The simple backend additionally allows setting and flushing the output file. It also supports dumping the trace buffer. I agree that neither of these would be a particularly interesting addition to the stderr backend. Paolo

Re: [Qemu-devel] [PATCH] Fix bug with virtio-9p fsync

2011-04-26 Thread Stefan Hajnoczi
On Tue, Apr 26, 2011 at 1:14 PM, Sassan Panahinejad wrote: > v9fs_fsync and possibly others break when asked to operate on a directory. > It does not check fid_type to see if it is operating on a directory and > therefore accesses the wrong element of the fs union. > This error can result in gues

[Qemu-devel] Qemu 0.14.1 last call for stable patches

2011-04-26 Thread Justin M. Forbes
It has come time to do the 0.14.1 stable release. If there are any patches which should make this release, please send them along. Remember, to be included, they need to be in the development tree already, and bug fixes only. I will cherry pick as appropriate. Thanks, Justin

Re: [Qemu-devel] KVM call agenda for April 26th

2011-04-26 Thread Jan Kiszka
On 2011-04-26 11:24, Juan Quintela wrote: > > Please, send in any agenda items you are interested in covering. > > From last week: >Tools for resource accounting the virtual machines. > Luis Antonio Galindo Castro (FunkyM0nk3y) > - status of QCFG (would be nice-to-have for building

Re: [Qemu-devel] [PATCH v2 10/11] trace-state: [stderr] add support for dynamically enabling/disabling events

2011-04-26 Thread Stefan Hajnoczi
On Tue, Apr 26, 2011 at 1:30 PM, Fabien Chouteau wrote: > On 04/25/2011 08:10 PM, Paolo Bonzini wrote: >> On 04/25/2011 12:27 PM, Lluís wrote: >>> But in any case, I'm still not sure if stderr should have programatic >>> tracing state controls. >> >> Yes, please, stderr is even more useful than si

Re: [Qemu-devel] [PATCH v2 10/11] trace-state: [stderr] add support for dynamically enabling/disabling events

2011-04-26 Thread Fabien Chouteau
On 04/25/2011 08:10 PM, Paolo Bonzini wrote: > On 04/25/2011 12:27 PM, Lluís wrote: >> But in any case, I'm still not sure if stderr should have programatic >> tracing state controls. > > Yes, please, stderr is even more useful than simple when you're using it > under gdb. Agreed, trace control

[Qemu-devel] [PATCH] vl: trivial spelling fix

2011-04-26 Thread Stefan Hajnoczi
From: Brad Hards Signed-off-by: Brad Hards Signed-off-by: Stefan Hajnoczi --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 68c3b53..b46ee66 100644 --- a/vl.c +++ b/vl.c @@ -756,7 +756,7 @@ void add_boot_device_path(int32_t bootindex, DeviceSt

[Qemu-devel] [PULL] Trivial patches

2011-04-26 Thread Stefan Hajnoczi
Only one patch but I want to keep them flowing regularly. The following changes since commit b0b36e5d2e4c8a96c2f6dbc0981a9fd0cde111d8: doc: fix slirp description (2011-04-25 23:10:04 +0200) are available in the git repository at: git://repo.or.cz/qemu/stefanha.git trivial-patches Brad Hards

[Qemu-devel] [PATCH 3/6] docs: Trace events must not expect pointer dereferencing

2011-04-26 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- docs/tracing.txt |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/docs/tracing.txt b/docs/tracing.txt index f15069c..905a083 100644 --- a/docs/tracing.txt +++ b/docs/tracing.txt @@ -69,6 +69,11 @@ Trace events should use types as foll

[Qemu-devel] [PATCH 2/6] trace: Remove %s in grlib trace events

2011-04-26 Thread Stefan Hajnoczi
Trace events cannot use %s in their format strings because trace backends vary in how they can deference pointers (if at all). Recording const char * values is not meaningful if their contents are not recorded too. Change grlib trace events that rely on strings so that they communicate similar in

[Qemu-devel] [PATCH 5/6] trace: [ust] fix generation of 'trace.c' on events without args

2011-04-26 Thread Stefan Hajnoczi
From: Lluís Signed-off-by: Lluís Vilanova Signed-off-by: Stefan Hajnoczi --- scripts/tracetool |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/scripts/tracetool b/scripts/tracetool index 9912f36..2155a57 100755 --- a/scripts/tracetool +++ b/scripts/tracetool @@ -

[Qemu-devel] [PATCH 4/6] docs/tracing.txt: minor documentation fixes

2011-04-26 Thread Stefan Hajnoczi
From: Lluís Signed-off-by: Lluís Vilanova Signed-off-by: Stefan Hajnoczi --- docs/tracing.txt | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/docs/tracing.txt b/docs/tracing.txt index 905a083..c99a0f2 100644 --- a/docs/tracing.txt +++ b/docs/tracing.tx

[Qemu-devel] [PULL 0/6] Tracing patches

2011-04-26 Thread Stefan Hajnoczi
The following changes since commit b0b36e5d2e4c8a96c2f6dbc0981a9fd0cde111d8: doc: fix slirp description (2011-04-25 23:10:04 +0200) are available in the git repository at: git://repo.or.cz/qemu/stefanha.git tracing Lluís (3): docs/tracing.txt: minor documentation fixes trace: [us

[Qemu-devel] [PATCH 1/6] tracetool: allow ) in trace output string

2011-04-26 Thread Stefan Hajnoczi
From: Paolo Bonzini Be greedy in matching the trailing "\)*" pattern. Otherwise, all the text in the trace string up to the last closed parenthesis is taken as part of the prototype. Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- scripts/tracetool |2 +- 1 files changed,

[Qemu-devel] [PATCH 6/6] trace: [trace-events] fix print formats in some events

2011-04-26 Thread Stefan Hajnoczi
From: Lluís Signed-off-by: Lluís Vilanova Signed-off-by: Stefan Hajnoczi --- trace-events |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/trace-events b/trace-events index 8272c86..77c96a5 100644 --- a/trace-events +++ b/trace-events @@ -254,8 +254,8 @@ disable leon

[Qemu-devel] [PATCH] Fix bug with virtio-9p fsync

2011-04-26 Thread Sassan Panahinejad
v9fs_fsync and possibly others break when asked to operate on a directory. It does not check fid_type to see if it is operating on a directory and therefore accesses the wrong element of the fs union. This error can result in guest applications failing (in my case it was dpkg). This patch fixes th

Re: [Qemu-devel] KVM call agenda for April 26th

2011-04-26 Thread Jes Sorensen
On 04/26/11 11:24, Juan Quintela wrote: > > Please, send in any agenda items you are interested in covering. > > From last week: >Tools for resource accounting the virtual machines. > Luis Antonio Galindo Castro (FunkyM0nk3y) > - Status of glib tree - next steps? Jes

[Qemu-devel] [PATCH] virtio: Move virtio-pci to hw library

2011-04-26 Thread Jan Kiszka
This module has no target dependencies (except for target_phys_addr_t size) and can thus be built as part of libhw. Signed-off-by: Jan Kiszka --- Makefile.objs |1 + Makefile.target |1 - 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index

Re: [Qemu-devel] pSeries build breakage

2011-04-26 Thread David Gibson
On Mon, Apr 25, 2011 at 06:42:25PM +0200, Andreas Färber wrote: > Hello, > > Building QEMU HEAD (347ac8e35661eff1c2b5ec74d11ee152f2a61856 target- > i386: switch to softfloat) on OSX/ppc64 results in: > > [...] > LINK arm-softmmu/qemu-system-arm > make: *** pc-bios/spapr-rtas: No such file or d

Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

2011-04-26 Thread Aurelien Jarno
On Mon, Apr 25, 2011 at 11:35:54PM +0100, Peter Maydell wrote: > On 25 April 2011 23:31, Aurelien Jarno wrote: > > On Mon, Apr 25, 2011 at 10:59:52PM +0100, Peter Maydell wrote: > >> On 25 April 2011 22:09, Aurelien Jarno wrote: > >> > Instead of having this complex test for all cp15 access, but

[Qemu-devel] [PATCH] char: Allow devices to use a single multiplexed chardev.

2011-04-26 Thread Kusanagi Kouichi
This fixes regression caused by commit 2d6c1ef40f3678ab47a4d14fb5dadaa486bfcda6 ("char: Prevent multiple devices opening same chardev"). -nodefaults -nographic -chardev stdio,id=stdio,mux=on,signal=off -mon stdio -device virtio-serial-pci -device virtconsole,chardev=stdio -device isa-serial,chard

Re: [Qemu-devel] [PATCH] net: add drop_packets parameter to -net nic

2011-04-26 Thread Nguyen Thai Ngoc Duy
On Tue, Apr 26, 2011 at 4:14 PM, Stefan Hajnoczi wrote: > The behavior you are describing sounds like a bug in QEMU's network > layer.  If RX is disabled we should not queue incoming packets. > > Have you looked into fixing QEMU so that the queue is disabled when RX > is disabled? it's in e1000_c

Re: [Qemu-devel] [PATCH v2 01/11] minor whitespace/indentation fixes

2011-04-26 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Wed, Apr 6, 2011 at 7:33 PM, Lluís wrote: >> Signed-off-by: Lluís Vilanova >> --- >>  configure       |   30 +- >>  hmp-commands.hx |   28 >>  monitor.c       |   14 ++-- >>  vl.c            |   64 >> +++

[Qemu-devel] [PATCH] handle bind(), listen() race

2011-04-26 Thread Simon Rowe
Hello, we've seen a very occasional failure in the startup of qemu where the call to inet_listen() for the VNC port fails with EADDRINUSE. I believe there is a race condition when two qemu processes both bind to the same port, in one the subsequent call to listen() will succeed and the other fa

Re: [Qemu-devel] [PATCH] qed: Fix consistency check on 32-bit hosts

2011-04-26 Thread Stefan Hajnoczi
On Tue, Apr 26, 2011 at 9:44 AM, Kevin Wolf wrote: > Am 24.04.2011 19:38, schrieb Stefan Hajnoczi: >> The qed_bytes_to_clusters() function is normally used with size_t >> lengths.  Consistency check used it with file size length and therefore >> failed on 32-bit hosts when the image file is 4 GB o

Re: [Qemu-devel] kvm crashes with spice while loading qxl

2011-04-26 Thread Gerd Hoffmann
On 04/26/11 11:06, Jan Kiszka wrote: On 2011-04-26 10:53, Gerd Hoffmann wrote: Two general issues with dropping the global mutex like this: - The caller of mutex_unlock is responsible for maintaining cpu_single_env across the unlocked phase (that's related to the abort above). Thi

Re: [Qemu-devel] kvm crashes with spice while loading qxl

2011-04-26 Thread Alon Levy
On Tue, Apr 26, 2011 at 10:53:04AM +0200, Gerd Hoffmann wrote: > Hi, > > [ ... back online now ... ] > > >>/var/tmp/portage/app-emulation/qemu-kvm-0.14.0/work/qemu-kvm-0.14.0/qemu-kvm.c:1724: > >>kvm_mutex_unlock: Assertion `!cpu_single_env' failed. > > >That's a spice bug. In fact, there are

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix typo in code and comments

2011-04-26 Thread Stefan Hajnoczi
On Tue, Apr 26, 2011 at 9:29 AM, Stefan Weil wrote: > Replace writeable -> writable Why make this change? writeable and writable are both commonly used spellings. Stefan

[Qemu-devel] KVM call agenda for April 26th

2011-04-26 Thread Juan Quintela
Please, send in any agenda items you are interested in covering. >From last week: Tools for resource accounting the virtual machines. Luis Antonio Galindo Castro (FunkyM0nk3y) Later, Juan.

Re: [Qemu-devel] [PATCH] net: add drop_packets parameter to -net nic

2011-04-26 Thread Stefan Hajnoczi
On Mon, Apr 25, 2011 at 3:06 PM, Nguyen Thai Ngoc Duy wrote: > 2011/4/25 Stefan Hajnoczi : >> 2011/4/25 Nguyễn Thái Ngọc Duy : >>> Dropping packets is sometimes perferred behavior. Add drop_packets >>> parameter to NICConf struct and let nic simulation decide how to use >>> it. >>> >>> Only e1000

Re: [Qemu-devel] [PATCH] Fix bug with virtio-9p fsync

2011-04-26 Thread Stefan Hajnoczi
On Mon, Apr 25, 2011 at 6:54 PM, Sassan Panahinejad wrote: Thanks for finding and fixing this. Please see this wiki page on contributing patches to QEMU: http://wiki.qemu.org/Contribute/SubmitAPatch > v9fs_fsync and possibly others break when asked to operate on a directory. > It does not check

Re: [Qemu-devel] QEMU: Discussion of separating core functionality vs supportive features

2011-04-26 Thread Gerd Hoffmann
Hi, I think that would work well for spice. Spice uses shared memory from the pci device for both the framebuffer and surfaces/commands, but this is Is that the only DMA do you do? That's good for this model. Yes. Spice does both reads and writes though, so a way to tag pages as dirty is

Re: [Qemu-devel] kvm crashes with spice while loading qxl

2011-04-26 Thread Jan Kiszka
On 2011-04-26 10:53, Gerd Hoffmann wrote: > Hi, > > [ ... back online now ... ] > >>> /var/tmp/portage/app-emulation/qemu-kvm-0.14.0/work/qemu-kvm-0.14.0/qemu-kvm.c:1724: >>> >>> kvm_mutex_unlock: Assertion `!cpu_single_env' failed. > >> That's a spice bug. In fact, there are a lot of >> qemu_

Re: [Qemu-devel] kvm crashes with spice while loading qxl

2011-04-26 Thread Gerd Hoffmann
Hi, [ ... back online now ... ] /var/tmp/portage/app-emulation/qemu-kvm-0.14.0/work/qemu-kvm-0.14.0/qemu-kvm.c:1724: kvm_mutex_unlock: Assertion `!cpu_single_env' failed. That's a spice bug. In fact, there are a lot of qemu_mutex_lock/unlock_iothread in that subsystem. I bet at least a few

[Qemu-devel] [PATCH] target-i386: Initialize CPUState::halted in cpu_reset

2011-04-26 Thread Jan Kiszka
Instead of having an extra reset function at machine level and special code for processing INIT, move the initialization of halted into the cpu reset handler. Signed-off-by: Jan Kiszka --- hw/pc.c | 12 ++-- target-i386/helper.c |5 - 2 files changed, 6 insertions(

Re: [Qemu-devel] [PATCH] qed: Fix consistency check on 32-bit hosts

2011-04-26 Thread Kevin Wolf
Am 24.04.2011 19:38, schrieb Stefan Hajnoczi: > The qed_bytes_to_clusters() function is normally used with size_t > lengths. Consistency check used it with file size length and therefore > failed on 32-bit hosts when the image file is 4 GB or more. > > Make qed_bytes_to_clusters() explicitly 64-b

  1   2   >