Re: [Qemu-devel] Bug #757654: UHCI fails to signal stall response patch

2011-04-15 Thread Brad Hards
On Sat, 16 Apr 2011 06:57:00 am Jan Vesely wrote: > +s->status |= UHCI_STS_USBERR; This is per UHCI 1.1D Section 4.1.5. Looks good. > +*int_mask |= 0x02; > +if (td->ctrl & TD_CTRL_IOC) > +*int_mask |= 0x01; > +uhci_update_irq(s); I see "A hardware interr

Re: [Qemu-devel] [PATCH] raw-posix: Linearize direct I/O on Linux NFS

2011-04-15 Thread Christoph Hellwig
On Fri, Apr 15, 2011 at 04:33:51PM -0700, Badari Pulavarty wrote: > To be honest with you, we should kill cache=none and just optimize only one > case and live with it (like other commerical > hypervisor). :( cache=none is the only sane mode for qemu, modulo bugs in nfs or similar weird protocols

Re: [Qemu-devel] [PATCH] raw-posix: Linearize direct I/O on Linux NFS

2011-04-15 Thread Christoph Hellwig
On Fri, Apr 15, 2011 at 03:21:36PM -0700, Badari Pulavarty wrote: > When you say "you're" - you really meant RH right ? RH should have caught > this in their > regression year ago as part of their first beta. Correct ? With you I mean whoever cares. Which apparently is no one but IBM.

[Qemu-devel] [PATCH 4/4] Slirp Reverse UDP Firewall

2011-04-15 Thread Daisuke Nojiri
This patch series adds a simple reverse UDP firewall functionality to Slirp. The series consists of four patches: 1. drop=udp|all - enables the firewall 2. droplog=FILE - sets the drop log filename 3. allow=PROTO:ADDR:PORT - adds an allow rule 4. parse network mask (e.g. /24) for A

Re: [Qemu-devel] [PATCH 3/4] Slirp Reverse UDP Firewall

2011-04-15 Thread Daisuke Nojiri
This patch series adds a simple reverse UDP firewall functionality to Slirp. The series consists of four patches: 1. drop=udp|all - enables the firewall 2. droplog=FILE - sets the drop log filename 3. allow=PROTO:ADDR:PORT - adds an allow rule 4. parse network mask (e.g. /24) for A

Re: [Qemu-devel] Para-virtualized ram-based filesystem?

2011-04-15 Thread Brad Hards
On Saturday 16 April 2011 09:58:32 Ritchie, Stuart wrote: > How does that sound? As a general user: Confusing. Is there a concrete example (specific applications, specific performance issues, specific requirements) that you can share? Brad

Re: [Qemu-devel] Para-virtualized ram-based filesystem?

2011-04-15 Thread Ritchie, Stuart
On 4/15/11 2:43 PM, "Anthony Liguori" wrote: >On 04/15/2011 04:09 PM, Ritchie, Stuart wrote: >> Hi all, >> >> Has anyone looked at implementing a para-virtualized ram-based >>filesystem >> for qemu? Or any similar dynamic memory mapping techniques for running >> guests? >> >> What I had in mind

Re: [Qemu-devel] [PATCH] raw-posix: Linearize direct I/O on Linux NFS

2011-04-15 Thread Badari Pulavarty
On 4/15/2011 4:00 PM, Anthony Liguori wrote: On 04/15/2011 05:21 PM, pbad...@linux.vnet.ibm.com wrote: On 4/15/2011 10:29 AM, Christoph Hellwig wrote: On Fri, Apr 15, 2011 at 09:23:54AM -0700, Badari Pulavarty wrote: True. That brings up a different question - whether we are doing enough testi

[Qemu-devel] [PATCH 3/4] Slirp Reverse UDP Firewall

2011-04-15 Thread Daisuke Nojiri
This patch series adds a simple reverse UDP firewall functionality to Slirp. The series consists of four patches: 1. drop=udp|all - enables the firewall 2. droplog=FILE - sets the drop log filename 3. allow=PROTO:ADDR:PORT - adds an allow rule 4. parse network mask (e.g. /24) for A

Re: [Qemu-devel] [PATCH] raw-posix: Linearize direct I/O on Linux NFS

2011-04-15 Thread Anthony Liguori
On 04/15/2011 05:21 PM, pbad...@linux.vnet.ibm.com wrote: On 4/15/2011 10:29 AM, Christoph Hellwig wrote: On Fri, Apr 15, 2011 at 09:23:54AM -0700, Badari Pulavarty wrote: True. That brings up a different question - whether we are doing enough testing on mainline QEMU :( It seems you're clearl

[Qemu-devel] [PATCH 2/4] Slirp Reverse UDP Firewall

2011-04-15 Thread Daisuke Nojiri
This patch series adds a simple reverse UDP firewall functionality to Slirp. The series consists of three patches. Each adds one -net user option: 1. drop=udp|all - enables the firewall 2. droplog=FILE - sets the drop log filename 3. allow=PROTO:ADDR:PORT - adds an allow rule e.g.)

[Qemu-devel] [PATCH 1/4] Slirp Reverse UDP Firewall

2011-04-15 Thread Daisuke Nojiri
This patch series adds a simple reverse UDP firewall functionality to Slirp. The series consists of three patches. Each adds one -net user option: 1. drop=udp|all - enables the firewall 2. droplog=FILE - sets the drop log filename 3. allow=PROTO:ADDR:PORT - adds an allow rule e.g.)

Re: [Qemu-devel] [PATCH] raw-posix: Linearize direct I/O on Linux NFS

2011-04-15 Thread Badari Pulavarty
On 4/15/2011 10:29 AM, Christoph Hellwig wrote: On Fri, Apr 15, 2011 at 09:23:54AM -0700, Badari Pulavarty wrote: True. That brings up a different question - whether we are doing enough testing on mainline QEMU :( It seems you're clearly not doing enough testing on any qemu. Even the

Re: [Qemu-devel] Para-virtualized ram-based filesystem?

2011-04-15 Thread Anthony Liguori
On 04/15/2011 04:09 PM, Ritchie, Stuart wrote: Hi all, Has anyone looked at implementing a para-virtualized ram-based filesystem for qemu? Or any similar dynamic memory mapping techniques for running guests? What I had in mind would be a convenient, zero-copy mechanism for sharing dynamically

[Qemu-devel] Para-virtualized ram-based filesystem?

2011-04-15 Thread Ritchie, Stuart
Hi all, Has anyone looked at implementing a para-virtualized ram-based filesystem for qemu? Or any similar dynamic memory mapping techniques for running guests? What I had in mind would be a convenient, zero-copy mechanism for sharing dynamically allocated, memory mapped files between host and g

[Qemu-devel] Bug #757654: UHCI fails to signal stall response patch

2011-04-15 Thread Jan Vesely
Hi, I'm sending a patch for bug #757654. The bug does not really break anything it just makes USB error detection harder. It's a quick fix and might need some polishing but it works (I am currently using it). thx, jan PS: I guess you need this line: Signed-off-by: Jan Vesely diff --git a/hw/us

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-15 Thread Paolo Bonzini
On 04/15/2011 05:04 PM, Stefan Hajnoczi wrote: The way I approached virtio-scsi was to look at the SCSI Architecture Model document and some of the Linux SCSI code. I'm not sure if letting virtio-blk SCSI pass-through or scsi-generic guide us is a good approach. How do your ioprio and barrier r

Re: [Qemu-devel] Question about total_sectors in block/vpc.c

2011-04-15 Thread Lyu Mitnick
Hello Kevin, 2011/4/14 Kevin Wolf > Am 13.04.2011 22:59, schrieb Lyu Mitnick: > > Hello Stefan, > > > > I have a question about get_option_parameter(). I am wondering whether > > get_option_parameter is suitable to use instead of doing the search by > > myself > > in the case like following: >

Re: [Qemu-devel] [PATCH 00/11] Introduce host, emulator, machine and CPU states

2011-04-15 Thread Blue Swirl
On Fri, Apr 8, 2011 at 11:43 PM, Blue Swirl wrote: > The overall plan is to gather some functions and structures around > "states" representing host, emulator, machine and (later) CPU. I see > qemu-common.h as a library of useful stuff, it also includes > OS-dependent declarations. > > Patches 1 t

Re: [Qemu-devel] [PATCH 04/11] Move generic or OS function declarations to qemu-common.h

2011-04-15 Thread Blue Swirl
On Tue, Apr 12, 2011 at 12:50 PM, Jes Sorensen wrote: > On 04/08/11 22:45, Blue Swirl wrote: >> Move generic or OS related function declarations and macro >> TFR to qemu-common.h. >> >> While moving, also add #include to fix a >> recent mingw32 build breakage. >> >> Signed-off-by: Blue Swirl >>

Re: [Qemu-devel] [PATCH] set VIRTIO_BALLOON_F_MUST_TELL_HOST unconditionally

2011-04-15 Thread Anthony Liguori
On 04/15/2011 02:15 PM, Dave Hansen wrote: On Fri, 2011-04-15 at 12:17 -0500, Anthony Liguori wrote: On 04/15/2011 11:36 AM, Dave Hansen wrote: Why would we do this in QEMU? This prevents the guest from doing ballooning reclaim during OOM. What the heck is "ballooning reclaim"? Could you ela

Re: [Qemu-devel] [PATCH] set VIRTIO_BALLOON_F_MUST_TELL_HOST unconditionally

2011-04-15 Thread Dave Hansen
On Fri, 2011-04-15 at 12:17 -0500, Anthony Liguori wrote: > On 04/15/2011 11:36 AM, Dave Hansen wrote: > >> Why would we do this in QEMU? This prevents the guest from doing > >> ballooning reclaim during OOM. > > What the heck is "ballooning reclaim"? Could you elaborate a bit on how > > this hap

Re: [Qemu-devel] [PATCH] raw-posix: Linearize direct I/O on Linux NFS

2011-04-15 Thread Badari Pulavarty
On Fri, 2011-04-15 at 13:09 -0500, Anthony Liguori wrote: > On 04/15/2011 11:23 AM, Badari Pulavarty wrote: > > On Fri, 2011-04-15 at 17:34 +0200, Christoph Hellwig wrote: > >> On Fri, Apr 15, 2011 at 04:26:41PM +0100, Stefan Hajnoczi wrote: > >>> On Fri, Apr 15, 2011 at 4:05 PM, Christoph Hellwig

Re: [Qemu-devel] [PATCH] sparc: Fix assertion caused by empty memory slot with 0 byte

2011-04-15 Thread Blue Swirl
Thanks, applied. On Thu, Apr 14, 2011 at 8:19 PM, Stefan Weil wrote: > If the memory size given on the command line is equal to the > maximum size of memory defined by the hardware, there is no > "empty slot" after physical memory. > > The following command > >                qemu-system-sparc -m

Re: [Qemu-devel] [PATCH] raw-posix: Linearize direct I/O on Linux NFS

2011-04-15 Thread Anthony Liguori
On 04/15/2011 11:23 AM, Badari Pulavarty wrote: On Fri, 2011-04-15 at 17:34 +0200, Christoph Hellwig wrote: On Fri, Apr 15, 2011 at 04:26:41PM +0100, Stefan Hajnoczi wrote: On Fri, Apr 15, 2011 at 4:05 PM, Christoph Hellwig wrote: NAK. ?Just wait for the bloody NFS client fix to get in instea

[Qemu-devel] [Bug 761469] Re: multicast VPN breaks IPv6 Duplicate Address Detection

2011-04-15 Thread Neil Wilson
** Bug watch added: Red Hat Bugzilla #557188 https://bugzilla.redhat.com/show_bug.cgi?id=557188 ** Also affects: fedora via https://bugzilla.redhat.com/show_bug.cgi?id=557188 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of qem

Re: [Qemu-devel] [PATCH] raw-posix: Linearize direct I/O on Linux NFS

2011-04-15 Thread Christoph Hellwig
On Fri, Apr 15, 2011 at 09:23:54AM -0700, Badari Pulavarty wrote: > True. That brings up a different question - whether we are doing > enough testing on mainline QEMU :( It seems you're clearly not doing enough testing on any qemu. Even the RHEL6 qemu has had preadv/pwritev since the first beta.

Re: [Qemu-devel] [PATCH] raw-posix: Linearize direct I/O on Linux NFS

2011-04-15 Thread Christoph Hellwig
On Fri, Apr 15, 2011 at 11:10:37AM -0500, Anthony Liguori wrote: > In general, since we are userspace, we should try to run well on whatever > kernel we're on. It should run with the interfaces given, but hacking around performance bugs in a gross way is not something qemu should do.

Re: [Qemu-devel] [PATCH] set VIRTIO_BALLOON_F_MUST_TELL_HOST unconditionally

2011-04-15 Thread Anthony Liguori
On 04/15/2011 11:36 AM, Dave Hansen wrote: On Fri, 2011-04-15 at 11:21 -0500, Anthony Liguori wrote: This patch makes the "tell host first" logic the only case. This should make everybody happy, and reduce the amount of untested or untestable code in the kernel. It doesn't make me happy. Darn

Re: [Qemu-devel] [PATCH] Remove obsolete 'enabled' variable from progress state

2011-04-15 Thread Kevin Wolf
Am 15.04.2011 17:08, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH 2/2 V7] qemu, qmp: add inject-nmi qmp command

2011-04-15 Thread Blue Swirl
On Thu, Apr 14, 2011 at 12:55 PM, Daniel P. Berrange wrote: > On Wed, Apr 13, 2011 at 10:56:21PM +0300, Blue Swirl wrote: >> On Wed, Apr 13, 2011 at 4:08 PM, Luiz Capitulino >> wrote: >> > On Tue, 12 Apr 2011 21:31:18 +0300 >> > Blue Swirl wrote: >> > >> >> On Tue, Apr 12, 2011 at 10:52 AM, Avi

Re: [Qemu-devel] [PATCH] set VIRTIO_BALLOON_F_MUST_TELL_HOST unconditionally

2011-04-15 Thread Dave Hansen
On Fri, 2011-04-15 at 11:21 -0500, Anthony Liguori wrote: > > This patch makes the "tell host first" logic the only case. This > > should make everybody happy, and reduce the amount of untested or > > untestable code in the kernel. > > It doesn't make me happy. Darn. > Why would we do this in Q

Re: [Qemu-devel] [PATCH] Remove obsolete 'enabled' variable from progress state

2011-04-15 Thread Stefan Hajnoczi
On Fri, Apr 15, 2011 at 4:08 PM, wrote: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen > --- >  qemu-progress.c |    8 ++-- >  1 files changed, 2 insertions(+), 6 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH] set VIRTIO_BALLOON_F_MUST_TELL_HOST unconditionally

2011-04-15 Thread Anthony Liguori
On 04/15/2011 09:44 AM, Dave Hansen wrote: There's a patch pending on LKML at the moment: http://lkml.org/lkml/2011/4/7/101 The virtio balloon driver has a VIRTIO_BALLOON_F_MUST_TELL_HOST feature bit. As of now, qemu-kvm defines the bit, but doesn't set it. feature bit. Whenever the b

Re: [Qemu-devel] [PATCH] raw-posix: Linearize direct I/O on Linux NFS

2011-04-15 Thread Badari Pulavarty
On Fri, 2011-04-15 at 17:34 +0200, Christoph Hellwig wrote: > On Fri, Apr 15, 2011 at 04:26:41PM +0100, Stefan Hajnoczi wrote: > > On Fri, Apr 15, 2011 at 4:05 PM, Christoph Hellwig wrote: > > > NAK. ?Just wait for the bloody NFS client fix to get in instead of > > > adding crap like that. > > >

Re: [Qemu-devel] [PATCH] raw-posix: Linearize direct I/O on Linux NFS

2011-04-15 Thread Stefan Hajnoczi
On Fri, Apr 15, 2011 at 5:10 PM, Anthony Liguori wrote: > On 04/15/2011 10:34 AM, Christoph Hellwig wrote: >> >> On Fri, Apr 15, 2011 at 04:26:41PM +0100, Stefan Hajnoczi wrote: >>> >>> On Fri, Apr 15, 2011 at 4:05 PM, Christoph Hellwig  wrote: NAK. ?Just wait for the bloody NFS client f

Re: [Qemu-devel] [PATCH] raw-posix: Linearize direct I/O on Linux NFS

2011-04-15 Thread Anthony Liguori
On 04/15/2011 10:34 AM, Christoph Hellwig wrote: On Fri, Apr 15, 2011 at 04:26:41PM +0100, Stefan Hajnoczi wrote: On Fri, Apr 15, 2011 at 4:05 PM, Christoph Hellwig wrote: NAK. ?Just wait for the bloody NFS client fix to get in instead of adding crap like that. That's totally fine if NFS clie

[Qemu-devel] [PATCH 11/17] s390x: helper functions for system emulation

2011-04-15 Thread Alexander Graf
When running system emulation, we need to transverse through the MMU and deliver interrupts according to the specification. This patch implements those two pieces and in addition adjusts the CPU initialization code to account for the new fields in CPUState. Signed-off-by: Alexander Graf --- v1

[Qemu-devel] [PATCH 10/17] s390x: keep hint on virtio managing size

2011-04-15 Thread Alexander Graf
The s390x virtio bus keeps management information on virtio after the top of the guest's RAM. We need to be able to tell the guest the size of its RAM (without virtio stuff), but also be able to trap when the guest accesses RAM outside of its scope (including virtio stuff). So we need a variable t

[Qemu-devel] [PATCH 17/17] s390x: build s390x by default

2011-04-15 Thread Alexander Graf
This patch enables building of s390x-softmmu and s390x-linux-user targets by default. Signed-off-by: Alexander Graf --- configure|2 ++ default-configs/s390x-linux-user.mak |1 + 2 files changed, 3 insertions(+), 0 deletions(-) create mode 100644 default-conf

Re: [Qemu-devel] [PATCH] raw-posix: Linearize direct I/O on Linux NFS

2011-04-15 Thread Christoph Hellwig
On Fri, Apr 15, 2011 at 04:26:41PM +0100, Stefan Hajnoczi wrote: > On Fri, Apr 15, 2011 at 4:05 PM, Christoph Hellwig wrote: > > NAK. ?Just wait for the bloody NFS client fix to get in instead of > > adding crap like that. > > That's totally fine if NFS client will be fixed in the near future but

[Qemu-devel] [PATCH 06/17] s390x: Prepare cpu.h for emulation

2011-04-15 Thread Alexander Graf
We need to add some more logic to the CPU description to leverage emulation of an s390x CPU. This patch adds all the required helpers, fields in CPUState and constant definitions required for user and system emulation. Signed-off-by: Alexander Graf --- v1 -> v2: - remove FPReg definition -

[Qemu-devel] [PATCH 07/17] s390x: Enable s390x-softmmu target

2011-04-15 Thread Alexander Graf
This patch adds some code paths for running s390x guest OSs without the need for KVM. Signed-off-by: Alexander Graf --- v3 -> v4: - declare non-working when EXT is masked - remove obsolete cpu_halted --- cpu-exec.c|8 target-s390x/exec.h | 11 ++- targ

[Qemu-devel] [PATCH 15/17] s390x: Adjust GDB stub

2011-04-15 Thread Alexander Graf
We have successfully lazilized cc computation, so we need to manually trigger its calculation when gdb wants to fetch it. We also changed the variable name, so writing it writes into a different field now. Signed-off-by: Alexander Graf --- gdbstub.c |8 ++-- 1 files changed, 6 insertions

[Qemu-devel] [PATCH 08/17] s390x: Dispatch interrupts to KVM or the real CPU

2011-04-15 Thread Alexander Graf
The KVM interrupt injection path is non-generic for now. So we need to push knowledge of how to inject a device interrupt using KVM into the actual device code. Signed-off-by: Alexander Graf --- hw/s390-virtio-bus.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 01/17] tcg: extend max tcg opcodes on 32bit

2011-04-15 Thread Alexander Graf
When running on a 32 bit host, we tend to use more TCG ops than on a 64 bit host. Reflect that in the reserved opcode amount constant. Signed-off-by: Alexander Graf --- exec-all.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/exec-all.h b/exec-all.h index 496c001..d

[Qemu-devel] [PATCH 02/17] s390x: s390x-linux-user support

2011-04-15 Thread Alexander Graf
From: Ulrich Hecht This patch adds support for running s390x binaries in the linux-user emulation code. Signed-off-by: Ulrich Hecht Signed-off-by: Alexander Graf --- v1 -> v2: - always set 64bit flag for s390x binaries in elf loader - remove redundant EXECUTE_SVC - advance psw.addr in

[Qemu-devel] [PATCH 05/17] kvm: add kvm stub for arch specific stuff

2011-04-15 Thread Alexander Graf
We have a generic stub architecture for kvm calls, but some architectures are different from others. So we do want to be able to have stubs for architecture specific functionality as well. This patch adds kvm stubs for all architectures. Signed-off-by: Alexander Graf --- Makefile.target

[Qemu-devel] [PATCH 09/17] s390x: virtio machine storage keys

2011-04-15 Thread Alexander Graf
For emulation (and migration) we need to know about the guest's storage keys. These are separate from actual RAM contents, so we need to allocate them in parallel to RAM. While touching the file, this patch also adjusts the hypercall function to a new syntax that aligns better with tcg emulated co

[Qemu-devel] [PATCH 13/17] s390x: Adjust internal kvm code

2011-04-15 Thread Alexander Graf
We're now finally emulating an s390x CPU, so we can move quite some logic from the kvm code out into generic CPU code. This patch does this and adjusts the interfaces according to what the code around now expects to be able to call. Signed-off-by: Alexander Graf --- target-s390x/kvm.c | 44 ++

[Qemu-devel] [PATCH 00/17] s390x emulation support v4

2011-04-15 Thread Alexander Graf
We've had support for running s390x guests with KVM for a while now. This patch set also enables support for running s390x guests in system as well as linux-user mode in emulation! Within this scope, I again want to stress that this is _not_ supposed to replace Hercules - the s390 emulator - in an

[Qemu-devel] [PATCH 03/17] linux-user: define a couple of syscalls for non-uid16 targets

2011-04-15 Thread Alexander Graf
From: Ulrich Hecht Quite a number of syscalls are only defined on systems with USE_UID16 defined; this patch defines them on other systems as well. Fixes a large number of uid/gid-related testcases on the s390x target (and most likely on other targets as well) Signed-off-by: Ulrich Hecht ---

[Qemu-devel] [PATCH 16/17] s390x: remove compatibility cc field

2011-04-15 Thread Alexander Graf
Remove the now unused cc field that was only required to not break bisectability. Signed-off-by: Alexander Graf --- target-s390x/cpu.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h index 6ba303d..3e7dbde 100644 --- a/target-s390x

[Qemu-devel] [PATCH 04/17] linux-user: add s390x to llseek list

2011-04-15 Thread Alexander Graf
We keep a list of host architectures that do llseek with the same syscall as lseek. S390x is one of them, so let's add it to the list. Original-patch-by: Ulrich Hecht Signed-off-by: Alexander Graf --- linux-user/syscall.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] raw-posix: Linearize direct I/O on Linux NFS

2011-04-15 Thread Stefan Hajnoczi
On Fri, Apr 15, 2011 at 4:05 PM, Christoph Hellwig wrote: > NAK.  Just wait for the bloody NFS client fix to get in instead of > adding crap like that. That's totally fine if NFS client will be fixed in the near future but this doesn't seem likely: http://www.spinics.net/lists/linux-nfs/msg20462

Re: [Qemu-devel] [PATCH] virtio-9p: Make rpath function thread safe

2011-04-15 Thread Venkateswararao Jujjuri
On 04/15/2011 02:42 AM, Stefan Hajnoczi wrote: On Fri, Apr 15, 2011 at 10:05 AM, M. Mohan Kumar wrote: Use dynamically allocated memory to return concatenated path (fs_root and file path) instead of a static buffer. Caller has to free the memory. Signed-off-by: M. Mohan Kumar --- This patch de

[Qemu-devel] [PATCH] Remove obsolete 'enabled' variable from progress state

2011-04-15 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- qemu-progress.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/qemu-progress.c b/qemu-progress.c index 6498161..f3ce974 100644 --- a/qemu-progress.c +++ b/qemu-progress.c @@ -29,7 +29,6 @@ #include struct p

Re: [Qemu-devel] [PATCH] raw-posix: Linearize direct I/O on Linux NFS

2011-04-15 Thread Christoph Hellwig
NAK. Just wait for the bloody NFS client fix to get in instead of adding crap like that.

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-15 Thread Stefan Hajnoczi
On Fri, Apr 15, 2011 at 3:37 PM, Paolo Bonzini wrote: > On 04/15/2011 04:28 PM, Stefan Hajnoczi wrote: >> Nothing formal.  I'm trying to learn SCSI as I go along: >> >> http://git.kernel.org/?p=linux/kernel/git/nab/lio-core-2.6.git;a=blob;f=include/linux/virtio_scsi.h;hb=refs/heads/tcm_vhost >> >>

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-15 Thread Paolo Bonzini
> Why vmw_pvscsi? Because all I wanted to do was to learn qemu's SCSI, and vmw_pvscsi is pretty much the simplest device I could pick... It's just an exercise, but since it works I thought I'd post it. > Good luck. Paul Brook absolutely insists on having them, but they kill > performance for any

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-15 Thread Hannes Reinecke
On 04/15/2011 04:17 PM, Paolo Bonzini wrote: > On 04/15/2011 04:01 PM, Stefan Hajnoczi wrote: >> I think SCSI brings many benefits. Guests can deal with it better >> than these alien vdX virtio-blk devices, which makes migration easier. >> It becomes possible to attach many disks without burning t

[Qemu-devel] [PATCH] set VIRTIO_BALLOON_F_MUST_TELL_HOST unconditionally

2011-04-15 Thread Dave Hansen
There's a patch pending on LKML at the moment: http://lkml.org/lkml/2011/4/7/101 The virtio balloon driver has a VIRTIO_BALLOON_F_MUST_TELL_HOST feature bit. As of now, qemu-kvm defines the bit, but doesn't set it. feature bit. Whenever the bit is set, the guest kernel must always tell

Re: [Qemu-devel] [PATCH 2/2] add tracing of scsi requests

2011-04-15 Thread Paolo Bonzini
On 04/15/2011 04:32 PM, Stefan Hajnoczi wrote: I've forgotten whether or not ust is happy with %s. Ok, that's enough to convince me. Paolo

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-15 Thread Paolo Bonzini
On 04/15/2011 04:28 PM, Stefan Hajnoczi wrote: > Nothing formal. I'm trying to learn SCSI as I go along: > > http://git.kernel.org/?p=linux/kernel/git/nab/lio-core-2.6.git;a=blob;f=include/linux/virtio_scsi.h;hb=refs/heads/tcm_vhost > > That's the interface I'm using. Requests are: > > [Header

Re: [Qemu-devel] [PATCH 2/2] add tracing of scsi requests

2011-04-15 Thread Stefan Hajnoczi
On Fri, Apr 15, 2011 at 3:22 PM, Paolo Bonzini wrote: > On 04/15/2011 04:15 PM, Stefan Hajnoczi wrote: >> >> On Fri, Apr 15, 2011 at 2:24 PM, Paolo Bonzini >>  wrote: >>> >>> +disable scsi_req_parsed(int target, int lun, int tag, int cmd, const >>> char *cmdname, int mode, int xfer, uint64_t lba)

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-15 Thread Stefan Hajnoczi
On Fri, Apr 15, 2011 at 3:17 PM, Paolo Bonzini wrote: > On 04/15/2011 04:01 PM, Stefan Hajnoczi wrote: >> >> I think SCSI brings many benefits.  Guests can deal with it better >> than these alien vdX virtio-blk devices, which makes migration easier. >> It becomes possible to attach many disks with

Re: [Qemu-devel] [PATCH 2/2] add tracing of scsi requests

2011-04-15 Thread Paolo Bonzini
On 04/15/2011 04:15 PM, Stefan Hajnoczi wrote: On Fri, Apr 15, 2011 at 2:24 PM, Paolo Bonzini wrote: +disable scsi_req_parsed(int target, int lun, int tag, int cmd, const char *cmdname, int mode, int xfer, uint64_t lba) "target %d lun %d tag %d command %d (%s) dir %d length %d lba %"PRIu64""

Re: [Qemu-devel] is it just me or is ne2k broken in qemu?

2011-04-15 Thread Alex Williamson
On Thu, 2011-04-14 at 12:31 +0400, Michael Tokarev wrote: > I performed several tests of various emulated NICs > booting with iPXE, and discovered that ne2k_pci (*) > emulated device does not quite work, for quite some > time already, at least with linux guests. > > The NIC works for a while, but

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-15 Thread Paolo Bonzini
On 04/15/2011 04:01 PM, Stefan Hajnoczi wrote: I think SCSI brings many benefits. Guests can deal with it better than these alien vdX virtio-blk devices, which makes migration easier. It becomes possible to attach many disks without burning through free PCI slots. We don't need to update guests

Re: [Qemu-devel] [PATCH 2/2] add tracing of scsi requests

2011-04-15 Thread Stefan Hajnoczi
On Fri, Apr 15, 2011 at 2:24 PM, Paolo Bonzini wrote: > +disable scsi_req_parsed(int target, int lun, int tag, int cmd, const char > *cmdname, int mode, int xfer, uint64_t lba) "target %d lun %d tag %d command > %d (%s) dir %d length %d lba %"PRIu64"" Tracing strings isn't possible with all tra

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-15 Thread Stefan Hajnoczi
On Fri, Apr 15, 2011 at 2:42 PM, Paolo Bonzini wrote: > Lightly tested with Linux guests; at least it can successfully partition > and format a disk.  scsi-generic also lightly tested. > > Doesn't do migration, doesn't do hotplug (the device would support that, > but it is not 100% documented and

[Qemu-devel] LPC2011 Virtualization Micro Conf

2011-04-15 Thread Jes Sorensen
Hi, With the success of last year's Virtualization micro-conference track at Linux Plumbers 2010, I have accepted to organize a similar track for Linux Plumbers 2011 in Santa Rosa. Please see the official Linux Plumbers 2011 website for full details about the conference: http://www.linuxplumbersco

[Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-15 Thread Paolo Bonzini
Lightly tested with Linux guests; at least it can successfully partition and format a disk. scsi-generic also lightly tested. Doesn't do migration, doesn't do hotplug (the device would support that, but it is not 100% documented and the Linux driver in particular cannot initiate hot-unplug). I d

[Qemu-devel] [PATCH] raw-posix: Linearize direct I/O on Linux NFS

2011-04-15 Thread Stefan Hajnoczi
The Linux NFS client issues separate NFS requests for vectored direct I/O writes. For example, a pwritev() with 8 elements results in 8 write requests to the server. This is very inefficient and a kernel-side fix is not trivial or likely to be available soon. This patch detects files on NFS and

[Qemu-devel] [PATCH 2/2] add tracing of scsi requests

2011-04-15 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c | 45 ++--- trace-events |6 ++ 2 files changed, 32 insertions(+), 19 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index ceeb4ec..6b306a7 100644 --- a/hw/scsi-bus.c +++ b/hw/scsi-bus.c @@

[Qemu-devel] [PATCH 1/2] allow ) in trace output string

2011-04-15 Thread Paolo Bonzini
Be greedy in matching the trailing "\)*" pattern. Otherwise, all the text in the trace string up to the last closed parenthesis is taken as part of the prototype. Signed-off-by: Paolo Bonzini --- scripts/tracetool |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts

[Qemu-devel] [PATCH 0/2] add tracing of scsi requests

2011-04-15 Thread Paolo Bonzini
Simple series to allow tracing of SCSI commands, helped me a bit in understanding how the thing works. Patch 1 is required to fix a small bug in tracetool. Paolo Bonzini (2): allow ) in trace output string add tracing of scsi requests hw/scsi-bus.c | 45 ++-

Re: [Qemu-devel] [PATCH] multiboot: Support quotable commas in module list

2011-04-15 Thread Kevin Wolf
Am 15.04.2011 09:56, schrieb Adam Lackorzynski: > Support quoting of ',' (and '\') to allow commas in the parameter list of > modules. > > Signed-off-by: Adam Lackorzynski Other options in qemu use double commas for escaping. So maybe reusing get_opt_value() would make things more consistent. It

Re: [Qemu-devel] [RFC PATCH] block: Fix eject -f for locked devices

2011-04-15 Thread Amit Shah
On (Fri) 18 Feb 2011 [16:16:07], Markus Armbruster wrote: > From 8cd4978c9be6ff2bcc414bb1c1b258b96b9a74c1 Mon Sep 17 00:00:00 2001 > From: Markus Armbruster > Date: Fri, 18 Feb 2011 15:54:02 +0100 > > After forcefully ejecting media locked by the guest, you can't ever > again insert new media. >

Re: [Qemu-devel] [PATCH] atapi: Indicate 'medium not ready' to 'medium ready' transition via error

2011-04-15 Thread Amit Shah
On (Fri) 15 Apr 2011 [13:05:00], Kevin Wolf wrote: > Am 15.04.2011 11:33, schrieb Amit Shah: > > MMC-5 Table F.1 lists errors that can be thrown for the TEST_UNIT_READY > > command. Going from medium not ready to medium ready states is > > communicated by throwing an error. > > > > This adds the

[Qemu-devel] [PATCH 2/2] docs: Trace events must not expect pointer dereferencing

2011-04-15 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- docs/tracing.txt |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/docs/tracing.txt b/docs/tracing.txt index f15069c..905a083 100644 --- a/docs/tracing.txt +++ b/docs/tracing.txt @@ -69,6 +69,11 @@ Trace events should use types as foll

[Qemu-devel] [PATCH 1/2] trace: Remove %s in grlib trace events

2011-04-15 Thread Stefan Hajnoczi
Trace events cannot use %s in their format strings because trace backends vary in how they can deference pointers (if at all). Recording const char * values is not meaningful if their contents are not recorded too. Change grlib trace events that rely on strings so that they communicate similar in

Re: [Qemu-devel] [PATCH] atapi: Indicate 'medium not ready' to 'medium ready' transition via error

2011-04-15 Thread Kevin Wolf
Am 15.04.2011 11:33, schrieb Amit Shah: > MMC-5 Table F.1 lists errors that can be thrown for the TEST_UNIT_READY > command. Going from medium not ready to medium ready states is > communicated by throwing an error. > > This adds the missing 'tray opened' event that we fail to report to > guests.

Re: [Qemu-devel] [PATCH] atapi: Indicate 'medium not ready' to 'medium ready' transition via error

2011-04-15 Thread Markus Armbruster
Amit Shah writes: > MMC-5 Table F.1 lists errors that can be thrown for the TEST_UNIT_READY > command. Going from medium not ready to medium ready states is > communicated by throwing an error. > > This adds the missing 'tray opened' event that we fail to report to > guests. After doing this, o

Re: [Qemu-devel] Problem in setting breakpoints at kernel code using "qemu and gdb"

2011-04-15 Thread Amirali Shambayati
That works well. Thanks so much Craig. On Fri, Apr 15, 2011 at 10:08 AM, Craig Brozefsky wrote: > On Thu, Apr 14, 2011 at 10:16 AM, Amirali Shambayati > wrote: > >> >> Also I tried combination of gdb and qemu using following commands: >> #gdb >> (gdb) symbol-file vmlinux.o >> (gdb) target remote

Re: [Qemu-devel] [PATCH] Add dd-style SIGUSR1 progress reporting

2011-04-15 Thread Kevin Wolf
Am 12.04.2011 11:34, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > This introduces support for dd-style progress reporting, if the user > hasn't specified -p to report progress. If sent a SIGUSR1, qemu-img > will report current progress for commands that support progress > reporting.

Re: [Qemu-devel] [PATCH v4 0/4] Fix -icount with iothread

2011-04-15 Thread Paolo Bonzini
On 04/15/2011 09:49 AM, Edgar E. Iglesias wrote: BTW, I removed this hunk from patch nr 2: diff --git a/roms/seabios b/roms/seabios index cc97564..06d0bdd 16 --- a/roms/seabios +++ b/roms/seabios @@ -1 +1 @@ -Subproject commit cc975646af69f279396d4d5e1379ac6af80ee637 +Subproject commit 06d0bd

Re: [Qemu-devel] [PATCH] virtio-9p: Make rpath function thread safe

2011-04-15 Thread Stefan Hajnoczi
On Fri, Apr 15, 2011 at 10:05 AM, M. Mohan Kumar wrote: > Use dynamically allocated memory to return concatenated path > (fs_root and file path) instead of a static buffer. Caller has to free > the memory. > > Signed-off-by: M. Mohan Kumar > --- > This patch depends on my chroot patchset. > http:

[Qemu-devel] [PATCH] atapi: Indicate 'medium not ready' to 'medium ready' transition via error

2011-04-15 Thread Amit Shah
MMC-5 Table F.1 lists errors that can be thrown for the TEST_UNIT_READY command. Going from medium not ready to medium ready states is communicated by throwing an error. This adds the missing 'tray opened' event that we fail to report to guests. After doing this, older Linux guests properly reva

Re: [Qemu-devel] [PATCH] multiboot: Support quotable commas in module list

2011-04-15 Thread Stefan Hajnoczi
On Fri, Apr 15, 2011 at 8:56 AM, Adam Lackorzynski wrote: > Support quoting of ',' (and '\') to allow commas in the parameter list of > modules. > > Signed-off-by: Adam Lackorzynski > --- >  hw/multiboot.c |   33 + >  1 files changed, 29 insertions(+), 4 deletions(

[Qemu-devel] [PATCH] virtio-9p: Make rpath function thread safe

2011-04-15 Thread M. Mohan Kumar
Use dynamically allocated memory to return concatenated path (fs_root and file path) instead of a static buffer. Caller has to free the memory. Signed-off-by: M. Mohan Kumar --- This patch depends on my chroot patchset. http://patchwork.ozlabs.org/patch/89033/ hw/9pfs/virtio-9p-local.c | 551 +

[Qemu-devel] [PATCH] multiboot: Support quotable commas in module list

2011-04-15 Thread Adam Lackorzynski
Support quoting of ',' (and '\') to allow commas in the parameter list of modules. Signed-off-by: Adam Lackorzynski --- hw/multiboot.c | 33 + 1 files changed, 29 insertions(+), 4 deletions(-) diff --git a/hw/multiboot.c b/hw/multiboot.c index 394ed01..73f01aa

Re: [Qemu-devel] [PATCH v4 0/4] Fix -icount with iothread

2011-04-15 Thread Edgar E. Iglesias
On Wed, Apr 13, 2011 at 10:03:42AM +0200, Paolo Bonzini wrote: > This series finally fixes -icount with iothread and avoids deadlocks > due to the vm_clock not making progress when the VM is stopped. > The crux of the fix is in patch 1, while patch 2 implements the > "clock warping" that fixes dead

[Qemu-devel] [Bug 761471] [NEW] Multicast VPN TTL hardcoded at 1

2011-04-15 Thread Neil Wilson
Public bug reported: The multicast VPN opens sockets with the default TTL of 1 and there doesn't appear to be an option anywhere that will allow you to increase that. This limits the usability of the VPN to the local network where the host server lives. ** Affects: qemu Importance: Undecide

[Qemu-devel] [Bug 761469] [NEW] multicast VPN breaks IPv6 Duplicate Address Detection

2011-04-15 Thread Neil Wilson
Public bug reported: The multicast VPN facility in Qemu uses Multicast Loopback to make sure that other Qemu processes on the Host server receive the transmission. The side effect of this is that the process sending the packet also gets the packet back on its receive channel and currently this is