[Qemu-devel] QEMU development for MIPS64 user mode

2011-03-28 Thread Khansa Butt
hi I have added support for MIPS64 user mode emulation in QEMU and email git patch to the qemu-devel mailing list but I got no any response yet. My Patch mail has the following subject line MIPS64 user mode emulation Patch please verify that this patch mail is not neglected or guide me towards the

[Qemu-devel] Re: [V9 PATCH 13/13] virtio-9p: Chroot environment for other functions

2011-03-28 Thread M. Mohan Kumar
Thanks Stefan. I will send next version with incorporating your suggestions. > dpath is leaked in the success case. I suggest writing the function like > this: static int get_dirfd(FsContext *fs_ctx, const char *path) > { > int fd; > char *dpath; > char *last_component; > > /* p

[Qemu-devel] [PATCH 0/4] usb: implement Interface Association Descriptor support

2011-03-28 Thread Brad Hards
This patchset implements Interface Association Descriptor suppoort. These descriptors are covered in Section 9.6.4 of the USB 3.0 spec, but there is a better description in the Intel IAD whitepaper (www.usb.org/developers/whitepapers/iadclasscode_r10.pdf). The short version is that IAD is an ex

[Qemu-devel] [PATCH 3/4] usb: remove fallback to bNumInterfaces if no .nif

2011-03-28 Thread Brad Hards
All callers have been updated. --- hw/usb-desc.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/usb-desc.c b/hw/usb-desc.c index 62591f2..a784155 100644 --- a/hw/usb-desc.c +++ b/hw/usb-desc.c @@ -76,7 +76,7 @@ int usb_desc_config(const USBDescConfig *conf, uint8_t

[Qemu-devel] [PATCH 4/4] usb: add support for "grouped" interfaces and the Interface Association Descriptor

2011-03-28 Thread Brad Hards
This is used for some devices that have multiple interfaces that form a logic device. An example is Video Class, which has a Control interface and a Streaming interface. There can be additional interfaces on the same (physical) devices (e.g. a microphone), and Interface Association Descriptor handl

[Qemu-devel] [PATCH 2/4] usb: update config descriptors to identify number of interfaces

2011-03-28 Thread Brad Hards
Previously we relied on the .bNumInterfaces, but that won't always be accurate after the introduction of grouped interfaces. --- hw/usb-hid.c|3 +++ hw/usb-hub.c|1 + hw/usb-msd.c|2 ++ hw/usb-serial.c |1 + hw/usb-wacom.c |1 + 5 files changed, 8 insertions(+), 0

[Qemu-devel] [PATCH 1/4] usb: Add Interface Association Descriptor descriptor type

2011-03-28 Thread Brad Hards
--- hw/usb.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/usb.h b/hw/usb.h index d3d755d..418853f 100644 --- a/hw/usb.h +++ b/hw/usb.h @@ -124,6 +124,7 @@ #define USB_DT_ENDPOINT0x05 #define USB_DT_DEVICE_QUALIFIER 0x06 #define USB_

[Qemu-devel] [PATCH V2] hw/xen_disk: ioreq not finished on error

2011-03-28 Thread Feiran Zheng
Bug fix: routines 'ioreq_runio_qemu_sync' and 'ioreq_runio_qemu_aio' won't call 'ioreq_unmap' or 'ioreq_finish' on errors, leaving ioreq in the blkdev->inflight list and a leak. Signed-off-by: Feiran Zheng --- hw/xen_disk.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) dif

[Qemu-devel] Re: [PATCH]hw/xen_disk: ioreq not finished on error

2011-03-28 Thread Feiran Zheng
Sorry for the confusing, I'll clean up it. On Tue, Mar 29, 2011 at 2:16 AM, Stefano Stabellini wrote: > On Mon, 28 Mar 2011, Feiran Zheng wrote: >> On Mon, Mar 28, 2011 at 9:42 PM, Stefano Stabellini >> wrote: >> > On Sun, 27 Mar 2011, Feiran Zheng wrote: >> >> Bug fix: routines 'ioreq_runio_qem

Re: [Qemu-devel] Re: [PATCH 1/2] rbd: use the higher level librbd instead of just librados

2011-03-28 Thread Josh Durgin
On 03/28/2011 02:08 PM, Stefan Hajnoczi wrote: > You have sent a malformed patch. Please send patches that follow the > guidelines at http://wiki.qemu.org/Contribute/SubmitAPatch and test that > your mail client is not line wrapping or mangling whitespace. Sorry about that. I've fixed the style i

[Qemu-devel] [PATCH v2 1/2] rbd: use the higher level librbd instead of just librados

2011-03-28 Thread Josh Durgin
librbd stacks on top of librados to provide access to rbd images. Using librbd simplifies the qemu code, and allows qemu to use new versions of the rbd format with few (if any) changes. Signed-off-by: Josh Durgin Signed-off-by: Yehuda Sadeh --- block/rbd.c | 785 +++-

[Qemu-devel] [PATCH v2 2/2] rbd: allow configuration of rados from the rbd filename

2011-03-28 Thread Josh Durgin
The new format is rbd:pool/image[@snapshot][:option1=value1[:option2=value2...]] Each option is used to configure rados, and may be any Ceph option, or "conf". The "conf" option specifies a Ceph configuration file to read. This allows rbd volumes from more than one Ceph cluster to be used by speci

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-03-28 Thread moonman
Wow you are fast! The hardware I use is pogoplug with plugapps linux. I think any plug computer will do. http://plugapps.com/index.php5/Install_on_Pogoplug_V2_Pink They are sold for about $50. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribe

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-03-28 Thread Peter Maydell
** Summary changed: - qemu-i386 on ARM bash: fork: Invalid argument + qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/739785 Titl

[Qemu-devel] Re: [Bug 739785] Re: qemu-i386 on ARM bash: fork: Invalid argument

2011-03-28 Thread Peter Maydell
On 28 March 2011 21:13, moonman <739...@bugs.launchpad.net> wrote: > Hello, > > [root@Plugbox ~]# strace -ff -o ls-strace.log chroot /i386 /usr/bin/qemu-i386 > /bin/ls > b?   d?    e?            l?  mu-e386i  ome  oot  roc  s?  u? > bin  diae  hlrc.tin.gar  m?  o?        oot  q    s?   t?  v? > >

[Qemu-devel] [PATCH 0/3] virtio and vhost error handling

2011-03-28 Thread Michael S. Tsirkin
This patchset makes virtio and vhost more robust in face of broken/malicious guests. Lightly tested. Pls review. Michael S. Tsirkin (3): virtio: don't exit on guest errors vhost: don't exit on memory errors vhost: roll our own cpu map variant hw/vhost.c | 74 +++

[Qemu-devel] [PATCH 3/3] vhost: roll our own cpu map variant

2011-03-28 Thread Michael S. Tsirkin
vhost used cpu_physical_memory_map to get the virtual address for the ring, however, this will exit on an illegal RAM address. Since the addresses are guest-controlled, we shouldn't do that. Switch to our own variant that uses the vhost tables and returns an error instead of exiting. Signed-off-b

[Qemu-devel] Re: [PATCH 1/2] rbd: use the higher level librbd instead of just librados

2011-03-28 Thread Stefan Hajnoczi
On Thu, Mar 24, 2011 at 03:51:36PM -0700, Josh Durgin wrote: You have sent a malformed patch. Please send patches that follow the guidelines at http://wiki.qemu.org/Contribute/SubmitAPatch and test that your mail client is not line wrapping or mangling whitespace. Stefan

[Qemu-devel] Re: [V9 PATCH 13/13] virtio-9p: Chroot environment for other functions

2011-03-28 Thread Stefan Hajnoczi
On Fri, Mar 18, 2011 at 08:58:01AM +0530, M. Mohan Kumar wrote: > +static int get_dirfd(FsContext *fs_ctx, const char *path) > +{ > +int fd; > +char *dpath = qemu_strdup(path); > +char *last_component; > + > +/* path can not contain ".." */ > +last_component = strrchr(path, '/')

[Qemu-devel] [PATCH 2/3] vhost: don't exit on memory errors

2011-03-28 Thread Michael S. Tsirkin
When memory including one of the VQs goes away, handle that as a guest error instead of exiting qemu. Signed-off-by: Michael S. Tsirkin --- hw/vhost.c |8 +--- hw/vhost.h |1 + 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/vhost.c b/hw/vhost.c index 97a1299..c17a8

[Qemu-devel] [PATCH 1/3] virtio: don't exit on guest errors

2011-03-28 Thread Michael S. Tsirkin
When guest does something illegal, such as programming invalid index values in the virtio device, qemu currently tends to crash. With virtio, a better idea is to log an error, and set status to FAIL which stops the device. Add an API to do this, and fix core, blk and serial to use it on error. S

[Qemu-devel] [PATCH] net: Remove unused net-checksum.c file

2011-03-28 Thread Stefan Hajnoczi
The common checksum functions were moved to net/checksum.c in commit 7200ac3c7c8eefe574193b49eeff09f120e11ec7 but the original net-checksum.c was never deleted from the source tree. Remove it now since all users of the checksum functions link against net/checksum.o and net-checksum.c is not even c

Re: [Qemu-devel] Re: [RFC][PATCH v1 05/12] qapi: fix handling for null-return async callbacks

2011-03-28 Thread Anthony Liguori
On 03/28/2011 03:42 PM, Michael Roth wrote: Is this supposed to be the current behavior? In early testing I noticed that not including a tag, and issuing an async command that never completed, still allowed for me to get responses for subsequent, tagless/pseudo-tagged requests. I don't thin

Re: [Qemu-devel] Re: [RFC][PATCH v1 05/12] qapi: fix handling for null-return async callbacks

2011-03-28 Thread Michael Roth
On 03/28/2011 01:27 PM, Anthony Liguori wrote: On 03/28/2011 12:59 PM, Michael Roth wrote: For a command like this, I can't imagine ever wanting to extend the return value... I think this is another topic, but also one we should hash out a bit better. Currently the plan is that the C API no

[Qemu-devel] [Bug 739785] Re: qemu-i386 on ARM bash: fork: Invalid argument

2011-03-28 Thread moonman
Hello, [root@Plugbox ~]# strace -ff -o ls-strace.log chroot /i386 /usr/bin/qemu-i386 /bin/ls b? d?e?l? mu-e386i ome oot roc s? u? bin diae hlrc.tin.gar m? o?oot qs? t? v? [root@Plugbox ~]# strace -ff -o bash-strace.log chroot /i386 /usr/bin/qemu-i386

Re: [Qemu-devel] FYI, cgit is temporarily disabled on qemu.org

2011-03-28 Thread Anthony Liguori
On 03/28/2011 03:22 PM, Anthony Liguori wrote: We've been having problems on qemu.org all day. Initially, it was due to a combination of a small DoS attack (not uncommon unfortunately). Later, the issue was observed when a crawler that was ignoring robots.txt started indexing git.qemu.org. W

[Qemu-devel] [Bug 739785] Re: qemu-i386 on ARM bash: fork: Invalid argument

2011-03-28 Thread moonman
Also by googling I noticed that many people have the same problem if their CPU architecture is different from x86, and the try to emulate x86. ** Attachment added: "ls-strace" https://bugs.launchpad.net/qemu/+bug/739785/+attachment/1951371/+files/ls-strace.log.32356 -- You received this bug

[Qemu-devel] FYI, cgit is temporarily disabled on qemu.org

2011-03-28 Thread Anthony Liguori
We've been having problems on qemu.org all day. Initially, it was due to a combination of a small DoS attack (not uncommon unfortunately). Later, the issue was observed when a crawler that was ignoring robots.txt started indexing git.qemu.org. We use cgit because of the fact that it does agg

Re: [Qemu-devel] Re: [RFC][PATCH v1 07/12] qmp proxy: core code for proxying qmp requests to guest

2011-03-28 Thread Michael Roth
On 03/28/2011 02:05 PM, Anthony Liguori wrote: On 03/25/2011 04:56 PM, Michael Roth wrote: I don't quite follow what this is doing. That's for the session negotiation so we can reset state when the guest agent restarts. The sequence is: guest -> host { "_xport_event": "guest_init", "_xport_

Re: [Qemu-devel] [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options

2011-03-28 Thread Aurelien Jarno
On Mon, Mar 28, 2011 at 01:50:40PM -0500, Anthony Liguori wrote: > On 03/28/2011 01:24 PM, Aurelien Jarno wrote: > >On Mon, Mar 28, 2011 at 01:02:45PM -0500, Anthony Liguori wrote: > >>On 03/28/2011 12:42 PM, Blue Swirl wrote: > >>>On Mon, Mar 28, 2011 at 4:16 PM, Anthony Liguori > >>>wrote: > >

[Qemu-devel] Re: [PULL] pci, virtio, vhost, e1000

2011-03-28 Thread Anthony Liguori
On 03/28/2011 01:37 PM, Michael S. Tsirkin wrote: The following changes since commit f64622c401d4975a56b8559e16286231a1d2cfb8: report that QEMU process was killed by a signal (2011-03-26 12:54:42 +) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/

Re: [Qemu-devel] Re: [RFC][PATCH v1 07/12] qmp proxy: core code for proxying qmp requests to guest

2011-03-28 Thread Anthony Liguori
On 03/25/2011 04:56 PM, Michael Roth wrote: I don't quite follow what this is doing. That's for the session negotiation so we can reset state when the guest agent restarts. The sequence is: guest -> host { "_xport_event": "guest_init", "_xport_arg_sid": } host -> guest { "_xport_event":

[Qemu-devel] [PULL] pci, virtio, vhost, e1000

2011-03-28 Thread Michael S. Tsirkin
The following changes since commit f64622c401d4975a56b8559e16286231a1d2cfb8: report that QEMU process was killed by a signal (2011-03-26 12:54:42 +) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_anthony Isaku Yamahata (4): pc

Re: [Qemu-devel] [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options

2011-03-28 Thread Anthony Liguori
On 03/28/2011 01:24 PM, Aurelien Jarno wrote: On Mon, Mar 28, 2011 at 01:02:45PM -0500, Anthony Liguori wrote: On 03/28/2011 12:42 PM, Blue Swirl wrote: On Mon, Mar 28, 2011 at 4:16 PM, Anthony Liguori wrote: On 03/28/2011 04:03 AM, Alexander Graf wrote: Um, ok. Do I need to do anything ab

[Qemu-devel] [PATCH v3] Do not delete BlockDriverState when deleting the drive

2011-03-28 Thread Ryan Harper
When removing a drive from the host-side via drive_del we currently have the following path: drive_del qemu_aio_flush() bdrv_close()// zaps bs->drv, which makes any subsequent I/O get // dropped. Works as designed drive_uninit() bdrv_delete() // frees the bs. Since the devi

Re: [Qemu-devel] [PATCH] cirrus_vga: Remove unneeded reset

2011-03-28 Thread Stefan Weil
Am 28.03.2011 11:24, schrieb Isaku Yamahata: On Mon, Mar 28, 2011 at 11:21:23AM +0200, Markus Armbruster wrote: Isaku Yamahata writes: On Mon, Mar 28, 2011 at 07:18:04AM +0200, Stefan Weil wrote: Am 28.03.2011 04:17, schrieb Isaku Yamahata: [...] On Sat, Mar 26, 2011 at 10:53:09PM +0100, S

Re: [Qemu-devel] Relative/Absolute timing snapshot problem

2011-03-28 Thread Clemens Kolbitsch
> On 03/18/11 21:39, Clemens Kolbitsch wrote: > > Hi list, > > > > strange situation: When I create a snapshot using Qemu 0.14.0 stable, > > everything works smoothly and resuming the CPU takes about 1-2 seconds. > > If I don't use the snapshot file for some time, the time it takes to > > resume g

[Qemu-devel] [PATCH 10/10] ccid: add docs

2011-03-28 Thread Alon Levy
Add documentation for the usb-ccid device and accompanying two card devices, ccid-card-emulated and ccid-card-passthru. Signed-off-by: Alon Levy --- docs/ccid.txt | 135 + 1 files changed, 135 insertions(+), 0 deletions(-) create mode 100

Re: [Qemu-devel] [PATCH v2] Do not delete BlockDriverState when deleting the drive

2011-03-28 Thread Ryan Harper
* Markus Armbruster [2011-03-24 07:27]: > Whoops, almost missed this. Best to cc: me to avoid that. > It was sent directly to you: > Sender: qemu-devel-bounces+ryanh=us.ibm@nongnu.org > From: Ryan Harper > Subject: Re: [Qemu-devel] [PATCH v2] Do not delete BlockDriverState when > d

Re: [Qemu-devel] Re: [RFC][PATCH v1 05/12] qapi: fix handling for null-return async callbacks

2011-03-28 Thread Anthony Liguori
On 03/28/2011 12:59 PM, Michael Roth wrote: For a command like this, I can't imagine ever wanting to extend the return value... I think this is another topic, but also one we should hash out a bit better. Currently the plan is that the C API not expose asynchronicity, underneath the cover

[Qemu-devel] Re: [PATCH]hw/xen_disk: ioreq not finished on error

2011-03-28 Thread Stefano Stabellini
On Mon, 28 Mar 2011, Feiran Zheng wrote: > On Mon, Mar 28, 2011 at 9:42 PM, Stefano Stabellini > wrote: > > On Sun, 27 Mar 2011, Feiran Zheng wrote: > >> Bug fix: routines 'ioreq_runio_qemu_sync' and 'ioreq_runio_qemu_aio' > >> won't call 'ioreq_unmap' or 'ioreq_finish' on errors, leaving ioreq in

[Qemu-devel] [PATCH 02/10] qemu-thread.h: include inttypes.h

2011-03-28 Thread Alon Levy
qemu-thread.h relies on uint64_t being defined, but doesn't include inttypes.h explicitly. This makes it easier to use it from vscclient (part of libcacard). --- qemu-thread.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/qemu-thread.h b/qemu-thread.h index edc7ab6..0a7

Re: [Qemu-devel] [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options

2011-03-28 Thread Aurelien Jarno
On Mon, Mar 28, 2011 at 01:02:45PM -0500, Anthony Liguori wrote: > On 03/28/2011 12:42 PM, Blue Swirl wrote: > >On Mon, Mar 28, 2011 at 4:16 PM, Anthony Liguori > >wrote: > >>On 03/28/2011 04:03 AM, Alexander Graf wrote: > Um, ok. Do I need to do anything about this? > >>>I'm also not sure t

[Qemu-devel] Re: [PATCH v2 3/5] hw/sun4m: Move QEMUMachine structs into sun4*_hwdef structs

2011-03-28 Thread Peter Maydell
On 28 March 2011 18:58, Blue Swirl wrote: > On Mon, Mar 28, 2011 at 8:36 PM, Peter Maydell > wrote: >> On 28 March 2011 18:31, Blue Swirl wrote: >>> On Mon, Mar 28, 2011 at 4:44 PM, Peter Maydell >>> wrote: Combine the per-machine QEMUMachine struct into the per-machine sun4*_hwdef

Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus

2011-03-28 Thread Blue Swirl
On Mon, Mar 28, 2011 at 9:00 PM, Alon Levy wrote: > On Mon, Mar 28, 2011 at 08:44:59PM +0300, Blue Swirl wrote: >> On Mon, Mar 28, 2011 at 5:31 PM, Jes Sorensen >> wrote: >> > On 03/28/11 16:28, Alon Levy wrote: >> >> On Mon, Mar 28, 2011 at 02:01:01PM +0200, Jes Sorensen wrote: >> >>> > On 03/2

[Qemu-devel] Re: [RFC][PATCH v1 05/12] qapi: fix handling for null-return async callbacks

2011-03-28 Thread Michael Roth
On 03/28/2011 11:47 AM, Luiz Capitulino wrote: On Fri, 25 Mar 2011 16:22:16 -0500 Anthony Liguori wrote: On 03/25/2011 02:47 PM, Michael Roth wrote: Async commands like 'guest-ping' have NULL retvals. Handle these by inserting an empty dictionary in the response's "return" field. Signed-off-

[Qemu-devel] Re: [RFC][PATCH v1 05/12] qapi: fix handling for null-return async callbacks

2011-03-28 Thread Luiz Capitulino
On Fri, 25 Mar 2011 16:22:16 -0500 Anthony Liguori wrote: > On 03/25/2011 02:47 PM, Michael Roth wrote: > > Async commands like 'guest-ping' have NULL retvals. Handle these by > > inserting an empty dictionary in the response's "return" field. > > > > Signed-off-by: Michael Roth > > --- > > qmp

Re: [Qemu-devel] [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options

2011-03-28 Thread Anthony Liguori
On 03/28/2011 12:42 PM, Blue Swirl wrote: On Mon, Mar 28, 2011 at 4:16 PM, Anthony Liguori wrote: On 03/28/2011 04:03 AM, Alexander Graf wrote: Um, ok. Do I need to do anything about this? I'm also not sure this is too important. It's GPL compliance so yes, it's very important. Most of

[Qemu-devel] Re: [RFC][PATCH v1 08/12] qemu-char: add qmp_proxy chardev

2011-03-28 Thread Anthony Liguori
On 03/25/2011 05:11 PM, Michael Roth wrote: Why are these options required? The qmp_proxy_new() constructor expects a path to a socket it can connect() to. Not sure about telnet, but the other options are required for this. Well...server=on at least, wait=off needs to be set as well because

Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus

2011-03-28 Thread Alon Levy
On Mon, Mar 28, 2011 at 08:44:59PM +0300, Blue Swirl wrote: > On Mon, Mar 28, 2011 at 5:31 PM, Jes Sorensen wrote: > > On 03/28/11 16:28, Alon Levy wrote: > >> On Mon, Mar 28, 2011 at 02:01:01PM +0200, Jes Sorensen wrote: > >>> > On 03/23/11 14:19, Alon Levy wrote: > > > A CCID device is a sm

[Qemu-devel] Re: [PATCH v2 3/5] hw/sun4m: Move QEMUMachine structs into sun4*_hwdef structs

2011-03-28 Thread Blue Swirl
On Mon, Mar 28, 2011 at 8:36 PM, Peter Maydell wrote: > On 28 March 2011 18:31, Blue Swirl wrote: >> On Mon, Mar 28, 2011 at 4:44 PM, Peter Maydell >> wrote: >>> Combine the per-machine QEMUMachine struct into the per-machine >>> sun4*_hwdef struct. This requires some moving around of init func

Re: [Qemu-devel] [PATCH 14/17] s390x: Implement opcode helpers

2011-03-28 Thread Peter Maydell
On 28 March 2011 18:23, Alexander Graf wrote: > On 03/24/2011 06:29 PM, Peter Maydell wrote: >>> +/* condition codes for binary FP ops */ >>> +static uint32_t set_cc_f32(float32 v1, float32 v2) >>> +{ >>> +    if (float32_is_any_nan(v1) || float32_is_any_nan(v2)) { >>> +        return 3; >>> +    

Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus

2011-03-28 Thread Blue Swirl
On Mon, Mar 28, 2011 at 5:31 PM, Jes Sorensen wrote: > On 03/28/11 16:28, Alon Levy wrote: >> On Mon, Mar 28, 2011 at 02:01:01PM +0200, Jes Sorensen wrote: >>> > On 03/23/11 14:19, Alon Levy wrote: > > A CCID device is a smart card reader. It is a USB device, defined at > > [1]. >

Re: [Qemu-devel] [PATCH 14/17] s390x: Implement opcode helpers

2011-03-28 Thread Richard Henderson
On 03/28/2011 10:23 AM, Alexander Graf wrote: > I just checked the macros there and it looks like > float32_compare_quiet returns eq when both numbers are NaN. No it doesn't -- a == b will never be true for either operand as NaN. Have a look at the "real" softfloat version anyway, not the softflo

Re: [Qemu-devel] Relative/Absolute timing snapshot problem

2011-03-28 Thread Blue Swirl
On Mon, Mar 28, 2011 at 7:32 PM, Jes Sorensen wrote: > On 03/28/11 18:25, Clemens Kolbitsch wrote: >>> Hi Clemens, >>> > >>> > Could you clarify what you are doing, when you say snapshot do you mean >>> > a savevm operation (ie. checkpoint) or a disk snapshot? >> I Jes, >> >> sorry for not being c

[Qemu-devel] Re: [PATCH v6 0/4] piix_pci: optimize irq data path

2011-03-28 Thread Michael S. Tsirkin
On Tue, Mar 29, 2011 at 12:05:26AM +0900, Isaku Yamahata wrote: > Here is v6 which fixed piix3_set_irq_pic(). > > 4/4 needs more extensive tests. So please feel free to pick it up now or > drop it for now. > > patch description: > This patch series optimizes irq data path of piix_pci. > So far pi

Re: [Qemu-devel] Relative/Absolute timing snapshot problem

2011-03-28 Thread Jes Sorensen
On 03/28/11 18:25, Clemens Kolbitsch wrote: >> Hi Clemens, >> > >> > Could you clarify what you are doing, when you say snapshot do you mean >> > a savevm operation (ie. checkpoint) or a disk snapshot? > I Jes, > > sorry for not being clear: I use a savevm operation. > > Following setup: I have

Re: [Qemu-devel] [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options

2011-03-28 Thread Blue Swirl
On Mon, Mar 28, 2011 at 4:16 PM, Anthony Liguori wrote: > On 03/28/2011 04:03 AM, Alexander Graf wrote: >> >>> Um, ok.  Do I need to do anything about this? >> >> I'm also not sure this is too important. > > It's GPL compliance so yes, it's very important. > >>  Most of our firmware blobs come fro

Re: [Qemu-devel] Re: [RFC][PATCH v1 05/12] qapi: fix handling for null-return async callbacks

2011-03-28 Thread Anthony Liguori
On 03/28/2011 12:27 PM, Luiz Capitulino wrote: We had to make a choice. We chose the current 'return' response. Iirc, one of my first suggestions was "{ 'return': 'null' }" It would be: { 'return': null } That's the valid JSON version. but you refused to have a 'null' object, our parser

Re: [Xen-devel] Re: [Qemu-devel] [PATCH V11 09/15] xen: Introduce the Xen mapcache

2011-03-28 Thread Anthony PERARD
On Wed, Mar 23, 2011 at 12:33, Alexander Graf wrote: > We have a bitmap framework in qemu now. Please use that :). See bitmap.h / > bitops.h / bitops.c. Will do. Thanks, -- Anthony PERARD

[Qemu-devel] Re: [PATCH v2 3/5] hw/sun4m: Move QEMUMachine structs into sun4*_hwdef structs

2011-03-28 Thread Peter Maydell
On 28 March 2011 18:31, Blue Swirl wrote: > On Mon, Mar 28, 2011 at 4:44 PM, Peter Maydell > wrote: >> Combine the per-machine QEMUMachine struct into the per-machine >> sun4*_hwdef struct. This requires some moving around of init functions >> to avoid forward references. We also have to move th

[Qemu-devel] Re: [PATCH v6 4/4] piix_pci: load path clean up

2011-03-28 Thread Michael S. Tsirkin
On Tue, Mar 29, 2011 at 12:05:30AM +0900, Isaku Yamahata wrote: > The previous patch didn't change the behavior when load, > it resulted in ugly code. This patch cleans it up. > > With this patch, pic irq lines are manipulated when loaded. > It is expected that it won't change the behaviour becaus

[Qemu-devel] Re: [PATCH v2 3/5] hw/sun4m: Move QEMUMachine structs into sun4*_hwdef structs

2011-03-28 Thread Blue Swirl
On Mon, Mar 28, 2011 at 4:44 PM, Peter Maydell wrote: > Combine the per-machine QEMUMachine struct into the per-machine > sun4*_hwdef struct. This requires some moving around of init functions > to avoid forward references. We also have to move the 'const' > attribute from the whole sun4*_hwdef[]

Re: [Xen-devel] Re: [Qemu-devel] [PATCH V11 02/15] xen: Make Xen build once.

2011-03-28 Thread Alexander Graf
On 03/28/2011 04:50 PM, Anthony PERARD wrote: On Wed, Mar 23, 2011 at 10:57, Alexander Graf wrote: On 01.03.2011, at 19:35, anthony.per...@citrix.com wrote: From: Anthony PERARD xen_domainbuild is now build in libhw. And xen_machine_pv is build only for i386 targets. Signed-off-by: Anthony

[Qemu-devel] Re: [PATCH v2 0/5] Let boards state maximum RAM limits in QEMUMachine struct

2011-03-28 Thread Blue Swirl
On Mon, Mar 28, 2011 at 4:44 PM, Peter Maydell wrote: > This fairly simple patchset adds a new 'max_ram' field to the QEMUMachine > structure so that a board model can specify the maximum RAM it will accept. > We can then produce a friendly diagnostic message when the user tries to > start qemu wi

[Qemu-devel] [Bug 739785] Re: qemu-i386 on ARM bash: fork: Invalid argument

2011-03-28 Thread Peter Maydell
OK, can you run the following and attach the resulting strace logfiles? strace -ff -o ls-strace.log chroot /i386 /usr/bin/qemu-i386 /bin/ls strace -ff -o bash-strace.log chroot /i386 /usr/bin/qemu-i386 /bin/bash -c /bin/ls (and tell us what the commands print as well). Also can you state exactl

Re: [Qemu-devel] Re: [RFC][PATCH v1 05/12] qapi: fix handling for null-return async callbacks

2011-03-28 Thread Luiz Capitulino
On Mon, 28 Mar 2011 12:19:53 -0500 Anthony Liguori wrote: > On 03/28/2011 12:06 PM, Luiz Capitulino wrote: > > On Mon, 28 Mar 2011 12:01:16 -0500 > > Anthony Liguori wrote: > > > >> On 03/28/2011 11:47 AM, Luiz Capitulino wrote: > >>> On Fri, 25 Mar 2011 16:22:16 -0500 > >>> Anthony Liguori wr

Re: [Qemu-devel] [PATCH 14/17] s390x: Implement opcode helpers

2011-03-28 Thread Alexander Graf
On 03/24/2011 06:29 PM, Peter Maydell wrote: On 24 March 2011 15:58, Alexander Graf wrote: This is more random comments in passing than a thorough review; sorry. +#if HOST_LONG_BITS == 64&& defined(__GNUC__) +/* assuming 64-bit hosts have __uint128_t */ +__uint128_t dividend

[Qemu-devel] Re: [PATCH 3/4] Introduce machine state

2011-03-28 Thread Blue Swirl
On Mon, Mar 28, 2011 at 10:25 AM, Paolo Bonzini wrote: > On 03/26/2011 11:28 PM, Blue Swirl wrote: >> >> Move generic machine state to machine-state.h, adjust >> users. > > What's the distinction between vm state and machine state? Machine state or configuration is visible to guest, for example n

Re: [Qemu-devel] Re: [RFC][PATCH v1 05/12] qapi: fix handling for null-return async callbacks

2011-03-28 Thread Anthony Liguori
On 03/28/2011 12:06 PM, Luiz Capitulino wrote: On Mon, 28 Mar 2011 12:01:16 -0500 Anthony Liguori wrote: On 03/28/2011 11:47 AM, Luiz Capitulino wrote: On Fri, 25 Mar 2011 16:22:16 -0500 Anthony Liguori wrote: On 03/25/2011 02:47 PM, Michael Roth wrote: Async commands like 'guest-ping' h

[Qemu-devel] [PATCH 03/10] usb-ccid: add CCID bus

2011-03-28 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_R

[Qemu-devel] Re: [RFC][PATCH v1 05/12] qapi: fix handling for null-return async callbacks

2011-03-28 Thread Luiz Capitulino
On Mon, 28 Mar 2011 12:01:16 -0500 Anthony Liguori wrote: > On 03/28/2011 11:47 AM, Luiz Capitulino wrote: > > On Fri, 25 Mar 2011 16:22:16 -0500 > > Anthony Liguori wrote: > > > >> On 03/25/2011 02:47 PM, Michael Roth wrote: > >>> Async commands like 'guest-ping' have NULL retvals. Handle these

Re: [Qemu-devel] Re: [RFC][PATCH v1 00/11] QEMU Guest Agent: QMP-based host/guest communication (virtagent)

2011-03-28 Thread Anthony Liguori
On 03/25/2011 05:36 PM, Michael Roth wrote: Basically just need a way to pull whatever is stored in the response qdict's "return" field out without specifying the QTYPE in advance... which exists in qdict.c:qdict_get_obj(), it's just not currently exposed to outside callers. Just use qdict_get(

[Qemu-devel] Re: [RFC][PATCH v1 05/12] qapi: fix handling for null-return async callbacks

2011-03-28 Thread Anthony Liguori
On 03/28/2011 11:47 AM, Luiz Capitulino wrote: On Fri, 25 Mar 2011 16:22:16 -0500 Anthony Liguori wrote: On 03/25/2011 02:47 PM, Michael Roth wrote: Async commands like 'guest-ping' have NULL retvals. Handle these by inserting an empty dictionary in the response's "return" field. Signed-off-

Re: [Qemu-devel] [PATCH v24 00/10] usb-ccid

2011-03-28 Thread Alon Levy
On Mon, Mar 28, 2011 at 06:11:04PM +0200, Alon Levy wrote: Sorry, please ignore this mail. > This patchset adds three new devices, usb-ccid, ccid-card-passthru and > ccid-card-emulated, providing a CCID bus, a simple passthru protocol > implementing card requiring a client, and a standalone emula

Re: [Qemu-devel] [PATCH] cirrus_vga: Remove unneeded reset

2011-03-28 Thread Michael S. Tsirkin
On Mon, Mar 28, 2011 at 06:20:15PM +0200, Stefan Weil wrote: > Am 28.03.2011 11:24, schrieb Isaku Yamahata: > >On Mon, Mar 28, 2011 at 11:21:23AM +0200, Markus Armbruster wrote: > >>Isaku Yamahata writes: > >> > >>>On Mon, Mar 28, 2011 at 07:18:04AM +0200, Stefan Weil wrote: > Am 28.03.2011 04

[Qemu-devel] Re: [PATCH v6 0/4] piix_pci: optimize irq data path

2011-03-28 Thread Michael S. Tsirkin
On Tue, Mar 29, 2011 at 12:05:26AM +0900, Isaku Yamahata wrote: > Here is v6 which fixed piix3_set_irq_pic(). > > 4/4 needs more extensive tests. So please feel free to pick it up now or > drop it for now. Could you pls clarify how did you test and which patches? > patch description: > This patc

Re: [Xen-devel] Re: [Qemu-devel] [PATCH V11 13/15] xen: Initialize event channels and io rings

2011-03-28 Thread Anthony PERARD
On Wed, Mar 23, 2011 at 12:36, Alexander Graf wrote: >> +/* Compatibility with older version */ >> +#if __XEN_LATEST_INTERFACE_VERSION__ < 0x0003020a >> +#  define xen_vcpu_eport(shared_page, i) \ >> +    (shared_page->vcpu_iodata[i].vp_eport) >> +#  define xen_vcpu_ioreq(shared_page, vcpu) \ >> +

[Qemu-devel] [PATCH 09/10] ccid: add ccid-card-emulated device

2011-03-28 Thread Alon Levy
This devices uses libcacard (internal) to emulate a smartcard conforming to the CAC standard. It attaches to the usb-ccid bus. Usage instructions (example command lines) are in the following patch in docs/ccid.txt. It uses libcacard which uses nss, so it can work with both hw cards and certificates

[Qemu-devel] [PATCH 05/10] ccid: add passthru card device

2011-03-28 Thread Alon Levy
The passthru ccid card is a device sitting on the usb-ccid bus and using a chardevice to communicate with a remote device using the VSCard protocol defined in libcacard/vscard_common.h Usage docs available in following patch in docs/ccid.txt Signed-off-by: Alon Levy --- Changes from v23->v24:

[Qemu-devel] [PATCH 08/10] libcacard: add docs

2011-03-28 Thread Alon Levy
From: Robert Relyea --- docs/libcacard.txt | 483 1 files changed, 483 insertions(+), 0 deletions(-) create mode 100644 docs/libcacard.txt diff --git a/docs/libcacard.txt b/docs/libcacard.txt new file mode 100644 index 000..5dee6fa ---

[Qemu-devel] [PATCH 07/10] libcacard: add vscclient

2011-03-28 Thread Alon Levy
From: Robert Relyea client to talk to ccid-card-passthru and use smartcard on client to perform actual operations. v23->v24 changes: (Jes Sorensen review 2) * use qemu_socket instead of socket * use fprintf(stderr,..) for errors * remove unneccessary includes since using qemu_common.h --- li

Re: [Qemu-devel] [PATCH V11 06/15] xen: Add the Xen platform pci device

2011-03-28 Thread Anthony PERARD
On Wed, Mar 23, 2011 at 12:08, Alexander Graf wrote: >> diff --git a/hw/pc_piix.c b/hw/pc_piix.c >> index 6eff06e..417c456 100644 >> --- a/hw/pc_piix.c >> +++ b/hw/pc_piix.c >> @@ -121,6 +121,10 @@ static void pc_init1(ram_addr_t ram_size, >> >>     pc_vga_init(pci_enabled? pci_bus: NULL); >> >> +

[Qemu-devel] [PATCH 04/10] introduce libcacard/vscard_common.h

2011-03-28 Thread Alon Levy
--- Signed-off-by: Alon Levy v20->v21 changes: (Jes Sorensen review) * license set to 2+ * long comment fixes, remove empty line at eof. * add reference to COPYING v19->v20 changes: * checkpatch.pl v15->v16 changes: Protocol change: * VSCMsgInit capabilities and magic * removed ReaderRe

[Qemu-devel] [PATCH v24 00/10] usb-ccid

2011-03-28 Thread Alon Levy
This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. It also introduces a new directory libcaccard with CAC card emulation, CAC is a type of

[Qemu-devel] [PATCH 01/10] trace: move trace objects from Makefile to Makefile.objs

2011-03-28 Thread Alon Levy
--- Makefile | 32 Makefile.objs | 32 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/Makefile b/Makefile index 89e88b4..209e14d 100644 --- a/Makefile +++ b/Makefile @@ -112,38 +112,6 @@ ui/vnc.o: QEMU_CFL

[Qemu-devel] [PATCH v24 00/10] usb-ccid

2011-03-28 Thread Alon Levy
This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. It also introduces a new directory libcaccard with CAC card emulation, CAC is a type of

Re: [Qemu-devel] [PATCH v23 01/11] trace: move trace objects from Makefile to Makefile.objs

2011-03-28 Thread Alon Levy
On Mon, Mar 28, 2011 at 04:30:26PM +0200, Jes Sorensen wrote: > On 03/28/11 16:26, Alon Levy wrote: > > On Mon, Mar 28, 2011 at 01:59:10PM +0200, Jes Sorensen wrote: > >> On 03/23/11 14:19, Alon Levy wrote: > >>> --- > >>> Makefile | 32 > >>> Makefile.objs

Re: [Qemu-devel] [PATCH 16/17] s390x: translate engine for s390x CPU

2011-03-28 Thread Peter Maydell
On 24 March 2011 15:58, Alexander Graf wrote: > diff --git a/target-s390x/translate.c b/target-s390x/translate.c > +typedef struct DisasContext DisasContext; > +struct DisasContext { > +    uint64_t pc; > +    int is_jmp; > +    enum cc_op cc_op; > +    CPUS390XState *env; > +    struct Translati

Re: [Xen-devel] Re: [Qemu-devel] [PATCH V11 03/15] xen: Support new libxc calls from xen unstable.

2011-03-28 Thread Anthony PERARD
On Wed, Mar 23, 2011 at 10:43, Alexander Graf wrote: > > On 01.03.2011, at 19:35, anthony.per...@citrix.com wrote: > >> From: Anthony PERARD >> >> This patch updates the libxenctrl calls in Qemu to use the new interface, >> otherwise Qemu wouldn't be able to build against new versions of the >> l

Re: [Qemu-devel] [PATCH v23 08/11] libcacard: add passthru

2011-03-28 Thread Jes Sorensen
On 03/28/11 17:21, Alon Levy wrote: >> > Where does this odd LONG type come from? I think Windows uses LONG so >> > having your own type would conflict with that, and of course we don't >> > really want Windows types directly in QEMU either, so I am curious? >> > > This comes from pcsclite (which

Re: [Qemu-devel] [PATCH v23 08/11] libcacard: add passthru

2011-03-28 Thread Alon Levy
On Mon, Mar 28, 2011 at 03:27:49PM +0200, Jes Sorensen wrote: > On 03/23/11 14:19, Alon Levy wrote: > > diff --git a/libcacard/passthru.c b/libcacard/passthru.c > > new file mode 100644 > > index 000..d78e2db > > --- /dev/null > > +++ b/libcacard/passthru.c > > @@ -0,0 +1,609 @@ > > +/* > > + *

[Qemu-devel] [PATCH v6 3/4] piix_pci: optimize set irq path

2011-03-28 Thread Isaku Yamahata
optimize irq routing in piix_pic.c which has been a TODO. So far piix3 tracks each pirq level and checks whether a given pic pins is asserted by seeing if each pirq is mapped into the pic pin. This is independent on irq routing, but data path is on slow path. Given that irq routing is rarely chang

[Qemu-devel] [PATCH v6 1/4] pci: add accessor function to get irq levels

2011-03-28 Thread Isaku Yamahata
Introduce accessor function to know INTx levels. It will be used later by q35. Although piix_pci tracks the intx line levels, it can be eliminated by this helper function. Cc: Michael S. Tsirkin Signed-off-by: Isaku Yamahata --- hw/pci.c |7 +++ hw/pci.h |1 + 2 files changed, 8 ins

[Qemu-devel] [PATCH v6 4/4] piix_pci: load path clean up

2011-03-28 Thread Isaku Yamahata
The previous patch didn't change the behavior when load, it resulted in ugly code. This patch cleans it up. With this patch, pic irq lines are manipulated when loaded. It is expected that it won't change the behaviour because the interrupts are level: at the moment e.g. pci devices already reasser

[Qemu-devel] [PATCH v6 2/4] piix_pci: eliminate PIIX3State::pci_irq_levels

2011-03-28 Thread Isaku Yamahata
PIIX3State::pci_irq_levels are redundant which is already tracked by PCIBus layer. So eliminate them. Cc: Juan Quintela Cc: Michael S. Tsirkin Signed-off-by: Isaku Yamahata --- Changes v3 -> v4: - use PCI_NUM_PINS instead of magic number 4 Changes v2 -> v3: - rename member s/dummy_for_save_loa

[Qemu-devel] [PATCH v6 0/4] piix_pci: optimize irq data path

2011-03-28 Thread Isaku Yamahata
Here is v6 which fixed piix3_set_irq_pic(). 4/4 needs more extensive tests. So please feel free to pick it up now or drop it for now. patch description: This patch series optimizes irq data path of piix_pci. So far piix3 tracks each pirq level and checks whether a given pic pins is asserted by se

Re: [Xen-devel] Re: [Qemu-devel] [PATCH V11 02/15] xen: Make Xen build once.

2011-03-28 Thread Anthony PERARD
On Wed, Mar 23, 2011 at 10:57, Alexander Graf wrote: > > On 01.03.2011, at 19:35, anthony.per...@citrix.com wrote: > >> From: Anthony PERARD >> >> xen_domainbuild is now build in libhw. And xen_machine_pv is build only >> for i386 targets. >> >> Signed-off-by: Anthony PERARD >> --- >> Makefile.o

Re: [Qemu-devel] [PATCH 12/17] s390x: Prepare cpu.h for emulation

2011-03-28 Thread Peter Maydell
On 24 March 2011 15:58, Alexander Graf wrote: > diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h Minor nits only. > -    FPReg fregs[16]; /* FP registers */ > +    CPU_DoubleU fregs[16]; /* FP registers */ These changes mean that the FPReg typedef in this file is no longer used, so you migh

Re: [Qemu-devel] [PATCH v23 06/11] libcacard: initial commit

2011-03-28 Thread Alon Levy
On Mon, Mar 28, 2011 at 02:35:23PM +0200, Jes Sorensen wrote: > On 03/23/11 14:19, Alon Levy wrote: > > From: Robert Relyea > > > > libcacard emulates a Common Access Card (CAC) which is a standard > > for smartcards. It is used by the emulated ccid card introduced in > > a following patch. Docs

  1   2   >