[Qemu-devel] Re: [PATCH 04/26] pci: add accessor function to get irq levels

2011-03-16 Thread Isaku Yamahata
On Thu, Mar 17, 2011 at 07:29:09AM +0200, Michael S. Tsirkin wrote: > On Wed, Mar 16, 2011 at 06:29:15PM +0900, Isaku Yamahata wrote: > > Introduce accessor function to know INTx levels. > > It will be used later by q35. > > Although piix_pci tracks the intx line levels, it can be eliminated > > by

[Qemu-devel] Re: [PATCH 02/26] pci: add opaque argument to pci_map_irq_fn

2011-03-16 Thread Michael S. Tsirkin
On Wed, Mar 16, 2011 at 06:29:13PM +0900, Isaku Yamahata wrote: > Pass opaque argument to pci_map_irq_fn like pci_set_irq_fn. > ICH9 irq routing is not static, but configurable by chipset configuration > registers, so the corresponding irq mapping function of pci_map_irq_fn > needs to know the poin

Re: [Qemu-devel] Re: [PATCH 07/26] pci/p2pbr: generic pci p2p bridge

2011-03-16 Thread Michael S. Tsirkin
On Thu, Mar 17, 2011 at 02:26:24PM +0900, Isaku Yamahata wrote: > On Thu, Mar 17, 2011 at 07:17:18AM +0200, Michael S. Tsirkin wrote: > > > Anyway this patch isn't very critical. I think the available choice is > > > > > > - this patch > > > - modify the patch to use 14 arguments function. > > >

[Qemu-devel] Re: [PATCH 04/26] pci: add accessor function to get irq levels

2011-03-16 Thread Michael S. Tsirkin
On Wed, Mar 16, 2011 at 06:29:15PM +0900, Isaku Yamahata wrote: > Introduce accessor function to know INTx levels. > It will be used later by q35. > Although piix_pci tracks the intx line levels, it can be eliminated > by this helper function. At least for piix, the right thing to IMO is to have b

Re: [Qemu-devel] Re: [PATCH 07/26] pci/p2pbr: generic pci p2p bridge

2011-03-16 Thread Isaku Yamahata
On Thu, Mar 17, 2011 at 07:17:18AM +0200, Michael S. Tsirkin wrote: > > Anyway this patch isn't very critical. I think the available choice is > > > > - this patch > > - modify the patch to use 14 arguments function. > > Thus we can save much more lines. > > - Add one more p2p bridge code which

[Qemu-devel] "-soundhw es1370 :drive with bus0 ,unit=0 exists"

2011-03-16 Thread Wasim Muhammed
Hi All , I get this error "-soundhw es1370 :drive with bus0 ,unit=0 exists" when i launch my statically built qemu using this command # qemu-system-x86_64 winxp.img -soundhw es1370 can anyone help me resolve this as i want to desperately play sound on my win

Re: [Qemu-devel] v2 revamp acpitable parsing and allow to specify complete (headerful) table

2011-03-16 Thread Isaku Yamahata
Ouch. You already clean it up. Here is my diff from your patch. Can you please merged into the patch? changes are - eliminate unaligned access - error report - replace magic number with symbolic constants - unconverted strtol(base=10) Signed-off-by: Isaku Yamahata --- qemu-acpi-load-other-0/hw/

Re: [Qemu-devel] Re: [PATCH 07/26] pci/p2pbr: generic pci p2p bridge

2011-03-16 Thread Michael S. Tsirkin
On Thu, Mar 17, 2011 at 11:08:51AM +0900, Isaku Yamahata wrote: > On Wed, Mar 16, 2011 at 11:34:42PM +0200, Michael S. Tsirkin wrote: > > On Wed, Mar 16, 2011 at 06:29:18PM +0900, Isaku Yamahata wrote: > > > Create generic pci p2p bridge device which can be customized > > > via properties like vend

Re: [Qemu-devel] [PATCH 03/26] Add a hook to allow hypercalls to be emulated on PowerPC

2011-03-16 Thread David Gibson
On Wed, Mar 16, 2011 at 03:44:49PM -0500, Anthony Liguori wrote: > On 03/15/2011 11:56 PM, David Gibson wrote: > >From: David Gibson > > > >PowerPC and POWER chips since the POWER4 and 970 have a special > >hypervisor mode, and a corresponding form of the system call > >instruction which traps to t

[Qemu-devel] Re: [v1 PATCH 3/3]: Convert v9fs_stat to threaded model.

2011-03-16 Thread Venkateswararao Jujjuri (JV)
On 3/16/2011 10:10 AM, Stefan Hajnoczi wrote: > On Wed, Mar 16, 2011 at 2:33 PM, Venkateswararao Jujjuri (JV) > wrote: >> On 3/16/2011 3:23 AM, Stefan Hajnoczi wrote: >>> On Tue, Mar 15, 2011 at 10:39 AM, Arun R Bharadwaj >>> wrote: -static void v9fs_stat_post_lstat(V9fsState *s, V9fsStatSta

Re: [Qemu-devel] RFC: ACPI table loading

2011-03-16 Thread Isaku Yamahata
The behavior seems reasonable. So I cleaned it up for upstream merge. thanks, >From cd336e50ebda63ecd84f8172dcf4d4456059d615 Mon Sep 17 00:00:00 2001 Message-Id: From: Isaku Yamahata Date: Thu, 17 Mar 2011 12:28:52 +0900 Subject: [PATCH] acpi: rewamp acpitable parsing, and allow specifying com

[Qemu-devel] Re: [PATCH 25/26] Add a PAPR TCE-bypass mechanism for the pSeries machine

2011-03-16 Thread Benjamin Herrenschmidt
On Thu, 2011-03-17 at 13:21 +1100, David Gibson wrote: > > Is this an official extension used by anyone or is it your own > > invention that's not implemented in pHyp? > > The latter. The main reason is to avoid having to deal with TCEs in SLOF :-) Cheers, Ben.

Re: [Qemu-devel] [PATCH 14/26] Implement the bus structure for PAPR virtual IO

2011-03-16 Thread David Gibson
On Wed, Mar 16, 2011 at 05:04:43PM -0500, Anthony Liguori wrote: > On 03/15/2011 11:56 PM, David Gibson wrote: [snip] > >+static int spapr_vio_busdev_init(DeviceState *dev, DeviceInfo *info) > >+{ > >+VIOsPAPRDeviceInfo *_info = (VIOsPAPRDeviceInfo *)info; > >+VIOsPAPRDevice *_dev = (VIOsPA

Re: [Qemu-devel] [PATCH 13/26] Start implementing pSeries logical partition machine

2011-03-16 Thread David Gibson
On Wed, Mar 16, 2011 at 04:59:22PM -0500, Anthony Liguori wrote: > On 03/15/2011 11:56 PM, David Gibson wrote: > >This patch adds a "pseries" machine to qemu. This aims to emulate a > >logical partition on an IBM pSeries machine, compliant to the > >"PowerPC Architecture Platform Requirements" (PA

Re: [Qemu-devel] Re: [PATCH 03/26] Add a hook to allow hypercalls to be emulated on PowerPC

2011-03-16 Thread David Gibson
On Wed, Mar 16, 2011 at 04:58:41PM +, Stefan Hajnoczi wrote: > On Wed, Mar 16, 2011 at 1:46 PM, Alexander Graf wrote: > > On 03/16/2011 05:56 AM, David Gibson wrote: [snip] > scripts/checkpatch.pl is there to automate style checking. That's the > easiest way to check patches before submitting

[Qemu-devel] Re: [PATCH 19/26] Add PAPR H_VIO_SIGNAL hypercall and infrastructure for VIO interrupts

2011-03-16 Thread David Gibson
On Wed, Mar 16, 2011 at 04:49:07PM +0100, Alexander Graf wrote: > On 03/16/2011 05:56 AM, David Gibson wrote: [snip] > >+return H_PARAMETER;; > >+ > >+dev->signal_state = mode; > > No need to notify the device? No, at the point it would send an interrupt the device checks signal_state

Re: [Qemu-devel] [PATCH 22/26] Implement sPAPR Virtual LAN (ibmveth)

2011-03-16 Thread David Gibson
On Wed, Mar 16, 2011 at 05:29:48PM -0500, Anthony Liguori wrote: > On 03/15/2011 11:56 PM, David Gibson wrote: [snip] > >+lbuf = qemu_mallocz(total_len); > >+p = lbuf; > >+for (i = 0; i< nbufs; i++) { > >+ret = spapr_tce_dma_read(sdev, VLAN_BD_ADDR(bufs[i]), > >+

[Qemu-devel] Re: [PATCH 25/26] Add a PAPR TCE-bypass mechanism for the pSeries machine

2011-03-16 Thread David Gibson
On Wed, Mar 16, 2011 at 05:43:55PM +0100, Alexander Graf wrote: > On 03/16/2011 05:57 AM, David Gibson wrote: > >From: Ben Herrenschmidt > > > >Usually, PAPR virtual IO devices use a virtual IOMMU mechanism, TCEs, > >to mediate all DMA transfers. While this is necessary for some sorts of > >operat

Re: [Qemu-devel] [PATCH 18/26] Implement the PAPR (pSeries) virtualized interrupt controller (xics)

2011-03-16 Thread David Gibson
On Wed, Mar 16, 2011 at 05:16:07PM -0500, Anthony Liguori wrote: > On 03/15/2011 11:56 PM, David Gibson wrote: [snip] > >+#include > > This isn't needed and it'll break the Windows build. We carry a > global mutex whenever QEMU code executes. Good point, I wrote this before I realized all the q

[Qemu-devel] Re: [PATCH 21/26] Implement TCE translation for sPAPR VIO

2011-03-16 Thread David Gibson
On Wed, Mar 16, 2011 at 05:03:54PM +0100, Alexander Graf wrote: > On 03/16/2011 05:56 AM, David Gibson wrote: > >From: Ben Herrenschmidt [snip] > >+/* XX Might want to special case KVM for speed ? */ > > XXX Comment removed. In fact, we've now implemented the KVM acceleration in a later series o

[Qemu-devel] Re: [PATCH 22/26] Implement sPAPR Virtual LAN (ibmveth)

2011-03-16 Thread David Gibson
On Wed, Mar 16, 2011 at 05:12:17PM +0100, Alexander Graf wrote: > On 03/16/2011 05:56 AM, David Gibson wrote: [snip] > >+#include "hw.h" > >+#include "net.h" > >+#include "hw/qdev.h" > >+#include "hw/spapr.h" > >+#include "hw/spapr_vio.h" > >+ > >+#include > > Hrm - might be good to protect compil

[Qemu-devel] Re: [PATCH 16/26] Implement hcall based RTAS for pSeries machines

2011-03-16 Thread David Gibson
On Wed, Mar 16, 2011 at 04:08:30PM +0100, Alexander Graf wrote: > On 03/16/2011 05:56 AM, David Gibson wrote: [snip] > >diff --git a/pc-bios/spapr-rtas.bin b/pc-bios/spapr-rtas.bin > >new file mode 100644 > >index > >..eade9c0e8ff0fd3071e3a6638a11c1a2e9a4715

[Qemu-devel] Re: [PATCH 18/26] Implement the PAPR (pSeries) virtualized interrupt controller (xics)

2011-03-16 Thread David Gibson
On Wed, Mar 16, 2011 at 04:47:11PM +0100, Alexander Graf wrote: > On 03/16/2011 05:56 AM, David Gibson wrote: [snip] > >+/* static void ics_resend(struct icp_server_state *ss) */ > >+/* { */ > >+/* int i; */ > >+ > >+/* for (i = 0; i< xics->nr_irqs; i++) */ > >+/* ics_resend_irq(xi

Re: [Qemu-devel] Re: [PATCH 07/26] pci/p2pbr: generic pci p2p bridge

2011-03-16 Thread Isaku Yamahata
On Wed, Mar 16, 2011 at 11:34:42PM +0200, Michael S. Tsirkin wrote: > On Wed, Mar 16, 2011 at 06:29:18PM +0900, Isaku Yamahata wrote: > > Create generic pci p2p bridge device which can be customized > > via properties like vendor id/device id and so on. > > With this, we can avoid to create many pc

[Qemu-devel] Re: [PATCH 15/26] Virtual hash page table handling on pSeries machine'

2011-03-16 Thread David Gibson
On Wed, Mar 16, 2011 at 04:03:47PM +0100, Alexander Graf wrote: > On 03/16/2011 05:56 AM, David Gibson wrote: [snip] > >@@ -248,6 +261,16 @@ static void ppc_spapr_init(ram_addr_t ram_size, > > ram_offset = qemu_ram_alloc(NULL, "ppc_spapr.ram", ram_size); > > cpu_register_physical_memory(0

[Qemu-devel] Re: [PATCH 01/14] lm32: add Milkymist AC97 support

2011-03-16 Thread malc
On Thu, 17 Mar 2011, Michael Walle wrote: > Am Mittwoch 16 M?rz 2011, 19:12:44 schrieb malc: > > > > diff --git a/hw/milkymist-ac97.c b/hw/milkymist-ac97.c > > > > new file mode 100644 > > > > index 000..6c9e318 > > > > --- /dev/null > > > > +++ b/hw/milkymist-ac97.c > > > > @@ -0,0 +1,335 @@

[Qemu-devel] Re: [PATCH 01/14] lm32: add Milkymist AC97 support

2011-03-16 Thread Alexander Graf
On 17.03.2011, at 00:02, Michael Walle wrote: > Am Mittwoch 16 März 2011, 19:12:44 schrieb malc: diff --git a/hw/milkymist-ac97.c b/hw/milkymist-ac97.c new file mode 100644 index 000..6c9e318 --- /dev/null +++ b/hw/milkymist-ac97.c @@ -0,0 +1,335 @@ +/*

Re: [Qemu-devel] [PATCH 02/17] lm32: translation routines

2011-03-16 Thread Alexander Graf
On 17.03.2011, at 00:08, Michael Walle wrote: > Am Freitag 11 März 2011, 06:57:18 schrieben Sie: >> On 17.02.2011, at 23:51, Michael Walle wrote: >>> Am Samstag 12 Februar 2011, 07:49:52 schrieb Blue Swirl: > That said, IMHO the best handling of unknown opcodes would be to kill > the

Re: [Qemu-devel] [PATCH 13/26] Start implementing pSeries logical partition machine

2011-03-16 Thread Alexander Graf
On 16.03.2011, at 22:59, Anthony Liguori wrote: > On 03/15/2011 11:56 PM, David Gibson wrote: >> This patch adds a "pseries" machine to qemu. This aims to emulate a >> logical partition on an IBM pSeries machine, compliant to the >> "PowerPC Architecture Platform Requirements" (PAPR) documen

Re: [Qemu-devel] [PATCH 02/17] lm32: translation routines

2011-03-16 Thread Michael Walle
Am Freitag 11 März 2011, 06:57:18 schrieben Sie: > On 17.02.2011, at 23:51, Michael Walle wrote: > > Am Samstag 12 Februar 2011, 07:49:52 schrieb Blue Swirl: > >>> That said, IMHO the best handling of unknown opcodes would be to kill > >>> the VM. > >> > >> In this case it should be OK. Alternativ

[Qemu-devel] Re: [PATCH 01/14] lm32: add Milkymist AC97 support

2011-03-16 Thread Michael Walle
Am Mittwoch 16 März 2011, 19:12:44 schrieb malc: > > > diff --git a/hw/milkymist-ac97.c b/hw/milkymist-ac97.c > > > new file mode 100644 > > > index 000..6c9e318 > > > --- /dev/null > > > +++ b/hw/milkymist-ac97.c > > > @@ -0,0 +1,335 @@ > > > +/* > > > + * QEMU model of the Milkymist System C

Re: [Qemu-devel] [PATCH 22/26] Implement sPAPR Virtual LAN (ibmveth)

2011-03-16 Thread Anthony Liguori
On 03/15/2011 11:56 PM, David Gibson wrote: This patch implements the PAPR specified Inter Virtual Machine Logical LAN; that is the virtual hardware used by the Linux ibmveth driver. Signed-off-by: Paul Mackerras Signed-off-by: David Gibson --- Makefile.target |2 +- hw/spapr.c | 2

[Qemu-devel] Re: [PATCH 2/2] net/socket: allow ipv6 for net_socket_listen_init and net_socket_connect_init

2011-03-16 Thread Juan Quintela
Peter Maydell wrote: > On 16 March 2011 21:01, Juan Quintela wrote: >> -    ret = bind(fd, (struct sockaddr *)&saddr, sizeof(saddr)); >> +    ret = tcp_server_start(host_str, &fd); >>     if (ret < 0) { >> -        perror("bind"); >> +        perror("tcp_server_start"); >>         return -1; >>  

[Qemu-devel] Re: [PATCH 1/2] Use getaddrinfo for migration

2011-03-16 Thread Juan Quintela
Peter Maydell wrote: > On 16 March 2011 21:01, Juan Quintela wrote: >> +static int tcp_server_bind(int fd, struct addrinfo *rp) >> +{ >> +    int val = 1; >> +    int ret; >> + >> +    /* allow fast reuse */ >> +    setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, (const char *)&val, >> +               s

Re: [Qemu-devel] [PATCH 21/26] Implement TCE translation for sPAPR VIO

2011-03-16 Thread Anthony Liguori
On 03/15/2011 11:56 PM, David Gibson wrote: From: Ben Herrenschmidt This patch implements the necessary infrastructure and hypercalls for sPAPR's TCE (Translation Control Entry) IOMMU mechanism. This is necessary for all virtual IO devices which do DMA (i.e. nearly all of them). Signed-off-by:

Re: [Qemu-devel] [PATCH 18/26] Implement the PAPR (pSeries) virtualized interrupt controller (xics)

2011-03-16 Thread Anthony Liguori
On 03/15/2011 11:56 PM, David Gibson wrote: PAPR defines an interrupt control architecture which is logically divided into ICS (Interrupt Control Presentation, each unit is responsible for presenting interrupts to a particular "interrupt server", i.e. CPU) and ICS (Interrupt Control Source, each

Re: [Qemu-devel] [PATCH 16/26] Implement hcall based RTAS for pSeries machines

2011-03-16 Thread Anthony Liguori
On 03/15/2011 11:56 PM, David Gibson wrote: diff --git a/hw/spapr_rtas.c b/hw/spapr_rtas.c new file mode 100644 index 000..c606018 --- /dev/null +++ b/hw/spapr_rtas.c @@ -0,0 +1,104 @@ Needs copyright Regards, Anthony Liguori +#include "cpu.h" +#include "sysemu.h" +#include "qemu-char.h

Re: [Qemu-devel] [PATCH 1/2] Use getaddrinfo for migration

2011-03-16 Thread Peter Maydell
On 16 March 2011 21:01, Juan Quintela wrote: > +static int tcp_server_bind(int fd, struct addrinfo *rp) > +{ > +    int val = 1; > +    int ret; > + > +    /* allow fast reuse */ > +    setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, (const char *)&val, > +               sizeof(val)); > + > +    ret = bi

Re: [Qemu-devel] [PATCH 14/26] Implement the bus structure for PAPR virtual IO

2011-03-16 Thread Anthony Liguori
On 03/15/2011 11:56 PM, David Gibson wrote: This extends the "pseries" (PAPR) machine to include a virtual IO bus supporting the PAPR defined hypercall based virtual IO mechanisms. So far only one VIO device is provided, the vty / vterm, providing a full console (polled only, for now). Signed-o

Re: [Qemu-devel] [PATCH 13/26] Start implementing pSeries logical partition machine

2011-03-16 Thread Anthony Liguori
On 03/15/2011 11:56 PM, David Gibson wrote: This patch adds a "pseries" machine to qemu. This aims to emulate a logical partition on an IBM pSeries machine, compliant to the "PowerPC Architecture Platform Requirements" (PAPR) document. Can we call the machine 'papr' or at least 'lpar' Technic

[Qemu-devel] Re: [PATCH 07/26] pci/p2pbr: generic pci p2p bridge

2011-03-16 Thread Michael S. Tsirkin
On Wed, Mar 16, 2011 at 06:29:18PM +0900, Isaku Yamahata wrote: > Create generic pci p2p bridge device which can be customized > via properties like vendor id/device id and so on. > With this, we can avoid to create many pci p2p bridge which only > differs in those ids. > > Cc: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH 2/2] net/socket: allow ipv6 for net_socket_listen_init and net_socket_connect_init

2011-03-16 Thread Peter Maydell
On 16 March 2011 21:01, Juan Quintela wrote: > -    ret = bind(fd, (struct sockaddr *)&saddr, sizeof(saddr)); > +    ret = tcp_server_start(host_str, &fd); >     if (ret < 0) { > -        perror("bind"); > +        perror("tcp_server_start"); >         return -1; >     } It looks like tcp_server_

[Qemu-devel] [Bug 735752] Re: qemu squeeze crashes "BUG: unable to handle kernel NULL pointer dereference at (null)"

2011-03-16 Thread Aidar Kamalov
Issue is trigered, but there are nothing changes, i will try to get core Mar 16 21:50:29 mainhost kernel: [28123.087654] BUG: unable to handle kernel NULL pointer dereference at (null) Mar 16 21:50:29 mainhost kernel: [28123.088106] IP: [] 0x

[Qemu-devel] [PATCH 1/2] Use getaddrinfo for migration

2011-03-16 Thread Juan Quintela
This allows us to use ipv4/ipv6 for migration addresses. Once there, it also uses /etc/services names (it came free). Signed-off-by: Juan Quintela --- migration-tcp.c | 53 ++--- net.c | 113 +++ qemu_socket.h

[Qemu-devel] [PATCH 2/2] net/socket: allow ipv6 for net_socket_listen_init and net_socket_connect_init

2011-03-16 Thread Juan Quintela
Remove use of parse_host_port. Signed-off-by: Juan Quintela --- net/socket.c | 60 ++--- 1 files changed, 11 insertions(+), 49 deletions(-) diff --git a/net/socket.c b/net/socket.c index 7337f4f..a28dfdd 100644 --- a/net/socket.c +++ b/net/s

[Qemu-devel] [PATCH 0/2] Allow ipv6 for migration

2011-03-16 Thread Juan Quintela
Hi 1st patch moves migration to use getaddrinfo() instead of parse_host_port(). This allows us to use ipv6 addresses. As an extra bonus, now we can use names from /etc/services. Code for net_socket_listen_init() and net_socket_connect_init() was almost identical to migration one, so also changed

Re: [Qemu-devel] [PATCH 03/26] Add a hook to allow hypercalls to be emulated on PowerPC

2011-03-16 Thread Anthony Liguori
On 03/15/2011 11:56 PM, David Gibson wrote: From: David Gibson PowerPC and POWER chips since the POWER4 and 970 have a special hypervisor mode, and a corresponding form of the system call instruction which traps to the hypervisor. qemu currently has stub implementations of hypervisor mode. Tha

Re: [Qemu-devel] [Bug 735752] Re: qemu squeeze crashes "BUG: unable to handle kernel NULL pointer dereference at (null)"

2011-03-16 Thread Stefan Hajnoczi
On Wed, Mar 16, 2011 at 8:27 PM, Aidar Kamalov <735...@bugs.launchpad.net> wrote: > I have compiled with CONFIG_DEBUG_INFO, but core is not creating, i > think i do all right: > > mainhost log # zcat /proc/config.gz |grep CONFIG_DEBUG_INFO > CONFIG_DEBUG_INFO=y > # CONFIG_DEBUG_INFO_REDUCED is not

[Qemu-devel] v2 revamp acpitable parsing and allow to specify complete (headerful) table

2011-03-16 Thread Michael Tokarev
This patch almost rewrites acpi_table_add() function (but still leaves it using old get_param_value() interface). The result is that it's now possible to specify whole table (together with a header) in an external file, instead of just data portion, with a new file= parameter, but at the same time

Re: [Qemu-devel] Re: [PATCH 21/26] Implement TCE translation for sPAPR VIO

2011-03-16 Thread Benjamin Herrenschmidt
On Wed, 2011-03-16 at 15:22 -0500, Anthony Liguori wrote: > > But BTW, if you're already being evil and using alloca, it's a whole > lot > nicer to just do: > > uint8_t zeros[size]; Right. I haven't written that bit of the code so I'll let David fix it but it does indeed look nicer. Eventually,

[Qemu-devel] [Bug 735752] Re: qemu squeeze crashes "BUG: unable to handle kernel NULL pointer dereference at (null)"

2011-03-16 Thread Aidar Kamalov
I have compiled with CONFIG_DEBUG_INFO, but core is not creating, i think i do all right: mainhost log # zcat /proc/config.gz |grep CONFIG_DEBUG_INFO CONFIG_DEBUG_INFO=y # CONFIG_DEBUG_INFO_REDUCED is not set mainhost log # cat /etc/security/limits.conf | grep core #- core - limits the co

Re: [Qemu-devel] Re: [PATCH 21/26] Implement TCE translation for sPAPR VIO

2011-03-16 Thread Anthony Liguori
On 03/16/2011 03:05 PM, Benjamin Herrenschmidt wrote: On Wed, 2011-03-16 at 17:03 +0100, Alexander Graf wrote: +int spapr_tce_dma_zero(VIOsPAPRDevice *dev, uint64_t taddr, uint32_t size) +{ +uint8_t *zeroes; + +#ifdef DEBUG_TCE +fprintf(stderr, "spapr_tce_dma_zero taddr=0x%llx size=0x%

Re: [Qemu-devel] Re: [PATCH 21/26] Implement TCE translation for sPAPR VIO

2011-03-16 Thread Anthony Liguori
On 03/16/2011 03:05 PM, Benjamin Herrenschmidt wrote: On Wed, 2011-03-16 at 17:03 +0100, Alexander Graf wrote: +int spapr_tce_dma_zero(VIOsPAPRDevice *dev, uint64_t taddr, uint32_t size) +{ +uint8_t *zeroes; + +#ifdef DEBUG_TCE +fprintf(stderr, "spapr_tce_dma_zero taddr=0x%llx size=0x%

Re: [Qemu-devel] Re: [PATCH 24/26] Implement PAPR virtual SCSI interface (ibmvscsi)

2011-03-16 Thread Anthony Liguori
On 03/16/2011 03:08 PM, Benjamin Herrenschmidt wrote: On Wed, 2011-03-16 at 17:41 +0100, Alexander Graf wrote: +/* + * Common MAD header + */ +struct mad_common { +uint32_t type; +uint16_t status; +uint16_t length; +uint64_t tag; Is this an in-memory representation? If so, it s

[Qemu-devel] rewamp acpitable parsing and allow to specify complete (headerful) table

2011-03-16 Thread Michael Tokarev
This patch almost rewrites acpi_table_add() function (but still leaves it using old get_param_value() interface). The result is that it's now possible to specify whole table (together with a header) in an external file, instead of just data portion, with a new file= parameter, but at the same time

[Qemu-devel] Re: [PATCH 21/35] Break up user and system cpu_interrupt implementations

2011-03-16 Thread Marcelo Tosatti
On Wed, Mar 16, 2011 at 10:02:18AM +0100, Jan Kiszka wrote: > On 2011-03-15 22:50, Marcelo Tosatti wrote: > > From: Jan Kiszka > > > > Both have only two lines in common, and we will convert the system > > service into a callback which is of no use for user mode operation. > > >From KVM POV, the

[Qemu-devel] Re: [PATCH 24/26] Implement PAPR virtual SCSI interface (ibmvscsi)

2011-03-16 Thread Benjamin Herrenschmidt
On Wed, 2011-03-16 at 17:41 +0100, Alexander Graf wrote: > > +/* > > + * Common MAD header > > + */ > > +struct mad_common { > > +uint32_t type; > > +uint16_t status; > > +uint16_t length; > > +uint64_t tag; > > Is this an in-memory representation? If so, it should be packed, righ

[Qemu-devel] Re: [PATCH 21/26] Implement TCE translation for sPAPR VIO

2011-03-16 Thread Benjamin Herrenschmidt
On Wed, 2011-03-16 at 17:03 +0100, Alexander Graf wrote: > > > +int spapr_tce_dma_zero(VIOsPAPRDevice *dev, uint64_t taddr, > uint32_t size) > > +{ > > +uint8_t *zeroes; > > + > > +#ifdef DEBUG_TCE > > +fprintf(stderr, "spapr_tce_dma_zero taddr=0x%llx size=0x%x\n", > > +(unsign

Re: [Qemu-devel] Re: [PATCH 00/15] QAPI Round 1 (core code generator) (v2)

2011-03-16 Thread Anthony Liguori
On 03/16/2011 02:27 PM, Luiz Capitulino wrote: You can design interfaces in Python that rely on variant arrays or types, or that add keyword values to arguments, but the absence of those does not make a Bad Library in Python. This has nothing to do with the need for bindings. I mentioned bind

Re: [Qemu-devel] Re: [PATCH 00/15] QAPI Round 1 (core code generator) (v2)

2011-03-16 Thread Luiz Capitulino
On Wed, 16 Mar 2011 13:32:50 -0500 Anthony Liguori wrote: > On 03/16/2011 01:09 PM, Luiz Capitulino wrote: > >> This is a shift in our direction but the good news is that the practical > >> impact is small. But I don't think there's a lot of value of focusing > >> on non-C consumers because any

Re: [Qemu-devel] [PATCH] pc-bios: Use iPXE ROMs

2011-03-16 Thread Alex Williamson
On Wed, 2011-03-16 at 18:48 +, Stefan Hajnoczi wrote: > On Tue, Mar 15, 2011 at 5:00 PM, Alex Williamson > wrote: > > diff --git a/scripts/refresh-pxe-roms.sh b/scripts/refresh-pxe-roms.sh > > Please enclose variable expansions in double-quotes so paths with > spaces in them work. For exampl

Re: [Qemu-devel] [PATCH] pc-bios: Use iPXE ROMs

2011-03-16 Thread Stefan Hajnoczi
On Tue, Mar 15, 2011 at 5:00 PM, Alex Williamson wrote: > diff --git a/scripts/refresh-pxe-roms.sh b/scripts/refresh-pxe-roms.sh Please enclose variable expansions in double-quotes so paths with spaces in them work. For example: cp $BUILD_DIR/$LOCAL_CONFIG $SAVED_CONFIG This will not do what yo

Re: [Qemu-devel] Re: [PATCH 00/15] QAPI Round 1 (core code generator) (v2)

2011-03-16 Thread Anthony Liguori
On 03/16/2011 01:09 PM, Luiz Capitulino wrote: This is a shift in our direction but the good news is that the practical impact is small. But I don't think there's a lot of value of focusing on non-C consumers because any non-C consumer is capable of consuming a good C interface (but the inverse

[Qemu-devel] Re: [PATCH 01/14] lm32: add Milkymist AC97 support

2011-03-16 Thread malc
On Wed, 16 Mar 2011, Alexander Graf wrote: > On 03/07/2011 11:32 PM, Michael Walle wrote: > > This patch adds support for the Milkymist AC97 compatible sound output and > > input core. > > Malc, could you please take a look at this? :) Okay... > > > Signed-off-by: Michael Walle > > --- > > M

Re: [Qemu-devel] Re: [PATCH 00/15] QAPI Round 1 (core code generator) (v2)

2011-03-16 Thread Luiz Capitulino
On Wed, 16 Mar 2011 10:59:33 -0500 Anthony Liguori wrote: > On 03/16/2011 09:34 AM, Luiz Capitulino wrote: > > On Fri, 11 Mar 2011 17:05:30 -0600 > > Anthony Liguori wrote: > > > >> For more information about the background of QAPI, see > >> http://wiki.qemu.org/Features/QAPI > >> > >> This seri

Re: [Qemu-devel] Re: [PATCH 00/15] QAPI Round 1 (core code generator) (v2)

2011-03-16 Thread Anthony Liguori
On 03/16/2011 11:31 AM, Paolo Bonzini wrote: On 03/16/2011 05:03 PM, Anthony Liguori wrote: So for an event, you just need to do: { 'signal': 'vnc-connected', 'data': { 'client': 'VncClientInfo' } } And you can add new fields to the VncClientInfo structure as much as you'd like without worryin

Re: [Qemu-devel] Re: KVM call agenda for Jan 25

2011-03-16 Thread Stefan Hajnoczi
On Tue, Mar 15, 2011 at 10:27 AM, Kevin Wolf wrote: > Am 14.03.2011 16:13, schrieb Dushyant Bansal: >>> >>> Nice that qemu-img convert isn't that far out by default on raw :). >>> >>> About Google Summer of Code, I have posted my take on applying and >>> want to share that with you and qemu-devel:

[Qemu-devel] Re: [v1 PATCH 3/3]: Convert v9fs_stat to threaded model.

2011-03-16 Thread Stefan Hajnoczi
On Wed, Mar 16, 2011 at 2:33 PM, Venkateswararao Jujjuri (JV) wrote: > On 3/16/2011 3:23 AM, Stefan Hajnoczi wrote: >> On Tue, Mar 15, 2011 at 10:39 AM, Arun R Bharadwaj >> wrote: >>> -static void v9fs_stat_post_lstat(V9fsState *s, V9fsStatState *vs, int err) >>> +static void v9fs_stat_post_lstat

Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-16 Thread Jes Sorensen
On 03/16/11 16:52, Alon Levy wrote: > +void qxl_server_request_cursor_set(PCIQXLDevice *qxl, QEMUCursor *c, int x, > int y) > +{ > +QXLServerCursorSetRequest req; > +int r; > + > +req.req = QXL_SERVER_CURSOR_SET; > +req.data.c = c; > +req.data.x = x; > +req.data.y = y; > +

Re: [Qemu-devel] [PATCH v3 1/4] qxl/spice-display: move pipe to ssd

2011-03-16 Thread Alon Levy
On Wed, Mar 16, 2011 at 05:39:32PM +0100, Jes Sorensen wrote: > On 03/16/11 16:52, Alon Levy wrote: > > This moves the int pipe[2] and pthread_t main data from the > > PCIQXLDevice struct to the SimpleSpiceDisplay. This will let us > > reuse it in the next patch for both -spice with no -qxl usage a

Re: [Qemu-devel] Re: [PATCH 00/15] QAPI Round 1 (core code generator) (v2)

2011-03-16 Thread Paolo Bonzini
On 03/16/2011 05:03 PM, Anthony Liguori wrote: So for an event, you just need to do: { 'signal': 'vnc-connected', 'data': { 'client': 'VncClientInfo' } } And you can add new fields to the VncClientInfo structure as much as you'd like without worrying about breaking the C ABI. So why couldn't

Re: [Qemu-devel] [PATCH] target-i386: Do not announce extended mwait features

2011-03-16 Thread Alexander Graf
On 03/16/2011 03:25 PM, Adam Lackorzynski wrote: CPUID claims that extended monitor/mwait features are available but the mwait helper instantly raises a GPF if they are used. Thus do not announce that the extension are available. Would be better to just implement mwait, no? Alex Signed-off-

[Qemu-devel] Re: [PATCH 00/14] lm32: Milkymist board support

2011-03-16 Thread Alexander Graf
On 03/07/2011 11:32 PM, Michael Walle wrote: This is the second (and last) patchset of the LatticeMico32 support. It adds almost complete support for the opensource and openhardware Milkymist One board [1]. [1] http://www.milkymist.org/mmone.html From my side you get: Acked-by: Alexander Gra

[Qemu-devel] Re: [PATCH 1/4] block: clarify the meaning of BDRV_O_NOCACHE

2011-03-16 Thread Stefan Hajnoczi
On Wed, Mar 16, 2011 at 2:08 PM, Christoph Hellwig wrote: > On Wed, Mar 16, 2011 at 09:42:37AM +, Stefan Hajnoczi wrote: >> -    writethrough = ((flags & BDRV_O_CACHE_MASK) == 0); >> +    writethrough = ((flags & (BDRV_O_CACHE_WB | BDRV_O_NO_FLUSH)) == 0); > > or rather > >        writethrough

Re: [Qemu-devel] Re: [PATCH 03/26] Add a hook to allow hypercalls to be emulated on PowerPC

2011-03-16 Thread Stefan Hajnoczi
On Wed, Mar 16, 2011 at 1:46 PM, Alexander Graf wrote: > On 03/16/2011 05:56 AM, David Gibson wrote: >> >> From: David Gibson >> >> PowerPC and POWER chips since the POWER4 and 970 have a special >> hypervisor mode, and a corresponding form of the system call >> instruction which traps to the hype

[Qemu-devel] Re: [v1 PATCH 2/3]: Helper routines to use GLib threadpool infrastructure in 9pfs.

2011-03-16 Thread Stefan Hajnoczi
On Wed, Mar 16, 2011 at 2:20 PM, Venkateswararao Jujjuri (JV) wrote: > On 3/16/2011 6:10 AM, Anthony Liguori wrote: >> On 03/16/2011 04:20 AM, Stefan Hajnoczi wrote: >>> On Tue, Mar 15, 2011 at 1:13 PM, Anthony Liguori   >>> wrote: Why even bothering signaling for completion with the virtio-9

Re: [Qemu-devel] Re: [PATCH 24/26] Implement PAPR virtual SCSI interface (ibmvscsi)

2011-03-16 Thread Anthony Liguori
On 03/16/2011 11:41 AM, Alexander Graf wrote: new file mode 100644 index 000..9d55fc4 --- /dev/null +++ b/hw/srp.h @@ -0,0 +1,241 @@ +/* + * Copyright (c) 2005 Cisco Systems. All rights reserved. + * + * This software is available to you under a choice of one of two + * licenses. You may ch

Re: [Qemu-devel] [PATCH v3 1/4] qxl/spice-display: move pipe to ssd

2011-03-16 Thread Jes Sorensen
On 03/16/11 16:52, Alon Levy wrote: > This moves the int pipe[2] and pthread_t main data from the > PCIQXLDevice struct to the SimpleSpiceDisplay. This will let us > reuse it in the next patch for both -spice with no -qxl usage and > for vga mode from qxl. > > Also move the pipe creation function

[Qemu-devel] Re: [PATCH 25/26] Add a PAPR TCE-bypass mechanism for the pSeries machine

2011-03-16 Thread Alexander Graf
On 03/16/2011 05:57 AM, David Gibson wrote: From: Ben Herrenschmidt Usually, PAPR virtual IO devices use a virtual IOMMU mechanism, TCEs, to mediate all DMA transfers. While this is necessary for some sorts of operation, it can be complex to program and slow for others. This patch implements a

[Qemu-devel] Re: [PATCH 01/14] lm32: add Milkymist AC97 support

2011-03-16 Thread Alexander Graf
On 03/07/2011 11:32 PM, Michael Walle wrote: This patch adds support for the Milkymist AC97 compatible sound output and input core. Malc, could you please take a look at this? :) Signed-off-by: Michael Walle --- Makefile.target |1 + configure |3 + hw/milkymist-ac97

[Qemu-devel] Re: [PATCH 24/26] Implement PAPR virtual SCSI interface (ibmvscsi)

2011-03-16 Thread Alexander Graf
On 03/16/2011 05:57 AM, David Gibson wrote: This patch implements the infrastructure and hypercalls necessary for the PAPR specified Virtual SCSI interface. This is the normal method for providing (virtual) disks to PAPR partitions. Signed-off-by: Ben Herrenschmidt Signed-off-by: David Gibson -

[Qemu-devel] Re: [PATCH 21/26] Implement TCE translation for sPAPR VIO

2011-03-16 Thread Alexander Graf
On 03/16/2011 05:56 AM, David Gibson wrote: From: Ben Herrenschmidt This patch implements the necessary infrastructure and hypercalls for sPAPR's TCE (Translation Control Entry) IOMMU mechanism. This is necessary for all virtual IO devices which do DMA (i.e. nearly all of them). Signed-off-by:

[Qemu-devel] Re: [PATCH 23/26] Implement PAPR CRQ hypercalls

2011-03-16 Thread Alexander Graf
On 03/16/2011 05:57 AM, David Gibson wrote: From: Ben Herrenschmidt This patch implements the infrastructure and hypercalls necessary for the PAPR specified CRQ (Command Request Queue) mechanism. This general request queueing system is used by many of the PAPR virtual IO devices, including the

[Qemu-devel] Re: [PATCH 22/26] Implement sPAPR Virtual LAN (ibmveth)

2011-03-16 Thread Alexander Graf
On 03/16/2011 05:56 AM, David Gibson wrote: This patch implements the PAPR specified Inter Virtual Machine Logical LAN; that is the virtual hardware used by the Linux ibmveth driver. Signed-off-by: Paul Mackerras Signed-off-by: David Gibson --- Makefile.target |2 +- hw/spapr.c | 2

Re: [Qemu-devel] Re: [PATCH 00/15] QAPI Round 1 (core code generator) (v2)

2011-03-16 Thread Anthony Liguori
On 03/16/2011 09:49 AM, Paolo Bonzini wrote: On 03/16/2011 03:34 PM, Luiz Capitulino wrote: +## +# @put_event: +# +# Disconnect a signal. This command is used to disconnect from a signal based +# on the handle returned by a signal accessor. +# +# @tag: the handle returned by a signal accessor

Re: [Qemu-devel] Re: [PATCH 00/15] QAPI Round 1 (core code generator) (v2)

2011-03-16 Thread Anthony Liguori
On 03/16/2011 10:00 AM, Luiz Capitulino wrote: On Wed, 16 Mar 2011 15:49:59 +0100 Paolo Bonzini wrote: On 03/16/2011 03:34 PM, Luiz Capitulino wrote: +## +# @put_event: +# +# Disconnect a signal. This command is used to disconnect from a signal based +# on the handle returned by a signal acc

Re: [Qemu-devel] Re: [PATCH 00/15] QAPI Round 1 (core code generator) (v2)

2011-03-16 Thread Anthony Liguori
On 03/16/2011 09:34 AM, Luiz Capitulino wrote: On Fri, 11 Mar 2011 17:05:30 -0600 Anthony Liguori wrote: For more information about the background of QAPI, see http://wiki.qemu.org/Features/QAPI This series depends on 'QAPI Round 0' which I posted earlier. Since v2, the major changes are:

[Qemu-devel] Re: [PATCH v3 3/4] qxl/spice: remove qemu_mutex_{un, }lock_iothread around dispatcher

2011-03-16 Thread Hans de Goede
Looks good now, ack: Acked-by: Hans de Goede On 03/16/2011 04:52 PM, Alon Levy wrote: with the previous patch making sure get_command no longer needs to lock, there is no reason to drop the qemu iothread mutex in qxl.c and in ui/spice-display.c The only location where the lock remains are th

[Qemu-devel] Re: [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-16 Thread Hans de Goede
Looks good now, ack: Acked-by: Hans de Goede On 03/16/2011 04:52 PM, Alon Levy wrote: Switching locking protection of ds->cursor_set/cursor_move to moving every call to these functions into the iothread and using the ssd->pipe to transfer that, adding QXL_SERVER_CURSOR_SET, QXL_SERVER_CURSOR_

[Qemu-devel] Re: [PATCH v3 2/4] qxl: implement get_command in vga mode without locks

2011-03-16 Thread Hans de Goede
Looks good now, ack: Acked-by: Hans de Goede On 03/16/2011 04:52 PM, Alon Levy wrote: From: Uri Lublin This patch and the next drop the requirement to lose the global qemu mutex during dispatcher calls. This patch enables it, the next drops the unlock/lock pairs around dispatcher calls. The

[Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-16 Thread Alon Levy
Switching locking protection of ds->cursor_set/cursor_move to moving every call to these functions into the iothread and using the ssd->pipe to transfer that, adding QXL_SERVER_CURSOR_SET, QXL_SERVER_CURSOR_MOVE. This is tested with both -vnc :0 -spice and -sdl -spice. --- hw/qxl-render.c|

Re: [Qemu-devel] [PATCH v3 1/4] qxl/spice-display: move pipe to ssd

2011-03-16 Thread Hans de Goede
Looks good now, ack: Acked-by: Hans de Goede On 03/16/2011 04:52 PM, Alon Levy wrote: This moves the int pipe[2] and pthread_t main data from the PCIQXLDevice struct to the SimpleSpiceDisplay. This will let us reuse it in the next patch for both -spice with no -qxl usage and for vga mode from

[Qemu-devel] [PATCH v3 3/4] qxl/spice: remove qemu_mutex_{un, }lock_iothread around dispatcher

2011-03-16 Thread Alon Levy
with the previous patch making sure get_command no longer needs to lock, there is no reason to drop the qemu iothread mutex in qxl.c and in ui/spice-display.c The only location where the lock remains are the cursor related callbacks, that path is currently broken. It is only triggered if running s

[Qemu-devel] [PATCH v3 2/4] qxl: implement get_command in vga mode without locks

2011-03-16 Thread Alon Levy
From: Uri Lublin This patch and the next drop the requirement to lose the global qemu mutex during dispatcher calls. This patch enables it, the next drops the unlock/lock pairs around dispatcher calls. The current solution of dropping the locks is buggy: * it allows multiple dispatcher calls fr

[Qemu-devel] [PATCH v3 1/4] qxl/spice-display: move pipe to ssd

2011-03-16 Thread Alon Levy
This moves the int pipe[2] and pthread_t main data from the PCIQXLDevice struct to the SimpleSpiceDisplay. This will let us reuse it in the next patch for both -spice with no -qxl usage and for vga mode from qxl. Also move the pipe creation function (which is effectively completely rewritten by th

[Qemu-devel] [PATCH v3 0/4] qxl: implement vga mode without locks

2011-03-16 Thread Alon Levy
v2->v3 changes: (Hans de Goede) * minor review fixes * fix compilation of qemu with --enable-spice with a target which does not have a qxl device v1->v2 changes: * patch 4 rewrite: instead of todos implemented usage of pipe for cursor_set and cursor_move. * small fixes: (Hans de Goede) *

[Qemu-devel] Re: [PATCH 19/26] Add PAPR H_VIO_SIGNAL hypercall and infrastructure for VIO interrupts

2011-03-16 Thread Alexander Graf
On 03/16/2011 05:56 AM, David Gibson wrote: This patch adds infrastructure to support interrupts from PAPR virtual IO devices. This includes correctly advertising those interrupts in the device tree, and implementing the H_VIO_SIGNAL hypercall, used to enable and disable individual device interr

[Qemu-devel] Re: [PATCH 18/26] Implement the PAPR (pSeries) virtualized interrupt controller (xics)

2011-03-16 Thread Alexander Graf
On 03/16/2011 05:56 AM, David Gibson wrote: PAPR defines an interrupt control architecture which is logically divided into ICS (Interrupt Control Presentation, each unit is responsible for presenting interrupts to a particular "interrupt server", i.e. CPU) and ICS (Interrupt Control Source, each

[Qemu-devel] [PATCH] tcg/arm: Support host code being compiled for Thumb

2011-03-16 Thread Peter Maydell
Although the TCG generated code is always in ARM mode, it is possible that the host code was compiled by gcc in Thumb mode (this is often the default for Linux distributions targeting ARM v7 only). Handle this by using BLX imm when doing a call from ARM into Thumb mode. Since BLX imm is not a condi

Re: [Qemu-devel] I need Help!

2011-03-16 Thread Jan Marten Simons
Am Montag 07 März 2011 14:45:21 schrieb Hadi Khalil pur: > Hello! > I'm Hadi khalilpur! I'm majoring in software engineering in MSc level. I'm > working on "Automatic bug localization of virtual machines". My > investigations are based on a prior researchs that proposed an automatic > methodology f

  1   2   3   >