[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-04 Thread Scott Wood
On Thu, 3 Feb 2011 10:19:06 +0100 Alexander Graf wrote: > On 02.02.2011, at 23:08, Scott Wood wrote: > > On Wed, 2 Feb 2011 22:33:41 +0100 > > Alexander Graf wrote: > >> This seems to fine-grained. I'd prefer a list of all TLB entries to be > >> pushed in either direction. What's the foreseeabl

[Qemu-devel] [PATCH 2/2] w32: Remove implementation of function ffs

2011-02-04 Thread Stefan Weil
This implementation is no longer needed. ffs is either a built-in function (for compilations with optimisation) or taken from libiberty.a (which was added by the previous patch). Cc: Anthony Liguori Signed-off-by: Stefan Weil --- oslib-win32.c |7 --- 1 files changed, 0 insertions(+),

[Qemu-devel] [PATCH 1/2] w32: Use additional library libiberty.a

2011-02-04 Thread Stefan Weil
libiberty.a is part of MinGW and provides useful functions like ffs (MinGW) and getopt (MinGW-w64). It is needed for w64 compilations and allows simpler code for w32. Cc: Anthony Liguori Signed-off-by: Stefan Weil --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[Qemu-devel] Re: [PATCH v3 02/23] Stop current VCPU on synchronous reset requests

2011-02-04 Thread Marcelo Tosatti
On Fri, Feb 04, 2011 at 07:21:25PM +0100, Jan Kiszka wrote: > On 2011-02-04 18:52, Jan Kiszka wrote: > > On 2011-02-04 18:34, Anthony Liguori wrote: > >> On 02/04/2011 09:47 AM, Marcelo Tosatti wrote: > >>> The following changes since commit > >>> bfddb47a343b4718e5768aa80bce8adead0f7fca: > >>> >

Re: [Qemu-devel] New stable branch information

2011-02-04 Thread Justin M. Forbes
On Fri, 2011-02-04 at 20:26 +0100, Aurelien Jarno wrote: > On Fri, Feb 04, 2011 at 06:25:26AM -0600, Anthony Liguori wrote: > > To help make the stable branch more active than it has been in the > > past, I'd like to split the stable branch into a separate tree to > > allow the tree to develop a li

[Qemu-devel] [PATCH] qemu-timer: Fix compilation of new timer code for w32, w64

2011-02-04 Thread Stefan Weil
qemu_next_alarm_deadline() is needed by MinGW, too. Cc: Paolo Bonzini Cc: Anthony Liguori Signed-off-by: Stefan Weil --- qemu-timer.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index b1a3a84..2de02fe 100644 --- a/qemu-timer.c +++ b/q

[Qemu-devel] [Bug 712416] Re: kvm_intel kernel module crash with via nano vmx

2011-02-04 Thread Aurelien Jarno
> yes this appears to be a duplication but the original bugreport > has been posted one year ago and there is no evolution. Moreover, > it's not posted on the officiel qemu / kvm bugtracker ;). Not really. KVM module bugs should be reported to the kernel's bug tracker as explained on http://www.l

Re: [Qemu-devel] [PATCH 0/4] target-arm: Fix decoding of preload and hint insns

2011-02-04 Thread Aurelien Jarno
On Thu, Feb 03, 2011 at 07:43:21PM +, Peter Maydell wrote: > The primary aim of this patch series is to fix the decoding of the > preload and hint instruction space (PLD, PLDW, PLI). Some of these > instructions (PLDW and some unallocated space which should NOP) are > v7MP only, so we introduce

Re: [Qemu-devel] [PATCH] do not pass NULL to strdup.

2011-02-04 Thread Aurelien Jarno
On Wed, Feb 02, 2011 at 05:34:34PM +0200, Gleb Natapov wrote: > Also use qemu_strdup() instead of strdup() in bootindex code. > > Signed-off-by: Gleb Natapov > --- > > Should go to stable too. Thanks, applied > diff --git a/vl.c b/vl.c > index 655617f..ed2cdfa 100644 > --- a/vl.c > +++ b/vl.c

Re: [Qemu-devel] [PATCH] block/vdi: Fix wrong size in conditionally used memset, memcmp

2011-02-04 Thread Anthony Liguori
On 02/04/2011 02:01 PM, Stefan Weil wrote: Error report from cppcheck: block/vdi.c:122: error: Using sizeof for array given as function argument returns the size of pointer. block/vdi.c:128: error: Using sizeof for array given as function argument returns the size of pointer. Fix both by setti

Re: [Qemu-devel] X86 Debian <== guest ... ARM based Linux <== host ?

2011-02-04 Thread Aurelien Jarno
Hi, On Fri, Jan 28, 2011 at 11:45:29AM -0700, AGSCalabrese wrote: > Is it possible to run X86 Debian as a guest where ARM based Linux is the host > ? > > I have a GuruPlug ( ARM based ) running Ubuntu. > http://www.globalscaletechnologies.com/t-guruplugdetails.aspx > > I would like to run RealB

Re: [Qemu-devel] Support for BMIPS4380 CPU?

2011-02-04 Thread Aurelien Jarno
On Thu, Feb 03, 2011 at 10:05:36AM +0100, xeros wrote: > Hi, Hi, > I'd like to ask about support for newer CPUs in QEMU, like this one: > system type : BCM3556C0 DTV platform > processor : 0 > cpu model : Broadcom BMIPS4380 V4.4 FPU V0.1 > BogoMIPS

[Qemu-devel] Re: qemu compiling error on ppc64: kvm.c:81: error: ‘struct kvm_sregs’ has no member named ‘pvr’

2011-02-04 Thread Alexander Graf
On 04.02.2011, at 20:19, Dushyant Bansal wrote: > On Friday 04 February 2011 08:13 PM, Alexander Graf wrote: >> On 04.02.2011, at 14:25, "Dushyant Bansal" >> wrote: >> >> >>> Hi, >>> I am trying to install kvm on ppc64 system (imac G5). I have built >>> kernel with kvm module. When I try

[Qemu-devel] Re: qemu compiling error on ppc64: kvm.c:81: error: ‘struct kvm_sregs’ has no member named ‘pvr’

2011-02-04 Thread Alexander Graf
On 04.02.2011, at 19:35, Jan Kiszka wrote: > On 2011-02-04 15:43, Alexander Graf wrote: >> >> On 04.02.2011, at 14:25, "Dushyant Bansal" >> wrote: >> >>> Hi, >>> I am trying to install kvm on ppc64 system (imac G5). I have built >>> kernel with kvm module. When I try to install qemu, I am

[Qemu-devel] [PATCH] block/vdi: Fix wrong size in conditionally used memset, memcmp

2011-02-04 Thread Stefan Weil
Error report from cppcheck: block/vdi.c:122: error: Using sizeof for array given as function argument returns the size of pointer. block/vdi.c:128: error: Using sizeof for array given as function argument returns the size of pointer. Fix both by setting the correct size. The buggy code is only

Re: [Qemu-devel] [PATCH v3] Set the right overflow bit for neon 32 and 64 bit saturating add/sub.

2011-02-04 Thread Aurelien Jarno
On Fri, Feb 04, 2011 at 03:17:51PM +0100, Christophe Lyon wrote: > > Signed-off-by: Christophe Lyon > --- > target-arm/helpers.h | 12 -- > target-arm/neon_helper.c | 89 > ++ > target-arm/op_helper.c | 49 - >

Re: [Qemu-devel] [PATCH] target-arm: Fix Neon vsra instructions.

2011-02-04 Thread Aurelien Jarno
On Tue, Jan 25, 2011 at 06:18:08PM +0100, Christophe Lyon wrote: > This patch fixes the errors reported by my tests in VSRA. > > Signed-off-by: Christophe Lyon > --- > target-arm/translate.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Thanks applied. > diff --git a/target-a

Re: [Qemu-devel] [PATCH] Softfloat: Add support to softfloat to return floatxx_default_nan when the corresponding target status flag is set.

2011-02-04 Thread Aurelien Jarno
On Fri, Feb 04, 2011 at 02:44:48PM +, Peter Maydell wrote: > On 4 February 2011 14:01, Christophe Lyon wrote: > > Some CPUs have a status flag imposing to return floatxx_default_nan > > whatever the input value, when converting from one FP format to > > another. Implement this, using the alrea

Re: [Qemu-devel] New stable branch information

2011-02-04 Thread Aurelien Jarno
On Fri, Feb 04, 2011 at 06:25:26AM -0600, Anthony Liguori wrote: > To help make the stable branch more active than it has been in the > past, I'd like to split the stable branch into a separate tree to > allow the tree to develop a life of its own over time. > > I'd like to begin this process with

[Qemu-devel] Re: qemu compiling error on ppc64: kvm.c:81: error: ‘struct kvm_sregs’ has no member named ‘pvr’

2011-02-04 Thread Dushyant Bansal
On Friday 04 February 2011 08:13 PM, Alexander Graf wrote: On 04.02.2011, at 14:25, "Dushyant Bansal" wrote: Hi, I am trying to install kvm on ppc64 system (imac G5). I have built kernel with kvm module. When I try to install qemu, I am getting this error $ ./configure --enable-kvm --ta

[Qemu-devel] Re: qemu compiling error on ppc64: kvm.c:81: error: ‘struct kvm_sregs’ has no member named ‘pvr’

2011-02-04 Thread Jan Kiszka
On 2011-02-04 15:43, Alexander Graf wrote: > > On 04.02.2011, at 14:25, "Dushyant Bansal" > wrote: > >> Hi, >> I am trying to install kvm on ppc64 system (imac G5). I have built >> kernel with kvm module. When I try to install qemu, I am getting this >> error >> >> $ ./configure --enable-kvm -

[Qemu-devel] [PATCH v3 02/23] Stop current VCPU on synchronous reset requests

2011-02-04 Thread Jan Kiszka
On 2011-02-04 18:52, Jan Kiszka wrote: > On 2011-02-04 18:34, Anthony Liguori wrote: >> On 02/04/2011 09:47 AM, Marcelo Tosatti wrote: >>> The following changes since commit bfddb47a343b4718e5768aa80bce8adead0f7fca: >>> >>>Open up the 0.15 development branch (2011-02-02 08:39:28 +0100) >>>

[Qemu-devel] Re: [PATCH][qemu-iotests] add support for rbd and sheepdog protocols

2011-02-04 Thread Christoph Hellwig
On Tue, Jan 18, 2011 at 02:01:17AM +0900, MORITA Kazutaka wrote: > This patch introduces tests for protocols other than file, and > initially supports rbd and sheepdog. Thanks a lot! This should also make adding nbd support trivial if anyone cares.

Re: [Qemu-devel] [PING 0.14] Missing patches (mostly fixes)

2011-02-04 Thread Anthony Liguori
On 02/04/2011 11:36 AM, Stefan Weil wrote: Hi Anthony, please accept that even if you said something multiple times, other people might have a different point of view. Yup, just making my point of view clear. QEMU is team work, isn't it? Both positives are correct, there was no false positi

Re: [Qemu-devel] [PATCH 00/23] [PULL] qemu-kvm.git uq/master queue

2011-02-04 Thread Jan Kiszka
On 2011-02-04 18:34, Anthony Liguori wrote: > On 02/04/2011 09:47 AM, Marcelo Tosatti wrote: >> The following changes since commit bfddb47a343b4718e5768aa80bce8adead0f7fca: >> >>Open up the 0.15 development branch (2011-02-02 08:39:28 +0100) >> > > This series breaks reboot of a Linux gues

Re: [Qemu-devel] [PING 0.14] Missing patches (mostly fixes)

2011-02-04 Thread Stefan Weil
Am 04.02.2011 18:21, schrieb Anthony Liguori: On 02/04/2011 11:18 AM, Stefan Weil wrote: Am 04.02.2011 16:27, schrieb Markus Armbruster: Anthony Liguori writes: On 02/02/2011 01:28 PM, Stefan Weil wrote: [...] [PATCH 1/3] tests: Fix two memory leaks (http://patchwork.ozlabs.org/patch/79945

[Qemu-devel] [PATCH 1/2] vl: initialize all displaystates

2011-02-04 Thread Dmitry Eremin-Solenikov
Init not only first displaystate, but all. Otherwise machines with multiple display devices (e.g. tosa, as it exists now) will just segfault on ds switch. Signed-off-by: Dmitry Eremin-Solenikov --- vl.c | 104 +- 1 files changed, 5

[Qemu-devel] [PATCH 2/2] tc6393xb: add support for invalidate display callback

2011-02-04 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- hw/tc6393xb.c | 17 ++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/hw/tc6393xb.c b/hw/tc6393xb.c index ed49e94..14847a9 100644 --- a/hw/tc6393xb.c +++ b/hw/tc6393xb.c @@ -126,7 +126,8 @@ struct TC6393xbState { ui

Re: [Qemu-devel] [PATCH 00/23] [PULL] qemu-kvm.git uq/master queue

2011-02-04 Thread Anthony Liguori
On 02/04/2011 09:47 AM, Marcelo Tosatti wrote: The following changes since commit bfddb47a343b4718e5768aa80bce8adead0f7fca: Open up the 0.15 development branch (2011-02-02 08:39:28 +0100) This series breaks reboot of a Linux guest both with TCG and KVM. Perhaps it's a conflict with the

Re: [Qemu-devel] [PATCH v2 00/10] Make some devices optional

2011-02-04 Thread Anthony Liguori
On 02/04/2011 02:04 AM, Markus Armbruster wrote: Blue Swirl writes: Disabling some devices from build is a frequently requested feature. Provide means to disable vmware_vga, vmmouse and HPET. Long patch series without proper threading are a PITA to review. git-send-email adds the ne

Re: [Qemu-devel] [PING 0.14] Missing patches (mostly fixes)

2011-02-04 Thread Anthony Liguori
On 02/04/2011 11:18 AM, Stefan Weil wrote: Am 04.02.2011 16:27, schrieb Markus Armbruster: Anthony Liguori writes: On 02/02/2011 01:28 PM, Stefan Weil wrote: [...] [PATCH 1/3] tests: Fix two memory leaks (http://patchwork.ozlabs.org/patch/79945/) [PATCH 2/3] check-qdict: Fix possible cra

Re: [Qemu-devel] [PING 0.14] Missing patches (mostly fixes)

2011-02-04 Thread Stefan Weil
Am 04.02.2011 16:27, schrieb Markus Armbruster: Anthony Liguori writes: On 02/02/2011 01:28 PM, Stefan Weil wrote: [...] [PATCH 1/3] tests: Fix two memory leaks (http://patchwork.ozlabs.org/patch/79945/) [PATCH 2/3] check-qdict: Fix possible crash (http://patchwork.ozlabs.org/patch/79946/

[Qemu-devel] Re: [PATCH 01/11] .gitignore: ignore vi swap files and ctags files

2011-02-04 Thread Dmitry Eremin-Solenikov
Hi, What about these patches? -- With best wishes Dmitry

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-04 Thread Stefan Hajnoczi
On Fri, Feb 4, 2011 at 4:27 PM, Michael Roth wrote: >> Aborting an RPC handler could leave the system in an inconsistent >> state unless we are careful.  For example, aborting freeze requires >> thawing those file systems that have been successfully frozen so far. >> For other handlers it might le

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-04 Thread Michael Roth
On 02/04/2011 05:03 AM, Jes Sorensen wrote: On 02/03/11 18:41, Michael Roth wrote: On 02/02/2011 02:48 AM, Jes Sorensen wrote: Yes very much so[1] - one reason why it would be nice to have virtagent use threads to execute the actual commands. We should probably add a flag to agent commands indi

[Qemu-devel] Re: [PATCH v2 00/24] [uq/master] Patch queue, part II

2011-02-04 Thread Marcelo Tosatti
On Fri, Feb 04, 2011 at 05:29:00PM +0100, Jan Kiszka wrote: > On 2011-02-04 14:54, Marcelo Tosatti wrote: > > On Tue, Feb 01, 2011 at 10:15:40PM +0100, Jan Kiszka wrote: > >> Version 2 of part II. Changes: > >> - Fixed "Unconditionally reenter kernel after IO exits" to take > >>self-INIT into

Re: [Qemu-devel] [PING 0.14] Missing patches (mostly fixes)

2011-02-04 Thread Luiz Capitulino
On Fri, 04 Feb 2011 16:27:46 +0100 Markus Armbruster wrote: > Anthony Liguori writes: > > > On 02/02/2011 01:28 PM, Stefan Weil wrote: > [...] > >> [PATCH 1/3] tests: Fix two memory leaks > >> (http://patchwork.ozlabs.org/patch/79945/) > > >> [PATCH 2/3] check-qdict: Fix possible crash > >> (h

[Qemu-devel] Re: [PATCH v2 00/24] [uq/master] Patch queue, part II

2011-02-04 Thread Jan Kiszka
On 2011-02-04 14:54, Marcelo Tosatti wrote: > On Tue, Feb 01, 2011 at 10:15:40PM +0100, Jan Kiszka wrote: >> Version 2 of part II. Changes: >> - Fixed "Unconditionally reenter kernel after IO exits" to take >>self-INIT into account >> - Fixed misplaced hunk in "Fix race between timer signals

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-04 Thread Michael Roth
On 02/04/2011 12:13 AM, Stefan Hajnoczi wrote: On Thu, Feb 3, 2011 at 5:41 PM, Michael Roth wrote: For things like logging and i/o on a frozen system...I agree we'd need some flag for these kinds of situations. Maybe a disable_logging() flagi really don't like this though... I'd imagine eve

[Qemu-devel] [PATCH 03/23] Process vmstop requests in IO thread

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka A pending vmstop request is also a reason to leave the inner main loop. So far we ignored it, and pending stop requests issued over VCPU threads were simply ignored. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- vl.c | 14 +- 1 files changed, 5 in

[Qemu-devel] [PATCH 09/23] kvm: Handle kvm_init_vcpu errors

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka Do not ignore errors of kvm_init_vcpu, they are fatal. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- cpus.c | 19 +++ 1 files changed, 15 insertions(+), 4 deletions(-) diff --git a/cpus.c b/cpus.c index 312c7a2..8475757 100644 --- a/cpus.c ++

[Qemu-devel] [PATCH 11/23] Refactor signal setup functions in cpus.c

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka Move {tcg,kvm}_init_ipi and block_io_signals to avoid prototypes, rename the former two to clarify that they deal with more than SIG_IPI. No functional changes - except for the tiny fixup of strerror usage. The forward declaration of sigbus_handler is just temporarily, it will b

[Qemu-devel] [PATCH 14/23] kvm: Call qemu_kvm_eat_signals also under !CONFIG_IOTHREAD

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka Move qemu_kvm_eat_signals around and call it also when the IO-thread is not used. Do not yet process SIGBUS, will be armed in a separate step. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- cpus.c | 90 +-

[Qemu-devel] [PATCH 15/23] Set up signalfd under !CONFIG_IOTHREAD

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka Will be required for SIGBUS handling. For obvious reasons, this will remain a nop on Windows hosts. Signed-off-by: Jan Kiszka Reviewed-by: Paolo Bonzini Signed-off-by: Marcelo Tosatti --- Makefile.objs |2 +- cpus.c| 117 +++--

[Qemu-devel] [PATCH 17/23] kvm: Add MCE signal support for !CONFIG_IOTHREAD

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka Currently, we only configure and process MCE-related SIGBUS events if CONFIG_IOTHREAD is enabled. The groundwork is laid, we just need to factor out the required handler registration and system configuration. Signed-off-by: Jan Kiszka CC: Huang Ying CC: Hidetoshi Seto CC: Jin

[Qemu-devel] [PATCH 10/23] kvm: Provide sigbus services arch-independently

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka Provide arch-independent kvm_on_sigbus* stubs to remove the #ifdef'ery from cpus.c. This patch also fixes --disable-kvm build by providing the missing kvm_on_sigbus_vcpu kvm-stub. Signed-off-by: Jan Kiszka Reviewed-by: Paolo Bonzini Acked-by: Alexander Graf Signed-off-by: Mar

[Qemu-devel] [PATCH 04/23] Trigger exit from cpu_exec_all on pending IO events

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka Except for timer events, we currently do not leave the loop over all VCPUs if an IO event was filed. That may cause unexpected IO latencies under !CONFIG_IOTHREAD in SMP scenarios. Fix it by setting the global exit_request which breaks the loop. Signed-off-by: Jan Kiszka Signed

[Qemu-devel] [PATCH 20/23] kvm: Remove static return code of kvm_handle_io

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka Improve the readability of the exit dispatcher by moving the static return value of kvm_handle_io to its caller. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- kvm-all.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/kvm

[Qemu-devel] [PATCH 02/23] Stop current VCPU on synchronous reset requests

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka If some I/O operation ends up calling qemu_system_reset_request in VCPU context, we record this and inform the io-thread, but we do not terminate the VCPU loop. This can lead to fairly unexpected behavior if the triggering reset operation is supposed to work synchronously. Fix t

[Qemu-devel] [PATCH 01/23] Prevent abortion on multiple VCPU kicks

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka If we call qemu_cpu_kick more than once before the target was able to process the signal, pthread_kill will fail, and qemu will abort. Prevent this by avoiding the redundant signal. This logic can be found in qemu-kvm as well. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo T

[Qemu-devel] [PATCH 12/23] kvm: Set up signal mask also for !CONFIG_IOTHREAD

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka Block SIG_IPI, unblock it during KVM_RUN, just like in io-thread mode. It's unused so far, but this infrastructure will be required for self-IPIs and to process SIGBUS plus, in KVM mode, SIGIO and SIGALRM. As Windows doesn't support signal services, we need to provide a stub for

[Qemu-devel] [PATCH 22/23] x86: Fix MCA broadcast parameters for TCG case

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka When broadcasting MCEs, we need to set MCIP and RIPV in mcg_status like it is done for KVM. Use the symbolic constants at this chance. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- target-i386/helper.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(

[Qemu-devel] [PATCH 16/23] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between checking for exit_request on vcpu entry and timer signals arriving before KVM starts to catch them. Plug it by blocking both timer related signals also on !CONFIG_IOTHREAD and process those via signalfd. As this f

[Qemu-devel] [PATCH 06/23] Flatten the main loop

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka First of all, vm_can_run is a misnomer, it actually means "no request pending". Moreover, there is no need to check all pending requests twice, the first time via the inner loop check and then again when actually processing the requests. We can simply remove the inner loop and do

[Qemu-devel] [PATCH 05/23] Leave inner main_loop faster on pending requests

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka If there is any pending request that requires us to leave the inner loop if main_loop, makes sure we do this as soon as possible by enforcing non-blocking IO processing. At this change, move variable definitions out of the inner loop to improve readability. Signed-off-by: Jan K

[Qemu-devel] [PATCH 13/23] kvm: Refactor qemu_kvm_eat_signals

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka We do not use the timeout, so drop its logic. As we always poll our signals, we do not need to drop the global lock. Removing those calls allows some further simplifications. Also fix the error processing of sigpending at this chance. Signed-off-by: Jan Kiszka Reviewed-by: Paol

[Qemu-devel] [PATCH 08/23] kvm: Drop redundant kvm_enabled from kvm_cpu_thread_fn

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- cpus.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index 5dfc54e..312c7a2 100644 --- a/cpus.c +++ b/cpus.c @@ -607,8 +607,8 @@ static void *kvm_cpu_thread_fn(void *arg)

[Qemu-devel] [PATCH 23/23] kvm: make tsc stable over migration and machine start

2011-02-04 Thread Marcelo Tosatti
From: Glauber Costa If the machine is stopped, we should not record two different tsc values upon a save operation. The same problem happens with kvmclock. But kvmclock is taking a different diretion, being now seen as a separate device. Since this is unlikely to happen with the tsc, I am taking

[Qemu-devel] [PATCH 00/23] [PULL] qemu-kvm.git uq/master queue

2011-02-04 Thread Marcelo Tosatti
The following changes since commit bfddb47a343b4718e5768aa80bce8adead0f7fca: Open up the 0.15 development branch (2011-02-02 08:39:28 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Glauber Costa (1): kvm: make tsc stable over

[Qemu-devel] [PATCH 18/23] Introduce VCPU self-signaling service

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka Introduce qemu_cpu_kick_self to send SIG_IPI to the calling VCPU context. First user will be kvm. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- cpus.c| 21 + qemu-common.h |1 + 2 files changed, 22 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH 19/23] kvm: Unconditionally reenter kernel after IO exits

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka KVM requires to reenter the kernel after IO exits in order to complete instruction emulation. Failing to do so will leave the kernel state inconsistently behind. To ensure that we will get back ASAP, we issue a self-signal that will cause KVM_RUN to return once the pending operat

[Qemu-devel] [PATCH 21/23] kvm: Leave kvm_cpu_exec directly after KVM_EXIT_SHUTDOWN

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka The reset we issue on KVM_EXIT_SHUTDOWN implies that we should also leave the VCPU loop. As we now check for exit_request which is set by qemu_system_reset_request, this bug is no longer critical. Still it's an unneeded extra turn. Signed-off-by: Jan Kiszka Signed-off-by: Marce

[Qemu-devel] [PATCH 07/23] kvm: Report proper error on GET_VCPU_MMAP_SIZE failures

2011-02-04 Thread Marcelo Tosatti
From: Jan Kiszka Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- kvm-all.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 2ec9e09..55f6ac3 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -219,6 +219,7 @@ int kvm_init_vcpu(CPUState *e

Re: [Qemu-devel] [PING 0.14] Missing patches (mostly fixes)

2011-02-04 Thread malc
On Fri, 4 Feb 2011, Anthony Liguori wrote: > On 02/02/2011 01:28 PM, Stefan Weil wrote: > > Hello, > > > > these are some patches which I found on my stack of open patches. > > > > All of them should go into 0.14, and at least some of them could also be > > applied to 0.13. > > This need the fo

Re: [Qemu-devel] [PING 0.14] Missing patches (mostly fixes)

2011-02-04 Thread Anthony Liguori
On 02/04/2011 09:27 AM, Markus Armbruster wrote: Anthony Liguori writes: On 02/02/2011 01:28 PM, Stefan Weil wrote: [...] [PATCH 1/3] tests: Fix two memory leaks (http://patchwork.ozlabs.org/patch/79945/) [PATCH 2/3] check-qdict: Fix possible crash (http://patchwor

Re: [Qemu-devel] [PING 0.14] Missing patches (mostly fixes)

2011-02-04 Thread Markus Armbruster
Anthony Liguori writes: > On 02/02/2011 01:28 PM, Stefan Weil wrote: [...] >> [PATCH 1/3] tests: Fix two memory leaks >> (http://patchwork.ozlabs.org/patch/79945/) >> [PATCH 2/3] check-qdict: Fix possible crash >> (http://patchwork.ozlabs.org/patch/79946/) > > Luiz I wouldn't bother with the se

[Qemu-devel] Re: [Bug 712416] Re: kvm_intel kernel module crash with via nano vmx

2011-02-04 Thread Serge Hallyn
Quoting khetzal (712...@bugs.launchpad.net): > Thanks for your help. I've subscribed to these mailing list. Have i do > report the bug in these mailing list too ? (or is it a useless other > duplication ?) It will not be duplication. These are development lists, not support lists, so you won't be

[Qemu-devel] Re: qemu compiling error on ppc64: kvm.c:81: error: ‘struct kvm_sregs’ has no member named ‘pvr’

2011-02-04 Thread Alexander Graf
On 04.02.2011, at 14:25, "Dushyant Bansal" wrote: > Hi, > I am trying to install kvm on ppc64 system (imac G5). I have built > kernel with kvm module. When I try to install qemu, I am getting this > error > > $ ./configure --enable-kvm --target-list="ppc-softmmu" > $ make > > [...] > CCs

[Qemu-devel] Re: [PATCH 1/4] Add config-devices.h again

2011-02-04 Thread Juan Quintela
Stefan Weil wrote: > Am 01.02.2011 17:53, schrieb Eduardo Habkost: >> This reverts part of commit a992fe3d0fc185112677286f7a02204d8245b61e. >> >> We do have code that needs #ifdefs depending on the list of enabled devices, >> but currently that code breaks when we try to disable a feature that is

Re: [Qemu-devel] [PATCH v3] Set the right overflow bit for neon 32 and 64 bit saturating add/sub.

2011-02-04 Thread Peter Maydell
On 4 February 2011 14:17, Christophe Lyon wrote: > > Signed-off-by: Christophe Lyon Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH] Softfloat: Add support to softfloat to return floatxx_default_nan when the corresponding target status flag is set.

2011-02-04 Thread Peter Maydell
On 4 February 2011 14:01, Christophe Lyon wrote: > Some CPUs have a status flag imposing to return floatxx_default_nan > whatever the input value, when converting from one FP format to > another. Implement this, using the already existing default_nan_mode > status flag, only for ARM at the moment,

Re: [Qemu-devel] [PING 0.14] Missing patches (mostly fixes)

2011-02-04 Thread Alexander Graf
On 04.02.2011, at 13:30, Anthony Liguori wrote: > On 02/02/2011 01:28 PM, Stefan Weil wrote: >> Hello, >> >> these are some patches which I found on my stack of open patches. >> >> All of them should go into 0.14, and at least some of them could also be >> applied to 0.13. > > This need t

[Qemu-devel] Re: [PATCH v2 00/24] [uq/master] Patch queue, part II

2011-02-04 Thread Marcelo Tosatti
On Tue, Feb 01, 2011 at 10:15:40PM +0100, Jan Kiszka wrote: > Version 2 of part II. Changes: > - Fixed "Unconditionally reenter kernel after IO exits" to take >self-INIT into account > - Fixed misplaced hunk in "Fix race between timer signals and vcpu >entry under !IOTHREAD" (rebase artif

[Qemu-devel] Re: [PATCH] x86: Fix MCA broadcast parameters for TCG case

2011-02-04 Thread Marcelo Tosatti
On Wed, Feb 02, 2011 at 09:35:26PM +0100, Jan Kiszka wrote: > On 2011-02-02 20:05, Blue Swirl wrote: > > Signed-off-by: Blue Swirl > > --- > > target-i386/helper.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/target-i386/helper.c b/target-i386/helper.c > >

[Qemu-devel] [PATCH v3] Set the right overflow bit for neon 32 and 64 bit saturating add/sub.

2011-02-04 Thread Christophe Lyon
Signed-off-by: Christophe Lyon --- target-arm/helpers.h | 12 -- target-arm/neon_helper.c | 89 ++ target-arm/op_helper.c | 49 - target-arm/translate.c | 18 - 4 files changed, 105 insertions(+), 63

[Qemu-devel] [PATCH] Softfloat: Add support to softfloat to return floatxx_default_nan when the corresponding target status flag is set.

2011-02-04 Thread Christophe Lyon
Some CPUs have a status flag imposing to return floatxx_default_nan whatever the input value, when converting from one FP format to another. Implement this, using the already existing default_nan_mode status flag, only for ARM at the moment, though other architectures may have the same feature. Thi

[Qemu-devel] Re: IO APIC emulation failure with qemu-kvm

2011-02-04 Thread Jan Kiszka
On 2011-02-04 14:35, Ravi Kumar Kulkarni wrote: > Hi all, > I'm Initializing the Local and IO APIC for a propeitary operating > system running in Virtualized Environment . > Im facing some problem with qemu-kvm but the code runs fine with qemu. Does it also run fine with qemu-kvm and -no-kvm-i

[Qemu-devel] [RFC][PATCH v1 1/4] qtest: add qtest to supported qemu modules

2011-02-04 Thread Michael Roth
Signed-off-by: Michael Roth --- module.h |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/module.h b/module.h index 9263f1c..d2bf34d 100644 --- a/module.h +++ b/module.h @@ -24,12 +24,15 @@ typedef enum { MODULE_INIT_BLOCK, MODULE_INIT_DEVICE, MODULE_IN

[Qemu-devel] [RFC][PATCH v1 3/4] qtest: add basic rtc test module

2011-02-04 Thread Michael Roth
This test module initializes a basic system with an ISA bus, a PIC (currently not used in the test), and an RTC. Currently only drift testing is performed at various frequencies. This is currently more of a proof of concept than a rigorous test, and will be improved over time. Signed-off-by: Micha

[Qemu-devel] [RFC][PATCH v1 2/4] qtest: basic test infrastructure and vl.c hooks

2011-02-04 Thread Michael Roth
Signed-off-by: Michael Roth --- qtest/qtest.c | 65 + qtest/qtest.h | 37 vl.c | 24 + 3 files changed, 126 insertions(+), 0 deletions(-) create mode 100644 qtest/qtest.c

[Qemu-devel] [RFC][PATCH v1 4/4] qtest: build qtest and add -test cmdline opt

2011-02-04 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile.objs |4 +++- Makefile.target |1 + configure | 20 qemu-options.hx |9 + vl.c| 11 +++ 5 files changed, 44 insertions(+), 1 deletions(-) diff --git a/Makefile.objs b/Makefile.objs

[Qemu-devel] [RFC][PATCH v6 00/04] qtest: qemu unit testing framework

2011-02-04 Thread Michael Roth
These patches apply to master (2-04-2011), and can also be obtained from: git://repo.or.cz/qemu/mdroth.git qtest_v1 OVERVIEW: QEMU currently lacks a standard means to do targeted unit testing of the device model. Frameworks like kvm-autotest interact via guest OS, which provide a highly abstrac

[Qemu-devel] IO APIC emulation failure with qemu-kvm

2011-02-04 Thread Ravi Kumar Kulkarni
Hi all, I'm Initializing the Local and IO APIC for a propeitary operating system running in Virtualized Environment . Im facing some problem with qemu-kvm but the code runs fine with qemu. when i run my kernel image with qemu-kvm it gives emulation error failure trying to execute the code outs

[Qemu-devel] qemu compiling error on ppc64: kvm.c:81: error: ‘struct kvm_sregs’ has no member named ‘pvr’

2011-02-04 Thread Dushyant Bansal
Hi, I am trying to install kvm on ppc64 system (imac G5). I have built kernel with kvm module. When I try to install qemu, I am getting this error $ ./configure --enable-kvm --target-list="ppc-softmmu" $ make [...] CCslirp/tftp.o CClibdis/ppc-dis.o GEN config-target.h CCpp

Re: [Qemu-devel] [PATCH v3 01/16] vnc: qemu can die if the client is disconnected while updating screen

2011-02-04 Thread Anthony Liguori
On 02/04/2011 02:05 AM, Corentin Chary wrote: agraf reported that qemu_mutex_destroy(vs->output_mutex) while failing in vnc_disconnect_finish(). It's because vnc_worker_thread_loop() tries to unlock the mutex while not locked. The unlocking call doesn't fail (pthread bug ?), but the destroy call

Re: [Qemu-devel] [PATCH 0.14] ui/sdl: Fix handling of caps lock and num lock keys

2011-02-04 Thread Anthony Liguori
On 02/03/2011 03:35 PM, Stefan Weil wrote: Starting with SDL version 1.2.14, caps lock and num lock keys will send a SDL_KEYUP when SDL_DISABLE_LOCK_KEYS=1 is set in the environment. The new code sets the environment unconditionally (it won't harm old versions which do not know it). The workaro

Re: [Qemu-devel] [PATCH master/0.14] virtio-serial: Make sure virtqueue is ready before discarding data

2011-02-04 Thread Anthony Liguori
On 02/04/2011 02:54 AM, Amit Shah wrote: This can happen if a port gets unplugged before guest has chance to initialise vqs. Reported-by: Juan Quintela Signed-off-by: Amit Shah Applied to master, Thanks. Regards, Anthony Liguori --- hw/virtio-serial-bus.c |3 +++ 1 files changed,

Re: [Qemu-devel] [0.14?][PATCH v3 1/4] ioapic: Implement EOI handling for level-triggered IRQs

2011-02-04 Thread Anthony Liguori
On 02/03/2011 03:54 PM, Jan Kiszka wrote: From: Jan Kiszka Add the missing EOI broadcast from local APIC to the IOAPICs on completion of level-triggered IRQs. This ensures that a still asserted IRQ source properly re-triggers an APIC IRQ. Signed-off-by: Jan Kiszka Applied to master, Thank

Re: [Qemu-devel] [PATCH v2 1/3] use nanoseconds everywhere for timeout computation

2011-02-04 Thread Anthony Liguori
On 02/03/2011 07:48 AM, Paolo Bonzini wrote: Suggested by Aurelien Jarno. Signed-off-by: Paolo Bonzini Applied to master, Thanks. Regards, Anthony Liguori --- qemu-timer.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/qemu-tim

Re: [Qemu-devel] [PATCH 0.14] savevm: fix corruption in vmstate_subsection_load().

2011-02-04 Thread Anthony Liguori
On 02/02/2011 10:34 PM, Yoshiaki Tamura wrote: Although it's rare to happen in live migration, when the head of a byte stream contains 0x05 which is the marker of subsection, the loader gets corrupted because vmstate_subsection_load() continues even the device doesn't require it. This patch adds

[Qemu-devel] 0.14.0 Release Schedule - Update

2011-02-04 Thread Anthony Liguori
I've also updated http://wiki.qemu.org/Planning/0.14 No dates were changed, but I've put in dates for two release candidates. I'll be travelling over the next week but I don't expect that to be a problem here. Please note that the dates are targets for tagging. Formal announcements will la

[Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-04 Thread Jes . Sorensen
From: Jes Sorensen Implement freeze/thaw support in the guest, allowing the host to request the guest freezes all it's file systems before a live snapshot is performed. - fsfreeze(): Walk the list of mounted local real file systems, and freeze them. - fsthaw(): Walk the list of

Re: [Qemu-devel] [PING 0.14] Missing patches (mostly fixes)

2011-02-04 Thread Paolo Bonzini
On 02/04/2011 01:30 PM, Anthony Liguori wrote: [PATCH 3/3] w64: Fix problem with missing sigset_t (http://patchwork.ozlabs.org/patch/79947/) We don't support w64... AFAIK mingw-w64 supports both 32-bit and 64-bit compilation, so the patch subject is misleading. Paolo

Re: [Qemu-devel] Re: phys_page_find bug?

2011-02-04 Thread Artyom Tarasenko
Tested-by: Artyom Tarasenko > There's two bugs in phys_page_find_alloc().  When the bottom level L2 > table is populated with IO_MEM_UNASSIGNED, region_offset is then used > for reporting the physical address.  First, region_offset may not be > aligned to the base address of the L2 region.  And s

[Qemu-devel] Re: [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-04 Thread Jes Sorensen
On 02/03/11 19:11, Michael Roth wrote: >> @@ -217,6 +221,186 @@ static xmlrpc_value *va_hello(xmlrpc_env *env, >> return result; >> } >> >> + >> +/* >> + * Walk the mount table and build a list of local file systems >> + */ >> + >> +struct direntry { >> +char *dirname; >> +char *dev

[Qemu-devel] Re: [PATCH master/0.14] virtio-serial: Make sure virtqueue is ready before discarding data

2011-02-04 Thread Juan Quintela
Amit Shah wrote: > This can happen if a port gets unplugged before guest has chance to > initialise vqs. > > Reported-by: Juan Quintela > Signed-off-by: Amit Shah > --- > hw/virtio-serial-bus.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/hw/virtio-serial-bus.

Re: [Qemu-devel] [PATCH] target-arm: Fix Neon vsra instructions.

2011-02-04 Thread Peter Maydell
On 25 January 2011 17:18, Christophe Lyon wrote: > This patch fixes the errors reported by my tests in VSRA. > > Signed-off-by: Christophe Lyon Reviewed-by: Peter Maydell

[Qemu-devel] [PATCH 2/2] Add monitor commands for fsfreeze support

2011-02-04 Thread Jes . Sorensen
From: Jes Sorensen This patch adds the following monitor commands: agent_fsfreeze: - Freezes all local file systems in the guest. Command will print the number of file systems that were frozen. agent_fsthaw: - Thaws all local file systems in the guest. Command will print the number of fi

Re: [Qemu-devel] [PING 0.14] Missing patches (mostly fixes)

2011-02-04 Thread Anthony Liguori
On 02/02/2011 01:28 PM, Stefan Weil wrote: Hello, these are some patches which I found on my stack of open patches. All of them should go into 0.14, and at least some of them could also be applied to 0.13. This need the following Acks: [PATCH] hw/fmopl: Fix buffer access out-of-bounds err

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-04 Thread Jes Sorensen
On 02/03/11 18:41, Michael Roth wrote: > On 02/02/2011 02:48 AM, Jes Sorensen wrote: >> Yes very much so[1] - one reason why it would be nice to have virtagent >> use threads to execute the actual commands. We should probably add a >> flag to agent commands indicating whether they issue disk I/O or

  1   2   >