[Qemu-devel] [V4 PATCH 8/8] Chroot environment for other functions

2011-01-31 Thread M. Mohan Kumar
Add chroot functionality for systemcalls that can operate on a file using relative directory file descriptor. Signed-off-by: M. Mohan Kumar --- hw/9pfs/virtio-9p-local.c | 221 +++-- 1 files changed, 191 insertions(+), 30 deletions(-) diff --git a/hw/9pf

[Qemu-devel] [V4 PATCH 4/8] Add support to open a file in chroot environment

2011-01-31 Thread M. Mohan Kumar
This patch adds both server and client side support to open a file (directory) in the chroot environment Signed-off-by: M. Mohan Kumar --- hw/9pfs/virtio-9p-chroot.c | 53 ++- hw/9pfs/virtio-9p-chroot.h |1 + hw/9pfs/virtio-9p-local.c | 52 +++

[Qemu-devel] [V4 PATCH 6/8] Support for creating special files

2011-01-31 Thread M. Mohan Kumar
Add both server and client side interfaces to create special files (directory, device nodes, links and symbolic links) Signed-off-by: M. Mohan Kumar --- hw/9pfs/virtio-9p-chroot.c | 84 ++ hw/9pfs/virtio-9p-chroot.h |2 + hw/9pfs/virtio-9p-local.c | 141 ++

[Qemu-devel] [V4 PATCH 5/8] Create support in chroot environment

2011-01-31 Thread M. Mohan Kumar
Add both server & client side interfaces to create regular files in chroot environment Signed-off-by: M. Mohan Kumar --- hw/9pfs/virtio-9p-chroot.c | 41 + hw/9pfs/virtio-9p-local.c | 22 -- 2 files changed, 61 insertions(+), 2 del

[Qemu-devel] [V4 PATCH 7/8] Move file post creation changes to none security model

2011-01-31 Thread M. Mohan Kumar
After creating a file object, its permission and ownership details are updated as per client's request for both passthrough and none security model. But with chrooted environment its not required for passthrough security model. Move all post file creation changes to none security model Signed-off-

[Qemu-devel] [V4 PATCH 3/8] Add client side interfaces for chroot environment

2011-01-31 Thread M. Mohan Kumar
Define QEMU side interfaces used for chroot environment. Signed-off-by: M. Mohan Kumar --- hw/9pfs/virtio-9p-chroot.c | 87 1 files changed, 87 insertions(+), 0 deletions(-) diff --git a/hw/9pfs/virtio-9p-chroot.c b/hw/9pfs/virtio-9p-chroot.c index

[Qemu-devel] [V4 PATCH 2/8] Provide chroot environment server side interfaces

2011-01-31 Thread M. Mohan Kumar
Implement chroot server side interfaces like sending the file descriptor to qemu process, reading the object request from socket etc. Also add chroot main function and other helper routines. Signed-off-by: M. Mohan Kumar --- Makefile.objs |1 + hw/9pfs/virtio-9p-chroot.c | 212

[Qemu-devel] [V4 PATCH 1/8] virtio-9p: Implement qemu_read_full

2011-01-31 Thread M. Mohan Kumar
Add qemu_read_full function Signed-off-by: M. Mohan Kumar --- osdep.c | 32 qemu-common.h |2 ++ 2 files changed, 34 insertions(+), 0 deletions(-) diff --git a/osdep.c b/osdep.c index 327583b..8d84a88 100644 --- a/osdep.c +++ b/osdep.c @@ -127,6 +127

[Qemu-devel] [V4 PATCH 0/8] virtio-9p: Use chroot to safely access files in passthrough security model

2011-01-31 Thread M. Mohan Kumar
In passthrough security model, following symbolic links in the server side could result in TOCTTOU vulnerabilities. This patchset resolves this issue by creating a dedicated process which chroots into the share path and all file object access is done in the chroot environment. This patchset imple

Re: [Qemu-devel] [PATCH 0/4] new Blackfin QEMU port

2011-01-31 Thread Mike Frysinger
On Mon, Jan 31, 2011 at 09:00, Edgar E. Iglesias wrote: > * Some operations seem to translate to large amounts of tcg code, >  maybe you should consider using helpers for those. An example >  is gen_rot_tl. seems like generated native code is better even if it is larger > * Maybe you should renam

[Qemu-devel] [PATCH 1/3] use nanoseconds everywhere for timeout computation

2011-01-31 Thread Paolo Bonzini
Suggested by Aurelien Jarno. Signed-off-by: Paolo Bonzini --- qemu-timer.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index db1ec49..60283a8 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -197,8 +197,8 @@ s

[Qemu-devel] Re: [PATCHv2] vhost: force vhost off for non-MSI guests

2011-01-31 Thread Michael S. Tsirkin
On Mon, Jan 31, 2011 at 03:07:49PM -0700, Alex Williamson wrote: > On Tue, 2011-02-01 at 00:02 +0200, Michael S. Tsirkin wrote: > > On Mon, Jan 31, 2011 at 02:47:34PM -0700, Alex Williamson wrote: > > > On Mon, 2011-01-31 at 23:19 +0200, Michael S. Tsirkin wrote: > > > > When MSI is off, each inter

[Qemu-devel] [PATCH 3/3] Unify alarm deadline computation

2011-01-31 Thread Paolo Bonzini
This patch shows how using the correct formula for qemu_next_deadline_dyntick can simplify the code of host_alarm_handler and eliminate useless duplication. Signed-off-by: Paolo Bonzini --- qemu-timer.c | 28 +++- 2 files changed, 11 insertions(+), 17 deletions(-) diff

[Qemu-devel] Re: [PATCHv2] vhost: force vhost off for non-MSI guests

2011-01-31 Thread Alex Williamson
On Tue, 2011-02-01 at 00:02 +0200, Michael S. Tsirkin wrote: > On Mon, Jan 31, 2011 at 02:47:34PM -0700, Alex Williamson wrote: > > On Mon, 2011-01-31 at 23:19 +0200, Michael S. Tsirkin wrote: > > > When MSI is off, each interrupt needs to be bounced through the io > > > thread when it's set/cleare

Re: [Qemu-devel] [PATCH 1/3] use nanoseconds everywhere for timeout computation

2011-01-31 Thread Anthony Liguori
On 01/31/2011 03:51 PM, Paolo Bonzini wrote: Suggested by Aurelien Jarno. Signed-off-by: Paolo Bonzini Something I've found is that we have a lot of bugs that are the result of unit conversions when the unit can't be mapped directly to base 10. This happens in both the PIT and RTC and p

[Qemu-devel] Re: [PATCHv2] vhost: force vhost off for non-MSI guests

2011-01-31 Thread Alex Williamson
On Mon, 2011-01-31 at 23:19 +0200, Michael S. Tsirkin wrote: > When MSI is off, each interrupt needs to be bounced through the io > thread when it's set/cleared, so vhost-net causes more context switches and > higher CPU utilization than userspace virtio which handles networking in > the same threa

[Qemu-devel] Re: [PATCHv2] vhost: force vhost off for non-MSI guests

2011-01-31 Thread Michael S. Tsirkin
On Mon, Jan 31, 2011 at 02:47:34PM -0700, Alex Williamson wrote: > On Mon, 2011-01-31 at 23:19 +0200, Michael S. Tsirkin wrote: > > When MSI is off, each interrupt needs to be bounced through the io > > thread when it's set/cleared, so vhost-net causes more context switches and > > higher CPU utili

[Qemu-devel] [PATCH 0/3] Simplify and fix alarm deadline computation

2011-01-31 Thread Paolo Bonzini
This is a rebased and updated version of the series to fix alarm deadline computation. I adopted Aurelien's suggestion to change everything to nanoseconds. I also did more testing than just compiling, by booting with -icount. Paolo Bonzini (3): use nanoseconds everywhere for timeout computatio

[Qemu-devel] Re: KVM call agenda for Feb 1

2011-01-31 Thread Anthony Liguori
On 01/31/2011 12:10 PM, Jan Kiszka wrote: On 2011-01-31 11:02, Juan Quintela wrote: Please send in any agenda items you are interested incovering. o KVM upstream merge: status, plans, coordination o QMP support status for 0.14. Luiz and I already chatted about it today but

[Qemu-devel] Re: [PATCHv2] vhost: force vhost off for non-MSI guests

2011-01-31 Thread Anthony Liguori
On 01/31/2011 03:19 PM, Michael S. Tsirkin wrote: When MSI is off, each interrupt needs to be bounced through the io thread when it's set/cleared, so vhost-net causes more context switches and higher CPU utilization than userspace virtio which handles networking in the same thread. We'll need to

[Qemu-devel] [PATCH 2/3] Correct alarm deadline computation

2011-01-31 Thread Paolo Bonzini
When the QEMU_CLOCK_HOST clock was added, computation of its deadline was added to qemu_next_deadline, which is correct but incomplete. I noticed this by reading the very convoluted rules whereby qemu_next_deadline_dyntick is computed, which miss QEMU_CLOCK_HOST when use_icount is true. This patc

Re: [Qemu-devel] [PATCH] vnc: Fix password expiration through 'change vnc ""'

2011-01-31 Thread Anthony Liguori
On 01/31/2011 02:43 PM, Anthony Liguori wrote: commit 52c18be9e99dabe295321153fda7fce9f76647ac introduced a regression in the change vnc password command that changed the behavior of setting the VNC password to an empty string from disabling login to disabling authentication. This commit refacto

[Qemu-devel] [PATCHv2] vhost: force vhost off for non-MSI guests

2011-01-31 Thread Michael S. Tsirkin
When MSI is off, each interrupt needs to be bounced through the io thread when it's set/cleared, so vhost-net causes more context switches and higher CPU utilization than userspace virtio which handles networking in the same thread. We'll need to fix this by adding level irq support in kvm irqfd,

[Qemu-devel] [PATCH] vnc: Fix password expiration through 'change vnc ""'

2011-01-31 Thread Anthony Liguori
commit 52c18be9e99dabe295321153fda7fce9f76647ac introduced a regression in the change vnc password command that changed the behavior of setting the VNC password to an empty string from disabling login to disabling authentication. This commit refactors the code to eliminate this overloaded semantic

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-01-31 Thread Anthony Liguori
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/697197 Title: Empty password allows access to VNC in libvirt Status in libvirt virtualization API:

Re: [Qemu-devel] [PATCH 4/7] ccid: add ccid-card-emulated device (v2)

2011-01-31 Thread Alon Levy
On Tue, Jan 25, 2011 at 08:21:13AM -0600, Anthony Liguori wrote: > On 01/11/2011 02:42 AM, Alon Levy wrote: > >This devices uses libcacard (internal) to emulate a smartcard conforming > >to the CAC standard. It attaches to the usb-ccid bus. Usage instructions > >(example command lines) are in the f

Re: [Qemu-devel] [PATCH] pcibus_get_dev_path: correct pci device path construction

2011-01-31 Thread Igor Kovalenko
On Mon, Jan 31, 2011 at 5:56 PM, Mark Cave-Ayland wrote: > On 18/01/11 21:10, Igor V. Kovalenko wrote: > >> From: Igor V. Kovalenko >> >> - fix snprintf off by one >>   pci domain and slot number formatting snprintf calls >>   require extra space for trailing null character >> >>   without this ch

[Qemu-devel] [PATCH] qemu-lock.h: Remove non-pthreads spinlock implementations

2011-01-31 Thread Peter Maydell
Since configure guarantees us that we have pthreads on all hosts except mingw (which doesn't support a USER_ONLY config), we can and should use the pthread_mutex based implementation of spin_lock() and spin_unlock() in all USER_ONLY cases. This means that all the inline-native-assembly code support

Re: [Qemu-devel] [PATCH 1/8] target-arm: Fixes for several shift instructions: VRSHL, VRSHR, VRSHRN, VSHLL, VRSRA.

2011-01-31 Thread Christophe Lyon
On 31.01.2011 17:46, Peter Maydell wrote: > On 31 January 2011 15:59, Aurelien Jarno wrote: >> It seems the problems come from here, if I add --enable-debug, I am not >> able to reproduce the problem anymore. I don't understand why though. > > --enable-debug turns off optimisation (ie does not pa

[Qemu-devel] Re: [PULL 0.14] pci

2011-01-31 Thread Anthony Liguori
On 01/31/2011 07:15 AM, Michael S. Tsirkin wrote: The following changes since commit 45d1aa828f8c94b082a0aa2dbf76535594ee45df: Update OpenBIOS images to r1018 (2011-01-30 13:10:10 +) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for

[Qemu-devel] [PATCH 3/8] target-arm: VQRSHRN related changes

2011-01-31 Thread christophe.lyon
From: Christophe Lyon More fixes for VQSHRN and VQSHRUN. Signed-off-by: Christophe Lyon --- target-arm/translate.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 6dd024d..9ca5b82 100644 --- a/target-arm/translat

[Qemu-devel] [PATCH 2/8] target-arm: Create and use neon_unarrow_sat* helpers

2011-01-31 Thread christophe.lyon
From: Christophe Lyon Fix VQMOVUN, improve VQSHRUN and VQRSHRUN. Signed-off-by: Christophe Lyon --- target-arm/helpers.h |3 ++ target-arm/neon_helper.c | 63 ++ target-arm/translate.c | 43 ++- 3 files chang

[Qemu-devel] [PATCH 5/8] target-arm: fix neon vqrshl instruction

2011-01-31 Thread christophe.lyon
From: Christophe Lyon Signed-off-by: Juha Riihimäki Signed-off-by: Christophe Lyon --- target-arm/neon_helper.c | 21 ++--- 1 files changed, 18 insertions(+), 3 deletions(-) diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c index 891b812..46fcdc4 100644 --- a/

[Qemu-devel] [PATCH 4/8] target-arm: fiddle decoding of 64 bit shift by imm and narrow

2011-01-31 Thread christophe.lyon
From: Christophe Lyon Tweak decoding of the shift-by-imm and narrow 64 bit insns (VSHRN, VRSHRN, VQSHRN, VQSHRUN, VQRSHRN, VQRSHRUN). Signed-off-by: Christophe Lyon --- target-arm/translate.c | 28 ++-- 1 files changed, 18 insertions(+), 10 deletions(-) diff --git a/

[Qemu-devel] [PATCH 8/8] target-arm: Fix VQRSHL Neon instructions (signed/unsigned 64 bits and signed 32 bits variants).

2011-01-31 Thread christophe.lyon
From: Christophe Lyon The addition of the rounding constant could cause overflows. Signed-off-by: Christophe Lyon --- target-arm/neon_helper.c | 50 ++--- 1 files changed, 46 insertions(+), 4 deletions(-) diff --git a/target-arm/neon_helper.c b/target

[Qemu-devel] Re: KVM call agenda for Feb 1

2011-01-31 Thread Jan Kiszka
On 2011-01-31 11:02, Juan Quintela wrote: > > Please send in any agenda items you are interested incovering. > o KVM upstream merge: status, plans, coordination Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux

[Qemu-devel] [PATCH 1/8] target-arm: Fixes for several shift instructions: VRSHL, VRSHR, VRSHRN, VSHLL, VRSRA.

2011-01-31 Thread christophe.lyon
From: Christophe Lyon For variants with rounding, fix cases where adding the rounding constant could overflow. For VSHLL, fix bit mask. Signed-off-by: Christophe Lyon --- target-arm/neon_helper.c | 61 ++--- target-arm/translate.c | 12 +++- 2

[Qemu-devel] [PATCH 7/8] target-arm: implement vsli.64, vsri.64

2011-01-31 Thread christophe.lyon
From: Christophe Lyon Signed-off-by: Christophe Lyon --- target-arm/translate.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 61d4c4c..9150242 100644 --- a/target-arm/translate.c +++ b/target-arm/transla

[Qemu-devel] [PATCH v2 0/8] target-arm: Fix Neon instructions VQMOVUN VQRSHL VQRSHRN VQRSHRUN VQSHRN VQSHRUN VSLI VSRI

2011-01-31 Thread christophe.lyon
From: Christophe Lyon This patchset combines fixes from the Meego tree (Peter Maydell, Juha Riihimäki) and my own fixes such that ARM Neon instructions VQMOVUN VQRSHL VQRSHRN VQRSHRUN VQSHRN VQSHRUN VSLI VSRI now pass all my tests. Christophe Lyon (3): Fixes for several shift instructions: VRS

[Qemu-devel] [PATCH 6/8] target-arm: Fix Neon VQ(R)SHRN instructions.

2011-01-31 Thread christophe.lyon
From: Christophe Lyon Handle unsigned variant of VQ(R)SHRN instructions. Signed-off-by: Christophe Lyon --- target-arm/translate.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index a614e34..61d4c4c 100644 --- a

[Qemu-devel] [PATCH v2 17&18/22] kvm: Unconditionally reenter kernel after IO exits

2011-01-31 Thread Jan Kiszka
On 2011-01-31 17:56, Gleb Natapov wrote: >>> The only thing we miss by moving process_irqchip_events is a self-INIT >>> of an AP - if such thing exists in real life. In that case, the AP would >>> cause a reset of itself, followed by a transition to HALT state. >> >> I checked a

[Qemu-devel] Re: [PULL 00/28] Block patches

2011-01-31 Thread Anthony Liguori
On 01/31/2011 09:28 AM, Kevin Wolf wrote: The following changes since commit 45d1aa828f8c94b082a0aa2dbf76535594ee45df: Update OpenBIOS images to r1018 (2011-01-30 13:10:10 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git block Pulled. Thanks. Regards,

[Qemu-devel] Re: [PATCH][RFC] Add stdio char device on windows

2011-01-31 Thread Paolo Bonzini
On 01/31/2011 06:09 PM, Fabien Chouteau wrote: Simple implementation of an stdio char device on Windows. Signed-off-by: Fabien Chouteau --- qemu-char.c | 171 +++ 1 files changed, 171 insertions(+), 0 deletions(-) diff --git a/qemu-cha

[Qemu-devel] Re: [PATCH] mingw32: Fix definitions for PRId64, PRIx64, PRIu64, PRIo64

2011-01-31 Thread Stefan Weil
Am 30.01.2011 23:14, schrieb Blue Swirl: On Sun, Jan 30, 2011 at 9:50 PM, Stefan Weil wrote: Am 30.01.2011 22:39, schrieb Blue Swirl: It would appear to suppress quite a few warnings about formats. But on my version of inttypes.h there is the following comment: /* 7.8.1 Macros for format speci

[Qemu-devel] [PATCH][RFC] Add stdio char device on windows

2011-01-31 Thread Fabien Chouteau
Simple implementation of an stdio char device on Windows. Signed-off-by: Fabien Chouteau --- qemu-char.c | 171 +++ 1 files changed, 171 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index edc9ad6..c18e668 100644 --

[Qemu-devel] Re: [PATCH 17/22] kvm: Move irqchip event processing out of inner loop

2011-01-31 Thread Jan Kiszka
On 2011-01-31 17:50, Gleb Natapov wrote: > On Mon, Jan 31, 2011 at 05:41:24PM +0100, Jan Kiszka wrote: >> On 2011-01-31 17:38, Gleb Natapov wrote: >>> On Mon, Jan 31, 2011 at 04:40:34PM +0100, Jan Kiszka wrote: On 2011-01-31 14:04, Jan Kiszka wrote: > On 2011-01-31 12:36, Jan Kiszka wrote:

[Qemu-devel] Re: [PATCH 17/22] kvm: Move irqchip event processing out of inner loop

2011-01-31 Thread Gleb Natapov
On Mon, Jan 31, 2011 at 05:41:24PM +0100, Jan Kiszka wrote: > On 2011-01-31 17:38, Gleb Natapov wrote: > > On Mon, Jan 31, 2011 at 04:40:34PM +0100, Jan Kiszka wrote: > >> On 2011-01-31 14:04, Jan Kiszka wrote: > >>> On 2011-01-31 12:36, Jan Kiszka wrote: > On 2011-01-31 11:08, Avi Kivity wrot

[Qemu-devel] Re: [PATCH 17/22] kvm: Move irqchip event processing out of inner loop

2011-01-31 Thread Gleb Natapov
On Mon, Jan 31, 2011 at 05:52:13PM +0100, Jan Kiszka wrote: > On 2011-01-31 17:50, Gleb Natapov wrote: > > On Mon, Jan 31, 2011 at 05:41:24PM +0100, Jan Kiszka wrote: > >> On 2011-01-31 17:38, Gleb Natapov wrote: > >>> On Mon, Jan 31, 2011 at 04:40:34PM +0100, Jan Kiszka wrote: > On 2011-01-31

[Qemu-devel] Re: [PATCH 17/22] kvm: Move irqchip event processing out of inner loop

2011-01-31 Thread Jan Kiszka
On 2011-01-31 17:41, Jan Kiszka wrote: > On 2011-01-31 17:38, Gleb Natapov wrote: >> On Mon, Jan 31, 2011 at 04:40:34PM +0100, Jan Kiszka wrote: >>> On 2011-01-31 14:04, Jan Kiszka wrote: On 2011-01-31 12:36, Jan Kiszka wrote: > On 2011-01-31 11:08, Avi Kivity wrote: >> On 01/27/2011 0

Re: [Qemu-devel] [PATCH 1/8] target-arm: Fixes for several shift instructions: VRSHL, VRSHR, VRSHRN, VSHLL, VRSRA.

2011-01-31 Thread Peter Maydell
On 31 January 2011 15:59, Aurelien Jarno wrote: > Christophe Lyon a écrit : >> Well, I can't reproduce this error :-( >> For the record, I configure with --target-list=arm-softmmu,arm-linux-user >> --disable-bluez --enable-debug --disable-sdl and point --host-cc and --cc to >> GCC-4.5.1. >> > >

[Qemu-devel] Re: [PATCH 17/22] kvm: Move irqchip event processing out of inner loop

2011-01-31 Thread Jan Kiszka
On 2011-01-31 17:38, Gleb Natapov wrote: > On Mon, Jan 31, 2011 at 04:40:34PM +0100, Jan Kiszka wrote: >> On 2011-01-31 14:04, Jan Kiszka wrote: >>> On 2011-01-31 12:36, Jan Kiszka wrote: On 2011-01-31 11:08, Avi Kivity wrote: > On 01/27/2011 03:10 PM, Jan Kiszka wrote: >> Align with q

Re: [Qemu-devel] [PATCHv2] fix linuxboot.bin and multiboot.bin to not hijack int19

2011-01-31 Thread Alexander Graf
On 31.01.2011, at 14:11, Gleb Natapov wrote: > Currently linuxboot.bin and multiboot.bin option roms override int19 > vector to intercept boot process. No sane option rom should do that. > Provide bev entry instead that will be called by BIOS if option rom > is selected for booting. No idea abou

Re: [Qemu-devel] [PATCH 1/8] target-arm: Fixes for several shift instructions: VRSHL, VRSHR, VRSHRN, VSHLL, VRSRA.

2011-01-31 Thread Aurelien Jarno
Christophe Lyon a écrit : > On 31.01.2011 10:44, Aurelien Jarno wrote: >> On Mon, Jan 31, 2011 at 10:35:30AM +0100, Christophe Lyon wrote: >>> On 31.01.2011 09:20, Aurelien Jarno wrote: On Fri, Jan 28, 2011 at 04:50:59PM +0100, christophe.l...@st.com wrote: > From: Christophe Lyon > >

[Qemu-devel] Re: [PATCH 17/22] kvm: Move irqchip event processing out of inner loop

2011-01-31 Thread Gleb Natapov
On Mon, Jan 31, 2011 at 04:40:34PM +0100, Jan Kiszka wrote: > On 2011-01-31 14:04, Jan Kiszka wrote: > > On 2011-01-31 12:36, Jan Kiszka wrote: > >> On 2011-01-31 11:08, Avi Kivity wrote: > >>> On 01/27/2011 03:10 PM, Jan Kiszka wrote: > Align with qemu-kvm and prepare for IO exit fix: There i

[Qemu-devel] Re: [PATCH v3 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-01-31 Thread Avi Kivity
On 01/31/2011 04:31 PM, Jan Kiszka wrote: >> >> And how would you be kicked out of the select() call if it is waiting >> with a timeout? We only have a single thread here. > > If we use signalfd() (either kernel provided or thread+pipe), we kick > out of select by select()ing it (though I don

Re: [Qemu-devel] [PATCH V9 10/16] xen: Introduce the Xen mapcache

2011-01-31 Thread Stefano Stabellini
On Wed, 26 Jan 2011, Anthony Liguori wrote: > > +void qemu_invalidate_map_cache(void) > > +{ > > +unsigned long i; > > +MapCacheRev *reventry; > > + > > +qemu_aio_flush(); > > > > This is bizarre? Why is this needed? > Sorry, I forgot to reply to this question. Xen might send an IO

[Qemu-devel] [PATCH 03/28] strtosz(): Fix name confusion in use of modf()

2011-01-31 Thread Kevin Wolf
From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- cutils.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cutils.c b/cutils.c index 78d35e2..369a016 100644 --- a/cutils.c +++ b/cutils.c @@ -304,8 +304,8 @@ int64_t strtosz_suffix(const cha

[Qemu-devel] Re: [PATCH 17/22] kvm: Move irqchip event processing out of inner loop

2011-01-31 Thread Jan Kiszka
On 2011-01-31 14:04, Jan Kiszka wrote: > On 2011-01-31 12:36, Jan Kiszka wrote: >> On 2011-01-31 11:08, Avi Kivity wrote: >>> On 01/27/2011 03:10 PM, Jan Kiszka wrote: Align with qemu-kvm and prepare for IO exit fix: There is no need to run kvm_arch_process_irqchip_events in the inner VCP

[Qemu-devel] [PATCH 22/28] blockdev: Fix regression in -drive if=scsi, index=N

2011-01-31 Thread Kevin Wolf
From: Markus Armbruster Before commit 622b520f, index=12 meant bus=1,unit=5. Since the commit, it means bus=0,unit=12. The drive is created, but not the guest device. That's because the controllers we use with if=scsi drives (lsi53c895a and esp) support only 7 units, and scsi_bus_legacy_handle

Re: [Qemu-devel] [PATCH] target-arm: Set the right overflow bit for neon 32 and 64 bit saturating add/sub.

2011-01-31 Thread Christophe Lyon
On 24.01.2011 13:41, Christophe Lyon wrote: > Here is an updated patch with these minor fixes. > ping?

[Qemu-devel] [PATCH 13/28] qemu-io: Fix discard command

2011-01-31 Thread Kevin Wolf
qemu-io passed bytes where it's supposed to pass sectors, so discard requests were off. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- qemu-io.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index 5b24c5e..4470e49 100644 --- a/qemu-i

Re: [Qemu-devel] [PATCH 03/11] arm: drop unused irq-related part of CPUARMState

2011-01-31 Thread Peter Maydell
On 31 January 2011 15:20, Dmitry Eremin-Solenikov wrote: > These two fields were added as a part of ARMv7 support patch (back in > 2007), were never used by any code, so can be dropped. > > Signed-off-by: Dmitry Eremin-Solenikov Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] [PATCH 26/28] blockdev: Reject multiple definitions for the same drive

2011-01-31 Thread Kevin Wolf
From: Markus Armbruster We silently ignore multiple definitions for the same drive: $ qemu-system-x86_64 -nodefaults -vnc :1 -S -monitor stdio -drive if=ide,index=1,file=tmp.qcow2 -drive if=ide,index=1,file=nonexistant QEMU 0.13.50 monitor - type 'help' for more information (qemu) i

[Qemu-devel] [PATCH 19/28] blockdev: New drive_get_next(), replacing qdev_init_bdrv()

2011-01-31 Thread Kevin Wolf
From: Markus Armbruster qdev_init_bdrv() doesn't belong into qdev.c; it's about drives, not qdevs. Rename to drive_get_next, move to blockdev.c, drop the bogus DeviceState argument, and return DriveInfo instead of BlockDriverState. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --

[Qemu-devel] [PATCH 20/28] blockdev: Move BlockInterfaceType from qemu-common.h to blockdev.h

2011-01-31 Thread Kevin Wolf
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- blockdev.h|6 ++ qemu-common.h |6 -- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/blockdev.h b/blockdev.h index 3ed6634..2cbbb87 100644 --- a/blockdev.h +++ b/blockdev.

[Qemu-devel] [PATCH 25/28] blockdev: New drive_get_by_index()

2011-01-31 Thread Kevin Wolf
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- blockdev.c |7 +++ blockdev.h |1 + 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index a42c5e4..01228f6 100644 --- a/blockdev.c +++ b/blockdev.c @@ -136,

[Qemu-devel] [PATCH 09/28] Add documentation for STRTOSZ_DEFSUFFIX_ macros

2011-01-31 Thread Kevin Wolf
From: Jes Sorensen Signed-off-by: Jes Sorensen Acked-by: Markus Armbruster Signed-off-by: Kevin Wolf --- qemu-common.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qemu-common.h b/qemu-common.h index c351131..79e1149 100644 --- a/qemu-common.h +++ b/qemu-comm

[Qemu-devel] [PATCH 23/28] blockdev: Make drive_add() take explicit type, index parameters

2011-01-31 Thread Kevin Wolf
From: Markus Armbruster Before, type & index were hidden in printf-like fmt, ... parameters, which get expanded into an option string. Rather inconvenient for uses later in this series. New IF_DEFAULT to ask for the machine's default interface. Before, that was done by having no option "if" in

[Qemu-devel] [PATCH 24/28] blockdev: Factor drive_index_to_{bus, unit}_id out of drive_init()

2011-01-31 Thread Kevin Wolf
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- blockdev.c | 22 ++ 1 files changed, 14 insertions(+), 8 deletions(-) diff --git a/blockdev.c b/blockdev.c index 6d828f2..a42c5e4 100644 --- a/blockdev.c +++ b/blockdev.c @@ -75,6 +75,

[Qemu-devel] [PATCH 28/28] blockdev: Fix drive_add for drives without media

2011-01-31 Thread Kevin Wolf
From: Markus Armbruster Watch this: (qemu) drive_add 0 if=none (qemu) info block none0: type=hd removable=0 [not inserted] (qemu) drive_del none0 Segmentation fault (core dumped) add_init_drive() is confused about drive_init()'s failure modes, and cleans up when it shouldn't

[Qemu-devel] [PATCH 21/28] blockdev: Put BlockInterfaceType names and max_devs in tables

2011-01-31 Thread Kevin Wolf
From: Markus Armbruster Turns drive_init()'s lengthy conditional into a concise loop, and makes the data available elsewhere. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- blockdev.c | 51 +-- 1 files changed, 21 insertions(+)

Re: [Qemu-devel] [PATCH] target-arm: Fix Neon vsra instructions.

2011-01-31 Thread Christophe Lyon
On 25.01.2011 18:18, Christophe Lyon wrote: > This patch fixes the errors reported by my tests in VSRA. > ping?

[Qemu-devel] [PATCH 11/28] Reorganize struct Qcow2Cache for better struct packing

2011-01-31 Thread Kevin Wolf
From: Jes Sorensen Move size after the two pointers in struct Qcow2Cache to get better packing of struct elements on 64 bit architectures. Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- block/qcow2-cache.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/bl

[Qemu-devel] [PATCH 16/28] raw-win32: Fix bdrv_flush return value

2011-01-31 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/raw-win32.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/raw-win32.c b/block/raw-win32.c index 06c9710..c204a80 100644 --- a/block/raw-win32.c +++ b/block/raw-win32.c @@ -153,7 +153,7 @@ static int raw_flush(BlockDriverState *

[Qemu-devel] [PATCH 06/28] block: tell drivers about an image resize

2011-01-31 Thread Kevin Wolf
From: Christoph Hellwig Extend the change_cb callback with a reason argument, and use it to tell drivers about size changes. Signed-off-by: Christoph Hellwig Signed-off-by: Kevin Wolf --- block.c | 12 block.h |3 ++- block_int.h |5 - hw/ide/core.c |

[Qemu-devel] [PATCH 17/28] scsi hotplug: Set DriveInfo member bus correctly

2011-01-31 Thread Kevin Wolf
From: Markus Armbruster drive_init() picks the first free bus and unit number, unless the user specifies them. This isn't a good fit for the drive_add monitor command, because there we specify the controller by PCI address instead of using bus number set by drive_init(). scsi_hot_add() takes ca

[Qemu-devel] [PATCH 10/28] ahci: Fix cpu_physical_memory_unmap() argument ordering

2011-01-31 Thread Kevin Wolf
From: Stefan Hajnoczi The len and is_write arguments to cpu_physical_memory_unmap() were swapped. This patch changes calls to use the correct argument ordering. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- hw/ide/ahci.c | 10 +- 1 files changed, 5 insertions(+), 5 d

[Qemu-devel] [PATCH 27/28] blockdev: Replace drive_add()'s fmt, ... by optstr parameter

2011-01-31 Thread Kevin Wolf
From: Markus Armbruster Let the callers build the optstr. Only one wants to. All the others become simpler, because they don't have to worry about escaping '%'. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- blockdev.c |8 +--- blockdev.h |5 + vl.c |

[Qemu-devel] [PATCH 05/28] block: add block_resize monitor command

2011-01-31 Thread Kevin Wolf
From: Christoph Hellwig Add a monitor command that allows resizing of block devices while qemu is running. It uses the existing bdrv_truncate method already used by qemu-img to do it's work. Compared to qemu-img the size parsing is very simplicistic, but I think having a properly numering objec

[Qemu-devel] [PATCH 12/28] sheepdog: support creating images on remote hosts

2011-01-31 Thread Kevin Wolf
From: MORITA Kazutaka This patch parses the input filename in sd_create(), and enables us specifying a target server to create sheepdog images. Signed-off-by: MORITA Kazutaka Signed-off-by: Kevin Wolf --- block/sheepdog.c | 17 ++--- 1 files changed, 14 insertions(+), 3 deletion

[Qemu-devel] [PATCH 15/28] qed: Images with backing file do not require QED_F_NEED_CHECK

2011-01-31 Thread Kevin Wolf
From: Stefan Hajnoczi The consistency check on open is necessary in order to fix inconsistent table offsets left as a result of a crash mid-operation. Images with a backing file actually flush before updating table offsets and are therefore guaranteed to be consistent. Do not mark these images

[Qemu-devel] [PATCH 14/28] qcow2: Add bdrv_discard support

2011-01-31 Thread Kevin Wolf
This adds a bdrv_discard function to qcow2 that frees the discarded clusters. It does not yet pass the discard on to the underlying file system driver, but the space can be reused by future writes to the image. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- block/qcow2-cluster.c |

[Qemu-devel] [PATCH 02/28] strtosz() use qemu_toupper() to simplify switch statement

2011-01-31 Thread Kevin Wolf
From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- cutils.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/cutils.c b/cutils.c index a067cf4..78d35e2 100644 --- a/cutils.c +++ b/cutils.c @@ -323,16 +323,14 @@ int64_t strtosz_suffix(cons

[Qemu-devel] [PATCH 18/28] qcow2-refcount: remove write-only variables

2011-01-31 Thread Kevin Wolf
From: Blue Swirl Variables l2_modified and l2_size are not really used, remove them. Spotted by GCC 4.6.0: CCblock/qcow2-refcount.o /src/qemu/block/qcow2-refcount.c: In function 'qcow2_update_snapshot_refcount': /src/qemu/block/qcow2-refcount.c:708:37: error: variable 'l2_modified' set but

[Qemu-devel] [PATCH 10/11] mainstone: convert FPGA emulation code to use QDev/SysBus

2011-01-31 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- hw/mainstone.c | 10 +++-- hw/mainstone.h |3 -- hw/mst_fpga.c | 103 +-- 3 files changed, 53 insertions(+), 63 deletions(-) diff --git a/hw/mainstone.c b/hw/mainstone.c index 61cac8a..7d13972

[Qemu-devel] [PATCH 07/28] virtio-blk: tell the guest about size changes

2011-01-31 Thread Kevin Wolf
From: Christoph Hellwig Raise a config change interrupt when the size changed. This allows virtio-blk guest drivers to read-read the information from the config space once it got the config chaged interrupt. Signed-off-by: Christoph Hellwig Signed-off-by: Kevin Wolf --- hw/virtio-blk.c | 1

[Qemu-devel] [PATCH 04/28] strtosz(): Use suffix macros in switch() statement

2011-01-31 Thread Kevin Wolf
From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- cutils.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cutils.c b/cutils.c index 369a016..8d562b2 100644 --- a/cutils.c +++ b/cutils.c @@ -324,26 +324,26 @@ int64_t strtosz_suffix(c

[Qemu-devel] [PATCH 08/28] virtio-pci: Disable virtio-ioeventfd when !CONFIG_IOTHREAD

2011-01-31 Thread Kevin Wolf
From: Stefan Hajnoczi It is not possible to use virtio-ioeventfd when building without an I/O thread. We rely on a signal to kick us out of vcpu execution. Timers and AIO use SIGALRM and SIGUSR2 respectively. Unfortunately eventfd does not support O_ASYNC (SIGIO) so eventfd cannot be used in a

[Qemu-devel] [PULL 00/28] Block patches

2011-01-31 Thread Kevin Wolf
The following changes since commit 45d1aa828f8c94b082a0aa2dbf76535594ee45df: Update OpenBIOS images to r1018 (2011-01-30 13:10:10 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git block Blue Swirl (1): qcow2-refcount: remove write-only variables Christoph

[Qemu-devel] [PATCH 07/11] tc6393xb: correct NAND isr assertion

2011-01-31 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- hw/tc6393xb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/tc6393xb.c b/hw/tc6393xb.c index c3fbe4e..0cadcde 100644 --- a/hw/tc6393xb.c +++ b/hw/tc6393xb.c @@ -381,7 +381,7 @@ static void tc6393xb_nand_writeb(TC6393xbState

[Qemu-devel] [PATCH 01/28] strtosz(): use unsigned char and switch to qemu_isspace()

2011-01-31 Thread Kevin Wolf
From: Jes Sorensen isspace() behavior is undefined for signed char. Bug pointed out by Eric Blake, thanks! Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- cutils.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/cutils.c b/cutils.c index 4d2e27c..a067

[Qemu-devel] [PATCH 08/11] Add scoop post_load callback that sets IRQs to loaded levels

2011-01-31 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- hw/zaurus.c | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/hw/zaurus.c b/hw/zaurus.c index fca11a5..90fedc9 100644 --- a/hw/zaurus.c +++ b/hw/zaurus.c @@ -181,17 +181,34 @@ static int scoop_init(SysBusDevice *

[Qemu-devel] [PATCH 06/11] pxa2xx_pic: fully encapsulate pic into DeviceState

2011-01-31 Thread Dmitry Eremin-Solenikov
Currently pxa2xx_pic exposes it's internal gpio_in array. Replace all references to the array with calls to qdev_get_gpio_in(). Signed-off-by: Dmitry Eremin-Solenikov --- hw/mst_fpga.c |7 --- hw/pxa.h | 10 +- hw/pxa2xx.c | 53 ++---

[Qemu-devel] [PATCH 11/11] Merge mainstone.h header into mainstone.c

2011-01-31 Thread Dmitry Eremin-Solenikov
Now the only user of mainstone.h is mainstone.c file. Merge header into board file. Signed-off-by: Dmitry Eremin-Solenikov --- hw/mainstone.c | 23 ++- hw/mainstone.h | 35 --- 2 files changed, 22 insertions(+), 36 deletions(-) delete mode

[Qemu-devel] [PATCH 05/11] pxa2xx_pic: update to use qdev and arm-pic

2011-01-31 Thread Dmitry Eremin-Solenikov
pxa2xx_pic duplicated some code from arm-pic. Drop it, replacing with references to arm-pic. Also use qdev/sysbus framework to handle pxa2xx-pic. Signed-off-by: Dmitry Eremin-Solenikov --- hw/pxa2xx_pic.c | 125 +-- 1 files changed, 66 inserti

[Qemu-devel] [PATCH 09/11] Drop unnecessary inclusions of pxa.h header

2011-01-31 Thread Dmitry Eremin-Solenikov
Seceral files contained onnecessary dependencies on hw/pxa.h header. Drop unused references. Signed-off-by: Dmitry Eremin-Solenikov --- hw/mainstone.c |2 +- hw/mainstone.h |2 +- hw/mst_fpga.c |9 - hw/tc6393xb.c |1 - hw/zaurus.c|1 - 5 files changed, 6 insert

[Qemu-devel] [PATCH 04/11] arm-pic: add one extra interrupt to support EXITTB interrupts

2011-01-31 Thread Dmitry Eremin-Solenikov
Some ARM processors (consider PXA2xx, Omap1, etc.) want to be able to send CPU_INTERRUPT_EXITTB to the cpu. Support doing that through common arm_pic. Signed-off-by: Dmitry Eremin-Solenikov --- hw/arm-misc.h |1 + hw/arm_pic.c |6 +- 2 files changed, 6 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH 03/11] arm: drop unused irq-related part of CPUARMState

2011-01-31 Thread Dmitry Eremin-Solenikov
These two fields were added as a part of ARMv7 support patch (back in 2007), were never used by any code, so can be dropped. Signed-off-by: Dmitry Eremin-Solenikov --- target-arm/cpu.h |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h

[Qemu-devel] [PATCH 02/11] sysbus: print amount of irqs in dev_print

2011-01-31 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- hw/sysbus.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/sysbus.c b/hw/sysbus.c index 1583bd8..1928b51 100644 --- a/hw/sysbus.c +++ b/hw/sysbus.c @@ -178,6 +178,7 @@ static void sysbus_dev_print(Monitor *mon, DeviceState *

[Qemu-devel] [PATCH 01/11] .gitignore: ignore vi swap files and ctags files

2011-01-31 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- .gitignore |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 3efb4ec..26703e1 100644 --- a/.gitignore +++ b/.gitignore @@ -51,6 +51,8 @@ QMP/qmp-commands.txt *.vr *.d *.o +*.swp +*.orig .pc patc

  1   2   >