[Qemu-devel] Re: [PATCH] add event queueing to USB HID

2011-01-06 Thread Gerd Hoffmann
On 12/23/10 15:57, Paolo Bonzini wrote: The polling nature of the USB HID device makes it very hard to double click or drag while on a high-latency VNC connection. This patch, based on work done in the Xen qemu-dm tree by Ian Jackson, fixes this bug by adding an event queue to the device. The e

[Qemu-devel] [PATCH] savevm: print migration failure to stderr rather than monitor

2011-01-06 Thread Alex Williamson
monitor_print only does anything for foreground commands, so we don't ever see this error message in the case of a 'migrate -d'. It also doesn't do much good to print a monitor error message if the migration is being driven by something like libvirt. Both of these seem to be the typical usage scen

Re: [Qemu-devel] Re: Usefulness of the bug tracker

2011-01-06 Thread Jes Sorensen
On 01/06/11 16:11, Michael S. Tsirkin wrote: > On Thu, Jan 06, 2011 at 10:28:46AM +, Stefan Hajnoczi wrote: >> The real problem is that we're collecting bugs but not effectively >> investigating and fixing them. Can Launchpad send out automatic bug >> summary emails once every week/two weeks/m

[Qemu-devel] [Bug 688085] Re: Guest kernel hang during boot when KVM is active on i386 host

2011-01-06 Thread Froggy
Fix verified, meego qemu works well with linux 2.6.35-24.42qemui386v3. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/688085 Title: Guest kernel hang during boot when KVM is active on i386 host Sta

[Qemu-devel] Re: [PATCH 04/13] Add ThreadletQueue.

2011-01-06 Thread Arun R Bharadwaj
* Stefan Hajnoczi [2011-01-05 19:54:38]: > On Tue, Jan 04, 2011 at 10:57:27AM +0530, Arun R Bharadwaj wrote: > > @@ -66,15 +81,10 @@ typedef struct PosixAioState { > > struct qemu_paiocb *first_aio; > > } PosixAioState; > > > > - > > -static pthread_mutex_t lock = PTHREAD_MUTEX_INITIALIZE

[Qemu-devel] Re: [PATCH 08/13] Remove thread_create routine.

2011-01-06 Thread Arun R Bharadwaj
* Stefan Hajnoczi [2011-01-05 19:56:00]: > On Tue, Jan 04, 2011 at 10:57:49AM +0530, Arun R Bharadwaj wrote: > > Remove thread_create and use qemu_thread_create instead. > > > > Signed-off-by: Arun R Bharadwaj > > --- > > posix-aio-compat.c | 19 ++- > > 1 files changed, 2 in

[Qemu-devel] snapshots

2011-01-06 Thread chandra shekar
hi everyone i have got snapshot out of the image file now i would like to analyze the snapshot like opening it or identifying the fields in it can anyone suggest any softwares which i can use to open the snapshot analyze it,thanks

Re: [Qemu-devel] qemu branching internal questions

2011-01-06 Thread Mike Frysinger
On Thu, Jan 6, 2011 at 21:04, Edgar E. Iglesias wrote: > You'll have to check the details in the code but I hope this gets > you going. thanks, that info was perfect. it allowed me to understand better what qemu actually was doing and track down the problem. i thought the infinite loop/hang was

Re: [Qemu-devel] qemu branching internal questions

2011-01-06 Thread Edgar E. Iglesias
On Thu, Jan 06, 2011 at 01:47:56PM -0500, Mike Frysinger wrote: > On Wed, Jan 5, 2011 at 05:59, Edgar E. Iglesias wrote: > > On Tue, Jan 04, 2011 at 02:43:11PM -0500, Mike Frysinger wrote: > >> i've been working on a new architecture port, but i cant quite figure > >> out some of the intricacies fr

[Qemu-devel] Re: [PATCH 3/3] MAINTAINERS: add entries for TCG

2011-01-06 Thread Richard Henderson
On 01/06/2011 02:45 PM, Alexander Graf wrote: >> +HPPA target >> +M: qemu-devel@nongnu.org >> +S: Orphan >> +F: tcg/hppa/ >> + >> +i386 target >> +M: qemu-devel@nongnu.org >> +S: Orphan >> +F: tcg/i386/ ... >> +S390 target >> +M: Alexander Graf >> +S: Maintained >> +F: tcg/s390/ > > Richard, you

[Qemu-devel] Re: [PATCH 3/3] MAINTAINERS: add entries for TCG

2011-01-06 Thread Alexander Graf
On 07.01.2011, at 02:05, Richard Henderson wrote: > On 01/06/2011 02:45 PM, Alexander Graf wrote: >>> +HPPA target >>> +M: qemu-devel@nongnu.org >>> +S: Orphan >>> +F: tcg/hppa/ >>> + >>> +i386 target >>> +M: qemu-devel@nongnu.org >>> +S: Orphan >>> +F: tcg/i386/ > ... >>> +S390 target >>> +M: Al

[Qemu-devel] Taro Celta on line - Saiba o que 2011 lhe reserva ! Promoção Janeiro de 2011

2011-01-06 Thread Taro Celta on line
O que 2011 lhe reserva? Faça esta consulta baseada na Roda Astrológica e saiba de todos os potenciais de seu ano de 2011!! e mais tiragem do plano mental de seu amor! Mais informações: http://lefayetarocelta.blogspot.com/2010/12/como-sera-seu-ano-de-2011.html Ciclos de Anos Pessoais Numerologia

Re: [Qemu-devel] [PATCH] add cacheflush in tcg_gen_code_search_pc.

2011-01-06 Thread Aurelien Jarno
Hi, On Mon, Oct 04, 2010 at 05:23:06PM +0800, qiaochong wrote: > Without cacheflush,qemu sometimes fail with segment fault on loongson > cpu,which often happens when linux begin to run init.Because user > porgram tlb refill,tlbl,tlbs,tlbm exception will often happen, > cpu_restore_state,tcg_ge

[Qemu-devel] Re: [PATCH 3/3] MAINTAINERS: add entries for TCG

2011-01-06 Thread Alexander Graf
On 06.01.2011, at 22:50, Aurelien Jarno wrote: > The MAINTAINERS file was lacking entries concerning the TCG code, add > them based on the git history. > > For the common TCG code, is probably better to keep qemu-de...@non-gnu.org > as this code can break easily, so it's better to get it reviewe

[Qemu-devel] tcg/{ppc, s390, sparc}: branch target and code retranslation

2011-01-06 Thread Aurelien Jarno
Hi, I have just sent a tcg/arm patch concerning code retranslation. You might want to look at the description (copied below), as from a first glance ppc, s390 and sparc TCG targets might be affected. If you see guest kernel panics, some segmentation fault of qemu or in the guest, strange behaviors

[Qemu-devel] Re: [PATCH 3/3] MAINTAINERS: add entries for TCG

2011-01-06 Thread malc
On Thu, 6 Jan 2011, Aurelien Jarno wrote: > The MAINTAINERS file was lacking entries concerning the TCG code, add > them based on the git history. > > For the common TCG code, is probably better to keep qemu-de...@non-gnu.org > as this code can break easily, so it's better to get it reviewed by a

[Qemu-devel] [PATCH] tcg/mips: fix branch target change during code retranslation

2011-01-06 Thread Aurelien Jarno
TCG on MIPS was trying to avoid changing the branch offset, but didn't due to a stupid typo. Fix it. Signed-off-by: Aurelien Jarno --- tcg/mips/tcg-target.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c index 2af7a2e..4e92

[Qemu-devel] [PATCH 1/3] tcg/arm: fix branch target change during code retranslation

2011-01-06 Thread Aurelien Jarno
QEMU uses code retranslation to restore the CPU state when an exception happens. For it to work the retranslation must not modify the generated code. This is what is currently implemented in ARM TCG. However on CPU that don't have icache/dcache/memory synchronised like ARM, this requirement is str

[Qemu-devel] [PATCH 3/3] tcg/arm: improve constant loading

2011-01-06 Thread Aurelien Jarno
Improve constant loading in two ways: - On all ARM versions, it's possible to load 0xff00 = -0x100 using the mvn rd, #0. Fix the conditions. - On <= ARMv6 versions, where movw and movt are not available, load the constants using mov and orr with rotations depending on the constant to load

[Qemu-devel] [PATCH 2/3] tcg/arm: fix qemu_st64 for big endian targets

2011-01-06 Thread Aurelien Jarno
Due to a typo, qemu_st64 doesn't properly byteswap the 32-bit low word of a 64 bit word before saving it. This patch fixes that. Cc: Andrzej Zaborowski Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tcg/arm/tcg-ta

[Qemu-devel] [PATCH 2/3] MAINTAINERS: Change MIPS and SH4 maintainers

2011-01-06 Thread Aurelien Jarno
Since nobody else seems interested in maintaining MIPS and SH4 targets, and as I have done most of the recent code changes, let officialize that. Signed-off-by: Aurelien Jarno --- MAINTAINERS |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINER

[Qemu-devel] [PATCH 1/3] MAINTAINERS: fix typos

2011-01-06 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- MAINTAINERS |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 59effc7..98af4ab 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -202,7 +202,7 @@ M: Edgar E. Iglesias S: Maintained F: hw/etraxfs.c -M86K M

[Qemu-devel] [PATCH 3/3] MAINTAINERS: add entries for TCG

2011-01-06 Thread Aurelien Jarno
The MAINTAINERS file was lacking entries concerning the TCG code, add them based on the git history. For the common TCG code, is probably better to keep qemu-de...@non-gnu.org as this code can break easily, so it's better to get it reviewed by a few persons. Cc: Alexander Graf Cc: Andrzej Zaboro

[Qemu-devel] [Bug 629298] Re: incorrect output of ARM instruction SMMLS

2011-01-06 Thread Aurelien Jarno
** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/629298 Title: incorrect output of ARM instruction SMMLS Status in QEMU: Fix Committe

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Aurelien Jarno
On Thu, Jan 06, 2011 at 09:19:13PM +, Peter Maydell wrote: > On 6 January 2011 18:48, Aurelien Jarno wrote: > > On Thu, Jan 06, 2011 at 03:34:38PM +, Peter Maydell wrote: > >> In helper_fnmadd() and helper_fnmsub(): > >>         if (likely(!float64_is_quiet_nan(farg1.d))) > >>            

Re: [Qemu-devel] Re: [PATCH] target-arm: fix SMMLA/SMMLS instructions

2011-01-06 Thread Aurelien Jarno
On Thu, Jan 06, 2011 at 07:00:09PM +, Peter Maydell wrote: > On 6 January 2011 18:53, Aurelien Jarno wrote: > > SMMLA and SMMLS are broken on both in normal and thumb mode, that is > > both (different) implementations are wrong. They try to avoid a 64-bit > > add for the rounding, which is not

Re: [Qemu-devel] [PATCH v2 0/3] ARM/softfloat: support flushing denormals on input

2011-01-06 Thread Aurelien Jarno
On Thu, Jan 06, 2011 at 07:37:52PM +, Peter Maydell wrote: > On ARM, the FPSCR FZ bit (which controls whether denormals should be > flushed to zero) is supposed to cause this flushing to occur both > when the output of a calculation is a denormal (already implemented in > softfloat) and also wh

Re: [Qemu-devel] cirrus_vga: uninitialized variable warnings

2011-01-06 Thread Blue Swirl
On Thu, Jan 6, 2011 at 9:13 PM, Aurelien Jarno wrote: > On Thu, Jan 06, 2011 at 07:45:01PM +, Blue Swirl wrote: >> There are a few variables which appear uninitialized to GCC 4.6.0: > > It's due to my commit 92d675d1c1f23f3617e24b63c825074a1d1da44b > >>   CC    i386-softmmu/cirrus_vga.o >> /sr

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Peter Maydell
On 6 January 2011 18:48, Aurelien Jarno wrote: > On Thu, Jan 06, 2011 at 03:34:38PM +, Peter Maydell wrote: >> In helper_fnmadd() and helper_fnmsub(): >>         if (likely(!float64_is_quiet_nan(farg1.d))) >>             farg1.d = float64_chs(farg1.d); >> >> is I think OK but somebody else mig

Re: [Qemu-devel] cirrus_vga: uninitialized variable warnings

2011-01-06 Thread Aurelien Jarno
On Thu, Jan 06, 2011 at 07:45:01PM +, Blue Swirl wrote: > There are a few variables which appear uninitialized to GCC 4.6.0: It's due to my commit 92d675d1c1f23f3617e24b63c825074a1d1da44b > CCi386-softmmu/cirrus_vga.o > /src/qemu/hw/cirrus_vga.c: In function 'cirrus_bitblt_start': > /sr

Re: [Qemu-devel] [PATCH] add MADV_DONTFORK to guest physical memory

2011-01-06 Thread Michael Roth
On 01/06/2011 11:49 AM, Andrea Arcangeli wrote: On Wed, Jan 05, 2011 at 03:27:37PM -0600, Michael Roth wrote: On 01/05/2011 02:35 PM, Andrea Arcangeli wrote: On Wed, Jan 05, 2011 at 02:26:19PM -0600, Michael Roth wrote: Yah you're right, but I've seen several discussions about using mempath fo

[Qemu-devel] [PATCH v2 2/3] ARM: Set softfloat cumulative exc flags from correct FPSCR bits

2011-01-06 Thread Peter Maydell
When handling a write to the ARM FPSCR, set the softfloat cumulative exception flags from the cumulative flags in the FPSCR, not the exception-enable bits. Also don't apply a mask: vfp_exceptbits_to_host will only look at the correct bits anyway. Signed-off-by: Peter Maydell --- target-arm/helpe

[Qemu-devel] [PATCH v2 1/3] softfloat: Implement flushing input denormals to zero

2011-01-06 Thread Peter Maydell
Add support to softfloat for flushing input denormal float32 and float64 to zero. softfloat's existing 'flush_to_zero' flag only flushes denormals to zero on output. Some CPUs need input denormals to be flushed before processing as well. Implement this, using a new status flag to enable it and a ne

[Qemu-devel] [PATCH v2 3/3] ARM: wire up the softfloat flush_input_to_zero flag

2011-01-06 Thread Peter Maydell
Wire up the new softfloat support for flushing input denormals to zero on ARM. The FPSCR FZ bit enables flush-to-zero for both inputs and outputs, but the reporting of when inputs are flushed to zero is via a separate IDC bit rather than the UFC (underflow) bit used when output denormals are flushe

[Qemu-devel] [PATCH v2 0/3] ARM/softfloat: support flushing denormals on input

2011-01-06 Thread Peter Maydell
On ARM, the FPSCR FZ bit (which controls whether denormals should be flushed to zero) is supposed to cause this flushing to occur both when the output of a calculation is a denormal (already implemented in softfloat) and also when the input to a calculation is a denormal (not implemented, as noted

[Qemu-devel] [PATCH 33/35] kvm: Do not use qemu_fair_mutex

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka The imbalance in the hold time of qemu_global_mutex only exists in TCG mode. In contrast to TCG VCPUs, KVM drops the global lock during guest execution. We already avoid touching the fairness lock from the IO-thread in KVM mode, so also stop using it from the VCPU threads. Signe

[Qemu-devel] cirrus_vga: uninitialized variable warnings

2011-01-06 Thread Blue Swirl
There are a few variables which appear uninitialized to GCC 4.6.0: CCi386-softmmu/cirrus_vga.o /src/qemu/hw/cirrus_vga.c: In function 'cirrus_bitblt_start': /src/qemu/hw/cirrus_vga.c:678: warning: 'depth' may be used uninitialized in this function /src/qemu/hw/cirrus_vga.c:678: note: 'depth'

[Qemu-devel] Re: [PATCH] target-arm: fix SMMLA/SMMLS instructions

2011-01-06 Thread Peter Maydell
On 6 January 2011 18:53, Aurelien Jarno wrote: > SMMLA and SMMLS are broken on both in normal and thumb mode, that is > both (different) implementations are wrong. They try to avoid a 64-bit > add for the rounding, which is not trivial if you want to support both > SMMLA and SMMLS with the same co

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Nathan Froyd
On Thu, Jan 06, 2011 at 03:34:38PM +, Peter Maydell wrote: > Similarly I'm dubious about uses in helper_fsel, helper_fcmpu > and helper_fcmpo, efsctsi, efsctui, efsctsiz, efsctuiz, efsctsf, > efsctuf and all the helper_efd* functions. I haven't actually > checked them all, but for instance efdc

[Qemu-devel] [PATCH] target-arm: fix SMMLA/SMMLS instructions

2011-01-06 Thread Aurelien Jarno
SMMLA and SMMLS are broken on both in normal and thumb mode, that is both (different) implementations are wrong. They try to avoid a 64-bit add for the rounding, which is not trivial if you want to support both SMMLA and SMMLS with the same code. The code below uses the same implementation for bot

[Qemu-devel] [PATCH 35/35] kvm: x86: Only read/write MSR_KVM_ASYNC_PF_EN if supported

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka If the kernel does not support KVM_CAP_ASYNC_PF, it also does not know about the related MSR. So skip it during state synchronization in that case. Fixes annoying kernel warnings. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- target-i386/kvm.c | 12 ++

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Stuart Brady
On Thu, Jan 06, 2011 at 06:43:28PM +, Peter Maydell wrote: > On 6 January 2011 18:13, Stuart Brady wrote: > > On Thu, Jan 06, 2011 at 08:58:17AM +, Peter Maydell wrote: > >> On 5 January 2011 23:13, Stuart Brady wrote: > >> > I do have a few concerns regarding SoftFloat, though: > >> > >

Re: [Qemu-devel] [PATCH] add MADV_DONTFORK to guest physical memory

2011-01-06 Thread Andrea Arcangeli
On Wed, Jan 05, 2011 at 03:27:37PM -0600, Michael Roth wrote: > On 01/05/2011 02:35 PM, Andrea Arcangeli wrote: > > On Wed, Jan 05, 2011 at 02:26:19PM -0600, Michael Roth wrote: > >> Yah you're right, but I've seen several discussions about using mempath > >> for tmpfs/ram-backed files for things l

[Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-06 Thread Anthony Liguori
On 01/06/2011 11:56 AM, Marcelo Tosatti wrote: From: Jan Kiszka QEMU supports only one VM, so there is only one kvm_state per process, and we gain nothing passing a reference to it around. Eliminate any need to refer to it outside of kvm-all.c. Signed-off-by: Jan Kiszka CC: Alexander Graf Signe

[Qemu-devel] [PATCH 1/2] softfloat: Implement floatx80_is_any_nan() and float128_is_any_nan()

2011-01-06 Thread Peter Maydell
Implement versions of float*_is_any_nan() for the floatx80 and float128 types. Signed-off-by: Peter Maydell --- fpu/softfloat.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/fpu/softfloat.h b/fpu/softfloat.h index f2104c6..ac81845 100644 --- a/fpu/softfloat.

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Peter Maydell
On 6 January 2011 18:13, Stuart Brady wrote: > On Thu, Jan 06, 2011 at 08:58:17AM +, Peter Maydell wrote: >> On 5 January 2011 23:13, Stuart Brady wrote: >> > I do have a few concerns regarding SoftFloat, though: >> > >> >   FIXMEs should be left in the code (or a document maintained on the >

[Qemu-devel] [PATCH 2/2] linux-user: Fix incorrect NaN detection in ARM nwfpe emulation

2011-01-06 Thread Peter Maydell
The code in the linux-user ARM nwfpe emulation was incorrectly checking only for quiet NaNs when it should have been checking for any kind of NaN. This is probably because the code in question was taken from the Linux kernel, whose copy of the softfloat library had been modified so that float*_is_n

[Qemu-devel] Re: acpi_piix4: expose no_hotplug attribute via i/o port

2011-01-06 Thread Marcelo Tosatti
On Wed, Jan 05, 2011 at 09:32:39PM +0200, Michael S. Tsirkin wrote: > On Wed, Dec 08, 2010 at 03:11:36PM -0200, Marcelo Tosatti wrote: > > > > On top of "add hotplug opt-out option for devices" patchset > > http://www.mail-archive.com/qemu-devel@nongnu.org/msg46953.html. > > > > Signed-off-by: M

Re: [Qemu-devel] Re: [PATCH 2/3] piix: tag as not hotpluggable.

2011-01-06 Thread Marcelo Tosatti
On Thu, Jan 06, 2011 at 04:34:38PM +0200, Michael S. Tsirkin wrote: > On Thu, Jan 06, 2011 at 03:14:18PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > >Could you split the tested and untested parts to separate patches, > > >noting the status in the commit message? > > > > I think this is overkill

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Aurelien Jarno
On Thu, Jan 06, 2011 at 03:34:38PM +, Peter Maydell wrote: > On 6 January 2011 14:35, Aurelien Jarno wrote: > > On Wed, Jan 05, 2011 at 11:13:06PM +, Stuart Brady wrote: > >>    Is there any plan to deal with use of float*_is_quiet_nan(), where > >>    float*_is_any_nan() was intended?  Th

[Qemu-devel] [PATCH 0/2] linux-user: fix incorrect NaN detection in ARM nwfpe emulation

2011-01-06 Thread Peter Maydell
The code in the linux-user ARM nwfpe emulation was incorrectly checking only for quiet NaNs when it should have been checking for any kind of NaN. This is probably because the code in question was taken from the Linux kernel, whose copy of the softfloat library had been modified so that float*_is_

Re: FIXED: Re: [Qemu-devel] possible regression in qemu-kvm 0.13.0 (memtest)

2011-01-06 Thread Blue Swirl
On Thu, Jan 6, 2011 at 4:41 PM, Serge E. Hallyn wrote: > Thanks, Stefan.  That patch actually doesn't compile for me, because > it leaves references in hw/pckbd.c to both ioport92_write and > ioport92_read, which it deletes from there.  Should ioport92_read > just be renamed to outport_read instea

[Qemu-devel] [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka QEMU supports only one VM, so there is only one kvm_state per process, and we gain nothing passing a reference to it around. Eliminate any need to refer to it outside of kvm-all.c. Signed-off-by: Jan Kiszka CC: Alexander Graf Signed-off-by: Marcelo Tosatti --- cpu-defs.h

Re: [Qemu-devel] qemu branching internal questions

2011-01-06 Thread Mike Frysinger
On Wed, Jan 5, 2011 at 05:59, Edgar E. Iglesias wrote: > On Tue, Jan 04, 2011 at 02:43:11PM -0500, Mike Frysinger wrote: >> i've been working on a new architecture port, but i cant quite figure >> out some of the intricacies from reading the code.  i have all the >> simple stuff working for linux-u

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Stuart Brady
On Thu, Jan 06, 2011 at 08:58:17AM +, Peter Maydell wrote: > On 5 January 2011 23:13, Stuart Brady wrote: > > I do have a few concerns regarding SoftFloat, though: > > > >   FIXMEs should be left in the code (or a document maintained on the > >   Wiki) to keep track of which architectures have

[Qemu-devel] Re: [PATCH v2 1/4] pci: allow devices being tagged as not hotpluggable.

2011-01-06 Thread Michael S. Tsirkin
On Thu, Jan 06, 2011 at 03:14:37PM +0100, Gerd Hoffmann wrote: > This patch adds a field to PCIDeviceInfo to tag devices as being > not hotpluggable. Any attempt to plug-in or -out such a device > will throw an error. > > Signed-off-by: Gerd Hoffmann Acked-by: Michael S. Tsirkin > --- > hw/p

[Qemu-devel] [PATCH 25/35] kvm: x86: Drop MCE MSRs write back restrictions

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka There is no need to restrict writing back MCE MSRs to reset or full state updates as setting their values has no side effects. Signed-off-by: Jan Kiszka CC: Huang Ying Signed-off-by: Marcelo Tosatti --- target-i386/kvm.c | 12 1 files changed, 4 insertions(+),

[Qemu-devel] [PATCH 06/35] kvm: introduce kvm_mce_in_progress

2011-01-06 Thread Marcelo Tosatti
From: Jin Dongming Share same error handing, and rename this function after MCIP (Machine Check In Progress) flag. Signed-off-by: Hidetoshi Seto Signed-off-by: Jin Dongming Signed-off-by: Marcelo Tosatti --- target-i386/kvm.c | 15 +-- 1 files changed, 5 insertions(+), 10 delet

[Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka If kvmclock is used, which implies the kernel supports it, register a kvmclock device with the sysbus. Its main purpose is to save and restore the kernel state on migration, but this will also allow to visualize it one day. Signed-off-by: Jan Kiszka CC: Glauber Costa Signed-of

[Qemu-devel] [PATCH 12/35] kvm: x86: Fix a few coding style violations

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka No functional changes. Signed-off-by: Jan Kiszka Signed-off-by: Avi Kivity --- target-i386/kvm.c | 335 + 1 files changed, 182 insertions(+), 153 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 85edac

[Qemu-devel] [PATCH 18/35] kvm: x86: Align kvm_arch_put_registers code with comment

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka The ordering doesn't matter in this case, but better keep it consistent. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- target-i386/kvm.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index d4

[Qemu-devel] [PATCH 04/35] Add "broadcast" option for mce command

2011-01-06 Thread Marcelo Tosatti
From: Jin Dongming When the following test case is injected with mce command, maybe user could not get the expected result. DATA command cpu bank status mcg_status addr misc (qemu) mce 1 10xbd00 0x050x1234 0x8c Expected

[Qemu-devel] [PATCH 31/35] kvm: x86: Rework identity map and TSS setup for larger BIOS sizes

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka In order to support loading BIOSes > 256K, reorder the code, adjusting the base if the kernel supports moving the identity map. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- target-i386/kvm.c | 63 +--- 1 files

[Qemu-devel] [Bug 688085] Re: Guest kernel hang during boot when KVM is active on i386 host

2011-01-06 Thread Brian Murray
** Also affects: kvm (Ubuntu Maverick) Importance: Undecided Status: New ** Also affects: linux (Ubuntu Maverick) Importance: Undecided Status: New ** Also affects: qemu (Ubuntu Maverick) Importance: Undecided Status: New ** Also affects: qemu-kvm (Ubuntu Maverick)

[Qemu-devel] [PATCH 15/35] kvm: Stop on all fatal exit reasons

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka Ensure that we stop the guest whenever we face a fatal or unknown exit reason. If we stop, we also have to enforce a cpu loop exit. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- kvm-all.c | 15 +++ target-i386/kvm.c |4 target-ppc

[Qemu-devel] [PATCH 07/35] kvm: kvm_mce_inj_* subroutines for templated error injections

2011-01-06 Thread Marcelo Tosatti
From: Jin Dongming Refactor codes for maintainability. Signed-off-by: Hidetoshi Seto Signed-off-by: Jin Dongming Signed-off-by: Marcelo Tosatti --- target-i386/kvm.c | 111 ++--- 1 files changed, 71 insertions(+), 40 deletions(-) diff --git a

[Qemu-devel] [PATCH 00/35] [PULL] qemu-kvm.git uq/master queue

2011-01-06 Thread Marcelo Tosatti
The following changes since commit 23979dc5411befabe9049e37075b2b6320debc4e: microblaze: Use more TB chaining (2011-01-05 02:23:09 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Jan Kiszka (27): kvm: x86: Fix DPL write back o

[Qemu-devel] [PATCH 05/35] Add function for checking mca broadcast of CPU

2011-01-06 Thread Marcelo Tosatti
From: Jin Dongming Add function for checking whether current CPU support mca broadcast. Signed-off-by: Jin Dongming Signed-off-by: Marcelo Tosatti --- target-i386/cpu.h|1 + target-i386/helper.c | 33 + target-i386/kvm.c|6 +- 3 files chan

[Qemu-devel] [PATCH 17/35] x86: Optionally dump code bytes on cpu_dump_state

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka Introduce the cpu_dump_state flag CPU_DUMP_CODE and implement it for x86. This writes out the code bytes around the current instruction pointer. Make use of this feature in KVM to help debugging fatal vm exits. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- cpu-

[Qemu-devel] [PATCH 16/35] kvm: Improve reporting of fatal errors

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka Report KVM_EXIT_UNKNOWN, KVM_EXIT_FAIL_ENTRY, and KVM_EXIT_EXCEPTION with more details to stderr. The latter two are so far x86-only, so move them into the arch-specific handler. Integrate the Intel real mode warning on KVM_EXIT_FAIL_ENTRY that qemu-kvm carries, but actually rest

[Qemu-devel] [PATCH 14/35] kvm: Drop return value of kvm_cpu_exec

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka It is not used, it is not needed, so let's remove it. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- kvm-all.c |6 ++ kvm-stub.c |4 ++-- kvm.h |2 +- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/kvm-all.c b/kvm-all.c inde

Re: [Qemu-devel] [PATCH] target-arm: fix SMMLA/SMMLS instructions

2011-01-06 Thread Peter Maydell
On 6 January 2011 17:24, Aurelien Jarno wrote: > For the subtraction, how would you say a = (b << 32) - a ? I think we should just say "Return (b << 32) - a" for that :-) I can't think of a clean way of putting it in English. -- PMM

[Qemu-devel] [PATCH 13/35] kvm: Fix coding style violations

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka No functional changes. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- kvm-all.c | 139 ++-- 1 files changed, 79 insertions(+), 60 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 35fc73c..2538283 100

[Qemu-devel] [PATCH 24/35] Synchronize VCPU states before reset

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka This is required to support keeping VCPU states across a system reset. If we do not read the current state before the reset, cpu_synchronize_all_post_reset may write back incorrect state information. The first user of this will be MCE MSR synchronization which currently works ar

[Qemu-devel] [PATCH 20/35] kvm: x86: Remove redundant mp_state initialization

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka kvm_arch_reset_vcpu initializes mp_state, and that function is invoked right after kvm_arch_init_vcpu. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- target-i386/kvm.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/target-i386/kvm.c b/

[Qemu-devel] [PATCH 27/35] kvm: x86: Fix !CONFIG_KVM_PARA build

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka If we lack kvm_para.h, MSR_KVM_ASYNC_PF_EN is not defined. The change in kvm_arch_init_vcpu is just for consistency reasons. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- target-i386/kvm.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PATCH 21/35] kvm: x86: Fix xcr0 reset mismerge

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka For unknown reasons, xcr0 reset ended up in kvm_arch_update_guest_debug on upstream merge. Fix this and also remove the misleading comment (1 is THE reset value). Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- target-i386/kvm.c |3 +-- 1 files changed, 1 ins

[Qemu-devel] [PATCH 22/35] kvm: x86: Refactor msr_star/hsave_pa setup and checks

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka Simplify kvm_has_msr_star/hsave_pa to booleans and push their one-time initialization into kvm_arch_init. Also handle potential errors of that setup procedure. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- target-i386/kvm.c | 47 +++---

[Qemu-devel] [PATCH 23/35] kvm: x86: Reset paravirtual MSRs

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka Make sure to write the cleared MSR_KVM_SYSTEM_TIME, MSR_KVM_WALL_CLOCK, and MSR_KVM_ASYNC_PF_EN to the kernel state so that a freshly booted guest cannot be disturbed by old values. Signed-off-by: Jan Kiszka CC: Glauber Costa Signed-off-by: Marcelo Tosatti --- target-i386/kv

[Qemu-devel] [PATCH 02/35] kvm: convert kvm_ioctl(KVM_CHECK_EXTENSION) to kvm_check_extension()

2011-01-06 Thread Marcelo Tosatti
From: Lai Jiangshan simple cleanup and use existing helper: kvm_check_extension(). Signed-off-by: Lai Jiangshan Signed-off-by: Marcelo Tosatti --- kvm-all.c |2 +- target-i386/kvm.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/kvm-all.c b/kvm-all.c i

[Qemu-devel] [PATCH 03/35] Clean up cpu_inject_x86_mce()

2011-01-06 Thread Marcelo Tosatti
From: Jin Dongming Clean up cpu_inject_x86_mce() for later patch. Signed-off-by: Jin Dongming Signed-off-by: Marcelo Tosatti --- target-i386/helper.c | 27 +-- 1 files changed, 17 insertions(+), 10 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.

[Qemu-devel] [PATCH 11/35] kvm: x86: Prevent sign extension of DR7 in guest debugging mode

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka This unbreaks guest debugging when the 4th hardware breakpoint used for guest debugging is a watchpoint of 4 or 8 byte lenght. The 31st bit of DR7 is set in that case and used to cause a sign extension to the high word which was breaking the guest state (vm entry failure). Signe

[Qemu-devel] [PATCH 34/35] kvm: x86: Implicitly clear nmi_injected/pending on reset

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka All CPUX86State variables before CPU_COMMON are automatically cleared on reset. Reorder nmi_injected and nmi_pending to avoid having to touch them explicitly. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- target-i386/cpu.h |6 -- target-i386/kvm.c |

[Qemu-devel] [PATCH 10/35] kvm: x86: Remove obsolete SS.RPL/DPL aligment

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka This seems to date back to the days KVM didn't support real mode. The check is no longer needed and, even worse, is corrupting the guest state in case SS.RPL != DPL. Signed-off-by: Jan Kiszka Signed-off-by: Avi Kivity --- target-i386/kvm.c |7 --- 1 files changed, 0 i

[Qemu-devel] [PATCH 09/35] kvm: x86: Fix DPL write back of segment registers

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka The DPL is stored in the flags and not in the selector. In fact, the RPL may differ from the DPL at some point in time, and so we were corrupting the guest state so far. Signed-off-by: Jan Kiszka Signed-off-by: Avi Kivity --- target-i386/kvm.c |2 +- 1 files changed, 1 in

[Qemu-devel] [PATCH 30/35] kvm: Consolidate must-have capability checks

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka Instead of splattering the code with #ifdefs and runtime checks for capabilities we cannot work without anyway, provide central test infrastructure for verifying their availability both at build and runtime. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- configu

[Qemu-devel] [PATCH 01/35] kvm: Enable user space NMI injection for kvm guest

2011-01-06 Thread Marcelo Tosatti
From: Lai Jiangshan Make use of the new KVM_NMI IOCTL to send NMIs into the KVM guest if the user space raised them. (example: qemu monitor's "nmi" command) Signed-off-by: Lai Jiangshan Acked-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- configure |3 +++ target-i386/kvm.c |

[Qemu-devel] [PATCH 32/35] kvm: Flush coalesced mmio buffer on IO window exits

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka We must flush pending mmio writes if we leave kvm_cpu_exec for an IO window. Otherwise we risk to loose those requests when migrating to a different host during that window. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- kvm-all.c |4 ++-- 1 files changed, 2

[Qemu-devel] [PATCH 19/35] kvm: x86: Prepare kvm_get_mp_state for in-kernel irqchip

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka This code path will not yet be taken as we still lack in-kernel irqchip support. But qemu-kvm can already make use of it and drop its own mp_state access services. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- target-i386/kvm.c |3 +++ 1 files changed, 3 in

[Qemu-devel] [PATCH 08/35] kvm: introduce kvm_inject_x86_mce_on

2011-01-06 Thread Marcelo Tosatti
From: Jin Dongming Pass a table instead of multiple args. Note: kvm_inject_x86_mce(env, bank, status, mcg_status, addr, misc, abort_on_error); is equal to: struct kvm_x86_mce mce = { .bank = bank, .status = status, .mcg_status = mcg_statu

[Qemu-devel] [PATCH 29/35] kvm: Drop smp_cpus argument from init functions

2011-01-06 Thread Marcelo Tosatti
From: Jan Kiszka No longer used. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- kvm-all.c |4 ++-- kvm-stub.c |2 +- kvm.h |4 ++-- target-i386/kvm.c |2 +- target-ppc/kvm.c |2 +- target-s390x/kvm.c |2 +- vl.c

[Qemu-devel] Re: [PATCH v5 0/4] virtio: Use ioeventfd for virtqueue notify

2011-01-06 Thread Michael S. Tsirkin
On Thu, Jan 06, 2011 at 04:41:50PM +, Stefan Hajnoczi wrote: > Here are 4k sequential read results (cache=none) to check whether we > see an ioeventfd performance regression with virtio-blk. > > The idea is to use a small blocksize with an I/O pattern (sequential > reads) that is cheap and exe

Re: [Qemu-devel] [PATCH] target-arm: fix SMMLA/SMMLS instructions

2011-01-06 Thread Aurelien Jarno
On Thu, Jan 06, 2011 at 03:54:46PM +, Peter Maydell wrote: > On 6 January 2011 15:50, Aurelien Jarno wrote: > > On Wed, Jan 05, 2011 at 11:15:15AM +, Peter Maydell wrote: > > >> Isn't this adding b to the msw of a, rather than the other > >> way round as the comment claims? > > > > I thin

[Qemu-devel] Re: [PATCH v5 0/4] virtio: Use ioeventfd for virtqueue notify

2011-01-06 Thread Michael S. Tsirkin
On Thu, Jan 06, 2011 at 04:41:50PM +, Stefan Hajnoczi wrote: > Here are 4k sequential read results (cache=none) to check whether we > see an ioeventfd performance regression with virtio-blk. > > The idea is to use a small blocksize with an I/O pattern (sequential > reads) that is cheap and exe

[Qemu-devel] Re: [PATCH v5 0/4] virtio: Use ioeventfd for virtqueue notify

2011-01-06 Thread Stefan Hajnoczi
Here are 4k sequential read results (cache=none) to check whether we see an ioeventfd performance regression with virtio-blk. The idea is to use a small blocksize with an I/O pattern (sequential reads) that is cheap and executes quickly. Therefore we're doing many iops and the cost virtqueue kick

Re: FIXED: Re: [Qemu-devel] possible regression in qemu-kvm 0.13.0 (memtest)

2011-01-06 Thread Serge E. Hallyn
Thanks, Stefan. That patch actually doesn't compile for me, because it leaves references in hw/pckbd.c to both ioport92_write and ioport92_read, which it deletes from there. Should ioport92_read just be renamed to outport_read instead of delted, and the remaining references changed to {input,outp

[Qemu-devel] [PATCH] do_snapshot_blkdev() error on missing snapshot_file argument

2011-01-06 Thread Jes . Sorensen
From: Jes Sorensen Current code does not support snapshot internally to the running image. Error in case no snapshot_file is specified. Signed-off-by: Jes Sorensen --- blockdev.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index d7add36

Re: [Qemu-devel] [PATCH] target-arm: fix SMMLA/SMMLS instructions

2011-01-06 Thread Peter Maydell
On 6 January 2011 15:50, Aurelien Jarno wrote: > On Wed, Jan 05, 2011 at 11:15:15AM +, Peter Maydell wrote: >> Isn't this adding b to the msw of a, rather than the other >> way round as the comment claims? > > I think the comment is actually wrong in both way, as a shift is > applied, and thu

Re: [Qemu-devel] [PATCH] target-arm: fix SMMLA/SMMLS instructions

2011-01-06 Thread Aurelien Jarno
On Wed, Jan 05, 2011 at 11:15:15AM +, Peter Maydell wrote: > On 1 January 2011 18:25, Aurelien Jarno wrote: > > SMMLA and SMMLS are broken on both in normal and thumb mode, that is > > both (different) implementations are wrong. They try to avoid a 64-bit > > add for the rounding, which is not

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Peter Maydell
On 6 January 2011 14:35, Aurelien Jarno wrote: > On Wed, Jan 05, 2011 at 11:13:06PM +, Stuart Brady wrote: >>    Is there any plan to deal with use of float*_is_quiet_nan(), where >>    float*_is_any_nan() was intended?  These should really either be >>    fixed (and tested), or if not, a FIXM

  1   2   >