[Qemu-devel] [RFT] ppc64 OpenBIOS

2010-12-17 Thread Andreas Färber
Hello, Except for some fs/iso9660/ issues, ppc64 guests are booting for me with the last five OpenBIOS patches posted. You can find them together with the config change to use fs/grubfs/ here: git://repo.or.cz/openbios/afaerber.git ppc64-boot Please test your favorite ppc64 kernels and

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-17 Thread Nathan Froyd
On Fri, Dec 17, 2010 at 11:32:03PM +, Peter Maydell wrote: > On 17 December 2010 17:54, Andreas Färber wrote: > > My patch does not touch the bits* types. I didn't notice any problem there. > > > > I replaced int32 by int32_t, int64 by int64_t etc. No sane code puts more > > than 32 bits into

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-17 Thread Peter Maydell
On 17 December 2010 17:54, Andreas Färber wrote: > Am 17.12.2010 um 17:48 schrieb Peter Maydell: >> On the types issue, at the moment softfloat uses "int32" etc for >> "a handy type holding at least 32 bits", and "bits32" for "exactly >> 32 bits". So I guess changing the 'bits' types to the POSIX

[Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-17 Thread Paolo Bonzini
On 12/17/2010 11:17 PM, Andreas Färber wrote: Example (needs bash's echo -e): # create line with crlf ending: echo -e 'include xy\r' >file # returns xy\r: awk '/^include / {ORS=" "; print $2}' file | od 000 074570 020015 004 # should return xy: awk '/^include / {ORS=" "; sub(/\r$/,

[Qemu-devel] Re: [PATCH 2/2] achi: delete write-only variables

2010-12-17 Thread Alexander Graf
On 17.12.2010, at 22:40, Blue Swirl wrote: > Avoid these warnings with GCC 4.6.0: > /src/qemu/hw/ide/ahci.c: In function 'ahci_reset_port': > /src/qemu/hw/ide/ahci.c:810:14: error: variable 'tfd' set but not used > [-Werror=unused-but-set-variable] > /src/qemu/hw/ide/ahci.c: In function 'handle_c

[Qemu-devel] [PATCH v2] softfloat: Fix function signature mismatches by using POSIX integer types

2010-12-17 Thread Andreas Färber
Don't reinvent C99 types like uint8_t by typedef'ing uint8 etc. On BeOS and Haiku, system headers {be,os}/support/SupportDefs.h do define [u]int{8,16,32,64}, but they define [u]int32 as long, so assumptions that int32 and int can be used interchangeably must be avoided. Inspired by mmlr's original

[Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-17 Thread Andreas Färber
Am 17.12.2010 um 22:25 schrieb Paolo Bonzini: On 12/17/2010 10:00 PM, Andreas Färber wrote: Am 17.12.2010 um 20:54 schrieb Stefan Weil: Am 17.12.2010 20:33, schrieb Andreas Färber: Am 17.12.2010 um 20:01 schrieb Stefan Weil: Am 17.12.2010 14:44, schrieb Paolo Bonzini: On 12/17/2010 02:34

[Qemu-devel] [PATCH 2/2] achi: delete write-only variables

2010-12-17 Thread Blue Swirl
Avoid these warnings with GCC 4.6.0: /src/qemu/hw/ide/ahci.c: In function 'ahci_reset_port': /src/qemu/hw/ide/ahci.c:810:14: error: variable 'tfd' set but not used [-Werror=unused-but-set-variable] /src/qemu/hw/ide/ahci.c: In function 'handle_cmd': /src/qemu/hw/ide/ahci.c:1103:19: error: variable '

[Qemu-devel] [PATCH 1/2] block: delete a write-only variable

2010-12-17 Thread Blue Swirl
Avoid a warning with GCC 4.6.0: /src/qemu/block.c: In function 'bdrv_img_create': /src/qemu/block.c:2862:25: error: variable 'fmt' set but not used [-Werror=unused-but-set-variable] CC: Kevin Wolf Signed-off-by: Blue Swirl --- block.c |5 - 1 files changed, 0 insertions(+), 5 deletions(

[Qemu-devel] [PATCH] ide: Fix build for cmd646.c

2010-12-17 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- hw/ide/cmd646.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index 89ba836..5d5464a 100644 --- a/hw/ide/cmd646.c +++ b/hw/ide/cmd646.c @@ -255,9 +255,9 @@ static int pci_cmd646_ide_initfn(PCIDevice *dev

[Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-17 Thread Paolo Bonzini
On 12/17/2010 10:00 PM, Andreas Färber wrote: Am 17.12.2010 um 20:54 schrieb Stefan Weil: Am 17.12.2010 20:33, schrieb Andreas Färber: Am 17.12.2010 um 20:01 schrieb Stefan Weil: Am 17.12.2010 14:44, schrieb Paolo Bonzini: On 12/17/2010 02:34 PM, Andreas Färber wrote: Fix this by removing

[Qemu-devel] [PATCH 1/5] usb-ccid: add CCID bus

2010-12-17 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_R

[Qemu-devel] [PATCH 18/38] qemu-img: Call error_set_progname

2010-12-17 Thread Kevin Wolf
Call error_set_progname during the qemu-img initialization, so that error messages printed with error_report() use the right prefix. Signed-off-by: Kevin Wolf --- qemu-img.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 1d936ed..f576cfb

Re: [Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-17 Thread Andreas Färber
Am 17.12.2010 um 20:54 schrieb Stefan Weil: Am 17.12.2010 20:33, schrieb Andreas Färber: Am 17.12.2010 um 20:01 schrieb Stefan Weil: Am 17.12.2010 14:44, schrieb Paolo Bonzini: On 12/17/2010 02:34 PM, Andreas Färber wrote: Fix this by removing any \r at end of line. Why isn't cygwin (or

Re: [Qemu-devel] [PATCH] sparc32_dma: separate ledma and espdma

2010-12-17 Thread Blue Swirl
On Fri, Dec 17, 2010 at 8:36 PM, Bob Breuer wrote: > Blue Swirl wrote: >> ESP and Lance DMA controllers are not identical. >> >> Separate the controllers on VMState and instantiation level. >> >> NB: This change breaks savevm and migration compatibility. >> >> Signed-off-by: Blue Swirl >> --- >>

[Qemu-devel] [PATCH 1/2] ide: Fix build for cmd646.c

2010-12-17 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Acked-by: Andreas Färber --- hw/ide/cmd646.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index 89ba836..5d5464a 100644 --- a/hw/ide/cmd646.c +++ b/hw/ide/cmd646.c @@ -255,9 +255,9 @@ static int pci_cmd646

[Qemu-devel] [PATCH 24/38] Remove NULL checks for bdrv_new return value

2010-12-17 Thread Kevin Wolf
It's an indirect call to qemu_malloc, which never returns an error. Signed-off-by: Kevin Wolf --- hw/xen_disk.c | 17 ++--- qemu-img.c|5 + qemu-io.c |2 -- qemu-nbd.c|2 -- 4 files changed, 7 insertions(+), 19 deletions(-) diff --git a/hw/xen_disk.c b/

[Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-17 Thread Paolo Bonzini
On 12/17/2010 08:01 PM, Stefan Weil wrote: I currently have no possibility to run tests with other awk implementations, so I cannot tell whether \012 is needed at all (\r is not a new invention). Do all awk versions support regular expressions with characters in octal encoding?. The awk manual

[Qemu-devel] [PATCH 34/38] qed: Read/write support

2010-12-17 Thread Kevin Wolf
From: Stefan Hajnoczi This patch implements the read/write state machine. Operations are fully asynchronous and multiple operations may be active at any time. Allocating writes lock tables to ensure metadata updates do not interfere with each other. If two allocating writes need to update the

[Qemu-devel] [Bug 691424] Re: qemu/kvm SDL over ssh -X broken

2010-12-17 Thread Bernhard M. Wiedemann
One possible way to get X11-forwarding back on qemu master is to disable zoom by this patch. But I do not know why the do_sdl_resize function should be problematic. There is probably a better solution. ** Patch added: "disable zoom" https://bugs.launchpad.net/qemu/+bug/691424/+attachment/1769

Re: [Qemu-devel] [PATCH] sparc32_dma: separate ledma and espdma

2010-12-17 Thread Bob Breuer
Blue Swirl wrote: > ESP and Lance DMA controllers are not identical. > > Separate the controllers on VMState and instantiation level. > > NB: This change breaks savevm and migration compatibility. > > Signed-off-by: Blue Swirl > --- > Perhaps the compat properties could be used to retain compatibi

[Qemu-devel] [PATCH] ide: Build fix for via.c

2010-12-17 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- hw/ide/via.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/ide/via.c b/hw/ide/via.c index 5b70bd2..0e90679 100644 --- a/hw/ide/via.c +++ b/hw/ide/via.c @@ -150,7 +150,7 @@ static void vt82c686b_init_ports(PCIIDEState *d) { bmdm

Re: [Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-17 Thread Stefan Weil
Am 17.12.2010 20:33, schrieb Andreas Färber: Am 17.12.2010 um 20:01 schrieb Stefan Weil: Am 17.12.2010 14:44, schrieb Paolo Bonzini: On 12/17/2010 02:34 PM, Andreas Färber wrote: Fix this by removing any \r at end of line. Why isn't cygwin (or whatever you're using) removing it? I believ

[Qemu-devel] [PATCH 0/5] usb-ccid (v11)

2010-12-17 Thread Alon Levy
This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. It also introduces a new directory libcaccard with CAC card emulation, CAC is a type of

[Qemu-devel] [PATCH 4/5] ccid: add ccid-card-emulated device (v2)

2010-12-17 Thread Alon Levy
This devices uses libcacard (internal) to emulate a smartcard conforming to the CAC standard. It attaches to the usb-ccid bus. Usage instructions (example command lines) are in the following patch in docs/ccid.txt. It uses libcacard which uses nss, so it can work with both hw cards and certificates

[Qemu-devel] [PATCH 2/5] ccid: add passthru card device

2010-12-17 Thread Alon Levy
The passthru ccid card is a device sitting on the usb-ccid bus and using a chardevice to communicate with a remote device using the VSCard protocol defined in libcacard/vscard_common.h Usage docs available in following patch in docs/ccid.txt Signed-off-by: Alon Levy --- Makefile.objs

[Qemu-devel] [PATCH 5/5] ccid: add docs

2010-12-17 Thread Alon Levy
Add documentation for the usb-ccid device and accompanying two card devices, ccid-card-emulated and ccid-card-passthru. --- docs/ccid.txt | 135 + 1 files changed, 135 insertions(+), 0 deletions(-) create mode 100644 docs/ccid.txt diff --g

[Qemu-devel] Re: [PULL 0/2] ide: Build fixes

2010-12-17 Thread Anthony Liguori
On 12/17/2010 01:38 PM, Kevin Wolf wrote: The following changes since commit e59d688ad112719cb264f395b1f5895866ebf309: docs: Fix missing carets in QED specification (2010-12-17 17:05:06 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Pushed

[Qemu-devel] [PATCH 17/38] ide: honor ncq for atapi

2010-12-17 Thread Kevin Wolf
From: Alexander Graf ATAPI also can do ncq, so let's expose the capability. This patch makes CD-ROM support work on Windows 7 for me. Signed-off-by: Alexander Graf Signed-off-by: Kevin Wolf --- hw/ide/core.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/ide

[Qemu-devel] [PATCH 2/2] ide: Build fix for via.c

2010-12-17 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- hw/ide/via.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/ide/via.c b/hw/ide/via.c index 5b70bd2..0e90679 100644 --- a/hw/ide/via.c +++ b/hw/ide/via.c @@ -150,7 +150,7 @@ static void vt82c686b_init_ports(PCIIDEState *d) { bmdm

[Qemu-devel] [PULL 0/2] ide: Build fixes

2010-12-17 Thread Kevin Wolf
The following changes since commit e59d688ad112719cb264f395b1f5895866ebf309: docs: Fix missing carets in QED specification (2010-12-17 17:05:06 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Kevin Wolf (2): ide: Fix build for cmd646.c i

Re: [Qemu-devel] [PATCH] spice: add chardev (v3)

2010-12-17 Thread Alon Levy
On Fri, Dec 17, 2010 at 09:01:31AM -0600, Anthony Liguori wrote: > On 12/17/2010 07:39 AM, Alon Levy wrote: > >Adding a chardev backend for spice, for usage by spice vdagent in > >conjunction with a properly named virtio-serial device. > > > >Example usage: > > qemu -device virtio-serial -chardev

Re: [Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-17 Thread Andreas Färber
Am 17.12.2010 um 20:01 schrieb Stefan Weil: Am 17.12.2010 14:44, schrieb Paolo Bonzini: On 12/17/2010 02:34 PM, Andreas Färber wrote: Fix this by removing any \r at end of line. Why isn't cygwin (or whatever you're using) removing it? I believe Cygwin had an option to choose the line endi

[Qemu-devel] [PATCH 05/38] qemu-img.c: Clean up handling of image size in img_create()

2010-12-17 Thread Kevin Wolf
From: Jes Sorensen This cleans up the handling of image size in img_create() by parsing the value early, and then only setting it once if a value has been added as the last argument to the command line. Signed-off-by: Jes Sorensen Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- qe

[Qemu-devel] [PATCH 23/38] qemu.img.c: Use error_report() instead of own error() implementation

2010-12-17 Thread Kevin Wolf
From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- qemu-img.c | 127 +-- 1 files changed, 62 insertions(+), 65 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 0ff179f..0b871d8 100644 --- a/qemu-img.c ++

Re: [Qemu-devel] Re: [PATCH v2] ide: Register vm change state handler once only

2010-12-17 Thread Kevin Wolf
Am 17.12.2010 19:35, schrieb Andreas Färber: > Am 17.12.2010 um 14:12 schrieb Kevin Wolf: > >> Am 16.12.2010 16:54, schrieb Stefan Hajnoczi: >>> We register the vm change state handler in a PCI BAR map() function. >>> This function can be called multiple times throughout the lifetime >>> of a >>

Re: [Qemu-devel] [PATCH 5/6] [RFC] Emulation of Leon3.

2010-12-17 Thread Blue Swirl
On Wed, Dec 15, 2010 at 5:47 PM, Fabien Chouteau wrote: > On 12/13/2010 07:18 PM, Blue Swirl wrote: >> >> On Mon, Dec 13, 2010 at 3:51 PM, Fabien Chouteau >>  wrote: >>> >>> On 12/11/2010 10:56 AM, Blue Swirl wrote: On Tue, Dec 7, 2010 at 11:40 AM, Fabien Chouteau  wrote: >

Re: [Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-17 Thread Stefan Weil
Am 17.12.2010 14:44, schrieb Paolo Bonzini: On 12/17/2010 02:34 PM, Andreas Färber wrote: Fix this by removing any \r at end of line. Why isn't cygwin (or whatever you're using) removing it? I believe Cygwin had an option to choose the line ending style once during setup. By default it uses

[Qemu-devel] [PATCH 3/3] qed: Add support for zero clusters

2010-12-17 Thread Stefan Hajnoczi
From: Anthony Liguori Zero clusters are similar to unallocated clusters except instead of reading their value from a backing file when one is available, the cluster is always read as zero. This implements read support only. At this stage, QED will never write a zero cluster. Signed-off-by: Ant

[Qemu-devel] Re: [PATCH] ide: Fix build for cmd646.c

2010-12-17 Thread Andreas Färber
Am 17.12.2010 um 19:44 schrieb Kevin Wolf: Signed-off-by: Kevin Wolf --- hw/ide/cmd646.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index 89ba836..5d5464a 100644 --- a/hw/ide/cmd646.c +++ b/hw/ide/cmd646.c @@ -255,9 +255,9 @@ sta

Re: [Qemu-devel] Re: [PATCH v2] ide: Register vm change state handler once only

2010-12-17 Thread Andreas Färber
Am 17.12.2010 um 19:46 schrieb Kevin Wolf: Am 17.12.2010 19:35, schrieb Andreas Färber: Am 17.12.2010 um 14:12 schrieb Kevin Wolf: Am 16.12.2010 16:54, schrieb Stefan Hajnoczi: We register the vm change state handler in a PCI BAR map() function. This function can be called multiple times t

[Qemu-devel] [PATCH 12/38] pci: add ich9 pci id

2010-12-17 Thread Kevin Wolf
From: Alexander Graf We need a PCI ID for our new AHCI adapter. I just picked an ICH-9 because that's the one in the Q35 chipset. This patch adds a PCI ID define for an ICH-9 AHCI adapter. Signed-off-by: Alexander Graf Signed-off-by: Kevin Wolf --- hw/pci.h |1 + 1 files changed, 1 inser

[Qemu-devel] [PATCH 29/38] raw-posix: add discard support

2010-12-17 Thread Kevin Wolf
From: Christoph Hellwig Add support to discard blocks in a raw image residing on an XFS filesystem by calling the XFS_IOC_UNRESVSP64 ioctl to punch holes. Support for other hole punching mechanisms can be added when they become available. Signed-off-by: Christoph Hellwig Signed-off-by: Kevin W

[Qemu-devel] Re: [PULL 00/38] Block patches

2010-12-17 Thread Anthony Liguori
On 12/17/2010 11:44 AM, Kevin Wolf wrote: The following changes since commit 9d861fa595c93f22d1d55b723a691531c36c9672: Merge remote branch 'arm/for-anthony' into staging (2010-12-17 08:25:17 -0600) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony

[Qemu-devel] [PATCH 15/38] config: add ahci for pci capable machines

2010-12-17 Thread Kevin Wolf
From: Alexander Graf This patch enables AHCI for all machines supporting PCI. Signed-off-by: Alexander Graf Signed-off-by: Kevin Wolf --- default-configs/pci.mak |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/default-configs/pci.mak b/default-configs/pci.mak index d7

[Qemu-devel] [PATCH 26/38] block: add discard support

2010-12-17 Thread Kevin Wolf
From: Christoph Hellwig Add a new bdrv_discard method to free blocks in a mapping image, and a new drive property to set the granularity for these discard. If no discard granularity support is set discard support is disabled. Signed-off-by: Christoph Hellwig Signed-off-by: Kevin Wolf --- blo

Re: [Qemu-devel] Re: [PATCH v2] ide: Register vm change state handler once only

2010-12-17 Thread Andreas Färber
Am 17.12.2010 um 14:12 schrieb Kevin Wolf: Am 16.12.2010 16:54, schrieb Stefan Hajnoczi: We register the vm change state handler in a PCI BAR map() function. This function can be called multiple times throughout the lifetime of a PCI IDE device. This results in duplicate vm change state han

[Qemu-devel] [PATCH 38/38] docs: Fix missing carets in QED specification

2010-12-17 Thread Kevin Wolf
From: Stefan Hajnoczi For some reason the carets ('^') in the QED specification disappeared. This patch puts them back. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- docs/specs/qed_spec.txt |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/specs/q

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-17 Thread Andreas Färber
Am 17.12.2010 um 17:48 schrieb Peter Maydell: On 17 December 2010 16:19, Andreas Färber wrote: Can this patch be applied? (There are more ARM/softfloat patches in my queue which will break it again otherwise...) If we're engaging into refactoring the softfloat library, I still have a larg

[Qemu-devel] [PATCH 27/38] scsi-disk: support WRITE SAME (16) with unmap bit

2010-12-17 Thread Kevin Wolf
From: Christoph Hellwig Support discards via the WRITE SAME command with the unmap bit set, and tell the initiator about the support for it via the block limit and the new thin provisioning EVPD pages. Also fix the comment which incorrectly describedthe block limits EVPD page. Signed-off-by: Ch

[Qemu-devel] [PATCH 32/38] qed: Add QEMU Enhanced Disk image format

2010-12-17 Thread Kevin Wolf
From: Stefan Hajnoczi This patch introduces the qed on-disk layout and implements image creation. Later patches add read/write and other functionality. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- Makefile.objs |1 + block/qed.c | 554 ++

[Qemu-devel] [PATCH 37/38] Add proper -errno error return values to qcow2_open()

2010-12-17 Thread Kevin Wolf
From: Jes Sorensen In addition this adds missing braces to the function to be consistent with the coding style. Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- block/qcow2.c | 60 +++- 1 files changed, 42 insertions(+), 18 deleti

[Qemu-devel] [PATCH 35/38] qed: Consistency check support

2010-12-17 Thread Kevin Wolf
From: Stefan Hajnoczi This patch adds support for the qemu-img check command. It also introduces a dirty bit in the qed header to mark modified images as needing a check. This bit is cleared when the image file is closed cleanly. If an image file is opened and it has the dirty bit set, a consi

[Qemu-devel] [PATCH 31/38] docs: Add QED image format specification

2010-12-17 Thread Kevin Wolf
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- docs/specs/qed_spec.txt | 130 +++ 1 files changed, 130 insertions(+), 0 deletions(-) create mode 100644 docs/specs/qed_spec.txt diff --git a/docs/specs/qed_spec.tx

[Qemu-devel] [PATCH 25/38] ide: Register vm change state handler once only

2010-12-17 Thread Kevin Wolf
From: Stefan Hajnoczi We register the vm change state handler in a PCI BAR map() function. This function can be called multiple times throughout the lifetime of a PCI IDE device. This results in duplicate vm change state handlers being register, none of which are ever unregistered. Instead, reg

[Qemu-devel] [PATCH 36/38] block/qcow2.c: rename qcow_ functions to qcow2_

2010-12-17 Thread Kevin Wolf
From: Jes Sorensen It doesn't really make sense for functions in qcow2.c to be named qcow_ so convert the names to match correctly. Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c |6 +- block/qcow2-snapshot.c |6 +- block/qcow2.c | 190 +

[Qemu-devel] [PATCH 28/38] qemu-io: Add discard command

2010-12-17 Thread Kevin Wolf
From: Stefan Hajnoczi discard [-Cq] off len -- discards a number of bytes at a specified offset discards a range of bytes from the given offset Example: 'discard 512 1k' - discards 1 kilobyte from 512 bytes into the file Discards a segment of the currently open file. -C, -- report statist

[Qemu-devel] [PATCH 16/38] ahci: set SATA Mode Select

2010-12-17 Thread Kevin Wolf
From: Sebastian Herbszt Set SATA Mode Select to AHCI in the Address Map Register. Signed-off-by: Sebastian Herbszt Signed-off-by: Kevin Wolf --- hw/ide/ahci.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index f937a92..8ae236a 100644

[Qemu-devel] [PATCH 11/38] pci: add storage class for sata

2010-12-17 Thread Kevin Wolf
From: Alexander Graf This patch adds the storage sata class id. Signed-off-by: Alexander Graf Signed-off-by: Kevin Wolf --- hw/pci_ids.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pci_ids.h b/hw/pci_ids.h index 82cba7e..ea3418c 100644 --- a/hw/pci_ids.h +++ b/

[Qemu-devel] [PATCH 06/38] ide: split ide command interpretation off

2010-12-17 Thread Kevin Wolf
From: Alexander Graf The ATA command interpretation code can be used for PATA and SATA interfaces alike. So let's split it out into a separate function. Signed-off-by: Alexander Graf Signed-off-by: Kevin Wolf --- hw/ide/core.c | 20 ++-- hw/ide/internal.h |2 ++ 2 fi

[Qemu-devel] [PATCH 30/38] qemu-io: Fix typo in help texts

2010-12-17 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- qemu-io.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index 2318a28..65dee13 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -326,7 +326,7 @@ read_help(void) " -l, -- length for pattern verification (only wit

[Qemu-devel] [PATCH 08/38] ide: Split out BMDMA code from ATA core

2010-12-17 Thread Kevin Wolf
From: Alexander Graf The ATA core is currently heavily intertwined with BMDMA code. Let's loosen that a bit, so we can happily replace the DMA backend with different implementations. Signed-off-by: Alexander Graf Signed-off-by: Kevin Wolf --- hw/ide/cmd646.c |6 +- hw/ide/core.c |

[Qemu-devel] [PATCH 20/38] Introduce do_snapshot_blkdev() and monitor command to handle it.

2010-12-17 Thread Kevin Wolf
From: Jes Sorensen The monitor command is: snapshot_blkdev [snapshot-file] [format] Default format is qcow2. For now snapshots without a snapshot-file, eg internal snapshots, are not supported. Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- blockdev.c | 62

[Qemu-devel] [PATCH 21/38] Prevent creating an image with the same filename as backing file

2010-12-17 Thread Kevin Wolf
From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- block.c | 15 +++ 1 files changed, 11 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index a48b30c..0c14eee 100644 --- a/block.c +++ b/block.c @@ -2764,7 +2764,7 @@ int bdrv_img_create(con

[Qemu-devel] [PATCH 19/38] qemu-img.c: Re-factor img_create()

2010-12-17 Thread Kevin Wolf
From: Jes Sorensen This patch re-factors img_create() moving the code doing the actual work into block.c where it can be shared with QEMU. This is needed to be able to create images from QEMU to be used for live snapshots. Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- block.c|

[Qemu-devel] [PATCH 07/38] ide: fix whitespace gap in ide_exec_cmd

2010-12-17 Thread Kevin Wolf
From: Alexander Graf Now that we have the function split out, we have to reindent it. In order to increase the readability of the actual functional change, this is split out. Signed-off-by: Alexander Graf Signed-off-by: Kevin Wolf --- hw/ide/core.c | 734 -

[Qemu-devel] [PATCH 14/38] config: move ide core and pci to pci.mak

2010-12-17 Thread Kevin Wolf
From: Alexander Graf Every device that can do PCI should also be able to do IDE. So let's move the IDE definitions over to pci.mak. Signed-off-by: Alexander Graf Signed-off-by: Kevin Wolf --- default-configs/arm-softmmu.mak |1 - default-configs/i386-softmmu.mak |3 --- defau

[Qemu-devel] [PATCH 13/38] ahci: add ahci emulation

2010-12-17 Thread Kevin Wolf
From: Alexander Graf This patch adds an emulation layer for an ICH-9 AHCI controller. For now this controller does not do IDE legacy emulation. It is a pure AHCI controller. Signed-off-by: Alexander Graf Signed-off-by: Kevin Wolf --- Makefile.objs |1 + hw/ide/ahci.c | 1524 ++

[Qemu-devel] [PATCH 01/38] blockdev: check dinfo ptr before using

2010-12-17 Thread Kevin Wolf
From: Ryan Harper If a user decides to punish a guest by revoking its block device via drive_del, and subsequently also attempts to remove the pci device backing it, and the device is using blockdev_auto_del() then we get a segfault when we attempt to access dinfo->auto_del.[1] The fix is to che

[Qemu-devel] [PATCH 22/38] bdrv_img_create() use proper errno return values

2010-12-17 Thread Kevin Wolf
From: Jes Sorensen Kevin suggested to have bdrv_img_create() return proper -errno values on error. Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- block.c | 23 ++- 1 files changed, 10 insertions(+), 13 deletions(-) diff --git a/block.c b/block.c index 0c14eee

[Qemu-devel] [PATCH 10/38] ide: add ncq identify data for ahci sata drives

2010-12-17 Thread Kevin Wolf
From: Roland Elek I modified ide_identify() to include the zero-based queue length value in word 75, and set bit 8 in word 76 to signal NCQ support in the identify data for AHCI SATA drives. Signed-off-by: Roland Elek Signed-off-by: Kevin Wolf --- hw/ide/core.c |7 +++ hw/ide/inte

[Qemu-devel] [PATCH 03/38] block: Fix the use of protocols in backing files

2010-12-17 Thread Kevin Wolf
From: Stefan Hajnoczi Backing filenames may contain a protocol. The code currently doesn't consider this case and produces filenames that embed ":". Don't combine filenames if the backing filename contains a protocol. Based on an earlier patch by Anthony Liguori . Signed-off-by: Stefan Hajnocz

[Qemu-devel] [PATCH 09/38] ide: move transfer_start after variable modification

2010-12-17 Thread Kevin Wolf
From: Alexander Graf We hook into transfer_start and immediately call the end function for ahci. This means that everything needs to be in place for the end function when we start the transfer, so let's move the function down to where all state is in place. Signed-off-by: Alexander Graf Signed-

[Qemu-devel] [PATCH 02/38] block: Introduce path_has_protocol() function

2010-12-17 Thread Kevin Wolf
From: Stefan Hajnoczi The bdrv_find_protocol() function returns NULL if an unknown protocol name is given. It returns the "file" protocol when the filename contains no protocol at all. This makes it difficult to distinguish between paths which contain a protocol and those which do not. Factor

[Qemu-devel] [PATCH 33/38] qed: Table, L2 cache, and cluster functions

2010-12-17 Thread Kevin Wolf
From: Stefan Hajnoczi This patch adds code to look up data cluster offsets in the image via the L1/L2 tables. The L2 tables are writethrough cached in memory for performance (each read/write requires a lookup so it is essential to cache the tables). With cluster lookup code in place it is possi

[Qemu-devel] [PATCH 04/38] Introduce strtosz_suffix()

2010-12-17 Thread Kevin Wolf
From: Jes Sorensen This introduces strtosz_suffix() which allows the caller to specify a default suffix in case the non default of MB is wanted. strtosz() is kept as a wrapper for strtosz_suffix() which keeps it's current default of MB. Signed-off-by: Jes Sorensen Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PULL 00/38] Block patches

2010-12-17 Thread Kevin Wolf
The following changes since commit 9d861fa595c93f22d1d55b723a691531c36c9672: Merge remote branch 'arm/for-anthony' into staging (2010-12-17 08:25:17 -0600) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Alexander Graf (10): ide: split ide command i

[Qemu-devel] [PATCH] softfloat: Fix function signature mismatches by using POSIX integer types

2010-12-17 Thread Andreas Färber
Don't reinvent C99 types like uint8_t by typedef'ing uint8 etc. On BeOS and Haiku, system headers {be,os}/support/SupportDefs.h do define [u]int{8,16,32,64}, but they define [u]int32 as long, so assumptions that int32 and int can be used interchangeably must be avoided. Inspired by mmlr's original

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-17 Thread Peter Maydell
On 17 December 2010 16:19, Andreas Färber wrote: >> Can this patch be applied? (There are more ARM/softfloat patches >> in my queue which will break it again otherwise...) > > If we're engaging into refactoring the softfloat library, I still have a > large'ish patch lying around to fix signature m

[Qemu-devel] Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

2010-12-17 Thread Yoshiaki Tamura
2010/12/17 Yoshiaki Tamura : > 2010/12/16 Michael S. Tsirkin : >> On Thu, Dec 16, 2010 at 11:28:46PM +0900, Yoshiaki Tamura wrote: >>> 2010/12/16 Michael S. Tsirkin : >>> > On Thu, Dec 16, 2010 at 04:36:16PM +0900, Yoshiaki Tamura wrote: >>> >> 2010/12/3 Yoshiaki Tamura : >>> >> > 2010/12/2 Michael

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-17 Thread Andreas Färber
Hello Peter, Am 17.12.2010 um 16:56 schrieb Peter Maydell: The softfloat functions float*_is_nan() were badly misnamed, because they return true only for quiet NaNs, not for all NaNs. Rename them to float*_is_quiet_nan() to more accurately reflect what they do. This change was produced by: per

[Qemu-devel] Re: [PATCH 11/21] ioport: insert event_tap_ioport() to ioport_write().

2010-12-17 Thread Yoshiaki Tamura
2010/12/17 Stefan Hajnoczi : > On Thu, Dec 16, 2010 at 9:50 AM, Yoshiaki Tamura > wrote: >> 2010/12/16 Michael S. Tsirkin : >>> On Thu, Dec 16, 2010 at 04:37:41PM +0900, Yoshiaki Tamura wrote: 2010/11/28 Yoshiaki Tamura : > 2010/11/28 Michael S. Tsirkin : >> On Thu, Nov 25, 2010 at

[Qemu-devel] [PATCH 1/3] docs: Fix missing carets in QED specification

2010-12-17 Thread Stefan Hajnoczi
For some reason the carets ('^') in the QED specification disappeared. This patch puts them back. Signed-off-by: Stefan Hajnoczi --- docs/specs/qed_spec.txt |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/specs/qed_spec.txt b/docs/specs/qed_spec.txt index 446b5a2

[Qemu-devel] [PATCH 0/3] qed: Add support for zero clusters

2010-12-17 Thread Stefan Hajnoczi
This patch series adds zero data clusters to QED. Clusters can be marked as zero clusters to store zeroed regions in a space-efficient way. The patch never actually creates new zero clusters but includes the I/O path support code to handle them if they are used by an image file. Image streaming

[Qemu-devel] [PATCH 2/3] docs: Describe zero data clusters in QED specification

2010-12-17 Thread Stefan Hajnoczi
Zero data clusters are a space-efficient way of storing zeroed regions of the image. Signed-off-by: Stefan Hajnoczi --- docs/specs/qed_spec.txt |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/docs/specs/qed_spec.txt b/docs/specs/qed_spec.txt index 1d5fa87..7982e05

[Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-17 Thread Peter Maydell
The softfloat functions float*_is_nan() were badly misnamed, because they return true only for quiet NaNs, not for all NaNs. Rename them to float*_is_quiet_nan() to more accurately reflect what they do. This change was produced by: perl -p -i -e 's/_is_nan/_is_quiet_nan/g' $(git grep -l is_nan) (

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-17 Thread Avi Kivity
On 12/17/2010 01:22 PM, Luiz Capitulino wrote: > > I think Avi's suggest is better, and I will use > "inject-nmi" (without cpu-index argument) to send NMI to all cpus, > like physical GUI. If some one want to send NMI to a set of cpus, > he can use "inject-nmi" multiple times. His suggestion

[Qemu-devel] Re: [PATCH v2 0/2] qcow2 cleanups

2010-12-17 Thread Kevin Wolf
Am 17.12.2010 16:02, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > Hi, > > These two patches tries to clean up the qcow2 code a little. First > makes the function names consistent, ie. we shouldn't have qcow_ > functions in the qcow2 code. Second tries to add proper errno return > va

[Qemu-devel] [PATCH 2/2] Add proper -errno error return values to qcow2_open()

2010-12-17 Thread Jes . Sorensen
From: Jes Sorensen In addition this adds missing braces to the function to be consistent with the coding style. Signed-off-by: Jes Sorensen --- block/qcow2.c | 60 +++- 1 files changed, 42 insertions(+), 18 deletions(-) diff --git a/block/

Re: [Qemu-devel] [PATCH] spice: add chardev (v3)

2010-12-17 Thread Anthony Liguori
On 12/17/2010 07:39 AM, Alon Levy wrote: Adding a chardev backend for spice, for usage by spice vdagent in conjunction with a properly named virtio-serial device. Example usage: qemu -device virtio-serial -chardev spicevmc,name=vdagent,id=vdagent -devic This is equivalent to the old: qemu -

[Qemu-devel] [RFC][PATCH 0/3] Let RTC follow backward jumps of host clock immediately

2010-12-17 Thread Jan Kiszka
By default, we base the mc146818 RTC on the host clock (CLOCK_REALTIME). This works fine if only the frequency of the host clock is tuned (e.g. by NTP) or if it is set to a future time. However, if the host is tuned backward, e.g. because NTP obtained the correct time after the guest was already st

[Qemu-devel] [RFC][PATCH 2/3] qemu-timer: Introduce warp callback

2010-12-17 Thread Jan Kiszka
QEMU_CLOCK_HOST is based on the system time which may jump backward in case the admin or NTP adjusts it. RTC emulations and other device models can suffer in this case as timers will stall for the period the clock was tuned back. This adds a detection mechanism that checks on every host clock read

[Qemu-devel] [PATCH 1/2] block/qcow2.c: rename qcow_ functions to qcow2_

2010-12-17 Thread Jes . Sorensen
From: Jes Sorensen It doesn't really make sense for functions in qcow2.c to be named qcow_ so convert the names to match correctly. Signed-off-by: Jes Sorensen --- block/qcow2-cluster.c |6 +- block/qcow2-snapshot.c |6 +- block/qcow2.c | 190 +---

[Qemu-devel] [PATCH v2 0/2] qcow2 cleanups

2010-12-17 Thread Jes . Sorensen
From: Jes Sorensen Hi, These two patches tries to clean up the qcow2 code a little. First makes the function names consistent, ie. we shouldn't have qcow_ functions in the qcow2 code. Second tries to add proper errno return values to qcow2_open(). New in v2: Fix the bdrv_pread() handling as poi

Re: [Qemu-devel] [PATCH v2 2/6] qdev: reset qdev along with qdev tree

2010-12-17 Thread Anthony Liguori
On 12/17/2010 08:45 AM, Peter Maydell wrote: On 17 December 2010 00:24, Anthony Liguori wrote: On 12/16/2010 05:48 PM, Michael S. Tsirkin wrote: Ugh, I keep forgetting about the non-qdev systems. Maybe it's a good way to finally make everyone to convert? If a system maintainer can't

[Qemu-devel] [RFC][PATCH 1/3] qemu-timer: Consolidate qemu_get_clock and qemu_get_clock_ns

2010-12-17 Thread Jan Kiszka
Both functions have a lot in common, push those bits into a shared helper. Signed-off-by: Jan Kiszka --- qemu-timer.c | 27 +-- 1 files changed, 13 insertions(+), 14 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 95814af..abad93b 100644 --- a/qemu-timer.c

[Qemu-devel] [RFC][PATCH 3/3] mc146818rtc: Handle host clock warps

2010-12-17 Thread Jan Kiszka
Make use of the new warp notifier to update the RTC whenever rtc_clock is the host clock and that happens to jump backward. This avoids that the RTC stalls for the period the host clock was set back. Signed-off-by: Jan Kiszka --- hw/mc146818rtc.c | 17 + 1 files changed, 17 ins

Re: [Qemu-devel] [PATCH 00/14] [PULL] ARM fixes, v2

2010-12-17 Thread Anthony Liguori
On 12/16/2010 12:07 PM, Peter Maydell wrote: On 7 December 2010 15:50, Peter Maydell wrote: The following changes since commit 2c90fe2b71df2534884bce96d90cbfcc93aeedb8: Kirill Batuzov (1): Speedup 'tb_find_slow' by using the same heuristic as during memory page lookup are availab

Re: [Qemu-devel] [PULL 00/14] Block patches

2010-12-17 Thread Anthony Liguori
On 12/09/2010 05:09 AM, Kevin Wolf wrote: The following changes since commit 138b38b61bf92d4e9588acf934e532499c94e185: ppc: kvm: fix signedness warning (2010-12-08 21:30:19 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Christian Brunner (1):

Re: [Qemu-devel] [PULL] pci, virtio, net, migration

2010-12-17 Thread Anthony Liguori
On 12/12/2010 05:25 AM, Michael S. Tsirkin wrote: The following changes since commit 962630f207a33b7de4316022884b5241e05491cd: Pass boot device list to firmware. (2010-12-11 21:32:48 +) Pulled. Thanks. Regards, Anthony Liguori are available in the git repository at: git://git

  1   2   >