On 12/08/2010 07:08 PM, Marcelo Tosatti wrote:
Use _RMV method to indicate whether device can be removed.
Data is retrieved from QEMU via I/O port 0xae0c.
Where did this port come from? What's the protocol?
Maybe we should do this via fw_cfg.
--
I have a truly marvellous patch that fixes t
Prezado cliente, (a) Bradesco
Informamos que devidos as suas ultimas movimentações financeiras em sua conta corrente/poupança será necessário a confirmação de dados. Tendo como objetivo garantir a veraci
On 11/24/2010 05:50 PM, Christoph Hellwig wrote:
Btw, it might make sense to split this series into two.
Patches 1 to 11 are genuine improvements to the SCSI code, which I'd
like to see merged ASAP. The rest is the actual megasas driver, which
I still want to see, but haven't even gotten to rev
On 12/10/2010 09:53 AM, Paolo Bonzini wrote:
On 12/09/2010 06:29 PM, Stefano Bonifazi wrote:
how can one think that addresses around zero are free for a mapping??
Addresses around zero are always free, because if they weren't you
couldn't detect NULL pointer dereferences reliably.
mmap-ing
Hi all!
From the technical documentation
(http://www.usenix.org/publications/library/proceedings/usenix05/tech/freenix/bellard.html)
I read:
The first step is to split each target CPU instruction into fewer
simpler instructions called /micro operations/. Each micro operation
is implemented
On (Fri) Dec 10 2010 [15:17:58], Paul Brook wrote:
> > On (Fri) Dec 10 2010 [13:59:50], Paul Brook wrote:
> > > > Check if the guest really sent any items in the out_vq before using
> > > > them. Similarly, check if there is a buffer to send data in before
> > > > writing.
> > >
> > > Can this ac
Separate out a non-changing condition over the period of a loop into an
if statement before the loop. This will be used later to re-work the
loop.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-serial-bu
The initialisation for generic ports and console ports is similar.
Factor out the parts that are the same in a different function that can
be called from each of the initfns.
Signed-off-by: Amit Shah
---
hw/virtio-console.c | 31 ++-
1 files changed, 14 insertions(+
On (Fri) Dec 10 2010 [14:02:37], Paul Brook wrote:
> > -if (!discard) {
> > +if (discard) {
> > +goto next;
> > +}
>
> > +next:
> > virtqueue_push(vq, &elem, 0);
>
> Please don't do this.
Could you elaborate?
I can move the 'discard' check into t
Not a qemu bug. madvise and (associated constants via sys/mman.h) are
supplied by glibc. You need to update your C library.
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bug
On 12/10/2010 12:43 AM, Jes Sorensen wrote:
On 12/09/10 22:12, Michael Roth wrote:
On 12/07/2010 08:26 AM, Jes Sorensen wrote:
I believe this suffers from the same architectural problem I mentioned
in my comment to 07/21 - you don't restrict the file size, so it could
blow up the QEMU process o
Hi All,
Here is what I have in mind as usb redirection protocol:
USB redirerection protocol (draft)
--
The protocol described in this document is meant for tunneling usb transfers
to a single usb device. Note: not an entire hub, only a single device.
The most si
> -if (!discard) {
> +if (discard) {
> +goto next;
> +}
> +next:
> virtqueue_push(vq, &elem, 0);
Please don't do this.
Paul
On Thu, Dec 02, 2010 at 01:12:13PM +0100, Kevin Wolf wrote:
> > DEFINE_PROP_UINT16("physical_block_size", _state, \
> > _conf.physical_block_size, 512), \
> > DEFINE_PROP_UINT16("min_io_size", _state, _conf.min_io_size, 0), \
> >
Alexander Graf writes:
> On 21.11.2010, at 13:37, Blue Swirl wrote:
>
>> On Fri, Nov 19, 2010 at 2:56 AM, Alexander Graf wrote:
>>> So far we have C preprocessor defines for target and host config
>>> options, but we're lacking any information on which devices are
>>> available.
>>>
>>> We do n
On Thu, Dec 9, 2010 at 9:03 PM, Anthony Liguori
wrote:
> On 12/09/2010 02:45 PM, Michael Roth wrote:
>>
>> On 12/08/2010 04:10 AM, Stefan Hajnoczi wrote:
>>>
>>> On Fri, Dec 3, 2010 at 6:03 PM, Michael Roth
>>> wrote:
These patches apply to master, and can also be obtained from:
gi
On 12/09/10 22:04, Michael Roth wrote:
> On 12/09/2010 08:40 AM, Adam Litke wrote:
>> Actually, a host-controlled interface would be both simpler to implement
>> (on both ends) and would concentrate control in the host (which is what
>> we probably want anyway).
>
> I also like the host-controlled
[Expired for qemu-kvm (Ubuntu) because there has been no activity for 60
days.]
** Changed in: qemu-kvm (Ubuntu)
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/543
On Wed, Dec 08, 2010 at 10:39:43AM +0100, Fabien Chouteau wrote:
> On 12/08/2010 09:30 AM, Edgar E. Iglesias wrote:
> > On Tue, Dec 07, 2010 at 10:55:33AM +0100, Fabien Chouteau wrote:
> >> On 12/06/2010 06:12 PM, Blue Swirl wrote:
> >>> On Mon, Dec 6, 2010 at 9:26 AM, Fabien Chouteau
> >>> wrot
Jason Wang wrote:
> Juan Quintela writes:
> > Jason Wang wrote:
> > > The saving and restoring of error_code seems lost and convert the
> > > error_code to uint32_t.
> > >
> > > Signed-off-by: Jason Wang
> > > ---
> > > target-i386/cpu.h |4 ++--
> > > target-i386/machine.c |
On 12/09/2010 03:25 PM, Jan Kiszka wrote:
> Am 09.12.2010 07:58, Lai Jiangshan wrote:
>>
>> Make use of the new KVM_NMI IOCTL to send NMIs into the KVM guest if the
>> user space APIC emulation or some other source raised them.
>
> In that light, the subject is not absolutely correct.
>
[...]
>
On Thu, 9 Dec 2010, Michael Walle wrote:
> Read should return bytes instead of samples.
Thanks, applied.
[..snip..]
--
mailto:av1...@comtv.ru
On Thu, 9 Dec 2010, Michael Walle wrote:
> The audio timer also has to be reset when a capture device is enabled. This
> will ensure the timer to be started even if just capture devices are
> active.
It was done in 39deb1e496de81957167daebf5cf5d1fbd5e47c2
--
mailto:av1...@comtv.ru
Remove unnecessary braces around a case statement.
Signed-off-by: Amit Shah
---
hw/virtio-console.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index d7fe68b..d0b9354 100644
--- a/hw/virtio-console.c
+++ b/hw/virtio-console
Hi,
This patch series converts virtio-serial-bus to use the guest buffers
instead of copying over guest data to the host, as suggested by Paul.
In addition, there are some trivial fixes for the virtio-console and
virtio-serial code.
v2:
- drop the erroring out patch till we decide what's to be
On Fri, 10 Dec 2010 16:20:34 +0100
Markus Armbruster wrote:
> [Note cc: Dan, Avi]
>
> Luiz Capitulino writes:
>
> > On Tue, 23 Nov 2010 10:43:48 -0200
> > Luiz Capitulino wrote:
> >
> >> On Tue, 23 Nov 2010 13:41:26 +0800
> >> Wen Congyang wrote:
> >>
> >> > The args_type of migrate_set_spe
[Note cc: Dan, Avi]
Luiz Capitulino writes:
> On Tue, 23 Nov 2010 10:43:48 -0200
> Luiz Capitulino wrote:
>
>> On Tue, 23 Nov 2010 13:41:26 +0800
>> Wen Congyang wrote:
>>
>> > The args_type of migrate_set_speed in qmp-commands.hx is wrong.
>> > When we set migrate speed by json, qemu will be
> On (Fri) Dec 10 2010 [13:59:50], Paul Brook wrote:
> > > Check if the guest really sent any items in the out_vq before using
> > > them. Similarly, check if there is a buffer to send data in before
> > > writing.
> >
> > Can this actually happen? If so why/how?
> > Why does it need a special ca
On (Fri) Dec 10 2010 [15:17:18], Paul Brook wrote:
> > On (Fri) Dec 10 2010 [14:02:37], Paul Brook wrote:
> > > > -if (!discard) {
> > > > +if (discard) {
> > > > +goto next;
> > > > +}
> > > >
> > > > +next:
> > > > virtqueue_push(vq, &elem, 0);
>
When the guest writes something to a host, we copied over the entire
buffer first into the host and then processed it. Do away with that, it
could result in a malicious guest causing a DoS on the host.
Reported-by: Paul Brook
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c | 16 -
> On (Fri) Dec 10 2010 [14:02:37], Paul Brook wrote:
> > > -if (!discard) {
> > > +if (discard) {
> > > +goto next;
> > > +}
> > >
> > > +next:
> > > virtqueue_push(vq, &elem, 0);
> >
> > Please don't do this.
>
> Could you elaborate?
>
> I can m
Add support for the data set management command, and the TRIM sub function
in it.
Signed-off-by: Christoph Hellwig
Index: qemu/hw/ide/core.c
===
--- qemu.orig/hw/ide/core.c 2010-12-10 11:35:30.471253949 +0100
+++ qemu/hw/ide/cor
The DMA I/O path is duplicated between read and write commands, and
support for the TRIM command would add another copy. Factor the
code into common helpers using the s->is_read flag added for the
macio ATA controller, and the newly added dma_bdrv_io function.
Signed-off-by: Christoph Hellwig
I
Currenly the code only resets the io_buffer_index field for reads,
but the code seems to expect this for all types of I/O. I guess
we simply don't hit large enough transfers that would require this
often enough.
Signed-off-by: Christoph Hellwig
Index: qemu/hw/ide/core.c
Am 08.12.2010 17:05, schrieb Ryan Harper:
> If a user decides to punish a guest by revoking its block device via
> drive_del, and subsequently also attempts to remove the pci device
> backing it, and the device is using blockdev_auto_del() then we get a
> segfault when we attempt to access dinfo->a
Add a new bdrv_discard method to free blocks in a mapping image, and a new
drive property to set the granularity for these discard. If no discard
granularity support is set discard support is disabled.
Signed-off-by: Christoph Hellwig
Index: qemu/block.c
Add support to discard blocks in a raw image residing on an XFS filesystem
by calling the XFS_IOC_UNRESVSP64 ioctl to punch holes. Support for other
hole punching mechanisms can be added when they become available.
Signed-off-by: Christoph Hellwig
Index: qemu/block/raw-posix.c
=
Support discards via the WRITE SAME command with the unmap bit set, and
tell the initiator about the support for it via the block limit and the
new thin provisioning EVPD pages. Also fix the comment which incorrectly
describedthe block limits EVPD page.
Signed-off-by: Christoph Hellwig
Index: q
Make dma_bdrv_io available for drivers, and pass an explicit I/O function
instead of hardcoding bdrv_aio_readv/bdrv_aio_writev. This is required
to implement non-READ/WRITE dma commands in the ide driver, e.g. the
upcoming TRIM support.
Signed-off-by: Christoph Hellwig
Index: qemu/dma-helpers.c
On (Fri) Dec 10 2010 [13:59:50], Paul Brook wrote:
> > Check if the guest really sent any items in the out_vq before using
> > them. Similarly, check if there is a buffer to send data in before
> > writing.
>
> Can this actually happen? If so why/how?
> Why does it need a special case in this dev
This patchset adds support for the ATA TRIM and SCSI WRITE SAME with
unmap commands, which allow reclaiming free space from a backing image.
The user facing implementation is pretty complete, but not really
efficient because the underlying bdrv_discard implementation doesn't
use the aio implementa
We register the vm change state handler in a PCI BAR map() function.
This function can be called multiple times throughout the lifetime of a
PCI IDE device. This results in duplicate vm change state handlers
being register, none of which are ever unregistered.
Instead, register the vm change stat
Hi,
Wrong. PCI certainly isn't the only bus which supports hotplug. It
*does* make sense to handle generic hotplug stuff at qdev level.
Could the proper place be qbus instead of qdev?
No. But PCI is the only bus where some devices are hot-pluggable and
some are not. On all other busse
> Check if the guest really sent any items in the out_vq before using
> them. Similarly, check if there is a buffer to send data in before
> writing.
Can this actually happen? If so why/how?
Why does it need a special case in this device?
If this is guest triggerable then calling abort() is wron
On Thu, Dec 02, 2010 at 03:07:49PM +0100, Kevin Wolf wrote:
> This looks wrong. Wouldn't werror=stop cause the request to be retried
> as a write when the VM is resumed?
Indeed.
> But having a copy&paste error gives just about right reason to mention
> that after read and write this is the third
Check if the guest really sent any items in the out_vq before using
them. Similarly, check if there is a buffer to send data in before
writing.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c | 19 +++
1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/hw/virt
Separate out a non-changing condition over the period of a loop into an
if statement before the loop. This will be used later to re-work the
loop.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-serial-bu
When the guest writes something to a host, we copied over the entire
buffer first into the host and then processed it. Do away with that, it
could result in a malicious guest causing a DoS on the host.
Reported-by: Paul Brook
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c | 20 +
Remove unnecessary braces around a case statement.
Signed-off-by: Amit Shah
---
hw/virtio-console.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index d7fe68b..d0b9354 100644
--- a/hw/virtio-console.c
+++ b/hw/virtio-console
Hi,
This patch series converts virtio-serial-bus to use the guest buffers
instead of copying over guest data to the host, as suggested by Paul.
In addition, there are some trivial fixes for the virtio-console and
virtio-serial code.
Amit Shah (5):
virtio-console: Factor out common init betwee
The initialisation for generic ports and console ports is similar.
Factor out the parts that are the same in a different function that can
be called from each of the initfns.
Signed-off-by: Amit Shah
---
hw/virtio-console.c | 31 ++-
1 files changed, 14 insertions(+
Jes Sorensen writes:
> On 11/22/10 16:20, Anthony Liguori wrote:
>> On 11/22/2010 09:10 AM, Jes Sorensen wrote:
>>> On 11/22/10 16:08, Anthony Liguori wrote:
On 11/22/2010 08:58 AM, Jes Sorensen wrote:
> Right, the right solution is probably to create a block driver list
> ar
On 10.12.2010, at 13:37, Markus Armbruster wrote:
> Alexander Graf writes:
>
>> On 21.11.2010, at 13:37, Blue Swirl wrote:
>>
>>> On Fri, Nov 19, 2010 at 2:56 AM, Alexander Graf wrote:
So far we have C preprocessor defines for target and host config
options, but we're lacking any in
Gerd Hoffmann writes:
>> I understand why you're adding this but this is one of those horrible
>> abuses of qdev that we really need to avoid.
>>
>> There are two valid reasons why hotplug is not possible:
>>
>> 1) Hotplugging is not supported by the *slot*. This is something that
>> needs to be
On Fri, 10 Dec 2010 14:36:08 +0800
Lai Jiangshan wrote:
> +SQMP
> +inject_nmi
> +--
> +
> +Inject an NMI on the given CPU (x86 only).
> +
> +Arguments:
> +
> +- "cpu_index": the index of the CPU to be injected NMI (json-int)
> +
> +Example:
> +
> +-> { "execute": "inject_nmi", "arguments"
On Fri, 10 Dec 2010 14:36:01 +0800
Lai Jiangshan wrote:
>
> Signed-off-by: Lai Jiangshan
As Markus said, we report this as an invalid parameter in do_cpu(), we can do
the same for inject-nmi.
> ---
> diff --git a/qerror.c b/qerror.c
> index ac2cdaf..f59fb58 100644
> --- a/qerror.c
> +++ b/qe
Lai Jiangshan writes:
> Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt).
>
> changed from v1
> Add document.
> Add error handling when the cpu index is invalid.
>
> Signed-off-by: Lai Jiangshan
> ---
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 23024ba..f8
On Thu, Dec 9, 2010 at 8:45 PM, Michael Roth wrote:
> On 12/08/2010 04:10 AM, Stefan Hajnoczi wrote:
>> What concrete use-cases are there?
>> * Reboot support on x86. A QMP command can invoke guest-initiated
>> reboot via virtagent.
>> * ?
>>
>
> * viewfile
> The ability to do a quick peek at gue
For the record, there's more on that bug at
http://thread.gmane.org/gmane.linux.ubuntu.bugs.server/36923
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/595117
Title:
qemu-nbd slow and missing "write
Am 09.12.2010 17:18, schrieb Alexander Graf:
> Kevin Wolf wrote:
>> Am 09.12.2010 16:48, schrieb Alexander Graf:
>>
> +static void ncq_cb(void *opaque, int ret)
> +{
> +NCQTransferState *ncq_tfs = (NCQTransferState *)opaque;
> +IDEState *ide_state;
> +
> +if (
On 12/09/2010 06:29 PM, Stefano Bonifazi wrote:
how can one think that addresses around zero are free for a mapping??
Addresses around zero are always free, because if they weren't you
couldn't detect NULL pointer dereferences reliably.
mmap-ing at zero thus is a tricky operation, because it
Am 10.12.2010 08:42, Lai Jiangshan wrote:
>
> Make use of the new KVM_NMI IOCTL to send NMIs into the KVM guest if the
> user space raised them. (example: qemu monitor's "nmi" command)
>
> Signed-off-by: Lai Jiangshan
> ---
> diff --git a/configure b/configure
> index 2917874..f6f9362 100755
> -
Juan Quintela writes:
> Jason Wang wrote:
> > Juan Quintela writes:
> > > Jason Wang wrote:
> > > > The saving and restoring of error_code seems lost and convert the
> > > > error_code to uint32_t.
> > > >
> > > > Signed-off-by: Jason Wang
> > > > ---
> > > > target-i386/cpu.h
63 matches
Mail list logo
