[Qemu-devel] [PATCH V2] qemu, kvm: Enable user space NMI injection for kvm guest

2010-12-09 Thread Lai Jiangshan
Make use of the new KVM_NMI IOCTL to send NMIs into the KVM guest if the user space raised them. (example: qemu monitor's "nmi" command) Signed-off-by: Lai Jiangshan --- diff --git a/configure b/configure index 2917874..f6f9362 100755 --- a/configure +++ b/configure @@ -1646,6 +1646,9 @@ if test

Re: [Qemu-devel] Re: [RFC][PATCH v5 09/21] virtagent: add va.getdmesg RPC

2010-12-09 Thread Jes Sorensen
On 12/09/10 22:15, Michael Roth wrote: > On 12/08/2010 01:22 PM, Jes Sorensen wrote: >>> This param is kind of quirky though, size doesn't seem to have an affect >>> for anything below 4KB, but if we stick with VA_DMESG_LEN>= 4KB this >>> should cover us, unless it's a distro-specific. But it shoul

[Qemu-devel] Re: [RFC][PATCH v5 08/21] virtagent: add agent_viewfile qmp/hmp command

2010-12-09 Thread Jes Sorensen
On 12/09/10 22:12, Michael Roth wrote: > On 12/07/2010 08:26 AM, Jes Sorensen wrote: >> I believe this suffers from the same architectural problem I mentioned >> in my comment to 07/21 - you don't restrict the file size, so it could >> blow up the QEMU process on the host trying to view the wrong f

[Qemu-devel] [PATCH v2 1/2] QError: new QERR_INVALID_CPU_INDEX

2010-12-09 Thread Lai Jiangshan
Signed-off-by: Lai Jiangshan --- diff --git a/qerror.c b/qerror.c index ac2cdaf..f59fb58 100644 --- a/qerror.c +++ b/qerror.c @@ -117,6 +117,10 @@ static const QErrorStringTable qerror_table[] = { .desc = "Invalid block format '%(name)'", }, { +.error_fmt = QERR_I

[Qemu-devel] [PATCH v2 2/2] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-09 Thread Lai Jiangshan
Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt). changed from v1 Add document. Add error handling when the cpu index is invalid. Signed-off-by: Lai Jiangshan --- diff --git a/hmp-commands.hx b/hmp-commands.hx index 23024ba..f86d9fe 100644 --- a/hmp-commands.hx +++ b/

[Qemu-devel] Re: [PATCH v3 1/1] qemu-img.c: Clean up handling of image size in img_create()

2010-12-09 Thread Kevin Wolf
Am 09.12.2010 10:45, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > This cleans up the handling of image size in img_create() by parsing > the value early, and then only setting it once if a value has been > added as the last argument to the command line. > > Signed-off-by: Jes Sorens

[Qemu-devel] [PATCH 22/24] usb: add device qualifier support

2010-12-09 Thread Gerd Hoffmann
Add support for device_qualifier and other_speed_config descriptors. These are used to query the "other speed" configuration of usb 2.0 devices, i.e. in high-speed mode they return the full-speed configuration and visa versa. Signed-off-by: Gerd Hoffmann --- hw/usb-desc.c | 46

[Qemu-devel] [Bug 595117] Re: qemu-nbd slow and missing "writeback" cache option

2010-12-09 Thread Launchpad Bug Tracker
[Expired for qemu-kvm (Ubuntu) because there has been no activity for 60 days.] ** Changed in: qemu-kvm (Ubuntu) Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/595

[Qemu-devel] Re: [PATCH] kvm: x86: Save/restore error_code

2010-12-09 Thread Jason Wang
Juan Quintela writes: > Jason Wang wrote: > > The saving and restoring of error_code seems lost and convert the > > error_code to uint32_t. > > > > Signed-off-by: Jason Wang > > --- > > target-i386/cpu.h |4 ++-- > > target-i386/machine.c |2 ++ > > 2 files changed, 4 insert

[Qemu-devel] [PATCH v2] block: Introduce path_has_protocol() function

2010-12-09 Thread Stefan Hajnoczi
The bdrv_find_protocol() function returns NULL if an unknown protocol name is given. It returns the "file" protocol when the filename contains no protocol at all. This makes it difficult to distinguish between paths which contain a protocol and those which do not. Factor out a helper function th

[Qemu-devel] [PATCH] audio: reset timer when enabling capture mode

2010-12-09 Thread Michael Walle
The audio timer also has to be reset when a capture device is enabled. This will ensure the timer to be started even if just capture devices are active. Signed-off-by: Michael Walle --- audio/audio.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/audio/audio.c b/audio/a

[Qemu-devel] [PATCH 06/24] usb bluetooth: use new descriptor infrastructure.

2010-12-09 Thread Gerd Hoffmann
Switch the usb bluetooth driver over to the new descriptor infrastructure. Signed-off-by: Gerd Hoffmann --- hw/usb-bt.c | 473 +-- 1 files changed, 202 insertions(+), 271 deletions(-) diff --git a/hw/usb-bt.c b/hw/usb-bt.c index 56d1a6c..

[Qemu-devel] [PATCH 16/24] usb: add usb_wakeup() + wakeup callback to port ops

2010-12-09 Thread Gerd Hoffmann
Add wakeup callback to port ops for remote wakeup handling. Also add a usb_wakeup() function for devices which want trigger a remote wakeup. Signed-off-by: Gerd Hoffmann --- hw/usb.c |7 +++ hw/usb.h |2 ++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/hw/usb.c b/hw/

Re: [Qemu-devel] [PATCH 1/6] [RFC] Emulation of GRLIB GPTimer as defined in GRLIB IP Core User's Manual.

2010-12-09 Thread Edgar E. Iglesias
On Thu, Dec 09, 2010 at 11:04:58AM +0100, Fabien Chouteau wrote: > On 12/08/2010 11:51 PM, Edgar E. Iglesias wrote: > > On Mon, Dec 06, 2010 at 10:26:02AM +0100, Fabien Chouteau wrote: > >> > >> Signed-off-by: Fabien Chouteau > >> --- > >> hw/grlib_gptimer.c | 448 > >> +

[Qemu-devel] QEMU Uncompressing Linux.... stalls

2010-12-09 Thread Prasad Joshi
Hello All, I built an arm-linux kernel and trying to boot it using QEMU. But it stalls after showing 'Uncompressing Linux...' $ qemu-system-arm -M realview-pbx-a9 -kernel clfskernel-2.6.36 -initrd rootfs.gz -append "console=ttyAMA0 root=/dev/sda1 rw ramdisk_size=32678" -m 256 -nographic Uncompres

[Qemu-devel] Re: [PATCH 1/2] Introduce strtosz_suffix()

2010-12-09 Thread Stefan Hajnoczi
On Thu, Dec 09, 2010 at 01:13:33PM +0100, jes.soren...@redhat.com wrote: > @@ -371,3 +377,8 @@ fail: > > return retval; > } > + > +ssize_t strtosz(const char *nptr, char **end) > +{ > +return strtosz_suffix(nptr, end, 0); This obscures what the default is, please use STRTOSZ_DEFSUFFIX_M

[Qemu-devel] [PATCH 10/24] usb network: use new descriptor infrastructure.

2010-12-09 Thread Gerd Hoffmann
Switch the usb network driver over to the new descriptor infrastructure. Signed-off-by: Gerd Hoffmann --- hw/usb-net.c | 453 +++--- 1 files changed, 209 insertions(+), 244 deletions(-) diff --git a/hw/usb-net.c b/hw/usb-net.c index 58c672f..

[Qemu-devel] [PATCH] noaudio: fix return value for read()

2010-12-09 Thread Michael Walle
Read should return bytes instead of samples. Signed-off-by: Michael Walle --- audio/noaudio.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/audio/noaudio.c b/audio/noaudio.c index 4925234..8015858 100644 --- a/audio/noaudio.c +++ b/audio/noaudio.c @@ -121,7 +121,7 @@

[Qemu-devel] [PATCH 14/24] usb: create USBPortOps, move attach there.

2010-12-09 Thread Gerd Hoffmann
Create USBPortOps struct, move the attach function to that struct. Signed-off-by: Gerd Hoffmann --- hw/usb-bus.c |4 ++-- hw/usb-hub.c |6 +- hw/usb-musb.c |6 +- hw/usb-ohci.c |6 +- hw/usb-uhci.c |6 +- hw/usb.c |2 +- hw/usb.h |8 +--

[Qemu-devel] [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-09 Thread Alex Williamson
The cpu_register_io_memory() value is unique to the VM instance and should not be restored after migration/save. Doing so means we could be pointing at arbitrary device's io regions after migration/restore. In this case, if we start a VM with a single rtl8139, hot add a 2nd, migrate the VM, then

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-09 Thread Juan Quintela
Alex Williamson wrote: > The cpu_register_io_memory() value is unique to the VM instance and > should not be restored after migration/save. Doing so means we > could be pointing at arbitrary device's io regions after migration/restore. > > In this case, if we start a VM with a single rtl8139, hot

Re: [Qemu-devel] [PATCH 2/6] [RFC] Emulation of GRLIB IRQMP as defined in GRLIB IP Core User's Manual.

2010-12-09 Thread Edgar E. Iglesias
On Mon, Dec 06, 2010 at 10:26:03AM +0100, Fabien Chouteau wrote: > > Signed-off-by: Fabien Chouteau > --- > hw/grlib_irqmp.c | 416 > ++ > 1 files changed, 416 insertions(+), 0 deletions(-) > > diff --git a/hw/grlib_irqmp.c b/hw/grlib_irqmp.

Re: [Qemu-devel] Re: [RFC][PATCH v5 09/21] virtagent: add va.getdmesg RPC

2010-12-09 Thread Michael Roth
On 12/08/2010 01:22 PM, Jes Sorensen wrote: On 12/07/10 18:32, Michael Roth wrote: On 12/07/2010 08:37 AM, Jes Sorensen wrote: On 12/03/10 19:03, Michael Roth wrote: +static xmlrpc_value *va_getdmesg(xmlrpc_env *env, + xmlrpc_value *param, +

[Qemu-devel] Re: [PATCH 6/6] qemu, qmp: Convert do_sendkey() to QObject, QError

2010-12-09 Thread Luiz Capitulino
On Thu, 09 Dec 2010 14:59:40 +0800 Lai Jiangshan wrote: > > Convert do_sendkey() to QObject,QError, we need to use it.(via libvirt) > > It is a trivial conversion, carefully converted the error reports. Trivial conversion doesn't seem to lead to a good interface for qmp, because sendkey carrie

Re: [Qemu-devel] Re: IRC channel movement -> FreeNode to OFTC

2010-12-09 Thread Brian Jackson
On Thursday, December 09, 2010 08:06:10 am François Revol wrote: > Hi, > > > I'd like to move IRC channels from FreeNode to OFTC, so please join #qemu > > on OFTC starting now. > > - what's wrong with freenode ? everyone is there. I can't speak for Anthony or the other devs, but freenode has so

Re: [Qemu-devel] [RFC][PATCH v5 00/21] virtagent: host/guest RPC communication agent

2010-12-09 Thread Michael Roth
On 12/08/2010 04:10 AM, Stefan Hajnoczi wrote: On Fri, Dec 3, 2010 at 6:03 PM, Michael Roth wrote: These patches apply to master, and can also be obtained from: git://repo.or.cz/qemu/mdroth.git virtagent_v5 Why XML-RPC and not QMP? When I skim through the patch series it seems like much of t

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-09 Thread Alex Williamson
On Thu, 2010-12-09 at 22:49 +0100, Juan Quintela wrote: > Alex Williamson wrote: > > The cpu_register_io_memory() value is unique to the VM instance and > > should not be restored after migration/save. Doing so means we > > could be pointing at arbitrary device's io regions after migration/restor

[Qemu-devel] [PATCH 3/6] qumu,qmp: QError: New QERR_INVALID_KEY

2010-12-09 Thread Lai Jiangshan
Signed-off-by: Lai Jiangshan --- diff --git a/qerror.c b/qerror.c index ac2cdaf..a7ef758 100644 --- a/qerror.c +++ b/qerror.c @@ -117,6 +117,10 @@ static const QErrorStringTable qerror_table[] = { .desc = "Invalid block format '%(name)'", }, { +.error_fmt = QERR_I

Re: [Qemu-devel] State of EHCI emulation for QEMU

2010-12-09 Thread David S. Ahern
On 12/09/10 06:05, Gerd Hoffmann wrote: > > Hi, > >> New features developed for the kernel are done in a separate git trees. >> When a feature is ready for inclusion into the main kernel tree, a pull >> request is sent. That workflow maintains a complete change history for >> the feature. Tak

[Qemu-devel] Re: [RFC][PATCH v5 08/21] virtagent: add agent_viewfile qmp/hmp command

2010-12-09 Thread Michael Roth
On 12/07/2010 08:26 AM, Jes Sorensen wrote: On 12/03/10 19:03, Michael Roth wrote: Utilize the getfile RPC to provide a means to view text files in the guest. Getfile can handle binary files as well but we don't advertise that here due to the special handling requiring to store it and provide it

[Qemu-devel] [Bug 688085] Re: Guest kernel hang during boot when KVM is active on i386 host

2010-12-09 Thread Коренберг Марк
When booting another kernel (like RHEL 6.0) in guest, kernel hang on the line: Probing EDD (edd=off to disable)... ok Really, it hang in set_64bit inside function native_set_pmd() -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https

Re: [Qemu-devel] [RFC][PATCH v5 00/21] virtagent: host/guest RPC communication agent

2010-12-09 Thread Anthony Liguori
On 12/09/2010 02:45 PM, Michael Roth wrote: On 12/08/2010 04:10 AM, Stefan Hajnoczi wrote: On Fri, Dec 3, 2010 at 6:03 PM, Michael Roth wrote: These patches apply to master, and can also be obtained from: git://repo.or.cz/qemu/mdroth.git virtagent_v5 Why XML-RPC and not QMP? When I skim thr

[Qemu-devel] [Bug 688085] [NEW] Guest kernel hang during boot when KVM is active on i386 host

2010-12-09 Thread Коренберг Марк
Public bug reported: Binary package hint: qemu Guest kernel hang during boot when KVM is active on i386 host See the patch. http://www.spinics.net/lists/kvm/msg40800.html How to reproduce: 1. install Maversick x86 (not amd64) 2. ensure you have kvm support in processor 3. kvm -kernel /boot/in

[Qemu-devel] [PATCH 1/6] qemu, kvm: Enable NMI support for user space irqchip

2010-12-09 Thread Lai Jiangshan
Make use of the new KVM_NMI IOCTL to send NMIs into the KVM guest if the user space APIC emulation or some other source raised them. Signed-off-by: Lai Jiangshan --- diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 7dfc357..c4ebe28 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @

[Qemu-devel] Re: [RFC][PATCH v5 07/21] virtagent: add va.getfile RPC

2010-12-09 Thread Michael Roth
On 12/09/2010 08:40 AM, Adam Litke wrote: On Wed, 2010-12-08 at 20:19 +0100, Jes Sorensen wrote: On 12/07/10 17:00, Adam Litke wrote: Hi Jes, you raise some good points and pitfalls with the current getfile approach. I've been thinking about an alternative and am wondering what you (and others

[Qemu-devel] [PATCH 24/24] usb storage: fix status reporting

2010-12-09 Thread Gerd Hoffmann
Change usb_msd_send_status() to take a pointer to the status packet instead of writing the status to s->usb_buf which might not point to the correct location. Signed-off-by: Gerd Hoffmann --- hw/usb-msd.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/usb

[Qemu-devel] Re: [PATCH 09/13] ahci: add ahci emulation

2010-12-09 Thread Kevin Wolf
Am 09.12.2010 16:48, schrieb Alexander Graf: >>> +static void ncq_cb(void *opaque, int ret) >>> +{ >>> +NCQTransferState *ncq_tfs = (NCQTransferState *)opaque; >>> +IDEState *ide_state; >>> + >>> +if (ret < 0) { >>> +/* XXX error */ >>> +} >>> >> >> Missing error handli

[Qemu-devel] Using the mailing list for asking questions about the source code

2010-12-09 Thread Stefano Bonifazi
Hi All! I am new in QEMU developing and I am not sure if I can use this mailing list for asking general questions about QEMU source code as I could not find any guidelines about it. I noticed that, usually, questions about the source code in the QEMU forum never receive answers. Surely the bes

[Qemu-devel] Re: [PATCH 09/13] ahci: add ahci emulation

2010-12-09 Thread Alexander Graf
Stefan Hajnoczi wrote: > On Wed, Dec 8, 2010 at 12:13 PM, Alexander Graf wrote: > >> +struct AHCIDevice { >> +IDEBus port; >> +int port_no; >> +uint32_t port_state; >> +uint32_t finished; >> +AHCIPortRegs port_regs; >> +struct AHCIState *hba; >> +uint8_t *lst; >> +

[Qemu-devel] Re: [RFC][PATCH v5 07/21] virtagent: add va.getfile RPC

2010-12-09 Thread Adam Litke
On Wed, 2010-12-08 at 20:19 +0100, Jes Sorensen wrote: > On 12/07/10 17:00, Adam Litke wrote: > > Hi Jes, you raise some good points and pitfalls with the current getfile > > approach. I've been thinking about an alternative and am wondering what > > you (and others) think... > > > > First off, I

[Qemu-devel] Re: [PATCH 2/6] qemu, qmp: convert do_inject_nmi() to QObject

2010-12-09 Thread Luiz Capitulino
On Thu, 09 Dec 2010 14:59:00 +0800 Lai Jiangshan wrote: > > Convert do_inject_nmi() to QObject, we need to use it(via libvirt). Patches 0/6 and 1/6 are missing. Also, I see that you're converting two unrelated commands in the same series. Please, split into two series. > It is trivial, as it

[Qemu-devel] Re: [PATCH v2] block: Introduce path_has_protocol() function

2010-12-09 Thread Kevin Wolf
Am 09.12.2010 12:53, schrieb Stefan Hajnoczi: > The bdrv_find_protocol() function returns NULL if an unknown protocol > name is given. It returns the "file" protocol when the filename > contains no protocol at all. This makes it difficult to distinguish > between paths which contain a protocol an

[Qemu-devel] [Bug 688052] Re: usb does not work 0.13.0

2010-12-09 Thread sirio81
** Attachment added: "host hardware details" https://bugs.launchpad.net/bugs/688052/+attachment/1760810/+files/host_info.txt.gz -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/688052 Title: usb

[Qemu-devel] [Bug 688052] [NEW] usb does not work 0.13.0

2010-12-09 Thread sirio81
Public bug reported: Hi all, I'm using both, debian lenny and debian squeeze. I installed qemu-kvm (0.12.5) form debian repository but I got problem trying to pass a host usb device to the guest. I compiled so the latest stable version (0.13.0) hoping that the problem was fixed. It didn't help,

[Qemu-devel] [PATCH 1/2] Introduce strtosz_suffix()

2010-12-09 Thread Jes . Sorensen
From: Jes Sorensen This introduces strtosz_suffix() which allows the caller to specify a default suffix in case the non default of MB is wanted. strtosz() is kept as a wrapper for strtosz_suffix() which keeps it's current default of MB. Signed-off-by: Jes Sorensen --- cutils.c | 17 +++

[Qemu-devel] Re: [PATCH 1/2] Introduce strtosz_suffix()

2010-12-09 Thread Jes Sorensen
On 12/09/10 13:53, Stefan Hajnoczi wrote: > On Thu, Dec 09, 2010 at 01:13:33PM +0100, jes.soren...@redhat.com wrote: >> @@ -371,3 +377,8 @@ fail: >> >> return retval; >> } >> + >> +ssize_t strtosz(const char *nptr, char **end) >> +{ >> +return strtosz_suffix(nptr, end, 0); > > This obscu

[Qemu-devel] [PATCH v5 0/2] Clean up img_create() and introduce strtosz_suffix()

2010-12-09 Thread Jes . Sorensen
From: Jes Sorensen This patch set introduces strtosz_suffix() which is needed to be able to use strtosz parsing with a non MB default suffix. This is used to clean up qemu-img.c:img_create(). Kevin asked me to rebase this instead of applying the other patches on top, so please discard the previo

[Qemu-devel] [PATCH 13/14] qemu-img: Free option parameter lists in img_create()

2010-12-09 Thread Kevin Wolf
From: Stefan Hajnoczi Free option parameter lists in the img_create() error return path. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- qemu-img.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index d146d8c..c5a173c 100644 --

[Qemu-devel] Re: [PATCH v5 0/2] Clean up img_create() and introduce strtosz_suffix()

2010-12-09 Thread Kevin Wolf
Am 09.12.2010 14:17, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > This patch set introduces strtosz_suffix() which is needed to be able > to use strtosz parsing with a non MB default suffix. This is used to > clean up qemu-img.c:img_create(). > > Kevin asked me to rebase this instea

[Qemu-devel] Re: [PATCH 09/13] ahci: add ahci emulation

2010-12-09 Thread Alexander Graf
Kevin Wolf wrote: > Am 09.12.2010 16:48, schrieb Alexander Graf: > +static void ncq_cb(void *opaque, int ret) +{ +NCQTransferState *ncq_tfs = (NCQTransferState *)opaque; +IDEState *ide_state; + +if (ret < 0) { +/* XXX error */ +} >>

Re: [Qemu-devel] IRC channel movement -> FreeNode to OFTC

2010-12-09 Thread Anthony Liguori
On 12/09/2010 09:12 AM, Mulyadi Santosa wrote: On Wed, Dec 8, 2010 at 23:18, Anthony Liguori wrote: Hi, I'd like to move IRC channels from FreeNode to OFTC, so please join #qemu on OFTC starting now. OFTC is nice place too IMHO... but if it's not a top secret, why move? Have

Re: [Qemu-devel] [PATCH 2/6] [RFC] Emulation of GRLIB IRQMP as defined in GRLIB IP Core User's Manual.

2010-12-09 Thread Edgar E. Iglesias
On Thu, Dec 09, 2010 at 12:03:35PM +0100, Fabien Chouteau wrote: > On 12/09/2010 11:32 AM, Edgar E. Iglesias wrote: > > On Mon, Dec 06, 2010 at 10:26:03AM +0100, Fabien Chouteau wrote: > >> > >> Signed-off-by: Fabien Chouteau > >> --- > >> hw/grlib_irqmp.c | 416 > >> +++

[Qemu-devel] Re: IRC channel movement -> FreeNode to OFTC

2010-12-09 Thread François Revol
Hi, > I'd like to move IRC channels from FreeNode to OFTC, so please join #qemu on > OFTC starting now. - what's wrong with freenode ? everyone is there. - #define OFTC ? François.

[Qemu-devel] Re: [PATCH] fix qruncom compilation problems

2010-12-09 Thread Stefano Bonifazi
On 12/09/2010 08:16 AM, Paolo Bonzini wrote: On 12/08/2010 10:43 PM, Stefano Bonifazi wrote: Anyway running it with a com file as argument gave the error: mmap: Operation not permitted You have to run it as root I think. Paolo Thank you! Running as root worked, though it raises then the f

[Qemu-devel] [Bug 688085] Re: Guest kernel hang during boot when KVM is active on i386 host

2010-12-09 Thread Scott Moser
** Changed in: kvm (Ubuntu) Status: New => Invalid ** Changed in: qemu (Ubuntu) Status: New => Invalid ** Changed in: qemu-kvm (Ubuntu) Importance: Undecided => Medium ** Changed in: qemu-kvm (Ubuntu) Status: New => Triaged -- You received this bug notification because

[Qemu-devel] [PULL] spice: add qxl device, qmp events + monitor commands.

2010-12-09 Thread Gerd Hoffmann
The following changes since commit 138b38b61bf92d4e9588acf934e532499c94e185: ppc: kvm: fix signedness warning (2010-12-08 21:30:19 +0100) are available in the git repository at: git://anongit.freedesktop.org/spice/qemu spice.v23.pull Gerd Hoffmann (7): spice: add qxl vgabios binary.

Re: [Qemu-devel] IRC channel movement -> FreeNode to OFTC

2010-12-09 Thread Mulyadi Santosa
On Wed, Dec 8, 2010 at 23:18, Anthony Liguori wrote: > Hi, > > I'd like to move IRC channels from FreeNode to OFTC, so please join #qemu on > OFTC starting now. OFTC is nice place too IMHO... but if it's not a top secret, why move? -- regards, Mulyadi Santosa Freelance Linux trainer and consu

[Qemu-devel] [PATCH 2/2] qemu-img.c: Clean up handling of image size in img_create()

2010-12-09 Thread Jes . Sorensen
From: Jes Sorensen This cleans up the handling of image size in img_create() by parsing the value early, and then only setting it once if a value has been added as the last argument to the command line. Signed-off-by: Jes Sorensen --- qemu-img.c | 23 +-- 1 files changed,

[Qemu-devel] Re: [PATCH 1/7] usb-linux: introduce a usb_linux_alt_setting function

2010-12-09 Thread Gerd Hoffmann
On 11/26/10 19:13, Hans de Goede wrote: The next patch in this series introduces multiple ways to get the alt setting dependent upon usb_fs_type, it is cleaner to put this into its own function. Note that this patch also changes the assumed alt setting in case of an error getting the alt setting

[Qemu-devel] Re: [PATCH] migration: ide: drop ide_pci_post_load()

2010-12-09 Thread Juan Quintela
Jason Wang wrote: > When the bmdma transfering ended, the unit were set to -1(0xFF), but > after migration ide_pci_post_load() would change it to 1. This is not > intended and it also would break the migration stability that we > could not get exactly the same exec file before and after migration.

[Qemu-devel] [PATCH 15/24] usb: rework attach/detach workflow

2010-12-09 Thread Gerd Hoffmann
Add separate detach callback to USBPortOps, split uhci/ohci/musb/usbhub attach functions into two. Move common code to the usb_attach() function, only the hardware-specific bits remain in the attach/detach callbacks. Keep track of the port it is attached to for each usb device. Signed-off-by: Ge

Re: [Qemu-devel] State of EHCI emulation for QEMU

2010-12-09 Thread Gerd Hoffmann
Hi, New features developed for the kernel are done in a separate git trees. When a feature is ready for inclusion into the main kernel tree, a pull request is sent. That workflow maintains a complete change history for the feature. Take performance events for example: you can go into Linus' gi

[Qemu-devel] [PATCH 19/24] usb: add speed mask to ports

2010-12-09 Thread Gerd Hoffmann
Add a field to usb ports indicating the speed(s) they are able to handle. Signed-off-by: Gerd Hoffmann --- hw/usb-bus.c |3 ++- hw/usb-hub.c |3 ++- hw/usb-musb.c |3 ++- hw/usb-ohci.c |3 ++- hw/usb-uhci.c |3 ++- hw/usb.h |9 - 6 files changed, 18 inserti

[Qemu-devel] [PATCH 21/24] usb: add usb_desc_attach

2010-12-09 Thread Gerd Hoffmann
Add usb_desc_attach() which sets up the device according to the speed the usb port is able to handle. This function can be hooked into the handle_attach callback. Signed-off-by: Gerd Hoffmann --- hw/usb-desc.c | 36 +--- hw/usb-desc.h |1 + 2 files changed,

[Qemu-devel] [PATCH 17/24] usb: uhci: remote wakeup support.

2010-12-09 Thread Gerd Hoffmann
Add support for remote wakeup to the UHCI adapter. Signed-off-by: Gerd Hoffmann --- hw/usb-uhci.c | 23 +-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index debf7f7..60d5d57 100644 --- a/hw/usb-uhci.c +++ b/hw/usb-uhci.c @@

[Qemu-devel] [PATCH 12/24] usb: move USB_REQ_{GET, SET}_CONFIGURATION handling to common code

2010-12-09 Thread Gerd Hoffmann
This patch adds fields to the USBDevice struct for the current speed (hard-wired to full speed for now) and current device configuration. Also a init function is added which inializes these fields. This allows USB_REQ_{GET,SET}_CONFIGURATION handling to be moved to common code. For most drivers

[Qemu-devel] [PATCH 13/24] usb: move remote wakeup handling to common code

2010-12-09 Thread Gerd Hoffmann
This patch moves setting and clearing the remote_wakeup feature bit (via USB_REQ_{SET,CLEAR}_FEATURE) to common code. Also USB_REQ_GET_STATUS handling is moved to common code. Signed-off-by: Gerd Hoffmann --- hw/usb-bt.c | 21 +++-- hw/usb-desc.c | 26 +

[Qemu-devel] [PATCH 6/6] qemu, qmp: Convert do_sendkey() to QObject, QError

2010-12-09 Thread Lai Jiangshan
Convert do_sendkey() to QObject,QError, we need to use it.(via libvirt) It is a trivial conversion, carefully converted the error reports. Signed-off-by: Lai Jiangshan --- diff --git a/hmp-commands.hx b/hmp-commands.hx index 23024ba..7a49b74 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@

[Qemu-devel] [PATCH 08/24] usb descriptors: add settable strings.

2010-12-09 Thread Gerd Hoffmann
This patch allows to set usb descriptor strings per device instance. Signed-off-by: Gerd Hoffmann --- hw/usb-bus.c |1 + hw/usb-desc.c | 52 hw/usb-desc.h |4 +++- hw/usb.h |9 + 4 files changed, 57 insertions(+), 9

[Qemu-devel] [PATCH 11/14] qemu-option: Don't reinvent append_option_parameters()

2010-12-09 Thread Kevin Wolf
From: Stefan Hajnoczi parse_option_parameters() may need to create a new option parameter list from a template list. Use append_option_parameters() instead of duplicating the code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- qemu-option.c |9 + 1 files changed, 1

[Qemu-devel] [PATCH] migration: ide: drop ide_pci_post_load()

2010-12-09 Thread Jason Wang
When the bmdma transfering ended, the unit were set to -1(0xFF), but after migration ide_pci_post_load() would change it to 1. This is not intended and it also would break the migration stability that we could not get exactly the same exec file before and after migration. So this patch drop the id

[Qemu-devel] [PATCH 11/24] usb: move USB_REQ_SET_ADDRESS handling to common code

2010-12-09 Thread Gerd Hoffmann
USB_REQ_SET_ADDRESS handling is identical in *all* emulated devices. Move it to common code. Signed-off-by: Gerd Hoffmann --- hw/usb-bt.c |4 hw/usb-desc.c |6 ++ hw/usb-hid.c|4 hw/usb-hub.c|4 hw/usb-msd.c|4 hw/usb-net.c|5

[Qemu-devel] [PATCH] kvm: x86: Save/restore error_code

2010-12-09 Thread Jason Wang
The saving and restoring of error_code seems lost and convert the error_code to uint32_t. Signed-off-by: Jason Wang --- target-i386/cpu.h |4 ++-- target-i386/machine.c |2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 0

[Qemu-devel] [PATCH 03/24] usb serial: use new descriptor infrastructure.

2010-12-09 Thread Gerd Hoffmann
Switch the usb serial drivers (serial, braille) over to the new descriptor infrastructure. Note that this removes the freely configurable vendor and product id properties. I think the only reason this was configurable is that the only difference between the serial and the braille device is the ve

[Qemu-devel] [PATCH 1/1] Introduce strtosz_suffix()

2010-12-09 Thread Jes . Sorensen
From: Jes Sorensen This introduces strtosz_suffix() which allows the caller to specify a default suffix in case the non default of MB is wanted. strtosz() is kept as a wrapper for strtosz_suffix() which keeps it's current default of MB. Signed-off-by: Jes Sorensen --- cutils.c | 17 +++

[Qemu-devel] [PATCH 10/14] qemu-img: Deprecate obsolete -6 and -e options

2010-12-09 Thread Kevin Wolf
From: Jes Sorensen If -6 or -e is specified, an error message is printed and we exit. It does not print help() to avoid the error message getting lost in the noise. Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- block_int.h |1 - qemu-img.c | 53 ++---

[Qemu-devel] [PATCH 05/14] Consolidate printing of block driver options

2010-12-09 Thread Kevin Wolf
From: Jes Sorensen This consolidates the printing of block driver options in print_block_option_help() which is called from both img_create() and img_convert(). This allows for the "?" detection to be done just after the parsing of options and the filename, instead of half way down the codepath

[Qemu-devel] [PATCH 00/24] usb descriptor overhaul.

2010-12-09 Thread Gerd Hoffmann
Hi, This patch series is the start for an overhaul of the usb descriptor handling for emulated usb devices. Instead of storing the device desriptors in blobs (aka char arrays) they are stored in structs, which makes it alot easier to work with them. This in turn allows to move common device ma

[Qemu-devel] [PATCH 0/2] Fix size default for qemu-img

2010-12-09 Thread Jes . Sorensen
From: Jes Sorensen Kevin pointed out that my chance to img_create()'s handling of the image size, changed the previous default of byte for size if no suffix was specified, since strtosz() defaults to MB. This patch set introduces strtosz_suffix() and then changes img_create() to use that instead

[Qemu-devel] [Bug 687733] [NEW] Linux KSM not compiled in (MADV_MERGEABLE always undef)

2010-12-09 Thread Walter Haidinger
Public bug reported: Linux KSM support is not enabled because MADV_MERGEABLE remains undefined. It seems that asm-generic/mman-common.h is not included. Maybe some kind of header dependency problem? Adding #include to exec.c of qemu-kvm-0.13.0 enables use of KSM and values change in /sys/kern

[Qemu-devel] [PATCH 14/14] qemu-img: Fail creation if backing format is invalid

2010-12-09 Thread Kevin Wolf
From: Stefan Hajnoczi The qemu-img create command should check the backing format to ensure only image files with valid backing formats are created. By checking in qemu-img.c we can print a useful error message. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- qemu-img.c | 22 +

[Qemu-devel] Re: [PATCH v5 0/2] Clean up img_create() and introduce strtosz_suffix()

2010-12-09 Thread Stefan Hajnoczi
Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 2/6] qemu, qmp: convert do_inject_nmi() to QObject

2010-12-09 Thread Lai Jiangshan
Convert do_inject_nmi() to QObject, we need to use it(via libvirt). It is trivial, as it never fails, doesn't have output nor return any data. Signed-off-by: Lai Jiangshan --- diff --git a/hmp-commands.hx b/hmp-commands.hx index 7a49b74..2e6b034 100644 --- a/hmp-commands.hx +++ b/hmp-commands.

[Qemu-devel] [PATCH 23/24] usb storage: high speed support

2010-12-09 Thread Gerd Hoffmann
Add high speed support to the usb mass storage device. With this patch applied the linux kernel recognises the usb storage device as highspeed capable device and suggests to connect it to a highspeed port instead of the uhci. Tested with both uhci and (not-yet submitted) ehci. Signed-off-by: Ger

[Qemu-devel] [PATCH 12/14] qemu-option: Fix parse_option_parameters() documentation typo

2010-12-09 Thread Kevin Wolf
From: Stefan Hajnoczi Yoda said, "list is the templace is". Fix this. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- qemu-option.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index e380fc1..65db542 100644 --- a/qemu-

[Qemu-devel] Re: [PATCH] fix qruncom compilation problems

2010-12-09 Thread Paolo Bonzini
On 12/08/2010 10:43 PM, Stefano Bonifazi wrote: I've linked qemu-malloc.o and cutils.o together with qruncom.c and I managed to succesfully make it! here the make line: #$(MAKE) -C ../i386-linux-user libqemu.a $(CC) $(CFLAGS) -fomit-frame-pointer $(LDFLAGS) -I../target-i386 -I.. -I../linux-user

[Qemu-devel] Invitation to connect on LinkedIn

2010-12-09 Thread Anbang Ruan via LinkedIn
LinkedIn Anbang Ruan requested to add you as a connection on LinkedIn: -- Jiajun, I'd like to add you to my professional network on LinkedIn. - Anbang Accept invitation from Anbang Ruan http://www.linkedin.com/e/-kkb1ec-ghhmmrcc-5/qTMmi8QEI_f3

[Qemu-devel] [PATCH 08/14] Make error handling more consistent in img_create() and img_resize()

2010-12-09 Thread Kevin Wolf
From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- qemu-img.c | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 6fd52e9..5b6e648 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -349,13 +349,15 @@ stati

[Qemu-devel] [PATCH 18/24] usb: hid: remote wakeup support.

2010-12-09 Thread Gerd Hoffmann
Add usb_wakeup() call to the hid driver so remote wakeup actually works. Signed-off-by: Gerd Hoffmann --- hw/usb-hid.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/usb-hid.c b/hw/usb-hid.c index 1c35960..60fa57f 100644 --- a/hw/usb-hid.c +++ b/hw/usb-hid.c @@ -429

[Qemu-devel] [PATCH 20/24] usb: add attach callback

2010-12-09 Thread Gerd Hoffmann
Add handle_attach() callback to USBDeviceInfo which is called by the generic package handler when the device is attached to the usb bus (i.e. plugged into a port). Signed-off-by: Gerd Hoffmann --- hw/usb.c |7 ++- hw/usb.h |5 + 2 files changed, 11 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH 04/14] img_convert(): Only try to free bs[] entries if bs is valid.

2010-12-09 Thread Kevin Wolf
From: Jes Sorensen This allows for jumping to 'out:' consistently for error exit. Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- qemu-img.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index eca99c4..aded72d 100644 ---

[Qemu-devel] [PATCH 07/24] usb hub: use new descriptor infrastructure.

2010-12-09 Thread Gerd Hoffmann
Switch the usb hub driver over to the new descriptor infrastructure. It also removes the nr_ports variable and MAX_PORTS define and introduces a NUM_PORTS define instead. The numver of ports was (and still is) fixed at 8 anyway. Signed-off-by: Gerd Hoffmann --- hw/usb-hub.c | 141

[Qemu-devel] Re: [PATCH 03/13] ide: Split out BMDMA code from ATA core

2010-12-09 Thread Kevin Wolf
Am 08.12.2010 13:13, schrieb Alexander Graf: > The ATA core is currently heavily intertwined with BMDMA code. Let's loosen > that a bit, so we can happily replace the DMA backend with different > implementations. > > Signed-off-by: Alexander Graf > > --- > > v7 -> v8: > > - rewrite as DMA op

[Qemu-devel] [PATCH 06/14] Fix formatting and missing braces in qemu-img.c

2010-12-09 Thread Kevin Wolf
From: Jes Sorensen Signed-off-by: Jes Sorensen Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- qemu-img.c | 77 +++ 1 files changed, 51 insertions(+), 26 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 50cfdda..cc77

[Qemu-devel] [PATCH 09/24] usb storage: serial number support

2010-12-09 Thread Gerd Hoffmann
If a serial number is present for the drive fill it into the usb serialnumber string descriptor. Signed-off-by: Gerd Hoffmann --- hw/usb-msd.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/usb-msd.c b/hw/usb-msd.c index 20ab886..9aa 100644 --- a/hw/usb-msd.

[Qemu-devel] [PATCH 05/24] usb wacom: use new descriptor infrastructure.

2010-12-09 Thread Gerd Hoffmann
Switch the usb wavom driver over to the new descriptor infrastructure. Signed-off-by: Gerd Hoffmann --- hw/usb-wacom.c | 178 +++- 1 files changed, 73 insertions(+), 105 deletions(-) diff --git a/hw/usb-wacom.c b/hw/usb-wacom.c index 47f26cd.

Re: [Qemu-devel] [PATCH 2/6] [RFC] Emulation of GRLIB IRQMP as defined in GRLIB IP Core User's Manual.

2010-12-09 Thread Fabien Chouteau
On 12/09/2010 11:32 AM, Edgar E. Iglesias wrote: On Mon, Dec 06, 2010 at 10:26:03AM +0100, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteau --- hw/grlib_irqmp.c | 416 ++ 1 files changed, 416 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH 02/24] usb hid: use new descriptor infrastructure.

2010-12-09 Thread Gerd Hoffmann
Switch the usb hid drivers (keyboard, mouse, tablet) over to the new descriptor infrastructure. Signed-off-by: Gerd Hoffmann --- hw/usb-hid.c | 448 +++--- 1 files changed, 205 insertions(+), 243 deletions(-) diff --git a/hw/usb-hid.c b/hw/us

[Qemu-devel] [PATCH 01/24] usb: data structs and helpers for usb descriptors.

2010-12-09 Thread Gerd Hoffmann
This patch adds hw/usb-desc.[ch] files. They carry data structures for various usb descriptors and helper functions to generate usb packets from the structures. The intention is to have a internal representation of the device desription which is more usable than the current char array blobs, so w

[Qemu-devel] Re: [PATCH 2/3] block: Introduce path_has_protocol() function

2010-12-09 Thread Kevin Wolf
Am 30.11.2010 16:14, schrieb Stefan Hajnoczi: > The bdrv_find_protocol() function returns NULL if an unknown protocol > name is given. It returns the "file" protocol when the filename > contains no protocol at all. This makes it difficult to distinguish > between paths which contain a protocol an

  1   2   >