Re: [Qemu-devel] [PATCH 00/21] Kemari for KVM 0.2

2010-11-26 Thread Stefan Hajnoczi
On Sat, Nov 27, 2010 at 4:29 AM, Yoshiaki Tamura wrote: > 2010/11/27 Blue Swirl : >> On Thu, Nov 25, 2010 at 6:06 AM, Yoshiaki Tamura >> wrote: >>> Hi, >>> >>> This patch series is a revised version of Kemari for KVM, which >>> applied comments for the previous post and KVM Forum 2010.  The >>> c

[Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v8)

2010-11-26 Thread Stefan Hajnoczi
On Fri, Nov 26, 2010 at 9:59 PM, Christian Brunner wrote: > Thanks for the review. What am I supposed to do now? Kevin is the block maintainer. His review is the next step, I have CCed him. After that rbd would be ready to merge. Stefan

Re: [Qemu-devel] [PATCH 00/21] Kemari for KVM 0.2

2010-11-26 Thread Yoshiaki Tamura
2010/11/27 Blue Swirl : > On Thu, Nov 25, 2010 at 6:06 AM, Yoshiaki Tamura > wrote: >> Hi, >> >> This patch series is a revised version of Kemari for KVM, which >> applied comments for the previous post and KVM Forum 2010.  The >> current code is based on qemu.git >> f711df67d611e4762966a249742a5f

[Qemu-devel] Re: [PATCH 12/13] config: add generic pci config file

2010-11-26 Thread Alexander Graf
On 27.11.2010, at 01:16, Paul Brook wrote: >> Currently we list PCI devices in every PCI capable architecture >> individually. This is cumbersome when adding new devices and prone to >> failure because one might miss out on one. >> >> So let's instead have a generic PCI configuration file where

Re: [Qemu-devel] [PATCH 0/3] Reduce duplication in default configs

2010-11-26 Thread Paul Brook
> As mentioned elsewhere recently, there are a lot of devices that are > common to all targets. In particular all PCI devices [should] work on > all PCI capable machies. Currently each target default config has to > be updated separately, which becomes unmaintainable as as we get finer > grained

[Qemu-devel] Re: [PATCH 12/13] config: add generic pci config file

2010-11-26 Thread Paul Brook
> Currently we list PCI devices in every PCI capable architecture > individually. This is cumbersome when adding new devices and prone to > failure because one might miss out on one. > > So let's instead have a generic PCI configuration file where people can > throw in their cross-platform compati

[Qemu-devel] [PATCH 3/3] VirtIO config option

2010-11-26 Thread Paul Brook
Make virtio devices optional. Selecting individual devices is not useful as the host bindings are all in one file. Signed-off-by: Paul Brook --- Makefile.objs | 10 -- Makefile.target |4 ++-- default-configs/s390x-softmmu.mak |1 + 3 file

[Qemu-devel] [PATCH 2/3] PCI config include

2010-11-26 Thread Paul Brook
Split PCI config options into a separate file Signed-off-by: Paul Brook --- Makefile.objs | 20 +++- Makefile.target|4 ++-- default-configs/arm-softmmu.mak|3 +-- default-configs/cris-softmmu.mak |2 +-

[Qemu-devel] [PATCH 1/3] Include directives in default configs

2010-11-26 Thread Paul Brook
Allow default configs to be split into several files. Signed-off-by: Paul Brook --- Makefile | 11 ++- Makefile.objs |3 ++- make_device_config.sh | 27 +++ 3 files changed, 35 insertions(+), 6 deletions(-) create mode 100644 make_dev

Re: [Qemu-devel] [PATCH 08/15] prep: Declare as little endian

2010-11-26 Thread Benjamin Herrenschmidt
On Fri, 2010-11-26 at 23:06 +0100, Alexander Graf wrote: > > http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/prep > > I simply replaces explicit bswaps with the flag. Testing prep is hard, > as recent kernels don't run on it. To be honest, unless someone steps > up to maintain it I might

[Qemu-devel] [PATCH 0/3] Reduce duplication in default configs

2010-11-26 Thread Paul Brook
As mentioned elsewhere recently, there are a lot of devices that are common to all targets. In particular all PCI devices [should] work on all PCI capable machies. Currently each target default config has to be updated separately, which becomes unmaintainable as as we get finer grained control ov

Re: [Qemu-devel] [PATCH 01/15] exec: introduce endianness swapped mmio

2010-11-26 Thread Paul Brook
> > diff --git a/exec.c b/exec.c > > index db9ff55..f54a360 100644 > > --- a/exec.c > > +++ b/exec.c > > > > @@ -3370,6 +3474,22 @@ static int cpu_register_io_memory_fixed(int > > io_index, > > > > } > > io_mem_opaque[io_index] = opaque; > > > > +switch (endian) { > > +case DEVIC

Re: [Qemu-devel] [PATCH 01/15] exec: introduce endianness swapped mmio

2010-11-26 Thread Peter Maydell
On 26 November 2010 23:00, Andreas Färber wrote: > Am 25.11.2010 um 08:35 schrieb Alexander Graf: >> +    switch (endian) { >> +    case DEVICE_BIG_ENDIAN: >> +#ifndef TARGET_WORDS_BIGENDIAN >> +        swapendian_init(io_index); >> +#endif >> +        break; > > So basically, you just moved the #

Re: [Qemu-devel] [PATCH 01/15] exec: introduce endianness swapped mmio

2010-11-26 Thread Alexander Graf
On 27.11.2010, at 00:00, Andreas Färber wrote: > Am 25.11.2010 um 08:35 schrieb Alexander Graf: > >> The way we're currently modeling mmio is too simplified. We assume that >> every device has the same endianness as the target CPU. In reality, >> most devices are little endian (all PCI and ISA o

Re: [Qemu-devel] [PATCH 01/15] exec: introduce endianness swapped mmio

2010-11-26 Thread Andreas Färber
Am 25.11.2010 um 08:35 schrieb Alexander Graf: The way we're currently modeling mmio is too simplified. We assume that every device has the same endianness as the target CPU. In reality, most devices are little endian (all PCI and ISA ones I'm aware of). Some are big endian (special system

Re: [Qemu-devel] Patch: fix FSTENV (and FSAVE) instructions in target-i386 (resend, cleaned up).

2010-11-26 Thread ChALkeR
> Please also consider fixing FSAVE and FXSAVE. FSAVE also works, i checked twice (code and test). FSAVE in QEMU calls FSTENV. op_helper.c: > void helper_fsave(target_ulong ptr, int data32) > { >CPU86_LDouble tmp; >int i; > >helper_fstenv(ptr, data32); Not sure how FXSAVE operates, t

Re: [Qemu-devel] [PATCH 08/15] prep: Declare as little endian

2010-11-26 Thread Alexander Graf
On 26.11.2010, at 22:58, Andreas Färber wrote: > Am 25.11.2010 um 08:35 schrieb Alexander Graf: > >> This patch replaces explicit bswaps with endianness hints to the >> mmio layer. >> >> Signed-off-by: Alexander Graf > > I'm confused by the subject: Are you positive that PReP is little-endian

Re: [Qemu-devel] [PATCH 08/15] prep: Declare as little endian

2010-11-26 Thread Andreas Färber
Am 25.11.2010 um 08:35 schrieb Alexander Graf: This patch replaces explicit bswaps with endianness hints to the mmio layer. Signed-off-by: Alexander Graf I'm confused by the subject: Are you positive that PReP is little- endian? Or should this read "prep: Declare some devices as little en

[Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v8)

2010-11-26 Thread Christian Brunner
Thanks for the review. What am I supposed to do now? Christian 2010/11/18 Stefan Hajnoczi : > Reviewed-by: Stefan Hajnoczi > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at  http://vger.ke

Re: [Qemu-devel] [RFC] Static instrumentation (aka guest code tracing)

2010-11-26 Thread Paul Brook
> > Likewise requiring separate tracing hooks be added to the existing > > decoders is extremely unlikely to be a feasible long-term > > solution. > > You mean having to modify each "translate.c"? The worst event to handle > is instruction fetch on x86. Instruction fetches are trivial, you just i

Re: [Qemu-devel] [RFC] Static instrumentation (aka guest code tracing)

2010-11-26 Thread Lluís
Paul Brook writes: >> 2) instrumenting i386 is extremely time-consuming (for the developer) >> >> As my work is not tied to a specific target architecture, I was thinking of >> shifting into PPC, as the ISA is pretty regular and that would certainly >> make the process easier by just patching a s

[Qemu-devel] [PATCH 11/13] ide: move pata specific parts to pata.c

2010-11-26 Thread Alexander Graf
Due to popular request, this patch moves pieces that are successfully identified as PATA only to a new file called pata.c. Signed-off-by: Alexander Graf --- Makefile.objs |2 +- hw/ide/core.c | 144 +-- hw/ide/internal.h |3 + hw/ide/pata.

[Qemu-devel] [PATCH 00/13] AHCI emulation support v6

2010-11-26 Thread Alexander Graf
This patch adds support for AHCI emulation. I have tested and verified it works in Linux, OpenBSD, Windows Vista and Windows 7. This AHCI emulation supports NCQ, so multiple read or write requests can be outstanding at the same time. The code is however not fully optimized yet. I'm fairly sure th

[Qemu-devel] [PATCH 02/13] ide: fix whitespace gap in ide_exec_cmd

2010-11-26 Thread Alexander Graf
Now that we have the function split out, we have to reindent it. In order to increase the readability of the actual functional change, this is split out. Signed-off-by: Alexander Graf --- hw/ide/core.c | 734 1 files changed, 367 insertio

Re: [Qemu-devel] Patch: fix FSTENV (and FSAVE) instructions in target-i386 (resend, cleaned up).

2010-11-26 Thread Blue Swirl
On Fri, Nov 26, 2010 at 1:14 PM, ChALkeR wrote: > Patch for the bug https://bugs.launchpad.net/qemu/+bug/661696 > > The testcase: > > $ cat test.c > #include > > extern void *x; > > int main() { >        int a; >        asm volatile ("x: fldz\n\ >        push %%edx\n\ >        fnstenv -0xc(%%esp)

[Qemu-devel] [PATCH 09/13] ahci: add -drive support

2010-11-26 Thread Alexander Graf
We need to be able to spawn new AHCI drives, so let's add AHCI support to the -drive option. Signed-off-by: Alexander Graf --- blockdev.c|6 +- blockdev.h|1 + qemu-common.h |2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.c inde

[Qemu-devel] [PATCH 13/13] config: add ahci for pci capable machines

2010-11-26 Thread Alexander Graf
This patch enables AHCI for all machines supporting PCI. Signed-off-by: Alexander Graf --- default-configs/pci-devices.mak |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/default-configs/pci-devices.mak b/default-configs/pci-devices.mak index b3a55bf..9dac2b4 100644 ---

[Qemu-devel] [PATCH 12/13] config: add generic pci config file

2010-11-26 Thread Alexander Graf
Currently we list PCI devices in every PCI capable architecture individually. This is cumbersome when adding new devices and prone to failure because one might miss out on one. So let's instead have a generic PCI configuration file where people can throw in their cross-platform compatible PCI devi

[Qemu-devel] [PATCH 08/13] ahci: add ahci emulation

2010-11-26 Thread Alexander Graf
This patch adds an emulation layer for an ICH-7M AHCI controller. For now this controller does not do IDE legacy emulation. It is a pure AHCI controller. Signed-off-by: Alexander Graf --- v1 -> v2: - rename IDEExtender to IDEBusOps and make a pointer (kraxel) - make dma hooks explicit by p

[Qemu-devel] [PATCH 05/13] ide: add ncq identify data for ahci sata drives

2010-11-26 Thread Alexander Graf
From: Roland Elek I modified ide_identify() to include the zero-based queue length value in word 75, and set bit 8 in word 76 to signal NCQ support in the identify data for AHCI SATA drives. Signed-off-by: Roland Elek --- hw/ide/core.c |7 +++ hw/ide/internal.h |2 ++ 2 files c

[Qemu-devel] [PATCH 07/13] pci: add ich7 pci id

2010-11-26 Thread Alexander Graf
We need a PCI ID for our new AHCI adapter. I just picked an ICH-7M because that's the one built into the first Macbooks. This patch adds a PCI ID define for an ICH-7M AHCI adapter. Signed-off-by: Alexander Graf --- v3 -> v4: - add ICH7 instead of ICH7M (herbszt) v4 -> v5: - rename to IC

[Qemu-devel] [PATCH 10/13] ahci: spawn controller on demand

2010-11-26 Thread Alexander Graf
When we add a device using -drive to the guest, we also need to create a new SATA bus to handle the device. This patch adds a function call that every machine that likes to have IF_SATA support can call to get full device creation by keeping the actual qdev code clean. Signed-off-by: Alexander Gra

[Qemu-devel] [PATCH 06/13] pci: add storage class for sata

2010-11-26 Thread Alexander Graf
This patch adds the storage sata class id. Signed-off-by: Alexander Graf --- hw/pci_ids.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pci_ids.h b/hw/pci_ids.h index 82cba7e..ea3418c 100644 --- a/hw/pci_ids.h +++ b/hw/pci_ids.h @@ -15,6 +15,7 @@ #define PCI_CLAS

[Qemu-devel] [PATCH 03/13] ide: add support for ide bus ops

2010-11-26 Thread Alexander Graf
From: Roland Elek We need to hook into some of the core IDE functionality for AHCI. To do that, the easiest way is to make explicit functions calls be implicit through a function call struct. Signed-off-by: Roland Elek Signed-off-by: Alexander Graf --- v1 -> v2: - rename IDEExtender to ID

[Qemu-devel] [PATCH 04/13] ide: add DMA hooks to bus ops

2010-11-26 Thread Alexander Graf
For DMA operations, we need to hook into even more IDE functionality. This patch adds the respective hooking points, allowing us to handle SG lists ourselves in the AHCI code. Signed-off-by: Roland Elek Signed-off-by: Alexander Graf --- v1 -> v2: - make dma hooks explicit by putting them i

[Qemu-devel] [PATCH 01/13] ide: split ide command interpretation off

2010-11-26 Thread Alexander Graf
The ATA command interpretation code can be used for PATA and SATA interfaces alike. So let's split it out into a separate function. Signed-off-by: Alexander Graf --- hw/ide/core.c | 20 ++-- hw/ide/internal.h |2 ++ 2 files changed, 16 insertions(+), 6 deletions(-) dif

Re: [Qemu-devel] [RFC] Static instrumentation (aka guest code tracing)

2010-11-26 Thread Paul Brook
> 2) instrumenting i386 is extremely time-consuming (for the developer) > > As my work is not tied to a specific target architecture, I was thinking of > shifting into PPC, as the ISA is pretty regular and that would certainly > make the process easier by just patching a small set of places in the

Re: [Qemu-devel] [PATCH 1/6] usb-ccid: add CCID bus

2010-11-26 Thread Blue Swirl
On Thu, Nov 25, 2010 at 4:22 PM, Alon Levy wrote: > A CCID device is a smart card reader. It is a USB device, defined at [1]. > This patch introduces the usb-ccid device that is a ccid bus. Next patches > will > introduce two card types to use it, a passthru card and an emulated card. > >  [1] ht

Re: [Qemu-devel] [PATCH 4/6] libcaccard: update configure to build and use internal libcaccard

2010-11-26 Thread Blue Swirl
On Thu, Nov 25, 2010 at 4:22 PM, Alon Levy wrote: > Signed-off-by: Alon Levy > --- >  Makefile            |    6 -- >  Makefile.objs       |    5 + >  Makefile.target     |    2 ++ >  configure           |   24 >  libcaccard/Makefile |   18 ++ >  5

[Qemu-devel] Re: [PATCH 00/15] [RFC] MMIO endianness cleanup

2010-11-26 Thread Alexander Graf
On 26.11.2010, at 19:44, Blue Swirl wrote: > On Thu, Nov 25, 2010 at 7:35 AM, Alexander Graf wrote: >> The way mmio endianness is currently implemented is horrifying. >> >> In the real world, CPUs have an endianness and write out data >> to the memory bus. Instead of RAM, a receiving side here

[Qemu-devel] Re: [PATCH 00/15] [RFC] MMIO endianness cleanup

2010-11-26 Thread Blue Swirl
On Thu, Nov 25, 2010 at 7:35 AM, Alexander Graf wrote: > The way mmio endianness is currently implemented is horrifying. > > In the real world, CPUs have an endianness and write out data > to the memory bus. Instead of RAM, a receiving side here can be > a device. This device gets a byte stream ag

Re: [Qemu-devel] [PATCH 00/21] Kemari for KVM 0.2

2010-11-26 Thread Blue Swirl
On Thu, Nov 25, 2010 at 6:06 AM, Yoshiaki Tamura wrote: > Hi, > > This patch series is a revised version of Kemari for KVM, which > applied comments for the previous post and KVM Forum 2010.  The > current code is based on qemu.git > f711df67d611e4762966a249742a5f7499e19f99. > > For general inform

[Qemu-devel] Re: [PATCH 10/11] ahci: spawn controller on demand

2010-11-26 Thread Blue Swirl
On Thu, Nov 25, 2010 at 7:07 AM, Alexander Graf wrote: > When we add a device using -drive to the guest, we also need to create a > new SATA bus to handle the device. This patch adds a function call that > every machine that likes to have IF_SATA support can call to get full > device creation by k

[Qemu-devel] [PATCH 6/7] usb-linux: We only need to keep track of 15 endpoints

2010-11-26 Thread Hans de Goede
Currently we reserve room for endpoint data for 16 endpoints, but given that we only use endpoint data for endpoints 1-15, and always index the array with the endpoint-number - 1, 15 is enough. Signed-off-by: Hans de Goede --- usb-linux.c |6 +++--- 1 files changed, 3 insertions(+), 3 deleti

[Qemu-devel] [PATCH 7/7] usb-linux: Add support for buffering iso out usb packets

2010-11-26 Thread Hans de Goede
Extend the iso buffering code to also buffer iso out packets, this fixes for example using usb speakers with usb redirection. Signed-off-by: Hans de Goede --- usb-linux.c | 152 +++ 1 files changed, 101 insertions(+), 51 deletions(-) diff

[Qemu-devel] [PATCH 5/7] usb-linux: Refuse iso packets when max packet size is 0 (alt setting 0)

2010-11-26 Thread Hans de Goede
Refuse iso usb packets when then max packet size for the endpoint is 0, this avoids an abort in usb_host_alloc_iso() caused by trying to qemu_malloc a 0 bytes large buffer. --- usb-linux.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index

[Qemu-devel] [PATCH 3/7] usb-linux: Add support for buffering iso usb packets

2010-11-26 Thread Hans de Goede
Currently we are submitting iso packets to the host one at a time, as we receive them from the emulated host controller. This has 2 problems: 1) If we were fast enough to submit every packet in time for the next host host controller usb frame, we would be generating 1000 hardware interrupts per sec

[Qemu-devel] [PATCH 4/7] usb-linux: Refuse packets for endpoints which are not in the usb descriptor

2010-11-26 Thread Hans de Goede
If an endpoint is not in the usb descriptor we've no idea what kind of endpoint it is and thus how to handle it, refuse packages in this case. Signed-off-by: Hans de Goede --- usb-linux.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/usb-linux.c b/usb-linu

[Qemu-devel] [PATCH 2/7] usb-linux: Get the alt. setting from sysfs rather then asking the dev

2010-11-26 Thread Hans de Goede
At least one device I have lies when receiving a USB_REQ_GET_INTERFACE, always returning 0 even if the alternate setting is different. This is likely caused because in practice this control message is never used as the operating system's usb stack knows which alternate setting it has told the devic

[Qemu-devel] [PATCH 1/7] usb-linux: introduce a usb_linux_alt_setting function

2010-11-26 Thread Hans de Goede
The next patch in this series introduces multiple ways to get the alt setting dependent upon usb_fs_type, it is cleaner to put this into its own function. Note that this patch also changes the assumed alt setting in case of an error getting the alt setting to be 0 (a sane default) rather then the

Re: [Qemu-devel] [PATCH] raw-posix: raw_pwrite comment fixup

2010-11-26 Thread Kevin Wolf
Am 26.11.2010 14:32, schrieb Christoph Hellwig: > Signed-off-by: Christoph Hellwig > > Index: qemu/block/raw-posix.c > === > --- qemu.orig/block/raw-posix.c 2010-11-26 14:27:44.156253530 +0100 > +++ qemu/block/raw-posix.c20

[Qemu-devel] Re: [PATCH 4/4] ide: Reset current_addr after stopping DMA

2010-11-26 Thread Stefan Hajnoczi
On Fri, Nov 26, 2010 at 4:21 PM, Kevin Wolf wrote: > Whenever SSBM is reset in the command register all state information is lost. > Restarting DMA means that current_addr must be reset to the base address of > the > PRD table. The OS is not required to change the base address register before > s

[Qemu-devel] Re: [PATCH 3/4] ide: Ignore double DMA transfer starts/stops

2010-11-26 Thread Stefan Hajnoczi
On Fri, Nov 26, 2010 at 4:21 PM, Kevin Wolf wrote: > You can only start a DMA transfer if it's not running yet, and you can only > cancel it if it's running. > > Signed-off-by: Kevin Wolf > --- >  hw/ide/pci.c |   60 ++--- >  1 files changed, 32

[Qemu-devel] Re: [PATCH 2/4] ide: Set bus master inactive on error

2010-11-26 Thread Stefan Hajnoczi
On Fri, Nov 26, 2010 at 4:21 PM, Kevin Wolf wrote: > BMIDEA in the status register must be cleared on error. This makes FreeBSD > respond (more) correctly to I/O errors. > > Signed-off-by: Kevin Wolf > --- >  hw/ide/core.c |    2 ++ >  1 files changed, 2 insertions(+), 0 deletions(-) Reviewed-by

[Qemu-devel] Re: [PATCH 1/4] ide: Factor ide_dma_set_inactive out

2010-11-26 Thread Stefan Hajnoczi
On Fri, Nov 26, 2010 at 4:21 PM, Kevin Wolf wrote: > Several places that stop a DMA transfer duplicate this code. Factor it out > into > a common function. > > Signed-off-by: Kevin Wolf > --- >  hw/ide/core.c |   29 + >  1 files changed, 13 insertions(+), 16 deletions

Re: [Qemu-devel] CFP: 1st International QEMU Users Forum

2010-11-26 Thread wolfgang mueller
Dear Peter, this is really great news. In this case is it possible to do the introductionary talk of the workshop with a QEMU overview. People are here interested in QEMU CPU (and evtl. device) emulation. Most of the attending people from industry (!) and universities will have ARM background/

[Qemu-devel] [PATCH 4/4] ide: Reset current_addr after stopping DMA

2010-11-26 Thread Kevin Wolf
Whenever SSBM is reset in the command register all state information is lost. Restarting DMA means that current_addr must be reset to the base address of the PRD table. The OS is not required to change the base address register before starting a DMA operation, it can reuse the value it wrote for an

[Qemu-devel] [PATCH 2/4] ide: Set bus master inactive on error

2010-11-26 Thread Kevin Wolf
BMIDEA in the status register must be cleared on error. This makes FreeBSD respond (more) correctly to I/O errors. Signed-off-by: Kevin Wolf --- hw/ide/core.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 7136ade..430350f 100644 ---

[Qemu-devel] [PATCH 1/4] ide: Factor ide_dma_set_inactive out

2010-11-26 Thread Kevin Wolf
Several places that stop a DMA transfer duplicate this code. Factor it out into a common function. Signed-off-by: Kevin Wolf --- hw/ide/core.c | 29 + 1 files changed, 13 insertions(+), 16 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 484e0ca..7136a

[Qemu-devel] [PATCH 3/4] ide: Ignore double DMA transfer starts/stops

2010-11-26 Thread Kevin Wolf
You can only start a DMA transfer if it's not running yet, and you can only cancel it if it's running. Signed-off-by: Kevin Wolf --- hw/ide/pci.c | 60 ++--- 1 files changed, 32 insertions(+), 28 deletions(-) diff --git a/hw/ide/pci.c b/hw/i

[Qemu-devel] [PATCH 0/4] ide: Some DMA related fixes

2010-11-26 Thread Kevin Wolf
These are some fixes for the DMA code in IDE that I came up with when debugging the crash in http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=604869 This doesn't fix the cause of the I/O errors (which is somewhere in vvfat), but rather improves how the error situation is handled. Kevin Wolf (4):

Re: [Qemu-devel] CFP: 1st International QEMU Users Forum

2010-11-26 Thread Anthony Liguori
On 11/26/2010 09:15 AM, Alexander Graf wrote: On 26.11.2010, at 15:21, Anthony Liguori wrote: On 11/26/2010 08:15 AM, Jes Sorensen wrote: I would be all in favor of this! Do you want to attach it to another conference or totally standalone? Attaching is easier logistically

Re: [Qemu-devel] [PATCH] vnc: qemu can die if the client is disconnected while updating screen

2010-11-26 Thread malc
On Fri, 26 Nov 2010, Corentin Chary wrote: > agraf reported that qemu_mutex_destroy(vs->output_mutex) was failing > in vnc_disconnect_finish() when the vnc client was disconnected while > updating the screen. > > It's because vnc_worker_thread_loop() tries to unlock the mutex while > not locked.

Re: [Xen-devel] Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-26 Thread Stefano Stabellini
On Fri, 26 Nov 2010, Kevin Wolf wrote: > Am 24.11.2010 19:44, schrieb Christoph Hellwig: > > On Wed, Nov 24, 2010 at 10:18:40AM -0800, Jeremy Fitzhardinge wrote: > >> Linux wants is a useful thing to do and implement (especially since it > >> amounts to standardising the ?BSD extension). I'm not s

Re: [Qemu-devel] CFP: 1st International QEMU Users Forum

2010-11-26 Thread Alexander Graf
On 26.11.2010, at 15:21, Anthony Liguori wrote: > On 11/26/2010 08:15 AM, Jes Sorensen wrote: >> I would be all in favor of this! Do you want to attach it to another >> conference or totally standalone? >> > > Attaching is easier logistically but I don't know how much that helps if it's > a

[Qemu-devel] [PATCH] vnc: qemu can die if the client is disconnected while updating screen

2010-11-26 Thread Corentin Chary
agraf reported that qemu_mutex_destroy(vs->output_mutex) was failing in vnc_disconnect_finish() when the vnc client was disconnected while updating the screen. It's because vnc_worker_thread_loop() tries to unlock the mutex while not locked. The unlocking call doesn't fail (pthread bug ?), but the

Re: [Qemu-devel] CFP: 1st International QEMU Users Forum

2010-11-26 Thread Alexander Graf
On 26.11.2010, at 16:10, Peter Maydell wrote: > On 26 November 2010 14:21, Anthony Liguori wrote: > >> But the key point is breadth, it should not be a "KVM Forum" but rather an >> Open Virtualization conference with topics as high level as cloud software >> automation and as low level as async

Re: [Qemu-devel] CFP: 1st International QEMU Users Forum

2010-11-26 Thread Alexander Graf
On 26.11.2010, at 15:33, Peter Maydell wrote: > On 26 November 2010 13:54, Alexander Graf wrote: >> On 25.11.2010, at 15:54, wolfgang mueller wrote: >>> the people we are addressing and we would like to bring together is from >>> the QEMU emulation community. >>> We are interested in running di

Re: [Qemu-devel] CFP: 1st International QEMU Users Forum

2010-11-26 Thread Peter Maydell
On 26 November 2010 14:21, Anthony Liguori wrote: > But the key point is breadth, it should not be a "KVM Forum" but rather an > Open Virtualization conference with topics as high level as cloud software > automation and as low level as asynchronous page faults :-) Does that breadth include the

Re: [Qemu-devel] CFP: 1st International QEMU Users Forum

2010-11-26 Thread Peter Maydell
On 26 November 2010 13:54, Alexander Graf wrote: > On 25.11.2010, at 15:54, wolfgang mueller wrote: >> the people we are addressing and we would like to bring together is from the >> QEMU emulation community. >> We are interested in running different ISAs mainly under Linux and Windows >> versio

Re: [Qemu-devel] CFP: 1st International QEMU Users Forum

2010-11-26 Thread Anthony Liguori
On 11/26/2010 08:15 AM, Jes Sorensen wrote: I would be all in favor of this! Do you want to attach it to another conference or totally standalone? Attaching is easier logistically but I don't know how much that helps if it's a full 3 days instead of just a single day. Might be worth pokin

Re: [Qemu-devel] CFP: 1st International QEMU Users Forum

2010-11-26 Thread Jes Sorensen
On 11/26/10 15:13, Anthony Liguori wrote: > On 11/26/2010 07:39 AM, Alexander Graf wrote: >> >> I can certainly get in touch with the organizers, but I can't answer >> the latter question. There are usually at least ~10-20 kernel >> developers around and it's easy to get most of the German qemu peo

Re: [Qemu-devel] CFP: 1st International QEMU Users Forum

2010-11-26 Thread Anthony Liguori
On 11/26/2010 07:39 AM, Alexander Graf wrote: I can certainly get in touch with the organizers, but I can't answer the latter question. There are usually at least ~10-20 kernel developers around and it's easy to get most of the German qemu people there too I assume (which is quite a significa

Re: [Qemu-devel] CFP: 1st International QEMU Users Forum

2010-11-26 Thread Alexander Graf
On 25.11.2010, at 15:54, wolfgang mueller wrote: > Alexander, > the people we are addressing and we would like to bring together is from the > QEMU emulation community. > We are interested in running different ISAs mainly under Linux and Windows > versions. There is a huge additional > interest

Re: [Qemu-devel] CFP: 1st International QEMU Users Forum

2010-11-26 Thread Alexander Graf
On 26.11.2010, at 13:29, Jes Sorensen wrote: > On 11/26/10 12:53, Alexander Graf wrote: >> >> On 26.11.2010, at 08:56, Jes Sorensen wrote: >>> Doing a get together somewhere in Europe really shouldn't be that hard >>> to organize, however it would probably be useful to have it attached to >>> a

[Qemu-devel] [PATCH] raw-posix: raw_pwrite comment fixup

2010-11-26 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig Index: qemu/block/raw-posix.c === --- qemu.orig/block/raw-posix.c 2010-11-26 14:27:44.156253530 +0100 +++ qemu/block/raw-posix.c 2010-11-26 14:27:59.812272461 +0100 @@ -463,7 +463,7 @@ static int

Re: [Xen-devel] Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-26 Thread Christoph Hellwig
On Fri, Nov 26, 2010 at 12:03:35PM +0100, Kevin Wolf wrote: > I don't think the synchronous flushes even do what they're supposed to > do. Shouldn't ioreq->postsync do the flush after the request has > completed instead of doing it as soon as it has been submitted? Indeed, that's yet another bug i

Re: [Qemu-devel] CFP: 1st International QEMU Users Forum

2010-11-26 Thread Jes Sorensen
On 11/26/10 12:53, Alexander Graf wrote: > > On 26.11.2010, at 08:56, Jes Sorensen wrote: >> Doing a get together somewhere in Europe really shouldn't be that hard >> to organize, however it would probably be useful to have it attached to >> a bigger conference to help with the logistics. There is

Re: [Xen-devel] Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-26 Thread Kevin Wolf
Am 24.11.2010 19:44, schrieb Christoph Hellwig: > On Wed, Nov 24, 2010 at 10:18:40AM -0800, Jeremy Fitzhardinge wrote: >> Linux wants is a useful thing to do and implement (especially since it >> amounts to standardising the ?BSD extension). I'm not sure of their >> precise semantics (esp WRT orde

[Qemu-devel] Patch: fix FSTENV (and FSAVE) instructions in target-i386 (resend, cleaned up).

2010-11-26 Thread ChALkeR
Patch for the bug https://bugs.launchpad.net/qemu/+bug/661696 The testcase: $ cat test.c #include extern void *x; int main() { int a; asm volatile ("x: fldz\n\ push %%edx\n\ fnstenv -0xc(%%esp)\n\ pop %%edx\n" : "=d" (a) : : "memory"); printf ("%

Re: [Qemu-devel] [Patch] Small fix for qemu APIC for Mac OS X support

2010-11-26 Thread Isaku Yamahata
On Thu, Nov 25, 2010 at 08:18:45PM +, adq wrote: > On 25 November 2010 11:28, Isaku Yamahata wrote: > > On Wed, Nov 24, 2010 at 02:08:16PM +, adq wrote: > >> > Interesting. I was also thinking that maybe we can leverage overriding > >> > mechanisms that are already available. Maybe it's p

Re: [Qemu-devel] [Patch] Small fix for qemu APIC for Mac OS X support

2010-11-26 Thread Isaku Yamahata
On Thu, Nov 25, 2010 at 08:18:45PM +, adq wrote: > On 25 November 2010 11:28, Isaku Yamahata wrote: > > On Wed, Nov 24, 2010 at 02:08:16PM +, adq wrote: > >> > Interesting. I was also thinking that maybe we can leverage overriding > >> > mechanisms that are already available. Maybe it's p

Re: [Qemu-devel] [patch 0/2] USB UHCI global suspend / remote wakeup

2010-11-26 Thread Paul Brook
> On 11/26/10 03:15, Marcelo Tosatti wrote: > > On Fri, Nov 26, 2010 at 12:38:28AM +, Paul Brook wrote: > >>> This patch enables USB UHCI global suspend/resume feature. The OS will > >>> stop the HC once all ports are suspended. If there is activity on the > >>> port(s), an interrupt signalling

[Qemu-devel] [PATCH] pci: make command SERR bit writable

2010-11-26 Thread Isaku Yamahata
pcie aer wants SERR bit to be writable. So make it writable. For compatibility, introduce compat global property command_serr_enable and don't make it writable when pre 0.14 pc machine. Signed-off-by: Isaku Yamahata --- This patch depends on b1d6dd8ce83e1430b7b0e98c898499a966464227 which is in up

Re: [Qemu-devel] CFP: 1st International QEMU Users Forum

2010-11-26 Thread Alexander Graf
On 26.11.2010, at 08:56, Jes Sorensen wrote: > On 11/26/10 00:48, Alexander Graf wrote: >> >> On 25.11.2010, at 23:53, Andreas Färber wrote: >> From the fosdem homepage: >> >> We would like to inform all interested parties that the call for devrooms >> is running at its end. >> Coming Saturd

[Qemu-devel] Patch: fix FSTENV (and FSAVE) instructions in target-i386.

2010-11-26 Thread ChALkeR
Patch for the bug https://bugs.launchpad.net/qemu/+bug/661696 Testcase: #include extern void *x; int main() { int a; asm volatile ("x: fldz\n\ push %%edx\n\ fnstenv -0xc(%%esp)\n\ pop %%edx\n" : "=d" (a) : : "memory"); printf ("%x %x\n", a, &x); return 0; } $ gcc -m32 test.

Re: [Qemu-devel] [Bug 681613] Re: Failed to convert vmdk on MacOSX ppc

2010-11-26 Thread Stefan Hajnoczi
On Fri, Nov 26, 2010 at 7:33 AM, Masaki Muranaka <681...@bugs.launchpad.net> wrote: > Oops, there seems to be something wrong with my patch. I'll do > additional fix. Please send the patch to qemu-devel@nongnu.org instead of uploading it to launchpad, it'll get more developer attention. The stand

Re: [Qemu-devel] [patch 0/2] USB UHCI global suspend / remote wakeup

2010-11-26 Thread Gerd Hoffmann
On 11/26/10 03:15, Marcelo Tosatti wrote: On Fri, Nov 26, 2010 at 12:38:28AM +, Paul Brook wrote: This patch enables USB UHCI global suspend/resume feature. The OS will stop the HC once all ports are suspended. If there is activity on the port(s), an interrupt signalling remote wakeup will b

Re: [Qemu-devel] [PATCH] Make SCSI HBA configurable

2010-11-26 Thread Jes Sorensen
On 11/25/10 14:22, Paul Brook wrote: >> On 25.11.2010, at 11:59, Paul Brook wrote: >> RH needs to compile out as much as they can from the code base, because >> they state that they support everything that's compiled in. So making as >> much as possible optional is good. And I don't see why we shou