Re: [Qemu-devel] [RFC] Can we remove special handling of standard headers (introduced for dyngen / OSX?)

2010-10-09 Thread Andreas Färber
Am 04.10.2010 um 21:29 schrieb Stefan Weil: Am 25.09.2010 09:46, schrieb Blue Swirl: On Thu, Sep 23, 2010 at 8:44 PM, Stefan Weil wrote: Am 23.09.2010 22:33, schrieb Blue Swirl: On Thu, Sep 23, 2010 at 7:28 PM, Stefan Weil wrote: Replace the remaining format attribute printf by macro

[Qemu-devel] Re: [HaikuPorts-devs] [PATCH] trace: Adapt trace file name for Haiku

2010-10-09 Thread Ingo Weinhold
On 2010-10-09 at 21:55:17 [+0200], Andreas Färber wrote: > Resolves the following warning: > > CCsimpletrace.o > /Data/QEMU/qemu/simpletrace.c: In function 'st_set_trace_file': > /Data/QEMU/qemu/simpletrace.c:77: warning: format '%u' expects type > 'unsigned int', but argument 3 has type

Re: [Qemu-devel] [PATCH, RFC] Sparc: convert some debug printf statements to tracepoints

2010-10-09 Thread Blue Swirl
On Sat, Oct 9, 2010 at 6:33 PM, Andreas Färber wrote: > Am 09.10.2010 um 18:00 schrieb Andreas Färber: > >> Am 09.10.2010 um 17:46 schrieb Blue Swirl: >> >>> On Sat, Oct 9, 2010 at 3:35 PM, Andreas Färber >>> wrote: Am 09.10.2010 um 17:10 schrieb Blue Swirl: > Replace some debu

[Qemu-devel] [PATCH] trace: Adapt trace file name for Haiku

2010-10-09 Thread Andreas Färber
Resolves the following warning: CCsimpletrace.o /Data/QEMU/qemu/simpletrace.c: In function 'st_set_trace_file': /Data/QEMU/qemu/simpletrace.c:77: warning: format '%u' expects type 'unsigned int', but argument 3 has type 'pid_t' Cc: Stefan Hajnoczi Cc: Blue Swirl Signed-off-by: Andreas Fä

Re: [Qemu-devel] [PATCH, RFC] Sparc: convert some debug printf statements to tracepoints

2010-10-09 Thread Andreas Färber
Am 09.10.2010 um 18:00 schrieb Andreas Färber: Am 09.10.2010 um 17:46 schrieb Blue Swirl: On Sat, Oct 9, 2010 at 3:35 PM, Andreas Färber > wrote: Am 09.10.2010 um 17:10 schrieb Blue Swirl: Replace some debug printf statements with tracepoints. Signed-off-by: Blue Swirl --- I think tracing

Re: [Qemu-devel] [PATCH, RFC] Sparc: convert some debug printf statements to tracepoints

2010-10-09 Thread Andreas Färber
Am 09.10.2010 um 17:46 schrieb Blue Swirl: On Sat, Oct 9, 2010 at 3:35 PM, Andreas Färber wrote: Am 09.10.2010 um 17:10 schrieb Blue Swirl: Replace some debug printf statements with tracepoints. Signed-off-by: Blue Swirl --- I think tracing way is more flexible than current conditional

Re: [Qemu-devel] [PATCH -v5] ceph/rbd block driver for qemu-kvm

2010-10-09 Thread Yehuda Sadeh Weinraub
On Sat, Oct 9, 2010 at 2:21 AM, Stefan Hajnoczi wrote: > On Fri, Oct 8, 2010 at 8:00 PM, Yehuda Sadeh wrote: > No flush operation is supported.  Can the guest be sure written data > is on stable storage when it receives completion? > That's part of the consistency that rados provides. >> +/* >>

[Qemu-devel] [PATCH] trace: print a warning if user tries to enable an unknown trace event

2010-10-09 Thread Blue Swirl
There was no warning if a bad trace event name was given to 'trace-event' command, thus the user could think that the command was successful even if this was not the case. Print a warning if the user tries to enable a trace event which is not known. Signed-off-by: Blue Swirl --- monitor.c |

Re: [Qemu-devel] [PATCH, RFC] Sparc: convert some debug printf statements to tracepoints

2010-10-09 Thread Blue Swirl
On Sat, Oct 9, 2010 at 3:35 PM, Andreas Färber wrote: > Am 09.10.2010 um 17:10 schrieb Blue Swirl: > >> Replace some debug printf statements with tracepoints. >> >> Signed-off-by: Blue Swirl >> --- >> I think tracing way is more flexible than current conditional code. I >> remember wading through

Re: [Qemu-devel] [PATCH, RFC] Sparc: convert some debug printf statements to tracepoints

2010-10-09 Thread Andreas Färber
Am 09.10.2010 um 17:10 schrieb Blue Swirl: Replace some debug printf statements with tracepoints. Signed-off-by: Blue Swirl --- I think tracing way is more flexible than current conditional code. I remember wading through hundreds of megs of DPRINTF output looking for a clue about a specific e

[Qemu-devel] [PATCH, RFC] Sparc: convert some debug printf statements to tracepoints

2010-10-09 Thread Blue Swirl
Replace some debug printf statements with tracepoints. Signed-off-by: Blue Swirl --- I think tracing way is more flexible than current conditional code. I remember wading through hundreds of megs of DPRINTF output looking for a clue about a specific event, so being able to control the trace dynam

[Qemu-devel] Re: [Bug 657329] [NEW] APIC unusable on QEMU

2010-10-09 Thread Jan Kiszka
Am 09.10.2010 15:51, Geoffrey Lee wrote: > Public bug reported: > > The APIC is unusable with QEMU using x86-64 system emulation. Problem > exists in the latest stable QEMU 0.12.5 as well as the latest git head. > I am using Mac OS X 10.6, 64-bit version of QEMU. > > The QEMU binary was configur

Re: [Qemu-devel] Re: [PATCH 05/11] Delete write only variables

2010-10-09 Thread Alexander Graf
Am 09.10.2010 um 16:27 schrieb Andreas Färber : > Am 08.10.2010 um 20:06 schrieb Blue Swirl: > >> On Fri, Oct 8, 2010 at 5:30 PM, Alexander Graf wrote: >>> >>> On 08.10.2010, at 19:28, Paolo Bonzini wrote: >>> On 10/07/2010 07:24 PM, Blue Swirl wrote: >>> On 10/06/2010 11:32 PM, Blue

Re: [Qemu-devel] Re: [PATCH 05/11] Delete write only variables

2010-10-09 Thread Andreas Färber
Am 08.10.2010 um 20:06 schrieb Blue Swirl: On Fri, Oct 8, 2010 at 5:30 PM, Alexander Graf wrote: On 08.10.2010, at 19:28, Paolo Bonzini wrote: On 10/07/2010 07:24 PM, Blue Swirl wrote: On 10/06/2010 11:32 PM, Blue Swirl wrote: @@ -91,8 +90,6 @@ static int vga_osi_call (CPUState *env)

[Qemu-devel] [Bug 642304] Re: Solaris/x86 v10 hangs under KVM

2010-10-09 Thread Nigel Horne
1: If you can give instructions on how to get a version number for kvm on Debian I'll follow them. "dpkg -l | fgrep kvm" lists nothing. 2: I'm using the qemu git tree. 3: Why are you asking? Are you saying that enable-io-thread is broken with --enable-kvm? -- Solaris/x86 v10 hangs under KVM

[Qemu-devel] [Bug 657329] [NEW] APIC unusable on QEMU

2010-10-09 Thread Geoffrey Lee
Public bug reported: The APIC is unusable with QEMU using x86-64 system emulation. Problem exists in the latest stable QEMU 0.12.5 as well as the latest git head. I am using Mac OS X 10.6, 64-bit version of QEMU. The QEMU binary was configured with: ./configure --target-list=i386-softmmu,x86_6

Re: [Qemu-devel] qdev "SUNW,fdtwo" is unusable with -device

2010-10-09 Thread Andreas Färber
Am 09.10.2010 um 12:09 schrieb Markus Armbruster: Commit 12a71a02 created qdev "SUNW,fdtwo". It can't be named in -device, because the name contains a comma: "-device SUNW,fdtwo" gets parsed as driver SUNW with property fdtwo. Calls for an escape mechanism then. :) Andreas Is this device u

Re: [Qemu-devel] Handling patch queues (was: [STATUS] static instrumentation)

2010-10-09 Thread Andreas Färber
Am 08.10.2010 um 18:53 schrieb Blue Swirl: On Thu, Oct 7, 2010 at 8:34 PM, Lluís wrote: Blue Swirl writes: The patches there seem to be fixes or small changes to your other patches. This makes any review very difficult. Sorry, I'm really new to git, so I don't really know how to maintain

[Qemu-devel] Re: qdev "SUNW,fdtwo" is unusable with -device

2010-10-09 Thread Blue Swirl
On Sat, Oct 9, 2010 at 10:09 AM, Markus Armbruster wrote: > Commit 12a71a02 created qdev "SUNW,fdtwo".  It can't be named in > -device, because the name contains a comma: "-device SUNW,fdtwo" gets > parsed as driver SUNW with property fdtwo. > > Is this device user-configurable?  Or should no_user

[Qemu-devel] qdev "SUNW,fdtwo" is unusable with -device

2010-10-09 Thread Markus Armbruster
Commit 12a71a02 created qdev "SUNW,fdtwo". It can't be named in -device, because the name contains a comma: "-device SUNW,fdtwo" gets parsed as driver SUNW with property fdtwo. Is this device user-configurable? Or should no_user be set? Regardless, can we have a more user-friendly name?

Re: [Qemu-devel] [PATCH v2] configure: Send error message from spice check to /dev/null

2010-10-09 Thread Blue Swirl
Thanks, applied. On Thu, Oct 7, 2010 at 7:15 PM, Stefan Weil wrote: > pkg-config is not always available (e.g. on win32 hosts), > but we don't want to see the 'command not found' error message. > > Redirect stdout and stderr to /dev/null. > > v2: > > * Removed changes which should not have been h

[Qemu-devel] Re: [PATCH] .gitignore: Ignore *-timestamp

2010-10-09 Thread Blue Swirl
Thanks, applied. I also applied a patch to remove the timestamp files. On Thu, Oct 7, 2010 at 11:07 AM, Stefan Hajnoczi wrote: > Timestamp files were recently added to reduce make churn on source files > that use tracing.  The timestamp files should never be committed and > should not be visible

Re: [Qemu-devel] [PATCH] acpi: Fix an infinite loop in acpi_table_add

2010-10-09 Thread Blue Swirl
Thanks, applied. On Tue, Oct 5, 2010 at 12:23 AM, Vincent Minet wrote: > Commit d729bb9a7700e364b1c5f9893d61f07a9e002bce has a typo, causing an > infinite loop in acpi_table_add. > > Signed-off-by: Vincent Minet > --- >  hw/acpi.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > >

Re: [Qemu-devel] [PATCH] configure: Remove unneeded defines from checks

2010-10-09 Thread Blue Swirl
Thanks, applied. On Wed, Oct 6, 2010 at 7:09 PM, Stefan Weil wrote: > _GNU_SOURCE is already defined in QEMU_CFLAGS which > is passed to gcc in shell function compile_prog. > > Removing the definition from several checks avoids compiler warnings > (which are now written to config.log). > > Signed

[Qemu-devel] Re: [PATCH] win32: Set unbuffered stdout

2010-10-09 Thread Blue Swirl
Thanks, applied. On Thu, Oct 7, 2010 at 4:55 PM, Stefan Weil wrote: > Win32 does not support line-buffering, but it allows > unbuffered output. > > Unbuffered output is a good approximation. For typical output > statements which usually end with '\n', it's even identical. > > Buffered output is u

Re: [Qemu-devel] [PATCH v2] configure: include stddef.h for NULL

2010-10-09 Thread Blue Swirl
Thanks, applied. On Tue, Oct 5, 2010 at 7:28 PM, Scott Wood wrote: > This fixes an observed failure to detect madvise() on Linux. > > To avoid similar issues, all other tests that use NULL but don't already > have stddef.h (or another header that is defined to provide NULL, > such as stdio.h, uni

[Qemu-devel] Re: [PATCH 1/4] trace: Use portable format strings

2010-10-09 Thread Blue Swirl
Thanks, applied all. On Tue, Oct 5, 2010 at 1:28 PM, Stefan Hajnoczi wrote: > It is not portable to use "%ld" for int64_t because int64_t may have > type long on 64-bit platforms and long long on 32-bit platforms.  Use > the standard library PRId64 macros to keep format strings portable. > > Sign

Re: [Qemu-devel] [PATCH -v5] ceph/rbd block driver for qemu-kvm

2010-10-09 Thread Stefan Hajnoczi
On Fri, Oct 8, 2010 at 8:00 PM, Yehuda Sadeh wrote: No flush operation is supported. Can the guest be sure written data is on stable storage when it receives completion? > +/* > + * This aio completion is being called from rbd_aio_event_reader() and > + * runs in qemu context. It schedules a bh,

[Qemu-devel] Re: [PATCH 11/12] ppc: avoid write only variables

2010-10-09 Thread Blue Swirl
On Fri, Oct 8, 2010 at 9:32 PM, Alexander Graf wrote: > > On 08.10.2010, at 23:25, Blue Swirl wrote: > >> Compiling with GCC 4.6.0 20100925 produced warnings: >> /src/qemu/target-ppc/op_helper.c: In function 'helper_icbi': >> /src/qemu/target-ppc/op_helper.c:351:14: error: variable 'tmp' set but >