Thanks, applied.
On Thu, 2010-09-30 at 15:23 +0200, Hannes Reinecke wrote:
> Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger
> >
> > Greetings Paul, Jan, Kevin and co,
> >
> > This series is against my v0.12.5 qemu-kvm.git that contains QEMU SCSI layer
> > SGL passthrough from Gerd Hoffman, 8708EM2 Meg
Next commit needs this new function: it will introduce the
the QMP's command dispatch table and qmp_find_cmd() will be
used to search on it.
Signed-off-by: Luiz Capitulino
---
monitor.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/monitor.c b/monitor.c
index c22
On Thu, 2010-09-30 at 10:07 +0200, Paolo Bonzini wrote:
> On 09/30/2010 07:07 AM, Nicholas A. Bellinger wrote:
> > case 0x06: /* SDID */
> > -if ((val& 0xf) != (s->ssid& 0xf))
> > -BADF("Destination ID does not match SSID\n");
> > +/*
> > + * This workaro
Calls a QObject handler and emits the QMP response, also drops
monitor_call_handler() which is now unused.
Signed-off-by: Luiz Capitulino
---
monitor.c | 39 +++
1 files changed, 15 insertions(+), 24 deletions(-)
diff --git a/monitor.c b/monitor.c
index adc
This avoids handle_user_command() calling monitor_call_handler(),
which is currently shared with QMP.
Signed-off-by: Luiz Capitulino
---
monitor.c | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/monitor.c b/monitor.c
index a48f919..adc5bbd 100644
--- a/monitor.c
Let's follow the convention introduced by the previous commit and
call it handler_is_async().
Signed-off-by: Luiz Capitulino
---
monitor.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/monitor.c b/monitor.c
index 91473f4..a48f919 100644
--- a/monitor.c
+++ b/m
That name makes no sense anymore, as dispatch tables have been split,
a better name is handler_is_qobject(), which really communicates
the handler's type.
Signed-off-by: Luiz Capitulino
---
monitor.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monito
We now iterate over QMP's dispatch tables, no need to check for
QMP-only handlers anymore.
Signed-off-by: Luiz Capitulino
---
monitor.c | 13 -
1 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/monitor.c b/monitor.c
index 7cb66df..dbf6e18 100644
--- a/monitor.c
+++ b/m
QMP has its own dispatch table and documentation file
(qmp-commands.hx), we can now drop the following QMP specific info
from qemu-monitor.hx:
o SQMP/EQMP sections
o The qmp_capabilities command
o The query-commands command
However, note that QObject handlers entries are not being rem
Also update QMP functions to use it. The table is generated
from the qmp-commands.hx file.
>From now on, QMP and HMP have different command dispatch
tables.
Signed-off-by: Luiz Capitulino
---
Makefile.target |7 +--
monitor.c | 11 +--
2 files changed, 14 insertions(+),
This is a HMP specific handler, it makes no sense to have it
under QMP.
Signed-off-by: Luiz Capitulino
---
monitor.c |5 ++---
qemu-monitor.hx |3 +--
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/monitor.c b/monitor.c
index 5b57810..c22f5d6 100644
--- a/monitor.c
The new table is a copy of HMP's table, containing only QObject
handlers.
In the near future HMP will be making QMP calls and then we will
be able to drop QObject handlers from HMP's table.
>From now on, QMP and HMP have different query command dispatch
tables.
Signed-off-by: Luiz Capitulino
--
This file contains a copy of the following information from the
qemu-monitor.hx file:
o QObject handlers entries
o QMP documentation (all SQMP/EQMP sections)
Right now it's only used to generate the QMP docs in QMP/, but
next commits will turn this into QMP's command dispatch table.
It's
As of last commit, QMP doesn't use do_info() anymore. Simplify it.
Signed-off-by: Luiz Capitulino
---
monitor.c | 39 ---
1 files changed, 8 insertions(+), 31 deletions(-)
diff --git a/monitor.c b/monitor.c
index af8bdfe..f638017 100644
--- a/monitor.c
+++
This function was only needed when QMP and HMP were sharing dispatch
tables, this is no longer true so just drop it.
Signed-off-by: Luiz Capitulino
---
monitor.c |5 -
monitor.h |1 -
2 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/monitor.c b/monitor.c
index 572752d..
If I understood it correcty, the is_async_return() logic was only
used to prevent QMP from issuing duplicated success responses
for asynchronous handlers.
However, QMP doesn't use do_info() anymore so this is dead logic
and (hopefully) can be safely dropped.
Signed-off-by: Luiz Capitulino
---
m
Since its inception, QMP has been using HMP's do_info() function
to run query commands.
This was a bad choice, as it made do_info() more complex and
contributed to couple QMP and HMP.
This commit fixes that by doing the following changes:
1. Introduce qmp_find_query_cmd() and use it to directl
Next commit will change how query commands are handled in a
way that the 'cmd' sanity check is also going to be needed
for query commands handling.
Let's move it out of the else body then.
Signed-off-by: Luiz Capitulino
---
monitor.c | 10 +-
1 files changed, 5 insertions(+), 5 deleti
QMP has its own dispatch tables, we can now drop the following
checks:
o 'info' command: this command doesn't exist in QMP's
dispatch table, the right thing will happen when it's
issued by a client (ie. command not found error)
o monitor_handler_ported(): all QMP handlers ar
On Thu, 30 Sep 2010, Stefan Weil wrote:
> The patch fixes these gcc warnings:
>
> ./hw/es1370.c: In function ?es1370_update_voices?:
> ./hw/es1370.c:411: error: format ?%d? expects type ?int?, but argument 3 has
> type ?size_t?
> ./hw/es1370.c: In function ?es1370_writel?:
> ./hw/es1370.c:579: e
It's a generic version of monitor_find_command() which searches
the dispatch table passed as an argument.
Future commits will introduce new dispatch tables, so we need
common code to search them.
Signed-off-by: Luiz Capitulino
---
monitor.c | 10 --
1 files changed, 8 insertions(+), 2
This is a respin with the following small changes:
v1 - v2:
o Renamed qemu-monitor-qmp.hx to qmp-commands.hx
o Added a new patch which renames qemu-monitor.hx to hmp-commands.hx
o Other minor changes
---
Makefile|4 +-
Makefile.target |9 +-
QMP/README |2 +-
hmp-comm
On Wed, Sep 29, 2010 at 6:09 PM, Blue Swirl wrote:
> On Tue, Sep 28, 2010 at 8:42 PM, Andreas Färber
> wrote:
>> Am 28.09.2010 um 22:24 schrieb Blue Swirl:
>>
>>> On Tue, Sep 28, 2010 at 8:02 PM, Andreas Färber
>>> wrote:
Am 28.09.2010 um 21:31 schrieb Artyom Tarasenko:
> 201
is_softmmu was removed with commit
d4c430a80f000d722bb70287af4d4c184a8d7006,
so remove it now from debug code, too.
Fix also the format specifier for paddr
in the same line of code.
Cc: Blue Swirl
Signed-off-by: Stefan Weil
---
exec.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions
Am 30.09.2010 22:09, schrieb Blue Swirl:
On Thu, Sep 30, 2010 at 7:55 PM, Stefan Weil wrote:
Am 30.09.2010 21:37, schrieb Blue Swirl:
On Thu, Sep 30, 2010 at 7:30 PM, Stefan Weil
wrote:
TARGET_FMT_lx is not allowed here, so use type casts to unsigned
(which should be large enough to hol
On Thu, Sep 30, 2010 at 7:55 PM, Stefan Weil wrote:
> Am 30.09.2010 21:37, schrieb Blue Swirl:
>>
>> On Thu, Sep 30, 2010 at 7:30 PM, Stefan Weil wrote:
>>
>>>
>>> TARGET_FMT_lx is not allowed here, so use type casts to unsigned
>>> (which should be large enough to hold typical nvram addresses).
min was unknown here, so avoid it.
Cc: Blue Swirl
Signed-off-by: Stefan Weil
---
hw/rc4030.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/hw/rc4030.c b/hw/rc4030.c
index 2231373..abbc3eb 100644
--- a/hw/rc4030.c
+++ b/hw/rc4030.c
@@ -749,7 +749,10 @@ static void
Am 30.09.2010 21:37, schrieb Blue Swirl:
On Thu, Sep 30, 2010 at 7:30 PM, Stefan Weil wrote:
TARGET_FMT_lx is not allowed here, so use type casts to unsigned
(which should be large enough to hold typical nvram addresses).
The correct format is TARGET_FMT_plx.
addr is typically
size_t needs a different format specifier, so fix this.
Cc: Blue Swirl
Signed-off-by: Stefan Weil
---
hw/mipsnet.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/mipsnet.c b/hw/mipsnet.c
index a95b3ce..c5e54ff 100644
--- a/hw/mipsnet.c
+++ b/hw/mipsnet.c
@@ -81,7 +
On Thu, Sep 30, 2010 at 7:30 PM, Stefan Weil wrote:
> TARGET_FMT_lx is not allowed here, so use type casts to unsigned
> (which should be large enough to hold typical nvram addresses).
The correct format is TARGET_FMT_plx.
TARGET_FMT_lx is not allowed here, so use type casts to unsigned
(which should be large enough to hold typical nvram addresses).
./hw/ds1225y.c:48:35: error: attempt to use poisoned "TARGET_FMT_lx"
./hw/ds1225y.c: In function ‘nvram_readb’:
./hw/ds1225y.c:48: error: expected ‘)’ before ‘TARGET_FMT
On Thu, Sep 30, 2010 at 6:28 PM, Roman Franchuk
<652...@bugs.launchpad.net> wrote:
> Public bug reported:
>
> I tried to use debian for sparc. I downloaded Debain Lenny 5.06 sparc netinst
> (file name: debian-506-sparc-netinst.iso). I tried to boot it by command:
> qemu-system-sparc -cdrom debian-
On 9/30/2010 2:13 AM, Stefan Hajnoczi wrote:
On Thu, Sep 30, 2010 at 1:50 AM, Venkateswararao Jujjuri (JV)
wrote:
Code: Mainline QEMU (git://git.qemu.org/qemu.git)
Machine: LS21 blade.
Disk: Local disk through VirtIO.
Did not select any cache option. Defaulting to writethrough.
Command tested
Fix this compiler warning:
./block/vvfat.c:2285: error: comparison of unsigned expression >= 0 is always
true
Cc: Blue Swirl
Cc: Kevin Wolf
Signed-off-by: Stefan Weil
---
block/vvfat.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index
The patch fixes these gcc warnings:
./hw/es1370.c: In function ‘es1370_update_voices’:
./hw/es1370.c:411: error: format ‘%d’ expects type ‘int’, but argument 3 has
type ‘size_t’
./hw/es1370.c: In function ‘es1370_writel’:
./hw/es1370.c:579: error: format ‘%d’ expects type ‘int’, but argument 3 ha
Public bug reported:
I tried to use debian for sparc. I downloaded Debain Lenny 5.06 sparc netinst
(file name: debian-506-sparc-netinst.iso). I tried to boot it by command:
qemu-system-sparc -cdrom debian-506-sparc-netinst.iso -boot d
It printed some messages to screen. The last 2 was:
entry poin
On Thu, Sep 30, 2010 at 03:15:54PM +0200, Alexander Graf wrote:
> Edgar E. Iglesias wrote:
> > v2:
> > * Address review comments from A. Graf.
> >
> > Edgar E. Iglesias (2):
> > powerpc: Add a ppc-440x5 Xilinx model
> > powerpc: Add a virtex5 ml507 refdesign board
> >
> > Makefile.target
On Thu, Sep 30, 2010 at 06:45:18PM +0200, Stefan Weil wrote:
> Am 29.09.2010 22:30, schrieb Edgar E. Iglesias:
> > On Wed, Sep 29, 2010 at 09:59:55PM +0200, Stefan Weil wrote:
> >
> >> I reviewed the latest sources of Linux, FreeBSD and NetBSD.
> >> They all reset the multiple IA bit (multi_ia
Am 20.09.2010 15:11, schrieb Stefan Hajnoczi:
The console_select() function does not check that active_console is
non-NULL before dereferencing it. When invoked with qemu -nodefaults it
is possible to hit this case.
This patch checks that active_console is non-NULL before stashing away
the old c
Hi, thanks for replying, this seems to have fixed itself for some odd
reason! I was able to successfully install XP earlier on today. I
also didn't notice the forums until ealier on today (they are under
Links on the wiki page and not Message boards) which would have been a
more appropriate plac
Am 29.09.2010 22:30, schrieb Edgar E. Iglesias:
On Wed, Sep 29, 2010 at 09:59:55PM +0200, Stefan Weil wrote:
I reviewed the latest sources of Linux, FreeBSD and NetBSD.
They all reset the multiple IA bit (multi_ia in BSD) to zero,
but I did not find code which sets this bit to one
(like it i
Virtqueue notify is currently handled synchronously in userspace virtio.
This prevents the vcpu from executing guest code while hardware
emulation code handles the notify.
On systems that support KVM, the ioeventfd mechanism can be used to make
virtqueue notify a lightweight exit by deferring hard
Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger
>
> Greetings Paul, Jan, Kevin and co,
>
> This series is against my v0.12.5 qemu-kvm.git that contains QEMU SCSI layer
> SGL passthrough from Gerd Hoffman, 8708EM2 MegaSas emulation from Dr. Hannes
> Reinecke, and well as my own hw/scsi-bs
Edgar E. Iglesias wrote:
> v2:
> * Address review comments from A. Graf.
>
> Edgar E. Iglesias (2):
> powerpc: Add a ppc-440x5 Xilinx model
> powerpc: Add a virtex5 ml507 refdesign board
>
> Makefile.target|8 +
> default-configs/ppc-softmmu.mak|2 +
> default-c
There is a block I/O corner case that I don't fully understand. I'd
appreciate thoughts on the expected behavior.
At one point during a Windows Server 2008 install to an IDE disk the
guest sends a read request with overlapping sglist buffers. It looks
like this:
[0] addr=A len=4k
[1] addr=B len=
On Thu, Sep 30, 2010 at 1:50 AM, Venkateswararao Jujjuri (JV)
wrote:
> Code: Mainline QEMU (git://git.qemu.org/qemu.git)
> Machine: LS21 blade.
> Disk: Local disk through VirtIO.
> Did not select any cache option. Defaulting to writethrough.
>
> Command tested:
> 3 parallel instances of : dd if=/d
On 09/29/2010 07:04 PM, Blue Swirl wrote:
On Wed, Sep 29, 2010 at 2:38 AM, TeLeMan wrote:
GDB can not insert breakpoints on Windows Vista/7 because of the flag
-dynamicbase.
I'd suppose that is a bug in GDB, or rather a missing feature. ASLR is
automatically disabled by GDB 7, but that and "s
On 09/30/2010 07:07 AM, Nicholas A. Bellinger wrote:
case 0x06: /* SDID */
-if ((val& 0xf) != (s->ssid& 0xf))
-BADF("Destination ID does not match SSID\n");
+/*
+ * This workaround is required by the SYM8XX.ADD driver for OS/2 Warp.
+ */
+
49 matches
Mail list logo
