Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Avi Kivity
On 09/08/2010 02:15 PM, Stefan Hajnoczi wrote: 3. Metadata update reaches disk but data does not. The interesting case! The L2 table now points to a cluster which is beyond the last cluster in the image file. Remember that file size is rounded down by cluster size, so partial data writes are

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Avi Kivity
On 09/09/2010 09:45 AM, Avi Kivity wrote: A new format doesn't introduce much additional complexity. We provide image conversion tool and we can almost certainly provide an in-place conversion tool that makes the process very fast. It requires users to make a decision. By the time qed is

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Avi Kivity
On 09/08/2010 03:48 PM, Anthony Liguori wrote: On 09/08/2010 03:23 AM, Avi Kivity wrote: On 09/08/2010 01:27 AM, Anthony Liguori wrote: FWIW, L2s are 256K at the moment and with a two level table, it can support 5PB of data. I clearly suck at basic math today. The image supports 64TB toda

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Avi Kivity
On 09/09/2010 05:35 AM, Christoph Hellwig wrote: On Wed, Sep 08, 2010 at 03:28:50PM -0500, Anthony Liguori wrote: That's a good point. Is there a reasonable way to do this cooperatively with the underlying filesystem? The only thing we can do easily is to try to use as large as possible exten

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Avi Kivity
On 09/08/2010 03:55 PM, Anthony Liguori wrote: (3 levels) Dunno, just seems more regular to me. Image resize doesn't need to relocate the L2 table in case it overflows. The overhead from three levels is an extra table, which is negligible. It means an extra I/O request in the degenerate

Re: [Qemu-devel] [PATCH 4/4] cpu model corrections/updates: add verbose config file handling

2010-09-08 Thread john cooper
Blue Swirl wrote: > On Tue, Sep 7, 2010 at 12:31 PM, john cooper wrote: >> Failure by qemu to open a default config file isn't cause to >> error exit -- it just quietly continues on. After puzzling >> issues with otherwise opaque config file locations and >> startup handling numerous times, some

[Qemu-devel] Re: [PATCH v2 7/9] pcie/hotplug: glue pushing attention button command. pcie_abp

2010-09-08 Thread Isaku Yamahata
On Wed, Sep 08, 2010 at 01:34:23PM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 08, 2010 at 04:39:40PM +0900, Isaku Yamahata wrote: > > glue to pcie_abp monitor command. > > > > Signed-off-by: Isaku Yamahata > > We also need to glue the LED so it's status both is reported > and can be polled f

[Qemu-devel] [PATCH 1/3] pci: sorting out type confusion in pci_register_bar().

2010-09-08 Thread Isaku Yamahata
This patch sorts out invalid use of pcibus_t. In pci_register_bar(), pcibus_t wmask is used. It should, However, be uint64_t because it is used to set pci configuration space value(PCIDevice::wmask) by pci_set_quad() or pci_set_long(). So make its type uint64_t and cast from pcibus_t to int64_t wh

[Qemu-devel] [PATCH 3/3] pci: improve signature of pci_register_bar().

2010-09-08 Thread Isaku Yamahata
Make type uint8_t from int because PCIIORegion::type is uint8_t. Signed-off-by: Isaku Yamahata --- hw/pci.c |2 +- hw/pci.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 31eba9a..ceee291 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -758,7 +758

[Qemu-devel] [PATCH 0/3] pci: pci_register_bar() clean up

2010-09-08 Thread Isaku Yamahata
This patch set cleans up pci_register_bar() a bit. Isaku Yamahata (3): pci: sorting out type confusion in pci_register_bar(). pci: don't ignore invalid parameter for pci_register_bar(). pci: improve signature of pci_register_bar(). hw/pci.c | 11 +-- hw/pci.h |2 +- 2 files c

[Qemu-devel] [PATCH 2/3] pci: don't ignore invalid parameter for pci_register_bar().

2010-09-08 Thread Isaku Yamahata
Abort when invalid value for region_num is passed to pci_register_bar. That is caller's bug. Abort instead of silently ignoring invalid value. Signed-off-by: Isaku Yamahata --- hw/pci.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 8d6b299

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Christoph Hellwig
On Wed, Sep 08, 2010 at 03:28:50PM -0500, Anthony Liguori wrote: > That's a good point. Is there a reasonable way to do this cooperatively > with the underlying filesystem? The only thing we can do easily is to try to use as large as possible extents in the allocation. Once we're at a cuple Meg

[Qemu-devel] [PATCH 7/8] [MIPS] qdev: convert jazz irq controller to sysbus device

2010-09-08 Thread Hervé Poussineau
Use it in Jazz emulation Signed-off-by: Hervé Poussineau --- hw/mips.h |3 +- hw/mips_jazz.c | 10 +++- hw/rc4030.c| 145 +++- 3 files changed, 111 insertions(+), 47 deletions(-) diff --git a/hw/mips.h b/hw/mips.h index 75b7c3d

[Qemu-devel] [PATCH 5/8] [MIPS] qdev: convert ISA VGA MM to sysbus device

2010-09-08 Thread Hervé Poussineau
Use it in Jazz emulation Remove isa_vga_mm_init() function, which is not used anymore Signed-off-by: Hervé Poussineau --- hw/mips_jazz.c |2 +- hw/pc.h |2 - hw/vga-isa-mm.c | 94 --- 3 files changed, 56 insertions(+), 42 del

[Qemu-devel] [PATCH 8/8] [MIPS] qdev: convert rc4030 to sysbus device

2010-09-08 Thread Hervé Poussineau
Use it in Jazz emulation Remove rc4030_init() function, which is not used anymore Signed-off-by: Hervé Poussineau --- hw/mips.h |4 +- hw/mips_jazz.c |8 +-- hw/rc4030.c| 135 ++- 3 files changed, 69 insertions(+), 78 deletion

[Qemu-devel] [PATCH 6/8] [MIPS] qdev: convert g364fb to sysbus device

2010-09-08 Thread Hervé Poussineau
Use it in Jazz emulation Remove g364fb_mm_init() function, which is not used anymore Signed-off-by: Hervé Poussineau --- hw/g364fb.c| 120 +-- hw/mips.h |5 -- hw/mips_jazz.c |2 +- 3 files changed, 64 insertions(+), 63 deleti

[Qemu-devel] [PATCH 4/8] [MIPS] qdev: Use qdev floppy disk controller in Jazz emulation

2010-09-08 Thread Hervé Poussineau
Remove fdctrl_init_sysbus() function, which is not used anymore Signed-off-by: Hervé Poussineau --- hw/fdc.c | 24 hw/fdc.h |2 -- hw/mips_jazz.c | 10 +- 3 files changed, 1 insertions(+), 35 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c inde

[Qemu-devel] [PATCH 2/8] [MIPS] qdev: convert ds1225y nvram to sysbus device

2010-09-08 Thread Hervé Poussineau
Use it in Jazz emulation Remove protection stuff, which doesn't belong to this device Remove ds1225y_init() and ds1225y_set_protection() functions, which are not used anymore Signed-off-by: Hervé Poussineau --- hw/ds1225y.c | 151 ++-- hw/m

[Qemu-devel] [PATCH 3/8] [MIPS] qdev: convert jazz-led to sysbus device

2010-09-08 Thread Hervé Poussineau
Use it in Jazz emulation Remove jazz_led_init() function, which is not used anymore Compile jazz_led.c file only once Signed-off-by: Hervé Poussineau --- Makefile.objs|1 + Makefile.target |2 +- default-configs/mips-softmmu.mak |1 +

[Qemu-devel] [PATCH v2 0/8] Convert some MIPS Jazz devices to qdev

2010-09-08 Thread Hervé Poussineau
changes v1 -> v2: - create sysbus devices instead of using a custom bus Patch description: This patch series converts some of the devices used by MIPS Jazz emulation to qdev devices. Makefile.objs|1 + Makefile.target |2 +- default-configs/m

[Qemu-devel] [PATCH 1/8] [MIPS] qdev: convert i8042 to sysbus device

2010-09-08 Thread Hervé Poussineau
Use it in Jazz emulation Remove i8042_mm_init() function, which is not used anymore Signed-off-by: Hervé Poussineau --- hw/mips_jazz.c |3 ++- hw/pc.h|3 --- hw/pckbd.c | 55 +++ 3 files changed, 37 insertions(+), 24 delet

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Anthony Liguori
On 09/08/2010 03:23 PM, Christoph Hellwig wrote: On Wed, Sep 08, 2010 at 11:30:10AM -0500, Anthony Liguori wrote: http://wiki.qemu.org/Features/QED/OnlineDefrag Is a spec for a very simple approach to online defrag that I hope we can implement in the near future. I think that once we have

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Christoph Hellwig
On Wed, Sep 08, 2010 at 11:30:10AM -0500, Anthony Liguori wrote: > http://wiki.qemu.org/Features/QED/OnlineDefrag > > Is a spec for a very simple approach to online defrag that I hope we can > implement in the near future. I think that once we have the mechanisms > to freeze clusters and to swa

Re: [Qemu-devel] Re: [ANNOUNCE] qemu-0.13.0-rc1

2010-09-08 Thread Anthony Liguori
On 09/08/2010 03:08 PM, Nigel Horne wrote: > The QEMU team is pleased to announce the availability of the 0.13.0-rc1 release. This is a release candidate for the 0.13.0 release. This is good news and well done. Could I ask if bug 623852 is likely to be fixed prior to release? Thanks! I don

[Qemu-devel] Re: [ANNOUNCE] qemu-0.13.0-rc1

2010-09-08 Thread Nigel Horne
> The QEMU team is pleased to announce the availability of the 0.13.0-rc1 release. This is a release candidate for the 0.13.0 release. This is good news and well done. Could I ask if bug 623852 is likely to be fixed prior to release? Thanks! Regards, -Nigel -- Nigel Horne. Arranger, Adjud

Re: [Qemu-devel] [PULL 0/4] PPC updates

2010-09-08 Thread Alexander Graf
Am 08.09.2010 um 21:58 schrieb Anthony Liguori : > On 09/08/2010 02:41 PM, Alexander Graf wrote: >> On 08.09.2010, at 21:31, Anthony Liguori wrote: >> >> >>> On 09/07/2010 06:53 AM, Alexander Graf wrote: >>> I would really appriciate if these would also make it for 0.13. Should I >>

Re: [Qemu-devel] [PULL 0/4] PPC updates

2010-09-08 Thread Anthony Liguori
On 09/08/2010 02:41 PM, Alexander Graf wrote: On 08.09.2010, at 21:31, Anthony Liguori wrote: On 09/07/2010 06:53 AM, Alexander Graf wrote: I would really appriciate if these would also make it for 0.13. Should I create a separate pull tree for that? The following changes since comm

Re: [Qemu-devel] [PULL 0/4] PPC updates

2010-09-08 Thread Alexander Graf
On 08.09.2010, at 21:31, Anthony Liguori wrote: > On 09/07/2010 06:53 AM, Alexander Graf wrote: >> I would really appriciate if these would also make it for 0.13. Should I >> create a separate pull tree for that? >> >> The following changes since commit ba5e7f82169f32ab8163c707d97c799ca09f8924:

Re: [Qemu-devel] [PULL 0/4] PPC updates

2010-09-08 Thread Anthony Liguori
On 09/07/2010 06:53 AM, Alexander Graf wrote: I would really appriciate if these would also make it for 0.13. Should I create a separate pull tree for that? The following changes since commit ba5e7f82169f32ab8163c707d97c799ca09f8924: Izumi Tsutsui (1): vnc: use bswapNN() rather than

Re: [Qemu-devel] [PULL] virtio, e1000

2010-09-08 Thread Anthony Liguori
On 09/07/2010 12:39 PM, Michael S. Tsirkin wrote: Hi Anthony, The tx timer patches seem to be very stable, and generally a good cleanup, and there's a fallback flag to get the old behaviour, so if there are regressions it will be easy for people to diagnose. Mergeable buffer support has been out

Re: [Qemu-devel] [PULL v2 00/25] Block patches

2010-09-08 Thread Anthony Liguori
On 09/08/2010 08:29 AM, Kevin Wolf wrote: The following changes since commit 02a89b219039621c940863aa5a9da4fec81a1546: isapc: fix segfault. (2010-08-28 08:50:40 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Pulled. Thanks. Regards, Ant

[Qemu-devel] Re: PULL request for VirtFS updates

2010-09-08 Thread Anthony Liguori
On 09/08/2010 02:22 PM, Venkateswararao Jujjuri (JV) wrote: The following changes since commit ba5e7f82169f32ab8163c707d97c799ca09f8924: Izumi Tsutsui (1): vnc: use bswapNN() rather than bswap_NN() Pulled. Thanks. Regards, Anthony Liguori are available in the git repository at:

Re: [Qemu-devel] [PULL 0/4] PPC updates

2010-09-08 Thread Anthony Liguori
On 09/07/2010 06:53 AM, Alexander Graf wrote: I would really appriciate if these would also make it for 0.13. Should I create a separate pull tree for that? It's too late for 0.13. Regards, Anthony Liguori The following changes since commit ba5e7f82169f32ab8163c707d97c799ca09f8924: I

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Anthony Liguori
On 09/08/2010 01:56 PM, Blue Swirl wrote: That's a bit big, for example CD images are only 640M and there were smaller disks. But I guess you mean the smallest maximum size limited by the cluster_size etc, so the actual images may be even smaller. Yes. The smallest image is one cluster. T

[Qemu-devel] PULL request for VirtFS updates

2010-09-08 Thread Venkateswararao Jujjuri (JV)
The following changes since commit ba5e7f82169f32ab8163c707d97c799ca09f8924: Izumi Tsutsui (1): vnc: use bswapNN() rather than bswap_NN() are available in the git repository at: git://repo.or.cz/qemu/aliguori/jvrao.git for-anthony Aneesh Kumar K.V (8): virtio-9p: Add fidtype s

[Qemu-devel] [ANNOUNCE] qemu-0.13.0-rc1

2010-09-08 Thread Anthony Liguori
The QEMU team is pleased to announce the availability of the 0.13.0-rc1 release. This is a release candidate for the 0.13.0 release. It can be downloaded from Savannah at: http://download.savannah.gnu.org/releases/qemu/qemu-0.13.0-rc1.tar.gz On behalf of the QEMU team, I'd like to thank everyo

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Blue Swirl
On Wed, Sep 8, 2010 at 6:35 PM, Anthony Liguori wrote: > On 09/08/2010 01:24 PM, Blue Swirl wrote: >> >> Based on these: >> #define TABLE_NOFFSETS (table_size * cluster_size / sizeof(uint64_t)) >> header.image_size<= TABLE_NOFFSETS * TABLE_NOFFSETS * header.cluster_size, >> the maximum image size

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Anthony Liguori
On 09/08/2010 01:24 PM, Blue Swirl wrote: Based on these: #define TABLE_NOFFSETS (table_size * cluster_size / sizeof(uint64_t)) header.image_size<= TABLE_NOFFSETS * TABLE_NOFFSETS * header.cluster_size, the maximum image size equals to table_size^2 * cluster_size^3 / sizeof(uint64_t)^2. Is the sq

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Blue Swirl
On Wed, Sep 8, 2010 at 3:37 PM, Stefan Hajnoczi wrote: > On Tue, Sep 7, 2010 at 8:25 PM, Blue Swirl wrote: >> On Mon, Sep 6, 2010 at 10:04 AM, Stefan Hajnoczi >> wrote: >>> QEMU Enhanced Disk format is a disk image format that forgoes features >>> found in qcow2 in favor of better levels of perf

Re: [Qemu-devel] [PATCH 2/4] PPC: Qdev'ify e500 pci

2010-09-08 Thread Blue Swirl
On Tue, Sep 7, 2010 at 9:33 PM, Alexander Graf wrote: > > On 07.09.2010, at 20:21, Blue Swirl wrote: > >> On Tue, Sep 7, 2010 at 11:53 AM, Alexander Graf wrote: >>> The e500 PCI controller isn't qdev'ified yet. This leads to severe issues >>> when running with -drive. >>> >>> To be able to use a

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Anthony Liguori
On 09/08/2010 10:38 AM, Christoph Hellwig wrote: On Wed, Sep 08, 2010 at 12:15:13PM +0100, Stefan Hajnoczi wrote: In-place writes overwrite old data in the image file. They do not allocate new clusters or update any metadata. This is why write performance is comparable to raw in the long r

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Christoph Hellwig
On Wed, Sep 08, 2010 at 12:15:13PM +0100, Stefan Hajnoczi wrote: > In-place writes overwrite old data in the image file. They do not > allocate new clusters or update any metadata. This is why write > performance is comparable to raw in the long run. Only if qed doesn't cause additional fragment

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Stefan Hajnoczi
On Tue, Sep 7, 2010 at 8:25 PM, Blue Swirl wrote: > On Mon, Sep 6, 2010 at 10:04 AM, Stefan Hajnoczi > wrote: >> QEMU Enhanced Disk format is a disk image format that forgoes features >> found in qcow2 in favor of better levels of performance and data >> integrity.  Due to its simpler on-disk lay

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Stefan Hajnoczi
On Tue, Sep 7, 2010 at 3:51 PM, Avi Kivity wrote: >  On 09/06/2010 04:06 PM, Anthony Liguori wrote: >> >> Another point worth mentioning is that our intention is to have a formal >> specification of the format before merging.  A start of that is located at >> http://wiki.qemu.org/Features/QED >> >

[Qemu-devel] [PATCH 01/25] virtio: Factor virtqueue_map_sg out

2010-09-08 Thread Kevin Wolf
Separate the mapping of requests to host memory from the descriptor iteration. The next patch will make use of it in a different context. Signed-off-by: Kevin Wolf --- hw/virtio.c | 38 -- hw/virtio.h |3 +++ 2 files changed, 27 insertions(+), 14 deletio

[Qemu-devel] [PATCH] [For 0.13] Disable virtio-balloon memory stats interface

2010-09-08 Thread Adam Litke
The addition of memory stats reporting to the virtio balloon causes the 'info balloon' command to become asynchronous. This is a regression because in some cases it can hang the user monitor. To fix this regression, the virtio balloon memory stats feature is being disabled in qemu-0.13. Signed-o

[Qemu-devel] [PATCH 09/25] monitor: make 'info snapshots' show only fully available snapshots

2010-09-08 Thread Kevin Wolf
From: Miguel Di Ciurcio Filho The output generated by 'info snapshots' shows only snapshots that exist on the block device that saves the VM state. This output can cause an user to erroneously try to load an snapshot that is not available on all block devices. $ qemu-img snapshot -l xxtest.qcow2

[Qemu-devel] [PATCH 10/25] savevm: Generate a name when run without one

2010-09-08 Thread Kevin Wolf
From: Miguel Di Ciurcio Filho When savevm is run without a name, the name stays blank and the snapshot is saved anyway. The new behavior is when savevm is run without parameters a name will be created automaticaly, so the snapshot is accessible to the user without needing the id when loadvm is r

[Qemu-devel] [PATCH 12/25] scsi-disk: fix the mode data header returned by the MODE SENSE(10) command

2010-09-08 Thread Kevin Wolf
From: Bernhard Kohl The header for the MODE SENSE(10) command is 8 bytes long. Signed-off-by: Bernhard Kohl Signed-off-by: Kevin Wolf --- hw/scsi-disk.c | 38 -- 1 files changed, 32 insertions(+), 6 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-dis

[Qemu-devel] [PATCH 13/25] scsi-disk: respect the page control (PC) field in the MODE SENSE command

2010-09-08 Thread Kevin Wolf
From: Bernhard Kohl The page control (PC) field defines the type of mode parameter values to be returned in the mode pages: PC=0 : Current values PC=1 : Changeable values PC=2 : Default values PC=3 : Saved values The current implementation always returns the same type of parameters. This is OK

[Qemu-devel] [PATCH 11/25] scsi-disk: fix the mode data length field returned by the MODE SENSE command

2010-09-08 Thread Kevin Wolf
From: Bernhard Kohl The MODE DATA LENGTH field indicates the length in bytes of the following data that is available to be transferred. The mode data length does not include the number of bytes in the MODE DATA LENGTH field. Signed-off-by: Bernhard Kohl Signed-off-by: Kevin Wolf --- hw/scsi-d

[Qemu-devel] [PATCH 16/25] scsi-disk: fix the check of the DBD bit in the MODE SENSE command

2010-09-08 Thread Kevin Wolf
From: Bernhard Kohl The DBD bit does not work as expected. SCSI-Spec: http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.2.10 "A disable block descriptors (DBD) bit of zero indicates that the target may return zero or more block descriptors in the returned MODE SENSE data (see 8.3.3), at the target

[Qemu-devel] [PATCH 19/25] raw-posix: Don't use file name for host_cdrom detection on Linux

2010-09-08 Thread Kevin Wolf
On Linux, we have code to detect CD-ROMs using an ioctl. We shouldn't lose anything but false positives by removing the check for a /dev/cd* path. Signed-off-by: Kevin Wolf --- block/raw-posix.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/block/raw-posix.c b/block/

[Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface

2010-09-08 Thread Adam Litke
The addition of memory stats reporting to the virtio balloon causes the 'info balloon' command to become asynchronous. This is a regression because in some cases it can hang the user monitor. Disable this feature until a better interface for asynchronous commands can be worked out. Signed-off-by

[Qemu-devel] [PATCH 03/25] block: Fix image re-open in bdrv_commit

2010-09-08 Thread Kevin Wolf
Arguably we should re-open the backing file with the backing file format and not with the format of the snapshot image. Signed-off-by: Kevin Wolf --- block.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index da70f29..a5514e3 100644 --- a

[Qemu-devel] [PATCH 04/25] sheepdog: remove unnecessary includes

2010-09-08 Thread Kevin Wolf
From: Izumi Tsutsui "qemu_socket.h" includes all necessary files and including without could cause errors on some systems. Signed-off-by: Izumi Tsutsui Signed-off-by: Kevin Wolf --- block/sheepdog.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/block/she

[Qemu-devel] [PULL v2 00/25] Block patches

2010-09-08 Thread Kevin Wolf
The following changes since commit 02a89b219039621c940863aa5a9da4fec81a1546: isapc: fix segfault. (2010-08-28 08:50:40 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Andrew de Quincey (1): posix-aio-compat: Fix async_conmtext for ioctl Bernh

[Qemu-devel] [PATCH 21/25] scsi-disk: add some optional scsi commands

2010-09-08 Thread Kevin Wolf
From: Bernhard Kohl I use a legacy OS which depends on some optional SCSI commands. In fact this implementation does nothing special, but provides minimum support for the following commands: REZERO UNIT WRITE AND VERIFY(10) WRITE AND VERIFY(12) WRITE AND VERIFY(16) MODE SELECT(6) MODE SELECT(10)

[Qemu-devel] [PATCH 07/25] nbd: Introduce NBD named exports.

2010-09-08 Thread Kevin Wolf
From: Laurent Vivier This patch allows to connect Qemu using NBD protocol to an nbd-server using named exports. For instance, if on the host "isoserver", in /etc/nbd-server/config, you have: [generic] [debian-500-ppc-netinst] exportname = /ISO/debian-500-powerpc-netinst.iso [Fedora-10-p

[Qemu-devel] [PATCH 08/25] posix-aio-compat: Fix async_conmtext for ioctl

2010-09-08 Thread Kevin Wolf
From: Andrew de Quincey Set the async_context_id field when queuing an async ioctl call Signed-off-by: Andrew de Quincey Signed-off-by: Kevin Wolf --- posix-aio-compat.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/posix-aio-compat.c b/posix-aio-compat.c index a67f

[Qemu-devel] [PATCH 20/25] Improve ATA IDENTIFY word 64 contents.

2010-09-08 Thread Kevin Wolf
From: Jonathan A. Kollasch Fill in word 64 of IDENTIFY data to indicate support for PIO modes 3 and 4. This allows NetBSD guests to use UltraDMA modes instead of just PIO mode 0. Signed-off-by: Jonathan A. Kollasch Signed-off-by: Kevin Wolf --- hw/ide/core.c |4 ++-- 1 files changed, 2 in

[Qemu-devel] [PATCH 24/25] block: Fix BDRV_O_CACHE_MASK

2010-09-08 Thread Kevin Wolf
BDRV_O_CACHE_MASK should have been extended when cache=unsafe introduced a new flag BDRV_O_NO_FLUSH. There are currently no users that would change their behaviour because of this, but let's clean it up before things break. Signed-off-by: Kevin Wolf --- block.h |2 +- 1 files changed, 1 inse

[Qemu-devel] [PATCH 23/25] qemu-img convert: Use cache=unsafe for output image

2010-09-08 Thread Kevin Wolf
If qemu-img crashes during the conversion, the user will throw away the broken output file anyway and start over. So no need to be too cautious. Signed-off-by: Kevin Wolf --- qemu-img.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index d2a97

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Kevin Wolf
Am 08.09.2010 15:26, schrieb Anthony Liguori: > On 09/08/2010 08:20 AM, Kevin Wolf wrote: >> Am 08.09.2010 14:48, schrieb Anthony Liguori: > I think one of the critical flaws in qcow2 was trying to invent a > better filesystem within qemu instead of just sticking to a very > simple and

[Qemu-devel] [PATCH 02/25] virtio-blk: Fix migration of queued requests

2010-09-08 Thread Kevin Wolf
in_sg[].iovec and out_sg[].ioved are pointer to (source) host memory and therefore invalid after migration. When loading the device state we must create a new mapping on the destination host. Signed-off-by: Kevin Wolf --- hw/virtio-blk.c |5 + 1 files changed, 5 insertions(+), 0 deletion

[Qemu-devel] [PATCH 05/25] qemu-img rebase: Open new backing file read-only

2010-09-08 Thread Kevin Wolf
We never write to a backing file, so opening rw is useless. It just means that you can't rebase on top of a file for which you don't have write permissions. Signed-off-by: Kevin Wolf --- qemu-img.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-img.c b/qemu-img.c

Re: [Qemu-devel] [PATCH] Improve cmpxchg emulation.

2010-09-08 Thread malc
On Wed, 8 Sep 2010, Jonathan A. Kollasch wrote: > Change the accumulator only after performing the redundant write during > cmpxchg. This fixes pthreaded programs using fork() in NetBSD/i386 > guests. > > >From Andreas Gustafsson in https://bugs.launchpad.net/qemu/+bug/569760. This is tab damag

[Qemu-devel] [PATCH 14/25] scsi-disk: fix the block descriptor returned by the MODE SENSE command

2010-09-08 Thread Kevin Wolf
From: Bernhard Kohl The block descriptor contains the number of blocks, not the highest LBA. Real hard disks return 0 if the number of blocks exceed the maximum 0xFF. SCSI-Spec: http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.3.3 "The number of blocks field specifies the number of logical bl

[Qemu-devel] [PATCH 18/25] qemu-io: Make alloc output useful when nb_sectors=1

2010-09-08 Thread Kevin Wolf
From: Stefan Hajnoczi There is no indication whether or not the sector is allocated when nb_sectors=1: sector allocated at offset 64 KiB This message is produced whether or not the sector is allocated. Simply use the same message as the plural case, I don't think the English is so broken tha

[Qemu-devel] [PATCH 17/25] scsi: fix and improve debug prints

2010-09-08 Thread Kevin Wolf
From: Bernhard Kohl Some of them are not compile clean. Signed-off-by: Bernhard Kohl Signed-off-by: Kevin Wolf --- hw/lsi53c895a.c |4 ++-- hw/scsi-disk.c|8 hw/scsi-generic.c | 18 ++ 3 files changed, 20 insertions(+), 10 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 25/25] qcow2: Remove unnecessary flush after L2 write

2010-09-08 Thread Kevin Wolf
When a new cluster was allocated, we only need a flush after the write to the L2 table if it was a COW and we need to decrease the refcounts of the old clusters. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 16 1 files changed, 12 insertions(+), 4 deletions(-) diff -

[Qemu-devel] [PATCH 22/25] raw-posix: improve detection of scsi-generic devices

2010-09-08 Thread Kevin Wolf
From: Bernhard Kohl Allow symbolic links which point to /dev/sgX devices. Signed-off-by: Bernhard Kohl Signed-off-by: Kevin Wolf --- block/raw-posix.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 0fce449..813372a

[Qemu-devel] [PATCH] Improve cmpxchg emulation.

2010-09-08 Thread Jonathan A. Kollasch
Change the accumulator only after performing the redundant write during cmpxchg. This fixes pthreaded programs using fork() in NetBSD/i386 guests. >From Andreas Gustafsson in https://bugs.launchpad.net/qemu/+bug/569760. Signed-off-by: Jonathan A. Kollasch --- target-i386/translate.c | 12 +++

[Qemu-devel] [PATCH 15/25] scsi-disk: return CHECK CONDITION for unknown page codes in the MODE SENSE command

2010-09-08 Thread Kevin Wolf
From: Bernhard Kohl SCSI-Spec: http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.2.10 "An initiator may request any one or all of the supported mode pages from a target. If an initiator issues a MODE SENSE command with a page code value not implemented by the target, the target shall return CHECK C

[Qemu-devel] [PATCH 06/25] vvfat: fat_chksum(): fix access above array bounds

2010-09-08 Thread Kevin Wolf
From: Loïc Minier Signed-off-by: Loïc Minier Signed-off-by: Kevin Wolf --- block/vvfat.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 6d61c2e..365332a 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -512,7 +512,7 @@ static inli

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Anthony Liguori
On 09/08/2010 08:20 AM, Kevin Wolf wrote: Am 08.09.2010 14:48, schrieb Anthony Liguori: On 09/08/2010 03:23 AM, Avi Kivity wrote: On 09/08/2010 01:27 AM, Anthony Liguori wrote: FWIW, L2s are 256K at the moment and with a two level table, it can support 5PB of data.

[Qemu-devel] [PATCH 2/2] qemu-virtio9p: Implement TGETLOCK

2010-09-08 Thread M. Mohan Kumar
Synopsis size[4] TGetlock tag[2] fid[4] getlock[n] size[4] RGetlock tag[2] getlock[n] Description TGetlock is used to test for the existence of byte range posix locks on a file identified by given fid. The reply contains getlock structure. If the lock could be placed it returns F_UNLCK i

[Qemu-devel] [PATCH 1/2] qemu-virto9p: Implement TLOCK

2010-09-08 Thread M. Mohan Kumar
Synopsis size[4] TLock tag[2] fid[4] flock[n] size[4] RLock tag[2] status[1] Description Tlock is used to acquire/release byte range posix locks on a file identified by given fid. The reply contains status of the lock request flock structure: type[1] - Type of lock: F_RDLCK,

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Kevin Wolf
Am 08.09.2010 14:48, schrieb Anthony Liguori: > On 09/08/2010 03:23 AM, Avi Kivity wrote: >> On 09/08/2010 01:27 AM, Anthony Liguori wrote: FWIW, L2s are 256K at the moment and with a two level table, it can support 5PB of data. >>> >>> >>> I clearly suck at basic math today. The image

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Anthony Liguori
On 09/08/2010 03:53 AM, Avi Kivity wrote: On 09/08/2010 11:41 AM, Alexander Graf wrote: On 08.09.2010, at 10:23, Avi Kivity wrote: On 09/08/2010 01:27 AM, Anthony Liguori wrote: FWIW, L2s are 256K at the moment and with a two level table, it can support 5PB of data. I clearly suck at basic

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Anthony Liguori
On 09/08/2010 03:23 AM, Avi Kivity wrote: On 09/08/2010 01:27 AM, Anthony Liguori wrote: FWIW, L2s are 256K at the moment and with a two level table, it can support 5PB of data. I clearly suck at basic math today. The image supports 64TB today. Dropping to 128K tables would reduce it to 1

Re: [Qemu-devel] [rfc 0/3] arm : dynamically choose initrd load address

2010-09-08 Thread Daniel Lezcano
On 09/06/2010 04:12 PM, Daniel Lezcano wrote: Hi all, after compiling my kernel on the arm architecture I was not able to start it because qemu was segfaulting or going to an infinite loop. After google'ing I found on launchpad the bug: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/5248

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Stefan Hajnoczi
Here is a summary of how qed images can be accessed safely after a crash or power loss. First off, we only need to consider write operations since read operations do not change the state of the image file and cannot lead to metadata corruption. There are two types of writes. Allocating writes wh

[Qemu-devel] Re: [PATCH] Disable virtio-balloon memory stats interface

2010-09-08 Thread Amit Shah
On (Tue) Aug 31 2010 [09:12:39], Amit Shah wrote: > On (Mon) Aug 30 2010 [14:17:51], Adam Litke wrote: > > The addition of memory stats reporting to the virtio balloon causes > > the 'info balloon' command to become asynchronous. This is a regression > > because management tools that consume this

[Qemu-devel] [PATCH 3/4] rtc: Remove TARGET_I386 from qemu-config.c, enables driftfix

2010-09-08 Thread Amit Shah
qemu-config.c doesn't contain any target-specific code, and the TARGET_I386 conditional code didn't get compiled as a result. Removing this enables the driftfix parameter for rtc. Signed-off-by: Amit Shah Signed-off-by: Anthony Liguori (cherry picked from commit 027c9e21e21bbe63f74ffb86381bb1131

[Qemu-devel] [PATCH 4/4] virtio-serial: Cleanup on device hot-unplug

2010-09-08 Thread Amit Shah
Free malloc'ed memory, unregister from savevm and clean up virtio-common bits on device hot-unplug. This was found performing a migration after device hot-unplug. Reported-by: Signed-off-by: Amit Shah Signed-off-by: Anthony Liguori (cherry picked from commit 8b53a865772789a3402a44aa80169f8dd72

[Qemu-devel] [PATCH 1/4] virtio-serial: Check if more max_ports specified than we can handle

2010-09-08 Thread Amit Shah
Currently virtio-serial supports a maximum of 31 ports. Specifying the 'max_ports' parameter to be > 31 on the cmd line causes badness. Ensure we initialise virtio-serial only if max_ports is within the supported range. Signed-off-by: Amit Shah Signed-off-by: Aurelien Jarno (cherry picked from

[Qemu-devel] [PATCH 2/4] migration: Accept 'cont' only after successful incoming migration

2010-09-08 Thread Amit Shah
When a 'cont' is issued on a VM that's just waiting for an incoming migration, the VM reboots and boots into the guest, possibly corrupting its storage since it could be shared with another VM running elsewhere. Ensure that a VM started with '-incoming' is only run when an incoming migration succe

[Qemu-devel] [PATCH 0/4] Backport fixes from master to stable-0.13

2010-09-08 Thread Amit Shah
Hello, These are a few fixes which I've submitted that are included in master but not in stable-0.13. Patches 1 and 4 fix virtio-serial crash and migration, patch 2 fixes a non-starting guest after migration in a particular case and patch 3 fixes the driftfix parameter needed by some guests. The

[Qemu-devel] Re: [PATCH v2 7/9] pcie/hotplug: glue pushing attention button command. pcie_abp

2010-09-08 Thread Michael S. Tsirkin
On Wed, Sep 08, 2010 at 04:39:40PM +0900, Isaku Yamahata wrote: > glue to pcie_abp monitor command. > > Signed-off-by: Isaku Yamahata We also need to glue the LED so it's status both is reported and can be polled from monitor? > --- > hw/pcie_port.c | 82 > +

[Qemu-devel] Re: [PATCH v2 9/9] msix: clear not only INTA, but all INTx when MSI-X is enabled.

2010-09-08 Thread Michael S. Tsirkin
On Wed, Sep 08, 2010 at 04:39:42PM +0900, Isaku Yamahata wrote: > clear not only INTA, but all INTx when MSI-X is enabled. > > Signed-off-by: Isaku Yamahata Nod. This makes sense. > --- > hw/msix.c |5 - > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/hw/msix.c b/h

[Qemu-devel] Re: [PATCH v2 1/9] msi: implemented msi.

2010-09-08 Thread Isaku Yamahata
On Wed, Sep 08, 2010 at 12:13:44PM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 08, 2010 at 04:39:34PM +0900, Isaku Yamahata wrote: > > implemented msi support functions. > > > > Signed-off-by: Isaku Yamahata > > Good stuff. Some minor corrections mostly to the comments. > It's up to you wheth

[Qemu-devel] Re: [PATCH v2 1/9] msi: implemented msi.

2010-09-08 Thread Michael S. Tsirkin
On Wed, Sep 08, 2010 at 04:39:34PM +0900, Isaku Yamahata wrote: > implemented msi support functions. > > Signed-off-by: Isaku Yamahata Good stuff. Some minor corrections mostly to the comments. It's up to you whether to address or ignore them. > --- > Changes v1 -> v2: > - opencode some oneline

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Avi Kivity
On 09/08/2010 11:41 AM, Alexander Graf wrote: On 08.09.2010, at 10:23, Avi Kivity wrote: On 09/08/2010 01:27 AM, Anthony Liguori wrote: FWIW, L2s are 256K at the moment and with a two level table, it can support 5PB of data. I clearly suck at basic math today. The image supports 64TB toda

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Alexander Graf
On 08.09.2010, at 10:23, Avi Kivity wrote: > On 09/08/2010 01:27 AM, Anthony Liguori wrote: >>> FWIW, L2s are 256K at the moment and with a two level table, it can support >>> 5PB of data. >> >> >> I clearly suck at basic math today. The image supports 64TB today. >> Dropping to 128K tables

Re: [Qemu-devel] QEMU interfaces for image streaming and post-copy block migration

2010-09-08 Thread Kevin Wolf
Am 07.09.2010 17:09, schrieb Stefan Hajnoczi: > Right, I'm a little hesitant to get too far into discussing the > management interface because I remember long threads about polling and > async. I never fully read them but I bet some wisdom came out of them > that applies here. > > There are two w

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Avi Kivity
On 09/08/2010 01:27 AM, Anthony Liguori wrote: FWIW, L2s are 256K at the moment and with a two level table, it can support 5PB of data. I clearly suck at basic math today. The image supports 64TB today. Dropping to 128K tables would reduce it to 16TB and 64k tables would be 4TB. Maybe w

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-08 Thread Kevin Wolf
Am 07.09.2010 22:41, schrieb Anthony Liguori: > There's two types of snapshots that I think can cause confusion. > There's CPU/device state snapshots and then there's a block device snapshot. > > qcow2 and qed both support block device snapshots. qed only supports > external snapshots (via bac

[Qemu-devel] Re: [PATCH 07/14] msi: implemented msi.

2010-09-08 Thread Michael S. Tsirkin
On Wed, Sep 08, 2010 at 04:43:27PM +0900, Isaku Yamahata wrote: > Thank you for through review. > > On Mon, Sep 06, 2010 at 12:44:16PM +0300, Michael S. Tsirkin wrote: > > > +uint32_t pending = > > > +pci_get_long(dev->config + msi_pending_reg(dev, is64bit)); > > > +uin

[Qemu-devel] [PATCH v2 7/9] pcie/hotplug: glue pushing attention button command. pcie_abp

2010-09-08 Thread Isaku Yamahata
glue to pcie_abp monitor command. Signed-off-by: Isaku Yamahata --- hw/pcie_port.c | 82 +++ qemu-monitor.hx | 14 + sysemu.h|4 +++ 3 files changed, 100 insertions(+), 0 deletions(-) diff --git a/hw/pcie_port.c b/hw/p

  1   2   >