[Qemu-devel] PCIe Qemu changes for Q35

2010-09-05 Thread Adhyas Avasthi
Hi Isaku I believe you were working on the Q35 chipset and PCIe emulation for the same, and planned to check your code in to the main git. I can use some of that work for something I am working on. I have not been too active on the mailing list, and might have missed your reviews if you have sent

[Qemu-devel] RE: [PATCH] ivshmem: remove unnecessary checks for unsigned

2010-09-05 Thread Hao, Xudong
Avi Kivity wrote: > On 09/03/2010 05:54 AM, Hidetoshi Seto wrote: >> >> Oops, since I've registered qemu-kvm ML but not qemu-devel ML, I >> could not noticed that Jes have already posted same patch to >> qemu-devel. >> >> Now build of ivshmem is enabled only on KVM systems, please apply >> this

[Qemu-devel] Re: [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-05 Thread andrzej zaborowski
On 5 September 2010 23:44, Blue Swirl wrote: > The problem case is when BLKDBG_EVENT_MAX > 0x8000 and the type of > enum is unsigned. Then the first check is ignored by the compiler and > the second does not catch values which are between 0x8000 and > BLKDBG_EVENT_MAX. This may not be what

[Qemu-devel] Re: [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-05 Thread Blue Swirl
On Sun, Sep 5, 2010 at 8:32 PM, andrzej zaborowski wrote: > On 5 September 2010 21:16, Blue Swirl wrote: >> On Sun, Sep 5, 2010 at 5:02 PM, andrzej zaborowski wrote: >>> On 5 September 2010 18:15, Blue Swirl wrote: On Sun, Sep 5, 2010 at 3:26 PM, andrzej zaborowski wrote: > On 5

[Qemu-devel] Re: [PATCH 08/15] blkdebug: fix enum comparison'

2010-09-05 Thread Michael S. Tsirkin
On Sun, Sep 05, 2010 at 07:37:54PM +, Blue Swirl wrote: > On Sun, Sep 5, 2010 at 5:57 PM, Michael S. Tsirkin wrote: > > On Sun, Sep 05, 2010 at 03:06:32PM +, Blue Swirl wrote: > >> The signedness of enum types depend on the compiler implementation. > >> Therefore the check for negative val

[Qemu-devel] Re: [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-05 Thread andrzej zaborowski
On 5 September 2010 21:16, Blue Swirl wrote: > On Sun, Sep 5, 2010 at 5:02 PM, andrzej zaborowski wrote: >> On 5 September 2010 18:15, Blue Swirl wrote: >>> On Sun, Sep 5, 2010 at 3:26 PM, andrzej zaborowski >>> wrote: On 5 September 2010 11:44, Blue Swirl wrote: > On Sun, Sep 5, 201

[Qemu-devel] Re: [PATCH 06/15] Use range_covers_byte

2010-09-05 Thread Blue Swirl
On Sun, Sep 5, 2010 at 6:03 PM, Michael S. Tsirkin wrote: > On Sun, Sep 05, 2010 at 03:06:07PM +, Blue Swirl wrote: >> Use range_covers_byte() instead of comparisons. >> >> This also fixes some warnings with GCC flag -Wtype-limits. >> >> Signed-off-by: Blue Swirl > > To me (not a native engli

[Qemu-devel] Re: [PATCH 08/15] blkdebug: fix enum comparison

2010-09-05 Thread Blue Swirl
On Sun, Sep 5, 2010 at 5:57 PM, Michael S. Tsirkin wrote: > On Sun, Sep 05, 2010 at 03:06:32PM +, Blue Swirl wrote: >> The signedness of enum types depend on the compiler implementation. >> Therefore the check for negative values may or may not be meaningful. >> >> Fix by explicitly casting to

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Anthony Liguori
On 09/05/2010 12:51 PM, Avi Kivity wrote: On 09/05/2010 08:44 PM, andrzej zaborowski wrote: I'm perfectly fine with dropping it. btw, there are other features in qemu that seem to be academic exercises - *-user for example. What is it useful for? Most open source stuff is multiplatform, a

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Anthony Liguori
On 09/05/2010 11:05 AM, Avi Kivity wrote: We don't have a massive pool of developers sitting on their hands waiting for something else to work on. We don't have myriads of users demanding better Windows support. Search the list, there's almost no one asking questions about Windows and conside

[Qemu-devel] Re: [PATCH 14/15] Use gcc warning flag -Wempty-body, fix warnings

2010-09-05 Thread Blue Swirl
On Sun, Sep 5, 2010 at 5:54 PM, Michael S. Tsirkin wrote: > On Sun, Sep 05, 2010 at 03:07:23PM +, Blue Swirl wrote: >> diff --git a/hw/pxa2xx.c b/hw/pxa2xx.c >> index 88f61c0..6e04645 100644 >> --- a/hw/pxa2xx.c >> +++ b/hw/pxa2xx.c >> @@ -1877,8 +1877,9 @@ static void pxa2xx_fir_write(void *o

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Edgar E. Iglesias
On Sun, Sep 05, 2010 at 07:56:02PM +0200, andrzej zaborowski wrote: > On 5 September 2010 19:51, Avi Kivity wrote: > >  On 09/05/2010 08:44 PM, andrzej zaborowski wrote: > >> > I'm perfectly fine with dropping it.  btw, there are other features in > qemu > that seem to be academic e

[Qemu-devel] Re: [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-05 Thread Blue Swirl
On Sun, Sep 5, 2010 at 5:02 PM, andrzej zaborowski wrote: > On 5 September 2010 18:15, Blue Swirl wrote: >> On Sun, Sep 5, 2010 at 3:26 PM, andrzej zaborowski wrote: >>> On 5 September 2010 11:44, Blue Swirl wrote: On Sun, Sep 5, 2010 at 9:26 AM, Michael S. Tsirkin wrote: > On Sun, Se

[Qemu-devel] [PATCH] ivshmem: fix build on a 32 bit system

2010-09-05 Thread Michael S. Tsirkin
/scm/qemu/hw/ivshmem.c: In function ‘check_shm_size’: /scm/qemu/hw/ivshmem.c:356: error: format ‘%ld’ expects type ‘long int’, but argument 4 has type ‘__off64_t’ Fix by casting to u64. Signed-off-by: Michael S. Tsirkin --- hw/ivshmem.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletion

[Qemu-devel] Re: [PATCH 06/15] Use range_covers_byte

2010-09-05 Thread Michael S. Tsirkin
On Sun, Sep 05, 2010 at 03:06:07PM +, Blue Swirl wrote: > Use range_covers_byte() instead of comparisons. > > This also fixes some warnings with GCC flag -Wtype-limits. > > Signed-off-by: Blue Swirl To me (not a native english speaker) this comment implies that there's a bugfix here. Is the

[Qemu-devel] Re: [PATCH 08/15] blkdebug: fix enum comparison

2010-09-05 Thread Michael S. Tsirkin
On Sun, Sep 05, 2010 at 03:06:32PM +, Blue Swirl wrote: > The signedness of enum types depend on the compiler implementation. > Therefore the check for negative values may or may not be meaningful. > > Fix by explicitly casting to a signed integer. > > Since the values are also checked earlie

[Qemu-devel] Re: [PATCH 14/15] Use gcc warning flag -Wempty-body, fix warnings

2010-09-05 Thread Michael S. Tsirkin
On Sun, Sep 05, 2010 at 03:07:23PM +, Blue Swirl wrote: > diff --git a/hw/pxa2xx.c b/hw/pxa2xx.c > index 88f61c0..6e04645 100644 > --- a/hw/pxa2xx.c > +++ b/hw/pxa2xx.c > @@ -1877,8 +1877,9 @@ static void pxa2xx_fir_write(void *opaque, > target_phys_addr_t addr, > s->control[0] = value

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Avi Kivity
On 09/05/2010 08:56 PM, andrzej zaborowski wrote: Well, both these examples are very far from the typical end user or even typical developer. Some of the industrial users include all of their "app developers" which count in big numbers. Now I haven't installed Nokia or Palm's SDKs but Poky's

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread andrzej zaborowski
On 5 September 2010 19:51, Avi Kivity wrote: >  On 09/05/2010 08:44 PM, andrzej zaborowski wrote: >> I'm perfectly fine with dropping it.  btw, there are other features in qemu that seem to be academic exercises - *-user for example.  What is it useful for?  Most open sour

Re: [Qemu-devel] Unmaintained ppc features (was: Unmaintained QEMU builds)

2010-09-05 Thread Andreas Färber
Am 05.09.2010 um 12:03 schrieb Alexander Graf: On 04.09.2010, at 16:41, Andreas Färber wrote: Am 17.08.2010 um 21:56 schrieb Anthony Liguori: Often time, the feature is not generally useful so the code just rots. I think an awful lot of the PPC boards and devices also fall into this cate

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Avi Kivity
On 09/05/2010 08:44 PM, andrzej zaborowski wrote: I'm perfectly fine with dropping it. btw, there are other features in qemu that seem to be academic exercises - *-user for example. What is it useful for? Most open source stuff is multiplatform, and serious commercial work needs something f

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread andrzej zaborowski
On 5 September 2010 19:33, malc wrote: > On Sun, 5 Sep 2010, Avi Kivity wrote: > >>  On 09/05/2010 06:57 PM, Anthony Liguori wrote: >> > On 09/05/2010 10:10 AM, Avi Kivity wrote: >> > > > As a baby step, is there any chance of publishing an automatic nightly >> > > > Windows (cross-)build as a .zi

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Peter Maydell
On 5 September 2010 17:05, Avi Kivity wrote: > I'm perfectly fine with dropping it.  btw, there are other features in qemu > that seem to be academic exercises - *-user for example.  What is it useful > for?  Most open source stuff is multiplatform, and serious commercial work > needs something fa

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread malc
On Sun, 5 Sep 2010, Avi Kivity wrote: > On 09/05/2010 06:57 PM, Anthony Liguori wrote: > > On 09/05/2010 10:10 AM, Avi Kivity wrote: > > > > As a baby step, is there any chance of publishing an automatic nightly > > > > Windows (cross-)build as a .zip file on qemu.org? That might give more > > >

[Qemu-devel] Re: [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-05 Thread andrzej zaborowski
On 5 September 2010 19:02, andrzej zaborowski wrote: > Patches 05, 06, 07, 09, 11, 14, 15 all replace one version of the code > with a different that achieves the exact same functionality for all Sorry, patch 11 is a fix (unrelated to the warning though). Cheers

[Qemu-devel] Re: [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-05 Thread andrzej zaborowski
On 5 September 2010 18:15, Blue Swirl wrote: > On Sun, Sep 5, 2010 at 3:26 PM, andrzej zaborowski wrote: >> On 5 September 2010 11:44, Blue Swirl wrote: >>> On Sun, Sep 5, 2010 at 9:26 AM, Michael S. Tsirkin wrote: On Sun, Sep 05, 2010 at 09:06:10AM +, Blue Swirl wrote: > On Sun, S

Re: [Qemu-devel] Guest cannot handle a PCI BAR > 1GB

2010-09-05 Thread Avi Kivity
On 09/04/2010 01:22 AM, Cam Macdonell wrote: Hi, I'm trying to test 2 GB (and eventually larger) BARs with ivshmem and I get an error in the guest that it is able to find a mem resource for a BAR larger than 1GB. I'm using 64-bit BARs. when running with 6GB of RAM and a 1GB BAR for ivshmem, i

[Qemu-devel] Re: Unmaintained QEMU builds

2010-09-05 Thread Andreas Färber
Am 05.09.2010 um 17:41 schrieb Paolo Bonzini: The main thing is what you wrote in another message: what can QEMU offer on Windows and Darwin that semi-free Virtual Box and proprietary VMware cannot? I like to think that it can offer something, but maybe I'm wrong. :/ On Darwin/ppc64, I'm

[Qemu-devel] [PATCH] qemu: e1000 fix TOR math

2010-09-05 Thread Michael S. Tsirkin
Patch b0b900070c7cb29bbefb732ec00397abe5de6d73 made TOR valuer incorrect: the spec says it should always include the CRC field, while size does not include CRC now. No one seems to use TOR field (which is likely why current code works fine), but better to stick to spec. Lightly tested with a linux

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Avi Kivity
On 09/05/2010 07:25 PM, Blue Swirl wrote: I'm perfectly fine with dropping it. btw, there are other features in qemu that seem to be academic exercises - *-user for example. What is it useful for? Most open source stuff is multiplatform, and serious commercial work needs something faster th

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Blue Swirl
On Sun, Sep 5, 2010 at 4:05 PM, Avi Kivity wrote: >  On 09/05/2010 06:57 PM, Anthony Liguori wrote: >> >> On 09/05/2010 10:10 AM, Avi Kivity wrote: As a baby step, is there any chance of publishing an automatic nightly Windows (cross-)build as a .zip file on qemu.org? That might giv

[Qemu-devel] Re: [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-05 Thread Blue Swirl
On Sun, Sep 5, 2010 at 3:26 PM, andrzej zaborowski wrote: > On 5 September 2010 11:44, Blue Swirl wrote: >> On Sun, Sep 5, 2010 at 9:26 AM, Michael S. Tsirkin wrote: >>> On Sun, Sep 05, 2010 at 09:06:10AM +, Blue Swirl wrote: On Sun, Sep 5, 2010 at 7:54 AM, Michael S. Tsirkin wrote: >>

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Avi Kivity
On 09/05/2010 06:57 PM, Anthony Liguori wrote: On 09/05/2010 10:10 AM, Avi Kivity wrote: As a baby step, is there any chance of publishing an automatic nightly Windows (cross-)build as a .zip file on qemu.org? That might give more users a chance of detecting runtime faults during the developm

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Anthony Liguori
On 09/05/2010 10:10 AM, Avi Kivity wrote: As a baby step, is there any chance of publishing an automatic nightly Windows (cross-)build as a .zip file on qemu.org? That might give more users a chance of detecting runtime faults during the development cycle. That's doable and useful, yes. I

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Avi Kivity
On 09/05/2010 06:44 PM, Andreas Färber wrote: Am 05.09.2010 um 16:17 schrieb Avi Kivity: On 09/05/2010 05:10 PM, Blue Swirl wrote: Easy to use GUI and integration to host system are important, but performance is also a big problem. QEMU/TCG can't compete with alternatives that use proprietary

[Qemu-devel] Re: Unmaintained QEMU builds

2010-09-05 Thread Paolo Bonzini
On 08/18/2010 11:46 AM, Alexander Graf wrote: I think a better question would be, should we even bother with thread wrappers? If we drop win32 support, we can just assume pthreads and avoid a layer of indirection. The current threading code is also broken on osx and last time I talked to paolo

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Andreas Färber
Am 05.09.2010 um 16:17 schrieb Avi Kivity: On 09/05/2010 05:10 PM, Blue Swirl wrote: Easy to use GUI and integration to host system are important, but performance is also a big problem. QEMU/TCG can't compete with alternatives that use proprietary kernel modules. Someone should recreate kqemu b

[Qemu-devel] Re: Unmaintained QEMU builds

2010-09-05 Thread Paolo Bonzini
On 09/04/2010 04:03 PM, Andreas Färber wrote: For BeOS there once was a pthreads library project. Maybe the same could work for Win32, implement the pthreads API and map to corresponding Win32 API functions? Then QEMU could use pthreads API and use wrappers only where strictly necessary. In theor

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Avi Kivity
On 09/05/2010 06:01 PM, Andreas Färber wrote: Am 05.09.2010 um 13:19 schrieb Avi Kivity: On 09/04/2010 04:56 PM, Andreas Färber wrote: Maybe it's time to rethink the relation between QEMU and its frontends / management tools? If we want to compete with the commercial products (sic), we mig

[Qemu-devel] [PATCH 14/15] Use gcc warning flag -Wempty-body, fix warnings

2010-09-05 Thread Blue Swirl
If the compiler supports the warning flag -Wempty-body, use it. Adjust the code to avoid the warnings. Signed-off-by: Blue Swirl --- configure |2 +- hw/omap_i2c.c |5 +++-- hw/omap_mmc.c |5 +++-- hw/pxa2xx.c |5 +++-- hw/soc_dma.c |5 +++-- targe

[Qemu-devel] Re: [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-05 Thread andrzej zaborowski
On 5 September 2010 11:44, Blue Swirl wrote: > On Sun, Sep 5, 2010 at 9:26 AM, Michael S. Tsirkin wrote: >> On Sun, Sep 05, 2010 at 09:06:10AM +, Blue Swirl wrote: >>> On Sun, Sep 5, 2010 at 7:54 AM, Michael S. Tsirkin wrote: >>> > On Sat, Sep 04, 2010 at 05:21:24PM +, Blue Swirl wrote:

[Qemu-devel] [PATCH 12/15] Use gcc warning flag -Wtype-limits

2010-09-05 Thread Blue Swirl
If the compiler supports the warning flag -Wtype-limits, use it. Signed-off-by: Blue Swirl --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 146dac0..47bbe39 100755 --- a/configure +++ b/configure @@ -138,7 +138,7 @@ QEMU_CFLAGS="

[Qemu-devel] [PATCH 09/15] PPC: Suppress gcc warnings with -Wtype-limits

2010-09-05 Thread Blue Swirl
The hack added by c5b76b381081680633e2e0a91216507430409fb2 was not enough to fix warnings with gcc flag -Wtype-limits. Add a new macro to fix both problems. Signed-off-by: Blue Swirl --- target-ppc/op_helper.c | 50 1 files changed, 25 insertion

[Qemu-devel] [PATCH 07/15] pxa2xx: remove useless checks

2010-09-05 Thread Blue Swirl
Remove checks which were made useless by r5849, 8da3ff180974732fc4272cb4433fef85c1822961. This also fixes a warning with GCC flag -Wtype-limits. Signed-off-by: Blue Swirl --- hw/pxa2xx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pxa2xx.c b/hw/pxa2xx.c index 26

[Qemu-devel] [PATCH 08/15] blkdebug: fix enum comparison

2010-09-05 Thread Blue Swirl
The signedness of enum types depend on the compiler implementation. Therefore the check for negative values may or may not be meaningful. Fix by explicitly casting to a signed integer. Since the values are also checked earlier against event_names table, this is an internal error. Change the 'if'

[Qemu-devel] [PATCH 15/15] Use gcc warning flag -Wnested-externs, fix warnings

2010-09-05 Thread Blue Swirl
If the compiler supports the warning flag -Wnested-externs, use it. Fix the only warning by moving the xml_builtin declaration to a more proper place. Signed-off-by: Blue Swirl --- configure |2 +- feature_to_c.sh |1 - gdbstub.c |1 - gdbstub.h |3 +++ 4 files

[Qemu-devel] [PATCH 06/15] Use range_covers_byte

2010-09-05 Thread Blue Swirl
Use range_covers_byte() instead of comparisons. This also fixes some warnings with GCC flag -Wtype-limits. Signed-off-by: Blue Swirl --- hw/omap1.c | 21 +++-- hw/sm501.c |5 +++-- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/hw/omap1.c b/hw/omap1.c inde

[Qemu-devel] [PATCH 13/15] Use a few more gcc warning flags

2010-09-05 Thread Blue Swirl
If the compiler supports the following warning flags, use them: -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wmissing-include-dirs -Wclobbered Currently, these flags don't produce any warnings. Signed-off-by: Blue Swirl --- configure |5 - 1 files changed, 4 inserti

[Qemu-devel] [PATCH 11/15] pxa2xx: fix SSSR TFN logic

2010-09-05 Thread Blue Swirl
Fix SSSR TFN logic: TX FIFO is never filled, so it is always in underrun condition if SSP is enabled. This also fixes a gcc warning with -Wtype-limits. Signed-off-by: Blue Swirl --- hw/pxa2xx.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/pxa2xx.c b/hw/pxa2

[Qemu-devel] [PATCH 05/15] Introduce range.h

2010-09-05 Thread Blue Swirl
Extract range functions from pci.h. These will be used by later patches by non-PCI devices. Adjust current users. Signed-off-by: Blue Swirl --- hw/acpi_piix4.c |1 + hw/msix.c |1 + hw/pci.c|1 + hw/pci.h| 29 - hw/piix_pci.c |

[Qemu-devel] [PATCH 04/15] linux-user: improve flatload error checking

2010-09-05 Thread Blue Swirl
Because of the use of unsigned type, possible errors during load were ignored. Fix by using a signed type. This also fixes a warning with GCC flag -Wtype-limits. Signed-off-by: Blue Swirl --- linux-user/flatload.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/linux

[Qemu-devel] [PATCH 03/15] linux-user: fix types in a comparison

2010-09-05 Thread Blue Swirl
-1ul is unsigned long, which does not necessarily match abi_ulong type. Fix by using abi_long instead. This also fixes a warning with GCC flag -Wtype-limits. Signed-off-by: Blue Swirl --- linux-user/mmap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/mma

[Qemu-devel] [PATCH 10/15] MIPS: fix yield handling

2010-09-05 Thread Blue Swirl
The parameter for yield should be handled as a signed integer for the comparisons to have any effect. This also fixes a gcc warning with -Wtype-limits. Signed-off-by: Blue Swirl --- target-mips/op_helper.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/target-mips/o

[Qemu-devel] [PATCH 01/15] Check for errors during BIOS or kernel load

2010-09-05 Thread Blue Swirl
Because of the use of unsigned types, possible errors during BIOS or kernel load were ignored. Fix by using a signed type. This also fixes some warnings with GCC flag -Wtype-limits. Signed-off-by: Blue Swirl --- hw/mips_fulong2e.c |2 +- hw/ppc405_boards.c | 23 +-- h

[Qemu-devel] [PATCH 02/15] linux-user: fix socklen_t comparisons

2010-09-05 Thread Blue Swirl
On many systems, socklen_t is defined as unsigned. This means that checks for negative values are not meaningful. Fix by explicitly casting to a signed integer. This also fixes some warnings with GCC flag -Wtype-limits. Signed-off-by: Blue Swirl --- linux-user/syscall.c | 20 +---

[Qemu-devel] [PATCH 00/15] GCC warning flag update

2010-09-05 Thread Blue Swirl
In this version, I split some of the patches into more logical pieces. 5/15 adds range.h which changed a few patches. Blue Swirl (15): Check for errors during BIOS or kernel load linux-user: fix socklen_t comparisons linux-user: fix types in a comparison linux-user: improve flatload error

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Andreas Färber
Am 05.09.2010 um 13:19 schrieb Avi Kivity: On 09/04/2010 04:56 PM, Andreas Färber wrote: Maybe it's time to rethink the relation between QEMU and its frontends / management tools? If we want to compete with the commercial products (sic), we might agree on some "official" frontend per GUI

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Avi Kivity
On 09/05/2010 05:40 PM, Blue Swirl wrote: On Sun, Sep 5, 2010 at 2:17 PM, Avi Kivity wrote: On 09/05/2010 05:10 PM, Blue Swirl wrote: Easy to use GUI and integration to host system are important, but performance is also a big problem. QEMU/TCG can't compete with alternatives that use propri

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Blue Swirl
On Sun, Sep 5, 2010 at 2:17 PM, Avi Kivity wrote: >  On 09/05/2010 05:10 PM, Blue Swirl wrote: >> >> Easy to use GUI and integration to host system are important, but >> performance is also a big problem. QEMU/TCG can't compete with >> alternatives that use proprietary kernel modules. Someone shou

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Avi Kivity
On 09/05/2010 05:10 PM, Blue Swirl wrote: Easy to use GUI and integration to host system are important, but performance is also a big problem. QEMU/TCG can't compete with alternatives that use proprietary kernel modules. Someone should recreate kqemu by using KVM compatible interfaces. If some

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Blue Swirl
On Sun, Sep 5, 2010 at 11:19 AM, Avi Kivity wrote: >  On 09/04/2010 04:56 PM, Andreas Färber wrote: >> >> Maybe it's time to rethink the relation between QEMU and its frontends / >> management tools? If we want to compete with the commercial products (sic), >> we might agree on some "official" fro

[Qemu-devel] Re: [PATCH] ivshmem: remove unnecessary checks for unsigned

2010-09-05 Thread Avi Kivity
On 09/03/2010 05:54 AM, Hidetoshi Seto wrote: > > Oops, since I've registered qemu-kvm ML but not qemu-devel ML, I could not > noticed that Jes have already posted same patch to qemu-devel. > > Now build of ivshmem is enabled only on KVM systems, please apply this patch > to qemu-kvm.git asap. >

[Qemu-devel] Re: [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-05 Thread Michael S. Tsirkin
On Sun, Sep 05, 2010 at 09:06:10AM +, Blue Swirl wrote: > On Sun, Sep 5, 2010 at 7:54 AM, Michael S. Tsirkin wrote: > > On Sat, Sep 04, 2010 at 05:21:24PM +, Blue Swirl wrote: > >> In the unsigned number space, the checks can be merged into one, > >> assuming that BLKDBG_EVEN_MAX is less t

[Qemu-devel] Re: [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-05 Thread Michael S. Tsirkin
On Sun, Sep 05, 2010 at 09:44:01AM +, Blue Swirl wrote: > On Sun, Sep 5, 2010 at 9:26 AM, Michael S. Tsirkin wrote: > > On Sun, Sep 05, 2010 at 09:06:10AM +, Blue Swirl wrote: > >> On Sun, Sep 5, 2010 at 7:54 AM, Michael S. Tsirkin wrote: > >> > On Sat, Sep 04, 2010 at 05:21:24PM +, B

[Qemu-devel] Re: [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-05 Thread Michael S. Tsirkin
On Sat, Sep 04, 2010 at 05:21:24PM +, Blue Swirl wrote: > In the unsigned number space, the checks can be merged into one, > assuming that BLKDBG_EVEN_MAX is less than INT_MAX. Alternatively we > could have: > -if (event < 0 || event >= BLKDBG_EVENT_MAX) { > +if ((int)event < 0 || eve

[Qemu-devel] Re: [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-05 Thread Blue Swirl
On Sun, Sep 5, 2010 at 7:54 AM, Michael S. Tsirkin wrote: > On Sat, Sep 04, 2010 at 05:21:24PM +, Blue Swirl wrote: >> In the unsigned number space, the checks can be merged into one, >> assuming that BLKDBG_EVEN_MAX is less than INT_MAX. Alternatively we >> could have: >>  -    if (event < 0

[Qemu-devel] Re: [PATCH 12/15] piix_pci: introduce a write_config notifier

2010-09-05 Thread Michael S. Tsirkin
On Fri, Aug 13, 2010 at 02:10:01PM +0100, Stefano Stabellini wrote: > On Thu, 12 Aug 2010, Blue Swirl wrote: > > On Thu, Aug 12, 2010 at 2:09 PM, wrote: > > > From: Anthony PERARD > > > > > > Introduce a write config notifier in piix_pci, so that clients can be > > > notified every time a pci co

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Avi Kivity
On 09/04/2010 04:56 PM, Andreas Färber wrote: Maybe it's time to rethink the relation between QEMU and its frontends / management tools? If we want to compete with the commercial products (sic), we might agree on some "official" frontend per GUI-centric platform, with a Git-based repository

[Qemu-devel] Re: [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-05 Thread Blue Swirl
On Sun, Sep 5, 2010 at 9:26 AM, Michael S. Tsirkin wrote: > On Sun, Sep 05, 2010 at 09:06:10AM +, Blue Swirl wrote: >> On Sun, Sep 5, 2010 at 7:54 AM, Michael S. Tsirkin wrote: >> > On Sat, Sep 04, 2010 at 05:21:24PM +, Blue Swirl wrote: >> >> In the unsigned number space, the checks can

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread Alexander Graf
On 04.09.2010, at 16:41, Andreas Färber wrote: > Am 17.08.2010 um 21:56 schrieb Anthony Liguori: > >> I think we have a lot of dump-and-run features in QEMU whereas someone >> writes the patches to implement something and then disappears. Often time, >> the feature is not generally useful so

[Qemu-devel] Re: [PATCH 00/14] trace: Add static tracing to QEMU

2010-09-05 Thread Michael S. Tsirkin
On Thu, Aug 12, 2010 at 11:36:21AM +0100, Stefan Hajnoczi wrote: > 2. The built-in 'simple' trace backend writes binary traces to >/tmp/trace-. Saving files with predictable names in /tmp is usually not a good idea, see e.g. http://en.wikipedia.org/wiki/Symlink_race. Put them in $HOME or somet

[Qemu-devel] Re: [PATCH 2/7] pci: memory access API and IOMMU support

2010-09-05 Thread Michael S. Tsirkin
On Sat, Sep 04, 2010 at 09:01:06AM +, Blue Swirl wrote: > On Thu, Sep 2, 2010 at 9:49 AM, Michael S. Tsirkin wrote: > > On Thu, Sep 02, 2010 at 11:40:58AM +0300, Eduard - Gabriel Munteanu wrote: > >> On Thu, Sep 02, 2010 at 08:28:26AM +0300, Michael S. Tsirkin wrote: > >> > On Sat, Aug 28, 201