[Qemu-devel] [Bug 629298] [NEW] incorrect output of ARM instruction SMMLS

Public bug reported: qemu release version: 0.12.5 for Linux qemu-arm release version: 0.12.5 for Linux Description: When simulating the ARMv6/ARMv7 instruction SMMLS, the output of qemu-arm and RVDS3.1 profiler are different. RVDS3.1 outputs correct result but qemu-arm doesn't. ** Affects: qemu

Re: [Qemu-devel] information about PL110 LCD controller

On Thu, Sep 2, 2010 at 6:41 PM, Andrea Galeazzi wrote: > Hi every body, > I'm a newbie about the qemu word but I'd like to emulate the versatile ARM > platform. In particular I'm very interested in knowing how much the > emulation of PL110 LCD controller fits the real hardware. Are some features >

[Qemu-devel] Re: [PATCH] ivshmem: remove unnecessary checks for unsigned

(2010/09/03 10:54), Hidetoshi Seto wrote: > fixes gcc 4.1 warning: > In function 'ivshmem_io_writel': > 202: warning: comparison is always false due to limited range of data type > 208: warning: comparison is always true due to limited range of data type > > Signed-off-by: Hidetoshi Seto > ---

[Qemu-devel] Re: [SeaBIOS] [PATCH 3/4] iommu: introduce AMD IOMMU support, initialize it

I think those global variables are unnecessary. Please see the comment on 4/4. thanks, On Sat, Aug 28, 2010 at 06:02:57PM +0300, Eduard - Gabriel Munteanu wrote: > The AMD IOMMU must be discovered and initialized by the BIOS if present. > > Signed-off-by: Eduard - Gabriel Munteanu > --- > Make

[Qemu-devel] Re: [SeaBIOS] [PATCH 4/4] iommu: provide ACPI tables

How about the following approach? Although I'm not sure how much multiple iommus is wanted, it wouldn't pose single iommu limit and global variables in 3/4 would be unnecessary. In stead of ACPI_INIT_TABLE(build_ivrs()), something like foreachpci() { if (class == PCI_CLASS_SYSTEM

[Qemu-devel] Re: [SeaBIOS] [PATCH 2/4] pci: add foreachcap() helper

Given the usage of 3/4, u32 pci_find_capability(bdf, cap) would be more direct. Maybe this is a matter of taste, though. On Sat, Aug 28, 2010 at 06:02:56PM +0300, Eduard - Gabriel Munteanu wrote: > This iterates over capabilities exposed by PCI devices. It's needed by > IOMMU initialization code

[Qemu-devel] Re: [PATCH 1/4] pci: expand tabs to spaces in pci_ids.h and pci_regs.h

On Sat, Aug 28, 2010 at 06:02:55PM +0300, Eduard - Gabriel Munteanu wrote: > The conversion was done using the GNU 'expand' tool (default settings) > to make it obey the SeaBIOS coding style. > > Signed-off-by: Eduard - Gabriel Munteanu Thanks Eduard. Patch 1 - I don't think we should reindent

Re: [Qemu-devel] Template for developing a Qemu device with PCIe?and MSI-X

On Thu, Sep 02, 2010 at 12:42:42PM -0500, Adnan Khaleel wrote: > I've tried everything you mentioned and I still get the same problem. The only > thing that seems to avoid that issue is if I reduce the aperture size from > 0x20ull to 0x200ull. I suppose that Cam is seeing the same issu

[Qemu-devel] [PATCH] ivshmem: remove unnecessary checks for unsigned

fixes gcc 4.1 warning: In function 'ivshmem_io_writel': 202: warning: comparison is always false due to limited range of data type 208: warning: comparison is always true due to limited range of data type Signed-off-by: Hidetoshi Seto --- hw/ivshmem.c |4 ++-- 1 files changed, 2 insertion

[Qemu-devel] Re: [PATCH] Use signed 16-bit values for ivshmem register writes

(2010/08/31 1:58), Cam Macdonell wrote: > fixes gcc 4.1 warning > > Signed-off-by: Cam Macdonell > --- > hw/ivshmem.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/ivshmem.c b/hw/ivshmem.c > index bbb5cba..fa9c684 100644 > --- a/hw/ivshmem.c > +++ b/hw/ivsh

[Qemu-devel] Re: [SeaBIOS] [PATCH] pciinit: remove unused variable, old_addr, in pci_set_io_region_addr().

On Mon, Aug 30, 2010 at 11:32:01AM +0900, Isaku Yamahata wrote: > old_addr is initialized, but not used. > remove the useless variable. > > Signed-off-by: Isaku Yamahata Thanks. -Kevin

[Qemu-devel] "sh: can't access tty; job control turned off" on Linux/SPARC w/ QEMU

I am currently working on QEMU emulating Linux/SPARC. I have compiled QEMU-0.12.5 and downloaded sparc-test-0.2.tar.gz from qemu.org website. When I have executed “qemu-g” which boots Linux/SPARC, the window appears but finally it generates the following error.

[Qemu-devel] correct bswap functions?

Hi, Is my guess that it's the bswapXX functions and not the bswap_XX functions that are supposed to be used outside of bswap.[ch]? Jonathan Kollasch

[Qemu-devel] [PATCH] Improve ATA IDENTIFY word 64 contents.

Fill in word 64 of IDENTIFY data to indicate support for PIO modes 3 and 4. This allows NetBSD guests to use UltraDMA modes instead of just PIO mode 0. --- hw/ide/core.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 3651d2b..2fa26f

Re: [Qemu-devel] [PATCH] Fill in word 64 of IDENTIFY data to indicate support for PIO modes 3 and 4. This allows NetBSD guests to use UltraDMA modes instead of just PIO mode 0.

On 03.09.2010, at 01:10, Jonathan A. Kollasch wrote: > In case it isn't obvious, git hates me, a lot. I may just give up on > this bug. Why? Things looked pretty good except for the subject line/content mess. When writing a patch, just make sure to have the subject be in the first line of the

[Qemu-devel] [PATCH 1/4] Fix compile of ivshmem on 32 bit hosts

The compile of ivshmem.c on my ppc system breaks with the following error: ivshmem.c: In function ‘check_shm_size’: ivshmem.c:356: error: format ‘%ld’ expects type ‘long int’, but argument 4 has type ‘__off64_t’ This patch adds an explicit cast, making printf happy. S

[Qemu-devel] [PATCH 3/4] PPC: Qdev'ify e500 pci

The e500 PCI controller isn't qdev'ified yet. This leads to severe issues when running with -drive. To be able to use a virtio disk with an e500 VM, let's convert the PCI controller over to qdev. Signed-off-by: Alexander Graf --- hw/ppce500_pci.c | 106 +

[Qemu-devel] [PATCH 2/4] KVM: PPC: Add level based interrupt logic

KVM on PowerPC used to have completely broken interrupt logic. Usually, interrupts work by having a PIC that pulls a line up/down, so the CPU knows that an interrupt is active. This line stays active until some action is done to the PIC to release the line. On KVM for PPC, we just checked if there

[Qemu-devel] [PULL 0/4] PPC updates

This time around I also included a fix for the shmem compile bug, as my tree wouldn't compile otherwise. The following changes since commit cb93bbdd7db92e50ff5e60a346b23df68acae46b: Blue Swirl (1): Fix OpenBSD linker warning are available in the git repository at: git://repo.or.cz/qe

[Qemu-devel] [PATCH 4/4] PPC: Make e500 pci byte swap config data

The config data field on the e500 pci controller is in little endian, so we need to enable byte swap there. Signed-off-by: Alexander Graf --- hw/ppce500_pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c index 3fa42d2..629b242 1006

Re: [Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

On Thu Sep 02, 2010 at 23:14:23 +0100, Peter Maydell wrote: > On Thu, Sep 02, 2010 at 11:40:50PM +0200, Adam Lackorzynski wrote: > > +case 7: > > +/* SMC? */ > > +if ((insn & 0xfff0) == 0xe1600070) { > > +goto illegal_op; > > +} > > +

Re: [Qemu-devel] [PATCH] Fill in word 64 of IDENTIFY data to indicate support for PIO modes 3 and 4. This allows NetBSD guests to use UltraDMA modes instead of just PIO mode 0.

In case it isn't obvious, git hates me, a lot. I may just give up on this bug. Jonathan Kollasch

[Qemu-devel] [PATCH] Fill in word 64 of IDENTIFY data to indicate support for PIO modes 3 and 4. This allows NetBSD guests to use UltraDMA modes instead of just PIO mode 0.

From: Jonathan A. Kollasch Signed-off-by: Jonathan A. Kollasch --- hw/ide/core.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 3651d2b..2fa26f4 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -139,6 +139,7 @@ static void ide_i

Re: [Qemu-devel] Template for developing a Qe mu device with PCIe and MSI-X

During bootup, I also see the following error message: pci :40:00.0: BAR 0 bad alignment 20: 0x00-0x1f Any idea whats causing this? AK _ From: Isaku Yamahata [mailto:yamah...@valinux.co.jp] To: Adnan Khaleel [mailto:ad...@khaleel.us] Cc: Cam Macdone

Re: [Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

On Thu, Sep 02, 2010 at 11:40:50PM +0200, Adam Lackorzynski wrote: > +case 7: > +/* SMC? */ > +if ((insn & 0xfff0) == 0xe1600070) { > +goto illegal_op; > +} > +/* bkpt */ This doesn't look right to me. SMC in the ARM encod

[Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

Handle smc as an undefined instruction instead of having it wrongly interpreted as some other one. Signed-off-by: Adam Lackorzynski --- target-arm/translate.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 6fcd

Re: [Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

Am 02.09.2010 22:27, schrieb Adam Lackorzynski: Handle smc as an undefined instruction instead of having it wrongly interpreted as some other one. Signed-off-by: Adam Lackorzynski --- target-arm/translate.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/target-a

[Qemu-devel] [PATCH -V5 23/28] virtio-9p: Fix the memset usage

From: Aneesh Kumar K.V The arguments are wrong. Use qemu_mallocz directly Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c index 4127439..a53b222

[Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

A via -kernel supplied x86_64 ELF image is being started in 32bit mode. Detect and exit if a 64bit image has been supplied. Signed-off-by: Adam Lackorzynski Acked-by: Alexander Graf --- hw/multiboot.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/multiboot.c

[Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

Handle smc as an undefined instruction instead of having it wrongly interpreted as some other one. Signed-off-by: Adam Lackorzynski --- target-arm/translate.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 6fcd

[Qemu-devel] [PATCH -V5 27/28] [virtio-9p] This patch implements TLERROR/RLERROR on the qemu 9P server.

From: Arun R Bharadwaj Signed-off-by: Arun R Bharadwaj Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p.c | 19 +-- hw/virtio-9p.h |2 ++ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c index 60a40b9..4b15ce7 100644 -

[Qemu-devel] [PATCH -V5 28/28] virtio-9p: Change handling of flags in open() path for 9P2000.L

From: Sripathi Kodi This patch applies on top of 9P2000.L patches that we have on the list. I took a look at how 9P server is handling open() flags in 9P2000.L path. I think we can do away with the valid_flags() function and simplify the code. The reasoning is as follows: O_NOCTTY: (If the file

[Qemu-devel] [PATCH -V5 21/28] virtio-9p: Add SM_NONE security model

From: Aneesh Kumar K.V This is equivalent to SM_PASSTHROUGH security model. The only exception is, failure of privilige operation like chown are ignored. This makes a passthrough like security model usable for people who runs kvm as non root Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkat

[Qemu-devel] [PATCH -V5 22/28] virtio-9p: Use lchown which won't follow symlink

From: Aneesh Kumar K.V We should always use functions which don't follow symlink on the server Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p-local.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/virtio-9p-local.c b/hw/vi

[Qemu-devel] [PATCH -V5 24/28] virtio-9p: Add support for removing xattr

From: Aneesh Kumar K.V Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h |1 + hw/virtio-9p-local.c | 17 + hw/virtio-9p.c | 25 - 3 files changed, 38 insertions(+), 5 deletions(-) diff --git a

[Qemu-devel] [PATCH -V5 18/28] virtio-9p: Implement TXATTRWALK

From: Aneesh Kumar K.V TXATTRWALK: Descend a ATTR namespace size[4] TXATTRWALK tag[2] fid[4] newfid[4] name[s] size[4] RXATTRWALK tag[2] size[8] txattrwalk gets a fid pointing to xattr. This fid can later be used to get read the xattr value. If name is NULL the fid returned can be used to get

[Qemu-devel] [PATCH -V5 20/28] virtio-9p: Hide user.virtfs xattr in case of mapped security.

From: Aneesh Kumar K.V With mapped security mode we use "user.virtfs" namespace is used to store the virtFs related attributes. So hide it from user. Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p-local.c | 71

[Qemu-devel] [PATCH -V5 14/28] qemu: virtio-9p: Implement TMKDIR

From: M. Mohan Kumar Synopsis size[4] Tmkdir tag[2] fid[4] name[s] mode[4] gid[4] size[4] Rmkdir tag[2] qid[13] Description mkdir asks the file server to create a directory with given name, mode and gid. The qid for the new directory is returned with the mkdir reply messag

[Qemu-devel] [PATCH -V5 25/28] virtio-9p: Make sure -virtfs option works correctly

From: Aneesh Kumar K.V When making copy of arguments we were doing partial copy Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri --- vl.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index 9f7358e..df11ab3 100644 --- a/vl.c +++

[Qemu-devel] [PATCH -V5 11/28] [virtio-9p] Define and implement TSYMLINK for 9P2000.L

This patch implements creating a symlink for TSYMLINK request and responds with RSYMLINK. In the case of error, we return RERROR. SYNOPSIS size[4] Tsymlink tag[2] fid[4] name[s] symtgt[s] gid[4] size[4] Rsymlink tag[2] qid[13] DESCRIPTION Create a symbolic link named 'name' poi

[Qemu-devel] [PATCH -V5 19/28] virtio-9p: Implement TXATTRCREATE

From: Aneesh Kumar K.V TXATTRCREATE: Prepare a fid for setting xattr value on a file system object. size[4] TXATTRCREATE tag[2] fid[4] name[s] attr_size[8] flags[4] size[4] RXATTRWALK tag[2] txattrcreate gets a fid pointing to xattr. This fid can later be used to get set the xattr value. fl

[Qemu-devel] [PATCH -V5 17/28] virtio-9p: Add fidtype so that we can do type specific operation

From: Aneesh Kumar K.V We want to add type specific operation during read/write Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p.c | 110 --- hw/virtio-9p.h | 24 +++- 2 files changed, 78 ins

[Qemu-devel] [PATCH -V5 26/28] [virtio-9p] Remove all instances of unnecessary dotu variable.

From: Arun R Bharadwaj Signed-off-by: Arun R Bharadwaj Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p-debug.c | 26 hw/virtio-9p-debug.h |1 - hw/virtio-9p.c | 115 +++--- 3 files changed, 61 insertions(+), 81 delet

[Qemu-devel] [PATCH -V5 08/28] [virtio-9p] Make v9fs_do_utimensat accept timespec structures instead of v9stat.

From: Sripathi Kodi Currently v9fs_do_utimensat takes a V9fsStat argument and builds timespec structures. It sets tv_nsec values to 0 by default. Instead of this it should take struct timespec[2] and pass it down to the system directly. This will make it more generic and useful elsewhere. Signed

[Qemu-devel] [PATCH -V5 16/28] [virtio-9p] qemu: virtio-9p: Implement LOPEN

From: M. Mohan Kumar Implement 9p2000.L version of open(LOPEN) interface in qemu 9p server. For LOPEN, no need to convert the flags to and from 9p mode to VFS mode. Synopsis: size[4] Tlopen tag[2] fid[4] mode[4] size[4] Rlopen tag[2] qid[13] iounit[4] Current qemu 9p server does not

[Qemu-devel] [PATCH -V5 13/28] qemu: virtio-9p: Implement TMKNOD

From: M. Mohan Kumar Implement TMKNOD as part of 2000.L Work Synopsis size[4] Tmknod tag[2] fid[4] name[s] mode[4] major[4] minor[4] gid[4] size[4] Rmknod tag[2] qid[13] Description mknod asks the file server to create a device node with given device type, mode and gid. The q

[Qemu-devel] [PATCH -V5 15/28] rename - change name of file or directory

From: M. Mohan Kumar size[4] Trename tag[2] fid[4] newdirfid[4] name[s] size[4] Rrename tag[2] Implement the 2000.L rename operation. A new function v9fs_complete_rename is introduced that acts as a common entry point for 2000.L rename operation and 2000.U rename opearation (via wstat). As part

[Qemu-devel] [PATCH -V5 09/28] virtio-9p: Implement server side of setattr for 9P2000.L protocol.

From: Sripathi Kodi SYNOPSIS size[4] Tsetattr tag[2] attr[n] size[4] Rsetattr tag[2] DESCRIPTION The setattr command changes some of the file status information. attr resembles the iattr structure used in Linux kernel. It specifies which status parameter is to

[Qemu-devel] [PATCH -V5 12/28] [virtio-9p] This patch implements TLCREATE for 9p2000.L protocol.

SYNOPSIS size[4] Tlcreate tag[2] fid[4] name[s] flags[4] mode[4] gid[4] size[4] Rlcreate tag[2] qid[13] iounit[4] DESCRIPTION The Tlreate request asks the file server to create a new regular file with the name supplied, in the directory (dir) represented by fid. The mode argument specif

[Qemu-devel] [PATCH -V5 10/28] [virtio-9p] Implement TLINK for 9P2000.L

Create a Hardlink. SYNOPSIS size[4] Tlink tag[2] dfid[4] oldfid[4] newpath[s] size[4] Rlink tag[2] DESCRIPTION Create a link 'newpath' in directory pointed by dfid linking to oldfid path. Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p-debug.c |9 + hw/virtio-9p.c

[Qemu-devel] [PATCH -V5 06/28] virtio-9p: getattr server implementation for 9P2000.L protocol.

From: Sripathi Kodi SYNOPSIS size[4] Tgetattr tag[2] fid[4] request_mask[8] size[4] Rgetattr tag[2] lstat[n] DESCRIPTION The getattr transaction inquires about the file identified by fid. request_mask is a bit mask

[Qemu-devel] [PATCH -V5 07/28] virtio-9p: Do not reset atime

From: M. Mohan Kumar Current code resets file's atime to 0 when there is a change in mtime. This results in resetting the atime to "1970-01-01 05:30:00". For example, truncate -s 0 filename results in changing the mtime to the truncate time, but resets the atime to "1970-01-01 05:

[Qemu-devel] [PATCH -V5 02/28] qemu: virtio-9p: Implement statfs support in server

From: M. Mohan Kumar Implement statfs support in qemu server based on Sripathi's initial statfs patch. Signed-off-by: M. Mohan Kumar Signed-off-by: Sripathi Kodi Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h |1 + hw/virtio-9p-local.c |6 hw/virtio-9p.c |

[Qemu-devel] [PATCH -V5 03/28] virtio-9p: Return correct error from v9fs_remove

From: Sripathi Kodi Signed-off-by: Sripathi Kodi In v9fs_remove_post_remove() we currently ignore the error returned by the previous call to remove() and return an error only if freeing the fid fails. However, the client expects to see the error from remove(). Currently the client falsely think

[Qemu-devel] [PATCH -V5 05/28] virtio-9p: Compute iounit based on host filesystem block size

From: M. Mohan Kumar Compute iounit based on the host filesystem block size and pass it to client with open/create response. Also return iounit as statfs's f_bsize for optimal block size transfers. Signed-off-by: M. Mohan Kumar Reviewd-by: Sripathi Kodi Signed-off-by: Venkateswararao Jujjuri

[Qemu-devel] [PATCH -V5 01/28] qemu: virtio-9p: Recognize 9P2000.L protocol

From: M. Mohan Kumar Make 9P server recognize 9P2000.L protocol version Signed-off-by: M. Mohan Kumar Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p.c |6 +- hw/virtio-9p.h |6 ++ 2 files changed, 11 insertions(+), 1 deletions(-) diff --git a/hw/virtio-9p.c b/hw/virt

[Qemu-devel] [PATCH -V5 04/28] [V4] virtio-9p: readdir implementation for 9p2000.L

From: Sripathi Kodi This patch implements the server part of readdir() implementation for 9p2000.L SYNOPSIS size[4] Treaddir tag[2] fid[4] offset[8] count[4] size[4] Rreaddir tag[2] count[4] data[count] DESCRIPTION The readdir request asks the server to read the directory

[Qemu-devel] [PATCH-V5 00/28] Consolidated VirtFS work

This patch series is a consolidated view of various VirtFS patches on the Mailing List. None of these patches are new in this series. For sometime all these patches were on the mainling list individually. Changes from V4: - Added two patches: o 0024-virtio-9p-Add-support-for-removing-xattr.pat

[Qemu-devel] gdb for sparc64?

Does any gdb version work with current qemu-system-sparc64 ? I tried 7.1 and 6.8 with --target=sparc64-linux and --target=sparc64 And result seems to be pretty much the same: GNU gdb 6.8 Copyright (C) 2008 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later

Re: [Qemu-devel] Template for developing a Qe mu device with PCIe and MSI-X

I've tried everything you mentioned and I still get the same problem. The only thing that seems to avoid that issue is if I reduce the aperture size from 0x20ull to 0x200ull. Here is the relevant section of code: static const unsigned long long BAR_Regions[6][2] = { // len , ty

Re: [Qemu-devel] [PATCH] raw-posix: Don't use file name for host_cdrom detection on Linux

On Thu, Sep 02, 2010 at 05:50:09PM +0200, Kevin Wolf wrote: > On Linux, we have code to detect CD-ROMs using an ioctl. We shouldn't lose > anything but false positives by removing the check for a /dev/cd* path. Agreed. Reviewed-by: Christoph Hellwig

[Qemu-devel] [PATCH v2 0/4] virtio-net: More configurability and bh handling for tx

Incorporated feedback. txburst= and txtimer= are now "x-" prefixed developer options. I added a tx= option, because I do want there to be a supported way to switch between TX strategies. This also drops the magic value of txtimer= 1 or 0 (setting default timeout or switching modes). I also drop

Re: [Qemu-devel] [PATCH 2/7] pci: memory access API and IOMMU support

On Thu, Sep 02, 2010 at 06:05:39PM +0200, Stefan Weil wrote: > Am 02.09.2010 10:51, schrieb Eduard - Gabriel Munteanu: [snip] > >> The functions pci_memory_read and pci_memory_write not only read > >> or write byte data but many different data types which leads to > >> a lot of type casts in your

[Qemu-devel] [PATCH] virtio-9p: Make sure -virtfs option works correctly

When making copy of arguments we were doing partial copy Signed-off-by: Aneesh Kumar K.V --- vl.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index 9f7358e..df11ab3 100644 --- a/vl.c +++ b/vl.c @@ -2332,7 +2332,7 @@ int main(int argc, char **argv, char

[Qemu-devel] Re: [PATCH 4/7] ide: use the PCI memory access interface

On 09/02/2010 06:39 PM, Michael S. Tsirkin wrote: On Thu, Sep 02, 2010 at 06:24:25PM +0300, Avi Kivity wrote: That's not a practical long term solution. Eventually everything gets turned on. That's why I wanted a simple !iommu check and fallback. This way unless it's really used there's no ov

Re: [Qemu-devel] [PATCH] scsi-generic: don't report negative length to the SCSI adapter

Am 02.09.2010 16:32, schrieb ext Kevin Wolf: Can we add a comment why len can become< 0 and that this is a workaround for buggy drivers? It's in your commit message, but I prefer this kind of things to be explained in the code. Yes I will do that, if we decide to apply this patch (see belo

Re: [Qemu-devel] [PATCH 2/7] pci: memory access API and IOMMU support

Am 02.09.2010 10:51, schrieb Eduard - Gabriel Munteanu: On Wed, Sep 01, 2010 at 10:10:30PM +0200, Stefan Weil wrote: Please see my comments at the end of this mail. Am 30.08.2010 00:08, schrieb Eduard - Gabriel Munteanu: PCI devices should access memory through pci_memory_*() instea

[Qemu-devel] [PATCH] raw-posix: Don't use file name for host_cdrom detection on Linux

On Linux, we have code to detect CD-ROMs using an ioctl. We shouldn't lose anything but false positives by removing the check for a /dev/cd* path. Signed-off-by: Kevin Wolf --- block/raw-posix.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/block/raw-posix.c b/block/

[Qemu-devel] Re: [PATCH 4/7] ide: use the PCI memory access interface

On Thu, Sep 02, 2010 at 06:24:25PM +0300, Avi Kivity wrote: > That's not a practical long term solution. Eventually everything > gets turned on. That's why I wanted a simple !iommu check and fallback. This way unless it's really used there's no overhead. > I don't really see a problem with the a

[Qemu-devel] [PATCH v2 3/4] virtio-net: Rename tx_timer_active to tx_waiting

De-couple this from the timer since we might want to use different backends to send the packet. Signed-off-by: Alex Williamson --- hw/virtio-net.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 55f3d94..1a4ba21 1

[Qemu-devel] Re: [PATCH v2 0/4] virtio-net: More configurability and bh handling for tx

On Thu, Sep 02, 2010 at 09:00:42AM -0600, Alex Williamson wrote: > Incorporated feedback. txburst= and txtimer= are now "x-" prefixed > developer options. I added a tx= option, because I do want there to > be a supported way to switch between TX strategies. This also drops > the magic value of t

[Qemu-devel] Re: [PATCH 4/7] ide: use the PCI memory access interface

On Thu, Sep 02, 2010 at 06:01:35PM +0300, Eduard - Gabriel Munteanu wrote: > On Thu, Sep 02, 2010 at 12:58:13PM +0300, Michael S. Tsirkin wrote: > > On Thu, Sep 02, 2010 at 12:12:00PM +0300, Eduard - Gabriel Munteanu wrote: > > > On Thu, Sep 02, 2010 at 08:19:11AM +0300, Michael S. Tsirkin wrote: >

[Qemu-devel] [PATCH v2 4/4] virtio-net: Introduce a new bottom half packet TX

Based on a patch from Mark McLoughlin, this patch introduces a new bottom half packet transmitter that avoids the latency imposed by the tx_timer approach. Rather than scheduling a timer when a TX packet comes in, schedule a bottom half to be run from the iothread. The bottom half handler first at

[Qemu-devel] Re: [PATCH 4/7] ide: use the PCI memory access interface

On Thu, Sep 02, 2010 at 12:58:13PM +0300, Michael S. Tsirkin wrote: > On Thu, Sep 02, 2010 at 12:12:00PM +0300, Eduard - Gabriel Munteanu wrote: > > On Thu, Sep 02, 2010 at 08:19:11AM +0300, Michael S. Tsirkin wrote: > > > On Sat, Aug 28, 2010 at 05:54:55PM +0300, Eduard - Gabriel Munteanu wrote: >

[Qemu-devel] Re: [PATCH 4/7] ide: use the PCI memory access interface

On 09/02/2010 06:01 PM, Eduard - Gabriel Munteanu wrote: On Thu, Sep 02, 2010 at 12:58:13PM +0300, Michael S. Tsirkin wrote: On Thu, Sep 02, 2010 at 12:12:00PM +0300, Eduard - Gabriel Munteanu wrote: On Thu, Sep 02, 2010 at 08:19:11AM +0300, Michael S. Tsirkin wrote: On Sat, Aug 28, 2010 at 0

[Qemu-devel] [PATCH v2 1/4] virtio-net: Make tx_timer timeout configurable

Add an option to make the TX mitigation timer adjustable as a device option. The 150us hard coded default used currently is reasonable, but may not be suitable for all workloads, this gives us a way to adjust it using a single binary. We can't support any random option though, so use the "x-" pre

[Qemu-devel] [PATCH v2 2/4] virtio-net: Limit number of packets sent per TX flush

If virtio_net_flush_tx() is called with notification disabled, we can race with the guest, processing packets at the same rate as they get produced. The trouble is that this means we have no guaranteed exit condition from the function and can spend minutes in there. Currently flush_tx is only call

Re: [Qemu-devel] [PATCH] lsi53c895a: avoid calling a NULL function

Am 02.09.2010 15:37, schrieb Bernhard Kohl: > In scsi-generic the reset() function is not available. > > Signed-off-by: Bernhard Kohl > --- > hw/lsi53c895a.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c > index 5eaf69e..01ff0

Re: [Qemu-devel] [PATCH] scsi-generic: don't report negative length to the SCSI adapter

Am 02.09.2010 15:27, schrieb Bernhard Kohl: > Some drivers report an incorrect number for 'resid'. I found that for > MODE_SENSE(6) on an IET iSCSI device. This device reports the > available mode data length minus actually transferred length. > > This is already a known problem: > http://tldp.org

[Qemu-devel] [PATCH] lsi53c895a: avoid calling a NULL function

In scsi-generic the reset() function is not available. Signed-off-by: Bernhard Kohl --- hw/lsi53c895a.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c index 5eaf69e..01ff028 100644 --- a/hw/lsi53c895a.c +++ b/hw/lsi53c895a.c @@ -1597

[Qemu-devel] [PATCH] scsi-generic: don't report negative length to the SCSI adapter

Some drivers report an incorrect number for 'resid'. I found that for MODE_SENSE(6) on an IET iSCSI device. This device reports the available mode data length minus actually transferred length. This is already a known problem: http://tldp.org/HOWTO/SCSI-Generic-HOWTO/x356.html Signed-off-by: Bern

Re: [Qemu-devel] [PATCH 2/7] pci: memory access API and IOMMU support

On 09/02/2010 04:08 AM, Eduard - Gabriel Munteanu wrote: On Thu, Sep 02, 2010 at 09:00:46AM +0300, Michael S. Tsirkin wrote: On Wed, Sep 01, 2010 at 10:10:30PM +0200, Stefan Weil wrote: +static inline void pci_memory_read(PCIDevice *dev, + pcibus_t addr, + uint8_t *buf, + pcibus_t len

[Qemu-devel] Re: [PATCH 0/6 v3] introduce qbus reset callback and pci bus reset clean up

On 09/02/2010 04:25 AM, Isaku Yamahata wrote: I recreated the patch series based on your qbus walker of git://repo.or.cz/qemu/aliguori.git Anthony, can you please review the first three patches and merge them if okay? They look really nice, I'll merge them into my branch. BTW what's the

[Qemu-devel] [PATCH] scsi-disk: add some optional scsi commands

I use a legacy OS which depends on some optional SCSI commands. In fact this implementation does nothing special, but provides minimum support for the following commands: REZERO UNIT WRITE AND VERIFY(10) WRITE AND VERIFY(12) WRITE AND VERIFY(16) MODE SELECT(6) MODE SELECT(10) SEEK(6) SEEK(10) ---

[Qemu-devel] information about PL110 LCD controller

Hi every body, I'm a newbie about the qemu word but I'd like to emulate the versatile ARM platform. In particular I'm very interested in knowing how much the emulation of PL110 LCD controller fits the real hardware. Are some features uncovered? Where can I find the source code for this controll

[Qemu-devel] Re: [PATCH 4/7] ide: use the PCI memory access interface

On Thu, Sep 02, 2010 at 12:12:00PM +0300, Eduard - Gabriel Munteanu wrote: > On Thu, Sep 02, 2010 at 08:19:11AM +0300, Michael S. Tsirkin wrote: > > On Sat, Aug 28, 2010 at 05:54:55PM +0300, Eduard - Gabriel Munteanu wrote: > > > Emulated PCI IDE controllers now use the memory access interface. Thi

[Qemu-devel] Re: [PATCH] qemu-io: Make alloc output useful when nb_sectors=1

Am 02.09.2010 11:38, schrieb Stefan Hajnoczi: > There is no indication whether or not the sector is allocated when > nb_sectors=1: > > sector allocated at offset 64 KiB > > This message is produced whether or not the sector is allocated. > > Simply use the same message as the plural case, I do

[Qemu-devel] Re: [PATCH 2/7] pci: memory access API and IOMMU support

On Thu, Sep 02, 2010 at 11:40:58AM +0300, Eduard - Gabriel Munteanu wrote: > On Thu, Sep 02, 2010 at 08:28:26AM +0300, Michael S. Tsirkin wrote: > > On Sat, Aug 28, 2010 at 05:54:53PM +0300, Eduard - Gabriel Munteanu wrote: > > > PCI devices should access memory through pci_memory_*() instead of >

[Qemu-devel] [PATCH] qemu-io: Make alloc output useful when nb_sectors=1

There is no indication whether or not the sector is allocated when nb_sectors=1: sector allocated at offset 64 KiB This message is produced whether or not the sector is allocated. Simply use the same message as the plural case, I don't think the English is so broken that we need special case o

[Qemu-devel] [Bug 568445] Re: LVM backed drives should default to cache='none'

** Bug watch added: Red Hat Bugzilla #623188 https://bugzilla.redhat.com/show_bug.cgi?id=623188 ** Also affects: virt-manager via https://bugzilla.redhat.com/show_bug.cgi?id=623188 Importance: Unknown Status: Unknown -- LVM backed drives should default to cache='none' https://bug

[Qemu-devel] Re: [PATCH 4/7] ide: use the PCI memory access interface

On Thu, Sep 02, 2010 at 08:19:11AM +0300, Michael S. Tsirkin wrote: > On Sat, Aug 28, 2010 at 05:54:55PM +0300, Eduard - Gabriel Munteanu wrote: > > Emulated PCI IDE controllers now use the memory access interface. This > > also allows an emulated IOMMU to translate and check accesses. > > > > Map

[Qemu-devel] [PATCH 1/6] qdev: Make qbus_walk_children() call busfn for root bus.

Make qbus_walk_children() call busfn for root bus. and it fixes qbus_realize_all(). The current qbus_walk_children() doesn't call busfn for root bus. It cause qbus_relialize_all() to fail to call realize the system bus. This patch also refactor qbus_walk_children() a bit. Another only user of busf

[Qemu-devel] [PATCH 2/6] qdev: introduce reset call back for qbus level.

and make it called via qbus_reset_all(). The qbus reset callback will be used by pci bus reset. Signed-off-by: Isaku Yamahata --- hw/qdev-core.h |3 +++ hw/qdev.c | 10 +- 2 files changed, 12 insertions(+), 1 deletions(-) diff --git a/hw/qdev-core.h b/hw/qdev-core.h index a9b

[Qemu-devel] [PATCH 3/6] qdev: introduce a helper function which triggers reset from a given device.

introduce a helper function which triggers reset on device tree from a given device. Signed-off-by: Isaku Yamahata --- hw/qdev-core.h |1 + hw/qdev.c |5 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/qdev-core.h b/hw/qdev-core.h index 49ac87a..20ebe1f 10064

[Qemu-devel] [PATCH 0/6 v3] introduce qbus reset callback and pci bus reset clean up

I recreated the patch series based on your qbus walker of git://repo.or.cz/qemu/aliguori.git Anthony, can you please review the first three patches and merge them if okay? BTW what's the merge plan of the repo? Any chance to merge the walker part first? Patch description: Introduce bus reset call

[Qemu-devel] [PATCH 5/6] pci: teach pci devices that have reset callback how to reset common registers.

teach pci devices that have reset callback how to reset common registers. Signed-off-by: Isaku Yamahata --- hw/e1000.c |1 + hw/lsi53c895a.c |2 ++ hw/pci.c|6 -- hw/pcnet.c |1 + hw/rtl8139.c|2 ++ hw/virtio-pci.c |1 + 6 files changed, 7 insert

[Qemu-devel] [PATCH 4/6] pci: make pci reset use qdev reset frame work.

make pci reset use qdev reset frame work. Signed-off-by: Isaku Yamahata --- hw/pci.c | 38 ++ hw/pci.h |2 ++ 2 files changed, 36 insertions(+), 4 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 655fead..4c99390 100644 --- a/hw/pci.c +++ b/hw/pci.c

[Qemu-devel] [PATCH 6/6] pci bridge: implement secondary bus reset.

implement secondary bus reset. Signed-off-by: Isaku Yamahata --- hw/pci.c | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index e23ac1b..183f595 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -1626,6 +1626,9 @@ static void pci_bridge_update_mapp

Re: [Qemu-devel] [PATCH 2/7] pci: memory access API and IOMMU support

On Thu, Sep 02, 2010 at 09:00:46AM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 01, 2010 at 10:10:30PM +0200, Stefan Weil wrote: > > >+static inline void pci_memory_read(PCIDevice *dev, > > >+ pcibus_t addr, > > >+ uint8_t *buf, > > >+ pcibus_t len) > > >+{ > > >+ pci_memory_rw(dev, addr, buf, le

Re: [Qemu-devel] [PATCH 2/7] pci: memory access API and IOMMU support

On Wed, Sep 01, 2010 at 10:10:30PM +0200, Stefan Weil wrote: > Please see my comments at the end of this mail. > > > Am 30.08.2010 00:08, schrieb Eduard - Gabriel Munteanu: > > PCI devices should access memory through pci_memory_*() instead of > > cpu_physical_memory_*(). This also provides suppo

  1   2   >