On 08/31/2010 12:54 AM, Juan Quintela wrote:
Please send in any agenda items you are interested in covering.
zero (dot|point) thirteen schedule
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
jes.soren...@redhat.com wrote:
> From: Jes Sorensen
>
> There is no need to check for dest < 0 or vector >= 0 as both are
> uint16_t.
>
> This should fix problems with broken build with aggressive compiler
> flags. Reported by Xudong Hao
>
> Signed-off-by: Jes Sorensen
> ---
> hw/ivshmem.c |
On Mon, Aug 30, 2010 at 07:07:11PM +, Blue Swirl wrote:
> On Mon, Aug 30, 2010 at 11:19 AM, Gleb Natapov wrote:
> > On Mon, Aug 30, 2010 at 05:35:20PM +0900, Isaku Yamahata wrote:
> >> On Mon, Aug 30, 2010 at 10:59:19AM +0300, Avi Kivity wrote:
> >> > On 08/30/2010 10:49 AM, Isaku Yamahata wr
On (Mon) Aug 30 2010 [14:17:51], Adam Litke wrote:
> The addition of memory stats reporting to the virtio balloon causes
> the 'info balloon' command to become asynchronous. This is a regression
> because management tools that consume this command were not designed to
> handle lost or delayed resp
Hi All,
Having gone through the documentation (developers) and source code, I couple
of questions:
1. For a microcontroller which doesn't have any OS support, can QEMU be
ported without any OS ?
2. Can QEMU be used as a simple instruction set simulator with probably gdb
support for remote debuggi
On Mon, Aug 30, 2010 at 07:59:22AM -0500, Anthony Liguori wrote:
> On 08/30/2010 02:49 AM, Isaku Yamahata wrote:
>> Distinguish warm reset from cold reset by introducing
>> cold/warm reset helper function instead of single reset routines.
>>
>> Signed-off-by: Isaku Yamahata
>> ---
>> hw/hw.h |
On 08/30/2010 04:54 PM, Juan Quintela wrote:
Please send in any agenda items you are interested in covering.
- QMP/QPI
Regards,
Anthony Liguori
thanks,
Juan.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majo
Please send in any agenda items you are interested in covering.
thanks,
Juan.
On Mon, Aug 30, 2010 at 8:42 PM, Blue Swirl wrote:
> On Mon, Aug 30, 2010 at 8:10 PM, malc wrote:
>> On Mon, 30 Aug 2010, Blue Swirl wrote:
>>
>>> On Mon, Aug 30, 2010 at 1:27 PM, Stefan Hajnoczi
>>> wrote:
>>> > This patch introduces the trace-events file where trace events can be
>>> > declare
On Mon, Aug 30, 2010 at 8:10 PM, malc wrote:
> On Mon, 30 Aug 2010, Blue Swirl wrote:
>
>> On Mon, Aug 30, 2010 at 1:27 PM, Stefan Hajnoczi
>> wrote:
>> > This patch introduces the trace-events file where trace events can be
>> > declared like so:
>> >
>> > qemu_malloc(size_t size) "size %zu"
>>
On Mon, 30 Aug 2010, Blue Swirl wrote:
> On Mon, Aug 30, 2010 at 1:27 PM, Stefan Hajnoczi
> wrote:
> > This patch introduces the trace-events file where trace events can be
> > declared like so:
> >
> > qemu_malloc(size_t size) "size %zu"
> > qemu_free(void *ptr) "ptr %p"
> >
> > These trace even
On 08/30/2010 02:36 PM, Blue Swirl wrote:
On Mon, Aug 30, 2010 at 7:25 PM, Anthony Liguori wrote:
On 08/30/2010 02:16 PM, Blue Swirl wrote:
On Mon, Aug 30, 2010 at 1:03 PM, Anthony Liguori
wrote:
On 08/30/2010 03:50 AM, Paolo Bonzini wrote:
On 08/30/2010 09:49
On 08/30/2010 08:48 AM, Anthony Liguori wrote:
> MyDeviceInfo device_infos[] = { {"foo", 0, 2}, {"bar", 0, 1}, {} /*
> or { 0 } */ };
>
> This is such a pervasive idiom that there's simply no way that GCC
> can possibly try to warn against this.
GCC only warns for this if you explicitly ask for i
On Mon, Aug 30, 2010 at 7:32 PM, Gerd Hoffmann wrote:
> On 08/30/10 21:02, Anthony Liguori wrote:
>>
>> On 08/30/2010 01:58 PM, Blue Swirl wrote:
>>>
>>> Wilful misconduct? May I ask if there are other things that you don't
>>> agree with and you are covertly working against?
>
> I'm just not used
On Mon, Aug 30, 2010 at 1:27 PM, Stefan Hajnoczi
wrote:
> This patch introduces the trace-events file where trace events can be
> declared like so:
>
> qemu_malloc(size_t size) "size %zu"
> qemu_free(void *ptr) "ptr %p"
>
> These trace event declarations are processed by a new tool called
> tracet
On 08/30/2010 11:27 AM, Anthony Liguori wrote:
> On 08/30/2010 01:19 PM, Jes Sorensen wrote:
>>
>> I totally agree on this. The problem with having such arguments
>> passed in is that you never know if they were used in the past and
>> it was forgotten when the code using them was removed, or if i
On Mon, Aug 30, 2010 at 7:25 PM, Anthony Liguori wrote:
> On 08/30/2010 02:16 PM, Blue Swirl wrote:
>>
>> On Mon, Aug 30, 2010 at 1:03 PM, Anthony Liguori
>> wrote:
>>
>>>
>>> On 08/30/2010 03:50 AM, Paolo Bonzini wrote:
>>>
On 08/30/2010 09:49 AM, Isaku Yamahata wrote:
>
>
On 08/30/10 21:02, Anthony Liguori wrote:
On 08/30/2010 01:58 PM, Blue Swirl wrote:
Wilful misconduct? May I ask if there are other things that you don't
agree with and you are covertly working against?
I'm just not used to it. Changing habits takes time.
I think I became better meanwhile o
On 08/30/2010 02:16 PM, Blue Swirl wrote:
On Mon, Aug 30, 2010 at 1:03 PM, Anthony Liguori wrote:
On 08/30/2010 03:50 AM, Paolo Bonzini wrote:
On 08/30/2010 09:49 AM, Isaku Yamahata wrote:
+/* those two functions are obsoleted by cold/warm reset API. */
[qemu_register_reset/
On Mon, Aug 30, 2010 at 3:35 PM, wrote:
> From: Jes Sorensen
>
> Hi,
>
> I started building QEMU with some more aggressive error flags to see
> what dropped out. I started fixing up some of the cases, removing
> unused arguments to functions, comparisons of unsigned types against
> negative valu
Just got back from vacation and saw this thread. I agree with Anthony
that the best thing to do is disable the memory stats interface for
0.13. We need to fix the underlying problems in qemu with respect to
asynchronous commands first, then we can look at re-enabling the
feature.
The virtio feat
On Mon, Aug 30, 2010 at 1:03 PM, Anthony Liguori wrote:
> On 08/30/2010 03:50 AM, Paolo Bonzini wrote:
>>
>> On 08/30/2010 09:49 AM, Isaku Yamahata wrote:
>>>
>>> +/* those two functions are obsoleted by cold/warm reset API. */
>>> [qemu_register_reset/qemu_unregister_reset]
>>
>> Are they?
>
> Ye
On Mon, Aug 30, 2010 at 11:19 AM, Gleb Natapov wrote:
> On Mon, Aug 30, 2010 at 05:35:20PM +0900, Isaku Yamahata wrote:
>> On Mon, Aug 30, 2010 at 10:59:19AM +0300, Avi Kivity wrote:
>> > On 08/30/2010 10:49 AM, Isaku Yamahata wrote:
>> >> This patch set distinguish warm reset from cold reset by
On 08/30/2010 01:58 PM, Blue Swirl wrote:
Wilful misconduct? May I ask if there are other things that you don't
agree with and you are covertly working against?
:-)
Braces should be used. The discussion was about enforcing coding style
at commit time and reformatting code.
But for the
On Mon, Aug 30, 2010 at 8:48 AM, Gerd Hoffmann wrote:
> On 08/28/10 08:42, Blue Swirl wrote:
>>
>> On Fri, Aug 27, 2010 at 9:59 AM, Gerd Hoffmann wrote:
>>>
>>> Hi,
>>>
>>> Here comes v4 of the iniial spice support patch series, hopefully the
>>> final version. It brings just the very basic bit
On 08/30/2010 01:19 PM, Jes Sorensen wrote:
I totally agree on this. The problem with having such arguments passed
in is that you never know if they were used in the past and it was
forgotten when the code using them was removed, or if it's new code, in
which case they do deserve the extra scrut
On 08/30/10 18:55, Nathan Froyd wrote:
> On Mon, Aug 30, 2010 at 10:48:55AM -0500, Anthony Liguori wrote:
>> No, this is GCC being stupid.
>>
>> How else do you terminate a list? IOW:
>>
>> MyDeviceInfo device_infos[] = {
>> {"foo", 0, 2},
>> {"bar", 0, 1},
>> {} /* or { 0 } */
>> };
>>
>> T
On 08/30/10 18:40, Paolo Bonzini wrote:
> On 08/30/2010 06:16 PM, Anthony Liguori wrote:
>> This is why this type of warning sucks. Passing BlockDriverState is a
>> matter of readability because these are roughly methods. Just because
>> 'this' isn't used right now, doesn't mean that it should no
From: Jes Sorensen
Do not store return of get_image_size() in a uint32_t as it makes it
impossible to detect error returns from get_image_size.
Signed-off-by: Jes Sorensen
---
hw/multiboot.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/multiboot.c b/hw/multiboot
On 08/30/2010 06:29 PM, Anthony Liguori wrote:
Arguably, an empty initializer should be special cased, but it
isn't.
So the warning is for old style initializer lists? I disagree that
it's a valid warning. First, {} is ambiguous as it can be an empty
list of c99 initializers and an empty list
in_sg[].iovec and out_sg[].ioved are pointer to (source) host memory and
therefore invalid after migration. When loading the device state we must
create a new mapping on the destination host.
Signed-off-by: Kevin Wolf
(cherry picked from commit b6a4805b55b409134dc712677fdc4f6a8795e965)
---
hw/vi
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
qemu-config.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/qemu-config.c b/qemu-config.c
index 3abe655..1efdbec 100644
--- a/qemu-config.c
+++ b/qemu-config.c
@@ -80,7 +80,7 @@ static QemuOptsList qemu_dri
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
qemu-nbd.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index 9cc8f47..67ce50b 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -417,7 +417,10 @@ int main(int argc, char **argv)
From: Jes Sorensen
Hi,
I started building QEMU with some more aggressive error flags to see
what dropped out. I started fixing up some of the cases, removing
unused arguments to functions, comparisons of unsigned types against
negative values etc. and a few other minor changes to avoid compiler
On 08/30/10 18:29, Anthony Liguori wrote:
> On 08/30/2010 11:18 AM, Paolo Bonzini wrote:
>> It falls under the "missing fields in initializer" warning. Arguably,
>> an empty initializer should be special cased, but it isn't.
>
> So the warning is for old style initializer lists? I disagree that
On 08/30/10 18:56, malc wrote:
> On Mon, 30 Aug 2010, Anthony Liguori wrote:
>
>> On 08/30/2010 10:35 AM, jes.soren...@redhat.com wrote:
>>> From: Jes Sorensen
>>> diff --git a/linux-aio.c b/linux-aio.c
>>> index 68f4b3d..3240996 100644
>>> --- a/linux-aio.c
>>> +++ b/linux-aio.c
>>> @@ -118,7 +11
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
block/qcow2-cluster.c | 17 -
block/qcow2.c | 10 +-
block/qcow2.h |7 +++
3 files changed, 16 insertions(+), 18 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
linux-aio.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/linux-aio.c b/linux-aio.c
index 68f4b3d..3240996 100644
--- a/linux-aio.c
+++ b/linux-aio.c
@@ -118,7 +118,7 @@ static void qemu_laio_completion_cb(void *opaq
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
block/qcow.c | 13 ++---
1 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/block/qcow.c b/block/qcow.c
index 816103d..c4d8cb3 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -214,9 +214,8 @@ static int qcow_set_key(BlockD
fixes gcc 4.1 warning
Signed-off-by: Cam Macdonell
---
hw/ivshmem.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/ivshmem.c b/hw/ivshmem.c
index bbb5cba..fa9c684 100644
--- a/hw/ivshmem.c
+++ b/hw/ivshmem.c
@@ -181,8 +181,8 @@ static void ivshmem_io_writel(void *
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
block/vmdk.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 2d4ba42..54ad66f 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -437,7 +437,7 @@ static uint64_t get_cluster_offset(Bloc
From: Loïc Minier
Signed-off-by: Loïc Minier
Signed-off-by: Kevin Wolf
(cherry picked from commit 2aa326be0d2039f51192707bdb2fc935d0e87c21)
---
block/vvfat.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 6d61c2e..365332a 100644
--
On Mon, 30 Aug 2010, Jes Sorensen wrote:
> On 08/30/10 18:56, malc wrote:
> > On Mon, 30 Aug 2010, Anthony Liguori wrote:
> >
> >> On 08/30/2010 10:35 AM, jes.soren...@redhat.com wrote:
> >>> From: Jes Sorensen
> >>> diff --git a/linux-aio.c b/linux-aio.c
> >>> index 68f4b3d..3240996 100644
> >>>
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
ui/vnc-enc-tight.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index c4c9c3b..c942bb7 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -905,7 +905,7 @@ stati
On 08/30/2010 12:38 PM, Jes Sorensen wrote:
On 08/30/10 18:56, malc wrote:
On Mon, 30 Aug 2010, Anthony Liguori wrote:
On 08/30/2010 10:35 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensen
diff --git a/linux-aio.c b/linux-aio.c
index 68f4b3d..3240996 100644
--- a/linux-a
Arguably we should re-open the backing file with the backing file format and
not with the format of the snapshot image.
Signed-off-by: Kevin Wolf
(cherry picked from commit ee1811965fd15e0b41f8d508b951a8ab826ae3a7)
Conflicts:
block.c
Signed-off-by: Kevin Wolf
---
block.c | 13 +
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
nbd.c |4 ++--
nbd.h |2 +-
qemu-nbd.c |2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/nbd.c b/nbd.c
index a9f295f..7049998 100644
--- a/nbd.c
+++ b/nbd.c
@@ -393,7 +393,7 @@ int nbd_disconnect(int fd
On 08/30/2010 11:18 AM, Paolo Bonzini wrote:
On 08/30/2010 06:15 PM, Anthony Liguori wrote:
On 08/30/2010 10:42 AM, Paolo Bonzini wrote:
On 08/30/2010 05:35 PM, jes.soren...@redhat.com wrote:
- JSONParsingState state = {};
+ JSONParsingState state;
+ memset(&state, 0, sizeof(state));
state.ap
From: Loïc Minier
Signed-off-by: Loïc Minier
Signed-off-by: Kevin Wolf
---
block/vvfat.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 6d61c2e..365332a 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -512,7 +512,7 @@ static inli
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
block/sheepdog.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 81aa564..2ef8655 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -394,7 +394,7 @@ s
From: Izumi Tsutsui
"qemu_socket.h" includes all necessary files and
including without
could cause errors on some systems.
Signed-off-by: Izumi Tsutsui
Signed-off-by: Kevin Wolf
---
block/sheepdog.c | 10 --
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/block/she
Hello,
Nagios uses pings as part of it's core functionality and we would
like to deploy a demo using qemu for win32 users. The icmp to udp
translation causes our software to misbehave.
Here is a solution I came up with. You should share racecourses with
other projects, coLinux being one.
Separate the mapping of requests to host memory from the descriptor iteration.
The next patch will make use of it in a different context.
Signed-off-by: Kevin Wolf
---
hw/virtio.c | 38 --
hw/virtio.h |3 +++
2 files changed, 27 insertions(+), 14 deletio
On 08/30/2010 06:53 PM, Jes Sorensen wrote:
On 08/30/10 17:48, Anthony Liguori wrote:
On 08/30/2010 10:43 AM, Jes Sorensen wrote:
Yes it's technically legal. However it's painful when you try to apply
more aggressive warning flags looking for real bugs.
No, this is GCC being stupid.
I would
From: Jes Sorensen
This keeps the compiler happy when building with -Wextra while
effectively generating the same code.
Signed-off-by: Jes Sorensen
---
qjson.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/qjson.c b/qjson.c
index e4ee433..f259547 100644
--- a/qjson
From: Andrew de Quincey
Set the async_context_id field when queuing an async ioctl call
Signed-off-by: Andrew de Quincey
Signed-off-by: Kevin Wolf
---
posix-aio-compat.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/posix-aio-compat.c b/posix-aio-compat.c
index a67f
On Mon, 30 Aug 2010, Anthony Liguori wrote:
> On 08/30/2010 10:43 AM, Jes Sorensen wrote:
> > On 08/30/10 17:39, Anthony Liguori wrote:
> >
> > > On 08/30/2010 10:35 AM, jes.soren...@redhat.com wrote:
> > >
> > > > From: Jes Sorensen
> > > >
> > > > This keeps the compiler happy when bu
On 08/30/2010 11:24 AM, Paolo Bonzini wrote:
On 08/30/2010 05:35 PM, jes.soren...@redhat.com wrote:
From: Jes Sorensen
I think it's better to leave ctxt in for future extensibility.
You can mark it as __attribute__((unused)) to suppress the warning.
That seriously ugifies the code IMHO.
Re
The following changes since commit 02a89b219039621c940863aa5a9da4fec81a1546:
isapc: fix segfault. (2010-08-28 08:50:40 +)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git for-anthony
Andrew de Quincey (1):
posix-aio-compat: Fix async_conmtext for ioctl
Izumi
On 08/30/2010 05:35 PM, jes.soren...@redhat.com wrote:
From: Jes Sorensen
I think it's better to leave ctxt in for future extensibility.
You can mark it as __attribute__((unused)) to suppress the warning.
Paolo
The following changes since commit 96638e706cd431528690cf611adcb04e1bc3255d:
ide: Avoid canceling IDE DMA (2010-08-03 16:39:54 +0200)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git for-stable-0.13
Andrew de Quincey (1):
posix-aio-compat: Fix async_conmtext for
On Mon, 30 Aug 2010, Anthony Liguori wrote:
> On 08/30/2010 10:35 AM, jes.soren...@redhat.com wrote:
> > From: Jes Sorensen
> >
> > Signed-off-by: Jes Sorensen
> > ---
> > linux-aio.c |2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/linux-aio.c b/linux-aio.
On Mon, 30 Aug 2010, Jes Sorensen wrote:
> On 08/30/10 17:43, Anthony Liguori wrote:
> > On 08/30/2010 10:35 AM, jes.soren...@redhat.com wrote:
> >> From: Jes Sorensen
> >>
> >> Signed-off-by: Jes Sorensen
> >> ---
> >> linux-aio.c |2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-
On Mon, Aug 30, 2010 at 10:48:55AM -0500, Anthony Liguori wrote:
> No, this is GCC being stupid.
>
> How else do you terminate a list? IOW:
>
> MyDeviceInfo device_infos[] = {
> {"foo", 0, 2},
> {"bar", 0, 1},
> {} /* or { 0 } */
> };
>
> This is such a pervasive idiom that there's simply no
From: Andrew de Quincey
Set the async_context_id field when queuing an async ioctl call
Signed-off-by: Andrew de Quincey
Signed-off-by: Kevin Wolf
(cherry picked from commit 34cf0081294513bc734896c9051c20ca6c19c3db)
---
posix-aio-compat.c |1 +
1 files changed, 1 insertions(+), 0 deletion
On Mon, 30 Aug 2010 10:38:45 -0500
Anthony Liguori wrote:
> On 08/30/2010 10:28 AM, Anthony Liguori wrote:
> > Having two interfaces guarantees failure. What's the separation
> > between internal and external? Is qdev internal or external?
>
> Let me put it another way, compatibility cannot b
Separate the mapping of requests to host memory from the descriptor iteration.
The next patch will make use of it in a different context.
Signed-off-by: Kevin Wolf
(cherry picked from commit 42fb2e0720511fa1da2f8e751be393f851b71d80)
---
hw/virtio.c | 38 --
On 08/30/2010 06:16 PM, Anthony Liguori wrote:
This is why this type of warning sucks. Passing BlockDriverState is a
matter of readability because these are roughly methods. Just because
'this' isn't used right now, doesn't mean that it should not be a method.
On the contrary, to me this is a
We never write to a backing file, so opening rw is useless. It just means that
you can't rebase on top of a file for which you don't have write permissions.
Signed-off-by: Kevin Wolf
(cherry picked from commit cdbae85169c384d1641aa1ae86cdeefe16285745)
---
qemu-img.c |2 +-
1 files changed, 1
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
slirp/bootp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/slirp/bootp.c b/slirp/bootp.c
index 3e4e881..41460ff 100644
--- a/slirp/bootp.c
+++ b/slirp/bootp.c
@@ -33,7 +33,7 @@ static const uint8_t rfc1533_cookie[]
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
json-parser.c | 39 +++
1 files changed, 19 insertions(+), 20 deletions(-)
diff --git a/json-parser.c b/json-parser.c
index 70b9b6f..68ff9c1 100644
--- a/json-parser.c
+++ b/json-parser.c
@@ -91,7 +91,7 @@
We never write to a backing file, so opening rw is useless. It just means that
you can't rebase on top of a file for which you don't have write permissions.
Signed-off-by: Kevin Wolf
---
qemu-img.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
From: Miguel Di Ciurcio Filho
The output generated by 'info snapshots' shows only snapshots that exist on the
block device that saves the VM state. This output can cause an user to
erroneously try to load an snapshot that is not available on all block devices.
$ qemu-img snapshot -l xxtest.qcow2
From: Miguel Di Ciurcio Filho
When savevm is run without a name, the name stays blank and the snapshot is
saved anyway.
The new behavior is when savevm is run without parameters a name will be
created automaticaly, so the snapshot is accessible to the user without needing
the id when loadvm is r
On 08/30/10 17:43, Anthony Liguori wrote:
> On 08/30/2010 10:35 AM, jes.soren...@redhat.com wrote:
>> From: Jes Sorensen
>>
>> Signed-off-by: Jes Sorensen
>> ---
>> linux-aio.c |2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/linux-aio.c b/linux-aio.c
>> index 68
in_sg[].iovec and out_sg[].ioved are pointer to (source) host memory and
therefore invalid after migration. When loading the device state we must
create a new mapping on the destination host.
Signed-off-by: Kevin Wolf
---
hw/virtio-blk.c |5 +
1 files changed, 5 insertions(+), 0 deletion
From: Laurent Vivier
This patch allows to connect Qemu using NBD protocol to an nbd-server
using named exports.
For instance, if on the host "isoserver", in /etc/nbd-server/config, you have:
[generic]
[debian-500-ppc-netinst]
exportname = /ISO/debian-500-powerpc-netinst.iso
[Fedora-10-p
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
block/raw.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/raw.c b/block/raw.c
index 61e6748..fc057d0 100644
--- a/block/raw.c
+++ b/block/raw.c
@@ -12,7 +12,7 @@ static int raw_open(BlockDriverState *bs, int
On 08/30/2010 10:43 AM, Jes Sorensen wrote:
On 08/30/10 17:39, Anthony Liguori wrote:
On 08/30/2010 10:35 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensen
This keeps the compiler happy when building with -Wextra while
effectively generating the same code.
Signed-off-by: Jes Sor
Arguably we should re-open the backing file with the backing file format and
not with the format of the snapshot image.
Signed-off-by: Kevin Wolf
---
block.c | 13 +
1 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/block.c b/block.c
index da70f29..a5514e3 100644
--- a
On 08/30/2010 10:35 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
linux-aio.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/linux-aio.c b/linux-aio.c
index 68f4b3d..3240996 100644
--- a/linux-aio.c
+++ b/linux-aio.c
@@ -118,7
On 08/30/2010 11:16 AM, Luiz Capitulino wrote:
On Mon, 30 Aug 2010 10:38:45 -0500
Anthony Liguori wrote:
On 08/30/2010 10:28 AM, Anthony Liguori wrote:
Having two interfaces guarantees failure. What's the separation
between internal and external? Is qdev internal or external?
On 08/30/2010 06:15 PM, Anthony Liguori wrote:
On 08/30/2010 10:42 AM, Paolo Bonzini wrote:
On 08/30/2010 05:35 PM, jes.soren...@redhat.com wrote:
- JSONParsingState state = {};
+ JSONParsingState state;
+ memset(&state, 0, sizeof(state));
state.ap = ap;
JSONParsingState state = { .ap = ap
On 08/30/2010 10:59 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
block/raw.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/raw.c b/block/raw.c
index 61e6748..fc057d0 100644
--- a/block/raw.c
+++ b/block/raw.c
@@ -12,
On 08/30/2010 10:28 AM, Anthony Liguori wrote:
Having two interfaces guarantees failure. What's the separation
between internal and external? Is qdev internal or external?
Let me put it another way, compatibility cannot be an after thought.
We need to think deeply about compatibility when we
On 08/30/2010 10:42 AM, Paolo Bonzini wrote:
On 08/30/2010 05:35 PM, jes.soren...@redhat.com wrote:
-JSONParsingState state = {};
+JSONParsingState state;
+memset(&state, 0, sizeof(state));
state.ap = ap;
JSONParsingState state = { .ap = ap };
achieves the same.
But t
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
ui/vnc-enc-tight.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index c4c9c3b..df975af 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -926,7 +926,7 @@ stati
On 08/30/2010 05:35 PM, jes.soren...@redhat.com wrote:
-JSONParsingState state = {};
+JSONParsingState state;
+memset(&state, 0, sizeof(state));
state.ap = ap;
JSONParsingState state = { .ap = ap };
achieves the same.
Paolo
On 08/30/10 17:48, Anthony Liguori wrote:
> On 08/30/2010 10:43 AM, Jes Sorensen wrote:
>> Yes it's technically legal. However it's painful when you try to apply
>> more aggressive warning flags looking for real bugs.
>
> No, this is GCC being stupid.
>
>> I would suggest we modify the coding st
On 08/30/2010 10:35 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensen
Signed-off-by: Jes Sorensen
This is the wrong fix, bytes should be a ssize_t or an int because
tight_compress_data can return error.
Regards,
Anthony Liguori
---
ui/vnc-enc-tight.c |8
1 files c
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
qemu-config.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/qemu-config.c b/qemu-config.c
index 3abe655..1efdbec 100644
--- a/qemu-config.c
+++ b/qemu-config.c
@@ -80,7 +80,7 @@ static QemuOptsList qemu_dri
From: Jes Sorensen
Do not store return of get_image_size() in a uint32_t as it makes it
impossible to detect error returns from get_image_size.
Signed-off-by: Jes Sorensen
---
hw/multiboot.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/multiboot.c b/hw/multiboot
On 08/30/10 17:39, Anthony Liguori wrote:
> On 08/30/2010 10:35 AM, jes.soren...@redhat.com wrote:
>> From: Jes Sorensen
>>
>> This keeps the compiler happy when building with -Wextra while
>> effectively generating the same code.
>>
>> Signed-off-by: Jes Sorensen
>>
>
> What's GCC's compliant
On 08/30/2010 10:35 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensen
This keeps the compiler happy when building with -Wextra while
effectively generating the same code.
Signed-off-by: Jes Sorensen
What's GCC's compliant?
Regards,
Anthony Liguori
---
qjson.c |3 ++-
1 file
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
slirp/bootp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/slirp/bootp.c b/slirp/bootp.c
index 3e4e881..41460ff 100644
--- a/slirp/bootp.c
+++ b/slirp/bootp.c
@@ -33,7 +33,7 @@ static const uint8_t rfc1533_cookie[]
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
linux-aio.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/linux-aio.c b/linux-aio.c
index 68f4b3d..3240996 100644
--- a/linux-aio.c
+++ b/linux-aio.c
@@ -118,7 +118,7 @@ static void qemu_laio_completion_cb(void *opaq
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
block/sheepdog.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 81aa564..2ef8655 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -394,7 +394,7 @@ s
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
block/vmdk.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 2d4ba42..54ad66f 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -437,7 +437,7 @@ static uint64_t get_cluster_offset(Bloc
From: Jes Sorensen
Hi,
I started building QEMU with some more aggressive error flags to see
what dropped out. I started fixing up some of the cases, removing
unused arguments to functions, comparisons of unsigned types against
negative values etc. and a few other minor changes to avoid compiler
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
json-parser.c | 39 +++
1 files changed, 19 insertions(+), 20 deletions(-)
diff --git a/json-parser.c b/json-parser.c
index 70b9b6f..68ff9c1 100644
--- a/json-parser.c
+++ b/json-parser.c
@@ -91,7 +91,7 @@
1 - 100 of 158 matches
Mail list logo
