Re: [Qemu-devel] [PATCH 3/7] AMD IOMMU emulation

2010-08-29 Thread Eduard - Gabriel Munteanu
On Mon, Aug 30, 2010 at 12:07:30PM +0900, Isaku Yamahata wrote: > On Sat, Aug 28, 2010 at 05:54:54PM +0300, Eduard - Gabriel Munteanu wrote: > > diff --git a/hw/pc.c b/hw/pc.c > > index a96187f..e2456b0 100644 > > --- a/hw/pc.c > > +++ b/hw/pc.c > > @@ -1068,6 +1068,8 @@ void pc_pci_device_init(PCI

Re: [Qemu-devel] [PATCH 3/7] AMD IOMMU emulation

2010-08-29 Thread Isaku Yamahata
On Sat, Aug 28, 2010 at 05:54:54PM +0300, Eduard - Gabriel Munteanu wrote: > diff --git a/hw/pc.c b/hw/pc.c > index a96187f..e2456b0 100644 > --- a/hw/pc.c > +++ b/hw/pc.c > @@ -1068,6 +1068,8 @@ void pc_pci_device_init(PCIBus *pci_bus) > int max_bus; > int bus; > > +pci_create_simp

Re: [Qemu-devel] Re: Unusual physical address when using 64-bit BAR

2010-08-29 Thread Isaku Yamahata
On Fri, Aug 27, 2010 at 01:35:23PM -0600, Cam Macdonell wrote: > In upstream seabios.git, the c040 is not written, but the device > returns from 0x1c (only reads and writes to 0x18 and 0x1c are > shown below) > > pci_read_config: (val) 0x4 <- 0x18 (addr) > pci_write_config: (val) 0xff

[Qemu-devel] [PATCH] pciinit: remove unused variable, old_addr, in pci_set_io_region_addr().

2010-08-29 Thread Isaku Yamahata
old_addr is initialized, but not used. remove the useless variable. Signed-off-by: Isaku Yamahata --- src/pciinit.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/src/pciinit.c b/src/pciinit.c index f75e552..0346423 100644 --- a/src/pciinit.c +++ b/src/pciinit.c @@ -

[Qemu-devel] [PATH,curses] Fix contro...@[\]^_} and ESC

2010-08-29 Thread Samuel Thibault
contro...@[\]^_} shouldn't get the 'a' - 'A' offset for correct translation. ESC is better simulated as escape key. Signed-off-by: Samuel Thibault diff --git a/ui/curses.c b/ui/curses.c index ed3165e..5d949d6 100644 --- a/ui/curses.c +++ b/ui/curses.c @@ -238,9 +240,12 @@ static void curses_refr

[Qemu-devel] Re: [PATCH 2/7] pci: memory access API and IOMMU support

2010-08-29 Thread Eduard - Gabriel Munteanu
On Mon, Aug 30, 2010 at 01:08:23AM +0300, Eduard - Gabriel Munteanu wrote: > PCI devices should access memory through pci_memory_*() instead of > cpu_physical_memory_*(). This also provides support for translation and > access checking in case an IOMMU is emulated. > > Memory maps are treated as r

[Qemu-devel] [PATCH 2/7] pci: memory access API and IOMMU support

2010-08-29 Thread Eduard - Gabriel Munteanu
PCI devices should access memory through pci_memory_*() instead of cpu_physical_memory_*(). This also provides support for translation and access checking in case an IOMMU is emulated. Memory maps are treated as remote IOTLBs (that is, translation caches belonging to the IOMMU-aware device itself)

[Qemu-devel] [Bug 586175] Re: Windows XP/2003 doesn't boot

2010-08-29 Thread Michael Tokarev
Does anyone else has similar problem? With 0.12.4 I were able to repeat it. With 0.12.5 all winxp and win2003 installations, existing and new, just work with either -drive or -hda or with virtio... -- Windows XP/2003 doesn't boot https://bugs.launchpad.net/bugs/586175 You received this bug noti

Re: [Qemu-devel] [PATCH] Fix ivshmem build on 32-bit hosts

2010-08-29 Thread Alexander Graf
On 29.08.2010, at 11:43, Avi Kivity wrote: > stat() fields can be more or less anything depending on configuration, cast > explicitly to uint64_t to avoid printf() format mismatches. > > Signed-off-by: Avi Kivity I got a very similar patch in my queue: fprintf(stderr, " than shared o

[Qemu-devel] Re: [PATCH 0/7] AMD IOMMU emulation patchset v4

2010-08-29 Thread Blue Swirl
On Sun, Aug 29, 2010 at 9:55 AM, Joerg Roedel wrote: > On Sat, Aug 28, 2010 at 04:00:31PM +, Blue Swirl wrote: >> On Sat, Aug 28, 2010 at 2:54 PM, Eduard - Gabriel Munteanu > >> > Please have a look and merge if you like it. >> >> The endianess bug still exists. I had also other comments to 2.

[Qemu-devel] Re: [PATCH 3/7] AMD IOMMU emulation

2010-08-29 Thread Blue Swirl
On Sat, Aug 28, 2010 at 9:53 PM, Eduard - Gabriel Munteanu wrote: > On Sat, Aug 28, 2010 at 03:58:23PM +, Blue Swirl wrote: >> On Sat, Aug 28, 2010 at 2:54 PM, Eduard - Gabriel Munteanu >> wrote: >> > This introduces emulation for the AMD IOMMU, described in "AMD I/O >> > Virtualization Techn

[Qemu-devel] [PATCH -V4 24/26] [virtio-9p] Remove all instances of unnecessary dotu variable.

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: Arun R Bharadwaj Signed-off-by: Arun R Bharadwaj Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p-debug.c | 26 hw/virtio-9p-debug.h |1 - hw/virtio-9p.c | 115 +++--- 3 files changed, 61 insertions(+), 81 delet

[Qemu-devel] [PATCH -V4 25/26] [virtio-9p] This patch implements TLERROR/RLERROR on the qemu 9P server.

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: Arun R Bharadwaj Signed-off-by: Arun R Bharadwaj Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p.c | 19 +-- hw/virtio-9p.h |2 ++ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c index 94dff78..b6c 100644 -

[Qemu-devel] [PATCH -V4 22/26] virtio-9p: Use lchown which won't follow symlink

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V We should always use functions which don't follow symlink on the server Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p-local.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/virtio-9p-local.c b/hw/vi

[Qemu-devel] [PATCH-V4 00/26] Consolidated VirtFS work

2010-08-29 Thread Venkateswararao Jujjuri (JV)
This patch series is a consolidated view of various VirtFS patches on the Mailing List. None of these patches are new in this series. For sometime all these patches were on the mainling list individually. Changes from V3: - Rebased to latest master. Changes from V2: - Couple of formatting issue

[Qemu-devel] [Bug 586175] Re: Windows XP/2003 doesn't boot

2010-08-29 Thread tekditt
P.S.: I just read the link posted by Michael. I have also to mention that this boot problem not only appears by using the -drive parameter, even the good old -hda got this bug. I've also tried to correct some funny offsets in the NTFS header, but all offsets were already set to the right values.

[Qemu-devel] [PATCH -V4 03/26] virtio-9p: Return correct error from v9fs_remove

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: Sripathi Kodi Signed-off-by: Sripathi Kodi In v9fs_remove_post_remove() we currently ignore the error returned by the previous call to remove() and return an error only if freeing the fid fails. However, the client expects to see the error from remove(). Currently the client falsely think

[Qemu-devel] [PATCH -V4 04/26] [V4] virtio-9p: readdir implementation for 9p2000.L

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: Sripathi Kodi This patch implements the server part of readdir() implementation for 9p2000.L SYNOPSIS size[4] Treaddir tag[2] fid[4] offset[8] count[4] size[4] Rreaddir tag[2] count[4] data[count] DESCRIPTION The readdir request asks the server to read the directory

[Qemu-devel] [PATCH -V4 21/26] virtio-9p: Add SM_NONE security model

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V This is equivalent to SM_PASSTHROUGH security model. The only exception is, failure of privilige operation like chown are ignored. This makes a passthrough like security model usable for people who runs kvm as non root Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkat

[Qemu-devel] [PATCH -V4 26/26] virtio-9p: Change handling of flags in open() path for 9P2000.L

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: Sripathi Kodi This patch applies on top of 9P2000.L patches that we have on the list. I took a look at how 9P server is handling open() flags in 9P2000.L path. I think we can do away with the valid_flags() function and simplify the code. The reasoning is as follows: O_NOCTTY: (If the file

[Qemu-devel] [PATCH -V4 23/26] virtio-9p: Fix the memset usage

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V The arguments are wrong. Use qemu_mallocz directly Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c index c154bac..eb44c86

[Qemu-devel] [PATCH -V4 14/26] qemu: virtio-9p: Implement TMKDIR

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar Synopsis size[4] Tmkdir tag[2] fid[4] name[s] mode[4] gid[4] size[4] Rmkdir tag[2] qid[13] Description mkdir asks the file server to create a directory with given name, mode and gid. The qid for the new directory is returned with the mkdir reply messag

[Qemu-devel] [PATCH -V4 18/26] virtio-9p: Implement TXATTRWALK

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V TXATTRWALK: Descend a ATTR namespace size[4] TXATTRWALK tag[2] fid[4] newfid[4] name[s] size[4] RXATTRWALK tag[2] size[8] txattrwalk gets a fid pointing to xattr. This fid can later be used to get read the xattr value. If name is NULL the fid returned can be used to get

[Qemu-devel] [PATCH -V4 19/26] virtio-9p: Implement TXATTRCREATE

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V TXATTRCREATE: Prepare a fid for setting xattr value on a file system object. size[4] TXATTRCREATE tag[2] fid[4] name[s] attr_size[8] flags[4] size[4] RXATTRWALK tag[2] txattrcreate gets a fid pointing to xattr. This fid can later be used to get set the xattr value. fl

[Qemu-devel] [PATCH -V4 13/26] qemu: virtio-9p: Implement TMKNOD

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar Implement TMKNOD as part of 2000.L Work Synopsis size[4] Tmknod tag[2] fid[4] name[s] mode[4] major[4] minor[4] gid[4] size[4] Rmknod tag[2] qid[13] Description mknod asks the file server to create a device node with given device type, mode and gid. The q

[Qemu-devel] [PATCH -V4 16/26] [virtio-9p] qemu: virtio-9p: Implement LOPEN

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar Implement 9p2000.L version of open(LOPEN) interface in qemu 9p server. For LOPEN, no need to convert the flags to and from 9p mode to VFS mode. Synopsis: size[4] Tlopen tag[2] fid[4] mode[4] size[4] Rlopen tag[2] qid[13] iounit[4] Current qemu 9p server does not

[Qemu-devel] [PATCH -V4 12/26] [virtio-9p] This patch implements TLCREATE for 9p2000.L protocol.

2010-08-29 Thread Venkateswararao Jujjuri (JV)
SYNOPSIS size[4] Tlcreate tag[2] fid[4] name[s] flags[4] mode[4] gid[4] size[4] Rlcreate tag[2] qid[13] iounit[4] DESCRIPTION The Tlreate request asks the file server to create a new regular file with the name supplied, in the directory (dir) represented by fid. The mode argument specif

[Qemu-devel] [Bug 586175] Re: Windows XP/2003 doesn't boot

2010-08-29 Thread tekditt
This bug is annoying. I don't know who patched what but: 1. I finally was able (with version 0.12.5) to set up a WinXP installation which is able to boot on its own. 2. But this works only with IDE, if I try to use VirtIO I still can't boot the installation. 3. I just updated from 0.12.5 to 0.12

[Qemu-devel] [PATCH -V4 11/26] [virtio-9p] Define and implement TSYMLINK for 9P2000.L

2010-08-29 Thread Venkateswararao Jujjuri (JV)
This patch implements creating a symlink for TSYMLINK request and responds with RSYMLINK. In the case of error, we return RERROR. SYNOPSIS size[4] Tsymlink tag[2] fid[4] name[s] symtgt[s] gid[4] size[4] Rsymlink tag[2] qid[13] DESCRIPTION Create a symbolic link named 'name' poi

[Qemu-devel] [PATCH -V4 05/26] virtio-9p: Compute iounit based on host filesystem block size

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar Compute iounit based on the host filesystem block size and pass it to client with open/create response. Also return iounit as statfs's f_bsize for optimal block size transfers. Signed-off-by: M. Mohan Kumar Reviewd-by: Sripathi Kodi Signed-off-by: Venkateswararao Jujjuri

[Qemu-devel] [PATCH -V4 20/26] virtio-9p: Hide user.virtfs xattr in case of mapped security.

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V With mapped security mode we use "user.virtfs" namespace is used to store the virtFs related attributes. So hide it from user. Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p-local.c | 75

[Qemu-devel] [PATCH -V4 10/26] [virtio-9p] Implement TLINK for 9P2000.L

2010-08-29 Thread Venkateswararao Jujjuri (JV)
Create a Hardlink. SYNOPSIS size[4] Tlink tag[2] dfid[4] oldfid[4] newpath[s] size[4] Rlink tag[2] DESCRIPTION Create a link 'newpath' in directory pointed by dfid linking to oldfid path. Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p-debug.c |9 + hw/virtio-9p.c

[Qemu-devel] [PATCH -V4 07/26] virtio-9p: Do not reset atime

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar Current code resets file's atime to 0 when there is a change in mtime. This results in resetting the atime to "1970-01-01 05:30:00". For example, truncate -s 0 filename results in changing the mtime to the truncate time, but resets the atime to "1970-01-01 05:

[Qemu-devel] [PATCH -V4 15/26] rename - change name of file or directory

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar size[4] Trename tag[2] fid[4] newdirfid[4] name[s] size[4] Rrename tag[2] Implement the 2000.L rename operation. A new function v9fs_complete_rename is introduced that acts as a common entry point for 2000.L rename operation and 2000.U rename opearation (via wstat). As part

[Qemu-devel] [PATCH -V4 09/26] virtio-9p: Implement server side of setattr for 9P2000.L protocol.

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: Sripathi Kodi SYNOPSIS size[4] Tsetattr tag[2] attr[n] size[4] Rsetattr tag[2] DESCRIPTION The setattr command changes some of the file status information. attr resembles the iattr structure used in Linux kernel. It specifies which status parameter is to

[Qemu-devel] [PATCH -V4 02/26] qemu: virtio-9p: Implement statfs support in server

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar Implement statfs support in qemu server based on Sripathi's initial statfs patch. Signed-off-by: M. Mohan Kumar Signed-off-by: Sripathi Kodi Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h |1 + hw/virtio-9p-local.c |6 hw/virtio-9p.c |

[Qemu-devel] [PATCH -V4 17/26] virtio-9p: Add fidtype so that we can do type specific operation

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V We want to add type specific operation during read/write Signed-off-by: Aneesh Kumar K.V --- hw/virtio-9p.c | 110 --- hw/virtio-9p.h | 24 +++- 2 files changed, 78 insertions(+), 56 deletions(-) diff --git

[Qemu-devel] [PATCH -V4 06/26] virtio-9p: getattr server implementation for 9P2000.L protocol.

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: Sripathi Kodi SYNOPSIS size[4] Tgetattr tag[2] fid[4] request_mask[8] size[4] Rgetattr tag[2] lstat[n] DESCRIPTION The getattr transaction inquires about the file identified by fid. request_mask is a bit mask

[Qemu-devel] [PATCH -V4 08/26] [virtio-9p] Make v9fs_do_utimensat accept timespec structures instead of v9stat.

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: Sripathi Kodi Currently v9fs_do_utimensat takes a V9fsStat argument and builds timespec structures. It sets tv_nsec values to 0 by default. Instead of this it should take struct timespec[2] and pass it down to the system directly. This will make it more generic and useful elsewhere. Signed

[Qemu-devel] [PATCH -V4 01/26] qemu: virtio-9p: Recognize 9P2000.L protocol

2010-08-29 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar Make 9P server recognize 9P2000.L protocol version Signed-off-by: M. Mohan Kumar Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p.c |6 +- hw/virtio-9p.h |6 ++ 2 files changed, 11 insertions(+), 1 deletions(-) diff --git a/hw/virtio-9p.c b/hw/virt

Re: [Qemu-devel] images

2010-08-29 Thread Mulyadi Santosa
On Sat, Aug 28, 2010 at 22:47, mattias wrote: > Where to find some images? > I found a page a long time before but can't find it now > The page have images of > Reactos > Ubuntu > Bsd Once there was Free OS Zoo, but I checked just about few minutes ago and the domain is for sale -- regards,

Re: [Qemu-devel] Re: qemu-kvm faster than qemu?

2010-08-29 Thread Avi Kivity
On 08/27/2010 12:57 AM, walt wrote: Also try qemu-kvm with -no-kvm-irqchip. I can't believe an in-kernel lapic would make this much of a difference with windows 7 but it's worth trying. Using that flag wipes out the difference entirely: both come in at about 65 seconds. I also tried xp-

[Qemu-devel] linux 2.6.35 hangs with -no-acpi

2010-08-29 Thread Samuel Thibault
Hello, Linux 2.6.35 hangs at boot when giving -no-acpi to qemu, for instance the Debian kernel: qemu -no-acpi -kernel /boot/vmlinuz-2.6.35-trunk-686 Samuel

Re: [Qemu-devel] webcam under windows xp guest

2010-08-29 Thread Natalia Portillo
Hi, El 29/08/2010, a las 14:34, Frans de Boer escribió: > Hi and thanks. However, I cannot download the repository because of a > bad HEAD. I will "someday" understand GIT. It was posted on the mailing list anyway so just search for it. > Is this a patch I can apply to the qemu-kvm 0.12.5 distr

Re: [Qemu-devel] webcam under windows xp guest

2010-08-29 Thread Frans de Boer
Hi and thanks. However, I cannot download the repository because of a bad HEAD. Is this a patch I can apply to the qemu-kvm 0.12.5 distribution? Regards, Frans. On 08/29/2010 02:05 PM, Natalia Portillo wrote: > Connecting the webcam directly with usb pass-thru will never work well > because of t

Re: [Qemu-devel] webcam under windows xp guest

2010-08-29 Thread Natalia Portillo
Connecting the webcam directly with usb pass-thru will never work well because of timing issues. Too much USB packets dropped and image that cannot be formed. If you want to use it, use the qemu-v4l2 patchset posted two months ago in the list. It's still experimental but will give you image if

[Qemu-devel] Re: [PATCH 0/7] AMD IOMMU emulation patchset v4

2010-08-29 Thread Joerg Roedel
On Sat, Aug 28, 2010 at 04:00:31PM +, Blue Swirl wrote: > On Sat, Aug 28, 2010 at 2:54 PM, Eduard - Gabriel Munteanu > > Please have a look and merge if you like it. > > The endianess bug still exists. I had also other comments to 2. I am very happy with this patch set. Besides your comments

[Qemu-devel] [PATCH] Fix ivshmem build on 32-bit hosts

2010-08-29 Thread Avi Kivity
stat() fields can be more or less anything depending on configuration, cast explicitly to uint64_t to avoid printf() format mismatches. Signed-off-by: Avi Kivity --- hw/ivshmem.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/ivshmem.c b/hw/ivshmem.c index bbb5

Re: [Qemu-devel] [PATCH] QEMUFileBuffered: indicate that we're ready when the underlying file is ready

2010-08-29 Thread Avi Kivity
On 08/19/2010 06:19 PM, Anthony Liguori wrote: On 07/07/2010 11:44 AM, Avi Kivity wrote: QEMUFileBuffered stops writing when the underlying QEMUFile is not ready, and tells its producer so. However, when the underlying QEMUFile becomes ready, it neglects to pass that information along, resul