On 08/23/2010 09:45 AM, Paolo Bonzini wrote:
On 08/17/2010 01:29 PM, Avi Kivity wrote:
On 08/12/2010 06:29 PM, Paolo Bonzini wrote:
Nothing earth shattering. :)
Paolo Bonzini (3):
move kvm_set_irqfd to kvm-stub.c
This touches kvm-all.c, so should be against uq/master.
kvm_set_irqfd is not
On 08/17/2010 01:29 PM, Avi Kivity wrote:
On 08/12/2010 06:29 PM, Paolo Bonzini wrote:
Nothing earth shattering. :)
Paolo Bonzini (3):
move kvm_set_irqfd to kvm-stub.c
This touches kvm-all.c, so should be against uq/master.
kvm_set_irqfd is not in upstream qemu, should I add it there even t
On 08/22/2010 11:50 PM, Anthony Liguori wrote:
On 08/11/2010 04:56 PM, Paolo Bonzini wrote:
Currently -qmp stdio (or the equivalent -mon/-chardev combination) sets
up the terminal attributes even though it does not go through readline
to actually do I/O. As a result, echo is disabled and you can
On Mon, Aug 23, 2010 at 2:55 AM, Yoshiaki Tamura
wrote:
> Currently qemu_set_fd_handler2() is only setting ioh->deleted upon
> deleting. This may cause a crash when a read handler calls
> qemu_set_fd_handler2() to delete handlers, but a write handler is
> still invoked from main_loop_wait(). Bec
On 08/23/2010 12:07 AM, Anthony Liguori wrote:
On 08/22/2010 02:44 PM, Avi Kivity wrote:
No more MI diamond and all devices have DeviceStates.
Coincidentally, it matches more closely how hardware works..
Well, I agree, but I honestly lost the context. How does this relate
to the APIC an
On 08/23/2010 12:06 AM, Anthony Liguori wrote:
On 08/22/2010 03:33 PM, Avi Kivity wrote:
On 08/22/2010 11:03 PM, Anthony Liguori wrote:
On 08/22/2010 02:44 PM, Avi Kivity wrote:
No more MI diamond and all devices have DeviceStates.
Coincidentally, it matches more closely how hardware works.
Check before trying subindexing.
Signed-off-by: Ken CC
---
hw/pci.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index a09fbac..f6f00c6 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -675,6 +675,10 @@ static PCIDevice *do_pci_register_device(PCIDevice
Check before trying subindexing.
Signed-off-by: Ken CC
---
hw/pci.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index a09fbac..f6f00c6 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -675,6 +675,10 @@ static PCIDevice *do_pci_register_device(PCIDevice
Signed-off-by: Ken CC
---
hw/pci.c |2 +-
hw/pci.h |1 +
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index a98d6f3..a09fbac 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -44,7 +44,7 @@ struct PCIBus {
pci_hotplug_fn hotplug;
DeviceState *hotplug
On 08/23/2010 12:02 AM, Anthony Liguori wrote:
On 08/22/2010 03:28 PM, Avi Kivity wrote:
On 08/20/2010 09:38 PM, Anthony Liguori wrote:
While that might be useful, I don't quite see what makes CPUs so
special
that they need to be kept out of qdev. Could be just my ignorance, of
course.
CP
Currently qemu_set_fd_handler2() is only setting ioh->deleted upon
deleting. This may cause a crash when a read handler calls
qemu_set_fd_handler2() to delete handlers, but a write handler is
still invoked from main_loop_wait(). Because main_loop_wait() checks
handlers before calling, setting NUL
On Sun, 2010-08-22 at 10:31 +0200, Christoph Hellwig wrote:
> On Sat, Aug 21, 2010 at 04:01:15PM -0700, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger
> >
> > Greetings hch, tomo and Co,
>
> What tree is this against? I can't see any specificc BSG support in qemu.
>
The Megasas / S
From: Nicholas Bellinger
Greetings hch, Paul and other lsi53c895a folks,
This patch merges the remaining changes from upstream v0.12.5
for hw/lsi53c895a.c to function with the existing SGL passthrough
code.
This includes the following:
*) conversion of lsi_request->finished to lsi_request-
On Sun, Aug 22, 2010 at 8:12 PM, Avi Kivity wrote:
> On 08/22/2010 07:40 PM, Jes Sorensen wrote:
>>
>> I totally agree with Markus
>> that it seems like wasted effort to come up with new tools and having to
>> maintain them when there are good ones out there like the ones from the
>> Linux kernel
On 08/11/2010 04:56 PM, Paolo Bonzini wrote:
Currently -qmp stdio (or the equivalent -mon/-chardev combination) sets
up the terminal attributes even though it does not go through readline
to actually do I/O. As a result, echo is disabled and you cannot see
anything you type. This patch fixes it
On 08/12/2010 05:36 AM, Stefan Hajnoczi wrote:
Signed-off-by: Stefan Hajnoczi
I very much like that you use wiki formatting.
---
docs/tracing.txt | 149 ++
1 files changed, 149 insertions(+), 0 deletions(-)
create mode 100644 docs/
On 08/12/2010 05:36 AM, Stefan Hajnoczi wrote:
From: Prerna Saxena
This patch adds an optional command line switch '-trace' to specify the
filename to write traces to, when qemu starts.
Eg, If compiled with the 'simple' trace backend,
[t...@system]$ qemu -trace FILENAME IMAGE
Allows the binary t
On 08/19/2010 07:48 PM, Amit Shah wrote:
If the machine is stopped and 'info balloon' is invoked, the monitor
process just hangs waiting for info from the guest. Return the most
recent balloon data in that case.
See https://bugzilla.redhat.com/show_bug.cgi?id=623903
Reported-by:
Signed-off-by:
On 08/12/2010 05:36 AM, Stefan Hajnoczi wrote:
This patch series adds static tracing to QEMU. It can be used to instrument
QEMU code by means of lightweight logging called trace events.
Prerna and I are now posting the entire patch series with a serious eye towards
checking we meet users' and d
On 08/15/2010 08:58 AM, Adam Lackorzynski wrote:
Correct the calculation of the offset in the msrpm
for the MSR range 0 - 0x1fff.
Signed-off-by: Adam Lackorzynski
Applied. Thanks.
Regards,
Anthony Liguori
---
target-i386/op_helper.c |2 +-
1 files changed, 1 insertions(+), 1 del
On 08/18/2010 01:41 AM, Yoshiaki Tamura wrote:
Since most of the code in qemu_ram_alloc() and
qemu_ram_alloc_from_ptr() are duplicated, let
qemu_ram_alloc_from_ptr() to switch by checking void *host, and change
qemu_ram_alloc() to a wrapper.
Signed-off-by: Yoshiaki Tamura
Applied. Thanks.
On 08/19/2010 07:52 AM, Bernhard Kohl wrote:
I have a guest OS which sends the command 0xfd to the keyboard
controller during initialization. To get rid of the message
"qemu: unsupported keyboard cmd=0x%02x\n" I added support for
the pulse output bit commands.
I found the following explanation h
On 08/17/2010 11:30 PM, Yoshiaki Tamura wrote:
Signed-off-by: Yoshiaki Tamura
Applied. Thanks.
Regards,
Anthony Liguori
---
arch_init.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 47bb4b2..1865ae5 100644
--- a/ar
On 08/20/2010 09:38 PM, Anthony Liguori wrote:
While that might be useful, I don't quite see what makes CPUs so special
that they need to be kept out of qdev. Could be just my ignorance, of
course.
CPUs have special relationships with things like memory in QEMU. You
can argue that a device
On 08/22/2010 02:44 PM, Avi Kivity wrote:
No more MI diamond and all devices have DeviceStates.
Coincidentally, it matches more closely how hardware works..
Well, I agree, but I honestly lost the context. How does this relate
to the APIC and cpu hotplug?
I'll take the opportunity to say
On 08/22/2010 10:44 PM, malc wrote:
There is the problem that some patch submitters are reminded of
CODING_STYLE while others aren't. Some don't need to be reminded but
they are not part of the problem.
And to this i fully subscribe.
I agree.
From my Linux experience, I started out whining
On Sun, 22 Aug 2010, Blue Swirl wrote:
> On Sun, Aug 22, 2010 at 7:44 PM, malc wrote:
> > On Sun, 22 Aug 2010, Anthony Liguori wrote:
> >
> >> On 08/22/2010 01:56 PM, Blue Swirl wrote:
> >> > > Why is this even still being discussed? What problem are people
> >> > > actually
> >> > > trying to
On 08/22/2010 03:33 PM, Avi Kivity wrote:
On 08/22/2010 11:03 PM, Anthony Liguori wrote:
On 08/22/2010 02:44 PM, Avi Kivity wrote:
No more MI diamond and all devices have DeviceStates.
Coincidentally, it matches more closely how hardware works..
Well, I agree, but I honestly lost the con
On 08/18/2010 08:21 PM, Amit Shah wrote:
Free malloc'ed memory, unregister from savevm and clean up virtio-common
bits on device hot-unplug.
This was found performing a migration after device hot-unplug.
Reported-by:
Signed-off-by: Amit Shah
Applied. Thanks.
Regards,
Anthony Liguori
-
On 08/17/2010 11:30 PM, Yoshiaki Tamura wrote:
Signed-off-by: Yoshiaki Tamura
Applied. Thanks.
Regards,
Anthony Liguori
---
exec.c | 56
1 files changed, 28 insertions(+), 28 deletions(-)
diff --git a/exec.c b/exec.c
index 8
On 08/22/2010 11:03 PM, Anthony Liguori wrote:
On 08/22/2010 02:44 PM, Avi Kivity wrote:
No more MI diamond and all devices have DeviceStates.
Coincidentally, it matches more closely how hardware works..
Well, I agree, but I honestly lost the context. How does this relate
to the APIC an
On 08/22/2010 03:09 PM, Avi Kivity wrote:
On 08/22/2010 09:56 PM, Blue Swirl wrote:
Can someone point to a bug in QEMU that's been caused because of
CODING_STYLE or the fact that some patches don't adhere to it?
7b1df88f284f462ecb236931ad863a815f243195
How was this bug caused by CODING_STY
On Sun, 22 Aug 2010, Anthony Liguori wrote:
> On 08/22/2010 01:56 PM, Blue Swirl wrote:
> > > Why is this even still being discussed? What problem are people actually
> > > trying to solve?
> > >
> > > Can someone point to a bug in QEMU that's been caused because of
> > > CODING_STYLE or the fac
On 08/22/2010 03:28 PM, Avi Kivity wrote:
On 08/20/2010 09:38 PM, Anthony Liguori wrote:
While that might be useful, I don't quite see what makes CPUs so
special
that they need to be kept out of qdev. Could be just my ignorance, of
course.
CPUs have special relationships with things like me
On 08/22/2010 11:17 PM, Anthony Liguori wrote:
On 08/22/2010 03:09 PM, Avi Kivity wrote:
On 08/22/2010 09:56 PM, Blue Swirl wrote:
Can someone point to a bug in QEMU that's been caused because of
CODING_STYLE or the fact that some patches don't adhere to it?
7b1df88f284f462ecb236931ad863a8
On 08/22/2010 11:20 PM, Jes Sorensen wrote:
I happen to like the single line braces rule. That is, I don't like how
the code looks (I dislike punctuation generally), but I like the
consistency and I like how patches that add or remove a line are easy to
read.
My preference would be: new code
On 08/22/2010 11:16 PM, Blue Swirl wrote:
scripts/Lindent is just a wrapper around indent(1). We don't need to come
up with new tools, just come up with the right switches to indent(1).
More importantly, we want checkpatch.pl.
That's a bit too obnoxious in my opinion. I think the main thi
On 08/22/10 22:15, Avi Kivity wrote:
> On 08/19/2010 09:29 PM, Blue Swirl wrote:
>>
>>> Just to be sure I follow, are you suggesting we relax all of the bracing
>>> rule, or just the part about braces around single line statements? I'd
>>> be happy to write up a patch for the latter.
>> I'd rather
On 08/12/2010 05:36 AM, Stefan Hajnoczi wrote:
From: Prerna Saxena
Signed-off-by: Prerna Saxena
Signed-off-by: Stefan Hajnoczi
---
balloon.c|2 ++
trace-events |4
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/balloon.c b/balloon.c
index 8e0b7f1..0021fef 100
On 08/12/2010 05:36 AM, Stefan Hajnoczi wrote:
+linetoh_nop()
+{
+local name args
+name=$(get_name "$1")
+args=$(get_args "$1")
+
+# Define an empty function for the trace event
+cat<
This seems like it can potentially create a single header that ends up
needed to know a
On 08/19/2010 07:56 AM, Bernhard Kohl wrote:
It's legal that the guest reads a single byte or word from mmio.
I have an OS which reads single bytes and it works fine on real
hardware. Maybe this happens due to casting.
Signed-off-by: Bernhard Kohl
Hi Michael,
I'm looking for this to come
On Sun, Aug 22, 2010 at 8:09 PM, Avi Kivity wrote:
> On 08/22/2010 09:56 PM, Blue Swirl wrote:
>>
>>> Can someone point to a bug in QEMU that's been caused because of
>>> CODING_STYLE or the fact that some patches don't adhere to it?
>>
>> 7b1df88f284f462ecb236931ad863a815f243195
>
> How was this
On 08/19/2010 09:29 PM, Blue Swirl wrote:
Just to be sure I follow, are you suggesting we relax all of the bracing
rule, or just the part about braces around single line statements? I'd
be happy to write up a patch for the latter.
I'd rather not relax the rules but find a solution so that the
On 08/22/2010 07:40 PM, Jes Sorensen wrote:
I totally agree with Markus
that it seems like wasted effort to come up with new tools and having to
maintain them when there are good ones out there like the ones from the
Linux kernel.
scripts/Lindent is just a wrapper around indent(1). We don't
On 08/22/2010 09:56 PM, Blue Swirl wrote:
Can someone point to a bug in QEMU that's been caused because of
CODING_STYLE or the fact that some patches don't adhere to it?
7b1df88f284f462ecb236931ad863a815f243195
How was this bug caused by CODING_STYLE? In fact, if CODING_STYLE was
applied
On 08/22/2010 09:52 PM, Anthony Liguori wrote:
So really, I think this suggests that some devices shouldn't have
any requirement to sit on a bus. A UART16650A does not sit on bus.
It sits on a card and is wired to the ISA bus or is sometimes wired
directly to pins on a CPU on a SoC.
I don'
On 08/22/2010 02:44 PM, Avi Kivity wrote:
No more MI diamond and all devices have DeviceStates.
Coincidentally, it matches more closely how hardware works..
Well, I agree, but I honestly lost the context. How does this relate
to the APIC and cpu hotplug?
My original assertion was that t
On 08/22/2010 09:42 PM, Anthony Liguori wrote:
I'm strongly opposed to any reformatting of the tree.
I strongly second this statement.
All it does is break git blame which makes debugging harder without
offering any real benefits.
Even worse, it makes backporting patches much harder.
On Sun, Aug 22, 2010 at 7:28 PM, Anthony Liguori wrote:
> On 08/22/2010 01:56 PM, Blue Swirl wrote:
>>>
>>> Why is this even still being discussed? What problem are people actually
>>> trying to solve?
>>>
>>> Can someone point to a bug in QEMU that's been caused because of
>>> CODING_STYLE or th
On Sun, Aug 22, 2010 at 7:44 PM, malc wrote:
> On Sun, 22 Aug 2010, Anthony Liguori wrote:
>
>> On 08/22/2010 01:56 PM, Blue Swirl wrote:
>> > > Why is this even still being discussed? What problem are people actually
>> > > trying to solve?
>> > >
>> > > Can someone point to a bug in QEMU that's
On 08/22/2010 01:56 PM, Blue Swirl wrote:
Why is this even still being discussed? What problem are people actually
trying to solve?
Can someone point to a bug in QEMU that's been caused because of
CODING_STYLE or the fact that some patches don't adhere to it?
7b1df88f284f462ecb236931ad86
On Sun, Aug 22, 2010 at 6:41 PM, Anthony Liguori wrote:
> On 08/22/2010 11:49 AM, Jes Sorensen wrote:
While wasting time for historical reasons is certainly better than
wasting time for the heck of it, it's arguably worse than stopping the
waste.
>>>
>>> But how would you
On 08/22/2010 04:37 AM, Avi Kivity wrote:
On 08/19/2010 11:49 PM, Anthony Liguori wrote:
The bus does not need to have any connection to existence or
non-existence of real buses. In SoCs or ASICs, all devices and buses
may reside inside a chip.
Well, I think this is part of the trouble with t
On 08/22/2010 01:36 PM, malc wrote:
But how would you do that? Drop the CODING_STYLE (and accept
anything)? Switch to a new CODING_STYLE that is widely appreciated and
so all bikeshedding will cease? Enforce current style?
I would suggest we either clean up the existing rule, or switc
On 08/22/2010 11:49 AM, Jes Sorensen wrote:
While wasting time for historical reasons is certainly better than
wasting time for the heck of it, it's arguably worse than stopping the
waste.
But how would you do that? Drop the CODING_STYLE (and accept
anything)? Switch to a new CODING_STYL
On Sun, 22 Aug 2010, Blue Swirl wrote:
> On Sun, Aug 22, 2010 at 4:40 PM, Jes Sorensen wrote:
> > On 08/21/10 12:47, Blue Swirl wrote:
> >> On Sat, Aug 21, 2010 at 9:54 AM, Markus Armbruster
> >> wrote:
> >>> Unless you mass-convert existing code to your style, tools working on
> >>> source fil
On Sun, 22 Aug 2010, Blue Swirl wrote:
> On Sun, Aug 22, 2010 at 4:49 PM, Jes Sorensen wrote:
> > On 08/21/10 16:03, Blue Swirl wrote:
> >> On Sat, Aug 21, 2010 at 12:24 PM, Markus Armbruster
> >> wrote:
> >>> Could be "fun" for developers using Windows. If they exist.
> >>
> >> At least OCaml
On Sun, 22 Aug 2010, Blue Swirl wrote:
> On Sun, Aug 22, 2010 at 5:00 PM, malc wrote:
> > On Sun, 22 Aug 2010, Jes Sorensen wrote:
> >
> >> On 08/21/10 16:03, Blue Swirl wrote:
> >> > On Sat, Aug 21, 2010 at 12:24 PM, Markus Armbruster
> >> > wrote:
> >> >> Could be "fun" for developers using W
On Sun, Aug 22, 2010 at 5:00 PM, malc wrote:
> On Sun, 22 Aug 2010, Jes Sorensen wrote:
>
>> On 08/21/10 16:03, Blue Swirl wrote:
>> > On Sat, Aug 21, 2010 at 12:24 PM, Markus Armbruster
>> > wrote:
>> >> Could be "fun" for developers using Windows. If they exist.
>> >
>> > At least OCaml site
We've been using a cp15 fix for a while to fix modern ARM kernels (with
perf support) from booting. e.g. both the Ubuntu versatile and OMAP
kernels fail to boot without this fix (the latter only boots with the
OMAP patches too of course).
Thanks!
On Tue, Aug 03, 2010, Matt Waddel wrote:
>
On Sun, Aug 22, 2010 at 4:49 PM, Jes Sorensen wrote:
> On 08/21/10 16:03, Blue Swirl wrote:
>> On Sat, Aug 21, 2010 at 12:24 PM, Markus Armbruster
>> wrote:
>>> Could be "fun" for developers using Windows. If they exist.
>>
>> At least OCaml site offers binary download for Windows. I didn't
>>
On Sun, Aug 22, 2010 at 4:40 PM, Jes Sorensen wrote:
> On 08/21/10 12:47, Blue Swirl wrote:
>> On Sat, Aug 21, 2010 at 9:54 AM, Markus Armbruster wrote:
>>> Unless you mass-convert existing code to your style, tools working on
>>> source files won't cut it, because reports of the patch's style
>>
Public bug reported:
qemu 0.12.2, SeaBios 0.5.1, running qemu-system-x86_64.exe with option -smp.
If smp>=92 then no MP floating point structure present in 1 Mb. This may be
verified by pmemsave 0 0x10 in debugger and search for _MP_ signature in
file.
qemu 0.10.5 (bios build 05/08/09) can
On Sun, 22 Aug 2010, Jes Sorensen wrote:
> On 08/21/10 16:03, Blue Swirl wrote:
> > On Sat, Aug 21, 2010 at 12:24 PM, Markus Armbruster
> > wrote:
> >> Could be "fun" for developers using Windows. If they exist.
> >
> > At least OCaml site offers binary download for Windows. I didn't
> > compi
On 08/21/10 16:03, Blue Swirl wrote:
> On Sat, Aug 21, 2010 at 12:24 PM, Markus Armbruster wrote:
>> Could be "fun" for developers using Windows. If they exist.
>
> At least OCaml site offers binary download for Windows. I didn't
> compile Coccinelle myself, so I don't know how much that helps.
On 08/21/10 12:47, Blue Swirl wrote:
> On Sat, Aug 21, 2010 at 9:54 AM, Markus Armbruster wrote:
>> Unless you mass-convert existing code to your style, tools working on
>> source files won't cut it, because reports of the patch's style
>> violations are prone to drown in a sea of reports of preex
On 08/19/2010 11:49 PM, Anthony Liguori wrote:
The bus does not need to have any connection to existence or
non-existence of real buses. In SoCs or ASICs, all devices and buses
may reside inside a chip.
Well, I think this is part of the trouble with the current qdev object
model. There are r
On 08/19/2010 10:33 PM, Anthony Liguori wrote:
On 06/12/2010 04:14 PM, Blue Swirl wrote:
Clean up APIC and IOAPIC. Convert both devices to qdev.
v1->v2:
Remove apic.h reorganization.
Add IOAPIC and APIC qdev conversions.
Use CPUState also in 5/7. However on 6/7 we have to again use void *
beca
On Sat, Aug 21, 2010 at 04:01:15PM -0700, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger
>
> Greetings hch, tomo and Co,
What tree is this against? I can't see any specificc BSG support in qemu.
Even more I think all this in the wrong place. The only reason
SG_IO support was shoe-hor
69 matches
Mail list logo
