[Qemu-devel] [Bug 618533] Re: OpenSolaris guest fails to see the Solaris partitions of a physical disk in qemu-kvm-9999 (GIT)

2010-08-19 Thread devsk
What's this bugdb for then? I now have to subscribe to a list, just to send the patch? -- OpenSolaris guest fails to see the Solaris partitions of a physical disk in qemu-kvm- (GIT) https://bugs.launchpad.net/bugs/618533 You received this bug notification because you are a member of qemu- de

Re: [Qemu-devel] Template for developing a Qemu device with PCIe?and MSI-X

2010-08-19 Thread Isaku Yamahata
On Thu, Aug 19, 2010 at 01:32:42PM -0500, Adnan Khaleel wrote: > Isaku, > > I'm having some difficulties building the sources, I get the following message > > *akhal...@yar95 qemu-q35 $ ./configure --help > : bad interpreter: No such file or directory > > And I get a similar error while compilin

Re: [Qemu-devel] Template for developing a Qemu device with PCIe?and MSI-X

2010-08-19 Thread Isaku Yamahata
On Thu, Aug 19, 2010 at 12:01:40PM -0500, Adnan Khaleel wrote: > Hi Isaku, thank you very much for your very detailed response. I have a few > questions, see below. > > Thanks again, > > Adnan > > > Qemu doesn't support pcie at the moment. > Only partial patches have been merged, still

Re: [Qemu-devel] [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-08-19 Thread Anthony Liguori
On 08/19/2010 05:52 PM, malc wrote: Yes, but the programming model was different. Look at the PIC compared to the lapic. The PIC is programmed via pio at a fixed location. There is only one PIC and it interacts with the system just like all other devices. IOW, there is no reference to CPUStat

[Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped

2010-08-19 Thread Amit Shah
If the machine is stopped and 'info balloon' is invoked, the monitor process just hangs waiting for info from the guest. Return the most recent balloon data in that case. See https://bugzilla.redhat.com/show_bug.cgi?id=623903 Reported-by: Signed-off-by: Amit Shah --- v2: simplify call to qemu_b

[Qemu-devel] Re: [PATCH 1/6] Revert "ide save/restore pio/atapi cmd transfer fields and io buffer"

2010-08-19 Thread Juan Quintela
Anthony Liguori wrote: > On 07/26/2010 02:38 PM, Juan Quintela wrote: >> This reverts commit ed487bb1d69040b9dac64a4fc076d8dd82b131d6. >> >> The conflicts are due to commit 4fc8d6711aff7a9c11e402c3d77b481609f9f486 >> that is a fix to the ide_drive_pre_save() function. It reverts both >> (and both

Re: [Qemu-devel] [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-08-19 Thread malc
On Thu, 19 Aug 2010, Anthony Liguori wrote: > On 08/19/2010 04:21 PM, Blue Swirl wrote: > > > Should CPUs appear in the QEMU device tree? > > > > > They have several properties that should be user visible. > > > > Sure, but that's an argument for having some of the qdev features (like >

[Qemu-devel] [Bug 586175] Re: Windows XP/2003 doesn't boot

2010-08-19 Thread Michael Tokarev
This is fixed by a backport of the mentioned patchset to stable-0.12 branch, in qemu git tree, see http://git.savannah.gnu.org/gitweb/?p=qemu.git;a=commit;h=6394bd0e05441c363ebb73597c74c951378810e6 -- Windows XP/2003 doesn't boot https://bugs.launchpad.net/bugs/586175 You received this bug notifi

Re: [Qemu-devel] [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-08-19 Thread Anthony Liguori
On 08/19/2010 04:21 PM, Blue Swirl wrote: Should CPUs appear in the QEMU device tree? They have several properties that should be user visible. Sure, but that's an argument for having some of the qdev features (like variant properties) be consumable outside of qdev. requirement t

Re: [Qemu-devel] [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-08-19 Thread Blue Swirl
On Thu, Aug 19, 2010 at 8:49 PM, Anthony Liguori wrote: > On 08/19/2010 03:09 PM, Blue Swirl wrote: >> >> On Thu, Aug 19, 2010 at 7:33 PM, Anthony Liguori >>  wrote: >> >>> >>> On 06/12/2010 04:14 PM, Blue Swirl wrote: >>> Clean up APIC and IOAPIC. Convert both devices to qdev.

Re: [Qemu-devel] qemu 0.12.5 sparc64 debian 505

2010-08-19 Thread Blue Swirl
On Thu, Aug 19, 2010 at 8:44 PM, Artyom Tarasenko wrote: > 2010/8/19 Blue Swirl : >> On Thu, Aug 19, 2010 at 10:15 AM, Laurikainen, Tuukka >> wrote: >>> Hi, >>> >>> As the Sparc64 support is not complete, I thought I'd ask here before >>> reporting a bug. >>> >>> Trying to boot a Debian netboot c

Re: [Qemu-devel] [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-08-19 Thread Anthony Liguori
On 08/19/2010 03:09 PM, Blue Swirl wrote: On Thu, Aug 19, 2010 at 7:33 PM, Anthony Liguori wrote: On 06/12/2010 04:14 PM, Blue Swirl wrote: Clean up APIC and IOAPIC. Convert both devices to qdev. v1->v2: Remove apic.h reorganization. Add IOAPIC and APIC qdev conversions. Use CPUStat

Re: [Qemu-devel] qemu 0.12.5 sparc64 debian 505

2010-08-19 Thread Artyom Tarasenko
2010/8/19 Blue Swirl : > On Thu, Aug 19, 2010 at 10:15 AM, Laurikainen, Tuukka > wrote: >> Hi, >> >> As the Sparc64 support is not complete, I thought I'd ask here before >> reporting a bug. >> >> Trying to boot a Debian netboot cd image for Sparc with Qemu 0.12.5: >> >> # qemu-system-sparc64 -boo

Re: [Qemu-devel] [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-08-19 Thread Blue Swirl
On Thu, Aug 19, 2010 at 7:33 PM, Anthony Liguori wrote: > On 06/12/2010 04:14 PM, Blue Swirl wrote: >> >> Clean up APIC and IOAPIC. Convert both devices to qdev. >> >> v1->v2: >> Remove apic.h reorganization. >> Add IOAPIC and APIC qdev conversions. >> Use CPUState also in 5/7. However on 6/7 we h

Re: [Qemu-devel] [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-08-19 Thread Anthony Liguori
On 06/12/2010 04:14 PM, Blue Swirl wrote: Clean up APIC and IOAPIC. Convert both devices to qdev. v1->v2: Remove apic.h reorganization. Add IOAPIC and APIC qdev conversions. Use CPUState also in 5/7. However on 6/7 we have to again use void * because of VMState limitations. VMState gurus, please

[Qemu-devel] Opportunity

2010-08-19 Thread Gibbons, Scott
My group has a need for someone to port our architecture (as a guest) so it can be simulated with QEMU.  Please contact me privately at sgibbonsqualcommcom and we can discuss it in more detail. I apologize if this is an inappropriate forum for this type of posting.  Please feel free to correct

Re: [Qemu-devel] [PATCH 8/9] spice: simple display

2010-08-19 Thread malc
On Thu, 19 Aug 2010, Anthony Liguori wrote: > On 08/19/2010 10:36 AM, malc wrote: > > > Apparently a recent POSIX function... > > > > > > Preferred alternatives? I really dislike all caps macros. > > > > > Macros should be all capps. > > > > If you like angry code. I'm a self-flagela

Re: [Qemu-devel] [PATCH 1/9] add pflib: PixelFormat conversion library.

2010-08-19 Thread Anthony Liguori
On 08/19/2010 10:34 AM, Gerd Hoffmann wrote: On 08/19/10 16:04, Anthony Liguori wrote: On 08/19/2010 07:40 AM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann This code is more or less stand alone so it's a good candidate for having some in-tree unit tests. I can provide some examples of h

Re: [Qemu-devel] Re: [PATCH] Fix bug for vcpu hotplug

2010-08-19 Thread Anthony Liguori
On 08/19/2010 10:34 AM, Avi Kivity wrote: On 08/19/2010 06:24 PM, Anthony Liguori wrote: On 08/18/2010 02:33 AM, Avi Kivity wrote: On 08/18/2010 10:17 AM, Liu, Jinsong wrote: During test, we found qemu-kvm has a bug result in guestos shutdown when vcpu hotadd. This patch is to fix the bug,

Re: [Qemu-devel] [PATCH 8/9] spice: simple display

2010-08-19 Thread Anthony Liguori
On 08/19/2010 10:36 AM, malc wrote: Apparently a recent POSIX function... Preferred alternatives? I really dislike all caps macros. Macros should be all capps. If you like angry code. But honestly, just make printd() a static inline and then every one's happy :-) Regards, Anth

Re: [Qemu-devel] [PATCH 8/9] spice: simple display

2010-08-19 Thread Anthony Liguori
On 08/19/2010 11:05 AM, Gerd Hoffmann wrote: While not really unsafe, the qemu_malloc functions are not guaranteed to be re-entrant by the interfaces today. It's also terribly subtle to have to rely on implicit re-entrance safety. The underlying malloc() is re-entrant, isn't it? pflib (which is

[Qemu-devel] Opportunity

2010-08-19 Thread Gibbons, Scott
My group has a need for someone to port our architecture (as a guest) so it can be simulated with QEMU. Please contact me privately at sgibbonsqualcommcom and we can discuss it in more detail. I apologize if this is an inappropriate forum for this type of posting. Please feel free to correct

Re: [Qemu-devel] Template for developing a Qe mu device with PCIe and MSI-X

2010-08-19 Thread Adnan Khaleel
Isaku, I'm having some difficulties building the sources, I get the following message *akhal...@yar95 qemu-q35 $ ./configure --help : bad interpreter: No such file or directory And I get a similar error while compiling seabios as well. What shell are you using or am I missing something? I'm com

Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

2010-08-19 Thread Blue Swirl
On Thu, Aug 19, 2010 at 1:32 PM, Jes Sorensen wrote: > On 08/17/10 20:56, Blue Swirl wrote: >> On Tue, Aug 17, 2010 at 1:55 PM, Jes Sorensen >> wrote: >>> I think we are in full agreement here, I am really just worried that we >>> add additional procedures here that will slow down the real devel

Re: [Qemu-devel] qemu 0.12.5 sparc64 debian 505

2010-08-19 Thread Blue Swirl
On Thu, Aug 19, 2010 at 10:15 AM, Laurikainen, Tuukka wrote: > Hi, > > As the Sparc64 support is not complete, I thought I'd ask here before > reporting a bug. > > Trying to boot a Debian netboot cd image for Sparc with Qemu 0.12.5: > > # qemu-system-sparc64 -boot d -cdrom debian-505-sparc-busines

Re: [Qemu-devel] [Bug 618533] Re: OpenSolaris guest fails to see the Solaris partitions of a physical disk in qemu-kvm-9999 (GIT)

2010-08-19 Thread Blue Swirl
On Thu, Aug 19, 2010 at 7:03 AM, devsk <618...@bugs.launchpad.net> wrote: > hello? anybody home? > > -- > OpenSolaris guest fails to see the Solaris partitions of a physical disk in > qemu-kvm- (GIT) > https://bugs.launchpad.net/bugs/618533 > You received this bug notification because you are

Re: [Qemu-devel] [PATCH - V3] Port codes from qemu-kvm to support booting from SCSI disk image

2010-08-19 Thread Blue Swirl
On Wed, Aug 18, 2010 at 4:04 PM, Paul Brook wrote: >> > Couldn't we just have an option rom for the SCSI controller? The same way >> > the VGABIOS is a rewrite of a VGA BIOS for the Cirrus Logic... >> >> Of course we could, but it should not be extboot, but proper scsi driver. >> gpxe has src/driv

[Qemu-devel] Re: [PATCH 0/4] fix PowerPC 440 Bamboo platform emulation

2010-08-19 Thread Hollis Blanchard
On 08/04/2010 05:21 PM, Hollis Blanchard wrote: These patches get the PowerPC Bamboo platform working again. I've re-written two of the patches based on feedback from qemu-devel. Hi Aurelien, any comment on these? Hollis Blanchard Mentor Graphics, Embedded Systems Division

[Qemu-devel] August Angebote, Mobile Messestände, Displays & bedruckte Sitzsäcke

2010-08-19 Thread moreno-druck.de // mobile Messesysteme
.Stil1 { FONT-SIZE: 12px; FONT-FAMILY: Geneva, Arial, Helvetica, sans- serif } .Stil3 {FONT-SIZE: 20px } Das ganze zu unschlagbaren Preisen. Die Lieferzeit liegt nur zwischen 2-3 Tagen nach Eingang der Druckdaten. Falls Sie Ihr Display oder Ihr Banner nicht selber gestalten

[Qemu-devel] Re: [PATCH] hw/musicpal: Set loader start address

2010-08-19 Thread Jan Kiszka
Stefan Weil wrote: > Start address 0x0 did not work with a linux kernel. Never tried this, always loaded u-boot this way. But that one is fine with the shifted offset, so: Acked-by: Jan Kiszka Out of curiosity: Which kernel are you booting on this platform, the Marvel BSP kernel shipped by Fre

Re: [Qemu-devel] Template for developing a Qe mu device with PCIe and MSI-X

2010-08-19 Thread Adnan Khaleel
Hi Isaku, thank you very much for your very detailed response. I have a few questions, see below. Thanks again, Adnan Qemu doesn't support pcie at the moment. Only partial patches have been merged, still more patches have to be merged for pcie to fully work. The following repo is availabl

[Qemu-devel] August Angebote, Mobile Messestände, Displays & bedruckte Sitzsäcke

2010-08-19 Thread moreno-druck.de // mobile Messesysteme
.Stil1 { FONT-SIZE: 12px; FONT-FAMILY: Geneva, Arial, Helvetica, sans- serif } .Stil3 {FONT-SIZE: 20px } Das ganze zu unschlagbaren Preisen. Die Lieferzeit liegt nur zwischen 2-3 Tagen nach Eingang der Druckdaten. Falls Sie Ihr Display oder Ihr Banner nicht selber gestalten

[Qemu-devel] August Angebote, Mobile Messestände, Displays & bedruckte Sitzsäcke

2010-08-19 Thread moreno-druck.de // mobile Messesysteme
.Stil1 { FONT-SIZE: 12px; FONT-FAMILY: Geneva, Arial, Helvetica, sans- serif } .Stil3 {FONT-SIZE: 20px } Das ganze zu unschlagbaren Preisen. Die Lieferzeit liegt nur zwischen 2-3 Tagen nach Eingang der Druckdaten. Falls Sie Ihr Display oder Ihr Banner nicht selber gestalten

[Qemu-devel] August Angebote, Mobile Messestände, Displays & bedruckte Sitzsäcke

2010-08-19 Thread moreno-druck.de // mobile Messesysteme
.Stil1 { FONT-SIZE: 12px; FONT-FAMILY: Geneva, Arial, Helvetica, sans- serif } .Stil3 {FONT-SIZE: 20px } Das ganze zu unschlagbaren Preisen. Die Lieferzeit liegt nur zwischen 2-3 Tagen nach Eingang der Druckdaten. Falls Sie Ihr Display oder Ihr Banner nicht selber gestalten

[Qemu-devel] August Angebote, Mobile Messestände, Displays & bedruckte Sitzsäcke

2010-08-19 Thread moreno-druck.de // mobile Messesysteme
.Stil1 { FONT-SIZE: 12px; FONT-FAMILY: Geneva, Arial, Helvetica, sans- serif } .Stil3 {FONT-SIZE: 20px } Das ganze zu unschlagbaren Preisen. Die Lieferzeit liegt nur zwischen 2-3 Tagen nach Eingang der Druckdaten. Falls Sie Ihr Display oder Ihr Banner nicht selber gestalten

[Qemu-devel] [PATCH 4/4] QMP: Update README file

2010-08-19 Thread Luiz Capitulino
A number of changes I prefer to do in one shot: - Fix example - Small clarifications - Add multiple monitors example - Add 'Development Process' section Signed-off-by: Luiz Capitulino --- QMP/README | 71 --- 1 files changed, 48 insertio

[Qemu-devel] [PATCH 2/4] QMP/monitor: update do_info_version() to output broken down version string

2010-08-19 Thread Luiz Capitulino
From: Miguel Di Ciurcio Filho This code was originally developed by Daniel P. Berrange Signed-off-by: Miguel Di Ciurcio Filho Signed-off-by: Luiz Capitulino --- monitor.c | 23 +++ 1 files changed, 19 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c ind

[Qemu-devel] [PATCH 3/4] QMP doc: Add 'Stability Considerations' section

2010-08-19 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qemu-monitor.hx | 26 -- 1 files changed, 24 insertions(+), 2 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx index 9c27b31..5c1da33 100644 --- a/qemu-monitor.hx +++ b/qemu-monitor.hx @@ -35,7 +35,29 @@ information on the S

[Qemu-devel] [master/0.13 0/4]: QMP: Stability related fixes

2010-08-19 Thread Luiz Capitulino
In the KVM Forum we talked about making the current QMP's interface stable and deprecating it as soon as the right one is available. This series updates some QMP docs to reflect that and also has a small fix for the greeting message which would harder to change later. Thanks.

[Qemu-devel] [PATCH 1/4] QMP: update 'query-version' documentation

2010-08-19 Thread Luiz Capitulino
From: Miguel Di Ciurcio Filho Update the documentation of 'query-version' to output the string version broken down. Signed-off-by: Miguel Di Ciurcio Filho Signed-off-by: Luiz Capitulino --- qemu-monitor.hx | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 2/2] ui/sdl: clean up dead code

2010-08-19 Thread Serge Ziryukin
Signed-off-by: Serge Ziryukin --- ui/sdl.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index f599d42..a1458ce 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -87,12 +87,6 @@ static void sdl_update(DisplayState *ds, int x, int y, int w, int h) stat

Re: [Qemu-devel] [PATCH 8/9] spice: simple display

2010-08-19 Thread Gerd Hoffmann
Hi, + pthread_mutex_lock(&ssd->lock); The locking worries me here. It only makes sense if the spice interface_* callbacks can be invoked from threads independently of any of the QEMU threads. If that's the case, that means that the interface_* code is potentially running in parallel to ano

Re: [Qemu-devel] [PATCH 2/9] configure: add logging

2010-08-19 Thread Gerd Hoffmann
On 08/19/10 16:05, Anthony Liguori wrote: On 08/19/2010 07:40 AM, Gerd Hoffmann wrote: Write compile commands and messages to config.log. Useful for debugging configure. Signed-off-by: Gerd Hoffmann Indeed. Acked-by: Anthony Liguori Given the large nature of spice, I suggest that you setup

[Qemu-devel] [PATCH 1/2] WM8750: clean up dead code

2010-08-19 Thread Serge Ziryukin
Signed-off-by: Serge Ziryukin --- hw/wm8750.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/hw/wm8750.c b/hw/wm8750.c index ce43c23..c9c6744 100644 --- a/hw/wm8750.c +++ b/hw/wm8750.c @@ -171,7 +171,6 @@ static void wm8750_set_format(WM8750State *s) int i;

Re: [Qemu-devel] Re: [PATCH] Fix bug for vcpu hotplug

2010-08-19 Thread Avi Kivity
On 08/19/2010 06:24 PM, Anthony Liguori wrote: On 08/18/2010 02:33 AM, Avi Kivity wrote: On 08/18/2010 10:17 AM, Liu, Jinsong wrote: During test, we found qemu-kvm has a bug result in guestos shutdown when vcpu hotadd. This patch is to fix the bug, allow hotplug for sysbus qdev. --- a/hw/qd

Re: [Qemu-devel] [PATCH 8/9] spice: simple display

2010-08-19 Thread Alexander Graf
On 19.08.2010, at 17:34, Anthony Liguori wrote: > On 08/19/2010 10:23 AM, malc wrote: >> + +void qemu_spice_destroy_update(SimpleSpiceDisplay *sdpy, SimpleSpiceUpdate *update) +{ +qemu_free(update->bitmap); +qemu_free(update); +} + +void qemu_

Re: [Qemu-devel] [PATCH 8/9] spice: simple display

2010-08-19 Thread malc
On Thu, 19 Aug 2010, Anthony Liguori wrote: > On 08/19/2010 10:23 AM, malc wrote: > > > > > > + > > > > +void qemu_spice_destroy_update(SimpleSpiceDisplay *sdpy, > > > > SimpleSpiceUpdate > > > > *update) > > > > +{ > > > > +qemu_free(update->bitmap); > > > > +qemu_free(update); > > > > +

Re: [Qemu-devel] [PATCH 1/9] add pflib: PixelFormat conversion library.

2010-08-19 Thread Gerd Hoffmann
On 08/19/10 16:04, Anthony Liguori wrote: On 08/19/2010 07:40 AM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann This code is more or less stand alone so it's a good candidate for having some in-tree unit tests. I can provide some examples of how it should be done if you like, but just som

Re: [Qemu-devel] [PATCH 8/9] spice: simple display

2010-08-19 Thread Anthony Liguori
On 08/19/2010 10:23 AM, malc wrote: + +void qemu_spice_destroy_update(SimpleSpiceDisplay *sdpy, SimpleSpiceUpdate *update) +{ +qemu_free(update->bitmap); +qemu_free(update); +} + +void qemu_spice_create_host_memslot(SimpleSpiceDisplay *ssd) +{ +QXLDevMemSlot memslot; + +if (debu

Re: [Qemu-devel] [PATCH 8/9] spice: simple display

2010-08-19 Thread malc
On Thu, 19 Aug 2010, Anthony Liguori wrote: > On 08/19/2010 07:40 AM, Gerd Hoffmann wrote: > > With that patch applied you'll actually see the guests screen in the > > spice client. This does *not* bring qxl and full spice support though. > > This is basically the qxl vga mode made more generic,

Re: [Qemu-devel] Re: [PATCH] Fix bug for vcpu hotplug

2010-08-19 Thread Anthony Liguori
On 08/18/2010 02:33 AM, Avi Kivity wrote: On 08/18/2010 10:17 AM, Liu, Jinsong wrote: During test, we found qemu-kvm has a bug result in guestos shutdown when vcpu hotadd. This patch is to fix the bug, allow hotplug for sysbus qdev. --- a/hw/qdev.c +++ b/hw/qdev.c @@ -108,6 +108,7 @@ DeviceSt

Re: [Qemu-devel] [PATCH 4/4] savevm: Reset last block info at beginning of each save

2010-08-19 Thread Anthony Liguori
On 08/19/2010 08:18 AM, Luiz Capitulino wrote: From: Alex Williamson If we save more than once we need to reset the last block info or else only the first save has the actual block info and each subsequent save will only use continue flags, making them unloadable independently. Found-by: Miguel

Re: [Qemu-devel] [PATCH] QEMUFileBuffered: indicate that we're ready when the underlying file is ready

2010-08-19 Thread Anthony Liguori
On 07/07/2010 11:44 AM, Avi Kivity wrote: QEMUFileBuffered stops writing when the underlying QEMUFile is not ready, and tells its producer so. However, when the underlying QEMUFile becomes ready, it neglects to pass that information along, resulting in stoppage of all data until the next tick (a

Re: [Qemu-devel] [PATCH 1/4] set proper migration status on ->write error (v5)

2010-08-19 Thread Anthony Liguori
On 08/19/2010 08:18 AM, Luiz Capitulino wrote: From: Marcelo Tosatti If ->write fails, declare migration status as MIG_STATE_ERROR. Also, in buffered_file.c, ->close the object in case of an error. Fixes "migrate -d "exec:dd of=file", where dd fails to open file. Signed-off-by: Marcelo Tosatt

Re: [Qemu-devel] [PATCH v2] rtc: Remove TARGET_I386 from qemu-config.c, enables driftfix

2010-08-19 Thread Anthony Liguori
On 06/23/2010 09:44 AM, Amit Shah wrote: qemu-config.c doesn't contain any target-specific code, and the TARGET_I386 conditional code didn't get compiled as a result. Removing this enables the driftfix parameter for rtc. Signed-off-by: Amit Shah Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] ARM: semi-hosting support for stderr

2010-08-19 Thread Christophe Lyon
Ping? On 25.06.2010 17:44, Christophe LYON wrote: Hello, I propose this small patch so that ARM semi-hosting handles stderr as expected when linking with Newlib/libgloss. diff --git a/arm-semi.c b/arm-semi.c index 9549e6c..6874036 100644 --- a/arm-semi.c +++ b/arm-semi.c @@ -211,8 +211,11 @@ u

[Qemu-devel] [Bug 617528] Re: Incorrect translation of unary PPC/SPE instructions (efdneg etc.)

2010-08-19 Thread Mike Pall
** Patch added: "Fix translation of unary PPC/SPE instructions (efdneg etc.)." https://bugs.launchpad.net/qemu/+bug/617528/+attachment/1500100/+files/qemu3.diff ** Patch removed: "Fix for unary SPE ops vs. 6cbf4c8c" https://bugs.launchpad.net/qemu/+bug/617528/+attachment/1488575/+files/qe

Re: [Qemu-devel] [PATCH 7/9] spice: add mouse

2010-08-19 Thread Anthony Liguori
On 08/19/2010 07:40 AM, Gerd Hoffmann wrote: Open mouse channel. Now you can move the guests mouse pointer. No tablet / absolute positioning (yet) though. Signed-off-by: Gerd Hoffmann --- spice-input.c | 31 +++ 1 files changed, 31 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [PATCH 6/9] spice: add keyboard

2010-08-19 Thread Anthony Liguori
On 08/19/2010 07:40 AM, Gerd Hoffmann wrote: Open keyboard channel. Now you can type into the spice client and the keyboard events are sent to your guest. You'll need some other display like vnc to actually see the guest responding to them though. Signed-off-by: Gerd Hoffmann --- Makefile.ob

Re: [Qemu-devel] [PATCH 9/9] spice: add tablet support

2010-08-19 Thread Anthony Liguori
On 08/19/2010 07:40 AM, Gerd Hoffmann wrote: Add support for the spice tablet interface. The tablet interface will be registered (and then used by the spice client) as soon as a absolute pointing device is available and used by the guest, i.e. you'll have to configure your guest with '-usbdevice

Re: [Qemu-devel] [PATCH 8/9] spice: simple display

2010-08-19 Thread Anthony Liguori
On 08/19/2010 07:40 AM, Gerd Hoffmann wrote: With that patch applied you'll actually see the guests screen in the spice client. This does *not* bring qxl and full spice support though. This is basically the qxl vga mode made more generic, so it plays together with any qemu-emulated gfx card. Yo

Re: [Qemu-devel] [PATCH 5/9] spice: core bits

2010-08-19 Thread Anthony Liguori
On 08/19/2010 07:40 AM, Gerd Hoffmann wrote: Add -spice command line switch. Has support setting passwd and port for now. With this patch applied the spice client can successfully connect to qemu. You can't do anything useful yet though. Signed-off-by: Gerd Hoffmann --- Makefile.objs |

[Qemu-devel] [Bug 617528] Re: Incorrect translation of unary PPC/SPE instructions (efdneg etc.)

2010-08-19 Thread Nathan Froyd
Your patch needs a Signed-off-by and preferably a From: as well. ** Tags added: powerpc -- Incorrect translation of unary PPC/SPE instructions (efdneg etc.) https://bugs.launchpad.net/bugs/617528 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed t

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Avi Kivity
On 08/19/2010 05:10 PM, Alexander Graf wrote: We rely on the existing behaviour in kvm-unit-tests.git. Tests (.flat files) are 64-bit elf binaries that are loaded in 32-bit more and switch immediately to 64-bit. We can easily wrap them in a 32-bit elf, but that's a needless complication.

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Alexander Graf
On 19.08.2010, at 16:05, Avi Kivity wrote: > On 08/19/2010 04:57 PM, Alexander Graf wrote: >> >>> We rely on the existing behaviour in kvm-unit-tests.git. Tests (.flat >>> files) are 64-bit elf binaries that are loaded in 32-bit more and switch >>> immediately to 64-bit. >>> >>> We can easil

Re: [Qemu-devel] [PATCH 3/9] add spice into the configure file

2010-08-19 Thread Anthony Liguori
On 08/19/2010 07:40 AM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann Acked-by: Anthony Liguori Regards, Anthony Liguori --- configure | 36 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 13d8be0

Re: [Qemu-devel] [PATCH 2/9] configure: add logging

2010-08-19 Thread Anthony Liguori
On 08/19/2010 07:40 AM, Gerd Hoffmann wrote: Write compile commands and messages to config.log. Useful for debugging configure. Signed-off-by: Gerd Hoffmann Indeed. Acked-by: Anthony Liguori Given the large nature of spice, I suggest that you setup a subtree for it and do a pull reques

Re: [Qemu-devel] [PATCH 1/9] add pflib: PixelFormat conversion library.

2010-08-19 Thread Anthony Liguori
On 08/19/2010 07:40 AM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann This code is more or less stand alone so it's a good candidate for having some in-tree unit tests. I can provide some examples of how it should be done if you like, but just something that lives in tests/ that exe

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Avi Kivity
On 08/19/2010 04:57 PM, Alexander Graf wrote: We rely on the existing behaviour in kvm-unit-tests.git. Tests (.flat files) are 64-bit elf binaries that are loaded in 32-bit more and switch immediately to 64-bit. We can easily wrap them in a 32-bit elf, but that's a needless complication.

[Qemu-devel] Re: [STABLE 0.13 0/4][PULL]: Migration fixes

2010-08-19 Thread Anthony Liguori
On 08/19/2010 08:51 AM, Luiz Capitulino wrote: On Thu, 19 Aug 2010 08:44:09 -0500 Anthony Liguori wrote: On 08/19/2010 08:18 AM, Luiz Capitulino wrote: Anthony, The following migration fixes have been sent to the list some time ago but have not been applied yet. They fix important

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Alexander Graf
On 19.08.2010, at 15:02, Avi Kivity wrote: > On 08/19/2010 02:24 PM, Adam Lackorzynski wrote: >> A via -kernel supplied x86_64 ELF image is being started in 32bit mode. >> Detect and exit if a 64bit image has been supplied. >> >> >> >> diff --git a/hw/multiboot.c b/hw/multiboot.c >> index dc98

[Qemu-devel] Re: [STABLE 0.13 0/4][PULL]: Migration fixes

2010-08-19 Thread Luiz Capitulino
On Thu, 19 Aug 2010 08:44:09 -0500 Anthony Liguori wrote: > On 08/19/2010 08:18 AM, Luiz Capitulino wrote: > > Anthony, > > > > The following migration fixes have been sent to the list some time ago > > but have not been applied yet. They fix important bugs and seem good > > to me (I've tested th

[Qemu-devel] Re: [STABLE 0.13 0/4][PULL]: Migration fixes

2010-08-19 Thread Anthony Liguori
On 08/19/2010 08:18 AM, Luiz Capitulino wrote: Anthony, The following migration fixes have been sent to the list some time ago but have not been applied yet. They fix important bugs and seem good to me (I've tested them too). The changes (since 96638e706cd431528690cf611adcb04e1bc3255d) are avai

[Qemu-devel] Re: [PATCH 1/6] Revert "ide save/restore pio/atapi cmd transfer fields and io buffer"

2010-08-19 Thread Anthony Liguori
On 07/26/2010 02:38 PM, Juan Quintela wrote: This reverts commit ed487bb1d69040b9dac64a4fc076d8dd82b131d6. The conflicts are due to commit 4fc8d6711aff7a9c11e402c3d77b481609f9f486 that is a fix to the ide_drive_pre_save() function. It reverts both (and both are reinstantiated later in the serie

Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

2010-08-19 Thread Jes Sorensen
On 08/17/10 20:56, Blue Swirl wrote: > On Tue, Aug 17, 2010 at 1:55 PM, Jes Sorensen wrote: >> I think we are in full agreement here, I am really just worried that we >> add additional procedures here that will slow down the real development. > > Either the braces rule in CODING_STYLE is downgrad

[Qemu-devel] [PATCH 3/4] migration: Accept 'cont' only after successful incoming migration

2010-08-19 Thread Luiz Capitulino
From: Amit Shah When a 'cont' is issued on a VM that's just waiting for an incoming migration, the VM reboots and boots into the guest, possibly corrupting its storage since it could be shared with another VM running elsewhere. Ensure that a VM started with '-incoming' is only run when an incomi

[Qemu-devel] [STABLE 0.13 0/4][PULL]: Migration fixes

2010-08-19 Thread Luiz Capitulino
Anthony, The following migration fixes have been sent to the list some time ago but have not been applied yet. They fix important bugs and seem good to me (I've tested them too). The changes (since 96638e706cd431528690cf611adcb04e1bc3255d) are available in the following repository: git://rep

[Qemu-devel] [PATCH 4/4] savevm: Reset last block info at beginning of each save

2010-08-19 Thread Luiz Capitulino
From: Alex Williamson If we save more than once we need to reset the last block info or else only the first save has the actual block info and each subsequent save will only use continue flags, making them unloadable independently. Found-by: Miguel Di Ciurcio Filho Signed-off-by: Alex Williamso

[Qemu-devel] [PATCH 2/4] QEMUFileBuffered: indicate that we're ready when the underlying file is ready

2010-08-19 Thread Luiz Capitulino
From: Avi Kivity QEMUFileBuffered stops writing when the underlying QEMUFile is not ready, and tells its producer so. However, when the underlying QEMUFile becomes ready, it neglects to pass that information along, resulting in stoppage of all data until the next tick (a tenths of a second). Us

[Qemu-devel] [PATCH 1/4] set proper migration status on ->write error (v5)

2010-08-19 Thread Luiz Capitulino
From: Marcelo Tosatti If ->write fails, declare migration status as MIG_STATE_ERROR. Also, in buffered_file.c, ->close the object in case of an error. Fixes "migrate -d "exec:dd of=file", where dd fails to open file. Signed-off-by: Marcelo Tosatti Signed-off-by: Luiz Capitulino --- buffered

Re: [Qemu-devel] Re: [PATCH] QEMUFileBuffered: indicate that we're ready when the underlying file is ready

2010-08-19 Thread Avi Kivity
On 08/03/2010 04:00 PM, Luiz Capitulino wrote: On Tue, 03 Aug 2010 09:12:52 +0300 Avi Kivity wrote: On 07/07/2010 07:44 PM, Avi Kivity wrote: QEMUFileBuffered stops writing when the underlying QEMUFile is not ready, and tells its producer so. However, when the underlying QEMUFile becomes

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Alexander Graf
On 19.08.2010, at 14:49, Adam Lackorzynski wrote: > > On Thu Aug 19, 2010 at 14:34:10 +0200, Alexander Graf wrote: >> >> On 19.08.2010, at 14:32, Adam Lackorzynski wrote: >> >>> >>> On Thu Aug 19, 2010 at 13:40:54 +0200, Alexander Graf wrote: On 19.08.2010, at 13:36, Adam Lackorzyn

Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules

2010-08-19 Thread Avi Kivity
On 08/19/2010 03:52 PM, malc wrote: Not at all, _Bool is smaller or equal to int and thus can only improve packing. That's not what standard says: 6.2.5#2 An object declared as type _Bool is large enough to store the values 0 and It later goes on to say (6.7.2.1 fn120): While the number o

Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules

2010-08-19 Thread malc
On Thu, 19 Aug 2010, Avi Kivity wrote: > On 08/19/2010 11:17 AM, Jes Sorensen wrote: > > On 08/19/10 10:10, Avi Kivity wrote: > > > On 08/19/2010 10:58 AM, Jes Sorensen wrote: > > > > > In C99, bool is a real type. > > > > Kinda real, I would qualify it more as a pseudo type. It doesn't map to

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Avi Kivity
On 08/19/2010 02:24 PM, Adam Lackorzynski wrote: A via -kernel supplied x86_64 ELF image is being started in 32bit mode. Detect and exit if a 64bit image has been supplied. diff --git a/hw/multiboot.c b/hw/multiboot.c index dc980e6..e9dcbc9 100644 --- a/hw/multiboot.c +++ b/hw/multiboot.c @@

[Qemu-devel] [PATCH RESENT] msix: allow byte and word reading from mmio

2010-08-19 Thread Bernhard Kohl
It's legal that the guest reads a single byte or word from mmio. I have an OS which reads single bytes and it works fine on real hardware. Maybe this happens due to casting. Signed-off-by: Bernhard Kohl --- hw/msix.c | 20 1 files changed, 16 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH RESENT] pckbd: support for commands 0xf0-0xff: Pulse output bit

2010-08-19 Thread Bernhard Kohl
I have a guest OS which sends the command 0xfd to the keyboard controller during initialization. To get rid of the message "qemu: unsupported keyboard cmd=0x%02x\n" I added support for the pulse output bit commands. I found the following explanation here: http://www.win.tue.nl/~aeb/linux/kbd/scanc

[Qemu-devel] [PATCH 8/9] spice: simple display

2010-08-19 Thread Gerd Hoffmann
With that patch applied you'll actually see the guests screen in the spice client. This does *not* bring qxl and full spice support though. This is basically the qxl vga mode made more generic, so it plays together with any qemu-emulated gfx card. You can display stdvga or cirrus via spice client

[Qemu-devel] [PATCH 9/9] spice: add tablet support

2010-08-19 Thread Gerd Hoffmann
Add support for the spice tablet interface. The tablet interface will be registered (and then used by the spice client) as soon as a absolute pointing device is available and used by the guest, i.e. you'll have to configure your guest with '-usbdevice tablet'. Signed-off-by: Gerd Hoffmann --- s

[Qemu-devel] [PATCH 4/9] configure: require spice 0.5.3

2010-08-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- configure |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 56e7084..0998e86 100755 --- a/configure +++ b/configure @@ -2061,11 +2061,10 @@ if test "$spice" != "no" ; then #include int main(void) { spice_s

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Adam Lackorzynski
On Thu Aug 19, 2010 at 14:34:10 +0200, Alexander Graf wrote: > > On 19.08.2010, at 14:32, Adam Lackorzynski wrote: > > > > > On Thu Aug 19, 2010 at 13:40:54 +0200, Alexander Graf wrote: > >> > >> On 19.08.2010, at 13:36, Adam Lackorzynski wrote: > >> > >>> > >>> On Thu Aug 19, 2010 at 13:27:

[Qemu-devel] [PATCH 6/9] spice: add keyboard

2010-08-19 Thread Gerd Hoffmann
Open keyboard channel. Now you can type into the spice client and the keyboard events are sent to your guest. You'll need some other display like vnc to actually see the guest responding to them though. Signed-off-by: Gerd Hoffmann --- Makefile.objs |2 +- qemu-spice.h |1 + spice-inp

[Qemu-devel] [PATCH 5/9] spice: core bits

2010-08-19 Thread Gerd Hoffmann
Add -spice command line switch. Has support setting passwd and port for now. With this patch applied the spice client can successfully connect to qemu. You can't do anything useful yet though. Signed-off-by: Gerd Hoffmann --- Makefile.objs |2 + qemu-config.c | 23 qemu-con

[Qemu-devel] [PATCH 1/9] add pflib: PixelFormat conversion library.

2010-08-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- Makefile.objs |1 + pflib.c | 213 + pflib.h | 20 ++ 3 files changed, 234 insertions(+), 0 deletions(-) create mode 100644 pflib.c create mode 100644 pflib.h diff --git a/Makefile.

[Qemu-devel] [PATCH 3/9] add spice into the configure file

2010-08-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- configure | 36 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 13d8be0..56e7084 100755 --- a/configure +++ b/configure @@ -318,6 +318,7 @@ pkgversion="" check_utests="no" user_p

[Qemu-devel] [PATCH 7/9] spice: add mouse

2010-08-19 Thread Gerd Hoffmann
Open mouse channel. Now you can move the guests mouse pointer. No tablet / absolute positioning (yet) though. Signed-off-by: Gerd Hoffmann --- spice-input.c | 31 +++ 1 files changed, 31 insertions(+), 0 deletions(-) diff --git a/spice-input.c b/spice-input.c inde

[Qemu-devel] [PATCH 2/9] configure: add logging

2010-08-19 Thread Gerd Hoffmann
Write compile commands and messages to config.log. Useful for debugging configure. Signed-off-by: Gerd Hoffmann --- configure |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/configure b/configure index a20371c..13d8be0 100755 --- a/configure +++ b/configure @@ -16,

[Qemu-devel] [PATCH 0/9] initial spice support.

2010-08-19 Thread Gerd Hoffmann
Hi, /me wants getting the spice support merging started, here is the first batch of patches. It brings just the very basic bits: * Detect spice in configure, Makefile windup. * Support for keyboard, mouse and tablet. * Support for simple display output (works as DisplayChangeListener, pl

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Alexander Graf
On 19.08.2010, at 14:32, Adam Lackorzynski wrote: > > On Thu Aug 19, 2010 at 13:40:54 +0200, Alexander Graf wrote: >> >> On 19.08.2010, at 13:36, Adam Lackorzynski wrote: >> >>> >>> On Thu Aug 19, 2010 at 13:27:32 +0200, Alexander Graf wrote: On 19.08.2010, at 13:24, Adam Lackorzyn

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Adam Lackorzynski
On Thu Aug 19, 2010 at 13:40:54 +0200, Alexander Graf wrote: > > On 19.08.2010, at 13:36, Adam Lackorzynski wrote: > > > > > On Thu Aug 19, 2010 at 13:27:32 +0200, Alexander Graf wrote: > >> > >> On 19.08.2010, at 13:24, Adam Lackorzynski wrote: > >> > >>> A via -kernel supplied x86_64 ELF im

  1   2   >