Markus Armbruster wrote:
> Subject is confusing: suggests a series of four parts.
Sorry. My bad for recycling old mail.
> Looks like this conflicts with my "PATCH v3 00/13] More block-related
> fixes and cleanups".
>
> Perhaps the easiest way to get this in would be to rebase to Kevin's
> block
Subject is confusing: suggests a series of four parts.
john cooper writes:
> This patch adds the final missing bits for support of
> passing a serial/id string to a virtio-blk guest driver.
>
> The guest-side component already exists in the virtio
> driver, and has recently been reworked by Ryan
(2010/07/02 4:48), Blue Swirl wrote:
> 2010/7/1 Hidetoshi Seto :
>> There were fsdev/qemu-fsdev.{o,d} not removed at "make clean".
>>
>> Signed-off-by: Hidetoshi Seto
>> ---
>> Makefile |2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index
This patch adds the final missing bits for support of
passing a serial/id string to a virtio-blk guest driver.
The guest-side component already exists in the virtio
driver, and has recently been reworked by Ryan to export
a /sys interface for retrival of the id from guest userland.
Signed-off-by:
On Wed, Jun 30, 2010 at 12:51:59PM +0100, Stefan Hajnoczi wrote:
> On Wed, Jun 30, 2010 at 11:20 AM, Prerna Saxena
> wrote:
> > On 06/26/2010 01:36 PM, Stefan Hajnoczi wrote:
> >>
> >> Here are the outstanding tasks for QEMU tracing, which Prerna and I have
> >> been working on. Tracing aids debu
allocate PCIBus dynamically for PCIBridge and bug fix of
pci_unregister_secondary_bus().
This is a preparation for splitting out pci_bridge functions.
Since PCIBus is private to pci.c, PCIBridge won't be able to
contain PCIBus in its structure.
Signed-off-by: Isaku Yamahata
---
hw/pci.c | 25 +
Move pci bridge related code into pci_bridge.c from pci.c
for further enhancement. pci.c is big enough now, so split it out.
No code change but exporting some accesser functions.
In fact, some of pci bridge functions stays in pci.c because
it accesses to PCIBus member. Unstatic the accessor functi
Now pci.c has grown. So split bridge related code into dedicated file
for further extension to pci bridge. Further clean up and pcie port emulator.
This make patch conflict less possible in future.
Isaku Yamahata (2):
pci/bridge: allocate PCIBus dynamically for PCIBridge.
pci/bridge: split out
Thank you the pointer. I found the followings.
https://groups.google.com/group/archlinux-for-loongson/web/loongson
https://groups.google.com/group/archlinux-for-loongson/web/bonito64-spec.pdf
Am I referring to a correct spec?
According to it,
[0x, 0x1000) RAM
[0x1000, 0x1400)
On Sat, Jun 26, 2010 at 10:54:21PM +0200, Andi Kleen wrote:
> Don't declare XSAVE as supported
>
> i386 cpuid.c currently claims XSAVE is supported in the CPUID filter,
> but that's not true: Only FXSAVE is supported. Remove that bit
> from the filter.
>
> Signed-off-by: Andi Kleen
Thanks, appl
On Sun, Jun 27, 2010 at 12:06:11AM +0200, Andi Kleen wrote:
> Add more boundary checking to sse3/4 parsing
>
> s?sse3 uses tables with only two entries per op, but it is indexed
> with b1 which can contain variables upto 3. This happens when ssse3
> or sse4 are used with REP* prefixes.
>
> Add bo
On Thu, Jul 01, 2010 at 11:08:49AM +0200, Stefan Weil wrote:
> Am 09.04.2010 13:20, schrieb Stefan Weil:
> >Aurelien Jarno schrieb:
> >>On Mon, Mar 29, 2010 at 09:16:52PM +0200, Stefan Weil wrote:
> >>>The compiler should check the arguments for these functions.
> >>>
> >>>gcc can do this, but only
This patch adds support for loongson 2E & 2F instructions. They are the
same instructions, but differ by the opcode encoding.
This patch has still a few problems (hence the RFC), but is enough to
boot a fulong 2E kernel built with the -mloongson2e flag:
- I am unable to understand the difference b
On Thu, 1 Jul 2010, Stefan Weil wrote:
> Am 01.07.2010 22:10, schrieb Blue Swirl:
> > On Thu, Jul 1, 2010 at 11:08 AM, Stefan Weil wrote:
> > > Signed-off-by: Stefan Weil
> > > ---
> > > blockdev.h |3 ++-
> > > 1 files changed, 2 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/bloc
On Thu, Jul 01, 2010 at 09:42:21AM -0700, Richard Henderson wrote:
> We were ignoring REX_B while special-casing NOP, i.e. xchg eax,eax.
>
> Signed-off-by: Richard Henderson
> ---
> target-i386/translate.c |9 +++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
Applied, thanks.
>
On Thu, Jul 01, 2010 at 12:30:23PM +0900, Hidetoshi Seto wrote:
> QMP/qmp-commands.txt is a generated file.
>
> Signed-off-by: Hidetoshi Seto
> ---
> .gitignore |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Thanks, applied.
> diff --git a/.gitignore b/.gitignore
> index ce66ed5
On Thu, Jul 01, 2010 at 12:32:32PM +0900, Hidetoshi Seto wrote:
> Remove generated qemu-options.def at "make distclean".
>
> Signed-off-by: Hidetoshi Seto
> ---
> Makefile |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Thanks, applied.
> diff --git a/Makefile b/Makefile
> index 2
On Mon, Jun 28, 2010 at 11:54:03PM +0800, Chih-Min Chao wrote:
> The three patches focuse on Bugs 595906 & Bug 591320. The first is related to
> Bug 595906 and the other solve Bug 591320.
>
> The series are also attached in the threads, listed below
> https://bugs.launchpad.net/qemu/+bug/59590
> Here is the patch again. There may be more work to be done on top of this,
> but this patch staying out of tree hasn't noticeably accelerated that work
> in the past year and change. Could it please be merged?
As mentioned previously, "V5" should be split into its component parts.
Paul
> I really see no tangible objection to Jan's patches. They don't impact
> any other code. They don't inhibit flexibility in the infrastructure.
> You might consider it to be a "hack" but so what. QEMU is filled with
> hacks. It would be useless without them because there would be very
> little
I just confirmed that Vincent Sanders' patch (which he posted on May 29, 2009,
and again on November 27, 2009) still applies to (and works with )current
qemu-git.
It adds a -cpu arm920t option to qemu-system-arm which boots a Linux kernel
configured with CONFIG_CPU_ARM920T=y, which isn't possible
Am 01.07.2010 22:10, schrieb Blue Swirl:
On Thu, Jul 1, 2010 at 11:08 AM, Stefan Weil wrote:
Signed-off-by: Stefan Weil
---
blockdev.h |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/blockdev.h b/blockdev.h
index 23ea576..3c5c85d 100644
--- a/blockdev.h
+++ b/blockd
On Thu, Jul 1, 2010 at 11:08 AM, Stefan Weil wrote:
> Signed-off-by: Stefan Weil
> ---
> blockdev.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/blockdev.h b/blockdev.h
> index 23ea576..3c5c85d 100644
> --- a/blockdev.h
> +++ b/blockdev.h
> @@ -42,7 +42,8 @@ ex
On Wed, Jun 30, 2010 at 8:56 AM, Paolo Bonzini wrote:
Wouldn't it be better to just put this in dyngen-exec.h ?
AFAICT there's a direct correlation between NEED_GLOBAL_ENV and #include
"exec.h".
>>>
>>> True, see cover letter in 0/4. I was told to make each file request
>>> explici
Drop a unneeded label and QDECREF() call.
Signed-off-by: Luiz Capitulino
---
monitor.c | 14 ++
1 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/monitor.c b/monitor.c
index 1c8992b..00a627a 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4234,7 +4234,7 @@ static void handl
2010/7/1 Hidetoshi Seto :
> There were fsdev/qemu-fsdev.{o,d} not removed at "make clean".
>
> Signed-off-by: Hidetoshi Seto
> ---
> Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 560eac6..ce5f0e6 100644
> --- a/Makefile
> +++ b
Previous commit added qmp_check_input_obj(), it does all the
checking we need.
Signed-off-by: Luiz Capitulino
---
monitor.c | 19 +--
1 files changed, 1 insertions(+), 18 deletions(-)
diff --git a/monitor.c b/monitor.c
index 22e0650..1c8992b 100644
--- a/monitor.c
+++ b/monito
This is similar to qmp_check_client_args(), but it checks if
the input object follows the specification (QMP/qmp-spec.txt
section 2.3).
As we're limited to three keys, the work here is quite simple:
we iterate over the input object, checking each time if the
current argument complies to the specif
From: Jan Kiszka
Ported commands that are marked 'user_only' will not be considered for
QMP monitor sessions. This allows to implement new commands that do not
(yet) provide a sufficiently stable interface for QMP use.
Signed-off-by: Jan Kiszka
Signed-off-by: Luiz Capitulino
---
monitor.c |
On Wed, Jun 30, 2010 at 09:37:31AM +0100, Stefan Hajnoczi wrote:
> On Tue, Jun 29, 2010 at 6:25 PM, Eduard - Gabriel Munteanu
> wrote:
> > On the other hand, we could just leave it alone for now. Changing
> > mappings during DMA is stupid anyway: I don't think the guest can
> > recover the results
Previous two commits added qmp_check_client_args(), which
fully replaces this code and is way better.
It's important to note that the new checker doesn't support
the '/' arg type. As we don't have any of those handlers
converted to QMP, this is just dead code.
Signed-off-by: Luiz Capitulino
---
Signed-off-by: Luiz Capitulino
---
qerror.c |4
qerror.h |3 +++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/qerror.c b/qerror.c
index cce1e7b..2f6f590 100644
--- a/qerror.c
+++ b/qerror.c
@@ -177,6 +177,10 @@ static const QErrorStringTable qerror_table[] = {
This commit introduces the second (and last) part of QMP's new
argument checker.
The job is done by check_client_args_type(), it iterates over
the client's argument qdict and for for each argument it checks
if it exists and if its type is valid.
It's important to observe the following changes fro
Signed-off-by: Luiz Capitulino
---
qdict.c | 18 ++
qdict.h |1 +
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/qdict.c b/qdict.c
index a28a0a9..dee0fb4 100644
--- a/qdict.c
+++ b/qdict.c
@@ -308,6 +308,24 @@ int64_t qdict_get_try_int(const QDict *qdict, co
Historically, user monitor arguments beginning with '-' (eg. '-f')
were passed as integers down to handlers.
I've maintained this behavior in the new monitor because we didn't
have a boolean type at the very beginning of QMP. Today we have it
and this behavior is causing trouble to QMP's argument
Current QMP's argument checker is more complex than it should be
and has (at least) one serious bug: it ignores unknown arguments.
To solve both problems we introduce a new argument checker. It's
added on top of the existing one, so that there are no regressions
during the transition.
This commit
Signed-off-by: Luiz Capitulino
---
check-qdict.c | 31 +++
1 files changed, 31 insertions(+), 0 deletions(-)
diff --git a/check-qdict.c b/check-qdict.c
index 1b070f4..6afce5a 100644
--- a/check-qdict.c
+++ b/check-qdict.c
@@ -194,6 +194,36 @@ START_TEST(qobject_to_q
Next commit will introduce a new QDict iteration API which
returns QDictEntry entries, but we don't want users to directly
access its members since QDictEntry should be private to QDict.
In the near future this kind of data type will be turned into a
forward reference.
Signed-off-by: Luiz Capitul
It's composed of functions qdict_first() and qdict_next(), plus
functions to access QDictEntry values.
This API was suggested by Markus Armbruster and
it offers full control over the iteration process.
The usage is simple, the following example prints all keys in 'qdict'
(it's hopefully better t
A missing key is not an error.
Signed-off-by: Luiz Capitulino
---
qdict.c |6 +++---
qdict.h |2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/qdict.c b/qdict.c
index 175bc17..c974d6f 100644
--- a/qdict.c
+++ b/qdict.c
@@ -272,16 +272,16 @@ const char *qdict_get_str(c
Let's call a 'hash' only what is returned by our hash function,
anything else is a 'bucket'.
This helps avoiding confusion with regard to how we traverse
our table.
Signed-off-by: Luiz Capitulino
---
check-qdict.c |2 +-
qdict.c | 24
qdict.h |4 ++
From: Jan Kiszka
As sending "qmp_capabilities" on session start became mandatory, both
python examples were broken.
Signed-off-by: Jan Kiszka
Signed-off-by: Luiz Capitulino
---
QMP/qmp-shell |1 +
QMP/vm-info |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/QMP/q
From: Yoshiaki Tamura
This fixes the following scenario using QMP.
First, put a bogus argument "foo" to "type", which results in an error.
{"execute": "netdev_add", "arguments": { "type": "foo", "id": "netdev1" } }
Then, call it again with correct argument "user".
{"execute": "netdev_add", "argu
The current asynchronous command API doesn't return a QMP response
when the async command fails.
This is easy to reproduce with the balloon command (the sole async
command we have so far): run qemu w/o the '-balloon virtio' option
and try to issue the balloon command via QMP: no response will be
s
From: Jan Kiszka
As we want to add more flags to monitor commands, convert the only so
far existing one accordingly.
Signed-off-by: Jan Kiszka
Signed-off-by: Luiz Capitulino
---
monitor.c |6 +++---
monitor.h |3 +++
qemu-monitor.hx |2 +-
3 files changed, 7 insertions
The 'by the guest' part is misleading, it could be disabled by
the host too.
We will likely need more surgery if we care for the distinction,
just dropping the problematic part is good enough for now.
Signed-off-by: Luiz Capitulino
---
qerror.c |2 +-
1 files changed, 1 insertions(+), 1 del
From: Jan Kiszka
Remove the arbitrary limitation of 1024 characters per return string and
read complete lines instead. Required for device_show.
Signed-off-by: Jan Kiszka
Signed-off-by: Luiz Capitulino
---
QMP/qmp.py |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git
From: Jan Kiszka
We now have to move forward to the next argument type via next_arg_type.
This patch fixes completion for 'eject' and maybe also other commands.
Signed-off-by: Jan Kiszka
Signed-off-by: Luiz Capitulino
---
monitor.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Hi Anthony,
The following QMP/Monitor patches have been sent to the list and look good
to me. I also did some basic testing on them.
Most of these changes are bug fixes, the only exception is my new argument
checker series, which is a complete rewrite (that also fix bugs...).
The changes (since
From: Jan Kiszka
Given too many arguments or an invalid command, we were leaking the
duplicated argument strings.
Signed-off-by: Jan Kiszka
Signed-off-by: Luiz Capitulino
---
monitor.c | 23 +++
1 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/monitor.c b/
On 07/01/2010 10:45 AM, Paul Brook wrote:
Since it solves existing problem and is rejected without any rational
explanation and without proposing alternative solution (in form of code)
it should be committed.
No. This is not sufficient justification for applying a patch. We should not
be a
On 07/01/2010 02:13 AM, Jan Kiszka wrote:
Anthony Liguori wrote:
-no-hpet works in every version of qemu/qemu-kvm that has included HPET
support. RHEL disables HPET support by default unlike qemu and qemu-
kvm.
I've updated the bug priority and title to reflect what the issue is.
We only
Am 01.07.2010 17:53, schrieb Jes Sorensen:
On 07/01/10 17:51, Stefan Weil wrote:
Am 01.07.2010 15:24, schrieb Jes Sorensen:
On 07/01/10 15:22, Stefan Weil wrote:
It won't fail for two reasons:
* It is not redefined (at least for linux systems) because I used the
POSIX declar
** Description changed:
When trying to install windows vista sp2 64bit on a KVM VM, we get
consistently a segfault.
Version of qemu affected: Commit hash for
git://git.savannah.nongnu.org/qemu.git is
d9b73e47a3d596c5b33802597ec5bd91ef3348e2 (no tag found)
Backtrace:
- [r...@vi
On 07/01/2010 04:08 AM, Stefan Weil wrote:
> gcc can check printf like variable arguments.
> These patches tell gcc to do so for several functions.
>
> [PATCH 1/4] blockdev.h: Add GCC attribute (check format arguments)
> [PATCH 2/4] darwin-user: Add GCC attribute (check format arguments)
> [PATCH
On Thu, 1 Jul 2010, Richard Henderson wrote:
> On 07/01/2010 05:04 AM, Vic3Dexe wrote:
> > Public bug reported:
> >
> > xchg r8,rax (49h 90h) executed as nop (90h) in long mode, in other words
> > REX not used.
> >
> > qemu 0.12.4, host Win 7 x64, running qemu-system-x86_64.exe.
> >
> > ** Aff
We were ignoring REX_B while special-casing NOP, i.e. xchg eax,eax.
Signed-off-by: Richard Henderson
---
target-i386/translate.c |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 708b0a1..8cb5cf0 100644
--- a/
On 07/01/2010 05:04 AM, Vic3Dexe wrote:
> Public bug reported:
>
> xchg r8,rax (49h 90h) executed as nop (90h) in long mode, in other words
> REX not used.
>
> qemu 0.12.4, host Win 7 x64, running qemu-system-x86_64.exe.
>
> ** Affects: qemu
> Importance: Undecided
> Status: New
>
On Thu, Jul 01, 2010 at 12:31:16PM +0900, Hidetoshi Seto wrote:
> # This patch is for qemu-kvm.git
>
> The vapic.bin is a generated binary file.
>
> Signed-off-by: Hidetoshi Seto
> ---
> .gitignore |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Applied, thanks.
On 07/01/10 17:51, Stefan Weil wrote:
> Am 01.07.2010 15:24, schrieb Jes Sorensen:
>> On 07/01/10 15:22, Stefan Weil wrote:
>>> It won't fail for two reasons:
>>>
>>> * It is not redefined (at least for linux systems) because I used the
>>> POSIX declaration.
>>
>> This still fails with strict comp
Am 01.07.2010 15:24, schrieb Jes Sorensen:
On 07/01/10 15:22, Stefan Weil wrote:
It won't fail for two reasons:
* It is not redefined (at least for linux systems) because I used the
POSIX declaration.
This still fails with strict compiler flags.
* It is compiled only for _WIN32 (see line 95
> Since it solves existing problem and is rejected without any rational
> explanation and without proposing alternative solution (in form of code)
> it should be committed.
No. This is not sufficient justification for applying a patch. We should not
be accepting patches just because they exist.
The bdrv_aio_multiwrite error handling has some bugs that lead to premature
cleanup, causing use-after-free and double free problems.
Kevin Wolf (2):
block: Fix too early free in multiwrite
block: Handle multiwrite errors only when all requests have completed
block.c | 11 +++
1 fi
bdrv_aio_writev may call the callback immediately (and it will commonly do so
in error cases). If num_requests doesn't have its final value yet,
multiwrite_cb will falsely detect that all requests are completed and frees
the mcb. However, the mcb is still used by other requests that are started onl
Don't try to be clever by freeing all temporary data and calling all callbacks
when the return value (an error) is certain. Doing so has at least two
important problems:
* The temporary data that is freed (qiov, possibly zero buffer) is still used
by the requests that have not yet completed.
* C
On 07/01/10 15:22, Stefan Weil wrote:
> It won't fail for two reasons:
>
> * It is not redefined (at least for linux systems) because I used the
> POSIX declaration.
This still fails with strict compiler flags.
> * It is compiled only for _WIN32 (see line 95).
True, but we need to move stuff ou
Am 01.07.2010 13:50, schrieb Jes Sorensen:
On 07/01/10 12:47, Stefan Weil wrote:
Mingw32 does not provide a declaration and implementation of function
setenv (which is used in sdl.c), so this patch adds both.
Signed-off-by: Stefan Weil
[snip]
diff --git a/osdep.h b/osdep.h
index
Am 01.07.2010 13:53, schrieb Christophe LYON:
Maybe adding a -logfile option would allow what you're trying to achieve
without affecting other use cases? I've always thought that it's strange
that you can only change the logfile location in the monitor and not on
the command line.
Kevin
Her
On Thu, 1 Jul 2010 14:26:13 +0530, Sripathi Kodi wrote:
> On Thu, 01 Jul 2010 11:01:15 +0530
> "Aneesh Kumar K. V" wrote:
>
> > On Fri, 28 May 2010 16:08:43 +0530, Sripathi Kodi
> > wrote:
> > > From: M. Mohan Kumar
> > >
> > > SYNOPSIS
> > >
> > > size[4] Tgetattr tag[2] fid[4]
> > >
Public bug reported:
xchg r8,rax (49h 90h) executed as nop (90h) in long mode, in other words
REX not used.
qemu 0.12.4, host Win 7 x64, running qemu-system-x86_64.exe.
** Affects: qemu
Importance: Undecided
Status: New
--
xchg r8,rax treated as nop
https://bugs.launchpad.net/bu
Looks good to me.
Maybe adding a -logfile option would allow what you're trying to achieve
without affecting other use cases? I've always thought that it's strange
that you can only change the logfile location in the monitor and not on
the command line.
Kevin
Here is patch that does what you suggest.
Christo
On 07/01/10 12:47, Stefan Weil wrote:
> Mingw32 does not provide a declaration and implementation of function
> setenv (which is used in sdl.c), so this patch adds both.
>
> Signed-off-by: Stefan Weil
[snip]
> diff --git a/osdep.h b/osdep.h
> index 75b5816..1cdc7e2 100644
> --- a/osdep.h
> +++ b/
state = 0 in rules means that the rule is valid for any state. Therefore it's
impossible to have a rule that works only in the initial state. This changes
the initial state from 0 to 1 to make this possible.
Signed-off-by: Kevin Wolf
---
block/blkdebug.c |3 +++
1 files changed, 3 insertions
The list head was initialized to point to the wrong list, so all actions ended
up being handled as inject-error even if they were set-state in fact.
Signed-off-by: Kevin Wolf
---
block/blkdebug.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/blkdebug.c b/block/b
Signed-off-by: Stefan Weil
---
qemu-char.h |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/qemu-char.h b/qemu-char.h
index e3a0783..1bbac6e 100644
--- a/qemu-char.h
+++ b/qemu-char.h
@@ -76,7 +76,8 @@ CharDriverState *qemu_chr_open_opts(QemuOpts *opts,
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
qemu-option.c |9 +
qemu-option.h |1 +
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/qemu-option.c b/qemu-option.c
index 7f70d0f..30327d4 100644
--- a/qemu-option.c
+++ b/q
Turns out that using more than one state doesn't really work well. I'm trying
to reproduce a bug for which I need states, so now is the time to fix it.
v2:
- Use Markus' qemu_opts_reset for freeing QemuOpts. Makes the code reusable and
fixes a use-after-free bug.
Kevin Wolf (3):
blkdebug: Fix
Signed-off-by: Stefan Weil
---
slirp/slirp.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/slirp/slirp.h b/slirp/slirp.h
index 98a2644..c30c19e 100644
--- a/slirp/slirp.h
+++ b/slirp/slirp.h
@@ -294,7 +294,7 @@ void if_start(struct ttys *);
long gethostid(void);
#en
Forgetting to free them means that the next instance inherits all rules and
gets its own rules only additionally.
Signed-off-by: Kevin Wolf
---
block/blkdebug.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/block/blkdebug.c b/block/blkdebug.c
index 4ec8ca6..78cbff4 10
Signed-off-by: Stefan Weil
---
darwin-user/qemu.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/darwin-user/qemu.h b/darwin-user/qemu.h
index 462bbda..c8adce7 100644
--- a/darwin-user/qemu.h
+++ b/darwin-user/qemu.h
@@ -100,7 +100,7 @@ int do_sigaction(int sig, const s
Signed-off-by: Stefan Weil
---
blockdev.h |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/blockdev.h b/blockdev.h
index 23ea576..3c5c85d 100644
--- a/blockdev.h
+++ b/blockdev.h
@@ -42,7 +42,8 @@ extern int drive_get_max_bus(BlockInterfaceType type);
extern void drive_
gcc can check printf like variable arguments.
These patches tell gcc to do so for several functions.
[PATCH 1/4] blockdev.h: Add GCC attribute (check format arguments)
[PATCH 2/4] darwin-user: Add GCC attribute (check format arguments)
[PATCH 3/4] qemu-char.h: Add GCC attribute (check format argum
Mingw32 does not provide a declaration and implementation of function
setenv (which is used in sdl.c), so this patch adds both.
Signed-off-by: Stefan Weil
---
os-win32.c | 15 +++
osdep.h|2 ++
2 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/os-win32.c b/os-
On 07/01/10 09:04, Jan Kiszka wrote:
>> As I wrote in this bug I had problems with a kernel 2.6.28-11 and the
>> _latest_ version of kvm-kmod. It works only with the right (not the
>> latest) version of kvm-kmod.
>
> Once you properly installed the kernel headers that kvm-kmod delivers,
> qemu sh
In addition to the previous fix for calling do_flush_queued_data() only
when the virtqueue is ready, ensure do_flush_queued_data() gets a vq
that's suitably initialised.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/h
Am 20.06.2010 21:26, schrieb MORITA Kazutaka:
> This patch removes exit(1) from error(), and properly releases
> resources such as a block driver and an allocated memory.
>
> For testing the Sheepdog block driver with qemu-iotests, it is
> necessary to call bdrv_delete() before the program exits.
If a virtio-serial port is removed before the guest comes up and
initialises the virtqueues, qemu exits with the message
Guest moved used index from 0 to 61440
This happens because we try to clear any pending buffers from the
virtqueue.
Ensure the virtqueue is initialised before calling any virt
On Wed, Jun 30, 2010 at 09:11:45PM +0530, Prerna Saxena wrote:
> [PATCH 1/1] Move definitions of monitor command handlers (do_info_trace,
> do_info_all_trace_events) to monitor.c. This removes build errors for
> user targets such as i386-linux-user, which are not linked with monitor.
>
> The exp
Am 09.04.2010 13:20, schrieb Stefan Weil:
Aurelien Jarno schrieb:
On Mon, Mar 29, 2010 at 09:16:52PM +0200, Stefan Weil wrote:
The compiler should check the arguments for these functions.
gcc can do this, but only if the function pointer's prototype
includes the __attribute__ flag.
As the nec
On Thu, 01 Jul 2010 11:01:15 +0530
"Aneesh Kumar K. V" wrote:
> On Fri, 28 May 2010 16:08:43 +0530, Sripathi Kodi
> wrote:
> > From: M. Mohan Kumar
> >
> > SYNOPSIS
> >
> > size[4] Tgetattr tag[2] fid[4]
> >
> > size[4] Rgetattr tag[2] lstat[n]
> >
> >DESCRIPTION
> >
> >
Am 01.07.2010 09:30, schrieb Markus Armbruster:
> I'm working on cleanly separating block device host and guest parts.
> I'd like to route all this work through Kevin's block tree. This is
> still just preliminaries.
>
> There will be at least one more round of cleanup & fixes before
> blockdev_a
On Thu, Jul 01, 2010 at 09:13:48AM +0200, Jan Kiszka wrote:
> > We could potentially use the
> > reset_irq_delivered/get_irq_delivered APIC functions to implement
> > interrupt catch-up but I think it would be better to try to merge Jan's
> > generic IRQ delivered API first.
>
> Which one? I'm a
BlockDriverState member removable controls whether virtual media
change (monitor commands change, eject) is allowed. It is set when
the "type hint" is BDRV_TYPE_CDROM or BDRV_TYPE_FLOPPY.
The type hint is only set by drive_init(). It sets BDRV_TYPE_FLOPPY
for if=floppy. It sets BDRV_TYPE_CDROM
Drives defined with -drive if=ide get get created along with the IDE
controller, inside machine->init(). That's before cmos_init().
Drives defined with -device get created during generic device init.
That's after cmos_init(). Because of that, CMOS has no information on
them (type, geometry, trans
Signed-off-by: Markus Armbruster
---
block.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/block.c b/block.c
index acb4182..603874d 100644
--- a/block.c
+++ b/block.c
@@ -1783,19 +1783,18 @@ BlockDriverState *bdrv_snapshots(void)
{
BlockDriverState *bs;
Set up host kernel include paths specified by --kerneldir
When host kernel headers are placed in non-standard paths, the
KVM_CFLAGS are presently invoked only for a few .c files (kvm*.c,vhost*.c)
and not for other files like machine.c, cpus.c ..etc which also depend on
linux/kvm.h
Signed-off-b
Signed-off-by: Markus Armbruster
---
hw/ide.h | 11 ++-
hw/ide/isa.c |8
hw/ide/piix.c |6 --
3 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/hw/ide.h b/hw/ide.h
index 0e7d540..f0cb320 100644
--- a/hw/ide.h
+++ b/hw/ide.h
@@ -1,17 +1,18 @@
#i
Signed-off-by: Markus Armbruster
---
blockdev.c | 12
blockdev.h |1 -
2 files changed, 0 insertions(+), 13 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 4848112..cecde2b 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -75,18 +75,6 @@ DriveInfo *drive_get(BlockInterfaceT
We automatically delete blockdev host parts on unplug of the guest
device. Too much magic, but we can't change that now.
The delete happens early in the guest device teardown, before the
connection to the host part is severed. Thus, the guest part's
pointer to the host part dangles for a brief t
1 - 100 of 111 matches
Mail list logo
