[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-16 Thread Peter Stuge
Avi Kivity wrote: > In general, ACPI code can work with memory or device registers that have > been initialized by the BIOS and depend on them. It's possible to write > ACPI code that depends on preceding BIOS code. It's also possible to write C code that makes extensive use of goto. :) To be

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-16 Thread Gleb Natapov
On Wed, Jun 16, 2010 at 08:55:05PM -0400, Kevin O'Connor wrote: > On Tue, Jun 15, 2010 at 07:41:02AM +0300, Avi Kivity wrote: > > On 06/14/2010 09:25 PM, Kevin O'Connor wrote: > > >This seems to be a philosophical distinction. Lets go over the > > >practical implications. > > In my experience, wel

[Qemu-devel] [PATCH 10/10] pci: don't overwrite multi functio bit in pci header type.

2010-06-16 Thread Isaku Yamahata
Don't overwrite pci header type. Otherwise, multi function bit which pci_init_header_type() sets appropriately is lost. Anyway PCI_HEADER_TYPE_NORMAL is zero, so it is unnecessary to zero which is already zero cleared. Signed-off-by: Isaku Yamahata --- changes v1 -> v2: - set header type of brid

[Qemu-devel] [PATCH 09/10] pci: set PCI multi-function bit appropriately.

2010-06-16 Thread Isaku Yamahata
set PCI multi-function bit appropriately. Signed-off-by: Isaku Yamahata --- changes v1 -> v2: don't set header type register in configuration space. --- hw/pci.c | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 5316aa5..

[Qemu-devel] [PATCH 06/10] pci: eliminate work around in pci_device_reset().

2010-06-16 Thread Isaku Yamahata
Eliminate work around in pci_device_reset() by making each pci reset function to call pci_device_reset_default(). If a driver reset function isn't specified, set it to pci default reset function. Signed-off-by: Isaku Yamahata --- hw/e1000.c |1 + hw/lsi53c895a.c |2 ++ hw/pci.c

[Qemu-devel] [PATCH 02/10] qdev: export qdev_reset() for later use.

2010-06-16 Thread Isaku Yamahata
export qdev_reset() for later use. Signed-off-by: Isaku Yamahata --- hw/qdev.c | 13 + hw/qdev.h |1 + 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 61f999c..378f842 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -256,13 +256,18 @@ Devic

[Qemu-devel] [PATCH 01/10] pci_bridge: split out pci bridge code into pci_bridge.c from pci.c

2010-06-16 Thread Isaku Yamahata
Move pci bridge related code into pci_bridge.c from pci.c for further enhancement. pci.c is big enough now, so split it out. In fact, some of pci bridge functions stays in pci.c because it accesses to PCIBus member. Unstatic the accessor functions and use them from pci_bridge.c Signed-off-by: Isa

[Qemu-devel] [PATCH 03/10] pci: fix pci_bus_reset() with 64bit BAR and several clean ups.

2010-06-16 Thread Isaku Yamahata
fix pci_device_reset() with 64bit BAR. export pci_bus_reset(), pci_device_reset() and two helper functions for later use. And several clean ups. Signed-off-by: Isaku Yamahata --- hw/pci.c | 44 hw/pci.h |5 + 2 files changed, 41 insertions(+

[Qemu-devel] [PATCH 04/10] pci_bridge: introduce pci bridge layer.

2010-06-16 Thread Isaku Yamahata
introduce pci bridge layer. export pci_bridge_write_config() for generic use. support device reset and bus reset of bridge control. convert apb bridge and dec p2p bridge to use new pci bridge layer. save/restore is supported as a side effect. This might be a bit over engineering, but this is also

[Qemu-devel] [PATCH 05/10] pci bridge: add helper function for ssvid capability.

2010-06-16 Thread Isaku Yamahata
helper function to add ssvid capability. Signed-off-by: Isaku Yamahata --- hw/pci_bridge.c | 20 hw/pci_bridge.h |3 +++ 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/hw/pci_bridge.c b/hw/pci_bridge.c index 43c21d4..1397a11 100644 --- a/hw/pci_bridge.

[Qemu-devel] [PATCH 00/10] pci: pci to pci bridge clean up and enhancement

2010-06-16 Thread Isaku Yamahata
This patch series cleans up pci to pci bridge layer by introducing pci bridge layer. and some bug fixes. Although pci bridge implementation would belong to pci.c, I split it out into pci_bridge.c because pci.c is already big enough. This might seem over engineering, but it's also a preparation for

[Qemu-devel] [PATCH 08/10] pci: remove PCIDeviceInfo::header_type

2010-06-16 Thread Isaku Yamahata
replace PCIDeviceInfo::header_type with is_bridge as suggested by Michael S. Tsirkin Signed-off-by: Isaku Yamahata --- hw/apb_pci.c|2 +- hw/dec_pci.c|2 +- hw/pci.c|9 - hw/pci.h|8 ++-- hw/pci_bridge.c |6 +- 5 files changed, 17 inse

[Qemu-devel] [PATCH 07/10] pci: fix pci domain registering.

2010-06-16 Thread Isaku Yamahata
Only pci host bus must be registered as root bus. Signed-off-by: Isaku Yamahata --- hw/pci.c |8 ++-- hw/pci.h |1 + hw/piix_pci.c |1 + 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 5dee102..162dcd4 100644 --- a/hw/pci.c +++ b

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Gleb Natapov
On Wed, Jun 16, 2010 at 06:00:56PM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Wed, Jun 16, 2010 at 12:35:16PM +0300, Gleb Natapov wrote: > >> On Wed, Jun 16, 2010 at 11:33:13AM +0200, Jan Kiszka wrote: > >>> Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 09:57:35AM +0200, Jan Kiszka

Re: [Qemu-devel] Re: KVM call minutes for June 15

2010-06-16 Thread Aurelien Jarno
On Tue, Jun 15, 2010 at 11:41:53AM -0400, Christoph Hellwig wrote: > On Tue, Jun 15, 2010 at 08:18:12AM -0700, Chris Wright wrote: > > KVM/qemu patches > > - patch rate is high, documentation is low, review is low > > - patches need to include better descriptions and documentation > > - will slow

Re: [Qemu-devel] Re: [PATCH RFC] Mark a device as non-migratable

2010-06-16 Thread Cam Macdonell
On Wed, Jun 16, 2010 at 6:34 AM, Anthony Liguori wrote: > On 06/16/2010 12:05 AM, Cam Macdonell wrote: >> >> On Tue, Jun 15, 2010 at 4:33 PM, Anthony Liguori >>  wrote: >> >>> >>> On 06/15/2010 05:26 PM, Cam Macdonell wrote: >>> On Tue, Jun 15, 2010 at 10:32 AM, Anthony Liguori  wro

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-16 Thread Avi Kivity
On 06/17/2010 04:47 AM, Kevin O'Connor wrote: BTW, it's been said several times now that ACPI is an interface between OS and firmware. I don't see this at all - ACPI defines how the OS can interact with the hardware. The only place I know of where seabios has involvement is with it's tiny (16

[Qemu-devel] Re: [PATCH] SeaBIOS: Fix bvprintf() to respect padding for hex printing.

2010-06-16 Thread Kevin O'Connor
On Mon, Jun 14, 2010 at 02:04:31PM +0200, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Fix bvprintf to respect space padding when printing hex numbers > and the caller specifies alignment without zero padding, eg. %2x > as opposed to %02x Hi Jes, I thought your patch would increase s

[Qemu-devel] Re: [PATCH v3] qemu: kvm: Enable XSAVE live migration support

2010-06-16 Thread Sheng Yang
On Thursday 17 June 2010 00:05:44 Marcelo Tosatti wrote: > On Wed, Jun 16, 2010 at 05:48:46PM +0200, Jan Kiszka wrote: > > Marcelo Tosatti wrote: > > > On Fri, Jun 11, 2010 at 12:36:49PM +0800, Sheng Yang wrote: > > >> Signed-off-by: Sheng Yang > > >> --- > > >> > > >> qemu-kvm-x86.c| 1

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-16 Thread Peter Stuge
My background is that of a strong coreboot proponent. Gleb Natapov wrote: > So why not go further? In theory qemu needs seabios only for legacy bios > functionality. Qemu is perfectly capable of configuring HW to OS usable > state by itself, so we can have coreboot functionality completely inside

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-16 Thread Kevin O'Connor
On Tue, Jun 15, 2010 at 09:50:48AM +0300, Gleb Natapov wrote: > On Tue, Jun 15, 2010 at 07:47:55AM +0300, Avi Kivity wrote: > > One of Kevin's points was that the ACPI tables are a documented > > interface. AFAIR, the firmware configuration interface isn't. We > > need to start documenting it (an

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-16 Thread Kevin O'Connor
On Tue, Jun 15, 2010 at 09:37:07AM +0300, Gleb Natapov wrote: > On Mon, Jun 14, 2010 at 04:12:32PM -0400, Kevin O'Connor wrote: > > But.. in order to move to a newer ACPI spec, there would be qemu > > changes anyway. (If nothing else, so that qemu can tell seabios if > > it's okay to use the new r

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-16 Thread Kevin O'Connor
On Tue, Jun 15, 2010 at 07:41:02AM +0300, Avi Kivity wrote: > On 06/14/2010 09:25 PM, Kevin O'Connor wrote: > >This seems to be a philosophical distinction. Lets go over the > >practical implications. > In my experience, well-defined interfaces ("philosophical > distinctions") are more important i

[Qemu-devel] Re: [RESEND PATCH] acpi_piix4: save gpe and pci hotplug slot status

2010-06-16 Thread Juan Quintela
Alex Williamson wrote: > On Wed, 2010-06-16 at 20:43 +0200, Juan Quintela wrote: >> Alex Williamson wrote: >> > On Wed, 2010-06-16 at 17:47 +0200, Juan Quintela wrote: >> >> Anthony Liguori wrote: >> >> > On 06/14/2010 03:28 PM, Alex Williamson wrote: >> >> >> PCI hotplug currently doesn't work

[Qemu-devel] Re: [CFR 6/10] cont command

2010-06-16 Thread Juan Quintela
Anthony Liguori wrote: > On 06/16/2010 05:05 PM, Juan Quintela wrote: >> Anthony Liguori wrote: >> >>> On 06/16/2010 11:25 AM, Daniel P. Berrange wrote: >>> > This is related to the commands, not QMP per se: > > Once that we are talking about "cont" command. Th

Re: [Qemu-devel] Re: [CFR 6/10] cont command

2010-06-16 Thread Anthony Liguori
On 06/16/2010 05:05 PM, Juan Quintela wrote: Anthony Liguori wrote: On 06/16/2010 11:25 AM, Daniel P. Berrange wrote: This is related to the commands, not QMP per se: Once that we are talking about "cont" command. There are two cases that we need to think of: - incoming mi

[Qemu-devel] Re: [CFR 6/10] cont command

2010-06-16 Thread Juan Quintela
Anthony Liguori wrote: > On 06/16/2010 11:17 AM, Juan Quintela wrote: >> Anthony Liguori wrote: >> >>> On 06/16/2010 08:11 AM, Juan Quintela wrote: >>> >> >>> It's only ensured if you've got the same disk image running on another >>> machine. Considering that we support migrating f

Re: [Qemu-devel] Re: [PATCH] monitor: Really show snapshot information about all devices

2010-06-16 Thread Miguel Di Ciurcio Filho
On Wed, Jun 16, 2010 at 12:22 PM, Chris Lalancette wrote: >> > I didn't mention in the commit, but I've looked at libvirt's source >> > and it is not using 'info snapshots' AFAIK. >> >> Anthony, Dan, are you okay with the change then? > > Right, exactly as Miguel said, libvirt doesn't use "info sn

[Qemu-devel] Re: [CFR 6/10] cont command

2010-06-16 Thread Juan Quintela
Anthony Liguori wrote: > On 06/16/2010 11:25 AM, Daniel P. Berrange wrote: >> >>> This is related to the commands, not QMP per se: >>> >>> Once that we are talking about "cont" command. There are two cases that >>> we need to think of: >>> >>> - incoming migration: >>> >>> If you start with -inco

[Qemu-devel] Re: [PATCH 2/8] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-16 Thread Miguel Di Ciurcio Filho
On Wed, Jun 16, 2010 at 2:39 PM, Luiz Capitulino wrote: >> +SQMP >> +query-netdev >> + >> + >> +Each device is represented by a json-object. The returned value is a >> json-array >> +of all devices. >> + >> +Each json-object contain the following: >> + >> +- "id": the device's ID,

[Qemu-devel] [Bug 595117] Re: qemu-nbd slow and missing "writeback" cache option

2010-06-16 Thread Dustin Kirkland
Stephane- Could you please send that patch to the qemu-devel@ mailing list? Thanks! -- qemu-nbd slow and missing "writeback" cache option https://bugs.launchpad.net/bugs/595117 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in

[Qemu-devel] [Bug 595117] Re: qemu-nbd slow and missing "writeback" cache option

2010-06-16 Thread Anthony Liguori
Patches should go to qemu-devel, not bug reports. ** Changed in: qemu Status: New => Invalid -- qemu-nbd slow and missing "writeback" cache option https://bugs.launchpad.net/bugs/595117 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to Q

[Qemu-devel] [Bug 595117] Re: qemu-nbd slow and missing "writeback" cache option

2010-06-16 Thread Serge Hallyn
Noone has confirmed, but have passed along to upstream. If upstream takes this patch then we will likely pull it into our patchset. ** Changed in: qemu-kvm (Ubuntu) Status: Confirmed => Incomplete -- qemu-nbd slow and missing "writeback" cache option https://bugs.launchpad.net/bugs/59511

Re: [Qemu-devel] Re: [PATCH 2/2] pci: don't overwrite pci header type.

2010-06-16 Thread Anthony Liguori
On 06/16/2010 02:22 PM, Michael S. Tsirkin wrote: On Wed, Jun 16, 2010 at 07:02:54PM +, Blue Swirl wrote: On Wed, Jun 16, 2010 at 6:51 PM, Michael S. Tsirkin wrote: On Wed, Jun 16, 2010 at 06:41:22PM +, Blue Swirl wrote: On Wed, Jun 16, 2010 at 8:54 AM, Michael S. Ts

[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

2010-06-16 Thread Rob
** Changed in: qemu-kvm (Ubuntu Lucid) Status: New => Confirmed -- qemu fails to set hdd serial number https://bugs.launchpad.net/bugs/584143 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: In Progress Status in “

[Qemu-devel] [Bug 595117] Re: qemu-nbd slow and missing "writeback" cache option

2010-06-16 Thread Serge Hallyn
** Also affects: qemu Importance: Undecided Status: New ** Changed in: qemu-kvm (Ubuntu) Status: New => Confirmed -- qemu-nbd slow and missing "writeback" cache option https://bugs.launchpad.net/bugs/595117 You received this bug notification because you are a member of qemu- dev

[Qemu-devel] Re: [PATCH 2/2] pci: don't overwrite pci header type.

2010-06-16 Thread Blue Swirl
On Wed, Jun 16, 2010 at 7:22 PM, Michael S. Tsirkin wrote: > On Wed, Jun 16, 2010 at 07:02:54PM +, Blue Swirl wrote: >> On Wed, Jun 16, 2010 at 6:51 PM, Michael S. Tsirkin wrote: >> > On Wed, Jun 16, 2010 at 06:41:22PM +, Blue Swirl wrote: >> >> On Wed, Jun 16, 2010 at 8:54 AM, Michael S.

Re: [Qemu-devel] [Bug 568228] Re: /home/qemu-0.12.3/tcg/tcg.c:1367: tcg fatal error

2010-06-16 Thread Blue Swirl
On Tue, Jun 15, 2010 at 11:21 AM, Deckhartz wrote: >  I have compiled the qemu 0.12.4 src on Debian 5.0.3 and I have the same > problem on my Sun Ultra45. > > $ uname -a > Linux workstation 2.6.26-2-sparc64 #1 Wed May 12 20:39:46 UTC 2010 sparc64 > GNU/Linux > > > $ qemu --version > QEMU PC emula

[Qemu-devel] Re: [PATCH 2/2] pci: don't overwrite pci header type.

2010-06-16 Thread Michael S. Tsirkin
On Wed, Jun 16, 2010 at 07:02:54PM +, Blue Swirl wrote: > On Wed, Jun 16, 2010 at 6:51 PM, Michael S. Tsirkin wrote: > > On Wed, Jun 16, 2010 at 06:41:22PM +, Blue Swirl wrote: > >> On Wed, Jun 16, 2010 at 8:54 AM, Michael S. Tsirkin > >> wrote: > >> > On Wed, Jun 16, 2010 at 11:20:02AM

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-16 Thread Juan Quintela
Luiz Capitulino wrote: > On Tue, 15 Jun 2010 17:24:59 +0200 > Juan Quintela wrote: >> > >> > I still don't see the need for MIGRATION_STARTED, it could be useful in >> > the target but I'd like to understand the use case in more detail. >> >> At this point, if you are doing migration with tcp,

[Qemu-devel] Re: [RESEND PATCH] acpi_piix4: save gpe and pci hotplug slot status

2010-06-16 Thread Alex Williamson
On Wed, 2010-06-16 at 20:43 +0200, Juan Quintela wrote: > Alex Williamson wrote: > > On Wed, 2010-06-16 at 17:47 +0200, Juan Quintela wrote: > >> Anthony Liguori wrote: > >> > On 06/14/2010 03:28 PM, Alex Williamson wrote: > >> >> PCI hotplug currently doesn't work after a migration because > >>

[Qemu-devel] Re: [PATCH 2/2] pci: don't overwrite pci header type.

2010-06-16 Thread Michael S. Tsirkin
On Wed, Jun 16, 2010 at 06:41:22PM +, Blue Swirl wrote: > On Wed, Jun 16, 2010 at 8:54 AM, Michael S. Tsirkin wrote: > > On Wed, Jun 16, 2010 at 11:20:02AM +0900, Isaku Yamahata wrote: > >> On Tue, Jun 15, 2010 at 12:12:07PM +0300, Michael S. Tsirkin wrote: > >> > On Tue, Jun 15, 2010 at 02:06

[Qemu-devel] Re: [CFR 10/10] qmp: query_balloon command

2010-06-16 Thread Anthony Liguori
On 06/16/2010 10:46 AM, Stefan Hajnoczi wrote: query-balloon - Show balloon information. Make an asynchronous request for balloon info. s/asynchronous//. All requests are asynchronous. When the request completes a json-object will be returned containing the following data: -

[Qemu-devel] Re: [CFR 9/10] qmp: pmemsave command

2010-06-16 Thread Anthony Liguori
On 06/16/2010 10:45 AM, Stefan Hajnoczi wrote: pmemsave Save to disk physical memory dump starting at 'val' of size 'size'. Same feedback as for memsave. Regards, Anthony Liguori Arguments: - "val": the starting address (json-int) - "size": the memory size, in bytes (json-int

[Qemu-devel] Re: [PATCH 2/2] pci: don't overwrite pci header type.

2010-06-16 Thread Blue Swirl
On Wed, Jun 16, 2010 at 6:51 PM, Michael S. Tsirkin wrote: > On Wed, Jun 16, 2010 at 06:41:22PM +, Blue Swirl wrote: >> On Wed, Jun 16, 2010 at 8:54 AM, Michael S. Tsirkin wrote: >> > On Wed, Jun 16, 2010 at 11:20:02AM +0900, Isaku Yamahata wrote: >> >> On Tue, Jun 15, 2010 at 12:12:07PM +030

[Qemu-devel] Re: [CFR 5/10] qmp: migrate_set_speed command

2010-06-16 Thread Anthony Liguori
On 06/16/2010 10:45 AM, Stefan Hajnoczi wrote: migrate_set_speed - Set maximum speed for migrations. Sets the target bandwidth usage for migration. We should mention that this command can be used during a live migration and that the default value is 32MB/sec. We should

[Qemu-devel] Re: [CFR 8/10] qmp: netdev_del command

2010-06-16 Thread Anthony Liguori
On 06/16/2010 10:45 AM, Stefan Hajnoczi wrote: netdev_del -- Remove host network device. Arguments: - "id": the device's ID, must be unique (json-string) Missing failure conditions. Regards, Anthony Liguori Example: -> { "execute": "netdev_del", "arguments": { "id": "netdev

[Qemu-devel] Re: [CFR 4/10] qmp: migrate_set_downtime command

2010-06-16 Thread Anthony Liguori
On 06/16/2010 10:45 AM, Stefan Hajnoczi wrote: migrate_set_downtime Set maximum tolerated downtime (in seconds) for migrations. We should clarify that this is a downtime target but not a hard guarantee. Arguments: - "value": maximum downtime (json-number) s/va

[Qemu-devel] Re: [CFR 6/10] qmp: migrate command

2010-06-16 Thread Anthony Liguori
On 06/16/2010 10:45 AM, Stefan Hajnoczi wrote: migrate --- Migrate to URI. This command will not be compatible with 0.14. Regards, Anthony Liguori Arguments: - "blk": block migration, full disk copy (json-bool, optional) - "inc": incremental disk copy (json-bool, optional) - "uri"

[Qemu-devel] Re: [CFR 7/10] qmp: netdev_add command

2010-06-16 Thread Anthony Liguori
On 06/16/2010 10:45 AM, Stefan Hajnoczi wrote: netdev_add -- Add host network device. Arguments: - "type": the device type, "tap", "user", ... (json-string) - "id": the device's ID, must be unique (json-string) - device options I'd like to see those options enumerated in the spec

[Qemu-devel] Re: [CFR 2/10] qmp: memsave command

2010-06-16 Thread Anthony Liguori
On 06/16/2010 10:45 AM, Stefan Hajnoczi wrote: memsave --- Save to disk virtual memory dump starting at 'val' of size 'size'. Arguments: - "val": the starting address (json-int) s/val/address/ - "size": the memory size, in bytes (json-int) The number of bytes to dump. - "fi

[Qemu-devel] Re: [CFR 3/10] qmp: migrate_cancel command

2010-06-16 Thread Anthony Liguori
On 06/16/2010 10:45 AM, Stefan Hajnoczi wrote: migrate_cancel -- Cancel the current migration. What if there is no pending migration? Regards, Anthony Liguori Arguments: None. Example: -> { "execute": "migrate_cancel" } <- { "return": {} }

[Qemu-devel] Re: [RESEND PATCH] acpi_piix4: save gpe and pci hotplug slot status

2010-06-16 Thread Anthony Liguori
On 06/16/2010 01:43 PM, Juan Quintela wrote: Alex Williamson wrote: On Wed, 2010-06-16 at 17:47 +0200, Juan Quintela wrote: Anthony Liguori wrote: On 06/14/2010 03:28 PM, Alex Williamson wrote: PCI hotplug currently doesn't work after a migration because we don't

[Qemu-devel] Re: [CFR 1/10] qmp: getfd command

2010-06-16 Thread Anthony Liguori
On 06/16/2010 10:45 AM, Stefan Hajnoczi wrote: getfd - Receive a file descriptor via SCM rights and assign it a name. As with the sendfd command, I think we should make this a QMP top-level operation. It's very transport specific. Luiz/Markus, any thoughts on this? Regards, Antho

[Qemu-devel] Re: [RESEND PATCH] acpi_piix4: save gpe and pci hotplug slot status

2010-06-16 Thread Juan Quintela
Alex Williamson wrote: > On Wed, 2010-06-16 at 17:47 +0200, Juan Quintela wrote: >> Anthony Liguori wrote: >> > On 06/14/2010 03:28 PM, Alex Williamson wrote: >> >> PCI hotplug currently doesn't work after a migration because >> >> we don't migrate the enable bits of the GPE state. Pull hotplug

[Qemu-devel] Re: [PATCH 2/2] pci: don't overwrite pci header type.

2010-06-16 Thread Blue Swirl
On Wed, Jun 16, 2010 at 8:54 AM, Michael S. Tsirkin wrote: > On Wed, Jun 16, 2010 at 11:20:02AM +0900, Isaku Yamahata wrote: >> On Tue, Jun 15, 2010 at 12:12:07PM +0300, Michael S. Tsirkin wrote: >> > On Tue, Jun 15, 2010 at 02:06:46PM +0900, Isaku Yamahata wrote: >> > > Don't overwrite pci header

Re: [Qemu-devel] [PATCH v2 7/7] apic: qdev conversion cleanup

2010-06-16 Thread Markus Armbruster
Blue Swirl writes: > On Tue, Jun 15, 2010 at 8:17 AM, Markus Armbruster wrote: >> Blue Swirl writes: >> >>> On Mon, Jun 14, 2010 at 9:36 AM, Markus Armbruster >>> wrote: Blue Swirl writes: > Make APICState completely private to apic.c by using DeviceState > in external APIs

Re: [Qemu-devel] [CFR 0/10] QMP specification review (Part 2)

2010-06-16 Thread Blue Swirl
On Wed, Jun 16, 2010 at 3:45 PM, Stefan Hajnoczi wrote: > This is the second set of commands as part of the QMP specification review. > Please comment on the individual commands specifications and Anthony and I > will > try to fold the comments back into the command documentation. Should the spe

Re: [Qemu-devel] Re: KVM call minutes for June 15

2010-06-16 Thread Blue Swirl
On Tue, Jun 15, 2010 at 4:13 PM, Anthony Liguori wrote: > On 06/15/2010 10:41 AM, Christoph Hellwig wrote: >> >> On Tue, Jun 15, 2010 at 08:18:12AM -0700, Chris Wright wrote: >> >>> >>> KVM/qemu patches >>> - patch rate is high, documentation is low, review is low >>> - patches need to include bet

Re: [Qemu-devel] Re: RFC v2: blockdev_add & friends, brief rationale, QMP docs

2010-06-16 Thread Anthony Liguori
On 06/16/2010 08:57 AM, Kevin Wolf wrote: Am 16.06.2010 15:41, schrieb Anthony Liguori: On 06/16/2010 07:41 AM, Markus Armbruster wrote: Kevin Wolf writes: But it's painful to type for the user. After all -blockdev on the command line is for the user, as tools should use QM

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-16 Thread Luiz Capitulino
On Tue, 15 Jun 2010 17:24:59 +0200 Juan Quintela wrote: > Luiz Capitulino wrote: > > On Tue, 15 Jun 2010 12:30:57 +0200 > > Juan Quintela wrote: > > > >> Anthony Liguori wrote: > >> > On 06/14/2010 02:54 PM, Juan Quintela wrote: > >> >> Anthony Liguori wrote: > >> > >> >>> What makes migrati

Re: [Qemu-devel] VLIW?

2010-06-16 Thread Richard Henderson
On 06/15/2010 08:53 AM, Gibbons, Scott wrote: > Has anyone done a port of QEMU to a VLIW architecture? I’m interested > in seeing what was done. Do you mean as guest or host? I presume guest. There's not such a port in the main repository; I don't know what might have been done privately. It'l

[Qemu-devel] Re: [PATCH 0/8] QMP: Introduce query-netdev

2010-06-16 Thread Luiz Capitulino
On Thu, 10 Jun 2010 18:36:57 -0300 Miguel Di Ciurcio Filho wrote: > This series introduces the protocol specification for querying the backend > network devices and a monitor command to show the same information. Please, add changelog info next time so that it's easier to know what has changed

[Qemu-devel] Re: [PATCH 3/8] net: Introduce VLANClientState->info_dict

2010-06-16 Thread Luiz Capitulino
On Thu, 10 Jun 2010 18:37:00 -0300 Miguel Di Ciurcio Filho wrote: > There is no standard format when formatting VLANClientState.info_str, > so it is difficult to extract information and transmit it over QMP. > > This patch adds info_dict, a QDict to better handle this information. > > Signed-of

[Qemu-devel] Re: [PATCH 4/8] net: tap/tap-win32: introduce info_dict

2010-06-16 Thread Luiz Capitulino
On Thu, 10 Jun 2010 18:37:01 -0300 Miguel Di Ciurcio Filho wrote: > Signed-off-by: Miguel Di Ciurcio Filho > --- > net/tap-win32.c |6 ++ > net/tap.c | 20 > 2 files changed, 26 insertions(+), 0 deletions(-) > > diff --git a/net/tap-win32.c b/net/tap-win32.

[Qemu-devel] Re: [PATCH 2/3] qemu: Enable XSAVE related CPUID

2010-06-16 Thread Marcelo Tosatti
On Wed, Jun 16, 2010 at 10:59:07PM +0800, Sheng Yang wrote: > On Thursday 10 June 2010 11:31:02 Sheng Yang wrote: > > We can support it in KVM now. The 0xd leaf is queried from KVM. > > Hi Marcelo & Avi > > How about patch 1 and 2 in this series? They are used to enable XSAVE cpuid. Applied.

[Qemu-devel] Re: [PATCH 2/8] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-16 Thread Luiz Capitulino
On Thu, 10 Jun 2010 18:36:59 -0300 Miguel Di Ciurcio Filho wrote: > These commands show the information about active backend network devices. > > Signed-off-by: Miguel Di Ciurcio Filho > --- > qemu-monitor.hx | 53 + > 1 files changed, 53 i

[Qemu-devel] RFC v3: blockdev_add & friends, brief rationale, QMP docs

2010-06-16 Thread Markus Armbruster
v3: We don't agree on what "protocol" and "format" mean, even less on how they stack, dumb down accordingly Human monitor syntax v2: Cover protocols Split blockdev_change into media_insert and media_remove Option syntax list TODOs Rationale: Why new commands for block devices

Re: [Qemu-devel] Q35 qemu repository?

2010-06-16 Thread Matthew Garrett
On Wed, Jun 16, 2010 at 04:42:10PM +0100, Matthew Garrett wrote: > Thanks for this - however, Vista gives me an ACPI error on boot (stop > 0x00a5, 0x000d, which indicates that there's a malformed or > undefined ACPI device). I don't suppose you have any idea what the > problem here may

Re: [Qemu-devel] [PATCH v2 7/7] apic: qdev conversion cleanup

2010-06-16 Thread Blue Swirl
On Tue, Jun 15, 2010 at 8:17 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> On Mon, Jun 14, 2010 at 9:36 AM, Markus Armbruster wrote: >>> Blue Swirl writes: >>> Make APICState completely private to apic.c by using DeviceState in external APIs. >>> >>> Could you explain why thi

Re: [Qemu-devel] Re: [CFR 6/10] cont command

2010-06-16 Thread Jamie Lokier
Anthony Liguori wrote: > On 06/16/2010 11:17 AM, Juan Quintela wrote: > >Consider the example that I showed you: > > > >(host A) (host B) > >launch qemu launch qemu -incoming > >migrate host B > > . > > do your things > >

Re: [Qemu-devel] Re: [CFR 6/10] cont command

2010-06-16 Thread Anthony Liguori
On 06/16/2010 11:25 AM, Daniel P. Berrange wrote: This is related to the commands, not QMP per se: Once that we are talking about "cont" command. There are two cases that we need to think of: - incoming migration: If you start with -incoming foo, and then run "cont" on the monitor without h

Re: [Qemu-devel] Re: [PATCH 1/2] qemu-io: retry fgets() when errno is EINTR

2010-06-16 Thread MORITA Kazutaka
At Wed, 16 Jun 2010 13:04:47 +0200, Kevin Wolf wrote: > > Am 15.06.2010 19:53, schrieb MORITA Kazutaka: > > posix-aio-compat sends a signal in aio operations, so we should > > consider that fgets() could be interrupted here. > > > > Signed-off-by: MORITA Kazutaka > > --- > > cmd.c |3 +++ >

[Qemu-devel] Re: [CFR 6/10] cont command

2010-06-16 Thread Anthony Liguori
On 06/16/2010 11:17 AM, Juan Quintela wrote: Anthony Liguori wrote: On 06/16/2010 08:11 AM, Juan Quintela wrote: It's only ensured if you've got the same disk image running on another machine. Considering that we support migrating from a file and we support migrating block devic

[Qemu-devel] Re: [RESEND PATCH] acpi_piix4: save gpe and pci hotplug slot status

2010-06-16 Thread Alex Williamson
On Wed, 2010-06-16 at 17:47 +0200, Juan Quintela wrote: > Anthony Liguori wrote: > > On 06/14/2010 03:28 PM, Alex Williamson wrote: > >> PCI hotplug currently doesn't work after a migration because > >> we don't migrate the enable bits of the GPE state. Pull hotplug > >> structs into vmstate. > >

[Qemu-devel] Re: [PATCH v3] qemu: kvm: Enable XSAVE live migration support

2010-06-16 Thread Marcelo Tosatti
On Wed, Jun 16, 2010 at 05:48:46PM +0200, Jan Kiszka wrote: > Marcelo Tosatti wrote: > > On Fri, Jun 11, 2010 at 12:36:49PM +0800, Sheng Yang wrote: > >> Signed-off-by: Sheng Yang > >> --- > >> qemu-kvm-x86.c| 109 > >> - > >> qemu-kvm.c

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-16 Thread Glauber Costa
On Mon, Jun 14, 2010 at 02:58:47PM -0500, Anthony Liguori wrote: > On 06/14/2010 02:42 PM, Glauber Costa wrote: > >On Mon, Jun 14, 2010 at 02:33:00PM -0500, Anthony Liguori wrote: > >>On 06/14/2010 02:27 PM, Glauber Costa wrote: > >>>This patch fixes a bug that happens with kvm, irqchip-in-kernel,

Re: [Qemu-devel] Re: [PATCH V4 2/3] qemu: Generic task offloading framework: threadlets

2010-06-16 Thread Paolo Bonzini
On 06/16/2010 05:07 PM, Jamie Lokier wrote: Putting the whole condition inside the mutex->cond_wait region, not just empty queue test, will remove the need for timed wait. Yes, the condition must include all the cases when you broadcast. Broadcast is still needed, or alternatively a cond_sign

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-16 Thread Glauber Costa
On Tue, Jun 15, 2010 at 10:33:21AM +0300, Avi Kivity wrote: > On 06/14/2010 10:33 PM, Anthony Liguori wrote: > >On 06/14/2010 02:27 PM, Glauber Costa wrote: > >>This patch fixes a bug that happens with kvm, irqchip-in-kernel, > >>while adding a netdev. Despite the situations of reproduction being >

Re: [Qemu-devel] Re: [CFR 6/10] cont command

2010-06-16 Thread Daniel P. Berrange
On Wed, Jun 16, 2010 at 03:11:24PM +0200, Juan Quintela wrote: > Anthony Liguori wrote: > > cont > > > > > > Resume emulation. > > > > Arguments: None. > > > > Example: > > > > -> { "execute": "cont" } > > <- { "return": {} } > > This is related to the commands, not QMP per se: > > Once tha

[Qemu-devel] Re: [CFR 6/10] cont command

2010-06-16 Thread Juan Quintela
Anthony Liguori wrote: > On 06/16/2010 08:11 AM, Juan Quintela wrote: > It's only ensured if you've got the same disk image running on another > machine. Considering that we support migrating from a file and we > support migrating block devices, I don't think it's practical. > >> - outgoing migr

[Qemu-devel] Re: [PATCH 5/5] linux fbdev display driver.

2010-06-16 Thread Julian Pidancet
On 06/16/2010 01:44 PM, Stefano Stabellini wrote: > > the patch still doesn't use the display allocator interface, but it > shouldn't be difficult to implement support for it on top of this patch, > so it is fine by me. > This patch adds display allocator support in the fbdev driver. This way we

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Jan Kiszka
Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 12:35:16PM +0300, Gleb Natapov wrote: >> On Wed, Jun 16, 2010 at 11:33:13AM +0200, Jan Kiszka wrote: >>> Gleb Natapov wrote: On Wed, Jun 16, 2010 at 09:57:35AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: >> On Wed, Jun 16, 2010 at 09:51:

Re: [Qemu-devel] VLIW?

2010-06-16 Thread Aurelien Jarno
On Tue, Jun 15, 2010 at 08:53:26AM -0700, Gibbons, Scott wrote: > Has anyone done a port of QEMU to a VLIW architecture? I'm interested in > seeing what was done. > The git version of QEMU is working on IA64, which is an EPIC CPU, but can be considered as certain kind of VLIW CPU. -- Aurelien

[Qemu-devel] Re: [PATCH v3] qemu: kvm: Enable XSAVE live migration support

2010-06-16 Thread Jan Kiszka
Marcelo Tosatti wrote: > On Fri, Jun 11, 2010 at 12:36:49PM +0800, Sheng Yang wrote: >> Signed-off-by: Sheng Yang >> --- >> qemu-kvm-x86.c| 109 >> - >> qemu-kvm.c| 24 +++ >> qemu-kvm.h| 28

Re: [Qemu-devel] Re: [PATCH V4 2/3] qemu: Generic task offloading framework: threadlets

2010-06-16 Thread Corentin Chary
On Wed, Jun 16, 2010 at 5:52 PM, Anthony Liguori wrote: > On 06/16/2010 10:47 AM, Corentin Chary wrote: >> >> I would need something like flush_threadlet_queue for the vnc server. >> I need it in >> vnc_disconnect(), vnc_dpy_resize() and vnc_dpy_cpy() so wait (and/or >> abort) current >> encoding

Re: [Qemu-devel] Re: [PATCH V4 2/3] qemu: Generic task offloading framework: threadlets

2010-06-16 Thread Anthony Liguori
On 06/16/2010 10:47 AM, Corentin Chary wrote: I would need something like flush_threadlet_queue for the vnc server. I need it in vnc_disconnect(), vnc_dpy_resize() and vnc_dpy_cpy() so wait (and/or abort) current encoding jobs. I'm not sure threadlets are the right thing for the VNC server

[Qemu-devel] Re: [RESEND PATCH] acpi_piix4: save gpe and pci hotplug slot status

2010-06-16 Thread Juan Quintela
Anthony Liguori wrote: > On 06/14/2010 03:28 PM, Alex Williamson wrote: >> PCI hotplug currently doesn't work after a migration because >> we don't migrate the enable bits of the GPE state. Pull hotplug >> structs into vmstate. >> >> Signed-off-by: Alex Williamson >> > > Applied. Thanks. > >

[Qemu-devel] [CFR 4/10] qmp: migrate_set_downtime command

2010-06-16 Thread Stefan Hajnoczi
migrate_set_downtime Set maximum tolerated downtime (in seconds) for migrations. Arguments: - "value": maximum downtime (json-number) Example: -> { "execute": "migrate_set_downtime", "arguments": { "value": 0.1 } } <- { "return": {} }

[Qemu-devel] [CFR 8/10] qmp: netdev_del command

2010-06-16 Thread Stefan Hajnoczi
netdev_del -- Remove host network device. Arguments: - "id": the device's ID, must be unique (json-string) Example: -> { "execute": "netdev_del", "arguments": { "id": "netdev1" } } <- { "return": {} }

[Qemu-devel] [CFR 10/10] qmp: query_balloon command

2010-06-16 Thread Stefan Hajnoczi
query-balloon - Show balloon information. Make an asynchronous request for balloon info. When the request completes a json-object will be returned containing the following data: - "actual": current balloon value in bytes (json-int) - "mem_swapped_in": Amount of memory swapped in byte

[Qemu-devel] [CFR 1/10] qmp: getfd command

2010-06-16 Thread Stefan Hajnoczi
getfd - Receive a file descriptor via SCM rights and assign it a name. Arguments: - "fdname": file descriptor name (json-string) Example: -> { "execute": "getfd", "arguments": { "fdname": "fd1" } } <- { "return": {} }

[Qemu-devel] [CFR 9/10] qmp: pmemsave command

2010-06-16 Thread Stefan Hajnoczi
pmemsave Save to disk physical memory dump starting at 'val' of size 'size'. Arguments: - "val": the starting address (json-int) - "size": the memory size, in bytes (json-int) - "filename": file path (json-string) Example: -> { "execute": "pmemsave", "arguments": { "val":

[Qemu-devel] [CFR 3/10] qmp: migrate_cancel command

2010-06-16 Thread Stefan Hajnoczi
migrate_cancel -- Cancel the current migration. Arguments: None. Example: -> { "execute": "migrate_cancel" } <- { "return": {} }

[Qemu-devel] [CFR 7/10] qmp: netdev_add command

2010-06-16 Thread Stefan Hajnoczi
netdev_add -- Add host network device. Arguments: - "type": the device type, "tap", "user", ... (json-string) - "id": the device's ID, must be unique (json-string) - device options Example: -> { "execute": "netdev_add", "arguments": { "type": "user", "id": "netdev1" } } <- { "return":

[Qemu-devel] [CFR 5/10] qmp: migrate_set_speed command

2010-06-16 Thread Stefan Hajnoczi
migrate_set_speed - Set maximum speed for migrations. Arguments: - "value": maximum speed, in bytes per second (json-number) Example: -> { "execute": "migrate_set_speed", "arguments": { "value": 1024 } } <- { "return": {} }

Re: [Qemu-devel] Re: [PATCH V4 2/3] qemu: Generic task offloading framework: threadlets

2010-06-16 Thread Corentin Chary
On Wed, Jun 16, 2010 at 5:20 PM, Anthony Liguori wrote: > On 06/16/2010 09:52 AM, Paolo Bonzini wrote: >> >> On 06/16/2010 04:38 PM, Anthony Liguori wrote: >>> >>> On 06/16/2010 09:29 AM, Paolo Bonzini wrote: On 06/16/2010 04:22 PM, Jamie Lokier wrote: > > Paolo Bonzini wrote: >>

[Qemu-devel] [CFR 2/10] qmp: memsave command

2010-06-16 Thread Stefan Hajnoczi
memsave --- Save to disk virtual memory dump starting at 'val' of size 'size'. Arguments: - "val": the starting address (json-int) - "size": the memory size, in bytes (json-int) - "filename": file path (json-string) Example: -> { "execute": "memsave", "arguments": { "val": 10,

[Qemu-devel] [CFR 0/10] QMP specification review (Part 2)

2010-06-16 Thread Stefan Hajnoczi
This is the second set of commands as part of the QMP specification review. Please comment on the individual commands specifications and Anthony and I will try to fold the comments back into the command documentation.

[Qemu-devel] [CFR 6/10] qmp: migrate command

2010-06-16 Thread Stefan Hajnoczi
migrate --- Migrate to URI. Arguments: - "blk": block migration, full disk copy (json-bool, optional) - "inc": incremental disk copy (json-bool, optional) - "uri": Destination URI (json-string) Example: -> { "execute": "migrate", "arguments": { "uri": "tcp:0:4446" } } <- { "return": {} }

  1   2   3   >