[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-14 Thread Gleb Natapov
On Tue, Jun 15, 2010 at 07:47:55AM +0300, Avi Kivity wrote: > On 06/14/2010 10:38 PM, Anthony Liguori wrote: > > > >I think we can be pretty flexible as long as we're careful about > >releases. For instance, I've applied Gleb's current patch but > >won't update SeaBIOS until the interface is worke

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-14 Thread Gleb Natapov
On Mon, Jun 14, 2010 at 04:12:32PM -0400, Kevin O'Connor wrote: > On Mon, Jun 14, 2010 at 09:56:15PM +0300, Gleb Natapov wrote: > > On Mon, Jun 14, 2010 at 02:25:21PM -0400, Kevin O'Connor wrote: > > > It seems there was a change in qemu to the hpet functionality. > > My patch is completely unrelat

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-14 Thread Daniel P. Berrange
On Mon, Jun 14, 2010 at 04:42:37PM -0300, Glauber Costa wrote: > On Mon, Jun 14, 2010 at 02:33:00PM -0500, Anthony Liguori wrote: > > On 06/14/2010 02:27 PM, Glauber Costa wrote: > > >This patch fixes a bug that happens with kvm, irqchip-in-kernel, > > >while adding a netdev. Despite the situations

[Qemu-devel] KVM call agenda for June 15

2010-06-14 Thread Chris Wright
Please send in any agenda items you are interested in covering. If we have a lack of agenda items I'll cancel the week's call. thanks, -chris

[Qemu-devel] [PATCH 2/2] pci: don't overwrite pci header type.

2010-06-14 Thread Isaku Yamahata
Don't overwrite pci header type. Otherwise, multi function bit which pci_init_header_type() sets appropriately is lost. Anyway PCI_HEADER_TYPE_NORMAL is zero, so it is unnecessary to zero which is already zero cleared. Signed-off-by: Isaku Yamahata --- hw/ac97.c |1 - hw/acpi_piix4.c

[Qemu-devel] [PATCH 0/2] pci: multi-function bit fixes

2010-06-14 Thread Isaku Yamahata
When pci devices are populated as multi-function, OS can fail to probe function > 0. It's because multi function bit of header type register in configuration space isn't set, so OS probes only function 0 skipping function > 0 as optimization. This patch set make qemu set multi function bit when fu

[Qemu-devel] [PATCH 1/2] pci: set PCI multi-function bit appropriately.

2010-06-14 Thread Isaku Yamahata
set PCI multi-function bit appropriately. Signed-off-by: Isaku Yamahata --- hw/pci.c | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 3777c1c..a01e9ac 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -578,6 +578,33 @@ static vo

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-14 Thread Avi Kivity
On 06/14/2010 10:38 PM, Anthony Liguori wrote: I think we can be pretty flexible as long as we're careful about releases. For instance, I've applied Gleb's current patch but won't update SeaBIOS until the interface is worked out. If we decide to implement a new interface, there's no harm si

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-14 Thread Avi Kivity
On 06/14/2010 09:25 PM, Kevin O'Connor wrote: On Mon, Jun 14, 2010 at 05:51:27PM +0300, Avi Kivity wrote: On 06/14/2010 05:09 PM, Gleb Natapov wrote: Could we just have qemu build the hpet tables and pass them through to seabios? Perhaps using the qemu_cfg_acpi_additional_tables() me

[Qemu-devel] [PATCH] seabios: acpi: allow qemu to load dsdt as external acpi table.

2010-06-14 Thread Isaku Yamahata
allow qemu to load dsdt as external acpi table. Signed-off-by: Isaku Yamahata --- src/acpi.c | 27 +-- 1 files changed, 25 insertions(+), 2 deletions(-) diff --git a/src/acpi.c b/src/acpi.c index 0559443..254e43b 100644 --- a/src/acpi.c +++ b/src/acpi.c @@ -126,6 +126,

[Qemu-devel] [PATCH] acpi: add option, load_header, to -acpitable in order to load acpi header.

2010-06-14 Thread Isaku Yamahata
This patch adds load_header option to -acpitable in order to load acpi table which includes acpi header. With this option and with seabios patches, alternative dsdt table can be passed to BIOS. Also fix potential buffer overflow. There is no guarantee that file size remains same when loading. Sig

[Qemu-devel] [PATCH] pci hotplug: staticfy pci_device_hot_remove().

2010-06-14 Thread Isaku Yamahata
staticfy pci_device_hot_remove(). Signed-off-by: Isaku Yamahata --- hw/pci-hotplug.c |2 +- sysemu.h |1 - 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/pci-hotplug.c b/hw/pci-hotplug.c index c39e640..098264c 100644 --- a/hw/pci-hotplug.c +++ b/hw/pci-hotplug.

[Qemu-devel] [PATCH] pci hotplug: make pci hotplug return value to caller.

2010-06-14 Thread Isaku Yamahata
Make pci hotplug callback return value to caller. There is no reason to discard return value. Signed-off-by: Isaku Yamahata --- hw/pci.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 7787005..3777c1c 100644 --- a/hw/pci.c +++ b/hw/pc

[Qemu-devel] Re: [Bug 513273] Re: kvm with -vga std is broken since karmic

2010-06-14 Thread Dustin Kirkland
@Claus- Other than the error message, are you seeing incorrect behavior? If so, what specifically? -- kvm with -vga std is broken since karmic https://bugs.launchpad.net/bugs/513273 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Stat

Re: [Qemu-devel] [PATCH 1/4] savevm: refactor qemu_loadvm_state().

2010-06-14 Thread Yoshiaki Tamura
Anthony Liguori wrote: On 06/03/2010 02:22 AM, Yoshiaki Tamura wrote: Split qemu_loadvm_state(), and introduce qemu_loadvm_state_{begin,iterate,complete,async}. qemu_loadvm_state_async() is a function to handle a single incoming section. Signed-off-by: Yoshiaki Tamura --- savevm.c | 206 +++

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-14 Thread Alex Williamson
On Mon, 2010-06-14 at 23:46 +0100, Paul Brook wrote: > > > > Ok, I can get it down to something like: > > > > > > > > /i440FX-pcihost/pci.0/virtio-blk-pci,09.0 > > > > > > > > The addr on the device is initially a little non-intuitive to me since > > > > it's a property of the bus, but I guess it

Re: [Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-14 Thread Paul Brook
> > >>Could we just have qemu build the hpet tables and pass them through to > > >>seabios? Perhaps using the qemu_cfg_acpi_additional_tables() method. > > > > > >Possible, and I considered that. I personally prefer to pass minimum > > >information required for seabios to discover underlying HW an

[Qemu-devel] [PATCH 1/2] tcg: Optionally sign-extend 32-bit arguments for 64-bit hosts.

2010-06-14 Thread Richard Henderson
Some hosts (amd64, ia64) have an ABI that ignores the high bits of the 64-bit register when passing 32-bit arguments. Others require the value to be properly sign-extended for the type. I.e. "int32_t" must be sign-extended and "uint32_t" must be zero-extended to 64-bits. To effect this, extend th

[Qemu-devel] [PATCH 0/2] S390 TCG Port, version 4

2010-06-14 Thread Richard Henderson
As requested, all of the s390 patches have been squashed. r~ Richard Henderson (2): tcg: Optionally sign-extend 32-bit arguments for 64-bit hosts. tcg-s390: New TCG Target. configure|2 + def-helper.h | 38 +- target-i386/ops_sse_header.h |3

Re: [Qemu-devel] [PATCH v2 2/7] ioapic: convert to qdev

2010-06-14 Thread Paul Brook
> >> -static void ioapic_reset(void *opaque) > >> +static void ioapic_reset(DeviceState *d) > >> { > >> -IOAPICState *s = opaque; > >> +IOAPICState *s = container_of(d, IOAPICState, busdev.qdev); > > > > DO_UPCAST()? I hate it, but it's what the other devices do... > > Both are used: >

Re: [Qemu-devel] [PATCH 5/5] [scsi-bsg]: Add initial support for BSG based SCSIDeviceInfo

2010-06-14 Thread Nicholas A. Bellinger
On Mon, 2010-06-14 at 18:11 +, Blue Swirl wrote: > On Mon, Jun 14, 2010 at 9:44 AM, Nicholas A. Bellinger > wrote: > > From: Nicholas Bellinger > > > > This patch adds initial support for using the Linux BSG interface with > > write/read vectored > > AIO as a QEMU backstore (SCSIDeviceInfo)

Re: [Qemu-devel] [PATCH] Fix and simplify gui timer logic.

2010-06-14 Thread Paul Brook
> >> This suggests we are incorrectly coalescing writes, and we should > >> actually be > >> notifying qemu when (at least) he first write occurs. If we aren't > >> outputting > >> anything we don't want to be waking up periodically just to flush an > >> empty > >> MMIO buffer. > > > > That is com

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-14 Thread Paul Brook
> > > Ok, I can get it down to something like: > > > > > > /i440FX-pcihost/pci.0/virtio-blk-pci,09.0 > > > > > > The addr on the device is initially a little non-intuitive to me since > > > it's a property of the bus, but I guess it make sense if we think of > > > that level as slot, which includ

Re: [Qemu-devel] [Bug 521994] Re: Windows 98 doesn't detect mouse on qemu and SeaBIOS.

2010-06-14 Thread Kevin O'Connor
Can you append: -chardev stdio,id=seabios -device isa-debugcon,iobase=0x402,chardev=seabios to your qemu command-line and send the output back? Hopefully they'll be some indication in the log why the mouse isn't working. Thanks, -Kevin On Thu, Jun 10, 2010 at 03:33:19AM -, Will Taff wrote

Re: [Qemu-devel] [PATCH 07/35] tcg: Optionally sign-extend 32-bit arguments for 64-bit host.

2010-06-14 Thread Richard Henderson
On 06/10/2010 03:22 AM, Aurelien Jarno wrote: >> - 0, GET_TCGV_I32(ret), 2, args); >> + (is_signed ? 0x2a : 0x00), GET_TCGV_I32(ret), 2, args); > > Wouldn't it be better to actually pass the whole flag to > tcg_gen_helper32(), so that we can in the future also sup

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-14 Thread Alex Williamson
On Mon, 2010-06-14 at 22:43 +0100, Paul Brook wrote: > > On Mon, 2010-06-14 at 18:49 +0200, Jan Kiszka wrote: > > > Alex Williamson wrote: > > Ok, I can get it down to something like: > > > > /i440FX-pcihost/pci.0/virtio-blk-pci,09.0 > > > > The addr on the device is initially a little non-intuit

Re: [Qemu-devel] [PATCH v6 6/6] the stand-alone shared memory server for inter-VM shared memory

2010-06-14 Thread Cam Macdonell
On Mon, Jun 14, 2010 at 9:53 AM, Anthony Liguori wrote: > On 06/04/2010 04:45 PM, Cam Macdonell wrote: >> >> this code is a standalone server which will pass file descriptors for the >> shared >> memory region and eventfds to support interrupts between guests using >> inter-VM >> shared memory. >>

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-14 Thread Paul Brook
> On Mon, 2010-06-14 at 18:49 +0200, Jan Kiszka wrote: > > Alex Williamson wrote: > > > On Mon, 2010-06-14 at 18:00 +0200, Jan Kiszka wrote: > > >> And instead of introducing another hierarchy level with the bus > > >> address, I would also prefer to add this as prefix or suffix to the > > >> devic

Re: [Qemu-devel] [RESEND PATCH] acpi_piix4: save gpe and pci hotplug slot status

2010-06-14 Thread Alexander Graf
On 14.06.2010, at 22:58, Anthony Liguori wrote: > On 06/14/2010 03:28 PM, Alex Williamson wrote: >> PCI hotplug currently doesn't work after a migration because >> we don't migrate the enable bits of the GPE state. Pull hotplug >> structs into vmstate. >> >> Signed-off-by: Alex Williamson >>

Re: [Qemu-devel] [PATCH] un-register kbd driver in case of USB kbd unplug.

2010-06-14 Thread Anthony Liguori
On 06/08/2010 08:12 AM, jes.soren...@redhat.com wrote: From: Jes Sorensen If a USB keyboard is unplugged, the keyboard eventhandler is never removed, and events will continue to be passed through to the device, causing crashes or memory corruption. Signed-off-by: Jes Sorensen Applied. Th

Re: [Qemu-devel] [PATCH-V7 09/10] virtio-9p: Implement Security model for mknod

2010-06-14 Thread Anthony Liguori
On 06/14/2010 03:34 PM, Venkateswararao Jujjuri (JV) wrote: Mapped mode stores extended attributes in the user space of the extended attributes. Given that the user space extended attributes are available to regular files only, special files are created as regular files on the fileserver and appr

Re: [Qemu-devel] [PATCH-V7 09/10] virtio-9p: Implement Security model for mknod

2010-06-14 Thread Venkateswararao Jujjuri (JV)
Anthony Liguori wrote: > On 06/14/2010 03:34 PM, Venkateswararao Jujjuri (JV) wrote: >> Mapped mode stores extended attributes in the user space of the extended >> attributes. Given that the user space extended attributes are available >> to regular files only, special files are created as regular

Re: [Qemu-devel] [PATCH 1/2] virtio-blk: stop tracking old_bs

2010-06-14 Thread Anthony Liguori
On 06/08/2010 11:25 AM, Christoph Hellwig wrote: There is a 1:1 relation between VirtIOBlock and BlockDriverState instances, no need to track it because it won't change. Signed-off-by: Christoph Hellwig Applied all. Thanks. Regards, Anthony Liguori Index: qemu/hw/virtio-blk.c =

Re: [Qemu-devel] [PATCH 1/4] savevm: refactor qemu_loadvm_state().

2010-06-14 Thread Anthony Liguori
On 06/03/2010 02:22 AM, Yoshiaki Tamura wrote: Split qemu_loadvm_state(), and introduce qemu_loadvm_state_{begin,iterate,complete,async}. qemu_loadvm_state_async() is a function to handle a single incoming section. Signed-off-by: Yoshiaki Tamura --- savevm.c | 206

[Qemu-devel] [PATCH] xen: Fix build error due to missing include

2010-06-14 Thread Jan Kiszka
From: Jan Kiszka Signed-off-by: Jan Kiszka --- hw/xen_backend.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/xen_backend.h b/hw/xen_backend.h index f07f7d4..cc25f9d 100644 --- a/hw/xen_backend.h +++ b/hw/xen_backend.h @@ -5,6 +5,7 @@ #include "sysemu.h" #include

Re: [Qemu-devel] [PATCH] migration-tcp: call migrate_fd_error() instead of close() and free().

2010-06-14 Thread Anthony Liguori
On 06/09/2010 04:50 PM, Yoshiaki Tamura wrote: This patch fixes the following error report. When changing migration-tcp.c to call migrate_fd_error() instead of close() and free() by itself, monitor is resumed, and returns allocated mig_state is set to current_migration in migration.c allows us t

Re: [Qemu-devel] [RESEND PATCH] acpi_piix4: save gpe and pci hotplug slot status

2010-06-14 Thread Anthony Liguori
On 06/14/2010 03:28 PM, Alex Williamson wrote: PCI hotplug currently doesn't work after a migration because we don't migrate the enable bits of the GPE state. Pull hotplug structs into vmstate. Signed-off-by: Alex Williamson Applied. Thanks. Regards, Anthony Liguori --- hw/acpi_pii

Re: [Qemu-devel] [PATCH] qemu-option: Reject anti-social IDs

2010-06-14 Thread Anthony Liguori
On 06/08/2010 06:54 AM, Markus Armbruster wrote: Restrict IDs to letters, digits, '-', '.', '_', starting with a letter. This takes care of '/' in qdev IDs breaking qbus_find(). Signed-off-by: Markus Armbruster Applied. Thanks. Regards, Anthony Liguori --- qemu-option.c | 20 +

Re: [Qemu-devel] [PATCH] migration: use qemu_free() instead of free().

2010-06-14 Thread Anthony Liguori
On 06/09/2010 12:44 AM, Yoshiaki Tamura wrote: Although there is no difference, other migration related code use qemu_free(), and it should be better to be consistent. Signed-off-by: Yoshiaki Tamura Applied. Thanks. Regards, Anthony Liguori --- migration.c |2 +- 1 files changed

Re: [Qemu-devel] [PATCH] Clarify error message when a PCI slot is already in use (v2)

2010-06-14 Thread Anthony Liguori
On 06/08/2010 09:24 AM, Daniel P. Berrange wrote: When mistakenly configuring two devices in the same PCI slot, QEMU gives a not entirely obvious message about a 'devfn' being in use: $ qemu -device rtl8139 -device virtio-balloon-pci,bus=pci.0,addr=0x3 qemu-kvm: -device virtio-balloon-pci,bus=pc

Re: [Qemu-devel] [PATCH] qdev: Revert the hack to let -net nic and pci_add set qdev ID

2010-06-14 Thread Anthony Liguori
On 06/08/2010 06:54 AM, Markus Armbruster wrote: Setting the ID in pci_nic_init() is a blatant violation of the DeviceState abstraction. Which even carries a comment advising against this: /* This structure should not be accessed directly. We declare it here so that it can be embedded in i

Re: [Qemu-devel] [PATCH] Add exit notifiers.

2010-06-14 Thread Anthony Liguori
On 06/04/2010 07:08 AM, Gerd Hoffmann wrote: Hook up any cleanup work which needs to be done here. Advantages over using atexit(3): (1) You get passed in a pointer to the notifier. If you embed that into your state struct you can use container_of() to get get your state info.

Re: [Qemu-devel] [PATCH] make qemu_thread_create block all signals

2010-06-14 Thread Anthony Liguori
On 06/03/2010 08:20 AM, Paolo Bonzini wrote: All signals will thus be routed through the IO thread. Signed-off-by: Paolo Bonzini Applied. Thanks. Regards, Anthony Liguori --- cpus.c| 38 +++--- qemu-thread.c |7 +++ 2 files changed

[Qemu-devel] Re: [PATCH v3] qemu: kvm: Enable XSAVE live migration support

2010-06-14 Thread Marcelo Tosatti
On Fri, Jun 11, 2010 at 12:36:49PM +0800, Sheng Yang wrote: > > Signed-off-by: Sheng Yang > --- > qemu-kvm-x86.c| 109 > - > qemu-kvm.c| 24 +++ > qemu-kvm.h| 28 + > target-i386/cpu.h |

[Qemu-devel] [PATCH-V7 04/10] virtio-9p: Security model for chown

2010-06-14 Thread Venkateswararao Jujjuri (JV)
mapped model changes the owner in the extended attributes. passthrough model does the change through lchown() as the server don't need to follow the link and client will send the actual filesystem object. Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h |2 +- hw/virtio-9p-loc

[Qemu-devel] [PATCH-V7 05/10] virtio-9p: Implemented Security model for lstat and fstat

2010-06-14 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p-local.c | 62 ++--- 1 files changed, 58 insertions(+), 4 deletions(-) diff --git a/hw/virtio-9p-local.c b/hw/virtio-9p-local.c index 1d7cb32..74c81a6 100644 --- a/hw/virtio-9p-local.c +++ b/hw/v

[Qemu-devel] [PATCH-V7 07/10] virtio-9p: Security model for mkdir

2010-06-14 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h |2 +- hw/virtio-9p-local.c | 35 +-- hw/virtio-9p.c | 12 +--- 3 files changed, 43 insertions(+), 6 deletions(-) diff --git a/hw/file-op-9p.h b/hw/file-op-9p.h index b345189..12

[Qemu-devel] [PATCH-V7 10/10] virtio-9p: Implement Security model for mksock using mknod.

2010-06-14 Thread Venkateswararao Jujjuri (JV)
This patch uses mknod to create socket. On Host/Fileserver: -rw---. 1 virfsuid virtfsgid 0 2010-05-11 09:57 asocket1 On Guest/Client: srwxr-xr-x 1 guestuser guestuser 0 2010-05-11 12:57 asocket1 Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h |1 - hw/virtio-9p-local.c

[Qemu-devel] [PATCH-V7 02/10] virtio-9p: Make infrastructure for the new security model.

2010-06-14 Thread Venkateswararao Jujjuri (JV)
This patch adds required infrastructure for the new security model. - A new configure option for attr/xattr. - if CONFIG_VIRTFS will be defined if both CONFIG_LINUX and CONFIG_ATTR defined. - Defines routines related to both security models. Signed-off-by: Venkateswararao Jujjuri --- Makefile.o

[Qemu-devel] [PATCH-V7 03/10] virtio-9p: Security model for chmod

2010-06-14 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h |2 +- hw/virtio-9p-local.c | 11 +++ hw/virtio-9p.c |5 - 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/file-op-9p.h b/hw/file-op-9p.h index 307bd1e..1c8d89b 100644 --- a/hw/file-op-9

[Qemu-devel] [PATCH-V7 08/10] virtio-9p: Security model for symlink and readlink

2010-06-14 Thread Venkateswararao Jujjuri (JV)
Mapped mode stores extended attributes in the user space of the extended attributes. Given that the user space extended attributes are available to regular files only, special files are created as regular files on the fileserver and appropriate mode bits are added to the extended attributes. This m

[Qemu-devel] [PATCH-V7 06/10] virtio-9p: Security model for create/open2

2010-06-14 Thread Venkateswararao Jujjuri (JV)
In the mapped security model, VirtFS server intercepts and maps the file object create and get/set attribute requests. Files on the fileserver will be created with VirtFS servers (QEMU) user credentials and the client-users credentials are stored in extended attributes. On the request to get attrib

[Qemu-devel] [PATCH-V7 01/10] virtio-9p: Introduces an option to specify the security model.

2010-06-14 Thread Venkateswararao Jujjuri (JV)
The new option is: -fsdev fstype,id=myid,path=/share_path/,security_model=[mapped|passthrough] -virtfs fstype,path=/share_path/,security_model=[mapped|passthrough],mnt_tag=tag In the case of mapped security model, files are created with QEMU user credentials and the client-user's credentials are

[Qemu-devel] PATCH-V7 0/10] virtio-9p:Introducing security model for VirtFS

2010-06-14 Thread Venkateswararao Jujjuri (JV)
This patch series introduces the security model for VirtFS. Brief description of this patch series: It introduces two type of security models for VirtFS. They are: mapped and passthrough. The following is common to both security models. * Client's VFS determines/enforces the access control. L

[Qemu-devel] [PATCH-V7 09/10] virtio-9p: Implement Security model for mknod

2010-06-14 Thread Venkateswararao Jujjuri (JV)
Mapped mode stores extended attributes in the user space of the extended attributes. Given that the user space extended attributes are available to regular files only, special files are created as regular files on the fileserver and appropriate mode bits are added to the extended attributes. This m

[Qemu-devel] [RESEND PATCH] acpi_piix4: save gpe and pci hotplug slot status

2010-06-14 Thread Alex Williamson
PCI hotplug currently doesn't work after a migration because we don't migrate the enable bits of the GPE state. Pull hotplug structs into vmstate. Signed-off-by: Alex Williamson --- hw/acpi_piix4.c | 29 - 1 files changed, 28 insertions(+), 1 deletions(-) diff --

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-14 Thread Kevin O'Connor
On Mon, Jun 14, 2010 at 09:56:15PM +0300, Gleb Natapov wrote: > On Mon, Jun 14, 2010 at 02:25:21PM -0400, Kevin O'Connor wrote: > > It seems there was a change in qemu to the hpet functionality. > My patch is completely unrelated to functionality change in qemu. In > fact I wrote it before the chan

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-14 Thread Glauber Costa
On Mon, Jun 14, 2010 at 02:58:47PM -0500, Anthony Liguori wrote: > On 06/14/2010 02:42 PM, Glauber Costa wrote: > >On Mon, Jun 14, 2010 at 02:33:00PM -0500, Anthony Liguori wrote: > >>On 06/14/2010 02:27 PM, Glauber Costa wrote: > >>>This patch fixes a bug that happens with kvm, irqchip-in-kernel,

Re: [Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-14 Thread Anthony Liguori
On 06/14/2010 02:54 PM, Juan Quintela wrote: Anthony Liguori wrote: On 06/14/2010 01:35 PM, Juan Quintela wrote: Ok. lets stop here. My definitions: Event: this important thing happened (important has several meanings). Migration events fully enter in this definition. Further

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-14 Thread Anthony Liguori
On 06/14/2010 02:42 PM, Glauber Costa wrote: On Mon, Jun 14, 2010 at 02:33:00PM -0500, Anthony Liguori wrote: On 06/14/2010 02:27 PM, Glauber Costa wrote: This patch fixes a bug that happens with kvm, irqchip-in-kernel, while adding a netdev. Despite the situations of reproduction bei

[Qemu-devel] Re: [RFC PATCH 0/5] Introduce canonical device hierarchy string

2010-06-14 Thread Alex Williamson
On Mon, 2010-06-14 at 09:02 +0200, Gerd Hoffmann wrote: > Hi, > > > My premise with this attempt is that we walk the hierarchy and use the > > names to create the base of the path. As we get to the device, > > particularly to the parent bus of the device, we need to start looking at > > propertie

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-14 Thread Juan Quintela
Anthony Liguori wrote: > On 06/14/2010 01:35 PM, Juan Quintela wrote: >> Ok. lets stop here. My definitions: >> >> Event: this important thing happened (important has several meanings). >> >> Migration events fully enter in this definition. Furthermore, migration >> events happens from actions

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-14 Thread Glauber Costa
On Mon, Jun 14, 2010 at 02:33:00PM -0500, Anthony Liguori wrote: > On 06/14/2010 02:27 PM, Glauber Costa wrote: > >This patch fixes a bug that happens with kvm, irqchip-in-kernel, > >while adding a netdev. Despite the situations of reproduction being > >specific to kvm, I believe this fix is pretty

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-14 Thread Anthony Liguori
On 06/14/2010 01:25 PM, Kevin O'Connor wrote: On Mon, Jun 14, 2010 at 05:51:27PM +0300, Avi Kivity wrote: On 06/14/2010 05:09 PM, Gleb Natapov wrote: Could we just have qemu build the hpet tables and pass them through to seabios? Perhaps using the qemu_cfg_acpi_additional_tables() me

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-14 Thread Anthony Liguori
On 06/14/2010 02:27 PM, Glauber Costa wrote: This patch fixes a bug that happens with kvm, irqchip-in-kernel, while adding a netdev. Despite the situations of reproduction being specific to kvm, I believe this fix is pretty generic, and fits here. Specially if we ever want to have our own irqchip

Re: [Qemu-devel] Fwd: [PATCH 1/4] Make configure find uuid functions in Mac OS X by looking into libSystem.B

2010-06-14 Thread Anthony Liguori
On 06/03/2010 04:05 PM, C.W. Betts wrote: Since this didn't seem to get to the mailing list, I'm forwarding it. It's lacking a Signed-off-by and as a quoted message, it's not possible to apply it. Regards, Anthony Liguori Begin forwarded message: *From: *"C.W. Betts"

[Qemu-devel] [PATCH] stop cpus before forking.

2010-06-14 Thread Glauber Costa
This patch fixes a bug that happens with kvm, irqchip-in-kernel, while adding a netdev. Despite the situations of reproduction being specific to kvm, I believe this fix is pretty generic, and fits here. Specially if we ever want to have our own irqchip in kernel too. The problem happens after the

Re: [Qemu-devel] [PATCH] Add optional dump of default config file paths..

2010-06-14 Thread Anthony Liguori
On 06/14/2010 12:59 PM, john cooper wrote: Anthony Liguori wrote: On 06/09/2010 03:05 AM, john cooper wrote: This patch adds the ability to determine the build-configured runtime "config file" paths from the command line. After support for cpu model definitions were added to the defa

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-14 Thread Anthony Liguori
On 06/14/2010 01:35 PM, Juan Quintela wrote: Anthony Liguori wrote: On 06/14/2010 11:02 AM, Juan Quintela wrote: Anthony Liguori wrote: On 06/12/2010 06:05 AM, Juan Quintela wrote: Luiz Capitulinowrote: The monitor that did it knows

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-14 Thread Gleb Natapov
On Mon, Jun 14, 2010 at 02:25:21PM -0400, Kevin O'Connor wrote: > On Mon, Jun 14, 2010 at 05:51:27PM +0300, Avi Kivity wrote: > > On 06/14/2010 05:09 PM, Gleb Natapov wrote: > > >>Could we just have qemu build the hpet tables and pass them through to > > >>seabios? Perhaps using the qemu_cfg_acpi_

[Qemu-devel] [PATCH] block: fix a warning and possible truncation

2010-06-14 Thread Blue Swirl
Fix a warning from OpenBSD gcc (3.3.5 (propolice)): /src/qemu/block.c: In function `bdrv_info_stats_bs': /src/qemu/block.c:1548: warning: long long int format, long unsigned int arg (arg 6) There may be also truncation effects. Signed-off-by: Blue Swirl --- Alternatively 'ULL' prefix could be ap

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-14 Thread Alex Williamson
On Mon, 2010-06-14 at 18:49 +0200, Jan Kiszka wrote: > Alex Williamson wrote: > > On Mon, 2010-06-14 at 18:00 +0200, Jan Kiszka wrote: > >> And instead of introducing another hierarchy level with the bus address, > >> I would also prefer to add this as prefix or suffix to the device name, > >> e.g

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-14 Thread Juan Quintela
Anthony Liguori wrote: > On 06/14/2010 11:02 AM, Juan Quintela wrote: >> Anthony Liguori wrote: >> >>> On 06/12/2010 06:05 AM, Juan Quintela wrote: >>> Luiz Capitulino wrote: >> The monitor that did it knows it, nobody else knows it. At destination tim

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-14 Thread Kevin O'Connor
On Mon, Jun 14, 2010 at 05:51:27PM +0300, Avi Kivity wrote: > On 06/14/2010 05:09 PM, Gleb Natapov wrote: > >>Could we just have qemu build the hpet tables and pass them through to > >>seabios? Perhaps using the qemu_cfg_acpi_additional_tables() method. > >> > >Possible, and I considered that. I p

Re: [Qemu-devel] [PATCH] Add optional dump of default config file paths..

2010-06-14 Thread john cooper
Anthony Liguori wrote: > On 06/09/2010 03:05 AM, john cooper wrote: >> This patch adds the ability to determine the build-configured >> runtime "config file" paths from the command line. After >> support for cpu model definitions were added to the default >> runtime "target-" config file, testing

Re: [Qemu-devel] [PATCH 5/5] [scsi-bsg]: Add initial support for BSG based SCSIDeviceInfo

2010-06-14 Thread Blue Swirl
On Mon, Jun 14, 2010 at 9:44 AM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch adds initial support for using the Linux BSG interface with > write/read vectored > AIO as a QEMU backstore (SCSIDeviceInfo) with hw/scsi-bus.c compatible HBA > emulation. Did I miss the doc

Re: [Qemu-devel] [PATCH v2 7/7] apic: qdev conversion cleanup

2010-06-14 Thread Blue Swirl
On Mon, Jun 14, 2010 at 9:36 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> Make APICState completely private to apic.c by using DeviceState >> in external APIs. > > Could you explain why this is an improvement? Outside of apic.c, there is no need to access APICState fields so we can rem

Re: [Qemu-devel] [PATCH 15/35] tcg-s390: Query instruction extensions that are installed.

2010-06-14 Thread Alexander Graf
Am 14.06.2010 um 18:20 schrieb Richard Henderson : On 06/13/2010 03:23 PM, Alexander Graf wrote: On 13.06.2010, at 18:44, Aurelien Jarno wrote: Is KVM in 31-bit mode actually functional? I'm not aware of anything preventing it to be. But I honestly haven't tried. As long as all hypercall pa

Re: [Qemu-devel] [PATCH v2 2/7] ioapic: convert to qdev

2010-06-14 Thread Blue Swirl
On Mon, Jun 14, 2010 at 9:33 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> Convert to qdev. >> >> Signed-off-by: Blue Swirl >> --- >>  hw/apic.h    |    2 -- >>  hw/ioapic.c  |   45 ++--- >>  hw/pc.h      |    4 +++- >>  hw/pc_piix.c |   19 ++

Re: [Qemu-devel] Re: [PATCH] lsi53c895a: fix Phase Mismatch Jump

2010-06-14 Thread Michal Novotny
On 06/14/2010 07:31 PM, Jan Kiszka wrote: Michal Novotny wrote: On 06/14/2010 07:05 PM, Jan Kiszka wrote: Paolo Bonzini wrote: lsi_bad_phase has a bug in the choice of pmjad1/pmjad2. This does not matter with Linux guests because it uses just one routine for both, but it br

Re: [Qemu-devel] Re: [PATCH] lsi53c895a: fix Phase Mismatch Jump

2010-06-14 Thread Michal Novotny
On 06/14/2010 07:05 PM, Jan Kiszka wrote: Paolo Bonzini wrote: lsi_bad_phase has a bug in the choice of pmjad1/pmjad2. This does not matter with Linux guests because it uses just one routine for both, but it breaks Windows 64-bit guests. This is the text from the spec: "[The PMJCTL] b

Re: [Qemu-devel] Re: [PATCH] lsi53c895a: fix Phase Mismatch Jump

2010-06-14 Thread Jan Kiszka
Michal Novotny wrote: > On 06/14/2010 07:05 PM, Jan Kiszka wrote: >> Paolo Bonzini wrote: >> >>> lsi_bad_phase has a bug in the choice of pmjad1/pmjad2. This does >>> not matter with Linux guests because it uses just one routine for >>> both, but it breaks Windows 64-bit guests. This is the t

[Qemu-devel] [PATCH v2] lsi53c895a: fix Phase Mismatch Jump

2010-06-14 Thread Paolo Bonzini
lsi_bad_phase has a bug in the choice of pmjad1/pmjad2. This does not matter with Linux guests because it uses just one routine for both, but it breaks Windows 64-bit guests. This is the text from the spec: "[The PMJCTL] bit controls which decision mechanism is used when jumping on phase m

Re: [Qemu-devel] Re: [PATCH] lsi53c895a: fix Phase Mismatch Jump

2010-06-14 Thread Michal Novotny
On 06/14/2010 07:05 PM, Jan Kiszka wrote: Paolo Bonzini wrote: lsi_bad_phase has a bug in the choice of pmjad1/pmjad2. This does not matter with Linux guests because it uses just one routine for both, but it breaks Windows 64-bit guests. This is the text from the spec: "[The PMJCTL] b

Re: [Qemu-devel] [PATCH] Fix and simplify gui timer logic.

2010-06-14 Thread Anthony Liguori
On 06/08/2010 08:18 AM, Gerd Hoffmann wrote: On 06/08/10 13:50, Paul Brook wrote: Kill nographic timer. Have a global gui_timer instead. Have the gui timer enabled unconditionally. We need a timer running anyway for mmio flush, so the whole have-gui-timer-only-when-needed logic is pretty po

Re: [Qemu-devel] [PATCH] Add optional dump of default config file paths..

2010-06-14 Thread Daniel P. Berrange
On Mon, Jun 14, 2010 at 12:01:42PM -0500, Anthony Liguori wrote: > On 06/09/2010 03:05 AM, john cooper wrote: > >This patch adds the ability to determine the build-configured > >runtime "config file" paths from the command line. After > >support for cpu model definitions were added to the default

[Qemu-devel] Re: [PATCH] lsi53c895a: fix Phase Mismatch Jump

2010-06-14 Thread Jan Kiszka
Paolo Bonzini wrote: > lsi_bad_phase has a bug in the choice of pmjad1/pmjad2. This does > not matter with Linux guests because it uses just one routine for > both, but it breaks Windows 64-bit guests. This is the text > from the spec: > >"[The PMJCTL] bit controls which decision mechanism i

Re: [Qemu-devel] [PATCH] Add optional dump of default config file paths..

2010-06-14 Thread Anthony Liguori
On 06/09/2010 03:05 AM, john cooper wrote: This patch adds the ability to determine the build-configured runtime "config file" paths from the command line. After support for cpu model definitions were added to the default runtime "target-" config file, testing of this feature has tripped over an

Re: [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command

2010-06-14 Thread Anthony Liguori
On 06/09/2010 09:27 AM, Gerd Hoffmann wrote: Hi, This make sense when you mistakenly add a pci device on a -s -S scenario, like the scenario described on the following bug: https://bugs.launchpad.net/qemu/+bug/544367. It doesn't IMHO. When ACPI-based hotplug support is present on the gues

Re: [Qemu-devel] [PATCH 0/5] Add '-device help' output for device params and help text

2010-06-14 Thread Anthony Liguori
On 06/08/2010 12:21 AM, Amit Shah wrote: On (Mon) Jun 07 2010 [11:09:32], Anthony Liguori wrote: On 05/31/2010 07:41 AM, Amit Shah wrote: Hello, This patch series adds support to specify some descriptive help text to qdev device parameters. This series adds some help text to the virt

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-14 Thread Jan Kiszka
Alex Williamson wrote: > On Mon, 2010-06-14 at 18:00 +0200, Jan Kiszka wrote: >> Alex Williamson wrote: >>> On Mon, 2010-06-14 at 14:09 +0100, Paul Brook wrote: >>> "/main-system-bus/pci.0,addr=09.0/virtio-blk-pci" There's a device missing between the main system bus and the pci bus. >>>

[Qemu-devel] [PATCH] lsi53c895a: fix Phase Mismatch Jump

2010-06-14 Thread Paolo Bonzini
lsi_bad_phase has a bug in the choice of pmjad1/pmjad2. This does not matter with Linux guests because it uses just one routine for both, but it breaks Windows 64-bit guests. This is the text from the spec: "[The PMJCTL] bit controls which decision mechanism is used when jumping on phase m

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-14 Thread Alex Williamson
On Mon, 2010-06-14 at 18:00 +0200, Jan Kiszka wrote: > Alex Williamson wrote: > > On Mon, 2010-06-14 at 14:09 +0100, Paul Brook wrote: > > "/main-system-bus/pci.0,addr=09.0/virtio-blk-pci" > >> There's a device missing between the main system bus and the pci bus. > >> Should > >> be somethin

Re: [Qemu-devel] [PATCH v2] add pflib: PixelFormat conversion library.

2010-06-14 Thread Anthony Liguori
On 06/14/2010 10:46 AM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- Makefile.objs |1 + pflib.c | 213 + pflib.h |6 ++ 3 files changed, 220 insertions(+), 0 deletions(-) create mode 100644 pflib.c cre

Re: [Qemu-devel] [PATCHv2] pass info about hpets to seabios.]

2010-06-14 Thread Anthony Liguori
On 06/14/2010 03:29 AM, Gleb Natapov wrote: Currently HPET ACPI table is created regardless of whether qemu actually created hpet device. This may confuse some guests that don't check that hpet is functional before using it. Solve this by passing info about hpets in qemu to seabios via fw config

Re: [Qemu-devel] [PATCH 1/2] Remove unused DEBUG defines from hw/msix.c

2010-06-14 Thread Anthony Liguori
On 06/14/2010 10:05 AM, jes.soren...@redhat.com wrote: From: Jes Sorensen Remove unused DEBUG defines from hw/msix.c to avoid having anything define the word DEBUG without any additions such as MSIX_DEBUG. Signed-off-by: Jes Sorensen Applied. Thanks. Regards, Anthony Liguori --- hw

Re: [Qemu-devel] [PATCH] hpet: Init capability register only once

2010-06-14 Thread Anthony Liguori
On 06/14/2010 01:40 AM, Jan Kiszka wrote: From: Jan Kiszka The capability register is read-only from guest POV, so we do not need to update it on reset. Signed-off-by: Jan Kiszka Applied. Thanks. Regards, Anthony Liguori --- hw/hpet.c |9 + 1 files changed, 5 insertions

Re: [Qemu-devel] [PATCH v2] ram_blocks: Convert to a QLIST

2010-06-14 Thread Anthony Liguori
On 06/11/2010 12:11 PM, Alex Williamson wrote: This makes the RAM block list easier to manipulate. Also incorporate relevant variables into the RAMList struct. Signed-off-by: Alex Williamson Acked-by: Chris Wright Applied. Thanks. Regards, Anthony Liguori --- v2: For qemu.git this ti

Re: [Qemu-devel] [PATCH] Make netdev_del delete the netdev even when it's in use

2010-06-14 Thread Anthony Liguori
On 06/11/2010 07:21 AM, Markus Armbruster wrote: To hot-unplug guest and host part of a network device, you do: device_del NIC-ID netdev_del NETDEV-ID For PCI devices, device_del merely tells ACPI to unplug the device. The device goes away for real only after the guest processed the A

Re: [Qemu-devel] [PATCH] qemu-option: Fix uninitialized value in append_option_parameter

2010-06-14 Thread Anthony Liguori
On 06/11/2010 03:19 AM, Kevin Wolf wrote: When dest is NULL, i.e. a new copy of the list is created, we don't get a properly terminated list after the realloc. Initialize it as an empty list. Signed-off-by: Kevin Wolf Applied. Thanks. Regards, Anthony Liguori --- Xudong, can you plea

  1   2   >