Re: [Qemu-devel] [RFC/ PATCH 2/2] qemu: Convert paio code to use the generic threading infrastructure.

2010-05-12 Thread Venkateswararao Jujjuri (JV)
Gautham R Shenoy wrote: > This patch makes the paio subsystem use the generic work offloading > infrastructure. > > The patch has been tested with fstress. > > Signed-off-by: Gautham R Shenoy Gauthem, surprisingly this makes the code really readable. Few comments below. > --- > posix-aio-co

Re: [Qemu-devel] [RFC PATCH 1/2] close all the block drivers before the qemu process exits

2010-05-12 Thread MORITA Kazutaka
On 2010/05/12 23:01, Christoph Hellwig wrote: > On Wed, May 12, 2010 at 07:46:52PM +0900, MORITA Kazutaka wrote: >> This patch calls the close handler of the block driver before the qemu >> process exits. >> >> This is necessary because the sheepdog block driver releases the lock >> of VM images in

Re: [Qemu-devel] [RFC PATCH 0/2] Sheepdog: distributed storage system for QEMU

2010-05-12 Thread MORITA Kazutaka
On 2010/05/12 20:38, Kevin Wolf wrote: > Am 12.05.2010 12:46, schrieb MORITA Kazutaka: >> Hi all, >> >> This patch adds a block driver for Sheepdog distributed storage >> system. Please consider for inclusion. >> >> Sheepdog is a distributed storage system for QEMU. It provides highly >> availabl

[Qemu-devel] [PATCH 4/4] PPC: use device info for CPU statistics

2010-05-12 Thread Blue Swirl
Signed-off-by: Blue Swirl --- cpu-all.h |3 --- monitor.c | 19 --- qemu-monitor.hx|2 -- target-ppc/cpu.h |2 ++ target-ppc/helper.c|4 target-ppc/translate.c | 45 ++---

[Qemu-devel] Re: [RFC PATCH 1/2] close all the block drivers before the qemu process exits

2010-05-12 Thread MORITA Kazutaka
On 2010/05/12 23:28, Avi Kivity wrote: > On 05/12/2010 01:46 PM, MORITA Kazutaka wrote: >> This patch calls the close handler of the block driver before the qemu >> process exits. >> >> This is necessary because the sheepdog block driver releases the lock >> of VM images in the close handler. >> >>

[Qemu-devel] [PATCH 1/2] Add no-op aio emulation stub

2010-05-12 Thread Alexander Graf
We need to be able to do nothing in AIO fashion. Since I suspect this could be useful for more cases than the non flushing, I figured I'd create a new function that does everything AIO-like, but doesn't do anything. Signed-off-by: Alexander Graf --- v1 -> v2: - remove stray define - make a

[Qemu-devel] [PATCH resend 3/6] MIPS: Initial support of VIA IDE controller used by fulong mini pc

2010-05-12 Thread Huacai Chen
resend by git send-email to avoid line-wrapping Signed-off-by: Huacai Chen --- Makefile.objs|1 + default-configs/mips64el-softmmu.mak |1 + hw/ide.h |1 + hw/ide/via.c | 185

[Qemu-devel] [PATCH 04/12] standardize on qemu_cpu_kick for signalling cpu thread(s)

2010-05-12 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti Signed-off-by: Avi Kivity --- cpus.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/cpus.c b/cpus.c index 53226b3..5afdb4a 100644 --- a/cpus.c +++ b/cpus.c @@ -454,8 +454,7 @@ void qemu_cpu_kick(void *_env) { CPUState *env = _e

[Qemu-devel] [PATCH, RFC 0/4] monitor device info infrastructure

2010-05-12 Thread Blue Swirl
Hi all, I finally refreshed some of my monitor patches. PCI and HPET patches (attached, they don't apply anymore) need more work because of the new monitor design. The patches provide a method for devices to register new monitor commands. This fixes some design problems, like useless pic_info/irq

[Qemu-devel] [PATCH] Fix tarbin Makefile rule

2010-05-12 Thread Stuart Brady
The 'tarbin' Makefile rule doesn't include qemu-system-sparc64, but should do, now that sparc64-softmmu is in the default target list. The rule attempts to tar up binaries that were not built if a target list was passed to the configure script -- in which case, it will either fail, or otherwise in

[Qemu-devel] [PATCH 2/6] vmstate: Drop unused post_save handler

2010-05-12 Thread Jan Kiszka
From: Jan Kiszka No device makes use of it anymore. Signed-off-by: Jan Kiszka --- hw/hw.h |1 - savevm.c |3 --- 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 328b704..2d39724 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -321,7 +321,6 @@ struct VMStat

[Qemu-devel] [PULL] virtio, pci fixes

2010-05-12 Thread Michael S. Tsirkin
The following changes since commit 54d7cf136f040713095cbc064f62d753bff6f9d2: doc: Clean up monitor command function index (2010-05-10 11:36:04 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_anthony Alex Williamson (1): pci:

[Qemu-devel] [PATCH 10/12] kvm: enable smp > 1

2010-05-12 Thread Marcelo Tosatti
Process INIT/SIPI requests and enable -smp > 1. Signed-off-by: Marcelo Tosatti Signed-off-by: Avi Kivity --- kvm-all.c | 10 +- kvm.h |2 ++ target-i386/kvm.c | 16 target-ppc/kvm.c |5 + target-s390x/kvm.c |5 + 5 files

[Qemu-devel] [PATCH 0/6] vmstate: Drop post_save / allow instance ID aliases

2010-05-12 Thread Jan Kiszka
This series comes with two major contributions: - after moving away the last user of post_save (tmp105), this vmstate callback is dropped - introduction of an instance ID alias to vmstate, allowing to drop a few more explicit vmstate_register calls Jan Kiszka (6): tmp105: Drop unused fau

[Qemu-devel] Re: [PATCH 0/6] vmstate: Drop post_save / allow instance ID aliases

2010-05-12 Thread Juan Quintela
Jan Kiszka wrote: > This series comes with two major contributions: > - after moving away the last user of post_save (tmp105), this vmstate >callback is dropped > - introduction of an instance ID alias to vmstate, allowing to drop a few >more explicit vmstate_register calls Reviewed-by:

[Qemu-devel] [PATCH 11/12] Do not stop VM if emulation failed in userspace.

2010-05-12 Thread Marcelo Tosatti
From: Gleb Natapov Continue vcpu execution in case emulation failure happened while vcpu was in userspace. In this case #UD will be injected into the guest allowing guest OS to kill offending process and continue. Signed-off-by: Gleb Natapov Signed-off-by: Marcelo Tosatti --- kvm-all.c

[Qemu-devel] [PATCH 6/6] mc146818rtc: Register vmstate via qdev

2010-05-12 Thread Jan Kiszka
From: Jan Kiszka After defining the required alias ID, we can push vmstate registration of mc146818rtc to qdev. Signed-off-by: Jan Kiszka --- hw/mc146818rtc.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index 89a423e..16b033a 1

[Qemu-devel] [PATCH 2/4] qdev: automatically register device info

2010-05-12 Thread Blue Swirl
Signed-off-by: Blue Swirl --- hw/qdev.c |3 +++ hw/qdev.h |3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index d3bf0fa..258bbef 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -280,6 +280,9 @@ int qdev_init(DeviceState *dev) qemu_register_reset

[Qemu-devel] [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-12 Thread Cole Robinson
Commit f75ca1ae205f24dae296c82d534c37746f87232f changed the version string from: QEMU PC Emulator version x.yy.z to QEMU Emulator version x.yy.z libvirt is overly sensitive to the format of this string, and barfs when trying to parse qemu -help output. While libvirt should certainly be more rob

[Qemu-devel] [PATCH 1/4] monitor: add device info infrastructure

2010-05-12 Thread Blue Swirl
Signed-off-by: Blue Swirl --- monitor.c | 41 + monitor.h | 10 ++ qemu-monitor.hx | 13 + 3 files changed, 64 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index a1ebc5d..9bb1a30 100644 --- a/monito

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-12 Thread Luiz Capitulino
On Wed, 12 May 2010 18:48:38 +0200 Markus Armbruster wrote: > > +query-block > > +--- > > + > > +Show the block devices. > > + > > +Each block device information is stored in a json-object and the returned > > value > > +is a json-array of all devices. > > + > > +Each json-object contain

[Qemu-devel] [PATCH 3/6] vmstate: Add support for alias ID

2010-05-12 Thread Jan Kiszka
From: Jan Kiszka Some legacy users (mostly PC devices) of vmstate_register manage instance IDs on their own, and that unfortunately in a way that is incompatible with automatically generated ones. This so far prevents switching those users to vmstates that are registered by qdev. To establish a

[Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-12 Thread Cole Robinson
On 05/12/2010 04:38 PM, Jes Sorensen wrote: > On 05/12/10 22:29, Cole Robinson wrote: >> Commit f75ca1ae205f24dae296c82d534c37746f87232f changed the version >> string from: >> >> QEMU PC Emulator version x.yy.z >> >> to >> >> QEMU Emulator version x.yy.z >> >> libvirt is overly sensitive to the for

[Qemu-devel] [PATCH 4/6] serial: Register vmstate via qdev

2010-05-12 Thread Jan Kiszka
From: Jan Kiszka At least for isa-serial, we can already let qdev do the vmstate registration for us. It just takes wrapping vmstate for the encapsulating ISASerialState and defining the proper instance ID aliases. Signed-off-by: Jan Kiszka --- hw/serial.c | 13 - 1 files changed

[Qemu-devel] [PATCH 3/4] x86/Sparc32: use device info for pic and irq

2010-05-12 Thread Blue Swirl
Signed-off-by: Blue Swirl --- hw/an5206.c |9 hw/arm_pic.c| 10 - hw/cris_pic_cpu.c |5 hw/i8259.c | 50 ++ hw/microblaze_pic_cpu.c |5 hw/pc.h |2

[Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-12 Thread Jes Sorensen
On 05/12/10 22:29, Cole Robinson wrote: > Commit f75ca1ae205f24dae296c82d534c37746f87232f changed the version > string from: > > QEMU PC Emulator version x.yy.z > > to > > QEMU Emulator version x.yy.z > > libvirt is overly sensitive to the format of this string, and barfs when > trying to parse

[Qemu-devel] Re: [PATCH] target-i386: Avoid kvm related compiler error

2010-05-12 Thread Jan Kiszka
Stefan Weil wrote: > Some versions of kvm.h (debian lenny) define KVM_CAP_VCPU_EVENTS > without defining KVM_VCPUEVENT_VALID_NMI_PENDING or > KVM_VCPUEVENT_VALID_SIPI_VECTOR. This rather looks like a bug to be sent to debian. Until they fixed their backport (I just hope it's a user space header is

[Qemu-devel] [PATCH 00/12] [PULL] qemu-kvm.git uq/master queue

2010-05-12 Thread Marcelo Tosatti
The following changes since commit 54d7cf136f040713095cbc064f62d753bff6f9d2: Markus Armbruster (1): doc: Clean up monitor command function index are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Gleb Natapov (2): Do not stop VM

[Qemu-devel] [PATCH 06/12] kvm: synchronize state from cpu context

2010-05-12 Thread Marcelo Tosatti
From: Jan Kiszka It is not safe to retrieve the KVM internal state of a given cpu while its potentially modifying it. Queue the request to run on cpu context, similarly to qemu-kvm. Signed-off-by: Marcelo Tosatti Signed-off-by: Avi Kivity --- kvm-all.c | 10 +- 1 files changed, 9 i

[Qemu-devel] [PATCH 09/12] kvm: validate context for kvm cpu get/put operations

2010-05-12 Thread Marcelo Tosatti
From: Jan Kiszka Validate that KVM vcpu state is only read/written from cpu thread itself or that cpu is stopped. Signed-off-by: Marcelo Tosatti Signed-off-by: Avi Kivity --- target-i386/kvm.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/target-i386/kvm.c b/targ

[Qemu-devel] Re: Commit 9c9bb6c89d4 breaks code execution from flash

2010-05-12 Thread Michael Walle
Am Wednesday 12 May 2010 09:56:31 schrieb Jan Kiszka: > OK, that was a hard nut. After various dead ends, I think I found an > possible solution. Can you give this a try? [..] > Still requires proper patch split up, and I need to think about possible > side effects. Thanks, the patch is working. B

[Qemu-devel] [PATCH 5/6] fdc: Register vmstate via qdev

2010-05-12 Thread Jan Kiszka
From: Jan Kiszka Establish vmstate containers for ISA and sysbus variant, define the iobase as instance ID alias, and let qdev do the vmstate registration work. Signed-off-by: Jan Kiszka --- hw/fdc.c | 35 ++- 1 files changed, 30 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH 12/12] kvm: fix 80000001.EDX supported bit filtering

2010-05-12 Thread Marcelo Tosatti
From: Gleb Natapov On AMD some bits from 1.EDX are reported in 8001.EDX. The mask used to copy bits from 1.EDX to 8001.EDX is incorrect resulting in unsupported features passed into a guest. Signed-off-by: Gleb Natapov Signed-off-by: Marcelo Tosatti --- target-i386/kvm.c |2 +- 1

[Qemu-devel] [PATCH 03/12] make SIG_IPI to tcg vcpu thread reliable

2010-05-12 Thread Marcelo Tosatti
Store tcg loop exit request on a global variable, and transfer it to per-CPUState exit_request after assignment of cpu_single_env. This makes exit request signal from robust. Drop the timedlock hack. Signed-off-by: Marcelo Tosatti Signed-off-by: Avi Kivity --- cpu-exec.c |7 +++ cpus.c

[Qemu-devel] [PATCH 07/12] add cpu_is_stopped helper

2010-05-12 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti Signed-off-by: Avi Kivity --- cpu-all.h |1 + cpus.c|5 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/cpu-all.h b/cpu-all.h index 9efb8a9..47a5722 100644 --- a/cpu-all.h +++ b/cpu-all.h @@ -821,6 +821,7 @@ void cpu_watchpoint_remo

[Qemu-devel] [PATCH 1/6] tmp105: Drop unused faults field

2010-05-12 Thread Jan Kiszka
From: Jan Kiszka It was only written, but never read. Signed-off-by: Jan Kiszka CC: Andrzej Zaborowski --- hw/tmp105.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/hw/tmp105.c b/hw/tmp105.c index 8343aff..cac5f2b 100644 --- a/hw/tmp105.c +++ b/hw/tmp105.c

[Qemu-devel] [PATCH 01/12] Fix -mem-path with hugetlbfs

2010-05-12 Thread Marcelo Tosatti
Fallback to qemu_vmalloc in case file_ram_alloc fails. Signed-off-by: Marcelo Tosatti Signed-off-by: Avi Kivity --- exec.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index 3416aed..56b5561 100644 --- a/exec.c +++ b/exec.c @@ -2775,8 +2775,12

[Qemu-devel] [PATCH 08/12] move stop/stopped CPU_COMMON fields after area zeroed by reset

2010-05-12 Thread Marcelo Tosatti
cpu_reset zeroes CPUState upto breakpoints member. Contents of stop/stopped should not be zeroed on cpu_reset. Signed-off-by: Marcelo Tosatti Signed-off-by: Avi Kivity --- cpu-defs.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cpu-defs.h b/cpu-defs.h index c764d6

[Qemu-devel] [PATCH] Fix qtypes' licenses

2010-05-12 Thread Luiz Capitulino
- Change from GPL to LGPL - Add license text when missing - Minor cosmetic changes to make all headers look the same Signed-off-by: Luiz Capitulino --- check-qdict.c |3 +++ check-qfloat.c |5 - check-qint.c|3 +++ check-qlist.c |4 ++-- check-qstring.c |3 +++ q

[Qemu-devel] Re: [PATCH][RESEND] vmstate: fix breakage by 7e72abc382b700a72549e8147bdea413534eeedc

2010-05-12 Thread Juan Quintela
TeLeMan wrote: > cirrus_post_load() will be executed twice when loading vm states and then the > wrong physical memory will be registered. This issue may lead to crash qemu. > > Signed-off-by: TeLeMan Nice catch. Acked-by: Juan Quintela

[Qemu-devel] [PATCH 05/12] port qemu-kvm's on_vcpu code

2010-05-12 Thread Marcelo Tosatti
run_on_cpu allows to execute work on a given CPUState context. Signed-off-by: Marcelo Tosatti Signed-off-by: Avi Kivity --- cpu-all.h |1 + cpu-defs.h|2 ++ cpus.c| 53 + qemu-common.h |8 4 files changed

Re: [Qemu-devel] [PATCH] [S390] Remove warning in tcg stub (tcg_out_reloc)

2010-05-12 Thread Alexander Graf
On 12.05.2010, at 19:28, Aurelien Jarno wrote: > On Tue, May 11, 2010 at 09:50:34PM +0200, Alexander Graf wrote: >> >> Am 11.05.2010 um 19:26 schrieb Richard Henderson : >> >>> On 05/11/2010 09:47 AM, Stefan Weil wrote: Won't you get another warning about unreachable code because tcg_

[Qemu-devel] [PATCH 2/2] Add cache=volatile parameter to -drive

2010-05-12 Thread Alexander Graf
Usually the guest can tell the host to flush data to disk. In some cases we don't want to flush though, but try to keep everything in cache. So let's add a new cache value to -drive that allows us to set the cache policy to most aggressive, disabling flushes. We call this mode "volatile", as guest

[Qemu-devel] [PATCH 02/12] kvm: set cpu_single_env around KVM_RUN ioctl

2010-05-12 Thread Marcelo Tosatti
Zero cpu_single_env before leaving global lock protection, and restore on return. Signed-off-by: Marcelo Tosatti Signed-off-by: Avi Kivity --- kvm-all.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 6962b2b..fbd084c 100644 --- a/kvm-all.c

[Qemu-devel] [PATCH resend 1/6] MIPS: Initial support of bonito north bridge used by fulong mini pc

2010-05-12 Thread Huacai Chen
resend by git send-email to avoid line-wrapping Signed-off-by: Huacai Chen --- Makefile.target |1 + default-configs/mips64el-softmmu.mak |1 + hw/bonito.c | 950 ++ hw/mips.h|3

[Qemu-devel] Re: S390 TCG target

2010-05-12 Thread Richard Henderson
Reference: http://lists.gnu.org/archive/html/qemu-devel/2009-12/msg01954.html > static const int tcg_target_call_iarg_regs[] = { > +TCG_REG_R2, > +TCG_REG_R3, > +TCG_REG_R4, > +TCG_REG_R5, > }; R6 is also an argument register. > +static void tcg_out_e3(TCGContext* s, int op, in

[Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush v2

2010-05-12 Thread Alexander Graf
Thanks to recent improvements, qemu flushes guest data to disk when the guest tells us to do so. This is great if we care about data consistency on host disk failures. In cases where we don't it just creates additional overhead for no net win. One such use case is the building of appliances in SUS

Re: [Qemu-devel] [PATCH] linux-user: rlimit conversion between host and target.

2010-05-12 Thread Richard Henderson
On 04/11/2010 12:07 PM, takas...@ops.dti.ne.jp wrote: > rlim_t conversion between host and target added. > Otherwise there are some incorrect case like > - RLIM_INFINITY on 32bit target -> 64bit host. > - RLIM_INFINITY on 64bit host -> mips and sparc target ? > - Big value(for 32bit target) on 64b

[Qemu-devel] [PATCH resend 4/6] MIPS: Initial support of VIA USB controller used by fulong mini pc

2010-05-12 Thread Huacai Chen
resend by git send-email to avoid line-wrapping Signed-off-by: Huacai Chen --- hw/usb-uhci.c | 30 ++ hw/usb-uhci.h |1 + 2 files changed, 31 insertions(+), 0 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index 624d55b..5fd5388 100644 --- a/hw/usb-uhc

Re: [Qemu-devel] [RFC] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2010-05-12 Thread Jun Koi
On Tue, Sep 29, 2009 at 1:50 AM, Stefan Weil wrote: > Hello > > The patch following this mail adds a new code generator > to qemu. It includes a README file with more details. > > Comments and contributions to complete it are welcome. Could you compare the performance of TCG and TCI? I suppose th

[Qemu-devel] [PATCH resend 5/6] MIPS: Initial support of fulong mini pc (CPU definition, machine construction, etc.)

2010-05-12 Thread Huacai Chen
resend by git send-email to avoid line-wrapping Signed-off-by: Huacai Chen --- Makefile.target |2 +- hw/mips_fulong2e.c | 420 ++ target-mips/translate_init.c | 35 3 files changed, 456 insertions(+), 1 deletions(-) cre

[Qemu-devel] [PATCH resend 2/6] MIPS: Initial support of vt82686b south bridge used by fulong mini pc

2010-05-12 Thread Huacai Chen
resend by git send-email to avoid line-wrapping Signed-off-by: Huacai Chen --- Makefile.target |2 +- hw/pc.h |7 + hw/pci_ids.h|8 + hw/vt82c686.c | 786 +++ 4 files changed, 802 insertions(+), 1 deletions(-) create

[Qemu-devel] Re: [RFC PATCH 1/2] close all the block drivers before the qemu process exits

2010-05-12 Thread MORITA Kazutaka
At Thu, 13 May 2010 05:16:35 +0900, MORITA Kazutaka wrote: > > On 2010/05/12 23:28, Avi Kivity wrote: > > On 05/12/2010 01:46 PM, MORITA Kazutaka wrote: > >> This patch calls the close handler of the block driver before the qemu > >> process exits. > >> > >> This is necessary because the sheepdog

[Qemu-devel] Migration failure from AMD to Intel

2010-05-12 Thread Tomoe Sugihara
Hi, Does anyone have any idea on a issue that I have regarding VM migration from AMD to Intel host? When the guest is migrated from AMD host and right after it starts on Intel host, qemu process crashes with log messages like below. Looks like, when the guest is loaded on its network, it is

[Qemu-devel] Re: ehci fixes

2010-05-12 Thread Jan Kiszka
Vincent Palatin wrote: > Dear developers, > > While using the EHCI patchset, I have found 2 minor issues. > So, I send in this email thread 2 fix proposals. Thanks, merged both and pushed an updated ehci branch. Jan signature.asc Description: OpenPGP digital signature

[Qemu-devel] [PATCH] target-i386: Avoid kvm related compiler error

2010-05-12 Thread Stefan Weil
Some versions of kvm.h (debian lenny) define KVM_CAP_VCPU_EVENTS without defining KVM_VCPUEVENT_VALID_NMI_PENDING or KVM_VCPUEVENT_VALID_SIPI_VECTOR. Without the patch, compilation fails: CCx86_64-softmmu/kvm.o /qemu/target-i386/kvm.c: In function 'kvm_put_vcpu_events': /qemu/target-i386/kv

[Qemu-devel] Re: [PATCH] target-sparc: Fix wrong printf argument

2010-05-12 Thread Blue Swirl
Thanks, applied. Another solution would have been to change the return value to uint32_t. On 5/12/10, Stefan Weil wrote: > cpu_get_ccr() returns a target_ulong, so a type cast is needed to avoid > wrong output on big endian hosts. We could also use TARGET_FMT_lx, > but that would print 8 inste

[Qemu-devel] Re: [PATCH v2] Fix -device help and documentation

2010-05-12 Thread Stefan Weil
Am 11.05.2010 14:02, schrieb Markus Armbruster: Commit 6616b2ad reverted commit 40ea285c. Looks like a mismerge to me. Signed-off-by: Markus Armbruster --- v2: rebased (v1 fell through the cracks apparently) qemu-options.hx | 15 ++- 1 files changed, 6 insertions(+), 9 deletio

Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Michael Tokarev
12.05.2010 22:11, Stefano Stabellini wrote: On Wed, 12 May 2010, Jamie Lokier wrote: Stefano Stabellini wrote: On Wed, 12 May 2010, Avi Kivity wrote: It's useful if you have a one-line horizontal pattern you want to propagate all over. It might be useful all right, but it is not entirely cle

Re: [Qemu-devel] [RFC] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2010-05-12 Thread Stefan Weil
Am 28.09.2009 18:50, schrieb Stefan Weil: Hello The patch following this mail adds a new code generator to qemu. It includes a README file with more details. Comments and contributions to complete it are welcome. Regards Stefan Weil Hello, The latest version of the TCG interpreter ("TCI") r

Re: [Qemu-devel] [PATCH 2/2] all vga: fail graicefully when vga ports are taken

2010-05-12 Thread Blue Swirl
On 5/11/10, Gerd Hoffmann wrote: > Try to pci hotplug a vga card, watch qemu die with hw_error(). > This patch fixes it. > > Signed-off-by: Gerd Hoffmann > --- > hw/cirrus_vga.c |3 +++ > hw/vga-pci.c|3 +++ > hw/vmware_vga.c |3 +++ > 3 files changed, 9 insertions(+), 0 d

[Qemu-devel] Re: [PPC] Can't boot iso images

2010-05-12 Thread Blue Swirl
On 5/11/10, Alexander Graf wrote: > Howdy, > > While trying to boot an openSUSE 11.1 iso I always get > "/packages/elf-loader is missing". Apparently that bug was fixed in a > more recent version of OpenBIOS. According to git log the version in > pc-bios is r721. > > Could we please pull in a

[Qemu-devel] Re: [PATCH] block/vdi: Fix image opening and creation for odd disk sizes

2010-05-12 Thread Kevin Wolf
Am 12.05.2010 20:25, schrieb Stefan Weil: > The fix is based on a patch from Kevin Wolf. Here his comment: > > "The number of blocks needs to be rounded up to cover all of the virtual hard > disk. Without this fix, we can't even open our own images if their size is not > a multiple of the block si

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-12 Thread Jan Kiszka
Alexander Graf wrote: > Jan Kiszka wrote: >> Alexander Graf wrote: >> >>> Jan Kiszka wrote: >>> Move the buffer flush from mux_chr_read to mux_chr_can_read. While the latter is called periodically, the former will only be invoked when new characters arrive at the back-end. Th

[Qemu-devel] [PATCH] target-sparc: Fix wrong printf argument

2010-05-12 Thread Stefan Weil
cpu_get_ccr() returns a target_ulong, so a type cast is needed to avoid wrong output on big endian hosts. We could also use TARGET_FMT_lx, but that would print 8 instead of 2 digits. Cc: Blue Swirl Signed-off-by: Stefan Weil --- target-sparc/helper.c |2 +- 1 files changed, 1 insertions(+),

Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Stefano Stabellini
On Wed, 12 May 2010, Jamie Lokier wrote: > Stefano Stabellini wrote: > > On Wed, 12 May 2010, Avi Kivity wrote: > > > It's useful if you have a one-line horizontal pattern you want to > > > propagate all over. > > > > It might be useful all right, but it is not entirely clear what the > > hardwa

[Qemu-devel] [PATCH] block/vdi: Fix image opening and creation for odd disk sizes

2010-05-12 Thread Stefan Weil
The fix is based on a patch from Kevin Wolf. Here his comment: "The number of blocks needs to be rounded up to cover all of the virtual hard disk. Without this fix, we can't even open our own images if their size is not a multiple of the block size." While Kevin's patch addressed vdi_create, my m

[Qemu-devel] [PATCH 2/3] sysemu: Export 'no_shutdown'

2010-05-12 Thread Luiz Capitulino
It's a global variable already, do_quit() will use it. Signed-off-by: Luiz Capitulino --- sysemu.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/sysemu.h b/sysemu.h index fcfccdf..58c9733 100644 --- a/sysemu.h +++ b/sysemu.h @@ -128,6 +128,7 @@ extern int max_cpus; ex

[Qemu-devel] [PATCH 1/3] target-sparc: Fix compilation with --enable-debug.

2010-05-12 Thread Richard Henderson
Return a target_ulong from compute_C_icc to match the width of the users. Signed-off-by: Richard Henderson --- target-sparc/helper.h|2 +- target-sparc/op_helper.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-sparc/helper.h b/target-sparc/helper.h inde

[Qemu-devel] [PATCH 3/3] target-sparc: Inline some generation of carry for ADDX/SUBX.

2010-05-12 Thread Richard Henderson
Computing carry is trivial for some inputs. By avoiding an external function call, we generate near-optimal code for the common cases of add+addx (double-word arithmetic) and cmp+addx (a setcc pattern). Signed-off-by: Richard Henderson --- target-sparc/helper.h|2 +- target-sparc/op_hel

[Qemu-devel] [PATCH 0/3] Fix ADDX compilation plus improvements, v2

2010-05-12 Thread Richard Henderson
Changes v1->v2: * Fix ADDX carry generation properly, i.e. use the previous ADD ICC carry computation for ADDX ICC and XCC. * Tidy PSR generators wrt CODING_STYLE, other minor improvements. * Set CC_OP properly in patch 3. r~ Richard Henderson (3): target-sparc: Fix compilation wit

[Qemu-devel] [PATCH 2/3] target-sparc: Simplify ICC generation.

2010-05-12 Thread Richard Henderson
Use int32 types instead of target_ulong when computing ICC. This simplifies the generated code for 32-bit host and 64-bit guest. Use the same simplified expressions for ICC as were already used for XCC in carry flag generation. Simplify the ADD carry generation to not consider a possible carry-in

[Qemu-devel] [PATCH 0/3]: Monitor: Better fix for 'quit' return

2010-05-12 Thread Luiz Capitulino
Right after when 0e8d2b55 was merged, Paolo suggested using qemu_system_shutdown_request() instead of adding yet another 'system request' operation. This series implements his suggestion, passes my tests :)

[Qemu-devel] [PATCH 3/3] Monitor: Return before exiting with 'quit'

2010-05-12 Thread Luiz Capitulino
This is a new version of the (now reverted) following commit: 0e8d2b5575938b8876a3c4bb66ee13c5d306fb6d The 'quit' Monitor command (implemented by do_quit()) calls exit() directly, this is problematic under QMP because QEMU exits before having a chance to send the ok response. Clients don't know

[Qemu-devel] [PATCH 1/3] Revert "Monitor: Return before exiting with 'quit'"

2010-05-12 Thread Luiz Capitulino
This reverts commit 0e8d2b5575938b8876a3c4bb66ee13c5d306fb6d. Next commits will do the same thing in a better way. Signed-off-by: Luiz Capitulino --- monitor.c |3 +-- sysemu.h |2 -- vl.c | 18 -- 3 files changed, 1 insertions(+), 22 deletions(-) diff --git a/m

Re: [Qemu-devel] [PATCH] [S390] Remove warning in tcg stub (tcg_out_reloc)

2010-05-12 Thread Aurelien Jarno
On Tue, May 11, 2010 at 09:50:34PM +0200, Alexander Graf wrote: > > Am 11.05.2010 um 19:26 schrieb Richard Henderson : > >> On 05/11/2010 09:47 AM, Stefan Weil wrote: >>> Won't you get another warning about unreachable code >>> because tcg_abort never returns? >> >> We don't enable that warning. >>

Re: [Qemu-devel] [PATCH 2/3] target-sparc: Simplify ICC generation; fix ADDX carry generation.

2010-05-12 Thread Richard Henderson
On 05/12/2010 08:18 AM, Artyom Tarasenko wrote: > It is last year, but > 3e6ba503400c34cbe0f9ad6e289921688bf303a3 > The page 108 of the SPARC Version 8 Architecture Manual describes > that addcc and addxcc shall compute carry flag the same way. > The page 110 claims the same about sub

Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Jamie Lokier
Stefano Stabellini wrote: > On Wed, 12 May 2010, Avi Kivity wrote: > > It's useful if you have a one-line horizontal pattern you want to > > propagate all over. > > It might be useful all right, but it is not entirely clear what the > hardware should do in this situation from the documentation w

[Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Avi Kivity
On 05/12/2010 07:55 PM, Stefano Stabellini wrote: 3CEh index 26h W(R/W): BLT Source Pitch (5426 +) bit 0-11 (5426-28) Number of bytes in a scanline at the source. 0-12 (5429 +) do if the source BLT is supposed to be the number of bytes in a scanline at th

[Qemu-devel] Re: [PATCH v2 0/2] Drop pci_add and pci_del from QMP

2010-05-12 Thread Luiz Capitulino
On Wed, 12 May 2010 10:52:59 +0200 Markus Armbruster wrote: > See PATCH 1/1 for rationale. > > v2: Cover pci_del, better commit message, rebased (no conflicts) > > Markus Armbruster (2): > Revert "PCI: Convert pci_device_hot_add() to QObject" > Revert "monitor: Convert do_pci_device_hot_rem

[Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Stefano Stabellini
On Wed, 12 May 2010, Avi Kivity wrote: > > I guess even a src blt pitch of 0 could be useful there, however in > > practice I think the only rop function that was written with this case in > > mind has: > > > > dstpitch -= bltwidth; > > srcpitch -= bltwidth; > > > > if (dstpitch< 0 || srcpitch< 0

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-12 Thread Markus Armbruster
Luiz Capitulino writes: > One of the most important missing feature in QMP today is its > supported commands documentation. > > The plan is to make it part of self-description support, however > self-description is a big task we have been postponing for a > long time now and still don't know when

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-12 Thread Avi Kivity
On 05/12/2010 07:14 PM, Cam Macdonell wrote: Why can't we complete initialization before exposing the card and BAR? Seems to be the simplest solution. Looking at it more closely, you're right, the fds for shared memory/eventfds are received in a fraction of a second, so that's why I ha

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-12 Thread Cam Macdonell
On Wed, May 12, 2010 at 9:49 AM, Avi Kivity wrote: > On 05/10/2010 07:48 PM, Cam Macdonell wrote: >> >> On Mon, May 10, 2010 at 10:40 AM, Avi Kivity  wrote: >> >>> >>> On 05/10/2010 06:41 PM, Cam Macdonell wrote: >>> > > What would happen to any data written to the BAR before the

[Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Avi Kivity
On 05/12/2010 06:57 PM, Stefano Stabellini wrote: On Wed, 12 May 2010, Avi Kivity wrote: I suggest to start using the display pitch (with the proper sign) instead of cirrus_blt_srcpitch in cirrus_do_copy at least when cirrus_blt_srcpitch doesn't have a proper value. Why switch from

Re: [Qemu-devel] Re: Webcam solution for QEMU

2010-05-12 Thread David Ahern
On 05/09/2010 08:28 PM, Natalia Portillo wrote: > Hello Arnon, > Hola Albert, > > Wouldn't be easier to implement a custom video capture device? > You can always emulate a simple one, like (to say) OV511 webcam, and feed > that emulated device with video taken from any V4L2/DirectShow/BDA suppo

[Qemu-devel] Re: [PATCH 1/6] MIPS: Initial support of bonito north bridge used by fulong mini pc

2010-05-12 Thread Stefan Weil
Am 12.05.2010 10:50, schrieb chen huacai: Signed-off-by: Huacai Chen --- Makefile.target |1 + default-configs/mips64el-softmmu.mak |1 + hw/bonito.c | 950 ++ hw/mips.h|3 +

[Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Stefano Stabellini
On Wed, 12 May 2010, Avi Kivity wrote: > > I suggest to start using the display pitch (with the proper sign) > > instead of cirrus_blt_srcpitch in cirrus_do_copy at least when > > cirrus_blt_srcpitch doesn't have a proper value. > > > > Why switch from one bug to the other? > > It's perfectly

Re: [Qemu-devel] [PATCH 3/3 v2] dmg: use qemu block API

2010-05-12 Thread Kevin Wolf
Am 12.05.2010 16:31, schrieb Christoph Hellwig: > Use bdrv_pwrite to access the backing device instead of pread, and > convert the driver to implementing the bdrv_open method which gives > it an already opened BlockDriverState for the underlying device. > > Dmg actually does an lseek to a negative

[Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-12 Thread Alexander Graf
Am 12.05.2010 um 17:36 schrieb Kevin Wolf : Am 12.05.2010 17:05, schrieb Alexander Graf: Kevin Wolf wrote: Am 10.05.2010 23:51, schrieb Alexander Graf: Usually the guest can tell the host to flush data to disk. In some cases we don't want to flush though, but try to keep everything in cac

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-12 Thread Avi Kivity
On 05/10/2010 07:48 PM, Cam Macdonell wrote: On Mon, May 10, 2010 at 10:40 AM, Avi Kivity wrote: On 05/10/2010 06:41 PM, Cam Macdonell wrote: What would happen to any data written to the BAR before the the handshake completed? I think it would disappear. But, the

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-12 Thread Avi Kivity
On 05/12/2010 06:32 PM, Cam Macdonell wrote: We can tunnel its migration data through qemu. Of course, gathering its dirty bitmap will be interesting. DSM may be the way to go here (we can even live migrate qemu through DSM: share the guest address space and immediately start running on the d

[Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-12 Thread Kevin Wolf
Am 12.05.2010 17:05, schrieb Alexander Graf: > Kevin Wolf wrote: >> Am 10.05.2010 23:51, schrieb Alexander Graf: >> >>> Usually the guest can tell the host to flush data to disk. In some cases we >>> don't want to flush though, but try to keep everything in cache. >>> >>> So let's add a new para

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-12 Thread Cam Macdonell
On Tue, May 11, 2010 at 12:13 PM, Avi Kivity wrote: > On 05/11/2010 08:05 PM, Anthony Liguori wrote: >> >> On 05/11/2010 11:39 AM, Cam Macdonell wrote: >>> >>> Most of the people I hear from who are using my patch are using a peer >>> model to share data between applications (simulations, JVMs, et

Re: [Qemu-devel] [PATCH 2/3] target-sparc: Simplify ICC generation; fix ADDX carry generation.

2010-05-12 Thread Artyom Tarasenko
2010/5/12 Richard Henderson : > On 05/11/2010 02:31 PM, Artyom Tarasenko wrote: >> Nack. It looks like you reverted carry generation to the previous >> (broken) behavior. > > Oh?  I suppose I should go back and look at the logs, but the way > it's written there sure seems to match 5.1.5.1 of the sp

[Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-12 Thread Alexander Graf
Kevin Wolf wrote: > Am 10.05.2010 23:51, schrieb Alexander Graf: > >> Usually the guest can tell the host to flush data to disk. In some cases we >> don't want to flush though, but try to keep everything in cache. >> >> So let's add a new parameter to -drive that allows us to set the flushing >>

Re: [Qemu-devel] [PATCH 2/3] target-sparc: Simplify ICC generation; fix ADDX carry generation.

2010-05-12 Thread Richard Henderson
On 05/11/2010 02:31 PM, Artyom Tarasenko wrote: > Nack. It looks like you reverted carry generation to the previous > (broken) behavior. Perhaps you could point out the change I'm reverting? I don't see any change to the actual computation of the flags since f0f26a06d51b7e7764f8951cdbf67ac9ad507

[Qemu-devel] Re: [PATCH] virtio-serial-bus: fix ports_map allocation on init

2010-05-12 Thread Amit Shah
On (Wed) May 12 2010 [17:50:02], Alon Levy wrote: > Fix for too small allocation to ports_map > > Signed-off-by: Alon Levy ACK Amit

Re: [Qemu-devel] [PATCH 2/3] target-sparc: Simplify ICC generation; fix ADDX carry generation.

2010-05-12 Thread Richard Henderson
On 05/11/2010 02:31 PM, Artyom Tarasenko wrote: > Nack. It looks like you reverted carry generation to the previous > (broken) behavior. Oh? I suppose I should go back and look at the logs, but the way it's written there sure seems to match 5.1.5.1 of the sparcv9 manual: You'll only get carry int

Re: [Qemu-devel] [PATCH v2] doc: Update monitor info subcommands

2010-05-12 Thread Markus Armbruster
Stefan Hajnoczi writes: > The "info blockstats" documentation was copy-pasted as "info block" > instead of "info blockstats". The documentation for "commands", "jit", > "numa", "qdm", and "roms" is missing. This patch resolves these issues > in qemu-monitor.hx. Looks good, thanks!

  1   2   >