On 04/09/2010 12:22 AM, Thomas Monjalon wrote:
From: Thomas Monjalon
Using GCC-4.2.4-1ubuntu4, there were 3 warnings.
The last two are correct, but what was the first error? If it was a
shadowed declaration as it seems to be, the solution is to
s/fprintf/fprintf_func/ throughout print_insn_
Aurelien Jarno schrieb:
> On Thu, Apr 08, 2010 at 03:38:52PM +0200, Stefan Weil wrote:
>
>> Register fp is a bad choice for compilations without
>> optimisation, because the compiler makes heavy use
>> of this register (so the resulting code crashes).
>>
>
> I don't fully understand why the
> {
> - fprintf_ftype fprintf = info->fprintf_func;
>void * stream = info->stream;
I'm pretty sure this is not the correct fix.
"Fix a warning" is not sufficient justification for any change. We need to
understand what was wrong with the old code, and why the new code is
> On Thu, Apr 08, 2010 at 03:38:52PM +0200, Stefan Weil wrote:
> > Register fp is a bad choice for compilations without
> > optimisation, because the compiler makes heavy use
> > of this register (so the resulting code crashes).
>
> I don't fully understand why the compiler makes use of this regis
> +static inline void tcg_out_bswap32(TCGContext *s, int cond, int rd, int rn)
> +#else
> +/* This code only uses one temporary register. There is probably
> + a faster way to do that with more temporary registers. */
You can do better even without a temporary:
eor r8, rn, rn, ror #
On Thu, Apr 08, 2010 at 09:32:41AM -0700, Richard Henderson wrote:
> On 04/08/2010 02:56 AM, Aurelien Jarno wrote:
> > I have applied the patch. I have some comments though, it would be nice
> > if you can address them with additional patches.
>
> Sure.
>
> >> +static void tcg_out_ori(TCGContext
On Thu, Apr 08, 2010 at 03:38:52PM +0200, Stefan Weil wrote:
> Register fp is a bad choice for compilations without
> optimisation, because the compiler makes heavy use
> of this register (so the resulting code crashes).
I don't fully understand why the compiler makes use of this register in
code
From: Thomas Monjalon
Using GCC-4.2.4-1ubuntu4, there were 3 warnings.
Signed-off-by: Thomas Monjalon
---
microblaze-dis.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/microblaze-dis.c b/microblaze-dis.c
index b26572f..698ea7b 100644
--- a/microblaze-dis.c
+++ b
Hi all,
A number of fixes have been accumulated in the stable-0.12 branch, and
I think it's time to release a new stable version. I would like to see
that happening for the end of next week (around the 18th of April).
If you want to see some patches included, please send a mail to the
mailing lis
On Fri, Mar 26, 2010 at 04:06:38PM +, Riku Voipio wrote:
> From: Riku Voipio
>
> Signed-Off-By: Riku Voipio
>
> ---
> sysemu.h |1 +
> vl.c |1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/sysemu.h b/sysemu.h
> index 525efd1..5b4ddd8 100644
> --- a/sys
On Fri, Mar 26, 2010 at 04:06:35PM +, Riku Voipio wrote:
> From: Riku Voipio
>
> Signed-Off-By: Riku Voipio
> Signed-Off-By: Juha Riihimäki
Thanks, applied.
> ---
> qemu-char.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> ind
On Sun, Mar 28, 2010 at 08:39:42PM +0200, Samuel Thibault wrote:
> Hello,
>
> This adds a destroy hook for the baum character device, to properly
> close the BrlAPI connection and free resources.
>
> Signed-off-by: Samuel Thibault
Thanks, applied.
> commit 447c41758cfda0022ea6e09aaf81137b2b27b
On Mon, Mar 29, 2010 at 03:16:58PM +0200, Lars Munch wrote:
> this fixes the smc91c111 emulation which has been broken for gumstix and
> mainstone and maybe others since the "MMIO callback interface changes"
> 8da3ff180974732fc4272cb4433fef85c1822961 where commited, see:
>
> http://thread.gmane.or
On Fri, Mar 26, 2010 at 04:06:24PM +, Riku Voipio wrote:
> From: Juha Riihimäki
>
> modified the arm disassembler to include the opcode binary representation
> along
> with the symbolic disassembly.
>
> Signed-Off-By: Riku Voipio
> Signed-Off-By: Juha Riihimäki
> ---
> arm-dis.c | 10 +
On 04/08/2010 09:32 AM, Richard Henderson wrote:
>>> +static void tcg_out_ori(TCGContext *s, int ret, int arg, tcg_target_ulong
>>> m)
>>> +{
>>> +if (m == 0) {
>>> +tcg_out_mov(s, ret, arg);
>>> +} else if (m == -1) {
>>> +tcg_out_movi(s, TCG_TYPE_I32, ret, -1);
>>
>> Thos
On Wed, Mar 31, 2010 at 11:22:51AM +0200, Thomas Monjalon wrote:
> From: Thomas Monjalon
>
> There was a pointer cast warning on Ubuntu since _FORTIFY_SOURCE has been
> reenabled.
>
> _FORTIFY_SOURCE had been disabled by 4a24470497360d8b77568b83008d0e9d6eb0787d
> and reenabled by 849583050d5f6f
On Thu, Apr 01, 2010 at 08:03:30PM +0200, Stefan Weil wrote:
> With argument checking for cpu_fprintf, gcc throws this warning:
>
> CCi386-softmmu/helper.o
> cc1: warnings being treated as errors
> /qemu/ar7/target-i386/helper.c: In function ‘cpu_x86_dump_seg_cache’:
> /qemu/ar7/target-i386/
On Thu, Apr 01, 2010 at 11:45:25PM +0200, Adam Lackorzynski wrote:
> Signed-off-by: Adam Lackorzynski
Thanks, applied.
> ---
> hw/debugcon.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/debugcon.c b/hw/debugcon.c
> index d549091..5ee6821 100644
> --- a/hw/
On Mon, Mar 29, 2010 at 09:16:52PM +0200, Stefan Weil wrote:
> The compiler should check the arguments for these functions.
>
> gcc can do this, but only if the function pointer's prototype
> includes the __attribute__ flag.
>
> As the necessary declaration is a bit lengthy, we use a new
> data t
Thanks, applied.
On Wed, Mar 31, 2010 at 04:54:11PM +0200, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> exec-all.h |4
> target-i386/translate.c |2 ++
> target-mips/translate.c |2 ++
> target-sh4/translate.c |2 ++
> target-sparc/translate.
On Tue, Apr 06, 2010 at 12:11:43PM +0200, Alexander Graf wrote:
> Commit b305b9d7d6990e492966ffb1fdf619482adeb7e2 made building of virtio-pci
> conditional and not enabled on S390x, because it collides with the S390 bus.
>
> Commit 087431d1d1bf4e785edfa89e8cd05fcdac558dc3 accidentially reverted th
On Thu, Apr 01, 2010 at 11:46:20PM +0200, Adam Lackorzynski wrote:
>
> Signed-off-by: Adam Lackorzynski
Thanks, applied.
> ---
> target-i386/op_helper.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
> index 222
On Thu, Apr 08, 2010 at 05:49:50PM -0300, Marcelo Tosatti wrote:
>
> So the userspace headers define KERNEL_STRICT_NAMES and there's no
> conflict on type definition for older kernels.
>
> igned-off-by: Marcelo Tosatti
Acked-by: Michael S. Tsirkin
> diff --git a/hw/vhost.c b/hw/vhost.c
> inde
So the userspace headers define KERNEL_STRICT_NAMES and there's no
conflict on type definition for older kernels.
igned-off-by: Marcelo Tosatti
diff --git a/hw/vhost.c b/hw/vhost.c
index ad2f98a..d37a66e 100644
--- a/hw/vhost.c
+++ b/hw/vhost.c
@@ -10,13 +10,13 @@
* the COPYING file in the to
Each device is represented by a QDict. The returned QObject is a QList
of all devices.
This commit slightly changes the monitor output when 'info network' is used.
Signed-off-by: Miguel Di Ciurcio Filho
---
monitor.c |3 +-
net.c | 133 ++
Signed-off-by: Miguel Di Ciurcio Filho
---
net/vde.c |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/net/vde.c b/net/vde.c
index 0b46fa6..f582878 100644
--- a/net/vde.c
+++ b/net/vde.c
@@ -31,6 +31,9 @@
#include "qemu-char.h"
#include "qemu-common.h"
#include "
Signed-off-by: Miguel Di Ciurcio Filho
---
net/tap-win32.c |9 ++---
net/tap.c | 18 +-
2 files changed, 19 insertions(+), 8 deletions(-)
diff --git a/net/tap-win32.c b/net/tap-win32.c
index 74348da..8e0ad2d 100644
--- a/net/tap-win32.c
+++ b/net/tap-win32.c
@@ -3
Signed-off-by: Miguel Di Ciurcio Filho
---
net/socket.c | 47 ++-
1 files changed, 34 insertions(+), 13 deletions(-)
diff --git a/net/socket.c b/net/socket.c
index 1c4e153..3521e21 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -28,6 +28,10 @@
#inc
Signed-off-by: Miguel Di Ciurcio Filho
---
net/slirp.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/net/slirp.c b/net/slirp.c
index b41c60a..4036b92 100644
--- a/net/slirp.c
+++ b/net/slirp.c
@@ -32,6 +32,8 @@
#include "monitor.h"
#include "sysemu.h"
#include
Signed-off-by: Miguel Di Ciurcio Filho
---
hw/xilinx_ethlite.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/xilinx_ethlite.c b/hw/xilinx_ethlite.c
index 37e33ec..345aea7 100644
--- a/hw/xilinx_ethlite.c
+++ b/hw/xilinx_ethlite.c
@@ -230,7 +230,7 @@ static int xilin
Signed-off-by: Miguel Di Ciurcio Filho
---
net/dump.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/net/dump.c b/net/dump.c
index 6db7ecf..dea7f7d 100644
--- a/net/dump.c
+++ b/net/dump.c
@@ -27,6 +27,9 @@
#include "sysemu.h"
#include "qemu-error.h"
#include "
Signed-off-by: Miguel Di Ciurcio Filho
---
hw/virtio-net.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index 970ba06..482a176 100644
--- a/hw/virtio-net.c
+++ b/hw/virtio-net.c
@@ -89,7 +89,7 @@ static void virtio_net_set_config(Vi
Signed-off-by: Miguel Di Ciurcio Filho
---
hw/usb-net.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/usb-net.c b/hw/usb-net.c
index ff0ca44..1583425 100644
--- a/hw/usb-net.c
+++ b/hw/usb-net.c
@@ -1454,7 +1454,7 @@ static int usb_net_initfn(USBDevice *dev)
qe
Signed-off-by: Miguel Di Ciurcio Filho
---
hw/stellaris_enet.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/stellaris_enet.c b/hw/stellaris_enet.c
index d1d755e..cf28670 100644
--- a/hw/stellaris_enet.c
+++ b/hw/stellaris_enet.c
@@ -416,7 +416,7 @@ static int stell
Signed-off-by: Miguel Di Ciurcio Filho
---
hw/smc91c111.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/smc91c111.c b/hw/smc91c111.c
index c1a88c9..767fc19 100644
--- a/hw/smc91c111.c
+++ b/hw/smc91c111.c
@@ -721,7 +721,7 @@ static int smc91c111_init1(SysBusDevice *
Signed-off-by: Miguel Di Ciurcio Filho
---
hw/rtl8139.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/rtl8139.c b/hw/rtl8139.c
index 72e2242..ee4fc5d 100644
--- a/hw/rtl8139.c
+++ b/hw/rtl8139.c
@@ -3382,7 +3382,7 @@ static int pci_rtl8139_init(PCIDevice *dev)
Signed-off-by: Miguel Di Ciurcio Filho
---
hw/lan9118.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/lan9118.c b/hw/lan9118.c
index 16d3330..07f9429 100644
--- a/hw/lan9118.c
+++ b/hw/lan9118.c
@@ -232,7 +232,7 @@ static void lan9118_update(lan9118_state *s)
s
Signed-off-by: Miguel Di Ciurcio Filho
---
hw/mipsnet.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/mipsnet.c b/hw/mipsnet.c
index a066f63..96bb588 100644
--- a/hw/mipsnet.c
+++ b/hw/mipsnet.c
@@ -280,7 +280,7 @@ void mipsnet_init (int base, qemu_irq irq, NICInfo
Signed-off-by: Miguel Di Ciurcio Filho
---
hw/mcf_fec.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/mcf_fec.c b/hw/mcf_fec.c
index 4e7fbed..1e592d2 100644
--- a/hw/mcf_fec.c
+++ b/hw/mcf_fec.c
@@ -476,5 +476,5 @@ void mcf_fec_init(NICInfo *nd, target_phys_addr_t b
Signed-off-by: Miguel Di Ciurcio Filho
---
hw/pcnet.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pcnet.c b/hw/pcnet.c
index 5e63eb5..7df39c4 100644
--- a/hw/pcnet.c
+++ b/hw/pcnet.c
@@ -1897,7 +1897,7 @@ int pcnet_common_init(DeviceState *dev, PCNetState *s,
Net
Signed-off-by: Miguel Di Ciurcio Filho
---
hw/ne2000-isa.c |2 +-
hw/ne2000.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/ne2000-isa.c b/hw/ne2000-isa.c
index 03a5a1f..d5403d9 100644
--- a/hw/ne2000-isa.c
+++ b/hw/ne2000-isa.c
@@ -84,7 +84,7 @@ static int
Signed-off-by: Miguel Di Ciurcio Filho
---
hw/eepro100.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/eepro100.c b/hw/eepro100.c
index 7db6fb5..329fe15 100644
--- a/hw/eepro100.c
+++ b/hw/eepro100.c
@@ -47,6 +47,8 @@
#include "pci.h"
#include "net.h"
#inclu
Signed-off-by: Miguel Di Ciurcio Filho
---
hw/e1000.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/e1000.c b/hw/e1000.c
index fd3059a..7cbff0d 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -1125,7 +1125,7 @@ static int pci_e1000_init(PCIDevice *pci_dev)
d->nic =
Signed-off-by: Miguel Di Ciurcio Filho
---
hw/dp8393x.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/dp8393x.c b/hw/dp8393x.c
index e65e4d1..ebb41a2 100644
--- a/hw/dp8393x.c
+++ b/hw/dp8393x.c
@@ -904,7 +904,7 @@ void dp83932_init(NICInfo *nd, target_phys_addr_t b
There is no standard format when formatting info_str, so it is difficult
to extract information and transmit it over QMP.
This patch changes info_str from a simple string to a QDict.
Patches that convert the devices to this new format will follow.
Signed-off-by: Miguel Di Ciurcio Filho
---
net
This is a helper function that converts a QDict to a QString, using the format:
key1=value1 SPACE key2=value2 SPACE key3=value3
Handy for debugging and other things.
Signed-off-by: Miguel Di Ciurcio Filho
---
qdict.c | 39 +++
qdict.h |3 +++
2 files c
The VLANClientState structure has the member info_str, a simple string that
is filled with information about NIC devices and used on monitor calls.
There is no coherent formatting of this string by all the NIC devices,
making it difficult to parse and represent this information over QMP.
Patch 0
On 04/07/2010 10:51 AM, Aurelien Jarno wrote:
> +#if defined(__ARM_ARCH_5T__) || \
> +defined(__ARM_ARCH_5TE__) || \
> +defined(__ARM_ARCH_5TEJ__) || \
> +defined(__ARM_ARCH_6__) || \
> +defined(__ARM_ARCH_7A__) || \
> +defined(__ARM_ARCH_7__)
> +# define USE_ARMV5_INSTRUCTIONS
On 04/08/2010 02:56 AM, Aurelien Jarno wrote:
> I have applied the patch. I have some comments though, it would be nice
> if you can address them with additional patches.
Sure.
>> +static void tcg_out_ori(TCGContext *s, int ret, int arg, tcg_target_ulong m)
>> +{
>> +if (m == 0) {
>> +
On Thu, Apr 8, 2010 at 5:02 PM, Mohammed Gamal wrote:
> On Thu, Apr 8, 2010 at 6:01 PM, Mohammed Gamal wrote:
>> 1- What does the community prefer to use and improve? CIFS, 9p, or
>> both? And which is better taken up for GSoC.
There have been recent patches for filesystem passthrough using 9P:
On Thu, Apr 8, 2010 at 6:01 PM, Mohammed Gamal wrote:
> Hi,
> Now that Cam is almost done with his ivshmem patches, I was thinking
> of another idea for GSoC which is improving the pass-though
> filesystems.
> I've got some questions on that:
>
> 1- What does the community prefer to use and improv
Hi,
Now that Cam is almost done with his ivshmem patches, I was thinking
of another idea for GSoC which is improving the pass-though
filesystems.
I've got some questions on that:
1- What does the community prefer to use and improve? CIFS, 9p, or
both? And which is better taken up for GSoC.
2- Wit
> Use a set of #define to define the allowed ARM instructions, depending
> on the __ARM_ARCH_*__ GCC defines.
>
> Signed-off-by: Aurelien Jarno
> ---
> tcg/arm/tcg-target.c | 27 ---
> 1 files changed, 24 insertions(+), 3 deletions(-)
>
> diff --git a/tcg/arm/tcg-targe
Register fp is a bad choice for compilations without
optimisation, because the compiler makes heavy use
of this register (so the resulting code crashes).
Register s0 was used for TCG_AREG1 in earlier releases,
but was no longer used and is now free for TCG_AREG0.
The resulting code works for comp
>1. DMAR tables must be loaded by command line ( -acpitable
> sig=DMAR,data=hw/DMAR.dat )
Why?
> +void cpu_physical_memory_rw_io(target_phys_addr_t addr, uint8_t *buf,
> + int len, int is_write, uint16_t devfn,
> + int* err);
This appear
On Fri, Mar 12, 2010 at 03:58:08PM +0100, Richard Henderson wrote:
Thanks, applied.
> ---
> cpu-exec.c | 38 +++---
> 1 files changed, 31 insertions(+), 7 deletions(-)
>
> diff --git a/cpu-exec.c b/cpu-exec.c
> index 372aeac..0f84857 100644
> --- a/cpu-exec.c
>
On Wed, Apr 07, 2010 at 04:46:33PM +0200, Richard Henderson wrote:
> Handle the output log part overlapping the input high parts.
> Also, improve sub2 to handle some constants the second input low part.
Thanks, applied.
> Signed-off-by: Richard Henderson
> ---
> tcg/hppa/tcg-target.c | 60 +++
On Wed, Apr 07, 2010 at 04:29:11PM -0700, Richard Henderson wrote:
> On 04/07/2010 04:56 AM, Aurelien Jarno wrote:
> > Sorry, I haven't find time to review it in details. Would also be nice
> > if someone can try it on an hppa machine, and ack it.
>
> I got an ack against v3 here:
>
> http://list
On Tue, Mar 23, 2010 at 04:39:51PM +0900, Yoshiaki Tamura wrote:
>
> Before replacing byte-based dirty bitmap with bit-based dirty bitmap,
> clearing direct accesses to the bitmap first seems to be good point to
> start with.
>
> This patch set is based on the following discussion.
>
> http://ww
On Thu, Apr 08, 2010 at 01:24:35AM +0200, Richard Henderson wrote:
> PA-RISC uses procedure descriptors. We'd need to emit a call to
> the millicode routine $$dyncall. However, this situation doesn't
> actually arise, since we always have the descriptor available at
> TCG code generation time.
T
On Mon, Mar 15, 2010 at 06:22:04PM +0100, Lars Munch wrote:
>
> This patch fixes few resource leaks in the iwmmxt disassemble.
Thanks, applied.
> Signed-off-by: Lars Munch
> ---
> target-arm/translate.c |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/target-arm/
Am 07.04.2010 22:30, schrieb Christoph Hellwig:
> We're running into various problems because the "raw" file access, which
> is used internally by the various image formats is entangled with the
> "raw" image format, which maps the VM view 1:1 to a file system.
>
> This patch renames the raw file
Am 07.04.2010 17:02, schrieb Stefan Hajnoczi:
> On Wed, Apr 7, 2010 at 12:57 PM, Christoph Hellwig wrote:
>> Various obscure image format drivers do not allow write access.
>> Instead of silently falling back to read-only access reject attempts
>> to open these images for write access.
>
> Does b
63 matches
Mail list logo
